Public report — GSYVideoPlayer, published 6 Aug 2026. Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version; ask the repo owner for the full report.
Watchdog 06-08-2026 @ 13:27 UTC Public
Code Health Audit

CarGuo/GSYVideoPlayer

35% Weak
CriticalWeakAdequateStrongExemplary
middle

Medium · 54,382 LoC · rebuild ~0.3 person-years · weakest lens: Security (10%)

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

19/21dimensions tool-verifieddeterministic · confidence 1.0 · 2 LLM-assisted, advisory
214findings with an exact file:lineof 225 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
21/93dimensions across the health lenses54382 LoC — wide & deep

Executive summary

Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.

CarGuo/GSYVideoPlayer carries serious gaps (35%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.

It is strongest in Architecture (99%) — the structure is clean and changes stay contained. Code Health (77%) is solid too.

The area that most needs attention is Security (10%) — exposure to security and compliance incidents is elevated. Readiness (47%) is the next concern — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade.

Leadership focus, highest impact first: 10 Secret finding(s) (Secrets (history)); 16 High finding(s) (Static Analysis (SAST)); SAST step to CI running what this repository's stack ships (Security & performance tooling).

For scale: Medium (~54,382 production lines); rebuilding it from scratch would take roughly ~0.3 person-years (~1 engineer). Approximate, ±~30%.

It builds on a genuinely strong Architecture foundation (99%); the priorities above are the highest-leverage way to bring the rest up to that level.

How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Security 10% · 47% weightReadiness 47% · 26% weightMaturity 56% · 14% weightCode Health 77% · 8% weightArchitecture 99% · 4% weight

Raise Security 10 → 70 (the Healthy floor) ⇒ headline 35 → ~57.

Code composition — where the lines go
Tests 100%
New since the last scan (1+)

1 finding(s) are new versus the previous scan (2026-08-01) — surfaced by this scheduled scan itself, no pull request required.

  • D35 · Change coupling: GSYRenderView.java ↔ GSYVideoGLViewSimpleRender.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/GSYRenderView.java

A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.

Rebuild cost & value ~ Modeled — €15,000–€78,000
Cost to rebuild€15,000–€78,000 (0.2–0.5 person-years (258–818 h), ~1 engineer)
Domain complexityStandard — harder problems cost more per line
Quality factor0.7× (at 35% quality) — the last 20% of quality is most of the work
Size & shapeMedium · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)

This codebase represents roughly ~0.3 person-years of build effort (about ~€47,000 to rebuild). Its weakest lens is Security at 10% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.0) — standard service × a 0.7× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Resolve the 10 Secret finding(s) in Secrets (history) — start with gradle.properties (5), build.gradle (3), DetailPlayer.java (2).
+14.4 pts · Medium effort · Secrets (history)
2
Resolve the 9 Medium finding(s) in Static Analysis (SAST) — start with AndroidManifest.xml (4), DetailDownloadExoPlayer.java, GSYDefaultHttpDataSource.java.
+4.7 pts · Low effort · Static Analysis (SAST)
3
Resolve the 16 High finding(s) in Static Analysis (SAST) — start with release.yml (7), ci.yml (6), publish-maven-central.yml (3).
+8.4 pts · Medium effort · Static Analysis (SAST)

Diagnosis — what's actually going on

Value concentrated against a weak lens · High · Value at risk
This is a Medium asset (~0.3 person-years to rebuild), and its weakest lens is Security at 10%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
Evidence: valuation: Medium, ~0.3 person-years rebuild (54,382 LoC) · weakest lens: Security 10%
→ Direct remediation budget at Security first — highest risk-reduction per euro on an asset this size.
The top fix pays for itself · High · Economics
The top-ranked fix costs roughly 3–10 engineer-days once. Not doing it costs about 3.6–23.7 engineer-days every year, paid as drag on the ~71,118 lines this team changes annually — a bill that arrives whether or not anyone books it. On those figures the fix breaks even in roughly 2–34 months and is free after that. Method, stated so this is not read as a quotation: debt from the ranked task's effort band; interest = annual changed lines (measured, annualised from the 90-day window) ÷ an ASSUMED 150–400 lines per engineer-day × the 2–5% drag implied by the code-quality signals; breaking point = debt ÷ annual interest. A modelled planning range built from measured inputs and one named assumption — not a quotation, a valuation, or a certified figure.
Evidence: D15 churn: 17,536 line(s) changed over a 90-day window ⇒ ~71,118/year · D1/D2/D4 code quality: averaging 7.4/10 ⇒ a 2–5% drag on each change · top-ranked remediation: Medium effort ⇒ about 3–10 engineer-day(s)
→ Do the top-ranked fix now if this code will still be yours in 34 months.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Resolve the 10 Secret finding(s) in Secrets (history) — start with gradle.properties (5), build.gradle (3), DetailPlayer.java (2). The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Resolve the 10 Secret finding(s) in Secrets (history) — start with gradle.properties (5), build.gradle (3), DetailPlayer.java (2).
A velocity tax on every change · Medium · Economics
The code-quality signals (complexity, duplication, cohesion) average 7.4/10, which acts as a tax on every change in the weaker areas: modifications there plausibly cost on the order of 2–5% more than in clean code, and the tax compounds as the codebase grows. (A modelled estimate, not a measured fact.)
Evidence: D1/D2/D4 code quality: averaging 7.4/10 across the code-quality signals actually measured
→ Pay it down where churn is highest — the hotspots — not everywhere; that's where the tax is actually paid.

Architecture — module dependency matrix

60 modules, 170 dependencies — 3 dependency cycles, shown as the red cell(s) above the diagonal. Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)

(global)…la.videocache.headers….gsyvideoplayer.model…u.gsyvideoplayer.cast…yvideoplayer.listener….gsyvideoplayer.model…yvideoplayer.subtitle…ikula.videocache.file…eocache.sourcestorage….render.view.listener…m.danikula.videocache….gsyvideoplayer.cache…gsyvideoplayer.playercom.shuyu.aliplay…ideoplayer.video.base…anmaku.ijk.media.exo2….gsyvideoplayer.video…syvideoplayer.builder…layer.compose.native_…eoplayer.compose.host….gsyvideoplayer.utils…player.simple.adapter…ideoplayer.switchplay….shuyu.gsyvideoplayer…deoplayer.render.view…le.gsyvideoplayer.exo…deoplayer.exosubtitle…gsyvideoplayer.simple….gsyvideoplayer.utils…layer.render.glrender…gsyvideoplayer.effect…gsyvideoplayer.render…ideoplayer.mediacodec…e.gsyvideoplayer.view….gsyvideoplayer.video…syvideoplayer.adapter…e.gsyvideoplayer.cast…gsyvideoplayer.holder…yvideoplayer.fragment…xample.gsyvideoplayer(global)1…la.videocache.headers2….gsyvideoplayer.model3…u.gsyvideoplayer.cast4…yvideoplayer.listener5….gsyvideoplayer.model6…yvideoplayer.subtitle7…ikula.videocache.file8…eocache.sourcestorage9….render.view.listener10…m.danikula.videocache11….gsyvideoplayer.cache12…gsyvideoplayer.player13com.shuyu.aliplay14…ideoplayer.video.base15…anmaku.ijk.media.exo216….gsyvideoplayer.video17…syvideoplayer.builder18…layer.compose.native_19…eoplayer.compose.host20….gsyvideoplayer.utils21…player.simple.adapter22…ideoplayer.switchplay23….shuyu.gsyvideoplayer24…deoplayer.render.view25…le.gsyvideoplayer.exo26…deoplayer.exosubtitle27…gsyvideoplayer.simple28….gsyvideoplayer.utils29…layer.render.glrender30…gsyvideoplayer.effect31…gsyvideoplayer.render32…ideoplayer.mediacodec33…e.gsyvideoplayer.view34….gsyvideoplayer.video35…syvideoplayer.adapter36…e.gsyvideoplayer.cast37…gsyvideoplayer.holder38…yvideoplayer.fragment39…xample.gsyvideoplayer4013113531125311265116111131437411113553212141222214322124977523124112332212321112313213412112223421121321233211323321127119172171261531222211752111119248112381+20 more modules (most-connected shown)

At a glance — Code Health · 77% · Strong

At a glance — Architecture · 99% · Exemplary

At a glance — Maturity · 56% · Adequate · gated by M2

At a glance — Readiness · 47% · Weak · gated by P3

At a glance — Security · 10% · Critical · gated by D28, D29, D36

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2021 — Injection29High / Critical
A02:2021 — Cryptographic Failures11High / Critical

Roadmap

Immediately resolve the ten secret exposures in the build and source files, followed by the sixteen high-severity static analysis findings in the CI configuration. Implement automated security scanning in the CI pipeline to prevent security regressions from reaching production. Finally, enforce a manual approval gate on release jobs to prevent accidental deployments, and begin documenting architectural decisions in a central location.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 10 Secret finding(s) in Secrets (history) — start with gradle.properties (5), build.gradle (3), DetailPlayer.java (2).+14.4 ptsMediumSecrets (history)
Resolve the 9 Medium finding(s) in Static Analysis (SAST) — start with AndroidManifest.xml (4), DetailDownloadExoPlayer.java, GSYDefaultHttpDataSource.java.+4.7 ptsLowStatic Analysis (SAST)
Resolve the 16 High finding(s) in Static Analysis (SAST) — start with release.yml (7), ci.yml (6), publish-maven-central.yml (3).+8.4 ptsMediumStatic Analysis (SAST)
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+7.2 ptsMediumSecurity & performance tooling
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.+7.0 ptsMediumDeployment & Rollback
Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing.+3.0 ptsLowSupply-chain Provenance & Signing
Resolve the 1 PR-triggered workflow without a permissions block finding(s) in Supply-chain Provenance & Signing.+3.0 ptsLowSupply-chain Provenance & Signing
Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing.+3.0 ptsLowSupply-chain Provenance & Signing

File quality

Per-file score 0–10 — a quality signature. Of 84 files carrying findings, judged against the Production bar: 1% slop · 57% mixed · 42% near-clean.

FileScoreBandWorst signal
app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java3.0SlopSecrets (history): Secret: generic-api-key
app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java4.3MixedStatic Analysis (SAST): Medium: weak-ssl-context
.github/workflows/release.yml4.4MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
.github/workflows/ci.yml4.5MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
gradle.properties4.6MixedSecrets (history): Secret: generic-api-key
build.gradle5.1MixedSecrets (history): Secret: github-pat
.github/workflows/publish-maven-central.yml5.1MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
app/src/main/AndroidManifest.xml6.1MixedStatic Analysis (SAST): Medium: exported_activity
gsyVideoPlayer-proxy_cache/src/main/java/com/danikula/videocache/HttpUrlSource.java6.4MixedStatic Analysis (SAST): Medium: weak-ssl-context
app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java6.4MixedStatic Analysis (SAST): Medium: use-of-md5
gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java7.0MixedCyclomatic Complexity: GSYVideoControlView.onTouch (cyclomatic 22)
gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java7.0MixedCyclomatic Complexity: StandardGSYVideoPlayer.onClickUiToggle (cyclomatic 22)
gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java7.0MixedCyclomatic Complexity: NeuQuant.map (cyclomatic 17)
app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java7.1MixedCognitive Complexity: 5.onPrepared (cognitive 16)
app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java7.1MixedCode Duplication: Duplicated block (27 lines × 2)
app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java7.1MixedCode Duplication: Duplicated block (14 lines × 2)
app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java7.1MixedCyclomatic Complexity: TvVideoPlayer.onTouch (cyclomatic 22)
app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java7.1MixedCode Duplication: Duplicated block (14 lines × 2)
gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java7.2MixedCyclomatic Complexity: 1.onOrientationChanged (cyclomatic 32)
gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java7.4MixedCyclomatic Complexity: GSYSampleADVideoPlayer.changeAdUIState (cyclomatic 23)

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 19 of 21 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 2 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.5 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 21 dimensions across the health lenses
D1D2D3D4D13D15D16D19D21D28D29D34D35D36M1M2M3M4P1P3P4

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 214 of 225 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
jscpdCode duplication✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.302✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.302✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 019fd741-8c47-75e3-b06b-e6031c632f37.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".

The LLM boundary

LLM-set scores this run (3): D19, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity7.2 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 7.2 / 10 · rule-coverage 100% · ceiling Prevented

19 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was MeasureHelper.doMeasure at 51. A further 3 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being MainActivity.onClick at 50 — they are counted neither in the figure above nor in this dimension's score.

MeasureHelper.doMeasure (cyclomatic 51)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/MeasureHelper.java:74
1.onOrientationChanged (cyclomatic 32)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:75
XmlContentHandler.characters (cyclomatic 27)app/src/main/java/com/example/gsyvideoplayer/utils/BiliDanmukuParser.java:155
NetworkUtils.getNetWorkType (cyclomatic 25)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/NetworkUtils.java:155
GSYSampleADVideoPlayer.changeAdUIState (cyclomatic 23)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:250

+ 14 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 MeasureHelper.doMeasure (cyclomatic 51) finding(s) in Cyclomatic Complexity — start with MeasureHelper.java. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 1.onOrientationChanged (cyclomatic 32) finding(s) in Cyclomatic Complexity — start with OrientationUtils.java. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 XmlContentHandler.characters (cyclomatic 27) finding(s) in Cyclomatic Complexity — start with BiliDanmukuParser.java. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.9 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 5.9 / 10 · rule-coverage 100% · ceiling Prevented

40 method(s) exceeded the cognitive complexity threshold of 15; the worst was MeasureHelper.doMeasure at 111.

MeasureHelper.doMeasure (cognitive 111)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/MeasureHelper.java:74
XmlContentHandler.characters (cognitive 76)app/src/main/java/com/example/gsyvideoplayer/utils/BiliDanmukuParser.java:155
StandardGSYVideoPlayer.onClickUiToggle (cognitive 75)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:389
1.onOrientationChanged (cognitive 72)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:75
NeuQuant.map (cognitive 58)gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:785

+ 35 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 MeasureHelper.doMeasure (cognitive 111) finding(s) in Cognitive Complexity — start with MeasureHelper.java. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 XmlContentHandler.characters (cognitive 76) finding(s) in Cognitive Complexity — start with BiliDanmukuParser.java. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 StandardGSYVideoPlayer.onClickUiToggle (cognitive 75) finding(s) in Cognitive Complexity — start with StandardGSYVideoPlayer.java. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.5 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

22 god class(es) detected.

TooManyMethods: GSYVideoControlView · ×16gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:54
FileTooLong: base/GSYVideoControlView.java · ×6gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:0

What to do

  1. Resolve the 16 TooManyMethods finding(s) in God Classes — start with GSYVideoControlView.java, GSYVideoView.java, IjkExo2MediaPlayer.java. — One of this dimension's main actionable groups (16 warning-level).
  2. Resolve the 6 FileTooLong finding(s) in God Classes — start with GSYVideoControlView.java, AnimatedGifEncoder.java, StandardGSYVideoPlayer.java. — One of this dimension's main actionable groups (6 warning-level).
  3. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.2 / 10Exemplary✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Verified

91 duplicated block group(s) detected.

Duplicated block (11 lines × 2) · ×11app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:44
Duplicated block (14 lines × 2) · ×7app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:283
Duplicated block (12 lines × 2) · ×7app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:207
Duplicated block (9 lines × 2) · ×7app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:221
Duplicated block (13 lines × 2) · ×6app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:90

+ 25 more group(s) — more in Appendix A; the complete list is findings.md.

✓ On the Gold path — maintain.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: app/src/main/java/com/example/gsyvideoplayer/MainActivity.java (3×50=150)

Hotspot: app/src/main/java/com/example/gsyvideoplayer/MainActivity.javaapp/src/main/java/com/example/gsyvideoplayer/MainActivity.java

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor6.4 / 10Adequate✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: DocumentedVerifiedPrevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Documented

70 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java.

Off-boarding risk: anonymized user #1

What to do

  1. Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality / 10Exemplary◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

This project's documentation is comprehensive and well-organized: three README files plus architecture/design markdowns cover the supported players (IJKPlayer, Media3/Exo2, MediaPlayer, AliPlayer), a HarmonyOS versioning guide with GitCode/Gitee sync options, a detailed 16kpatch dependency-installation flow for arm64/x86_64/armv7a, a curated registry of demo video URLs (MP4/BIPBOP, HLS/DASH/SRT), three simple-use examples (direct playback, list usage, detail page), and an exhaustive version-by-version update doc with unreleased/v13.0.x milestones plus regression fixes for each change. 文档质量极高,涵盖 README、架构/设计文件和依赖指南三类内容。README 包含清晰的通用字幕能力目标、基本用法、多字幕切换、样式偏移示例以及 Media3 内嵌字幕桥接说明;智能硬解降级调研与阶段结论完整且结构严谨,从组合判据到 Surface 花屏修复分点论述并附真机实测佐证;近期播放能力入口总览和提交覆盖表配合详尽的文档覆盖率说明;依赖指南采用双渠道发布方案对比清晰、迁移说明细致,并配测试脚本与新旧流程对比,形成完整的项目依赖配置体系。 The documentation is comprehensive and well-structured for a video-player project: three README files cover Maven Central publishing (with GPG key setup, GitHub Actions workflow, local act debugging), a dedicated Keep Last Frame demo with goals, usage, implementation notes, regression checklist, and a Java test playbook; the architecture doc explains the layered structure (player core, cache, manager, render) and how each layer can be customised. The project also has an English project-info document that is clipped mid-sentence but clearly outlines its current structure and future features.

The README ends with a link to 'UPDATE_VERSION.md' but no version-by-version table is shown in the visible portion.README.md

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency / 10Exemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.

Maturity: DocumentedVerifiedPrevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

10 finding(s): 0 critical, 10 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

Secret: github-pat · ×10build.gradle:40detected by gitleaks finding
Rotate the exposed credentials — git history can't be un-committed

What to do

  1. Resolve the 10 Secret finding(s) in Secrets (history) — start with gradle.properties (5), build.gradle (3), DetailPlayer.java (2). — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.4 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: DocumentedVerifiedPrevented · effective 0.4 / 10 · rule-coverage 100% · ceiling Documented

29 finding(s): 0 critical, 16 high, 9 medium, 4 low.

High: github-actions-mutable-action-tag · ×16.github/workflows/ci.yml:39detected by semgrep finding
Medium: exported_activity · ×9app/src/main/AndroidManifest.xml:41detected by semgrep finding
Low: insecure-hostname-verifier · ×4app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:592detected by semgrep finding

What to do

  1. Resolve the 16 High finding(s) in Static Analysis (SAST) — start with release.yml (7), ci.yml (6), publish-maven-central.yml (3). — One of this dimension's main actionable groups (16 issue-level).
  2. Resolve the 9 Medium finding(s) in Static Analysis (SAST) — start with AndroidManifest.xml (4), DetailDownloadExoPlayer.java, GSYDefaultHttpDataSource.java. — One of this dimension's main actionable groups (9 warning-level).
  3. Resolve the 4 Low finding(s) in Static Analysis (SAST) — start with GSYDefaultHttpDataSource.java (4). — One of this dimension's main actionable groups (4 recommendation-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness9.7 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: DocumentedVerifiedPrevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

7 of 224 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java.

Further orphaned files (smaller)

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: GSYRenderView.java↔GSYVideoGLViewSimpleRender.java 50%

Change coupling: GSYRenderView.java ↔ GSYVideoGLViewSimpleRender.javagsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/GSYRenderView.java

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: DocumentedVerifiedPrevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

Unpinned build actions
PR-triggered workflow without a permissions block
No build provenance
No SBOM

What to do

  1. Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 PR-triggered workflow without a permissions block finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

M1 · Documentation (README)6.7 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 14 of 14 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy6.0 / 10Adequate◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • README advertises Docker containerisation, but no Dockerfile/compose file exists
  • README advertises a Flutter app, but no Flutter/Dart project exists

What to do

  • Reconcile the README with reality: README advertises Docker containerisation, but no Dockerfile/compose file exists; README advertises a Flutter app, but no Flutter/Dart project exists.
P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Check the coverage dimensions first: if this repo has no test suite yet, that is the finding and this row follows from it. If a suite does exist, make the runner step explicit so the gate is unambiguous.

What to do

  • Run the test suite in CI via an explicit runner step (`./gradlew test` for the toolchain this pipeline already uses) and gate merges on it.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step.

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health77%StrongSolid.
Architecture99%ExemplaryStrongest area.
Maturity56%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness47%Weak — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security10%Critical — gated by D28, D29, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Not included — 72 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — no DI registrations detected
  • AX10 Code composition — not assessed — code composition is computed by ROLE over a document set that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — no singleton implementations detected
  • AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~339 lines of test source are present (.java) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included
  • D12 Dependency Hygiene — Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
  • D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (a Gradle version catalogue), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
  • D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D22 Internal API Consistency — No exposed public API
  • D23 Boundary Type-Coupling — Production source is present (.java, .kt, .py) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle version catalogue — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
  • D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D38 OSV Dependency Vulnerabilities — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
  • D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .java, .kt, .py, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • D9 Test Distribution — Test source is present (.java) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 48 value object(s); 1 domain event(s)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
  • GD1 Unfinished & placeholder code — no source files
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
  • P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
  • P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Issue — 26 finding(s)
D29 · Static Analysis (SAST) · High · ×16
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:39 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v3`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:40 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-java@<40-character SHA>`. This step references `actions/setup-java@v3`; resolve the SHA it points at today with `gh api repos/actions/setup-java/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:44 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: gradle/gradle-build-action@<40-character SHA>`. This step references `gradle/gradle-build-action@v2`; resolve the SHA it points at today with `gh api repos/gradle/gradle-build-action/commits/v2 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:52 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v3`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:53 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-java@<40-character SHA>`. This step references `actions/setup-java@v3`; resolve the SHA it points at today with `gh api repos/actions/setup-java/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/ci.yml:57 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: gradle/gradle-build-action@<40-character SHA>`. This step references `gradle/gradle-build-action@v2`; resolve the SHA it points at today with `gh api repos/gradle/gradle-build-action/commits/v2 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/publish-maven-central.yml:21 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v4`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v4 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/publish-maven-central.yml:24 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-java@<40-character SHA>`. This step references `actions/setup-java@v4`; resolve the SHA it points at today with `gh api repos/actions/setup-java/commits/v4 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/publish-maven-central.yml:30 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: gradle/gradle-build-action@<40-character SHA>`. This step references `gradle/gradle-build-action@v2`; resolve the SHA it points at today with `gh api repos/gradle/gradle-build-action/commits/v2 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:15 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v3`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:16 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-java@<40-character SHA>`. This step references `actions/setup-java@v3`; resolve the SHA it points at today with `gh api repos/actions/setup-java/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:21 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: gradle/gradle-build-action@<40-character SHA>`. This step references `gradle/gradle-build-action@v2`; resolve the SHA it points at today with `gh api repos/gradle/gradle-build-action/commits/v2 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:25 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: ncipollo/release-action@<40-character SHA>`. This step references `ncipollo/release-action@v1`; resolve the SHA it points at today with `gh api repos/ncipollo/release-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:39 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v4`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v4 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:40 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-java@<40-character SHA>`. This step references `actions/setup-java@v4`; resolve the SHA it points at today with `gh api repos/actions/setup-java/commits/v4 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/release.yml:44 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: gradle/gradle-build-action@<40-character SHA>`. This step references `gradle/gradle-build-action@v2`; resolve the SHA it points at today with `gh api repos/gradle/gradle-build-action/commits/v2 --jq .sha`.
D28 · Secrets (history) · Secret · ×10
  • Secret: github-pat build.gradle:40 — matched rule 'github-pat'
  • Secret: github-pat build.gradle:19 — matched rule 'github-pat'
  • Secret: github-pat build.gradle:19 — matched rule 'github-pat'
  • Secret: generic-api-key app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:452 — matched rule 'generic-api-key'
  • Secret: generic-api-key gradle.properties:19 — matched rule 'generic-api-key'
  • Secret: generic-api-key app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:243 — matched rule 'generic-api-key'
  • Secret: generic-api-key gradle.properties:19 — matched rule 'generic-api-key'
  • Secret: generic-api-key gradle.properties:19 — matched rule 'generic-api-key'
  • Secret: generic-api-key gradle.properties:19 — matched rule 'generic-api-key'
  • Secret: generic-api-key gradle.properties:19 — matched rule 'generic-api-key'
Warning — 185 finding(s)
D3 · God Classes · TooManyMethods · ×16
  • TooManyMethods: GSYVideoControlView gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:54 — TooManyMethods — 120 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYVideoView gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:44 — TooManyMethods — 91 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: IjkExo2MediaPlayer gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/IjkExo2MediaPlayer.java:58 — TooManyMethods — 89 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYVideoBaseManager gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoBaseManager.java:44 — TooManyMethods — 87 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYBaseVideoPlayer gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java:44 — TooManyMethods — 64 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: StandardGSYVideoPlayer gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:48 — TooManyMethods — 62 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ListVideoUtil gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:37 — TooManyMethods — 54 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYVideoOptionBuilder gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/builder/GSYVideoOptionBuilder.java:28 — TooManyMethods — 51 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYVideoGLView gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYVideoGLView.java:35 — TooManyMethods — 46 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYVideoHelperBuilder gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/GSYVideoHelper.java:581 — TooManyMethods — 44 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AliMediaPlayer gsyVideoPlayer-aliplay/src/main/java/com/shuyu/aliplay/AliMediaPlayer.java:36 — TooManyMethods — 43 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYBaseActivityDetail gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYBaseActivityDetail.java:20 — TooManyMethods — 41 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ExoSourceManager gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/ExoSourceManager.java:55 — TooManyMethods — 40 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: IjkPlayerManager gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/player/IjkPlayerManager.java:37 — TooManyMethods — 35 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYSurfaceView gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYSurfaceView.java:38 — TooManyMethods — 31 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GSYTextureView gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYTextureView.java:30 — TooManyMethods — 31 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×11
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:44 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:44-54 | app/src/main/java/com/example/gsyvideoplayer/simple/adapter/SimpleListVideoMode2Adapter.java:39-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:44` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:334 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:334-344 | app/src/main/java/com/example/gsyvideoplayer/SubtitleDetailPlayer.java:133-143 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:334` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:441 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:441-451 | app/src/main/java/com/example/gsyvideoplayer/SubtitleDetailPlayer.java:218-228 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:441` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/fragment/VideoFragment.java:65 — app/src/main/java/com/example/gsyvideoplayer/fragment/VideoFragment.java:65-75 | app/src/main/java/com/example/gsyvideoplayer/RecyclerViewActivity.java:62-72 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/fragment/VideoFragment.java:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:127 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:127-137 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:189-199 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:127` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:390 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:390-400 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:101-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:390` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:163 — app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:163-173 | app/src/main/java/com/example/gsyvideoplayer/video/SampleVideo.java:186-196 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:163` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:62 — app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:62-72 | app/src/main/java/com/example/gsyvideoplayer/RecyclerViewActivity.java:55-65 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:475 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:475-485 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:540-550 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:475` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:685 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:685-695 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:734-744 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:685` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:249 — gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:249-259 | gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:310-320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:249` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D29 · Static Analysis (SAST) · Medium · ×9
  • Medium: exported_activity app/src/main/AndroidManifest.xml:41 — The application exports an activity. Any application on the device can launch the exported activity which may compromise the integrity of your application or its data. Ensure that any exported activities do not have privileged access to your application's control plane.
  • Medium: exported_activity app/src/main/AndroidManifest.xml:46 — The application exports an activity. Any application on the device can launch the exported activity which may compromise the integrity of your application or its data. Ensure that any exported activities do not have privileged access to your application's control plane.
  • Medium: exported_activity app/src/main/AndroidManifest.xml:238 — The application exports an activity. Any application on the device can launch the exported activity which may compromise the integrity of your application or its data. Ensure that any exported activities do not have privileged access to your application's control plane.
  • Medium: exported_activity app/src/main/AndroidManifest.xml:274 — The application exports an activity. Any application on the device can launch the exported activity which may compromise the integrity of your application or its data. Ensure that any exported activities do not have privileged access to your application's control plane.
  • Medium: use-of-md5 app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java:333 — Detected MD5 hash algorithm which is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature. Use HMAC instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Medium: weak-ssl-context app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:618 — An insecure SSL context was detected. TLS versions 1.0, 1.1, and all SSL versions are considered weak encryption and are deprecated. Use SSLContext.getInstance("TLSv1.2") for the best security. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
  • Medium: unencrypted-socket gsyVideoPlayer-proxy_cache/src/main/java/com/danikula/videocache/HttpProxyCacheServer.java:75 — Detected use of a Java socket that is not encrypted. As a result, the traffic could be read by an attacker intercepting the network traffic. Use an SSLSocket created by 'SSLSocketFactory' or 'SSLServerSocketFactory' instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Medium: weak-ssl-context gsyVideoPlayer-proxy_cache/src/main/java/com/danikula/videocache/HttpUrlSource.java:176 — An insecure SSL context was detected. TLS versions 1.0, 1.1, and all SSL versions are considered weak encryption and are deprecated. Use SSLContext.getInstance("TLSv1.2") for the best security. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
  • Medium: use-of-md5 gsyVideoPlayer-proxy_cache/src/main/java/com/danikula/videocache/ProxyCacheUtils.java:78 — Detected MD5 hash algorithm which is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature. Use HMAC instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×7
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:283 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:283-296 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:657-670 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemNormalHolder.java:100 — app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemNormalHolder.java:100-113 | app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemPlayNormalHolder.java:93-106 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemNormalHolder.java:100` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:47 — app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:47-60 | app/src/main/java/com/example/gsyvideoplayer/ListVideo2Activity.java:59-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:285 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:285-298 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:323-336 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:285` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:70 — app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:70-84 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:545-558 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:70` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:147 — app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:147-160 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYSurfaceView.java:180-193 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:147` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:160 — app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:160-173 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity2.java:166-179 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×7
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:207 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:207-219 | app/src/main/java/com/example/gsyvideoplayer/DetailDownloadPlayer.java:75-86 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/mediacodec/MediaCodecTextureView.java:181 — app/src/main/java/com/example/gsyvideoplayer/mediacodec/MediaCodecTextureView.java:181-192 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYTextureView.java:188-199 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/mediacodec/MediaCodecTextureView.java:181` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode1.java:30 — app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode1.java:30-41 | app/src/main/java/com/example/gsyvideoplayer/switchplay/SwitchListVideoActivity.java:29-40 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode1.java:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/AudioDetailPlayer.java:60 — app/src/main/java/com/example/gsyvideoplayer/AudioDetailPlayer.java:60-71 | app/src/main/java/com/example/gsyvideoplayer/DetailNormalActivityPlayer.java:67-78 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/AudioDetailPlayer.java:60` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:45 — app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:45-56 | app/src/main/java/com/example/gsyvideoplayer/RecyclerViewActivity.java:41-53 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/AutoPlayRecyclerViewActivity.java:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:152 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:152-163 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:144-155 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java:140 — app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java:140-151 | app/src/main/java/com/example/gsyvideoplayer/DetailMoreTypeActivity.java:118-129 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×7
  • Duplicated block (9 lines × 2) app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:221 — app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:221-230 | app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender3.java:47-55 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:221` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:206 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:206-214 | app/src/main/java/com/example/gsyvideoplayer/video/FloatingVideo.java:165-173 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:206` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:228 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:228-236 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:675-683 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:228` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:343 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:343-351 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:367-375 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) app/src/main/java/com/example/gsyvideoplayer/ViewPager2Activity.java:42 — app/src/main/java/com/example/gsyvideoplayer/ViewPager2Activity.java:42-50 | app/src/main/java/com/example/gsyvideoplayer/ViewPagerDemoActivity.java:42-50 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/ViewPager2Activity.java:42` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:1081 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:1081-1089 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:1100-1108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:154 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:154-162 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/NormalGSYVideoPlayer.java:37-45 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:154` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D3 · God Classes · FileTooLong · ×6
  • FileTooLong: base/GSYVideoControlView.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:0 — FileTooLong — 903 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: GSYVideoControlView (54-1601). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: utils/AnimatedGifEncoder.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:0 — FileTooLong — 680 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: video/StandardGSYVideoPlayer.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:0 — FileTooLong — 636 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: StandardGSYVideoPlayer (48-1099). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: base/GSYBaseVideoPlayer.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java:0 — FileTooLong — 608 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: GSYBaseVideoPlayer (44-1118). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: gsyvideoplayer/GSYVideoBaseManager.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoBaseManager.java:0 — FileTooLong — 579 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: GSYVideoBaseManager (44-1014). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: base/GSYVideoView.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:0 — FileTooLong — 570 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: GSYVideoView (44-1223). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×6
  • Duplicated block (13 lines × 2) app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:90 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:90-106 | app/src/main/java/com/example/gsyvideoplayer/simple/adapter/SimpleListVideoMode2Adapter.java:87-99 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListVideoAdapter.java:90` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/DetailExoListPlayer.java:80 — app/src/main/java/com/example/gsyvideoplayer/exo/DetailExoListPlayer.java:80-92 | app/src/main/java/com/example/gsyvideoplayer/DetailListPlayer.java:70-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/DetailExoListPlayer.java:80` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemNormalHolder.java:47 — app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemNormalHolder.java:47-59 | app/src/main/java/com/example/gsyvideoplayer/holder/RecyclerItemPlayNormalHolder.java:45-57 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (13 lines × 2) app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:97 — app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:97-109 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:579-592 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:97` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:48 — app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:48-60 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity2.java:54-66 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:809 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:809-821 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:834-846 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:809` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×6
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:119 — app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:119-130 | app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender4.java:78-89 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/glrender/GSYVideoGLViewSimpleRender.java:299-310 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/effect/GSYVideoGLViewCustomRender.java:119` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:56 — app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:56-67 | app/src/main/java/com/example/gsyvideoplayer/video/MultiSampleVideo.java:109-120 | app/src/main/java/com/example/gsyvideoplayer/video/SampleCoverVideo.java:68-79 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:56 — app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:56-67 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:636-647 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:675-687 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:265 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:265-276 | app/src/main/java/com/example/gsyvideoplayer/DetailFilterActivity.java:708-719 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:257-268 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:265` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:48 — app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:48-59 | app/src/main/java/com/example/gsyvideoplayer/PlayPickActivity.java:48-59 | app/src/main/java/com/example/gsyvideoplayer/PlayTVActivity.java:48-59 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:188 — app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:188-199 | app/src/main/java/com/example/gsyvideoplayer/PlayEmptyControlActivity.java:113-124 | app/src/main/java/com/example/gsyvideoplayer/PlayPickActivity.java:172-183 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×5
  • Duplicated block (10 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2MediaPlayer.java:191 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2MediaPlayer.java:191-200 | app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayer.java:54-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2MediaPlayer.java:191` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:240 — app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:240-249 | app/src/main/java/com/example/gsyvideoplayer/video/SampleVideo.java:295-304 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:240` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:174 — app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:174-183 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/view/GSYSurfaceView.java:211-220 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/view/CustomTextureSurface.java:174` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:346 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:346-355 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:338-347 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:346` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:495 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:495-506 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:518-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×4
  • Duplicated block (6 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exo/ExoAdaptiveTrackActivity.java:122 — app/src/main/java/com/example/gsyvideoplayer/exo/ExoAdaptiveTrackActivity.java:122-127 | app/src/main/java/com/example/gsyvideoplayer/SmartMediaCodecFallbackActivity.java:71-76 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) app/src/main/java/com/example/gsyvideoplayer/simple/SimpleActivity.java:41 — app/src/main/java/com/example/gsyvideoplayer/simple/SimpleActivity.java:41-46 | app/src/main/java/com/example/gsyvideoplayer/MainActivity.java:103-108 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/simple/SimpleActivity.java:41` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) gsyVideoPlayer-aliplay/src/main/java/com/shuyu/aliplay/AliPlayerManager.java:45 — gsyVideoPlayer-aliplay/src/main/java/com/shuyu/aliplay/AliPlayerManager.java:45-50 | gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/Exo2PlayerManager.java:57-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-aliplay/src/main/java/com/shuyu/aliplay/AliPlayerManager.java:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYSrtSubtitleParser.java:11 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYSrtSubtitleParser.java:11-16 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYWebVttSubtitleParser.java:11-16 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×4
  • Duplicated block (5 lines × 2) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:186 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:186-190 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:240-244 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:223 — app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:223-227 | app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:230-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:223` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:725 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:725-729 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:769-773 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:901 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:901-905 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:910-914 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:901` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×3
  • Duplicated block (17 lines × 2) app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:271 — app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:271-287 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity2.java:286-302 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:271` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (17 lines × 2) app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:119 — app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:119-142 | app/src/main/java/com/example/gsyvideoplayer/PlayPickActivity.java:110-126 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/PlayActivity.java:119` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:160 — app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:160-176 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView3Activity.java:180-196 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×3
  • Duplicated block (10 lines × 3) app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:85 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:85-94 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:186-196 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity2.java:192-202 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:85` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 3) app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:105 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:105-115 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity.java:218-228 | app/src/main/java/com/example/gsyvideoplayer/ListADVideoActivity2.java:224-233 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListMultiNormalAdapter.java:105` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 3) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:265 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:265-274 | app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:58-67 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:638-647 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×3
  • Duplicated block (8 lines × 2) app/src/main/java/com/example/gsyvideoplayer/CastDemoActivity.java:82 — app/src/main/java/com/example/gsyvideoplayer/CastDemoActivity.java:82-89 | app/src/main/java/com/example/gsyvideoplayer/SubtitleDetailPlayer.java:70-77 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/CastDemoActivity.java:82` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYSrtSubtitleParser.java:50 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYSrtSubtitleParser.java:50-57 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYWebVttSubtitleParser.java:49-56 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYSrtSubtitleParser.java:50` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:104 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:104-111 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:234-241 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×3
  • Duplicated block (7 lines × 2) app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:87 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:87-95 | app/src/main/java/com/example/gsyvideoplayer/simple/adapter/SimpleListVideoModeAdapter.java:73-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:141 — app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:141-149 | app/src/main/java/com/example/gsyvideoplayer/simple/adapter/SimpleListVideoModeAdapter.java:84-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/adapter/ListNormalAdapter.java:141` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:62 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:62-68 | gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/Exo2PlayerManager.java:60-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:110 — app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:110-124 | app/src/main/java/com/example/gsyvideoplayer/video/SampleVideo.java:133-147 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/SampleControlVideo.java:110` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:59 — app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:59-73 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView3Activity.java:64-79 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:59` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×2
  • Duplicated block (11 lines × 3) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:290 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:290-300 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/player/SystemPlayerManager.java:286-296 | gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/Exo2PlayerManager.java:278-288 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayerManager.java:290` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 3) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:229 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:229-239 | app/src/main/java/com/example/gsyvideoplayer/DetailFilterActivity.java:396-406 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:221-231 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:229` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×2
  • Duplicated block (9 lines × 3) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:161 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:161-169 | app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleVideoView.java:54-62 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:348-356 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exo/GSYExo2PlayerView.java:161` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:95 — app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:95-103 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:502-510 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:523-531 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/KeepLastFrameVideo.java:95` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:41 — app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:41-48 | app/src/main/java/com/example/gsyvideoplayer/video/MultiSampleVideo.java:49-56 | app/src/main/java/com/example/gsyvideoplayer/video/SampleCoverVideo.java:53-60 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:41` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) app/src/main/java/com/example/gsyvideoplayer/ListVideo2Activity.java:74 — app/src/main/java/com/example/gsyvideoplayer/ListVideo2Activity.java:74-81 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:148-155 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView3Activity.java:168-175 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/ListVideo2Activity.java:74` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×2
  • Duplicated block (7 lines × 3) app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java:68 — app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java:68-74 | app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java:107-113 | app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java:127-133 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java:68` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:216 — app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:216-222 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/GSYVideoHelper.java:218-224 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/ListVideoUtil.java:262-268 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/utils/SmallVideoHelper.java:216` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D1 · Cyclomatic Complexity · MeasureHelper.doMeasure (cyclomatic 51) · ×1
  • MeasureHelper.doMeasure (cyclomatic 51) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/MeasureHelper.java:74 — MeasureHelper.doMeasure has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 1.onOrientationChanged (cyclomatic 32) · ×1
  • 1.onOrientationChanged (cyclomatic 32) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:75 — 1.onOrientationChanged has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · XmlContentHandler.characters (cyclomatic 27) · ×1
  • XmlContentHandler.characters (cyclomatic 27) app/src/main/java/com/example/gsyvideoplayer/utils/BiliDanmukuParser.java:155 — XmlContentHandler.characters has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NetworkUtils.getNetWorkType (cyclomatic 25) · ×1
  • NetworkUtils.getNetWorkType (cyclomatic 25) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/NetworkUtils.java:155 — NetworkUtils.getNetWorkType has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · GSYSampleADVideoPlayer.changeAdUIState (cyclomatic 23) · ×1
  • GSYSampleADVideoPlayer.changeAdUIState (cyclomatic 23) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:250 — GSYSampleADVideoPlayer.changeAdUIState has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TvVideoPlayer.onTouch (cyclomatic 22) · ×1
  • TvVideoPlayer.onTouch (cyclomatic 22) app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:60 — TvVideoPlayer.onTouch has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · GSYVideoControlView.onTouch (cyclomatic 22) · ×1
  • GSYVideoControlView.onTouch (cyclomatic 22) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:532 — GSYVideoControlView.onTouch has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · StandardGSYVideoPlayer.onClickUiToggle (cyclomatic 22) · ×1
  • StandardGSYVideoPlayer.onClickUiToggle (cyclomatic 22) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:389 — StandardGSYVideoPlayer.onClickUiToggle has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · IjkPlayerManager.initVideoPlayer (cyclomatic 20) · ×1
  • IjkPlayerManager.initVideoPlayer (cyclomatic 20) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/player/IjkPlayerManager.java:59 — IjkPlayerManager.initVideoPlayer has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · GSYWebVttSubtitleParser.parse (cyclomatic 19) · ×1
  • GSYWebVttSubtitleParser.parse (cyclomatic 19) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYWebVttSubtitleParser.java:10 — GSYWebVttSubtitleParser.parse has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYVideoControlView.setStateAndUi (cyclomatic 19) · ×1
  • GSYVideoControlView.setStateAndUi (cyclomatic 19) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:366 — GSYVideoControlView.setStateAndUi has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StandardGSYVideoPlayer.showProgressDialog (cyclomatic 19) · ×1
  • StandardGSYVideoPlayer.showProgressDialog (cyclomatic 19) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:183 — StandardGSYVideoPlayer.showProgressDialog has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYVideoControlView.clickStartIcon (cyclomatic 18) · ×1
  • GSYVideoControlView.clickStartIcon (cyclomatic 18) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:941 — GSYVideoControlView.clickStartIcon has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYVideoControlView.onClick (cyclomatic 18) · ×1
  • GSYVideoControlView.onClick (cyclomatic 18) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:454 — GSYVideoControlView.onClick has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYVideoControlView.touchSurfaceUp (cyclomatic 18) · ×1
  • GSYVideoControlView.touchSurfaceUp (cyclomatic 18) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:839 — GSYVideoControlView.touchSurfaceUp has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYDefaultHttpDataSource.open (cyclomatic 17) · ×1
  • GSYDefaultHttpDataSource.open (cyclomatic 17) app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:330 — GSYDefaultHttpDataSource.open has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NeuQuant.map (cyclomatic 17) · ×1
  • NeuQuant.map (cyclomatic 17) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:785 — NeuQuant.map has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GSYVideoControlView.setProgressAndTime (cyclomatic 16) · ×1
  • GSYVideoControlView.setProgressAndTime (cyclomatic 16) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:1032 — GSYVideoControlView.setProgressAndTime has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ENDownloadView.onDraw (cyclomatic 16) · ×1
  • ENDownloadView.onDraw (cyclomatic 16) gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:152 — ENDownloadView.onDraw has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D15 · Churn × Complexity Hotspots · Hotspot · ×1
  • Hotspot: app/src/main/java/com/example/gsyvideoplayer/MainActivity.java app/src/main/java/com/example/gsyvideoplayer/MainActivity.java — app/src/main/java/com/example/gsyvideoplayer/MainActivity.java changed 3 times in last 90 days, max complexity 50. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, behind tests written first.
D2 · Cognitive Complexity · MeasureHelper.doMeasure (cognitive 111) · ×1
  • MeasureHelper.doMeasure (cognitive 111) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/MeasureHelper.java:74 — MeasureHelper.doMeasure has cognitive complexity 111 (threshold 15). Drivers by points: if/else 88, boolean chains 15, match/switch 8 (nesting depth added 67). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XmlContentHandler.characters (cognitive 76) · ×1
  • XmlContentHandler.characters (cognitive 76) app/src/main/java/com/example/gsyvideoplayer/utils/BiliDanmukuParser.java:155 — XmlContentHandler.characters has cognitive complexity 76 (threshold 15). Drivers by points: if/else 60, loops 9, boolean chains 4, error handling 3 (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StandardGSYVideoPlayer.onClickUiToggle (cognitive 75) · ×1
  • StandardGSYVideoPlayer.onClickUiToggle (cognitive 75) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:389 — StandardGSYVideoPlayer.onClickUiToggle has cognitive complexity 75 (threshold 15). Drivers by points: if/else 73, boolean chains 2 (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.onOrientationChanged (cognitive 72) · ×1
  • 1.onOrientationChanged (cognitive 72) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:75 — 1.onOrientationChanged has cognitive complexity 72 (threshold 15). Drivers by points: if/else 62, boolean chains 10 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NeuQuant.map (cognitive 58) · ×1
  • NeuQuant.map (cognitive 58) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:785 — NeuQuant.map has cognitive complexity 58 (threshold 15). Drivers by points: if/else 56, boolean chains 1, loops 1 (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.onClick (cognitive 44) · ×1
  • GSYVideoControlView.onClick (cognitive 44) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:454 — GSYVideoControlView.onClick has cognitive complexity 44 (threshold 15). Drivers by points: if/else 41, boolean chains 3 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 3.onPrepared (cognitive 43) · ×1
  • 3.onPrepared (cognitive 43) app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:198 — 3.onPrepared has cognitive complexity 43 (threshold 15). Drivers by points: loops 33, if/else 10 (nesting depth added 31). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · GSYVideoControlView.clickStartIcon (cognitive 40) · ×1
  • GSYVideoControlView.clickStartIcon (cognitive 40) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:941 — GSYVideoControlView.clickStartIcon has cognitive complexity 40 (threshold 15). Drivers by points: if/else 29, error handling 7, boolean chains 4 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TvVideoPlayer.onTouch (cognitive 33) · ×1
  • TvVideoPlayer.onTouch (cognitive 33) app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:60 — TvVideoPlayer.onTouch has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14, loops 8, boolean chains 6, match/switch 5 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.onTouch (cognitive 33) · ×1
  • GSYVideoControlView.onTouch (cognitive 33) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:532 — GSYVideoControlView.onTouch has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14, loops 8, boolean chains 6, match/switch 5 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYWebVttSubtitleParser.parse (cognitive 30) · ×1
  • GSYWebVttSubtitleParser.parse (cognitive 30) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/subtitle/GSYWebVttSubtitleParser.java:10 — GSYWebVttSubtitleParser.parse has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18, boolean chains 6, loops 6 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYSampleADVideoPlayer.changeAdUIState (cognitive 29) · ×1
  • GSYSampleADVideoPlayer.changeAdUIState (cognitive 29) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYSampleADVideoPlayer.java:250 — GSYSampleADVideoPlayer.changeAdUIState has cognitive complexity 29 (threshold 15). Drivers by points: ternaries 14, boolean chains 8, if/else 7 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IjkPlayerManager.initVideoPlayer (cognitive 28) · ×1
  • IjkPlayerManager.initVideoPlayer (cognitive 28) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/player/IjkPlayerManager.java:59 — IjkPlayerManager.initVideoPlayer has cognitive complexity 28 (threshold 15). Drivers by points: if/else 14, boolean chains 7, error handling 6, ternaries 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · GSYVideoControlView.touchSurfaceUp (cognitive 28) · ×1
  • GSYVideoControlView.touchSurfaceUp (cognitive 28) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:839 — GSYVideoControlView.touchSurfaceUp has cognitive complexity 28 (threshold 15). Drivers by points: if/else 17, boolean chains 5, ternaries 4, error handling 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StandardGSYVideoPlayer.showProgressDialog (cognitive 28) · ×1
  • StandardGSYVideoPlayer.showProgressDialog (cognitive 28) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/StandardGSYVideoPlayer.java:183 — StandardGSYVideoPlayer.showProgressDialog has cognitive complexity 28 (threshold 15). Drivers by points: if/else 26, boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LZWEncoder.compress (cognitive 26) · ×1
  • LZWEncoder.compress (cognitive 26) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:1121 — LZWEncoder.compress has cognitive complexity 26 (threshold 15). Drivers by points: if/else 20, loops 6 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HttpUrlSource.openConnection (cognitive 25) · ×1
  • HttpUrlSource.openConnection (cognitive 25) gsyVideoPlayer-proxy_cache/src/main/java/com/danikula/videocache/HttpUrlSource.java:164 — HttpUrlSource.openConnection has cognitive complexity 25 (threshold 15). Drivers by points: if/else 19, error handling 3, boolean chains 2, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYDefaultHttpDataSource.open (cognitive 24) · ×1
  • GSYDefaultHttpDataSource.open (cognitive 24) app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:330 — GSYDefaultHttpDataSource.open has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10, ternaries 6, error handling 5, boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NeuQuant.learn (cognitive 23) · ×1
  • NeuQuant.learn (cognitive 23) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/AnimatedGifEncoder.java:707 — NeuQuant.learn has cognitive complexity 23 (threshold 15). Drivers by points: if/else 18, loops 5 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.touchSurfaceMoveFullLogic (cognitive 23) · ×1
  • GSYVideoControlView.touchSurfaceMoveFullLogic (cognitive 23) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:803 — GSYVideoControlView.touchSurfaceMoveFullLogic has cognitive complexity 23 (threshold 15). Drivers by points: if/else 19, boolean chains 2, ternaries 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 7.onClick (cognitive 22) · ×1
  • 7.onClick (cognitive 22) app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:461 — 7.onClick has cognitive complexity 22 (threshold 15). Drivers by points: if/else 19, loops 3 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoView.onInfo (cognitive 22) · ×1
  • GSYVideoView.onInfo (cognitive 22) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java:722 — GSYVideoView.onInfo has cognitive complexity 22 (threshold 15). Drivers by points: if/else 20, boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScrollCalculatorHelper.playVideo (cognitive 21) · ×1
  • ScrollCalculatorHelper.playVideo (cognitive 21) app/src/main/java/com/example/gsyvideoplayer/utils/ScrollCalculatorHelper.java:77 — ScrollCalculatorHelper.playVideo has cognitive complexity 21 (threshold 15). Drivers by points: if/else 17, boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.setStateAndUi (cognitive 21) · ×1
  • GSYVideoControlView.setStateAndUi (cognitive 21) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:366 — GSYVideoControlView.setStateAndUi has cognitive complexity 21 (threshold 15). Drivers by points: if/else 17, boolean chains 3, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ENDownloadView.onDraw (cognitive 21) · ×1
  • ENDownloadView.onDraw (cognitive 21) gsyVideoPlayer-java/src/main/java/moe/codeest/enviews/ENDownloadView.java:152 — ENDownloadView.onDraw has cognitive complexity 21 (threshold 15). Drivers by points: if/else 16, boolean chains 2, loops 2, match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SmartPickVideo.resolveStartChange (cognitive 19) · ×1
  • SmartPickVideo.resolveStartChange (cognitive 19) app/src/main/java/com/example/gsyvideoplayer/video/SmartPickVideo.java:326 — SmartPickVideo.resolveStartChange has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14, error handling 3, boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.touchSurfaceMove (cognitive 19) · ×1
  • GSYVideoControlView.touchSurfaceMove (cognitive 19) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:765 — GSYVideoControlView.touchSurfaceMove has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15, ternaries 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SampleCastControlVideo.isPlausibleIpv4 (cognitive 18) · ×1
  • SampleCastControlVideo.isPlausibleIpv4 (cognitive 18) app/src/main/java/com/example/gsyvideoplayer/video/SampleCastControlVideo.java:1048 — SampleCastControlVideo.isPlausibleIpv4 has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9, boolean chains 4, loops 3, error handling 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TvVideoHandler.handleMessage (cognitive 18) · ×1
  • TvVideoHandler.handleMessage (cognitive 18) app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java:264 — TvVideoHandler.handleMessage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 16, boolean chains 1, match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · GSYADVideoPlayer.changeAdUIState (cognitive 18) · ×1
  • GSYADVideoPlayer.changeAdUIState (cognitive 18) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/GSYADVideoPlayer.java:213 — GSYADVideoPlayer.changeAdUIState has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 12, if/else 6 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SampleCastControlVideo.enterRemoteMode (cognitive 17) · ×1
  • SampleCastControlVideo.enterRemoteMode (cognitive 17) app/src/main/java/com/example/gsyvideoplayer/video/SampleCastControlVideo.java:708 — SampleCastControlVideo.enterRemoteMode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8, ternaries 4, error handling 3, boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · SampleCastControlVideo.updateRemoteOverlayProgress (cognitive 17) · ×1
  • SampleCastControlVideo.updateRemoteOverlayProgress (cognitive 17) app/src/main/java/com/example/gsyvideoplayer/video/SampleCastControlVideo.java:794 — SampleCastControlVideo.updateRemoteOverlayProgress has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12, boolean chains 3, ternaries 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 8.onClick (cognitive 17) · ×1
  • 8.onClick (cognitive 17) app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java:492 — 8.onClick has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8, loops 8, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoGLViewSimpleRender.takeBitmap (cognitive 17) · ×1
  • GSYVideoGLViewSimpleRender.takeBitmap (cognitive 17) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/glrender/GSYVideoGLViewSimpleRender.java:262 — GSYVideoGLViewSimpleRender.takeBitmap has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6, ternaries 6, error handling 4, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NetworkUtils.getNetWorkType (cognitive 17) · ×1
  • NetworkUtils.getNetWorkType (cognitive 17) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/NetworkUtils.java:155 — NetworkUtils.getNetWorkType has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11, match/switch 4, boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoControlView.setProgressAndTime (cognitive 17) · ×1
  • GSYVideoControlView.setProgressAndTime (cognitive 17) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java:1032 — GSYVideoControlView.setProgressAndTime has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13, boolean chains 4 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · 5.onPrepared (cognitive 16) · ×1
  • 5.onPrepared (cognitive 16) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:222 — 5.onPrepared has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, loops 8 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GSYVideoPreviewVttParser.parseFrames (cognitive 16) · ×1
  • GSYVideoPreviewVttParser.parseFrames (cognitive 16) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/preview/GSYVideoPreviewVttParser.java:22 — GSYVideoPreviewVttParser.parseFrames has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11, loops 3, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OrientationUtils.resolveByClick (cognitive 16) · ×1
  • OrientationUtils.resolveByClick (cognitive 16) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/OrientationUtils.java:208 — OrientationUtils.resolveByClick has cognitive complexity 16 (threshold 15). Drivers by points: if/else 15, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IjkExo2MediaPlayer.onPlayWhenReadyChanged (cognitive 16) · ×1
  • IjkExo2MediaPlayer.onPlayWhenReadyChanged (cognitive 16) gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/IjkExo2MediaPlayer.java:539 — IjkExo2MediaPlayer.onPlayWhenReadyChanged has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 8, if/else 7, boolean chains 1 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: GSYRenderView.java ↔ GSYVideoGLViewSimpleRender.java gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/GSYRenderView.java — `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/GSYRenderView.java` and `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/glrender/GSYVideoGLViewSimpleRender.java` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking.
D36 · Supply-chain Provenance & Signing · Unpinned build actions · ×1
  • Unpinned build actions — CI references GitHub Actions by a floating ref (@main / @tag) rather than a pinned commit SHA, weakening build integrity. 16 floating ref(s) across 3 workflow file(s). Each floating ref is itemized at file:line by the SAST (D29) lens.
D36 · Supply-chain Provenance & Signing · PR-triggered workflow without a permissions block · ×1
  • PR-triggered workflow without a permissions block — 1 workflow(s) triggered by pull_request declare no `permissions:` block (ci.yml) and so run with the repository's default GITHUB_TOKEN scope, while 1 sibling workflow in the same repository is already scoped. Pull-request runs build the least-trusted code in the repository; give each of these workflows its own least-privilege block — `permissions: {contents: read}` at the top of the workflow, widened per job only where a job genuinely writes.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×1
  • Duplicated block (30 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/BarrelBlurEffect.java:60 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/BarrelBlurEffect.java:60-90 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/GaussianBlurEffect.java:61-90 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/BarrelBlurEffect.java:60` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:79 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:79-105 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:71-97 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:79` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/DocumentaryEffect.java:67 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/DocumentaryEffect.java:67-93 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/LamoishEffect.java:71-96 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/GrainEffect.java:56 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/GrainEffect.java:56-83 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/LamoishEffect.java:66-89 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1
  • Duplicated block (20 lines × 2) gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/DuotoneEffect.java:52 — gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/DuotoneEffect.java:52-73 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/TintEffect.java:45-64 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/render/effect/DuotoneEffect.java:52` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (17 lines × 4) · ×1
  • Duplicated block (17 lines × 4) app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:106 — app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:106-123 | app/src/main/java/com/example/gsyvideoplayer/ListVideo2Activity.java:127-144 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView2Activity.java:100-116 | app/src/main/java/com/example/gsyvideoplayer/RecyclerView3Activity.java:106-122 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/simple/SimpleListVideoActivityMode2.java:106` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:106 — app/src/main/java/com/example/gsyvideoplayer/video/AudioSampleVideo.java:106-122 | app/src/main/java/com/example/gsyvideoplayer/video/SampleCoverVideo.java:128-144 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java:422-438 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:178 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:178-193 | app/src/main/java/com/example/gsyvideoplayer/DetailDownloadPlayer.java:55-70 | app/src/main/java/com/example/gsyvideoplayer/DetailNormalActivityPlayer.java:45-60 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:126 — app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:126-140 | app/src/main/java/com/example/gsyvideoplayer/DetailFilterActivity.java:274-288 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:118-132 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:126` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 8) · ×1
  • Duplicated block (13 lines × 8) app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:284 — app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:284-296 | app/src/main/java/com/example/gsyvideoplayer/AudioDetailPlayer.java:112-125 | app/src/main/java/com/example/gsyvideoplayer/CastDemoActivity.java:96-108 | app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java:158-171 | app/src/main/java/com/example/gsyvideoplayer/DetailDownloadPlayer.java:129-142 | app/src/main/java/com/example/gsyvideoplayer/DetailNormalActivityPlayer.java:119-132 | app/src/main/java/com/example/gsyvideoplayer/ScrollingActivity.java:121-134 | app/src/main/java/com/example/gsyvideoplayer/SubtitleDetailPlayer.java:91-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 8 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 8 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleDetailPlayer.java:284` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 5) · ×1
  • Duplicated block (10 lines × 5) app/src/main/java/com/example/gsyvideoplayer/simple/SimpleDetailActivityMode1.java:89 — app/src/main/java/com/example/gsyvideoplayer/simple/SimpleDetailActivityMode1.java:89-98 | app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java:322-331 | app/src/main/java/com/example/gsyvideoplayer/DetailFilterActivity.java:435-444 | app/src/main/java/com/example/gsyvideoplayer/DetailTransparentActivity.java:314-323 | app/src/main/java/com/example/gsyvideoplayer/WebDetailActivity.java:158-167 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/example/gsyvideoplayer/simple/SimpleDetailActivityMode1.java:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 5) · ×1
  • Duplicated block (7 lines × 5) app/src/main/java/com/example/gsyvideoplayer/exo/GSYExoVideoManager.java:183 — app/src/main/java/com/example/gsyvideoplayer/exo/GSYExoVideoManager.java:183-189 | app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitleVideoManager.java:151-157 | app/src/main/java/com/example/gsyvideoplayer/video/manager/CustomManager.java:180-186 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoADManager.java:116-122 | gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoManager.java:144-150 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Recommendation — 12 finding(s)
D29 · Static Analysis (SAST) · Low · ×4
  • Low: insecure-hostname-verifier app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:592 — Insecure HostnameVerifier implementation detected. This will accept any SSL certificate with any hostname, which creates the possibility for man-in-the-middle attacks. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Low: insecure-trust-manager app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:601 — Detected empty trust manager implementations. This is dangerous because it accepts any certificate, enabling man-in-the-middle attacks. Consider using a KeyStore and TrustManagerFactory instead. See https://stackoverflow.com/questions/2642777/trusting-all-certificates-using-httpclient-over-https for more information. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Low: insecure-trust-manager app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:605 — Detected empty trust manager implementations. This is dangerous because it accepts any certificate, enabling man-in-the-middle attacks. Consider using a KeyStore and TrustManagerFactory instead. See https://stackoverflow.com/questions/2642777/trusting-all-certificates-using-httpclient-over-https for more information. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Low: insecure-hostname-verifier app/src/main/java/com/example/gsyvideoplayer/exosource/GSYDefaultHttpDataSource.java:623 — Insecure HostnameVerifier implementation detected. This will accept any SSL certificate with any hostname, which creates the possibility for man-in-the-middle attacks. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
D11 · Test Reliability · Test reliability not included · ×1
  • Test reliability not included — Test source is present (.java) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 70 significant file(s) lose their only recent owner: gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoControlView.java, gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java, gsyVideoPlayer-compose/src/main/java/com/shuyu/gsyvideoplayer/compose/native_/GSYPlayerController.kt, app/src/main/java/com/example/gsyvideoplayer/DetailPlayer.java, gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoBaseManager.java, app/src/main/java/com/example/gsyvideoplayer/DetailFilterActivity.java, gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/ExoSourceManager.java, app/src/main/java/com/example/gsyvideoplayer/video/SmartPickVideo.java (+62 more). Pair on, review, or document these before any departure.
D19 · Documentation Quality · The README ends with a link to 'UPDATE_VERSION.md' but no version-by-version table is shown in the visible portion. · ×1
  • The README ends with a link to 'UPDATE_VERSION.md' but no version-by-version table is shown in the visible portion. README.md — Since UPDATE_VERSION_EN.md is clipped, do not flag it as missing; only add new content.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • Rotate the exposed credentials — git history can't be un-committed — Some of these secrets are in git HISTORY: deleting the file does not remove them (the commit persists on every clone, fork and backup). The remediation is to ROTATE each historically-exposed credential and treat it as compromised — not to delete the file. Rewriting history is disruptive and unreliable across existing forks. (Working-tree-only secrets — no commit — can instead be removed from the file and moved to a secret store.) These 10 location(s) do not all need the same action: 2 sit inside a test/fixture/sample tree and 8 do not. Rotate the ones outside those trees as stated above. For the fixture ones there may be no live credential to revoke — confirm each value was never reused outside the tests (a fixture key shared with a staging or demo environment IS a live credential and must be rotated), then generate that material at test time instead of committing it, and record the deliberate exposure where a reader of the file will see it.
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 7 of 224 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 100 lines or more, excluding tests, vendored, generated and example/demo trees, largest first). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — largest first: app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java, gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/utils/GSYAudioFocusManager.java, app/src/main/java/com/example/gsyvideoplayer/PlayTVActivity.java (and 4 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · No build provenance · ×1
  • No build provenance — No SLSA provenance generation or build attestation found in CI — nothing binds a released artifact to the build that produced it, so a consumer cannot tell your artifact from a substituted one. On GitHub Actions, `actions/attest-build-provenance` (or slsa-github-generator) emits one from the job's own OIDC identity; elsewhere, run `cosign attest` over the released artifact from the release pipeline and publish the attestation beside it.
D36 · Supply-chain Provenance & Signing · No SBOM · ×1
  • No SBOM — No SBOM generation or committed SBOM found — produce one with what your ecosystem ships (the `cyclonedx-gradle-plugin` on the build, `syft` (or `anchore/sbom-action` in CI) over the source tree or released image). Publish it as a release asset (`*.spdx.json` / `*.cdx.json`) so consumers can see what they are installing.
D8 · Code Coverage · Coverage not included · ×1
  • Coverage not included — suite not readable by the collector — Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored.
Info — 2 finding(s)
D12 · Dependency Hygiene · Dependency hygiene not measured · ×1
  • Dependency hygiene not measured — dependency manifest found but not parsed for hygiene — This repository's dependency manifest (a Gradle version catalogue) was found, but this pass cannot parse it for hygiene, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D38 wherever the manifest is OSV-readable.
D22 · Internal API Consistency · No exposed public API · ×1
  • No exposed public API — No intentionally-exposed types (IsPackable or .Contracts) to evaluate.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaksgitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source .10artifacts/raw/gitleaks-history.json
D29 · Static Analysis (SAST)semgrepsemgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --json --quiet --timeout 0 --metrics off .29artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (no readable dependency manifest)none (no readable dependency manifest): not present in this environment0
D31 · IaC & Container Securitytrivytrivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.0
D32 · Data Compliance (PII/GDPR)semgrepsemgrep: not applicable — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.0
D33 · JS/npm Dependency Vulnerabilitiestrivytrivy: not applicable — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.0
D37 · Vulnerability-disclosure Policydisclosuredisclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0
D38 · OSV Dependency Vulnerabilitiesosv-scannerosv-scanner: not applicable — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.0
D40 · Network Egress Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0
D41 · Kernel & Syscall Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0
D42 · Runtime Threat Enforcementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0

Run 019fd741-8c47-75e3-b06b-e6031c632f37 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md