Executive summary
Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.
Krutonium/OpenRCT2Launcher carries serious gaps (45%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.
It is strongest in Architecture (89%) — the structure is clean and changes stay contained. Security (80%) is solid too.
The area that most needs attention is Readiness (34%) — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade. Maturity (43%) is the next concern — onboarding is slow — key decisions and the architecture aren't written down, so contributors have to reverse-engineer the intent.
Leadership focus, highest impact first: ILogger (or Serilog) and log at meaningful points across… (Observability); 1 Leaked secret finding(s) (Secret Scanning); Keep a changelog (e.g. Keep-a-Changelog) recording what shipped… (Release Hygiene).
For scale: Small (~2,508 production lines); rebuilding it from scratch would take roughly ~0.1 person-years (~1 engineer). Approximate, ±~30%.
It builds on a genuinely strong Architecture foundation (89%); the priorities above are the highest-leverage way to bring the rest up to that level.
Raise Readiness 34 → 70 (the Healthy floor) ⇒ headline 45 → ~55.
New since the last scan (1+)
- D8 · Coverage not measured — analyzer environment
Rebuild cost & value ~ Modeled — €1,200–€6,300
| Cost to rebuild | €1,200–€6,300 |
| Domain complexity | Standard |
| Quality factor | 0.7× (at 45% quality) |
| Size & shape | Small · 52% boilerplate · 15% straight-line · 33% branching logic |
This codebase represents roughly ~0.1 person-years of build effort (about ~€3,800 to rebuild). Its weakest lens is Readiness at 34% — the part of that asset most exposed by the findings below.
Top priorities
Diagnosis — what's actually going on
Architecture — module dependency graph
At a glance — Code Health
At a glance — Architecture
At a glance — Maturity
At a glance — Readiness
At a glance — Security
Security & Compliance — OWASP Top-10 mapping
| OWASP category | Findings | Severity |
|---|---|---|
| A02:2021 — Cryptographic Failures | 5 | High / Critical |
Roadmap
First, implement structured logging using ILogger or Serilog across all projects and enable health checks to improve observability. Next, immediately resolve the leaked secret in App.config and remove any orphaned files to secure the codebase. Finally, establish a changelog for every release and begin documenting significant architectural decisions to ensure long-term knowledge freshness.
| Do this | Helps | Effort | Dimension |
|---|---|---|---|
| Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with App.config. | +11.4 pts | Low | Secret Scanning |
| Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. | +7.7 pts | Low | Knowledge Freshness |
| Resolve the 1 No ADRs found finding(s) in ADR Quality. | +6.3 pts | Low | ADR Quality |
| Adopt ILogger (or Serilog) and log at meaningful points across the projects. | +12.3 pts | Medium | Observability |
| Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release. | +11.4 pts | Medium | Release Hygiene |
| Start an ADR log (docs/adr/) recording significant decisions and their rationale. | +8.0 pts | Medium | Architecture documentation |
| Add a build/run (quick start) section to the root README — the first thing a newcomer needs. | +7.0 pts | Medium | Documentation (README) |
| Run the test suite in CI via an explicit runner step for your stack, and gate merges on it. | +5.9 pts | Medium | CI/CD gates |
File quality
| File | Score | Band | Worst signal |
|---|---|---|---|
| Launcher/Launcher/Launcher.vb | 0.6 | Slop | Secrets (history): Secret: generic-api-key |
| Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb | 2.2 | Slop | Explicit Debt: EmptyCatchBlock |
| Launcher/LauncherWFP/App.config | 4.4 | Mixed | Secret Scanning: Leaked secret: high-entropy-secret |
| Launcher/ReparsePointLibrary/Utils/IniConfiguration.cs | 5.0 | Mixed | Explicit Debt: EmptyCatchBlock |
| Launcher/ORCT2ModPacker/ORCT2ModPacker/Class1.vb | 5.4 | Mixed | Explicit Debt: EmptyCatchBlock |
| Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetLogin.vb | 5.4 | Mixed | Secrets (history): Secret: generic-api-key |
| Launcher/Launcher/Forms/Extras.vb | 5.5 | Mixed | Explicit Debt: EmptyCatchBlock |
| Launcher/LauncherWFP/Management/RctLocator.cs | 6.7 | Mixed | Explicit Debt: TodoComment |
| Launcher/Launcher/GameConfig.vb | 8.5 | Near-clean | Cyclomatic Complexity: GameConfigValues.New.ctor (cyclomatic 26) |
| Launcher/ReparsePointLibrary/Utils/CommandLineArgs.cs | 8.5 | Near-clean | Cognitive Complexity: CommandLineArgs.CommandLineArgs.ctor (cognitive 29) |
| Launcher/ReparsePointLibrary/Utils/ReparsePoint.cs | 8.5 | Near-clean | Cognitive Complexity: ReparsePoint.GetTarget (cognitive 16) |
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 38 of 40 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 2 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.5 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
What we checked — 40 dimensions across the health lenses
- Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 35 of 49 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line.
- Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
- Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
Tools & methods
| Method | Backs | Version | Evaluator |
|---|---|---|---|
| Roslyn static analysis | Complexity, cohesion, coupling, dead code, API surface, layering | 5.3.0 | ✓ deterministic |
| Native secret scanner | Hardcoded secrets / credentials | 1.0.0 | ✓ deterministic |
| jscpd | Code duplication | — | ✓ deterministic |
| Coverage (coverlet / dotnet-coverage) | Line & branch coverage | 10.0.302 | ✓ deterministic |
| NuGet / dotnet | Outdated, vulnerable & deprecated dependencies | 10.0.302 | ✓ deterministic |
| git / LibGit2Sharp | Churn hotspots, knowledge concentration, history | 2.43.0 · 0.31.0 | ✓ deterministic |
| gitleaks · semgrep · trivy · checkov | Secrets in history, SAST, CVEs, IaC & container, PII / GDPR | 1.86.0 · 0.69.3 | ✓ deterministic |
| LLM (sampled · advisory) | Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement | Local LLM | ◐ LLM · sampled · advisory |
Run transparency — what happened this run
- D24 Comment Value — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
- D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
- D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
- D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
- D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
- D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
- D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
- D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
- D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
- D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
- D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
- D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
- D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
- D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
- D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
- D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
- D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
- D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
- D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
- D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
- D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
- D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
- AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
- M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
- P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
Dimensions
D1 · Cyclomatic Complexity
3 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was GameConfigValues.New.ctor at 26.
D2 · Cognitive Complexity
9 method(s) exceeded the cognitive complexity threshold of 15; the worst was UnPackMod.UnPackMod at 37.
What to do
- Resolve the 1 UnPackMod.UnPackMod (cognitive 37) finding(s) in Cognitive Complexity — start with Class1.vb. — One of this dimension's main actionable groups (1 warning-level).
- Resolve the 1 OpenRCTdotNetWebActions.UploadSaves (cognitive 29) finding(s) in Cognitive Complexity — start with OpenRCTdotNetWebActions.vb. — One of this dimension's main actionable groups (1 warning-level).
- Resolve the 1 CommandLineArgs.CommandLineArgs.ctor (cognitive 29) finding(s) in Cognitive Complexity — start with CommandLineArgs.cs. — One of this dimension's main actionable groups (1 warning-level).
- Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
D3 · God Classes
0 god class(es) detected.
D4 · Code Duplication
0 duplicated block group(s) detected.
D5 · Coupling
5 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).
What to do
- Resolve the 2 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (2 warning-level).
- Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
D6 · Cohesion (LCOM4)
1 of 10 classes have LCOM4 above 3.
What to do
- Resolve the 1 Low cohesion finding(s) in Cohesion (LCOM4) — start with Launcher.vb. — One of this dimension's main actionable groups (1 warning-level).
- Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
D9 · Test Distribution
4 test methods: 4 unit, 0 integration, 0 BDD, 0 e2e.
D10 · Test Quality
0 skipped, 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 4 tests.
D12 · Dependency Hygiene
0 outdated, 0 vulnerable, 0 deprecated packages.
D13 · Secret Scanning
1 secret(s) detected.
What to do
- Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with App.config. — One of this dimension's main actionable groups (1 issue-level).
- Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
D15 · Churn × Complexity Hotspots
No churn × complexity hotspots in the window.
D17 · Explicit Debt
14 deducted debt markers + 0 dead symbols across 4381 LoC (1.5/KLoC) → score 7.0.
What to do
- Resolve the 9 EmptyCatchBlock finding(s) in Explicit Debt — start with Extras.vb (4), Launcher.vb (2), OpenRCTdotNetWebActions.vb. — One of this dimension's main actionable groups (9 issue-level).
- Resolve the 5 TodoComment finding(s) in Explicit Debt — start with OpenRCTdotNetWebActions.vb (3), OpenRCTdotNetLogin.vb, RctLocator.cs. — One of this dimension's main actionable groups (5 warning-level).
- Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
D18 · Solution Shape
5 projects, 39 source files, 4477 hand-written lines of code (4381 production / 96 test), plus 4915 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 3 inter-project edges (build failed).
D19 · Documentation Quality
The single README is a retired launcher description with no architecture or usage documentation. It states the project has been retired and links to OpenRCT2.org, Gitter chat, AppVeyor CI, and an update list that promises features such as automatic updates, CoasterCloud syncing, mod installation, and theme music copying but never explains how to install it or what the actual launcher does (itself). The credits section lists contributors who have contributed code rather than documentation. There is no architecture document for ORCT2ModPacker, no XML docs, and no per-project coverage.
What to do
- Improve Documentation Quality — currently 3.0/10. — The single README is a retired launcher description with no architecture or usage documentation. It states the project has been retired and links to OpenRCT2.org, Gitter chat, AppVeyor CI, and an update list that promises features such as automatic updates, CoasterCloud syncing, mod installation, and theme music copying but never explains how to install it or what the actual launcher does (itself). The credits section lists contributors who have contributed code rather than documentation. There is no architecture document for ORCT2ModPacker, no XML docs, and no per-project coverage.
D20 · ADR Quality
No architecture decision records were found.
What to do
- Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).
D21 · Naming Consistency
2 naming inconsistencies across 200 sampled symbols.
D26 · Project Cohesion
0 of 5 projects flagged as possibly oversized/incoherent.
D28 · Secrets (history)
4 finding(s): 0 critical, 4 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
What to do
- Resolve the 3 Secret finding(s) in Secrets (history) — start with App.config, OpenRCTdotNetLogin.vb, Launcher.vb. — One of this dimension's main actionable groups (3 issue-level).
- Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
D29 · Static Analysis (SAST)
semgrep found no security issues.
D34 · Knowledge Freshness
12 of 12 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is Launcher/LauncherWFP/Data/Context/MainWindowContext.cs.
What to do
- Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
D35 · Change Coupling
No strong hidden change-coupling between production files.
Frontend & cross-cutting dimensions
AX10 · Code composition
What to do
- The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).
AX3 · Project dependency cycles
AX4 · Dependency direction
AX5 · Architecture & structure
GD1 · Unfinished & placeholder code
IC1 · Incompleteness & stubs
- `ConfigCommandImpl` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — MainWindowContext.cs:209
- `ExtrasCommandImpl` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — MainWindowContext.cs:220
- A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). — IniConfiguration.cs:411
What to do
- Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
- Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)
What to do
- Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
- Add a 'Testing' section to the root README — how to run the test suite.
- Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
- Add a README to the 5 of 5 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation
- No Architecture Decision Records found — decisions aren't captured for future maintainers.
- No C4/PlantUML/Mermaid diagram or architecture.md — the high-level shape isn't documented.
What to do
- Start an ADR log (docs/adr/) recording significant decisions and their rationale.
- Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure
- Only 1/5 projects share a common root namespace — the code's module identity is inconsistent.
What to do
- Adopt a consistent root-namespace convention (a shared prefix, e.g. Acme.*); short project-file/directory names are fine as long as the RootNamespace is uniform.
M4 · Documentation accuracy
- README claims it copies Roller Coaster Tycoon 1 theme music into OpenRCT2 but the evidence contains no music-copying component
What to do
- Reconcile the README with reality: README claims it copies Roller Coaster Tycoon 1 theme music into OpenRCT2 but the evidence contains no music-copying component.
P1 · CI/CD gates
- A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — the gate may be running tests, or "test" may be incidental (a path, "latest", a reporter). Make the test step explicit so the gate is unambiguous.
What to do
- Run the test suite in CI via an explicit runner step for your stack, and gate merges on it.
P2 · Observability
- No ILogger/Serilog usage found — production issues will be hard to diagnose.
What to do
- Adopt ILogger (or Serilog) and log at meaningful points across the projects.
- Consider OpenTelemetry tracing/metrics and a health-check endpoint for operability.
P3 · Security & performance tooling
- No static application security testing detected. For this repository's stack, add CodeQL's csharp pack (it analyses VB.NET too), or a security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step.
What to do
- Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack (it analyses VB.NET too), or a security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
- Enable Dependabot/Renovate or a dependency-review gate.
- Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene
- No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
- Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
S1 · Cryptographic Hygiene
- MD5/SHA1 is broken for security purposes (collision-vulnerable). Use SHA-256+ for content integrity; for password storage, use a KDF (PBKDF2/Argon2/BCrypt). — OpenRctBuildManager.cs:118
What to do
- Replace MD5/SHA1 with SHA-256+ for content hashing; switch to a KDF (PBKDF2/Argon2/BCrypt) for password storage.
X1 · Async correctness
- `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. — MainWindowContext.cs:116
- Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Make the caller `async` and `await` instead. — MainWindowContext.cs:296
What to do
- async void method: UpdateCommandImpl
X2 · Cancellation propagation
- Only 0/5 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
- No CancellationToken parameter — this work can't be stopped early once started. (×5) — OpenRctNetApiWrapper.cs:49, OpenRctNetApiWrapper.cs:91, OpenRctNetApiWrapper.cs:141, …
What to do
- Thread a CancellationToken through async methods so work stops promptly on cancellation.
X3 · Exception handling
- An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — IniConfiguration.cs:322
What to do
- Swallowed exception (empty catch)
X4 · Structured logging
Reference — by lens
| Lens | Score | Rating | Impact |
|---|---|---|---|
| Code Health | 56% | Adequate | Acceptable, with room to improve. |
| Architecture | 89% | Strong | Strongest area. |
| Maturity | 43% | Weak — gated by D34, M2 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Readiness | 34% | Weak — gated by P2, P3 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Security | 80% | Strong | Solid. |
Not included — 56 check(s) not relevant to this codebase
- AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
- AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
- AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
- AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
- AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
- AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
- AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
- AX1 Captive dependencies — no DI registrations detected
- AX2 Stateful singletons — no singleton implementations detected
- AX6 Interface segregation — no public interfaces
- AX7 Slice cohesion — not applicable — not a vertical-slice architecture
- AX8 Test isolation — no test/production split to check
- AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
- C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
- C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
- C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
- C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
- C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
- D11 Test Reliability — Test reliability not measured — no test run produced results
- D14 License Compliance — license scan produced no result — the tool ran but its JSON output could not be parsed; the offline NuGet fallback resolved nothing
- D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
- D22 Internal API Consistency — No exposed public API
- D23 Boundary Type-Coupling — Bounded contexts not declared
- D24 Comment Value — LLM evaluation failed
- D25 ADR Conformance — no ADRs to check
- D27 Navigability — symbol resolution incomplete — navigability not assessed
- D30 Dependency Vulnerabilities — `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read; classic .NET Framework projects are packages.config by default). No packages could be enumerated, so there was nothing to scan for NuGet CVEs — excluded rather than scored, because an unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan
- D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
- D32 Data Compliance (PII/GDPR) — No PII/GDPR ruleset is bundled (the public p/gdpr semgrep pack was retired) — data compliance is not assessed in this scan.
- D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
- D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines.yml, Jenkinsfile, .circleci); there is no build to attest provenance for.
- D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
- D38 OSV Dependency Vulnerabilities — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.
- D39 IL Efficiency — The target did not build, so no IL was available to measure.
- D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
- D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
- D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
- D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
- D8 Code Coverage — Coverage not measured — analyzer environment
- DM1 Domain Modelling — not run — 0/3 markers found
- ED1 Event-Driven — not run — 0/3 markers found
- ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
- ES1 Event Sourcing — not run — 0/3 markers found
- P12 CI test-gate honesty — no data
- P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
- P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
- P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
- P8 Schema migrations — no EF Core usage detected
- P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
- PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
- PF2 Allocation hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
- PF3 Async & latency hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
- SC1 Supply-chain hygiene — no data
- X5 Nullable reference types — no NRT-eligible projects
- X6 Hand-rolled structured-format parsing — no data
- X7 Silent fallback defaults — no data
Appendix A — Findings (grouped)
Issue — 13 finding(s)
- EmptyCatchBlock Launcher/Launcher/Forms/Extras.vb:212
- EmptyCatchBlock Launcher/Launcher/Forms/Extras.vb:216
- EmptyCatchBlock Launcher/Launcher/Forms/Extras.vb:220
- EmptyCatchBlock Launcher/Launcher/Forms/Extras.vb:224
- EmptyCatchBlock Launcher/Launcher/Launcher.vb:54
- EmptyCatchBlock Launcher/Launcher/Launcher.vb:260
- EmptyCatchBlock Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:62
- EmptyCatchBlock Launcher/ORCT2ModPacker/ORCT2ModPacker/Class1.vb:16
- EmptyCatchBlock Launcher/ReparsePointLibrary/Utils/IniConfiguration.cs:322
- Secret: generic-api-key Launcher/LauncherWFP/App.config:50
- Secret: generic-api-key Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetLogin.vb:20
- Secret: generic-api-key Launcher/Launcher/Launcher.vb:193
- Leaked secret: high-entropy-secret Launcher/LauncherWFP/App.config:50
Warning — 24 finding(s)
- TodoComment Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetLogin.vb:8
- TodoComment Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:63
- TodoComment Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:120
- TodoComment Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:123
- TodoComment Launcher/LauncherWFP/Management/RctLocator.cs:163
- Off the main sequence: HelperLibrary
- Off the main sequence: ORCT2ModPacker
- GameConfigValues.New.ctor (cyclomatic 26) Launcher/Launcher/GameConfig.vb:9
- UnPackMod.UnPackMod (cyclomatic 24) Launcher/ORCT2ModPacker/ORCT2ModPacker/Class1.vb:153
- IniConfiguration.ReadPropertyValue (cyclomatic 17) Launcher/ReparsePointLibrary/Utils/IniConfiguration.cs:382
- Test reliability not measured — no test run produced results
- dormant codebase — no living knowledge left to concentrate
- UnPackMod.UnPackMod (cognitive 37) Launcher/ORCT2ModPacker/ORCT2ModPacker/Class1.vb:153
- OpenRCTdotNetWebActions.UploadSaves (cognitive 29) Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:128
- CommandLineArgs.CommandLineArgs.ctor (cognitive 29) Launcher/ReparsePointLibrary/Utils/CommandLineArgs.cs:12
- frmLauncher.cmdLaunchGame_Click (cognitive 25) Launcher/Launcher/Launcher.vb:103
- IniConfiguration.ReadPropertyValue (cognitive 20) Launcher/ReparsePointLibrary/Utils/IniConfiguration.cs:382
- RegistryExplorer.SearchForInstallPath (cognitive 18) Launcher/LauncherWFP/Management/RctLocator.cs:140
- IniConfiguration.Parse (cognitive 17) Launcher/ReparsePointLibrary/Utils/IniConfiguration.cs:332
- OpenRCTdotNetWebActions.DownloadSaves (cognitive 16) Launcher/Launcher/OpenRCTdotNet/OpenRCTdotNetWebActions.vb:75
- ReparsePoint.GetTarget (cognitive 16) Launcher/ReparsePointLibrary/Utils/ReparsePoint.cs:159
- LLM evaluation failed
- Low cohesion: frmLauncher (LCOM4 5) Launcher/Launcher/Launcher.vb:12
- Coverage not measured — analyzer environment
Recommendation — 6 finding(s)
- No ADRs found
- Inconsistent naming for ViewModel/Context classes. The codebase uses 'Context' as a suffix for view-models (e.g., MainWindowContext, WelcomeDataContext), but the base class or interface naming is not explicitly shown, however, the pattern is consistent within the namespace. However, looking at the list, we see 'MainWindowContext' and 'WelcomeDataContext'. This is actually consistent. Let's look for actual inconsistencies.
- Inconsistent naming for interop/Windows API wrappers. Some members are static methods on the 'ReparsePoint' class (e.g., Create, Move, LookupPrivilegeValue), while others are nested types or separate classes. More importantly, the class 'ReparsePoint' is used for file system operations (symlinks), but the name 'ReparsePoint' is a specific Windows API structure/constant, not a general utility class name. This is a conceptual inconsistency where the class name reflects a specific API detail rather than the domain concept (e.g., 'SymlinkManager' or 'FileSystemLinker').
- Bounded contexts not declared
- Rotate the exposed credentials — git history can't be un-committed
- Further orphaned files (smaller)
Info — 6 finding(s)
- XML-doc coverage: Launcher Launcher/Launcher/Launcher.vbproj
- XML-doc coverage: HelperLibrary Launcher/ReparsePointLibrary/HelperLibrary.csproj
- XML-doc coverage: ORCT2ModPacker Launcher/ORCT2ModPacker/ORCT2ModPacker/ORCT2ModPacker.vbproj
- XML-doc coverage: LauncherWPF Launcher/LauncherWFP/LauncherWPF.csproj
- Build did not complete in the analyzer
- No exposed public API
Appendix B — Reproduction & audit trail
| Dimension | Tool | Version | Command | Findings | Raw output |
|---|---|---|---|---|---|
| D28 · Secrets (history) | gitleaks | — | gitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source . | 4 | artifacts/raw/gitleaks-history.json |
| D29 · Static Analysis (SAST) | semgrep | — | semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --json --quiet --timeout 0 --metrics off . | 0 | artifacts/raw/semgrep.json |
| D30 · Dependency Vulnerabilities | dotnet | — | dotnet: not applicable — `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read; classic .NET Framework projects are packages.config by default). No packages could be enumerated, so there was nothing to scan for NuGet CVEs — excluded rather than scored, because an unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan | 0 | — |
| D31 · IaC & Container Security | trivy | — | trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan. | 0 | — |
| D32 · Data Compliance (PII/GDPR) | semgrep | — | semgrep: not applicable — No PII/GDPR ruleset is bundled (the public p/gdpr semgrep pack was retired) — data compliance is not assessed in this scan. | 0 | — |
| D33 · JS/npm Dependency Vulnerabilities | trivy | — | trivy: not applicable — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan. | 0 | — |
| D36 · Supply-chain Provenance & Signing | provenance | — | provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines.yml, Jenkinsfile, .circleci); there is no build to attest provenance for. | 0 | — |
| D37 · Vulnerability-disclosure Policy | disclosure | — | disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed. | 0 | — |
| D38 · OSV Dependency Vulnerabilities | osv-scanner | — | osv-scanner: not applicable — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain. | 0 | — |
| D40 · Network Egress Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here. | 0 | — |
| D41 · Kernel & Syscall Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here. | 0 | — |
| D42 · Runtime Threat Enforcement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here. | 0 | — |