Public report — PictureSelector, published 6 Aug 2026. Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version; ask the repo owner for the full report.
Watchdog 06-08-2026 @ 16:40 UTC Public
Code Health Audit

LuckSiege/PictureSelector

45% Weak
CriticalWeakAdequateStrongExemplary
upper third — near Adequate

Medium · 47,976 LoC · rebuild ~0.3 person-years · weakest lens: Readiness (24%)

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

16/18dimensions tool-verifieddeterministic · confidence 1.0 · 2 LLM-assisted, advisory
272findings with an exact file:lineof 278 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
18/93dimensions across the health lenses47976 LoC — wide & deep

Executive summary

Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.

LuckSiege/PictureSelector carries serious gaps (45%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.

It is strongest in Architecture (96%) — the structure is clean and changes stay contained. Security (92%) is solid too.

The area that most needs attention is Readiness (24%) — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade. Maturity (46%) is the next concern — onboarding is slow — key decisions and the architecture aren't written down, so contributors have to reverse-engineer the intent.

Leadership focus, highest impact first: CI workflow that builds and runs the test suite on every push/PR (CI/CD gates); Run what this repository's stack ships (Security & performance tooling); Record significant decisions one document per decision (Architecture documentation).

For scale: Medium (~47,976 production lines); rebuilding it from scratch would take roughly ~0.3 person-years (~1 engineer). Approximate, ±~30%.

Encouragingly, the gaps are in documentation and release process — not in the code's correctness, structure or security, which are strong. They're low-risk to close, and doing so would lift the grade without re-engineering anything that already works.

How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Readiness 24% · 47% weightMaturity 46% · 26% weightCode Health 73% · 14% weightSecurity 92% · 8% weightArchitecture 96% · 4% weight

Raise Readiness 24 → 70 (the Healthy floor) ⇒ headline 45 → ~62.

Code composition — where the lines go
Tests 100%
New since the last scan (7+)

7 finding(s) are new versus the previous scan (2026-08-02) — surfaced by this scheduled scan itself, no pull request required.

  • D35 · Boundary-crossing change coupling: MainActivity.java ↔ BaseRecyclerMediaHolder.java app/src/main/java/com/luck/pictureselector/MainActivity.java
  • D35 · Boundary-crossing change coupling: InjectFragmentActivity.java ↔ PictureSelectionModel.java app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java
  • D35 · Change coupling: MainActivity.java ↔ PictureSelectorEngineImp.java app/src/main/java/com/luck/pictureselector/MainActivity.java
  • D35 · Change coupling: PictureSelectionModel.java ↔ PictureSelectionPreviewModel.java selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java
  • D35 · Change coupling: App.java ↔ MainActivity.java app/src/main/java/com/luck/pictureselector/App.java
  • D35 · Change coupling: PictureImageGridAdapter.java ↔ PicturePreviewAdapter.java selector/src/main/java/com/luck/picture/lib/adapter/PictureImageGridAdapter.java
  • D35 · Change coupling: PictureSelectorPreviewFragment.java ↔ PictureSelectorSupporterActivity.java selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java

A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.

Rebuild cost & value ~ Modeled — €14,000–€71,000
Cost to rebuild€14,000–€71,000 (0.1–0.4 person-years (236–749 h), ~1 engineer)
Domain complexityStandard — harder problems cost more per line
Quality factor0.7× (at 45% quality) — the last 20% of quality is most of the work
Size & shapeMedium · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)

This codebase represents roughly ~0.3 person-years of build effort (about ~€43,000 to rebuild). Its weakest lens is Readiness at 24% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.0) — standard service × a 0.7× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Add a CI workflow that builds and runs the test suite on every push/PR.
+20.6 pts · Medium effort · CI/CD gates
2
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
+20.6 pts · Medium effort · Security & performance tooling
3
Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with MainActivity.java, PictureCommonFragment.java, PictureSelectorPreviewFragment.java.
+8.5 pts · Low effort · Knowledge Freshness

Diagnosis — what's actually going on

Value concentrated against a weak lens · High · Value at risk
This is a Medium asset (~0.3 person-years to rebuild), and its weakest lens is Readiness at 24%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
Evidence: valuation: Medium, ~0.3 person-years rebuild (47,976 LoC) · weakest lens: Readiness 24%
→ Direct remediation budget at Readiness first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Add a CI workflow that builds and runs the test suite on every push/PR. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Add a CI workflow that builds and runs the test suite on every push/PR.
A velocity tax on every change · Medium · Economics
The code-quality signals (complexity, duplication, cohesion) average 7.2/10, which acts as a tax on every change in the weaker areas: modifications there plausibly cost on the order of 2–5% more than in clean code, and the tax compounds as the codebase grows. (A modelled estimate, not a measured fact.)
Evidence: D1/D2/D4 code quality: averaging 7.2/10 across the code-quality signals actually measured
→ Pay it down where churn is highest — the hotspots — not everywhere; that's where the tax is actually paid.

Architecture — module dependency matrix

51 modules, 104 dependencies — 2 dependency cycles, shown as the red cell(s) above the diagonal. Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)

(global)….lib.camerax.listener…b.camerax.permissions…uck.lib.camerax.utils…cture.lib.permissions…picture.lib.photoview…uck.picture.lib.style…tureselector.listener….yalantis.ucrop.model…ck.lib.camerax.widget….picture.lib.obj.pool…ck.picture.lib.thread…lantis.ucrop.callback…tis.ucrop.view.widgettop.zibin.lubantop.zibin.luban.io…ijk.media.player.misccom.luck.lib.camerax…ck.picture.lib.entity…m.yalantis.ucrop.task…m.yalantis.ucrop.util…maku.ijk.media.player…icture.lib.interfaces…ctureselector.adapter…m.yalantis.ucrop.view…ck.picture.lib.dialog…ck.picture.lib.loader…k.picture.lib.manager…ck.picture.lib.widgetcom.yalantis.ucrop…ck.picture.lib.engine….luck.picture.lib.app…uck.picture.lib.basic…ck.picture.lib.config…re.lib.adapter.holder…k.picture.lib.magical…uck.picture.lib.utils…k.picture.lib.adaptercom.luck.picture.lib….luck.pictureselector(global)1….lib.camerax.listener2…b.camerax.permissions3…uck.lib.camerax.utils4…cture.lib.permissions5…picture.lib.photoview6…uck.picture.lib.style7…tureselector.listener8….yalantis.ucrop.model9…ck.lib.camerax.widget10….picture.lib.obj.pool11…ck.picture.lib.thread12…lantis.ucrop.callback13…tis.ucrop.view.widget14top.zibin.luban15top.zibin.luban.io16…ijk.media.player.misc17com.luck.lib.camerax18…ck.picture.lib.entity19…m.yalantis.ucrop.task20…m.yalantis.ucrop.util21…maku.ijk.media.player22…icture.lib.interfaces23…ctureselector.adapter24…m.yalantis.ucrop.view25…ck.picture.lib.dialog26…ck.picture.lib.loader27…k.picture.lib.manager28…ck.picture.lib.widget29com.yalantis.ucrop30…ck.picture.lib.engine31….luck.picture.lib.app32…uck.picture.lib.basic33…ck.picture.lib.config34…re.lib.adapter.holder35…k.picture.lib.magical36…uck.picture.lib.utils37…k.picture.lib.adapter38com.luck.picture.lib39….luck.pictureselector4043311182162314211177111113312113119313312129181111232313491323831219932111611135214133117182115213411111713515222181221+11 more modules (most-connected shown)

At a glance — Code Health · 73% · Strong

At a glance — Architecture · 96% · Exemplary

At a glance — Maturity · 46% · Weak · gated by D34, M2

At a glance — Readiness · 24% · Critical · gated by P1, P3

At a glance — Security · 92% · Exemplary

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2021 — Injection1Medium

Roadmap

First, establish a CI/CD pipeline to automatically build the code and run the test suite on every push or pull request. Next, integrate static security and performance tooling, such as SpotBugs or Semgrep, into this workflow to fail the build on security regressions. Then, document key architectural decisions in a dedicated directory to preserve context and consequences. Finally, resolve orphaned files to improve code freshness and update the README to clearly explain how to run the test suite.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Add a CI workflow that builds and runs the test suite on every push/PR.+20.6 ptsMediumCI/CD gates
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.+20.6 ptsMediumSecurity & performance tooling
Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with MainActivity.java, PictureCommonFragment.java, PictureSelectorPreviewFragment.java.+8.5 ptsLowKnowledge Freshness
Resolve the 1 The Contents outline lists Usage as a section, but the visible text only… finding(s) in Documentation Quality — start with README.md.+7.4 ptsLowDocumentation Quality
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).+10.3 ptsMediumArchitecture documentation
Add a 'Testing' section to the root README — how to run the test suite.+7.9 ptsMediumDocumentation (README)
Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness.+3.3 ptsLowKnowledge Freshness
Reconcile the README with reality: README advertises Docker containerisation, but no Dockerfile/compose file exists.+5.2 ptsMediumDocumentation accuracy

File quality

Per-file score 0–10 — a quality signature. Of 90 files carrying findings, judged against the Production bar: 1% slop · 53% mixed · 46% near-clean.

FileScoreBandWorst signal
app/src/main/java/com/luck/pictureselector/MainActivity.java2.0SlopChange Coupling: Boundary-crossing change coupling: MainActivity.java ↔ PictureSelectionPreviewModel.java
selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java5.5MixedCyclomatic Complexity: PictureSelectorPreviewFragment.initComplete (cyclomatic 21)
selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java5.7MixedStatic Analysis (SAST): Medium: use-of-md5
selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java5.7MixedCognitive Complexity: PictureSelectionModel.setQueryOnlyMimeType (cognitive 17)
app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java6.5MixedChange Coupling: Boundary-crossing change coupling: InjectFragmentActivity.java ↔ PictureSelectionModel.java
selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java7.0MixedCyclomatic Complexity: PictureCommonFragment.checkOnlyMimeTypeValidity (cyclomatic 46)
selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java7.0MixedCyclomatic Complexity: LocalMediaLoader.parseLocalMedia (cyclomatic 28)
selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java7.0MixedCyclomatic Complexity: PictureSelectorFragment.mergeFolder (cyclomatic 16)
ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java7.0MixedCognitive Complexity: UCropActivity.processOptions (cognitive 18)
selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java7.0MixedCyclomatic Complexity: LocalMediaPageLoader.parseLocalMedia (cyclomatic 34)
selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java7.0MixedCognitive Complexity: PictureFileUtils.deleteAllCacheDirFile (cognitive 30)
selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java7.0MixedCyclomatic Complexity: LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18)
selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java7.0MixedGod Classes: TooManyMethods: PictureSelectionCameraModel
selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java7.1MixedCyclomatic Complexity: CompleteSelectView.setSelectedChange (cyclomatic 25)
selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java7.1MixedCyclomatic Complexity: PictureCacheManager.deleteAllCacheDirFile (cyclomatic 22)
ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java7.1MixedCyclomatic Complexity: EventHandler.handleMessage (cyclomatic 19)
selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java7.1MixedCode Duplication: Duplicated block (12 lines × 2)
selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java7.2MixedCyclomatic Complexity: BottomNavBar.setBottomNavBarStyle (cyclomatic 23)
ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java7.2MixedCyclomatic Complexity: ImageHeaderParser.parseExifSegment (cyclomatic 20)
selector/src/main/java/com/luck/picture/lib/photoview/PhotoViewAttacher.java7.2MixedCyclomatic Complexity: PhotoViewAttacher.onTouch (cyclomatic 17)

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 16 of 18 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 2 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.4 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 18 dimensions across the health lenses
D1D2D3D4D13D15D19D21D28D29D34D35M1M2M3M4P1P3

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 272 of 278 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
jscpdCode duplication✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.302✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.302✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 019fd7f3-07a6-7396-a405-e58125538889.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.

The LLM boundary

LLM-set scores this run (3): D19, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity6.8 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 6.8 / 10 · rule-coverage 100% · ceiling Prevented

28 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was PictureCommonFragment.checkOnlyMimeTypeValidity at 46. A further 3 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being MainActivity.onCheckedChanged at 43 — they are counted neither in the figure above nor in this dimension's score.

LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18) · ×2selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:111
PictureCommonFragment.checkOnlyMimeTypeValidity (cyclomatic 46)selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:594
PictureCommonFragment.checkWithMimeTypeValidity (cyclomatic 35)selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:473
LocalMediaPageLoader.parseLocalMedia (cyclomatic 34)selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:625
SandboxFileLoader.loadInAppSandboxFile (cyclomatic 34)selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java:62

+ 22 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 2 LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18) finding(s) in Cyclomatic Complexity — start with LightStatusBarUtils.java (2). — One of this dimension's main actionable groups (2 warning-level).
  2. Resolve the 1 PictureCommonFragment.checkOnlyMimeTypeValidity (cyclomatic 46) finding(s) in Cyclomatic Complexity — start with PictureCommonFragment.java. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 PictureCommonFragment.checkWithMimeTypeValidity (cyclomatic 35) finding(s) in Cyclomatic Complexity — start with PictureCommonFragment.java. — One of this dimension's main actionable groups (1 warning-level).
  4. Stand up a CI pipeline, then gate Cyclomatic Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.7 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Prevented

87 method(s) exceeded the cognitive complexity threshold of 15; the worst was PictureCommonFragment.checkOnlyMimeTypeValidity at 129.

LightStatusBarUtils.setAndroidNativeLightStatusBar (cognitive 39) · ×2selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:111
BitmapUtils.computeSize (cognitive 16) · ×2camerax/src/main/java/com/luck/lib/camerax/utils/BitmapUtils.java:27
PictureCommonFragment.checkOnlyMimeTypeValidity (cognitive 129)selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:594
3.doInBackground (cognitive 97)selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:265
PictureCommonFragment.checkWithMimeTypeValidity (cognitive 95)selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:473

+ 80 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 2 LightStatusBarUtils.setAndroidNativeLightStatusBar (cognitive 39) finding(s) in Cognitive Complexity — start with LightStatusBarUtils.java (2). — One of this dimension's main actionable groups (2 warning-level).
  2. Resolve the 2 BitmapUtils.computeSize (cognitive 16) finding(s) in Cognitive Complexity — start with BitmapUtils.java (2). — One of this dimension's main actionable groups (2 warning-level).
  3. Resolve the 1 PictureCommonFragment.checkOnlyMimeTypeValidity (cognitive 129) finding(s) in Cognitive Complexity — start with PictureCommonFragment.java. — One of this dimension's main actionable groups (1 warning-level).
  4. Stand up a CI pipeline, then gate Cognitive Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes7.7 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 7.7 / 10 · rule-coverage 100% · ceiling Prevented

32 god class(es) detected.

TooManyMethods: IjkMediaPlayer · ×23ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:68
FileTooLong: pictureselector/MainActivity.java · ×9app/src/main/java/com/luck/pictureselector/MainActivity.java:0

What to do

  1. Resolve the 23 TooManyMethods finding(s) in God Classes — start with IjkMediaPlayer.java, PictureSelectionModel.java, SelectMainStyle.java. — One of this dimension's main actionable groups (23 warning-level).
  2. Resolve the 9 FileTooLong finding(s) in God Classes — start with MainActivity.java, PictureCommonFragment.java, PictureSelectorPreviewFragment.java. — One of this dimension's main actionable groups (9 warning-level).
  3. Stand up a CI pipeline, then gate God Classes in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication8.9 / 10Strong✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 8.9 / 10 · rule-coverage 100% · ceiling Verified

110 duplicated block group(s) detected.

Duplicated block (10 lines × 2) · ×16app/src/main/java/com/luck/pictureselector/ImageLoaderUtils.java:17
Duplicated block (9 lines × 2) · ×14app/src/main/java/com/luck/pictureselector/IjkPlayerEngine.java:98
Duplicated block (11 lines × 2) · ×12app/src/main/java/com/luck/pictureselector/MainActivity.java:717
Duplicated block (12 lines × 2) · ×11app/src/main/java/com/luck/pictureselector/MainActivity.java:1337
Duplicated block (7 lines × 2) · ×11app/src/main/java/com/luck/pictureselector/MainActivity.java:1697

+ 19 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 16 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with UCropActivity.java (4), PictureCommonFragment.java (2), MediaUtils.java (2). — One of this dimension's main actionable groups (16 warning-level).
  2. Resolve the 14 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with PictureCommonFragment.java (2), IjkPlayerEngine.java, MainActivity.java. — One of this dimension's main actionable groups (14 warning-level).
  3. Resolve the 12 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with PictureCommonFragment.java (3), MainActivity.java, AudioViewHolder.java. — One of this dimension's main actionable groups (12 warning-level).
  4. Stand up a CI pipeline, then gate Code Duplication in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D19 · Documentation Quality / 10Weak◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Weak / 10 · rule-coverage 100% · ceiling Documented

The single README is a decent landing page for the Android picture selector framework, covering purpose, links to Chinese and demo APK, Maven Central, PRs welcome, and an initial download section with Gradle dependency code. It lists many sections in its Contents outline (Latest version, Download, Usage, Permission, Result description, Effect, ProGuard, Common errors, Issues, License) but the body is cut at the 'Demo' link mid-Usage before any of those topics are fully developed.

The Contents outline lists Usage as a section, but the visible text only shows Download and Permission; no Usage content appears in the clipped document.README.md

What to do

  1. Resolve the 1 The Contents outline lists Usage as a section, but the visible text only… finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency / 10Exemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D28 · Secrets (history)9.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.

Maturity: DocumentedVerifiedPrevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)9.5 / 10Exemplary✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: DocumentedVerifiedPrevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 0 high, 1 medium, 0 low.

Medium: use-of-md5selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java:81detected by semgrep finding

✓ On the Gold path — maintain.

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: DocumentedVerifiedPrevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

146 of 146 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is app/src/main/java/com/luck/pictureselector/MainActivity.java.

Largest orphaned file · ×3app/src/main/java/com/luck/pictureselector/MainActivity.java
Dormant codebase

What to do

  1. Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with MainActivity.java, PictureCommonFragment.java, PictureSelectorPreviewFragment.java. — One of this dimension's main actionable groups (3 recommendation-level).
  2. Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.6 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.

Maturity: DocumentedVerifiedPrevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: MainActivity.java↔PictureSelectorEngineImp.java 75%; PictureSelectionModel.java↔PictureSelectionPreviewModel.java 67%; MainActivity.java↔PictureSelectionPreviewModel.java 62%

Boundary-crossing change coupling: MainActivity.java ↔ PictureSelectionPreviewModel.java · ×5app/src/main/java/com/luck/pictureselector/MainActivity.java
Change coupling: MainActivity.java ↔ PictureSelectorEngineImp.java · ×5app/src/main/java/com/luck/pictureselector/MainActivity.java

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

M1 · Documentation (README)6.7 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 6 of 6 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/PlantUML/Mermaid diagram or architecture.md — the high-level shape isn't documented.

What to do

  • Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy8.0 / 10Strong◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • README advertises Docker containerisation, but no Dockerfile/compose file exists

What to do

  • Reconcile the README with reality: README advertises Docker containerisation, but no Dockerfile/compose file exists.
P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.

What to do

  • Add a CI workflow that builds and runs the test suite on every push/PR.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build.

What to do

  • Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health73%StrongSolid.
Architecture96%ExemplaryStrongest area.
Maturity46%Weak — gated by D34, M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness24%Critical — gated by P1, P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security92%ExemplarySolid.
Not included — 75 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — no DI registrations detected
  • AX10 Code composition — not assessed — code composition is computed by ROLE over a document set that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — no singleton implementations detected
  • AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~11 lines of test source are present (.java) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included
  • D12 Dependency Hygiene — Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
  • D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (a Gradle version catalogue), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
  • D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
  • D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D22 Internal API Consistency — No exposed public API
  • D23 Boundary Type-Coupling — Production source is present (.java, .kt) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle version catalogue — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
  • D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
  • D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, Jenkinsfile, .circleci); there is no build to attest provenance for.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D38 OSV Dependency Vulnerabilities — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
  • D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .java, .kt, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • D9 Test Distribution — Test source is present (.java) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this check looks for (27 value object(s))
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
  • GD1 Unfinished & placeholder code — no source files
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — no CI workflow found
  • P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
  • P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
  • P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Issue — 5 finding(s)
D35 · Change Coupling · Boundary-crossing change coupling · ×5
  • Boundary-crossing change coupling: MainActivity.java ↔ PictureSelectionPreviewModel.java app/src/main/java/com/luck/pictureselector/MainActivity.java — `app/src/main/java/com/luck/pictureselector/MainActivity.java` (context main) and `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java` (context selector) sit in DIFFERENT parts of the tree yet change together 62% of the time (13 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see.
  • Boundary-crossing change coupling: MainActivity.java ↔ UCropMultipleActivity.java app/src/main/java/com/luck/pictureselector/MainActivity.java — `app/src/main/java/com/luck/pictureselector/MainActivity.java` (context main) and `ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java` (context ucrop) sit in DIFFERENT parts of the tree yet change together 60% of the time (9 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see.
  • Boundary-crossing change coupling: MainActivity.java ↔ BaseRecyclerMediaHolder.java app/src/main/java/com/luck/pictureselector/MainActivity.java — `app/src/main/java/com/luck/pictureselector/MainActivity.java` (context main) and `selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java` (context selector) sit in DIFFERENT parts of the tree yet change together 50% of the time (9 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see.
  • Boundary-crossing change coupling: PictureSelectorEngineImp.java ↔ PictureSelectorPreviewFragment.java app/src/main/java/com/luck/pictureselector/PictureSelectorEngineImp.java — `app/src/main/java/com/luck/pictureselector/PictureSelectorEngineImp.java` (context main) and `selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java` (context selector) sit in DIFFERENT parts of the tree yet change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see.
  • Boundary-crossing change coupling: InjectFragmentActivity.java ↔ PictureSelectionModel.java app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java — `app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java` (context main) and `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java` (context selector) sit in DIFFERENT parts of the tree yet change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see.
Warning — 264 finding(s)
D3 · God Classes · TooManyMethods · ×23
  • TooManyMethods: IjkMediaPlayer ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:68 — TooManyMethods — 117 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureSelectionModel selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:70 — TooManyMethods — 114 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SelectMainStyle selector/src/main/java/com/luck/picture/lib/style/SelectMainStyle.java:10 — TooManyMethods — 107 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureCommonFragment selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:97 — TooManyMethods — 97 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LocalMedia selector/src/main/java/com/luck/picture/lib/entity/LocalMedia.java:25 — TooManyMethods — 87 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureThreadUtils selector/src/main/java/com/luck/picture/lib/thread/PictureThreadUtils.java:34 — TooManyMethods — 71 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureSelectorPreviewFragment selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:92 — TooManyMethods — 64 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureSelectionCameraModel selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:50 — TooManyMethods — 53 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureSelectorFragment selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:84 — TooManyMethods — 52 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PhotoViewAttacher selector/src/main/java/com/luck/picture/lib/photoview/PhotoViewAttacher.java:25 — TooManyMethods — 52 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BottomNavBarStyle selector/src/main/java/com/luck/picture/lib/style/BottomNavBarStyle.java:8 — TooManyMethods — 47 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Options ucrop/src/main/java/com/yalantis/ucrop/UCrop.java:327 — TooManyMethods — 47 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TitleBarStyle selector/src/main/java/com/luck/picture/lib/style/TitleBarStyle.java:8 — TooManyMethods — 45 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MediaPlayerProxy ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/MediaPlayerProxy.java:34 — TooManyMethods — 44 methods. Most of these members implement player.IMediaPlayer (38 of 40 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
  • TooManyMethods: PhotoView selector/src/main/java/com/luck/picture/lib/photoview/PhotoView.java:19 — TooManyMethods — 44 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MainActivity app/src/main/java/com/luck/pictureselector/MainActivity.java:167 — TooManyMethods — 43 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CustomCameraView camerax/src/main/java/com/luck/lib/camerax/CustomCameraView.java:96 — TooManyMethods — 39 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AndroidMediaPlayer ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/AndroidMediaPlayer.java:43 — TooManyMethods — 38 methods. Most of these members implement player.IMediaPlayer (30 of 34 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
  • TooManyMethods: OverlayView ucrop/src/main/java/com/yalantis/ucrop/view/OverlayView.java:39 — TooManyMethods — 38 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PictureMimeType selector/src/main/java/com/luck/picture/lib/config/PictureMimeType.java:12 — TooManyMethods — 33 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CropImageView ucrop/src/main/java/com/yalantis/ucrop/view/CropImageView.java:34 — TooManyMethods — 33 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: UCropActivity ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:71 — TooManyMethods — 32 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TransformImageView ucrop/src/main/java/com/yalantis/ucrop/view/TransformImageView.java:32 — TooManyMethods — 32 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×16
  • Duplicated block (10 lines × 2) app/src/main/java/com/luck/pictureselector/ImageLoaderUtils.java:17 — app/src/main/java/com/luck/pictureselector/ImageLoaderUtils.java:17-26 | selector/src/main/java/com/luck/picture/lib/utils/ActivityCompatHelper.java:44-53 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/ImageLoaderUtils.java:17` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:656 — app/src/main/java/com/luck/pictureselector/MainActivity.java:656-665 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:932-941 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:656` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) app/src/main/java/com/luck/pictureselector/PicassoEngine.java:78 — app/src/main/java/com/luck/pictureselector/PicassoEngine.java:78-87 | app/src/main/java/com/luck/pictureselector/PicassoEngine.java:126-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/PicassoEngine.java:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:146 — camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:146-155 | selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:448-457 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:146` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:683 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:683-692 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:722-731 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:683` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1311 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1311-1320 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1341-1350 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1311` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionQueryModel.java:218 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionQueryModel.java:218-227 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionQueryModel.java:243-252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:171 — selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:171-180 | selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:202-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:171` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:275 — selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:275-284 | selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:319-328 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:275` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1558 — selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1558-1567 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1600-1609 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1558` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:222 — selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:222-231 | selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:327-336 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:222` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:428 — ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:428-437 | ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:471-480 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:428` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:154 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:154-163 | ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java:452-461 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:154` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:173 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:173-182 | ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java:471-480 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:173` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:370 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:370-379 | ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java:314-323 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (10 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:659 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:659-668 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:534-543 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:659` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×14
  • Duplicated block (9 lines × 2) app/src/main/java/com/luck/pictureselector/IjkPlayerEngine.java:98 — app/src/main/java/com/luck/pictureselector/IjkPlayerEngine.java:98-107 | selector/src/main/java/com/luck/picture/lib/engine/MediaPlayerEngine.java:97-105 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/IjkPlayerEngine.java:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:1818 — app/src/main/java/com/luck/pictureselector/MainActivity.java:1818-1826 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1836-1844 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:1818` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) camerax/src/main/java/com/luck/lib/camerax/permissions/PermissionChecker.java:70 — camerax/src/main/java/com/luck/lib/camerax/permissions/PermissionChecker.java:70-78 | selector/src/main/java/com/luck/picture/lib/permissions/PermissionChecker.java:72-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/permissions/PermissionChecker.java:70` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1298 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1298-1306 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1328-1337 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1298` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1571 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1571-1579 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1584-1592 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1571` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:737 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:737-745 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1534-1542 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:737` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1437 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1437-1445 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1469-1477 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:370 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:370-378 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:411-419 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:370` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/decoration/GridSpacingItemDecoration.java:33 — selector/src/main/java/com/luck/picture/lib/decoration/GridSpacingItemDecoration.java:33-41 | ucrop/src/main/java/com/yalantis/ucrop/decoration/GridSpacingItemDecoration.java:31-39 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/decoration/GridSpacingItemDecoration.java:33` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:232 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:232-240 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:589-597 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:232` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:100 — selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:100-108 | selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:160-170 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:324 — selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:324-332 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:572-580 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:324` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:183 — selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:183-191 | selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:283-291 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:183` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:118 — ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:118-126 | ucrop/src/main/java/com/yalantis/ucrop/util/BitmapLoadUtils.java:135-143 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:118` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×12
  • Duplicated block (11 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:717 — app/src/main/java/com/luck/pictureselector/MainActivity.java:717-727 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:964-974 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:717` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/adapter/holder/AudioViewHolder.java:36 — selector/src/main/java/com/luck/picture/lib/adapter/holder/AudioViewHolder.java:36-46 | selector/src/main/java/com/luck/picture/lib/adapter/holder/VideoViewHolder.java:36-46 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:508 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:508-520 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:598-608 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:508` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:535 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:535-546 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:644-654 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:535` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1507 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1507-1517 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1540-1550 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1507` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:90 — selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:90-100 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:90-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:90` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:70 — selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:70-80 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/RomUtils.java:68-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:70` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:350 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:350-360 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:726-736 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:350` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:298 — selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:298-308 | selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:330-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/MediaUtils.java:298` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/PSEglUtils.java:108 — selector/src/main/java/com/luck/picture/lib/utils/PSEglUtils.java:108-118 | ucrop/src/main/java/com/yalantis/ucrop/util/EglUtils.java:106-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/ValueOf.java:93 — selector/src/main/java/com/luck/picture/lib/utils/ValueOf.java:93-103 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/RomUtils.java:204-214 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/ValueOf.java:93` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:209 — selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:209-219 | selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:308-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:209` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×11
  • Duplicated block (12 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:1337 — app/src/main/java/com/luck/pictureselector/MainActivity.java:1337-1348 | app/src/main/java/com/luck/pictureselector/PictureSelectorEngineImp.java:135-146 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:1337` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:86 — camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:86-97 | selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:100-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:478 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:478-489 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:612-623 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:478` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:695 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:695-706 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1493-1504 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:809 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:809-820 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:483-494 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:177 — selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:177-188 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:177-188 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:177` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:214 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:214-225 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:570-582 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:214` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:403 — selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:403-414 | selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:415-426 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:168 — selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:168-179 | selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:262-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:168` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:101 — ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:101-112 | ucrop/src/main/java/com/yalantis/ucrop/util/BitmapLoadUtils.java:121-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:101` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:499 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:499-510 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:374-385 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:499` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×11
  • Duplicated block (7 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:1697 — app/src/main/java/com/luck/pictureselector/MainActivity.java:1697-1703 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1767-1774 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:1697` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:42 — camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:42-48 | selector/src/main/java/com/luck/picture/lib/utils/MediaStoreUtils.java:122-128 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:42` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:73 — camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:73-79 | selector/src/main/java/com/luck/picture/lib/utils/MediaStoreUtils.java:178-184 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/CameraUtils.java:73` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectorSupporterActivity.java:46 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectorSupporterActivity.java:46-52 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectorTransparentActivity.java:66-72 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectorSupporterActivity.java:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:204 — selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:204-210 | selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:216-222 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:204` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:232 — selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:232-238 | compress/src/main/java/top/zibin/luban/LubanUtils.java:38-44 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:232` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:136 — selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:136-142 | selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:209-215 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:136` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:291 — selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:291-297 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:661-667 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:291` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:271 — selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:271-277 | selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:316-322 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/PictureSelectorSystemFragment.java:271` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:476 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:476-482 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:351-357 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:476` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:726 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:726-732 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:598-604 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:726` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D3 · God Classes · FileTooLong · ×9
  • FileTooLong: pictureselector/MainActivity.java app/src/main/java/com/luck/pictureselector/MainActivity.java:0 — FileTooLong — 1668 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: MainActivity (167-2390). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: basic/PictureCommonFragment.java selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:0 — FileTooLong — 1318 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: PictureCommonFragment (97-2153). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: lib/PictureSelectorPreviewFragment.java selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:0 — FileTooLong — 1105 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: PictureSelectorPreviewFragment (92-1734). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: lib/PictureSelectorFragment.java selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:0 — FileTooLong — 868 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: PictureSelectorFragment (84-1289). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: camerax/CustomCameraView.java camerax/src/main/java/com/luck/lib/camerax/CustomCameraView.java:0 — FileTooLong — 744 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: CustomCameraView (96-1197). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: player/IjkMediaPlayer.java ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:0 — FileTooLong — 735 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: IjkMediaPlayer (68-1287). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: thread/PictureThreadUtils.java selector/src/main/java/com/luck/picture/lib/thread/PictureThreadUtils.java:0 — FileTooLong — 596 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: PictureThreadUtils (34-1387). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: basic/PictureSelectionModel.java selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:0 — FileTooLong — 539 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: PictureSelectionModel (70-1543). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: photoview/PhotoViewAttacher.java selector/src/main/java/com/luck/picture/lib/photoview/PhotoViewAttacher.java:0 — FileTooLong — 513 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: PhotoViewAttacher (25-809). Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×9
  • Duplicated block (8 lines × 2) app/src/main/java/com/luck/pictureselector/adapter/GridImageAdapter.java:158 — app/src/main/java/com/luck/pictureselector/adapter/GridImageAdapter.java:158-166 | app/src/main/java/com/luck/pictureselector/OnlyQueryDataActivity.java:113-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/adapter/GridImageAdapter.java:158` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java:86 — app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java:86-93 | app/src/main/java/com/luck/pictureselector/MainActivity.java:2276-2283 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/InjectFragmentActivity.java:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) app/src/main/java/com/luck/pictureselector/PicassoEngine.java:89 — app/src/main/java/com/luck/pictureselector/PicassoEngine.java:89-96 | app/src/main/java/com/luck/pictureselector/PicassoEngine.java:136-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/PicassoEngine.java:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:71 — camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:71-78 | selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:85-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:756 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:756-763 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:434-441 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:756` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java:330 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java:330-337 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java:374-381 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java:330` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:176 — selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:176-183 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/ImmersiveManager.java:122-129 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:176` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:59 — selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:59-66 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:59-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:59` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:298 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:298-305 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:274-281 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:298` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D35 · Change Coupling · Change coupling · ×5
  • Change coupling: MainActivity.java ↔ PictureSelectorEngineImp.java app/src/main/java/com/luck/pictureselector/MainActivity.java — `app/src/main/java/com/luck/pictureselector/MainActivity.java` and `app/src/main/java/com/luck/pictureselector/PictureSelectorEngineImp.java` change together 75% of the time (9 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: PictureSelectionModel.java ↔ PictureSelectionPreviewModel.java selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java — `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java` and `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java` change together 67% of the time (14 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: App.java ↔ MainActivity.java app/src/main/java/com/luck/pictureselector/App.java — `app/src/main/java/com/luck/pictureselector/App.java` and `app/src/main/java/com/luck/pictureselector/MainActivity.java` change together 58% of the time (11 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: PictureImageGridAdapter.java ↔ PicturePreviewAdapter.java selector/src/main/java/com/luck/picture/lib/adapter/PictureImageGridAdapter.java — `selector/src/main/java/com/luck/picture/lib/adapter/PictureImageGridAdapter.java` and `selector/src/main/java/com/luck/picture/lib/adapter/PicturePreviewAdapter.java` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: PictureSelectorPreviewFragment.java ↔ PictureSelectorSupporterActivity.java selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java — `selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java` and `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectorSupporterActivity.java` change together 50% of the time (12 of the 24 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×5
  • Duplicated block (5 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:2097 — app/src/main/java/com/luck/pictureselector/MainActivity.java:2097-2101 | app/src/main/java/com/luck/pictureselector/MainActivity.java:2123-2128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:313 — selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:313-317 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1623-1627 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:313` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1081 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1081-1085 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1668-1672 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:258 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:258-262 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:626-630 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (5 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:266 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:266-270 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:634-638 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×4
  • Duplicated block (14 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:973 — app/src/main/java/com/luck/pictureselector/MainActivity.java:973-986 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1051-1064 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:973` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:127 — selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:127-140 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/RomUtils.java:125-138 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:127` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:281 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:281-296 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:659-672 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:281` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:572 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:572-585 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:447-460 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:572` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×4
  • Duplicated block (6 lines × 2) selector/src/main/java/com/luck/picture/lib/adapter/holder/PreviewImageHolder.java:28 — selector/src/main/java/com/luck/picture/lib/adapter/holder/PreviewImageHolder.java:28-33 | selector/src/main/java/com/luck/picture/lib/adapter/holder/PreviewVideoHolder.java:67-72 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/adapter/holder/PreviewImageHolder.java:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:148 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:148-153 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:377-382 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:148` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:63 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:63-69 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:491-496 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:519 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:519-524 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:529-534 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:519` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:184 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:184-196 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:241-253 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:184` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/PSEglUtils.java:60 — selector/src/main/java/com/luck/picture/lib/utils/PSEglUtils.java:60-72 | ucrop/src/main/java/com/yalantis/ucrop/util/EglUtils.java:58-70 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/PSEglUtils.java:60` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:244 — selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:244-256 | compress/src/main/java/top/zibin/luban/LubanUtils.java:50-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:244` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D1 · Cyclomatic Complexity · LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18) · ×2
  • LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:111 — LightStatusBarUtils.setAndroidNativeLightStatusBar has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
  • LightStatusBarUtils.setAndroidNativeLightStatusBar (cyclomatic 18) ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:111 — LightStatusBarUtils.setAndroidNativeLightStatusBar has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · LightStatusBarUtils.setAndroidNativeLightStatusBar (cognitive 39) · ×2
  • LightStatusBarUtils.setAndroidNativeLightStatusBar (cognitive 39) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:111 — LightStatusBarUtils.setAndroidNativeLightStatusBar has cognitive complexity 39 (threshold 15). Drivers by points: if/else 31, boolean chains 7, error handling 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • LightStatusBarUtils.setAndroidNativeLightStatusBar (cognitive 39) ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:111 — LightStatusBarUtils.setAndroidNativeLightStatusBar has cognitive complexity 39 (threshold 15). Drivers by points: if/else 31, boolean chains 7, error handling 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BitmapUtils.computeSize (cognitive 16) · ×2
  • BitmapUtils.computeSize (cognitive 16) camerax/src/main/java/com/luck/lib/camerax/utils/BitmapUtils.java:27 — BitmapUtils.computeSize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, ternaries 5, boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
  • BitmapUtils.computeSize (cognitive 16) selector/src/main/java/com/luck/picture/lib/utils/BitmapUtils.java:195 — BitmapUtils.computeSize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, ternaries 5, boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×2
  • Duplicated block (17 lines × 2) selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:156 — selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:156-172 | selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:182-198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:156` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:528 — ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:528-544 | ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:403-419 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:528` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:142 — selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:142-157 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:142-157 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:142` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:95 — selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:95-110 | selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:208-223 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:95` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) app/src/main/java/com/luck/pictureselector/MainActivity.java:1433 — app/src/main/java/com/luck/pictureselector/MainActivity.java:1433-1447 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1560-1574 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:1433` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:40 — selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:40-54 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/LightStatusBarUtils.java:40-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/LightStatusBarUtils.java:40` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×2
  • Duplicated block (12 lines × 3) camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:222 — camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:222-233 | selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:342-353 | ucrop/src/main/java/com/yalantis/ucrop/util/FileUtils.java:500-511 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/FileUtils.java:222` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:658 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:658-669 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:717-728 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1514-1525 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×2
  • Duplicated block (10 lines × 3) app/src/main/java/com/luck/pictureselector/MainActivity.java:1420 — app/src/main/java/com/luck/pictureselector/MainActivity.java:1420-1429 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1547-1556 | app/src/main/java/com/luck/pictureselector/MainActivity.java:1605-1614 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `app/src/main/java/com/luck/pictureselector/MainActivity.java:1420` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 3) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:783 — selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:783-792 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1464-1473 | selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionSystemModel.java:459-468 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionCameraModel.java:783` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×2
  • Duplicated block (6 lines × 3) app/src/main/java/com/luck/pictureselector/MainActivity.java:337 — app/src/main/java/com/luck/pictureselector/MainActivity.java:337-342 | app/src/main/java/com/luck/pictureselector/MainActivity.java:346-351 | app/src/main/java/com/luck/pictureselector/MainActivity.java:356-361 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (6 lines × 3) selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:76 — selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:76-81 | selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:132-137 | selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:205-210 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:76` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×2
  • Duplicated block (5 lines × 3) selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:174 — selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:174-178 | selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:202-206 | selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:214-218 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/IBridgeMediaLoader.java:174` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:88 — selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:88-93 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:107-111 | selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:123-127 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:88` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D1 · Cyclomatic Complexity · PictureCommonFragment.checkOnlyMimeTypeValidity (cyclomatic 46) · ×1
  • PictureCommonFragment.checkOnlyMimeTypeValidity (cyclomatic 46) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:594 — PictureCommonFragment.checkOnlyMimeTypeValidity has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PictureCommonFragment.checkWithMimeTypeValidity (cyclomatic 35) · ×1
  • PictureCommonFragment.checkWithMimeTypeValidity (cyclomatic 35) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:473 — PictureCommonFragment.checkWithMimeTypeValidity has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LocalMediaPageLoader.parseLocalMedia (cyclomatic 34) · ×1
  • LocalMediaPageLoader.parseLocalMedia (cyclomatic 34) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:625 — LocalMediaPageLoader.parseLocalMedia has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SandboxFileLoader.loadInAppSandboxFile (cyclomatic 34) · ×1
  • SandboxFileLoader.loadInAppSandboxFile (cyclomatic 34) selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java:62 — SandboxFileLoader.loadInAppSandboxFile has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LocalMediaLoader.parseLocalMedia (cyclomatic 28) · ×1
  • LocalMediaLoader.parseLocalMedia (cyclomatic 28) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:257 — LocalMediaLoader.parseLocalMedia has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 3.doInBackground (cyclomatic 28) · ×1
  • 3.doInBackground (cyclomatic 28) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:265 — 3.doInBackground has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MainActivity.onCheckedChanged (cyclomatic 26) · ×1
  • MainActivity.onCheckedChanged (cyclomatic 26) app/src/main/java/com/luck/pictureselector/MainActivity.java:2210 — MainActivity.onCheckedChanged has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PictureCommonFragment.checkCompleteSelectLimit (cyclomatic 26) · ×1
  • PictureCommonFragment.checkCompleteSelectLimit (cyclomatic 26) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1278 — PictureCommonFragment.checkCompleteSelectLimit has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CompleteSelectView.setSelectedChange (cyclomatic 25) · ×1
  • CompleteSelectView.setSelectedChange (cyclomatic 25) selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:119 — CompleteSelectView.setSelectedChange has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Checker.getOrientation (cyclomatic 25) · ×1
  • Checker.getOrientation (cyclomatic 25) compress/src/main/java/top/zibin/luban/Checker.java:59 — Checker.getOrientation has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BottomNavBar.setBottomNavBarStyle (cyclomatic 23) · ×1
  • BottomNavBar.setBottomNavBarStyle (cyclomatic 23) selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:85 — BottomNavBar.setBottomNavBarStyle has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PictureCacheManager.deleteAllCacheDirFile (cyclomatic 22) · ×1
  • PictureCacheManager.deleteAllCacheDirFile (cyclomatic 22) selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:144 — PictureCacheManager.deleteAllCacheDirFile has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 1.doInBackground (cyclomatic 22) · ×1
  • 1.doInBackground (cyclomatic 22) selector/src/main/java/com/luck/picture/lib/utils/DownloadFileUtils.java:42 — 1.doInBackground has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TitleBar.setTitleBarStyle (cyclomatic 22) · ×1
  • TitleBar.setTitleBarStyle (cyclomatic 22) selector/src/main/java/com/luck/picture/lib/widget/TitleBar.java:132 — TitleBar.setTitleBarStyle has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PictureSelectorPreviewFragment.initComplete (cyclomatic 21) · ×1
  • PictureSelectorPreviewFragment.initComplete (cyclomatic 21) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:623 — PictureSelectorPreviewFragment.initComplete has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PictureCommonFragment.onActivityResult (cyclomatic 20) · ×1
  • PictureCommonFragment.onActivityResult (cyclomatic 20) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1066 — PictureCommonFragment.onActivityResult has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PermissionConfig.getReadPermissionArray (cyclomatic 20) · ×1
  • PermissionConfig.getReadPermissionArray (cyclomatic 20) selector/src/main/java/com/luck/picture/lib/permissions/PermissionConfig.java:43 — PermissionConfig.getReadPermissionArray has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ImageHeaderParser.parseExifSegment (cyclomatic 20) · ×1
  • ImageHeaderParser.parseExifSegment (cyclomatic 20) ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:196 — ImageHeaderParser.parseExifSegment has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EventHandler.handleMessage (cyclomatic 19) · ×1
  • EventHandler.handleMessage (cyclomatic 19) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:970 — EventHandler.handleMessage has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · IjkVideoTextureView.onMeasure (cyclomatic 18) · ×1
  • IjkVideoTextureView.onMeasure (cyclomatic 18) app/src/main/java/com/luck/pictureselector/IjkPlayerView.java:148 — IjkVideoTextureView.onMeasure has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CustomGestureDetector.processTouchEvent (cyclomatic 18) · ×1
  • CustomGestureDetector.processTouchEvent (cyclomatic 18) selector/src/main/java/com/luck/picture/lib/photoview/CustomGestureDetector.java:108 — CustomGestureDetector.processTouchEvent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BufferedInputStreamWrap.read (cyclomatic 18) · ×1
  • BufferedInputStreamWrap.read (cyclomatic 18) compress/src/main/java/top/zibin/luban/io/BufferedInputStreamWrap.java:242 — BufferedInputStreamWrap.read has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PhotoViewAttacher.onTouch (cyclomatic 17) · ×1
  • PhotoViewAttacher.onTouch (cyclomatic 17) selector/src/main/java/com/luck/picture/lib/photoview/PhotoViewAttacher.java:325 — PhotoViewAttacher.onTouch has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VideoSurfaceView.onMeasure (cyclomatic 17) · ×1
  • VideoSurfaceView.onMeasure (cyclomatic 17) selector/src/main/java/com/luck/picture/lib/widget/MediaPlayerView.java:146 — VideoSurfaceView.onMeasure has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PictureSelectorFragment.mergeFolder (cyclomatic 16) · ×1
  • PictureSelectorFragment.mergeFolder (cyclomatic 16) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:1182 — PictureSelectorFragment.mergeFolder has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · IjkMediaCodecInfo.setupCandidate (cyclomatic 16) · ×1
  • IjkMediaCodecInfo.setupCandidate (cyclomatic 16) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaCodecInfo.java:138 — IjkMediaCodecInfo.setupCandidate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D16 · Bus Factor · dormant codebase · ×1
  • dormant codebase — no living knowledge left to concentrate — All 140 significant source file(s) were last meaningfully changed so long ago that no living knowledge remains — nothing since has been substantial enough to re-establish ownership (a broad, mechanical sweep that touches many files shallowly does not count, and neither does no activity at all). There is no concentration to measure, so the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness).
D2 · Cognitive Complexity · PictureCommonFragment.checkOnlyMimeTypeValidity (cognitive 129) · ×1
  • PictureCommonFragment.checkOnlyMimeTypeValidity (cognitive 129) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:594 — PictureCommonFragment.checkOnlyMimeTypeValidity has cognitive complexity 129 (threshold 15). Drivers by points: if/else 119, boolean chains 7, ternaries 3 (nesting depth added 83). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 3.doInBackground (cognitive 97) · ×1
  • 3.doInBackground (cognitive 97) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:265 — 3.doInBackground has cognitive complexity 97 (threshold 15). Drivers by points: if/else 68, ternaries 15, loops 12, boolean chains 1, error handling 1 (nesting depth added 66). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.checkWithMimeTypeValidity (cognitive 95) · ×1
  • PictureCommonFragment.checkWithMimeTypeValidity (cognitive 95) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:473 — PictureCommonFragment.checkWithMimeTypeValidity has cognitive complexity 95 (threshold 15). Drivers by points: if/else 90, boolean chains 5 (nesting depth added 61). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SandboxFileLoader.loadInAppSandboxFile (cognitive 93) · ×1
  • SandboxFileLoader.loadInAppSandboxFile (cognitive 93) selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java:62 — SandboxFileLoader.loadInAppSandboxFile has cognitive complexity 93 (threshold 15). Drivers by points: if/else 80, boolean chains 6, ternaries 3, error handling 2, loops 2 (nesting depth added 58). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.checkCompleteSelectLimit (cognitive 68) · ×1
  • PictureCommonFragment.checkCompleteSelectLimit (cognitive 68) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1278 — PictureCommonFragment.checkCompleteSelectLimit has cognitive complexity 68 (threshold 15). Drivers by points: if/else 62, boolean chains 4, loops 2 (nesting depth added 41). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CompleteSelectView.setSelectedChange (cognitive 68) · ×1
  • CompleteSelectView.setSelectedChange (cognitive 68) selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:119 — CompleteSelectView.setSelectedChange has cognitive complexity 68 (threshold 15). Drivers by points: if/else 62, ternaries 4, boolean chains 2 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.onActivityResult (cognitive 66) · ×1
  • PictureCommonFragment.onActivityResult (cognitive 66) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1066 — PictureCommonFragment.onActivityResult has cognitive complexity 66 (threshold 15). Drivers by points: if/else 45, ternaries 9, loops 7, error handling 5 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCacheManager.deleteAllCacheDirFile (cognitive 66) · ×1
  • PictureCacheManager.deleteAllCacheDirFile (cognitive 66) selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:144 — PictureCacheManager.deleteAllCacheDirFile has cognitive complexity 66 (threshold 15). Drivers by points: if/else 57, loops 9 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IjkMediaCodecInfo.setupCandidate (cognitive 53) · ×1
  • IjkMediaCodecInfo.setupCandidate (cognitive 53) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaCodecInfo.java:138 — IjkMediaCodecInfo.setupCandidate has cognitive complexity 53 (threshold 15). Drivers by points: if/else 42, error handling 10, boolean chains 1 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PermissionConfig.getReadPermissionArray (cognitive 52) · ×1
  • PermissionConfig.getReadPermissionArray (cognitive 52) selector/src/main/java/com/luck/picture/lib/permissions/PermissionConfig.java:43 — PermissionConfig.getReadPermissionArray has cognitive complexity 52 (threshold 15). Drivers by points: if/else 26, ternaries 26 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalMediaPageLoader.parseLocalMedia (cognitive 46) · ×1
  • LocalMediaPageLoader.parseLocalMedia (cognitive 46) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:625 — LocalMediaPageLoader.parseLocalMedia has cognitive complexity 46 (threshold 15). Drivers by points: if/else 36, boolean chains 7, ternaries 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.doInBackground (cognitive 46) · ×1
  • 1.doInBackground (cognitive 46) selector/src/main/java/com/luck/picture/lib/utils/DownloadFileUtils.java:42 — 1.doInBackground has cognitive complexity 46 (threshold 15). Drivers by points: if/else 21, ternaries 20, boolean chains 4, error handling 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.doInBackground (cognitive 39) · ×1
  • 1.doInBackground (cognitive 39) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:96 — 1.doInBackground has cognitive complexity 39 (threshold 15). Drivers by points: if/else 29, ternaries 5, loops 3, boolean chains 1, error handling 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageHeaderParser.parseExifSegment (cognitive 39) · ×1
  • ImageHeaderParser.parseExifSegment (cognitive 39) ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:196 — ImageHeaderParser.parseExifSegment has cognitive complexity 39 (threshold 15). Drivers by points: if/else 35, boolean chains 3, loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BufferedInputStreamWrap.read (cognitive 38) · ×1
  • BufferedInputStreamWrap.read (cognitive 38) compress/src/main/java/top/zibin/luban/io/BufferedInputStreamWrap.java:242 — BufferedInputStreamWrap.read has cognitive complexity 38 (threshold 15). Drivers by points: if/else 27, ternaries 8, boolean chains 2, loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalMediaLoader.parseLocalMedia (cognitive 37) · ×1
  • LocalMediaLoader.parseLocalMedia (cognitive 37) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaLoader.java:257 — LocalMediaLoader.parseLocalMedia has cognitive complexity 37 (threshold 15). Drivers by points: if/else 29, boolean chains 6, ternaries 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IjkVideoTextureView.onMeasure (cognitive 36) · ×1
  • IjkVideoTextureView.onMeasure (cognitive 36) app/src/main/java/com/luck/pictureselector/IjkPlayerView.java:148 — IjkVideoTextureView.onMeasure has cognitive complexity 36 (threshold 15). Drivers by points: if/else 30, boolean chains 6 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MainActivity.onCheckedChanged (cognitive 36) · ×1
  • MainActivity.onCheckedChanged (cognitive 36) app/src/main/java/com/luck/pictureselector/MainActivity.java:2210 — MainActivity.onCheckedChanged has cognitive complexity 36 (threshold 15). Drivers by points: ternaries 26, if/else 9, match/switch 1 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · VideoSurfaceView.onMeasure (cognitive 35) · ×1
  • VideoSurfaceView.onMeasure (cognitive 35) selector/src/main/java/com/luck/picture/lib/widget/MediaPlayerView.java:146 — VideoSurfaceView.onMeasure has cognitive complexity 35 (threshold 15). Drivers by points: if/else 29, boolean chains 6 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TitleBar.setTitleBarStyle (cognitive 35) · ×1
  • TitleBar.setTitleBarStyle (cognitive 35) selector/src/main/java/com/luck/picture/lib/widget/TitleBar.java:132 — TitleBar.setTitleBarStyle has cognitive complexity 35 (threshold 15). Drivers by points: if/else 32, ternaries 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Checker.getOrientation (cognitive 34) · ×1
  • Checker.getOrientation (cognitive 34) compress/src/main/java/top/zibin/luban/Checker.java:59 — Checker.getOrientation has cognitive complexity 34 (threshold 15). Drivers by points: if/else 19, boolean chains 8, match/switch 4, loops 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectorPreviewFragment.initComplete (cognitive 33) · ×1
  • PictureSelectorPreviewFragment.initComplete (cognitive 33) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:623 — PictureSelectorPreviewFragment.initComplete has cognitive complexity 33 (threshold 15). Drivers by points: if/else 33 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureFileUtils.deleteAllCacheDirFile (cognitive 30) · ×1
  • PictureFileUtils.deleteAllCacheDirFile (cognitive 30) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:400 — PictureFileUtils.deleteAllCacheDirFile has cognitive complexity 30 (threshold 15). Drivers by points: if/else 21, loops 9 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FileUtils.getPath (cognitive 30) · ×1
  • FileUtils.getPath (cognitive 30) ucrop/src/main/java/com/yalantis/ucrop/util/FileUtils.java:351 — FileUtils.getPath has cognitive complexity 30 (threshold 15). Drivers by points: if/else 24, error handling 5, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 3.openPicture (cognitive 29) · ×1
  • 3.openPicture (cognitive 29) app/src/main/java/com/luck/pictureselector/MainActivity.java:445 — 3.openPicture has cognitive complexity 29 (threshold 15). Drivers by points: ternaries 24, if/else 5 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseRecyclerMediaHolder.dispatchHandleMask (cognitive 29) · ×1
  • BaseRecyclerMediaHolder.dispatchHandleMask (cognitive 29) selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:231 — BaseRecyclerMediaHolder.dispatchHandleMask has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21, ternaries 5, boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CustomGestureDetector.processTouchEvent (cognitive 29) · ×1
  • CustomGestureDetector.processTouchEvent (cognitive 29) selector/src/main/java/com/luck/picture/lib/photoview/CustomGestureDetector.java:108 — CustomGestureDetector.processTouchEvent has cognitive complexity 29 (threshold 15). Drivers by points: if/else 24, ternaries 4, match/switch 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MyImageResultCallback.onImageSaved (cognitive 28) · ×1
  • MyImageResultCallback.onImageSaved (cognitive 28) camerax/src/main/java/com/luck/lib/camerax/CustomCameraView.java:927 — MyImageResultCallback.onImageSaved has cognitive complexity 28 (threshold 15). Drivers by points: if/else 22, ternaries 4, boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PhotoViewAttacher.onTouch (cognitive 28) · ×1
  • PhotoViewAttacher.onTouch (cognitive 28) selector/src/main/java/com/luck/picture/lib/photoview/PhotoViewAttacher.java:325 — PhotoViewAttacher.onTouch has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21, boolean chains 5, match/switch 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BottomNavBar.setBottomNavBarStyle (cognitive 28) · ×1
  • BottomNavBar.setBottomNavBarStyle (cognitive 28) selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:85 — BottomNavBar.setBottomNavBarStyle has cognitive complexity 28 (threshold 15). Drivers by points: if/else 23, ternaries 5 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · 1.onPageSelected (cognitive 28) · ×1
  • 1.onPageSelected (cognitive 28) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:1437 — 1.onPageSelected has cognitive complexity 28 (threshold 15). Drivers by points: if/else 24, boolean chains 4 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UCropMultipleActivity.initCropFragments (cognitive 27) · ×1
  • UCropMultipleActivity.initCropFragments (cognitive 27) ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java:107 — UCropMultipleActivity.initCropFragments has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11, ternaries 11, boolean chains 4, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.checkCropValidity (cognitive 26) · ×1
  • PictureCommonFragment.checkCropValidity (cognitive 26) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1502 — PictureCommonFragment.checkCropValidity has cognitive complexity 26 (threshold 15). Drivers by points: if/else 22, loops 3, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.checkOldCropValidity (cognitive 26) · ×1
  • PictureCommonFragment.checkOldCropValidity (cognitive 26) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1535 — PictureCommonFragment.checkOldCropValidity has cognitive complexity 26 (threshold 15). Drivers by points: if/else 22, loops 3, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureFileUtils.getPath (cognitive 26) · ×1
  • PictureFileUtils.getPath (cognitive 26) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:231 — PictureFileUtils.getPath has cognitive complexity 26 (threshold 15). Drivers by points: if/else 25, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LubanUtils.getPath (cognitive 26) · ×1
  • LubanUtils.getPath (cognitive 26) compress/src/main/java/top/zibin/luban/LubanUtils.java:37 — LubanUtils.getPath has cognitive complexity 26 (threshold 15). Drivers by points: if/else 25, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Task.run (cognitive 25) · ×1
  • Task.run (cognitive 25) selector/src/main/java/com/luck/picture/lib/thread/PictureThreadUtils.java:1194 — Task.run has cognitive complexity 25 (threshold 15). Drivers by points: if/else 23, error handling 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RecyclerPreloadView.onScrolled (cognitive 25) · ×1
  • RecyclerPreloadView.onScrolled (cognitive 25) selector/src/main/java/com/luck/picture/lib/widget/RecyclerPreloadView.java:96 — RecyclerPreloadView.onScrolled has cognitive complexity 25 (threshold 15). Drivers by points: if/else 25 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 1.doInBackground (cognitive 23) · ×1
  • 1.doInBackground (cognitive 23) selector/src/main/java/com/luck/picture/lib/loader/LocalMediaPageLoader.java:183 — 1.doInBackground has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15, loops 3, boolean chains 2, ternaries 2, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCacheManager.deleteCacheDirFile (cognitive 23) · ×1
  • PictureCacheManager.deleteCacheDirFile (cognitive 23) selector/src/main/java/com/luck/picture/lib/manager/PictureCacheManager.java:83 — PictureCacheManager.deleteCacheDirFile has cognitive complexity 23 (threshold 15). Drivers by points: if/else 19, loops 3, ternaries 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BottomNavBar.setSelectedChange (cognitive 23) · ×1
  • BottomNavBar.setSelectedChange (cognitive 23) selector/src/main/java/com/luck/picture/lib/widget/BottomNavBar.java:185 — BottomNavBar.setSelectedChange has cognitive complexity 23 (threshold 15). Drivers by points: if/else 19, ternaries 4 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlideSelectTouchListener.processAutoScroll (cognitive 23) · ×1
  • SlideSelectTouchListener.processAutoScroll (cognitive 23) selector/src/main/java/com/luck/picture/lib/widget/SlideSelectTouchListener.java:256 — SlideSelectTouchListener.processAutoScroll has cognitive complexity 23 (threshold 15). Drivers by points: if/else 19, boolean chains 4 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectorFragment.checkNotifyStrategy (cognitive 23) · ×1
  • PictureSelectorFragment.checkNotifyStrategy (cognitive 23) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:188 — PictureSelectorFragment.checkNotifyStrategy has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10, boolean chains 8, ternaries 5 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageHeaderParser.moveToExifSegmentAndGetLength (cognitive 23) · ×1
  • ImageHeaderParser.moveToExifSegmentAndGetLength (cognitive 23) ucrop/src/main/java/com/yalantis/ucrop/util/ImageHeaderParser.java:153 — ImageHeaderParser.moveToExifSegmentAndGetLength has cognitive complexity 23 (threshold 15). Drivers by points: if/else 22, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultMediaCodecSelector.onMediaCodecSelect (cognitive 23) · ×1
  • DefaultMediaCodecSelector.onMediaCodecSelect (cognitive 23) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:1224 — DefaultMediaCodecSelector.onMediaCodecSelect has cognitive complexity 23 (threshold 15). Drivers by points: if/else 19, loops 4 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImmersiveManager.immersiveAboveAPI23 (cognitive 22) · ×1
  • ImmersiveManager.immersiveAboveAPI23 (cognitive 22) selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:44 — ImmersiveManager.immersiveAboveAPI23 has cognitive complexity 22 (threshold 15). Drivers by points: if/else 17, boolean chains 4, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureFileUtils.formatFileSize (cognitive 22) · ×1
  • PictureFileUtils.formatFileSize (cognitive 22) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:520 — PictureFileUtils.formatFileSize has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 17, if/else 5 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseRecyclerMediaHolder.<init> (cognitive 21) · ×1
  • BaseRecyclerMediaHolder.<init> (cognitive 21) selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:63 — BaseRecyclerMediaHolder.<init> has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12, loops 6, boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectorFragment.mergeFolder (cognitive 21) · ×1
  • PictureSelectorFragment.mergeFolder (cognitive 21) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:1182 — PictureSelectorFragment.mergeFolder has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12, ternaries 5, boolean chains 3, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PictureSelectorFragment.onStartPreview (cognitive 21) · ×1
  • PictureSelectorFragment.onStartPreview (cognitive 21) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:977 — PictureSelectorFragment.onStartPreview has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13, ternaries 7, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridImageAdapter.onBindViewHolder (cognitive 20) · ×1
  • GridImageAdapter.onBindViewHolder (cognitive 20) app/src/main/java/com/luck/pictureselector/adapter/GridImageAdapter.java:128 — GridImageAdapter.onBindViewHolder has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13, ternaries 5, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PermissionUtil.isAllGranted (cognitive 20) · ×1
  • PermissionUtil.isAllGranted (cognitive 20) selector/src/main/java/com/luck/picture/lib/permissions/PermissionUtil.java:87 — PermissionUtil.isAllGranted has cognitive complexity 20 (threshold 15). Drivers by points: if/else 17, loops 2, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BitmapCropTask.crop (cognitive 20) · ×1
  • BitmapCropTask.crop (cognitive 20) ucrop/src/main/java/com/yalantis/ucrop/task/BitmapCropTask.java:117 — BitmapCropTask.crop has cognitive complexity 20 (threshold 15). Drivers by points: if/else 17, boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PermissionChecker.requestPermissions (cognitive 19) · ×1
  • PermissionChecker.requestPermissions (cognitive 19) selector/src/main/java/com/luck/picture/lib/permissions/PermissionChecker.java:60 — PermissionChecker.requestPermissions has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14, loops 5 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureFileUtils.createOutFile (cognitive 19) · ×1
  • PictureFileUtils.createOutFile (cognitive 19) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:84 — PictureFileUtils.createOutFile has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10, ternaries 8, match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 7.onItemClick (cognitive 19) · ×1
  • 7.onItemClick (cognitive 19) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:519 — 7.onItemClick has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14, boolean chains 3, ternaries 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImmersiveManager.immersiveAboveAPI23 (cognitive 19) · ×1
  • ImmersiveManager.immersiveAboveAPI23 (cognitive 19) ucrop/src/main/java/com/yalantis/ucrop/statusbar/ImmersiveManager.java:45 — ImmersiveManager.immersiveAboveAPI23 has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15, boolean chains 3, error handling 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FullyGridLayoutManager.onMeasure (cognitive 18) · ×1
  • FullyGridLayoutManager.onMeasure (cognitive 18) app/src/main/java/com/luck/pictureselector/FullyGridLayoutManager.java:29 — FullyGridLayoutManager.onMeasure has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15, match/switch 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PermissionChecker.requestPermissions (cognitive 18) · ×1
  • PermissionChecker.requestPermissions (cognitive 18) camerax/src/main/java/com/luck/lib/camerax/permissions/PermissionChecker.java:62 — PermissionChecker.requestPermissions has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13, loops 5 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.confirmSelect (cognitive 18) · ×1
  • PictureCommonFragment.confirmSelect (cognitive 18) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:398 — PictureCommonFragment.confirmSelect has cognitive complexity 18 (threshold 15). Drivers by points: if/else 18 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectionPreviewModel.startFragmentPreview (cognitive 18) · ×1
  • PictureSelectionPreviewModel.startFragmentPreview (cognitive 18) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionPreviewModel.java:328 — PictureSelectionPreviewModel.startFragmentPreview has cognitive complexity 18 (threshold 15). Drivers by points: if/else 16, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectorFragment.initComplete (cognitive 18) · ×1
  • PictureSelectorFragment.initComplete (cognitive 18) selector/src/main/java/com/luck/picture/lib/PictureSelectorFragment.java:280 — PictureSelectorFragment.initComplete has cognitive complexity 18 (threshold 15). Drivers by points: if/else 17, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 13.onItemClick (cognitive 18) · ×1
  • 13.onItemClick (cognitive 18) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:837 — 13.onItemClick has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8, ternaries 6, boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 14.clearView (cognitive 18) · ×1
  • 14.clearView (cognitive 18) selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:956 — 14.clearView has cognitive complexity 18 (threshold 15). Drivers by points: if/else 14, loops 3, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BitmapLoadTask.doInBackground (cognitive 18) · ×1
  • BitmapLoadTask.doInBackground (cognitive 18) ucrop/src/main/java/com/yalantis/ucrop/task/BitmapLoadTask.java:80 — BitmapLoadTask.doInBackground has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10, error handling 6, boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · UCropActivity.processOptions (cognitive 18) · ×1
  • UCropActivity.processOptions (cognitive 18) ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java:243 — UCropActivity.processOptions has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8, ternaries 6, boolean chains 4 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UCropFragment.processOptions (cognitive 18) · ×1
  • UCropFragment.processOptions (cognitive 18) ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java:219 — UCropFragment.processOptions has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8, ternaries 6, boolean chains 4 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 2.onClick (cognitive 17) · ×1
  • 2.onClick (cognitive 17) selector/src/main/java/com/luck/picture/lib/adapter/holder/BaseRecyclerMediaHolder.java:157 — 2.onClick has cognitive complexity 17 (threshold 15). Drivers by points: if/else 17 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureSelectionModel.setQueryOnlyMimeType (cognitive 17) · ×1
  • PictureSelectionModel.setQueryOnlyMimeType (cognitive 17) selector/src/main/java/com/luck/picture/lib/basic/PictureSelectionModel.java:1095 — PictureSelectionModel.setQueryOnlyMimeType has cognitive complexity 17 (threshold 15). Drivers by points: if/else 16, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BuildRecycleItemViewParams.generateViewParams (cognitive 17) · ×1
  • BuildRecycleItemViewParams.generateViewParams (cognitive 17) selector/src/main/java/com/luck/picture/lib/magical/BuildRecycleItemViewParams.java:33 — BuildRecycleItemViewParams.generateViewParams has cognitive complexity 17 (threshold 15). Drivers by points: if/else 14, loops 2, ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IjkMediaMeta.parse (cognitive 17) · ×1
  • IjkMediaMeta.parse (cognitive 17) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaMeta.java:193 — IjkMediaMeta.parse has cognitive complexity 17 (threshold 15). Drivers by points: if/else 16, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImageViewHolder.<init> (cognitive 16) · ×1
  • ImageViewHolder.<init> (cognitive 16) selector/src/main/java/com/luck/picture/lib/adapter/holder/ImageViewHolder.java:26 — ImageViewHolder.<init> has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10, loops 6 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · PictureCommonFragment.startCameraImageCapture (cognitive 16) · ×1
  • PictureCommonFragment.startCameraImageCapture (cognitive 16) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:902 — PictureCommonFragment.startCameraImageCapture has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PictureCommonFragment.startCameraVideoCapture (cognitive 16) · ×1
  • PictureCommonFragment.startCameraVideoCapture (cognitive 16) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:949 — PictureCommonFragment.startCameraVideoCapture has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 10.onCallback (cognitive 16) · ×1
  • 10.onCallback (cognitive 16) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1457 — 10.onCallback has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BitmapUtils.rotateImage (cognitive 16) · ×1
  • BitmapUtils.rotateImage (cognitive 16) selector/src/main/java/com/luck/picture/lib/utils/BitmapUtils.java:34 — BitmapUtils.rotateImage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14, boolean chains 1, error handling 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FileDirMap.init (cognitive 16) · ×1
  • FileDirMap.init (cognitive 16) selector/src/main/java/com/luck/picture/lib/utils/FileDirMap.java:19 — FileDirMap.init has cognitive complexity 16 (threshold 15). Drivers by points: if/else 13, boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CompleteSelectView.setCompleteSelectViewStyle (cognitive 16) · ×1
  • CompleteSelectView.setCompleteSelectViewStyle (cognitive 16) selector/src/main/java/com/luck/picture/lib/widget/CompleteSelectView.java:68 — CompleteSelectView.setCompleteSelectViewStyle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 15, ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlideSelectTouchListener.notifySelectRangeChange (cognitive 16) · ×1
  • SlideSelectTouchListener.notifySelectRangeChange (cognitive 16) selector/src/main/java/com/luck/picture/lib/widget/SlideSelectTouchListener.java:302 — SlideSelectTouchListener.notifySelectRangeChange has cognitive complexity 16 (threshold 15). Drivers by points: if/else 14, boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · BitmapLoadUtils.computeSize (cognitive 16) · ×1
  • BitmapLoadUtils.computeSize (cognitive 16) ucrop/src/main/java/com/yalantis/ucrop/util/BitmapLoadUtils.java:80 — BitmapLoadUtils.computeSize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, ternaries 5, boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · UCropMultipleActivity.onCropFinish (cognitive 16) · ×1
  • UCropMultipleActivity.onCropFinish (cognitive 16) ucrop/src/main/java/com/yalantis/ucrop/UCropMultipleActivity.java:357 — UCropMultipleActivity.onCropFinish has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12, loops 3, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Engine.computeSize (cognitive 16) · ×1
  • Engine.computeSize (cognitive 16) compress/src/main/java/top/zibin/luban/Engine.java:36 — Engine.computeSize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, ternaries 5, boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · EventHandler.handleMessage (cognitive 16) · ×1
  • EventHandler.handleMessage (cognitive 16) ijkplayer-java/src/main/java/tv/danmaku/ijk/media/player/IjkMediaPlayer.java:970 — EventHandler.handleMessage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12, match/switch 3, boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · Medium · ×1
  • Medium: use-of-md5 selector/src/main/java/com/luck/picture/lib/loader/SandboxFileLoader.java:81 — Detected MD5 hash algorithm which is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature. Use HMAC instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:36 — selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:36-54 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/RomUtils.java:34-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/RomUtils.java:36` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1
  • Duplicated block (18 lines × 2) selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:88 — selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:88-105 | ucrop/src/main/java/com/yalantis/ucrop/statusbar/ImmersiveManager.java:89-106 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/immersive/ImmersiveManager.java:88` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:278 — selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:278-292 | ucrop/src/main/java/com/yalantis/ucrop/util/FileUtils.java:400-414 | compress/src/main/java/top/zibin/luban/LubanUtils.java:84-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:278` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:195 — selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:195-205 | ucrop/src/main/java/com/yalantis/ucrop/util/FileUtils.java:315-325 | compress/src/main/java/top/zibin/luban/LubanUtils.java:122-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/utils/PictureFileUtils.java:195` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) camerax/src/main/java/com/luck/lib/camerax/utils/BitmapUtils.java:36 — camerax/src/main/java/com/luck/lib/camerax/utils/BitmapUtils.java:36-45 | selector/src/main/java/com/luck/picture/lib/utils/BitmapUtils.java:204-213 | ucrop/src/main/java/com/yalantis/ucrop/util/BitmapLoadUtils.java:89-98 | compress/src/main/java/top/zibin/luban/Engine.java:45-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `camerax/src/main/java/com/luck/lib/camerax/utils/BitmapUtils.java:36` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×1
  • Duplicated block (6 lines × 4) app/src/main/java/com/luck/pictureselector/CustomLoadingDialog.java:26 — app/src/main/java/com/luck/pictureselector/CustomLoadingDialog.java:26-31 | selector/src/main/java/com/luck/picture/lib/dialog/PictureCommonDialog.java:42-47 | selector/src/main/java/com/luck/picture/lib/dialog/PictureLoadingDialog.java:28-33 | selector/src/main/java/com/luck/picture/lib/dialog/RemindDialog.java:58-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:778 — selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:778-782 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:791-795 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:804-808 | selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:1972-1976 | selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java:988-992 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java:778` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Recommendation — 7 finding(s)
D34 · Knowledge Freshness · Largest orphaned file · ×3
  • Largest orphaned file app/src/main/java/com/luck/pictureselector/MainActivity.java — One of the largest files with no living knowledge remaining — a reasonable place to start a read-through before the aggregate risk above bites.
  • Largest orphaned file selector/src/main/java/com/luck/picture/lib/basic/PictureCommonFragment.java — One of the largest files with no living knowledge remaining — a reasonable place to start a read-through before the aggregate risk above bites.
  • Largest orphaned file selector/src/main/java/com/luck/picture/lib/PictureSelectorPreviewFragment.java — One of the largest files with no living knowledge remaining — a reasonable place to start a read-through before the aggregate risk above bites.
D11 · Test Reliability · Test reliability not included · ×1
  • Test reliability not included — Test source is present (.java) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D19 · Documentation Quality · The Contents outline lists Usage as a section, but the visible text only shows Download and Permission; no Usage content appears in the clipped document. · ×1
  • The Contents outline lists Usage as a section, but the visible text only shows Download and Permission; no Usage content appears in the clipped document. README.md — Add a short Usage section covering how to add PictureSelector to an Android project (Kotlin/Java) and call its main API.
D34 · Knowledge Freshness · Dormant codebase · ×1
  • Dormant codebase — 146 of 146 significant files have no living knowledge — the codebase as a whole is dormant, not 146 separate risks. Re-engage owners or document before change.
D8 · Code Coverage · Coverage not included · ×1
  • Coverage not included — suite not readable by the collector — Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored.
Info — 2 finding(s)
D12 · Dependency Hygiene · Dependency hygiene not measured · ×1
  • Dependency hygiene not measured — dependency manifest found but not parsed for hygiene — This repository's dependency manifest (a Gradle version catalogue) was found, but this pass cannot parse it for hygiene, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D38 wherever the manifest is OSV-readable.
D22 · Internal API Consistency · No exposed public API · ×1
  • No exposed public API — No intentionally-exposed types (IsPackable or .Contracts) to evaluate.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaksgitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source .1artifacts/raw/gitleaks-history.json
D29 · Static Analysis (SAST)semgrepsemgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --json --quiet --timeout 0 --metrics off .1artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (no readable dependency manifest)none (no readable dependency manifest): not present in this environment0
D31 · IaC & Container Securitytrivytrivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.0
D32 · Data Compliance (PII/GDPR)semgrepsemgrep: not applicable — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.0
D33 · JS/npm Dependency Vulnerabilitiestrivytrivy: not applicable — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.0
D36 · Supply-chain Provenance & Signingprovenanceprovenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, Jenkinsfile, .circleci); there is no build to attest provenance for.0
D37 · Vulnerability-disclosure Policydisclosuredisclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0
D38 · OSV Dependency Vulnerabilitiesosv-scannerosv-scanner: not applicable — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.0
D40 · Network Egress Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0
D41 · Kernel & Syscall Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0
D42 · Runtime Threat Enforcementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0

Run 019fd7f3-07a6-7396-a405-e58125538889 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md