MehrdadShirvani/AlibabaClone-Backend

Executive summary

MehrdadShirvani/AlibabaClone-Backend scores 43 out of 100 and is rated Weak, while six of its seven lenses score higher still: Performance at 100, rated Exemplary, Architecture at 87 and Code Health at 80, both rated Strong, Security and Compliance at 60 and Maturity at 59, both rated Adequate, and Domain Modelling at 47, rated Weak.

The score is lower than those six because the weakest lens counts most, and here that is Production Readiness, which scores 26 and is rated Weak. Its Code Coverage dimension scores 0 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to resolve the 1 No automated tests finding(s) in Code Coverage and to resolve the 1 No tests found finding(s) in Test Distribution, and if Production Readiness rose to 70, the score would rise from 43 to about 57.

22 findings are critical: 13 in Static Analysis (SAST), four in Explicit Debt, one in Code Coverage, one in Dependency Hygiene, one in Dependency Vulnerabilities, one in IaC & Container Security and one in Project dependency cycles.

The product code is 3,821 lines, which would take an estimated 0.1 person-years, around €6,900, to rebuild.

Code Health 80 Strong Architecture 87 Strong Maturity 59 Adequate, capped by Knowledge Freshness Production Readiness 26 Weak, capped by Code Coverage, Test Distribution, Observability and Security & performance tooling Security and Compliance 60 Adequate, capped by Static Analysis (SAST) and Supply-chain Provenance & Signing Domain Modelling 47 Weak, capped by Strongly-typed ids, Rich vs anemic model and Repository granularity Performance 100 ★ Exemplary

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.

Production Readiness 26 · counts for 46%Domain Modelling 47 · counts for 25%Maturity 59 · counts for 14%Security and Compliance 60 · counts for 8%Code Health 80 · counts for 4%Architecture 87 · counts for 2%Performance 100 · counts for 1%

If Production Readiness rose from 26 to 70, the lowest score rated Strong, the score would rise from 43 to about 57.

Code composition: what the lines of code are

Business logic 6%Supporting code 38%Generated by tools 55%

New since the last survey: 24 findings

These 24 critical or serious findings weren't in the previous survey, on 6 October 2026.

Static Analysis (SAST) · REDACTED
Static Analysis (SAST) · REDACTED
Static Analysis (SAST) · REDACTED
Supply-chain Provenance & Signing · REDACTED
Web-Security Posture · Password key derivation is priced too cheaply AlibabaClone.Application/Utils/PasswordHasher.cs
Web-Security Posture · Password key derivation is priced too cheaply AlibabaClone.Application/Utils/PasswordHasher.cs
Cancellation propagation · Async method without CancellationToken: GetProfileAsync AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: GetTravels AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: GetTicketOrderTravelersDetails AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: GetAccountTransactions AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: UpdateEmailAsync AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: UpdatePasswordAsync AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: UpsertBankAccountDetailAsync AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: GetPeople AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: TopUpAccount AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: PayForTicketOrderAsync AlibabaClone.Application/Services/AccountService.cs
Cancellation propagation · Async method without CancellationToken: RegisterAsync AlibabaClone.Application/Services/AuthService.cs
Cancellation propagation · Async method without CancellationToken: LoginAsync AlibabaClone.Application/Services/AuthService.cs
Cancellation propagation · Async method without CancellationToken: GetCitiesAsync AlibabaClone.Application/Services/CityService.cs
Cancellation propagation · Async method without CancellationToken: ValidateCouponAsync AlibabaClone.Application/Services/CouponService.cs
Cancellation propagation · Async method without CancellationToken: UpsertAccountPersonAsync AlibabaClone.Application/Services/PersonService.cs
Cancellation propagation · Async method without CancellationToken: UpsertPersonAsync AlibabaClone.Application/Services/PersonService.cs
Cancellation propagation · Async method without CancellationToken: CreateTicketOrderAsync AlibabaClone.Application/Services/TicketOrderService.cs
Cancellation propagation · Async method without CancellationToken: GenerateTicketsPdfAsync AlibabaClone.Application/Services/TicketOrderService.cs

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 3 findings

These 3 critical or serious findings were in the previous survey, on 6 October 2026, and are gone from this one.

Supply-chain Provenance & Signing REDACTED
Web-Security Posture · Cryptographic key material is a compile-time constant AlibabaClone.Application/Utils/PasswordHasher.cs
Repository granularity · Repository for a non-root entity: AccountRepository → Account AlibabaClone.Infrastructure/Services/AccountAggregates/AccountRepository.cs

Rebuild cost: about €6,900 · Estimate

Cost to rebuild	€2,300 to €11,000, for 38 to 120 hours of work, about 0.1 person-years for one engineer
Difficulty of the problem	High, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor	×0.7 at a score of 43. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size	Small: 3,821 lines of product code, of which 37% is declarations and boilerplate, 49% straight logic and 14% logic with branches

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

Resolve the 1 No automated tests finding(s) in Code Coverage.

Raises the score by about 14 points · Low effort · Code Coverage

Resolve the 1 No tests found finding(s) in Test Distribution.

Raises the score by about 14 points · Low effort · Test Distribution

Resolve the 1 Vulnerable finding(s) in Dependency Hygiene.

Raises the score by about 13 points · Low effort · Dependency Hygiene

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk

This code would cost about €6,900 to build again, about 0.1 person-years of work. Its weakest lens is Production Readiness, at 26 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.

Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts

What to do: Start with the Production Readiness actions in Top priorities.

One cause behind 60 Domain Modelling findings · Common cause

60 findings in the Domain Modelling lens come from the same cause. The code models the business as objects, such as an order or a customer, and each object should guard its own rules: an order, for example, should refuse to be shipped before it has been paid. Here the objects don't do that. Other code can change an object's data directly, so it can put an order into a state the rules forbid. Some objects only hold data, while the rules that should keep that data valid sit elsewhere in the code. Identifiers, such as order numbers and customer numbers, are passed around as plain numbers or text, so nothing stops the code from using one kind where another belongs. Because all of these findings have the same cause, fixing it once, in the business objects themselves, deals with them together.

Based on: Encapsulated state (19 findings) · Rich vs anemic model (18 findings) · Strongly-typed ids (23 findings)

What to do: Give each business object the methods that enforce its rules, such as a method for shipping an order that first checks it has been paid, and let only those methods change its data. Give each kind of identifier a type of its own, so an order number can't be used where a customer number belongs.

If you do one thing first · First action

Resolve the 1 No automated tests finding(s) in Code Coverage. Of all the actions in this report, it raises the score most for the work it takes: about 14 points for low effort, because it clears the 1 Code Coverage findings. The next survey will show the change in the score.

Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

44 modules, with 97 dependencies between them. One loop runs through 6 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 4 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →	1 Application.DTOs.Account	2 Application.DTOs.Authentication	3 Application.DTOs.City	4 Application.DTOs.Transaction	5 Application.DTOs.Transportation	6 Application.Result	7 Domain.Framework.Interfaces	8 Domain.Framework.Interfaces.Repositories	9 Domain.Framework.Base	10 Domain.Framework.Interfaces.Repositories.CompanyRepositories	11 Domain.Framework.Interfaces.Repositories.LocationRepositories	12 Domain.Aggregates.CompanyAggregates	13 Domain.Aggregates.LocationAggregates	14 Domain.Aggregates.TransactionAggregates	15 Domain.Aggregates.VehicleAggregates	16 Domain.Aggregates.AccountAggregates	17 Domain.Framework.Interfaces.Repositories.TransactionRepositories	18 Domain.Framework.Interfaces.Repositories.VehicleRepositories	23 Domain.Aggregates.TransportationAggregates	24 Domain.Framework.Interfaces.Repositories.AccountRepositories	26 Application.Interfaces	27 Domain.Framework.Interfaces.Repositories.TransportationRepositories	28 Infrastructure	31 Infrastructure.Framework.Base	34 WebAPI.Authentication
1 Application.DTOs.Account
2 Application.DTOs.Authentication
3 Application.DTOs.City
4 Application.DTOs.Transaction
5 Application.DTOs.Transportation
6 Application.Result
7 Domain.Framework.Interfaces
8 Domain.Framework.Interfaces.Repositories
9 Domain.Framework.Base							1
10 Domain.Framework.Interfaces.Repositories.CompanyRepositories								1
11 Domain.Framework.Interfaces.Repositories.LocationRepositories								3
12 Domain.Aggregates.CompanyAggregates									1										1
13 Domain.Aggregates.LocationAggregates									3										1
14 Domain.Aggregates.TransactionAggregates									3							1			1
15 Domain.Aggregates.VehicleAggregates									3										2
16 Domain.Aggregates.AccountAggregates									5					1					2
17 Domain.Framework.Interfaces.Repositories.TransactionRepositories								2						2
18 Domain.Framework.Interfaces.Repositories.VehicleRepositories								3							1
19 Infrastructure.Configurations.CompanyAggregates												1
20 Infrastructure.Configurations.LocationAggregates													3
21 Infrastructure.Configurations.TransactionAggregates														3
22 Infrastructure.Configurations.VehicleAggregates															3
23 Domain.Aggregates.TransportationAggregates									4			1	1	1	2	2
24 Domain.Framework.Interfaces.Repositories.AccountRepositories								5								4
25 Infrastructure.Configurations.AccountAggregates																6
26 Application.Interfaces	5	3	1	4	6	8													1
27 Domain.Framework.Interfaces.Repositories.TransportationRepositories								4											3
28 Infrastructure												1	3	3	3	6			4
29 Infrastructure.Configurations.TransportationAggregates																			4
30 Application.Services	5	3	1	4	7	8	7				1			1			4	2	1	9	16	6
31 Infrastructure.Framework.Base							1	1															1
32 Infrastructure.Seeders																							1
33 Infrastructure.Services																			2		1
34 WebAPI.Authentication		2																			1
35 Infrastructure.Services.AccountAggregates											3					4				5			8	8
36 Infrastructure.Services.CompanyAggregates										1													1	1
37 Infrastructure.Services.TransactionAggregates														2			2						2	2
38 Infrastructure.Services.TransportationAggregates																			3			4	4	4
39 Infrastructure.Services.VehicleAggregates															1			3					3	3
40 WebAPI.Controllers	5	2		1	2																11				1

Uses a module listed above itPart of a loopThe module itself

At a glance — Code Health · 80% · Strong ·

The Good

D1 · .NET / C# Cyclomatic Complexity 10.0 D2 · .NET / C# Cognitive Complexity 10.0 D3 · .NET / C# God Classes 10.0 D4 · .NET / C# Code Duplication 9.4 D17 · .NET / C# Explicit Debt 8.5 D18 · .NET / C# Solution Shape 10.0 D39 · .NET / C# IL Efficiency 9.5 GD1 · Repo Unfinished & placeholder code 10.0 IC1 · Repo Incompleteness & stubs 10.0 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 10.0 X30 · Repo Support guard that admits what it rejects 10.0 X32 · Repo Type resolved by simple name across every loaded assembly 10.0 X4 · Repo Structured logging 10.0 X5 · Repo Nullable reference types 9.9

The Ugly

X18 · Repo Disposal-pattern correctness 3.0 X2 · Repo Cancellation propagation 4.0

At a glance — Architecture · 87% · Strong ·

The Good

D5 · .NET / C# Coupling 10.0 D6 · .NET / C# Cohesion (LCOM4) 10.0 D26 · .NET / C# Project Cohesion 10.0 D27 · .NET / C# Navigability 9.9 D35 · .NET / C# Change Coupling 10.0 AX1 · Repo Captive dependencies 10.0 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX5 · Repo Architecture & structure 10.0 AX6 · Repo Interface segregation 10.0

The Bad

AX10 · Repo Code composition 5.5

At a glance — Maturity · 59% · Adequate · gated by D34 ·

The Good

D15 · .NET / C# Churn × Complexity Hotspots 10.0 D21 · .NET / C# Naming Consistency 9.0 M1 · Repo Documentation (README) 8.0 M4 · Repo Documentation accuracy 8.0

The Bad

D24 · .NET / C# Comment Value 5.0 M2 · Repo Architecture documentation 5.0 M3 · Repo Folder & project structure 6.0

The Ugly

D19 · .NET / C# Documentation Quality 4.0 D20 · .NET / C# ADR Quality 0.0 D34 · .NET / C# Knowledge Freshness 0.0

At a glance — Readiness · 26% · Weak · gated by D8, D9, P2, P3 ·

The Good

D13 · .NET / C# Secret Scanning 10.0 D14 · .NET / C# License Compliance 10.0 P1 · Repo CI/CD gates 8.5 P8 · Repo Schema migrations 10.0

The Bad

D12 · .NET / C# Dependency Hygiene 6.2 P4 · Repo Deployment & Rollback 5.0

The Ugly

D8 · .NET / C# Code Coverage 0.0 P2 · Repo Observability 0.0 P3 · Repo Security & performance tooling 0.0

At a glance — Security · 60% · Adequate · gated by D29, D36 ·

The Good

D28 · .NET / C# Secrets (history) 10.0 D30 · .NET / C# Dependency Vulnerabilities 9.4 D31 · .NET / C# IaC & Container Security 9.4 D44 · .NET / C# Platform End-of-Life 10.0 C2 · Repo Access Controls 10.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0

The Bad

C4 · Repo Data Retention 6.5 S1 · Repo Web-Security Posture 6.0

The Ugly

D29 · .NET / C# Static Analysis (SAST) 1.5 D36 · .NET / C# Supply-chain Provenance & Signing 0.0 C1 · Repo Data Protection 4.0

At a glance — Domain Modelling · 47% · Weak · gated by DM2, DM4, DM7 ·

The Good

DM1 · Repo Aggregate boundaries 10.0 DM10 · Repo One transaction, one aggregate 10.0 DM11 · Repo Constructible invalid state 10.0 DM12 · Repo Ambient inputs in the domain 9.8 DM6 · Repo Domain ↔ infrastructure boundary 10.0 DM8 · Repo Value-object opportunities 10.0 DM9 · Repo Scattered domain decisions 9.6

The Bad

DM5 · Repo Encapsulated state 6.0

The Ugly

DM2 · Repo Strongly-typed ids 3.0 DM4 · Repo Rich vs anemic model 3.4 DM7 · Repo Repository granularity 1.3

At a glance — Performance · 100% · Exemplary ·

The Good

PF3 · Repo Async & latency hygiene 10.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP category	Findings	Severity
A05:2025 — Injection	16	High / Critical
A03:2025 — Software Supply Chain Failures	7	High / Critical
A02:2025 — Security Misconfiguration	4	High / Critical

Roadmap

First, establish a baseline of reliability by resolving the single gaps in automated code coverage and test distribution. Next, immediately address the identified vulnerability in dependencies to secure the codebase. Then, implement structured logging across all service-like projects to improve observability. Finally, integrate a static analysis security tool into the CI pipeline to prevent security regressions from reaching production.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do this	Helps	Effort	Dimension
Resolve the 1 No automated tests finding(s) in Code Coverage.	+14.2 pts	Low	Code Coverage
Resolve the 1 No tests found finding(s) in Test Distribution.	+14.2 pts	Low	Test Distribution
Resolve the 1 Vulnerable finding(s) in Dependency Hygiene.	+13.3 pts	Low	Dependency Hygiene
Adopt ILogger (or Serilog) and log at meaningful points across the projects.	+5.6 pts	Medium	Observability
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.	+5.6 pts	Medium	Security & performance tooling
Resolve the 1 No ADRs found finding(s) in ADR Quality.	+1.8 pts	Low	ADR Quality
Define repositories per aggregate root and keep the query handle inside them; reach child entities through their root so invariants can't be bypassed.	+3.1 pts	Medium	Repository granularity
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md.	+1.2 pts	Low	Documentation Quality

File quality

Per-file score 0–10 — a quality signature. Of 20 files carrying findings, judged against the Production bar: 10% slop · 50% mixed · 40% near-clean.

File	Score	Band	Worst signal
REDACTED	2.3	Slop	Static Analysis (SAST): High: REDACTED
REDACTED	3.4	Slop	IaC & Container Security: High IaC: REDACTED
AlibabaClone.WebAPI/Controllers/AccountController.cs	7.2	Mixed	Code Duplication: Members sharing a duplicated core (7 members, 50+ identical tokens)
REDACTED	7.2	Mixed	Dependency Vulnerabilities: High CVE: REDACTED
AlibabaClone.Application/Services/CityService.cs	7.6	Mixed	Explicit Debt: WriteOnlyPrivateField
AlibabaClone.Application/Services/TransportationService.cs	7.6	Mixed	Explicit Debt: WriteOnlyPrivateField
AlibabaClone.Application/Services/TicketOrderService.cs	7.6	Mixed	Explicit Debt: WriteOnlyPrivateField
AlibabaClone.WebAPI/Controllers/TicketOrderController.cs	7.6	Mixed	Explicit Debt: WriteOnlyPrivateField
AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs	7.8	Mixed	Code Duplication: Members sharing a duplicated core (8 members, 50+ identical tokens)
REDACTED	7.9	Mixed	Static Analysis (SAST): Medium: REDACTED
REDACTED	7.9	Mixed	Static Analysis (SAST): Medium: REDACTED
REDACTED	7.9	Mixed	Static Analysis (SAST): Medium: REDACTED
AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs	8.2	Near-clean	Explicit Debt: CommentedOutCode
AlibabaClone.Infrastructure/Services/PdfGenerator.cs	8.2	Near-clean	Explicit Debt: Dead code: CellStyle
AlibabaClone.Application/DTOs/Account/PersonDto.cs	8.5	Near-clean	Code Duplication: Duplicated block (18 lines × 2)
AlibabaClone.WebAPI/Controllers/CouponController.cs	8.5	Near-clean	Code Duplication: Duplicated block (10–11 lines × 2)
AlibabaClone.Application/Services/AccountService.cs	8.5	Near-clean	Code Duplication: Duplicated block (7 lines × 2)
README.md	9.5	Near-clean	Documentation Quality: Documentation: no contributor guidance
AlibabaClone.Application/Interfaces/IPersonService.cs	9.5	Near-clean	Comment Value: misleading comment
AlibabaClone.Application/Mappers/Profiles/MappingProfile.cs	9.5	Near-clean	IL Efficiency: IL efficiency: 6 authored method(s) exceed the IL budget

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 22

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 114

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 104

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 4

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 84 of 88 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 1.0 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 88 dimensions across the health lenses

D1D2D3D4D5D6D8D9D12D13D14D15D17D18D19D20D21D24D26D27D28D29D30D31D34D35D36D39D44AX1AX10AX2AX3AX4AX5AX6C1C2C4DM1DM10DM11DM12DM2DM4DM5DM6DM7DM8DM9GD1IC1M1M2M3M4P1P2P3P4P8PF3S1X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X32X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions

Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 204 of 240 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

Method	Backs	Version	Evaluator
Roslyn static analysis	Complexity, cohesion, coupling, dead code, API surface, layering	5.3.0	✓ deterministic
Native secret scanner	Hardcoded secrets / credentials	1.0.0	✓ deterministic
Watchdog duplication detector (in-process)	Code duplication	1.0.0	✓ deterministic
Coverage (coverlet / dotnet-coverage)	Line & branch coverage	10.0.400	✓ deterministic
NuGet / dotnet	Outdated, vulnerable & deprecated dependencies	10.0.400	✓ deterministic
git / LibGit2Sharp	Churn hotspots, knowledge concentration, history	2.43.0 · 0.31.0	✓ deterministic
gitleaks · semgrep · trivy · checkov	Secrets in history, SAST, CVEs, IaC & container, PII / GDPR	1.86.0 · 0.69.3 · 3.2.533	✓ deterministic
LLM (sampled · advisory)	Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement	Local LLM	◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a16008-c22d-753f-ab0c-36379b2fe9ef.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-contributor repository — bus factor is not applicable (1 contributor(s) across 310 commit(s) sampled, automation and bot accounts excluded). Concentration needs a team to concentrate: with one contributor there is nobody to spread the knowledge to, so there is nothing here for the owner to act on.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
P1 CI/CD gates — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 26 further occurrence(s) are not listed individually; the score already reflects all 66.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D8 Code Coverage: Coverage is measured by building and running the test suite inside Watchdog's isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
DM4 Rich vs anemic model: Behaviour is detected as state mutation inside a method body — a method that enforces an invariant by validating-and-throwing without mutating reads as a query, and mutation delegated through an interface the scan can't resolve isn't credited; entities with zero public properties still drop out of the population. It detects that state changes, not whether the rule is correct.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".

The LLM boundary

LLM-set scores this run (4): D19, D21, D24, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity10.0 / 10Exemplary✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 method(s) exceeded the cyclomatic complexity threshold of 15.

✓ On the Gold path — maintain.

Detailed fixes: d1_recommendation.md.

Do you agree with this assessment?

D2 · Cognitive Complexity10.0 / 10Exemplary✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 method(s) exceeded the cognitive complexity threshold of 15.

✓ On the Gold path — maintain.

Detailed fixes: d2_recommendation.md.

Do you agree with this assessment?

D3 · God Classes10.0 / 10Exemplary✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 god class(es) detected.

✓ On the Gold path — maintain.

Detailed fixes: d3_recommendation.md.

Do you agree with this assessment?

D4 · Code Duplication9.4 / 10Stronggated by 9 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Verified

7 duplicated block group(s) detected. A further 2 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Members sharing a duplicated core (8 members, 50+ identical tokens)AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10

Members sharing a duplicated core (7 members, 50+ identical tokens)AlibabaClone.WebAPI/Controllers/AccountController.cs:27

Duplicated block (18 lines × 2)AlibabaClone.Application/DTOs/Account/PersonDto.cs:7

Duplicated block (13 lines × 7)AlibabaClone.WebAPI/Controllers/AccountController.cs:31

Duplicated block (12–13 lines × 8)AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 1 Members sharing a duplicated core (8 members, 50+ identical tokens) finding(s) in Code Duplication — start with GenderConfiguration.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Members sharing a duplicated core (7 members, 50+ identical tokens) finding(s) in Code Duplication — start with AccountController.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Duplicated block (18 lines × 2) finding(s) in Code Duplication — start with PersonDto.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

4 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

Do you agree with this assessment?

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 14 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

Do you agree with this assessment?

D8 · Code Coverage0.0 / 10Critical✓ Tool-verified

What it measures: How much of the code is actually exercised by tests.

Method: Coverage from coverlet runs or committed reports (Cobertura/OpenCover/lcov), computed per-file with structured exclusions for generated, trivial, and glue code. When the suite can't be built/run in-image AND no report is committed, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Verified

No automated tests — no test code was found in this repository.

No automated tests

What to do

Resolve the 1 No automated tests finding(s) in Code Coverage. — One of this dimension's main actionable groups (1 issue-level).
Enforce Code Coverage in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D9 · Test Distribution0.0 / 10Critical✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No test suite found.

No tests found

What to do

Resolve the 1 No tests found finding(s) in Test Distribution. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d9_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D12 · Dependency Hygiene6.2 / 10Adequate✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Verified

14 outdated, 1 vulnerable, 0 deprecated packages.

Vulnerable: AutoMapper

Outdated: AutoMapper · ×14

What to do

Resolve the 1 Vulnerable finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (1 issue-level).
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

Do you agree with this assessment?

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 190 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 14 direct `PackageReference`(s), and 172 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

Do you agree with this assessment?

D15 · Churn × Complexity Hotspots10.0 / 10Stronggated by 14 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window. Repeated repair below the complexity floor: AlibabaClone.Application/Services/TicketOrderService.cs (6 of 10 changes were fixes); AlibabaClone.Application/Services/AuthService.cs (4 of 5 changes were fixes); AlibabaClone.Application/Services/PersonService.cs (4 of 4 changes were fixes)

Repeated repair: AlibabaClone.Application/Services/TicketOrderService.cs · ×14AlibabaClone.Application/Services/TicketOrderService.cs:66

What to do

Resolve the 14 Repeated repair finding(s) in Churn × Complexity Hotspots — start with TicketOrderService.cs, AuthService.cs, PersonService.cs. — One of this dimension's main actionable groups (14 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D17 · Explicit Debt8.5 / 10Adequategated by 4 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

5 deducted debt markers + 1 dead symbols across 3821 LoC in the .NET projects (0.8/KLoC) → score 8.5.

WriteOnlyPrivateField · ×4AlibabaClone.Application/Services/CityService.cs:14

CommentedOutCodeAlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:31

Dead code: CellStyleAlibabaClone.Infrastructure/Services/PdfGenerator.cs:32

What to do

Resolve the 4 WriteOnlyPrivateField finding(s) in Explicit Debt — start with CityService.cs, TransportationService.cs, TicketOrderService.cs. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 1 CommentedOutCode finding(s) in Explicit Debt — start with TransportationRepository.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Dead code finding(s) in Explicit Debt — start with PdfGenerator.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D18 · Solution Shape10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

4 projects, 147 source files, 3821 hand-written lines of code (3821 production / 0 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 7316 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 5 inter-project edges.

✓ On the Gold path — maintain.

Detailed fixes: d18_recommendation.md.

Do you agree with this assessment?

D19 · Documentation QualityWeak◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Weak / 10 · rule-coverage 100% · ceiling Documented

The repository's root README is a single cohesive document covering the project's purpose, an overview of the tech stack with a table, and a brief 'Getting Started' section. It begins with a strong About-the-Project heading that states what the backend does (transportation management app) and links to the frontend, then transitions into a Tech Stack table before opening up a full architecture outline. The visible content is clear but thin: it names no install/build commands, gives no usage examples, and only mentions 'Authentication & Authorization' as one of several core features without explaining what they do or how to run the app.

Documentation: no contributor guidanceREADME.md

XML-doc coverage: AlibabaClone.WebAPI · ×4AlibabaClone.WebAPI/AlibabaClone.WebAPI.csproj

What to do

Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

1 naming inconsistencies across 200 sampled symbols.

Migration class names use inconsistent casing conventions: PascalCase (`AdjustDatabaseforProfilePage`) vs camelCase (`updatecoupon`).

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D24 · Comment ValueAdequate◐ Sampled · advisory

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Adequate / 10 · rule-coverage 100% · ceiling Documented

10 valuable / 0 redundant across 34 sampled comments; 1 shown with locations.

misleading commentAlibabaClone.Application/Interfaces/IPersonService.cs:8

What to do

Resolve the 1 misleading comment finding(s) in Comment Value — start with IPersonService.cs. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D26 · Project Cohesion10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 4 projects flagged as possibly oversized/incoherent.

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md.

Do you agree with this assessment?

D27 · Navigability9.9 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

100 % of calls cross a namespace and 2 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

Do you agree with this assessment?

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

Do you agree with this assessment?

D29 · Static Analysis (SAST)1.5 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 1.5 / 10 · rule-coverage 100% · ceiling Documented

16 finding(s): 0 critical, 13 high, 3 medium, 0 low. 3 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 5 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (5). — One of this dimension's main actionable groups (5 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
No action in Static Analysis (SAST) — all 3 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (3 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D30 · Dependency Vulnerabilities9.4 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low.

REDACTED

What to do

Resolve the 1 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D31 · IaC & Container Security9.4 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

4 finding(s): 0 critical, 1 high, 2 medium, 1 low.

REDACTED

What to do

Resolve the 1 High IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 Low IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

12 of 12 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is AlibabaClone.Application/Services/AccountService.cs. Counted over 12 of the 147 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×12AlibabaClone.Application/Services/AccountService.cs:1

Orphaned files with no living knowledge

What to do

Resolve the 12 Orphaned file finding(s) in Knowledge Freshness — start with AccountService.cs, TicketOrderService.cs, AccountController.cs. — One of this dimension's main actionable groups (12 recommendation-level).
Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

Do you agree with this assessment?

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D39 · IL Efficiency9.5 / 10Exemplary✓ Tool-verified

Method: IL instruction count per method, read from the BUILT first-party assemblies via Mono.Cecil (the target is compiled on a deep run); scored on the fraction of methods whose emitted IL body exceeds the size threshold. Sees compiler-generated bloat source can't; not-applicable when the target fails to build. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Verified

6 of 223 first-party methods have an oversized IL body.

IL efficiency: 6 authored method(s) exceed the IL budgetAlibabaClone.Application/Mappers/Profiles/MappingProfile.cs:17

✓ On the Gold path — maintain.

Detailed fixes: d39_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 4 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Do you agree with this assessment?

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

Do you agree with this assessment?

AX10 · Code composition5.5 / 10Adequate✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

Do you agree with this assessment?

AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

Do you agree with this assessment?

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

The namespaces AlibabaClone.Domain.Aggregates.AccountAggregates ↔ AlibabaClone.Domain.Aggregates.CompanyAggregates ↔ AlibabaClone.Domain.Aggregates.LocationAggregates ↔ AlibabaClone.Domain.Aggregates.TransactionAggregates ↔ AlibabaClone.Domain.Aggregates.TransportationAggregates ↔ AlibabaClone.Domain.Aggregates.VehicleAggregates depend on each other. The lightest dependency in the cycle is AlibabaClone.Domain.Aggregates.AccountAggregates → AlibabaClone.Domain.Aggregates.TransactionAggregates (AlibabaClone.Domain.Aggregates.AccountAggregates.Account → AlibabaClone.Domain.Aggregates.TransactionAggregates.Transaction, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:1

What to do

Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.

Do you agree with this assessment?

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

Do you agree with this assessment?

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

Do you agree with this assessment?

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

Do you agree with this assessment?

C1 · Data Protection4.0 / 10Weak✓ Tool-verified

Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.

Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.

What to do

Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.

Do you agree with this assessment?

C2 · Access Controls10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.

Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.

Do you agree with this assessment?

C4 · Data Retention6.5 / 10Adequate✓ Tool-verified

Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).

Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.

A retention mechanism is present, but the data-lifecycle is not yet complete — missing: a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob), a documented retention period / data-expiry.

What to do

Complete the data-lifecycle story: an expiry limit (a declared maximum age for the stored data — a retention-age setting, or a store-level TTL where your storage offers one), a scheduled purge/cleanup job that enforces it, and a documented retention period covering the personal data.

Do you agree with this assessment?

DM1 · Aggregate boundaries10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.

Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.

Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.

Do you agree with this assessment?

DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

Do you agree with this assessment?

DM11 · Constructible invalid state10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether an aggregate can be constructed in a state its own rules forbid — a public constructor that takes a raw primitive, stores it, and validates nothing, with no factory beside it. A constructor taking only value objects is not counted: each parameter has already validated itself.

Method: Neutral surface (DDD-gated): each non-abstract entity/aggregate checked for a PUBLIC constructor taking at least one RAW PRIMITIVE parameter whose body contains no guard token (throw / Guard. / Ensure. / ArgumentException / CheckRule), on a type that also offers no static Create/Of/From/New factory. A constructor taking only value objects is never charged -- measured: 64 of 87 unguarded public constructors on the C# corpus take value objects only, so ignoring parameter types would be 73% false positives. One finding per entity. Deterministic.

Do you agree with this assessment?

DM12 · Ambient inputs in the domain9.8 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

`Coupon` reads `DateTime.UtcNow` inside `IsExpired`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:17

What to do

Pass the instant into the domain method that needs it, or inject `TimeProvider` (BCL, .NET 8+) and read it there — then a test can choose the moment a rule is evaluated at.

Do you agree with this assessment?

DM2 · Strongly-typed ids3.0 / 10Weak✓ Tool-verified

Other · Domain Modelling — How much of the domain uses strongly-typed ids vs raw Guid/string/int — adoption curve, not all-or-nothing.

Method: Roslyn (DDD-gated): strongly-typed id adoption on domain entities/events; raw Guid/int/string ids counted versus wrapped types. An id wrapper is recognised by VALUE SEMANTICS, not by being a struct — a record struct, a record class (`record ApartmentId(Guid Value)`) or a class declared by a typed-id base (`class MemberId : TypedIdValueBase`) all count, while a plain mutable class (reference equality) and a verb-phrase query record (`GetCustomerById`) do not. Deterministic, adoption percentage.

Coverage: Population: id-like members by *Id/*Key NAME suffix; strongly-typed-ID shape then checked semantically — non-suffixed identifiers are not seen.

`Account.PersonId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:12
`BankAccountDetail.AccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:7
`Person.GenderId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:13
`Person.CreatorAccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:18
`Location.CityId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:9
`Location.LocationTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:10
`Transaction.TransactionTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:9
`Transaction.AccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:10
`Transaction.TicketOrderId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:11
`Transaction.CouponId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:16
`Ticket.TicketOrderId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:10
`Ticket.SeatId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:11
`Ticket.TravelerId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:12
`Ticket.CompanionId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:15
`Ticket.TicketStatusId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:16
`TicketOrder.TransportationId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:9
`TicketOrder.BuyerId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:10
`Transportation.FromLocationId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:10
`Transportation.ToLocationId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:11
`Transportation.CompanyId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:12
`Transportation.VehicleId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:13
`Seat.VehicleId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:8
`Vehicle.VehicleTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that. — AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:9

What to do

Adopt strongly-typed ids across the domain — finish the migration or document the boundary; primitive ids invite transposed-argument bugs.

Do you agree with this assessment?

DM4 · Rich vs anemic model3.4 / 10Weak✓ Tool-verified

Other · Domain Modelling — Whether aggregates/entities carry the behaviour that protects their invariants, rather than being data bags driven by external services.

Method: Roslyn (DDD-gated): entity method BODIES classified mutator-vs-query — only methods that mutate the entity's own declared state count as invariant-protecting behaviour, so a getter/passthrough doesn't rescue an anemic class. Deterministic, exhaustive over domain-layer entities.

Coverage: Population: entities by name/base convention; rich-vs-anemic judged by classifying each method body mutator-vs-query — logic-bearing domain types outside the convention are invisible.

`BankAccountDetail` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:5
`Gender` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/AccountAggregates/Gender.cs:5
`Person` is an aggregate/entity with 13 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:6
`Role` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/AccountAggregates/Role.cs:5
`Company` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/CompanyAggregates/Company.cs:6
`City` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/LocationAggregates/City.cs:5
`Location` is an aggregate/entity with 7 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:6
`LocationType` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/LocationAggregates/LocationType.cs:5
`Coupon` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:5
`Transaction` is an aggregate/entity with 13 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:7
`TransactionType` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransactionAggregates/TransactionType.cs:5
`Ticket` is an aggregate/entity with 14 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:7
`TicketOrder` is an aggregate/entity with 9 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:7
`TicketStatus` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketStatus.cs:5
`Transportation` is an aggregate/entity with 15 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:8
`Seat` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:6
`Vehicle` is an aggregate/entity with 7 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:6
`VehicleType` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — AlibabaClone.Domain/Aggregates/VehicleAggregates/VehicleType.cs:5

What to do

Move business rules onto the aggregates/entities they govern so invariants are enforced at the source, not in anemic services.

Do you agree with this assessment?

DM5 · Encapsulated state6.0 / 10Adequate✓ Tool-verified

Other · Domain Modelling — Whether entities protect their state — private/init-only setters, and collections handed out as read-only views rather than the mutable backing collection — instead of exposing writable state that bypasses invariants. Softened when a rehydration framework (Marten/EF) is present.

Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.

Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.

`Account` exposes publicly writable state (PhoneNumber, Password, Email, PersonId, Person, BankAccountDetail, and 4 more). — AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:7
`BankAccountDetail` exposes publicly writable state (AccountId, BankName, CardNumber, IBAN, BankAccountNumber, Account). — AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:5
`Gender` exposes publicly writable state (Title). — AlibabaClone.Domain/Aggregates/AccountAggregates/Gender.cs:5
`Person` exposes publicly writable state (FirstName, LastName, IdNumber, Birthdate, GenderId, PhoneNumber, and 7 more). — AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:6
`Role` exposes publicly writable state (Title). — AlibabaClone.Domain/Aggregates/AccountAggregates/Role.cs:5
`Company` exposes publicly writable state (Title, Transportations). — AlibabaClone.Domain/Aggregates/CompanyAggregates/Company.cs:6
`City` exposes publicly writable state (Title, Locations). — AlibabaClone.Domain/Aggregates/LocationAggregates/City.cs:5
`Location` exposes publicly writable state (Title, CityId, LocationTypeId, City, LocationType, DepartingTransportations, and 1 more). — AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:6
`LocationType` exposes publicly writable state (Title, Locations). — AlibabaClone.Domain/Aggregates/LocationAggregates/LocationType.cs:5
`Coupon` exposes publicly writable state (Code, MaxDiscountAmount, DiscountPercentage, ExpiryDate, MaxUsages, MaxUsagesPerAccount, and 2 more). — AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:5
`Transaction` exposes publicly writable state (TransactionTypeId, AccountId, TicketOrderId, BaseAmount, FinalAmount, SerialNumber, and 7 more). — AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:7
`TransactionType` exposes publicly writable state (Title). — AlibabaClone.Domain/Aggregates/TransactionAggregates/TransactionType.cs:5
`Ticket` exposes publicly writable state (TicketOrderId, SeatId, TravelerId, CreatedAt, CanceledAt, CompanionId, and 8 more). — AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:7
`TicketOrder` exposes publicly writable state (TransportationId, BuyerId, CreatedAt, SerialNumber, Description, Tickets, and 3 more). — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:7
`TicketStatus` exposes publicly writable state (Title). — AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketStatus.cs:5
`Transportation` exposes publicly writable state (FromLocationId, ToLocationId, CompanyId, VehicleId, StartDateTime, EndDateTime, and 7 more). — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:8
`Seat` exposes publicly writable state (VehicleId, Row, Column, IsVIP, IsAvailable, Description, and 2 more). — AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:6
`Vehicle` exposes publicly writable state (Title, VehicleTypeId, Capacity, PlateNumber, VehicleType, Seats, and 1 more). — AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:6
`VehicleType` exposes publicly writable state (Title, Vehicles). — AlibabaClone.Domain/Aggregates/VehicleAggregates/VehicleType.cs:5

What to do

Make entity setters private/init-only and hand collections out as IReadOnlyList/IReadOnlyCollection over a private backing field; change state only through methods that enforce the invariants (Marten/EF can bind via constructor or private setters).

Do you agree with this assessment?

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

Do you agree with this assessment?

DM7 · Repository granularity1.3 / 10Critical✓ Tool-verified

Other · Domain Modelling — Whether repositories are per aggregate root (not per child entity) and keep the persistence query handle behind the contract, so the root's invariants can't be bypassed.

Method: Roslyn (DDD-gated): repository abstraction detection; repositories over non-aggregate-root entities flagged, and (C#/VB) repository INTERFACES whose members return a live persistence query handle (IQueryable/DbSet/IMongoQueryable) — implementations and specification evaluators are out of population by design, since composing a query internally is what an implementation is for. Deterministic, DDD-native.

Coverage: Population: repositories + aggregate roots by NAME convention; per-root repository rule checked within the set.

`IBankAccountDetailRepository` is a repository over `BankAccountDetail`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `BankAccountDetail` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IBankAccountDetailRepository.cs:5
`IGenderRepository` is a repository over `Gender`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Gender` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IGenderRepository.cs:5
`IPersonRepository` is a repository over `Person`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Person` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IPersonRepository.cs:5
`IRoleRepository` is a repository over `Role`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Role` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IRoleRepository.cs:5
`ICompanyRepository` is a repository over `Company`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Company` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/CompanyRepositories/ICompanyRepository.cs:5
`ICityRepository` is a repository over `City`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `City` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ICityRepository.cs:5
`ILocationRepository` is a repository over `Location`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Location` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ILocationRepository.cs:5
`ILocationTypeRepository` is a repository over `LocationType`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `LocationType` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ILocationTypeRepository.cs:5
`ICouponRepository` is a repository over `Coupon`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Coupon` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransactionRepositories/ICouponRepository.cs:5
`ITransactionRepository` is a repository over `Transaction`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Transaction` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransactionRepositories/ITransactionRepository.cs:5
`ITicketOrderRepository` is a repository over `TicketOrder`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `TicketOrder` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketOrderRepository.cs:5
`ITicketRepository` is a repository over `Ticket`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Ticket` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketRepository.cs:5
`ITicketStatusRepository` is a repository over `TicketStatus`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `TicketStatus` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketStatusRepository.cs:5
`ITransportationRepository` is a repository over `Transportation`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Transportation` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITransportationRepository.cs:5
`ISeatRepository` is a repository over `Seat`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Seat` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/ISeatRepository.cs:5
`IVehicleRepository` is a repository over `Vehicle`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Vehicle` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/IVehicleRepository.cs:5
`IVehicleTypeRepository` is a repository over `VehicleType`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `VehicleType` through its owning aggregate instead. — AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/IVehicleTypeRepository.cs:5

What to do

Define repositories per aggregate root and keep the query handle inside them; reach child entities through their root so invariants can't be bypassed.

Do you agree with this assessment?

DM8 · Value-object opportunities10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.

Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.

Do you agree with this assessment?

DM9 · Scattered domain decisions9.6 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

AlibabaClone.Domain.Aggregates.AccountAggregates.Person's [CreatorAccountId, IdNumber] are judged in AlibabaClone.Application.Services.PersonService, AlibabaClone.Application.Services.TicketOrderService — the same decision, restated. Every copy is a chance to drift, and copies drift silently because each one looks correct on its own. Move the judgement onto the type that owns the members and let the call sites ask it.

What to do

Move each repeated judgement onto the type that owns the members it reads, so the rule has one home and cannot drift.

Do you agree with this assessment?

GD1 · Unfinished & placeholder code10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

Do you agree with this assessment?

IC1 · Incompleteness & stubs10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×8) — AlibabaClone.Infrastructure/Services/PdfGenerator.cs:22, AlibabaClone.Infrastructure/Services/PdfGenerator.cs:23, AlibabaClone.Infrastructure/Services/PdfGenerator.cs:66, …

What to do

Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.

Do you agree with this assessment?

M1 · Documentation (README)8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

Add a README to the 4 of 4 project(s) that lack one — worth up to 2 pts.

Do you agree with this assessment?

M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Do you agree with this assessment?

M3 · Folder & project structure6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.

What to do

Group production code under src/ (or split deliberately, e.g. backend/ + frontend/) so production and tooling code aren't mixed at the root.
Start a test surface where your build system looks for one (tests/, test/, spec/, or your ecosystem's test source set) — the separation follows from putting the first tests in the right place.

Do you agree with this assessment?

M4 · Documentation accuracy8.0 / 10Strong◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

README advertises a microservices architecture, but the repo is a single project with no service manifests — searched for: `microservice`, `service-mesh`, `istio`. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest and configuration files (package.json and other *.json, *.csproj, *.props, *.sln/*.slnx, *.yml, *.toml, *.config, tool configs such as eslint.config.js, REDACTED); the README's own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read — a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong. — README.md:463

What to do

Reconcile the README with reality: README advertises a microservices architecture, but the repo is a single project with no service manifests.

Do you agree with this assessment?

P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

Run the test suite in CI via an explicit runner step for your stack, and gate merges on it.

Do you agree with this assessment?

P2 · Observability0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

No logging call was found in the 176 `.cs` file(s) this check read. Each was searched for the framework names `ILogger`, `Serilog`, `NLog` and `log4net`; for a call on a receiver whose name ends in `Logger`; for a `System.Diagnostics` write; for a level-gated log facade; and for the builder spellings that CONFIGURE logging for everyone else (`AddLogging(`, `ConfigureLogging(`, `UseSerilog(`, `UseNLog(`, `.Logging.Add…(`); and for emission through an `EventSource`, `ActivitySource` or `DiagnosticSource` (`WriteEvent(`, `StartActivity(`, `.Write("event", …)`). That walk sees only `.cs` documents from projects the workspace loaded, so it cannot see logging in source that did not load, in another language, or through a repo-local wrapper whose name does not end in `Logger` — this is 'no logging found by this walk', not a verdict that nothing here logs. If it is right, production issues will be hard to diagnose.

What to do

Adopt ILogger (or Serilog) and log at meaningful points across the projects.
Consider OpenTelemetry tracing/metrics and a health-check endpoint for operability.

Do you agree with this assessment?

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1732 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.

Do you agree with this assessment?

P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

Deployment automation exists but no readiness/liveness probes, rolling-update strategy, lifecycle hooks or migration job were evidenced — a bad release is harder to detect and reverse.

What to do

Add readiness/liveness probes and a rolling-update (or blue/green) strategy so a bad release is caught and rolled back automatically.
Add an approval/environment gate (required reviewers / protection rules) before production promotion.

Do you agree with this assessment?

P8 · Schema migrations10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether EF Core schema changes go through versioned migrations rather than the un-evolvable EnsureCreated().

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

Do you agree with this assessment?

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

Do you agree with this assessment?

S1 · Web-Security Posture6.0 / 10Adequate✓ Tool-verified

Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

This code fixes PBKDF2-SHA-256 at 100,000 iterations. A key-derivation function's only defence is the cost of ONE guess, and that cost is this number — the algorithm choice does not set it. Current OWASP guidance is 1,300,000 PBKDF2 iterations with HMAC-SHA1, 600,000 with SHA-256 and 210,000 with SHA-512; scrypt at N=2^17, r=8, p=1 (or an equivalent N·r·p product); Argon2id at 19 MiB of memory and 2 iterations (or an equivalent row); bcrypt at a work factor of at least 10. This figure divides the attacker's work by a factor of tens or hundreds against the same stolen hash, on hardware they already own. Where what is derived is short or low-entropy — a PIN, a numeric parental code, a four-character token — the whole keyspace falls in the time this parameter buys, and no salt or constant-time comparison changes that. Raise the count to the current published figure for the PRF you use, measure it on the slowest hardware that must run it (a target of roughly 100 ms per derivation is the usual budget), and read the value from configuration so a deployment can raise it again without a rebuild. Where the derived value must interoperate with a format someone else fixed, the count cannot move — derive a SEPARATE value for anything you own rather than inheriting the external format's price. (×2) — AlibabaClone.Application/Utils/PasswordHasher.cs:11, AlibabaClone.Application/Utils/PasswordHasher.cs:28
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves. — AlibabaClone.WebAPI/Program.cs:26

What to do

Raise the cost parameter to current guidance — PBKDF2 at 1,300,000 (HMAC-SHA1), 600,000 (SHA-256) or 210,000 (SHA-512) iterations; scrypt at N=2^17, r=8, p=1; bcrypt at a work factor of 10 or more — or move to a memory-hard KDF (Argon2id, scrypt) where the platform offers one. Read the parameter from configuration and tune it to roughly 100 ms per derivation on the slowest hardware that must run it, so the price can be raised again without shipping new code. This repository constructs a key derivation priced below the floor at 2 sites, not one: `AlibabaClone.Application/Utils/PasswordHasher.cs:11` (PBKDF2-SHA-256, 100,000 iterations), `AlibabaClone.Application/Utils/PasswordHasher.cs:28` (PBKDF2-SHA-256, 100,000 iterations). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.

Do you agree with this assessment?

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

Do you agree with this assessment?

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X18 · Disposal-pattern correctness3.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

`pbkdf2` is a `Rfc2898DeriveBytes`, which implements `IDisposable`, and it is created here (line 11). Every use of it in `HashPassword` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var pbkdf2 = …;`), which releases it at the end of the scope on every path including a throw. — AlibabaClone.Application/Utils/PasswordHasher.cs:11
`pbkdf2` is a `Rfc2898DeriveBytes`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `VerifyPassword` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var pbkdf2 = …;`), which releases it at the end of the scope on every path including a throw. — AlibabaClone.Application/Utils/PasswordHasher.cs:28
`_context` is never created by `UnitOfWork` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 16). Its declared type `ApplicationDBContext` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — AlibabaClone.Infrastructure/Framework/Base/UnitOfWork.cs:16

What to do

Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.

Do you agree with this assessment?

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

Only 0/65 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×39) — AlibabaClone.WebAPI/Controllers/AccountController.cs:26, AlibabaClone.WebAPI/Controllers/AccountController.cs:46, AlibabaClone.WebAPI/Controllers/AccountController.cs:67, …

What to do

Thread a CancellationToken through async methods so work stops promptly on cancellation.

Do you agree with this assessment?

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

Do you agree with this assessment?

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.

Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

Do you agree with this assessment?

X5 · Nullable reference types9.9 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

~0.1 `!` suppressions per 1k syntax nodes — 7 suppression(s) across the 69443 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.

What to do

Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Do you agree with this assessment?

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

Lens	Score	Rating	Impact
Code Health	80%	Strong	Solid.
Architecture	87%	Strong	Solid.
Maturity	59%	Adequate — gated by D34	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness	26%	Weak — gated by D8, D9, P2, P3	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security	60%	Adequate — gated by D29, D36	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling	47%	Weak — gated by DM2, DM4, DM7	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance	100%	Exemplary	Strongest area.

Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.

Not evidenced — 4 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo

Not included — 38 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — This repository has no user interface to render — no markup (HTML, Razor, JSX, Vue, Svelte or server templates), no UI framework dependency, no UI component source and no native UI project — so WCAG's runtime success criteria have nothing to apply to here. Not applicable: this is neither a gap in the scan nor a finding about your code.
AXS1 Runtime exposed surface — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
D10 Test Quality — No tests were found in the analyzed repository to assess for quality.
D11 Test Reliability — No test suite was found to re-run, so reliability couldn't be assessed. Two searches produced that zero and both came back empty: the classifier that reads the loaded workspace recognised no suite it could run, and a walk of the source on disk — which covers the JS/TS `*.test.*` and `*.spec.*` conventions and probes for a Pester suite — found no test source in any other ecosystem either. Neither search reaches a suite that is missing from the loaded workspace and carries no name either walk recognises, so this is 'no suite found by those two searches', not a verdict that the repository has none.
D16 Bus Factor — single-contributor repository — bus factor is not applicable
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — small single-context codebase (3,821 production LoC in the .NET projects) — bounded contexts are not needed at this size No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Aggregate roots were found in only one source directory (AlibabaClone.Domain), which is a layered codebase, not two contexts. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D25 ADR Conformance — no ADRs to check
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P7 Outbound HTTP resilience — no outbound HTTP usage detected — no HttpClient/IHttpClientFactory/AddHttpClient in source, and no Refit/RestSharp/Flurl.Http namespace or package reference
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
PF2 Allocation hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 22 finding(s)

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D17 · Explicit Debt · WriteOnlyPrivateField · ×4

WriteOnlyPrivateField AlibabaClone.Application/Services/CityService.cs:14 — private IUnitOfWork _unitOfWork — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField AlibabaClone.Application/Services/TransportationService.cs:16 — private IUnitOfWork _unitOfWork — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField AlibabaClone.Application/Services/TicketOrderService.cs:28 — private ITransactionService _transactionService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField AlibabaClone.WebAPI/Controllers/TicketOrderController.cs:16 — private ITransportationService _transportationService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED

AX3 · Project dependency cycles · Namespace dependency cycle · ×1

Namespace dependency cycle AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:1 — The namespaces AlibabaClone.Domain.Aggregates.AccountAggregates ↔ AlibabaClone.Domain.Aggregates.CompanyAggregates ↔ AlibabaClone.Domain.Aggregates.LocationAggregates ↔ AlibabaClone.Domain.Aggregates.TransactionAggregates ↔ AlibabaClone.Domain.Aggregates.TransportationAggregates ↔ AlibabaClone.Domain.Aggregates.VehicleAggregates depend on each other. The lightest dependency in the cycle is AlibabaClone.Domain.Aggregates.AccountAggregates → AlibabaClone.Domain.Aggregates.TransactionAggregates (AlibabaClone.Domain.Aggregates.AccountAggregates.Account → AlibabaClone.Domain.Aggregates.TransactionAggregates.Transaction, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.

D12 · Dependency Hygiene · Vulnerable · ×1

Vulnerable: AutoMapper — REDACTED — High severity. https://github.com/advisories/[GHSA redacted]

D29 · Static Analysis (SAST) · REDACTED · ×1

REDACTED

D30 · Dependency Vulnerabilities · High CVE · ×1

REDACTED

D31 · IaC & Container Security · High IaC · ×1

REDACTED

D8 · Code Coverage · No automated tests · ×1

No automated tests — No automated tests — no test code was found in this repository. Untested code is the largest single risk to changing it safely. Start with the code you change most often: add a suite in a framework a runner can collect (xUnit, NUnit or MSTest), and run it in CI so the gap cannot reopen.

Serious — 114 finding(s)

X2 · Cancellation propagation · Async method without CancellationToken · ×39

Async method without CancellationToken: GetProfile AlibabaClone.WebAPI/Controllers/AccountController.cs:26 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetMyTravels AlibabaClone.WebAPI/Controllers/AccountController.cs:46 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetTravelOrderDetails AlibabaClone.WebAPI/Controllers/AccountController.cs:67 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetMyTransactions AlibabaClone.WebAPI/Controllers/AccountController.cs:88 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EditEmail AlibabaClone.WebAPI/Controllers/AccountController.cs:110 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EditPassword AlibabaClone.WebAPI/Controllers/AccountController.cs:128 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertAccountPerson AlibabaClone.WebAPI/Controllers/AccountController.cs:146 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertPerson AlibabaClone.WebAPI/Controllers/AccountController.cs:163 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertBankDetail AlibabaClone.WebAPI/Controllers/AccountController.cs:181 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetMyPeople AlibabaClone.WebAPI/Controllers/AccountController.cs:199 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: TopUpAccount AlibabaClone.WebAPI/Controllers/AccountController.cs:221 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Register REDACTED:22 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Login REDACTED:41 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetAllCities REDACTED:18 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ValidateCoupon AlibabaClone.WebAPI/Controllers/CouponController.cs:25 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CreateTicketOrder AlibabaClone.WebAPI/Controllers/TicketOrderController.cs:28 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DownloadPdf AlibabaClone.WebAPI/Controllers/TicketOrderController.cs:46 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: SearchTransportations REDACTED:20 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetTransportationSeats REDACTED:43 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetProfileAsync AlibabaClone.Application/Services/AccountService.cs:50 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetTravels AlibabaClone.Application/Services/AccountService.cs:61 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetTicketOrderTravelersDetails AlibabaClone.Application/Services/AccountService.cs:72 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetAccountTransactions AlibabaClone.Application/Services/AccountService.cs:88 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpdateEmailAsync AlibabaClone.Application/Services/AccountService.cs:99 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpdatePasswordAsync AlibabaClone.Application/Services/AccountService.cs:123 — No CancellationToken parameter — this work can't be stopped early once started.
+ 14 more in this group — see findings.md.

DM4 · Rich vs anemic model · Anemic entity · ×18

Anemic entity: BankAccountDetail AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:5 — `BankAccountDetail` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Gender AlibabaClone.Domain/Aggregates/AccountAggregates/Gender.cs:5 — `Gender` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Person AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:6 — `Person` is an aggregate/entity with 13 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Role AlibabaClone.Domain/Aggregates/AccountAggregates/Role.cs:5 — `Role` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Company AlibabaClone.Domain/Aggregates/CompanyAggregates/Company.cs:6 — `Company` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: City AlibabaClone.Domain/Aggregates/LocationAggregates/City.cs:5 — `City` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Location AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:6 — `Location` is an aggregate/entity with 7 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: LocationType AlibabaClone.Domain/Aggregates/LocationAggregates/LocationType.cs:5 — `LocationType` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Coupon AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:5 — `Coupon` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Transaction AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:7 — `Transaction` is an aggregate/entity with 13 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: TransactionType AlibabaClone.Domain/Aggregates/TransactionAggregates/TransactionType.cs:5 — `TransactionType` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Ticket AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:7 — `Ticket` is an aggregate/entity with 14 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: TicketOrder AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:7 — `TicketOrder` is an aggregate/entity with 9 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: TicketStatus AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketStatus.cs:5 — `TicketStatus` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Transportation AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:8 — `Transportation` is an aggregate/entity with 15 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Seat AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:6 — `Seat` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Vehicle AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:6 — `Vehicle` is an aggregate/entity with 7 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: VehicleType AlibabaClone.Domain/Aggregates/VehicleAggregates/VehicleType.cs:5 — `VehicleType` is an aggregate/entity with 2 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.

DM7 · Repository granularity · Repository for a non-root entity · ×17

Repository for a non-root entity: IBankAccountDetailRepository → BankAccountDetail AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IBankAccountDetailRepository.cs:5 — `IBankAccountDetailRepository` is a repository over `BankAccountDetail`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `BankAccountDetail` through its owning aggregate instead.
Repository for a non-root entity: IGenderRepository → Gender AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IGenderRepository.cs:5 — `IGenderRepository` is a repository over `Gender`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Gender` through its owning aggregate instead.
Repository for a non-root entity: IPersonRepository → Person AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IPersonRepository.cs:5 — `IPersonRepository` is a repository over `Person`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Person` through its owning aggregate instead.
Repository for a non-root entity: IRoleRepository → Role AlibabaClone.Domain/Framework/Interfaces/Repositories/AccountRepositories/IRoleRepository.cs:5 — `IRoleRepository` is a repository over `Role`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Role` through its owning aggregate instead.
Repository for a non-root entity: ICompanyRepository → Company AlibabaClone.Domain/Framework/Interfaces/Repositories/CompanyRepositories/ICompanyRepository.cs:5 — `ICompanyRepository` is a repository over `Company`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Company` through its owning aggregate instead.
Repository for a non-root entity: ICityRepository → City AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ICityRepository.cs:5 — `ICityRepository` is a repository over `City`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `City` through its owning aggregate instead.
Repository for a non-root entity: ILocationRepository → Location AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ILocationRepository.cs:5 — `ILocationRepository` is a repository over `Location`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Location` through its owning aggregate instead.
Repository for a non-root entity: ILocationTypeRepository → LocationType AlibabaClone.Domain/Framework/Interfaces/Repositories/LocationRepositories/ILocationTypeRepository.cs:5 — `ILocationTypeRepository` is a repository over `LocationType`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `LocationType` through its owning aggregate instead.
Repository for a non-root entity: ICouponRepository → Coupon AlibabaClone.Domain/Framework/Interfaces/Repositories/TransactionRepositories/ICouponRepository.cs:5 — `ICouponRepository` is a repository over `Coupon`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Coupon` through its owning aggregate instead.
Repository for a non-root entity: ITransactionRepository → Transaction AlibabaClone.Domain/Framework/Interfaces/Repositories/TransactionRepositories/ITransactionRepository.cs:5 — `ITransactionRepository` is a repository over `Transaction`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Transaction` through its owning aggregate instead.
Repository for a non-root entity: ITicketOrderRepository → TicketOrder AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketOrderRepository.cs:5 — `ITicketOrderRepository` is a repository over `TicketOrder`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `TicketOrder` through its owning aggregate instead.
Repository for a non-root entity: ITicketRepository → Ticket AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketRepository.cs:5 — `ITicketRepository` is a repository over `Ticket`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Ticket` through its owning aggregate instead.
Repository for a non-root entity: ITicketStatusRepository → TicketStatus AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITicketStatusRepository.cs:5 — `ITicketStatusRepository` is a repository over `TicketStatus`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `TicketStatus` through its owning aggregate instead.
Repository for a non-root entity: ITransportationRepository → Transportation AlibabaClone.Domain/Framework/Interfaces/Repositories/TransportationRepositories/ITransportationRepository.cs:5 — `ITransportationRepository` is a repository over `Transportation`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Transportation` through its owning aggregate instead.
Repository for a non-root entity: ISeatRepository → Seat AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/ISeatRepository.cs:5 — `ISeatRepository` is a repository over `Seat`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Seat` through its owning aggregate instead.
Repository for a non-root entity: IVehicleRepository → Vehicle AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/IVehicleRepository.cs:5 — `IVehicleRepository` is a repository over `Vehicle`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `Vehicle` through its owning aggregate instead.
Repository for a non-root entity: IVehicleTypeRepository → VehicleType AlibabaClone.Domain/Framework/Interfaces/Repositories/VehicleRepositories/IVehicleTypeRepository.cs:5 — `IVehicleTypeRepository` is a repository over `VehicleType`, which is an entity but not an aggregate root. Repositories should be per aggregate ROOT — loading/saving a child entity independently lets callers bypass the root's invariants. Access `VehicleType` through its owning aggregate instead.

D15 · Churn × Complexity Hotspots · Repeated repair · ×14

Repeated repair: AlibabaClone.Application/Services/TicketOrderService.cs AlibabaClone.Application/Services/TicketOrderService.cs:66 — AlibabaClone.Application/Services/TicketOrderService.cs changed 10 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is TicketOrderService.CreateTicketOrderAsync at line 66), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: handle traveler seat id being null better in TicketOrderService”; “fix: use enum values instread of constant values in services”; “fix: remove redundant and unncessary imports in Application files”; “fix: handling null values and null returns from methods in services and mapping profile better”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Application/Services/TicketOrderService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Application/Services/AuthService.cs AlibabaClone.Application/Services/AuthService.cs:96 — AlibabaClone.Application/Services/AuthService.cs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is AuthService.IsPasswordStrong at line 96), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: use enum values instread of constant values in services”; “fix: change Result creator methods and adjust Services which use Result.Error”; “fix: add id in authResponseDto in Login method in AuthService fix the UserContext to extract the id correctly”; “fix: move the token generation logic to Presentation Layer”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Application/Services/AuthService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Application/Services/PersonService.cs AlibabaClone.Application/Services/PersonService.cs:59 — AlibabaClone.Application/Services/PersonService.cs changed 4 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is PersonService.UpsertPersonAsync at line 59), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: make BankName, CardNumber, IBAN, BankAccountNumber nullable in BankAccountDetail entity”; “fix: handling null values and null returns from methods in services and mapping profile better”; “fix: change Result creator methods and adjust Services which use Result.Error”; “fix: remove a logic error in PersonService”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Application/Services/PersonService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:32 — AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is Account.Withdraw at line 32), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: adding AccountId in TransactionId and adjust navigation properties and TransactionConfiguration”; “fix: adjust entites with TicketOrder and Coupon”; “fix: add AccountRoles in Account and Account and Role in AccountRole and adjust configurations”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:9 — AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is GenderConfiguration.Configure at line 9), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs:9 — AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is RoleConfiguration.Configure at line 9), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs:10 — AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is LocationTypeConfiguration.Configure at line 10), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs:10 — AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is TransactionTypeConfiguration.Configure at line 10), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs:9 — AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is TicketStatusConfiguration.Configure at line 9), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs:12 — AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is VehicleTypeConfiguration.Configure at line 12), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove changes applied to lookup tables and remove migraion seed data”; “fix: add identity to lookup tables”; “fix: make lookup tables(Gender, Role, LocationType, TransactionType, TicketStatus, VehicleType) id not not auto generated”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Application/Services/TransportationService.cs AlibabaClone.Application/Services/TransportationService.cs:51 — AlibabaClone.Application/Services/TransportationService.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is TransportationService.GetTransportationSeatsAsync at line 51), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: use enum values instread of constant values in services”; “fix: change Result creator methods and adjust Services which use Result.Error”; “fix: fix GetTransportationSeatsAsync”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Application/Services/TransportationService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Application/Result/Result.cs AlibabaClone.Application/Result/Result.cs:8 — AlibabaClone.Application/Result/Result.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is Result.IsSuccess.get at line 8), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove redundant and unncessary imports in Application files”; “fix: change Result creator methods and adjust Services which use Result.Error”; “fix: modify result to include error message”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Application/Result/Result.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TransportationConfiguration.cs AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TransportationConfiguration.cs:9 — AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TransportationConfiguration.cs changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is TransportationConfiguration.Configure at line 9), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove redundant imports handle nullabe better for repository interfaces and implemnatations”; “fix: make EFCore ignore RemainingCapacity and use it as a calcualted field”; “fix: adjust transaction, ticket, and transportation configurations”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TransportationConfiguration.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:17 — AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is Transportation.RemainingCapacity.get at line 17), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: remove redundant imports”; “fix: make EFCore ignore RemainingCapacity and use it as a calcualted field”; “fix: adjust entites with TicketOrder and Coupon”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2025-04-19..2025-07-18, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-04-19 23:51:03 +03:30' --until='2025-07-18 23:51:03 +03:30' --full-history --no-merges -- AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.

D29 · Static Analysis (SAST) · REDACTED · ×3

REDACTED
REDACTED
REDACTED

D31 · IaC & Container Security · Medium IaC · ×2

REDACTED
REDACTED

S1 · Web-Security Posture · Password key derivation is priced too cheaply · ×2

Password key derivation is priced too cheaply AlibabaClone.Application/Utils/PasswordHasher.cs:11 — This code fixes PBKDF2-SHA-256 at 100,000 iterations. A key-derivation function's only defence is the cost of ONE guess, and that cost is this number — the algorithm choice does not set it. Current OWASP guidance is 1,300,000 PBKDF2 iterations with HMAC-SHA1, 600,000 with SHA-256 and 210,000 with SHA-512; scrypt at N=2^17, r=8, p=1 (or an equivalent N·r·p product); Argon2id at 19 MiB of memory and 2 iterations (or an equivalent row); bcrypt at a work factor of at least 10. This figure divides the attacker's work by a factor of tens or hundreds against the same stolen hash, on hardware they already own. Where what is derived is short or low-entropy — a PIN, a numeric parental code, a four-character token — the whole keyspace falls in the time this parameter buys, and no salt or constant-time comparison changes that. Raise the count to the current published figure for the PRF you use, measure it on the slowest hardware that must run it (a target of roughly 100 ms per derivation is the usual budget), and read the value from configuration so a deployment can raise it again without a rebuild. Where the derived value must interoperate with a format someone else fixed, the count cannot move — derive a SEPARATE value for anything you own rather than inheriting the external format's price.
Password key derivation is priced too cheaply AlibabaClone.Application/Utils/PasswordHasher.cs:28 — This code fixes PBKDF2-SHA-256 at 100,000 iterations. A key-derivation function's only defence is the cost of ONE guess, and that cost is this number — the algorithm choice does not set it. Current OWASP guidance is 1,300,000 PBKDF2 iterations with HMAC-SHA1, 600,000 with SHA-256 and 210,000 with SHA-512; scrypt at N=2^17, r=8, p=1 (or an equivalent N·r·p product); Argon2id at 19 MiB of memory and 2 iterations (or an equivalent row); bcrypt at a work factor of at least 10. This figure divides the attacker's work by a factor of tens or hundreds against the same stolen hash, on hardware they already own. Where what is derived is short or low-entropy — a PIN, a numeric parental code, a four-character token — the whole keyspace falls in the time this parameter buys, and no salt or constant-time comparison changes that. Raise the count to the current published figure for the PRF you use, measure it on the slowest hardware that must run it (a target of roughly 100 ms per derivation is the usual budget), and read the value from configuration so a deployment can raise it again without a rebuild. Where the derived value must interoperate with a format someone else fixed, the count cannot move — derive a SEPARATE value for anything you own rather than inheriting the external format's price.

X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×2

Disposable created and abandoned in the method that made it AlibabaClone.Application/Utils/PasswordHasher.cs:11 — `pbkdf2` is a `Rfc2898DeriveBytes`, which implements `IDisposable`, and it is created here (line 11). Every use of it in `HashPassword` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var pbkdf2 = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it AlibabaClone.Application/Utils/PasswordHasher.cs:28 — `pbkdf2` is a `Rfc2898DeriveBytes`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `VerifyPassword` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var pbkdf2 = …;`), which releases it at the end of the scope on every path including a throw.

D17 · Explicit Debt · CommentedOutCode · ×1

CommentedOutCode AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:31 — 5 consecutive commented-code lines

D17 · Explicit Debt · Dead code · ×1

Dead code: CellStyle AlibabaClone.Infrastructure/Services/PdfGenerator.cs:32 — Method CellStyle — Roslyn's SymbolFinder walked every project the solution loads, including AlibabaClone.Infrastructure, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing REDACTED · ×1

REDACTED

D4 · Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1

Members sharing a duplicated core (8 members, 50+ identical tokens) AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10 — AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/CompanyAggregates/CompanyConfiguration.cs:10-21 | AlibabaClone.Infrastructure/Configurations/LocationAggregates/CityConfiguration.cs:10-21 | AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs:11-23 | AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs:11-23 | AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs:13-25 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.

D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1

Members sharing a duplicated core (7 members, 50+ identical tokens) AlibabaClone.WebAPI/Controllers/AccountController.cs:27 — AlibabaClone.WebAPI/Controllers/AccountController.cs:27-43 | AlibabaClone.WebAPI/Controllers/AccountController.cs:47-64 | AlibabaClone.WebAPI/Controllers/AccountController.cs:68-85 | AlibabaClone.WebAPI/Controllers/AccountController.cs:89-106 | AlibabaClone.WebAPI/Controllers/AccountController.cs:200-217 | AlibabaClone.WebAPI/Controllers/AccountController.cs:222-240 | REDACTED:44-58 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.

D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1

Duplicated block (18 lines × 2) AlibabaClone.Application/DTOs/Account/PersonDto.cs:7 — AlibabaClone.Application/DTOs/Account/PersonDto.cs:7-24 | AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:7-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.

D4 · Code Duplication · Duplicated block (13 lines × 7) · ×1

Duplicated block (13 lines × 7) AlibabaClone.WebAPI/Controllers/AccountController.cs:31 — AlibabaClone.WebAPI/Controllers/AccountController.cs:31-43 | AlibabaClone.WebAPI/Controllers/AccountController.cs:52-64 | AlibabaClone.WebAPI/Controllers/AccountController.cs:73-85 | AlibabaClone.WebAPI/Controllers/AccountController.cs:94-106 | AlibabaClone.WebAPI/Controllers/AccountController.cs:205-217 | AlibabaClone.WebAPI/Controllers/AccountController.cs:228-240 | REDACTED:46-58 — there are 7 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `AlibabaClone.WebAPI/Controllers/AccountController.cs:31` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (12–13 lines × 8) · ×1

Duplicated block (12–13 lines × 8) AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10 — AlibabaClone.Infrastructure/Configurations/AccountAggregates/GenderConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/AccountAggregates/RoleConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/CompanyAggregates/CompanyConfiguration.cs:10-21 | AlibabaClone.Infrastructure/Configurations/LocationAggregates/CityConfiguration.cs:10-21 | AlibabaClone.Infrastructure/Configurations/LocationAggregates/LocationTypeConfiguration.cs:11-23 | AlibabaClone.Infrastructure/Configurations/TransactionAggregates/TransactionTypeConfiguration.cs:11-23 | AlibabaClone.Infrastructure/Configurations/TransportationAggregates/TicketStatusConfiguration.cs:10-22 | AlibabaClone.Infrastructure/Configurations/VehicleAggregates/VehicleTypeConfiguration.cs:13-25 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 8 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 8 times. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `EntityTypeBuilder<Gender>` in one and `EntityTypeBuilder<Role>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D4 · Code Duplication · Duplicated block (10 lines × 2) · ×1

Duplicated block (10 lines × 2) AlibabaClone.WebAPI/Controllers/AccountController.cs:116 — AlibabaClone.WebAPI/Controllers/AccountController.cs:116-125 | AlibabaClone.WebAPI/Controllers/AccountController.cs:134-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AlibabaClone.WebAPI/Controllers/AccountController.cs:116` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1

Duplicated block (10–11 lines × 2) AlibabaClone.WebAPI/Controllers/CouponController.cs:29 — AlibabaClone.WebAPI/Controllers/CouponController.cs:29-38 | AlibabaClone.WebAPI/Controllers/TicketOrderController.cs:32-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `AlibabaClone.WebAPI/Controllers/CouponController.cs:29` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `dto` to `CouponValidationRequestDto` in one and `CreateTicketOrderDto` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1

Duplicated block (9 lines × 3) AlibabaClone.WebAPI/Controllers/AccountController.cs:152 — AlibabaClone.WebAPI/Controllers/AccountController.cs:152-160 | AlibabaClone.WebAPI/Controllers/AccountController.cs:169-177 | AlibabaClone.WebAPI/Controllers/AccountController.cs:187-195 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AlibabaClone.WebAPI/Controllers/AccountController.cs:152` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (7 lines × 2) · ×1

Duplicated block (7 lines × 2) AlibabaClone.Application/Services/AccountService.cs:145 — AlibabaClone.Application/Services/AccountService.cs:145-151 | AlibabaClone.Application/Services/AuthService.cs:98-104 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

DM12 · Ambient inputs in the domain · Domain type reads the wall clock · ×1

Domain type reads the wall clock: Coupon AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:17 — `Coupon` reads `DateTime.UtcNow` inside `IsExpired`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.

P2 · Observability · No structured logging · ×1

No structured logging — No logging call was found in the 176 `.cs` file(s) this check read. Each was searched for the framework names `ILogger`, `Serilog`, `NLog` and `log4net`; for a call on a receiver whose name ends in `Logger`; for a `System.Diagnostics` write; for a level-gated log facade; and for the builder spellings that CONFIGURE logging for everyone else (`AddLogging(`, `ConfigureLogging(`, `UseSerilog(`, `UseNLog(`, `.Logging.Add…(`); and for emission through an `EventSource`, `ActivitySource` or `DiagnosticSource` (`WriteEvent(`, `StartActivity(`, `.Write("event", …)`). That walk sees only `.cs` documents from projects the workspace loaded, so it cannot see logging in source that did not load, in another language, or through a repo-local wrapper whose name does not end in `Logger` — this is 'no logging found by this walk', not a verdict that nothing here logs. If it is right, production issues will be hard to diagnose.

SC1 · Supply-chain hygiene · NuGet dependencies are not locked · ×1

NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.

X18 · Disposal-pattern correctness · Disposes a dependency it does not own · ×1

Disposes a dependency it does not own AlibabaClone.Infrastructure/Framework/Base/UnitOfWork.cs:16 — `_context` is never created by `UnitOfWork` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 16). Its declared type `ApplicationDBContext` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.

Minor — 86 finding(s)

DM2 · Strongly-typed ids · Primitive id on a domain type · ×23

Primitive id on a domain type: Account.PersonId AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:12 — `Account.PersonId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: BankAccountDetail.AccountId AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:7 — `BankAccountDetail.AccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Person.GenderId AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:13 — `Person.GenderId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that.
Primitive id on a domain type: Person.CreatorAccountId AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:18 — `Person.CreatorAccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Location.CityId AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:9 — `Location.CityId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Location.LocationTypeId AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:10 — `Location.LocationTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that.
Primitive id on a domain type: Transaction.TransactionTypeId AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:9 — `Transaction.TransactionTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that.
Primitive id on a domain type: Transaction.AccountId AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:10 — `Transaction.AccountId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Transaction.TicketOrderId AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:11 — `Transaction.TicketOrderId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Transaction.CouponId AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:16 — `Transaction.CouponId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Ticket.TicketOrderId AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:10 — `Ticket.TicketOrderId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Ticket.SeatId AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:11 — `Ticket.SeatId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Ticket.TravelerId AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:12 — `Ticket.TravelerId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Ticket.CompanionId AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:15 — `Ticket.CompanionId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Ticket.TicketStatusId AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:16 — `Ticket.TicketStatusId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that.
Primitive id on a domain type: TicketOrder.TransportationId AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:9 — `TicketOrder.TransportationId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: TicketOrder.BuyerId AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:10 — `TicketOrder.BuyerId` is a raw `Int64` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int64`, in whatever form your language spells that.
Primitive id on a domain type: Transportation.FromLocationId AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:10 — `Transportation.FromLocationId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Transportation.ToLocationId AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:11 — `Transportation.ToLocationId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Transportation.CompanyId AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:12 — `Transportation.CompanyId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Transportation.VehicleId AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:13 — `Transportation.VehicleId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Seat.VehicleId AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:8 — `Seat.VehicleId` is a raw `Int32` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int32`, in whatever form your language spells that.
Primitive id on a domain type: Vehicle.VehicleTypeId AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:9 — `Vehicle.VehicleTypeId` is a raw `Int16` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int16`, in whatever form your language spells that.

DM5 · Encapsulated state · Mutable entity · ×19

Mutable entity: Account AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:7 — `Account` exposes publicly writable state (PhoneNumber, Password, Email, PersonId, Person, BankAccountDetail, and 4 more).
Mutable entity: BankAccountDetail AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:5 — `BankAccountDetail` exposes publicly writable state (AccountId, BankName, CardNumber, IBAN, BankAccountNumber, Account).
Mutable entity: Gender AlibabaClone.Domain/Aggregates/AccountAggregates/Gender.cs:5 — `Gender` exposes publicly writable state (Title).
Mutable entity: Person AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:6 — `Person` exposes publicly writable state (FirstName, LastName, IdNumber, Birthdate, GenderId, PhoneNumber, and 7 more).
Mutable entity: Role AlibabaClone.Domain/Aggregates/AccountAggregates/Role.cs:5 — `Role` exposes publicly writable state (Title).
Mutable entity: Company AlibabaClone.Domain/Aggregates/CompanyAggregates/Company.cs:6 — `Company` exposes publicly writable state (Title, Transportations).
Mutable entity: City AlibabaClone.Domain/Aggregates/LocationAggregates/City.cs:5 — `City` exposes publicly writable state (Title, Locations).
Mutable entity: Location AlibabaClone.Domain/Aggregates/LocationAggregates/Location.cs:6 — `Location` exposes publicly writable state (Title, CityId, LocationTypeId, City, LocationType, DepartingTransportations, and 1 more).
Mutable entity: LocationType AlibabaClone.Domain/Aggregates/LocationAggregates/LocationType.cs:5 — `LocationType` exposes publicly writable state (Title, Locations).
Mutable entity: Coupon AlibabaClone.Domain/Aggregates/TransactionAggregates/Coupon.cs:5 — `Coupon` exposes publicly writable state (Code, MaxDiscountAmount, DiscountPercentage, ExpiryDate, MaxUsages, MaxUsagesPerAccount, and 2 more).
Mutable entity: Transaction AlibabaClone.Domain/Aggregates/TransactionAggregates/Transaction.cs:7 — `Transaction` exposes publicly writable state (TransactionTypeId, AccountId, TicketOrderId, BaseAmount, FinalAmount, SerialNumber, and 7 more).
Mutable entity: TransactionType AlibabaClone.Domain/Aggregates/TransactionAggregates/TransactionType.cs:5 — `TransactionType` exposes publicly writable state (Title).
Mutable entity: Ticket AlibabaClone.Domain/Aggregates/TransportationAggregates/Ticket.cs:7 — `Ticket` exposes publicly writable state (TicketOrderId, SeatId, TravelerId, CreatedAt, CanceledAt, CompanionId, and 8 more).
Mutable entity: TicketOrder AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketOrder.cs:7 — `TicketOrder` exposes publicly writable state (TransportationId, BuyerId, CreatedAt, SerialNumber, Description, Tickets, and 3 more).
Mutable entity: TicketStatus AlibabaClone.Domain/Aggregates/TransportationAggregates/TicketStatus.cs:5 — `TicketStatus` exposes publicly writable state (Title).
Mutable entity: Transportation AlibabaClone.Domain/Aggregates/TransportationAggregates/Transportation.cs:8 — `Transportation` exposes publicly writable state (FromLocationId, ToLocationId, CompanyId, VehicleId, StartDateTime, EndDateTime, and 7 more).
Mutable entity: Seat AlibabaClone.Domain/Aggregates/VehicleAggregates/Seat.cs:6 — `Seat` exposes publicly writable state (VehicleId, Row, Column, IsVIP, IsAvailable, Description, and 2 more).
Mutable entity: Vehicle AlibabaClone.Domain/Aggregates/VehicleAggregates/Vehicle.cs:6 — `Vehicle` exposes publicly writable state (Title, VehicleTypeId, Capacity, PlateNumber, VehicleType, Seats, and 1 more).
Mutable entity: VehicleType AlibabaClone.Domain/Aggregates/VehicleAggregates/VehicleType.cs:5 — `VehicleType` exposes publicly writable state (Title, Vehicles).

D34 · Knowledge Freshness · Orphaned file · ×12

Orphaned file AlibabaClone.Application/Services/AccountService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Services/TicketOrderService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.WebAPI/Controllers/AccountController.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Mappers/Profiles/MappingProfile.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.WebAPI/Program.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Infrastructure/Services/PdfGenerator.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Services/AuthService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Services/CouponService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Services/PersonService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Infrastructure/Seeders/DBInitializer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.Application/Services/TransportationService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file AlibabaClone.WebAPI/Controllers/TicketOrderController.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.

IC1 · Incompleteness & stubs · Commented-out code · ×8

Commented-out code AlibabaClone.Infrastructure/Services/PdfGenerator.cs:22 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/PdfGenerator.cs:23 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/PdfGenerator.cs:66 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:31 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:32 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:33 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:34 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code AlibabaClone.Infrastructure/Services/TransportationAggregates/TransportationRepository.cs:35 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).

S1 · Web-Security Posture · No security response headers detected · ×2

No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No security response headers detected AlibabaClone.WebAPI/Program.cs:26 — This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.

C4 · Data Retention · Partial data-retention evidence · ×1

Partial data-retention evidence — A retention mechanism is present, but the data-lifecycle is not yet complete — missing: a scheduled purge / cleanup job (PurgeOlderThan / CleanupJob), a documented retention period / data-expiry.

D19 · Documentation Quality · Documentation · ×1

Documentation: no contributor guidance README.md — The README mentions 'Contribute' but does not explain how contributors can submit pull requests (e.g. create an issue, set up local repos). Add Contributing guidance covering the process for submitting code changes and fixing bugs.

D20 · ADR Quality · No ADRs found · ×1

No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.

D21 · Naming Consistency · Migration class names use inconsistent casing conventions · ×1

Migration class names use inconsistent casing conventions: PascalCase (`AdjustDatabaseforProfilePage`) vs camelCase (`updatecoupon`). — Standardize all migration class names to PascalCase (e.g., `AdjustDatabaseForProfilePage`, `UpdateCoupon`). (symbols: AlibabaClone.Infrastructure.Migrations.AdjustDatabaseforProfilePage, AlibabaClone.Infrastructure.Migrations.updatecoupon)

D24 · Comment Value · misleading comment · ×1

misleading comment AlibabaClone.Application/Interfaces/IPersonService.cs:8 — "Returns PersonId" — The method returns Task<Result<long>>; the comment is wrong and must be removed from UpsertAccountPersonAsync.

D31 · IaC & Container Security · Low IaC · ×1

REDACTED

D34 · Knowledge Freshness · Orphaned files with no living knowledge · ×1

Orphaned files with no living knowledge — 12 of 12 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 12 of the 147 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: AlibabaClone.Application/Services/AccountService.cs, AlibabaClone.Application/Services/TicketOrderService.cs, AlibabaClone.Application/Mappers/Profiles/MappingProfile.cs, AlibabaClone.WebAPI/Program.cs, AlibabaClone.WebAPI/Controllers/AccountController.cs, AlibabaClone.Application/Services/AuthService.cs, AlibabaClone.Application/Services/CouponService.cs, AlibabaClone.Application/Services/PersonService.cs (and 4 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D39 · IL Efficiency · IL efficiency · ×1

IL efficiency: 6 authored method(s) exceed the IL budget AlibabaClone.Application/Mappers/Profiles/MappingProfile.cs:17 — 6 of 223 first-party methods compile to oversized IL bodies (> 250 instructions); worst: AlibabaClone.Application.Mappers.Profiles.MappingProfile..ctor @ AlibabaClone.Application/Mappers/Profiles/MappingProfile.cs:17, 1444 IL instructions; that pulled this dimension to 9.5/10. These bodies are far past the JIT's inline budget, so splitting them does not make them inlinable — what moves the number is emitting less: collapsing LINQ chains and closures on hot paths, and interpolation built eagerly where it is only sometimes used.

D9 · Test Distribution · No tests found · ×1

No tests found — No test suite could be collected — no discoverable tests to count. If this repository does test, wiring the suite to a framework a runner can collect (xUnit, NUnit or MSTest) is what makes it countable here; a pipeline step that invokes a runner is not evidence on its own, because a runner over an empty suite passes. Tests written as plain executables or shell/PowerShell harnesses are not collectible this way and are not scored here.

DM9 · Scattered domain decisions · Rule about [CreatorAccountId, IdNumber] decided in 2 places · ×1

Rule about [CreatorAccountId, IdNumber] decided in 2 places — AlibabaClone.Domain.Aggregates.AccountAggregates.Person's [CreatorAccountId, IdNumber] are judged in AlibabaClone.Application.Services.PersonService, AlibabaClone.Application.Services.TicketOrderService — the same decision, restated. Every copy is a chance to drift, and copies drift silently because each one looks correct on its own. Move the judgement onto the type that owns the members and let the call sites ask it.

M2 · Architecture documentation · No ADRs · ×1

No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

M3 · Folder & project structure · No src/ separation · ×1

No src/ separation — Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.

M4 · Documentation accuracy · README/code drift · ×1

README/code drift README.md:463 — README advertises a microservices architecture, but the repo is a single project with no service manifests — searched for: `microservice`, `service-mesh`, `istio`. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest and configuration files (package.json and other *.json, *.csproj, *.props, *.sln/*.slnx, *.yml, *.toml, *.config, tool configs such as eslint.config.js, REDACTED); the README's own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read — a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong.

P3 · Security & performance tooling · No SAST · ×1

No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1732 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

P4 · Deployment & Rollback · No rollback/health safety · ×1

No rollback/health safety — Deployment automation exists but no readiness/liveness probes, rolling-update strategy, lifecycle hooks or migration job were evidenced — a bad release is harder to detect and reverse.

X10 · Duplicated predicate · Duplicated predicate · ×1

Duplicated predicate AlibabaClone.Application/Services/AccountService.cs:145 — `string.IsNullOrWhiteSpace(password) || password.Length < 8` appears character-identically in 2 files — AlibabaClone.Application/Services/AccountService.cs, AlibabaClone.Application/Services/AuthService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.

X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1

Not all async methods take a CancellationToken — Only 0/65 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.

X5 · Nullable reference types · Null-forgiving operator (`!`) suppressions reduce the NRT score · ×1

Null-forgiving operator (`!`) suppressions reduce the NRT score — ~0.1 `!` suppressions per 1k syntax nodes — 7 suppression(s) across the 69443 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.

Minor — 18 finding(s)

D12 · Dependency Hygiene · Outdated · ×14

Outdated: AutoMapper — REDACTED → 16.2.0 available (referenced by AlibabaClone.WebAPI).
Outdated: DotNetEnv — DotNetEnv 3.1.1 → 3.2.0 available (referenced by AlibabaClone.WebAPI).
Outdated: Microsoft.AspNetCore.Authentication.JwtBearer — Microsoft.AspNetCore.Authentication.JwtBearer 8.0.17 → 10.0.13 available (referenced by AlibabaClone.WebAPI).
Outdated: Microsoft.EntityFrameworkCore.Design — Microsoft.EntityFrameworkCore.Design 9.0.6 → 10.0.13 available (referenced by AlibabaClone.WebAPI).
Outdated: Newtonsoft.Json — Newtonsoft.Json 13.0.3 → 13.0.4 available (referenced by AlibabaClone.WebAPI).
Outdated: Swashbuckle.AspNetCore — Swashbuckle.AspNetCore 9.0.1 → 10.3.1 available (referenced by AlibabaClone.WebAPI).
Outdated: Swashbuckle.AspNetCore.Swagger — Swashbuckle.AspNetCore.Swagger 9.0.1 → 10.3.1 available (referenced by AlibabaClone.WebAPI).
Outdated: System.IdentityModel.Tokens.Jwt — System.IdentityModel.Tokens.Jwt 8.12.1 → 8.23.0 available (referenced by AlibabaClone.WebAPI).
Outdated: Microsoft.Extensions.DependencyInjection — Microsoft.Extensions.DependencyInjection 9.0.6 → 10.0.13 available (referenced by AlibabaClone.Application).
Outdated: Microsoft.EntityFrameworkCore — Microsoft.EntityFrameworkCore 9.0.6 → 10.0.13 available (referenced by AlibabaClone.Infrastructure).
Outdated: Microsoft.EntityFrameworkCore.Proxies — Microsoft.EntityFrameworkCore.Proxies 9.0.6 → 10.0.13 available (referenced by AlibabaClone.Infrastructure).
Outdated: Microsoft.EntityFrameworkCore.SqlServer — Microsoft.EntityFrameworkCore.SqlServer 9.0.6 → 10.0.13 available (referenced by AlibabaClone.Infrastructure).
Outdated: Microsoft.EntityFrameworkCore.Tools — Microsoft.EntityFrameworkCore.Tools 9.0.6 → 10.0.13 available (referenced by AlibabaClone.Infrastructure).
Outdated: QuestPDF — QuestPDF 2025.5.1 → 2026.9.1 available (referenced by AlibabaClone.Infrastructure).

D19 · Documentation Quality · XML-doc coverage · ×4

XML-doc coverage: AlibabaClone.WebAPI AlibabaClone.WebAPI/AlibabaClone.WebAPI.csproj — AlibabaClone.WebAPI: 0 % XML-doc coverage (0/43).
XML-doc coverage: AlibabaClone.Application REDACTED — AlibabaClone.Application: 0 % XML-doc coverage (0/212).
XML-doc coverage: AlibabaClone.Domain AlibabaClone.Domain/AlibabaClone.Domain.csproj — AlibabaClone.Domain: 0 % XML-doc coverage (0/182).
XML-doc coverage: AlibabaClone.Infrastructure AlibabaClone.Infrastructure/AlibabaClone.Infrastructure.csproj — AlibabaClone.Infrastructure: 6 % XML-doc coverage (8/145).

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

Dimension	Tool	Version	Command	Findings	Raw output
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-1b84013ee1cb45db93eb0a811d06b8f9/history.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-history.json
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-1b84013ee1cb45db93eb0a811d06b8f9/tree.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)	semgrep	—	semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .	16	artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilities	dotnet	—	dotnet list AlibabaClone-Backend.sln package --vulnerable --include-transitive --format json	1	artifacts/raw/dotnet-vulnerable.json
D31 · IaC & Container Security	trivy	—	trivy config --format json --quiet .	4	artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)	semgrep	—	semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.	0	—
D37 · Vulnerability-disclosure Policy	disclosure	—	disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.	0	—
D40 · Network Egress Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.	0	—
D41 · Kernel & Syscall Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.	0	—
D42 · Runtime Threat Enforcement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.	0	—
D43 · Malicious Dependencies	none (no readable dependency manifest)	—	none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).	0	—

Run 01a16008-c22d-753f-ab0c-36379b2fe9ef · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Appendix C — Personal-data map

Every field, property and record parameter whose name is conventional personal data — 40 field(s) across 6 categories, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.

Name — 14 field(s)

PersonDto.FirstName AlibabaClone.Application/DTOs/Account/PersonDto.cs:10
PersonDto.LastName AlibabaClone.Application/DTOs/Account/PersonDto.cs:12
PersonDto.EnglishFirstName AlibabaClone.Application/DTOs/Account/PersonDto.cs:23
PersonDto.EnglishLastName AlibabaClone.Application/DTOs/Account/PersonDto.cs:24
ProfileDto.FirstName AlibabaClone.Application/DTOs/Account/ProfileDto.cs:5
ProfileDto.LastName AlibabaClone.Application/DTOs/Account/ProfileDto.cs:6
CreateTravelerTicketDto.FirstName AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:10
CreateTravelerTicketDto.LastName AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:12
CreateTravelerTicketDto.EnglishFirstName AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:23
CreateTravelerTicketDto.EnglishLastName AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:24
Person.FirstName AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:8
Person.LastName AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:9
Person.EnglishFirstName AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:16
Person.EnglishLastName AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:17

Phone — 10 field(s)

AccountDto.PhoneNumber AlibabaClone.Application/DTOs/Account/AccountDTO.cs:6
PersonDto.PhoneNumber AlibabaClone.Application/DTOs/Account/PersonDto.cs:20
ProfileDto.AccountPhoneNumber AlibabaClone.Application/DTOs/Account/ProfileDto.cs:7
ProfileDto.PersonPhoneNumber AlibabaClone.Application/DTOs/Account/ProfileDto.cs:11
AuthResponseDto.PhoneNumber AlibabaClone.Application/DTOs/Authentication/AuthResponseDto.cs:7
LoginRequestDto.PhoneNumber AlibabaClone.Application/DTOs/Authentication/LoginRequestDto.cs:5
RegisterRequestDto.PhoneNumber AlibabaClone.Application/DTOs/Authentication/RegisterRequestDto.cs:9
CreateTravelerTicketDto.PhoneNumber AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:20
Account.PhoneNumber AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:9
Person.PhoneNumber AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:14

Financial (card / IBAN) — 6 field(s)

ProfileDto.IBAN AlibabaClone.Application/DTOs/Account/ProfileDto.cs:14
ProfileDto.CardNumber AlibabaClone.Application/DTOs/Account/ProfileDto.cs:16
UpsertBankAccountDetailDto.IBAN AlibabaClone.Application/DTOs/Account/UpsertBankAccountDetailDto.cs:5
UpsertBankAccountDetailDto.CardNumber AlibabaClone.Application/DTOs/Account/UpsertBankAccountDetailDto.cs:6
BankAccountDetail.CardNumber AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:9
BankAccountDetail.IBAN AlibabaClone.Domain/Aggregates/AccountAggregates/BankAccountDetail.cs:10

Date of birth — 5 field(s)

PersonDto.BirthDate AlibabaClone.Application/DTOs/Account/PersonDto.cs:22
ProfileDto.BirthDate AlibabaClone.Application/DTOs/Account/ProfileDto.cs:12
CreateTravelerTicketDto.BirthDate AlibabaClone.Application/DTOs/Transportation/CreateTravelerTicketDto.cs:22
TravelerTicketDto.BirthDate AlibabaClone.Application/DTOs/Transportation/TravelerTicketDto.cs:8
Person.Birthdate AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:12

Email — 4 field(s)

AccountDto.Email AlibabaClone.Application/DTOs/Account/AccountDTO.cs:8
EditEmailDto.NewEmail AlibabaClone.Application/DTOs/Account/EditEmailDto.cs:8
ProfileDto.Email AlibabaClone.Application/DTOs/Account/ProfileDto.cs:8
Account.Email AlibabaClone.Domain/Aggregates/AccountAggregates/Account.cs:11

Government ID (SSN / passport / tax) — 1 field(s)

Person.PassportNumber AlibabaClone.Domain/Aggregates/AccountAggregates/Person.cs:15

Findings by how serious they are

This survey was produced by

Executive summary

Top priorities

Diagnosis: what the measurements show together

Architecture — module dependency graph

Architecture: which parts of the code depend on which

At a glance — Code Health · 80% · Strong ·

At a glance — Architecture · 87% · Strong ·

At a glance — Maturity · 59% · Adequate · gated by D34 ·

At a glance — Readiness · 26% · Weak · gated by D8, D9, P2, P3 ·

At a glance — Security · 60% · Adequate · gated by D29, D36 ·

At a glance — Domain Modelling · 47% · Weak · gated by DM2, DM4, DM7 ·

At a glance — Performance · 100% · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Roadmap

File quality

How the grades work

Methodology & how to trust this report

Tools & methods

Run transparency — what happened this run

Limitations & what we did not check

Per-dimension blind spots

The LLM boundary

Dimensions

Frontend & cross-cutting dimensions

Reference — by lens

Appendix A — Findings (grouped)

Appendix B — Reproduction & audit trail

Appendix C — Personal-data map

Downloadable artifacts