Public report of OrchardCMS/OrchardCore, published 23 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 23 October 2026, 11:26 UTC · Survey ID cd_0eed50c8ab90475fb0a789b902c3379c
OrchardCMS/OrchardCore
Measured 23 October 2026, 11:00 UTC, at code version 462f4ae
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
Code coverage is not measured: .NET suite (CouldNotMeasureNoCollector).
Boundary Type-Coupling is not measured: Bounded contexts not declared.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
Down 5 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 305,555 lines of product code in 257 projects, tests not counted · Estimated rebuild effort: about 7.1 person-years · Weakest lens: Production Readiness, 35
Findings by how serious they are
287 critical1926 serious455 minor
5 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
23 October 2026, 11:00 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
101of 106 dimensions measured by tools. The other 5 are advisory notes from an AI model, which explain the code but don't count towards the score.
2635of 2668 findings point to an exact file and line, so you can open each one in the code. The other 33 concern the repository as a whole, such as missing documentation.
106dimensions across 8 lenses, read from 305,555 lines of product code in 257 projects.
OrchardCMS/OrchardCore scores 44 out of 100 and is rated Weak, while six of its eight lenses score higher still: Event-Driven at 100, rated Exemplary, Performance at 76 and Maturity at 75, both rated Strong, and Security and Compliance at 76, Architecture at 55 and Code Health at 54, all rated Adequate.
The score is lower than those six because the weakest lens counts most, and here that is Production Readiness, which scores 35 and is rated Weak. Its Secret Scanning dimension scores 0 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to resolve the 10 Leaked secret finding(s) in Secret Scanning and to remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies, and if Production Readiness rose to 70, the score would rise from 44 to about 50.
287 findings are critical: 63 in Explicit Debt, 57 in Dependency Vulnerabilities, 39 in Forms & labels, 33 in Captive dependencies, 24 in Dependency Hygiene, 19 in Project dependency cycles, 18 in Keyboard semantics, ten in Secret Scanning, eight in Static Analysis (SAST), seven in Text alternatives, five in Coupling, two in Change Coupling and two in Page structure.
Watchdog couldn't measure 4 dimensions in this code, among them Dependency Hygiene, Secrets (history) and CQS / query purity, so they are left out of the score. The product code is 305,555 lines, which would take an estimated 7.1 person-years, around €1,000,000, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Production Readiness rose from 35 to 70, the lowest score rated Strong, the score would rise from 44 to about 50.
Code composition: what the lines of code are
Business logic 31%Supporting code 43%Tests 26%Code analyzers 0%
New since the last survey: 452 findings
These 452 critical or serious findings weren't in the previous survey, on 9 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
God Classes · TooManyMethods: ExcelDataFileFormat src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs
God Classes · ClassTooLong: DataPipelineDesignerController src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs
God Classes · TooManyMethods: ExpressionFunctions src/OrchardCore/OrchardCore.DataSources.Core/Expressions/ExpressionFunctions.cs
God Classes · FunctionTooLong: designerStore.createDesignerStore src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/state/designerStore.ts
God Classes · FunctionTooLong: flows.edit.document.addEventListener("DOMContentLoaded") src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts
God Classes · FileTooLong: Files/ExcelDataFileFormat.cs src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs
Code Duplication · Edited copy of a member (12 corresponding lines) src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs
Code Duplication · Members sharing a duplicated core (10 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs
Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) REDACTED
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 1985 findings
These 1985 critical or serious findings were in the previous survey, on 9 October 2026, and are gone from this one. The first 100 are listed here.
God Classes · FileTooLong: REDACTED src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs
Code Duplication · Edited copy of a member (13 corresponding lines) src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs
Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) REDACTED
Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Facebook/AdminMenuLogin.cs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED
€340,000 to €1,700,000, for 5,585 to 18,106 hours of work, about 7.1 person-years for 4 to 14 engineers
Difficulty of the problem
Very high, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 44. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 305,555 lines of product code
Comment lines
The estimate prices 277,672 lines. Comment lines count towards the size of 305,555 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 10 Leaked secret finding(s) in Secret Scanning — start with REDACTED (2), REDACTED, REDACTED.
Raises the score by about 7 points · Medium effort · Secret Scanning
2
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
Resolve the 9 WriteOnlyPrivateField finding(s) in Explicit Debt — start with REDACTED (3), ExternalAuthenticationsController.cs (2), AdminMenu.cs.
Raises the score by about 2 points · Low effort · Explicit Debt
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €1,000,000 to build again, about 7.1 person-years of work. Its weakest lens is Production Readiness, at 35 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 10 Leaked secret finding(s) in Secret Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for medium effort, because it clears the 10 Secret Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — bounded-context dependency graph
Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
1351 modules, with 4121 dependencies between them. 19 loops run through 107 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 1311 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
ContentManagement.Metadata.Models uses ContentManagement, so a change to ContentManagement can break ContentManagement.Metadata.Models, while a change to ContentManagement.Metadata.Models can't break ContentManagement.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
6→11 DisplayManagement.Views uses DisplayManagement.Handlerspart of a loop✕
Connections
9 pairs of types, where a type in DisplayManagement.Views uses a type in DisplayManagement.Handlers.
DisplayManagement.Views uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break DisplayManagement.Views, while a change to DisplayManagement.Views can't break DisplayManagement.Handlers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
6→13 DisplayManagement.Views uses DisplayManagement.Descriptorspart of a loop✕
Connections
2 pairs of types, where a type in DisplayManagement.Views uses a type in DisplayManagement.Descriptors.
DisplayManagement.Views uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break DisplayManagement.Views, while a change to DisplayManagement.Views can't break DisplayManagement.Descriptors.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
6→15 DisplayManagement.Views uses DisplayManagementpart of a loop✕
Connections
4 pairs of types, where a type in DisplayManagement.Views uses a type in DisplayManagement.
DisplayManagement.Views uses DisplayManagement, so a change to DisplayManagement can break DisplayManagement.Views, while a change to DisplayManagement.Views can't break DisplayManagement.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Environment.Shell uses Environment.Extensions, so a change to Environment.Extensions can break Environment.Shell, while a change to Environment.Shell can't break Environment.Extensions.
Position
Below the diagonal: Environment.Shell uses a module listed above it, which is the healthy direction.
7→12 Environment.Shell uses Environment.Shell.Configurationpart of a loop✕
Connections
5 pairs of types, where a type in Environment.Shell uses a type in Environment.Shell.Configuration.
Environment.Shell uses Environment.Shell.Configuration, so a change to Environment.Shell.Configuration can break Environment.Shell, while a change to Environment.Shell can't break Environment.Shell.Configuration.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
8→18 Security.Permissions uses Localizationpart of a loop✕
Connections
2 pairs of types, where a type in Security.Permissions uses a type in Localization.
Security.Permissions uses Localization, so a change to Localization can break Security.Permissions, while a change to Security.Permissions can't break Localization.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
ContentManagement.Metadata uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentManagement.Metadata, while a change to ContentManagement.Metadata can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentManagement.Metadata uses a module listed above it, which is the healthy direction.
Data.Documents uses Environment.Shell, so a change to Environment.Shell can break Data.Documents, while a change to Data.Documents can't break Environment.Shell.
Position
Below the diagonal: Data.Documents uses a module listed above it, which is the healthy direction.
DisplayManagement.Handlers uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break DisplayManagement.Handlers, while a change to DisplayManagement.Handlers can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: DisplayManagement.Handlers uses a module listed above it, which is the healthy direction.
DisplayManagement.Handlers uses DisplayManagement.Views, so a change to DisplayManagement.Views can break DisplayManagement.Handlers, while a change to DisplayManagement.Handlers can't break DisplayManagement.Views.
Position
Below the diagonal: DisplayManagement.Handlers uses a module listed above it, which is the healthy direction.
11→13 DisplayManagement.Handlers uses DisplayManagement.Descriptorspart of a loop✕
Connections
2 pairs of types, where a type in DisplayManagement.Handlers uses a type in DisplayManagement.Descriptors.
DisplayManagement.Handlers uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break DisplayManagement.Handlers, while a change to DisplayManagement.Handlers can't break DisplayManagement.Descriptors.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
11→15 DisplayManagement.Handlers uses DisplayManagementpart of a loop✕
Connections
11 pairs of types, where a type in DisplayManagement.Handlers uses a type in DisplayManagement.
DisplayManagement.Handlers uses DisplayManagement, so a change to DisplayManagement can break DisplayManagement.Handlers, while a change to DisplayManagement.Handlers can't break DisplayManagement.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Environment.Shell.Configuration uses Environment.Shell, so a change to Environment.Shell can break Environment.Shell.Configuration, while a change to Environment.Shell.Configuration can't break Environment.Shell.
Position
Below the diagonal: Environment.Shell.Configuration uses a module listed above it, which is the healthy direction.
DisplayManagement.Descriptors uses Environment.Extensions, so a change to Environment.Extensions can break DisplayManagement.Descriptors, while a change to DisplayManagement.Descriptors can't break Environment.Extensions.
Position
Below the diagonal: DisplayManagement.Descriptors uses a module listed above it, which is the healthy direction.
DisplayManagement.Descriptors uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break DisplayManagement.Descriptors, while a change to DisplayManagement.Descriptors can't break DisplayManagement.Handlers.
Position
Below the diagonal: DisplayManagement.Descriptors uses a module listed above it, which is the healthy direction.
13→15 DisplayManagement.Descriptors uses DisplayManagementpart of a loop✕
Connections
1 pair of types, where a type in DisplayManagement.Descriptors uses a type in DisplayManagement.
DisplayManagement.Descriptors uses DisplayManagement, so a change to DisplayManagement can break DisplayManagement.Descriptors, while a change to DisplayManagement.Descriptors can't break DisplayManagement.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
DisplayManagement uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break DisplayManagement, while a change to DisplayManagement can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: DisplayManagement uses a module listed above it, which is the healthy direction.
DisplayManagement uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break DisplayManagement, while a change to DisplayManagement can't break DisplayManagement.Handlers.
Position
Below the diagonal: DisplayManagement uses a module listed above it, which is the healthy direction.
DisplayManagement uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break DisplayManagement, while a change to DisplayManagement can't break DisplayManagement.Descriptors.
Position
Below the diagonal: DisplayManagement uses a module listed above it, which is the healthy direction.
DisplayManagement.Notify uses DisplayManagement, so a change to DisplayManagement can break DisplayManagement.Notify, while a change to DisplayManagement.Notify can't break DisplayManagement.
Position
Below the diagonal: DisplayManagement.Notify uses a module listed above it, which is the healthy direction.
Navigation uses Security.Permissions, so a change to Security.Permissions can break Navigation, while a change to Navigation can't break Security.Permissions.
Position
Below the diagonal: Navigation uses a module listed above it, which is the healthy direction.
Navigation uses Environment.Shell.Configuration, so a change to Environment.Shell.Configuration can break Navigation, while a change to Navigation can't break Environment.Shell.Configuration.
Position
Below the diagonal: Navigation uses a module listed above it, which is the healthy direction.
Navigation uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break Navigation, while a change to Navigation can't break DisplayManagement.Descriptors.
Position
Below the diagonal: Navigation uses a module listed above it, which is the healthy direction.
Localization uses Environment.Extensions, so a change to Environment.Extensions can break Localization, while a change to Localization can't break Environment.Extensions.
Position
Below the diagonal: Localization uses a module listed above it, which is the healthy direction.
Localization uses Environment.Shell, so a change to Environment.Shell can break Localization, while a change to Localization can't break Environment.Shell.
Position
Below the diagonal: Localization uses a module listed above it, which is the healthy direction.
Localization uses Security.Permissions, so a change to Security.Permissions can break Localization, while a change to Localization can't break Security.Permissions.
Position
Below the diagonal: Localization uses a module listed above it, which is the healthy direction.
ContentManagement.Handlers uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentManagement.Handlers, while a change to ContentManagement.Handlers can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentManagement.Handlers uses a module listed above it, which is the healthy direction.
ContentManagement.Handlers uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break ContentManagement.Handlers, while a change to ContentManagement.Handlers can't break ContentManagement.Metadata.
Position
Below the diagonal: ContentManagement.Handlers uses a module listed above it, which is the healthy direction.
ContentManagement.Handlers uses Modules, so a change to Modules can break ContentManagement.Handlers, while a change to ContentManagement.Handlers can't break Modules.
Position
Below the diagonal: ContentManagement.Handlers uses a module listed above it, which is the healthy direction.
20→24 ContentManagement.Handlers uses ContentManagementpart of a loop✕
Connections
43 pairs of types, where a type in ContentManagement.Handlers uses a type in ContentManagement. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
ContentManagement.Handlers uses ContentManagement, so a change to ContentManagement can break ContentManagement.Handlers, while a change to ContentManagement.Handlers can't break ContentManagement.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Data.Migration uses Environment.Extensions, so a change to Environment.Extensions can break Data.Migration, while a change to Data.Migration can't break Environment.Extensions.
Position
Below the diagonal: Data.Migration uses a module listed above it, which is the healthy direction.
Data.Migration uses Environment.Shell, so a change to Environment.Shell can break Data.Migration, while a change to Data.Migration can't break Environment.Shell.
Position
Below the diagonal: Data.Migration uses a module listed above it, which is the healthy direction.
ContentManagement uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break ContentManagement, while a change to ContentManagement can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: ContentManagement uses a module listed above it, which is the healthy direction.
ContentManagement uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentManagement, while a change to ContentManagement can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentManagement uses a module listed above it, which is the healthy direction.
ContentManagement uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break ContentManagement, while a change to ContentManagement can't break ContentManagement.Metadata.
Position
Below the diagonal: ContentManagement uses a module listed above it, which is the healthy direction.
ContentManagement uses Data.Documents, so a change to Data.Documents can break ContentManagement, while a change to ContentManagement can't break Data.Documents.
Position
Below the diagonal: ContentManagement uses a module listed above it, which is the healthy direction.
ContentManagement uses ContentManagement.Handlers, so a change to ContentManagement.Handlers can break ContentManagement, while a change to ContentManagement can't break ContentManagement.Handlers.
Position
Below the diagonal: ContentManagement uses a module listed above it, which is the healthy direction.
Deployment uses Security.Permissions, so a change to Security.Permissions can break Deployment, while a change to Deployment can't break Security.Permissions.
Position
Below the diagonal: Deployment uses a module listed above it, which is the healthy direction.
ContentManagement.Display.Models uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentManagement.Display.Models, while a change to ContentManagement.Display.Models can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentManagement.Display.Models uses a module listed above it, which is the healthy direction.
ContentManagement.Display.Models uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break ContentManagement.Display.Models, while a change to ContentManagement.Display.Models can't break DisplayManagement.Handlers.
Position
Below the diagonal: ContentManagement.Display.Models uses a module listed above it, which is the healthy direction.
ContentManagement.Display.Models uses ContentManagement, so a change to ContentManagement can break ContentManagement.Display.Models, while a change to ContentManagement.Display.Models can't break ContentManagement.
Position
Below the diagonal: ContentManagement.Display.Models uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in ContentTypes.Editors uses a type in ContentManagement.Metadata.Models. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
ContentTypes.Editors uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses DisplayManagement.Views, so a change to DisplayManagement.Views can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break DisplayManagement.Views.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break ContentManagement.Metadata.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break DisplayManagement.Handlers.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break DisplayManagement.Descriptors.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses DisplayManagement, so a change to DisplayManagement can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break DisplayManagement.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
ContentTypes.Editors uses ContentManagement, so a change to ContentManagement can break ContentTypes.Editors, while a change to ContentTypes.Editors can't break ContentManagement.
Position
Below the diagonal: ContentTypes.Editors uses a module listed above it, which is the healthy direction.
Indexing uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break Indexing, while a change to Indexing can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: Indexing uses a module listed above it, which is the healthy direction.
Indexing uses Security.Permissions, so a change to Security.Permissions can break Indexing, while a change to Indexing can't break Security.Permissions.
Position
Below the diagonal: Indexing uses a module listed above it, which is the healthy direction.
Indexing uses ContentManagement.Handlers, so a change to ContentManagement.Handlers can break Indexing, while a change to Indexing can't break ContentManagement.Handlers.
Position
Below the diagonal: Indexing uses a module listed above it, which is the healthy direction.
Recipes.Services uses Environment.Extensions, so a change to Environment.Extensions can break Recipes.Services, while a change to Recipes.Services can't break Environment.Extensions.
Position
Below the diagonal: Recipes.Services uses a module listed above it, which is the healthy direction.
Recipes.Services uses Recipes.Models, so a change to Recipes.Models can break Recipes.Services, while a change to Recipes.Services can't break Recipes.Models.
Position
Below the diagonal: Recipes.Services uses a module listed above it, which is the healthy direction.
Recipes.Services uses Environment.Shell, so a change to Environment.Shell can break Recipes.Services, while a change to Recipes.Services can't break Environment.Shell.
Position
Below the diagonal: Recipes.Services uses a module listed above it, which is the healthy direction.
Recipes.Services uses Data.Migration, so a change to Data.Migration can break Recipes.Services, while a change to Recipes.Services can't break Data.Migration.
Position
Below the diagonal: Recipes.Services uses a module listed above it, which is the healthy direction.
Workflows.Services uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break Workflows.Services, while a change to Workflows.Services can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
52 pairs of types, where a type in Workflows.Services uses a type in Workflows.Models. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Workflows.Services uses Workflows.Models, so a change to Workflows.Models can break Workflows.Services, while a change to Workflows.Services can't break Workflows.Models.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
Workflows.Services uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break Workflows.Services, while a change to Workflows.Services can't break DisplayManagement.Handlers.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
Workflows.Services uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break Workflows.Services, while a change to Workflows.Services can't break DisplayManagement.Descriptors.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
Workflows.Services uses DisplayManagement, so a change to DisplayManagement can break Workflows.Services, while a change to Workflows.Services can't break DisplayManagement.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
Workflows.Services uses ContentManagement, so a change to ContentManagement can break Workflows.Services, while a change to Workflows.Services can't break ContentManagement.
Position
Below the diagonal: Workflows.Services uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses DisplayManagement.Views, so a change to DisplayManagement.Views can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break DisplayManagement.Views.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break DisplayManagement.Handlers.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses DisplayManagement, so a change to DisplayManagement can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break DisplayManagement.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses ContentManagement, so a change to ContentManagement can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break ContentManagement.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
ContentManagement.Display.ContentDisplay uses ContentManagement.Display.Models, so a change to ContentManagement.Display.Models can break ContentManagement.Display.ContentDisplay, while a change to ContentManagement.Display.ContentDisplay can't break ContentManagement.Display.Models.
Position
Below the diagonal: ContentManagement.Display.ContentDisplay uses a module listed above it, which is the healthy direction.
Settings uses Security.Permissions, so a change to Security.Permissions can break Settings, while a change to Settings can't break Security.Permissions.
Position
Below the diagonal: Settings uses a module listed above it, which is the healthy direction.
Settings uses Environment.Shell.Configuration, so a change to Environment.Shell.Configuration can break Settings, while a change to Settings can't break Environment.Shell.Configuration.
Position
Below the diagonal: Settings uses a module listed above it, which is the healthy direction.
DisplayManagement.Entities uses DisplayManagement.Views, so a change to DisplayManagement.Views can break DisplayManagement.Entities, while a change to DisplayManagement.Entities can't break DisplayManagement.Views.
Position
Below the diagonal: DisplayManagement.Entities uses a module listed above it, which is the healthy direction.
DisplayManagement.Entities uses DisplayManagement.Handlers, so a change to DisplayManagement.Handlers can break DisplayManagement.Entities, while a change to DisplayManagement.Entities can't break DisplayManagement.Handlers.
Position
Below the diagonal: DisplayManagement.Entities uses a module listed above it, which is the healthy direction.
DisplayManagement.Entities uses DisplayManagement, so a change to DisplayManagement can break DisplayManagement.Entities, while a change to DisplayManagement.Entities can't break DisplayManagement.
Position
Below the diagonal: DisplayManagement.Entities uses a module listed above it, which is the healthy direction.
DisplayManagement.Entities uses Settings, so a change to Settings can break DisplayManagement.Entities, while a change to DisplayManagement.Entities can't break Settings.
Position
Below the diagonal: DisplayManagement.Entities uses a module listed above it, which is the healthy direction.
Media.Services uses Environment.Shell, so a change to Environment.Shell can break Media.Services, while a change to Media.Services can't break Environment.Shell.
Position
Below the diagonal: Media.Services uses a module listed above it, which is the healthy direction.
Media.Services uses Security.Permissions, so a change to Security.Permissions can break Media.Services, while a change to Media.Services can't break Security.Permissions.
Position
Below the diagonal: Media.Services uses a module listed above it, which is the healthy direction.
Media.Services uses Environment.Shell.Configuration, so a change to Environment.Shell.Configuration can break Media.Services, while a change to Media.Services can't break Environment.Shell.Configuration.
Position
Below the diagonal: Media.Services uses a module listed above it, which is the healthy direction.
Media.Services uses ContentManagement, so a change to ContentManagement can break Media.Services, while a change to Media.Services can't break ContentManagement.
Position
Below the diagonal: Media.Services uses a module listed above it, which is the healthy direction.
33 pairs of types, where a type in Media.Services uses a type in Media. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Admin uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break Admin, while a change to Admin can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: Admin uses a module listed above it, which is the healthy direction.
Admin uses Environment.Shell.Configuration, so a change to Environment.Shell.Configuration can break Admin, while a change to Admin can't break Environment.Shell.Configuration.
Position
Below the diagonal: Admin uses a module listed above it, which is the healthy direction.
Admin uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break Admin, while a change to Admin can't break DisplayManagement.Descriptors.
Position
Below the diagonal: Admin uses a module listed above it, which is the healthy direction.
Liquid uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break Liquid, while a change to Liquid can't break ContentManagement.Metadata.
Position
Below the diagonal: Liquid uses a module listed above it, which is the healthy direction.
Media uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break Media, while a change to Media can't break ContentManagement.Metadata.
Position
Below the diagonal: Media uses a module listed above it, which is the healthy direction.
Users uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break Users, while a change to Users can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: Users uses a module listed above it, which is the healthy direction.
Users uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break Users, while a change to Users can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: Users uses a module listed above it, which is the healthy direction.
Users uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break Users, while a change to Users can't break ContentManagement.Metadata.
Position
Below the diagonal: Users uses a module listed above it, which is the healthy direction.
Users uses DisplayManagement.Descriptors, so a change to DisplayManagement.Descriptors can break Users, while a change to Users can't break DisplayManagement.Descriptors.
Position
Below the diagonal: Users uses a module listed above it, which is the healthy direction.
Users.Services uses DisplayManagement.ModelBinding, so a change to DisplayManagement.ModelBinding can break Users.Services, while a change to Users.Services can't break DisplayManagement.ModelBinding.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses ContentManagement.Metadata.Models, so a change to ContentManagement.Metadata.Models can break Users.Services, while a change to Users.Services can't break ContentManagement.Metadata.Models.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses Security.Permissions, so a change to Security.Permissions can break Users.Services, while a change to Users.Services can't break Security.Permissions.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses ContentManagement.Metadata, so a change to ContentManagement.Metadata can break Users.Services, while a change to Users.Services can't break ContentManagement.Metadata.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses DisplayManagement, so a change to DisplayManagement can break Users.Services, while a change to Users.Services can't break DisplayManagement.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses ContentManagement, so a change to ContentManagement can break Users.Services, while a change to Users.Services can't break ContentManagement.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Users.Services uses Recipes.Services, so a change to Recipes.Services can break Users.Services, while a change to Users.Services can't break Recipes.Services.
Position
Below the diagonal: Users.Services uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
131
High / Critical
A03:2025 — Software Supply Chain Failures
89
High / Critical
A07:2025 — Authentication Failures
10
High / Critical
A02:2025 — Security Misconfiguration
9
Medium
A01:2025 — Broken Access Control
1
Medium
Roadmap
Immediately resolve the ten leaked secrets, prioritizing the identified configuration and program files, to secure the application. Simultaneously, clean up the dependency tree by removing unused packages and explicitly declaring imports to reduce technical debt. Address critical accessibility gaps by ensuring all custom controls are keyboard-operable and that visual elements meet contrast and motion safety standards. Finally, improve reliability by adding tests for the currently unreached production modules.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 10 Leaked secret finding(s) in Secret Scanning — start with REDACTED (2), REDACTED, REDACTED.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 287
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 1926
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 455
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 5
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 101 of 106 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 5 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 106 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 2635 of 2668 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 2,721 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 62 test source file(s) (.ts) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: No assets file was found for `test/OrchardCore.Tests.Modules/Errors.OrchardCoreModules.TwoPlus/Errors.OrchardCoreModules.TwoPlus.csproj`. Run restore before running this command.
D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares REDACTED, but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D15 Churn × Complexity Hotspots — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A hotspot's complexity is meant to be the worst body its churn actually touched. For src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml that could not be established — the complexity reader for the file reports no body extents, or the history carries no per-line attribution — so the row quotes the file's worst body, which the counted changes may never have touched. The churn count is unaffected.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (273,634 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D28 Secrets (history) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `gitleaks` TIMED OUT after 372.7s against a 372.6s budget, so we killed its process tree. The budget is ours; the work may simply be larger than it allows. Nothing about this repository is asserted by the absence of a result; the budget is ours to raise, and raising it is our backlog item, not an action for this repository's owner.
D31 IaC & Container Security — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Checkov ran but its report could not be read (checkov produced no output — not a clean result). Every misconfiguration only checkov reports — most of its Terraform, CloudFormation, Bicep and Ansible policies — is absent from this card, so its absence here is not evidence those resources are configured correctly.
D31 IaC & Container Security — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. REDACTED.dockerignore, src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/monaco-esm/dockerfile.4db8cf4d.js.map carries no `FROM` instruction, so it declares no build stage and every REDACTED rule this engine owns — the runtime-hardening, key-material, mutable-clone, no-op-shim, build-context, trust-anchor, install-guard, setuid and world-writable-path rules — is outside its own premise there and returned nothing. That silence is deliberate and correct: with no base image there is no image to reason about. It is reported here because it is NOT the same fact as a clean file, and coverage is stated as 3 of 5 Infrastructure-as-Code manifest(s) fully judged rather than as 100%. The vendor scanners (trivy, checkov) do read these files and their findings above stand; only this engine's own stage-keyed rules are absent. No owner action: a build file with no FROM is a legitimate include fragment.
D32 Data Compliance (PII/GDPR) — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. `.agents/skills/orchardcore-video-producer/scripts/recorder/Scenes.cs`, `.scripts/bloom/designer/core/autosave.ts`, `src/OrchardCore.Modules/OrchardCore.Admin/Permissions.cs`, `src/OrchardCore.Modules/OrchardCore.Admin/PermissionsAdminSettings.cs`, `src/OrchardCore.Modules/OrchardCore.AdminDashboard/Permissions.cs`, … (+274 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AC2 Forms & labels — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 116 further occurrence(s) are not listed individually; the score already reflects all 156.
AC4 Keyboard semantics — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 45 further occurrence(s) are not listed individually; the score already reflects all 85.
AC6 Visual & motion safety — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 161 further occurrence(s) are not listed individually; the score already reflects all 201.
AX9 CQS / query purity — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 5 query handlers were classified, but the query-purity walk could not open any of their bodies: it recognises a value-returning entry point named Execute/Handle/Consume (±Async), or one implementing a member of the handler interface the type was classified on, and the handlers in this repository have neither. Scoring the set anyway would report every unopened handler as pure, so AX9 abstains instead of publishing a perfect score it did not measure.
AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via REDACTED (REDACTED). docker build failed (exit 1) — DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
Install the buildx component to build images with BuildKit:
https://docs.docker.com/go/bui…; runtime evidence skipped.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 8 further occurrence(s) are not listed individually; the score already reflects all 48.
PF3 Async & latency hygiene — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 44 further occurrence(s) are not listed individually; the score already reflects all 84.
R10 Code Duplication — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 54 further occurrence(s) are not listed individually; the score already reflects all 94.
R4 Test Coverage — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 270 further occurrence(s) are not listed individually; the score already reflects all 310.
R7 Dead Code — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 56 further occurrence(s) are not listed individually; the score already reflects all 96.
X1 Async correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 50 further occurrence(s) are not listed individually; the score already reflects all 90.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 2495 further occurrence(s) are not listed individually; the score already reflects all 2535.
X24 Document value interpolated into markup unescaped — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 117 further occurrence(s) are not listed individually; the score already reflects all 157.
Repo exclusion declarations: 1 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D11 Test Reliability: Flakiness is inferred from history/markers — Watchdog runs the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D32 Data Compliance (PII/GDPR): PII/GDPR signals are heuristic pattern matches in code — they flag likely handling concerns, not legal compliance, and cannot trace where data actually flows at runtime.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
C3 Audit Trail: This control is scored from in-repo evidence only — a working control configured outside the repository leaves no signal a static scan can credit.
C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (5): D19, D21, D24, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
159 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was init at 131. A further 11 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being PermissionsPolicySettings.Edit.cshtml › GetPermissionPolicyName at 31 — they are counted neither in the figure above nor in this dimension's score. 10 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml (PermissionsPolicySettings.Edit.cshtml › GetPermissionPolicyName at 31), src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataAccumulator.cs (DataAccumulator.Result at 25), src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/HttpRequestValue.cs (HttpRequestValue.GetValueAsync at 23), src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/GeoDistanceFilterProvider.cs (GeoDistanceFilterProvider.TryParseDistance at 22), src/OrchardCore.Modules/OrchardCore.Settings/Deployment/SiteSettingsDeploymentSource.cs (SiteSettingsDeploymentSource.ProcessAsync at 21), and 5 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 150 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with init (cyclomatic 131), DefaultPluralRuleProvider.DefaultPluralRuleProvider.ctor (cyclomatic 70), UppyFileUpload.useFileUpload (cyclomatic 64). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cyclomatic Complexity from 5.7 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 325 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 1 body over 120 down to 120 or less in Cognitive Complexity — start with init (cognitive 181). — Refactoring it lifts Cognitive Complexity from 5.4 to about 5.8/10.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.2 / 10Stronggated by 59 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 18 TooManyMethods finding(s) in God Classes — start with REDACTED (2), JsonDynamicValue.cs, UserStore.cs. — One of this dimension's main actionable groups (18 warning-level).
Resolve the 17 MethodTooLong finding(s) in God Classes — start with Migrations.cs (3), Startup.cs (2), ResourceManagementOptionsConfiguration.cs. — One of this dimension's main actionable groups (17 warning-level).
Resolve the 10 FunctionTooLong finding(s) in God Classes — start with UppyFileUpload.ts, FileLibraryManager.ts, FieldUploadService.ts. — One of this dimension's main actionable groups (10 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
381 duplicated block group(s) detected. A further 27 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×14src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:66
+ 122 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 23 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with REDACTED (3), StringExtensions.cs (2), ScriptTag.cs. — One of this dimension's main actionable groups (23 warning-level).
Resolve the 22 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with REDACTED (3), ModuleService.cs (2), AutoroutePartHandler.cs. — One of this dimension's main actionable groups (22 warning-level).
Resolve the 20 Duplicated block (13 lines × 2) finding(s) in Code Duplication — start with REDACTED (4), ContentPartFieldIndexSettingsDisplayDriver.cs (3), UrlRedirectRuleDisplayDriver.cs. — One of this dimension's main actionable groups (20 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling6.6 / 10Adequate✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
+ 77 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 5 Layer violation finding(s) in Coupling — start with OrchardCore.AzureAI.Core.csproj, OrchardCore.Notifications.Core.csproj, OrchardCore.OpenId.Core.csproj. — One of this dimension's main actionable groups (5 issue-level).
Resolve the 10 Off the main sequence finding(s) in Coupling — start with OrchardCore.ResourceManagement.csproj, OrchardCore.Settings.Core.csproj, OrchardCore.ContentFields.Core.csproj. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 1 Unstable project OrchardCore.AdminMenu finding(s) in Coupling — start with OrchardCore.AdminMenu.csproj. — One of this dimension's main actionable groups (1 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 9 Low cohesion finding(s) in Cohesion (LCOM4) — start with UserStore.cs, OpenIdApplicationStore.cs, OpenIdTokenStore.cs. — One of this dimension's main actionable groups (9 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution9.4 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
3472 test methods: 3310 unit, 0 integration, 0 BDD, 162 e2e. The JavaScript/TypeScript suite contributes 751 `it`/`test` case(s) across 58 test file(s) declaring at least one beside 2721 .NET test method(s); its tier split is read from package names and paths only.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality10.0 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
0 skipped, 1 zero-assertion, 3 mock references across 2721 tests. Measured on the C# suite only — at least 62 test source file(s) (.ts) went unread, so its test quality is unmeasured and is not in these counts.
No assertions: ScopesCanBeEnteredAndExited_Default_Succeedstest/OrchardCore.Tests/OrchardCore.Environment.Cache/CacheScopeManagerTests.cs:7
Resolve the 4 Mock-dominated test finding(s) in Test Quality — start with SecretManagerTests.cs (3), MediaFileStoreExtensionsTests.cs. — One of this dimension's main actionable groups (4 recommendation-level).
Resolve the 1 No assertions finding(s) in Test Quality — start with CacheScopeManagerTests.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests pass reliably, with no flakiness.
Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 10 Leaked secret finding(s) in Secret Scanning — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (10 issue-level).
Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 85 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 109 direct `PackageReference`(s), and 84 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares REDACTED, and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 24 Hotspot finding(s) in Churn × Complexity Hotspots — start with Startup.cs (2), REDACTED (2), PagerShapesTableProvider.cs. — One of this dimension's main actionable groups (24 warning-level).
Resolve the 1 Repeated repair finding(s) in Churn × Complexity Hotspots — start with main.ts. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor9.5 / 10Exemplary✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
66 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs. Counted over 1280 of the 5640 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×4
Further sole-owners (lower concentration)
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
+ 9 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 36 NoWarnInCsproj finding(s) in Explicit Debt — start with Directory.Build.props (18), OrchardCore.ProjectTemplates.csproj (3), OrchardCore.Tests.csproj (2). — One of this dimension's main actionable groups (36 issue-level).
Resolve the 17 EmptyCatchBlock finding(s) in Explicit Debt — start with Module.cs (2), REDACTED (2), DataPipelineDesignerController.cs. — One of this dimension's main actionable groups (17 issue-level).
Resolve the 9 WriteOnlyPrivateField finding(s) in Explicit Debt — start with REDACTED (3), ExternalAuthenticationsController.cs (2), AdminMenu.cs. — One of this dimension's main actionable groups (9 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D18 · Solution Shape8.5 / 10Strong✓ Tool-verified
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
251 projects, 6269 source files, 350880 hand-written lines of code (273290 production / 77590 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 1381 inter-project edges.
Thin analysable surface across projects: BaseThemeSample2 · ×3test/OrchardCore.Tests.Modules/BaseThemeSample2/BaseThemeSample2.csproj
Resolve the 3 Thin analysable surface across projects finding(s) in Solution Shape — start with BaseThemeSample2.csproj, DerivedThemeSample.csproj, DerivedThemeSample2.csproj. — One of this dimension's main actionable groups (3 recommendation-level).
Resolve the 1 Shell project finding(s) in Solution Shape — start with OrchardCore.Docs.csproj. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
Orchard Core's documentation is comprehensive and well-structured across the repository root (1027-word README), src/docs/README.md (10k words), test directories, and architecture/designer docs. It documents two main projects: the framework and CMS with a clear distinction of their purposes, an overview of each target, and detailed build status for release/3.0 and preview/main branches. The root README also links to external resources like the Gurubase badge, Crowdin translation, and Discord community. The repository is well documented: the READMEs of each directory document that directory's purpose and usage, with installation/build/usage guidance for most directories. The root README gives an overview, installation, and a contributing section; the architecture/design docs are separate markdown files (92) covering topics like OpenAPI client generation, audit trails, and data pipelines. XML-doc coverage is low across many assemblies but high on OrchardCore.OpenApi.Core (48%), OrchardCore.Localization.Abstractions (89%), and OrchardCore.Security (0%). The internal-focused jargon ('ticket ids') is not present in any document, so no such finding. The repository's documentation is comprehensive: 176 README files (including the reference and community directories) plus architecture/Docs markdown coverages for 92 documents. The XML-doc coverage figures show strong coverage across modules like App security, authentication, content, data pipelines, and search/Indexing; however, there are gaps in the visible documentation that reflect a thin overview and sparse usage/contribution sections for the repository root. The repository's documentation is comprehensive across READMEs, architecture/Docs markdown files, and XML-doc coverage. The READMEs document their respective directories (e.g., the 'Owners' table for a community directory, code-generation templates for Orchard CMS), with no root-level overview of what the project does or how to use it. There are no install/build or usage examples in any document, so installation/usage guidance is missing from every visible README and the repository's single root README (which would be judged there). The repository's README documentation is strong and well-organized. The root README gives a clear overview of what Orchard Core is (an open-source .NET CMS framework) and its licensing, while the guides document specific directories such as content-definition stores, creating custom admin themes, and setting up Blazor CMS applications. There are no missing installation/usage sections for the repository-wide docs; each guide is self-contained and covers its own directory's purpose. The repository's READMEs and architecture/Docs markdown files are well documented for their respective directories: each README documents what it contains (e.g. the custom module guide, Liquid widget creation) without an overview of the project or its scope; the architecture/Docs set covers Orchard Core modules with design coverage across 92 files. The XML-doc coverage is low overall but shows promise in specific areas like OrchardCore.ContentLocalization and OrchardCore.RateLimits.
Documentation: no project overviewsrc/docs/guides/create-install-custom-module/README.md
Resolve the 1 Documentation finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
0 naming inconsistencies across 200 sampled symbols.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md.
Do you agree with this assessment?
D24 · Comment ValueExemplary◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
10 of 257 projects flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
✓ On the Gold path — maintain.
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D27 · Navigability7.9 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
91 % of calls cross a namespace and 14 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
Resolve the 9 Pass-through layer finding(s) in Navigability — start with DatabasePlacementsStore.cs, FilePlacementsStore.cs, DefaultDynamicCache.cs. — One of this dimension's main actionable groups (9 recommendation-level).
Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
131 finding(s): 0 critical, 8 high, 102 medium, 21 low. semgrep hit a parse error in 308 file(s) — `.agents/skills/orchardcore-video-producer/scripts/recorder/Scenes.cs` (line 25), `.scripts/bloom/designer/core/autosave.ts` (line 286), `src/OrchardCore.Modules/OrchardCore.Admin/Permissions.cs` (lines 10–12, line 12), `src/OrchardCore.Modules/OrchardCore.Admin/PermissionsAdminSettings.cs` (lines 7–10, line 18), `src/OrchardCore.Modules/OrchardCore.AdminDashboard/Permissions.cs` (lines 11–15, lines 20–22, line 22), … (+303 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 23 of those file(s) — `src/OrchardCore.Modules/OrchardCore.AdminMenu/Services/AdminMenuJSLocalizer.cs`, `src/OrchardCore.Modules/OrchardCore.AuditTrail/Migrations.cs`, `src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs`, `src/OrchardCore.Modules/OrchardCore.ContentFields/Services/ContentFieldsJSLocalizer.cs`, `src/OrchardCore.Modules/OrchardCore.Contents/ContentShapeAlternatesFactory.cs`, … (+18 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 9 of those file(s) — `src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs`, `src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Queries/QueriesDataSource.cs`, `src/OrchardCore.Modules/OrchardCore.Lucene/Permissions.cs`, `src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs`, `src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs`, … (+4 more) — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 6 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 10 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
Resolve the 49 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (39), REDACTED (3), REDACTED. — One of this dimension's main actionable groups (49 issue-level).
Resolve the 4 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Resolve the 4 High vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
Resolve the 7 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (4), REDACTED (3). — One of this dimension's main actionable groups (7 warning-level).
Resolve the 2 Low IaC finding(s) in IaC & Container Security — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D32 · Data Compliance (PII/GDPR)9.0 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Likely personal-data (PII / GDPR) handling concerns — logging or storing data without safeguards.
Method: Heuristic PII/GDPR LEAK scan via semgrep across the repo, using Watchdog's own ruleset: personal data crossing a boundary it should not — reaching a log/console sink, a URL or query string, or unprotected browser storage. Matches map to severity and a 0-10 wide normalizer. A clean sweep is unscored rather than an unearned 10, and is a statement about the leak paths checked only — this dimension does not inventory the personal data a repository holds (the personal-data map and the C1-C5 compliance cards do that), so it never reports that a repository has no personal-data surface. Reported LOUDLY as a measurement gap if the ruleset is missing from the analyzer image. Exhaustive over the leak paths, advisory-leaning; degrades on parse failure.
1 finding(s): 0 critical, 0 high, 1 medium, 0 low. semgrep could not parse 279 file(s) — `.agents/skills/orchardcore-video-producer/scripts/recorder/Scenes.cs`, `.scripts/bloom/designer/core/autosave.ts`, `src/OrchardCore.Modules/OrchardCore.Admin/Permissions.cs`, `src/OrchardCore.Modules/OrchardCore.Admin/PermissionsAdminSettings.cs`, `src/OrchardCore.Modules/OrchardCore.AdminDashboard/Permissions.cs`, … (+274 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Data Compliance (PII/GDPR) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d32_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
37 of 1280 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs. Counted over 1280 of the 5640 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 2 Boundary-crossing change coupling finding(s) in Change Coupling — start with RecipesStep.cs, ContentMethodsProvider.cs. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 12 Change coupling finding(s) in Change Coupling — start with REDACTED (2), OpenIdServerSettingsDisplayDriver.cs (2), ScriptTagHelper.cs. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 1 Change coupling clique finding(s) in Change Coupling — start with OpenIdApplicationStore.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.
✓ On the Gold path — maintain.
Detailed fixes: d37_recommendation.md.
Do you agree with this assessment?
D39 · IL Efficiency10.0 / 10Exemplary✓ Tool-verified
Method: IL instruction count per method, read from the BUILT first-party assemblies via Mono.Cecil (the target is compiled on a deep run); scored on the fraction of methods whose emitted IL body exceeds the size threshold. Sees compiler-generated bloat source can't; not-applicable when the target fails to build. Deterministic.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 32 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives5.1 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. (×7) — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/GalleryCardItem.vue:29, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/GalleryListItem.vue:21, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:136, …
What to do
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
Do you agree with this assessment?
AC2 · Forms & labels6.8 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. (×5) — src/OrchardCore.Modules/OrchardCore.Admin/Views/AdminListSearch.cshtml:32, src/OrchardCore.Modules/OrchardCore.DataLocalization/Views/Admin/Index.cshtml:120, src/OrchardCore.Modules/OrchardCore.DataLocalization/Views/Admin/Index.cshtml:149, …
This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id. (×14) — src/OrchardCore.Modules/OrchardCore.Admin/Views/AdminSettings.Edit.cshtml:69, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextField-CheckboxList.Edit.cshtml:19, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextField-Picker.Edit.cshtml:36, …
A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one). (×10) — src/OrchardCore.Modules/OrchardCore.AdminDashboard/Views/DashboardWidget.DetailAdmin.cshtml:10, src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml:66, src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml:40, …
This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×10) — src/OrchardCore.Modules/OrchardCore.ArchiveLater/Views/ArchiveLaterPart.Edit.cshtml:11, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/DateField-Localized.Edit.cshtml:22, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/NumericField-Range.Edit.cshtml:34, …
A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one. — src/OrchardCore.Modules/OrchardCore.Autoroute/Views/AutoroutePartSettings.Edit.cshtml:61
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×19) — src/OrchardCore.Modules/OrchardCore.ContentPreview/Views/Preview/_Layout.cshtml:2, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/index.html:2, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/standalone/callback.html:2, …
A timed meta-refresh moves users with no control or warning. Use a server redirect or a user-triggered action instead. — REDACTED:18
A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). (×2) — src/OrchardCore.Modules/OrchardCore.Demo/Views/Todo.Edit.liquid:2, src/OrchardCore.Modules/OrchardCore.Users/Views/ExternalAuthentications/ExternalLogins.cshtml:13
Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. (×3) — REDACTED:221, REDACTED:241, src/OrchardCore.Modules/OrchardCore.Users/Views/TwoFactorAuthentication/LoginWithTwoFactorAuthentication.cshtml:19
An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative. (×2) — src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/bootstrap.bundle.js:5513, src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/bootstrap.js:3695
An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label. — src/OrchardCore.Modules/OrchardCore.Templates/Views/Preview/Index.cshtml:8
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). — src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Mvc.Web/Views/Shared/_Layout.cshtml:2
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close. (×9) — src/OrchardCore.Modules/OrchardCore.Admin/Views/QuickNavigationNavbarItem.cshtml:16, src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml:95, src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml:70, …
The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. (×9) — src/OrchardCore.Modules/OrchardCore.AuditTrail/Views/AuditTrailTrimmingSettings.Edit.cshtml:25, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Monaco.Edit.cshtml:17, src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlFieldMonacoEditorSettings.Edit.cshtml:13, …
The repo's own CSS styles .btn with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — REDACTED:39
This <div role="dialog"> is a modal dialog, but focus is moved into it, but nothing keeps it there: Tab walks out to the page behind, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close. (×2) — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/ConnectDialog.vue:57, src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/QuickAddMenu.vue:84
The repo's own CSS styles .cursor-pointer with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — src/OrchardCore.Modules/OrchardCore.Deployment/Views/DeploymentPlan/Display.cshtml:47
An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. (×11) — src/OrchardCore.Modules/OrchardCore.Flows/Views/ContentTypePicker.cshtml:19, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:34, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:54, …
The repo's own CSS styles .thumb-container with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:146
A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler. (×3) — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:12, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:16, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:20
The repo's own CSS styles .table-cell with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:26
The repo's own CSS styles .expand with `cursor: pointer`, so this <span> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. (×2) — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderComponent.vue:8, src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderRow.vue:9
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`#graphiql` moves (`transition: left 0.2s ease-in-out, width 0.2s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:11
`[dir=rtl] #graphiql` moves (`transition: right 0.2s ease-in-out, width 0.2s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:17
`.loader` moves (`animation: spin 1s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:27
`.md-fenced-code-tabs label` sets color: #fff on background-color: #999 — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/docs/assets/css/code-tabs.css:18
`ul.pager li a:hover` sets color: #0085A1 on background-color: #e9ecef — 3.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/bootstrap-oc.css:222
`.list-group-item-warning.list-group-item-action:hover, .list-group-item-warning.list-group-item-action:focus` sets color: #997404 on background-color: #e6dbb9 — 3.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5107
`.dropdown-item.active, .dropdown-item:active` sets color: #fff on background-color: #ffc800 — 1.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:3463
`.workflow-canvas .activity.activity-start, .workflow-canvas .activity.activity-blocking` sets color: #ffffff on background-color: #7ab02c — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. (×2) — src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/orchard.workflows-editor.css:45, src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/orchard.workflows-viewer.css:45
`.leaflet-bar a.leaflet-disabled` sets color: #bbb on background-color: #f4f4f4 — 1.7:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Modules/OrchardCore.Spatial/wwwroot/Styles/leaflet.css:318
`.mf-btn-primary` sets color: #fff on background-color: #7bc143 — 2.2:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from). — src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media-field2.css:1
`.oc-media-input-group-text` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from). — src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media-picker2.css:1
`.stepper .step-circle.active` sets color: #fff on background-color: #0a8cfa — 3.4:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from). — src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media2.css:1
`.oc-media-input-group-text` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Modules/OrchardCore.Media/Assets/shared/media-admin.css:170
`.stepper .step-circle.active` sets color: #fff on background-color: rgb(10, 140, 250) — 3.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/assets/css/file.css:1944
`.form-range:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×3) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:2582, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:2570, src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2339
`.btn-check:focus + .btn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×2) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:3024, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:2991
`.modal` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×3) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:5488, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5249, src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5267
`.modal-content` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×3) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:5540, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5300, src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5320
`.carousel-control-prev:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×3) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:6096, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5805, src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5891
`.offcanvas` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. (×3) — src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:6279, src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5988, src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6518
`.form-control-plaintext:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2080
`.btn-check:focus-visible + .btn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2828
`.offcanvas-sm` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6079
`.offcanvas-md` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6167
`.offcanvas-lg` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6255
`.offcanvas-xl` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6343
`.offcanvas-xxl` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6431
`.jtk-surface-tile` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/jsplumbtoolkit-defaults.css:148
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Do you agree with this assessment?
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified
Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.
Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.
Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.
No accessibility enforcement found — no a11y linter (eslint-plugin-vuejs-accessibility) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 1863 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
What to do
Enforce accessibility in the toolchain: add eslint-plugin-vuejs-accessibility, then assert with vitest-axe in tests, then gate axe/pa11y/Lighthouse in CI.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
`ElasticsearchQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:27
`SiteLayersQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Layers/GraphQL/SiteLayersQuery.cs:22
`LuceneQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:28
`MediaAssetQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaAssetQuery.cs:20
`MediaJSLocalizer` is registered as a SINGLETON but its constructor takes `IStringLocalizer S`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Media/Services/MediaJSLocalizer.cs:11
`SqlQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:31
`FileDownloadDeploymentTargetProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Deployment/Services/FileDownloadDeploymentTargetProvider.cs:10
`FacebookService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Facebook/Services/FacebookService.cs:17
`GoogleAuthenticationService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Google/Authentication/Services/GoogleAuthenticationService.cs:16
`SiteCulturesQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Localization/GraphQL/SiteCulturesQuery.cs:28
`AzureADService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Services/AzureADService.cs:16
`MicrosoftAccountService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Services/MicrosoftAccountService.cs:16
`OpenIdClientService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdClientService.cs:19
`OpenIdServerService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:38
`OpenIdValidationService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdValidationService.cs:30
`FixedWindowRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.RateLimits/Services/FixedWindowRateLimiterSource.cs:23
`SlidingWindowRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.RateLimits/Services/SlidingWindowRateLimiterSource.cs:23
`ConcurrencyRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.RateLimits/Services/ConcurrencyRateLimiterSource.cs:23
`TokenBucketRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.RateLimits/Services/TokenBucketRateLimiterSource.cs:23
`TwitterSettingsService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Twitter/Services/TwitterSettingsService.cs:16
`CurrentUserQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore.Modules/OrchardCore.Users/GraphQL/CurrentUserQuery.cs:24
`ContentItemQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemQuery.cs:16
`ContentTypeQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentTypeQuery.cs:28
`ShellDbTablesRemovingHandler` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.Data.YesSql/Removing/ShellDbTablesRemovingHandler.cs:25
`DataLocalizerFactory` is registered as a SINGLETON but its constructor takes `DataResourceManager dataResourceManager`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `DataResourceManager` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.Localization.Core/Data/DataLocalizerFactory.cs:14
`ReCaptchaService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.ReCaptcha.Core/Services/ReCaptchaService.cs:30
`DefaultSystemRoleProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer S`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore.Roles.Core/DefaultSystemRoleProvider.cs:16
`ShellContextFactory` is registered as a SINGLETON but its constructor takes `IEnumerable shellFeatures`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ShellFeature` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Builders/ShellContextFactory.cs:19
`ShellRemovalManager` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Removing/ShellRemovalManager.cs:21
`ShellWebRootRemovingHandler` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Removing/ShellWebRootRemovingHandler.cs:19
`ShellSiteFolderRemovingHandler` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:19
`ShellSettingsRemovingHandler` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Removing/ShellSettingsRemovingHandler.cs:17
`SetFeaturesShellDescriptorManager` is registered as a SINGLETON but its constructor takes `IEnumerable shellFeatures`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ShellFeature` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/OrchardCore/OrchardCore/Shell/Descriptor/Settings/SetFeaturesShellDescriptorManager.cs:17
What to do
Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`RazorCompilationFileProviderAccessor` is a singleton (one shared instance) but mutates instance state outside any lock (_compositeFileProvider; e.g. `_compositeFileProvider` at line 25). — src/OrchardCore/OrchardCore.Mvc.Core/RazorCompilationFileProviderAccessor.cs:9
`TestBackgroundTask` is a singleton (one shared instance) but mutates instance state outside any lock (_count; e.g. `_count` at line 13). — src/OrchardCore.Modules/OrchardCore.Demo/Services/TestBackgroundTask.cs:5
`HomeRouteValuesAddressScheme` is a singleton (one shared instance) but mutates instance state outside any lock (_cachedEndpoint, _cachedEndpointKey; e.g. `_cachedEndpoint` at line 54). — src/OrchardCore.Modules/OrchardCore.HomeRoute/Routing/HomeRouteValuesAddressScheme.cs:9
`LuceneIndexingState` is a singleton (one shared instance) but mutates instance state outside any lock (_stateDocument; e.g. `_stateDocument` at line 55). — src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexingState.cs:12
`SitemapEntries` is a singleton (one shared instance) but mutates instance state outside any lock (_document; e.g. `_document` at line 67). — src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapEntries.cs:5
`RedisService` is a singleton (one shared instance) but mutates instance state outside any lock (Database; e.g. `Database` at line 26). — src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisService.cs:7
`AzureAIClientFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_searchIndexClient; e.g. `_searchIndexClient` at line 82). — src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAIClientFactory.cs:10
`DocumentOptionsSetup` is a singleton (one shared instance) but mutates instance state outside any lock (_defaultDocumentSerializer; e.g. `_defaultDocumentSerializer` at line 57). — src/OrchardCore/OrchardCore.Infrastructure/Documents/Options/DocumentOptionsSetup.cs:9
`DefaultTimeZoneSelectListProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_items; e.g. `_items` at line 17). — src/OrchardCore/OrchardCore/Modules/Services/DefaultTimeZoneSelectListProvider.cs:3
`TenantHttpClientFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_services, _scopeFactory, _optionsMonitor, _filters, _entryFactory; e.g. `_services` at line 362). — src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:17
`ShellSettings` is a singleton (one shared instance) but mutates instance state outside any lock (_versionId, _tenantId, _requestUrlHost, _requestUrlHosts, _requestUrlPrefix, _requestPathBase; e.g. `_versionId` at line 89). — src/OrchardCore/OrchardCore.Abstractions/Shell/ShellSettings.cs:14
`RunningShellTable` is a singleton (one shared instance) but mutates instance state outside any lock (_default, _hasStarMapping; e.g. `_default` at line 18). — src/OrchardCore/OrchardCore/Shell/RunningShellTable.cs:7
`DistributedShellHostedService` is a singleton (one shared instance) but mutates instance state outside any lock (_shellChangedId, _shellCountChangedId, _terminated, _context, _defaultContextUtcTicks, _busyStartTime; e.g. `_shellChangedId` at line 301). — src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:15
`SetFeaturesShellDescriptorManager` is a singleton (one shared instance) but mutates instance state outside any lock (_shellDescriptor; e.g. `_shellDescriptor` at line 34). — src/OrchardCore/OrchardCore/Shell/Descriptor/Settings/SetFeaturesShellDescriptorManager.cs:10
`TestContentElementDisplayDriver` is registered per request (scoped/transient), so each caller expects its own instance — but it keeps mutable `static` state that every instance in the process shares, and mutates it outside any lock (s_creating, s_processing; e.g. `s_creating` at line 28). The per-request lifetime buys nothing here: the field outlives every request and concurrent requests race on it. — src/OrchardCore.Modules/OrchardCore.Demo/ContentElementDisplays/TestContentElementDisplayDriver.cs:9
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Mutable `static` state in a per-request component is shared by the whole process: inject it as a registered singleton (so its sharing is visible and testable) or make it thread-safe.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces OrchardCore.Locking ↔ OrchardCore.Locking.Distributed depend on each other. The lightest dependency in the cycle is OrchardCore.Locking → OrchardCore.Locking.Distributed (OrchardCore.Locking.LocalLock → OrchardCore.Locking.Distributed.IDistributedLock, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore/Locking/LocalLock.cs:2
The namespaces OrchardCore.Json ↔ System.Text.Json.Serialization depend on each other. The lightest dependency in the cycle is OrchardCore.Json → System.Text.Json.Serialization (OrchardCore.Json.JsonDerivedTypesOptions → System.Text.Json.Serialization.IJsonDerivedTypeInfo, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Abstractions/Json/JsonDerivedTypesOptions.cs:1
The namespaces Microsoft.Extensions.DependencyInjection ↔ OrchardCore ↔ OrchardCore.Admin ↔ OrchardCore.Admin.Models ↔ OrchardCore.BackgroundTasks ↔ OrchardCore.ContentManagement ↔ OrchardCore.ContentManagement.Handlers ↔ OrchardCore.ContentManagement.Metadata ↔ OrchardCore.ContentManagement.Metadata.Builders ↔ OrchardCore.ContentManagement.Metadata.Models ↔ OrchardCore.ContentManagement.Metadata.Records ↔ OrchardCore.ContentManagement.Metadata.Settings ↔ OrchardCore.ContentManagement.Records ↔ OrchardCore.ContentTypes.Events ↔ OrchardCore.Data.Documents ↔ OrchardCore.Data.Migration ↔ OrchardCore.DataSources ↔ OrchardCore.DataSources.Expressions ↔ OrchardCore.Deployment ↔ OrchardCore.Deployment.Remote.Models ↔ OrchardCore.Deployment.Remote.Services ↔ OrchardCore.DisplayManagement ↔ OrchardCore.DisplayManagement.Descriptors ↔ OrchardCore.DisplayManagement.Descriptors.ShapeTemplateStrategy ↔ OrchardCore.DisplayManagement.Handlers ↔ OrchardCore.DisplayManagement.Implementation ↔ OrchardCore.DisplayManagement.Layout ↔ OrchardCore.DisplayManagement.Razor ↔ OrchardCore.DisplayManagement.Shapes ↔ OrchardCore.DisplayManagement.Theming ↔ OrchardCore.DisplayManagement.Title ↔ OrchardCore.DisplayManagement.ViewModels ↔ OrchardCore.DisplayManagement.Views ↔ OrchardCore.DisplayManagement.Zones ↔ OrchardCore.Documents ↔ OrchardCore.Documents.Options ↔ OrchardCore.Environment.Cache ↔ OrchardCore.Environment.Extensions ↔ OrchardCore.Environment.Extensions.Features ↔ OrchardCore.Environment.Shell ↔ OrchardCore.Environment.Shell.Builders ↔ OrchardCore.Environment.Shell.Builders.Models ↔ OrchardCore.Environment.Shell.Configuration ↔ OrchardCore.Environment.Shell.Removing ↔ OrchardCore.Environment.Shell.Scope ↔ OrchardCore.FileStorage ↔ OrchardCore.FileStorage.AzureBlob ↔ OrchardCore.Localization ↔ OrchardCore.Modules ↔ OrchardCore.Modules.Services ↔ OrchardCore.Navigation ↔ OrchardCore.Recipes.Services ↔ OrchardCore.ResourceManagement ↔ OrchardCore.Scripting ↔ OrchardCore.Security.Permissions ↔ OrchardCore.Settings ↔ OrchardCore.Shells.Azure.Configuration ↔ OrchardCore.Shells.Azure.Services depend on each other. The lightest dependency in the cycle is Microsoft.Extensions.DependencyInjection → OrchardCore.Environment.Shell.Configuration (Microsoft.Extensions.DependencyInjection.ServiceCollectionExtensions → OrchardCore.Environment.Shell.Configuration.IShellConfiguration, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Workflows/Trimming/Extensions/ServiceCollectionExtensions.cs:3
The namespaces OrchardCore.Data ↔ OrchardCore.Data.YesSql depend on each other. The lightest dependency in the cycle is OrchardCore.Data.YesSql → OrchardCore.Data (OrchardCore.Data.YesSql.ITableNameConventionFactory → OrchardCore.Data.DatabaseTableOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Data.YesSql.Abstractions/ITableNameConventionFactory.cs:5
The namespaces OrchardCore.Indexing ↔ OrchardCore.Indexing.Models depend on each other. The lightest dependency in the cycle is OrchardCore.Indexing.Models → OrchardCore.Indexing (OrchardCore.Indexing.Models.CreateIndexingTaskContext → OrchardCore.Indexing.RecordIndexingTaskTypes, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Indexing.Abstractions/Models/CreateIndexingTaskContext.cs:3
The namespaces OrchardCore.Security.Options ↔ OrchardCore.Security.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Security.Options → OrchardCore.Security.Services (OrchardCore.Security.Options.SecurityHeadersOptions → OrchardCore.Security.Services.IHeaderPolicyProvider, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Security/Options/SecurityHeadersOptions.cs:1
The namespaces OrchardCore.Users ↔ OrchardCore.Users.Events ↔ OrchardCore.Users.Handlers ↔ OrchardCore.Users.Models ↔ OrchardCore.Users.Services ↔ OrchardCore.Users.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Users → OrchardCore.Users.Handlers (OrchardCore.Users.UserManagerExtensions → OrchardCore.Users.Handlers.UpdateUserContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Users.Core/UserManagerExtensions.cs:4
The namespaces OrchardCore.DisplayManagement.Liquid ↔ OrchardCore.Liquid depend on each other. The lightest dependency in the cycle is OrchardCore.Liquid → OrchardCore.DisplayManagement.Liquid (OrchardCore.Liquid.ResourceManagementOptionsConfiguration → OrchardCore.DisplayManagement.Liquid.LiquidViewParser, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Liquid/ResourceManagementOptionsConfiguration.cs:3
The namespaces OrchardCore.ContentManagement.GraphQL.Queries ↔ OrchardCore.ContentManagement.GraphQL.Queries.Predicates depend on each other. The lightest dependency in the cycle is OrchardCore.ContentManagement.GraphQL.Queries → OrchardCore.ContentManagement.GraphQL.Queries.Predicates (OrchardCore.ContentManagement.GraphQL.Queries.ContentItemsFieldType → OrchardCore.ContentManagement.GraphQL.Queries.Predicates.Junction, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:13
The namespaces OrchardCore.AuditTrail.Services.Models ↔ OrchardCore.AuditTrail.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.AuditTrail.ViewModels → OrchardCore.AuditTrail.Services.Models (OrchardCore.AuditTrail.ViewModels.AuditTrailEventViewModel → OrchardCore.AuditTrail.Services.Models.AuditTrailEventDescriptor, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.AuditTrail/ViewModels/AuditTrailEventViewModel.cs:2
The namespaces OrchardCore.Sitemaps.Builders ↔ OrchardCore.Sitemaps.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Sitemaps.Builders → OrchardCore.Sitemaps.Services (OrchardCore.Sitemaps.Builders.SitemapIndexTypeBuilder → OrchardCore.Sitemaps.Services.ISitemapManager, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Sitemaps/Builders/SitemapIndexTypeBuilder.cs:7
The namespaces OrchardCore.ContentLocalization ↔ OrchardCore.ContentLocalization.Handlers ↔ OrchardCore.ContentLocalization.Models ↔ OrchardCore.ContentLocalization.Services depend on each other. The lightest dependency in the cycle is OrchardCore.ContentLocalization → OrchardCore.ContentLocalization.Handlers (OrchardCore.ContentLocalization.DefaultContentLocalizationManager → OrchardCore.ContentLocalization.Handlers.IContentLocalizationHandler, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.ContentLocalization/DefaultContentLocalizationManager.cs:3
The namespaces OrchardCore.Media ↔ OrchardCore.Media.Services ↔ OrchardCore.Media.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Media → OrchardCore.Media.Services (OrchardCore.Media.SecureMediaPermissions → OrchardCore.Media.Services.AttachedMediaFieldFileService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Media/SecureMediaPermissions.cs:6
The namespaces OrchardCore.Workflows.Activities ↔ OrchardCore.Workflows.Indexes ↔ OrchardCore.Workflows.Models ↔ OrchardCore.Workflows.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Workflows.Models → OrchardCore.Workflows.Activities (OrchardCore.Workflows.Models.ActivityContext → OrchardCore.Workflows.Activities.IActivity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Workflows.Abstractions/Models/ActivityContext.cs:1
The namespaces OrchardCore.Feeds ↔ OrchardCore.Feeds.Models depend on each other. The lightest dependency in the cycle is OrchardCore.Feeds.Models → OrchardCore.Feeds (OrchardCore.Feeds.Models.FeedContext → OrchardCore.Feeds.IFeedBuilder, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Feeds.Abstractions/Models/FeedContext.cs:5
The namespaces OrchardCore.DataPipelines.Models ↔ OrchardCore.DataPipelines.Services ↔ OrchardCore.DataPipelines.Steps ↔ OrchardCore.DataPipelines.ViewModels.Designer depend on each other. The lightest dependency in the cycle is OrchardCore.DataPipelines.Steps → OrchardCore.DataPipelines.Services (OrchardCore.DataPipelines.Steps.ConvertTimeZoneStep → OrchardCore.DataPipelines.Services.IDataTimeZoneResolver, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/ConvertTimeZoneStep.cs:2
The namespaces OrchardCore.Elasticsearch ↔ OrchardCore.Elasticsearch.Core.Services ↔ OrchardCore.Elasticsearch.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Elasticsearch.ViewModels → OrchardCore.Elasticsearch (OrchardCore.Elasticsearch.ViewModels.AdminQueryViewModel → OrchardCore.Elasticsearch.ElasticsearchRecord, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Elasticsearch/ViewModels/AdminQueryViewModel.cs:7
The namespaces OrchardCore.Lucene ↔ OrchardCore.Lucene.Core ↔ OrchardCore.Lucene.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Lucene → OrchardCore.Lucene.Services (OrchardCore.Lucene.LuceneQuerySource → OrchardCore.Lucene.Services.LuceneAnalyzerManager, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneQuerySource.cs:15
The namespaces OrchardCore.Media.Core.Events ↔ OrchardCore.Media.Events depend on each other. The lightest dependency in the cycle is OrchardCore.Media.Events → OrchardCore.Media.Core.Events (OrchardCore.Media.Events.SecureMediaFileStoreEventHandler → OrchardCore.Media.Core.Events.MediaEventHandlerBase, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/OrchardCore.Modules/OrchardCore.Media/Events/SecureMediaFileStoreEventHandler.cs:2
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IContentManager` declares 20 members: `NewAsync`, `UpdateAsync`, `CreateAsync`, `CreateContentItemVersionAsync`, `UpdateContentItemVersionAsync`, `ImportAsync`, `ValidateAsync`, `RestoreAsync`, `GetAsync`, `GetAsync`, `GetVersionAsync`, `GetAllVersionsAsync`, `LoadAsync`, `RemoveAsync`, `DiscardDraftAsync`, `SaveDraftAsync`, `PublishAsync`, `UnpublishAsync`, `PopulateAspectAsync`, `CloneAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 20 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ContentManagement.Abstractions/IContentManager.cs:8
`IContentFieldHandler` declares 27 members: `ActivatedAsync`, `ActivatingAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentFieldHandler.cs:6
`IContentHandler` declares 29 members: `ActivatingAsync`, `ActivatedAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `RestoringAsync`, `RestoredAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentHandler.cs:3
`IContentPartHandler` declares 27 members: `ActivatedAsync`, `ActivatingAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentPartHandler.cs:6
`IContentDefinitionService` declares 16 members under just 15 distinct name(s): `AddTypeAsync`, `RemoveTypeAsync`, `AddPartToTypeAsync`, `AddReusablePartToTypeAsync`, `RemovePartFromTypeAsync`, `AddPartAsync`, `RemovePartAsync`, `AddFieldToPartAsync`, `AddFieldToPartAsync`, `RemoveFieldFromPartAsync`, `AlterFieldAsync`, `AlterTypePartAsync`, `AlterTypePartsOrderAsync`, `AlterPartFieldsOrderAsync`, `GenerateContentTypeNameFromDisplayNameAsync`, `GenerateFieldNameFromDisplayNameAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/OrchardCore/OrchardCore.ContentTypes.Abstractions/IContentDefinitionService.cs:9
`IContentDefinitionEventHandler` declares 17 members: `ContentTypeCreated`, `ContentTypeUpdated`, `ContentTypeRemoved`, `ContentTypeImporting`, `ContentTypeImported`, `ContentPartCreated`, `ContentPartUpdated`, `ContentPartRemoved`, `ContentPartAttached`, `ContentPartDetached`, `ContentPartImporting`, `ContentPartImported`, `ContentTypePartUpdated`, `ContentFieldAttached`, `ContentFieldUpdated`, `ContentFieldDetached`, `ContentPartFieldUpdated`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ContentTypes.Abstractions/Events/IContentDefinitionEventHandler.cs:3
`IFileStore` declares 16 members under just 15 distinct name(s): `GetFileInfoAsync`, `GetDirectoryInfoAsync`, `GetDirectoryContentAsync`, `GetFilesAsync`, `GetDirectoriesAsync`, `TryCreateDirectoryAsync`, `TryDeleteFileAsync`, `TryDeleteDirectoryAsync`, `MoveFileAsync`, `CopyFileAsync`, `GetFileStreamAsync`, `GetFileStreamAsync`, `CreateFileFromStreamAsync`, `GetPermittedStorageAsync`, `Capabilities`, `StorageName`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/OrchardCore/OrchardCore.FileStorage.Abstractions/IFileStore.cs:16
`ISite` declares 21 members: `SiteName`, `PageTitleFormat`, `SiteSalt`, `SuperUser`, `Calendar`, `TimeZoneId`, `ResourceDebugMode`, `UseCdn`, `CdnBaseUrl`, `PageSize`, `MaxPageSize`, `MaxPagedCount`, `AllowPageSizeSelection`, `PageSizeOptions`, `BaseUrl`, `HomeRoute`, `AppendVersion`, `CacheMode`, `As`, `GetOrCreate`, `TryGet`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Settings/ISite.cs:6
`IResourceManager` declares 24 members: `InlineManifest`, `FindResource`, `NotRequired`, `RegisterUrl`, `RegisterResource`, `RegisterHeadScript`, `RegisterFootScript`, `RegisterStyle`, `RegisterLink`, `RegisterMeta`, `AppendMeta`, `GetRequiredResources`, `GetRegisteredLinks`, `GetRegisteredMetas`, `GetRegisteredHeadScripts`, `GetRegisteredFootScripts`, `GetRegisteredStyles`, `RenderMeta`, `RenderHeadLink`, `RenderStylesheet`, `RenderHeadScript`, `RenderFootScript`, `RenderLocalScript`, `RenderLocalStyle`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/IResourceManager.cs:5
`IActivity` declares 19 members: `Name`, `DisplayText`, `Category`, `Properties`, `HasEditor`, `GetPossibleOutcomesAsync`, `GetPossibleOutcomes`, `CanExecuteAsync`, `ExecuteAsync`, `ResumeAsync`, `OnInputReceivedAsync`, `OnWorkflowStartingAsync`, `OnWorkflowStartedAsync`, `OnWorkflowResumingAsync`, `OnWorkflowResumedAsync`, `OnWorkflowRestartingAsync`, `OnWorkflowRestartedAsync`, `OnActivityExecutingAsync`, `OnActivityExecutedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/OrchardCore/OrchardCore.Workflows.Abstractions/Activities/IActivity.cs:9
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C1 · Data Protection8.5 / 10Strong✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Do you agree with this assessment?
C3 · Audit Trail7.5 / 10Strong✓ Tool-verified
Other · Security — Whether changes to sensitive data are recorded (who, what, when) for compliance + incident response.
An audit mechanism is present, but the trail is not yet complete — missing: an EF SaveChanges interceptor (or equivalent write-side hook, e.g. an event-store append every change flows through), [Audited] per-entity coverage.
What to do
Back the audit convention with a structural mechanism: an EF SaveChanges interceptor (or equivalent) writing every sensitive change to an immutable audit log, and apply [Audited] to the entities that need a who-changed-what trail.
Do you agree with this assessment?
C4 · Data Retention10.0 / 10Exemplary✓ Tool-verified
Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).
Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.
Other · Event-Driven — Whether event handlers stay asynchronous (no blocking remote HTTP/gRPC calls awaited inside a handler).
Method: Roslyn semantic scan (event-driven gated): event-handler bodies scanned for HTTP/gRPC invocations by resolved symbol type, not substring. Deterministic, semantic-resolved.
Other · Event-Driven — Whether state changes and message publishes are atomic (a transactional outbox) rather than a crash-unsafe dual write.
Method: Roslyn semantic scan (event-driven gated): event-handler methods scanned for DB-save plus bus-publish without a transactional outbox reference. Deterministic, semantic-resolved.
Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.
Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×13) — src/OrchardCore/OrchardCore.Data/Documents/FileDocumentStore.cs:77, src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:319, src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:380, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`EditAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. (×4) — src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaForgotPasswordFormDisplayDriver.cs:19, src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaLoginFormDisplayDriver.cs:20, src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaResetPasswordFormDisplayDriver.cs:20, …
`MapAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/OrchardCore.Modules/OrchardCore.Settings/Services/SitePropertiesLiquidMapper.cs:14
`CommitAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/OrchardCore/OrchardCore.Data/Documents/FileDocumentStore.cs:77
`Items` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:34
`AddAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:53
`PlaceChildContent` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/OrchardCore/OrchardCore.DisplayManagement/Shapes/CoreShapes.cs:13
`Slugify` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/OrchardCore/OrchardCore/Modules/Services/SlugService.cs:12
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×29) — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:56, src/OrchardCore.Modules/OrchardCore.Contents/ViewModels/PublishContentViewModel.cs:9, src/OrchardCore.Modules/OrchardCore.Demo/Startup.cs:117, …
4 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — src/OrchardCore.Modules/OrchardCore.Users/Drivers/AuthenticatorAppLoginSettingsDisplayDriver.cs:51
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 254 of 257 project(s) that lack one — worth up to 2 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
.scripts/bloom/designer/README.md runs `yarn vitest run`, but no REDACTED declares a `vitest` script. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — .scripts/bloom/designer/README.md:46
src/docs/contributing/contributing-documentation.md names `OrchardCore.sln`, but no file or folder `OrchardCore.sln` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/contributing/contributing-documentation.md:17
src/docs/contributing/contributing-documentation.md names `reference/modules/README.md`, but no file or folder `reference/modules/README.md` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/contributing/contributing-documentation.md:28
src/docs/development/media/media-field.md names `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue`, but no file or folder `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-field.md:122
src/docs/development/media/media-gallery.md names `media-gallery/src/components/MediaPickerModal.vue`, but no file or folder `media-gallery/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:236
src/docs/development/media/media-gallery.md names `media-gallery/src/trumbowyg/`, but no file or folder `media-gallery/src/trumbowyg` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:272
src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/components/MediaPickerModal.vue`, but no file or folder `Assets/media-gallery/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:321
src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/trumbowyg/trumbowyg.media.tag.ts`, but no file or folder `Assets/media-gallery/src/trumbowyg/trumbowyg.media.tag.ts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:322
src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/trumbowyg/trumbowyg.media.url.ts`, but no file or folder `Assets/media-gallery/src/trumbowyg/trumbowyg.media.url.ts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:323
src/docs/development/media/media-gallery.md names `Assets/media-picker/src/assets/field.css`, but no file or folder `Assets/media-picker/src/assets/field.css` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/development/media/media-gallery.md:327
src/docs/guides/add-admin-menu/README.md runs ``dotnet run --project .\MySite\MySite.csproj``, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/add-admin-menu/README.md:188
src/docs/guides/assets-manager/README.md runs `yarn {build, watch or host} -n asset-name1, asset-name2`, but no REDACTED declares a `{build,` script. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/assets-manager/README.md:62
src/docs/guides/assets-manager/README.md changes into `C:/repo/OrchardCore/src`, but no such folder exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/assets-manager/README.md:244
src/docs/guides/create-admin-theme/README.md runs `dotnet run --project .\MySite\MySite.csproj`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-admin-theme/README.md:52
src/docs/guides/create-blazor-cms/README.md names .NET 8, but the projects target .NET 10. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-blazor-cms/README.md:9
src/docs/guides/create-blazor-cms/README.md runs `dotnet run --project ./BlazorCms/BlazorCms.csproj`, but `./BlazorCms/BlazorCms.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-blazor-cms/README.md:29
src/docs/guides/create-cms-application/README.md runs `dotnet run --project .\MySite\MySite.csproj`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-cms-application/README.md:33
src/docs/guides/create-modular-application-mvc/README.md runs `dotnet run --project .\OrchardCore.Mvc.Web\OrchardCore.Mvc.Web.csproj`, but `./OrchardCore.Mvc.Web/OrchardCore.Mvc.Web.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-modular-application-mvc/README.md:51
src/docs/guides/create-modular-application-mvc/README.md runs `dotnet restore .\MySite\MySite.csproj --source https://nuget.cloudsmith.io/orchardcore/preview/v3/index.json`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/create-modular-application-mvc/README.md:54
src/docs/guides/gulp-pipeline/README.md names `src/gulpfile.js`, but no file or folder `src/gulpfile.js` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/gulp-pipeline/README.md:17
src/docs/guides/microsoft-entra-id-integration/README.md names the project `OrchardCore.MicrosoftAuthentication.AzureAD`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/guides/microsoft-entra-id-integration/README.md:3
src/docs/topics/display/shapes.md names `Content-BlogPost.cshtml`, but no file or folder `Content-BlogPost.cshtml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/topics/display/shapes.md:271
src/docs/topics/display/shapes.md names `Content-BlogPost.Summary.cshtml`, but no file or folder `Content-BlogPost.Summary.cshtml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/topics/display/shapes.md:272
src/docs/topics/docker/README.md runs `docker image prune -f --filter label=stage=build-env`, but `--filter` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/topics/docker/README.md:82
src/docs/reference/modules/Contents/README.md names the project `OrchardCore.IOrchardHelper`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Contents/README.md:149
src/docs/reference/modules/DataLocalization/README.md documents the environment variable `CONTENT_TYPE_ARTICLE`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/DataLocalization/README.md:172
src/docs/reference/modules/Elasticsearch/README.md links to ``docker-compose.yml``, but `src/docs/reference/modules/Elasticsearch/`docker-compose.yml`` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Elasticsearch/README.md:31
src/docs/reference/modules/Email.Smtp/README.md documents the setting `SmtpEncryptionMethodSTARTTLS`, but no code or configuration file names `SmtpEncryptionMethodSTARTTLS`. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Email.Smtp/README.md:22
src/docs/reference/modules/Media/README.md names the project `OrchardCore.IOrchardHelper`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Media/README.md:271
src/docs/reference/modules/Notifications/README.md names the project `OrchardCore.AdminTemplates`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Notifications/README.md:198
src/docs/reference/modules/OpenId/README.md documents the setting `UseRollingRefreshTokens`, but no code or configuration file names `UseRollingRefreshTokens`. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/OpenId/README.md:396
src/docs/reference/modules/Queries/README.md names the project `OrchardCore.IOrchardHelper`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Queries/README.md:205
src/docs/reference/modules/Secrets/README.md documents the setting `EnvironmentCredential`, but no code or configuration file names `EnvironmentCredential`. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Secrets/README.md:341
src/docs/reference/modules/Secrets/README.md documents the setting `AzurePowerShellCredential`, but no code or configuration file names `AzurePowerShellCredential`. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Secrets/README.md:343
src/docs/reference/modules/Secrets/README.md documents the setting `VisualStudioCredential`, but no code or configuration file names `VisualStudioCredential`. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Secrets/README.md:344
src/docs/reference/modules/Tenants/README.md names the project `OrchardCore.AdminTemplates`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/docs/reference/modules/Tenants/README.md:59
What to do
Reconcile the README with reality: .scripts/bloom/designer/README.md runs `yarn vitest run`, but no REDACTED declares a `vitest` script; src/docs/contributing/contributing-documentation.md names `OrchardCore.sln`, but no file or folder `OrchardCore.sln` exists; src/docs/contributing/contributing-documentation.md names `reference/modules/README.md`, but no file or folder `reference/modules/README.md` exists; src/docs/development/media/media-field.md names `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue`, but no file or folder `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue` exists; src/docs/development/media/media-gallery.md names `media-gallery/src/components/MediaPickerModal.vue`, but no file or folder `media-gallery/src/components/MediaPickerModal.vue` exists.
Only 99/167 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 167, 6 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
What to do
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
The .NET analyzers are running but not blocking — tighten them (set <AnalysisMode>All</AnalysisMode>, or treat analyzer warnings as errors on CI) so a security/quality regression fails the build rather than scrolling past as a warning.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
What to do
The pipeline declares a deployment environment, but whether required reviewers / protection rules are attached to it lives in repository settings we cannot read — confirm the gate is enforced before production promotion.
Do you agree with this assessment?
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
What to do
Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`services.AddHttpClient(SendToWebApiStep.HttpClientName)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/OrchardCore.Modules/OrchardCore.DataPipelines/Startups/DestinationsStartup.cs:16
`services.AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). (×3) — src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Startup.cs:20, src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:69, src/OrchardCore.Modules/OrchardCore.Workflows/Http/Startup.cs:31
`new ServiceCollection() .AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/OrchardCore/OrchardCore/Modules/Extensions/ServiceCollectionExtensions.cs:59
`new HttpClient(handler, disposeHandler: false)` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:119
`new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — REDACTED:128
What to do
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 1282 use(s) across 292,080 production line(s) (~4.4/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
`option` is async and calls subprocess.run — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs. — .agents/skills/orchardcore-video-producer/scripts/pronounce.py:27
`main` is async and calls subprocess.run — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs. — .agents/skills/orchardcore-video-producer/scripts/pronounce.py:49
81 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×26) — src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:42, src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:23, src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:32, …
`.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×11) — src/OrchardCore.Modules/OrchardCore.Email.Azure/Services/AzureEmailOptionsConfiguration.cs:44, src/OrchardCore.Modules/OrchardCore.Email.Smtp/Services/SmtpOptionsConfiguration.cs:71, src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:96, …
What to do
Python: await the async equivalent (asyncio.sleep, an async HTTP client such as httpx.AsyncClient or aiohttp, asyncio.create_subprocess_exec), or move the blocking call off the loop with `await asyncio.to_thread(...)`; never call asyncio.run inside a coroutine — await the coroutine.
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Do you agree with this assessment?
R1 · Type Safety8.1 / 10Strong✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
What to do
Migrate the remaining .js/.jsx files to TypeScript.
React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.
src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/ and src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/ are near-verbatim copies of each other: 19 files are byte-identical under the same relative paths (~470 lines; the trees hold 47 and 32 files). That is one structural fact, not 19 local ones: every edit made to one tree and not the other drifts silently, which is the failure whole-tree forks guarantee. Pick one tree as the single source and produce the other from it (generated, copied at build or release time, or re-exported) — or, if the copy is a stale snapshot nothing produces any more, delete it. Check first whether the copy is a deliberately published deliverable (a template consumers copy verbatim, a released sample frozen at a version); where it is, keep it produced from the source tree rather than edited in place. — src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/sb-watch.js:1
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/ and src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/ are near-verbatim copies of each other: 18 files are byte-identical under the same relative paths (~449 lines; the trees hold 52 and 32 files). That is one structural fact, not 18 local ones: every edit made to one tree and not the other drifts silently, which is the failure whole-tree forks guarantee. Pick one tree as the single source and produce the other from it (generated, copied at build or release time, or re-exported) — or, if the copy is a stale snapshot nothing produces any more, delete it. Check first whether the copy is a deliberately published deliverable (a template consumers copy verbatim, a released sample frozen at a version); where it is, keep it produced from the source tree rather than edited in place. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:1
34 duplicated blocks under src/OrchardCore.Modules/ have copies in at least two of the sibling directories OrchardCore.AdminMenu, OrchardCore.Apis.GraphQL, OrchardCore.AuditTrail, OrchardCore.Autoroute, OrchardCore.ContentFields, OrchardCore.DataLocalization (+27 more sibling(s) not listed) — 28 of them are reported below, and 6 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 34 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 34 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 34 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1
9 of the duplicated blocks reported below have copies in at least two of the sibling directories TheAdmin, TheAgencyTheme, TheBlogTheme, TheComingSoonTheme, TheTheme under src/OrchardCore.Themes/. That concentration is one structural fact, not 9 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 9 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3
8 duplicated blocks under src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/ have copies in at least two of the sibling directories cleanpaste, colors, emoji, fontfamily, fontsize, giphy (+8 more sibling(s) not listed) — 6 of them are reported below, and 2 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1428
5 of the duplicated blocks reported below have copies in at least two of the sibling directories media-gallery, media-picker under src/OrchardCore.Modules/OrchardCore.Media/Assets/. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/PipelinePanel.vue:23 · src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue:20 — the two spans are one implementation copied and then locally edited — 1072 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/PipelinePanel.vue:23
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:194 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldGallery.vue:132 — the two spans are one implementation copied and then locally edited — 680 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:194
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:256 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:203 — the two spans are one implementation copied and then locally edited — 569 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:256
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1 · src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.url.ts:1 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.tag.ts:1 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.url.ts:1 — these 4 files are line-for-line copies of one another — 67 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/sb-watch.js:3 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/sb-watch.js:3 — these 3 files are line-for-line copies of one another — 51 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3
src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:35 · src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:72 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:35
src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/webpack.config.js:6 · src/OrchardCore.Modules/OrchardCore.AuditTrail/Assets/webpack.config.js:5 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/webpack.config.js:6
src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:23 · src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:62 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:22 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:62 — the 4 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:23
src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:88 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:89 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:88
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/ConfirmModalService.ts:7 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileActionModalService.ts:7 — the two spans are one implementation copied and then locally edited — 154 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/ConfirmModalService.ts:7
src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:28 · src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-viewer.ts:12 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:28
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-pug.js:8 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/render-pug.js:8 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/render-pug.js:8 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-pug.js:8
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/vitest.config.ts:4 — the 2 copies are spread across 2 files, and the CITED SPAN is a run of DECLARATIONS inside a construct — the members of a type, or the entries of an object or array literal — with no statement anywhere in it. Do not read this as an extract-a-helper row: nothing here executes, so there is no call site, and a call expression cannot stand where a member declaration or a literal's entry was. What repeats is a SHAPE, and which shape decides the move. Where the copies declare the same members, the repetition is a missing common ancestor: give it a base type, an interface both extend, a generic instantiated twice, or — where the copies are a literal's entries rather than a type's members — one shared constant each site spreads or refers to, so the set is written once. Where they declare DIFFERENT members and only the form is shared — a decorator and its options, an annotation, a registration table's keys — the form is prescribed by a framework or a schema rather than copied, and the only collapse available is to generate the declarations from that schema; where you do not own the generator, this is the cost of the framework and there is nothing to extract. Check which of the two it is before acting: these copies still drift apart the first time only one of them is edited, which is why the repetition is reported, but the sentence to act on is not the same in both cases. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-scss.js:13 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/render-scss.js:13 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/render-scss.js:13 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-scss.js:13
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.config.ts:12 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/vite.config.ts:16 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.config.ts:12
src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:5 · src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/placeholder-admin-node.ts:5 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:5
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start-debug.js:4 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/start-debug.js:4 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/start-debug.js:4 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start-debug.js:4
src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start.js:4 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/start.js:4 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/start.js:4 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start.js:4
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/content-picker-field-settings.ts:10 · src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/bag-part-settings.ts:4 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/content-picker-field-settings.ts:10
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaPickerModal.vue:104 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js:303 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:153 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js:303
src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:2 · src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/placeholder-admin-node.ts:2 · src/OrchardCore.Modules/OrchardCore.Localization/Assets/ts/localization-settings.ts:1 — the 3 copies are spread across 3 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:2
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:46 · src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.url.ts:47 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.tag.ts:46 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.url.ts:47 · +1 more site(s) not listed — the 5 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 5 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:46
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:42 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:97 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:42
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js:131 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:75 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js:131
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:200 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/preformatted/trumbowyg.preformatted.js:99 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:200
src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-index.ts:1 · src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-type-index.ts:1 — the two spans are one implementation copied and then locally edited — 96 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-index.ts:1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/main.ts:67 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaPickerModal.vue:104 — the 3 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:158 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldGallery.vue:109 — the 2 copies are spread across 2 files, and the CITED SPAN is a run of MODULE-LEVEL DECLARATIONS — bindings the module declares and exports — rather than statements with a call site. Do not read this as an extract-a-helper row: a call expression cannot stand where a declaration was, and putting one there would delete the names themselves, which are what the rest of the codebase imports. What actually repeats here is the INITIALISER — the same expression shape written once per binding. So give that expression one name (a small helper the initialisers call, or a shared base value they are each derived from) and keep every binding under the name it already has. Where the run is an enumeration — one binding per distinct thing, differing precisely in the thing each one names — the repetition IS the enumeration and collapsing it would delete entries; consider instead whether the set belongs in one exported table the individual names are read out of. Reported because the copies drift apart the first time only one of them is edited. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:158
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/html-field-trumbowyg-editor.ts:5 · src/OrchardCore.Modules/OrchardCore.Html/Assets/ts/html-body-part-trumbowyg-editor.ts:5 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/html-field-trumbowyg-editor.ts:5
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-monaco.ts:8 · src/OrchardCore.Modules/OrchardCore.Queries/Assets/ts/queries-admin-query.ts:13 — the two spans are one implementation copied and then locally edited — 84 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-monaco.ts:8
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-settings.ts:7 · src/OrchardCore.Modules/OrchardCore.Title/Assets/ts/title-part-settings.ts:7 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-settings.ts:7
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/vite.config.ts:11 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.standalone.config.ts:24 — the two spans are one implementation copied and then locally edited — 66 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/vite.config.ts:11
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:220 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:240 — the two spans are one implementation copied and then locally edited — 70 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:220
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Architecture — Conformance to the detected frontend architecture layout (feature-sliced / layered src) plus cross-package deep-import rules (D-386).
Method: Conformance to the detected frontend layout (feature-sliced / layered src) plus cross-package deep-import rules, over the module graph. Deterministic.
src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/js/App.tsx:6 imports graphiql/dist/components/GraphiQL, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/js/App.tsx:6
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/date-field-localized.ts:8 imports flatpickr/dist/l10n/index.js, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/date-field-localized.ts:8
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:7 imports @uppy/locales/lib/en_US, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:7
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:8 imports @uppy/locales/lib/fr_FR, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:8
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:9 imports @uppy/locales/lib/it_IT, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:9
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:10 imports @uppy/locales/lib/es_ES, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:10
What to do
Fix the listed violations: import through public entries (package exports / slice index), never reach into another layer or package's internals.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
getOptions has cyclomatic complexity 56 and cognitive complexity 54; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:84
orientOutcomeLabels has cyclomatic complexity 30 and cognitive complexity 49; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-canvas.ts:148
(anonymous) has cyclomatic complexity 28 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.MiniProfiler/Assets/ts/miniprofiler.ts:190
validateRule has cyclomatic complexity 23 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:258
updateFilterRow has cyclomatic complexity 21 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:97
onEnd has cyclomatic complexity 20 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Layers/Assets/ts/layers-index.ts:13
openNodeMenu has cyclomatic complexity 16 and cognitive complexity 25; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/DesignerCanvas.vue:239
(anonymous) has cyclomatic complexity 15 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:685
getLiquidContextInfo has cyclomatic complexity 15 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Liquid/Assets/monaco/liquid-intellisense.ts:91
getActiveClientFilters has cyclomatic complexity 15 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:243
getFilterState has cyclomatic complexity 15 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:51
(anonymous) has cyclomatic complexity 14 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileLibraryManager.ts:351
updateGroup has cyclomatic complexity 14 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:637
loadIndex has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Admin/Assets/js/quick-navigation.ts:220
(anonymous) has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. (×2) — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/runs/runOverlay.ts:46, src/OrchardCore.Modules/OrchardCore.OpenApi/Assets/openapi-ui-auth/src/openapi-ui-auth.ts:181
refreshFlows has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-client-settings.ts:21
convertToFileHierarchyTreeNode has cyclomatic complexity 13 and cognitive complexity 24; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:142
(anonymous) has cyclomatic complexity 13 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:349
readConfig has cyclomatic complexity 13 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts:36
What to do
Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
Do you agree with this assessment?
R3 · Large Files9.2 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js has 1480 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js has 1401 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:1
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue has 800 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue:1
src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js has 586 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts has 568 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue has 517 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:1
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue has 447 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue:1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue has 412 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:1
What to do
Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
Do you agree with this assessment?
R4 · Test Coverage2.2 / 10Critical✓ Tool-verified
React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.
Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.
No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×40) — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:1, src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1, src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:1, …
What to do
Add tests that import the unreached modules (directly or through their public entry).
Do you agree with this assessment?
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each REDACTED script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.
Method: REDACTED scanned for test/lint/typecheck script wiring. Deterministic presence check.
Do you agree with this assessment?
R7 · Dead Code6.3 / 10Adequate✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
2 file(s) (~33 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package. — src/OrchardCore.Modules/OrchardCore.Autoroute/Assets
2 file(s) (~30 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package. — src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Assets
2 file(s) (~12 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package. — src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Assets
Unreachable from the 188 application, 23 tooling and 62 test entry point(s) detected in this repo. Gate removals on `yarn run build` — an undetected custom entry would make these reachable.
no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make (×35) — src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js, src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js, src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js, …
no import path from any entry point (188 application, 23 tooling, 62 test roots considered), but 3 in-repo import(s) from 3 other file(s) do name it (src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/bag-part-blocks.ts, src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-card-flow-part-blocks.ts, src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flow-part-blocks.ts) — every one of those referrers is itself unreachable, so this file is dead only as a member of that cluster: if any referrer is in fact alive, this row falls with it — src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flow-widget-picker-button.ts
What to do
Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.
Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.
Imported but not declared in any reachable REDACTED — installs work only by hoisting accident. (×24) — src/OrchardCore.Modules/OrchardCore.Media/Assets/ts/media-profile-editor.ts:1, src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/menu-list.ts:1, src/OrchardCore.Modules/OrchardCore.Alias/Assets/ts/alias-part-settings.ts:1, …
Imported only as a TYPE and declared in no reachable REDACTED. The import is erased at compile time, so nothing is installed and no runtime resolution depends on it — but type-checking a clean clone will fail. Declare the typings it resolves through (or the package itself) in the owning REDACTED. — src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-type-picker.ts:3
Declared in the root REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it. (×3)
Every import is type-only — move it to devDependencies. — src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:13
Only test files import it (first: src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/__tests__/media-gallery-auth.spec.ts:170) — move it to devDependencies. — REDACTED:29
What to do
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`https://use.fontawesome.com/releases/v6.3.0/js/all.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 9 such include(s) across the repository's markup. — src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/src/pug/index.pug:17
What to do
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×37) — src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:42, src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:23, src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:32, …
Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×2) — src/OrchardCore.Modules/OrchardCore.CustomSettings/Services/CustomSettingsService.cs:60, src/OrchardCore.Modules/OrchardCore.DataLocalization/Services/DataTranslationProvider.cs:23
`File.WriteAllText` blocks the thread on I/O while `File.WriteAllTextAsync` exists to wait without one — inside a method that is already `async`, await the twin. — src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/ImportController.cs:179
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader3.5 / 10Weak✓ Tool-verified
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
`length` is read from the stream being parsed at line 44 (`ReadInt32`), then used to size an array at line 51 — and nowhere in this method is `length` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `length` against the bytes actually remaining in the stream before spending it. — src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataRowSerializer.cs:51
What to do
Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document2.7 / 10Weak✓ Tool-verified
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
`FindTerm` is internal and takes the `JsonArray` from its caller, and it calls itself at line 82 with a child of the node it was given — and nowhere in `FindTerm` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the tree it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. A document nested past the stack that remains raises `StackOverflowException`, which .NET neither lets you catch nor unwinds: the process is torn down where it stands, taking every other request in flight with it, and no `try`/`catch` around `FindTerm` can intervene. Thread a depth argument through `FindTerm` and reject the document past a fixed maximum, or rewrite the descent with an explicit stack. — src/OrchardCore.Modules/OrchardCore.Taxonomies/Helper/TaxonomyOrchardHelperExtensions.cs:82
`FindTermHierarchy` is internal and takes the `JsonArray` from its caller, and it calls itself at line 109 with a child of the node it was given — and nowhere in `FindTermHierarchy` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the tree it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. A document nested past the stack that remains raises `StackOverflowException`, which .NET neither lets you catch nor unwinds: the process is torn down where it stands, taking every other request in flight with it, and no `try`/`catch` around `FindTermHierarchy` can intervene. Thread a depth argument through `FindTermHierarchy` and reject the document past a fixed maximum, or rewrite the descent with an explicit stack. — src/OrchardCore.Modules/OrchardCore.Taxonomies/Helper/TaxonomyOrchardHelperExtensions.cs:109
What to do
Each finding names the externally-callable member that accepts the document and the self-call that descends, and states that no depth parameter or counter exists anywhere in the walk. Confirm from the two, then thread a depth argument through the walk and reject documents past a fixed maximum, or rewrite it with an explicit stack.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`ShellContext` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_semaphore` itself (line 12), which makes that instance its own. But `_semaphore` is named in none of the methods the disposal search covered: `Dispose` (line 325), `DisposeAsync` (line 331), `Close` (line 337), `CloseAsync` (line 354) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_semaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/OrchardCore/OrchardCore.Abstractions/Shell/Builders/ShellContext.cs:12
`_batches` is never created by `DataPipelineRowReader` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 139). Its declared type `IAsyncEnumerator` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/DataPipelineRowReader.cs:139
`debugContent` is a `StringWriter`, which implements `IDisposable`, and it is created here (line 109). Every use of it in `WriteToAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var debugContent = …;`), which releases it at the end of the scope on every path including a throw. — src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheTag.cs:109
`transferUtility` is a `TransferUtility`, which implements `IDisposable`, and it is created here (line 255). Every use of it in `GetFileStreamAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var transferUtility = …;`), which releases it at the end of the scope on every path including a throw. — src/OrchardCore/OrchardCore.FileStorage.AmazonS3/AwsFileStorage.cs:255
`ShellHost` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializingSemaphore` itself (line 30), which makes that instance its own. But `_initializingSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 536), `DisposeAsync` (line 544), `ListShellContexts` (line 313) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializingSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/OrchardCore/OrchardCore/Shell/ShellHost.cs:30
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 287/2814 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×39) — src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:59, src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs:57, src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:56, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped2.1 / 10Critical✓ Tool-verified
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
`Model.Html` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×8) — src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField.cshtml:9, src/OrchardCore.Modules/OrchardCore.Facebook/Views/FacebookPluginPart.Summary.cshtml:12, src/OrchardCore.Modules/OrchardCore.Facebook/Views/FacebookPluginPart.cshtml:12, …
`bodyAspect.Body` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Contents/Views/BodyAspect.cshtml:11
`_htmlEncoder.Encode(url)` is text this program did not author, and it is written into the start of a URL attribute, where it chooses the scheme through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML encoding does not help here — a `javascript:` URL contains nothing it changes; allow only http(s) or a relative path. — src/OrchardCore.Modules/OrchardCore.DataPipelines/SharedLinks/SharedLinkManager.cs:320
`Render(settings.Body, run, now, WebUtility.HtmlEncode(fileNames))` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendByEmailStep.cs:137
`sb.ToString()` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Demo/Shapes/DemoShapeProvider.cs:29
`cachedContent` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:57
`cacheContext.CacheId` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:103, src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:114
`$" VARY BY: {string.Join(", ", cacheContext.Contexts)}"` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:104
`$" DEPENDENCIES: {string.Join(", ", cacheContext.Tags)}"` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:105
`sw.ToString()` is text this program did not author, and it is written into the text of an element through `AppendHtml` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:111
`content` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:126
`content` is text this program did not author, and it is written into the text of an element through `SetHtmlContent` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:154
`html` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×3) — src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:215, src/OrchardCore.Modules/OrchardCore.Markdown/Handlers/MarkdownBodyPartHandler.cs:45, src/OrchardCore.Modules/OrchardCore.Markdown/Razor/ContentRazorHelperExtensions.cs:23
`value` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:224
`Url.Action("Query", "Admin", new { area = "OrchardCore.Elasticsearch", query = Model.MatchAllQuery, id = Model.Id })` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Elasticsearch/Views/Admin/Query.cshtml:37
`message.HtmlBody` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — REDACTED:130
`htmlBody?.Trim()` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — src/OrchardCore.Modules/OrchardCore.Email/Workflows/Activities/EmailTask.cs:159, src/OrchardCore.Modules/OrchardCore.Email/Workflows/Activities/EmailTask.cs:166
`activity.HtmlBody.Expression` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Email/Workflows/Drivers/EmailTaskDisplayDriver.cs:19
`new WorkflowExpression<string>(model.HtmlBody)` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Email/Workflows/Drivers/EmailTaskDisplayDriver.cs:33
`model.Html` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Html/Handlers/HtmlBodyPartHandler.cs:52
`Model.Html.RemoveTags(true).Ellipsize(200)` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×3) — src/OrchardCore.Modules/OrchardCore.Html/Views/HtmlBodyPart.Summary.cshtml:3, src/OrchardCore.Modules/OrchardCore.Liquid/Views/LiquidPart.Summary.cshtml:4, src/OrchardCore.Modules/OrchardCore.Markdown/Views/MarkdownBodyPart.Summary.cshtml:4
`S["Lucene"]` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — src/OrchardCore.Modules/OrchardCore.Lucene/Shapes/LuceneContentPickerShapeProvider.cs:26, src/OrchardCore.Modules/OrchardCore.Lucene/Shapes/LuceneContentPickerShapeProvider.cs:28
`Url.Action("Query", "Admin", new { area = "OrchardCore.Lucene", query = Model.MatchAllQuery, id = Model.Id })` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Lucene/Views/Admin/Query.cshtml:33
`htmlMenuItemPart.Html` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Menu/Views/MenuItemLink-HtmlMenuItem.cshtml:29
`CoerceHtmlString(Value)` is text this program did not author, and it is written into the text of an element through `AppendHtml` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:549
`option` is text this program did not author, and it is written into the text of an element through `AppendHtml` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:593
What to do
Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×17) — src/OrchardCore.Modules/OrchardCore.Forms/Drivers/FormInputElementVisibilityPartDisplayDriver.cs:146, src/OrchardCore.Modules/OrchardCore.Liquid/Filters/DataProtectionFilters.cs:53, src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:203, …
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×7) — src/OrchardCore.Modules/OrchardCore.Html/Handlers/HtmlBodyPartHandler.cs:54, src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidPartHandler.cs:73, src/OrchardCore.Modules/OrchardCore.Markdown/Handlers/MarkdownBodyPartHandler.cs:47, …
`catch (BadHttpRequestException) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:102
`catch (CryptographicException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×2) — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:274, src/OrchardCore.Modules/OrchardCore.Secrets/Drivers/X509SecretDisplayDriver.cs:114
`catch (Exception) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineEdge.cs:175
`catch (OverflowException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataAccumulator.cs:156
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×2) — src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEnginePool.cs:177, src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEnginePool.cs:241
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `REDACTED` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `partFieldDefinition`: line 48 writes `partFieldDefinition?.GetSettings`, which says `partFieldDefinition` can be null, but line 54 then dereferences it directly as `partFieldDefinition.Editor` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partFieldDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partFieldDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.ContentFields/Controllers/ContentPickerAdminController.cs:54
This method contradicts itself about `partFieldDefinition`: line 50 writes `partFieldDefinition?.GetSettings`, which says `partFieldDefinition` can be null, but line 56 then dereferences it directly as `partFieldDefinition.Editor` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partFieldDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partFieldDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.ContentFields/Controllers/UserPickerAdminController.cs:56
This method contradicts itself about `ci`: line 97 writes `ci?.ContentItemId`, which says `ci` can be null, but line 89 then dereferences it directly as `ci.ContentItemId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `ci` truly cannot be null here, the `?.` is misleading. Settle it one way — test `ci` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.ContentLocalization/Drivers/LocalizationPartDisplayDriver.cs:89
This method contradicts itself about `data`: line 37 assigns it with `as JsonArray`, which hands back null rather than throwing when the value is not a `JsonArray`, but line 38 then dereferences it directly as `data.Add` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `data` once before the first use and handle the null case, or cast with `(JsonArray)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AddToDeploymentPlan/ContentItemDeploymentSource.cs:38
This method contradicts itself about `controller`: line 12 assigns it with `as Controller`, which hands back null rather than throwing when the value is not a `Controller`, but line 26 then dereferences it directly as `controller.TempData` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `controller` once before the first use and handle the null case, or cast with `(Controller)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Forms/Filters/ImportModelStateAttribute.cs:26
This method contradicts itself about `pageModel`: line 12 assigns it with `as PageModel`, which hands back null rather than throwing when the value is not a `PageModel`, but line 27 then dereferences it directly as `pageModel.TempData` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `pageModel` once before the first use and handle the null case, or cast with `(PageModel)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Forms/Filters/ImportModelStatePageFilter.cs:27
This method contradicts itself about `menuItems`: line 270 assigns it with `as JsonArray`, which hands back null rather than throwing when the value is not a `JsonArray`, but line 272 then dereferences it directly as `menuItems.Remove` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `menuItems` once before the first use and handle the null case, or cast with `(JsonArray)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:272
This method contradicts itself about `indexSource`: line 220 assigns it with `as SitemapIndexSource`, which hands back null rather than throwing when the value is not a `SitemapIndexSource`, but line 228 then dereferences it directly as `indexSource.ContainedSitemapIds` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `indexSource` once before the first use and handle the null case, or cast with `(SitemapIndexSource)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:228
This method contradicts itself about `indexSource`: line 261 assigns it with `as SitemapIndexSource`, which hands back null rather than throwing when the value is not a `SitemapIndexSource`, but line 277 then dereferences it directly as `indexSource.ContainedSitemapIds` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `indexSource` once before the first use and handle the null case, or cast with `(SitemapIndexSource)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:277
This method contradicts itself about `partViewModel`: line 171 writes `partViewModel?.Position`, which says `partViewModel` can be null, but line 184 then dereferences it directly as `partViewModel.Position` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partViewModel` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partViewModel` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.AdminDashboard/Controllers/DashboardController.cs:184
This method contradicts itself about `operationDefinition`: line 34 writes `operationDefinition?.Name`, which says `operationDefinition` can be null, but line 34 then dereferences it directly as `operationDefinition.Operation` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `operationDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `operationDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:34
This method contradicts itself about `fieldType`: line 75 writes `fieldType?.GetPermissions`, which says `fieldType` can be null, but line 95 then dereferences it directly as `fieldType.Name` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `fieldType` truly cannot be null here, the `?.` is misleading. Settle it one way — test `fieldType` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:95
This method contradicts itself about `settings`: line 68 writes `settings?.IsEnabled`, which says `settings` can be null, but line 60 then dereferences it directly as `settings.Name` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `settings` truly cannot be null here, the `?.` is misleading. Settle it one way — test `settings` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.AuditTrail/Drivers/AuditTrailSettingsDisplayDriver.cs:60
This method contradicts itself about `request`: line 270 writes `request?.DataSet`, which says `request` can be null, but line 272 then dereferences it directly as `request.DataSet` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `request` truly cannot be null here, the `?.` is misleading. Settle it one way — test `request` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:272
This method contradicts itself about `pipeline`: line 380 writes `pipeline?.`, which says `pipeline` can be null, but line 430 then dereferences it directly as `pipeline.GetEditableDefinition` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `pipeline` truly cannot be null here, the `?.` is misleading. Settle it one way — test `pipeline` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:430
This method contradicts itself about `request`: line 702 writes `request?.VersionId`, which says `request` can be null, but line 711 then dereferences it directly as `request.Revision` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `request` truly cannot be null here, the `?.` is misleading. Settle it one way — test `request` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:711
This method contradicts itself about `index`: line 263 writes `index?.ContentItemId`, which says `index` can be null, but line 260 then dereferences it directly as `index.ContentType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `index` truly cannot be null here, the `?.` is misleading. Settle it one way — test `index` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Contents/SaveContentItemsStep.cs:260
This method contradicts itself about `header`: line 120 writes `header?.Name`, which says `header` can be null, but line 139 then dereferences it directly as `header.Value` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `header` truly cannot be null here, the `?.` is misleading. Settle it one way — test `header` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:139
This method contradicts itself about `header`: line 202 writes `header?.Name`, which says `header` can be null, but line 209 then dereferences it directly as `header.Value` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `header` truly cannot be null here, the `?.` is misleading. Settle it one way — test `header` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:209
This method contradicts itself about `model`: line 25 assigns it with `as FacebookPluginPartViewModel`, which hands back null rather than throwing when the value is not a `FacebookPluginPartViewModel`, but line 28 then dereferences it directly as `model.Html` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `model` once before the first use and handle the null case, or cast with `(FacebookPluginPartViewModel)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Facebook/Widgets/Services/LiquidShapes.cs:28
This method contradicts itself about `existingPolicy`: line 584 writes `existingPolicy?.IsEnabled`, which says `existingPolicy` can be null, but line 593 then dereferences it directly as `existingPolicy.Scope` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `existingPolicy` truly cannot be null here, the `?.` is misleading. Settle it one way — test `existingPolicy` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs:593
This method contradicts itself about `id`: line 93 writes `id?.IndexOf`, which says `id` can be null, but line 95 then dereferences it directly as `id.Length` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `id` truly cannot be null here, the `?.` is misleading. Settle it one way — test `id` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Secrets/ViewModels/SecretIndexViewModel.cs:95
This method contradicts itself about `userInfo`: line 609 assigns it with `as User`, which hands back null rather than throwing when the value is not a `User`, but line 611 then dereferences it directly as `userInfo.Properties` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `userInfo` once before the first use and handle the null case, or cast with `(User)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:611
This method contradicts itself about `info`: line 713 writes `info?.`, which says `info` can be null, but line 720 then dereferences it directly as `info.LoginProvider` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `info` truly cannot be null here, the `?.` is misleading. Settle it one way — test `info` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:720
This method contradicts itself about `options`: line 44 writes `options?.CookieManager`, which says `options` can be null, but line 46 then dereferences it directly as `options.TicketDataFormat` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `options` truly cannot be null here, the `?.` is misleading. Settle it one way — test `options` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Users/RateLimitPartitionKeys.cs:46
This method contradicts itself about `user`: line 46 writes `user?.Identity`, which says `user` can be null, but line 52 then dereferences it directly as `user.Identity` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `user` truly cannot be null here, the `?.` is misleading. Settle it one way — test `user` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Users/Workflows/Activities/ValidateUserTask.cs:52
This method contradicts itself about `exception`: line 25 writes `exception?.ToString`, which says `exception` can be null, but line 26 then dereferences it directly as `exception.Message` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `exception` truly cannot be null here, the `?.` is misleading. Settle it one way — test `exception` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore.Modules/OrchardCore.Workflows/Handlers/DefaultWorkflowFaultHandler.cs:26
This method contradicts itself about `contentShape`: line 200 assigns it with `as IZoneHolding`, which hands back null rather than throwing when the value is not a `IZoneHolding`, but line 207 then dereferences it directly as `contentShape.Zones` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `contentShape` once before the first use and handle the null case, or cast with `(IZoneHolding)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:207
This method contradicts itself about `contentShape`: line 295 assigns it with `as IZoneHolding`, which hands back null rather than throwing when the value is not a `IZoneHolding`, but line 302 then dereferences it directly as `contentShape.Zones` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `contentShape` once before the first use and handle the null case, or cast with `(IZoneHolding)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:302
This method contradicts itself about `shape`: line 94 assigns it with `as Shape`, which hands back null rather than throwing when the value is not a `Shape`, but line 95 then dereferences it directly as `shape.TryGetProperty` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `shape` once before the first use and handle the null case, or cast with `(Shape)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.ContentManagement.Display/Placement/ContentPartPlacementNodeFilterProvider.cs:95
This method contradicts itself about `currentField`: line 287 writes `currentField?.GetMetadata`, which says `currentField` can be null, but line 384 then dereferences it directly as `currentField.GetMetadata` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `currentField` truly cannot be null here, the `?.` is misleading. Settle it one way — test `currentField` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:384
This method contradicts itself about `importingItem`: line 742 writes `importingItem?.ContentItemVersionId`, which says `importingItem` can be null, but line 713 then dereferences it directly as `importingItem.ContentItemVersionId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `importingItem` truly cannot be null here, the `?.` is misleading. Settle it one way — test `importingItem` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:713
This method contradicts itself about `context`: line 19 writes `context?.User`, which says `context` can be null, but line 19 then dereferences it directly as `context.HasSucceeded` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `context` truly cannot be null here, the `?.` is misleading. Settle it one way — test `context` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/OrchardCore/OrchardCore.Infrastructure/Security/AuthorizationHandlers/PermissionHandler.cs:19
8/231 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~1.0 `!` suppressions per 1k syntax nodes — 32 suppression(s) across the 32485 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 3 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 4 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 20 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 24 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AX4 Dependency direction — not applicable to a CQRS architecture (the inward-dependency rule is for layered/clean styles)
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — 5 query handlers detected, but none of their entry-point bodies could be walked — the query-purity oracle recognises a value-returning Execute/Handle/Consume (±Async) entry point or one that implements the classifying handler interface's member, and this codebase's handlers were classified but never read. This is an engine limitation, not a finding about the repository.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — docker build failed (exit 1) — DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
Install the buildx component to build images with BuildKit:
https://docs.docker.com/go/bui…; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
D12 Dependency Hygiene — Dependency hygiene not measured
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D28 Secrets (history) — gitleaks killed before it finished — this repository's git history not scanned
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: the .NET half could not be measured — the repository runs its tests on Microsoft.Testing.Platform and wires up no coverage extension for it; the JavaScript/TypeScript half measured 68.0% (vitest + @vitest/coverage-v8 via `yarn install --immutable --mode=skip-build` in src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/). This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 3 value object(s); 17 domain event(s); its domain events are published by services or handlers — no domain entity raises one
ED2 Event/command shape — no command-shaped messages detected — single-handler-per-command check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
R5 Dependency Freshness — uses a yarn lockfile — dependency freshness not measured here; JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
NoWarnInCsproj tools/OpenApiClientGenerator/OpenApiClientGenerator.csproj:9— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests/OrchardCore.Tests.csproj:7— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests.Integration/OrchardCore.Tests.Integration.csproj:7— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests.Functional/OrchardCore.Tests.Functional.csproj:7— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Benchmarks/OrchardCore.Benchmarks.csproj:11— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj:8— CA1707 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests/OrchardCore.Tests.csproj:7— EnableGenerateDocumentationFile — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests.Integration/OrchardCore.Tests.Integration.csproj:7— EnableGenerateDocumentationFile — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Benchmarks/OrchardCore.Benchmarks.csproj:11— EnableGenerateDocumentationFile — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj:8— EnableGenerateDocumentationFile — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/OrchardCore.Tests.Pages/OrchardCore.Application.Pages/OrchardCore.Application.Pages.csproj:10— EnableGenerateDocumentationFile — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/OrchardCore.Mvc.Web/OrchardCore.Mvc.Web.csproj:9— CS1591 — this project generates an XML documentation file as a build output, so its documentation is something it PUBLISHES to whoever consumes the assembly, and this entry switches off a rule whose only job is to report that documentation missing or malformed. The two decisions sit in the same file and the quiet one wins: the documentation this project ships has holes exactly where the rule would have pointed, no build says so, and the people who meet the gap are downstream — in their editor, at the moment they are trying to use the member. Write the documentation the rule is asking for and drop the code from the list; where only some elements genuinely cannot carry it, narrow the suppression to those sites and give each one its reason, so the rest of the API stays covered. If the documentation was never meant to be consumed, the honest fix is the other line — stop generating the file, so the project no longer publishes something it is choosing not to check.
NoWarnInCsproj src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj:17— CS1591 — this project generates an XML documentation file as a build output, so its documentation is something it PUBLISHES to whoever consumes the assembly, and this entry switches off a rule whose only job is to report that documentation missing or malformed. The two decisions sit in the same file and the quiet one wins: the documentation this project ships has holes exactly where the rule would have pointed, no build says so, and the people who meet the gap are downstream — in their editor, at the moment they are trying to use the member. Write the documentation the rule is asking for and drop the code from the list; where only some elements genuinely cannot carry it, narrow the suppression to those sites and give each one its reason, so the rest of the API stays covered. If the documentation was never meant to be consumed, the honest fix is the other line — stop generating the file, so the project no longer publishes something it is choosing not to check.
NoWarnInCsproj Directory.Build.props:61— CS1591 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/OrchardCore.Build/OrchardCore.Commons.props:10— CS1591 — this project generates an XML documentation file as a build output, so its documentation is something it PUBLISHES to whoever consumes the assembly, and this entry switches off a rule whose only job is to report that documentation missing or malformed. The two decisions sit in the same file and the quiet one wins: the documentation this project ships has holes exactly where the rule would have pointed, no build says so, and the people who meet the gap are downstream — in their editor, at the moment they are trying to use the member. Write the documentation the rule is asking for and drop the code from the list; where only some elements genuinely cannot carry it, narrow the suppression to those sites and give each one its reason, so the rest of the API stays covered. If the documentation was never meant to be consumed, the honest fix is the other line — stop generating the file, so the project no longer publishes something it is choosing not to check.
NoWarnInCsproj src/OrchardCore.AspireHost/OrchardCore.AspireHost.csproj:10— ASPIRE010 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj:22— CS8021 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj:22— CS2008 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/Templates/OrchardCore.ProjectTemplates/OrchardCore.ProjectTemplates.csproj:22— CA1016 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:23— CA1304 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:23— CA1305 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:23— CA1310 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:26— CA1311 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:29— CA1000 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj Directory.Build.props:32— CA1848 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
Captive dependency: singleton ElasticsearchQueryFieldTypeProvider captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:27— `ElasticsearchQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton SiteLayersQuery captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Layers/GraphQL/SiteLayersQuery.cs:22— `SiteLayersQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton LuceneQueryFieldTypeProvider captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:28— `LuceneQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton MediaAssetQuery captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaAssetQuery.cs:20— `MediaAssetQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton MediaJSLocalizer captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Media/Services/MediaJSLocalizer.cs:11— `MediaJSLocalizer` is registered as a SINGLETON but its constructor takes `IStringLocalizer S`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton SqlQueryFieldTypeProvider captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:31— `SqlQueryFieldTypeProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton FileDownloadDeploymentTargetProvider captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Deployment/Services/FileDownloadDeploymentTargetProvider.cs:10— `FileDownloadDeploymentTargetProvider` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton FacebookService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Facebook/Services/FacebookService.cs:17— `FacebookService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton GoogleAuthenticationService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Google/Authentication/Services/GoogleAuthenticationService.cs:16— `GoogleAuthenticationService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton SiteCulturesQuery captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Localization/GraphQL/SiteCulturesQuery.cs:28— `SiteCulturesQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton AzureADService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Services/AzureADService.cs:16— `AzureADService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton MicrosoftAccountService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Services/MicrosoftAccountService.cs:16— `MicrosoftAccountService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton OpenIdClientService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdClientService.cs:19— `OpenIdClientService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton OpenIdServerService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:38— `OpenIdServerService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton OpenIdValidationService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdValidationService.cs:30— `OpenIdValidationService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton FixedWindowRateLimiterSource captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.RateLimits/Services/FixedWindowRateLimiterSource.cs:23— `FixedWindowRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton SlidingWindowRateLimiterSource captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.RateLimits/Services/SlidingWindowRateLimiterSource.cs:23— `SlidingWindowRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ConcurrencyRateLimiterSource captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.RateLimits/Services/ConcurrencyRateLimiterSource.cs:23— `ConcurrencyRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton TokenBucketRateLimiterSource captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.RateLimits/Services/TokenBucketRateLimiterSource.cs:23— `TokenBucketRateLimiterSource` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton TwitterSettingsService captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Twitter/Services/TwitterSettingsService.cs:16— `TwitterSettingsService` is registered as a SINGLETON but its constructor takes `IStringLocalizer stringLocalizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton CurrentUserQuery captures transient IStringLocalizer src/OrchardCore.Modules/OrchardCore.Users/GraphQL/CurrentUserQuery.cs:24— `CurrentUserQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ContentItemQuery captures transient IStringLocalizer src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemQuery.cs:16— `ContentItemQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ContentTypeQuery captures transient IStringLocalizer src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentTypeQuery.cs:28— `ContentTypeQuery` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton ShellDbTablesRemovingHandler captures transient IStringLocalizer src/OrchardCore/OrchardCore.Data.YesSql/Removing/ShellDbTablesRemovingHandler.cs:25— `ShellDbTablesRemovingHandler` is registered as a SINGLETON but its constructor takes `IStringLocalizer localizer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IStringLocalizer` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton DataLocalizerFactory captures transient DataResourceManager src/OrchardCore/OrchardCore.Localization.Core/Data/DataLocalizerFactory.cs:14— `DataLocalizerFactory` is registered as a SINGLETON but its constructor takes `DataResourceManager dataResourceManager`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `DataResourceManager` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Media/Assets/ts/media-profile-editor.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/menu-list.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Alias/Assets/ts/alias-part-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Autoroute/Assets/ts/autoroute-part-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Assets/ts/background-task-index.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/content-picker-field-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.ContentPreview/Assets/ts/preview-part-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.ContentTypes/Assets/js/autocomplete.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Contents/Assets/ts/content-task-editor.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Cors/Assets/ts/cors-admin-index.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.CustomSettings/Assets/ts/custom-settings-deployment-step.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.DataLocalization/Assets/ts/translation-editor.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Assets/ts/remote-client-index.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Deployment/Assets/ts/deployment-plan-display.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Elasticsearch/Assets/ts/elastic-query.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Email/Assets/ts/email-task.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Facebook/Assets/ts/facebook-plugin-part-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-type-picker.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Forms/Assets/ts/form-element-label-part.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Html/Assets/ts/html-body-part-monaco-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Indexing/Assets/ts/indexing-admin-index.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Liquid/Assets/ts/liquid-part.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Lists/Assets/ts/lists-admin-node.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Unlisted import '@orchardcore/bloom' src/OrchardCore.Modules/OrchardCore.Localization/Assets/ts/localization-settings.ts:1— Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Namespace dependency cycle src/OrchardCore/OrchardCore/Locking/LocalLock.cs:2— The namespaces OrchardCore.Locking ↔ OrchardCore.Locking.Distributed depend on each other. The lightest dependency in the cycle is OrchardCore.Locking → OrchardCore.Locking.Distributed (OrchardCore.Locking.LocalLock → OrchardCore.Locking.Distributed.IDistributedLock, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Abstractions/Json/JsonDerivedTypesOptions.cs:1— The namespaces OrchardCore.Json ↔ System.Text.Json.Serialization depend on each other. The lightest dependency in the cycle is OrchardCore.Json → System.Text.Json.Serialization (OrchardCore.Json.JsonDerivedTypesOptions → System.Text.Json.Serialization.IJsonDerivedTypeInfo, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Workflows/Trimming/Extensions/ServiceCollectionExtensions.cs:3— The namespaces Microsoft.Extensions.DependencyInjection ↔ OrchardCore ↔ OrchardCore.Admin ↔ OrchardCore.Admin.Models ↔ OrchardCore.BackgroundTasks ↔ OrchardCore.ContentManagement ↔ OrchardCore.ContentManagement.Handlers ↔ OrchardCore.ContentManagement.Metadata ↔ OrchardCore.ContentManagement.Metadata.Builders ↔ OrchardCore.ContentManagement.Metadata.Models ↔ OrchardCore.ContentManagement.Metadata.Records ↔ OrchardCore.ContentManagement.Metadata.Settings ↔ OrchardCore.ContentManagement.Records ↔ OrchardCore.ContentTypes.Events ↔ OrchardCore.Data.Documents ↔ OrchardCore.Data.Migration ↔ OrchardCore.DataSources ↔ OrchardCore.DataSources.Expressions ↔ OrchardCore.Deployment ↔ OrchardCore.Deployment.Remote.Models ↔ OrchardCore.Deployment.Remote.Services ↔ OrchardCore.DisplayManagement ↔ OrchardCore.DisplayManagement.Descriptors ↔ OrchardCore.DisplayManagement.Descriptors.ShapeTemplateStrategy ↔ OrchardCore.DisplayManagement.Handlers ↔ OrchardCore.DisplayManagement.Implementation ↔ OrchardCore.DisplayManagement.Layout ↔ OrchardCore.DisplayManagement.Razor ↔ OrchardCore.DisplayManagement.Shapes ↔ OrchardCore.DisplayManagement.Theming ↔ OrchardCore.DisplayManagement.Title ↔ OrchardCore.DisplayManagement.ViewModels ↔ OrchardCore.DisplayManagement.Views ↔ OrchardCore.DisplayManagement.Zones ↔ OrchardCore.Documents ↔ OrchardCore.Documents.Options ↔ OrchardCore.Environment.Cache ↔ OrchardCore.Environment.Extensions ↔ OrchardCore.Environment.Extensions.Features ↔ OrchardCore.Environment.Shell ↔ OrchardCore.Environment.Shell.Builders ↔ OrchardCore.Environment.Shell.Builders.Models ↔ OrchardCore.Environment.Shell.Configuration ↔ OrchardCore.Environment.Shell.Removing ↔ OrchardCore.Environment.Shell.Scope ↔ OrchardCore.FileStorage ↔ OrchardCore.FileStorage.AzureBlob ↔ OrchardCore.Localization ↔ OrchardCore.Modules ↔ OrchardCore.Modules.Services ↔ OrchardCore.Navigation ↔ OrchardCore.Recipes.Services ↔ OrchardCore.ResourceManagement ↔ OrchardCore.Scripting ↔ OrchardCore.Security.Permissions ↔ OrchardCore.Settings ↔ OrchardCore.Shells.Azure.Configuration ↔ OrchardCore.Shells.Azure.Services depend on each other. The lightest dependency in the cycle is Microsoft.Extensions.DependencyInjection → OrchardCore.Environment.Shell.Configuration (Microsoft.Extensions.DependencyInjection.ServiceCollectionExtensions → OrchardCore.Environment.Shell.Configuration.IShellConfiguration, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Data.YesSql.Abstractions/ITableNameConventionFactory.cs:5— The namespaces OrchardCore.Data ↔ OrchardCore.Data.YesSql depend on each other. The lightest dependency in the cycle is OrchardCore.Data.YesSql → OrchardCore.Data (OrchardCore.Data.YesSql.ITableNameConventionFactory → OrchardCore.Data.DatabaseTableOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Indexing.Abstractions/Models/CreateIndexingTaskContext.cs:3— The namespaces OrchardCore.Indexing ↔ OrchardCore.Indexing.Models depend on each other. The lightest dependency in the cycle is OrchardCore.Indexing.Models → OrchardCore.Indexing (OrchardCore.Indexing.Models.CreateIndexingTaskContext → OrchardCore.Indexing.RecordIndexingTaskTypes, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Security/Options/SecurityHeadersOptions.cs:1— The namespaces OrchardCore.Security.Options ↔ OrchardCore.Security.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Security.Options → OrchardCore.Security.Services (OrchardCore.Security.Options.SecurityHeadersOptions → OrchardCore.Security.Services.IHeaderPolicyProvider, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Users.Core/UserManagerExtensions.cs:4— The namespaces OrchardCore.Users ↔ OrchardCore.Users.Events ↔ OrchardCore.Users.Handlers ↔ OrchardCore.Users.Models ↔ OrchardCore.Users.Services ↔ OrchardCore.Users.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Users → OrchardCore.Users.Handlers (OrchardCore.Users.UserManagerExtensions → OrchardCore.Users.Handlers.UpdateUserContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Liquid/ResourceManagementOptionsConfiguration.cs:3— The namespaces OrchardCore.DisplayManagement.Liquid ↔ OrchardCore.Liquid depend on each other. The lightest dependency in the cycle is OrchardCore.Liquid → OrchardCore.DisplayManagement.Liquid (OrchardCore.Liquid.ResourceManagementOptionsConfiguration → OrchardCore.DisplayManagement.Liquid.LiquidViewParser, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:13— The namespaces OrchardCore.ContentManagement.GraphQL.Queries ↔ OrchardCore.ContentManagement.GraphQL.Queries.Predicates depend on each other. The lightest dependency in the cycle is OrchardCore.ContentManagement.GraphQL.Queries → OrchardCore.ContentManagement.GraphQL.Queries.Predicates (OrchardCore.ContentManagement.GraphQL.Queries.ContentItemsFieldType → OrchardCore.ContentManagement.GraphQL.Queries.Predicates.Junction, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.AuditTrail/ViewModels/AuditTrailEventViewModel.cs:2— The namespaces OrchardCore.AuditTrail.Services.Models ↔ OrchardCore.AuditTrail.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.AuditTrail.ViewModels → OrchardCore.AuditTrail.Services.Models (OrchardCore.AuditTrail.ViewModels.AuditTrailEventViewModel → OrchardCore.AuditTrail.Services.Models.AuditTrailEventDescriptor, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Sitemaps/Builders/SitemapIndexTypeBuilder.cs:7— The namespaces OrchardCore.Sitemaps.Builders ↔ OrchardCore.Sitemaps.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Sitemaps.Builders → OrchardCore.Sitemaps.Services (OrchardCore.Sitemaps.Builders.SitemapIndexTypeBuilder → OrchardCore.Sitemaps.Services.ISitemapManager, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.ContentLocalization/DefaultContentLocalizationManager.cs:3— The namespaces OrchardCore.ContentLocalization ↔ OrchardCore.ContentLocalization.Handlers ↔ OrchardCore.ContentLocalization.Models ↔ OrchardCore.ContentLocalization.Services depend on each other. The lightest dependency in the cycle is OrchardCore.ContentLocalization → OrchardCore.ContentLocalization.Handlers (OrchardCore.ContentLocalization.DefaultContentLocalizationManager → OrchardCore.ContentLocalization.Handlers.IContentLocalizationHandler, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Media/SecureMediaPermissions.cs:6— The namespaces OrchardCore.Media ↔ OrchardCore.Media.Services ↔ OrchardCore.Media.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Media → OrchardCore.Media.Services (OrchardCore.Media.SecureMediaPermissions → OrchardCore.Media.Services.AttachedMediaFieldFileService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Workflows.Abstractions/Models/ActivityContext.cs:1— The namespaces OrchardCore.Workflows.Activities ↔ OrchardCore.Workflows.Indexes ↔ OrchardCore.Workflows.Models ↔ OrchardCore.Workflows.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Workflows.Models → OrchardCore.Workflows.Activities (OrchardCore.Workflows.Models.ActivityContext → OrchardCore.Workflows.Activities.IActivity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Feeds.Abstractions/Models/FeedContext.cs:5— The namespaces OrchardCore.Feeds ↔ OrchardCore.Feeds.Models depend on each other. The lightest dependency in the cycle is OrchardCore.Feeds.Models → OrchardCore.Feeds (OrchardCore.Feeds.Models.FeedContext → OrchardCore.Feeds.IFeedBuilder, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/ConvertTimeZoneStep.cs:2— The namespaces OrchardCore.DataPipelines.Models ↔ OrchardCore.DataPipelines.Services ↔ OrchardCore.DataPipelines.Steps ↔ OrchardCore.DataPipelines.ViewModels.Designer depend on each other. The lightest dependency in the cycle is OrchardCore.DataPipelines.Steps → OrchardCore.DataPipelines.Services (OrchardCore.DataPipelines.Steps.ConvertTimeZoneStep → OrchardCore.DataPipelines.Services.IDataTimeZoneResolver, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Elasticsearch/ViewModels/AdminQueryViewModel.cs:7— The namespaces OrchardCore.Elasticsearch ↔ OrchardCore.Elasticsearch.Core.Services ↔ OrchardCore.Elasticsearch.ViewModels depend on each other. The lightest dependency in the cycle is OrchardCore.Elasticsearch.ViewModels → OrchardCore.Elasticsearch (OrchardCore.Elasticsearch.ViewModels.AdminQueryViewModel → OrchardCore.Elasticsearch.ElasticsearchRecord, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneQuerySource.cs:15— The namespaces OrchardCore.Lucene ↔ OrchardCore.Lucene.Core ↔ OrchardCore.Lucene.Services depend on each other. The lightest dependency in the cycle is OrchardCore.Lucene → OrchardCore.Lucene.Services (OrchardCore.Lucene.LuceneQuerySource → OrchardCore.Lucene.Services.LuceneAnalyzerManager, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/OrchardCore.Modules/OrchardCore.Media/Events/SecureMediaFileStoreEventHandler.cs:2— The namespaces OrchardCore.Media.Core.Events ↔ OrchardCore.Media.Events depend on each other. The lightest dependency in the cycle is OrchardCore.Media.Events → OrchardCore.Media.Core.Events (OrchardCore.Media.Events.SecureMediaFileStoreEventHandler → OrchardCore.Media.Core.Events.MediaEventHandlerBase, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:601— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.Forms/Drivers/FormInputElementVisibilityPartDisplayDriver.cs:146— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.Liquid/Filters/DataProtectionFilters.cs:53— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:203— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs:106— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore.Modules/OrchardCore.Workflows/Services/SecurityTokenService.cs:41— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs:154— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore.Abstractions/Modules/Module.cs:111— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore.Abstractions/Modules/Module.cs:114— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore.Data.YesSql/DbConnectionValidator.cs:159— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore.Lucene.Core/LuceneIndexStore.cs:100— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:441— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:769— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:41— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/OrchardCore/OrchardCore/Shell/Removing/ShellWebRootRemovingHandler.cs:45— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:230— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:245— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
AC4 · Keyboard semantics· Clickable element isn't keyboard-operable · ×15
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.AuditTrail/Views/AuditTrailTrimmingSettings.Edit.cshtml:25— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Monaco.Edit.cshtml:17— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlFieldMonacoEditorSettings.Edit.cshtml:13— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.ContentFields/Views/TextField-Monaco.Edit.cshtml:23— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.ContentFields/Views/TextFieldMonacoEditorSettings.Edit.cshtml:13— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable REDACTED:39— The repo's own CSS styles .btn with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Deployment/Views/DeploymentPlan/Display.cshtml:47— The repo's own CSS styles .cursor-pointer with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Deployment/Views/Items/JsonRecipeDeploymentStep.Fields.Edit.cshtml:7— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Elasticsearch/Views/Admin/IndexInfo.cshtml:10— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Html/Views/HtmlBodyPart-Monaco.Edit.cshtml:13— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Html/Views/HtmlBodyPartMonacoSettings.Edit.cshtml:13— The repo's own CSS styles .form-control with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:146— The repo's own CSS styles .thumb-container with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:26— The repo's own CSS styles .table-cell with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderComponent.vue:8— The repo's own CSS styles .expand with `cursor: pointer`, so this <span> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Clickable element isn't keyboard-operable src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderRow.vue:9— The repo's own CSS styles .expand with `cursor: pointer`, so this <span> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
AC2 · Forms & labels· <label> that labels no control · ×14
<label> that labels no control src/OrchardCore.Modules/OrchardCore.Admin/Views/AdminSettings.Edit.cshtml:69— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextField-CheckboxList.Edit.cshtml:19— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextField-Picker.Edit.cshtml:36— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.Contents/Views/ContentVersionPruningSettings_Edit.cshtml:32— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataLocalization/Views/Items/TranslationsDeploymentStep_Fields_Edit.cshtml:31— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/Aggregate.Fields.Edit.cshtml:20— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/CalculatedFields.Fields.Edit.cshtml:6— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/DataSource.Fields.Edit.cshtml:59— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/Items/DataPipelinesDeploymentStep.Fields.Edit.cshtml:24— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/Join.Fields.Edit.cshtml:19— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/SaveContentItems.Fields.Edit.cshtml:50— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/SelectFields.Fields.Edit.cshtml:6— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/SendToWebApi.Fields.Edit.cshtml:46— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
<label> that labels no control src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/Sort.Fields.Edit.cshtml:6— This <label> has no for and wraps no form control, so it names nothing: assistive tech never announces it, and clicking the caption focuses no field. Note that an id on the label is not an association — it is the TARGET of one, so a control still has to point at it. Give the label for="<the control's id>", move the control inside the label, or point the control's aria-labelledby at this label's id.
AC2 · Forms & labels· <input> without a programmatic label · ×10
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.Admin/Views/AdminListSearch.cshtml:32— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.ArchiveLater/Views/ArchiveLaterPart.Edit.cshtml:11— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.ContentFields/Views/DateField-Localized.Edit.cshtml:22— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.ContentFields/Views/NumericField-Range.Edit.cshtml:34— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.DataLocalization/Views/Admin/Index.cshtml:120— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.DataLocalization/Views/Admin/Index.cshtml:149— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.Demo/Pages/Foo/Admin/Edit.cshtml:18— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.Demo/Pages/Foo/List.cshtml:19— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.Demo/Views/Home/Index.cshtml:37— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/OrchardCore.Modules/OrchardCore.Forms/Views/Items/InputPart.cshtml:40— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC2 · Forms & labels· <button> with no accessible text · ×10
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.AdminDashboard/Views/DashboardWidget.DetailAdmin.cshtml:10— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml:66— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml:40— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.ContentFields/Views/NumericField-Spinner.Edit.cshtml:32— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.ContentFields/Views/NumericField-Spinner.Edit.cshtml:33— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.ContentFields/Views/TextField-IconPicker.Edit.cshtml:29— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.Flows/Views/ContentCard-BagPart.Edit.cshtml:37— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.Flows/Views/ContentCard-FlowPart.Edit.cshtml:79— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.Flows/Views/ContentCard-FlowPartBlocks.Edit.cshtml:87— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
<button> with no accessible text src/OrchardCore.Modules/OrchardCore.Flows/Views/FlowMetadata.Edit.cshtml:10— A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
WriteOnlyPrivateField REDACTED:17— private ITestDependency _testDependency — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField REDACTED:19— private ISession _session — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField REDACTED:22— private IContentItemDisplayManager _contentDisplay — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/OrchardCore.Modules/OrchardCore.Users/AuditTrail/AdminMenu.cs:13— private RouteValueDictionary s_routeValues — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:32— private IDataProtectionProvider _dataProtectionProvider — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:35— private IShellFeaturesManager _shellFeaturesManager — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/OrchardCore.Modules/OrchardCore.Users/Handlers/ScriptExternalLoginEventHandler.cs:18— private ILogger _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/OrchardCore.Modules/OrchardCore.Users/Handlers/UserModerationLoginFormEvent.cs:16— private UserManager<IUser> _userManager — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/Drivers/MyTestPartDisplayDriver.cs:15— private IContentDefinitionManager _contentDefinitionManager — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
AC1 · Text alternatives· <img> without a text alternative · ×7
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/GalleryCardItem.vue:29— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/GalleryListItem.vue:21— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:136— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:119— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldGallery.vue:70— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/ThumbsContainer.vue:50— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
<img> without a text alternative src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg/trumbowyg-plugins.js:2900— An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
D30 · Dependency Vulnerabilities· High vulnerability · ×4
REDACTED
REDACTED
REDACTED
REDACTED
AC2 · Forms & labels· <textarea> without a programmatic label · ×3
<textarea> without a programmatic label REDACTED:43— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<textarea> without a programmatic label src/OrchardCore.Modules/OrchardCore.Contents/Views/FullTextAspectSettings.Edit.cshtml:56— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<textarea> without a programmatic label src/OrchardCore.Modules/OrchardCore.Forms/Views/Items/TextAreaPart.cshtml:24— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC4 · Keyboard semantics· Click handler on a non-interactive <div> · ×3
Click handler on a non-interactive <div> src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:12— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:16— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
Click handler on a non-interactive <div> src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileItemsComponent.vue:20— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC2 · Forms & labels· <select> without a programmatic label · ×2
<select> without a programmatic label src/OrchardCore.Modules/OrchardCore.DataPipelines/Views/SaveContentItems.Fields.Edit.cshtml:36— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<select> without a programmatic label src/OrchardCore.Modules/OrchardCore.Forms/Views/Items/SelectPart.cshtml:40— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
Boundary-crossing change coupling: RecipesStep.cs ↔ RecipeExecutor.cs src/OrchardCore.Modules/OrchardCore.Recipes/RecipeSteps/RecipesStep.cs:1— `src/OrchardCore.Modules/OrchardCore.Recipes/RecipeSteps/RecipesStep.cs` (context OrchardCore.Modules) and `src/OrchardCore/OrchardCore.Recipes.Core/Services/RecipeExecutor.cs` (context OrchardCore) sit in DIFFERENT parts of the tree yet change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `ff88852c` Show recipe error instead if throwing an exeption (#16148); `7b99380d` Fixes inner recipes #1609 (#1642) (at that commit the file was still `src/OrchardCore/OrchardCore.Recipes.Implementations/Services/RecipeExecutor.cs`); `c5b6d199` Refactoring Orchard.Recipes (at that commit the files were still `src/Orchard.Cms.Web/Modules/Orchard.Recipes/RecipeSteps/RecipesStep.cs` and `src/Orchard.Recipes.Implementations/Services/RecipeExecutor.cs`) — run `git show` on any of them.
Boundary-crossing change coupling: ContentMethodsProvider.cs ↔ DefaultContentManager.cs src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:1— `src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs` (context OrchardCore.Modules) and `src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs` (context OrchardCore) sit in DIFFERENT parts of the tree yet change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `622a1cc3` Remove implicit CancelAsync from ValidateAsync, move to callers (#18939); `c1448cc7` Update event should only be called when updating content item (#17429); `29336302` Make Content Recipe Step Idempotent (#5487) — run `git show` on any of them.
AC3 · Page structure· <iframe> without a title · ×1
<iframe> without a title src/OrchardCore.Modules/OrchardCore.Templates/Views/Preview/Index.cshtml:8— An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label.
<html> without a lang src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Mvc.Web/Views/Shared/_Layout.cshtml:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
FileScopedPragmaDisable src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:1— #pragma warning disable CA1707 // Remove the underscores from member name — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
TodoComment src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:74— // Todo: This logic can be shared by all TreeNodeNavigationBuilders. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeNavigationBuilder.cs:50— // todo: this logic can be shared by all TreeNodeNavigationBuilders — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:78— // todo: handle the case where there is a deserialization exception on some of the presets. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/OrchardFieldNameConverter.cs:10— // todo: custom argument name? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/OrchardFieldNameConverter.cs:16— // TODO: check functionality. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:56— // AuthorizeNodePermissionAsync(fieldAst, fieldDef.ResolvedType.GetNamedType(), validationContext, userContext).GetAwaiter().GetResult(); // TODO: need to think of something to avoid this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.AuditTrail/Services/DefaultAuditTrailAdminListFilterProvider.cs:153— // TODO add a context property to the mapping func. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.AuditTrail/Services/DefaultAuditTrailAdminListFilterProvider.cs:161— // TODO add a context property to the mapping func. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.ContentPreview/Controllers/PreviewController.cs:87— // TODO: we should probably get this value from the main editor as it might impact validators. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.ContentTypes/Startup.cs:65— // TODO: Put in its own feature to be able to execute this recipe without having to enable — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Contents/Deployment/ContentDeploymentSource.cs:22— // TODO: Batch and create separate content files in the result. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Contents/Drivers/OwnerEditorDriver.cs:51— // TODO Move this editor to a user picker. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Email/Workflows/Activities/EmailTask.cs:52— // TODO: Add support for the following format: Jack Bauer<jack@ctu.com>, ... — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:187— // TODO, some how here contentItems should be sorted by a defined order — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Forms/Workflows/Activities/ValidateFormFieldTask.cs:10— // TODO: Add the ability to configure various types of validators. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Lists/Handlers/ContainedPartLocalizationHandler.cs:25— // todo: remove this check and change the handler to target ContainedPart when issue 3890 is fixed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Settings/Services/SetupEventHandler.cs:29— // TODO: Add Encryption Settings in. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Taxonomies/Indexing/TaxonomyFieldIndexHandler.cs:21— // TODO: Also add the parents of each term, probably as a separate field — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Taxonomies/Services/TaxonomyContentsAdminListFilter.cs:13— // TODO Create a Terms Index independent of the standard index, which can index taxonomy terms by their display text
TodoComment src/OrchardCore.Modules/OrchardCore.Themes/Services/ThemeService.cs:85— // TODO: MWP: probably follow on issue: should this be recursive? maybe with a depth limit? i.e. base3->base2->base1 ... — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment REDACTED:162— // TODO Candidate for dynamic localization. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Users/Deployment/CustomUserSettingsDeploymentSource.cs:29— // Todo: check permissions for each settings type — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Users/Liquid/UserEmailFilter.cs:29— // Todo: Use 'IdentityOptions.ClaimsIdentity.EmailClaimType' that will be supported in a future version. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Users/Migrations.cs:19— // TODO These should have defaults. on SQL Server they will fall at 255. Exceptions are currently thrown if you go over that. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/OrchardCore.Modules/OrchardCore.Users/Services/EmailClaimsProvider.cs:21— // Todo: In a future version the base implementation will generate the email claim if the user store is an 'IUserEmailStore', — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Sync-over-async blocking .agents/skills/orchardcore-video-producer/scripts/pronounce.py:27— `option` is async and calls subprocess.run — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs.
Sync-over-async blocking .agents/skills/orchardcore-video-producer/scripts/pronounce.py:49— `main` is async and calls subprocess.run — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs.
Sync-over-async blocking — 81 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:42— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:23— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:32— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:41— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:50— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:247— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:257— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:269— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:275— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:289— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:292— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:293— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/AzureBlobTusTempStore.cs:173— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/AzureBlobTusTempStore.cs:178— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Queries/QueryGlobalMethodProvider.cs:20— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapValuesAddressScheme.cs:36— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Cors/Services/CorsOptionsConfiguration.cs:20— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.DataProtection.Azure/BlobOptionsConfiguration.cs:76— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Email.Azure/Services/AzureEmailOptionsConfiguration.cs:44— `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Email.Smtp/Services/SmtpOptionsConfiguration.cs:71— `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:56— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:83— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
+ 15 more in this group — see findings.md.
R4 · Test Coverage· No test reaches this file · ×40
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Admin/Assets/js/quick-navigation.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.MiniProfiler/Assets/ts/miniprofiler.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Cors/Assets/ts/cors-admin-index.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Forms/Assets/ts/select-part-editor.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.OpenApi/Assets/openapi-ui-auth/src/openapi-ui-auth.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/upload/trumbowyg.upload.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/resizimg/trumbowyg.resizimg.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Setup/Assets/ts/setup.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.DataLocalization/Assets/ts/translation-editor.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-type-picker.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-canvas.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.AdminDashboard/Assets/ts/dashboard.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Markdown/Assets/Scripts/mde.mediatoolbar.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/giphy/trumbowyg.giphy.js:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/TheAdmin.ts:1— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
+ 15 more in this group — see findings.md.
X24 · Document value interpolated into markup unescaped· Untrusted text written into markup unescaped · ×40
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField.cshtml:9— `Model.Html` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Contents/Views/BodyAspect.cshtml:11— `bodyAspect.Body` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DataPipelines/SharedLinks/SharedLinkManager.cs:320— `_htmlEncoder.Encode(url)` is text this program did not author, and it is written into the start of a URL attribute, where it chooses the scheme through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML encoding does not help here — a `javascript:` URL contains nothing it changes; allow only http(s) or a relative path.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendByEmailStep.cs:137— `Render(settings.Body, run, now, WebUtility.HtmlEncode(fileNames))` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Demo/Shapes/DemoShapeProvider.cs:29— `sb.ToString()` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:57— `cachedContent` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:103— `cacheContext.CacheId` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:104— `$" VARY BY: {string.Join(", ", cacheContext.Contexts)}"` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:105— `$" DEPENDENCIES: {string.Join(", ", cacheContext.Tags)}"` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:111— `sw.ToString()` is text this program did not author, and it is written into the text of an element through `AppendHtml` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:114— `cacheContext.CacheId` is text this program did not author, and it is written into the text of an element through `AppendHtmlLine` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/EventHandlers/DynamicCacheShapeDisplayEvents.cs:126— `content` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:154— `content` is text this program did not author, and it is written into the text of an element through `SetHtmlContent` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:215— `html` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:224— `value` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Elasticsearch/Views/Admin/Query.cshtml:37— `Url.Action("Query", "Admin", new { area = "OrchardCore.Elasticsearch", query = Model.MatchAllQuery, id = Model.Id })` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped REDACTED:130— `message.HtmlBody` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Email/Workflows/Activities/EmailTask.cs:159— `htmlBody?.Trim()` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Email/Workflows/Activities/EmailTask.cs:166— `htmlBody?.Trim()` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Email/Workflows/Drivers/EmailTaskDisplayDriver.cs:19— `activity.HtmlBody.Expression` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Email/Workflows/Drivers/EmailTaskDisplayDriver.cs:33— `new WorkflowExpression<string>(model.HtmlBody)` is text this program did not author, and it is written into the text of an element through an HTML e-mail body with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Facebook/Views/FacebookPluginPart.Summary.cshtml:12— `Model.Html` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Facebook/Views/FacebookPluginPart.cshtml:12— `Model.Html` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Html/Handlers/HtmlBodyPartHandler.cs:52— `model.Html` is text this program did not author, and it is written into the text of an element through `new HtmlString(…)` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Untrusted text written into markup unescaped src/OrchardCore.Modules/OrchardCore.Html/Views/HtmlBodyPart.Summary.cshtml:3— `Model.Html.RemoveTags(true).Ellipsize(200)` is text this program did not author, and it is written into the text of an element through Razor's `Html.Raw` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
+ 15 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×39
Async method without CancellationToken: UpdateAsync src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:59— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpdateAsync src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs:57— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: List src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:56— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Create src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:133— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Create src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:146— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Edit src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:165— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Edit src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:190— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Delete src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:220— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: IndexPost src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:252— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Toggle src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/MenuController.cs:284— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: List src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:44— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BuildDisplayViewModel src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:62— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Create src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:82— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Create src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:116— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Edit src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:159— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Edit src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:198— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Delete src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:255— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Toggle src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:290— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: MoveNode src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:322— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ProcessAsync src/OrchardCore.Modules/OrchardCore.AdminMenu/Deployment/AdminMenuDeploymentSource.cs:23— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: MigrateAdminMenuNode src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:24— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: MigrateMenuItemNodes src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:98— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetPermissionsAsync src/OrchardCore.Modules/OrchardCore.AdminMenu/Permissions.cs:27— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: HandleAsync src/OrchardCore.Modules/OrchardCore.AdminMenu/Recipes/AdminMenuStep.cs:35— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: MigrateAdminMenuNode src/OrchardCore.Modules/OrchardCore.AdminMenu/Recipes/AdminMenuStep.cs:59— No CancellationToken parameter — this work can't be stopped early once started.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:42— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:23— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:32— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:41— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:50— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:247— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:256— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:269— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:275— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:289— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:292— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:293— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/AzureBlobTusTempStore.cs:173— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/AzureBlobTusTempStore.cs:178— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Queries/QueryGlobalMethodProvider.cs:20— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapValuesAddressScheme.cs:36— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Cors/Services/CorsOptionsConfiguration.cs:20— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.DataProtection.Azure/BlobOptionsConfiguration.cs:76— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Email.Azure/Services/AzureEmailOptionsConfiguration.cs:39— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Email.Smtp/Services/SmtpOptionsConfiguration.cs:66— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:56— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:83— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs:91— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.Facebook/Services/FacebookSettingsConfiguration.cs:18— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/OrchardCore.Modules/OrchardCore.GitHub/Configuration/GitHubAuthenticationOptionsConfiguration.cs:66— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
+ 12 more in this group — see findings.md.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×33
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.ContentFields/Controllers/ContentPickerAdminController.cs:54— This method contradicts itself about `partFieldDefinition`: line 48 writes `partFieldDefinition?.GetSettings`, which says `partFieldDefinition` can be null, but line 54 then dereferences it directly as `partFieldDefinition.Editor` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partFieldDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partFieldDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.ContentFields/Controllers/UserPickerAdminController.cs:56— This method contradicts itself about `partFieldDefinition`: line 50 writes `partFieldDefinition?.GetSettings`, which says `partFieldDefinition` can be null, but line 56 then dereferences it directly as `partFieldDefinition.Editor` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partFieldDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partFieldDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.ContentLocalization/Drivers/LocalizationPartDisplayDriver.cs:89— This method contradicts itself about `ci`: line 97 writes `ci?.ContentItemId`, which says `ci` can be null, but line 89 then dereferences it directly as `ci.ContentItemId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `ci` truly cannot be null here, the `?.` is misleading. Settle it one way — test `ci` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AddToDeploymentPlan/ContentItemDeploymentSource.cs:38— This method contradicts itself about `data`: line 37 assigns it with `as JsonArray`, which hands back null rather than throwing when the value is not a `JsonArray`, but line 38 then dereferences it directly as `data.Add` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `data` once before the first use and handle the null case, or cast with `(JsonArray)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Forms/Filters/ImportModelStateAttribute.cs:26— This method contradicts itself about `controller`: line 12 assigns it with `as Controller`, which hands back null rather than throwing when the value is not a `Controller`, but line 26 then dereferences it directly as `controller.TempData` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `controller` once before the first use and handle the null case, or cast with `(Controller)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Forms/Filters/ImportModelStatePageFilter.cs:27— This method contradicts itself about `pageModel`: line 12 assigns it with `as PageModel`, which hands back null rather than throwing when the value is not a `PageModel`, but line 27 then dereferences it directly as `pageModel.TempData` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `pageModel` once before the first use and handle the null case, or cast with `(PageModel)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:272— This method contradicts itself about `menuItems`: line 270 assigns it with `as JsonArray`, which hands back null rather than throwing when the value is not a `JsonArray`, but line 272 then dereferences it directly as `menuItems.Remove` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `menuItems` once before the first use and handle the null case, or cast with `(JsonArray)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:228— This method contradicts itself about `indexSource`: line 220 assigns it with `as SitemapIndexSource`, which hands back null rather than throwing when the value is not a `SitemapIndexSource`, but line 228 then dereferences it directly as `indexSource.ContainedSitemapIds` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `indexSource` once before the first use and handle the null case, or cast with `(SitemapIndexSource)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:277— This method contradicts itself about `indexSource`: line 261 assigns it with `as SitemapIndexSource`, which hands back null rather than throwing when the value is not a `SitemapIndexSource`, but line 277 then dereferences it directly as `indexSource.ContainedSitemapIds` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `indexSource` once before the first use and handle the null case, or cast with `(SitemapIndexSource)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.AdminDashboard/Controllers/DashboardController.cs:184— This method contradicts itself about `partViewModel`: line 171 writes `partViewModel?.Position`, which says `partViewModel` can be null, but line 184 then dereferences it directly as `partViewModel.Position` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `partViewModel` truly cannot be null here, the `?.` is misleading. Settle it one way — test `partViewModel` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:34— This method contradicts itself about `operationDefinition`: line 34 writes `operationDefinition?.Name`, which says `operationDefinition` can be null, but line 34 then dereferences it directly as `operationDefinition.Operation` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `operationDefinition` truly cannot be null here, the `?.` is misleading. Settle it one way — test `operationDefinition` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:95— This method contradicts itself about `fieldType`: line 75 writes `fieldType?.GetPermissions`, which says `fieldType` can be null, but line 95 then dereferences it directly as `fieldType.Name` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `fieldType` truly cannot be null here, the `?.` is misleading. Settle it one way — test `fieldType` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.AuditTrail/Drivers/AuditTrailSettingsDisplayDriver.cs:60— This method contradicts itself about `settings`: line 68 writes `settings?.IsEnabled`, which says `settings` can be null, but line 60 then dereferences it directly as `settings.Name` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `settings` truly cannot be null here, the `?.` is misleading. Settle it one way — test `settings` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:272— This method contradicts itself about `request`: line 270 writes `request?.DataSet`, which says `request` can be null, but line 272 then dereferences it directly as `request.DataSet` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `request` truly cannot be null here, the `?.` is misleading. Settle it one way — test `request` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:430— This method contradicts itself about `pipeline`: line 380 writes `pipeline?.`, which says `pipeline` can be null, but line 430 then dereferences it directly as `pipeline.GetEditableDefinition` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `pipeline` truly cannot be null here, the `?.` is misleading. Settle it one way — test `pipeline` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:711— This method contradicts itself about `request`: line 702 writes `request?.VersionId`, which says `request` can be null, but line 711 then dereferences it directly as `request.Revision` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `request` truly cannot be null here, the `?.` is misleading. Settle it one way — test `request` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Contents/SaveContentItemsStep.cs:260— This method contradicts itself about `index`: line 263 writes `index?.ContentItemId`, which says `index` can be null, but line 260 then dereferences it directly as `index.ContentType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `index` truly cannot be null here, the `?.` is misleading. Settle it one way — test `index` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:139— This method contradicts itself about `header`: line 120 writes `header?.Name`, which says `header` can be null, but line 139 then dereferences it directly as `header.Value` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `header` truly cannot be null here, the `?.` is misleading. Settle it one way — test `header` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:209— This method contradicts itself about `header`: line 202 writes `header?.Name`, which says `header` can be null, but line 209 then dereferences it directly as `header.Value` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `header` truly cannot be null here, the `?.` is misleading. Settle it one way — test `header` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Facebook/Widgets/Services/LiquidShapes.cs:28— This method contradicts itself about `model`: line 25 assigns it with `as FacebookPluginPartViewModel`, which hands back null rather than throwing when the value is not a `FacebookPluginPartViewModel`, but line 28 then dereferences it directly as `model.Html` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `model` once before the first use and handle the null case, or cast with `(FacebookPluginPartViewModel)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs:593— This method contradicts itself about `existingPolicy`: line 584 writes `existingPolicy?.IsEnabled`, which says `existingPolicy` can be null, but line 593 then dereferences it directly as `existingPolicy.Scope` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `existingPolicy` truly cannot be null here, the `?.` is misleading. Settle it one way — test `existingPolicy` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Secrets/ViewModels/SecretIndexViewModel.cs:95— This method contradicts itself about `id`: line 93 writes `id?.IndexOf`, which says `id` can be null, but line 95 then dereferences it directly as `id.Length` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `id` truly cannot be null here, the `?.` is misleading. Settle it one way — test `id` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:611— This method contradicts itself about `userInfo`: line 609 assigns it with `as User`, which hands back null rather than throwing when the value is not a `User`, but line 611 then dereferences it directly as `userInfo.Properties` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `userInfo` once before the first use and handle the null case, or cast with `(User)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:720— This method contradicts itself about `info`: line 713 writes `info?.`, which says `info` can be null, but line 720 then dereferences it directly as `info.LoginProvider` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `info` truly cannot be null here, the `?.` is misleading. Settle it one way — test `info` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/OrchardCore.Modules/OrchardCore.Users/RateLimitPartitionKeys.cs:46— This method contradicts itself about `options`: line 44 writes `options?.CookieManager`, which says `options` can be null, but line 46 then dereferences it directly as `options.TicketDataFormat` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `options` truly cannot be null here, the `?.` is misleading. Settle it one way — test `options` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Dead code: CookieOptionsConfiguration src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Configuration/CookieOptionsConfiguration.cs:9— NamedType CookieOptionsConfiguration — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Microsoft.Authentication, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: Deconstruct test/OrchardCore.Abstractions.Tests/Modules/Manifest/FeatureAttributeTests.Attribute.cs:253— Method Deconstruct — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Abstractions.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: Deconstruct test/OrchardCore.Abstractions.Tests/Modules/Manifest/FeatureAttributeTests.Attribute.cs:266— Method Deconstruct — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Abstractions.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ClickSaveContinueAsync test/OrchardCore.Tests.Functional/Helpers/ButtonHelper.cs:13— Method ClickSaveContinueAsync — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Functional, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ClickPublishContinueAsync test/OrchardCore.Tests.Functional/Helpers/ButtonHelper.cs:22— Method ClickPublishContinueAsync — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Functional, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: GetByCy test/OrchardCore.Tests.Functional/Helpers/SelectorHelper.cs:7— Method GetByCy — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Functional, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: FindByCy test/OrchardCore.Tests.Functional/Helpers/SelectorHelper.cs:14— Method FindByCy — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Functional, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: TestModuleInitializer test/OrchardCore.Tests.Functional/Helpers/TestModuleInitializer.cs:11— NamedType TestModuleInitializer — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Functional, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: WarnsWhenGen2Detected test/OrchardCore.Tests.Integration/MediaAzure/MediaGalleryCapabilitiesFilterTests.cs:90— Method WarnsWhenGen2Detected — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Integration, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DoesNotWarnWhenGen1Confirmed test/OrchardCore.Tests.Integration/MediaAzure/MediaGalleryCapabilitiesFilterTests.cs:102— Method DoesNotWarnWhenGen1Confirmed — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Integration, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DoesNotWarnForUnrelatedAction test/OrchardCore.Tests.Integration/MediaAzure/MediaGalleryCapabilitiesFilterTests.cs:114— Method DoesNotWarnForUnrelatedAction — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Integration, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DoesNotWarnForUnrelatedController test/OrchardCore.Tests.Integration/MediaAzure/MediaGalleryCapabilitiesFilterTests.cs:126— Method DoesNotWarnForUnrelatedController — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests.Integration, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: WithDatabaseProvider test/OrchardCore.Tests/Apis/Context/SiteContext.cs:209— Method WithDatabaseProvider — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: WithConnectionString test/OrchardCore.Tests/Apis/Context/SiteContext.cs:215— Method WithConnectionString — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ConcatParams test/OrchardCore.Tests/Commands/CommandHandlerTests.cs:252— Method ConcatParams — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ConcatAllParams test/OrchardCore.Tests/Commands/CommandHandlerTests.cs:262— Method ConcatAllParams — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: GetOnlyListPart test/OrchardCore.Tests/Data/ContentItemTests.cs:376— NamedType GetOnlyListPart — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: Positional test/OrchardCore.Tests/DisplayManagement/ArgsUtility.cs:31— Method Positional — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ISized test/OrchardCore.Tests/DisplayManagement/CompositeTests.cs:68— NamedType ISized — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: LoadExtensionsAsync test/OrchardCore.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs:242— Method LoadExtensionsAsync — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: LoadFeatureAsync test/OrchardCore.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs:248— Method LoadFeatureAsync — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ContentTypeDataLocalizationProviderTests test/OrchardCore.Tests/Modules/OrchardCore.DataLocalization/Services/ContentTypeDataLocalizationProviderTests.cs:6— NamedType ContentTypeDataLocalizationProviderTests — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SubResourceIntegrityTests test/OrchardCore.Tests/Modules/OrchardCore.Resources/SubResourceIntegrityTests.cs:7— NamedType SubResourceIntegrityTests — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: CreateGetMessageWithCookies test/OrchardCore.Tests/Modules/OrchardCore.Users/HttpRequestHelper.cs:30— Method CreateGetMessageWithCookies — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: StubResourceManifestProvider test/OrchardCore.Tests/ResourceManagement/ResourceManagerTests.cs:906— NamedType StubResourceManifestProvider — Roslyn's SymbolFinder walked every project the solution loads, including OrchardCore.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
AC6 · Visual & motion safety· Focus outline removed in CSS without a · ×25
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:2582— `.form-range:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:3024— `.btn-check:focus + .btn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:5488— `.modal` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:5540— `.modal-content` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:6096— `.carousel-control-prev:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheComingSoonTheme/wwwroot/css/styles.css:6279— `.offcanvas` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:2570— `.form-range:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:2991— `.btn-check:focus + .btn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5249— `.modal` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5300— `.modal-content` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5805— `.carousel-control-prev:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5988— `.offcanvas` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2080— `.form-control-plaintext:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2339— `.form-range:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:2828— `.btn-check:focus-visible + .btn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5267— `.modal` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5320— `.modal-content` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:5891— `.carousel-control-prev:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6079— `.offcanvas-sm` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6167— `.offcanvas-md` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6255— `.offcanvas-lg` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6343— `.offcanvas-xl` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6431— `.offcanvas-xxl` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:6518— `.offcanvas` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Focus outline removed in CSS without a :focus replacement src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/jsplumbtoolkit-defaults.css:148— `.jtk-surface-tile` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
Hotspot: src/OrchardCore.Modules/OrchardCore.Media/Startup.cs src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:488— src/OrchardCore.Modules/OrchardCore.Media/Startup.cs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in MediaTusStartup.Configure at line 488. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Media/Startup.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:146— src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 31 in PagerShapes.Pager_Links at line 146. 1 of those changes was a fix/bug commit, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:132— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 64 in UppyFileUpload.useFileUpload at line 132. 1 of those changes was a fix/bug commit, and the other 1 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: REDACTED REDACTED:67— REDACTED changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in AdminController.List at line 67. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:340— src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in TenantApiController.Setup at line 340. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Media/Services/ViewMediaFolderAuthorizationHandler.cs src/OrchardCore.Modules/OrchardCore.Media/Services/ViewMediaFolderAuthorizationHandler.cs:47— src/OrchardCore.Modules/OrchardCore.Media/Services/ViewMediaFolderAuthorizationHandler.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ViewMediaFolderAuthorizationHandler.HandleRequirementAsync at line 47. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Media/Services/ViewMediaFolderAuthorizationHandler.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Settings/Startup.cs src/OrchardCore.Modules/OrchardCore.Settings/Startup.cs:77— src/OrchardCore.Modules/OrchardCore.Settings/Startup.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in LiquidStartup.ConfigureServices at line 77. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Settings/Startup.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs:83— src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in AzureAISearchDefaultSettingsDisplayDriver.UpdateAsync at line 83. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs:41— src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in RemoteMediaCacheBackgroundTask.DoWorkAsync at line 41. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts:308— src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in menu.initializeMenu at line 308. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs:48— src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in DefaultHtmlDisplay.ExecuteAsync at line 48. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:34— src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in CreateEndpoint.HandleAsync at line 34. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml— src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml changed 2 times in last 90 days, max cyclomatic complexity 31. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Security/Views/PermissionsPolicySettings.Edit.cshtml`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSettingsDisplayDriver.cs:72— src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSettingsDisplayDriver.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in TwilioSettingsDisplayDriver.UpdateAsync at line 72. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs:71— src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in AzureSettingsDisplayDriver.UpdateAsync at line 71. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Settings/Drivers/DefaultSiteSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Settings/Drivers/DefaultSiteSettingsDisplayDriver.cs:64— src/OrchardCore.Modules/OrchardCore.Settings/Drivers/DefaultSiteSettingsDisplayDriver.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in DefaultSiteSettingsDisplayDriver.UpdateAsync at line 64. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Settings/Drivers/DefaultSiteSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: REDACTED REDACTED:96— REDACTED changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in AdminController.Index at line 96. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:22— src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in flows.edit.document.addEventListener("DOMContentLoaded") at line 22. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs:54— src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in FlatPositionComparer.Compare at line 54. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:43— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in ContentItemDisplayCoordinator.BuildDisplayAsync at line 43. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:92— src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in SmtpSettingsDisplayDriver.UpdateAsync at line 92. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:23— src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in MenuShapes.DiscoverAsync at line 23. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:70— src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in AzureEmailSettingsDisplayDriver.UpdateAsync at line 70. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSettingsDisplayDriver.cs:108— src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSettingsDisplayDriver.cs changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in OpenIdClientSettingsDisplayDriver.UpdateAsync at line 108. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSettingsDisplayDriver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:219— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:219-230 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:290-301 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:219` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:182— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:182-193 | src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs:148-159 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:196` calls `RenderStringAsync`, `Select`, `Create` and `src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs:161` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:164— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:164-175 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:161-172 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:347— src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:347-358 | src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:398-409 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:236— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:236-247 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:307-318 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:236` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:118— src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:118-129 | src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:200-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.DataPipelines.Ftp/Steps/UploadToFtpStep.cs:67— src/OrchardCore.Modules/OrchardCore.DataPipelines.Ftp/Steps/UploadToFtpStep.cs:67-78 | src/OrchardCore.Modules/OrchardCore.DataPipelines.Sftp/Steps/UploadToSftpStep.cs:68-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.DataPipelines.Ftp/Steps/UploadToFtpStep.cs:67` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Themes/Controllers/AdminController.cs:188— src/OrchardCore.Modules/OrchardCore.Themes/Controllers/AdminController.cs:188-199 | src/OrchardCore.Modules/OrchardCore.Themes/Controllers/AdminController.cs:211-222 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:212— src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:212-223 | src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs:431-442 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:212` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:224` calls `Any` and `src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs:443` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/CalculatedFieldsStep.cs:69— src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/CalculatedFieldsStep.cs:69-80 | src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/SelectFieldsStep.cs:57-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/CalculatedFieldsStep.cs:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/SelectFieldsStep.cs:70` calls `Select`, `ToArray` and `src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/CalculatedFieldsStep.cs:82` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidFieldHandler.cs:31— src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidFieldHandler.cs:31-42 | src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidPartHandler.cs:39-50 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidFieldHandler.cs:31` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `ValidateContentFieldContext` in one and `ValidateContentPartContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlParser.cs:212— src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlParser.cs:212-223 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlParser.cs:244-255 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlParser.cs:212` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `node` to `TableName` in one and `ColumnExpression` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:365— src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:365-376 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:507-518 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:365` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddAlternatesTag.cs:12— src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddAlternatesTag.cs:12-23 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddClassesTag.cs:12-23 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddAlternatesTag.cs:12` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:91— src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:91-102 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:169-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `LayerRuleCreateViewModel` in one and `LayerRuleEditViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:349— src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:349-360 | src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:374-385 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:432— src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:432-443 | src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:490-501 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:432` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:139— src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:139-150 | src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:162-173 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:139` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Seo/Models/SeoAspect.cs:9— src/OrchardCore.Modules/OrchardCore.Seo/Models/SeoAspect.cs:9-20 | src/OrchardCore.Modules/OrchardCore.Seo/Models/SeoMetaPart.cs:14-26 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (12 lines × 2) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:298— src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:298-310 | src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:348-359 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Events/ThemeFeaturesProvider.cs:106— src/OrchardCore/OrchardCore.DisplayManagement/Events/ThemeFeaturesProvider.cs:106-117 | src/OrchardCore/OrchardCore/Extensions/Features/FeatureInfo.cs:69-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) REDACTED:104— REDACTED:104-115 | REDACTED:90-101 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:155— src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:155-166 | src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs:122-133 — before extracting anything, compare `src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs` and `src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:263— src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:263-272 | src/OrchardCore/OrchardCore.Autoroute.Core/Indexes/AutoroutePartIndex.cs:164-173 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:263` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Liquid/Services/LiquidTemplateManager.cs:38— src/OrchardCore.Modules/OrchardCore.Liquid/Services/LiquidTemplateManager.cs:38-47 | src/OrchardCore.Modules/OrchardCore.Liquid/Services/LiquidTemplateManager.cs:84-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:150— src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:150-159 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:248-257 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:150` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ScopeController.cs:160— src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ScopeController.cs:160-169 | src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ScopeController.cs:257-266 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ScopeController.cs:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `CreateOpenIdScopeViewModel` in one and `EditOpenIdScopeViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) REDACTED:381— REDACTED:381-390 | REDACTED:537-546 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:381` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:901— src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:901-910 | src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:916-925 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:928` calls `ToDisplayString` and `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:913` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Autoroute/Services/ContentAutorouteShapeTableProvider.cs:13— src/OrchardCore.Modules/OrchardCore.Autoroute/Services/ContentAutorouteShapeTableProvider.cs:13-22 | src/OrchardCore.Modules/OrchardCore.Autoroute/Services/WidgetAutorouteShapeTableProvider.cs:13-22 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Autoroute/Services/ContentAutorouteShapeTableProvider.cs:13` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Controllers/RemoteClientController.cs:79— src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Controllers/RemoteClientController.cs:79-88 | src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Controllers/RemoteInstanceController.cs:72-81 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:19— src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:19-28 | src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentTypePartIndexSettingsDisplayDriver.cs:26-35 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:61— src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:61-70 | src/OrchardCore.Modules/OrchardCore.Themes/Services/ThemeService.cs:116-125 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:88— src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:88-97 | src/OrchardCore.Modules/OrchardCore.Themes/Services/ThemeService.cs:143-152 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:27— src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:27-36 | src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:43-52 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:27` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleUpdater.cs:59— src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleUpdater.cs:59-68 | src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleUpdater.cs:103-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore/Localization/NullHtmlLocalizer.cs:34— src/OrchardCore/OrchardCore/Localization/NullHtmlLocalizer.cs:34-43 | src/OrchardCore/OrchardCore/Localization/NullStringLocalizer.cs:25-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:116— src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:116-126 | src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:157-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:58— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:58-70 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:42-51 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:58` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:958— src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:958-967 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1193-1202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchQuerySource.cs:97— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchQuerySource.cs:97-106 | src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneQuerySource.cs:109-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchQuerySource.cs:97` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore.Logging.NLog/HostBuilderExtensions.cs:23— src/OrchardCore/OrchardCore.Logging.NLog/HostBuilderExtensions.cs:23-33 | src/OrchardCore/OrchardCore.Logging.NLog/WebHostBuilderExtensions.cs:25-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Logging.NLog/HostBuilderExtensions.cs:23` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:100— src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:100-109 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapValuesAddressScheme.cs:90-99 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:314— src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:314-323 | src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs:368-378 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:30— src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:30-39 | src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeViewModel.cs:56-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:188— src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:188-200 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:246-258 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRedirectRuleDisplayDriver.cs:75— src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRedirectRuleDisplayDriver.cs:75-87 | src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRewriteRuleDisplayDriver.cs:66-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRedirectRuleDisplayDriver.cs:75` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:348— src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:348-360 | src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:452-464 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:295— src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:295-307 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:296-308 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:313— src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:313-325 | src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:385-397 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:313` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:22— src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:22-34 | src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexResetStep.cs:22-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:22` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:32— src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:32-44 | src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/ContentTypePartIndexSettingsDisplayDriver.cs:39-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdatePartFieldEditorContext` in one and `UpdateTypePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.CustomSettings/Drivers/CustomSettingsDisplayDriver.cs:30— src/OrchardCore.Modules/OrchardCore.CustomSettings/Drivers/CustomSettingsDisplayDriver.cs:30-42 | src/OrchardCore.Modules/OrchardCore.CustomSettings/Drivers/CustomSettingsDisplayDriver.cs:54-66 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `BuildEditorContext` in one and `UpdateEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:40— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Drivers/ContentPartFieldIndexSettingsDisplayDriver.cs:40-52 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Drivers/ContentTypePartIndexSettingsDisplayDriver.cs:40-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdatePartFieldEditorContext` in one and `UpdateTypePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Settings/ContentPartFieldIndexSettingsDisplayDriver.cs:40— src/OrchardCore.Modules/OrchardCore.Lucene/Settings/ContentPartFieldIndexSettingsDisplayDriver.cs:40-52 | src/OrchardCore.Modules/OrchardCore.Lucene/Settings/ContentTypePartIndexSettingsDisplayDriver.cs:40-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdatePartFieldEditorContext` in one and `UpdateTypePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:127— src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:127-139 | src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:143-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) REDACTED:420— REDACTED:420-432 | REDACTED:520-532 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:420` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AddToDeploymentPlan/AddToDeploymentPlanController.cs:47— src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AddToDeploymentPlan/AddToDeploymentPlanController.cs:47-59 | src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AddToDeploymentPlan/AddToDeploymentPlanController.cs:103-115 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.DataPipelines/Models/DataPipelineRun.cs:168— src/OrchardCore.Modules/OrchardCore.DataPipelines/Models/DataPipelineRun.cs:168-198 | src/OrchardCore.Modules/OrchardCore.DataPipelines/ViewModels/Designer/DataPipelineDesignerModels.cs:180-192 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:18— src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:18-30 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs:20-32 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) REDACTED:125— REDACTED:125-137 | REDACTED:187-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `LoginWithTwoFactorAuthenticationViewModel` in one and `LoginWithRecoveryCodeViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:157— src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:157-170 | src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:192-204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:157` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `indexDocuments` to `IEnumerable<DocumentIndex>` in one and `IEnumerable<ContentItemDocumentIndex>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Predicates/PredicateQuery.cs:69— src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Predicates/PredicateQuery.cs:69-81 | src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Predicates/PredicateQuery.cs:124-141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Predicates/PredicateQuery.cs:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/Services/AdminMenuJSLocalizer.cs:12— src/OrchardCore.Modules/OrchardCore.AdminMenu/Services/AdminMenuJSLocalizer.cs:12-24 | src/OrchardCore.Modules/OrchardCore.Menu/Services/MenuJSLocalizer.cs:12-24 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AdminMenu/Services/AdminMenuJSLocalizer.cs` and `src/OrchardCore.Modules/OrchardCore.Menu/Services/MenuJSLocalizer.cs` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Events/ThemeFeaturesProvider.cs:92— src/OrchardCore/OrchardCore.DisplayManagement/Events/ThemeFeaturesProvider.cs:92-104 | src/OrchardCore/OrchardCore/Extensions/Features/FeatureInfo.cs:55-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
AC3 · Page structure· Page without a main landmark · ×19
Page without a main landmark src/OrchardCore.Modules/OrchardCore.ContentPreview/Views/Preview/_Layout.cshtml:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/index.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/standalone/callback.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Modules/OrchardCore.Setup/Views/_Layout.cshtml:5— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Modules/OrchardCore.Templates/Views/Preview/_Layout.cshtml:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark REDACTED:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/SafeMode/Views/Layout.cshtml:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheAdmin/Views/Layout-Login.cshtml— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheAdmin/Views/Layout-TwoFactor.cshtml— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheAdmin/Views/Layout.cshtml— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/src/pug/index.pug:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheAgencyTheme/Views/Layout.liquid:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/src/pug/index.pug:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/src/pug/post.pug:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheBlogTheme/Views/Layout.liquid:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/src/pug/index.pug:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/OrchardCore.Themes/TheComingSoonTheme/Views/layout.liquid:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Mvc.Web/Views/Shared/_Layout.cshtml:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Theme/Views/Layout.liquid:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D30 · Dependency Vulnerabilities· Medium CVE · ×19
TooManyMethods: JsonDynamicValue src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs— TooManyMethods — 351 significant lines (blank, comment-only and punctuation-only lines excluded), 112 methods. The bar is 30 methods; this is 82 over it, 3.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UserStore src/OrchardCore/OrchardCore.Users.Core/Services/UserStore.cs— TooManyMethods — 408 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentPartHandler src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/ContentPartHandler.cs— TooManyMethods — 142 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: ContentFieldHandler src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/ContentFieldHandler.cs— TooManyMethods — 134 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: OpenIdApplicationStore src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs— TooManyMethods — 208 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: OpenIdTokenStore src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs— TooManyMethods — 288 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DisplayDriverBase src/OrchardCore/OrchardCore.DisplayManagement/Handlers/DisplayDriverBase.cs— TooManyMethods — 231 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ResourceManager src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs— TooManyMethods — 333 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ShapeFactoryGenerator src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs— TooManyMethods — 660 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: AdminController src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs— TooManyMethods — 475 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ExcelDataFileFormat src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs— TooManyMethods — 493 significant lines (blank, comment-only and punctuation-only lines excluded), 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AdminController src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs— TooManyMethods — 589 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ShellScope src/OrchardCore/OrchardCore.Abstractions/Shell/Scope/ShellScope.cs— TooManyMethods — 210 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: OpenIdAuthorizationStore src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs— TooManyMethods — 252 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ExpressionFunctions src/OrchardCore/OrchardCore.DataSources.Core/Expressions/ExpressionFunctions.cs— TooManyMethods — 279 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods, declared across 2 files: Expressions/ExpressionFunctions.cs (24), Expressions/ExpressionFunctions.Dates.cs (8). The bar is 30 methods; this is 2 over it, 1.07× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: ContentPartHandlerCoordinator src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs— TooManyMethods — 287 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentDefinitionManager src/OrchardCore/OrchardCore.ContentManagement/ContentDefinitionManager.cs— TooManyMethods — 237 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: OpenIdScopeStore src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdScopeStore.cs— TooManyMethods — 141 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
MethodTooLong: ResourceManagementOptionsConfiguration.BuildManifest src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs:35— MethodTooLong — BuildManifest runs 898 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 798 over it, 8.98× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Migrations.CreateAsync src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:17— MethodTooLong — CreateAsync runs 303 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 203 over it, 3.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Migrations.UpdateFrom3Async src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:469— MethodTooLong — UpdateFrom3Async runs 207 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 107 over it, 2.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: WorkflowEditor.constructor src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:22— MethodTooLong — constructor runs 178 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 78 over it, 1.78× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ShapeFactoryGenerator.GenerateInterceptor src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:872— MethodTooLong — GenerateInterceptor runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MediaTusStartup.Configure src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:488— MethodTooLong — Configure runs 135 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 35 over it, 1.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DependencyOrdering.Order src/OrchardCore/OrchardCore/Extensions/DependencyOrdering.cs:7— MethodTooLong — Order runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AdminController.List REDACTED:67— MethodTooLong — List runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PagerShapes.Pager_Links src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:146— MethodTooLong — Pager_Links runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SeoContentDriver.DisplayAsync src/OrchardCore.Modules/OrchardCore.Seo/Drivers/SeoContentDriver.cs:44— MethodTooLong — DisplayAsync runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AnchorTag.WriteToAsync src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AnchorTag.cs:22— MethodTooLong — WriteToAsync runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DistributedShellHostedService.ExecuteAsync src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:68— MethodTooLong — ExecuteAsync runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Startup.ConfigureServices src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:67— MethodTooLong — ConfigureServices runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: OpenIdMigrations.CreateAsync src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:23— MethodTooLong — CreateAsync runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SearchController.Search src/OrchardCore.Modules/OrchardCore.Search/Controllers/SearchController.cs:63— MethodTooLong — Search runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Migrations.CreateAsync src/OrchardCore.Modules/OrchardCore.Forms/Migrations.cs:17— MethodTooLong — CreateAsync runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AzureAISearchIndexSettingsMigrations.UpdateFrom1 src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:47— MethodTooLong — UpdateFrom1 runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.Forms/Drivers/FormInputElementVisibilityPartDisplayDriver.cs:146— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.Liquid/Filters/DataProtectionFilters.cs:53— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:203— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs:106— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs:601— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore.Modules/OrchardCore.Workflows/Services/SecurityTokenService.cs:41— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs:154— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore.Abstractions/Modules/Module.cs:111— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore.Abstractions/Modules/Module.cs:114— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore.Data.YesSql/DbConnectionValidator.cs:159— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore.Lucene.Core/LuceneIndexStore.cs:100— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:441— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:769— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:41— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/OrchardCore/OrchardCore/Shell/Removing/ShellWebRootRemovingHandler.cs:45— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:230— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:245— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75— src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75-89 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:115-129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:317— src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:317-331 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:318-332 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:315— src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:315-329 | src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:364-378 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:82— src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:82-96 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:104-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:348— src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:348-362 | src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:424-438 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:348` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:262— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:262-276 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:355-369 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:262` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `BuildEditorContext` in one and `UpdateEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresAfterTag.cs:15— src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresAfterTag.cs:15-29 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresSlidingTag.cs:15-29 — before extracting anything, compare `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresAfterTag.cs` and `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresSlidingTag.cs` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresAfterTag.cs:15` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Services/DiskTusTempStore.cs:55— src/OrchardCore.Modules/OrchardCore.Media/Services/DiskTusTempStore.cs:55-69 | src/OrchardCore.Modules/OrchardCore.Media/Services/DiskTusTempStore.cs:105-119 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Services/DiskTusTempStore.cs:55` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Extensions/DataLoaderExtensions.cs:38— src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Extensions/DataLoaderExtensions.cs:38-52 | src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:234-248 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:161— src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:161-175 | src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:277-291 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:161` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:208— src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:208-222 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:240-254 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.Placements/Services/PlacementProvider.cs:68— src/OrchardCore.Modules/OrchardCore.Placements/Services/PlacementProvider.cs:68-82 | src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapePlacementStrategy/ShapePlacementParsingStrategy.cs:73-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Placements/Services/PlacementProvider.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ServerConfigurationController.cs:80— src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ServerConfigurationController.cs:80-94 | src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ValidationConfigurationController.cs:80-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs:133— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs:133-147 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs:175-190 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.FileStorage.FileSystem/FileSystemStore.cs:27— src/OrchardCore/OrchardCore.FileStorage.FileSystem/FileSystemStore.cs:27-41 | src/OrchardCore/OrchardCore.FileStorage.FileSystem/FileSystemStore.cs:51-65 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.FileStorage.FileSystem/FileSystemStore.cs:27` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/PrefixFilterProvider.cs:38— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/PrefixFilterProvider.cs:38-52 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/PrefixQueryProvider.cs:32-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/PrefixFilterProvider.cs:38` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Stateful singleton: RazorCompilationFileProviderAccessor src/OrchardCore/OrchardCore.Mvc.Core/RazorCompilationFileProviderAccessor.cs:9— `RazorCompilationFileProviderAccessor` is a singleton (one shared instance) but mutates instance state outside any lock (_compositeFileProvider; e.g. `_compositeFileProvider` at line 25).
Stateful singleton: TestBackgroundTask src/OrchardCore.Modules/OrchardCore.Demo/Services/TestBackgroundTask.cs:5— `TestBackgroundTask` is a singleton (one shared instance) but mutates instance state outside any lock (_count; e.g. `_count` at line 13).
Stateful singleton: HomeRouteValuesAddressScheme src/OrchardCore.Modules/OrchardCore.HomeRoute/Routing/HomeRouteValuesAddressScheme.cs:9— `HomeRouteValuesAddressScheme` is a singleton (one shared instance) but mutates instance state outside any lock (_cachedEndpoint, _cachedEndpointKey; e.g. `_cachedEndpoint` at line 54).
Stateful singleton: LuceneIndexingState src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexingState.cs:12— `LuceneIndexingState` is a singleton (one shared instance) but mutates instance state outside any lock (_stateDocument; e.g. `_stateDocument` at line 55).
Stateful singleton: SitemapEntries src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapEntries.cs:5— `SitemapEntries` is a singleton (one shared instance) but mutates instance state outside any lock (_document; e.g. `_document` at line 67).
Stateful singleton: RedisService src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisService.cs:7— `RedisService` is a singleton (one shared instance) but mutates instance state outside any lock (Database; e.g. `Database` at line 26).
Stateful singleton: AzureAIClientFactory src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAIClientFactory.cs:10— `AzureAIClientFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_searchIndexClient; e.g. `_searchIndexClient` at line 82).
Stateful singleton: DocumentOptionsSetup src/OrchardCore/OrchardCore.Infrastructure/Documents/Options/DocumentOptionsSetup.cs:9— `DocumentOptionsSetup` is a singleton (one shared instance) but mutates instance state outside any lock (_defaultDocumentSerializer; e.g. `_defaultDocumentSerializer` at line 57).
Stateful singleton: DefaultTimeZoneSelectListProvider src/OrchardCore/OrchardCore/Modules/Services/DefaultTimeZoneSelectListProvider.cs:3— `DefaultTimeZoneSelectListProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_items; e.g. `_items` at line 17).
Stateful singleton: TenantHttpClientFactory src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:17— `TenantHttpClientFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_services, _scopeFactory, _optionsMonitor, _filters, _entryFactory; e.g. `_services` at line 362).
Stateful singleton: ShellSettings src/OrchardCore/OrchardCore.Abstractions/Shell/ShellSettings.cs:14— `ShellSettings` is a singleton (one shared instance) but mutates instance state outside any lock (_versionId, _tenantId, _requestUrlHost, _requestUrlHosts, _requestUrlPrefix, _requestPathBase; e.g. `_versionId` at line 89).
Stateful singleton: RunningShellTable src/OrchardCore/OrchardCore/Shell/RunningShellTable.cs:7— `RunningShellTable` is a singleton (one shared instance) but mutates instance state outside any lock (_default, _hasStarMapping; e.g. `_default` at line 18).
Stateful singleton: DistributedShellHostedService src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:15— `DistributedShellHostedService` is a singleton (one shared instance) but mutates instance state outside any lock (_shellChangedId, _shellCountChangedId, _terminated, _context, _defaultContextUtcTicks, _busyStartTime; e.g. `_shellChangedId` at line 301).
Stateful singleton: SetFeaturesShellDescriptorManager src/OrchardCore/OrchardCore/Shell/Descriptor/Settings/SetFeaturesShellDescriptorManager.cs:10— `SetFeaturesShellDescriptorManager` is a singleton (one shared instance) but mutates instance state outside any lock (_shellDescriptor; e.g. `_shellDescriptor` at line 34).
DeadPreprocessorBranch src/OrchardCore/OrchardCore.DisplayManagement/ObjectPool.cs:50— #if DETECT_LEAKS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/OrchardCore/OrchardCore.DisplayManagement/ObjectPool.cs:128— #if DETECT_LEAKS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/OrchardCore/OrchardCore.DisplayManagement/ObjectPool.cs:57— #if TRACE_LEAKS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/OrchardCore/OrchardCore.DisplayManagement/ObjectPool.cs:69— #if TRACE_LEAKS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/OrchardCore/OrchardCore.DisplayManagement/ObjectPool.cs:132— #if TRACE_LEAKS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/Manifest.cs:9— #if (AddPart) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/Startup.cs:1— #if (AddPart) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/Startup.cs:7— #if (AddPart) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/Startup.cs:27— #if (AddPart) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Web/Program.cs:1— #if (UseNLog) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Web/Program.cs:11— #if (UseNLog) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Web/Program.cs:4— #if (UseSerilog) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Web/Program.cs:14— #if (UseSerilog) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Web/Program.cs:43— #if (UseSerilog) — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×14
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:66— src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:66-103 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:83-130 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:133-168 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:171-241 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:250— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:250-266 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:269-285 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:321-337 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:340-361 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:48— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:48-261 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:39-227 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:32-202 | src/OrchardCore/OrchardCore.Indexing.Core/Handlers/ContentIndexProfileHandler.cs:107-151 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:107— src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:107-165 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:385-461 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:533-582 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:699-788 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:27— src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:27-66 | src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs:27-63 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexRebuildStep.cs:28-67 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexResetStep.cs:28-63 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:41— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:41-82 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetFoldersEndpoint.cs:37-106 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs:43-81 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/UploadMediaEndpoint.cs:53-186 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:28— src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:28-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/CultureConditionDisplayDriver.cs:28-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/RoleConditionDisplayDriver.cs:28-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/UrlConditionDisplayDriver.cs:28-38 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:41— src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:41-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/CultureConditionDisplayDriver.cs:41-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/RoleConditionDisplayDriver.cs:41-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/UrlConditionDisplayDriver.cs:41-52 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs:116— src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs:116-138 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs:233-255 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdValidationConfiguration.cs:251-273 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdValidationConfiguration.cs:276-298 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:17— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:17-189 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:15-217 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:18-170 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:15-210 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:459— REDACTED:459-512 | REDACTED:615-646 | REDACTED:650-675 | REDACTED:679-704 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:15— src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:15-38 | src/OrchardCore/OrchardCore.Contents.Core/Services/ContentItemFilterEngineModelBinder.cs:15-38 | src/OrchardCore/OrchardCore.Notifications.Core/Services/NotificationFilterEngineModelBinder.cs:15-36 | src/OrchardCore/OrchardCore.Users.Core/Services/UserFilterEngineModelBinder.cs:15-38 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:259— src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:259-305 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:333-397 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:407-461 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:468-541 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:382— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:382-441 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:445-474 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:478-507 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:510-539 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:157— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:157-170 | src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs:123-136 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexStep.cs:32— src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexStep.cs:32-45 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexStep.cs:34-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexStep.cs:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:54— src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:54-67 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:85-98 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:243— src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:243-256 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:273-286 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:144— src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:144-157 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:182-195 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:144` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:196` calls `GetDirectoryName`, `GetFileNameWithoutExtension` and `src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:158` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentLocalization/Handlers/ContentLocalizationPartHandlerCoordinator.cs:31— src/OrchardCore.Modules/OrchardCore.ContentLocalization/Handlers/ContentLocalizationPartHandlerCoordinator.cs:31-44 | src/OrchardCore.Modules/OrchardCore.ContentLocalization/Handlers/ContentLocalizationPartHandlerCoordinator.cs:52-65 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentLocalization/Handlers/ContentLocalizationPartHandlerCoordinator.cs:31` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Services/DistributedMediaTusStore.cs:274— src/OrchardCore.Modules/OrchardCore.Media/Services/DistributedMediaTusStore.cs:274-287 | src/OrchardCore.Modules/OrchardCore.Media/Services/DistributedMediaTusStore.cs:298-311 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Services/DistributedMediaTusStore.cs:274` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/Drivers/HtmlMenuItemPartDisplayDriver.cs:72— src/OrchardCore.Modules/OrchardCore.Menu/Drivers/HtmlMenuItemPartDisplayDriver.cs:72-85 | src/OrchardCore.Modules/OrchardCore.Menu/Drivers/LinkMenuItemPartDisplayDriver.cs:76-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Menu/Drivers/HtmlMenuItemPartDisplayDriver.cs:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `part` to `HtmlMenuItemPart` in one and `LinkMenuItemPart` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.GitHub/Drivers/GithubAuthenticationSettingsDisplayDriver.cs:75— src/OrchardCore.Modules/OrchardCore.GitHub/Drivers/GithubAuthenticationSettingsDisplayDriver.cs:75-88 | src/OrchardCore.Modules/OrchardCore.Google/Authentication/Drivers/GoogleAuthenticationSettingsDisplayDriver.cs:75-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.GitHub/Drivers/GithubAuthenticationSettingsDisplayDriver.cs:75` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `settings` to `GitHubAuthenticationSettings` in one and `GoogleAuthenticationSettings` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) REDACTED:616— REDACTED:616-629 | REDACTED:651-664 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetAllMediaItemsEndpoint.cs:44— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetAllMediaItemsEndpoint.cs:44-57 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryTreeEndpoint.cs:38-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (14 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:83— src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:83-96 | src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:160-174 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:526— src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:526-539 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:583-596 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) src/OrchardCore/OrchardCore.Shortcodes.Abstractions/ShortcodeDescriptor.cs:18— src/OrchardCore/OrchardCore.Shortcodes.Abstractions/ShortcodeDescriptor.cs:18-31 | src/OrchardCore/OrchardCore.Shortcodes.Abstractions/ShortcodeOption.cs:18-31 — before extracting anything, compare `src/OrchardCore/OrchardCore.Shortcodes.Abstractions/ShortcodeDescriptor.cs` and `src/OrchardCore/OrchardCore.Shortcodes.Abstractions/ShortcodeOption.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Html/Handlers/HtmlBodyPartHandler.cs:54— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Liquid/Handlers/LiquidPartHandler.cs:73— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Markdown/Handlers/MarkdownBodyPartHandler.cs:47— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/S3TusTempStore.cs:102— `catch (BadHttpRequestException) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Seo/Drivers/SeoContentDriver.cs:288— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Facebook/Widgets/Handlers/FacebookPluginPartHandler.cs:41— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:274— `catch (CryptographicException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore.Modules/OrchardCore.Secrets/Drivers/X509SecretDisplayDriver.cs:114— `catch (CryptographicException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemExtensions.cs:34— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemExtensions.cs:56— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineEdge.cs:175— `catch (Exception) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataAccumulator.cs:156— `catch (OverflowException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEnginePool.cs:177— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEnginePool.cs:241— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownBodyPartWysiwygEditorSettingsDriver.cs:36— src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownBodyPartWysiwygEditorSettingsDriver.cs:36-54 | src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownFieldWysiwygEditorSettingsDriver.cs:36-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownBodyPartWysiwygEditorSettingsDriver.cs:36` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdateTypePartEditorContext` in one and `UpdatePartFieldEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:39— src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:39-57 | src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs:37-55 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs` and `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:39` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `treeNode` to `LinkAdminNode` in one and `PlaceholderAdminNode` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:265— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:265-283 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:240-258 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:511— src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:511-529 | src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:611-629 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:511` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:81— src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:81-99 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:75-93 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:95` calls `PagerAsync` and `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:101` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:67— src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:67-85 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:134-152 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:257— src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:257-275 | src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs:292-310 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ContentDefinitionDeploymentSource.cs:19— src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ContentDefinitionDeploymentSource.cs:19-37 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ReplaceContentDefinitionDeploymentSource.cs:19-37 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `step` to `ContentDefinitionDeploymentStep` in one and `ReplaceContentDefinitionDeploymentStep` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.CustomSettings/Services/CustomSettingsService.cs:96— src/OrchardCore.Modules/OrchardCore.CustomSettings/Services/CustomSettingsService.cs:96-114 | src/OrchardCore.Modules/OrchardCore.Users/Drivers/CustomUserSettingsDisplayDriver.cs:125-143 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Templates/Deployment/AllAdminTemplatesDeploymentSource.cs:29— src/OrchardCore.Modules/OrchardCore.Templates/Deployment/AllAdminTemplatesDeploymentSource.cs:29-47 | src/OrchardCore.Modules/OrchardCore.Templates/Deployment/AllTemplatesDeploymentSource.cs:29-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Templates/Deployment/AllAdminTemplatesDeploymentSource.cs:29` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Cors/Settings/CorsPolicySetting.cs:5— src/OrchardCore.Modules/OrchardCore.Cors/Settings/CorsPolicySetting.cs:5-23 | src/OrchardCore.Modules/OrchardCore.Cors/ViewModels/CorsPolicyViewModel.cs:5-23 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Cors/Settings/CorsPolicySetting.cs` and `src/OrchardCore.Modules/OrchardCore.Cors/ViewModels/CorsPolicyViewModel.cs` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (19 lines × 2) src/OrchardCore.Modules/OrchardCore.Flows/Indexing/BagPartIndexHandler.cs:31— src/OrchardCore.Modules/OrchardCore.Flows/Indexing/BagPartIndexHandler.cs:31-49 | src/OrchardCore.Modules/OrchardCore.Flows/Indexing/FlowPartIndexHandler.cs:31-49 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Flows/Indexing/BagPartIndexHandler.cs:31` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs:80— src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs:80-98 | src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs:97-115 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs:80` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:43— src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:43-59 | src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:60-76 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Extensions/ElasticsearchOptionsExtensions.cs:13— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Extensions/ElasticsearchOptionsExtensions.cs:13-29 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Extensions/ElasticsearchOptionsExtensions.cs:51-67 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Extensions/ElasticsearchOptionsExtensions.cs:13` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:87— src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:87-103 | src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:127-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:158— src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:158-174 | src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:193-209 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:158` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (17 lines × 2) REDACTED:144— REDACTED:144-160 | REDACTED:257-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (17 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddClassesTag.cs:18— src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddClassesTag.cs:18-34 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapePagerTag.cs:73-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AddClassesTag.cs:18` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) REDACTED:189— REDACTED:189-205 | REDACTED:229-245 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/Handlers/LuceneContentIndexProfileHandler.cs:45— src/OrchardCore/OrchardCore.Lucene.Core/Handlers/LuceneContentIndexProfileHandler.cs:45-61 | src/OrchardCore/OrchardCore.Lucene.Core/Handlers/LuceneContentIndexProfileHandler.cs:68-84 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:35— src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:35-51 | src/OrchardCore/OrchardCore/Shell/Removing/ShellWebRootRemovingHandler.cs:39-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore/Shell/Removing/ShellSiteFolderRemovingHandler.cs:35` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:203— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:203-219 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:182-198 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 170 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:203` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:221` calls `UpdateLegacyAnalyzerNameAsync`, `EnsureDefaultSearchSiteSettingAsync` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:199` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs:273— src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs:273-289 | src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:550-567 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:550` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:547` calls `GetTypeDefinitionAsync`, `FirstOrDefault`, `Equals` and `src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs:272` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:113— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:113-130 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:98-114 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:77— src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:77-94 | src/OrchardCore/OrchardCore/Shell/Configuration/ShellsSettingsSources.cs:35-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:77` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:76` calls `DatabaseShellsSettings` and `src/OrchardCore/OrchardCore/Shell/Configuration/ShellsSettingsSources.cs:34` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldTrumbowygEditorSettingsDriver.cs:37— src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldTrumbowygEditorSettingsDriver.cs:37-52 | src/OrchardCore.Modules/OrchardCore.Html/Settings/HtmlBodyPartTrumbowygEditorSettingsDriver.cs:37-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldTrumbowygEditorSettingsDriver.cs:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdatePartFieldEditorContext` in one and `UpdateTypePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Controllers/BackgroundTaskController.cs:307— src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Controllers/BackgroundTaskController.cs:307-322 | src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Controllers/BackgroundTaskController.cs:336-351 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.Shells.Azure/Configuration/BlobShellConfigurationSources.cs:69— src/OrchardCore/OrchardCore.Shells.Azure/Configuration/BlobShellConfigurationSources.cs:69-84 | src/OrchardCore/OrchardCore/Shell/Configuration/ShellConfigurationSources.cs:42-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Shells.Azure/Configuration/BlobShellConfigurationSources.cs:69` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Drivers/ElasticsearchQueryDisplayDriver.cs:83— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Drivers/ElasticsearchQueryDisplayDriver.cs:83-98 | src/OrchardCore.Modules/OrchardCore.Lucene/Drivers/LuceneQueryDisplayDriver.cs:83-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Liquid/MediaAnchorTag.cs:82— src/OrchardCore.Modules/OrchardCore.Media/Liquid/MediaAnchorTag.cs:82-97 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AnchorTag.cs:186-201 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Liquid/MediaAnchorTag.cs:82` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Processing/SingleFlight.cs:26— src/OrchardCore.Modules/OrchardCore.Media/Processing/SingleFlight.cs:26-41 | src/OrchardCore.Modules/OrchardCore.Media/Processing/SingleFlight.cs:70-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Processing/SingleFlight.cs:26` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) src/OrchardCore.Modules/OrchardCore.Templates/Services/AdminPreviewTemplatesProvider.cs:22— src/OrchardCore.Modules/OrchardCore.Templates/Services/AdminPreviewTemplatesProvider.cs:22-37 | src/OrchardCore.Modules/OrchardCore.Templates/Services/PreviewTemplatesProvider.cs:22-37 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Templates/Services/AdminPreviewTemplatesProvider.cs:22` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:325— src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:325-340 | src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:401-416 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:325` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `dispatch` to `Func<TEvents, TState, Task>` in one and `Func<TEvents, TState, Task<TResult>>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:135— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:135-150 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:194-209 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:135` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:947— src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:947-962 | src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:968-983 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:986` calls `ToDisplayString` and `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:965` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:251— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:251-266 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:322-337 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:270— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:270-285 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:346-361 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:346` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:246— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:246-261 | src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexManager.cs:100-115 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:246` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.Data/Documents/FileDocumentStore.cs:77— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:319— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:380— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:381— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:382— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:383— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:384— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:385— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:34— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:53— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Shapes/CoreShapes.cs:13— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.Workflows.Abstractions/Converters/LocalizedStringConverter.cs:14— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore/Modules/Services/SlugService.cs:12— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Change coupling: REDACTED ↔ EditUserViewModel.cs REDACTED:1— `REDACTED` and `src/OrchardCore.Modules/OrchardCore.Users/ViewModels/EditUserViewModel.cs` change together 73% of the time (8 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `f6d51527` Don't call IEnumerable<IUserEventHandler> from UserDisplayDriver (#17…; `c5e9ada6` Move the user approval process outside the edit form (#17684); `d66c5d46` Add password to user creating form (#11582) — run `git show` on any of them.
Change coupling: ScriptTagHelper.cs ↔ StyleTagHelper.cs src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:1— `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` change together 67% of the time (12 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `9eeb66fa` Fix debug-src support in StyleTagHelper for anonymous styles with dep…; `adda2895` Unify seperator in Script and Tag Helper (#17387); `1c8ae258` Support depend-on when using script and style inline (#17349) — run `git show` on any of them.
Change coupling: ContentPartDefinitionBuilder.cs ↔ ContentTypeDefinitionBuilder.cs src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:1— `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs` and `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs` change together 64% of the time (9 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `f59edd1d` Add StringExtensions Unit Tests (#14099); `da845ea8` Remove code marked obsolete for more than two years (#12955); `abce5b62` Adding helpful methods for ContentPart, ContentType builders and Cont… — run `git show` on any of them.
Change coupling: OpenIdServerSettingsDisplayDriver.cs ↔ OpenIdServerSettingsStep.cs src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:1— `src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `fa14f11b` Add OAuth 2.0 Pushed Authorization Requests support in the OpenID mod…; `4944fb10` Added additional OpenId Introspection/Revocation endpoints and PKCE t…; `87024f75` Bump OpenIddict to 3.0.0-beta6.20527.75 — run `git show` on any of them.
Change coupling: OpenIdServerSettingsStep.cs ↔ OpenIdServerService.cs src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs:1— `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `fa14f11b` Add OAuth 2.0 Pushed Authorization Requests support in the OpenID mod…; `4944fb10` Added additional OpenId Introspection/Revocation endpoints and PKCE t…; `87024f75` Bump OpenIddict to 3.0.0-beta6.20527.75 — run `git show` on any of them.
Change coupling: REDACTED ↔ ItemController.cs REDACTED:1— `REDACTED` and `src/OrchardCore.Modules/OrchardCore.Contents/Controllers/ItemController.cs` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `3551a629` Reduce Constructur Injections (#15395); `58da4538` Unused usings (#7322); `b9f1f8c9` Update session save usage (#6257) — run `git show` on any of them.
Change coupling: DynamicContentTypeBuilder.cs ↔ TypedContentTypeBuilder.cs src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/DynamicContentTypeBuilder.cs:1— `src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/DynamicContentTypeBuilder.cs` and `src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/TypedContentTypeBuilder.cs` change together 57% of the time (8 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `6347ef1b` Refactorings in preparation of .NET 9.0 support (#16575); `07a655bc` Fixes several minor issues when building the GraphQL schema (#16151); `86cfabcc` Add hidden content type settnigs to allow hidding a content type from… — run `git show` on any of them.
Change coupling: ResourceManager.cs ↔ ScriptTagHelper.cs src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:1— `src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` change together 56% of the time (10 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `6f59635d` Fix script tag helper dependencies inheriting the script's HTML attri…; `237acbc7` Fix local stylesheet rendering (#8269); `6162c62f` Support Inline location for styles and scripts (#8211) — run `git show` on any of them.
Change coupling: OpenIdServerSettingsDisplayDriver.cs ↔ OpenIdServerService.cs src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:1— `src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `fa14f11b` Add OAuth 2.0 Pushed Authorization Requests support in the OpenID mod…; `4944fb10` Added additional OpenId Introspection/Revocation endpoints and PKCE t…; `87024f75` Bump OpenIddict to 3.0.0-beta6.20527.75 — run `git show` on any of them.
Change coupling: REDACTED ↔ REDACTED REDACTED:1— `REDACTED` and `REDACTED` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `55c58098` Fixing that a captcha is required on external login and registration,…; `54ada205` Redirect escapeUrl parameter was not used (#10398); `bc9888be` Add user approval feature (#9873) — run `git show` on any of them.
Change coupling: ListPartDisplayDriver.cs ↔ ListPartSettingsDisplayDriver.cs src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs:1— `src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.Lists/Settings/ListPartSettingsDisplayDriver.cs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `ff6d2920` Make ListPart Pagination Configurable (Slim by Default, Full as an Op…; `b45c84c7` Add "Display Header" property to ListPartSettings (#12525); `0d46fefe` Make lists sortable with ordering setting (#3711) — run `git show` on any of them.
Change coupling: ContentMethodsProvider.cs ↔ CreateContentTask.cs src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs:1— `src/OrchardCore.Modules/OrchardCore.Contents/Scripting/ContentMethodsProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/CreateContentTask.cs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `622a1cc3` Remove implicit CancelAsync from ValidateAsync, move to callers (#18939); `c1448cc7` Update event should only be called when updating content item (#17429); `29336302` Make Content Recipe Step Idempotent (#5487) — run `git show` on any of them.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:143— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:143-160 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:122-139 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:143` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:196— src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:196-213 | src/OrchardCore.Modules/OrchardCore.Media/Liquid/MediaAnchorTag.cs:75-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:204— src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:204-221 | src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/LimitStep.cs:76-93 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:204` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:33— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:33-50 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:18-35 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:342— src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:342-359 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:343-360 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:342` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:195— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:195-212 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:290-307 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:195` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `BuildEditorContext` in one and `UpdateEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.Navigation.Core/NavigationManager.cs:100— src/OrchardCore/OrchardCore.Navigation.Core/NavigationManager.cs:100-117 | src/OrchardCore/OrchardCore.Navigation.Core/NavigationManager.cs:124-141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Deployment/Download/DownloadController.cs:31— src/OrchardCore.Modules/OrchardCore.Contents/Deployment/Download/DownloadController.cs:31-48 | src/OrchardCore.Modules/OrchardCore.Contents/Deployment/Download/DownloadController.cs:62-79 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/StepController.cs:125— src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/StepController.cs:125-142 | src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/StepController.cs:203-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 2) src/OrchardCore.Modules/OrchardCore.Rules/Services/AllConditionEvaluator.cs:15— src/OrchardCore.Modules/OrchardCore.Rules/Services/AllConditionEvaluator.cs:15-32 | src/OrchardCore/OrchardCore.Rules.Core/Services/RuleService.cs:13-30 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:130— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:130-147 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:279-297 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs:182— src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs:182-199 | src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs:162-179 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:179— src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:179-189 | src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs:176-186 — before extracting anything, compare `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:179` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/DeleteEndpoint.cs:32— src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/DeleteEndpoint.cs:32-42 | src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/GetEndpoint.cs:32-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:87— src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:87-97 | src/OrchardCore/OrchardCore.Contents.TagHelpers/ContentLinkTagHelper.cs:86-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:49— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:49-59 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:237-247 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:187— src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:187-197 | src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:209-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:187` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.RateLimits/Drivers/FixedWindowRateLimiterDisplayDriver.cs:52— src/OrchardCore.Modules/OrchardCore.RateLimits/Drivers/FixedWindowRateLimiterDisplayDriver.cs:52-62 | src/OrchardCore.Modules/OrchardCore.RateLimits/Drivers/SlidingWindowRateLimiterDisplayDriver.cs:53-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Handlers/ElasticsearchIndexProfileHandler.cs:97— src/OrchardCore/OrchardCore.Elasticsearch.Core/Handlers/ElasticsearchIndexProfileHandler.cs:97-107 | src/OrchardCore/OrchardCore.Lucene.Core/Handlers/LuceneContentIndexProfileHandler.cs:88-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Extensions/ContentOrchardHelperExtensions.cs:31— src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Extensions/ContentOrchardHelperExtensions.cs:31-41 | src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:272-282 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:151— src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:151-161 | src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:176-186 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:151` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:174` calls `Weld`, `FlowMetadata` and `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:150` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:206— src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:206-216 | src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:252-262 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:76— src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:76-86 | src/OrchardCore.Modules/OrchardCore.Email.Smtp/Services/SmtpOptionsConfiguration.cs:54-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:76` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:74` calls `IsNullOrWhiteSpace` and `src/OrchardCore.Modules/OrchardCore.Email.Smtp/Services/SmtpOptionsConfiguration.cs:54` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:170— src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:170-180 | src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs:137-147 — before extracting anything, compare `src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs` and `src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:100— src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:100-108 | src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:135-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:100` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/BooleanQueryProvider.cs:94— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/BooleanQueryProvider.cs:94-102 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/BooleanQueryProvider.cs:113-121 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Razor/OrchardRazorHelperExtensions.cs:27— src/OrchardCore.Modules/OrchardCore.Media/Razor/OrchardRazorHelperExtensions.cs:27-35 | src/OrchardCore.Modules/OrchardCore.Media/Razor/OrchardRazorHelperExtensions.cs:52-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:31— src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:31-39 | src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:43-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:745— src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:745-753 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:803-811 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:745` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeQueryResourceBuilder.cs:52— src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeQueryResourceBuilder.cs:52-60 | src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeQueryResourceBuilder.cs:81-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeQueryResourceBuilder.cs:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:61— src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:61-69 | src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:79-87 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:61` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:89` calls `Named` and `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:72` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.DataPipelines.Ftp/Drivers/UploadToFtpStepDisplayDriver.cs:50— src/OrchardCore.Modules/OrchardCore.DataPipelines.Ftp/Drivers/UploadToFtpStepDisplayDriver.cs:50-58 | src/OrchardCore.Modules/OrchardCore.DataPipelines.Sftp/Drivers/UploadToSftpStepDisplayDriver.cs:51-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `UploadToFtpStepViewModel` in one and `UploadToSftpStepViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/LuceneQueryService.cs:51— src/OrchardCore/OrchardCore.Lucene.Core/LuceneQueryService.cs:51-59 | src/OrchardCore/OrchardCore.Lucene.Core/LuceneQueryService.cs:67-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/LuceneQueryService.cs:51` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:129— src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:129-137 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:352-361 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:129` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `SetupViewModel` in one and `SetupApiViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) REDACTED:501— REDACTED:501-509 | REDACTED:595-603 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:501` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:497` calls `WhenAll`, `Select`, `HarvestRecipesAsync` and `REDACTED:594` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) src/OrchardCore.Modules/OrchardCore.Templates/Services/AdminTemplatesShapeBindingResolver.cs:58— src/OrchardCore.Modules/OrchardCore.Templates/Services/AdminTemplatesShapeBindingResolver.cs:58-66 | src/OrchardCore.Modules/OrchardCore.Templates/Services/TemplatesShapeBindingResolver.cs:57-65 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
AC4 · Keyboard semantics· Modal dialog does not manage focus · ×11
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Admin/Views/QuickNavigationNavbarItem.cshtml:16— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml:95— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml:70— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/AddToDeploymentPlan-ActionDeploymentPlan.Modal.cshtml:11— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/AddToDeploymentPlan-ContentsBulkActionsDeploymentPlan.Modal.cshtml:7— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ContentTypesAdminNode.Fields.TreeEdit.cshtml:124— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ExportContentToDeploymentTarget-ActionDeploymentTarget.Modal.cshtml:8— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ExportContentToDeploymentTarget-ContentsBulkActionsDeploymentTarget.Modal.cshtml:4— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/ConnectDialog.vue:57— This <div role="dialog"> is a modal dialog, but focus is moved into it, but nothing keeps it there: Tab walks out to the page behind, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/QuickAddMenu.vue:84— This <div role="dialog"> is a modal dialog, but focus is moved into it, but nothing keeps it there: Tab walks out to the page behind, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
Modal dialog does not manage focus src/OrchardCore.Modules/OrchardCore.Lists/Views/Items/ListsAdminNode.Fields.TreeEdit.cshtml:103— This <div role="dialog"> is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native <dialog> opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close.
AC4 · Keyboard semantics· Link used as a button (placeholder href) · ×11
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Flows/Views/ContentTypePicker.cshtml:19— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:34— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:54— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:98— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:104— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:111— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FileMenu.vue:3— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderComponent.vue:6— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderComponent.vue— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderComponent.vue:25— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Link used as a button (placeholder href) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/components/FolderRow.vue:7— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
Duplicated block (8 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/GeoBoundingBoxFilterProvider.cs:58— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/GeoBoundingBoxFilterProvider.cs:58-65 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/GeoDistanceFilterProvider.cs:81-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/GeoBoundingBoxFilterProvider.cs:58` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Indexing/Drivers/IndexProfileDisplayDriver.cs:32— src/OrchardCore.Modules/OrchardCore.Indexing/Drivers/IndexProfileDisplayDriver.cs:32-39 | src/OrchardCore.Modules/OrchardCore.Roles/Drivers/RoleEntryDisplayDriver.cs:16-23 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Indexing/Drivers/IndexProfileDisplayDriver.cs:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteFolderEndpoint.cs:41— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteFolderEndpoint.cs:41-48 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteMediaEndpoint.cs:34-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteFolderEndpoint.cs:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Facebook/Endpoints/GetSdkEndpoints.cs:49— src/OrchardCore.Modules/OrchardCore.Facebook/Endpoints/GetSdkEndpoints.cs:49-56 | src/OrchardCore.Modules/OrchardCore.Facebook/Endpoints/GetSdkEndpoints.cs:104-111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Facebook/Endpoints/GetSdkEndpoints.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44— src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44-51 | src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:123-130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentLocalization/Drivers/ContentCulturePickerNavbarDisplayDriver.cs:30— src/OrchardCore.Modules/OrchardCore.ContentLocalization/Drivers/ContentCulturePickerNavbarDisplayDriver.cs:30-37 | src/OrchardCore.Modules/OrchardCore.Localization/Drivers/AdminCulturePickerNavbarDisplayDriver.cs:29-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentLocalization/Drivers/ContentCulturePickerNavbarDisplayDriver.cs:30` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:115— src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:115-122 | src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:137-144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:115` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:231— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:231-238 | src/OrchardCore.Modules/OrchardCore.Users/Migrations.cs:242-249 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:231` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Users/Migrations.cs:251` calls `LogDebug` and `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:240` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Widgets/ContentCardShapes.cs:27— src/OrchardCore.Modules/OrchardCore.Widgets/ContentCardShapes.cs:27-34 | src/OrchardCore.Modules/OrchardCore.Widgets/ContentCardShapes.cs:64-71 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:100— src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:100-107 | src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:120-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/FeatureAttribute.cs:340— src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/FeatureAttribute.cs:340-347 | src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/ModuleAttribute.cs:321-328 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
FunctionTooLong: UppyFileUpload.useFileUpload src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:132— FunctionTooLong — useFileUpload runs 276 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 176 over it, 2.76× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: FileLibraryManager.useFileLibraryManager src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileLibraryManager.ts:57— FunctionTooLong — useFileLibraryManager runs 224 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 124 over it, 2.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: FieldUploadService.useFieldUpload src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/services/FieldUploadService.ts:33— FunctionTooLong — useFieldUpload runs 166 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 66 over it, 1.66× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: HierarchicalTreeBuilder.useHierarchicalTreeBuilder src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:29— FunctionTooLong — useHierarchicalTreeBuilder runs 165 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 65 over it, 1.65× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: setup.init src/OrchardCore.Modules/OrchardCore.Setup/Assets/ts/setup.ts:109— FunctionTooLong — init runs 127 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 27 over it, 1.27× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: Globals.useGlobals src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/Globals.ts:56— FunctionTooLong — useGlobals runs 119 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 19 over it, 1.19× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: EventBusService.useEventBusService src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/EventBusService.ts:15— FunctionTooLong — useEventBusService runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: designerStore.createDesignerStore src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/state/designerStore.ts:103— FunctionTooLong — createDesignerStore runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: flows.edit.document.addEventListener("DOMContentLoaded") src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:22— FunctionTooLong — document.addEventListener("DOMContentLoaded") runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
FunctionTooLong: trumbowyg.resizimg.ResizeWithCanvas src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/resizimg/trumbowyg.resizimg.js:14— FunctionTooLong — ResizeWithCanvas runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:107— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:107-113 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:152-158 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:107` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:277— src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:277-283 | src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:313-319 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:277` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:9— src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:9-15 | src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdApplicationStepModel.cs:5-11 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.Users/ViewModels/EditPasswordViewModel.cs:14— src/OrchardCore.Modules/OrchardCore.Users/ViewModels/EditPasswordViewModel.cs:14-20 | src/OrchardCore.Modules/OrchardCore.Users/ViewModels/ResetPasswordViewModel.cs:14-20 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Users/ViewModels/EditPasswordViewModel.cs:11` calls `DataType` and `src/OrchardCore.Modules/OrchardCore.Users/ViewModels/ResetPasswordViewModel.cs:11` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:28— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:28-34 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/MatchQueryProvider.cs:21-27 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.Rules/Drivers/AllConditionDisplayDriver.cs:16— src/OrchardCore.Modules/OrchardCore.Rules/Drivers/AllConditionDisplayDriver.cs:16-22 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/AnyConditionDisplayDriver.cs:16-22 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Rules/Drivers/AllConditionDisplayDriver.cs:16` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `condition` to `AllConditionGroup` in one and `AnyConditionGroup` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Shell/ShellOrchardCoreBuilderExtensions.cs:31— src/OrchardCore/OrchardCore.Infrastructure/Shell/ShellOrchardCoreBuilderExtensions.cs:31-37 | src/OrchardCore/OrchardCore/Modules/Extensions/OrchardCoreBuilderExtensions.cs:63-69 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:121— src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:121-127 | src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:236-242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:121` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:129` calls `FindFirstValue` and `src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:245` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItem.cs:44— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItem.cs:44-74 | src/OrchardCore/OrchardCore.ContentManagement/Records/ContentItemIndex.cs:19-25 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentLocalization/Security/LocalizeContentAuthorizationHandler.cs:71— src/OrchardCore.Modules/OrchardCore.ContentLocalization/Security/LocalizeContentAuthorizationHandler.cs:71-77 | src/OrchardCore.Modules/OrchardCore.Contents/Security/ContentTypeAuthorizationHandler.cs:87-93 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Off the main sequence: OrchardCore.ResourceManagement src/OrchardCore/OrchardCore.ResourceManagement/OrchardCore.ResourceManagement.csproj:1— OrchardCore.ResourceManagement: abstractness 0.00, instability 0.01, distance 0.99 — zone of pain — concrete and depended on by 72 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Settings.Core src/OrchardCore/OrchardCore.Settings.Core/OrchardCore.Settings.Core.csproj:1— OrchardCore.Settings.Core: abstractness 0.00, instability 0.11, distance 0.89 — zone of pain — concrete and depended on by 16 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.ContentFields.Core src/OrchardCore/OrchardCore.ContentFields.Core/OrchardCore.ContentFields.Core.csproj:1— OrchardCore.ContentFields.Core: abstractness 0.00, instability 0.17, distance 0.83 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.ContentManagement src/OrchardCore/OrchardCore.ContentManagement/OrchardCore.ContentManagement.csproj:1— OrchardCore.ContentManagement: abstractness 0.00, instability 0.17, distance 0.83 — zone of pain — concrete and depended on by 24 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Deployment.Core src/OrchardCore/OrchardCore.Deployment.Core/OrchardCore.Deployment.Core.csproj:1— OrchardCore.Deployment.Core: abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Navigation.Core src/OrchardCore/OrchardCore.Navigation.Core/OrchardCore.Navigation.Core.csproj:1— OrchardCore.Navigation.Core: abstractness 0.19, instability 0.04, distance 0.76 — zone of pain — concrete and depended on by 66 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Data.YesSql REDACTED:1— OrchardCore.Data.YesSql: abstractness 0.00, instability 0.25, distance 0.75 — zone of pain — concrete and depended on by 9 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Queries.Core src/OrchardCore/OrchardCore.Queries.Core/OrchardCore.Queries.Core.csproj:1— OrchardCore.Queries.Core: abstractness 0.00, instability 0.25, distance 0.75 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.Roles.Core src/OrchardCore/OrchardCore.Roles.Core/OrchardCore.Roles.Core.csproj:1— OrchardCore.Roles.Core: abstractness 0.00, instability 0.29, distance 0.71 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: OrchardCore.ContentManagement.Display src/OrchardCore/OrchardCore.ContentManagement.Display/OrchardCore.ContentManagement.Display.csproj:1— OrchardCore.ContentManagement.Display: abstractness 0.24, instability 0.06, distance 0.70 — zone of pain — concrete and depended on by 33 project(s), so it's rigid to change.
Low cohesion: UserStore (LCOM4 41) src/OrchardCore/OrchardCore.Users.Core/Services/UserStore.cs:14— UserStore's methods fall into 41 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 41 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OpenIdApplicationStore (LCOM4 33) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs:16— OpenIdApplicationStore's methods fall into 33 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 33 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OpenIdTokenStore (LCOM4 25) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:17— OpenIdTokenStore's methods fall into 25 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 25 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OpenIdScopeStore (LCOM4 17) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdScopeStore.cs:15— OpenIdScopeStore's methods fall into 17 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 17 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: OpenIdAuthorizationStore (LCOM4 16) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:18— OpenIdAuthorizationStore's methods fall into 16 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 16 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: RoleStore (LCOM4 9) src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleStore.cs:13— RoleStore's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: HomeController (LCOM4 4) REDACTED:15— HomeController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: TwoFactorAuthenticationController (LCOM4 4) REDACTED:23— TwoFactorAuthenticationController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ShapeMetadata (LCOM4 4) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/ShapeMetadata.cs:9— ShapeMetadata's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
FileTooLong: table/trumbowyg.table.js src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js— FileTooLong — 1059 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 559 over it, 2.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs— FileTooLong — 936 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 436 over it, 1.87× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs— FileTooLong — 685 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 185 over it, 1.37× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: OrchardCore.ContentManagement/DefaultContentManager.cs src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs— FileTooLong — 615 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 115 over it, 1.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs— FileTooLong — 610 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 110 over it, 1.22× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: SQL/Migrations.cs src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs— FileTooLong — 559 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 59 over it, 1.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 540 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 40 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Files/ExcelDataFileFormat.cs src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs— FileTooLong — 506 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 6 over it, 1.01× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Duplicated block (29 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:225— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:225-253 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:320-348 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:225` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `BuildEditorContext` in one and `UpdateEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (29 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:324— src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:324-352 | src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:413-441 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:324` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:322` calls `CreateAsync` and `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:411` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (29 lines × 2) src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:11— src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:11-39 | src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs:12-40 — before extracting anything, compare `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (29 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:48— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:48-76 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/MoveMediaEndpoint.cs:47-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:253— src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:253-281 | src/OrchardCore.Modules/OrchardCore.Secrets/Drivers/X509SecretDisplayDriver.cs:93-121 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (29 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:56— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:56-84 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:56-84 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (29 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:64— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:64-92 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:285-313 — before extracting anything, compare `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs` and `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:64` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (29 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:66— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:66-94 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:337-365 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:66` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:160— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:160-180 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:197-217 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (21 lines × 2) src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:421— src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:421-441 | src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:538-558 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:421` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/DeleteContentTask.cs:33— src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/DeleteContentTask.cs:33-53 | src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/UnpublishContentTask.cs:34-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:77— src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:77-97 | src/OrchardCore.Modules/OrchardCore.Media.Azure/Startup.cs:67-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:77` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/DisableTenantTask.cs:28— src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/DisableTenantTask.cs:28-48 | src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/EnableTenantTask.cs:31-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/SetOutputTaskDisplayDriver.cs:46— src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/SetOutputTaskDisplayDriver.cs:46-66 | src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/SetVariableTaskDisplayDriver.cs:46-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/SetOutputTaskDisplayDriver.cs:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `activity` to `SetOutputTask` in one and `SetPropertyTask` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (21 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/ViewModels/ElasticIndexSettingsViewModel.cs:8— src/OrchardCore.Modules/OrchardCore.Elasticsearch/ViewModels/ElasticIndexSettingsViewModel.cs:8-28 | src/OrchardCore.Modules/OrchardCore.Lucene/ViewModels/LuceneIndexSettingsViewModel.cs:8-28 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (21 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:94— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:94-114 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:445-465 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:94` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:102— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:102-126 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:133-157 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (25 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:82— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:82-106 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:70-94 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (25 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Deployment/LuceneIndexDeploymentSource.cs:22— src/OrchardCore.Modules/OrchardCore.Lucene/Deployment/LuceneIndexDeploymentSource.cs:22-46 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Deployment/ElasticsearchIndexDeploymentSource.cs:22-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Deployment/LuceneIndexDeploymentSource.cs:22` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `step` to `LuceneIndexDeploymentStep` in one and `ElasticsearchIndexDeploymentStep` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (25 lines × 2) src/OrchardCore.Modules/OrchardCore.Taxonomies/Drivers/TaxonomyFieldDisplayDriver.cs:43— src/OrchardCore.Modules/OrchardCore.Taxonomies/Drivers/TaxonomyFieldDisplayDriver.cs:43-67 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Drivers/TaxonomyFieldTagsDisplayDriver.cs:45-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Taxonomies/Drivers/TaxonomyFieldDisplayDriver.cs:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:16— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:16-40 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:16-40 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:16` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25 lines × 2) src/OrchardCore/OrchardCore.AzureAI.Core/Handlers/AzureAISearchIndexProfileHandler.cs:86— src/OrchardCore/OrchardCore.AzureAI.Core/Handlers/AzureAISearchIndexProfileHandler.cs:86-110 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Handlers/ElasticsearchIndexProfileHandler.cs:120-144 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AzureAI.Core/Handlers/AzureAISearchIndexProfileHandler.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (25 lines × 2) src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:262— src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:262-286 | src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs:258-282 — before extracting anything, compare `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:262` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:76— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:76-85 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:60-69 | src/OrchardCore/OrchardCore.Queries.Core/QueriesDocumentMigrationHelper.cs:36-45 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 143 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 3) src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldMonacoEditorSettingsDriver.cs:46— src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldMonacoEditorSettingsDriver.cs:46-55 | src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/TextFieldMonacoEditorSettingsDriver.cs:41-50 | src/OrchardCore.Modules/OrchardCore.Html/Settings/HtmlBodyPartMonacoEditorSettingsDriver.cs:41-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldMonacoEditorSettingsDriver.cs:46` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdatePartFieldEditorContext` in one and `UpdateTypePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldMonacoEditorSettingsDriver.cs:56` calls `Parse` and `src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/TextFieldMonacoEditorSettingsDriver.cs:51` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:250— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:250-259 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:269-278 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:321-330 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:250` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 3) src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:44— src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:44-53 | src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:72-81 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:56-65 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 143 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:54` calls `LogInformation` and `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:82` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:87— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:87-97 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:71-80 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:71-80 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:71` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:101` calls `GetDefaultSearchFields` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:84` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:220— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:220-230 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:171-180 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:162-171 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 3) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs:234— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs:234-243 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:210-219 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:239-248 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Outbound HTTP without resilience src/OrchardCore.Modules/OrchardCore.DataPipelines/Startups/DestinationsStartup.cs:16— `services.AddHttpClient(SendToWebApiStep.HttpClientName)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Startup.cs:20— `services.AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:69— `services.AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/OrchardCore.Modules/OrchardCore.Workflows/Http/Startup.cs:31— `services.AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/OrchardCore/OrchardCore/Modules/Extensions/ServiceCollectionExtensions.cs:59— `new ServiceCollection() .AddHttpClient()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/OrchardCore/OrchardCore/Modules/Overrides/HttpClient/TenantHttpClientFactory.cs:119— `new HttpClient(handler, disposeHandler: false)` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience REDACTED:128— `new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
ClassTooLong: ResourceManagementOptionsConfiguration src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs— ClassTooLong — 930 significant lines (blank, comment-only and punctuation-only lines excluded), 3 methods. The bar is 400 significant lines; this is 530 over it, 2.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DefaultContentManager src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs— ClassTooLong — 599 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 199 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Migrations src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs— ClassTooLong — 554 significant lines (blank, comment-only and punctuation-only lines excluded), 6 methods. The bar is 400 significant lines; this is 154 over it, 1.39× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AdminController REDACTED— ClassTooLong — 512 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 112 over it, 1.28× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AdminController REDACTED— ClassTooLong — 445 significant lines (blank, comment-only and punctuation-only lines excluded), 17 methods. The bar is 400 significant lines; this is 45 over it, 1.11× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DataPipelineDesignerController src/OrchardCore.Modules/OrchardCore.DataPipelines/Controllers/DataPipelineDesignerController.cs— ClassTooLong — 443 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 43 over it, 1.11× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Duplicated block (20 lines × 2) src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:170— src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:170-189 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:264-283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:170` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:285` calls `RemoveShortcodeTemplateAsync` and `src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:191` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (20 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:60— src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:60-79 | src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeNavigationBuilder.cs:36-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRedirectRuleHandler.cs:34— src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRedirectRuleHandler.cs:34-53 | src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRewriteRuleHandler.cs:34-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRedirectRuleHandler.cs:34` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (20 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:1135— src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:1135-1154 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:1163-1182 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:1135` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42-61 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs:44-63 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (20 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:263— src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:263-282 | src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:312-331 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:263` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/js/App.tsx:6— src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/js/App.tsx:6 imports graphiql/dist/components/GraphiQL, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/date-field-localized.ts:8— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/date-field-localized.ts:8 imports flatpickr/dist/l10n/index.js, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:7— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:7 imports @uppy/locales/lib/en_US, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:8— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:8 imports @uppy/locales/lib/fr_FR, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:9— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:9 imports @uppy/locales/lib/it_IT, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
Boundary violation [package:third-party-deep-import] src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:10— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:10 imports @uppy/locales/lib/es_ES, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
BareSuppressMessage src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/ElasticsearchQueryMigrations.cs:9— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/LuceneQueryMigrations.cs:9— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/OrchardCore.Modules/OrchardCore.Queries/Sql/Migrations/SqlQueryMigrations.cs:8— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage test/OrchardCore.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerBindingsTests.cs:13— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:229— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
Duplicated block (24 lines × 2) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:72— src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:72-95 | src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:92-115 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:89` calls `Named` and `src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:70` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (24 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LinkFieldDisplayDriver.cs:76— src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LinkFieldDisplayDriver.cs:76-99 | src/OrchardCore.Modules/OrchardCore.ContentFields/Handlers/LinkFieldHandler.cs:40-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LinkFieldDisplayDriver.cs:76` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs:57— src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs:57-80 | src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentEventDisplayDriver.cs:84-107 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (24 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ContentDefinitionDeploymentStepDriver.cs:31— src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ContentDefinitionDeploymentStepDriver.cs:31-54 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Deployment/ReplaceContentDefinitionDeploymentStepDriver.cs:31-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `step` to `ContentDefinitionDeploymentStep` in one and `ReplaceContentDefinitionDeploymentStep` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (24 lines × 2) src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/IfElseTaskDisplayDriver.cs:41— src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/IfElseTaskDisplayDriver.cs:41-64 | src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/WhileLoopTaskDisplayDriver.cs:40-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Workflows/Drivers/IfElseTaskDisplayDriver.cs:41` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `activity` to `IfElseTask` in one and `WhileLoopTask` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs:71— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs:71-93 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/RangeQueryProvider.cs:64-86 — before extracting anything, compare `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs` and `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/RangeQueryProvider.cs` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (23 lines × 2) src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:114— src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:114-136 | src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs:118-140 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:114` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `settings` to `AzureEmailSettings` in one and `AzureSmsSettings` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:374— src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:374-396 | src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:450-472 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Modules/Extensions/InvokeExtensions.cs:374` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `dispatch` to `Func<TEvents, TState, Task<TResult>>` in one and `Func<TEvents, TState, Task<IEnumerable<TResult>>>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) REDACTED:402— REDACTED:402-424 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:130-152 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:402` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `EditTenantViewModel` in one and `TenantApiModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:96— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:96-119 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:324-346 — before extracting anything, compare `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs` and `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:324` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75— src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75-80 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:115-120 | src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:175-180 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement.Liquid/ViewBufferTextWriterContent.cs:75` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `buffer` to `char[]` in one and `ReadOnlySpan<char>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 3) src/OrchardCore.Modules/OrchardCore.Alias/Settings/AliasPartSettingsDisplayDriver.cs:45— src/OrchardCore.Modules/OrchardCore.Alias/Settings/AliasPartSettingsDisplayDriver.cs:45-50 | src/OrchardCore.Modules/OrchardCore.Autoroute/Settings/AutoroutePartSettingsDisplayDriver.cs:58-63 | src/OrchardCore.Modules/OrchardCore.ContentPreview/Settings/PreviewPartSettingsDisplayDriver.cs:44-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Alias/Settings/AliasPartSettingsDisplayDriver.cs:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:236— src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:236-241 | src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:327-332 | src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:401-406 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:236` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44— src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44-49 | src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:83-88 | src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:123-128 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/OrchardCore.Modules/OrchardCore.Templates/Settings/TemplateContentPartDefinitionDriver.cs:59— src/OrchardCore.Modules/OrchardCore.Templates/Settings/TemplateContentPartDefinitionDriver.cs:59-64 | src/OrchardCore.Modules/OrchardCore.Templates/Settings/TemplateContentTypeDefinitionDriver.cs:63-68 | src/OrchardCore.Modules/OrchardCore.Templates/Settings/TemplateContentTypePartDefinitionDriver.cs:61-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (6 lines × 2) src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:38— src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:38-43 | src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexResetStep.cs:37-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:46` calls `RebuildAsync` and `src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexResetStep.cs:45` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:83— src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:83-88 | src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:123-128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:62— src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:62-67 | src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:103-108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:65— src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:65-70 | src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedQuery.cs:87-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedQuery.cs:84` calls `AddProperty`, `XElement`, `XCData` and `src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:64` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/LuceneIndexPermissionHelper.cs:22— src/OrchardCore.Modules/OrchardCore.Lucene/LuceneIndexPermissionHelper.cs:22-37 | src/OrchardCore/OrchardCore.Elasticsearch.Core/ElasticsearchIndexPermissionHelper.cs:13-18 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldDisplayDriver.cs:77— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldDisplayDriver.cs:77-81 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldDisplayDriver.cs:106-110 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44-48 | src/OrchardCore.Modules/OrchardCore.Users/Migrations.cs:242-246 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/OrchardCore.Modules/OrchardCore.Autoroute/Drivers/AutoroutePartDisplayDriver.cs:121— src/OrchardCore.Modules/OrchardCore.Autoroute/Drivers/AutoroutePartDisplayDriver.cs:121-125 | src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:599-603 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:193— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs:193-197 | src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs:177-181 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Controllers/AdminController.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/Controllers/AdminController.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 2) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/AWSS3ResizedImageCache.cs:178— src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/AWSS3ResizedImageCache.cs:178-182 | src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/AzureBlobResizedImageCache.cs:132-136 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Fake-async — async method never awaits src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaForgotPasswordFormDisplayDriver.cs:19— `EditAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaLoginFormDisplayDriver.cs:20— `EditAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaResetPasswordFormDisplayDriver.cs:20— `EditAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/RegisterUserFormDisplayDriver.cs:20— `EditAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/OrchardCore.Modules/OrchardCore.Settings/Services/SitePropertiesLiquidMapper.cs:14— `MapAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.Data/Documents/FileDocumentStore.cs:77— `CommitAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:34— `Items` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs:53— `AddAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore.DisplayManagement/Shapes/CoreShapes.cs:13— `PlaceChildContent` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/OrchardCore/OrchardCore/Modules/Services/SlugService.cs:12— `Slugify` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
D17 · Explicit Debt· Whole file has no live code · ×4
Whole file has no live code — 1 debt marker inside it src/OrchardCore.Modules/OrchardCore.Contents/ViewModels/PublishContentViewModel.cs:12— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 23 debt markers inside it test/OrchardCore.Abstractions.Tests/Modules/Manifest/ModuleMarkerAttributeTests.cs:1— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 23 debt markers (21 CommentedOutCode, 2 TodoComment) all sit inside that dead text: one decision to leave the whole file switched off, not 23 independent debts. The first note recorded in it is "//// TODO: MWP: will circle around on this one..." (line 1). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 11 debt markers inside it test/OrchardCore.Tests/ContentDefinition/ContentDefinitionManagerTests.cs:1— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 11 debt markers (11 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 11 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 5 debt markers inside it test/OrchardCore.Tests/DisplayManagement/SubsystemTests.cs:1— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 5 debt markers (5 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 5 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Duplicated block (22 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:314— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:314-335 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:356-377 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:314` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:73— src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:73-94 | src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:179-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentItemDisplayManager.cs:106— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentItemDisplayManager.cs:106-127 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentItemDisplayManager.cs:151-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (22 lines × 2) src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:33— src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:33-54 | src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRewriteRuleSource.cs:33-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:33` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/PermissionMigrations.cs:41— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/PermissionMigrations.cs:41-48 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/PermissionMigrations.cs:38-45 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/PermissionMigrations.cs:38-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (8 lines × 3) src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:34— src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:34-41 | src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedQuery.cs:72-79 | src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedQuery.cs:85-92 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Feeds/CommonFeedItemBuilder.cs:34` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/OrchardCore.Modules/OrchardCore.Deployment/Steps/RecipeFileDeploymentStep.cs:19— src/OrchardCore.Modules/OrchardCore.Deployment/Steps/RecipeFileDeploymentStep.cs:19-33 | src/OrchardCore.Modules/OrchardCore.Deployment/ViewModels/RecipeFileDeploymentStepViewModel.cs:5-12 | src/OrchardCore/OrchardCore.Recipes.Abstractions/Models/RecipeDescriptor.cs:7-14 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:651— src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:651-660 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1053-1060 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1150-1157 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `null` to `VersionOptions options =` in one and `IEnumerable<ContentItem> evictionVersions =` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Dead file (~86 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/indent/trumbowyg.indent.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~86 LoC) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~86 LoC) src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/sb-watch.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~86 LoC) src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/sb-watch.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×3
Animation without a prefers-reduced-motion guard src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:11— `#graphiql` moves (`transition: left 0.2s ease-in-out, width 0.2s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:17— `[dir=rtl] #graphiql` moves (`transition: right 0.2s ease-in-out, width 0.2s ease-in-out`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Views/Admin/Index.cshtml:27— `.loader` moves (`animation: spin 1s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
BarePragmaDisable src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleStore.cs:263— #pragma warning disable CA1816 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/OrchardCore/OrchardCore.Roles.Core/Services/NullRoleStore.cs:20— #pragma warning disable CA1816 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/OrchardCore.Tests/Commands/CommandHandlerDescriptorBuilderTests.cs:62— #pragma warning disable 660,661 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
Duplicated block (20–21 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:68— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:68-88 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:56-75 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (20–21 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Deployment/ContentDeploymentSource.cs:36— src/OrchardCore.Modules/OrchardCore.Contents/Deployment/ContentDeploymentSource.cs:36-56 | src/OrchardCore.Modules/OrchardCore.Queries/Deployment/QueryBasedContentDeploymentSource.cs:52-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Deployment/ContentDeploymentSource.cs:36` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20–21 lines × 2) src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PoParser.cs:37— src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PoParser.cs:37-56 | src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PoParser.cs:69-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PoParser.cs:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 3) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:457— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:457-469 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:490-502 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:522-534 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (13 lines × 3) src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:188— src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:188-200 | src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:253-265 | src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowController.cs:274-286 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (13 lines × 3) src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:75— src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:75-87 | src/OrchardCore.Modules/OrchardCore.Contents/AdminNodes/ContentTypesAdminNodeNavigationBuilder.cs:72-84 | src/OrchardCore.Modules/OrchardCore.Lists/AdminNodes/ListsAdminNodeNavigationBuilder.cs:73-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeNavigationBuilder.cs:75` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 3) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:132— src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:132-145 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:418-431 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:551-564 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `viewModel` to `CreateTypeViewModel` in one and `CreatePartViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 3) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchIndexManager.cs:134— src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchIndexManager.cs:134-147 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:245-258 | src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexManager.cs:99-112 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchIndexManager.cs:134` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchIndexManager.cs:149` calls `CreateSearchIndexClient` and `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchIndexManager.cs:260` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 3) src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:578— src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:578-591 | src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:616-629 | src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:653-666 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:578` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:248— src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:248-256 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:278-286 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:308-316 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) REDACTED:150— REDACTED:150-158 | REDACTED:263-271 | REDACTED:583-591 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 3) src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:954— src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:954-962 | src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:975-983 | src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:997-1005 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:986` calls `ToDisplayString` and `src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:965` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 3) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:563— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:563-573 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdScopeStore.cs:323-333 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:677-687 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:563` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/CreateTenantTask.cs:94— src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/CreateTenantTask.cs:94-104 | src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/DisableTenantTask.cs:28-38 | src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/EnableTenantTask.cs:31-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 3) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:192— src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:192-202 | src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:268-278 | src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:317-327 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (14–15 lines × 2) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:220— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:220-234 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:162-175 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 143 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:220` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14–15 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/Handlers/ContainedPartLocalizationHandler.cs:24— src/OrchardCore.Modules/OrchardCore.Lists/Handlers/ContainedPartLocalizationHandler.cs:24-38 | src/OrchardCore.Modules/OrchardCore.Lists/Handlers/ContainedPartLocalizationHandler.cs:54-67 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `LocalizationContentContext` in one and `CreateContentContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14–15 lines × 2) src/OrchardCore.Modules/OrchardCore.Roles/Controllers/AdminController.cs:292— src/OrchardCore.Modules/OrchardCore.Roles/Controllers/AdminController.cs:292-305 | src/OrchardCore.Modules/OrchardCore.Roles/Services/PermissionsLocalizationDataProvider.cs:35-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Roles/Controllers/AdminController.cs:292` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 4) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42-51 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetFoldersEndpoint.cs:38-47 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs:44-53 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/UploadMediaEndpoint.cs:54-63 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 4) src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:43— src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:43-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/CultureConditionDisplayDriver.cs:43-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/RoleConditionDisplayDriver.cs:43-52 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/UrlConditionDisplayDriver.cs:43-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:43` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `condition` to `ContentTypeCondition` in one and `CultureCondition` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 4) src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaForgotPasswordFormDisplayDriver.cs:21— src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaForgotPasswordFormDisplayDriver.cs:21-30 | src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaLoginFormDisplayDriver.cs:22-31 | src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/ReCaptchaResetPasswordFormDisplayDriver.cs:22-31 | src/OrchardCore.Modules/OrchardCore.ReCaptcha/Drivers/RegisterUserFormDisplayDriver.cs:22-31 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/content-picker-field-settings.ts:10— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/content-picker-field-settings.ts:10 · src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/bag-part-settings.ts:4 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (17 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaPickerModal.vue:104 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (17 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js:303— src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js:303 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:153 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (16 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:42— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:42 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:97 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (16 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js:131— src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js:131 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:75 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (16 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:200— src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js:200 · src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/preformatted/trumbowyg.preformatted.js:99 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication· Duplicated block with local edits (14 matched lines × 2 locations) · ×3
Duplicated block with local edits (14 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-monaco.ts:8— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-monaco.ts:8 · src/OrchardCore.Modules/OrchardCore.Queries/Assets/ts/queries-admin-query.ts:13 — the two spans are one implementation copied and then locally edited — 84 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block with local edits (14 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/vite.config.ts:11— src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/vite.config.ts:11 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.standalone.config.ts:24 — the two spans are one implementation copied and then locally edited — 66 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block with local edits (14 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:220— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:220 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/media-gallery-auth.ts:240 — the two spans are one implementation copied and then locally edited — 70 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
AC3 · Page structure· Data table has no header cells · ×2
Data table has no header cells src/OrchardCore.Modules/OrchardCore.Demo/Views/Todo.Edit.liquid:2— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
Data table has no header cells src/OrchardCore.Modules/OrchardCore.Users/Views/ExternalAuthentications/ExternalLogins.cshtml:13— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
AC3 · Page structure· Heading level jumps from h3 to h6 · ×2
Heading level jumps from h3 to h6 REDACTED:221— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Heading level jumps from h3 to h6 REDACTED:241— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Empty <h3> heading src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/bootstrap.bundle.js:5513— An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
Empty <h3> heading src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/bootstrap.js:3695— An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
Low contrast colour pair in CSS (2.6:1) src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/orchard.workflows-editor.css:45— `.workflow-canvas .activity.activity-start, .workflow-canvas .activity.activity-blocking` sets color: #ffffff on background-color: #7ab02c — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (2.6:1) src/OrchardCore.Modules/OrchardCore.Workflows/wwwroot/Styles/orchard.workflows-viewer.css:45— `.workflow-canvas .activity.activity-start, .workflow-canvas .activity.activity-blocking` sets color: #ffffff on background-color: #7ab02c — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (4.4:1) src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media-picker2.css:1— `.oc-media-input-group-text` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from).
Low contrast colour pair in CSS (4.4:1) src/OrchardCore.Modules/OrchardCore.Media/Assets/shared/media-admin.css:170— `.oc-media-input-group-text` sets color: #6c757d on background-color: #f8f9fa — 4.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (3.4:1) src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media2.css:1— `.stepper .step-circle.active` sets color: #fff on background-color: #0a8cfa — 3.4:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from).
Low contrast colour pair in CSS (3.4:1) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/assets/css/file.css:1944— `.stepper .step-circle.active` sets color: #fff on background-color: rgb(10, 140, 250) — 3.4:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
list-management.initializeSearch::update (cognitive 18) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:382— list-management.initializeSearch::update has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (11 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (list-management.initializeSearch::navigateToSearchAction) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
list-management.initializeSearch::navigateToSearchAction (cognitive 17) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:352— list-management.initializeSearch::navigateToSearchAction has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 4 (9 pts), if/else 5 (7 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (list-management.initializeSearch::update) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×2
Edited copy of a member (36 corresponding lines) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:67— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:67-115 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:340-401 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (36 corresponding lines) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:65— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:65-103 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:382-441 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Members sharing a duplicated core (12 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (12 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs:27— src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs:27-82 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/ContentPickerFieldIndexProvider.cs:27-85 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/DateFieldIndexProvider.cs:27-81 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/DateTimeFieldIndexProvider.cs:27-82 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/HtmlFieldIndexProvider.cs:27-82 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/LinkFieldIndexProvider.cs:36-96 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/MultiTextFieldIndexProvider.cs:33-91 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/NumericFieldIndexProvider.cs:27-82 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/TextFieldIndexProvider.cs:33-89 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/TimeFieldIndexProvider.cs:27-82 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/UserPickerFieldIndexProvider.cs:27-84 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Indexing/TaxonomyIndexProvider.cs:24-101 — These 12 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 12 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 12 times.
Members sharing a duplicated core (12 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:93— src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:93-181 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:163-178 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:184-224 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:206-221 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:94-182 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:164-179 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:185-225 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:207-222 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:97-184 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:166-181 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:187-226 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:208-223 — These 12 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 12 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 12 times.
D4 · Code Duplication· Members sharing a duplicated core (7 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (7 members, 50+ identical tokens) REDACTED:62— REDACTED:62-115 | src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:65-121 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:69-121 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/AdminController.cs:70-121 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:64-117 | src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs:69-153 | REDACTED:62-123 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Members sharing a duplicated core (7 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:72— src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:72-140 | src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs:178-240 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:53-79 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:84-166 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:170-212 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:217-292 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:297-350 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Duplicated block (35–39 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:68— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:68-102 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:341-379 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (35–39 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:66— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:66-100 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:383-421 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (35 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:105— src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:105-139 | src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs:28-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (35 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/CreateOpenIdApplicationViewModel.cs:7— src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/CreateOpenIdApplicationViewModel.cs:7-41 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/EditOpenIdApplicationViewModel.cs:11-45 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/CreateOpenIdApplicationViewModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/EditOpenIdApplicationViewModel.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (33 lines × 2) src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:218— src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:218-250 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:298-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (33 lines × 2) src/OrchardCore/OrchardCore/Extensions/Features/FeaturesProvider.cs:49— src/OrchardCore/OrchardCore/Extensions/Features/FeaturesProvider.cs:49-81 | src/OrchardCore/OrchardCore/Extensions/Features/FeaturesProvider.cs:101-133 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore/Extensions/Features/FeaturesProvider.cs:49` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (32 lines × 2) src/OrchardCore.Modules/OrchardCore.Liquid/Filters/LocalTimeZoneFilter.cs:19— src/OrchardCore.Modules/OrchardCore.Liquid/Filters/LocalTimeZoneFilter.cs:19-50 | src/OrchardCore.Modules/OrchardCore.Liquid/Filters/UtcTimeZoneFilter.cs:19-50 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Liquid/Filters/LocalTimeZoneFilter.cs` and `src/OrchardCore.Modules/OrchardCore.Liquid/Filters/UtcTimeZoneFilter.cs` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (32 lines × 2) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:316— src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:316-347 | src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:243-274 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (28 lines × 2) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:205— src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:205-232 | src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:306-333 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:205` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (28 lines × 2) src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs:93— src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs:93-120 | src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs:129-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (26 lines × 2) src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:113— src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:113-138 | src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs:114-139 — before extracting anything, compare `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (26 lines × 2) src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:58— src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:58-83 | src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRewriteRuleSource.cs:58-83 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/UrlRedirectRuleSource.cs:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `metadata` to `UrlRedirectSourceMetadata` in one and `UrlRewriteSourceMetadata` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (27 lines × 2) src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:227— src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs:227-253 | src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs:226-252 — before extracting anything, compare `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs` and `src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/StyleTagHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (27 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/ContentPickerFieldDisplayDriver.cs:99— src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/ContentPickerFieldDisplayDriver.cs:99-126 | src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LocalizationSetContentPickerFieldDisplayDriver.cs:78-104 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `field` to `ContentPickerField` in one and `LocalizationSetContentPickerField` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (25–26 lines × 2) src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:147— src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:147-172 | src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:180-204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:147` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25–26 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/TermsFilterProvider.cs:23— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/TermsFilterProvider.cs:23-48 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/TermsQueryProvider.cs:17-41 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/TermsFilterProvider.cs:22` calls `AsObject` and `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/TermsQueryProvider.cs:15` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18 lines × 3) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:384— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:384-401 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:417-434 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:450-467 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs:384` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 3) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:424— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:424-441 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:457-474 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:522-539 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:424` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18–19 lines × 2) src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:177— src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:177-195 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:267-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:177` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `CreateSitemapIndexViewModel` in one and `EditSitemapIndexViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (18–19 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:114— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:114-131 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:172-190 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 4) REDACTED:460— REDACTED:460-473 | REDACTED:616-629 | REDACTED:651-664 | REDACTED:680-693 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 4) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:111— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:111-124 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:147-160 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:96-109 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:126-139 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 4) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:132— src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:132-140 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:418-426 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:551-559 | src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:745-753 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `viewModel` to `CreateTypeViewModel` in one and `CreatePartViewModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 4) src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:30— src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:30-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/CultureConditionDisplayDriver.cs:30-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/RoleConditionDisplayDriver.cs:30-38 | src/OrchardCore.Modules/OrchardCore.Rules/Drivers/UrlConditionDisplayDriver.cs:30-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:30` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `condition` to `ContentTypeCondition` in one and `CultureCondition` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13–14 lines × 3) src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:177— src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:177-190 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:49-61 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:136-148 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:177` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 3) src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:250— src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:250-263 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:207-219 | src/OrchardCore.Modules/OrchardCore.Layers/Controllers/LayerRuleController.cs:239-251 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs:250` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–13 lines × 2) src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:71— src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:71-82 | src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs:65-77 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs` and `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:71` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `treeNode` to `LinkAdminNode` in one and `PlaceholderAdminNode` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12–13 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/FuzzyFilterProvider.cs:32— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/FuzzyFilterProvider.cs:32-43 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/FuzzyQueryProvider.cs:23-35 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 3) src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:216— src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:216-220 | src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:263-267 | src/OrchardCore/OrchardCore.Autoroute.Core/Indexes/AutoroutePartIndex.cs:164-168 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:216` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 3) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44-48 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:231-235 | src/OrchardCore.Modules/OrchardCore.Users/Migrations.cs:242-246 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–10 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:31— src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:31-39 | src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:51-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:51` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:51` calls `Where`, `Any`, `Equals` and `src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceModifiedDateProvider.cs:31` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9–10 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:102— src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:102-111 | src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:126-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/RemotePublishing/MetaWeblogHandler.cs:102` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
P12 · CI test-gate honesty· Tests run only outside the merge gate · ×2
Tests run only outside the merge gate .github/workflows/integration_tests.yml:42— `dotnet test --project ./test/OrchardCore.Tests.Integration/OrchardCore.Tests.Integration.csproj -c Release --no-build` is the only CI command that runs 54 test(s) (e.g. AWSS3ResizedImageCacheTests.Get_NonExistentKey_ReturnsNull, AWSS3ResizedImageCacheTests.Set_ThenGetJPEG_RoundTripsContentAndContentType), and the workflow runs only on pushes to named branches or tags — after the merge — a failure there is found after the change merged, when the only remedy is a revert. Run them on pull requests (or in the merge queue).
Tests run only outside the merge gate .github/workflows/integration_tests.yml:63— `dotnet test --project ./test/OrchardCore.Tests.Integration/OrchardCore.Tests.Integration.csproj -c Release --no-build` is the only CI command that runs 54 test(s) (e.g. AWSS3ResizedImageCacheTests.Get_NonExistentKey_ReturnsNull, AWSS3ResizedImageCacheTests.Set_ThenGetJPEG_RoundTripsContentAndContentType), and the workflow runs only on pushes to named branches or tags — after the merge — a failure there is found after the change merged, when the only remedy is a revert. Run them on pull requests (or in the merge queue).
Duplicated block (28 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/webpack.config.js:6— src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Assets/webpack.config.js:6 · src/OrchardCore.Modules/OrchardCore.AuditTrail/Assets/webpack.config.js:5 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (28 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:88— src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:88 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:89 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (18 lines × 3 locations) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start-debug.js:4— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start-debug.js:4 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/start-debug.js:4 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/start-debug.js:4 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (18 lines × 3 locations) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start.js:4— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/start.js:4 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/start.js:4 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/start.js:4 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (14 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/html-field-trumbowyg-editor.ts:5— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/html-field-trumbowyg-editor.ts:5 · src/OrchardCore.Modules/OrchardCore.Html/Assets/ts/html-body-part-trumbowyg-editor.ts:5 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (14 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-settings.ts:7— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-settings.ts:7 · src/OrchardCore.Modules/OrchardCore.Title/Assets/ts/title-part-settings.ts:7 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Complex function (anonymous) (cyclomatic 14, cognitive 13) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/runs/runOverlay.ts:46— (anonymous) has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 14, cognitive 13) src/OrchardCore.Modules/OrchardCore.OpenApi/Assets/openapi-ui-auth/src/openapi-ui-auth.ts:181— (anonymous) has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Dead file (~146 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/noembed/trumbowyg.noembed.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~146 LoC) src/OrchardCore.Modules/OrchardCore.Templates/Assets/ts/template-preview.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~96 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/pasteembed/trumbowyg.pasteembed.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~96 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/template/trumbowyg.template.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Sync-over-async (deadlock risk) through `.Result` src/OrchardCore.Modules/OrchardCore.CustomSettings/Services/CustomSettingsService.cs:60— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/OrchardCore.Modules/OrchardCore.DataLocalization/Services/DataTranslationProvider.cs:23— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
X17 · Uncapped recursion over a caller-supplied document· Recursive walk over a caller-supplied document has no depth cap · ×2
Recursive walk over a caller-supplied document has no depth cap src/OrchardCore.Modules/OrchardCore.Taxonomies/Helper/TaxonomyOrchardHelperExtensions.cs:82— `FindTerm` is internal and takes the `JsonArray` from its caller, and it calls itself at line 82 with a child of the node it was given — and nowhere in `FindTerm` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the tree it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. A document nested past the stack that remains raises `StackOverflowException`, which .NET neither lets you catch nor unwinds: the process is torn down where it stands, taking every other request in flight with it, and no `try`/`catch` around `FindTerm` can intervene. Thread a depth argument through `FindTerm` and reject the document past a fixed maximum, or rewrite the descent with an explicit stack.
Recursive walk over a caller-supplied document has no depth cap src/OrchardCore.Modules/OrchardCore.Taxonomies/Helper/TaxonomyOrchardHelperExtensions.cs:109— `FindTermHierarchy` is internal and takes the `JsonArray` from its caller, and it calls itself at line 109 with a child of the node it was given — and nowhere in `FindTermHierarchy` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the tree it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. A document nested past the stack that remains raises `StackOverflowException`, which .NET neither lets you catch nor unwinds: the process is torn down where it stands, taking every other request in flight with it, and no `try`/`catch` around `FindTermHierarchy` can intervene. Thread a depth argument through `FindTermHierarchy` and reject the document past a fixed maximum, or rewrite the descent with an explicit stack.
X18 · Disposal-pattern correctness· Owned disposable field is never released · ×2
Owned disposable field is never released src/OrchardCore/OrchardCore.Abstractions/Shell/Builders/ShellContext.cs:12— `ShellContext` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_semaphore` itself (line 12), which makes that instance its own. But `_semaphore` is named in none of the methods the disposal search covered: `Dispose` (line 325), `DisposeAsync` (line 331), `Close` (line 337), `CloseAsync` (line 354) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_semaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released src/OrchardCore/OrchardCore/Shell/ShellHost.cs:30— `ShellHost` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializingSemaphore` itself (line 30), which makes that instance its own. But `_initializingSemaphore` is named in none of the methods the disposal search covered: `Dispose` (line 536), `DisposeAsync` (line 544), `ListShellContexts` (line 313) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializingSemaphore?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×2
Disposable created and abandoned in the method that made it src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheTag.cs:109— `debugContent` is a `StringWriter`, which implements `IDisposable`, and it is created here (line 109). Every use of it in `WriteToAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var debugContent = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/OrchardCore/OrchardCore.FileStorage.AmazonS3/AwsFileStorage.cs:255— `transferUtility` is a `TransferUtility`, which implements `IDisposable`, and it is created here (line 255). Every use of it in `GetFileStreamAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var transferUtility = …;`), which releases it at the end of the scope on every path including a throw.
AC2 · Forms & labels· <fieldset> without a <legend> · ×1
<fieldset> without a <legend> src/OrchardCore.Modules/OrchardCore.Autoroute/Views/AutoroutePartSettings.Edit.cshtml:61— A fieldset groups related controls but has no <legend> to name the group. Add a <legend> as its first child — or, if the group already has a visible caption beside it (or the fieldset is there only to disable its subtree and carries no group box), point aria-labelledby at that caption's id instead, which names the group without rendering a second one.
meta-refresh timed redirect/refresh REDACTED:18— A timed meta-refresh moves users with no control or warning. Use a server redirect or a user-triggered action instead.
AC3 · Page structure· Heading level jumps from h1 to h3 · ×1
Heading level jumps from h1 to h3 src/OrchardCore.Modules/OrchardCore.Users/Views/TwoFactorAuthentication/LoginWithTwoFactorAuthentication.cshtml:19— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Low contrast colour pair in CSS (2.8:1) src/docs/assets/css/code-tabs.css:18— `.md-fenced-code-tabs label` sets color: #fff on background-color: #999 — 2.8:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (3.6:1) src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/bootstrap-oc.css:222— `ul.pager li a:hover` sets color: #0085A1 on background-color: #e9ecef — 3.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (3.1:1) src/OrchardCore.Themes/TheBlogTheme/wwwroot/css/styles.css:5107— `.list-group-item-warning.list-group-item-action:hover, .list-group-item-warning.list-group-item-action:focus` sets color: #997404 on background-color: #e6dbb9 — 3.1:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (1.6:1) src/OrchardCore.Themes/TheAgencyTheme/wwwroot/css/styles.css:3463— `.dropdown-item.active, .dropdown-item:active` sets color: #fff on background-color: #ffc800 — 1.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (1.7:1) src/OrchardCore.Modules/OrchardCore.Spatial/wwwroot/Styles/leaflet.css:318— `.leaflet-bar a.leaflet-disabled` sets color: #bbb on background-color: #f4f4f4 — 1.7:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
Low contrast colour pair in CSS (2.2:1) src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Styles/media-field2.css:1— `.mf-btn-primary` sets color: #fff on background-color: #7bc143 — 2.2:1, below the 4.5:1 WCAG AA minimum for normal text. This is a MINIFIED, build-generated sheet — editing the literal here is undone by the next vendor drop or rebuild, so override the rule in your own stylesheet (or fix it upstream / in the source the bundle is built from).
AC7 · A11y enforcement· Accessibility enforcement below the top rung · ×1
Accessibility enforcement below the top rung — No accessibility enforcement found — no a11y linter (eslint-plugin-vuejs-accessibility) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 1863 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
AX2 · Stateful singletons· Process-global static state · ×1
Process-global static state: TestContentElementDisplayDriver src/OrchardCore.Modules/OrchardCore.Demo/ContentElementDisplays/TestContentElementDisplayDriver.cs:9— `TestContentElementDisplayDriver` is registered per request (scoped/transient), so each caller expects its own instance — but it keeps mutable `static` state that every instance in the process shares, and mutates it outside any lock (s_creating, s_processing; e.g. `s_creating` at line 28). The per-request lifetime buys nothing here: the field outlives every request and concurrent requests race on it.
init (cyclomatic 131) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:306— init has cyclomatic complexity 131 (threshold 15). Most of this is not in the body itself: 4 of the 131 points are its own statements and the rest belongs to 77 function items inside it that branch (a function literal at line 685, a function literal at line 576, tableBuild, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
DefaultPluralRuleProvider.DefaultPluralRuleProvider.ctor (cyclomatic 70) src/OrchardCore/OrchardCore.Localization.Core/DefaultPluralRuleProvider.cs:14— DefaultPluralRuleProvider.DefaultPluralRuleProvider.ctor has cyclomatic complexity 70 (threshold 15). Most of this is not in the body itself: 1 of the 70 points is its own statement and the rest belongs to 20 function literals inside it that branch (lines 24, 33, 35, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UppyFileUpload.useFileUpload (cyclomatic 64) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:132— UppyFileUpload.useFileUpload has cyclomatic complexity 64 (threshold 15). Most of this is not in the body itself: 8 of the 64 points are its own statements and the rest belongs to 18 function literals inside it that branch (lines 454, 178, 301, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
list-management.getOptions (cyclomatic 57) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:84— list-management.getOptions has cyclomatic complexity 57 (threshold 15). Of this number, 56 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
DefaultContentsAdminListFilterProvider.Build (cyclomatic 50) src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:18— DefaultContentsAdminListFilterProvider.Build has cyclomatic complexity 50 (threshold 15). Most of this is not in the body itself: 1 of the 50 points is its own statement and the rest belongs to 18 function literals inside it that branch (lines 122, 237, 22, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AnchorTag.WriteToAsync (cyclomatic 48) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AnchorTag.cs:22— AnchorTag.WriteToAsync has cyclomatic complexity 48 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ScriptTag.WriteToAsync (cyclomatic 44) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:14— ScriptTag.WriteToAsync has cyclomatic complexity 44 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
OpenIdServerService.ValidateSettingsAsync (cyclomatic 43) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:95— OpenIdServerService.ValidateSettingsAsync has cyclomatic complexity 43 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentItemsFieldType.BuildExpressionsInternal (cyclomatic 43) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:268— ContentItemsFieldType.BuildExpressionsInternal has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DependencyOrdering.Order (cyclomatic 43) src/OrchardCore/OrchardCore/Extensions/DependencyOrdering.cs:7— DependencyOrdering.Order has cyclomatic complexity 43 (threshold 15). Of this number, 41 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SeoMetaSettingsHandler.GetContentItemAspectAsync (cyclomatic 42) src/OrchardCore.Modules/OrchardCore.Seo/Handlers/SeoMetaSettingsHandler.cs:37— SeoMetaSettingsHandler.GetContentItemAspectAsync has cyclomatic complexity 42 (threshold 15). Most of this is not in the body itself: 1 of the 42 points is its own statement and the rest belongs to one function literal inside it that branches (line 39). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
StyleTag.WriteToAsync (cyclomatic 41) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:14— StyleTag.WriteToAsync has cyclomatic complexity 41 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ResourceDefinition.GetTagBuilder (cyclomatic 40) src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/ResourceDefinition.cs:181— ResourceDefinition.GetTagBuilder has cyclomatic complexity 40 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TenantValidator.ValidateAsync (cyclomatic 39) src/OrchardCore.Modules/OrchardCore.Tenants/Services/TenantValidator.cs:44— TenantValidator.ValidateAsync has cyclomatic complexity 39 (threshold 15). Of this number, 37 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DataSourceStep.ExecuteAsync (cyclomatic 39) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:74— DataSourceStep.ExecuteAsync has cyclomatic complexity 39 (threshold 15). Of this number, 37 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WorkflowEditor.constructor (cyclomatic 39) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:22— WorkflowEditor.constructor has cyclomatic complexity 39 (threshold 15). Most of this is not in the body itself: 1 of the 39 points is its own statement and the rest belongs to 13 function literals inside it that branch (lines 65, 37, 94, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ContentAnchorTag.WriteToAsync (cyclomatic 37) src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:36— ContentAnchorTag.WriteToAsync has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataFilterPredicates.Build (cyclomatic 37) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:21— DataFilterPredicates.Build has cyclomatic complexity 37 (threshold 15). Of this number, 30 points are the body's own statements and 7 belong to 5 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
(anonymous) (cyclomatic 36) .scripts/assets-manager/build.mjs:382— (anonymous) has cyclomatic complexity 36 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
LuceneIndexManager.CreateLuceneDocument (cyclomatic 35) src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexManager.cs:254— LuceneIndexManager.CreateLuceneDocument has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DistributedShellHostedService.ExecuteAsync (cyclomatic 35) src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:68— DistributedShellHostedService.ExecuteAsync has cyclomatic complexity 35 (threshold 15). Of this number, 34 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
list-management.initializeSearch (cyclomatic 35) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:335— list-management.initializeSearch has cyclomatic complexity 35 (threshold 15). Most of this is not in the body itself: 7 of the 35 points are its own statements and the rest belongs to 6 function items inside it that branch (update, navigateToSearchAction, a function literal at line 437, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
OpenIdApplicationExtensions.UpdateDescriptorFromSettings (cyclomatic 34) src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:35— OpenIdApplicationExtensions.UpdateDescriptorFromSettings has cyclomatic complexity 34 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TenantApiController.Setup (cyclomatic 33) src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:340— TenantApiController.Setup has cyclomatic complexity 33 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentItemConverter.Read (cyclomatic 33) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemConverter.cs:33— ContentItemConverter.Read has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicContentTypeBuilder.BuildInternal (cyclomatic 32) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/DynamicContentTypeBuilder.cs:37— DynamicContentTypeBuilder.BuildInternal has cyclomatic complexity 32 (threshold 15). Of this number, 31 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AzureAISearchIndexSettingsMigrations.UpdateFrom1 (cyclomatic 31) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:47— AzureAISearchIndexSettingsMigrations.UpdateFrom1 has cyclomatic complexity 31 (threshold 15). Most of this is not in the body itself: 2 of the 31 points are its own statements and the rest belongs to one function literal inside it that branches (line 56). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
PagerShapes.Pager_Links (cyclomatic 31) src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:146— PagerShapes.Pager_Links has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ScriptBlock.WriteToAsync (cyclomatic 31) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:16— ScriptBlock.WriteToAsync has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SeoContentDriver.DisplayAsync (cyclomatic 30) src/OrchardCore.Modules/OrchardCore.Seo/Drivers/SeoContentDriver.cs:44— SeoContentDriver.DisplayAsync has cyclomatic complexity 30 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
StyleBlock.WriteToAsync (cyclomatic 30) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:17— StyleBlock.WriteToAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataFilterPredicates.BuildExactConditions (cyclomatic 30) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:217— DataFilterPredicates.BuildExactConditions has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NamedIndexingService.ProcessRecordsAsync (cyclomatic 30) src/OrchardCore/OrchardCore.Indexing.Core/NamedIndexingService.cs:64— NamedIndexingService.ProcessRecordsAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AdminController.List (cyclomatic 29) REDACTED:67— AdminController.List has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
formVisibilityGroups.initialize (cyclomatic 29) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility.js:76— formVisibilityGroups.initialize has cyclomatic complexity 29 (threshold 15). Most of this is not in the body itself: 2 of the 29 points are its own statements and the rest belongs to 22 function items inside it that branch (data, a function literal at line 146, mounted, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
AdminController.IndexPost (cyclomatic 28) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:490— AdminController.IndexPost has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WorkflowCanvas.orientOutcomeLabels (cyclomatic 28) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-canvas.ts:148— WorkflowCanvas.orientOutcomeLabels has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Migrations.UpgradeAsync (cyclomatic 27) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:99— Migrations.UpgradeAsync has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 4 of the 27 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 152, 107, 231). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
OpenIdValidationService.ValidateSettingsAsync (cyclomatic 27) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdValidationService.cs:80— OpenIdValidationService.ValidateSettingsAsync has cyclomatic complexity 27 (threshold 15). Of this number, 24 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AzureAISearchDocumentIndexManager.CreateSearchDocument (cyclomatic 27) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:257— AzureAISearchDocumentIndexManager.CreateSearchDocument has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BaseShapeTagHelper.ProcessAsync (cyclomatic 27) src/OrchardCore/OrchardCore.DisplayManagement/TagHelpers/BaseShapeTagHelper.cs:56— BaseShapeTagHelper.ProcessAsync has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HttpWorkflowController.Invoke (cyclomatic 26) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Controllers/HttpWorkflowController.cs:73— HttpWorkflowController.Invoke has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataFilterPredicates.BuildCondition (cyclomatic 26) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:133— DataFilterPredicates.BuildCondition has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SetupService.SetupInternalAsync (cyclomatic 26) src/OrchardCore/OrchardCore.Setup.Core/Services/SetupService.cs:113— SetupService.SetupInternalAsync has cyclomatic complexity 26 (threshold 15). Of this number, 24 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ExternalAuthenticationsController.ExternalLoginCallback (cyclomatic 25) src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:94— ExternalAuthenticationsController.ExternalLoginCallback has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WorkflowManager.TriggerEventAsync (cyclomatic 25) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:135— WorkflowManager.TriggerEventAsync has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
data-pipelines-editors.updateFilterRow (cyclomatic 25) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:97— data-pipelines-editors.updateFilterRow has cyclomatic complexity 25 (threshold 15). Of this number, 20 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
list-management.initializeGroupSelection (cyclomatic 25) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:624— list-management.initializeGroupSelection has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 6 of the 25 points are its own statements and the rest belongs to 5 function items inside it that branch (updateGroup, a function literal at line 683, a function literal at line 699, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
PagerShapesTableProvider.DiscoverAsync (cyclomatic 24) src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:24— PagerShapesTableProvider.DiscoverAsync has cyclomatic complexity 24 (threshold 15). Most of this is not in the body itself: 1 of the 24 points is its own statement and the rest belongs to 9 function literals inside it that branch (lines 59, 70, 81, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SettingsStep.HandleAsync (cyclomatic 24) src/OrchardCore.Modules/OrchardCore.Settings/Recipes/SettingsStep.cs:21— SettingsStep.HandleAsync has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DefaultContentManager.GetAsync (cyclomatic 24) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:205— DefaultContentManager.GetAsync has cyclomatic complexity 24 (threshold 15). Of this number, 19 points are the body's own statements and 5 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExcelDataFileFormat.KindOf (cyclomatic 24) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:402— ExcelDataFileFormat.KindOf has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
IndexingMigrations.Create (cyclomatic 23) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:38— IndexingMigrations.Create has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 2 of the 23 points are its own statements and the rest belongs to one function literal inside it that branches (line 47). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
MediaCommandParser.Parse (cyclomatic 23) src/OrchardCore.Modules/OrchardCore.Media/Processing/MediaCommandParser.cs:24— MediaCommandParser.Parse has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SearchController.Search (cyclomatic 23) src/OrchardCore.Modules/OrchardCore.Search/Controllers/SearchController.cs:63— SearchController.Search has cyclomatic complexity 23 (threshold 15). Of this number, 21 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentDataValueDiscovery.TryGetDataType (cyclomatic 23) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs:211— ContentDataValueDiscovery.TryGetDataType has cyclomatic complexity 23 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
JArray.Merge (cyclomatic 23) src/OrchardCore/OrchardCore.Abstractions/Json/Nodes/JArray.cs:109— JArray.Merge has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExpressionCompiler.InferBinaryType (cyclomatic 23) src/OrchardCore/OrchardCore.DataSources.Core/Expressions/ExpressionCompiler.cs:185— ExpressionCompiler.InferBinaryType has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExcelDataFileFormat.ReadCell (cyclomatic 23) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:289— ExcelDataFileFormat.ReadCell has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShapePagerTag.WriteToAsync (cyclomatic 23) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapePagerTag.cs:24— ShapePagerTag.WriteToAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
(anonymous).validateRule (cyclomatic 23) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:258— (anonymous).validateRule has cyclomatic complexity 23 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
AdminController.ListPOST (cyclomatic 22) REDACTED:325— AdminController.ListPOST has cyclomatic complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContainerService.QueryContainedItemsAsync (cyclomatic 22) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:147— ContainerService.QueryContainedItemsAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentDataColumns.Build (cyclomatic 22) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataColumns.cs:30— ContentDataColumns.Build has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SendToWebApiStep.DescribeAsync (cyclomatic 22) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:90— SendToWebApiStep.DescribeAsync has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
RolesMigrations.MigrateSystemRoles (cyclomatic 22) src/OrchardCore.Modules/OrchardCore.Roles/Migrations/RolesMigrations.cs:45— RolesMigrations.MigrateSystemRoles has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 1 of the 22 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 47, 132). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DataJoin.MergeAsync (cyclomatic 22) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataJoin.cs:173— DataJoin.MergeAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShapeTag.WriteToAsync (cyclomatic 22) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapeTag.cs:14— ShapeTag.WriteToAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DefaultHtmlDisplay.ExecuteAsync (cyclomatic 22) src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs:48— DefaultHtmlDisplay.ExecuteAsync has cyclomatic complexity 22 (threshold 15). Of this number, 20 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShapeResult.ApplyImplementationAsync (cyclomatic 22) src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeResult.cs:349— ShapeResult.ApplyImplementationAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
init (cyclomatic 22) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/history/trumbowyg.history.js:17— init has cyclomatic complexity 22 (threshold 15). Most of this is not in the body itself: 2 of the 22 points are its own statements and the rest belongs to 9 function items inside it that branch (pushToHistory, arraysAreIdentical, toggleButtonState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
UpdateContentTask.ExecuteAsync (cyclomatic 21) src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/UpdateContentTask.cs:72— UpdateContentTask.ExecuteAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IndexingMigrations.Create (cyclomatic 21) src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:31— IndexingMigrations.Create has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 2 of the 21 points are its own statements and the rest belongs to one function literal inside it that branches (line 40). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SeoMetaPartHandler.GetContentItemAspectAsync (cyclomatic 21) src/OrchardCore.Modules/OrchardCore.Seo/Handlers/SeoMetaPartHandler.cs:37— SeoMetaPartHandler.GetContentItemAspectAsync has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to one function literal inside it that branches (line 39). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
DataPipelineAnalyzer.AnalyzeAsync (cyclomatic 21) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineAnalyzer.cs:39— DataPipelineAnalyzer.AnalyzeAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CsvParser.ReadRecordAsync (cyclomatic 21) src/OrchardCore/OrchardCore.DataSources.Core/Files/CsvDataFileFormat.cs:200— CsvParser.ReadRecordAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataFieldTransforms.Apply (cyclomatic 21) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFieldTransforms.cs:127— DataFieldTransforms.Apply has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
LiquidTagHelperActivator.LiquidTagHelperActivator.ctor (cyclomatic 21) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/LiquidTagHelperActivator.cs:31— LiquidTagHelperActivator.LiquidTagHelperActivator.ctor has cyclomatic complexity 21 (threshold 15). Of this number, 11 points are the body's own statements and 10 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExtensionManager.EnsureInitialized (cyclomatic 21) src/OrchardCore/OrchardCore/Extensions/ExtensionManager.cs:151— ExtensionManager.EnsureInitialized has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContainerService.SetInitialOrder (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:74— ContainerService.SetInitialOrder has cyclomatic complexity 20 (threshold 15). Of this number, 14 points are the body's own statements and 6 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MediaTusStartup.Configure (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:488— MediaTusStartup.Configure has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 5 function literals inside it that branch (lines 500, 597, 536, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AdminListBuilder.BuildAsync (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Admin/Services/AdminListBuilder.cs:35— AdminListBuilder.BuildAsync has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentDataValueDiscovery.Collect (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs:104— ContentDataValueDiscovery.Collect has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UserInfoController.Me (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/UserInfoController.cs:31— UserInfoController.Me has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AdminController.Index (cyclomatic 20) REDACTED:96— AdminController.Index has cyclomatic complexity 20 (threshold 15). Of this number, 14 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
WorkflowActionFilter.ProcessWorkflowsAsync (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Filters/WorkflowActionFilter.cs:108— WorkflowActionFilter.ProcessWorkflowsAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DataPipelineExecutor.RunAsync (cyclomatic 20) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineExecutor.cs:145— DataPipelineExecutor.RunAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ElasticsearchDocumentIndexManager.CreateElasticDocument (cyclomatic 20) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:228— ElasticsearchDocumentIndexManager.CreateElasticDocument has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RangeFilterProvider.CreateFilteredQuery (cyclomatic 20) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs:9— RangeFilterProvider.CreateFilteredQuery has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ModularBackgroundService.RunAsync (cyclomatic 20) src/OrchardCore/OrchardCore/Modules/ModularBackgroundService.cs:98— ModularBackgroundService.RunAsync has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 100, 159). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
content-type-picker.initializeContentTypePickerApplication (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-type-picker.ts:65— content-type-picker.initializeContentTypePickerApplication has cyclomatic complexity 20 (threshold 15). Of this number, 13 points are the body's own statements and 7 belong to 4 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
list-management.initializeSelection (cyclomatic 20) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:512— list-management.initializeSelection has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 5 of the 20 points are its own statements and the rest belongs to 5 function items inside it that branch (updateSelection, a function literal at line 580, submitBulkAction, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
SaveContentItemsStep.ExecuteAsync (cyclomatic 19) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Contents/SaveContentItemsStep.cs:89— SaveContentItemsStep.ExecuteAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SetupController.IndexPOST (cyclomatic 19) src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:85— SetupController.IndexPOST has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AdminController.IndexPOST (cyclomatic 19) REDACTED:220— AdminController.IndexPOST has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicJsonConverter.Read (cyclomatic 19) src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/DynamicJsonConverter.cs:9— DynamicJsonConverter.Read has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentPartAlternatesFactory.BuildAlternates (cyclomatic 19) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentPartAlternatesFactory.cs:50— ContentPartAlternatesFactory.BuildAlternates has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DbConnectionValidator.ValidateAsync (cyclomatic 19) src/OrchardCore/OrchardCore.Data.YesSql/DbConnectionValidator.cs:46— DbConnectionValidator.ValidateAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FlatPositionComparer.Compare (cyclomatic 19) src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs:54— FlatPositionComparer.Compare has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RangeQueryProvider.CreateQuery (cyclomatic 19) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/RangeQueryProvider.cs:9— RangeQueryProvider.CreateQuery has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
SecretStoreOperations.MoveAsync (cyclomatic 19) src/OrchardCore/OrchardCore.Secrets.Core/Services/SecretStoreOperations.cs:53— SecretStoreOperations.MoveAsync has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
CompositionStrategy.ComposeAsync (cyclomatic 19) src/OrchardCore/OrchardCore/Shell/Builders/CompositionStrategy.cs:26— CompositionStrategy.ComposeAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
flows.edit.document.addEventListener("DOMContentLoaded") (cyclomatic 19) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:22— flows.edit.document.addEventListener("DOMContentLoaded") has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 10 function literals inside it that branch (lines 119, 155, 23, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
miniprofiler.styleQueries (cyclomatic 19) src/OrchardCore.Modules/OrchardCore.MiniProfiler/Assets/ts/miniprofiler.ts:174— miniprofiler.styleQueries has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 2 of the 19 points are its own statements and the rest belongs to one function literal inside it that branches (line 190). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ShellFileVersionProvider.AddFileVersionToPath (cyclomatic 18) src/OrchardCore/OrchardCore.Mvc.Core/ShellFileVersionProvider.cs:37— ShellFileVersionProvider.AddFileVersionToPath has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AzureAISearchDefaultSettingsDisplayDriver.UpdateAsync (cyclomatic 18) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs:83— AzureAISearchDefaultSettingsDisplayDriver.UpdateAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RemoteMediaCacheBackgroundTask.DoWorkAsync (cyclomatic 18) src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs:41— RemoteMediaCacheBackgroundTask.DoWorkAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PlacementInfoResolver.ResolvePlacement (cyclomatic 18) src/OrchardCore.Modules/OrchardCore.Placements/Services/PlacementProvider.cs:53— PlacementInfoResolver.ResolvePlacement has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SendToWebApiStepDisplayDriver.UpdateAsync (cyclomatic 18) src/OrchardCore.Modules/OrchardCore.DataPipelines/Drivers/DestinationStepDisplayDrivers.cs:48— SendToWebApiStepDisplayDriver.UpdateAsync has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
AccessController.Authorize (cyclomatic 18) REDACTED:54— AccessController.Authorize has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
LinkTag.WriteToAsync (cyclomatic 18) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/LinkTag.cs:12— LinkTag.WriteToAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
JsonDynamicValue.Compare (cyclomatic 18) src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs:675— JsonDynamicValue.Compare has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentItemDisplayCoordinator.BuildDisplayAsync (cyclomatic 18) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:43— ContentItemDisplayCoordinator.BuildDisplayAsync has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentItemsFieldType.OrderBy (cyclomatic 18) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:419— ContentItemsFieldType.OrderBy has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DefaultContentManager.GetAsync (cyclomatic 18) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:102— DefaultContentManager.GetAsync has cyclomatic complexity 18 (threshold 15). Of this number, 14 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShapeAttributeBindingStrategy.BindParameter (cyclomatic 18) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:189— ShapeAttributeBindingStrategy.BindParameter has cyclomatic complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
RazorViewActionFilter.OnActionExecutionAsync (cyclomatic 18) src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorViewActionFilter.cs:51— RazorViewActionFilter.OnActionExecutionAsync has cyclomatic complexity 18 (threshold 15). Of this number, 12 points are the body's own statements and 6 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShapeResult.BuildAndAddShapeAsync (cyclomatic 18) src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeResult.cs:460— ShapeResult.BuildAndAddShapeAsync has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ModularBackgroundService.UpdateAsync (cyclomatic 18) src/OrchardCore/OrchardCore/Modules/ModularBackgroundService.cs:239— ModularBackgroundService.UpdateAsync has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 275, 245). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
OriginalFlatPositionComparer.Compare (cyclomatic 18) test/OrchardCore.Benchmarks/FlatPositionComparerBenchmark.cs:109— OriginalFlatPositionComparer.Compare has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AdminController.AddFieldToPOST (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:697— AdminController.AddFieldToPOST has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImageShortcodeProvider.EvaluateAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:42— ImageShortcodeProvider.EvaluateAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TermShapes.DiscoverAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:15— TermShapes.DiscoverAsync has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 30, 141). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AdminListShapeTableProvider.DiscoverAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Admin/AdminListShapeTableProvider.cs:37— AdminListShapeTableProvider.DiscoverAsync has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 93, 40, 145, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TenantSetupOptions.Validate (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.AutoSetup/Options/TenantSetupOptions.cs:99— TenantSetupOptions.Validate has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentDataValueDiscovery.Humanize (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs:61— ContentDataValueDiscovery.Humanize has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
SmtpSettingsDisplayDriver.UpdateAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:92— SmtpSettingsDisplayDriver.UpdateAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Startup.Configure (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.OpenApi/Startup.cs:76— Startup.Configure has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 2 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 100). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
OpenIdServerConfiguration.Configure (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs:48— OpenIdServerConfiguration.Configure has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. Note what this body is, though: it works in explicit hardware vector and instruction-set types. A kernel divided across a call boundary passes its vectors between the parts and depends on the runtime putting them back together, so the division can cost more than the complexity it removes. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
OpenIdClientService.ValidateSettingsAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdClientService.cs:43— OpenIdClientService.ValidateSettingsAsync has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
SetupTenantTask.ExecuteAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/SetupTenantTask.cs:110— SetupTenantTask.ExecuteAsync has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
WorkflowManager.ExecuteWorkflowAsync (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:393— WorkflowManager.ExecuteWorkflowAsync has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AzureAISearchDocumentIndexManager.GetNestedValue (cyclomatic 17) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:369— AzureAISearchDocumentIndexManager.GetNestedValue has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DefaultContentManager.ImportAsync (cyclomatic 17) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:673— DefaultContentManager.ImportAsync has cyclomatic complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentLinkTagHelper.ProcessAsync (cyclomatic 17) src/OrchardCore/OrchardCore.Contents.TagHelpers/ContentLinkTagHelper.cs:74— ContentLinkTagHelper.ProcessAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BulkRequestDescriptorExtensions.CreateElasticDocument (cyclomatic 17) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:19— BulkRequestDescriptorExtensions.CreateElasticDocument has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DefaultIndexProfileHandler.ValidatingAsync (cyclomatic 17) src/OrchardCore/OrchardCore.Indexing.Core/Handlers/DefaultIndexProfileHandler.cs:46— DefaultIndexProfileHandler.ValidatingAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IndexingContentHandler.IndexAsync (cyclomatic 17) src/OrchardCore/OrchardCore.Indexing.Core/Handlers/IndexingContentHandler.cs:102— IndexingContentHandler.IndexAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServiceProviderExtensions.CreateChildContainer (cyclomatic 17) src/OrchardCore/OrchardCore/Shell/Builders/Extensions/ServiceProviderExtensions.cs:15— ServiceProviderExtensions.CreateChildContainer has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellRemovalManager.RemoveAsync (cyclomatic 17) src/OrchardCore/OrchardCore/Shell/Removing/ShellRemovalManager.cs:31— ShellRemovalManager.RemoveAsync has cyclomatic complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellDescriptorFeaturesManager.UpdateFeaturesAsync (cyclomatic 17) src/OrchardCore/OrchardCore/Shell/ShellDescriptorFeaturesManager.cs:31— ShellDescriptorFeaturesManager.UpdateFeaturesAsync has cyclomatic complexity 17 (threshold 15). Of this number, 10 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
setup.init (cyclomatic 17) src/OrchardCore.Modules/OrchardCore.Setup/Assets/ts/setup.ts:109— setup.init has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 4 of the 17 points are its own statements and the rest belongs to 5 function items inside it that branch (evaluatePasswordRules, createPopover, updatePopoverRules, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
menu.initializeMenu (cyclomatic 17) src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts:308— menu.initializeMenu has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 6 of the 17 points are its own statements and the rest belongs to 9 function literals inside it that branch (lines 342, 387, 319, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
CreateEndpoint.HandleAsync (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:34— CreateEndpoint.HandleAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MediaFieldDisplayDriver.UpdateAsync (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Media/Drivers/MediaFieldDisplayDriver.cs:85— MediaFieldDisplayDriver.UpdateAsync has cyclomatic complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MenuShapes.DiscoverAsync (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:23— MenuShapes.DiscoverAsync has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 26, 109, 158). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SchemaService.GetSchemaAsync (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Services/SchemaService.cs:27— SchemaService.GetSchemaAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UploadToSftpStep.DescribeAsync (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.DataPipelines.Sftp/Steps/UploadToSftpStep.cs:58— UploadToSftpStep.DescribeAsync has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AdminController.IndexPost (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs:327— AdminController.IndexPost has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TypedContentTypeBuilder.Build (cyclomatic 16) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/TypedContentTypeBuilder.cs:26— TypedContentTypeBuilder.Build has cyclomatic complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DateTimeShapes.TimeSpan (cyclomatic 16) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/DateTimeShapes.cs:32— DateTimeShapes.TimeSpan has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShapeSerializer.Serialize (cyclomatic 16) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/ShapeSerializer.cs:28— ShapeSerializer.Serialize has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ElasticsearchClientFactory.Create (cyclomatic 16) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchClientFactory.cs:18— ElasticsearchClientFactory.Create has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
notificationManager.initialize (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Notifications/Assets/js/notification-manager.js:15— notificationManager.initialize has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 5 of the 16 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 72, 40, 65, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
(anonymous).processGroups (cyclomatic 16) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:135— (anonymous).processGroups has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 6 of the 16 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 143, 139, 172, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
No assertions: ScopesCanBeEnteredAndExited_Default_Succeeds test/OrchardCore.Tests/OrchardCore.Environment.Cache/CacheScopeManagerTests.cs:7— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
Repeated repair: src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts:36— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is main.readConfig at line 36), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix media picker and Autoroute/Sitemap toggles in editors added by the Flow and Bag parts (#20033)”; “Fix Media Picker rename dialog, real-time updates, and kebab menu hit targets (#19809)”; “Improve Media Gallery styles and fix UI issues (#19713)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 11:41:11 +02:00' --until='2026-10-23 11:41:11 +02:00' --full-history --no-merges -- src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D17 · Explicit Debt· BarePragmaDisable repeated 14 times in one file · ×1
BarePragmaDisable repeated 14 times in one file test/OrchardCore.Benchmarks/ArgumentsBenchmark.cs:25— The identical BarePragmaDisable (`#pragma warning disable CA1822`) appears 14 times in one file — one decision applied repeatedly (e.g. the same rule silenced on every overload of a fluent API), not 14 independent debts. Decide it once — at the type or project level, or by fixing the underlying pattern — rather than occurrence-by-occurrence. (Every occurrence still counts toward the score and metrics.)
init (cognitive 181) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:306— init has cognitive complexity 181 (threshold 15). Drivers by points: if/else 74 (98 pts), loops 28 (37 pts), ternaries 12 (25 pts), boolean chains 21 (nesting depth added 46). Most of this is not in the body itself: 3 of the 181 points are its own statements and the rest belongs to 77 function items inside it that branch (a function literal at line 685, a function literal at line 576, fn, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
UppyFileUpload.useFileUpload (cognitive 120) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:132— UppyFileUpload.useFileUpload has cognitive complexity 120 (threshold 15). Drivers by points: if/else 53 (96 pts), boolean chains 11, ternaries 5 (9 pts), error handling 3 (4 pts) (nesting depth added 48). Most of this is not in the body itself: 7 of the 120 points are its own statements and the rest belongs to 18 function literals inside it that branch (lines 178, 454, 301, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DefaultPluralRuleProvider.DefaultPluralRuleProvider.ctor (cognitive 105) src/OrchardCore/OrchardCore.Localization.Core/DefaultPluralRuleProvider.cs:14— DefaultPluralRuleProvider.DefaultPluralRuleProvider.ctor has cognitive complexity 105 (threshold 15). None of this is in the body itself: all 105 points belong to 20 function literals inside it that branch (lines 38, 37, 33, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DynamicContentTypeBuilder.BuildInternal (cognitive 100) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/DynamicContentTypeBuilder.cs:37— DynamicContentTypeBuilder.BuildInternal has cognitive complexity 100 (threshold 15). Of this number, 99 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SeoMetaSettingsHandler.GetContentItemAspectAsync (cognitive 87) src/OrchardCore.Modules/OrchardCore.Seo/Handlers/SeoMetaSettingsHandler.cs:37— SeoMetaSettingsHandler.GetContentItemAspectAsync has cognitive complexity 87 (threshold 15). None of this is in the body itself: all 87 points belong to one function literal inside it that branches (line 39). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
LuceneIndexManager.CreateLuceneDocument (cognitive 84) src/OrchardCore/OrchardCore.Lucene.Core/Services/LuceneIndexManager.cs:254— LuceneIndexManager.CreateLuceneDocument has cognitive complexity 84 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migrations.UpgradeAsync (cognitive 83) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:99— Migrations.UpgradeAsync has cognitive complexity 83 (threshold 15). Most of this is not in the body itself: 4 of the 83 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 152, 107, 231). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DistributedShellHostedService.ExecuteAsync (cognitive 81) src/OrchardCore/OrchardCore/Shell/Distributed/DistributedShellHostedService.cs:68— DistributedShellHostedService.ExecuteAsync has cognitive complexity 81 (threshold 15). Of this number, 80 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentAnchorTag.WriteToAsync (cognitive 79) src/OrchardCore.Modules/OrchardCore.Contents/Liquid/ContentAnchorTag.cs:36— ContentAnchorTag.WriteToAsync has cognitive complexity 79 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AdminController.IndexPost (cognitive 77) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:490— AdminController.IndexPost has cognitive complexity 77 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapePagerTag.WriteToAsync (cognitive 73) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapePagerTag.cs:24— ShapePagerTag.WriteToAsync has cognitive complexity 73 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DefaultContentsAdminListFilterProvider.Build (cognitive 71) src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListFilterProvider.cs:18— DefaultContentsAdminListFilterProvider.Build has cognitive complexity 71 (threshold 15). None of this is in the body itself: all 71 points belong to 18 function literals inside it that branch (lines 122, 237, 22, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DependencyOrdering.Order (cognitive 71) src/OrchardCore/OrchardCore/Extensions/DependencyOrdering.cs:7— DependencyOrdering.Order has cognitive complexity 71 (threshold 15). Of this number, 69 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemsFieldType.BuildExpressionsInternal (cognitive 67) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:268— ContentItemsFieldType.BuildExpressionsInternal has cognitive complexity 67 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NamedIndexingService.ProcessRecordsAsync (cognitive 63) src/OrchardCore/OrchardCore.Indexing.Core/NamedIndexingService.cs:64— NamedIndexingService.ProcessRecordsAsync has cognitive complexity 63 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContainerService.QueryContainedItemsAsync (cognitive 60) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:147— ContainerService.QueryContainedItemsAsync has cognitive complexity 60 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AzureAISearchIndexSettingsMigrations.UpdateFrom1 (cognitive 59) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:47— AzureAISearchIndexSettingsMigrations.UpdateFrom1 has cognitive complexity 59 (threshold 15). Most of this is not in the body itself: 1 of the 59 points is its own statement and the rest belongs to one function literal inside it that branches (line 56). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
HttpWorkflowController.Invoke (cognitive 57) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Controllers/HttpWorkflowController.cs:73— HttpWorkflowController.Invoke has cognitive complexity 57 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
list-management.getOptions (cognitive 55) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:84— list-management.getOptions has cognitive complexity 55 (threshold 15). Drivers by points: boolean chains 46, if/else 7 (9 pts) (nesting depth added 2). Of this number, 54 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
DataSourceStep.ExecuteAsync (cognitive 53) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:74— DataSourceStep.ExecuteAsync has cognitive complexity 53 (threshold 15). Of this number, 51 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureAISearchDocumentIndexManager.CreateSearchDocument (cognitive 52) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:257— AzureAISearchDocumentIndexManager.CreateSearchDocument has cognitive complexity 52 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PagerShapes.Pager_Links (cognitive 51) src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:146— PagerShapes.Pager_Links has cognitive complexity 51 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ScriptBlock.WriteToAsync (cognitive 51) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:16— ScriptBlock.WriteToAsync has cognitive complexity 51 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
WorkflowActionFilter.ProcessWorkflowsAsync (cognitive 51) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Filters/WorkflowActionFilter.cs:108— WorkflowActionFilter.ProcessWorkflowsAsync has cognitive complexity 51 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
WorkflowEditor.constructor (cognitive 51) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:22— WorkflowEditor.constructor has cognitive complexity 51 (threshold 15). Drivers by points: if/else 28 (42 pts), boolean chains 7, loops 2 (nesting depth added 14). None of this is in the body itself: all 51 points belong to 13 function literals inside it that branch (lines 65, 123, 37, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DefaultContentManager.ImportAsync (cognitive 50) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:673— DefaultContentManager.ImportAsync has cognitive complexity 50 (threshold 15). Of this number, 48 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OpenIdApplicationExtensions.UpdateDescriptorFromSettings (cognitive 49) src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:35— OpenIdApplicationExtensions.UpdateDescriptorFromSettings has cognitive complexity 49 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
StyleBlock.WriteToAsync (cognitive 49) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:17— StyleBlock.WriteToAsync has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExternalAuthenticationsController.ExternalLoginCallback (cognitive 49) src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:94— ExternalAuthenticationsController.ExternalLoginCallback has cognitive complexity 49 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentPartAlternatesFactory.BuildAlternates (cognitive 49) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentPartAlternatesFactory.cs:50— ContentPartAlternatesFactory.BuildAlternates has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExtensionManager.EnsureInitialized (cognitive 49) src/OrchardCore/OrchardCore/Extensions/ExtensionManager.cs:151— ExtensionManager.EnsureInitialized has cognitive complexity 49 (threshold 15). Of this number, 48 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JArray.Merge (cognitive 47) src/OrchardCore/OrchardCore.Abstractions/Json/Nodes/JArray.cs:109— JArray.Merge has cognitive complexity 47 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.ListPOST (cognitive 46) REDACTED:325— AdminController.ListPOST has cognitive complexity 46 (threshold 15). Of this number, 45 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ServiceProviderExtensions.CreateChildContainer (cognitive 46) src/OrchardCore/OrchardCore/Shell/Builders/Extensions/ServiceProviderExtensions.cs:15— ServiceProviderExtensions.CreateChildContainer has cognitive complexity 46 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentItemConverter.Read (cognitive 45) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemConverter.cs:33— ContentItemConverter.Read has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataJoin.MergeAsync (cognitive 45) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataJoin.cs:173— DataJoin.MergeAsync has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AnchorTag.WriteToAsync (cognitive 45) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/AnchorTag.cs:22— AnchorTag.WriteToAsync has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RolesMigrations.MigrateSystemRoles (cognitive 44) src/OrchardCore.Modules/OrchardCore.Roles/Migrations/RolesMigrations.cs:45— RolesMigrations.MigrateSystemRoles has cognitive complexity 44 (threshold 15). None of this is in the body itself: all 44 points belong to 2 function literals inside it that branch (lines 47, 132). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
IndexingMigrations.Create (cognitive 43) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:38— IndexingMigrations.Create has cognitive complexity 43 (threshold 15). Most of this is not in the body itself: 1 of the 43 points is its own statement and the rest belongs to one function literal inside it that branches (line 47). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
TenantValidator.ValidateAsync (cognitive 43) src/OrchardCore.Modules/OrchardCore.Tenants/Services/TenantValidator.cs:44— TenantValidator.ValidateAsync has cognitive complexity 43 (threshold 15). Of this number, 42 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DataPipelineExecutor.RunAsync (cognitive 42) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineExecutor.cs:145— DataPipelineExecutor.RunAsync has cognitive complexity 42 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.List (cognitive 41) REDACTED:67— AdminController.List has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneRecipeEventHandler.RecipeStepExecutingAsync (cognitive 41) src/OrchardCore.Modules/OrchardCore.ContentTypes/Recipes/LuceneRecipeEventHandler.cs:23— LuceneRecipeEventHandler.RecipeStepExecutingAsync has cognitive complexity 41 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
OpenIdServerService.ValidateSettingsAsync (cognitive 41) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:95— OpenIdServerService.ValidateSettingsAsync has cognitive complexity 41 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
OpenIdValidationService.ValidateSettingsAsync (cognitive 41) src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdValidationService.cs:80— OpenIdValidationService.ValidateSettingsAsync has cognitive complexity 41 (threshold 15). Of this number, 30 points are the body's own statements and 11 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ResourceDefinition.GetTagBuilder (cognitive 41) src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/ResourceDefinition.cs:181— ResourceDefinition.GetTagBuilder has cognitive complexity 41 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
WorkflowCanvas.orientOutcomeLabels (cognitive 41) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-canvas.ts:148— WorkflowCanvas.orientOutcomeLabels has cognitive complexity 41 (threshold 15). Drivers by points: if/else 11 (22 pts), ternaries 6 (12 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Startup.Configure (cognitive 40) src/OrchardCore.Modules/OrchardCore.OpenApi/Startup.cs:76— Startup.Configure has cognitive complexity 40 (threshold 15). Most of this is not in the body itself: 1 of the 40 points is its own statement and the rest belongs to one function literal inside it that branches (line 100). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
IndexingMigrations.Create (cognitive 39) src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:31— IndexingMigrations.Create has cognitive complexity 39 (threshold 15). Most of this is not in the body itself: 1 of the 39 points is its own statement and the rest belongs to one function literal inside it that branches (line 40). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ContentDataColumns.Build (cognitive 39) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataColumns.cs:30— ContentDataColumns.Build has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WorkflowManager.TriggerEventAsync (cognitive 39) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:135— WorkflowManager.TriggerEventAsync has cognitive complexity 39 (threshold 15). Of this number, 37 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemDisplayCoordinator.BuildDisplayAsync (cognitive 39) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:43— ContentItemDisplayCoordinator.BuildDisplayAsync has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountController.LoginPOST (cognitive 38) REDACTED:111— AccountController.LoginPOST has cognitive complexity 38 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellViewFeatureProvider.PopulateFeatureInternal (cognitive 37) src/OrchardCore/OrchardCore.Mvc.Core/ShellViewFeatureProvider.cs:81— ShellViewFeatureProvider.PopulateFeatureInternal has cognitive complexity 37 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
TypedContentTypeBuilder.Build (cognitive 37) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/TypedContentTypeBuilder.cs:26— TypedContentTypeBuilder.Build has cognitive complexity 37 (threshold 15). Of this number, 35 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CsvParser.ReadRecordAsync (cognitive 37) src/OrchardCore/OrchardCore.DataSources.Core/Files/CsvDataFileFormat.cs:200— CsvParser.ReadRecordAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataAggregator.AggregateAsync (cognitive 37) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataAggregator.cs:35— DataAggregator.AggregateAsync has cognitive complexity 37 (threshold 15). Of this number, 33 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LiquidTagHelperActivator.LiquidTagHelperActivator.ctor (cognitive 37) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/LiquidTagHelperActivator.cs:31— LiquidTagHelperActivator.LiquidTagHelperActivator.ctor has cognitive complexity 37 (threshold 15). Of this number, 21 points are the body's own statements and 16 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZoneShapes.ColumnGrouping (cognitive 37) src/OrchardCore/OrchardCore.DisplayManagement/Zones/ZoneShapes.cs:204— ZoneShapes.ColumnGrouping has cognitive complexity 37 (threshold 15). Of this number, 36 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CreateOrUpdateIndexProfileStep.HandleAsync (cognitive 37) src/OrchardCore/OrchardCore.Indexing.Core/Recipes/CreateOrUpdateIndexProfileStep.cs:34— CreateOrUpdateIndexProfileStep.HandleAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RecipeExecutor.ExecuteAsync (cognitive 37) src/OrchardCore/OrchardCore.Recipes.Core/Services/RecipeExecutor.cs:40— RecipeExecutor.ExecuteAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModularBackgroundService.RunAsync (cognitive 37) src/OrchardCore/OrchardCore/Modules/ModularBackgroundService.cs:98— ModularBackgroundService.RunAsync has cognitive complexity 37 (threshold 15). None of this is in the body itself: all 37 points belong to 2 function literals inside it that branch (lines 100, 159). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
CompositionStrategy.ComposeAsync (cognitive 37) src/OrchardCore/OrchardCore/Shell/Builders/CompositionStrategy.cs:26— CompositionStrategy.ComposeAsync has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TenantApiController.Setup (cognitive 36) src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:340— TenantApiController.Setup has cognitive complexity 36 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DefaultContentManager.GetAsync (cognitive 36) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:205— DefaultContentManager.GetAsync has cognitive complexity 36 (threshold 15). Of this number, 32 points are the body's own statements and 4 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Assembler.run (cognitive 36) .agents/skills/orchardcore-video-producer/scripts/assemble.py:139— Assembler.run has cognitive complexity 36 (threshold 15). Drivers by points: loops 6 (13 pts), ternaries 3 (12 pts), if/else 5 (11 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AutoSetupMiddleware.InvokeAsync (cognitive 35) src/OrchardCore.Modules/OrchardCore.AutoSetup/AutoSetupMiddleware.cs:93— AutoSetupMiddleware.InvokeAsync has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ScriptTag.WriteToAsync (cognitive 35) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:14— ScriptTag.WriteToAsync has cognitive complexity 35 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
WorkflowManager.ExecuteWorkflowAsync (cognitive 35) src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs:393— WorkflowManager.ExecuteWorkflowAsync has cognitive complexity 35 (threshold 15). Of this number, 34 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeQueryResourceBuilder.Build (cognitive 35) src/OrchardCore/OrchardCore.Apis.GraphQL.Client/ContentTypeQueryResourceBuilder.cs:103— ContentTypeQueryResourceBuilder.Build has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseShapeTagHelper.ProcessAsync (cognitive 35) src/OrchardCore/OrchardCore.DisplayManagement/TagHelpers/BaseShapeTagHelper.cs:56— BaseShapeTagHelper.ProcessAsync has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
notificationManager.initialize (cognitive 35) src/OrchardCore.Modules/OrchardCore.Notifications/Assets/js/notification-manager.js:15— notificationManager.initialize has cognitive complexity 35 (threshold 15). Drivers by points: if/else 15 (32 pts), error handling 1 (2 pts), loops 1 (nesting depth added 18). Most of this is not in the body itself: 5 of the 35 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 72, 40, 65, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ContainerService.SetInitialOrder (cognitive 34) src/OrchardCore.Modules/OrchardCore.Lists/Services/ContainerService.cs:74— ContainerService.SetInitialOrder has cognitive complexity 34 (threshold 15). Of this number, 28 points are the body's own statements and 6 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserInfoController.Me (cognitive 33) src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/UserInfoController.cs:31— UserInfoController.Me has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemsFieldType.OrderBy (cognitive 33) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:419— ContentItemsFieldType.OrderBy has cognitive complexity 33 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
IndexingContentHandler.IndexAsync (cognitive 33) src/OrchardCore/OrchardCore.Indexing.Core/Handlers/IndexingContentHandler.cs:102— IndexingContentHandler.IndexAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 33) .scripts/assets-manager/min.mjs:42— (anonymous) has cognitive complexity 33 (threshold 15). Drivers by points: if/else 15 (28 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 16). Most of this is not in the body itself: 5 of the 33 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 82, 67, 95, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
processSources (cognitive 33) .scripts/assets-manager/copy.mjs:39— processSources has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (24 pts), error handling 1 (4 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementInfoResolver.ResolvePlacement (cognitive 32) src/OrchardCore.Modules/OrchardCore.Placements/Services/PlacementProvider.cs:53— PlacementInfoResolver.ResolvePlacement has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 32) .scripts/assets-manager/build.mjs:382— (anonymous) has cognitive complexity 32 (threshold 15). Drivers by points: if/else 8 (16 pts), other 8, boolean chains 7, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
AdminController.GetTranslatableStringsAsync (cognitive 31) src/OrchardCore.Modules/OrchardCore.DataLocalization/Controllers/AdminController.cs:242— AdminController.GetTranslatableStringsAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.ListPOST (cognitive 31) src/OrchardCore.Modules/OrchardCore.Notifications/Controllers/AdminController.cs:162— AdminController.ListPOST has cognitive complexity 31 (threshold 15). Of this number, 30 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StyleTag.WriteToAsync (cognitive 31) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:14— StyleTag.WriteToAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShellRemovalManager.RemoveAsync (cognitive 31) src/OrchardCore/OrchardCore/Shell/Removing/ShellRemovalManager.cs:31— ShellRemovalManager.RemoveAsync has cognitive complexity 31 (threshold 15). Of this number, 23 points are the body's own statements and 8 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UpdateContentTask.ExecuteAsync (cognitive 30) src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/UpdateContentTask.cs:72— UpdateContentTask.ExecuteAsync has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SeoContentDriver.DisplayAsync (cognitive 30) src/OrchardCore.Modules/OrchardCore.Seo/Drivers/SeoContentDriver.cs:44— SeoContentDriver.DisplayAsync has cognitive complexity 30 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentLinkTagHelper.ProcessAsync (cognitive 30) src/OrchardCore/OrchardCore.Contents.TagHelpers/ContentLinkTagHelper.cs:74— ContentLinkTagHelper.ProcessAsync has cognitive complexity 30 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DataFilterPredicates.BuildExactConditions (cognitive 30) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:217— DataFilterPredicates.BuildExactConditions has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
formVisibilityGroups.initialize (cognitive 30) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility.js:76— formVisibilityGroups.initialize has cognitive complexity 30 (threshold 15). Drivers by points: if/else 15 (17 pts), boolean chains 13 (nesting depth added 2). Most of this is not in the body itself: 1 of the 30 points is its own statement and the rest belongs to 22 function items inside it that branch (a function literal at line 146, data, mounted, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
ContentActivity.OnWorkflowRestartingAsync (cognitive 29) src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/ContentActivity.cs:74— ContentActivity.OnWorkflowRestartingAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageShortcodeProvider.EvaluateAsync (cognitive 29) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:42— ImageShortcodeProvider.EvaluateAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SearchController.Search (cognitive 29) src/OrchardCore.Modules/OrchardCore.Search/Controllers/SearchController.cs:63— SearchController.Search has cognitive complexity 29 (threshold 15). Of this number, 27 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DataPipelineAnalyzer.AnalyzeAsync (cognitive 29) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineAnalyzer.cs:39— DataPipelineAnalyzer.AnalyzeAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RazorViewActionFilter.OnActionExecutionAsync (cognitive 29) src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorViewActionFilter.cs:51— RazorViewActionFilter.OnActionExecutionAsync has cognitive complexity 29 (threshold 15). Of this number, 20 points are the body's own statements and 9 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
list-management.initializeSelection (cognitive 29) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:512— list-management.initializeSelection has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (17 pts), loops 5 (8 pts), boolean chains 4 (nesting depth added 9). Most of this is not in the body itself: 4 of the 29 points are its own statements and the rest belongs to 5 function items inside it that branch (updateSelection, a function literal at line 580, a function literal at line 606, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
runSass (cognitive 29) .scripts/assets-manager/sass.mjs:112— runSass has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (29 pts) (nesting depth added 15). None of this is in the body itself: all 29 points belong to 3 function literals inside it that branch (lines 153, 113, 138). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
CreateEndpoint.HandleAsync (cognitive 28) src/OrchardCore.Modules/OrchardCore.Contents/Endpoints/Api/CreateEndpoint.cs:34— CreateEndpoint.HandleAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RolesStep.HandleAsync (cognitive 28) src/OrchardCore.Modules/OrchardCore.Roles/Recipes/RolesStep.cs:27— RolesStep.HandleAsync has cognitive complexity 28 (threshold 15). Of this number, 26 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.IndexPOST (cognitive 28) REDACTED:220— AdminController.IndexPOST has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeResult.ApplyImplementationAsync (cognitive 28) src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeResult.cs:349— ShapeResult.ApplyImplementationAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FlatPositionComparer.Compare (cognitive 28) src/OrchardCore/OrchardCore.DisplayManagement/Zones/FlatPositionComparer.cs:54— FlatPositionComparer.Compare has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElasticsearchDocumentIndexManager.CreateElasticDocument (cognitive 28) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:228— ElasticsearchDocumentIndexManager.CreateElasticDocument has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellDescriptorFeaturesManager.UpdateFeaturesAsync (cognitive 28) src/OrchardCore/OrchardCore/Shell/ShellDescriptorFeaturesManager.cs:31— ShellDescriptorFeaturesManager.UpdateFeaturesAsync has cognitive complexity 28 (threshold 15). Most of this is not in the body itself: 12 of the 28 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 116, 54). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
list-management.initializeGroupSelection (cognitive 28) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:624— list-management.initializeGroupSelection has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (10 pts), boolean chains 8, loops 5 (7 pts), ternaries 3 (nesting depth added 5). Most of this is not in the body itself: 4 of the 28 points are its own statements and the rest belongs to 5 function items inside it that branch (updateGroup, a function literal at line 683, a function literal at line 699, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
(anonymous).processGroups (cognitive 28) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:135— (anonymous).processGroups has cognitive complexity 28 (threshold 15). Drivers by points: if/else 15 (21 pts), ternaries 2 (5 pts), boolean chains 2 (nesting depth added 9). Most of this is not in the body itself: 12 of the 28 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 143, 139, 172, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
LayerFilter.OnResultExecutionAsync (cognitive 27) src/OrchardCore.Modules/OrchardCore.Layers/Services/LayerFilter.cs:62— LayerFilter.OnResultExecutionAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentDataValueDiscovery.Collect (cognitive 27) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs:104— ContentDataValueDiscovery.Collect has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SaveContentItemsStep.ExecuteAsync (cognitive 27) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Contents/SaveContentItemsStep.cs:89— SaveContentItemsStep.ExecuteAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserInformationDisplayDriver.UpdateAsync (cognitive 27) src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserInformationDisplayDriver.cs:75— UserInformationDisplayDriver.UpdateAsync has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UserRoleDisplayDriver.UpdateAsync (cognitive 27) src/OrchardCore.Modules/OrchardCore.Users/Drivers/UserRoleDisplayDriver.cs:85— UserRoleDisplayDriver.UpdateAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultHtmlDisplay.ExecuteAsync (cognitive 27) src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs:48— DefaultHtmlDisplay.ExecuteAsync has cognitive complexity 27 (threshold 15). Of this number, 24 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
BulkRequestDescriptorExtensions.CreateElasticDocument (cognitive 27) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:19— BulkRequestDescriptorExtensions.CreateElasticDocument has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlobFileStore.GetDirectoryContentFlatAsync (cognitive 27) src/OrchardCore/OrchardCore.FileStorage.AzureBlob/BlobFileStore.cs:333— BlobFileStore.GetDirectoryContentFlatAsync has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
liquid-intellisense.getLiquidContextInfo (cognitive 27) src/OrchardCore.Modules/OrchardCore.Liquid/Assets/monaco/liquid-intellisense.ts:91— liquid-intellisense.getLiquidContextInfo has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (21 pts), ternaries 2 (4 pts), boolean chains 2 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
clean (cognitive 27) .scripts/assets-manager/clean.mjs:6— clean has cognitive complexity 27 (threshold 15). Drivers by points: error handling 5 (13 pts), if/else 5 (12 pts), boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinkFieldDisplayDriver.UpdateAsync (cognitive 26) src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LinkFieldDisplayDriver.cs:68— LinkFieldDisplayDriver.UpdateAsync has cognitive complexity 26 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AdminController.IndexPost (cognitive 26) src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/AdminController.cs:327— AdminController.IndexPost has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExternalAuthenticationsController.RegisterExternalLogin (cognitive 26) src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:279— ExternalAuthenticationsController.RegisterExternalLogin has cognitive complexity 26 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NavigationManager.Merge (cognitive 26) src/OrchardCore/OrchardCore.Navigation.Core/NavigationManager.cs:74— NavigationManager.Merge has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migrations.UpdateFrom3Async (cognitive 25) src/OrchardCore.Modules/OrchardCore.Html/Migrations.cs:53— Migrations.UpdateFrom3Async has cognitive complexity 25 (threshold 15). Of this number, 15 points are the body's own statements and 10 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AssetUrlShortcodeProvider.EvaluateAsync (cognitive 25) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:26— AssetUrlShortcodeProvider.EvaluateAsync has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SeoMetaPartHandler.GetContentItemAspectAsync (cognitive 25) src/OrchardCore.Modules/OrchardCore.Seo/Handlers/SeoMetaPartHandler.cs:37— SeoMetaPartHandler.GetContentItemAspectAsync has cognitive complexity 25 (threshold 15). None of this is in the body itself: all 25 points belong to one function literal inside it that branches (line 39). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
HttpMethodsProvider.DeserializeRequestDataAsync (cognitive 25) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Scripting/HttpMethodsProvider.cs:127— HttpMethodsProvider.DeserializeRequestDataAsync has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DynamicJsonConverter.Read (cognitive 25) src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/DynamicJsonConverter.cs:9— DynamicJsonConverter.Read has cognitive complexity 25 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ConfigurationExtensions.ToJsonNode (cognitive 25) src/OrchardCore/OrchardCore.Abstractions/Shell/Configuration/Internal/ConfigurationExtensions.cs:20— ConfigurationExtensions.ToJsonNode has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataFilterPredicates.Build (cognitive 25) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:21— DataFilterPredicates.Build has cognitive complexity 25 (threshold 15). Of this number, 20 points are the body's own statements and 5 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StringValuesValue.Equals (cognitive 25) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/StringValuesValue.cs:25— StringValuesValue.Equals has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultIndexProfileHandler.ValidatingAsync (cognitive 25) src/OrchardCore/OrchardCore.Indexing.Core/Handlers/DefaultIndexProfileHandler.cs:46— DefaultIndexProfileHandler.ValidatingAsync has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OriginalFlatPositionComparer.Compare (cognitive 25) test/OrchardCore.Benchmarks/FlatPositionComparerBenchmark.cs:109— OriginalFlatPositionComparer.Compare has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LayerStep.HandleAsync (cognitive 24) src/OrchardCore.Modules/OrchardCore.Layers/Recipes/LayerStep.cs:42— LayerStep.HandleAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneIndexStep.HandleAsync (cognitive 24) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexStep.cs:30— LuceneIndexStep.HandleAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaFieldIndexHandler.BuildIndexAsync (cognitive 24) src/OrchardCore.Modules/OrchardCore.Media/Indexing/MediaFieldIndexHandler.cs:29— MediaFieldIndexHandler.BuildIndexAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpSettingsDisplayDriver.UpdateAsync (cognitive 24) src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSettingsDisplayDriver.cs:92— SmtpSettingsDisplayDriver.UpdateAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelDataFileFormat.ReadCell (cognitive 24) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:289— ExcelDataFileFormat.ReadCell has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
DataJoin.HashJoinAsync (cognitive 24) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataJoin.cs:72— DataJoin.HashJoinAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Shape.TrySetMemberImpl (cognitive 24) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs:202— Shape.TrySetMemberImpl has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElasticsearchIndexStep.HandleAsync (cognitive 24) src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexStep.cs:32— ElasticsearchIndexStep.HandleAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneIndexStore.WriteAsync (cognitive 24) src/OrchardCore/OrchardCore.Lucene.Core/LuceneIndexStore.cs:134— LuceneIndexStore.WriteAsync has cognitive complexity 24 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ModularBackgroundService.UpdateAsync (cognitive 24) src/OrchardCore/OrchardCore/Modules/ModularBackgroundService.cs:239— ModularBackgroundService.UpdateAsync has cognitive complexity 24 (threshold 15). None of this is in the body itself: all 24 points belong to 2 function literals inside it that branch (lines 275, 245). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
ModuleProjectRazorFileProvider.Watch (cognitive 23) src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:170— ModuleProjectRazorFileProvider.Watch has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AutoroutePartHandler.ValidateContainedContentItemRoutesAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs:287— AutoroutePartHandler.ValidateContainedContentItemRoutesAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContainedPartHandler.GetContainedContentTypesAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Lists/Handlers/ContainedPartHandler.cs:61— ContainedPartHandler.GetContainedContentTypesAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaFieldDisplayDriver.UpdateAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Media/Drivers/MediaFieldDisplayDriver.cs:85— MediaFieldDisplayDriver.UpdateAsync has cognitive complexity 23 (threshold 15). Of this number, 20 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migrations.UpdateFrom1 (cognitive 23) src/OrchardCore.Modules/OrchardCore.Title/Migrations.cs:42— Migrations.UpdateFrom1 has cognitive complexity 23 (threshold 15). Of this number, 13 points are the body's own statements and 10 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UsersDataSource.ReadAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Users/UsersDataSource.cs:83— UsersDataSource.ReadAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SendToWebApiStep.DescribeAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:90— SendToWebApiStep.DescribeAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
AzureEmailSettingsDisplayDriver.UpdateAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSettingsDisplayDriver.cs:70— AzureEmailSettingsDisplayDriver.UpdateAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SecretsRecipeStep.ImportFromObjectAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Secrets/Recipes/SecretsRecipeStep.cs:63— SecretsRecipeStep.ImportFromObjectAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HasPermissionFilter.ProcessAsync (cognitive 23) src/OrchardCore.Modules/OrchardCore.Users/Liquid/HasPermissionFilter.cs:21— HasPermissionFilter.ProcessAsync has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ExpressionCompiler.InferBinaryType (cognitive 23) src/OrchardCore/OrchardCore.DataSources.Core/Expressions/ExpressionCompiler.cs:185— ExpressionCompiler.InferBinaryType has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementInfo.ParseLocation (cognitive 23) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:386— PlacementInfo.ParseLocation has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MatchFilterProvider.CreateFilteredQuery (cognitive 23) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:10— MatchFilterProvider.CreateFilteredQuery has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SetupService.SetupInternalAsync (cognitive 23) src/OrchardCore/OrchardCore.Setup.Core/Services/SetupService.cs:113— SetupService.SetupInternalAsync has cognitive complexity 23 (threshold 15). Of this number, 21 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
data-pipelines-editors.updateFilterRow (cognitive 23) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:97— data-pipelines-editors.updateFilterRow has cognitive complexity 23 (threshold 15). Drivers by points: boolean chains 12, if/else 7, ternaries 3 (4 pts) (nesting depth added 1). Of this number, 17 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
setup.init (cognitive 23) src/OrchardCore.Modules/OrchardCore.Setup/Assets/ts/setup.ts:109— setup.init has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 4, ternaries 1 (2 pts) (nesting depth added 8). Most of this is not in the body itself: 3 of the 23 points are its own statements and the rest belongs to 5 function items inside it that branch (evaluatePasswordRules, createPopover, updatePopoverRules, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
TheAdmin.document.addEventListener("DOMContentLoaded") (cognitive 23) src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/TheAdmin.ts:112— TheAdmin.document.addEventListener("DOMContentLoaded") has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 12). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 115, 159, 172). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
init (cognitive 23) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/history/trumbowyg.history.js:17— init has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (15 pts), boolean chains 7, loops 1 (nesting depth added 2). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 9 function items inside it that branch (pushToHistory, arraysAreIdentical, toggleButtonState, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
ShellFileVersionProvider.AddFileVersionToPath (cognitive 22) src/OrchardCore/OrchardCore.Mvc.Core/ShellFileVersionProvider.cs:37— ShellFileVersionProvider.AddFileVersionToPath has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migrations.MigrateMenuItemNodes (cognitive 22) src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:98— Migrations.MigrateMenuItemNodes has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IndexProfileDisplayDriver.UpdateAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Indexing/Drivers/IndexProfileDisplayDriver.cs:71— IndexProfileDisplayDriver.UpdateAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LiquidContentAuthorizationHandler.ContainsProtectedContentItemAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Liquid/Security/LiquidContentAuthorizationHandler.cs:102— LiquidContentAuthorizationHandler.ContainsProtectedContentItemAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RemoteMediaCacheBackgroundTask.DoWorkAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Media/Services/RemoteMediaCacheBackgroundTask.cs:41— RemoteMediaCacheBackgroundTask.DoWorkAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaTusStartup.Configure (cognitive 22) src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:488— MediaTusStartup.Configure has cognitive complexity 22 (threshold 15). None of this is in the body itself: all 22 points belong to 5 function literals inside it that branch (lines 500, 597, 536, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TermShapes.DiscoverAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Taxonomies/TermShapes.cs:15— TermShapes.DiscoverAsync has cognitive complexity 22 (threshold 15). None of this is in the body itself: all 22 points belong to 2 function literals inside it that branch (lines 30, 141). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AdminListBuilder.BuildAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Admin/Services/AdminListBuilder.cs:35— AdminListBuilder.BuildAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CorsOptionsConfiguration.Configure (cognitive 22) src/OrchardCore.Modules/OrchardCore.Cors/Services/CorsOptionsConfiguration.cs:18— CorsOptionsConfiguration.Configure has cognitive complexity 22 (threshold 15). Most of this is not in the body itself: 8 of the 22 points are its own statements and the rest belongs to one function literal inside it that branches (line 34). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
AzureEmailProviderBase.FromMailMessage (cognitive 22) src/OrchardCore.Modules/OrchardCore.Email.Azure/Services/AzureEmailProviderBase.cs:200— AzureEmailProviderBase.FromMailMessage has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PermissionsLocalizationDataProvider.GetDescriptorsAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Roles/Services/PermissionsLocalizationDataProvider.cs:32— PermissionsLocalizationDataProvider.GetDescriptorsAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RsaSecretDisplayDriver.UpdateAsync (cognitive 22) src/OrchardCore.Modules/OrchardCore.Secrets/Drivers/RsaSecretDisplayDriver.cs:86— RsaSecretDisplayDriver.UpdateAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SetupController.IndexPOST (cognitive 22) src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:85— SetupController.IndexPOST has cognitive complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DataPipelineAnalyzer.DescribeAsync (cognitive 22) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineAnalyzer.cs:219— DataPipelineAnalyzer.DescribeAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataSourceStep.BuildPlan (cognitive 22) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataSourceStep.cs:289— DataSourceStep.BuildPlan has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElasticsearchQuerySource.ExecuteQueryAsync (cognitive 22) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchQuerySource.cs:48— ElasticsearchQuerySource.ExecuteQueryAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RangeFilterProvider.CreateFilteredQuery (cognitive 22) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/RangeFilterProvider.cs:9— RangeFilterProvider.CreateFilteredQuery has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MatchQueryProvider.CreateQuery (cognitive 22) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/MatchQueryProvider.cs:10— MatchQueryProvider.CreateQuery has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureAISearchDefaultSettingsDisplayDriver.UpdateAsync (cognitive 21) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchDefaultSettingsDisplayDriver.cs:83— AzureAISearchDefaultSettingsDisplayDriver.UpdateAsync has cognitive complexity 21 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MenuShapes.DiscoverAsync (cognitive 21) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:23— MenuShapes.DiscoverAsync has cognitive complexity 21 (threshold 15). None of this is in the body itself: all 21 points belong to 3 function literals inside it that branch (lines 26, 109, 158). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SitemapsRobotsProvider.GetContentAsync (cognitive 21) src/OrchardCore.Modules/OrchardCore.Sitemaps/Services/SitemapsRobotsProvider.cs:21— SitemapsRobotsProvider.GetContentAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationShapes.DiscoverAsync (cognitive 21) src/OrchardCore.Modules/OrchardCore.Navigation/NavigationShapes.cs:12— NavigationShapes.DiscoverAsync has cognitive complexity 21 (threshold 15). None of this is in the body itself: all 21 points belong to 3 function literals inside it that branch (lines 24, 73, 84). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TwilioSettingsDisplayDriver.UpdateAsync (cognitive 21) src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSettingsDisplayDriver.cs:72— TwilioSettingsDisplayDriver.UpdateAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JObject.Merge (cognitive 21) src/OrchardCore/OrchardCore.Abstractions/Json/Nodes/JObject.cs:88— JObject.Merge has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultContentManager.GetAsync (cognitive 21) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:102— DefaultContentManager.GetAsync has cognitive complexity 21 (threshold 15). Of this number, 18 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DbConnectionValidator.ValidateAsync (cognitive 21) src/OrchardCore/OrchardCore.Data.YesSql/DbConnectionValidator.cs:46— DbConnectionValidator.ValidateAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataMigrationManager.UpdateAsync (cognitive 21) src/OrchardCore/OrchardCore.Data.YesSql/Migration/DataMigrationManager.cs:165— DataMigrationManager.UpdateAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExpressionLexer.Tokenize (cognitive 21) src/OrchardCore/OrchardCore.DataSources.Core/Expressions/ExpressionLexer.cs:43— ExpressionLexer.Tokenize has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelDataFileFormat.KindOf (cognitive 21) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:402— ExcelDataFileFormat.KindOf has cognitive complexity 21 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
ExcelDataFileFormat.WriteWorksheetAsync (cognitive 21) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:673— ExcelDataFileFormat.WriteWorksheetAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CoreShapes.List (cognitive 21) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/CoreShapes.cs:19— CoreShapes.List has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RangeQueryProvider.CreateQuery (cognitive 21) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/RangeQueryProvider.cs:9— RangeQueryProvider.CreateQuery has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RecipeExecutor.EvaluateJsonTreeAsync (cognitive 21) src/OrchardCore/OrchardCore.Recipes.Core/Services/RecipeExecutor.cs:198— RecipeExecutor.EvaluateJsonTreeAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
brand.draw_code (cognitive 21) .agents/skills/orchardcore-video-producer/scripts/brand.py:211— brand.draw_code has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (4 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HierarchicalTreeBuilder.useHierarchicalTreeBuilder.convertToFileHierarchyTreeNode (cognitive 21) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:142— HierarchicalTreeBuilder.useHierarchicalTreeBuilder.convertToFileHierarchyTreeNode has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (12 pts), ternaries 3 (7 pts), loops 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileLibraryManager.useFileLibraryManager.loadDirectoryFiles (cognitive 21) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileLibraryManager.ts:351— FileLibraryManager.useFileLibraryManager.loadDirectoryFiles has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (18 pts), error handling 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RouterService.useRouterService (cognitive 21) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/RouterService.ts:11— RouterService.useRouterService has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (21 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
menu.initializeMenu (cognitive 21) src/OrchardCore.Themes/TheAdmin/Assets/js/TheAdmin/menu.ts:308— menu.initializeMenu has cognitive complexity 21 (threshold 15). Drivers by points: if/else 15 (18 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 4). Most of this is not in the body itself: 9 of the 21 points are its own statements and the rest belongs to 9 function literals inside it that branch (lines 326, 342, 387, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
FileProviderExtensions.GetViewFilePaths (cognitive 20) src/OrchardCore/OrchardCore.Mvc.Core/FileProviders/FileProviderExtensions.cs:7— FileProviderExtensions.GetViewFilePaths has cognitive complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AutoroutePartDisplayDriver.UpdateAsync (cognitive 20) src/OrchardCore.Modules/OrchardCore.Autoroute/Drivers/AutoroutePartDisplayDriver.cs:78— AutoroutePartDisplayDriver.UpdateAsync has cognitive complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.EditTypePartPOST (cognitive 20) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:1002— AdminController.EditTypePartPOST has cognitive complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.CreatePost (cognitive 20) src/OrchardCore.Modules/OrchardCore.Indexing/Controllers/AdminController.cs:179— AdminController.CreatePost has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TagController.CreatePost (cognitive 20) src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/TagController.cs:34— TagController.CreatePost has cognitive complexity 20 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MaxNumberOfResultsValidationRule.GetPreNodeVisitorAsync (cognitive 20) src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/MaxNumberOfResultsValidationRule.cs:28— MaxNumberOfResultsValidationRule.GetPreNodeVisitorAsync has cognitive complexity 20 (threshold 15). None of this is in the body itself: all 20 points belong to one function literal inside it that branches (line 31). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
AzureSettingsDisplayDriver.UpdateAsync (cognitive 20) src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSettingsDisplayDriver.cs:71— AzureSettingsDisplayDriver.UpdateAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RoleAuthorizationHandler.HandleRequirementAsync (cognitive 20) src/OrchardCore.Modules/OrchardCore.Users/Roles/Handlers/RoleAuthorizationHandler.cs:23— RoleAuthorizationHandler.HandleRequirementAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemsFieldType.FilterWhereArgumentsAsync (cognitive 20) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs:126— ContentItemsFieldType.FilterWhereArgumentsAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PredicateQuery.GetColumnName (cognitive 20) src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Predicates/PredicateQuery.cs:98— PredicateQuery.GetColumnName has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentPartHandlerCoordinator.InvokeHandlers (cognitive 20) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:324— ContentPartHandlerCoordinator.InvokeHandlers has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataPipelineExecutor.PreviewAsync (cognitive 20) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineExecutor.cs:73— DataPipelineExecutor.PreviewAsync has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConvertTimeZoneStep.ExecuteAsync (cognitive 20) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/ConvertTimeZoneStep.cs:83— ConvertTimeZoneStep.ExecuteAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataFilterPredicates.BuildCondition (cognitive 20) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:133— DataFilterPredicates.BuildCondition has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataSorter.SortAsync (cognitive 20) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataSorter.cs:52— DataSorter.SortAsync has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
LiquidTagHelperActivator.Create (cognitive 20) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/LiquidTagHelperActivator.cs:142— LiquidTagHelperActivator.Create has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementInfoExtensions.Combine (cognitive 20) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfoExtensions.cs:14— PlacementInfoExtensions.Combine has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeResult.BuildAndAddShapeAsync (cognitive 20) src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeResult.cs:460— ShapeResult.BuildAndAddShapeAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ElasticsearchContentPickerResultProvider.Search (cognitive 20) src/OrchardCore/OrchardCore.Elasticsearch.Core/Providers/ElasticsearchContentPickerResultProvider.cs:32— ElasticsearchContentPickerResultProvider.Search has cognitive complexity 20 (threshold 15). Most of this is not in the body itself: 4 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 55). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
BlobFileStore.GetDirectoryContentByHierarchyAsync (cognitive 20) src/OrchardCore/OrchardCore.FileStorage.AzureBlob/BlobFileStore.cs:273— BlobFileStore.GetDirectoryContentByHierarchyAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocumentManager.GetInternalAsync (cognitive 20) src/OrchardCore/OrchardCore.Infrastructure/Documents/DocumentManager.cs:241— DocumentManager.GetInternalAsync has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PortableObjectStringLocalizer.GetTranslation (cognitive 20) src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PortableObjectStringLocalizer.cs:165— PortableObjectStringLocalizer.GetTranslation has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneQueryService.SearchAsync (cognitive 20) src/OrchardCore/OrchardCore.Lucene.Core/LuceneQueryService.cs:18— LuceneQueryService.SearchAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BooleanQueryProvider.CreateFilteredQuery (cognitive 20) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/BooleanQueryProvider.cs:81— BooleanQueryProvider.CreateFilteredQuery has cognitive complexity 20 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
NavigationManager.AuthorizeAsync (cognitive 20) src/OrchardCore/OrchardCore.Navigation.Core/NavigationManager.cs:208— NavigationManager.AuthorizeAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserManagerExtensions.UpdateUserPropertiesAsync (cognitive 20) src/OrchardCore/OrchardCore.Users.Core/UserManagerExtensions.cs:17— UserManagerExtensions.UpdateUserPropertiesAsync has cognitive complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AutorouteValuesAddressScheme.FindEndpoints (cognitive 19) src/OrchardCore.Modules/OrchardCore.Autoroute/Routing/AutorouteValuesAddressScheme.cs:23— AutorouteValuesAddressScheme.FindEndpoints has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CreateContentTask.ExecuteAsync (cognitive 19) src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/CreateContentTask.cs:67— CreateContentTask.ExecuteAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.EditFieldPOST (cognitive 19) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:827— AdminController.EditFieldPOST has cognitive complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MediaCommandParser.Parse (cognitive 19) src/OrchardCore.Modules/OrchardCore.Media/Processing/MediaCommandParser.cs:24— MediaCommandParser.Parse has cognitive complexity 19 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
GraphQLMiddleware.ExecuteAsync (cognitive 19) src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/GraphQLMiddleware.cs:88— GraphQLMiddleware.ExecuteAsync has cognitive complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamicCacheTagHelper.ProcessContentAsync (cognitive 19) src/OrchardCore.Modules/OrchardCore.DynamicCache/TagHelpers/DynamicCacheTagHelper.cs:157— DynamicCacheTagHelper.ProcessContentAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PushedAuthorizationRequestsMigration.Create (cognitive 19) src/OrchardCore.Modules/OrchardCore.OpenId/Migrations/PushedAuthorizationRequestsMigration.cs:19— PushedAuthorizationRequestsMigration.Create has cognitive complexity 19 (threshold 15). None of this is in the body itself: all 19 points belong to one function literal inside it that branches (line 24). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
UrlRewritingStep.HandleAsync (cognitive 19) src/OrchardCore.Modules/OrchardCore.UrlRewriting/Recipes/UrlRewritingStep.cs:27— UrlRewritingStep.HandleAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureAISearchDocumentIndexManager.GetNestedValue (cognitive 19) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs:369— AzureAISearchDocumentIndexManager.GetNestedValue has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SelectFieldsStep.ExecuteAsync (cognitive 19) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/SelectFieldsStep.cs:48— SelectFieldsStep.ExecuteAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CsvDataFileFormat.ReadAsync (cognitive 19) src/OrchardCore/OrchardCore.DataSources.Core/Files/CsvDataFileFormat.cs:66— CsvDataFileFormat.ReadAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ThemeViewLocationExpanderProvider.ExpandViewLocations (cognitive 19) src/OrchardCore/OrchardCore.DisplayManagement/LocationExpander/ThemeViewLocationExpanderProvider.cs:35— ThemeViewLocationExpanderProvider.ExpandViewLocations has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElasticsearchDocumentIndexManager.AddOrUpdateDocumentsAsync (cognitive 19) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:130— ElasticsearchDocumentIndexManager.AddOrUpdateDocumentsAsync has cognitive complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlobStorageOptionsConfiguration.Configure (cognitive 19) src/OrchardCore/OrchardCore.FileStorage.AzureBlob/BlobStorageOptionsConfiguration.cs:28— BlobStorageOptionsConfiguration.Configure has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultCommandHandler.GetInvokeParametersForMethod (cognitive 19) src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Commands/DefaultCommandHandler.cs:94— DefaultCommandHandler.GetInvokeParametersForMethod has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RunningShellTable.TryMatchInternal (cognitive 19) src/OrchardCore/OrchardCore/Shell/RunningShellTable.cs:89— RunningShellTable.TryMatchInternal has cognitive complexity 19 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
flows.edit.document.addEventListener("DOMContentLoaded") (cognitive 19) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:22— flows.edit.document.addEventListener("DOMContentLoaded") has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (14 pts), ternaries 3, boolean chains 2 (nesting depth added 1). None of this is in the body itself: all 19 points belong to 10 function literals inside it that branch (lines 119, 155, 23, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
AdminMenuStep.MigrateMenuItemNodes (cognitive 18) src/OrchardCore.Modules/OrchardCore.AdminMenu/Recipes/AdminMenuStep.cs:67— AdminMenuStep.MigrateMenuItemNodes has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinkFieldHandler.ValidatingAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.ContentFields/Handlers/LinkFieldHandler.cs:36— LinkFieldHandler.ValidatingAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FullTextFilter.ProcessAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Contents/Liquid/FullTextFilter.cs:23— FullTextFilter.ProcessAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultContentsAdminListQueryService.QueryAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs:36— DefaultContentsAdminListQueryService.QueryAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.AddFieldToPOST (cognitive 18) src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs:697— AdminController.AddFieldToPOST has cognitive complexity 18 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BagPartDisplayDriver.UpdateAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:94— BagPartDisplayDriver.UpdateAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FlowPartDisplayDriver.UpdateAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:115— FlowPartDisplayDriver.UpdateAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaProfilesController.CreatePost (cognitive 18) REDACTED:139— MediaProfilesController.CreatePost has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GetFoldersEndpoint.HandleAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetFoldersEndpoint.cs:29— GetFoldersEndpoint.HandleAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MenuShapes.ShouldCreateAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:258— MenuShapes.ShouldCreateAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SitemapValuesAddressScheme.FindEndpoints (cognitive 18) src/OrchardCore.Modules/OrchardCore.Sitemaps/Routing/SitemapValuesAddressScheme.cs:22— SitemapValuesAddressScheme.FindEndpoints has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SchemaService.GetSchemaAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Services/SchemaService.cs:27— SchemaService.GetSchemaAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SendToWebApiStep.ExecuteAsync (cognitive 18) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:178— SendToWebApiStep.ExecuteAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdminController.Index (cognitive 18) REDACTED:253— AdminController.Index has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureAISearchIndexManager.GetSearchFieldTemplate (cognitive 18) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchIndexManager.cs:380— AzureAISearchIndexManager.GetSearchFieldTemplate has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureAISearchService.SearchAsync (cognitive 18) src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchService.cs:32— AzureAISearchService.SearchAsync has cognitive complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemDisplayCoordinator.BuildEditorAsync (cognitive 18) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:192— ContentItemDisplayCoordinator.BuildEditorAsync has cognitive complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ContentItemDisplayCoordinator.UpdateEditorAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ContentItemDisplayCoordinator.UpdateEditorAsync (cognitive 18) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:287— ContentItemDisplayCoordinator.UpdateEditorAsync has cognitive complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ContentItemDisplayCoordinator.BuildEditorAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ContentPartHandlerCoordinator.InvokeHandlers (cognitive 18) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:463— ContentPartHandlerCoordinator.InvokeHandlers has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PreviewCapture.ReadAsync (cognitive 18) src/OrchardCore/OrchardCore.DataPipelines.Core/Services/DataPipelineExecutor.cs:453— PreviewCapture.ReadAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AggregateStep.BuildPlan (cognitive 18) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/AggregateStep.cs:87— AggregateStep.BuildPlan has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FilterStep.ExecuteAsync (cognitive 18) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/FilterStep.cs:85— FilterStep.ExecuteAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExcelDataFileFormat.ReadAsync (cognitive 18) src/OrchardCore/OrchardCore.DataSources.Core/Files/ExcelDataFileFormat.cs:131— ExcelDataFileFormat.ReadAsync has cognitive complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeDescriptorIndex.ShapeDescriptorIndex.ctor (cognitive 18) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/FeatureShapeDescriptor.cs:47— ShapeDescriptorIndex.ShapeDescriptorIndex.ctor has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementInfo.BuildLocationString (cognitive 18) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:306— PlacementInfo.BuildLocationString has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZoneShapes.ContentZone (cognitive 18) src/OrchardCore/OrchardCore.DisplayManagement/Zones/ZoneShapes.cs:28— ZoneShapes.ContentZone has cognitive complexity 18 (threshold 15). Of this number, 10 points are the body's own statements and 8 belong to 4 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FileCreationService.CreateAsync (cognitive 18) src/OrchardCore/OrchardCore.FileStorage.Abstractions/FileCreationService.cs:32— FileCreationService.CreateAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PathExtensions.ResolvePath (cognitive 18) src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Files/PathExtensions.cs:63— PathExtensions.ResolvePath has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BooleanQueryProvider.CreateQuery (cognitive 18) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/BooleanQueryProvider.cs:17— BooleanQueryProvider.CreateQuery has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShapeFactoryGenerator.GetShapeFactoryInvocationKind (cognitive 18) src/OrchardCore/OrchardCore.SourceGenerators/ShapeFactoryGenerator.cs:163— ShapeFactoryGenerator.GetShapeFactoryInvocationKind has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
miniprofiler.styleQueries (cognitive 18) src/OrchardCore.Modules/OrchardCore.MiniProfiler/Assets/ts/miniprofiler.ts:174— miniprofiler.styleQueries has cognitive complexity 18 (threshold 15). Drivers by points: boolean chains 8, if/else 8, ternaries 1 (2 pts) (nesting depth added 1). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to one function literal inside it that branches (line 190). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
list-management.getActiveClientFilters (cognitive 18) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:243— list-management.getActiveClientFilters has cognitive complexity 18 (threshold 15). Drivers by points: boolean chains 7, if/else 2 (5 pts), loops 3 (4 pts), ternaries 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous).addProperListeners (cognitive 18) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:61— (anonymous).addProperListeners has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
init (cognitive 18) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/pasteembed/trumbowyg.pasteembed.js:25— init has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 4, error handling 1 (nesting depth added 5). Most of this is not in the body itself: 2 of the 18 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 32, (anonymous)::complete, (anonymous)::success, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
NumericFieldDisplayDriver.UpdateAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/NumericFieldDisplayDriver.cs:63— NumericFieldDisplayDriver.UpdateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypesSitemapSourceBuilder.BuildSourceAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceBuilder.cs:34— ContentTypesSitemapSourceBuilder.BuildSourceAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentVersionPruningService.PruneVersionsAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Contents/VersionPruning/Services/ContentVersionPruningService.cs:36— ContentVersionPruningService.PruneVersionsAsync has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UploadMediaEndpoint.HandleAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/UploadMediaEndpoint.cs:37— UploadMediaEndpoint.HandleAsync has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 81). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
MediaFieldQueryObjectType.MediaFieldQueryObjectType.ctor (cognitive 17) src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQueryObjectType.cs:13— MediaFieldQueryObjectType.MediaFieldQueryObjectType.ctor has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 5 function literals inside it that branch (lines 76, 22, 35, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
MediaProfileService.GetMediaProfileCommands (cognitive 17) src/OrchardCore.Modules/OrchardCore.Media/Services/MediaProfileService.cs:16— MediaProfileService.GetMediaProfileCommands has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GeoPointFieldDisplayDriver.UpdateAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Spatial/Drivers/GeoPointFieldDisplayDriver.cs:47— GeoPointFieldDisplayDriver.UpdateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentDataValueDiscovery.Humanize (cognitive 17) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentDataValueDiscovery.cs:61— ContentDataValueDiscovery.Humanize has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentItemsDataSource.ReadAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.DataPipelines/DataSources/Contents/ContentItemsDataSource.cs:97— ContentItemsDataSource.ReadAsync has cognitive complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataPipelineRunExecutor.RunAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.DataPipelines/Services/DataPipelineRunExecutor.cs:119— DataPipelineRunExecutor.RunAsync has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 7 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 203, 166). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SaveContentItemsStep.SaveAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Contents/SaveContentItemsStep.cs:177— SaveContentItemsStep.SaveAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImportController.Import (cognitive 17) src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/ImportController.cs:64— ImportController.Import has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PagerShapesTableProvider.DiscoverAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Navigation/PagerShapesTableProvider.cs:24— PagerShapesTableProvider.DiscoverAsync has cognitive complexity 17 (threshold 15). None of this is in the body itself: all 17 points belong to 9 function literals inside it that branch (lines 34, 50, 59, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
OpenIdClientSettingsDisplayDriver.UpdateAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSettingsDisplayDriver.cs:108— OpenIdClientSettingsDisplayDriver.UpdateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DefaultSiteSettingsDisplayDriver.UpdateAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Settings/Drivers/DefaultSiteSettingsDisplayDriver.cs:64— DefaultSiteSettingsDisplayDriver.UpdateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
SetupTenantTask.ExecuteAsync (cognitive 17) src/OrchardCore.Modules/OrchardCore.Tenants/Workflows/Activities/SetupTenantTask.cs:110— SetupTenantTask.ExecuteAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AdminController.SetCurrentTheme (cognitive 17) src/OrchardCore.Modules/OrchardCore.Themes/Controllers/AdminController.cs:104— AdminController.SetCurrentTheme has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExternalAuthenticationsController.LinkExternalLogin (cognitive 17) src/OrchardCore.Modules/OrchardCore.Users/Controllers/ExternalAuthenticationsController.cs:362— ExternalAuthenticationsController.LinkExternalLogin has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
HttpWorkflowController.Trigger (cognitive 17) src/OrchardCore.Modules/OrchardCore.Workflows/Http/Controllers/HttpWorkflowController.cs:215— HttpWorkflowController.Trigger has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataFilterValueList.Parse (cognitive 17) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Sources/DataFilterValueList.cs:17— DataFilterValueList.Parse has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CacheTag.WriteToAsync (cognitive 17) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheTag.cs:17— CacheTag.WriteToAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeCacheTag.WriteToAsync (cognitive 17) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapeCacheTag.cs:11— ShapeCacheTag.WriteToAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeAttributeBindingStrategy.CreateDelegate (cognitive 17) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:63— ShapeAttributeBindingStrategy.CreateDelegate has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 4 of the 17 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 79, 92, 105, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
DefaultHtmlDisplay.GetShapeBindingAsync (cognitive 17) src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs:318— DefaultHtmlDisplay.GetShapeBindingAsync has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShapeSerializer.Serialize (cognitive 17) src/OrchardCore/OrchardCore.DisplayManagement/Shapes/ShapeSerializer.cs:28— ShapeSerializer.Serialize has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ElasticsearchIndexRebuildStep.HandleAsync (cognitive 17) src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexRebuildStep.cs:27— ElasticsearchIndexRebuildStep.HandleAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentIndexingService.BeforeProcessingTasksAsync (cognitive 17) src/OrchardCore/OrchardCore.Indexing.Core/ContentIndexingService.cs:45— ContentIndexingService.BeforeProcessingTasksAsync has cognitive complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BreadcrumbTagHelper.ProcessAsync (cognitive 17) src/OrchardCore/OrchardCore.Navigation.Core/BreadcrumbTagHelper.cs:100— BreadcrumbTagHelper.ProcessAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
SlugService.Slugify (cognitive 17) src/OrchardCore/OrchardCore/Modules/Services/SlugService.cs:17— SlugService.Slugify has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
brand.bullets (cognitive 17) .agents/skills/orchardcore-video-producer/scripts/brand.py:160— brand.bullets has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 6 (12 pts), if/else 2 (3 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous).validateRule (cognitive 17) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:258— (anonymous).validateRule has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), boolean chains 4, ternaries 2, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModuleProjectRazorFileProvider.ModuleProjectRazorFileProvider.ctor (cognitive 16) src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:20— ModuleProjectRazorFileProvider.ModuleProjectRazorFileProvider.ctor has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneIndexRebuildStep.HandleAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:26— LuceneIndexRebuildStep.HandleAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LuceneIndexResetStep.HandleAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs:26— LuceneIndexResetStep.HandleAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaBlobContainerTenantEvents.RemovingAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Media.Azure/Services/MediaBlobContainerTenantEvents.cs:88— MediaBlobContainerTenantEvents.RemovingAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MediaStep.HandleAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Media/Recipes/MediaStep.cs:39— MediaStep.HandleAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MoveAttachedMediaFieldsStepExecutor.ProcessContentTypeAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Media/Recipes/MoveAttachedMediaFieldsStepExecutor.cs:80— MoveAttachedMediaFieldsStepExecutor.ProcessContentTypeAsync has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ViewMediaFolderAuthorizationHandler.HandleRequirementAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Media/Services/ViewMediaFolderAuthorizationHandler.cs:47— ViewMediaFolderAuthorizationHandler.HandleRequirementAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SitemapIndexTypeUpdateHandler.UpdateSitemapAsync (cognitive 16) src/OrchardCore.Modules/OrchardCore.Sitemaps/Handlers/SitemapIndexTypeUpdateHandler.cs:16— SitemapIndexTypeUpdateHandler.UpdateSitemapAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OpenIdServerConfiguration.Configure (cognitive 16) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs:48— OpenIdServerConfiguration.Configure has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. Note what this body is, though: it works in explicit hardware vector and instruction-set types. A kernel divided across a call boundary passes its vectors between the parts and depends on the runtime putting them back together, so the division can cost more than the complexity it removes. The measurement stands — a hot path is not a licence to be unreadable — but the move that pays here is to lift the COLD parts out first (argument validation, fallback and error paths, one-off setup) and leave the kernel whole. Where the kernel itself has to be divided, ask for the extracted parts to be inlined as well, and measure the result rather than assuming the division is free.
AdminController.IndexBulkActionPost (cognitive 16) src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:167— AdminController.IndexBulkActionPost has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellScope.BeforeDisposeAsync (cognitive 16) src/OrchardCore/OrchardCore.Abstractions/Shell/Scope/ShellScope.cs:444— ShellScope.BeforeDisposeAsync has cognitive complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentFieldAlternatesFactory.BuildAlternates (cognitive 16) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldAlternatesFactory.cs:57— ContentFieldAlternatesFactory.BuildAlternates has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CalculatedFieldsStep.ExecuteAsync (cognitive 16) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/CalculatedFieldsStep.cs:59— CalculatedFieldsStep.ExecuteAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UnionStep.ExecuteAsync (cognitive 16) src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/Transforms/UnionStep.cs:49— UnionStep.ExecuteAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DataDistinct.DistinctAsync (cognitive 16) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataDistinct.cs:26— DataDistinct.DistinctAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultRequiredAttributeParser.AddRequiredAttributes (cognitive 16) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:47— DefaultRequiredAttributeParser.AddRequiredAttributes has cognitive complexity 16 (threshold 15). Most of this is not in the body itself: 4 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 59). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ShapeTag.WriteToAsync (cognitive 16) src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Tags/ShapeTag.cs:14— ShapeTag.WriteToAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElasticsearchIndexResetStep.HandleAsync (cognitive 16) src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexResetStep.cs:27— ElasticsearchIndexResetStep.HandleAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RebuildIndexStep.HandleAsync (cognitive 16) src/OrchardCore/OrchardCore.Indexing.Core/Recipes/RebuildIndexStep.cs:20— RebuildIndexStep.HandleAsync has cognitive complexity 16 (threshold 15). Most of this is not in the body itself: 4 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 34). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
NavigationHelper.MarkAsSelectedIfMatchesPath (cognitive 16) src/OrchardCore/OrchardCore.Navigation.Core/NavigationHelper.cs:91— NavigationHelper.MarkAsSelectedIfMatchesPath has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationHelper.GetHighestPrioritySelectedMenuItem (cognitive 16) src/OrchardCore/OrchardCore.Navigation.Core/NavigationHelper.cs:287— NavigationHelper.GetHighestPrioritySelectedMenuItem has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ResourceManager.ExpandDependenciesImplementation (cognitive 16) src/OrchardCore/OrchardCore.ResourceManagement/ResourceManager.cs:383— ResourceManager.ExpandDependenciesImplementation has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaScriptEnginePool.Sweep (cognitive 16) src/OrchardCore/OrchardCore.Scripting.JavaScript/JavaScriptEnginePool.cs:200— JavaScriptEnginePool.Sweep has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
data-pipelines-editors.document.addEventListener("click") (cognitive 16) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:349— data-pipelines-editors.document.addEventListener("click") has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
FieldUploadService.useFieldUpload.uploadFileXhr (cognitive 16) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/services/FieldUploadService.ts:151— FieldUploadService.useFieldUpload.uploadFileXhr has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 2, error handling 1 (2 pts), ternaries 1 (nesting depth added 4). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 173, 167, 166). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
init (cognitive 16) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/upload/trumbowyg.upload.js:156— init has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 3, error handling 1 (nesting depth added 3). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 9 function items inside it that branch (fn::(anonymous)::success, a function literal at line 196, fn, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
Change coupling clique: OpenIdApplicationStore.cs, OpenIdAuthorizationStore.cs, OpenIdScopeStore.cs, OpenIdTokenStore.cs src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs— 4 files — `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdApplicationStore.cs`, `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdAuthorizationStore.cs`, `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdScopeStore.cs`, `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs` — all change together with no explicit dependency: a fully-connected co-change clique, not 6 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
Change-coupling hub: OpenIdServerConfiguration.cs → OpenIdValidationConfiguration.cs, OpenIdServerSettingsDisplayDriver.cs, OpenIdServerSettingsStep.cs, OpenIdServerService.cs src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs— `src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs` changes together with 4 other files — `src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdValidationConfiguration.cs`, `src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs`, `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs`, `src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
Near-duplicate member pair (62 shared lines) src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:193— src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:193-285 | src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentItemDisplayCoordinator.cs:288-378 — These two members are variants of one another: 62 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (50 shared lines) src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:27— src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:27-108 | src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs:43-139 — These two members are variants of one another: 50 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (31 corresponding lines) · ×1
Edited copy of a member (31 corresponding lines) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:47— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:47-85 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/MoveMediaEndpoint.cs:46-90 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (39 corresponding lines) · ×1
Edited copy of a member (39 corresponding lines) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:24— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:24-162 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:297-398 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×1
Edited copy of a member (12 corresponding lines) src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:30— src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:30-64 | src/OrchardCore.Modules/OrchardCore.Markdown/GraphQL/MarkdownFieldQueryObjectType.cs:30-62 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Members sharing a duplicated core (10 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (10 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:69— src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:69-101 | src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSecretMigrationDisplayDriver.cs:70-102 | src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSecretMigrationDisplayDriver.cs:68-100 | src/OrchardCore.Modules/OrchardCore.Facebook/Drivers/FacebookSecretMigrationDisplayDriver.cs:68-100 | src/OrchardCore.Modules/OrchardCore.GitHub/Drivers/GitHubSecretMigrationDisplayDriver.cs:68-100 | src/OrchardCore.Modules/OrchardCore.Google/Authentication/Drivers/GoogleSecretMigrationDisplayDriver.cs:68-100 | src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Drivers/MicrosoftAccountSecretMigrationDisplayDriver.cs:68-100 | src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSecretMigrationDisplayDriver.cs:68-98 | src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSmsSecretMigrationDisplayDriver.cs:69-101 | src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSecretMigrationDisplayDriver.cs:69-101 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:25— src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:25-96 | src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:48-261 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:39-227 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:32-202 | src/OrchardCore/OrchardCore.Queries.Core/QueriesDocumentMigrationHelper.cs:14-73 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (88–89 lines × 3) src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:93— src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:93-181 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:94-182 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:97-184 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 174 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (42–48 lines × 2) src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:25— src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:25-66 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs:230-277 — before extracting anything, compare `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs` and `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchDocumentIndexManager.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/BulkRequestDescriptorExtensions.cs:25` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `documentIndex` to `ContentItemDocumentIndex` in one and `DocumentIndex` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (45 lines × 2) src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:96— src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:96-140 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:95-139 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 170 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (45–46 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:24— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:24-68 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:402-447 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:24` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (44–45 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:315— src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:315-359 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:667-710 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/Migrations.cs:315` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (40–43 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/Records/Migrations.cs:32— src/OrchardCore/OrchardCore.ContentManagement/Records/Migrations.cs:32-71 | src/OrchardCore/OrchardCore.ContentManagement/Records/Migrations.cs:191-233 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement/Records/Migrations.cs:32` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17–42 lines × 2) src/OrchardCore/OrchardCore.Email.Abstractions/SmtpOptions.cs:9— src/OrchardCore/OrchardCore.Email.Abstractions/SmtpOptions.cs:9-25 | src/OrchardCore/OrchardCore.Email.Abstractions/SmtpSettings.cs:11-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (40–41 lines × 3) src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:184— src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:184-224 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:185-225 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:187-226 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 174 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (37 lines × 2) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:289— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs:289-325 | src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs:365-401 — before extracting anything, compare `src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Utilities/StringExtensions.cs` and `src/OrchardCore/OrchardCore.Mvc.Core/Utilities/StringExtensions.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 167 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (37–38 lines × 2) src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:49— src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:49-85 | src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:93-130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.RateLimits/Controllers/LimiterController.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (35–37 lines × 2) src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceUpdateHandler.cs:37— src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceUpdateHandler.cs:37-73 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Handlers/SitemapIndexTypeUpdateHandler.cs:40-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Contents/Sitemaps/ContentTypesSitemapSourceUpdateHandler.cs:37` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (36 lines × 2) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:123— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:123-158 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:302-337 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Migrations/OpenIdMigrations.cs:123` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (33–34 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchPhraseFilterProvider.cs:23— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchPhraseFilterProvider.cs:23-55 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/MatchPhraseQueryProvider.cs:17-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchPhraseFilterProvider.cs:22` calls `AsObject` and `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/MatchPhraseQueryProvider.cs:15` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (31 lines × 2) src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:106— src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:106-136 | src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:127-157 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs` and `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:106` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/FlowPartDisplayDriver.cs:159` calls `Weld`, `FlowMetadata` and `src/OrchardCore.Modules/OrchardCore.Flows/Drivers/BagPartDisplayDriver.cs:139` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (30–31 lines × 12) src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs:28— src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/ContentPickerFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/DateFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/DateTimeFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/HtmlFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/LinkFieldIndexProvider.cs:37-67 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/MultiTextFieldIndexProvider.cs:34-63 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/NumericFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/TextFieldIndexProvider.cs:34-63 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/TimeFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/UserPickerFieldIndexProvider.cs:28-57 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Indexing/TaxonomyIndexProvider.cs:25-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 12 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 12 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29–30 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:51— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:51-80 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:42-70 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:35-64 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17–30 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:425— src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:425-441 | src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:455-484 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/PlacementInfo.cs:455` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (26–28 lines × 3) src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:62— src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:62-87 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:61-88 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:66-91 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 174 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:62` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (22 lines × 3) src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:95— src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:95-116 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:223-244 | src/OrchardCore.Modules/OrchardCore.Taxonomies/Controllers/AdminController.cs:303-324 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25–27 lines × 2) REDACTED:554— REDACTED:554-580 | src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs:202-226 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:554` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `model` to `EditTenantViewModel` in one and `TenantApiModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23–26 lines × 2) REDACTED:56— REDACTED:56-81 | REDACTED:308-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (20–25 lines × 3) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:151— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:151-170 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:104-128 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:103-127 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:151` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (24–25 lines × 2) src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:35— src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:35-58 | src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/MatchQueryProvider.cs:29-53 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Lucene.Core/QueryProviders/Filters/MatchFilterProvider.cs:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 4) src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:36— src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:36-57 | src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs:36-57 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexRebuildStep.cs:37-58 | src/OrchardCore/OrchardCore.Elasticsearch.Core/Recipes/ElasticsearchIndexResetStep.cs:37-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs:36` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23–24 lines × 3) src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:117— src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:117-140 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:162-184 | src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:199-222 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lucene/Migrations.cs:117` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (19–24 lines × 3) src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:116— src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:116-134 | src/OrchardCore.Modules/OrchardCore.Media.Azure/Startup.cs:111-130 | src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:147-170 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Startup.cs:116` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (21–22 lines × 2) src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1054— src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1054-1074 | src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:1151-1172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11–21 lines × 4) src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:18— src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:18-28 | src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdApplicationStepModel.cs:14-24 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/CreateOpenIdApplicationViewModel.cs:29-49 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/EditOpenIdApplicationViewModel.cs:33-53 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/CreateOpenIdApplicationViewModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/EditOpenIdApplicationViewModel.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (21 lines × 3) src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:18— src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:18-38 | src/OrchardCore/OrchardCore.Contents.Core/Services/ContentItemFilterEngineModelBinder.cs:18-38 | src/OrchardCore/OrchardCore.Users.Core/Services/UserFilterEngineModelBinder.cs:18-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:18` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19–20 lines × 3) src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AllContentDeploymentSource.cs:28— src/OrchardCore.Modules/OrchardCore.Contents/Deployment/AllContentDeploymentSource.cs:28-47 | src/OrchardCore.Modules/OrchardCore.Contents/Deployment/ContentDeploymentSource.cs:25-44 | src/OrchardCore.Modules/OrchardCore.Queries/Deployment/QueryBasedContentDeploymentSource.cs:41-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note first that the copies are not typed on the same thing: the declarations holding them bind `step` to `AllContentDeploymentStep` in one and `ContentDeploymentStep` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (18–20 lines × 2) src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ContainedPartDisplayDriver.cs:41— src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ContainedPartDisplayDriver.cs:41-60 | src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ContainedPartDisplayDriver.cs:70-87 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ContainedPartDisplayDriver.cs:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `BuildEditorContext` in one and `UpdateEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19–20 lines × 2) src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:69— src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs:69-88 | src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs:66-84 — before extracting anything, compare `src/OrchardCore/OrchardCore.DisplayManagement/Razor/RazorPage.cs` and `src/OrchardCore/OrchardCore.DisplayManagement/RazorPages/Page.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (17–20 lines × 2) src/OrchardCore/OrchardCore.Infrastructure/Scripting/DefaultScriptingManager.cs:49— src/OrchardCore/OrchardCore.Infrastructure/Scripting/DefaultScriptingManager.cs:49-65 | src/OrchardCore/OrchardCore.Infrastructure/Scripting/DefaultScriptingManager.cs:82-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Infrastructure/Scripting/DefaultScriptingManager.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18–19 lines × 4) REDACTED:75— REDACTED:75-93 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:82-99 | src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs:85-102 | REDACTED:78-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:75` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (18–19 lines × 3) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:260— src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:260-277 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:334-351 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:469-487 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `ContentItemAspectContext` in one and `CloneContentContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (18 lines × 4) src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:175— src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:175-192 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:128-145 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:127-144 | src/OrchardCore/OrchardCore.Indexing.Core/Handlers/ContentIndexProfileHandler.cs:131-148 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (17–18 lines × 4) src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:259— src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:259-275 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:333-349 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:407-424 | src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:468-485 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.ContentManagement/Handlers/ContentPartHandlerCoordinator.cs:259` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `ContentItemAspectContext` in one and `CloneContentContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 3) src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42— src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs:42-57 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetFoldersEndpoint.cs:38-53 | src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs:44-59 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs` and `src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15–18 lines × 3) REDACTED:120— REDACTED:120-134 | REDACTED:232-249 | REDACTED:553-569 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:120` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16–18 lines × 2) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:22— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:22-39 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:22-37 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:22` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10–18 lines × 2) src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:29— src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:29-38 | src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:232-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataFilterPredicates.cs:29` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 3) src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:69— src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:69-85 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:95-111 | src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:136-152 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.Abstractions/Modules/ModuleEmbeddedFileProvider.cs:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:116` calls `EndsWith`, `Contains` and `src/OrchardCore/OrchardCore.Mvc.Core/ModuleProjectRazorFileProvider.cs:156` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9–17 lines × 2) src/OrchardCore.Modules/OrchardCore.Deployment/Steps/RecipeFileDeploymentStep.cs:19— src/OrchardCore.Modules/OrchardCore.Deployment/Steps/RecipeFileDeploymentStep.cs:19-35 | src/OrchardCore.Modules/OrchardCore.Deployment/ViewModels/RecipeFileDeploymentStepViewModel.cs:5-13 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16–17 lines × 2) src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:328— src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:328-344 | src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:439-454 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Secrets/Controllers/AdminController.cs:328` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 10) src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:73— src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:73-85 | src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSecretMigrationDisplayDriver.cs:74-86 | src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSecretMigrationDisplayDriver.cs:72-84 | src/OrchardCore.Modules/OrchardCore.Facebook/Drivers/FacebookSecretMigrationDisplayDriver.cs:72-84 | src/OrchardCore.Modules/OrchardCore.GitHub/Drivers/GitHubSecretMigrationDisplayDriver.cs:72-84 | src/OrchardCore.Modules/OrchardCore.Google/Authentication/Drivers/GoogleSecretMigrationDisplayDriver.cs:72-84 | src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Drivers/MicrosoftAccountSecretMigrationDisplayDriver.cs:72-84 | src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdClientSecretMigrationDisplayDriver.cs:71-83 | src/OrchardCore.Modules/OrchardCore.Sms.Azure/Drivers/AzureSmsSecretMigrationDisplayDriver.cs:73-85 | src/OrchardCore.Modules/OrchardCore.Sms/Drivers/TwilioSecretMigrationDisplayDriver.cs:73-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 10 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 10 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:73` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 6) src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:163— src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:163-178 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs:206-221 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:164-179 | src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs:207-222 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:166-181 | src/OrchardCore.Modules/OrchardCore.Queries/Sql/GraphQL/SqlQueryFieldTypeProvider.cs:208-223 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Elasticsearch/GraphQL/ElasticsearchQueryFieldTypeProvider.cs` and `src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 174 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 4) src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:16— src/OrchardCore/OrchardCore.AuditTrail.Abstractions/Services/AuditTrailFilterEngineModelBinder.cs:16-30 | src/OrchardCore/OrchardCore.Contents.Core/Services/ContentItemFilterEngineModelBinder.cs:16-30 | src/OrchardCore/OrchardCore.Notifications.Core/Services/NotificationFilterEngineModelBinder.cs:16-30 | src/OrchardCore/OrchardCore.Users.Core/Services/UserFilterEngineModelBinder.cs:16-30 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times.
Duplicated block (16 lines × 4) src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:423— src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:423-438 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:455-471 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:488-504 | src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:520-536 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs:455` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (11–16 lines × 2) src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs:33— src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs:33-48 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs:27-37 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9–16 lines × 2) src/OrchardCore.Modules/OrchardCore.Recipes/Models/RecipeEntry.cs:9— src/OrchardCore.Modules/OrchardCore.Recipes/Models/RecipeEntry.cs:9-24 | src/OrchardCore.Modules/OrchardCore.Recipes/ViewModels/RecipeViewModel.cs:7-15 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Recipes/Models/RecipeEntry.cs:9` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–15 lines × 4) src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:25— src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:25-39 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:28-40 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs:25-37 | src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs:28-40 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs` and `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleBlock.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 121 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptBlock.cs:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (15 lines × 3) src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:58— src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:58-72 | src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs:129-143 | src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStep.cs:52-66 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (14–15 lines × 3) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:84— src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentPartDefinitionBuilder.cs:84-98 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypeDefinitionBuilder.cs:84-97 | src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Builders/ContentTypePartDefinitionBuilder.cs:41-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12–13 lines × 5) src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:32— src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:32-43 | src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs:60-71 | src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs:51-62 | src/OrchardCore.Modules/OrchardCore.Lucene/DataMigrations/IndexingMigrations.cs:44-55 | src/OrchardCore/OrchardCore.Queries.Core/QueriesDocumentMigrationHelper.cs:21-33 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AzureAI/Migrations/AzureAISearchIndexSettingsMigrations.cs` and `src/OrchardCore.Modules/OrchardCore.Elasticsearch/Migrations/IndexingMigrations.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 127 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 5) REDACTED:80— REDACTED:80-93 | src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:87-99 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:87-99 | src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs:90-102 | REDACTED:84-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:97` calls `Select`, `ToList` and `src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:103` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 6) REDACTED:81— REDACTED:81-93 | src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:88-99 | src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:88-99 | src/OrchardCore.Modules/OrchardCore.Sitemaps/Controllers/SitemapIndexController.cs:83-95 | src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs:91-102 | REDACTED:85-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 6 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 6 times. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:81` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:97` calls `Select`, `ToList` and `src/OrchardCore.Modules/OrchardCore.Placements/Controllers/AdminController.cs:103` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 4) src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs:123— src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs:123-128 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs:240-245 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdValidationConfiguration.cs:258-263 | src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdValidationConfiguration.cs:283-288 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdClientConfiguration.cs:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 3) src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:72— src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:72-82 | src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs:66-77 | src/OrchardCore.Modules/OrchardCore.Menu/Drivers/MenuItemPermissionPartDisplayDriver.cs:52-63 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs` and `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/PlaceholderAdminNodeDriver.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.AdminMenu/AdminNodes/LinkAdminNodeDriver.cs:72` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `treeNode` to `LinkAdminNode` in one and `PlaceholderAdminNode` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9–12 lines × 3) src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:24— src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:24-32 | src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs:31-42 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs:26-34 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (11–12 lines × 2) src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:31— src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:31-41 | src/OrchardCore.Modules/OrchardCore.Markdown/GraphQL/MarkdownFieldQueryObjectType.cs:36-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `ctx` to `IResolveFieldContext<HtmlField>` in one and `IResolveFieldContext<MarkdownField>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 3) src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:79— src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:79-85 | src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:92-98 | src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:105-111 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs:79` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–11 lines × 2) src/OrchardCore.Modules/OrchardCore.Navigation/NavigationShapes.cs:72— src/OrchardCore.Modules/OrchardCore.Navigation/NavigationShapes.cs:72-80 | src/OrchardCore.Modules/OrchardCore.Navigation/NavigationShapes.cs:83-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Navigation/NavigationShapes.cs:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–10 lines × 3) src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:10— src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:10-18 | src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs:10-19 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs:11-19 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7–10 lines × 2) src/OrchardCore.Modules/OrchardCore.Liquid/Drivers/LiquidFieldDisplayDriver.cs:72— src/OrchardCore.Modules/OrchardCore.Liquid/Drivers/LiquidFieldDisplayDriver.cs:72-81 | src/OrchardCore.Modules/OrchardCore.Liquid/Drivers/LiquidPartDisplayDriver.cs:61-67 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Liquid/Drivers/LiquidFieldDisplayDriver.cs:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `UpdateFieldEditorContext` in one and `UpdatePartEditorContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (3–10 lines × 3) REDACTED:447— REDACTED:447-456 | REDACTED:497-499 | REDACTED:603-611 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:447` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7–9 lines × 2) src/OrchardCore.Modules/OrchardCore.Media.Azure/Startup.cs:103— src/OrchardCore.Modules/OrchardCore.Media.Azure/Startup.cs:103-109 | src/OrchardCore.Modules/OrchardCore.Media/Startup.cs:124-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 4) src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:17— src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationSettings.cs:17-24 | src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs:24-31 | src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs:31-40 | src/OrchardCore.Modules/OrchardCore.OpenId/ViewModels/OpenIdServerSettingsViewModel.cs:26-33 — before extracting anything, compare `src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdServerSettingsStepModel.cs` and `src/OrchardCore.Modules/OrchardCore.OpenId/Settings/OpenIdServerSettings.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6–7 lines × 3) src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:37— src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/HtmlFieldQueryObjectType.cs:37-42 | src/OrchardCore.Modules/OrchardCore.Liquid/GraphQL/LiquidFieldQueryObjectType.cs:34-40 | src/OrchardCore.Modules/OrchardCore.Markdown/GraphQL/MarkdownFieldQueryObjectType.cs:42-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/OrchardCore.Modules/OrchardCore.Liquid/GraphQL/LiquidFieldQueryObjectType.cs:34` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `ctx` to `IResolveFieldContext<HtmlField>` in one and `IResolveFieldContext<MarkdownField>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Coverage not measured — .NET suite — Coverage NOT MEASURED: the .NET half could not be measured — the repository runs its tests on Microsoft.Testing.Platform and wires up no coverage extension for it; the JavaScript/TypeScript half measured 68.0% (vitest + @vitest/coverage-v8 via `yarn install --immutable --mode=skip-build` in src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/). This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
P12 · CI test-gate honesty· Test project never run by CI · ×1
Test project never run by CI test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj:1— `test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj` declares 45 test(s), but no CI command runs it — it is not in the solution the pipeline tests and no step names it, so its tests gate nothing. Add it to the solution (or a test step), or delete it.
Forked directory tree (19 identical files, ~470 lines × 2 trees) src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/sb-watch.js:1— src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/ and src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/ are near-verbatim copies of each other: 19 files are byte-identical under the same relative paths (~470 lines; the trees hold 47 and 32 files). That is one structural fact, not 19 local ones: every edit made to one tree and not the other drifts silently, which is the failure whole-tree forks guarantee. Pick one tree as the single source and produce the other from it (generated, copied at build or release time, or re-exported) — or, if the copy is a stale snapshot nothing produces any more, delete it. Check first whether the copy is a deliberately published deliverable (a template consumers copy verbatim, a released sample frozen at a version); where it is, keep it produced from the source tree rather than edited in place.
Forked directory tree (18 identical files, ~449 lines × 2 trees) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:1— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/ and src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/ are near-verbatim copies of each other: 18 files are byte-identical under the same relative paths (~449 lines; the trees hold 52 and 32 files). That is one structural fact, not 18 local ones: every edit made to one tree and not the other drifts silently, which is the failure whole-tree forks guarantee. Pick one tree as the single source and produce the other from it (generated, copied at build or release time, or re-exported) — or, if the copy is a stale snapshot nothing produces any more, delete it. Check first whether the copy is a deliberately published deliverable (a template consumers copy verbatim, a released sample frozen at a version); where it is, keep it produced from the source tree rather than edited in place.
Duplication concentrated across 33 sibling directories (34 clone groups) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1— 34 duplicated blocks under src/OrchardCore.Modules/ have copies in at least two of the sibling directories OrchardCore.AdminMenu, OrchardCore.Apis.GraphQL, OrchardCore.AuditTrail, OrchardCore.Autoroute, OrchardCore.ContentFields, OrchardCore.DataLocalization (+27 more sibling(s) not listed) — 28 of them are reported below, and 6 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 34 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 34 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 34 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 5 sibling directories (9 clone groups) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3— 9 of the duplicated blocks reported below have copies in at least two of the sibling directories TheAdmin, TheAgencyTheme, TheBlogTheme, TheComingSoonTheme, TheTheme under src/OrchardCore.Themes/. That concentration is one structural fact, not 9 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 9 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 14 sibling directories (8 clone groups) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1428— 8 duplicated blocks under src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/ have copies in at least two of the sibling directories cleanpaste, colors, emoji, fontfamily, fontsize, giphy (+8 more sibling(s) not listed) — 6 of them are reported below, and 2 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 2 sibling directories (5 clone groups) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5— 5 of the duplicated blocks reported below have copies in at least two of the sibling directories media-gallery, media-picker under src/OrchardCore.Modules/OrchardCore.Media/Assets/. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication· Duplicated block with local edits (150 matched lines × 2 locations) · ×1
Duplicated block with local edits (150 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/PipelinePanel.vue:23— src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/PipelinePanel.vue:23 · src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue:20 — the two spans are one implementation copied and then locally edited — 1072 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (107 matched lines × 2 locations) · ×1
Duplicated block with local edits (107 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:194— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:194 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldGallery.vue:132 — the two spans are one implementation copied and then locally edited — 680 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (97 matched lines × 2 locations) · ×1
Duplicated block with local edits (97 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:256— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:256 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:203 — the two spans are one implementation copied and then locally edited — 569 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Wholesale file copy (67 identical lines × 4 files) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:1 · src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.url.ts:1 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.tag.ts:1 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.url.ts:1 — these 4 files are line-for-line copies of one another — 67 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
Wholesale file copy (51 identical lines × 3 files) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/sb-watch.js:3 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/sb-watch.js:3 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/sb-watch.js:3 — these 3 files are line-for-line copies of one another — 51 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
Duplicated block (30 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:35— src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:35 · src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts:72 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (28 lines × 4 locations) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:23— src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:23 · src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flows.edit.ts:62 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:22 · src/OrchardCore.Modules/OrchardCore.Widgets/Assets/ts/widgetslist.edit.ts:62 — the 4 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication· Duplicated block with local edits (27 matched lines × 2 locations) · ×1
Duplicated block with local edits (27 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/ConfirmModalService.ts:7— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/ConfirmModalService.ts:7 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileActionModalService.ts:7 — the two spans are one implementation copied and then locally edited — 154 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (24 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:28— src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:28 · src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-viewer.ts:12 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (24 lines × 3 locations) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-pug.js:8— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-pug.js:8 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/render-pug.js:8 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/render-pug.js:8 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (23 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vitest.config.ts:5 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/vitest.config.ts:4 — the 2 copies are spread across 2 files, and the CITED SPAN is a run of DECLARATIONS inside a construct — the members of a type, or the entries of an object or array literal — with no statement anywhere in it. Do not read this as an extract-a-helper row: nothing here executes, so there is no call site, and a call expression cannot stand where a member declaration or a literal's entry was. What repeats is a SHAPE, and which shape decides the move. Where the copies declare the same members, the repetition is a missing common ancestor: give it a base type, an interface both extend, a generic instantiated twice, or — where the copies are a literal's entries rather than a type's members — one shared constant each site spreads or refers to, so the set is written once. Where they declare DIFFERENT members and only the form is shared — a decorator and its options, an annotation, a registration table's keys — the form is prescribed by a framework or a schema rather than copied, and the only collapse available is to generate the declarations from that schema; where you do not own the generator, this is the cost of the framework and there is nothing to extract. Check which of the two it is before acting: these copies still drift apart the first time only one of them is edited, which is why the repetition is reported, but the sentence to act on is not the same in both cases.
Duplicated block (22 lines × 3 locations) src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-scss.js:13— src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/scripts/render-scss.js:13 · src/OrchardCore.Themes/TheBlogTheme/Assets/TheBlogTheme/scripts/render-scss.js:13 · src/OrchardCore.Themes/TheComingSoonTheme/Assets/TheComingSoonTheme/scripts/render-scss.js:13 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (20 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.config.ts:12— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/vite.config.ts:12 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/vite.config.ts:16 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (19 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:5— src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:5 · src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/placeholder-admin-node.ts:5 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
Duplicated block (16 lines × 3 locations) src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:2— src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/link-admin-node.ts:2 · src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets/ts/placeholder-admin-node.ts:2 · src/OrchardCore.Modules/OrchardCore.Localization/Assets/ts/localization-settings.ts:1 — the 3 copies are spread across 3 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
Duplicated block (16 lines × 5 locations) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:46— src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts:46 · src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.url.ts:47 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.tag.ts:46 · src/OrchardCore.Modules/OrchardCore.Html/Assets/trumbowyg.media.url.ts:47 · +1 more site(s) not listed — the 5 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 5 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R10 · Code Duplication· Duplicated block with local edits (16 matched lines × 2 locations) · ×1
Duplicated block with local edits (16 matched lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-index.ts:1— src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-index.ts:1 · src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-type-index.ts:1 — the two spans are one implementation copied and then locally edited — 96 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (15 lines × 3 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:343 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/main.ts:67 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaPickerModal.vue:104 — the 3 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
Duplicated block (15 lines × 2 locations) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:158— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldBasic.vue:158 · src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldGallery.vue:109 — the 2 copies are spread across 2 files, and the CITED SPAN is a run of MODULE-LEVEL DECLARATIONS — bindings the module declares and exports — rather than statements with a call site. Do not read this as an extract-a-helper row: a call expression cannot stand where a declaration was, and putting one there would delete the names themselves, which are what the rest of the codebase imports. What actually repeats here is the INITIALISER — the same expression shape written once per binding. So give that expression one name (a small helper the initialisers call, or a shared base value they are each derived from) and keep every binding under the name it already has. Where the run is an enumeration — one binding per distinct thing, differing precisely in the thing each one names — the repetition IS the enumeration and collapsing it would delete entries; consider instead whether the set belongs in one exported table the individual names are read out of. Reported because the copies drift apart the first time only one of them is edited.
Complex function getOptions (cyclomatic 56, cognitive 54) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:84— getOptions has cyclomatic complexity 56 and cognitive complexity 54; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function orientOutcomeLabels (cyclomatic 30, cognitive 49) src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-canvas.ts:148— orientOutcomeLabels has cyclomatic complexity 30 and cognitive complexity 49; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 28, cognitive 27) src/OrchardCore.Modules/OrchardCore.MiniProfiler/Assets/ts/miniprofiler.ts:190— (anonymous) has cyclomatic complexity 28 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function validateRule (cyclomatic 23, cognitive 17) src/OrchardCore.Modules/OrchardCore.Forms/Assets/js/form-visibility-rules.js:258— validateRule has cyclomatic complexity 23 and cognitive complexity 17; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function updateFilterRow (cyclomatic 21, cognitive 18) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:97— updateFilterRow has cyclomatic complexity 21 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function onEnd (cyclomatic 20, cognitive 18) src/OrchardCore.Modules/OrchardCore.Layers/Assets/ts/layers-index.ts:13— onEnd has cyclomatic complexity 20 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function openNodeMenu (cyclomatic 16, cognitive 25) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/canvas/DesignerCanvas.vue:239— openNodeMenu has cyclomatic complexity 16 and cognitive complexity 25; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 15, cognitive 30) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:685— (anonymous) has cyclomatic complexity 15 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function getLiquidContextInfo (cyclomatic 15, cognitive 27) src/OrchardCore.Modules/OrchardCore.Liquid/Assets/monaco/liquid-intellisense.ts:91— getLiquidContextInfo has cyclomatic complexity 15 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function getActiveClientFilters (cyclomatic 15, cognitive 18) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:243— getActiveClientFilters has cyclomatic complexity 15 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function getFilterState (cyclomatic 15, cognitive 14) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:51— getFilterState has cyclomatic complexity 15 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 14, cognitive 21) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/FileLibraryManager.ts:351— (anonymous) has cyclomatic complexity 14 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function updateGroup (cyclomatic 14, cognitive 15) src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:637— updateGroup has cyclomatic complexity 14 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function loadIndex (cyclomatic 14, cognitive 13) src/OrchardCore.Modules/OrchardCore.Admin/Assets/js/quick-navigation.ts:220— loadIndex has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function refreshFlows (cyclomatic 14, cognitive 13) src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-client-settings.ts:21— refreshFlows has cyclomatic complexity 14 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function convertToFileHierarchyTreeNode (cyclomatic 13, cognitive 24) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/HierarchicalTreeBuilder.ts:142— convertToFileHierarchyTreeNode has cyclomatic complexity 13 and cognitive complexity 24; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 13, cognitive 16) src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/Scripts/data-pipelines-editors.js:349— (anonymous) has cyclomatic complexity 13 and cognitive complexity 16; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function readConfig (cyclomatic 13, cognitive 11) src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/main.ts:36— readConfig has cyclomatic complexity 13 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js · ×1
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js: 1480 lines of code src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js:1— src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js has 1480 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js · ×1
src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js: 1401 lines of code src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js:1— src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js has 1401 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue · ×1
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue: 800 lines of code src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue:1— src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/App.vue has 800 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js · ×1
src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js: 586 lines of code src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js:1— src/OrchardCore.Modules/OrchardCore.Resources/Assets/js/list-management.js has 586 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts · ×1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts: 568 lines of code src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts:1— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/UppyFileUpload.ts has 568 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue · ×1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue: 517 lines of code src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue:1— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/App.vue has 517 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue · ×1
src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue: 447 lines of code src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue:1— src/OrchardCore.Modules/OrchardCore.DataPipelines/Assets/designer/src/panel/StepPanel.vue has 447 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files· src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue · ×1
src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue: 412 lines of code src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue:1— src/OrchardCore.Modules/OrchardCore.Media/Assets/media-picker/src/components/MediaFieldAttached.vue has 412 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
Dead file (~1683 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/table/trumbowyg.table.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~1488 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/emoji/trumbowyg.emoji.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~393 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontsize/trumbowyg.fontsize.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~324 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/upload/trumbowyg.upload.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~311 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/resizimg/trumbowyg.resizimg.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~299 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/colors/trumbowyg.colors.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~235 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/giphy/trumbowyg.giphy.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~216 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/lineheight/trumbowyg.lineheight.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~214 LoC) src/OrchardCore.Modules/OrchardCore.OpenId/Assets/ts/openid-server-settings.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~185 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/base64/trumbowyg.base64.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~173 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/history/trumbowyg.history.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~169 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/mathml/trumbowyg.mathml.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~162 LoC) REDACTED— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~157 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/preformatted/trumbowyg.preformatted.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~147 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/cleanpaste/trumbowyg.cleanpaste.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~134 LoC) src/OrchardCore.Modules/OrchardCore.Users/Assets/ts/external-login-settings.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~131 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/mention/trumbowyg.mention.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~121 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/insertaudio/trumbowyg.insertaudio.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~116 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/fontfamily/trumbowyg.fontfamily.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~115 LoC) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.url.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~111 LoC) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.media.tag.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~100 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/specialchars/trumbowyg.specialchars.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~72 LoC) src/OrchardCore.Modules/OrchardCore.Templates/Assets/ts/template-edit.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~70 LoC) src/OrchardCore.Modules/OrchardCore.Users/Assets/ts/user-fields.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~54 LoC) src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flow-widget-picker-button.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), but 3 in-repo import(s) from 3 other file(s) do name it (src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/bag-part-blocks.ts, src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-card-flow-part-blocks.ts, src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/flow-part-blocks.ts) — every one of those referrers is itself unreachable, so this file is dead only as a member of that cluster: if any referrer is in fact alive, this row falls with it
Dead file (~50 LoC) src/OrchardCore.Modules/OrchardCore.Users/Assets/ts/external-registration-settings.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~49 LoC) src/OrchardCore.Modules/OrchardCore.Resources/Assets/trumbowyg/plugins/pasteimage/trumbowyg.pasteimage.js— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Dead file (~41 LoC) src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/ts/text-field-icon-picker.ts— no import path from any entry point (188 application, 23 tooling, 62 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
Unlisted import 'bootstrap' src/OrchardCore.Modules/OrchardCore.Flows/Assets/ts/content-type-picker.ts:3— Imported only as a TYPE and declared in no reachable REDACTED. The import is erased at compile time, so nothing is installed and no runtime resolution depends on it — but type-checking a clean clone will fail. Declare the typings it resolves through (or the package itself) in the owning REDACTED.
Unused dependency 'child_process' — Declared in the root REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency 'es6-promise' — Declared in the root REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Unused dependency 'graceful-fs' — Declared in the root REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Third-party script without Subresource Integrity src/OrchardCore.Themes/TheAgencyTheme/Assets/TheAgencyTheme/src/pug/index.pug:17— `https://use.fontawesome.com/releases/v6.3.0/js/all.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 9 such include(s) across the repository's markup.
Blocking `File.WriteAllText` inside an `async` method src/OrchardCore.Modules/OrchardCore.Deployment/Controllers/ImportController.cs:179— `File.WriteAllText` blocks the thread on I/O while `File.WriteAllTextAsync` exists to wait without one — inside a method that is already `async`, await the twin.
X15 · Unvalidated length from an untrusted reader· Length read from the parsed input is spent without ever being bounded · ×1
Length read from the parsed input is spent without ever being bounded src/OrchardCore/OrchardCore.DataSources.Core/Operations/DataRowSerializer.cs:51— `length` is read from the stream being parsed at line 44 (`ReadInt32`), then used to size an array at line 51 — and nowhere in this method is `length` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). A file the caller did not write therefore chooses the size directly: a value near `int.MaxValue` allocates until the process dies, and a value that overflows the cast to `int` goes negative and throws out of a parser whose failure path was written for malformed input, not for hostile input. Bound `length` against the bytes actually remaining in the stream before spending it.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×1
Disposes a dependency it does not own src/OrchardCore/OrchardCore.DataPipelines.Core/Steps/DataPipelineRowReader.cs:139— `_batches` is never created by `DataPipelineRowReader` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 139). Its declared type `IAsyncEnumerator` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Orphaned file src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore/Shell/Removing/ShellRemovalManager.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Data.YesSql/Removing/ShellDbTablesRemovingHandler.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/RewriteRulesManager.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Forms/Drivers/FormInputElementVisibilityPartDisplayDriver.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Abstractions/Shell/Configuration/Internal/JsonConfigurationParser.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Contents/VersionPruning/Services/ContentVersionPruningService.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Abstractions/Shell/Extensions/ShellSettingsExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/AwsTenantEventsBase.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.OpenId/Migrations/PushedAuthorizationRequestsMigration.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Json/GraphQLNamedQueryRequestJsonConverter.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/AwsStorageOptionsExtension.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRedirectRuleDisplayDriver.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRedirectRuleHandler.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.UrlRewriting.Core/Handlers/UrlRewriteRuleHandler.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore/Modules/Extensions/ShellPipelineExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Users.Core/Authentication/CacheTicketStore.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/UrlRewriteRuleDisplayDriver.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Data.YesSql.Abstractions/DataMigrationExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.OpenId.Core/Services/Managers/OpenIdAuthorizationManager.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.UrlRewriting/Drivers/RewriteRulesDisplayDriver.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.Abstractions/Shell/Configuration/Internal/ConfigurationExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.OpenId.Core/Services/Managers/OpenIdScopeManager.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownBodyPartWysiwygEditorSettingsDriver.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/OrchardCore/OrchardCore.UrlRewriting.Abstractions/IRewriteRuleHandler.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
README/code drift .scripts/bloom/designer/README.md:46— .scripts/bloom/designer/README.md runs `yarn vitest run`, but no REDACTED declares a `vitest` script. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/contributing/contributing-documentation.md:17— src/docs/contributing/contributing-documentation.md names `OrchardCore.sln`, but no file or folder `OrchardCore.sln` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/contributing/contributing-documentation.md:28— src/docs/contributing/contributing-documentation.md names `reference/modules/README.md`, but no file or folder `reference/modules/README.md` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-field.md:122— src/docs/development/media/media-field.md names `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue`, but no file or folder `src/OrchardCore.Modules/OrchardCore.Media/Assets/media-field/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:236— src/docs/development/media/media-gallery.md names `media-gallery/src/components/MediaPickerModal.vue`, but no file or folder `media-gallery/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:272— src/docs/development/media/media-gallery.md names `media-gallery/src/trumbowyg/`, but no file or folder `media-gallery/src/trumbowyg` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:321— src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/components/MediaPickerModal.vue`, but no file or folder `Assets/media-gallery/src/components/MediaPickerModal.vue` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:322— src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/trumbowyg/trumbowyg.media.tag.ts`, but no file or folder `Assets/media-gallery/src/trumbowyg/trumbowyg.media.tag.ts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:323— src/docs/development/media/media-gallery.md names `Assets/media-gallery/src/trumbowyg/trumbowyg.media.url.ts`, but no file or folder `Assets/media-gallery/src/trumbowyg/trumbowyg.media.url.ts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/development/media/media-gallery.md:327— src/docs/development/media/media-gallery.md names `Assets/media-picker/src/assets/field.css`, but no file or folder `Assets/media-picker/src/assets/field.css` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/add-admin-menu/README.md:188— src/docs/guides/add-admin-menu/README.md runs ``dotnet run --project .\MySite\MySite.csproj``, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/assets-manager/README.md:62— src/docs/guides/assets-manager/README.md runs `yarn {build, watch or host} -n asset-name1, asset-name2`, but no REDACTED declares a `{build,` script. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/assets-manager/README.md:244— src/docs/guides/assets-manager/README.md changes into `C:/repo/OrchardCore/src`, but no such folder exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-admin-theme/README.md:52— src/docs/guides/create-admin-theme/README.md runs `dotnet run --project .\MySite\MySite.csproj`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-blazor-cms/README.md:9— src/docs/guides/create-blazor-cms/README.md names .NET 8, but the projects target .NET 10. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-blazor-cms/README.md:29— src/docs/guides/create-blazor-cms/README.md runs `dotnet run --project ./BlazorCms/BlazorCms.csproj`, but `./BlazorCms/BlazorCms.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-cms-application/README.md:33— src/docs/guides/create-cms-application/README.md runs `dotnet run --project .\MySite\MySite.csproj`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-modular-application-mvc/README.md:51— src/docs/guides/create-modular-application-mvc/README.md runs `dotnet run --project .\OrchardCore.Mvc.Web\OrchardCore.Mvc.Web.csproj`, but `./OrchardCore.Mvc.Web/OrchardCore.Mvc.Web.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/create-modular-application-mvc/README.md:54— src/docs/guides/create-modular-application-mvc/README.md runs `dotnet restore .\MySite\MySite.csproj --source https://nuget.cloudsmith.io/orchardcore/preview/v3/index.json`, but `./MySite/MySite.csproj` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/gulp-pipeline/README.md:17— src/docs/guides/gulp-pipeline/README.md names `src/gulpfile.js`, but no file or folder `src/gulpfile.js` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/guides/microsoft-entra-id-integration/README.md:3— src/docs/guides/microsoft-entra-id-integration/README.md names the project `OrchardCore.MicrosoftAuthentication.AzureAD`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/topics/display/shapes.md:271— src/docs/topics/display/shapes.md names `Content-BlogPost.cshtml`, but no file or folder `Content-BlogPost.cshtml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/topics/display/shapes.md:272— src/docs/topics/display/shapes.md names `Content-BlogPost.Summary.cshtml`, but no file or folder `Content-BlogPost.Summary.cshtml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/topics/docker/README.md:82— src/docs/topics/docker/README.md runs `docker image prune -f --filter label=stage=build-env`, but `--filter` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift src/docs/reference/modules/Contents/README.md:149— src/docs/reference/modules/Contents/README.md names the project `OrchardCore.IOrchardHelper`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every REDACTED, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
Commented-out code src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/ValidationRules/RequiresPermissionValidationRule.cs:56— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Contents/ViewModels/PublishContentViewModel.cs:9— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Demo/Startup.cs:117— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:105— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Features/Services/ModuleService.cs:123— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Forms/GraphQL/Startup.cs:23— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Rules/Services/ConditionResolver.cs:24— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore.Modules/OrchardCore.Users/Drivers/AuthenticatorAppLoginSettingsDisplayDriver.cs:51— 4 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.Abstractions/Modules/Overrides/Configuration/TenantJsonConfigurationExtensions.cs:67— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.Abstractions/Modules/Overrides/Configuration/TenantJsonConfigurationExtensions.cs:72— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.Abstractions/Modules/Overrides/Configuration/TenantJsonConfigurationExtensions.cs:103— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:766— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs:774— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:88— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:89— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:162— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:163— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:170— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:171— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:196— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:197— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:262— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:263— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:267— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/OrchardCore/OrchardCore.DisplayManagement.Liquid/TagHelpers/RequiredAttributeParser.cs:268— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Duplicated predicate src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs:55— `!CanMigrate(settings) || !await AuthorizeAsync()` appears character-identically in 10 files — src/OrchardCore.Modules/OrchardCore.AzureAI/Drivers/AzureAISearchSecretMigrationDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Email.Azure/Drivers/AzureEmailSecretMigrationDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Email.Smtp/Drivers/SmtpSecretMigrationDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Facebook/Drivers/FacebookSecretMigrationDisplayDriver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/CreateContentTask.cs:86— `!Publish && InlineEvent.Name == nameof(ContentDraftSavedEvent)` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/CreateContentTask.cs, src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/UpdateContentTask.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs:48— `!await authorizationService.AuthorizeAsync(httpContext.User, MediaPermissions.ManageMedia) || !await authorizationService.AuthorizeAsync(htt…` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/CopyMediaEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/MoveMediaEndpoint.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteFolderEndpoint.cs:41— `!await authorizationService.AuthorizeAsync(httpContext.User, MediaPermissions.ManageMedia) || !await authorizationService.AuthorizeAsync(htt…` appears character-identically in 6 files — src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteFolderEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/DeleteMediaEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryContentEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetFoldersEndpoint.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetAllMediaItemsEndpoint.cs:44— `!await authorizationService.AuthorizeAsync(httpContext.User, MediaPermissions.ManageMedia) || !await authorizationService.AuthorizeAsync(htt…` appears character-identically in 3 files — src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetAllMediaItemsEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetDirectoryTreeEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetPermittedStorageEndpoint.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs:268— `!certificate.Archived && certificate.HasPrivateKey` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs, src/OrchardCore.Modules/OrchardCore.Secrets/Drivers/X509SecretDisplayDriver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs:43— `!content.StartsWith("//", StringComparison.Ordinal) && !content.StartsWith("http", StringComparison.OrdinalIgnoreCase)` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/AssetUrlShortcodeProvider.cs, src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Alias/Indexes/AliasPartIndex.cs:62— `!contentItem.Published && !contentItem.Latest` appears character-identically in 14 files — src/OrchardCore.Modules/OrchardCore.AdminDashboard/Indexes/DashboardPartIndex.cs, src/OrchardCore.Modules/OrchardCore.Alias/Indexes/AliasPartIndex.cs, src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/BooleanFieldIndexProvider.cs, src/OrchardCore.Modules/OrchardCore.ContentFields/Indexing/SQL/ContentPickerFieldIndexProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs:74— `!filterByExtensions || allowedExtensions.Contains(Path.GetExtension(entry.Path))` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetMediaItemsEndpoint.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/MediaEndpointHelpers.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore/OrchardCore.Indexing.Core/Recipes/RebuildIndexStep.cs:29— `!model.IncludeAll && (model.IndexNames == null || model.IndexNames.Length == 0)` appears character-identically in 2 files — src/OrchardCore/OrchardCore.Indexing.Core/Recipes/RebuildIndexStep.cs, src/OrchardCore/OrchardCore.Indexing.Core/Recipes/ResetIndexStep.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs:27— `!model.IncludeAll && (model.Indices == null || model.Indices.Length == 0)` appears character-identically in 2 files — src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexRebuildStep.cs, src/OrchardCore/OrchardCore.AzureAI.Core/Recipes/AzureAISearchIndexResetStep.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldTrumbowygEditorSettingsDriver.cs:45— `!options.StartsWith('{') || !options.EndsWith('}')` appears character-identically in 4 files — src/OrchardCore.Modules/OrchardCore.ContentFields/Settings/HtmlFieldTrumbowygEditorSettingsDriver.cs, src/OrchardCore.Modules/OrchardCore.Html/Settings/HtmlBodyPartTrumbowygEditorSettingsDriver.cs, src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownBodyPartWysiwygEditorSettingsDriver.cs, src/OrchardCore.Modules/OrchardCore.Markdown/Settings/MarkdownFieldWysiwygEditorSettingsDriver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:785— `!provider.HasConnectionString || !string.IsNullOrWhiteSpace(connectionString)` appears character-identically in 2 files — REDACTED, src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdClientService.cs:56— `!settings.Authority.IsAbsoluteUri || !settings.Authority.IsWellFormedOriginalString()` appears character-identically in 3 files — src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdClientService.cs, src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs, src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdValidationService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/ContentPickerFieldDisplayDriver.cs:120— `!settings.Multiple && field.ContentItemIds.Length > 1` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/ContentPickerFieldDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.ContentFields/Handlers/ContentPickerFieldHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LocalizationSetContentPickerFieldDisplayDriver.cs:98— `!settings.Multiple && field.LocalizationSets.Length > 1` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/LocalizationSetContentPickerFieldDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.ContentFields/Handlers/LocalizationSetContentPickerFieldHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/UserPickerFieldDisplayDriver.cs:87— `!settings.Multiple && field.UserIds.Length > 1` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.ContentFields/Drivers/UserPickerFieldDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.ContentFields/Handlers/UserPickerFieldHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldDisplayDriver.cs:77— `!string.Equals(typeof(TField).Name, partFieldDefinition.FieldDefinition.Name, StringComparison.Ordinal) && !string.Equals(nameof(ContentFiel…` appears character-identically in 2 files — src/OrchardCore/OrchardCore.ContentManagement.Display/ContentDisplay/ContentFieldDisplayDriver.cs, src/OrchardCore/OrchardCore.Indexing.Abstractions/ContentFieldIndexHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs:116— `!string.IsNullOrEmpty(contentTypeId) && string.IsNullOrEmpty(entry["ContentTypeName"]?.GetValue<string>())` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.AdminMenu/Migrations.cs, src/OrchardCore.Modules/OrchardCore.AdminMenu/Recipes/AdminMenuStep.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:127— `!string.IsNullOrEmpty(model.Email) && !_emailAddressValidator.Validate(model.Email)` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs, src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Alias/Settings/AliasPartSettingsDisplayDriver.cs:45— `!string.IsNullOrEmpty(model.Pattern) && !_templateManager.Validate(model.Pattern, out var errors)` appears character-identically in 3 files — src/OrchardCore.Modules/OrchardCore.Alias/Settings/AliasPartSettingsDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Autoroute/Settings/AutoroutePartSettingsDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.ContentPreview/Settings/PreviewPartSettingsDisplayDriver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs:46— `!string.IsNullOrEmpty(model.SelectedOperation) && _options.Factories.TryGetValue(model.SelectedOperation, out var factory)` appears character-identically in 4 files — src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Rules/Drivers/CultureConditionDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Rules/Drivers/RoleConditionDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.Rules/Drivers/UrlConditionDisplayDriver.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs:132— `!string.IsNullOrEmpty(model.UserName) && model.UserName.Any(c => !_identityOptions.User.AllowedUserNameCharacters.Contains(c))` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs, src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/TenantApiController.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:211— `!string.IsNullOrEmpty(name) && !string.IsNullOrEmpty(src)` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs, src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs:207— `!string.IsNullOrEmpty(name) && string.IsNullOrEmpty(src)` appears character-identically in 2 files — src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs, src/OrchardCore.Modules/OrchardCore.Resources/Liquid/StyleTag.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Silent fallback default on parse failure src/OrchardCore.Modules/OrchardCore.Liquid/Filters/LocalTimeZoneFilter.cs:31— `ProcessAsync` returns `NilValue.Instance` when `DateTimeOffset.TryParse(stringValue, ctx.Options.CultureInfo, DateTimeStyles.Ass…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore.Modules/OrchardCore.Liquid/Filters/UtcTimeZoneFilter.cs:31— `ProcessAsync` returns `NilValue.Instance` when `DateTimeOffset.TryParse(stringValue, ctx.Options.CultureInfo, DateTimeStyles.Ass…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore.Modules/OrchardCore.Media/Services/DistributedMediaTusStore.cs:111— `GetUploadOffsetAsync` falls back to `0L` when `long.TryParse(text, out var offset)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlLiquidOutputExpressionDetector.cs:28— `ContainsOutputStatement` returns `false` when `_parser.TryParse(query, out var template, out _)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore.Modules/OrchardCore.DataPipelines/Services/DataPipelineFileLinkHandler.cs:83— `OpenAsync` falls back to `"application/octet-stream"` when `link.Properties.TryGetValue(ContentTypeProperty, out var value) && !string.IsNul…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresOnTag.cs:30— `WriteToAsync` returns `Completion.Normal` when `DateTimeOffset.TryParse(stringValue, context.CultureInfo, DateTimeStyles.AssumeU…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Cache/CacheExpiresSlidingTag.cs:30— `WriteToAsync` returns `Completion.Normal` when `TimeSpan.TryParse(stringValue, out value)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.DisplayManagement/Arguments.cs:247— `this[]` falls back to `default` when `_nameToIndex.TryGetValue(key, out var index)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.DisplayManagement/Events/ThemeFeaturesProvider.cs:50— `GetFeatures` falls back to `0` when `int.TryParse(moduleInfo.Priority, out var priority)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.DisplayManagement/TagHelpers/UserDisplayNameTagHelper.cs:22— `ProcessAsync` returns `Task.CompletedTask` when `Properties.TryGetValue(nameof(UserName), out var name)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/OrchardCore/OrchardCore.Lucene.Core/LuceneIndexStore.cs:136— `WriteAsync` returns `Task.CompletedTask` when `_writers.TryGetValue(index.Id, out var writer)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Fat interface: IContentManager (20 members) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/IContentManager.cs:8— `IContentManager` declares 20 members: `NewAsync`, `UpdateAsync`, `CreateAsync`, `CreateContentItemVersionAsync`, `UpdateContentItemVersionAsync`, `ImportAsync`, `ValidateAsync`, `RestoreAsync`, `GetAsync`, `GetAsync`, `GetVersionAsync`, `GetAllVersionsAsync`, `LoadAsync`, `RemoveAsync`, `DiscardDraftAsync`, `SaveDraftAsync`, `PublishAsync`, `UnpublishAsync`, `PopulateAspectAsync`, `CloneAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 20 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentFieldHandler (27 members) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentFieldHandler.cs:6— `IContentFieldHandler` declares 27 members: `ActivatedAsync`, `ActivatingAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentHandler (29 members) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentHandler.cs:3— `IContentHandler` declares 29 members: `ActivatingAsync`, `ActivatedAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `RestoringAsync`, `RestoredAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentPartHandler (27 members) src/OrchardCore/OrchardCore.ContentManagement.Abstractions/Handlers/IContentPartHandler.cs:6— `IContentPartHandler` declares 27 members: `ActivatedAsync`, `ActivatingAsync`, `InitializingAsync`, `InitializedAsync`, `CreatingAsync`, `CreatedAsync`, `LoadingAsync`, `LoadedAsync`, `ImportingAsync`, `ImportedAsync`, `UpdatingAsync`, `UpdatedAsync`, `ValidatingAsync`, `ValidatedAsync`, `VersioningAsync`, `VersionedAsync`, `DraftSavingAsync`, `DraftSavedAsync`, `PublishingAsync`, `PublishedAsync`, `UnpublishingAsync`, `UnpublishedAsync`, `RemovingAsync`, `RemovedAsync`, `GetContentItemAspectAsync`, `CloningAsync`, `ClonedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentDefinitionService (16 members) src/OrchardCore/OrchardCore.ContentTypes.Abstractions/IContentDefinitionService.cs:9— `IContentDefinitionService` declares 16 members under just 15 distinct name(s): `AddTypeAsync`, `RemoveTypeAsync`, `AddPartToTypeAsync`, `AddReusablePartToTypeAsync`, `RemovePartFromTypeAsync`, `AddPartAsync`, `RemovePartAsync`, `AddFieldToPartAsync`, `AddFieldToPartAsync`, `RemoveFieldFromPartAsync`, `AlterFieldAsync`, `AlterTypePartAsync`, `AlterTypePartsOrderAsync`, `AlterPartFieldsOrderAsync`, `GenerateContentTypeNameFromDisplayNameAsync`, `GenerateFieldNameFromDisplayNameAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IContentDefinitionEventHandler (17 members) src/OrchardCore/OrchardCore.ContentTypes.Abstractions/Events/IContentDefinitionEventHandler.cs:3— `IContentDefinitionEventHandler` declares 17 members: `ContentTypeCreated`, `ContentTypeUpdated`, `ContentTypeRemoved`, `ContentTypeImporting`, `ContentTypeImported`, `ContentPartCreated`, `ContentPartUpdated`, `ContentPartRemoved`, `ContentPartAttached`, `ContentPartDetached`, `ContentPartImporting`, `ContentPartImported`, `ContentTypePartUpdated`, `ContentFieldAttached`, `ContentFieldUpdated`, `ContentFieldDetached`, `ContentPartFieldUpdated`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IFileStore (16 members) src/OrchardCore/OrchardCore.FileStorage.Abstractions/IFileStore.cs:16— `IFileStore` declares 16 members under just 15 distinct name(s): `GetFileInfoAsync`, `GetDirectoryInfoAsync`, `GetDirectoryContentAsync`, `GetFilesAsync`, `GetDirectoriesAsync`, `TryCreateDirectoryAsync`, `TryDeleteFileAsync`, `TryDeleteDirectoryAsync`, `MoveFileAsync`, `CopyFileAsync`, `GetFileStreamAsync`, `GetFileStreamAsync`, `CreateFileFromStreamAsync`, `GetPermittedStorageAsync`, `Capabilities`, `StorageName`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: ISite (21 members) src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Settings/ISite.cs:6— `ISite` declares 21 members: `SiteName`, `PageTitleFormat`, `SiteSalt`, `SuperUser`, `Calendar`, `TimeZoneId`, `ResourceDebugMode`, `UseCdn`, `CdnBaseUrl`, `PageSize`, `MaxPageSize`, `MaxPagedCount`, `AllowPageSizeSelection`, `PageSizeOptions`, `BaseUrl`, `HomeRoute`, `AppendVersion`, `CacheMode`, `As`, `GetOrCreate`, `TryGet`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IResourceManager (24 members) src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/IResourceManager.cs:5— `IResourceManager` declares 24 members: `InlineManifest`, `FindResource`, `NotRequired`, `RegisterUrl`, `RegisterResource`, `RegisterHeadScript`, `RegisterFootScript`, `RegisterStyle`, `RegisterLink`, `RegisterMeta`, `AppendMeta`, `GetRequiredResources`, `GetRegisteredLinks`, `GetRegisteredMetas`, `GetRegisteredHeadScripts`, `GetRegisteredFootScripts`, `GetRegisteredStyles`, `RenderMeta`, `RenderHeadLink`, `RenderStylesheet`, `RenderHeadScript`, `RenderFootScript`, `RenderLocalScript`, `RenderLocalStyle`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IActivity (19 members) src/OrchardCore/OrchardCore.Workflows.Abstractions/Activities/IActivity.cs:9— `IActivity` declares 19 members: `Name`, `DisplayText`, `Category`, `Properties`, `HasEditor`, `GetPossibleOutcomesAsync`, `GetPossibleOutcomes`, `CanExecuteAsync`, `ExecuteAsync`, `ResumeAsync`, `OnInputReceivedAsync`, `OnWorkflowStartingAsync`, `OnWorkflowStartedAsync`, `OnWorkflowResumingAsync`, `OnWorkflowResumedAsync`, `OnWorkflowRestartingAsync`, `OnWorkflowRestartedAsync`, `OnActivityExecutingAsync`, `OnActivityExecutedAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Pass-through layer src/OrchardCore.Modules/OrchardCore.Placements/Services/DatabasePlacementsStore.cs:6— DatabasePlacementsStore: all 3 public methods forward their arguments unchanged to _documentManager and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _documentManager directly, or give the layer a job.
Pass-through layer src/OrchardCore.Modules/OrchardCore.Placements/Services/FilePlacementsStore.cs:7— FilePlacementsStore: all 3 public methods forward their arguments unchanged to _documentManager and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _documentManager directly, or give the layer a job.
Pass-through layer src/OrchardCore.Modules/OrchardCore.DynamicCache/Services/DefaultDynamicCache.cs:5— DefaultDynamicCache: all 3 public methods forward their arguments unchanged to _distributedCache and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _distributedCache directly, or give the layer a job.
Pass-through layer src/OrchardCore.Modules/OrchardCore.Redis/Services/RedisCacheWrapper.cs:13— RedisCacheWrapper: all 8 public methods forward their arguments unchanged to _cache and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _cache directly, or give the layer a job.
Pass-through layer src/OrchardCore.Modules/OrchardCore.Workflows/Services/ActivityDisplayManager.cs:14— ActivityDisplayManager: all 3 public methods forward their arguments unchanged to _displayManager and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _displayManager directly, or give the layer a job.
Pass-through layer src/OrchardCore/OrchardCore.ContentManagement/DatabaseContentDefinitionStore.cs:6— DatabaseContentDefinitionStore: all 3 public methods forward their arguments unchanged to _documentManager and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _documentManager directly, or give the layer a job.
Pass-through layer src/OrchardCore/OrchardCore.ContentManagement/FileContentDefinitionStore.cs:7— FileContentDefinitionStore: all 3 public methods forward their arguments unchanged to _documentManager and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _documentManager directly, or give the layer a job.
Pass-through layer src/OrchardCore/OrchardCore.DisplayManagement.Liquid/LazyViewLocalizer.cs:13— LazyViewLocalizer: all 3 public methods forward their arguments unchanged to Localizer and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call Localizer directly, or give the layer a job.
Pass-through layer src/OrchardCore/OrchardCore.DisplayManagement/ModelBinding/ControllerModelUpdater.cs:7— ControllerModelUpdater: all 5 public methods forward their arguments unchanged to _controller and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _controller directly, or give the layer a job.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.Menu/MenuShapes.cs:218— `IsSafeUrl` swallows `UriFormatException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs:369— `IsValidShortcodeName` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.Spatial/GraphQL/GeoPointGraphType.cs:31— `ParseValue` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.DataPipelines/Steps/Destinations/SendToWebApiStep.cs:340— `ReadStartAsync` swallows `Exception` into `return string.Empty;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.Workflows/Http/Scripting/HttpMethodsProvider.cs:222— `isValidJSON` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore/OrchardCore.DisplayManagement/Notify/NotifyFilter.cs:181— `SerializeNotifyEntry` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore/OrchardCore.Infrastructure/PhoneFormatValidator.cs:17— `IsValid` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore/OrchardCore.Secrets.Abstractions/X509Secret.cs:139— `GetCertificateFromStore` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/Sortable.js:173— `matches` swallows every exception into `return false` — a data error becomes a silent behavior change with no trail. Log the failure or let it raise. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing.
Mock-dominated test: CreateFileFromStreamAsync_FileEventHandlersRunCreatedAfterTheFileIsStored_Succeeds test/OrchardCore.Tests/Modules/OrchardCore.Media/MediaFileStoreExtensionsTests.cs:78— This test sets up 3 test doubles (for example `new Mock<IMediaFileStore>()`) against 1 real object(s) of its own, and its only verification is 1 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
Mock-dominated test: SaveSecretAsync_SavesTo_DefaultWritableStore test/OrchardCore.Tests/Modules/OrchardCore.Secrets/SecretManagerTests.cs:134— This test sets up 4 test doubles (for example `new Mock<ISecretStore>()`) against 2 real object(s) of its own, and its only verification is 2 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
Mock-dominated test: SaveSecretAsync_WithStoreName_SavesTo_SpecificStore test/OrchardCore.Tests/Modules/OrchardCore.Secrets/SecretManagerTests.cs:175— This test sets up 4 test doubles (for example `new Mock<ISecretStore>()`) against 2 real object(s) of its own, and its only verification is 2 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
Mock-dominated test: RemoveSecretAsync_RemovesFromAllWritableStores test/OrchardCore.Tests/Modules/OrchardCore.Secrets/SecretManagerTests.cs:216— This test sets up 5 test doubles (for example `new Mock<ISecretStore>()`) against 1 real object(s) of its own, and its only verification is 3 check(s) that the doubles were called. It pins how the code is wired, not what it does: it passes with a wrong result and fails when a call is harmlessly reordered or merged. Assert the outcome instead (the value returned, the state left behind), build collaborators and value objects for real or with a small hand-written fake, and keep doubles for the boundaries the test cannot own — the network, the clock, the file system.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 30 significant file(s) lose their only recent owner: src/OrchardCore/OrchardCore.AzureAI.Core/Services/AzureAISearchDocumentIndexManager.cs, src/OrchardCore.Modules/OrchardCore.BackgroundTasks/Controllers/BackgroundTaskController.cs, src/OrchardCore/OrchardCore.Media.Core/Services/ChunkFileUploadService.cs, src/OrchardCore/OrchardCore.Indexing.Core/Handlers/DefaultIndexProfileHandler.cs, src/OrchardCore/OrchardCore.Indexing.Core/IndexingTaskManager.cs, src/OrchardCore/OrchardCore.Elasticsearch.Core/Services/ElasticsearchService.cs, src/OrchardCore/OrchardCore.Infrastructure.Abstractions/Entities/EntityExtensions.cs, src/OrchardCore.Modules/OrchardCore.Deployment.Remote/Controllers/ImportRemoteInstanceController.cs (+22 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 16 significant file(s) lose their only recent owner: src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapeAttributeStrategy/ShapeAttributeBindingStrategy.cs, src/OrchardCore.Modules/OrchardCore.Workflows/Migrations.cs, src/OrchardCore/OrchardCore.SourceGenerators/FeatureAttributeTargetAnalyzer.cs, src/OrchardCore/OrchardCore.DisplayManagement/IShape.cs, src/OrchardCore/OrchardCore.DisplayManagement/Shapes/GroupShapes.cs, src/OrchardCore/OrchardCore.DisplayManagement/Shapes/Shape.cs, src/OrchardCore/OrchardCore.DisplayManagement/Descriptors/ShapePlacementStrategy/ShapePlacementParsingStrategy.cs, src/OrchardCore/OrchardCore.DisplayManagement.Liquid/LiquidViewParser.cs (+8 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 6 significant file(s) lose their only recent owner: src/OrchardCore/OrchardCore.Mvc.Core/ShellViewFeatureProvider.cs, src/OrchardCore/OrchardCore/Shell/RunningShellTable.cs, src/OrchardCore.Modules/OrchardCore.ContentLocalization/Services/ContentCulturePickerService.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/MoveMediaListEndpoint.cs, src/OrchardCore/OrchardCore.Mvc.Core/ShellFeatureApplicationPart.cs, src/OrchardCore.Modules/OrchardCore.Media/Endpoints/Api/GetTusFileInfoEndpoint.cs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #4 — If anonymized user #4 becomes unavailable, 4 significant file(s) lose their only recent owner: src/OrchardCore.Modules/OrchardCore.Facebook/Endpoints/GetSdkEndpoints.cs, src/OrchardCore.Modules/OrchardCore.Contents/AdminNodes/ContentTypesAdminNodeDriver.cs, src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PortableObjectStringLocalizerFactory.cs, src/OrchardCore.Modules/OrchardCore.Resources/Liquid/LinkTag.cs. Pair on, review, or document these before any departure.
Thin analysable surface across projects: BaseThemeSample2 test/OrchardCore.Tests.Modules/BaseThemeSample2/BaseThemeSample2.csproj— 3 project(s) carry only a thin slice of real code; `BaseThemeSample2` has 10 significant line(s). The mean analysable-surface weight is 88 %; this project lowers Solution Shape by about 0.24 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
Thin analysable surface across projects: DerivedThemeSample test/OrchardCore.Tests.Modules/DerivedThemeSample/DerivedThemeSample.csproj— 3 project(s) carry only a thin slice of real code; `DerivedThemeSample` has 11 significant line(s). The mean analysable-surface weight is 88 %; this project lowers Solution Shape by about 0.24 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
Thin analysable surface across projects: DerivedThemeSample2 test/OrchardCore.Tests.Modules/DerivedThemeSample2/DerivedThemeSample2.csproj— 3 project(s) carry only a thin slice of real code; `DerivedThemeSample2` has 11 significant line(s). The mean analysable-surface weight is 88 %; this project lowers Solution Shape by about 0.24 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
DuplicateAnalyzerSeverity .editorconfig:57— IDE0051 severity is assigned warning twice in the same [*.cs] section — here and again at line 67. The later assignment is the one that applies; this one is a duplicate to remove. — both lines say the same thing, so nothing about the build changes either way, but the repetition is what makes the next edit dangerous: whoever changes one of them will believe the change took effect, and the surviving copy will silently keep the old behaviour. Delete this one and leave a single entry for the rule.
DuplicateAnalyzerSeverity .editorconfig:249— SA1137 severity is assigned none twice in the same [*.cs] section — here and again at line 366. The later assignment is the one that applies; this one is a duplicate to remove. — both lines say the same thing, so nothing about the build changes either way, but the repetition is what makes the next edit dangerous: whoever changes one of them will believe the change took effect, and the surviving copy will silently keep the old behaviour. Delete this one and leave a single entry for the rule.
Partial audit-trail evidence — An audit mechanism is present, but the trail is not yet complete — missing: an EF SaveChanges interceptor (or equivalent write-side hook, e.g. an event-store append every change flows through), [Audited] per-entity coverage.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 9 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (66 single-owned of 1280 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1280 of the 5640 production source files in this repository met that bar). They are anonymized user #5 (2 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)), anonymized user #8 (1 file(s)), anonymized user #9 (1 file(s)), anonymized user #10 (1 file(s)) (+3 more) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: test/OrchardCore.Benchmarks/ScriptingBenchmark.cs, src/OrchardCore.Modules/OrchardCore.Rules/Services/JavascriptConditionEvaluator.cs, src/OrchardCore.Modules/OrchardCore.Media/Services/MediaJSLocalizer.cs, src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemFilters.cs, src/OrchardCore.Modules/OrchardCore.Media/Liquid/MediaAnchorTag.cs, src/OrchardCore.Modules/OrchardCore.Security/Services/PermissionsHeaderPolicyProvider.cs, src/OrchardCore.Modules/OrchardCore.Media/Services/ClientDisconnectAwarePipeReader.cs, src/OrchardCore/OrchardCore.ContentManagement/Records/Migrations.cs (+2 more).
Shell project: OrchardCore.Docs src/docs/OrchardCore.Docs.csproj— `OrchardCore.Docs` contributes only 0 significant line(s) — an empty/placeholder project is structural noise. Remove it or fold its contents into a real project.
Documentation: no project overview src/docs/guides/create-install-custom-module/README.md— The document does not state what the directory is for, only that it documents how to install a custom module.
No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 10 of 257 project(s) overshoot their size bounds, lowering Project Cohesion to 9.3/10. The most over is `OrchardCore.Abstractions` (9889 LoC, 234 public types across 50 namespaces). Review these for cohesion — split a project that spans unrelated responsibilities.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 37 of 1280 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1280 of the 5640 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: src/OrchardCore/OrchardCore/Shell/Removing/ShellRemovalManager.cs, src/OrchardCore/OrchardCore.UrlRewriting.Core/Services/RewriteRulesManager.cs, src/OrchardCore.Modules/OrchardCore.Forms/Drivers/FormInputElementVisibilityPartDisplayDriver.cs, src/OrchardCore.Modules/OrchardCore.UrlRewriting/Controllers/AdminController.cs, src/OrchardCore.Modules/OrchardCore.Contents/VersionPruning/Services/ContentVersionPruningService.cs, src/OrchardCore/OrchardCore.Abstractions/Shell/Extensions/ShellSettingsExtensions.cs, src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/Services/AwsTenantEventsBase.cs, src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Json/GraphQLNamedQueryRequestJsonConverter.cs (and 29 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
IL efficiency: 45 authored method(s) exceed the IL budget src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs:37— 45 of 22650 first-party methods compile to oversized IL bodies (> 250 instructions); worst: OrchardCore.Resources.ResourceManagementOptionsConfiguration.BuildManifest @ src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs:37, 1317 IL instructions; that pulled this dimension to 10.0/10. These bodies are far past the JIT's inline budget, so splitting them does not make them inlinable — what moves the number is emitting less: collapsing LINQ chains and closures on hot paths, and interpolation built eagerly where it is only sometimes used.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 15 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
Logging is not universal — Only 99/167 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 167, 6 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
R8 · Dependency Hygiene· Type-only dependency 'bootstrap' in production deps · ×1
Type-only dependency 'bootstrap' in production deps src/OrchardCore.Modules/OrchardCore.Workflows/Assets/Scripts/workflow-editor.ts:13— Every import is type-only — move it to devDependencies.
R8 · Dependency Hygiene· Test-only dependency 'oidc-client-ts' in production deps · ×1
Test-only dependency 'oidc-client-ts' in production deps REDACTED:29— Only test files import it (first: src/OrchardCore.Modules/OrchardCore.Media/Assets/media-gallery/src/services/__tests__/media-gallery-auth.spec.ts:170) — move it to devDependencies.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 287/2814 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Nullable reference types not enabled everywhere — 8/231 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~1.0 `!` suppressions per 1k syntax nodes — 32 suppression(s) across the 32485 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Off the main sequence: OrchardCore.ContentPreview.Abstractions src/OrchardCore/OrchardCore.ContentPreview.Abstractions/OrchardCore.ContentPreview.Abstractions.csproj:1— OrchardCore.ContentPreview.Abstractions: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: OrchardCore.ResourceManagement.Abstractions src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/OrchardCore.ResourceManagement.Abstractions.csproj:1— OrchardCore.ResourceManagement.Abstractions: abstractness 0.17, instability 0.00, distance 0.83 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: OrchardCore.Secrets.Abstractions src/OrchardCore/OrchardCore.Secrets.Abstractions/OrchardCore.Secrets.Abstractions.csproj:1— OrchardCore.Secrets.Abstractions: abstractness 0.24, instability 0.00, distance 0.76 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: OrchardCore.ContentManagement.Abstractions src/OrchardCore/OrchardCore.ContentManagement.Abstractions/OrchardCore.ContentManagement.Abstractions.csproj:1— OrchardCore.ContentManagement.Abstractions: abstractness 0.22, instability 0.02, distance 0.76 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: OrchardCore.Admin.Abstractions src/OrchardCore/OrchardCore.Admin.Abstractions/OrchardCore.Admin.Abstractions.csproj:1— OrchardCore.Admin.Abstractions: abstractness 0.22, instability 0.05, distance 0.73 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: OrchardCore.Liquid.Abstractions src/OrchardCore/OrchardCore.Liquid.Abstractions/OrchardCore.Liquid.Abstractions.csproj:1— OrchardCore.Liquid.Abstractions: abstractness 0.20, instability 0.07, distance 0.73 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1686b-92a6-78fb-8bcf-a26fc1209dc6 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 57 field(s) across 4 categories, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 287 · Warnings: 1926 · Recommendations: 230 · Info: 225 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 23-10-2026 @ 11:00 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.