Public report — NServiceBus, published 29 Jun 2026. Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version; ask the repo owner for the full report.
Watchdog 29-06-2026 @ 11:37 UTC Public
Code Health Audit

Particular/NServiceBus

62% Strong
CriticalWeakAdequateStrongExemplary
middle

Medium · 41,131 LoC · 11 projects · rebuild ~1.2 person-years · weakest lens: Code Health (58%)

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

48/51dimensions tool-verifieddeterministic · confidence 1.0 · 3 LLM-assisted, advisory
249findings with an exact file:lineof 268 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
51/94dimensions across the health lenses41131 LoC · 11 projects — wide & deep

Executive summary

Read through the Template lens: this is a template / kata / sample / demo — code meant to be read or copied, not operated. The ship-it and operate-it dimensions (CI/CD, observability, ADRs, architecture docs, deployment security) are N/A, and the colour bands on what remains are relaxed to what an example needs. Code correctness stays near-strict; the score is absolute and comparable across repos.

Particular/NServiceBus is in good health (62%). It can be evolved and operated with normal engineering discipline; the items below are improvements, not blockers.

The area that most needs attention is Code Health (58%) — changes there are slower and more error-prone. Architecture (60%) is the next concern — the code resists change, so features cost more over time.

Leadership focus, highest impact first: Finish or delete the unfinished stubs (NotImplementedException… (Incompleteness & stubs); Enable <Nullable>enable</Nullable> across all projects… (Nullable reference types); Swallowed exception (empty catch) (Exception handling).

For scale: Medium (~41,131 production lines); rebuilding it from scratch would take roughly ~1.2 person-years (~1–3 engineers). Approximate, ±~30%.

How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Code Health 58% · 46% weightArchitecture 60% · 25% weightReadiness 69% · 14% weightMaturity 70% · 8% weightSecurity 75% · 4% weightPerformance 76% · 2% weight

Raise Code Health 58 → 70 (the Healthy floor) ⇒ headline 62 → ~65.

Code composition — where the lines go
Business logic 9%Plumbing 23%Tests 62%Analyzers 6%
Rebuild cost & value ~ Modeled — €60,000–€300,000
Cost to rebuild€60,000–€300,000 (0.6–1.9 person-years (993–3,178 h), ~1–3 engineers)
Domain complexityStandard — harder problems cost more per line
Quality factor0.9× (at 62% quality) — the last 20% of quality is most of the work
Size & shapeMedium · 47% boilerplate · 20% straight-line · 33% branching logic

This codebase represents roughly ~1.2 person-years of build effort (about ~€180,000 to rebuild). Its weakest lens is Code Health at 58% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.2) — service/app, vertical slice × a 0.9× quality factor, at €60–95/h; indicative, ±~30%. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Resolve the 1 EmptyCatchBlock finding(s) in Explicit Debt — start with DefaultRecoverabilityPolicy.cs.
+3.8 pts · Low effort · Explicit Debt
2
Resolve the 1 Split NServiceBus.Core finding(s) in Project Cohesion.
+2.6 pts · Low effort · Project Cohesion
3
Resolve the 1 Scattered collaborators finding(s) in Navigability.
+2.3 pts · Low effort · Navigability

Diagnosis — what's actually going on

Value concentrated against a weak lens · Medium · Value at risk
This is a Medium asset (~1.2 person-years to rebuild), and its weakest lens is Code Health at 58%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
Evidence: valuation: Medium, ~1.2 person-years rebuild (41,131 LoC) · weakest lens: Code Health 58%
→ Direct remediation budget at Code Health first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Improving trajectory · Info · Trajectory
The headline is improving steadily (+3.5 pts/run over 6 runs) — whatever you're doing is working; keep the gate.
Evidence: trajectory: +3.5 pts/run over 6 runs

Trajectory

Where this codebase is heading — something a one-shot snapshot cannot show. 62, unchanged across 6 runs.

025507510026 Junnow
OverallCode HealthArchitectureMaturityReadinessSecurityPerformance

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

arch NServiceBus.Core Core NServiceBus.Core.Analyzer.Fixes Fixes NServiceBus.Testing.Fakes Fakes NServiceBus.Testing.Fakes->NServiceBus.Core

At a glance — Code Health · 58% · Adequate · gated by X5

At a glance — Architecture · 60% · Adequate · gated by D26, AX7

At a glance — Maturity · 70% · Strong

At a glance — Readiness · 69% · Strong

At a glance — Security · 75% · Adequate · gated by D36

At a glance — Performance · 76% · Strong

Roadmap

Begin by eliminating dead code by completing or removing the 50 unfinished method stubs to ensure all surface area is functional. Next, enable nullable reference types across all projects and resolve the resulting warnings instead of suppressing them. Then, address the 97 explicit debt items, prioritizing obsoletes-v10.cs, followed by resolving the single empty catch block in DefaultRecoverabilityPolicy.cs.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 EmptyCatchBlock finding(s) in Explicit Debt — start with DefaultRecoverabilityPolicy.cs.+3.8 ptsLowExplicit Debt
Resolve the 1 Split NServiceBus.Core finding(s) in Project Cohesion.+2.6 ptsLowProject Cohesion
Resolve the 1 Scattered collaborators finding(s) in Navigability.+2.3 ptsLowNavigability
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.+4.3 ptsMediumIncompleteness & stubs
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.+4.3 ptsMediumNullable reference types
Swallowed exception (empty catch)+3.9 ptsMediumException handling
Resolve the 97 ObsoleteWithCallers finding(s) in Explicit Debt — start with obsoletes-v10.cs (69), DefaultFactory.cs (3), Endpoint.cs (3).+3.8 ptsMediumExplicit Debt
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.+3.4 ptsMediumStateful singletons

File quality

Per-file score 0–10 — a quality signature. Of 104 files carrying findings, judged against the Template bar: 0% slop · 1% mixed · 99% near-clean.

FileScoreBandWorst signal
src/NServiceBus.Core/Recoverability/DefaultRecoverabilityPolicy.cs5.8MixedExplicit Debt: EmptyCatchBlock
src/NServiceBus.Core/obsoletes-v10.cs6.4Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/EndpointConfiguration.cs6.6Near-cleanExplicit Debt: BareSuppressMessage
src/NServiceBus.Core/EndpointCreator.cs6.6Near-cleanExplicit Debt: BareSuppressMessage
src/NServiceBus.Core/Features/Feature.cs6.7Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/Endpoint.cs6.9Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/IStartableEndpointWithExternallyManagedContainer.cs6.9Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/Logging/DefaultFactory.cs6.9Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs7.0Near-cleanCode Duplication: Duplicated block (14 lines × 3)
src/NServiceBus.Testing.Fakes/TestableMessageSession.cs7.0Near-cleanCode Duplication: Duplicated block (10 lines × 2)
src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs7.1Near-cleanCyclomatic Complexity: SagaAnalyzer.AnalyzeSagaClass (cyclomatic 39)
src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs7.1Near-cleanTest Quality: No assertions: Initialize_ShouldBeThreadsafe
src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs7.1Near-cleanCyclomatic Complexity: HandlerAttributeAnalyzer.Initialize (cyclomatic 63)
src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs7.1Near-cleanCyclomatic Complexity: XmlDeserialization.GetPropertyValue (cyclomatic 60)
src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs7.2Near-cleanCyclomatic Complexity: HandlerAttributeFixer.MoveHandlerAttribute (cyclomatic 27)
src/NServiceBus.Core.Analyzer.Fixes/Sagas/RewriteConfigureHowToFindSagaFixer.cs7.3Near-cleanExplicit Debt: TodoComment
src/NServiceBus.Core.Tests/Serializers/XML/XmlSerializerCacheTests.cs7.3Near-cleanExplicit Debt: BarePragmaDisable
src/NServiceBus.Core/IStartableEndpoint.cs7.3Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/IEndpointInstance.cs7.3Near-cleanExplicit Debt: ObsoleteWithCallers
src/NServiceBus.Core/Installation/Installer.cs7.3Near-cleanExplicit Debt: ObsoleteWithCallers

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 48 of 51 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 3 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.7 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 51 dimensions across the health lenses
D1D2D3D4D5D6D9D10D11D12D13D14D15D16D17D18D19D21D26D27D28D29D35D36D37AX1AX10AX2AX3AX5AX6AX7AX8GD1IC1M1M3M4P1P10P2P3P4PF1PF2PF3X1X2X3X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 249 of 268 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
jscpdCode duplication✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.301✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.301✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 019f132b-f66a-7ba9-8d19-bae32cfeeb08.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D24 Comment Value — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.
  • D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
  • D31 IaC & Container Security — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
  • D32 Data Compliance (PII/GDPR) — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
  • D33 JS/npm Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
  • D38 OSV Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (EF migration scaffolds, *.Designer.cs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only; the generated footprint is reported separately under Solution Shape.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D11 Test Reliability: Flakiness is inferred from history/markers — Watchdog runs the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (EF migrations, designer files, snapshots) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".

The LLM boundary

LLM-set scores this run (3): D19, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity7.2 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 7.2 / 10 · rule-coverage 100% · ceiling Prevented

16 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was HandlerAttributeAnalyzer.Initialize at 63.

HandlerAttributeAnalyzer.Initialize (cyclomatic 63)src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:17
XmlDeserialization.GetPropertyValue (cyclomatic 60)src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:342
SagaAnalyzer.AnalyzeSagaClass (cyclomatic 39)src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:73
SagaAttributeAnalyzer.Initialize (cyclomatic 29)src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:16
HandlerAttributeFixer.MoveHandlerAttribute (cyclomatic 27)src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:121

+ 11 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 HandlerAttributeAnalyzer.Initialize (cyclomatic 63) finding(s) in Cyclomatic Complexity — start with HandlerAttributeAnalyzer.cs. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 XmlDeserialization.GetPropertyValue (cyclomatic 60) finding(s) in Cyclomatic Complexity — start with XmlDeserialization.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 SagaAnalyzer.AnalyzeSagaClass (cyclomatic 39) finding(s) in Cyclomatic Complexity — start with SagaAnalyzer.cs. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.7 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Prevented

33 method(s) exceeded the cognitive complexity threshold of 15; the worst was XmlDeserialization.GetPropertyValue at 131.

XmlDeserialization.GetPropertyValue (cognitive 131)src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:342
HandlerAttributeAnalyzer.Initialize (cognitive 126)src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:17
SagaAnalyzer.AnalyzeSagaClass (cognitive 88)src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:73
SagaAttributeAnalyzer.Initialize (cognitive 50)src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:16
XmlSerializerCache.InitTypeInternal (cognitive 44)src/NServiceBus.Core/Serializers/XML/XmlSerializerCache.cs:27

+ 28 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 XmlDeserialization.GetPropertyValue (cognitive 131) finding(s) in Cognitive Complexity — start with XmlDeserialization.cs. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 HandlerAttributeAnalyzer.Initialize (cognitive 126) finding(s) in Cognitive Complexity — start with HandlerAttributeAnalyzer.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 SagaAnalyzer.AnalyzeSagaClass (cognitive 88) finding(s) in Cognitive Complexity — start with SagaAnalyzer.cs. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes10.0 / 10Exemplary✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 god class(es) detected.

✓ On the Gold path — maintain.

Detailed fixes: d3_recommendation.md.

D4 · Code Duplication9.7 / 10Exemplary✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

23 duplicated block group(s) detected.

Duplicated block (15 lines × 2) · ×4src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:209
Duplicated block (16 lines × 2) · ×2src/NServiceBus.Core/Conventions/Conventions.cs:139
Duplicated block (12 lines × 2) · ×2src/NServiceBus.Core.Analyzer/Handlers/AddHandlerGenerator.cs:37
Duplicated block (9 lines × 2) · ×2src/NServiceBus.Core/Routing/MessageDrivenSubscriptions/MessageDrivenUnsubscribeTerminator.cs:36
Duplicated block (7 lines × 2) · ×2src/NServiceBus.Core/Hosting/KeyedServices/KeyedServiceCollectionAdapter.cs:143

+ 11 more group(s) — more in Appendix A; the complete list is findings.md.

✓ On the Gold path — maintain.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling7.8 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: DocumentedVerifiedPrevented · effective 7.8 / 10 · rule-coverage 100% · ceiling Prevented

11 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: NServiceBus.Core.Analyzer.Fixes · ×3

What to do

  1. Resolve the 3 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (3 warning-level).
  2. Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.7 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: DocumentedVerifiedPrevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

4 of 166 classes have LCOM4 above 3.

Low cohesion: IncomingPipelineMetrics (LCOM4 10) · ×4src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:12

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2023 test methods: 2023 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality9.8 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

6 skipped (4 with a documented reason), 24 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 1853 tests.

No assertions: Should_allow_sending_events · ×24src/NServiceBus.AcceptanceTests/Core/BestPractices/When_sending_events_bestpractices_disabled_on_endpoint.cs:11
Skipped test: Should_for_our_code_exclude_everything_but_NServiceBus_by_default · ×2src/NServiceBus.Core.Tests/AssemblyScanner/When_scanning_assemblies.cs:21
Skipped (documented): Should_deserialize_arrayList · ×4src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:183

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests pass reliably, with no flakiness.

Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 flaky across 1 measured tier(s). unit: measured (0 flaky); other: not included — too large to re-run within its budget.

✓ On the Gold path — maintain.

Detailed fixes: d11_recommendation.md.

D12 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 outdated, 0 vulnerable, 0 deprecated packages.

✓ On the Gold path — maintain.

Detailed fixes: d12_recommendation.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 13 packages use a banned license.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs (2×60=120); src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs (1×63=63); src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs (2×17=34)

Hotspot: src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs · ×5src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor6.2 / 10Adequate✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: DocumentedVerifiedPrevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Documented

99 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/NServiceBus.Core.Analyzer/ForwardCancellationTokenAnalyzer.cs.

Off-boarding risk: anonymized user #1 · ×3
Further sole-owners (lower concentration)

What to do

  1. Resolve the 3 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (3 recommendation-level).
  2. Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt7.1 / 10Strong✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: DocumentedVerifiedPrevented · effective 7.1 / 10 · rule-coverage 100% · ceiling Prevented

133 deducted debt markers + 0 dead symbols across 41123 LoC (1.4/KLoC) → score 7.1.

EmptyCatchBlocksrc/NServiceBus.Core/Recoverability/DefaultRecoverabilityPolicy.cs:94
ObsoleteWithCallers · ×97src/NServiceBus.Core/Endpoint.cs:16
BarePragmaDisable · ×15src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs:62
TodoComment · ×9src/NServiceBus.Core.Analyzer.Fixes/ForwardCancellationTokenFixer.cs:40
BareSuppressMessage · ×7src/NServiceBus.Core/EndpointConfiguration.cs:131

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 97 ObsoleteWithCallers finding(s) in Explicit Debt — start with obsoletes-v10.cs (69), DefaultFactory.cs (3), Endpoint.cs (3). — One of this dimension's main actionable groups (97 warning-level).
  2. Resolve the 1 EmptyCatchBlock finding(s) in Explicit Debt — start with DefaultRecoverabilityPolicy.cs. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 15 BarePragmaDisable finding(s) in Explicit Debt — start with XmlSerializerCacheTests.cs (2), LoadHandlersConnector.cs, MeterTests.cs. — One of this dimension's main actionable groups (15 warning-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

11 projects, 1807 .cs files, 107726 hand-written lines of code (41123 production / 66603 test), 13 inter-project edges (build status unknown — did not finish).

Build status unknown

✓ On the Gold path — maintain.

Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality / 10Adequate◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Adequate / 10 · rule-coverage 100% · ceiling Documented

The README for NServiceBus is clear and comprehensive: it describes the platform's value proposition, links to a quick start, explains how to install templates, lists NuGet packages, and notes support channels. It also begins a Guidelines section referencing coding guidelines, but no further documentation exists in the visible portion of the file (the clip marker ends the body). A separate architecture/usage doc would strengthen the README.

Low XML-doc coverage: NServiceBus.Core · ×3src/NServiceBus.Core/NServiceBus.Core.csproj
The Getting started section links to two tutorials and one NuGet package for templates but does not mention how to install NServiceBus via nuget or dotnet new.README.md
XML-doc coverage: NServiceBus.Testing.Fakessrc/NServiceBus.Testing.Fakes/NServiceBus.Testing.Fakes.csproj

What to do

  1. Resolve the 3 Low XML-doc coverage finding(s) in Documentation Quality — start with NServiceBus.Core.Analyzer.Fixes.csproj, NServiceBus.Core.Analyzer.csproj, NServiceBus.Core.csproj. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 The Getting started section links to two tutorials and one NuGet package… finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency / 10Exemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 200 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D26 · Project Cohesion2.7 / 10Weak✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: DocumentedVerifiedPrevented · effective 2.7 / 10 · rule-coverage 100% · ceiling Documented

4 of 11 projects flagged as possibly oversized/incoherent.

Split NServiceBus.Core

What to do

  1. Resolve the 1 Split NServiceBus.Core finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability5.6 / 10Adequate✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: DocumentedVerifiedPrevented · effective 5.6 / 10 · rule-coverage 100% · ceiling Documented

68 % of calls cross a namespace and 9 % go through an interface, but 49 % of collaborators are co-located — so following a call takes several hops. Baseline: medium — clean/modular boundaries expected.

Scattered collaborators

What to do

  1. Resolve the 1 Scattered collaborators finding(s) in Navigability. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)10.0 / 10Exemplary○ Nothing flagged

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep --config auto across the repo; severity rules (ERROR/WARNING/INFO) map to a 0-10 wide normalizer. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

semgrep found no security issues.

✓ On the Gold path — maintain.

Detailed fixes: d29_recommendation.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: DocumentedVerifiedPrevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

Unpinned build actions
No build provenance
No artifact signing
No SBOM

What to do

  1. Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 No artifact signing finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

AX10 · Code composition9.0 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).
AX2 · Stateful singletons5.3 / 10Adequate✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `MessageHandlerRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (deduplicationSet, messageHandlerFactories; e.g. `deduplicationSet` at line 122). — MessageHandlerRegistry.cs:19
  • `MessageMetadataRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (isMessageType, allowDynamicTypeLoading, preRegisteredMessagesWithHierarchy, preRegisteredMessageTypes, initialized; e.g. `isMessageType` at line 36). — obsoletes-v10.cs:614

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface member counts; fat-interface threshold (over 15 members) flagged per type. Deterministic, type-level.

  • `IRecoverabilityActionContext` declares 22 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IRecoverabilityActionContext.cs:13
  • `IRecoverabilityContext` declares 28 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IRecoverabilityContext.cs:13
  • `ILog` declares 25 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — ILog.cs:10

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX7 · Slice cohesion1.0 / 10Critical✓ Tool-verified

Other · Architecture — Whether feature slices stay independent (no direct cross-slice references) — the discipline that makes vertical-slice architecture pay off.

Method: Roslyn scan (vertical-slice gated): feature slices resolved from namespaces (.Features.*, .Slices.*) or project names; cross-slice type references detected. Deterministic, traceable.

  • `DefaultTestingLoggerFactory` (slice 'NServiceBus.Testing.Fakes') depends on `LogLevel` from slice 'NServiceBus'. — DefaultTestingLoggerFactory.cs:7
  • `TestableAuditContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingMessage` from slice 'NServiceBus'. — TestableAuditContext.cs:12
  • `TestableBehaviorContext` (slice 'NServiceBus.Testing.Fakes') depends on `ContextBag` from slice 'NServiceBus'. — TestableBehaviorContext.cs:13
  • `TestableIncomingLogicalMessageContext` (slice 'NServiceBus.Testing.Fakes') depends on `LogicalMessage` from slice 'NServiceBus'. — TestableIncomingLogicalMessageContext.cs:10
  • `TestableIncomingPhysicalMessageContext` (slice 'NServiceBus.Testing.Fakes') depends on `IncomingMessage` from slice 'NServiceBus'. — TestableIncomingPhysicalMessageContext.cs:10
  • `TestableInvokeHandlerContext` (slice 'NServiceBus.Testing.Fakes') depends on `ISynchronizedStorageSession` from slice 'NServiceBus'. — TestableInvokeHandlerContext.cs:13
  • `TestableMessageSession` (slice 'NServiceBus.Testing.Fakes') depends on `ContextBag` from slice 'NServiceBus'. — TestableMessageSession.cs:13
  • `TestableOutgoingLogicalMessageContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingLogicalMessage` from slice 'NServiceBus'. — TestableOutgoingLogicalMessageContext.cs:10
  • `TestableOutgoingPublishContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingLogicalMessage` from slice 'NServiceBus'. — TestableOutgoingPublishContext.cs:8
  • `TestableOutgoingReplyContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingLogicalMessage` from slice 'NServiceBus'. — TestableOutgoingReplyContext.cs:8
  • `TestableOutgoingSendContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingLogicalMessage` from slice 'NServiceBus'. — TestableOutgoingSendContext.cs:8
  • `TestablePipelineContext` (slice 'NServiceBus.Testing.Fakes') depends on `ContextBag` from slice 'NServiceBus'. — TestablePipelineContext.cs:14
  • `TestableRecoverabilityContext` (slice 'NServiceBus.Testing.Fakes') depends on `IncomingMessage` from slice 'NServiceBus'. — TestableRecoverabilityContext.cs:11
  • `TestableRoutingContext` (slice 'NServiceBus.Testing.Fakes') depends on `OutgoingMessage` from slice 'NServiceBus'. — TestableRoutingContext.cs:12
  • `TestableTransportReceiveContext` (slice 'NServiceBus.Testing.Fakes') depends on `IncomingMessage` from slice 'NServiceBus'. — TestableTransportReceiveContext.cs:10

What to do

  • Keep slices independent: share cross-slice needs via an explicit contract/shared-kernel, not direct references between slices.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×25) — HostStartupDiagnosticsWriter.cs:110, obsoletes-v10.cs:30, obsoletes-v10.cs:40, …

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs5.2 / 10Adequate✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `Create` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — Feature.cs:234
  • `StartedAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — EndpointHostedService.cs:18
  • `StoppingAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. (×2) — EndpointHostedService.cs:20, InstallerCoordinatorHostedService.cs:24
  • `StoppedAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. (×2) — EndpointHostedService.cs:22, InstallerCoordinatorHostedService.cs:25
  • `InstallerCoordinatorHostedService` has 5 unfinished members out of 6 — a scaffolded type that was never implemented. — InstallerCoordinatorHostedService.cs:9
  • `StartingAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — InstallerCoordinatorHostedService.cs:11
  • `StartAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — InstallerCoordinatorHostedService.cs:22
  • `StopAsync` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — InstallerCoordinatorHostedService.cs:23
  • `Read` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — HostStartupDiagnosticsWriter.cs:110
  • `Open` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — LearningSynchronizedStorageSession.cs:54
  • `CreateInvokerNode` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — IBehavior.cs:47
  • `CompletedRoot` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — PipelineInvoker.cs:27
  • `OnStop` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — AutoSubscribe.cs:100
  • `Commit` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — NoTransaction.cs:28
  • `BasePath` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:25
  • `IsDataBusProperty` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:35
  • `DefiningDataBusPropertiesAs` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:45
  • `SetValue` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:105
  • `GetValue` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:112
  • `ProvidedByFeature` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:127
  • `Serialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:185
  • `Deserialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:192
  • `UseDataBus` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×3) — obsoletes-v10.cs:214, obsoletes-v10.cs:223, obsoletes-v10.cs:231
  • `UsePersistence` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:241
  • `EnableFeature` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:268
  • `DisableFeature` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — obsoletes-v10.cs:273

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)5.2 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

  • 843 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.

What to do

  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 11 of 11 project(s) that lack one — worth up to 2 pts.
  • Review the README against recent changes; refresh the parts that drifted.
M3 · Folder & project structure8.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

  • Test projects aren't grouped under a tests/ folder — the test surface isn't separable from production code at a glance.

What to do

  • Group test projects under tests/ (or test/, spec/) so the test surface is discoverable and CI can scope it.
M4 · Documentation accuracy8.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • README advertises Docker containerisation, but no Dockerfile/compose file exists

What to do

  • Reconcile the README with reality: README advertises Docker containerisation, but no Dockerfile/compose file exists.
P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries. Exhaustive, deterministic.

P2 · Observability7.5 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 2/4 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log).

What to do

  • Extend structured logging to the remaining service-like projects so the whole executable surface is diagnosable in production.
  • Add a health-check endpoint (AddHealthChecks/MapHealthChecks) so orchestrators and load balancers can probe liveness/readiness.
P3 · Security & performance tooling4.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem/Roslyn scan: CodeQL, Dependabot, secret-scanning, and BenchmarkDotNet presence in pipelines and projects. Exhaustive, deterministic.

What to do

  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • Deployment automation exists but no readiness/liveness probes, rolling-update strategy, lifecycle hooks or migration job were evidenced — a bad release is harder to detect and reverse.

What to do

  • Add readiness/liveness probes and a rolling-update (or blue/green) strategy so a bad release is caught and rolled back automatically.
  • Add an approval/environment gate (required reviewers / protection rules) before production promotion.
PF1 · Benchmark discipline6.0 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the library protects its performance with benchmarks — a BenchmarkDotNet suite, an allocation MemoryDiagnoser, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

  • No BenchmarkDotNet suite was found. For a performance-sensitive library, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.

What to do

  • Add a BenchmarkDotNet project for the hot paths (with [MemoryDiagnoser] to track allocations), and run it in CI to catch regressions.
PF2 · Allocation hygiene8.1 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's GC — Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc, ValueTask, value-type structs and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 179 use(s) across 41,955 production line(s) (~4.3/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
PF3 · Async & latency hygiene9.9 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code keeps its host responsive — a library awaits with ConfigureAwait(false) (so it never captures and stalls the host's context) and avoids sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) that wastes threads and risks deadlock.

Method: Production-source scan: sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) counted everywhere, and — for a library with ≥5 awaits — the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X2 · Cancellation propagation8.7 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage.

  • Only 101/128 async methods accept a CancellationToken, so requests can't be cancelled cleanly under load or on client disconnect. In Blazor Server circuits and other short-write hosts, omitting it can be an accepted convention — judge against your hosting model.
  • No CancellationToken parameter — work can't be cancelled cleanly on disconnect/shutdown. (×25) — InvokeAuditPipelineBehavior.cs:19, EndpointInstanceExtensions.cs:26, BaseEndpointLifecycle.cs:103, …

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X3 · Exception handling7.4 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — DefaultRecoverabilityPolicy.cs:94

What to do

  • Swallowed exception (empty catch)
X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. Deterministic.

X5 · Nullable reference types1.9 / 10Weak✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 0/2 projects enable <Nullable>enable</Nullable>. NRTs catch a whole class of null-deref bugs at compile time.
  • ~0.5 `!` suppressions per 1k syntax nodes — each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health58%Adequate — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture60%Adequate — gated by D26, AX7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity70%StrongSolid.
Readiness69%StrongSolid.
Security75%Adequate — gated by D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance76%StrongStrongest area.
Not included — 44 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX4 Dependency direction — not applicable to a vertical-slice architecture (the inward-dependency rule is for layered/clean styles)
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — no data
  • C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C2 Access Controls — This is a dotnet-new template — authorization is deferred to the application you build from it. Add [Authorize]/policies (or imperative guards) when you wire up real users; until then there are no real endpoints to protect.
  • C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • D20 ADR Quality — N/A — this repo declares itself a template / kata / sample / demo; a formal ADR log is deferred to a real application built from it.
  • D22 Internal API Consistency — No exposed public API
  • D23 Boundary Type-Coupling — Bounded contexts not declared
  • D24 Comment Value — LLM evaluation failed
  • D25 ADR Conformance — no ADRs to check
  • D30 Dependency Vulnerabilities — the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan for NuGet CVEs — excluded rather than scored; re-run on an SDK that can restore this solution
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
  • D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside bin/obj (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
  • D34 Knowledge Freshness — knowledge concentrated in recent work — freshness signal contradicted by repo activity
  • D38 OSV Dependency Vulnerabilities — No JS/npm lockfile found outside bin/obj (package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); nothing for OSV to scan.
  • D39 IL Efficiency — The target did not build, so no IL was available to measure.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage not measured — test suite did not build
  • DM1 Domain Modelling — not run — only 1/3 markers (10 value object(s))
  • ED1 Event-Driven — not run — only 1/3 markers (a message-bus package)
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not run — 0/3 markers found
  • M2 Architecture documentation — This repo declares itself a template / kata / sample / demo — formal architecture documentation (ADRs, C4 diagrams) is deferred to a real application built from it, so its absence is not a defect here.
  • P12 CI test-gate honesty — no data
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
  • P7 Outbound HTTP resilience — no outbound HTTP usage detected
  • P8 Schema migrations — no EF Core usage detected
  • P9 Domain vs controller coverage — no coverage report found on disk — run tests with `--collect:"XPlat Code Coverage"` (or in CI) to enable this cross-layer check
  • S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
  • SC1 Supply-chain hygiene — no data
  • X6 Hand-rolled structured-format parsing — no data
  • X7 Silent fallback defaults — no data

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Issue — 1 finding(s)
D17 · Explicit Debt · EmptyCatchBlock · ×1
  • EmptyCatchBlock src/NServiceBus.Core/Recoverability/DefaultRecoverabilityPolicy.cs:94 — empty catch block
Warning — 248 finding(s)
D17 · Explicit Debt · ObsoleteWithCallers · ×97
  • ObsoleteWithCallers src/NServiceBus.Core/Endpoint.cs:16 — [Obsolete] Endpoint
  • ObsoleteWithCallers src/NServiceBus.Core/Endpoint.cs:29 — [Obsolete] Create
  • ObsoleteWithCallers src/NServiceBus.Core/EndpointWithExternallyManagedContainer.cs:21 — [Obsolete] Create
  • ObsoleteWithCallers src/NServiceBus.Core/obsoletes-v10.cs:588 — [Obsolete] Create
  • ObsoleteWithCallers src/NServiceBus.Core/obsoletes-v10.cs:592 — [Obsolete] Create
  • ObsoleteWithCallers src/NServiceBus.Core/Endpoint.cs:57 — [Obsolete] Start
  • ObsoleteWithCallers src/NServiceBus.Core/IStartableEndpoint.cs:25 — [Obsolete] Start
  • ObsoleteWithCallers src/NServiceBus.Core/IStartableEndpointWithExternallyManagedContainer.cs:27 — [Obsolete] Start
  • ObsoleteWithCallers src/NServiceBus.Core/obsoletes-v10.cs:419 — [Obsolete] Start
  • ObsoleteWithCallers src/NServiceBus.Core/EndpointConfiguration.cs:99 — [Obsolete] RegisterComponents
  • ObsoleteWithCallers src/NServiceBus.Core/EndpointInstanceExtensions.cs:26 — [Obsolete] Stop
  • ObsoleteWithCallers src/NServiceBus.Core/IEndpointInstance.cs:24 — [Obsolete] Stop
  • ObsoleteWithCallers src/NServiceBus.Core/Features/Feature.cs:83 — [Obsolete] EnableByDefault
  • ObsoleteWithCallers src/NServiceBus.Core/IEndpointInstance.cs:13 — [Obsolete] IEndpointInstance
  • ObsoleteWithCallers src/NServiceBus.Core/IStartableEndpoint.cs:13 — [Obsolete] IStartableEndpoint
  • ObsoleteWithCallers src/NServiceBus.Core/IStartableEndpointWithExternallyManagedContainer.cs:13 — [Obsolete] IStartableEndpointWithExternallyManagedContainer
  • ObsoleteWithCallers src/NServiceBus.Core/IStartableEndpointWithExternallyManagedContainer.cs:39 — [Obsolete] MessageSession
  • ObsoleteWithCallers src/NServiceBus.Core/IWantToRunBeforeConfigurationIsFinalized.cs:13 — [Obsolete] IWantToRunBeforeConfigurationIsFinalized
  • ObsoleteWithCallers src/NServiceBus.Core/Installation/Installer.cs:26 — [Obsolete] Setup
  • ObsoleteWithCallers src/NServiceBus.Core/Installation/Installer.cs:54 — [Obsolete] CreateInstallerWithExternallyManagedContainer
  • ObsoleteWithCallers src/NServiceBus.Core/Logging/DefaultFactory.cs:13 — [Obsolete] DefaultFactory
  • ObsoleteWithCallers src/NServiceBus.Core/Logging/DefaultFactory.cs:51 — [Obsolete] Level
  • ObsoleteWithCallers src/NServiceBus.Core/Logging/DefaultFactory.cs:61 — [Obsolete] Directory
  • ObsoleteWithCallers src/NServiceBus.Core/Logging/LogManager.cs:28 — [Obsolete] Use
  • ObsoleteWithCallers src/NServiceBus.Core/Logging/LogManager.cs:52 — [Obsolete] UseFactory
  • + 72 more in this group — see findings.md.
D10 · Test Quality · No assertions · ×24
  • No assertions: Should_allow_sending_events src/NServiceBus.AcceptanceTests/Core/BestPractices/When_sending_events_bestpractices_disabled_on_endpoint.cs:11 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_pass_it_to_the_transport src/NServiceBus.AcceptanceTests/Core/FakeTransport/ProcessingOptimizations/When_using_concurrency_limit.cs:15 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: ReceiveFeature_should_work_without_ISynchronizedStorage src/NServiceBus.AcceptanceTests/Core/Persistence/When_a_persistence_does_not_provide_synchronized_storage_session.cs:18 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_throttle_pipeline_after_configured_number_of_consecutive_failures src/NServiceBus.AcceptanceTests/Core/Recoverability/When_messages_never_succeed.cs:15 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_not_throttle_pipeline_if_number_of_consecutive_failures_is_below_threshold src/NServiceBus.AcceptanceTests/Core/Recoverability/When_messages_never_succeed.cs:34 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_wait_the_configured_delay_between_processing_attempts_in_throttled_mode src/NServiceBus.AcceptanceTests/Core/Recoverability/When_messages_never_succeed_with_delays_specified.cs:11 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_end_throttling_mode_after_a_single_successful_message src/NServiceBus.AcceptanceTests/Core/Recoverability/When_messages_succeed_after_throttling.cs:11 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_hydrate_and_invoke_the_existing_instance src/NServiceBus.AcceptanceTests/Sagas/When_saga_has_a_non_empty_constructor.cs:11 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_handle_message src/NServiceBus.AcceptanceTests/Serialization/When_no_content_type.cs:11 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Dll_with_message_handlers_gets_loaded src/NServiceBus.Core.Tests/AssemblyScanner/When_directory_with_handler_dll_is_scanned.cs:10 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: ShouldAllowSettingMessageProperties src/NServiceBus.Core.Tests/Fakes/TestableMessageHandlerContextTests.cs:122 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Initialize_ShouldBeThreadsafe src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:14 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: CreateInstance_WhenMessageInitialized_ShouldBeThreadsafe src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:30 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_handle_messages_with_nullable_reference_types src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:51 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: CreateInstance_WhenMessageNotInitialized_ShouldBeThreadsafe src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:71 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: ShouldAllowMultipleMapperInstancesPerAppDomain src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:84 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_create_instance_of_concrete_type_with_illegal_interface_property src/NServiceBus.Core.Tests/MessageMapper/MessageMapperTests.cs:96 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_not_throw_for_simple_behavior src/NServiceBus.Core.Tests/Pipeline/BehaviorTypeCheckerTests.cs:13 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_not_throw_for_behavior_using_context_interfaces src/NServiceBus.Core.Tests/Pipeline/BehaviorTypeCheckerTests.cs:19 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Should_not_throw_for_closed_generic_behavior src/NServiceBus.Core.Tests/Pipeline/BehaviorTypeCheckerTests.cs:25 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: Comparison src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:625 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: TestInterfaces src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:632 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: TestDataContractSerializer src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:767 — Test method exercises code but verifies nothing — add an assertion.
  • No assertions: RunNew src/NServiceBus.Core.Tests/Unicast/HandlerInvocationCache.cs:15 — Test method exercises code but verifies nothing — add an assertion.
D17 · Explicit Debt · BarePragmaDisable · ×15
  • BarePragmaDisable src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs:62 — #pragma warning disable PS0019
  • BarePragmaDisable src/NServiceBus.Core.Tests/Pipeline/PipelineTests.cs:200 — #pragma warning disable PS0019
  • BarePragmaDisable src/NServiceBus.Core/Pipeline/Incoming/LoadHandlersConnector.cs:63 — #pragma warning disable PS0019
  • BarePragmaDisable src/NServiceBus.Core/Unicast/RunningEndpointInstance.cs:113 — #pragma warning disable PS0019
  • BarePragmaDisable src/NServiceBus.AcceptanceTests/Core/LoggingIntegration/When_using_extensions_logging_bridge.cs:79 — #pragma warning disable CA2254
  • BarePragmaDisable src/NServiceBus.AcceptanceTests/Registrations/Sagas/When_mixing_registered_and_scanned_sagas.cs:96 — #pragma warning disable NSB0025
  • BarePragmaDisable src/NServiceBus.Core.Analyzer.Tests.Roslyn5/Helpers/MockTrimmingAnalyzer.cs:15 — #pragma warning disable RS2008
  • BarePragmaDisable src/NServiceBus.Core.Tests/OpenTelemetry/MeterTests.cs:24 — #pragma warning disable CA1806
  • BarePragmaDisable src/NServiceBus.Core.Tests/Sagas/SagaMetadataCreationTests.cs:916 — #pragma warning disable 649
  • BarePragmaDisable src/NServiceBus.Core.Tests/Sagas/SagaModelPartialProperty1Tests.cs:5 — #pragma warning disable IDE0055
  • BarePragmaDisable src/NServiceBus.Core.Tests/Sagas/SagaModelPartialProperty2Tests.cs:5 — #pragma warning disable IDE0032
  • BarePragmaDisable src/NServiceBus.Core.Tests/Serializers/XML/XmlSerializerCacheTests.cs:57 — #pragma warning disable 649, 169
  • BarePragmaDisable src/NServiceBus.Core.Tests/Serializers/XML/XmlSerializerCacheTests.cs:66 — #pragma warning disable 649, 169
  • BarePragmaDisable src/NServiceBus.Core.Tests/Utils/Reflection/MethodInfoExtensionTests.cs:64 — #pragma warning disable CA1822
  • BarePragmaDisable src/NServiceBus.Core/Logging/RollingLoggerProvider.cs:67 — #pragma warning disable PS0023
D17 · Explicit Debt · TodoComment · ×9
  • TodoComment src/NServiceBus.Core.Analyzer.Fixes/ForwardCancellationTokenFixer.cs:40 — // TODO: consider whether analyzer should pass in name of property, i.e. "CancellationToken", — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Core.Analyzer.Fixes/Sagas/RewriteConfigureHowToFindSagaFixer.cs:107 — // TODO: Probably a way to make this perform better — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Core.Analyzer/TypeSymbolExtensions.cs:145 — // TODO: cater for generics, including in/out - test what CA2016 does in .NET 6 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Core.Tests/Recoverability/RecoverabilityExecutorTests.cs:67 — // TODO: Does not get disposed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Core.Tests/ServicePlatform/Retries/RetryAcknowledgementBehaviorTests.cs:120 — // TODO: Does not get disposed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Core.Tests/StandardsTests.cs:40 — // TODO: This can be removed once this bug is fixed in Roslyn: https://github.com/dotnet/roslyn/issues/72539 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Testing.Fakes/TestableBehaviorContext.cs:36 — // TODO: When will this be disposed? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Testing.Fakes/TestableIncomingContext.cs:36 — // TODO: When will this be disposed? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/NServiceBus.Testing.Fakes/TestableOutgoingContext.cs:29 — // TODO: When will this be disposed? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
D17 · Explicit Debt · BareSuppressMessage · ×7
  • BareSuppressMessage src/NServiceBus.Core/EndpointConfiguration.cs:131 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointConfiguration.cs:179 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointConfiguration.cs:180 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointCreator.cs:61 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointCreator.cs:180 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointCreator.cs:183 — UnconditionalSuppressMessage
  • BareSuppressMessage src/NServiceBus.Core/EndpointCreator.cs:186 — UnconditionalSuppressMessage
D15 · Churn × Complexity Hotspots · Hotspot · ×5
  • Hotspot: src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs — src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs changed 2 times in last 90 days, max complexity 60.
  • Hotspot: src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs — src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs changed 1 times in last 90 days, max complexity 63. 1 of those changes were fix/bug commits — a defect-dense hotspot worth prioritising.
  • Hotspot: src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs — src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs changed 2 times in last 90 days, max complexity 17. 2 of those changes were fix/bug commits — a defect-dense hotspot worth prioritising.
  • Hotspot: src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs — src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs changed 1 times in last 90 days, max complexity 27. 1 of those changes were fix/bug commits — a defect-dense hotspot worth prioritising.
  • Hotspot: src/NServiceBus.Core/Serializers/XML/XmlSerialization.cs src/NServiceBus.Core/Serializers/XML/XmlSerialization.cs — src/NServiceBus.Core/Serializers/XML/XmlSerialization.cs changed 1 times in last 90 days, max complexity 24.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×4
  • Duplicated block (15 lines × 2) src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:209 — src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:209-223 | src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:236-250
  • Duplicated block (15 lines × 2) src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:31 — src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:31-45 | src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddIHandleMessagesInterfaceFixer.cs:31-45
  • Duplicated block (15 lines × 2) src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:294 — src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:294-308 | src/NServiceBus.Core.Analyzer.Fixes/Sagas/SagaAttributeFixer.cs:246-260
  • Duplicated block (15 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:88 — src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:88-100 | src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:176-190
D6 · Cohesion (LCOM4) · Low cohesion · ×4
  • Low cohesion: IncomingPipelineMetrics (LCOM4 10) src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:12 — IncomingPipelineMetrics's methods form 10 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: Feature (LCOM4 6) src/NServiceBus.Core/Features/Feature.cs:15 — Feature's methods form 6 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: SettingsHolder (LCOM4 6) src/NServiceBus.Core/Settings/SettingsHolder.cs:10 — SettingsHolder's methods form 6 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: TestableMessageSession (LCOM4 4) src/NServiceBus.Testing.Fakes/TestableMessageSession.cs:13 — TestableMessageSession's methods form 4 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
D17 · Explicit Debt · HackComment · ×3
  • HackComment src/NServiceBus.AcceptanceTests/EndpointTemplates/ConfigureExtensions.cs:13 — // This is kind of a hack because the acceptance testing framework doesn't give any access to the transport definition to individual tests. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • HackComment src/NServiceBus.Core.Tests/Features/FeatureStartupTests.cs:285 — // This is a hack to bypass the restriction that the same feature type can't be added twice — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
  • HackComment src/NServiceBus.Core/Recoverability/DefaultRecoverabilityPolicy.cs:91 — // this code won't usually throw but in case a user has decided to hack a message/headers and for some bizarre reason — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: PROJ-123`), so the task is planned where tasks live and the ticket links back to the code.
D19 · Documentation Quality · Low XML-doc coverage · ×3
  • Low XML-doc coverage: NServiceBus.Core src/NServiceBus.Core/NServiceBus.Core.csproj — NServiceBus.Core: 50 % XML-doc coverage (1232/2484).
  • Low XML-doc coverage: NServiceBus.Core.Analyzer.Fixes src/NServiceBus.Core.Analyzer.Fixes/NServiceBus.Core.Analyzer.Fixes.csproj — NServiceBus.Core.Analyzer.Fixes: 0 % XML-doc coverage (0/112).
  • Low XML-doc coverage: NServiceBus.Core.Analyzer src/NServiceBus.Core.Analyzer/NServiceBus.Core.Analyzer.csproj — NServiceBus.Core.Analyzer: 1 % XML-doc coverage (3/318).
D5 · Coupling · Off the main sequence · ×3
  • Off the main sequence: NServiceBus.Core.Analyzer.Fixes — NServiceBus.Core.Analyzer.Fixes: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and heavily depended-on, so it's rigid to change.
  • Off the main sequence: NServiceBus.Core.Analyzer — NServiceBus.Core.Analyzer: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and heavily depended-on, so it's rigid to change.
  • Off the main sequence: NServiceBus.Core — NServiceBus.Core: abstractness 0.20, instability 0.00, distance 0.80 — zone of pain — concrete and heavily depended-on, so it's rigid to change.
D10 · Test Quality · Skipped test · ×2
  • Skipped test: Should_for_our_code_exclude_everything_but_NServiceBus_by_default src/NServiceBus.Core.Tests/AssemblyScanner/When_scanning_assemblies.cs:21 — Skipped — Does not work
  • Skipped test: Class_abstract_with_methods_should_not_be_mapped src/NServiceBus.Core.Tests/MessageMapper/When_mapping_usinggenerics.cs:80 — Skipped — Does not work.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) src/NServiceBus.Core/Conventions/Conventions.cs:139 — src/NServiceBus.Core/Conventions/Conventions.cs:139-154 | src/NServiceBus.Core/Conventions/Conventions.cs:182-197
  • Duplicated block (16 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/AddHandlerInterceptor.Suppressor.cs:19 — src/NServiceBus.Core.Analyzer/Handlers/AddHandlerInterceptor.Suppressor.cs:19-34 | src/NServiceBus.Core.Analyzer/Sagas/AddSagaInterceptor.Suppressor.cs:19-34
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/AddHandlerGenerator.cs:37 — src/NServiceBus.Core.Analyzer/Handlers/AddHandlerGenerator.cs:37-48 | src/NServiceBus.Core.Analyzer/Sagas/AddSagaGenerator.cs:38-49
  • Duplicated block (12 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:193 — src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:193-204 | src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:87-98
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×2
  • Duplicated block (9 lines × 2) src/NServiceBus.Core/Routing/MessageDrivenSubscriptions/MessageDrivenUnsubscribeTerminator.cs:36 — src/NServiceBus.Core/Routing/MessageDrivenSubscriptions/MessageDrivenUnsubscribeTerminator.cs:36-44 | src/NServiceBus.Core/Routing/SubscriptionMigrationMode/MigrationUnsubscribeTerminator.cs:43-51
  • Duplicated block (9 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/AddHandlerInterceptor.cs:22 — src/NServiceBus.Core.Analyzer/Handlers/AddHandlerInterceptor.cs:22-30 | src/NServiceBus.Core.Analyzer/Sagas/AddSagaGenerator.cs:23-31
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×2
  • Duplicated block (7 lines × 2) src/NServiceBus.Core/Hosting/KeyedServices/KeyedServiceCollectionAdapter.cs:143 — src/NServiceBus.Core/Hosting/KeyedServices/KeyedServiceCollectionAdapter.cs:143-148 | src/NServiceBus.Core/Hosting/KeyedServices/KeyedServiceCollectionAdapter.cs:152-158
  • Duplicated block (7 lines × 2) src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:53 — src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:53-59 | src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddIHandleMessagesInterfaceFixer.cs:53-59
D1 · Cyclomatic Complexity · HandlerAttributeAnalyzer.Initialize (cyclomatic 63) · ×1
  • HandlerAttributeAnalyzer.Initialize (cyclomatic 63) src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:17 — HandlerAttributeAnalyzer.Initialize has cyclomatic complexity 63 (threshold 15).
D1 · Cyclomatic Complexity · XmlDeserialization.GetPropertyValue (cyclomatic 60) · ×1
  • XmlDeserialization.GetPropertyValue (cyclomatic 60) src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:342 — XmlDeserialization.GetPropertyValue has cyclomatic complexity 60 (threshold 15).
D1 · Cyclomatic Complexity · SagaAnalyzer.AnalyzeSagaClass (cyclomatic 39) · ×1
  • SagaAnalyzer.AnalyzeSagaClass (cyclomatic 39) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:73 — SagaAnalyzer.AnalyzeSagaClass has cyclomatic complexity 39 (threshold 15).
D1 · Cyclomatic Complexity · SagaAttributeAnalyzer.Initialize (cyclomatic 29) · ×1
  • SagaAttributeAnalyzer.Initialize (cyclomatic 29) src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:16 — SagaAttributeAnalyzer.Initialize has cyclomatic complexity 29 (threshold 15).
D1 · Cyclomatic Complexity · HandlerAttributeFixer.MoveHandlerAttribute (cyclomatic 27) · ×1
  • HandlerAttributeFixer.MoveHandlerAttribute (cyclomatic 27) src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:121 — HandlerAttributeFixer.MoveHandlerAttribute has cyclomatic complexity 27 (threshold 15).
D1 · Cyclomatic Complexity · XmlSerializerCache.InitTypeInternal (cyclomatic 26) · ×1
  • XmlSerializerCache.InitTypeInternal (cyclomatic 26) src/NServiceBus.Core/Serializers/XML/XmlSerializerCache.cs:27 — XmlSerializerCache.InitTypeInternal has cyclomatic complexity 26 (threshold 15).
D1 · Cyclomatic Complexity · XmlSerialization.WriteEntry (cyclomatic 24) · ×1
  • XmlSerialization.WriteEntry (cyclomatic 24) src/NServiceBus.Core/Serializers/XML/XmlSerialization.cs:172 — XmlSerialization.WriteEntry has cyclomatic complexity 24 (threshold 15).
D1 · Cyclomatic Complexity · SagaAnalyzer.TryAddSagaMappingsFromExpression (cyclomatic 22) · ×1
  • SagaAnalyzer.TryAddSagaMappingsFromExpression (cyclomatic 22) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:625 — SagaAnalyzer.TryAddSagaMappingsFromExpression has cyclomatic complexity 22 (threshold 15).
D1 · Cyclomatic Complexity · SagaAttributeFixer.MoveSagaAttribute (cyclomatic 21) · ×1
  • SagaAttributeFixer.MoveSagaAttribute (cyclomatic 21) src/NServiceBus.Core.Analyzer.Fixes/Sagas/SagaAttributeFixer.cs:113 — SagaAttributeFixer.MoveSagaAttribute has cyclomatic complexity 21 (threshold 15).
D1 · Cyclomatic Complexity · SagaPersistenceBehavior.Invoke (cyclomatic 20) · ×1
  • SagaPersistenceBehavior.Invoke (cyclomatic 20) src/NServiceBus.Core/Sagas/SagaPersistenceBehavior.cs:15 — SagaPersistenceBehavior.Invoke has cyclomatic complexity 20 (threshold 15).
D1 · Cyclomatic Complexity · ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken (cyclomatic 19) · ×1
  • ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken (cyclomatic 19) src/NServiceBus.Core.Analyzer/ForwardCancellationTokenAnalyzer.cs:302 — ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken has cyclomatic complexity 19 (threshold 15).
D1 · Cyclomatic Complexity · PipelineModelBuilder.Build (cyclomatic 18) · ×1
  • PipelineModelBuilder.Build (cyclomatic 18) src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:17 — PipelineModelBuilder.Build has cyclomatic complexity 18 (threshold 15).
D1 · Cyclomatic Complexity · DateTimeOffsetHelper.ToDateTimeOffset (cyclomatic 17) · ×1
  • DateTimeOffsetHelper.ToDateTimeOffset (cyclomatic 17) src/NServiceBus.Core/DateTimeOffsetHelper.cs:23 — DateTimeOffsetHelper.ToDateTimeOffset has cyclomatic complexity 17 (threshold 15).
D1 · Cyclomatic Complexity · ConventionBasedHandlerHelper.IsValidConventionBasedHandleMethod (cyclomatic 17) · ×1
  • ConventionBasedHandlerHelper.IsValidConventionBasedHandleMethod (cyclomatic 17) src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs:65 — ConventionBasedHandlerHelper.IsValidConventionBasedHandleMethod has cyclomatic complexity 17 (threshold 15).
D1 · Cyclomatic Complexity · SagaAnalyzer.AnalyzeSagaDataClass (cyclomatic 17) · ×1
  • SagaAnalyzer.AnalyzeSagaDataClass (cyclomatic 17) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:289 — SagaAnalyzer.AnalyzeSagaDataClass has cyclomatic complexity 17 (threshold 15).
D1 · Cyclomatic Complexity · HandlerRegistryExtensionsAttributeAnalyzer.Initialize (cyclomatic 16) · ×1
  • HandlerRegistryExtensionsAttributeAnalyzer.Initialize (cyclomatic 16) src/NServiceBus.Core.Analyzer/HandlerRegistryExtensionsAttributeAnalyzer.cs:30 — HandlerRegistryExtensionsAttributeAnalyzer.Initialize has cyclomatic complexity 16 (threshold 15).
D17 · Explicit Debt · CommentedOutCode · ×1
  • CommentedOutCode src/NServiceBus.Core.Analyzer.Fixes/Sagas/RewriteConfigureHowToFindSagaFixer.cs:151 — 3 consecutive commented-code lines
D2 · Cognitive Complexity · XmlDeserialization.GetPropertyValue (cognitive 131) · ×1
  • XmlDeserialization.GetPropertyValue (cognitive 131) src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:342 — XmlDeserialization.GetPropertyValue has cognitive complexity 131 (threshold 15).
D2 · Cognitive Complexity · HandlerAttributeAnalyzer.Initialize (cognitive 126) · ×1
  • HandlerAttributeAnalyzer.Initialize (cognitive 126) src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:17 — HandlerAttributeAnalyzer.Initialize has cognitive complexity 126 (threshold 15).
D2 · Cognitive Complexity · SagaAnalyzer.AnalyzeSagaClass (cognitive 88) · ×1
  • SagaAnalyzer.AnalyzeSagaClass (cognitive 88) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:73 — SagaAnalyzer.AnalyzeSagaClass has cognitive complexity 88 (threshold 15).
D2 · Cognitive Complexity · SagaAttributeAnalyzer.Initialize (cognitive 50) · ×1
  • SagaAttributeAnalyzer.Initialize (cognitive 50) src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:16 — SagaAttributeAnalyzer.Initialize has cognitive complexity 50 (threshold 15).
D2 · Cognitive Complexity · XmlSerializerCache.InitTypeInternal (cognitive 44) · ×1
  • XmlSerializerCache.InitTypeInternal (cognitive 44) src/NServiceBus.Core/Serializers/XML/XmlSerializerCache.cs:27 — XmlSerializerCache.InitTypeInternal has cognitive complexity 44 (threshold 15).
D2 · Cognitive Complexity · HandlerAttributeFixer.MoveHandlerAttribute (cognitive 44) · ×1
  • HandlerAttributeFixer.MoveHandlerAttribute (cognitive 44) src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:121 — HandlerAttributeFixer.MoveHandlerAttribute has cognitive complexity 44 (threshold 15).
D2 · Cognitive Complexity · XmlSerialization.WriteEntry (cognitive 43) · ×1
  • XmlSerialization.WriteEntry (cognitive 43) src/NServiceBus.Core/Serializers/XML/XmlSerialization.cs:172 — XmlSerialization.WriteEntry has cognitive complexity 43 (threshold 15).
D2 · Cognitive Complexity · SagaPersistenceBehavior.Invoke (cognitive 40) · ×1
  • SagaPersistenceBehavior.Invoke (cognitive 40) src/NServiceBus.Core/Sagas/SagaPersistenceBehavior.cs:15 — SagaPersistenceBehavior.Invoke has cognitive complexity 40 (threshold 15).
D2 · Cognitive Complexity · SagaAnalyzer.TryAddSagaMappingsFromExpression (cognitive 40) · ×1
  • SagaAnalyzer.TryAddSagaMappingsFromExpression (cognitive 40) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:625 — SagaAnalyzer.TryAddSagaMappingsFromExpression has cognitive complexity 40 (threshold 15).
D2 · Cognitive Complexity · Parser.GetRegistrationMethodNamePatterns (cognitive 38) · ×1
  • Parser.GetRegistrationMethodNamePatterns (cognitive 38) src/NServiceBus.Core.Analyzer/AddHandlerAndSagasRegistrationGenerator.Parser.cs:147 — Parser.GetRegistrationMethodNamePatterns has cognitive complexity 38 (threshold 15).
D2 · Cognitive Complexity · ConventionBasedHandlerHelper.CollectInterfaceHandleCallees (cognitive 37) · ×1
  • ConventionBasedHandlerHelper.CollectInterfaceHandleCallees (cognitive 37) src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs:135 — ConventionBasedHandlerHelper.CollectInterfaceHandleCallees has cognitive complexity 37 (threshold 15).
D2 · Cognitive Complexity · SagaAttributeFixer.MoveSagaAttribute (cognitive 35) · ×1
  • SagaAttributeFixer.MoveSagaAttribute (cognitive 35) src/NServiceBus.Core.Analyzer.Fixes/Sagas/SagaAttributeFixer.cs:113 — SagaAttributeFixer.MoveSagaAttribute has cognitive complexity 35 (threshold 15).
D2 · Cognitive Complexity · PipelineModelBuilder.Build (cognitive 34) · ×1
  • PipelineModelBuilder.Build (cognitive 34) src/NServiceBus.Core/Pipeline/PipelineModelBuilder.cs:17 — PipelineModelBuilder.Build has cognitive complexity 34 (threshold 15).
D2 · Cognitive Complexity · KeyedServiceCollectionAdapter.EnsureKeyedDescriptor (cognitive 30) · ×1
  • KeyedServiceCollectionAdapter.EnsureKeyedDescriptor (cognitive 30) src/NServiceBus.Core/Hosting/KeyedServices/KeyedServiceCollectionAdapter.cs:134 — KeyedServiceCollectionAdapter.EnsureKeyedDescriptor has cognitive complexity 30 (threshold 15).
D2 · Cognitive Complexity · AssemblyScanner.GetScannableAssemblies (cognitive 28) · ×1
  • AssemblyScanner.GetScannableAssemblies (cognitive 28) src/NServiceBus.Core/Hosting/Helpers/AssemblyScanner.cs:73 — AssemblyScanner.GetScannableAssemblies has cognitive complexity 28 (threshold 15).
D2 · Cognitive Complexity · XmlSerializerCache.GetAllPropertiesForType (cognitive 28) · ×1
  • XmlSerializerCache.GetAllPropertiesForType (cognitive 28) src/NServiceBus.Core/Serializers/XML/XmlSerializerCache.cs:145 — XmlSerializerCache.GetAllPropertiesForType has cognitive complexity 28 (threshold 15).
D2 · Cognitive Complexity · DateTimeOffsetHelper.ToDateTimeOffset (cognitive 25) · ×1
  • DateTimeOffsetHelper.ToDateTimeOffset (cognitive 25) src/NServiceBus.Core/DateTimeOffsetHelper.cs:23 — DateTimeOffsetHelper.ToDateTimeOffset has cognitive complexity 25 (threshold 15).
D2 · Cognitive Complexity · SagaAnalyzer.AnalyzeSagaDataClass (cognitive 25) · ×1
  • SagaAnalyzer.AnalyzeSagaDataClass (cognitive 25) src/NServiceBus.Core.Analyzer/Sagas/SagaAnalyzer.cs:289 — SagaAnalyzer.AnalyzeSagaDataClass has cognitive complexity 25 (threshold 15).
D2 · Cognitive Complexity · HandlerRegistryExtensionsAttributeAnalyzer.Initialize (cognitive 23) · ×1
  • HandlerRegistryExtensionsAttributeAnalyzer.Initialize (cognitive 23) src/NServiceBus.Core.Analyzer/HandlerRegistryExtensionsAttributeAnalyzer.cs:30 — HandlerRegistryExtensionsAttributeAnalyzer.Initialize has cognitive complexity 23 (threshold 15).
D2 · Cognitive Complexity · XmlDeserialization.InferNodeType (cognitive 22) · ×1
  • XmlDeserialization.InferNodeType (cognitive 22) src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:193 — XmlDeserialization.InferNodeType has cognitive complexity 22 (threshold 15).
D2 · Cognitive Complexity · MessageMetadataRegistry.GetMessageMetadata (cognitive 22) · ×1
  • MessageMetadataRegistry.GetMessageMetadata (cognitive 22) src/NServiceBus.Core/Unicast/Messages/MessageMetadataRegistry.cs:89 — MessageMetadataRegistry.GetMessageMetadata has cognitive complexity 22 (threshold 15).
D2 · Cognitive Complexity · ConventionBasedHandlerHelper.ImplementsHandlerInterfaceMember (cognitive 21) · ×1
  • ConventionBasedHandlerHelper.ImplementsHandlerInterfaceMember (cognitive 21) src/NServiceBus.Core.Analyzer/Handlers/ConventionBasedHandlerHelper.cs:208 — ConventionBasedHandlerHelper.ImplementsHandlerInterfaceMember has cognitive complexity 21 (threshold 15).
D2 · Cognitive Complexity · Conventions.IsMessageType (cognitive 20) · ×1
  • Conventions.IsMessageType (cognitive 20) src/NServiceBus.Core/Conventions/Conventions.cs:28 — Conventions.IsMessageType has cognitive complexity 20 (threshold 15).
D2 · Cognitive Complexity · MessageMapper.InnerInitialize (cognitive 20) · ×1
  • MessageMapper.InnerInitialize (cognitive 20) src/NServiceBus.Core/MessageInterfaces/MessageMapper/Reflection/MessageMapper.cs:132 — MessageMapper.InnerInitialize has cognitive complexity 20 (threshold 15).
D2 · Cognitive Complexity · EnvelopeUnwrapper.UnwrapEnvelope (cognitive 19) · ×1
  • EnvelopeUnwrapper.UnwrapEnvelope (cognitive 19) src/NServiceBus.Core/Envelopes/EnvelopeUnwrapper.cs:14 — EnvelopeUnwrapper.UnwrapEnvelope has cognitive complexity 19 (threshold 15).
D2 · Cognitive Complexity · XmlDeserialization.CacheDefaultNamespaceMessageBaseTypesAndPrefixes (cognitive 18) · ×1
  • XmlDeserialization.CacheDefaultNamespaceMessageBaseTypesAndPrefixes (cognitive 18) src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:128 — XmlDeserialization.CacheDefaultNamespaceMessageBaseTypesAndPrefixes has cognitive complexity 18 (threshold 15).
D2 · Cognitive Complexity · DeserializeMessageConnector.Extract (cognitive 17) · ×1
  • DeserializeMessageConnector.Extract (cognitive 17) src/NServiceBus.Core/Pipeline/Incoming/DeserializeMessageConnector.cs:60 — DeserializeMessageConnector.Extract has cognitive complexity 17 (threshold 15).
D2 · Cognitive Complexity · WrappedMessageReceiver.RateLimitLoop (cognitive 17) · ×1
  • WrappedMessageReceiver.RateLimitLoop (cognitive 17) src/NServiceBus.Core/Receiving/WrappedMessageReceiver.cs:96 — WrappedMessageReceiver.RateLimitLoop has cognitive complexity 17 (threshold 15).
D2 · Cognitive Complexity · XmlDeserialization.GetObjectOfTypeFromNode (cognitive 17) · ×1
  • XmlDeserialization.GetObjectOfTypeFromNode (cognitive 17) src/NServiceBus.Core/Serializers/XML/XmlDeserialization.cs:274 — XmlDeserialization.GetObjectOfTypeFromNode has cognitive complexity 17 (threshold 15).
D2 · Cognitive Complexity · ActivityFactory.StartIncomingPipelineActivity (cognitive 16) · ×1
  • ActivityFactory.StartIncomingPipelineActivity (cognitive 16) src/NServiceBus.Core/OpenTelemetry/Tracing/ActivityFactory.cs:11 — ActivityFactory.StartIncomingPipelineActivity has cognitive complexity 16 (threshold 15).
D2 · Cognitive Complexity · MigrationSubscribeTerminator.Terminate (cognitive 16) · ×1
  • MigrationSubscribeTerminator.Terminate (cognitive 16) src/NServiceBus.Core/Routing/SubscriptionMigrationMode/MigrationSubscribeTerminator.cs:31 — MigrationSubscribeTerminator.Terminate has cognitive complexity 16 (threshold 15).
D2 · Cognitive Complexity · ForwardCancellationTokenAnalyzer.LooksLikeCancellationToken (cognitive 16) · ×1
  • ForwardCancellationTokenAnalyzer.LooksLikeCancellationToken (cognitive 16) src/NServiceBus.Core.Analyzer/ForwardCancellationTokenAnalyzer.cs:152 — ForwardCancellationTokenAnalyzer.LooksLikeCancellationToken has cognitive complexity 16 (threshold 15).
D2 · Cognitive Complexity · ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken (cognitive 16) · ×1
  • ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken (cognitive 16) src/NServiceBus.Core.Analyzer/ForwardCancellationTokenAnalyzer.cs:302 — ForwardCancellationTokenAnalyzer.HasSameParametersPlusCancellationToken has cognitive complexity 16 (threshold 15).
D24 · Comment Value · LLM evaluation failed · ×1
  • LLM evaluation failed — JSON parse error: Expected end of string, but instead reached end of data. Path: $.notable[5].comment | LineNumber: 0 | BytePositionInLine: 1014.
D36 · Supply-chain Provenance & Signing · Unpinned build actions · ×1
  • Unpinned build actions — CI references GitHub Actions by a floating ref (@main / @tag) rather than a pinned commit SHA, weakening build integrity.
D4 · Code Duplication · Duplicated block (118 lines × 2) · ×1
  • Duplicated block (118 lines × 2) src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:144 — src/NServiceBus.Core.Analyzer.Fixes/Handlers/HandlerAttributeFixer.cs:144-261 | src/NServiceBus.Core.Analyzer.Fixes/Sagas/SagaAttributeFixer.cs:133-226
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:84 — src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddConventionBasedHandleMethodFixer.cs:84-108 | src/NServiceBus.Core.Analyzer.Fixes/Handlers/AddIHandleMessagesInterfaceFixer.cs:99-119
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×1
  • Duplicated block (21 lines × 2) src/NServiceBus.Core.Analyzer/Sagas/Sagas.Parser.cs:177 — src/NServiceBus.Core.Analyzer/Sagas/Sagas.Parser.cs:177-196 | src/NServiceBus.Core.Analyzer/Sagas/Sagas.Parser.cs:215-235
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1
  • Duplicated block (18 lines × 2) src/NServiceBus.Core/Routing/NativeSubscribeTerminator.cs:20 — src/NServiceBus.Core/Routing/NativeSubscribeTerminator.cs:20-37 | src/NServiceBus.Core/Routing/SubscriptionMigrationMode/MigrationSubscribeTerminator.cs:34-51
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) src/NServiceBus.Core/DateTimeOffsetHelper.cs:49 — src/NServiceBus.Core/DateTimeOffsetHelper.cs:49-65 | src/NServiceBus.Core/DateTimeOffsetHelper.cs:67-83 | src/NServiceBus.Core/DateTimeOffsetHelper.cs:85-101
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) src/NServiceBus.Core/Transports/Learning/DirectoryBasedTransaction.cs:119 — src/NServiceBus.Core/Transports/Learning/DirectoryBasedTransaction.cs:119-135 | src/NServiceBus.Core/Transports/Learning/DirectoryBasedTransaction.cs:149-164
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:191 — src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:191-204 | src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:210-223 | src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetrics.cs:229-242
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:213 — src/NServiceBus.Core.Analyzer/Handlers/HandlerAttributeAnalyzer.cs:213-226 | src/NServiceBus.Core.Analyzer/Sagas/SagaAttributeAnalyzer.cs:107-120
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×1
  • Duplicated block (13 lines × 2) src/NServiceBus.Core.Analyzer/AddHandlerAndSagasRegistrationGenerator.Emitter.cs:149 — src/NServiceBus.Core.Analyzer/AddHandlerAndSagasRegistrationGenerator.Emitter.cs:149-160 | src/NServiceBus.Core.Analyzer/AddHandlerAndSagasRegistrationGenerator.Emitter.cs:166-178
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×1
  • Duplicated block (11 lines × 2) src/NServiceBus.Core/Sagas/HeaderPropertySagaFinder.cs:44 — src/NServiceBus.Core/Sagas/HeaderPropertySagaFinder.cs:44-53 | src/NServiceBus.Core/Sagas/PropertySagaFinder.cs:27-37
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×1
  • Duplicated block (10 lines × 2) src/NServiceBus.Testing.Fakes/TestableMessageSession.cs:95 — src/NServiceBus.Testing.Fakes/TestableMessageSession.cs:95-104 | src/NServiceBus.Testing.Fakes/TestablePipelineContext.cs:97-106
D8 · Code Coverage · Coverage not measured · ×1
  • Coverage not measured — test suite did not build — Coverage NOT MEASURED: the repo's own test suite did not build (a C#/MSBuild compiler error in the test code), so no coverage could be collected. It is excluded from the score rather than counted as a near-zero defect. Fix the test build, or commit the Cobertura/OpenCover/lcov report your CI already produces, and real coverage will be measured.
Recommendation — 12 finding(s)
D16 · Bus Factor · Off-boarding risk · ×3
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 80 significant file(s) lose their only recent owner (largest: src/NServiceBus.Core.Analyzer/ForwardCancellationTokenAnalyzer.cs). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 8 significant file(s) lose their only recent owner (largest: src/NServiceBus.Core.Analyzer.Fixes/Sagas/RewriteConfigureHowToFindSagaFixer.cs). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 6 significant file(s) lose their only recent owner (largest: src/NServiceBus.Core/Serializers/XML/XmlSerializerCache.cs). Pair on, review, or document these before any departure.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 3 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (99 single-owned of 254 analysed files in total).
D19 · Documentation Quality · The Getting started section links to two tutorials and one NuGet package for templates but does not mention how to install NServiceBus via nuget or dotnet new. · ×1
  • The Getting started section links to two tutorials and one NuGet package for templates but does not mention how to install NServiceBus via nuget or dotnet new. README.md — Add a brief Install/Startup snippet showing how to add NServiceBus to a project using dotnet new or the ParticularTemplates nuget.
D23 · Boundary Type-Coupling · Bounded contexts not declared · ×1
  • Bounded contexts not declared — At 41k LoC across 11 projects the codebase is large and multi-module, so explicit bounded contexts are needed. Declare architecture.contexts (≥2) in config to assess cross-boundary type coupling.
D26 · Project Cohesion · Split NServiceBus.Core · ×1
  • Split NServiceBus.Core — A core library at 32k LoC and 354 types across 36 unrelated namespaces is a sprawling grab-bag. Suggested: by namespace: NServiceBus.Routing, NServiceBus.Serialization, NServiceBus.Filters
D27 · Navigability · Scattered collaborators · ×1
  • Scattered collaborators — 68 % of calls cross a namespace and only 49 % of collaborators are co-located — group each feature's code into a vertical slice so a call's collaborators sit together.
D34 · Knowledge Freshness · knowledge concentrated in recent work · ×1
  • knowledge concentrated in recent work — freshness signal contradicted by repo activity — File-level freshness contradicts repo activity: 85 commits in the last 90 days, yet 153 of 254 significant files carry no living knowledge. The history shape (bulk moves/imports or broad sweep commits diluting per-file focus) is distorting the recency signal, so freshness is not scored for this run.
D36 · Supply-chain Provenance & Signing · No build provenance · ×1
  • No build provenance — No SLSA provenance generation or build attestation found in CI (e.g. slsa-github-generator, actions/attest-build-provenance).
D36 · Supply-chain Provenance & Signing · No artifact signing · ×1
  • No artifact signing — No artifact signing found in CI (e.g. cosign / sigstore / gitsign).
D36 · Supply-chain Provenance & Signing · No SBOM · ×1
  • No SBOM — No SBOM generation or committed SBOM found (e.g. syft / anchore/sbom-action / *.spdx.json / *.cdx.json).
Info — 7 finding(s)
D10 · Test Quality · Skipped (documented) · ×4
  • Skipped (documented): Should_deserialize_arrayList src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:183 — Skipped with a documented reason — a deferral, not lazy debt: ArrayList is not supported
  • Skipped (documented): Should_deserialize_hashtable src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:198 — Skipped with a documented reason — a deferral, not lazy debt: Hashtable is not supported
  • Skipped (documented): System_classes_with_non_default_constructors_should_be_supported src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:1140 — Skipped with a documented reason — a deferral, not lazy debt: We're not supporting this type
  • Skipped (documented): Messages_with_polymorphic_properties_should_be_supported src/NServiceBus.Core.Tests/Serializers/XML/SerializerTests.cs:1162 — Skipped with a documented reason — a deferral, not lazy debt: We're currently not supporting polymorphic properties
D18 · Solution Shape · Build status unknown · ×1
  • Build status unknown — The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
D19 · Documentation Quality · XML-doc coverage · ×1
  • XML-doc coverage: NServiceBus.Testing.Fakes src/NServiceBus.Testing.Fakes/NServiceBus.Testing.Fakes.csproj — NServiceBus.Testing.Fakes: 83 % XML-doc coverage (145/175).
D22 · Internal API Consistency · No exposed public API · ×1
  • No exposed public API — No intentionally-exposed types (IsPackable or .Contracts) to evaluate.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaksgitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D29 · Static Analysis (SAST)semgrepsemgrep --config auto --json --quiet --timeout 0 --metrics off .0
D30 · Dependency Vulnerabilitiesdotnetdotnet: not applicable — the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan for NuGet CVEs — excluded rather than scored; re-run on an SDK that can restore this solution0
D31 · IaC & Container Securitytrivytrivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.0
D32 · Data Compliance (PII/GDPR)semgrepsemgrep: not applicable — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.0
D33 · JS/npm Dependency Vulnerabilitiestrivytrivy: not applicable — No JS/npm manifest or lockfile found outside bin/obj (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.0
D38 · OSV Dependency Vulnerabilitiesosv-scannerosv-scanner: not applicable — No JS/npm lockfile found outside bin/obj (package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); nothing for OSV to scan.0

Run 019f132b-f66a-7ba9-8d19-bae32cfeeb08 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Appendix C — Personal-data map

Every field, property and record parameter whose name is conventional personal data — 4 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by name with a deliberately specific classifier (the same one the GDPR dimensions use, so CardDefinition or FileName don't trip); informational — it feeds no score.

Name — 4 field(s)
  • AssemblyIdentity.FullName src/NServiceBus.Core/Hosting/Helpers/AssemblyScanner.cs:423
  • AssemblyDetails.FullName src/NServiceBus.Core/Hosting/Helpers/AssemblyScanningDiagnostics.cs:28
  • PersistenceDefinition.FullName src/NServiceBus.Core/Persistence/PersistenceDefinition.cs:53
  • ReceiveComponentManifestMessageType.FullName src/NServiceBus.Core/Receiving/ReceiveComponent.Configuration.cs:52

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md