Public report of Whaally/Domain, published 22 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 22 October 2026, 00:08 UTC · Survey ID cd_2fece0d3db8f4bbf952d6fc2653dca59
Whaally/Domain
Measured 22 October 2026, 00:03 UTC, at code version 3293740
Code coverage is not measured: Suite not runnable in-image and no committed report.
CAI scoreAdequate
CriticalWeakAdequateStrongExemplary
Down 2 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A small codebase: 2,962 lines of product code in 9 projects, tests not counted · Estimated rebuild effort: about 0.1 person-years · Weakest lens: Production Readiness, 47
Findings by how serious they are
11 critical127 serious63 minor
4 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
22 October 2026, 00:03 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
76of 81 dimensions measured by tools. The other 5 are advisory notes from an AI model, which explain the code but don't count towards the score.
152of 201 findings point to an exact file and line, so you can open each one in the code. The other 49 concern the repository as a whole, such as missing documentation.
81dimensions across 8 lenses, read from 2,962 lines of product code in 9 projects.
Whaally/Domain scores 56 out of 100 and is rated Adequate, while six of its eight lenses score higher still: Event-Driven at 100 and Domain Modelling at 96, both rated Exemplary, Architecture at 83 and Code Health at 73, both rated Strong, and Security and Compliance and Performance at 65, both rated Adequate.
The score is lower than those six because the weakest lens counts most, and here that is Production Readiness, which scores 47 and is rated Weak. Its Security & performance tooling dimension scores 1 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to resolve the 2 Outdated finding(s) in Dependency Hygiene and to resolve the 1 Vulnerable finding(s) in Dependency Hygiene, and if Production Readiness rose to 70, the score would rise from 56 to about 62.
11 findings are critical: five in Static Analysis (SAST), four in Explicit Debt, one in Dependency Hygiene and one in Project dependency cycles.
Watchdog couldn't measure IL Efficiency, CQS / query purity and Runtime accessibility in this code, so those dimensions are left out of the score. The product code is 2,962 lines, which would take an estimated 0.1 person-years, around €6,400, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain/Saga/SagaContext.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain/Service/ServiceHandlerContext.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs
Async & latency hygiene · Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 1 finding
This critical or serious finding was in the previous survey, on 7 October 2026, and is gone from this one.
Supply-chain Provenance & Signing REDACTED
Rebuild cost: about €6,400 · Estimate
Cost to rebuild
€2,100 to €11,000, for 35 to 112 hours of work, about 0.1 person-years for one engineer
Difficulty of the problem
Very high, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 56. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Small: 2,962 lines of product code, of which 50% is declarations and boilerplate, 23% straight logic and 27% logic with branches
Comment lines
The estimate prices 2,830 lines. Comment lines count towards the size of 2,962 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 2 Outdated finding(s) in Dependency Hygiene — start with Directory.Build.targets, Skyhop.Hosting.csproj.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €6,400 to build again, about 0.1 person-years of work. Its weakest lens is Production Readiness, at 47 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 2 Outdated finding(s) in Dependency Hygiene. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for low effort, because it clears the 2 Dependency Hygiene findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
17 modules, with 51 dependencies between them. One loop runs through 5 of the modules, marked above the diagonal.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
Abstractions.Event uses Abstractions, so a change to Abstractions can break Abstractions.Event, while a change to Abstractions.Event can't break Abstractions.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Abstractions.Command uses Abstractions.Event, so a change to Abstractions.Event can break Abstractions.Command, while a change to Abstractions.Command can't break Abstractions.Event.
Position
Below the diagonal: Abstractions.Command uses a module listed above it, which is the healthy direction.
2→7 Abstractions.Command uses Abstractionspart of a loop✕
Connections
9 pairs of types, where a type in Abstractions.Command uses a type in Abstractions.
Abstractions.Command uses Abstractions, so a change to Abstractions can break Abstractions.Command, while a change to Abstractions.Command can't break Abstractions.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Abstractions.Aggregate uses Abstractions.Event, so a change to Abstractions.Event can break Abstractions.Aggregate, while a change to Abstractions.Aggregate can't break Abstractions.Event.
Position
Below the diagonal: Abstractions.Aggregate uses a module listed above it, which is the healthy direction.
Abstractions.Aggregate uses Abstractions.Command, so a change to Abstractions.Command can break Abstractions.Aggregate, while a change to Abstractions.Aggregate can't break Abstractions.Command.
Position
Below the diagonal: Abstractions.Aggregate uses a module listed above it, which is the healthy direction.
Abstractions.Service uses Abstractions.Command, so a change to Abstractions.Command can break Abstractions.Service, while a change to Abstractions.Service can't break Abstractions.Command.
Position
Below the diagonal: Abstractions.Service uses a module listed above it, which is the healthy direction.
Abstractions.Service uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Abstractions.Service, while a change to Abstractions.Service can't break Abstractions.Aggregate.
Position
Below the diagonal: Abstractions.Service uses a module listed above it, which is the healthy direction.
4→7 Abstractions.Service uses Abstractionspart of a loop✕
Connections
8 pairs of types, where a type in Abstractions.Service uses a type in Abstractions.
Abstractions.Service uses Abstractions, so a change to Abstractions can break Abstractions.Service, while a change to Abstractions.Service can't break Abstractions.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Aggregate uses Abstractions.Command, so a change to Abstractions.Command can break Aggregate, while a change to Aggregate can't break Abstractions.Command.
Position
Below the diagonal: Aggregate uses a module listed above it, which is the healthy direction.
Aggregate uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Aggregate, while a change to Aggregate can't break Abstractions.Aggregate.
Position
Below the diagonal: Aggregate uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Infrastructure.OrleansHost, while a change to Infrastructure.OrleansHost can't break Abstractions.Aggregate.
Position
Below the diagonal: Infrastructure.OrleansHost uses a module listed above it, which is the healthy direction.
Abstractions uses Abstractions.Event, so a change to Abstractions.Event can break Abstractions, while a change to Abstractions can't break Abstractions.Event.
Position
Below the diagonal: Abstractions uses a module listed above it, which is the healthy direction.
Abstractions uses Abstractions.Command, so a change to Abstractions.Command can break Abstractions, while a change to Abstractions can't break Abstractions.Command.
Position
Below the diagonal: Abstractions uses a module listed above it, which is the healthy direction.
Abstractions uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Abstractions, while a change to Abstractions can't break Abstractions.Aggregate.
Position
Below the diagonal: Abstractions uses a module listed above it, which is the healthy direction.
Abstractions uses Abstractions.Service, so a change to Abstractions.Service can break Abstractions, while a change to Abstractions can't break Abstractions.Service.
Position
Below the diagonal: Abstractions uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Grains uses Abstractions.Event, so a change to Abstractions.Event can break Infrastructure.OrleansHost.Grains, while a change to Infrastructure.OrleansHost.Grains can't break Abstractions.Event.
Position
Below the diagonal: Infrastructure.OrleansHost.Grains uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Grains uses Abstractions.Command, so a change to Abstractions.Command can break Infrastructure.OrleansHost.Grains, while a change to Infrastructure.OrleansHost.Grains can't break Abstractions.Command.
Position
Below the diagonal: Infrastructure.OrleansHost.Grains uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Grains uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Infrastructure.OrleansHost.Grains, while a change to Infrastructure.OrleansHost.Grains can't break Abstractions.Aggregate.
Position
Below the diagonal: Infrastructure.OrleansHost.Grains uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Grains uses Infrastructure.OrleansHost, so a change to Infrastructure.OrleansHost can break Infrastructure.OrleansHost.Grains, while a change to Infrastructure.OrleansHost.Grains can't break Infrastructure.OrleansHost.
Position
Below the diagonal: Infrastructure.OrleansHost.Grains uses a module listed above it, which is the healthy direction.
Whaally.Domain uses Abstractions.Event, so a change to Abstractions.Event can break Whaally.Domain, while a change to Whaally.Domain can't break Abstractions.Event.
Position
Below the diagonal: Whaally.Domain uses a module listed above it, which is the healthy direction.
Whaally.Domain uses Abstractions.Command, so a change to Abstractions.Command can break Whaally.Domain, while a change to Whaally.Domain can't break Abstractions.Command.
Position
Below the diagonal: Whaally.Domain uses a module listed above it, which is the healthy direction.
Whaally.Domain uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Whaally.Domain, while a change to Whaally.Domain can't break Abstractions.Aggregate.
Position
Below the diagonal: Whaally.Domain uses a module listed above it, which is the healthy direction.
Whaally.Domain uses Abstractions.Service, so a change to Abstractions.Service can break Whaally.Domain, while a change to Whaally.Domain can't break Abstractions.Service.
Position
Below the diagonal: Whaally.Domain uses a module listed above it, which is the healthy direction.
Abstractions.Saga uses Abstractions.Event, so a change to Abstractions.Event can break Abstractions.Saga, while a change to Abstractions.Saga can't break Abstractions.Event.
Position
Below the diagonal: Abstractions.Saga uses a module listed above it, which is the healthy direction.
Abstractions.Saga uses Abstractions.Command, so a change to Abstractions.Command can break Abstractions.Saga, while a change to Abstractions.Saga can't break Abstractions.Command.
Position
Below the diagonal: Abstractions.Saga uses a module listed above it, which is the healthy direction.
Abstractions.Saga uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Abstractions.Saga, while a change to Abstractions.Saga can't break Abstractions.Aggregate.
Position
Below the diagonal: Abstractions.Saga uses a module listed above it, which is the healthy direction.
Abstractions.Saga uses Abstractions.Service, so a change to Abstractions.Service can break Abstractions.Saga, while a change to Abstractions.Saga can't break Abstractions.Service.
Position
Below the diagonal: Abstractions.Saga uses a module listed above it, which is the healthy direction.
Abstractions.Saga uses Abstractions, so a change to Abstractions can break Abstractions.Saga, while a change to Abstractions.Saga can't break Abstractions.
Position
Below the diagonal: Abstractions.Saga uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.MartenPersistence uses Abstractions.Event, so a change to Abstractions.Event can break Infrastructure.OrleansHost.MartenPersistence, while a change to Infrastructure.OrleansHost.MartenPersistence can't break Abstractions.Event.
Position
Below the diagonal: Infrastructure.OrleansHost.MartenPersistence uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.MartenPersistence uses Infrastructure.OrleansHost.Grains, so a change to Infrastructure.OrleansHost.Grains can break Infrastructure.OrleansHost.MartenPersistence, while a change to Infrastructure.OrleansHost.MartenPersistence can't break Infrastructure.OrleansHost.Grains.
Position
Below the diagonal: Infrastructure.OrleansHost.MartenPersistence uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Surrogates uses Abstractions.Event, so a change to Abstractions.Event can break Infrastructure.OrleansHost.Surrogates, while a change to Infrastructure.OrleansHost.Surrogates can't break Abstractions.Event.
Position
Below the diagonal: Infrastructure.OrleansHost.Surrogates uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Surrogates uses Abstractions.Command, so a change to Abstractions.Command can break Infrastructure.OrleansHost.Surrogates, while a change to Infrastructure.OrleansHost.Surrogates can't break Abstractions.Command.
Position
Below the diagonal: Infrastructure.OrleansHost.Surrogates uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Surrogates uses Abstractions, so a change to Abstractions can break Infrastructure.OrleansHost.Surrogates, while a change to Infrastructure.OrleansHost.Surrogates can't break Abstractions.
Position
Below the diagonal: Infrastructure.OrleansHost.Surrogates uses a module listed above it, which is the healthy direction.
Service uses Abstractions.Aggregate, so a change to Abstractions.Aggregate can break Service, while a change to Service can't break Abstractions.Aggregate.
Position
Below the diagonal: Service uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Converters uses Command, so a change to Command can break Infrastructure.OrleansHost.Converters, while a change to Infrastructure.OrleansHost.Converters can't break Command.
Position
Below the diagonal: Infrastructure.OrleansHost.Converters uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Converters uses Event, so a change to Event can break Infrastructure.OrleansHost.Converters, while a change to Infrastructure.OrleansHost.Converters can't break Event.
Position
Below the diagonal: Infrastructure.OrleansHost.Converters uses a module listed above it, which is the healthy direction.
Infrastructure.OrleansHost.Converters uses Infrastructure.OrleansHost.Surrogates, so a change to Infrastructure.OrleansHost.Surrogates can break Infrastructure.OrleansHost.Converters, while a change to Infrastructure.OrleansHost.Converters can't break Infrastructure.OrleansHost.Surrogates.
Position
Below the diagonal: Infrastructure.OrleansHost.Converters uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2025 — Software Supply Chain Failures
9
Medium
A05:2025 — Injection
7
High / Critical
Roadmap
Begin by addressing the three critical dependency hygiene issues, prioritizing the outdated packages in Directory.Build.targets and Skyhop.Hosting.csproj, followed by the single vulnerable and deprecated findings. Next, integrate a static application security testing step into the CI pipeline, such as CodeQL or Semgrep, to ensure security regressions fail the build immediately. Finally, clean up the codebase by resolving the ten orphaned files, starting with ServiceCollectionExtensions.cs, DefaultEvaluationAgent.cs, and DefaultAggregateHandler.cs.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 2 Outdated finding(s) in Dependency Hygiene — start with Directory.Build.targets, Skyhop.Hosting.csproj.
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Resolve the 10 Orphaned file finding(s) in Knowledge Freshness — start with ServiceCollectionExtensions.cs, DefaultEvaluationAgent.cs, DefaultAggregateHandler.cs.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 11
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 127
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 63
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 4
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 76 of 81 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 5 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 81 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 152 of 201 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The test suite couldn't be built/run in-image and no coverage report is committed, so line coverage was not measured — and it is EXCLUDED from the score rather than scored on a LoC-ratio proxy. No coverage collector was found in your CI either, so there is no existing report to hand us. You can widen what we reach: optional: add a coverage collector to your test run and commit (or publish) its Cobertura/OpenCover/lcov output anywhere in the repo, or make the suite runnable in-image, and real coverage will be measured.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-contributor repository — bus factor is not applicable (1 contributor(s) across 62 commit(s) sampled, automation and bot accounts excluded). Concentration needs a team to concentrate: with one contributor there is nobody to spread the knowledge to, so there is nothing here for the owner to act on.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/Whaally.Domain.Infrastructure.OrleansHost/OrleansAggregateHandlerFactory.cs`, `src/Whaally.Domain/Command/CommandHandlerContext.cs`, `src/Whaally.Domain/Service/ServiceHandlerContext.cs` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's build of this repository exited 1 and the cause could not be attributed, so no assemblies were produced and there was no IL to read. We do not read it as a defect in the repository: an unattributed failure leans OURS. D18 owns the question of whether this repository builds; it was not answered here.
AX9 CQS / query purity — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 4 query handlers were classified, but the query-purity walk could not open any of their bodies: it recognises a value-returning entry point named Execute/Handle/Consume (±Async), or one implementing a member of the handler interface the type was classified on, and the handlers in this repository have neither. Scoring the set anyway would report every unopened handler as pure, so AX9 abstains instead of publishing a perfect score it did not measure.
AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via Dockerfile (samples/Skyhop.Hosting/Dockerfile). docker build failed (exit 1) — DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
Install the buildx component to build images with BuildKit:
https://docs.docker.com/go/bui…; runtime evidence skipped.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D11 Test Reliability: Flakiness is inferred from history/markers — Watchdog runs the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D23 Boundary Type-Coupling: Boundary leakage is detected from type references across detected contexts — leaks that flow through primitives, serialization or shared infrastructure may not surface as a typed reference.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (5): D19, D21, D24, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
0 method(s) exceeded the cognitive complexity threshold of 15.
✓ On the Gold path — maintain.
Detailed fixes: d2_recommendation.md.
Do you agree with this assessment?
D3 · God Classes10.0 / 10Exemplary✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
4 duplicated block group(s) detected. 2 of the 4 are in trees this repository does not ship — vendored, example/demo, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
Resolve the 1 Duplicated block (17–18 lines × 2) finding(s) in Code Duplication — start with DefaultAggregateHandler.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with DefaultEvaluationAgent.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Duplicated block (15 lines × 2) finding(s) in Code Duplication — start with OnArrival.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
39 test methods: 38 unit, 1 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality7.1 / 10Strong✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
No assertions: CanInvokeCommandtests/Whaally.Domain.Tests/Scenarios/_0002__command_composition/CommandHandlerContextTests.cs:33
What to do
Resolve the 5 Skipped test finding(s) in Test Quality — start with SerializationTests.cs (5). — One of this dimension's main actionable groups (5 warning-level).
Resolve the 1 No assertions finding(s) in Test Quality — start with CommandHandlerContextTests.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests pass reliably, with no flakiness.
Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
Resolve the 2 Outdated finding(s) in Dependency Hygiene — start with Directory.Build.targets, Skyhop.Hosting.csproj. — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 1 Vulnerable finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Deprecated finding(s) in Dependency Hygiene — start with Directory.Build.targets. — One of this dimension's main actionable groups (1 warning-level).
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 164 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 21 direct `PackageReference`(s), and 153 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
Dead code: CorrectTotalFlightCountHandler · ×27samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Commands/CorrectTotalFlightCount.cs:12
Resolve the 27 Dead code finding(s) in Explicit Debt — start with CorrectTotalFlightCount.cs, CorrectTotalFlightTime.cs, RemoveFlight.cs. — One of this dimension's main actionable groups (27 warning-level).
Resolve the 3 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SagaBenchmarkTest.cs (2), EvaluateApplyOperationBenchmark.cs. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 1 NoWarnInCsproj finding(s) in Explicit Debt — start with Whaally.Domain.Infrastructure.OrleansHost.csproj. — One of this dimension's main actionable groups (1 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
9 projects, 140 source files, 3893 hand-written lines of code (2962 production / 931 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 224 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 13 inter-project edges.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
The repository's root README and its sibling directories (Aggregate/Command/Event/Saga/Service) are each excellent domain-design documents. The root README is a strong overview of the project's purpose and an initial sketch of what components exist; it also links to the detailed per-component docs. All component-level documentation is well written, complete, and well-structured with headings, examples, and cross-references (e.g. 'commands', 'events'). There are no missing installation/usage sections in any document, but the README files themselves are not the repository root — they each document their own directories and do not address the repository's overall overview or licensing.
Resolve the 6 Low XML-doc coverage finding(s) in Documentation Quality — start with Whaally.Domain.csproj, Whaally.Domain.Infrastructure.OrleansHost.csproj, Skyhop.Domain.csproj. — One of this dimension's main actionable groups (6 warning-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
What it measures: Whether domain types (IDs, enums, value objects) leak across bounded-context boundaries.
Method: Cross-context domain-type leakage via Roslyn structural classification (strongly-typed IDs / value objects) over every public surface. Exhaustive, deterministic, type-level aggregate-boundary check.
Coverage: Bounded contexts derived from NAMESPACE prefix (or graph-inferred where available); cross-boundary domain-type leakage then checked exhaustively over every public member of every type.
7 domain type(s) cross context boundaries across 6 contexts.
Cross-context type AircraftRemoved (FlightContext → AircraftContext) · ×2samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftRemoved.cs:14
Cross-context type DepartureTimeSet (FlightContext → AircraftContext) · ×2samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs:12
Cross-context type SetAircraft (FlightContext → samples)samples/Skyhop.Hosting/Controllers/FlightController.cs:30
Cross-context type SetDeparture (FlightContext → samples)samples/Skyhop.Hosting/Controllers/FlightController.cs:35
Cross-context type SetArrival (FlightContext → samples)samples/Skyhop.Hosting/Controllers/FlightController.cs:40
+ 3 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 Cross-context type AircraftRemoved (FlightContext → AircraftContext) finding(s) in Boundary Type-Coupling — start with OnAircraftRemoved.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 Cross-context type DepartureTimeSet (FlightContext → AircraftContext) finding(s) in Boundary Type-Coupling — start with OnDeparture.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 Cross-context type SetAircraft (FlightContext → samples) finding(s) in Boundary Type-Coupling — start with FlightController.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Boundary Type-Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d23_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D24 · Comment ValueExemplary◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
95 % of calls cross a namespace and 16 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
7 finding(s): 0 critical, 5 high, 2 medium, 0 low. 3 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 3 file(s) — `src/Whaally.Domain.Infrastructure.OrleansHost/OrleansAggregateHandlerFactory.cs` (line 5), `src/Whaally.Domain/Command/CommandHandlerContext.cs` (line 10), `src/Whaally.Domain/Service/ServiceHandlerContext.cs` (line 12) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 3 of those file(s) — `src/Whaally.Domain.Infrastructure.OrleansHost/OrleansAggregateHandlerFactory.cs`, `src/Whaally.Domain/Command/CommandHandlerContext.cs`, `src/Whaally.Domain/Service/ServiceHandlerContext.cs` — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
No action in Static Analysis (SAST) — all 3 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (3 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
10 of 10 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Whaally.Domain/ServiceCollectionExtensions.cs. Counted over 10 of the 67 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 10 Orphaned file finding(s) in Knowledge Freshness — start with ServiceCollectionExtensions.cs, DefaultEvaluationAgent.cs, DefaultAggregateHandler.cs. — One of this dimension's main actionable groups (10 recommendation-level).
Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
1 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Resolve the 1 End-of-life runtime finding(s) in Platform End-of-Life — start with Whaally.Domain.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`DefaultAggregateHandlerFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_dictionary; e.g. `_dictionary` at line 28). — src/Whaally.Domain/Aggregate/DefaultAggregateHandlerFactory.cs:5
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces Whaally.Domain.Abstractions ↔ Whaally.Domain.Abstractions.Aggregate ↔ Whaally.Domain.Abstractions.Command ↔ Whaally.Domain.Abstractions.Event ↔ Whaally.Domain.Abstractions.Service depend on each other. The lightest dependency in the cycle is Whaally.Domain.Abstractions → Whaally.Domain.Abstractions.Aggregate (Whaally.Domain.Abstractions.IProvideAggregateInstance → Whaally.Domain.Abstractions.Aggregate.IAggregate, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Whaally.Domain/Abstractions/IProvideAggregateInstance.cs:1
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
DM12 · Ambient inputs in the domain9.7 / 10Exemplary✓ Tool-verified
Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.
Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.
`CommandEnvelope` reads `DateTime.UtcNow` inside `op_Implicit`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Command/CommandEnvelope.cs:15
`DomainContext` reads `DateTime.UtcNow` inside `EvaluateCommand`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Domain.cs:47
`IAggregateHandler` reads `DateTime.UtcNow` inside `Evaluate`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Abstractions/Aggregate/IAggregateHandler.cs:15
`SagaContext` reads `DateTime.UtcNow` inside `StageCommand`, `EvaluateService`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Saga/SagaContext.cs:34
`ServiceEnvelope` reads `DateTime.UtcNow` inside `op_Implicit`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Service/ServiceEnvelope.cs:11
`ServiceHandlerContext` reads `DateTime.UtcNow` inside `StageCommand`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Whaally.Domain/Service/ServiceHandlerContext.cs:61
What to do
Pass the instant into the domain method that needs it, or inject `TimeProvider` (BCL, .NET 8+) and read it there — then a test can choose the moment a rule is evaluated at.
Other · Event-Driven — Whether event handlers stay asynchronous (no blocking remote HTTP/gRPC calls awaited inside a handler).
Method: Roslyn semantic scan (event-driven gated): event-handler bodies scanned for HTTP/gRPC invocations by resolved symbol type, not substring. Deterministic, semantic-resolved.
Other · Event-Driven — Whether state changes and message publishes are atomic (a transactional outbox) rather than a crash-unsafe dual write.
Method: Roslyn semantic scan (event-driven gated): event-handler methods scanned for DB-save plus bus-publish without a transactional outbox reference. Deterministic, semantic-resolved.
Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.
Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it. (×5) — tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:15, tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:19, tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:23, …
What to do
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a README to the 5 of 9 project(s) that lack one — worth up to 1.1 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Only 5/9 projects share a common root namespace — the code's module identity is inconsistent.
What to do
Adopt a consistent root-namespace convention (a shared prefix, e.g. Acme.*); short project-file/directory names are fine as long as the RootNamespace is uniform.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
91/92 types (99%) are public. For a library, every public type is a stability contract — make internal-by-default and expose only the intended API.
What to do
Make types internal by default; expose only the deliberate public API so internals can change without breaking consumers.
Do you agree with this assessment?
P2 · Observability5.8 / 10Adequate✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1617 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
What to do
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it.
What to do
Add an approval/environment gate (required reviewers / protection rules) before production promotion.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
What to do
Add [MemoryDiagnoser] to the benchmarks so allocation regressions are visible, not just time.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
No Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc, ValueTask or buffer-writer usage was found. If this code sits on a hot path, these reduce the GC pressure it creates — a bonus, not a requirement.
What to do
On hot paths, prefer Span<T>/ReadOnlySpan<T>, ArrayPool<T>, stackalloc and ValueTask to cut the allocations those paths would otherwise make.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Only 0/26 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
`await Continue(events)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:139
`await Task.Run(async () => { var commands = await evaluationAgent.EvaluateSaga(@eve...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:156
`await evaluationAgent.EvaluateSaga(@event)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:158
`await evaluationAgent.EvaluateCommands(commands.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:162
`await evaluationAgent.EvaluateEvents(events.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:166
`await aggregateHandler.Evaluate(commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/AggregateHandlerExtensions.cs:12
`await aggregateHandler.Apply(evaluationResult.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/AggregateHandlerExtensions.cs:17
`await handler.Evaluate(operation.commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/DefaultEvaluationAgent.cs:58
`await handler.Apply(operation.events)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/DefaultEvaluationAgent.cs:105
`await saga.Evaluate( context, eventEnvelope.Message)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/DefaultEvaluationAgent.cs:141
`await serviceHandler.Handle<TService>( serviceHandlerContext, serviceEnvelope.Message)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/DefaultEvaluationAgent.cs:168
`await handler.Evaluate( new CommandEnvelope( command, new CommandMetadata() { Aggre...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Domain.cs:64
`await handler.Continue(result.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Domain.cs:75
`await evaluationAgent.EvaluateService( new ServiceEnvelope<TService>( service, new ...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. (×2) — src/Whaally.Domain/Domain.cs:85, src/Whaally.Domain/Service/ServiceHandlerContext.cs:43
`await evaluationAgent.EvaluateCommands(evalResult.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Domain.cs:93
`await evaluationAgent.EvaluateService( new ServiceEnvelope<IService>( service, new ...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain/Saga/SagaContext.cs:50
`await RefreshNow()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:41
`await base.OnActivateAsync(token)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:43
`await ConfirmEvents()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:65
`await AggregateHandler.Evaluate(commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:74
`await using … = _store.LightweightSession()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. (×2) — src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:29, src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:56
`await session.Events.FetchStreamAsync(this.GetPrimaryKey())` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:31
`await AggregateHandler.Apply(new EventEnvelope( (IEvent)@event.Data, new EventMetad...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:38
`await session.SaveChangesAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:62
What to do
In library code, append .ConfigureAwait(false) to every await (or set <ConfigureAwait>false</ConfigureAwait> / use the analyzer CA2007) so the library never captures the host's context.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 3/23 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×20) — src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:109, src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:149, src/Whaally.Domain/AggregateHandlerExtensions.cs:10, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
~2.0 `!` suppressions per 1k syntax nodes — 25 suppression(s) across the 12773 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 41 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — 4 query handlers detected, but none of their entry-point bodies could be walked — the query-purity oracle recognises a value-returning Execute/Handle/Consume (±Async) entry point or one that implements the classifying handler interface's member, and this codebase's handlers were classified but never read. This is an engine limitation, not a finding about the repository.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — docker build failed (exit 1) — DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
Install the buildx component to build images with BuildKit:
https://docs.docker.com/go/bui…; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D16 Bus Factor — single-contributor repository — bus factor is not applicable
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D25 ADR Conformance — no ADRs to check
D30 Dependency Vulnerabilities — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
D32 Data Compliance (PII/GDPR) — 3 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage not measured
DM1 Domain Modelling — applicable but not scored (6 signals for this style, 3 needed — the count is met but a required primary signal is absent): 2 aggregate root(s) (AggregateRoot/IAggregateRoot); 4 value object(s); 12 domain event(s); its domain events are published by services or handlers — no domain entity raises one; a Domain/Aggregates/ValueObjects layer; 14 aggregate-constrained repository/repositories (IRepository<T> where T : IAggregateRoot); 4 per-aggregate domain namespaces (…/BasketAggregate, …/OrderAggregate); a top-level samples/ tree: a library or framework whose examples are its consumers — these types are building blocks, not a domain
ED2 Event/command shape — no command-shaped messages detected — single-handler-per-command check not applicable
ES1 Event Sourcing — not scored — this repository shows only 1 of the 3 signals this lens looks for (an event-store package (Marten/EventStore))
P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
P7 Outbound HTTP resilience — no outbound HTTP usage detected — no HttpClient/IHttpClientFactory/AddHttpClient in source, and no Refit/RestSharp/Flurl.Http namespace or package reference
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
WriteOnlyPrivateField samples/Skyhop.Domain.Benchmark/EvaluateApplyOperationBenchmark.cs:20— private string _g — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField samples/Skyhop.Domain.Benchmark/SagaBenchmarkTest.cs:24— private IAggregateHandler<Aircraft>? a1H — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField samples/Skyhop.Domain.Benchmark/SagaBenchmarkTest.cs:25— private IAggregateHandler<Aircraft>? a2H — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Namespace dependency cycle src/Whaally.Domain/Abstractions/IProvideAggregateInstance.cs:1— The namespaces Whaally.Domain.Abstractions ↔ Whaally.Domain.Abstractions.Aggregate ↔ Whaally.Domain.Abstractions.Command ↔ Whaally.Domain.Abstractions.Event ↔ Whaally.Domain.Abstractions.Service depend on each other. The lightest dependency in the cycle is Whaally.Domain.Abstractions → Whaally.Domain.Abstractions.Aggregate (Whaally.Domain.Abstractions.IProvideAggregateInstance → Whaally.Domain.Abstractions.Aggregate.IAggregate, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
NoWarnInCsproj src/Whaally.Domain.Infrastructure.OrleansHost/Whaally.Domain.Infrastructure.OrleansHost.csproj:23— CS0618 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
Dead code: CorrectTotalFlightCountHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Commands/CorrectTotalFlightCount.cs:12— NamedType CorrectTotalFlightCountHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: CorrectTotalFlightTimeHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Commands/CorrectTotalFlightTime.cs:12— NamedType CorrectTotalFlightTimeHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RemoveFlightHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Commands/RemoveFlight.cs:11— NamedType RemoveFlightHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SetFlightInfoHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Commands/SetFlightInfo.cs:14— NamedType SetFlightInfoHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: FlightInfoSetHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Events/FlightInfoSet.cs:13— NamedType FlightInfoSetHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: FlightRemovedHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Events/FlightRemoved.cs:9— NamedType FlightRemovedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: TotalFlightCountCorrectedHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Events/TotalFlightCountCorrected.cs:11— NamedType TotalFlightCountCorrectedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: TotalFlightTimeCorrectedHandler samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Events/TotalFlightTimeCorrected.cs:11— NamedType TotalFlightTimeCorrectedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AircraftSnapshotFactory samples/Skyhop.Domain/AircraftContext/Aggregates/AircraftAggregate/Snapshots/AircraftSnapshot.cs:9— NamedType AircraftSnapshotFactory — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: OnAircraftChanged samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftChanged.cs:12— NamedType OnAircraftChanged — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: OnAircraftRemoved samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftRemoved.cs:12— NamedType OnAircraftRemoved — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: OnArrival samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs:10— NamedType OnArrival — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ImportHandler samples/Skyhop.Domain/AircraftContext/Services/Import.cs:8— NamedType ImportHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: CreateHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/Create.cs:11— NamedType CreateHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RemoveAircraftHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/RemoveAircraft.cs:11— NamedType RemoveAircraftHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SetAircraftHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetAircraft.cs:11— NamedType SetAircraftHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SetArrivalHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetArrival.cs:13— NamedType SetArrivalHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SetDepartureHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetDeparture.cs:13— NamedType SetDepartureHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AircraftRemovedHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/AircraftRemoved.cs:9— NamedType AircraftRemovedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AircraftSetHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/AircraftSet.cs:9— NamedType AircraftSetHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ArrivalAirfieldSetHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/ArrivalAirfieldSet.cs:9— NamedType ArrivalAirfieldSetHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ArrivalTimeSetHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/ArrivalTimeSet.cs:9— NamedType ArrivalTimeSetHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: CreatedHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/Created.cs:9— NamedType CreatedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DepartureAirfieldChangedHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/DepartureAirfieldChanged.cs:11— NamedType DepartureAirfieldChangedHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DepartureAirfieldSetHandler samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Events/DepartureAirfieldSet.cs:9— NamedType DepartureAirfieldSetHandler — Roslyn's SymbolFinder walked every project the solution loads, including Skyhop.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Awaits without ConfigureAwait(false) — Only 0/26 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:139— `await Continue(events)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:156— `await Task.Run(async () => { var commands = await evaluationAgent.EvaluateSaga(@eve...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:158— `await evaluationAgent.EvaluateSaga(@event)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:162— `await evaluationAgent.EvaluateCommands(commands.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:166— `await evaluationAgent.EvaluateEvents(events.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/AggregateHandlerExtensions.cs:12— `await aggregateHandler.Evaluate(commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/AggregateHandlerExtensions.cs:17— `await aggregateHandler.Apply(evaluationResult.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/DefaultEvaluationAgent.cs:58— `await handler.Evaluate(operation.commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/DefaultEvaluationAgent.cs:105— `await handler.Apply(operation.events)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/DefaultEvaluationAgent.cs:141— `await saga.Evaluate( context, eventEnvelope.Message)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/DefaultEvaluationAgent.cs:168— `await serviceHandler.Handle<TService>( serviceHandlerContext, serviceEnvelope.Message)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Domain.cs:64— `await handler.Evaluate( new CommandEnvelope( command, new CommandMetadata() { Aggre...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Domain.cs:75— `await handler.Continue(result.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Domain.cs:85— `await evaluationAgent.EvaluateService( new ServiceEnvelope<TService>( service, new ...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Domain.cs:93— `await evaluationAgent.EvaluateCommands(evalResult.Value)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Saga/SagaContext.cs:50— `await evaluationAgent.EvaluateService( new ServiceEnvelope<IService>( service, new ...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain/Service/ServiceHandlerContext.cs:43— `await evaluationAgent.EvaluateService( new ServiceEnvelope<TService>( service, new ...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:41— `await RefreshNow()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:43— `await base.OnActivateAsync(token)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:65— `await ConfirmEvents()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:74— `await AggregateHandler.Evaluate(commands)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:29— `await using … = _store.LightweightSession()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:31— `await session.Events.FetchStreamAsync(this.GetPrimaryKey())` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:38— `await AggregateHandler.Apply(new EventEnvelope( (IEvent)@event.Data, new EventMetad...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
+ 2 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×20
Async method without CancellationToken: Apply src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:109— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Continue src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:149— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateAndApply src/Whaally.Domain/AggregateHandlerExtensions.cs:10— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateCommands src/Whaally.Domain/DefaultEvaluationAgent.cs:28— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateEvents src/Whaally.Domain/DefaultEvaluationAgent.cs:75— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateSaga src/Whaally.Domain/DefaultEvaluationAgent.cs:113— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateService src/Whaally.Domain/DefaultEvaluationAgent.cs:162— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateCommand src/Whaally.Domain/Domain.cs:47— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateService src/Whaally.Domain/Domain.cs:80— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateService src/Whaally.Domain/Saga/SagaContext.cs:46— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateService src/Whaally.Domain/Service/ServiceHandlerContext.cs:38— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Evaluate src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:72— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Evaluate samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftChanged.cs:14— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Evaluate samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftRemoved.cs:14— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Evaluate samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs:12— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Evaluate samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs:12— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Run samples/Skyhop.Domain.Benchmark/EvaluateApplyOperationBenchmark.cs:43— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadStateFromStorage src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:27— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ApplyUpdatesToStorage src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:51— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: EvaluateAndApply samples/Skyhop.Hosting/DomainHelpers.cs:9— No CancellationToken parameter — this work can't be stopped early once started.
TodoComment samples/Skyhop.Domain.Benchmark/EvaluateApplyOperationBenchmark.cs:35— // ToDo: Ensure the aggregate is never null upon initialization! — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:53— // ToDo: Add version check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain.Infrastructure.OrleansHost.MartenPersistence/AggregateHandlerGrain.cs:54— // ToDo: Add tracing information to each event individually — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Abstractions/Event/IEventHandler.cs:17— // ToDo: Deal with the situation where @event.Message is IEvent and cannot be casted to TEvent. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Abstractions/IMessageMetadata.cs:14— // ToDo: consider adding authorization information as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:26— // ToDo: Use an options pattern to supply mandatory/optional parameters — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:40— // ToDo: Check whether the commands have in fact been intended for the present aggregate — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:44— // ToDo: Extract the command handler instantiation to some other component — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:155— // ToDo: Ensure these sagas are properly evaluated in the background — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Command/CommandHandlerContext.cs:46— // ToDo: Assert the aggregate types of the command and this context do match. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Domain.cs:52— // ToDo: Refactor this to use some internal resolver rather than the global DI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Whaally.Domain/Saga/SagaContext.cs:30— // ToDo: I do not know about situations in which no aggregateId would be provided, — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tests/Skyhop.Domain.Tests/AircraftContext/Sagas/OnAircraftChanged_Saga_Tests.cs:26— // ToDo: Assert change on a1H but not on a2H — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tests/Skyhop.Domain.Tests/FlightContext/Commands/Create_Command_Tests.cs:26— // ToDo: We'll need an `EvaluateAndApply` method to do stuff like this? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tests/Whaally.Domain.Tests/Scenarios/_0002__command_composition/CommandHandlerContextTests.cs:23— // ToDo: Build a different and more elegant mechanism to keep track of handler implementations etc. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
DM12 · Ambient inputs in the domain· Domain type reads the wall clock · ×6
Domain type reads the wall clock: CommandEnvelope src/Whaally.Domain/Command/CommandEnvelope.cs:15— `CommandEnvelope` reads `DateTime.UtcNow` inside `op_Implicit`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: DomainContext src/Whaally.Domain/Domain.cs:47— `DomainContext` reads `DateTime.UtcNow` inside `EvaluateCommand`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: IAggregateHandler src/Whaally.Domain/Abstractions/Aggregate/IAggregateHandler.cs:15— `IAggregateHandler` reads `DateTime.UtcNow` inside `Evaluate`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: SagaContext src/Whaally.Domain/Saga/SagaContext.cs:34— `SagaContext` reads `DateTime.UtcNow` inside `StageCommand`, `EvaluateService`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: ServiceEnvelope src/Whaally.Domain/Service/ServiceEnvelope.cs:11— `ServiceEnvelope` reads `DateTime.UtcNow` inside `op_Implicit`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: ServiceHandlerContext src/Whaally.Domain/Service/ServiceHandlerContext.cs:61— `ServiceHandlerContext` reads `DateTime.UtcNow` inside `StageCommand`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Cross-context type AircraftRemoved (FlightContext → AircraftContext) samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftRemoved.cs:14— AircraftRemoved (context FlightContext) is exposed in AircraftContext's public surface via OnAircraftRemoved.Evaluate — couples the contexts.
Cross-context type AircraftRemoved (FlightContext → AircraftContext) samples/Skyhop.Domain/AircraftContext/Sagas/OnAircraftRemoved.cs:12— AircraftRemoved (context FlightContext) is exposed in AircraftContext's public surface via OnAircraftRemoved.ISaga — couples the contexts.
Cross-context type DepartureTimeSet (FlightContext → AircraftContext) samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs:12— DepartureTimeSet (context FlightContext) is exposed in AircraftContext's public surface via OnDeparture.Evaluate — couples the contexts.
Cross-context type DepartureTimeSet (FlightContext → AircraftContext) samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs:10— DepartureTimeSet (context FlightContext) is exposed in AircraftContext's public surface via OnDeparture.ISaga — couples the contexts.
Stateful singleton: DefaultAggregateHandlerFactory src/Whaally.Domain/Aggregate/DefaultAggregateHandlerFactory.cs:5— `DefaultAggregateHandlerFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_dictionary; e.g. `_dictionary` at line 28).
No assertions: CanInvokeCommand tests/Whaally.Domain.Tests/Scenarios/_0002__command_composition/CommandHandlerContextTests.cs:33— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
Deprecated: xunit tests/Directory.Build.targets:28— xunit 2.9.2 — Legacy — the publisher's replacement is `xunit.v3`; that is the next major line under a new package id, so the move is a breaking rename rather than a version bump — budget for API changes in the code that uses it, not only the reference swap.
Cross-context type SetAircraft (FlightContext → samples) samples/Skyhop.Hosting/Controllers/FlightController.cs:30— SetAircraft (context FlightContext) is exposed in samples's public surface via FlightController.SetAircraft — couples the contexts.
Cross-context type SetDeparture (FlightContext → samples) samples/Skyhop.Hosting/Controllers/FlightController.cs:35— SetDeparture (context FlightContext) is exposed in samples's public surface via FlightController.SetDeparture — couples the contexts.
Cross-context type SetArrival (FlightContext → samples) samples/Skyhop.Hosting/Controllers/FlightController.cs:40— SetArrival (context FlightContext) is exposed in samples's public surface via FlightController.SetArrival — couples the contexts.
Duplicated block (17–18 lines × 2) src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:79— src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:79-95 | src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:117-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Whaally.Domain/DefaultEvaluationAgent.cs:32— src/Whaally.Domain/DefaultEvaluationAgent.cs:32-42 | src/Whaally.Domain/DefaultEvaluationAgent.cs:79-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Whaally.Domain/DefaultEvaluationAgent.cs:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs:14— samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs:14-28 | samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs:14-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetArrival.cs:17— samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetArrival.cs:17-26 | samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetDeparture.cs:17-26 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `command` to `SetArrival` in one and `SetDeparture` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
End-of-life runtime: .NET net6.0 src/Whaally.Domain/Whaally.Domain.csproj:4— src/Whaally.Domain/Whaally.Domain.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
SC1 · Supply-chain hygiene· NuGet dependencies are not locked · ×1
NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
Orphaned file src/Whaally.Domain/ServiceCollectionExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/DefaultEvaluationAgent.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/ServiceProviderExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/Domain.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/Service/ServiceHandlerContext.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain.Infrastructure.OrleansHost/ProtocolServices.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/Abstractions/IEvaluationAgent.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Whaally.Domain/Command/CommandHandlerContext.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Disabled test tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:15— A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
Disabled test tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:19— A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
Disabled test tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:23— A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
Disabled test tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:27— A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
Disabled test tests/Whaally.Domain.Tests/Scenarios/_0001__orleans_serialization/Tests/SerializationTests.cs:31— A test is skipped ("_") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
Duplicated predicate samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs:18— `!string.IsNullOrWhiteSpace(snapshot.AircraftId) && snapshot.AircraftId != null` appears character-identically in 2 files — samples/Skyhop.Domain/AircraftContext/Sagas/OnArrival.cs, samples/Skyhop.Domain/AircraftContext/Sagas/OnDeparture.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetArrival.cs:25— `command.Time == DateTime.MinValue || command.Time == DateTime.MaxValue` appears character-identically in 2 files — samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetArrival.cs, samples/Skyhop.Domain/FlightContext/Aggregates/FlightAggregate/Commands/SetDeparture.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 10 of 10 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 10 of the 67 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: src/Whaally.Domain/ServiceCollectionExtensions.cs, src/Whaally.Domain/DefaultEvaluationAgent.cs, src/Whaally.Domain/Aggregate/DefaultAggregateHandler.cs, src/Whaally.Domain.Infrastructure.OrleansHost/Grains/AbstractAggregateHandlerGrain.cs, src/Whaally.Domain/ServiceProviderExtensions.cs, src/Whaally.Domain/Domain.cs, src/Whaally.Domain/Service/ServiceHandlerContext.cs, src/Whaally.Domain.Infrastructure.OrleansHost/ProtocolServices.cs (and 2 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
Inconsistent root namespaces — Only 5/9 projects share a common root namespace — the code's module identity is inconsistent.
P10 · Library API & versioning· Large public API surface · ×1
Large public API surface — 91/92 types (99%) are public. For a library, every public type is a stability contract — make internal-by-default and expose only the intended API.
No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1617 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No release approval gate — Deployment is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever reaches the release trigger goes to production unreviewed, so a mistaken merge or tag is live before anyone can stop it.
Benchmarks don't track allocations — A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
PF2 · Allocation hygiene· No allocation-aware APIs detected · ×1
No allocation-aware APIs detected — No Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc, ValueTask or buffer-writer usage was found. If this code sits on a hot path, these reduce the GC pressure it creates — a bonus, not a requirement.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 3/23 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~2.0 `!` suppressions per 1k syntax nodes — 25 suppression(s) across the 12773 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Whaally: 3 contract type(s) expose producer-owned ids/enums — In Whaally, 3 contract type(s) (EventEnvelope, EventMetadata, IEventEnvelope) expose strong-typed ids/value objects (IEventMetadata); a serialized contract could expose the underlying primitive instead. Advisory — a deliberate strong-ID style is fine.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 3 file(s) — `src/Whaally.Domain.Infrastructure.OrleansHost/OrleansAggregateHandlerFactory.cs`, `src/Whaally.Domain/Command/CommandHandlerContext.cs`, `src/Whaally.Domain/Service/ServiceHandlerContext.cs` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
0
—
Run 01a160eb-f4c4-7d74-844b-9f8c930cef28 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 11 · Warnings: 127 · Recommendations: 35 · Info: 28 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 22-10-2026 @ 00:03 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.