Public report — jivejdon, published 4 Aug 2026.
Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version;
ask the repo owner for the full report.
303findings with an exact file:lineof 311 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
33/112dimensions across the health lenses45403 LoC — wide & deep
Executive summary
Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.
banq/jivejdon carries serious gaps (35%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.
It is strongest in Domain Modelling (100%) — the domain model is expressive and well-guarded. Architecture (100%) is solid too.
The area that most needs attention is Readiness (21%) — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade. Code Health (24%) is the next concern — changes there are slower and more error-prone.
Leadership focus, highest impact first: CI workflow that builds and runs the test suite on every push/PR (CI/CD gates); Run what this repository's stack ships (Security & performance tooling); tests that import the unreached modules (directly or through… (Test Coverage).
For scale: Medium (~45,403 production lines); rebuilding it from scratch would take roughly ~0.4 person-years (~1 engineer). Approximate, ±~30%.
It builds on a genuinely strong Domain Modelling foundation (100%); the priorities above are the highest-leverage way to bring the rest up to that level.
How the score is built — each lens's share of the headlineWidth is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
240 finding(s) are new versus the previous scan (2026-07-29) — surfaced by this scheduled scan itself, no pull request required. Showing the first 100; the full set is in the report.
A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.
0.7× (at 35% quality) — the last 20% of quality is most of the work
Size & shape
Medium · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)
Dead frontend code
~17902 LoC unreachable (99 file(s)) — that slice of this estimate buys code with zero runtime value; deleting it is the cheapest win in this report (the R7 card lists every file)
This codebase represents roughly ~0.4 person-years of build effort (about ~€52,000 to rebuild). Its weakest lens is Readiness at 21% — the part of that asset most exposed by the findings below.
How we model this: boilerplate at a scaffolding rate + logic × domain High (×1.4) — DDD/clean architecture, domain model × a 0.7× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).
Top priorities
The highest-leverage moves; the full ranked list is in the Roadmap below.
1
Add a CI workflow that builds and runs the test suite on every push/PR.
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Value concentrated against a weak lens · High · Value at risk
This is a Medium asset (~0.4 person-years to rebuild), and its weakest lens is Readiness at 21%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
→ Direct remediation budget at Readiness first — highest risk-reduction per euro on an asset this size.
The top fix pays for itself · High · Economics
The top-ranked fix costs roughly 3–10 engineer-days once. Not doing it costs about 1.6–9.7 engineer-days every year, paid as drag on the ~16,599 lines this team changes annually — a bill that arrives whether or not anyone books it. On those figures the fix breaks even in roughly 4–75 months and is free after that. Method, stated so this is not read as a quotation: debt from the ranked task's effort band; interest = annual changed lines (measured, annualised from the 90-day window) ÷ an ASSUMED 150–400 lines per engineer-day × the 4–9% drag implied by the code-quality signals; breaking point = debt ÷ annual interest. A modelled planning range built from measured inputs and one named assumption — not a quotation, a valuation, or a certified figure.
Evidence: D15 churn: 4,093 line(s) changed over a 90-day window ⇒ ~16,599/year · D1/D2/D4 code quality: averaging 6.4/10 ⇒ a 4–9% drag on each change · top-ranked remediation: Medium effort ⇒ about 3–10 engineer-day(s)
→ Do the top-ranked fix now if this code will still be yours in 75 months.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Add a CI workflow that builds and runs the test suite on every push/PR. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Add a CI workflow that builds and runs the test suite on every push/PR.
A velocity tax on every change · Medium · Economics
The code-quality signals (complexity, duplication, cohesion) average 6.4/10, which acts as a tax on every change in the weaker areas: modifications there plausibly cost on the order of 4–9% more than in clean code, and the tax compounds as the codebase grows. (A modelled estimate, not a measured fact.)
Evidence: D1/D2/D4 code quality: averaging 6.4/10 across the code-quality signals actually measured
→ Pay it down where churn is highest — the hotspots — not everywhere; that's where the tax is actually paid.
Architecture — module dependency matrix
115 modules, 441 dependencies — 3 dependency cycles, shown as the red cell(s) above the diagonal. Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)
At a glance — Code Health · 24% · Critical · gated by R1, R2, R7
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2021 — Injection
20
High / Critical
A05:2021 — Security Misconfiguration
11
High / Critical
A04:2021 — Insecure Design
5
High / Critical
A02:2021 — Cryptographic Failures
2
High / Critical
Roadmap
First, establish a continuous integration pipeline that builds the code and runs the test suite on every change. Next, integrate security scanning into that same pipeline to ensure security regressions fail the build. Then, increase test coverage by adding tests for all currently unreached modules. After that, adopt TypeScript for the frontend by adding a typecheck step and progressively typing the existing JavaScript files. Finally, reduce cyclomatic complexity in high-traffic functions to improve maintainability.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Add a CI workflow that builds and runs the test suite on every push/PR.
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 32 of 33 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 1 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.5 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 33 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 303 of 311 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D19 Documentation Quality — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.
D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D32 Data Compliance (PII/GDPR): PII/GDPR signals are heuristic pattern matches in code — they flag likely handling concerns, not legal compliance, and cannot trace where data actually flows at runtime.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (2): D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
+ 51 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 initialize (cyclomatic 29) finding(s) in Cyclomatic Complexity — start with window_def.js, window.js. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 (anonymous) (cyclomatic 24) finding(s) in Cyclomatic Complexity — start with jquery-ui.js (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 setSize (cyclomatic 17) finding(s) in Cyclomatic Complexity — start with window_def.js, window.js. — One of this dimension's main actionable groups (2 warning-level).
Stand up a CI pipeline, then gate Cyclomatic Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 81 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 initialize (cognitive 36) finding(s) in Cognitive Complexity — start with window_def.js, window.js. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 FiltersUtils.getPropertyHTML (cognitive 26) finding(s) in Cognitive Complexity — start with FiltersUtils.java (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 _saveCookie (cognitive 19) finding(s) in Cognitive Complexity — start with window_def.js, window.js. — One of this dimension's main actionable groups (2 warning-level).
Stand up a CI pipeline, then gate Cognitive Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.1 / 10Exemplary✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
+ 18 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 16 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with SubscriptionDaoSql.java (2), OAuthAccountServiceImp.java, JavaCodeHighlighter.java. — One of this dimension's main actionable groups (16 warning-level).
Resolve the 15 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with TagDaoSql.java (4), AccountSSOSql.java (2), MessageQueryDaoSql.java (2). — One of this dimension's main actionable groups (15 warning-level).
Resolve the 14 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with MessageQueryDaoSql.java (3), AccountDaoSql.java (2), MessageDaoSql.java (2). — One of this dimension's main actionable groups (14 warning-level).
Stand up a CI pipeline, then gate Code Duplication in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor8.9 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
72 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java.
Small-team knowledge concentration
What to do
Resolve the 1 Small-team knowledge concentration finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.
7 finding(s): 0 critical, 7 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
Secret: generic-api-keysrc/main/java/com/jdon/jivejdon/presentation/action/account/SmsQQAction.java:49detected by gitleaks finding
Rotate the exposed credentials — git history can't be un-committed
What to do
Resolve the 1 Secret finding(s) in Secrets (history) — start with SmsQQAction.java. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
High: object-deserializationsrc/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UserconnectorSql.java:127detected by semgrep finding
Medium: use-of-md5 · ×13src/main/java/com/jdon/jivejdon/auth/jaas/DigestUtil.java:34detected by semgrep finding
Low: insecure-trust-manager · ×6src/main/java/com/jdon/jivejdon/spi/component/pingrpc/BlogPingSender.java:103detected by semgrep finding
What to do
Resolve the 13 Medium finding(s) in Static Analysis (SAST) — start with FiltersAction.java (3), AccountProfileAction.java (2), DigestUtil.java. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 1 High finding(s) in Static Analysis (SAST) — start with UserconnectorSql.java. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 6 Low finding(s) in Static Analysis (SAST) — start with BlogPingSender.java (3), ToolsUtil.java (2), HttpClientUtil.java. — One of this dimension's main actionable groups (6 recommendation-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
High IaC: DS-0002Dockerfile.webdetected by trivy finding
Medium IaC: CKV_DOCKER_4 · ×8Dockerfile.web:5detected by trivy finding
Low IaC: DS-0005 · ×2Dockerfile.webdetected by trivy finding
What to do
Resolve the 1 High IaC finding(s) in IaC & Container Security — start with Dockerfile.web. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 8 Medium IaC finding(s) in IaC & Container Security — start with Dockerfile.web (8). — One of this dimension's main actionable groups (8 warning-level).
Resolve the 2 Low IaC finding(s) in IaC & Container Security — start with Dockerfile.web (2). — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D32 · Data Compliance (PII/GDPR)2.9 / 10Weak✓ Tool-verified
What it measures: Likely personal-data (PII / GDPR) handling concerns — logging or storing data without safeguards.
Method: Heuristic PII/GDPR pattern scan via semgrep across the repo, using Watchdog's own ruleset (personal data reaching log/console sinks, URLs and query strings, or unprotected browser storage); matches map to severity and a 0-10 wide normalizer. NotApplicable when the scan runs and detects no PII/GDPR surface (no unearned 10); reported LOUDLY as a measurement gap, never as not-applicable, if the ruleset is missing from the analyzer image. Exhaustive, advisory-leaning; degrades on parse failure.
High: watchdog-sensitive-personal-data-in-log · ×3src/main/java/com/jdon/jivejdon/domain/model/message/output/RenderingFilterManagerImp.java:177detected by semgrep finding
Medium: watchdog-personal-data-in-log · ×2src/main/java/com/jdon/jivejdon/presentation/action/account/SmsQQAction.java:43detected by semgrep finding
What to do
Resolve the 3 High finding(s) in Data Compliance (PII/GDPR) — start with FiltersAction.java (2), RenderingFilterManagerImp.java. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 Medium finding(s) in Data Compliance (PII/GDPR) — start with SmsQQAction.java (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d32_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Domain Modelling — Whether entities protect their state (private/init-only setters) instead of exposing public setters that bypass invariants. Softened when a rehydration framework (Marten/EF) is present.
Method: Roslyn (DDD-gated): public setters on entities detected; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.
Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.
Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a 'Testing' section to the root README — how to run the test suite.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Tests aren't grouped in a dedicated test folder — the test surface isn't separable from production code at a glance.
What to do
Group tests in the folder your build system expects (tests/, test/, spec/, or your module's test source set) so the test surface is discoverable and CI can scope it.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Do you agree with this assessment?
P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
What to do
Add a CI workflow that builds and runs the test suite on every push/PR.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build.
What to do
Run what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
What to do
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
Do you agree with this assessment?
P6 · Release Hygiene8.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
A changelog exists but has few versioned entries — keep it current with each release.
What to do
Keep the changelog current — add a versioned entry (Keep-a-Changelog ## [x.y.z]) for each release so the history isn't a stub.
Do you agree with this assessment?
R1 · Type Safety0.0 / 10Critical✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
0 typed · 101 plain JS — the untyped files are application/admin/js/admin.js, application/common/autocomplete/jquery-ui.js, application/common/ckeditor/build-config.js, application/common/ckeditor/config.js, application/common/ckeditor/lang/vi.js, application/common/ckeditor/plugins/autogrow/plugin.js (+95 more).
What to do
Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
React / JS · Code Health — Copy-pasted token-identical blocks across the frontend (the D4 clone algorithm over JS/TS tokens, D-386).
Method: Copy-pasted token-identical blocks across the frontend (the D4 clone algorithm run over JS/TS tokens). Deterministic.
application/common/js/calendar-zh.js:2 · application/common/js/calendar.js:7 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — calendar-zh.js:2
application/common/form.js:75 · application/forum/js/form.js:178 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — form.js:75
application/common/js/window.js:34 · application/common/js/window_def.js:35 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same names written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents. — window.js:34
application/common/autocomplete/jquery-ui.js:9503 · application/common/autocomplete/jquery-ui.js:9528 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — jquery-ui.js:9503
application/common/autocomplete/jquery-ui.js:1096 · application/common/autocomplete/jquery-ui.js:3734 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — jquery-ui.js:1096
application/common/autocomplete/jquery-ui.js:1243 · application/common/autocomplete/jquery-ui.js:2372 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — jquery-ui.js:1243
application/common/autocomplete/jquery-ui.js:5300 · application/common/autocomplete/jquery-ui.js:5312 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — jquery-ui.js:5300
application/common/js/calendar-setup.js:8 · application/common/js/calendar.js:62 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — calendar-setup.js:8
What to do
Extract the duplicated blocks into shared functions/components.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
Branch-heavy code is where defects cluster — extract decisions into smaller functions. (×8) — jquery-ui.js:8313, jquery-ui.js:7392, jquery-ui.js:1485, …
What to do
Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
Do you agree with this assessment?
R3 · Large Files8.0 / 10Strong✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
What to do
Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
Do you agree with this assessment?
R4 · Test Coverage0.0 / 10Critical✓ Tool-verified
React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.
Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.
0% of 101 production file(s) reachable from 0 test file(s) via the import graph
What to do
Add tests that import the unreached modules (directly or through their public entry).
Do you agree with this assessment?
R7 · Dead Code0.0 / 10Critical✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
Unreachable from the 2 application, 0 tooling and 0 test entry point(s) detected in this repo. Gate removals on your build/type-check — an undetected custom entry would make these reachable.
no import path from any entry point (2 application, 0 tooling, 0 test roots considered) (×7) — jquery-ui.js, window_def.js, window.js, …
What to do
Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Not included — 79 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC2 Forms & labels — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC3 Page structure — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC4 Keyboard semantics — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC5 ARIA correctness — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC6 Visual & motion safety — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AC7 A11y enforcement — Frontend below the scale floor (16 DOM element(s) < 25) — too little surface to assess accessibility.
AX1 Captive dependencies — no DI registrations detected
AX10 Code composition — not assessed — code composition is computed by ROLE over a document set that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX2 Stateful singletons — no singleton implementations detected
AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D10 Test Quality — ~265 lines of test source are present (.java) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included
D12 Dependency Hygiene — Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (a Maven POM), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D19 Documentation Quality — LLM evaluation failed
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — No exposed public API
D23 Boundary Type-Coupling — Production source is present (.java) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — No inline comments to assess — comment value is not applicable here.
D25 ADR Conformance — no ADRs to check
D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Maven POM — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, Jenkinsfile, .circleci); there is no build to attest provenance for.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D38 OSV Dependency Vulnerabilities — Scanner failed to run — not a clean result
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .java, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
D9 Test Distribution — Test source is present (.java) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
GD1 Unfinished & placeholder code — no source files
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — no CI workflow found
P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D33 (JS/npm Dependency Vulnerabilities)
R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
R8 Dependency Hygiene — Not measured — no package.json declares any dependency, so there is nothing to check imports against (imports may resolve through a host runtime rather than node).
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
High: watchdog-sensitive-personal-data-in-log src/main/java/com/jdon/jivejdon/domain/model/message/output/RenderingFilterManagerImp.java:177— Special-category or directly-identifying personal data appears to be written to a log or console sink. Logs are copied, shipped to third parties and retained far longer than the data itself is lawfully needed. Log a stable pseudonymous reference instead of the value.
High: watchdog-sensitive-personal-data-in-log src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:238— Special-category or directly-identifying personal data appears to be written to a log or console sink. Logs are copied, shipped to third parties and retained far longer than the data itself is lawfully needed. Log a stable pseudonymous reference instead of the value.
High: watchdog-sensitive-personal-data-in-log src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:262— Special-category or directly-identifying personal data appears to be written to a log or console sink. Logs are copied, shipped to third parties and retained far longer than the data itself is lawfully needed. Log a stable pseudonymous reference instead of the value.
High: object-deserialization src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UserconnectorSql.java:127— Found object deserialization using ObjectInputStream. Deserializing entire Java objects is dangerous because malicious actors can create Java object streams with unintended consequences. Ensure that the objects being deserialized are not user-controlled. If this must be done, consider using HMACs to sign the data stream to make sure it is not tampered with, or consider only transmitting object fields and populating a new object. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
High IaC: DS-0002 Dockerfile.web— Image user should not be 'root' A container that starts as root runs your process with root's capabilities inside the namespace, so a compromise of the process starts from there. The step: create an unprivileged account in the image (`RUN useradd -r -M app` — or whatever this base image's account tooling is, `adduser` and `useradd` are not both present everywhere`), give it ownership of the paths the process writes at runtime (`COPY --chown=` on those layers, or a `RUN chown -R`), and end the final stage with `USER app` so it is the default at start. Build stages that only compile can stay root; it is the stage that RUNS that needs the account. If the process genuinely requires root — it manages the container runtime, ptraces another process or opens raw devices — say so here rather than making a change that breaks it.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:100— src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:100-109 | src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:229-238 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:703— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:703-713 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:728-737 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:703` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:656— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:656-665 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:671-680 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:656` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:190— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:190-199 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:254-266 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:190` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:125— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:125-134 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:221-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:149— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:149-158 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:189-198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:149` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/search/MessageSearchProxy.java:82— src/main/java/com/jdon/jivejdon/infrastructure/repository/search/MessageSearchProxy.java:82-91 | src/main/java/com/jdon/jivejdon/infrastructure/repository/search/MessageSearchProxy.java:116-125 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/search/MessageSearchProxy.java:82` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:125— src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:125-134 | src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:174-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/blog/FollowerListAction.java:37— src/main/java/com/jdon/jivejdon/presentation/action/blog/FollowerListAction.java:37-46 | src/main/java/com/jdon/jivejdon/presentation/action/blog/FollowingListAction.java:37-46 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigListAction.java:92— src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigListAction.java:92-102 | src/main/java/com/jdon/jivejdon/spi/component/mapreduce/ThreadDigComparator.java:24-33 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigListAction.java:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/MessageListNav2Action.java:35— src/main/java/com/jdon/jivejdon/presentation/action/MessageListNav2Action.java:35-44 | src/main/java/com/jdon/jivejdon/presentation/action/MessageListNavAction.java:34-43 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/MessageListNav2Action.java:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/form/AccountFaceFileForm.java:139— src/main/java/com/jdon/jivejdon/presentation/form/AccountFaceFileForm.java:139-148 | src/main/java/com/jdon/jivejdon/presentation/form/UpLoadFileForm.java:145-154 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/form/AccountFaceFileForm.java:139` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/servlet/RegisterCodeAction.java:122— src/main/java/com/jdon/jivejdon/presentation/servlet/RegisterCodeAction.java:122-132 | src/main/java/com/jdon/jivejdon/presentation/servlet/VerifySpammerAction.java:35-44 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/servlet/RegisterCodeAction.java:122` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:89— src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:89-99 | src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:113-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/spi/pubsub/subscriber/postThread/ThreadPostListener.java:76— src/main/java/com/jdon/jivejdon/spi/pubsub/subscriber/postThread/ThreadPostListener.java:76-91 | src/main/java/com/jdon/jivejdon/spi/pubsub/subscriber/MessageMovingListener.java:83-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/pubsub/subscriber/postThread/ThreadPostListener.java:76` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/com/jdon/jivejdon/util/ContainerUtil.java:101— src/main/java/com/jdon/jivejdon/util/ContainerUtil.java:101-110 | src/main/java/com/jdon/jivejdon/util/ContainerUtil.java:127-136 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/upload/UploadInfoVOServiceImp.java:52— src/main/java/com/jdon/jivejdon/api/impl/upload/UploadInfoVOServiceImp.java:52-59 | src/main/java/com/jdon/jivejdon/spi/component/query/SlideImageQueryManager.java:84-91 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:62— src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:62-69 | src/main/java/com/jdon/jivejdon/util/FiltersUtils.java:76-83 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:71— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:71-79 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:173-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:120— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountSSOSql.java:120-127 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/util/OldUpdateNewUtil.java:133-140 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:223— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:223-230 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:427-435 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:473— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:473-480 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:513-520 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:484— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:484-491 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:525-532 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:484` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:176— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:176-183 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UserconnectorSql.java:144-152 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:176` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:199— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:199-206 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:221-228 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:199` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:313— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:313-320 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:354-361 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:313` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:355— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:355-362 | src/main/java/com/jdon/jivejdon/infrastructure/repository/search/ReBuildIndex.java:116-123 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:355` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigSortedListAction.java:68— src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigSortedListAction.java:68-75 | src/main/java/com/jdon/jivejdon/presentation/action/MaxThreadListAction.java:66-73 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigSortedListAction.java:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:110— src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:110-117 | src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:125-132 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:222— src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:222-229 | src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:287-294 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:222` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/main/java/com/jdon/jivejdon/util/XMLProperties.java:81— src/main/java/com/jdon/jivejdon/util/XMLProperties.java:81-88 | src/main/java/com/jdon/jivejdon/util/XMLProperties.java:94-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/util/XMLProperties.java:81` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:174— src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:174-182 | src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:198-206 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:174` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/emotion/Emoticon.java:390— src/main/java/com/jdon/jivejdon/domain/model/message/output/emotion/Emoticon.java:390-398 | src/main/java/com/jdon/jivejdon/domain/model/message/output/emotion/Emoticon.java:400-408 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:188— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:188-196 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:115-123 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:259— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:259-269 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:150-158 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/JdbcTempSSOSource.java:43— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/JdbcTempSSOSource.java:43-52 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/JdbcTempSource.java:40-48 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/JdbcTempSSOSource.java:43` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:366— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:366-374 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:385-393 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:366` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:463— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:463-472 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:476-484 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:463` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:257— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:257-265 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:453-461 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:257` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:269— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:269-277 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageUtilSQL.java:39-47 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:269` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:621— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:621-629 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:642-650 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:621` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SetupDaoSql.java:49— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SetupDaoSql.java:49-58 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UserconnectorSql.java:151-159 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SetupDaoSql.java:49` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:168— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:168-176 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:210-218 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:168` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/SearchAction.java:25— src/main/java/com/jdon/jivejdon/presentation/action/query/SearchAction.java:25-33 | src/main/java/com/jdon/jivejdon/presentation/action/query/SearchThreadAction.java:55-64 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/query/SearchAction.java:25` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigSortedListAction.java:37— src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadDigSortedListAction.java:37-46 | src/main/java/com/jdon/jivejdon/presentation/action/MaxThreadListAction.java:32-40 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Medium: use-of-md5 src/main/java/com/jdon/jivejdon/auth/jaas/DigestUtil.java:34— Detected MD5 hash algorithm which is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature. Use HMAC instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Medium: no-direct-response-writer src/main/java/com/jdon/jivejdon/presentation/action/MessageDigAction.java:59— Detected a request with potential user-input going into a OutputStream or Writer object. This bypasses any view or template environments, including HTML escaping, which may expose this application to cross-site scripting (XSS) vulnerabilities. Consider using a view technology such as JavaServer Faces (JSFs) which automatically escapes HTML views. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/MessageListNav2Action.java:42— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/MessageListNavAction.java:42— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/account/AccountProfileAction.java:68— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/account/AccountProfileAction.java:69— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/account/SmsQQAction.java:40— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/account/oauth/SinaUserCallBackAction.java:46— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:225— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:237— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: crlf-injection-logs src/main/java/com/jdon/jivejdon/presentation/action/admin/FiltersAction.java:255— When data from an untrusted source is put into a logger and not neutralized correctly, an attacker could forge log entries or include malicious content. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: weak-ssl-context src/main/java/com/jdon/jivejdon/spi/component/pingrpc/BlogPingSender.java:101— An insecure SSL context was detected. TLS versions 1.0, 1.1, and all SSL versions are considered weak encryption and are deprecated. Use SSLContext.getInstance("TLSv1.2") for the best security. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: use-of-md5 src/main/java/com/jdon/jivejdon/util/ToolsUtil.java:201— Detected MD5 hash algorithm which is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature. Use HMAC instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/shortmessage/ShortMessageServiceImp.java:141— src/main/java/com/jdon/jivejdon/api/impl/shortmessage/ShortMessageServiceImp.java:141-147 | src/main/java/com/jdon/jivejdon/api/impl/shortmessage/ShortMessageServiceImp.java:160-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/api/impl/shortmessage/ShortMessageServiceImp.java:141` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/auth/jaas/DigestUtil.java:49— src/main/java/com/jdon/jivejdon/auth/jaas/DigestUtil.java:49-55 | src/main/java/com/jdon/jivejdon/util/ToolsUtil.java:228-234 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/auth/jaas/DigestUtil.java:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:356— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:356-362 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:987-993 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:403— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:403-409 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:1031-1037 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:403` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:600— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:600-606 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:618-624 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:600` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/subscription/SubscribedState.java:62— src/main/java/com/jdon/jivejdon/domain/model/subscription/SubscribedState.java:62-68 | src/main/java/com/jdon/jivejdon/domain/model/subscription/SubscribedState.java:79-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/subscription/SubscribedState.java:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:202— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:202-208 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:229-235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:202` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/admin/UserMessageListAction.java:30— src/main/java/com/jdon/jivejdon/presentation/action/admin/UserMessageListAction.java:30-36 | src/main/java/com/jdon/jivejdon/presentation/action/query/MessageQueryUserAction.java:59-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/admin/UserMessageListAction.java:30` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/main/java/com/jdon/jivejdon/presentation/filter/MessageEditAuthFilter.java:35— src/main/java/com/jdon/jivejdon/presentation/filter/MessageEditAuthFilter.java:35-41 | src/main/java/com/jdon/jivejdon/presentation/filter/ThreadEditAuthFilter.java:29-35 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/filter/MessageEditAuthFilter.java:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
TooManyMethods: JavaCodeViewer src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:31— TooManyMethods — 59 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: JavaCodeHighlighter src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:30— TooManyMethods — 53 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Account src/main/java/com/jdon/jivejdon/domain/model/account/Account.java:27— TooManyMethods — 52 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ForumThread src/main/java/com/jdon/jivejdon/domain/model/ForumThread.java:61— TooManyMethods — 43 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ForumMessage src/main/java/com/jdon/jivejdon/domain/model/ForumMessage.java:65— TooManyMethods — 42 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageForm src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java:43— TooManyMethods — 37 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AnemicMessageDTO src/main/java/com/jdon/jivejdon/infrastructure/dto/AnemicMessageDTO.java:16— TooManyMethods — 36 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ToolsUtil src/main/java/com/jdon/jivejdon/util/ToolsUtil.java:43— TooManyMethods — 32 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:625— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:625-635 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:640-650 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:625` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:102— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:102-112 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:135-145 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UploadFileDaoSql.java:155— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UploadFileDaoSql.java:155-165 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UploadFileDaoSql.java:171-181 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/UploadFileDaoSql.java:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:257— src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:257-267 | src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:313-323 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/spi/component/query/HotThreadQueryManager.java:62— src/main/java/com/jdon/jivejdon/spi/component/query/HotThreadQueryManager.java:62-72 | src/main/java/com/jdon/jivejdon/spi/component/query/HotThreadQueryManager.java:85-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/component/query/HotThreadQueryManager.java:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:201— src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:201-211 | src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:266-276 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/component/sitemap/SitemapRepositoryImpl.java:201` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/TextStyle.java:293— src/main/java/com/jdon/jivejdon/domain/model/message/output/html/TextStyle.java:293-301 | src/main/java/com/jdon/jivejdon/domain/model/message/output/html/TextStyle.java:303-311 | src/main/java/com/jdon/jivejdon/domain/model/message/output/html/TextStyle.java:313-321 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/html/TextStyle.java:293` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:220— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:220-228 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:245-253 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:262-270 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:220` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:303— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:303-311 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:348-356 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:381-389 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:303` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:146— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:146-154 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:252-260 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:373-381 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:146` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:271— src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:271-279 | src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:301-309 | src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:326-335 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:271` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:38— src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:38-46 | src/main/java/com/jdon/jivejdon/presentation/taglib/NextTag.java:46-55 | src/main/java/com/jdon/jivejdon/presentation/taglib/PrevTag.java:46-54 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:38` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageServiceImpl.java:360— src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageServiceImpl.java:360-365 | src/main/java/com/jdon/jivejdon/infrastructure/repository/search/ReBuildIndex.java:82-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/builder/MessageInitFactory.java:64— src/main/java/com/jdon/jivejdon/infrastructure/repository/builder/MessageInitFactory.java:64-69 | src/main/java/com/jdon/jivejdon/infrastructure/repository/builder/MessageInitFactory.java:134-139 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:68— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:68-74 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:254-259 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:556— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:556-561 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:598-603 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:271— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:271-276 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:283-288 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/MessageQueryUserAction.java:76— src/main/java/com/jdon/jivejdon/presentation/action/query/MessageQueryUserAction.java:76-81 | src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadQueryUserAction.java:81-86 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
Duplicated block (15 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:24— src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:24-38 | src/main/java/com/jdon/jivejdon/util/FiltersUtils.java:38-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (15 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:337— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:337-351 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:766-780 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:337` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/main/java/com/jdon/jivejdon/spi/component/subscription/action/ShortMsgAction.java:41— src/main/java/com/jdon/jivejdon/spi/component/subscription/action/ShortMsgAction.java:41-55 | src/main/java/com/jdon/jivejdon/spi/component/subscription/action/SinaWeiboAction.java:49-63 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/component/subscription/action/ShortMsgAction.java:41` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/main/java/com/jdon/jivejdon/util/XMLProperties.java:267— src/main/java/com/jdon/jivejdon/util/XMLProperties.java:267-281 | src/main/java/com/jdon/jivejdon/util/XMLProperties.java:284-298 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/util/XMLProperties.java:267` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:127— src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:127-139 | src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:156-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/api/impl/message/ForumMessageQueryServiceImp.java:127` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/acccount/AccountFactoryDao.java:41— src/main/java/com/jdon/jivejdon/infrastructure/repository/acccount/AccountFactoryDao.java:41-53 | src/main/java/com/jdon/jivejdon/infrastructure/repository/builder/ForumDirector.java:31-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/acccount/AccountFactoryDao.java:41` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/main/java/com/jdon/jivejdon/presentation/taglib/NextTag.java:71— src/main/java/com/jdon/jivejdon/presentation/taglib/NextTag.java:71-83 | src/main/java/com/jdon/jivejdon/presentation/taglib/PrevTag.java:67-79 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/taglib/NextTag.java:71` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 5) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:149— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:149-156 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:81-89 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:148-156 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:209-217 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:229-237 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:149` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 5) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:112— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:112-119 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:149-156 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:188-196 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:251-262 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:430-440 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 5) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:88— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:88-95 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:172-179 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:190-197 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:165-172 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:207-214 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:88` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
initialize (cyclomatic 29) application/common/js/window_def.js:8— initialize has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
initialize (cyclomatic 29) application/common/js/window.js:7— initialize has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 24) application/common/autocomplete/jquery-ui.js:2791— (anonymous) has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 24) application/common/autocomplete/jquery-ui.js:10073— (anonymous) has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
setSize (cyclomatic 17) application/common/js/window_def.js:419— setSize has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
setSize (cyclomatic 17) application/common/js/window.js:418— setSize has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 17) application/common/autocomplete/jquery-ui.js:4768— (anonymous) has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 17) application/common/autocomplete/jquery-ui.js:5048— (anonymous) has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
maximize (cyclomatic 16) application/common/js/window_def.js:588— maximize has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
maximize (cyclomatic 16) application/common/js/window.js:587— maximize has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
initialize (cognitive 36) application/common/js/window_def.js:8— initialize has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
initialize (cognitive 36) application/common/js/window.js:7— initialize has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FiltersUtils.getPropertyHTML (cognitive 26) src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:18— FiltersUtils.getPropertyHTML has cognitive complexity 26 (threshold 15). Drivers by points: if/else 18, ternaries 6, boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FiltersUtils.getPropertyHTML (cognitive 26) src/main/java/com/jdon/jivejdon/util/FiltersUtils.java:32— FiltersUtils.getPropertyHTML has cognitive complexity 26 (threshold 15). Drivers by points: if/else 18, ternaries 6, boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_saveCookie (cognitive 19) application/common/js/window_def.js:720— _saveCookie has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_saveCookie (cognitive 19) application/common/js/window.js:719— _saveCookie has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 19) application/common/autocomplete/jquery-ui.js:5048— (anonymous) has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 19) application/common/autocomplete/jquery-ui.js:10942— (anonymous) has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FiltersUtils.escapeHTMLTags (cognitive 17) src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:88— FiltersUtils.escapeHTMLTags has cognitive complexity 17 (threshold 15). Drivers by points: if/else 16, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FiltersUtils.escapeHTMLTags (cognitive 17) src/main/java/com/jdon/jivejdon/util/FiltersUtils.java:102— FiltersUtils.escapeHTMLTags has cognitive complexity 17 (threshold 15). Drivers by points: if/else 16, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
maximize (cognitive 17) application/common/js/window_def.js:588— maximize has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
maximize (cognitive 17) application/common/js/window.js:587— maximize has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_openDialog (cognitive 17) application/common/js/window_def.js:935— _openDialog has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_openDialog (cognitive 17) application/common/js/window.js:934— _openDialog has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileTooLong: autocomplete/jquery-ui.js application/common/autocomplete/jquery-ui.js:0— FileTooLong — 7157 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: codeviewer/JavaCodeViewer.java src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:0— FileTooLong — 652 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Medium: watchdog-personal-data-in-log src/main/java/com/jdon/jivejdon/presentation/action/account/SmsQQAction.java:43— Personal data appears to be written to a log or console sink. Under GDPR Article 5(1)(c) logs should carry the minimum needed to operate the system; prefer a pseudonymous identifier over the personal value itself.
Medium: watchdog-personal-data-in-log src/main/java/com/jdon/jivejdon/presentation/action/account/SmsQQAction.java:74— Personal data appears to be written to a log or console sink. Under GDPR Article 5(1)(c) logs should carry the minimum needed to operate the system; prefer a pseudonymous identifier over the personal value itself.
Duplicated block (14 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:415— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:415-428 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:453-466 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:415` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/query/QueryCriteria.java:84— src/main/java/com/jdon/jivejdon/domain/model/query/QueryCriteria.java:84-97 | src/main/java/com/jdon/jivejdon/domain/model/query/QueryCriteria.java:141-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/query/QueryCriteria.java:84` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:720— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:720-732 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:736-747 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:720` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/main/java/com/jdon/jivejdon/presentation/action/query/MessageQueryUserAction.java:31— src/main/java/com/jdon/jivejdon/presentation/action/query/MessageQueryUserAction.java:31-42 | src/main/java/com/jdon/jivejdon/presentation/action/query/ThreadQueryUserAction.java:35-46 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
Duplicated block (9 lines × 5) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:239— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:239-248 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:86-94 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:170-178 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:188-196 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/SubscriptionDaoSql.java:163-171 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:239` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 5) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:279— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:279-287 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:82-90 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:149-157 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:210-218 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:230-238 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ForumDaoSql.java:279` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:381— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:381-386 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:143-148 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:370-375 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageDaoSql.java:381` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/property/PropertyFactoryDao.java:53— src/main/java/com/jdon/jivejdon/infrastructure/repository/property/PropertyFactoryDao.java:53-58 | src/main/java/com/jdon/jivejdon/infrastructure/repository/property/PropertyFactoryDao.java:78-83 | src/main/java/com/jdon/jivejdon/infrastructure/repository/property/PropertyFactoryDao.java:115-120 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/property/PropertyFactoryDao.java:53` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:193— src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:193-197 | src/main/java/com/jdon/jivejdon/api/impl/account/OAuthAccountServiceImp.java:260-264 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:180— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:180-184 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/AccountDaoSql.java:252-256 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
JavaCodeViewer.javaCodeFilter (cyclomatic 122) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:303— JavaCodeViewer.javaCodeFilter has cyclomatic complexity 122 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_generateHTML (cyclomatic 91) application/common/autocomplete/jquery-ui.js:8313— _generateHTML has cyclomatic complexity 91 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Emoticon.convertEmoticons (cyclomatic 83) src/main/java/com/jdon/jivejdon/domain/model/message/output/emotion/Emoticon.java:240— Emoticon.convertEmoticons has cyclomatic complexity 83 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_doKeyDown (cyclomatic 45) application/common/autocomplete/jquery-ui.js:7392— _doKeyDown has cyclomatic complexity 45 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
drag (cyclomatic 44) application/common/autocomplete/jquery-ui.js:1485— drag has cyclomatic complexity 44 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
parseDate (cyclomatic 41) application/common/autocomplete/jquery-ui.js:7854— parseDate has cyclomatic complexity 41 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
parseDate (cyclomatic 36) application/common/js/calendar.js:4— parseDate has cyclomatic complexity 36 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_keyEvent (cyclomatic 35) application/common/js/calendar.js:4— _keyEvent has cyclomatic complexity 35 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_generatePosition (cyclomatic 32) application/common/autocomplete/jquery-ui.js:1161— _generatePosition has cyclomatic complexity 32 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_mouseDrag (cyclomatic 32) application/common/autocomplete/jquery-ui.js:3129— _mouseDrag has cyclomatic complexity 32 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_clear (cyclomatic 32) application/common/autocomplete/jquery-ui.js:3870— _clear has cyclomatic complexity 32 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
onShow (cyclomatic 31) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:274— onShow has cyclomatic complexity 31 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_generatePosition (cyclomatic 30) application/common/autocomplete/jquery-ui.js:3794— _generatePosition has cyclomatic complexity 30 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
intersect (cyclomatic 29) application/common/autocomplete/jquery-ui.js:1709— intersect has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_respectSize (cyclomatic 29) application/common/autocomplete/jquery-ui.js:2240— _respectSize has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_tabify (cyclomatic 28) application/common/autocomplete/jquery-ui.js:10706— _tabify has cyclomatic complexity 28 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 27) application/common/autocomplete/jquery-ui.js:4619— (anonymous) has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_showDatepicker (cyclomatic 27) application/common/autocomplete/jquery-ui.js:7503— _showDatepicker has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
formatDate (cyclomatic 27) application/common/autocomplete/jquery-ui.js:8036— formatDate has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_generateMonthYearHeader (cyclomatic 27) application/common/autocomplete/jquery-ui.js:8481— _generateMonthYearHeader has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
JavaCodeHighlighter.highlightCode (cyclomatic 26) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:608— JavaCodeHighlighter.highlightCode has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
$ (cyclomatic 26) application/common/ckeditor/plugins/bbcode/plugin.js:622— $ has cyclomatic complexity 26 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_init (cyclomatic 25) application/common/js/calendar.js:4— _init has cyclomatic complexity 25 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_setContainment (cyclomatic 25) application/common/autocomplete/jquery-ui.js:1107— _setContainment has cyclomatic complexity 25 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
parse (cyclomatic 24) application/common/ckeditor/plugins/bbcode/plugin.js:80— parse has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
cellClick (cyclomatic 22) application/common/js/calendar.js:4— cellClick has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
drag (cyclomatic 22) application/common/autocomplete/jquery-ui.js:1425— drag has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
resize (cyclomatic 22) application/common/autocomplete/jquery-ui.js:2523— resize has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_setOption (cyclomatic 22) application/common/autocomplete/jquery-ui.js:9275— _setOption has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
onOk (cyclomatic 22) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:346— onOk has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
AccountForm.doValidate (cyclomatic 21) src/main/java/com/jdon/jivejdon/presentation/form/AccountForm.java:131— AccountForm.doValidate has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IndexTag.doStartTag (cyclomatic 20) src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:34— IndexTag.doStartTag has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
imagePreview (cyclomatic 20) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:79— imagePreview has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
AuthorNameFilter.getUsernameFromBody (cyclomatic 19) src/main/java/com/jdon/jivejdon/domain/model/message/infilter/AuthorNameFilter.java:30— AuthorNameFilter.getUsernameFromBody has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PasswordassitAction.execute (cyclomatic 19) src/main/java/com/jdon/jivejdon/presentation/action/account/PasswordassitAction.java:44— PasswordassitAction.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
create (cyclomatic 19) application/common/js/calendar.js:4— create has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_contactContainers (cyclomatic 19) application/common/autocomplete/jquery-ui.js:3582— _contactContainers has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_refreshValue (cyclomatic 19) application/common/autocomplete/jquery-ui.js:10551— _refreshValue has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 18) application/common/autocomplete/jquery-ui.js:1809— (anonymous) has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_mouseStart (cyclomatic 18) application/common/autocomplete/jquery-ui.js:3013— _mouseStart has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_setContainment (cyclomatic 18) application/common/autocomplete/jquery-ui.js:3745— _setContainment has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PinyinUtils.toPinyin (cyclomatic 17) src/main/java/com/jdon/jivejdon/util/PinyinUtils.java:10— PinyinUtils.toPinyin has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_mouseStop (cyclomatic 17) application/common/autocomplete/jquery-ui.js:937— _mouseStop has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_toggle (cyclomatic 17) application/common/autocomplete/jquery-ui.js:5642— _toggle has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
MessageForm.doValidate (cyclomatic 16) src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java:260— MessageForm.doValidate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_convertPositionTo (cyclomatic 16) application/common/autocomplete/jquery-ui.js:1138— _convertPositionTo has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_clickHandler (cyclomatic 16) application/common/autocomplete/jquery-ui.js:5556— _clickHandler has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_optionDatepicker (cyclomatic 16) application/common/autocomplete/jquery-ui.js:7321— _optionDatepicker has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_hideDatepicker (cyclomatic 16) application/common/autocomplete/jquery-ui.js:7666— _hideDatepicker has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity· position (cyclomatic 16) · ×1
position (cyclomatic 16) application/common/autocomplete/jquery-ui.js:9585— position has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
(anonymous) (cyclomatic 16) application/common/autocomplete/jquery-ui.js:10942— (anonymous) has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Hotspot: src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java— src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java changed 4 times in last 90 days, max complexity 16. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, behind tests written first.
LLM evaluation failed — JSON parse error: Expected end of string, but instead reached end of data. Path: $.findings[1].docPath | LineNumber: 0 | BytePositionInLine: 1143.
JavaCodeViewer.javaCodeFilter (cognitive 382) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:303— JavaCodeViewer.javaCodeFilter has cognitive complexity 382 (threshold 15). Drivers by points: if/else 363, boolean chains 16, match/switch 2, loops 1 (nesting depth added 239). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_generateHTML (cognitive 207) application/common/autocomplete/jquery-ui.js:8313— _generateHTML has cognitive complexity 207 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Emoticon.convertEmoticons (cognitive 183) src/main/java/com/jdon/jivejdon/domain/model/message/output/emotion/Emoticon.java:240— Emoticon.convertEmoticons has cognitive complexity 183 (threshold 15). Drivers by points: ternaries 116, if/else 45, boolean chains 13, match/switch 8, loops 1 (nesting depth added 123). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JavaCodeHighlighter.highlightCode (cognitive 104) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeHighlighter.java:608— JavaCodeHighlighter.highlightCode has cognitive complexity 104 (threshold 15). Drivers by points: if/else 98, boolean chains 4, loops 2 (nesting depth added 69). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PasswordassitAction.execute (cognitive 63) src/main/java/com/jdon/jivejdon/presentation/action/account/PasswordassitAction.java:44— PasswordassitAction.execute has cognitive complexity 63 (threshold 15). Drivers by points: if/else 54, loops 7, boolean chains 1, error handling 1 (nesting depth added 41). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_generatePosition (cognitive 58) application/common/autocomplete/jquery-ui.js:1161— _generatePosition has cognitive complexity 58 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_doKeyDown (cognitive 54) application/common/autocomplete/jquery-ui.js:7392— _doKeyDown has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_generatePosition (cognitive 51) application/common/autocomplete/jquery-ui.js:3794— _generatePosition has cognitive complexity 51 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_mouseDrag (cognitive 50) application/common/autocomplete/jquery-ui.js:3129— _mouseDrag has cognitive complexity 50 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
parseDate (cognitive 49) application/common/js/calendar.js:4— parseDate has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
drag (cognitive 49) application/common/autocomplete/jquery-ui.js:1485— drag has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_init (cognitive 45) application/common/js/calendar.js:4— _init has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_clear (cognitive 45) application/common/autocomplete/jquery-ui.js:3870— _clear has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
parseDate (cognitive 43) application/common/autocomplete/jquery-ui.js:7854— parseDate has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_tabify (cognitive 43) application/common/autocomplete/jquery-ui.js:10706— _tabify has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
parse (cognitive 43) application/common/ckeditor/plugins/bbcode/plugin.js:80— parse has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
onShow (cognitive 41) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:274— onShow has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AccountForm.doValidate (cognitive 38) src/main/java/com/jdon/jivejdon/presentation/form/AccountForm.java:131— AccountForm.doValidate has cognitive complexity 38 (threshold 15). Drivers by points: if/else 35, boolean chains 3 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_contactContainers (cognitive 37) application/common/autocomplete/jquery-ui.js:3582— _contactContainers has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
$ (cognitive 37) application/common/ckeditor/plugins/bbcode/plugin.js:622— $ has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_keyEvent (cognitive 36) application/common/js/calendar.js:4— _keyEvent has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_generateMonthYearHeader (cognitive 36) application/common/autocomplete/jquery-ui.js:8481— _generateMonthYearHeader has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PinyinUtils.toPinyin (cognitive 35) src/main/java/com/jdon/jivejdon/util/PinyinUtils.java:10— PinyinUtils.toPinyin has cognitive complexity 35 (threshold 15). Drivers by points: if/else 23, loops 5, boolean chains 4, error handling 3 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
onOk (cognitive 34) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:346— onOk has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuoteFilter.reformatText (cognitive 33) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/QuoteFilter.java:203— QuoteFilter.reformatText has cognitive complexity 33 (threshold 15). Drivers by points: if/else 24, loops 6, ternaries 2, boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 32) application/common/autocomplete/jquery-ui.js:4619— (anonymous) has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_showDatepicker (cognitive 32) application/common/autocomplete/jquery-ui.js:7503— _showDatepicker has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
resize (cognitive 31) application/common/autocomplete/jquery-ui.js:2523— resize has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
formatDate (cognitive 30) application/common/autocomplete/jquery-ui.js:8036— formatDate has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 30) application/common/autocomplete/jquery-ui.js:10564— (anonymous) has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
imagePreview (cognitive 30) application/common/ckeditor/plugins/base64image/dialogs/base64image.js:79— imagePreview has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
drag (cognitive 29) application/common/autocomplete/jquery-ui.js:1425— drag has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 29) application/common/autocomplete/jquery-ui.js:4768— (anonymous) has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_setContainment (cognitive 27) application/common/autocomplete/jquery-ui.js:1107— _setContainment has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_resetButton (cognitive 27) application/common/autocomplete/jquery-ui.js:6778— _resetButton has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_hideDatepicker (cognitive 27) application/common/autocomplete/jquery-ui.js:7666— _hideDatepicker has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AuthorNameFilter.getUsernameFromBody (cognitive 26) src/main/java/com/jdon/jivejdon/domain/model/message/infilter/AuthorNameFilter.java:30— AuthorNameFilter.getUsernameFromBody has cognitive complexity 26 (threshold 15). Drivers by points: if/else 18, boolean chains 7, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 26) application/common/autocomplete/jquery-ui.js:2791— (anonymous) has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_toggle (cognitive 25) application/common/autocomplete/jquery-ui.js:5642— _toggle has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageForm.doValidate (cognitive 24) src/main/java/com/jdon/jivejdon/presentation/form/MessageForm.java:260— MessageForm.doValidate has cognitive complexity 24 (threshold 15). Drivers by points: if/else 18, boolean chains 6 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IndexTag.doStartTag (cognitive 24) src/main/java/com/jdon/jivejdon/presentation/taglib/IndexTag.java:34— IndexTag.doStartTag has cognitive complexity 24 (threshold 15). Drivers by points: if/else 18, boolean chains 3, loops 2, error handling 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
BlockStrategyFixed.locate (cognitive 24) src/main/java/com/jdon/jivejdon/util/BlockStrategyFixed.java:23— BlockStrategyFixed.locate has cognitive complexity 24 (threshold 15). Drivers by points: if/else 20, boolean chains 2, error handling 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
cellClick (cognitive 23) application/common/js/calendar.js:4— cellClick has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_refreshValue (cognitive 23) application/common/autocomplete/jquery-ui.js:10551— _refreshValue has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
create (cognitive 22) application/common/js/calendar.js:4— create has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_respectSize (cognitive 22) application/common/autocomplete/jquery-ui.js:2240— _respectSize has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_refreshItems (cognitive 22) application/common/autocomplete/jquery-ui.js:3457— _refreshItems has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_slide (cognitive 22) application/common/autocomplete/jquery-ui.js:10328— _slide has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
URLConverter.convertURL (cognitive 21) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/URLConverter.java:150— URLConverter.convertURL has cognitive complexity 21 (threshold 15). Drivers by points: if/else 17, boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_renderAxis (cognitive 21) application/common/autocomplete/jquery-ui.js:1955— _renderAxis has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_mouseStart (cognitive 21) application/common/autocomplete/jquery-ui.js:3013— _mouseStart has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 20) application/common/autocomplete/jquery-ui.js:1809— (anonymous) has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_getItemsAsjQuery (cognitive 20) application/common/autocomplete/jquery-ui.js:3411— _getItemsAsjQuery has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_setOption (cognitive 20) application/common/autocomplete/jquery-ui.js:9275— _setOption has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ToolsUtil.convertTagsFirst (cognitive 19) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/ToolsUtil.java:40— ToolsUtil.convertTagsFirst has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15, boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
cancel (cognitive 19) application/common/autocomplete/jquery-ui.js:3248— cancel has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_setContainment (cognitive 19) application/common/autocomplete/jquery-ui.js:3745— _setContainment has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_optionDatepicker (cognitive 19) application/common/autocomplete/jquery-ui.js:7321— _optionDatepicker has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuoteFilter.parseQuotes (cognitive 18) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/QuoteFilter.java:122— QuoteFilter.parseQuotes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10, loops 5, boolean chains 2, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EmailTask.addMessage (cognitive 18) src/main/java/com/jdon/jivejdon/util/EmailTask.java:164— EmailTask.addMessage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 14, boolean chains 2, error handling 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_showTooltip (cognitive 18) application/common/js/window_def.js:1408— _showTooltip has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_mouseStop (cognitive 18) application/common/autocomplete/jquery-ui.js:937— _mouseStop has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
prepareOffsets (cognitive 18) application/common/autocomplete/jquery-ui.js:1759— prepareOffsets has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
onTagOpen (cognitive 18) application/common/ckeditor/plugins/bbcode/plugin.js:251— onTagOpen has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodeHighlighter.highlightCode (cognitive 17) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeHighlighter.java:181— CodeHighlighter.highlightCode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, boolean chains 3, loops 3, error handling 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HTMLFilter.escapeHTMLTags (cognitive 17) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/HTMLFilter.java:52— HTMLFilter.escapeHTMLTags has cognitive complexity 17 (threshold 15). Drivers by points: if/else 16, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Newline.convertNewlinesAroundCode (cognitive 17) src/main/java/com/jdon/jivejdon/domain/model/message/output/html/Newline.java:151— Newline.convertNewlinesAroundCode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10, loops 4, boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ThreadApprovedNewList.loadApprovedThreads (cognitive 17) src/main/java/com/jdon/jivejdon/spi/component/mapreduce/ThreadApprovedNewList.java:159— ThreadApprovedNewList.loadApprovedThreads has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12, loops 3, boolean chains 1, error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 17) application/common/login2.js:5— (anonymous) has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
tableMouseOver (cognitive 17) application/common/js/calendar.js:4— tableMouseOver has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
intersect (cognitive 17) application/common/autocomplete/jquery-ui.js:1709— intersect has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_determineButtonType (cognitive 17) application/common/autocomplete/jquery-ui.js:6678— _determineButtonType has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_create (cognitive 17) application/common/autocomplete/jquery-ui.js:9993— _create has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodeViewer.keywordFilter (cognitive 16) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/CodeViewer.java:272— CodeViewer.keywordFilter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7, boolean chains 6, loops 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RSSGenServlet.checkModifiedEtagFilter (cognitive 16) src/main/java/com/jdon/jivejdon/presentation/servlet/RSSGenServlet.java:95— RSSGenServlet.checkModifiedEtagFilter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 13, boolean chains 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
setDimensions (cognitive 16) application/common/js/window_def.js:1— setDimensions has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
(anonymous) (cognitive 16) application/common/autocomplete/jquery-ui.js:5006— (anonymous) has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_clickHandler (cognitive 16) application/common/autocomplete/jquery-ui.js:5556— _clickHandler has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity· position (cognitive 16) · ×1
position (cognitive 16) application/common/autocomplete/jquery-ui.js:9585— position has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Change coupling: MessageForumListAction.java ↔ MessageListNavAction.java src/main/java/com/jdon/jivejdon/presentation/action/MessageForumListAction.java— `src/main/java/com/jdon/jivejdon/presentation/action/MessageForumListAction.java` and `src/main/java/com/jdon/jivejdon/presentation/action/MessageListNavAction.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
Duplicated block (16 lines × 2) src/main/java/com/jdon/jivejdon/spi/component/throttle/hitkey/HitConf.java:38— src/main/java/com/jdon/jivejdon/spi/component/throttle/hitkey/HitConf.java:38-53 | src/main/java/com/jdon/jivejdon/spi/component/throttle/post/VIPUserThrottleConf.java:48-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/spi/component/throttle/hitkey/HitConf.java:38` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 3) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:429— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:429-444 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:466-480 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:501-517 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:429` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 3) src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:108— src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:108-119 | src/main/java/com/jdon/jivejdon/domain/model/message/output/html/HTMLFilter.java:72-83 | src/main/java/com/jdon/jivejdon/util/FiltersUtils.java:122-133 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/beanutil/FiltersUtils.java:108` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:84— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:84-94 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:110-120 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:136-146 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/PropertyDaoSql.java:84` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 4) src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:684— src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:684-693 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:719-729 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:735-744 | src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:750-759 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/domain/model/message/output/codeviewer/JavaCodeViewer.java:684` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ShortMessageDaoSql.java:206— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ShortMessageDaoSql.java:206-215 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ShortMessageDaoSql.java:221-230 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ShortMessageDaoSql.java:235-244 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/ShortMessageDaoSql.java:206` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 4) src/main/java/com/jdon/jivejdon/presentation/action/sub/SubAccountListAction.java:18— src/main/java/com/jdon/jivejdon/presentation/action/sub/SubAccountListAction.java:18-24 | src/main/java/com/jdon/jivejdon/presentation/action/sub/SubForumListAction.java:34-40 | src/main/java/com/jdon/jivejdon/presentation/action/sub/SubTagListAction.java:18-24 | src/main/java/com/jdon/jivejdon/presentation/action/sub/SubThreadListAction.java:18-24 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/presentation/action/sub/SubAccountListAction.java:18` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 3) src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:426— src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:426-430 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:312-316 | src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/TagDaoSql.java:353-357 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/com/jdon/jivejdon/infrastructure/repository/dao/sql/MessageQueryDaoSql.java:426` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Low: insecure-trust-manager src/main/java/com/jdon/jivejdon/spi/component/pingrpc/BlogPingSender.java:103— Detected empty trust manager implementations. This is dangerous because it accepts any certificate, enabling man-in-the-middle attacks. Consider using a KeyStore and TrustManagerFactory instead. See https://stackoverflow.com/questions/2642777/trusting-all-certificates-using-httpclient-over-https for more information. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Low: insecure-trust-manager src/main/java/com/jdon/jivejdon/spi/component/pingrpc/BlogPingSender.java:107— Detected empty trust manager implementations. This is dangerous because it accepts any certificate, enabling man-in-the-middle attacks. Consider using a KeyStore and TrustManagerFactory instead. See https://stackoverflow.com/questions/2642777/trusting-all-certificates-using-httpclient-over-https for more information. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Low: insecure-trust-manager src/main/java/com/jdon/jivejdon/spi/component/pingrpc/BlogPingSender.java:111— Detected empty trust manager implementations. This is dangerous because it accepts any certificate, enabling man-in-the-middle attacks. Consider using a KeyStore and TrustManagerFactory instead. See https://stackoverflow.com/questions/2642777/trusting-all-certificates-using-httpclient-over-https for more information. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Low: defaulthttpclient-is-deprecated src/main/java/com/jdon/jivejdon/util/HttpClientUtil.java:14— DefaultHttpClient is deprecated. Further, it does not support connections using TLS1.2, which makes using DefaultHttpClient a security hazard. Use HttpClientBuilder instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
Low: cookie-missing-httponly src/main/java/com/jdon/jivejdon/util/ToolsUtil.java:562— A cookie was detected without setting the 'HttpOnly' flag. The 'HttpOnly' flag for cookies instructs the browser to forbid client-side scripts from reading the cookie. Set the 'HttpOnly' flag by calling 'cookie.setHttpOnly(true);'. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Low: cookie-missing-secure-flag src/main/java/com/jdon/jivejdon/util/ToolsUtil.java:562— A cookie was detected without setting the 'secure' flag. The 'secure' flag for cookies prevents the client from transmitting the cookie over insecure channels such as HTTP. Set the 'secure' flag by calling 'cookie.setSecure(true);'. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Low IaC: DS-0005 Dockerfile.web— ADD instead of COPY
Low IaC: DS-0026 Dockerfile.web— No HEALTHCHECK defined Without one the runtime only knows whether the process is alive, not whether it is serving, so a wedged container is restarted by nobody. The step: add a `HEALTHCHECK` to the image that probes the service the way a client would — this image already declares `EXPOSE 8080`, so a request to `localhost:8080` on the service's own health or root route, exiting non-zero when it does not answer, is the probe — and give it an `--interval`, a `--timeout` and a `--start-period` long enough to cover startup. If the image ships no HTTP client, probe with whatever the runtime already has, or declare the check in the orchestrator instead and say so here.
D11 · Test Reliability· Test reliability not included · ×1
Test reliability not included — Test source is present (.java) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D16 · Bus Factor· Small-team knowledge concentration · ×1
Small-team knowledge concentration — 72 file(s) are concentrated to one author — the ambient state with 2 active author(s), not 72 separate risks. The signal becomes meaningful as ownership spreads; no per-file action implied now.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
Rotate the exposed credentials — git history can't be un-committed — Some of these secrets are in git HISTORY: deleting the file does not remove them (the commit persists on every clone, fork and backup). The remediation is to ROTATE each historically-exposed credential and treat it as compromised — not to delete the file. Rewriting history is disruptive and unreliable across existing forks. (Working-tree-only secrets — no commit — can instead be removed from the file and moved to a secret store.)
D38 · OSV Dependency Vulnerabilities· Scanner failed to run · ×1
Scanner failed to run — not a clean result — osv-scanner exited 128 with no findings — the advisory database was likely unreachable. The scanner exited non-zero and produced no findings (typically the advisory DB was unreachable), so this is reported as a measurement gap rather than a clean pass.
Coverage not included — suite not readable by the collector — Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored.
Info — 2 finding(s)
D12 · Dependency Hygiene· Dependency hygiene not measured · ×1
Dependency hygiene not measured — dependency manifest found but not parsed for hygiene — This repository's dependency manifest (a Maven POM) was found, but this pass cannot parse it for hygiene, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D38 wherever the manifest is OSV-readable.
D22 · Internal API Consistency· No exposed public API · ×1
No exposed public API — No intentionally-exposed types (IsPackable or .Contracts) to evaluate.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, Jenkinsfile, .circleci); there is no build to attest provenance for.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
0
—
Run 019fced3-dca6-703c-adcb-d3c978de965e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 6 · Warnings: 290 · Recommendations: 13 · Info: 2 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 04-08-2026 @ 22:10 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.