Executive summary
Read through the Preview lens: this repo is pre-1.0 / in development, so the colour bands are relaxed to what a preview needs — *green* means good enough for a preview, not yet production-stable. Code correctness and security stay near-strict even here; the score itself is absolute and comparable across repos.
bluzky/salad_ui carries serious gaps (60%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.
It is strongest in Architecture (99%) — the structure is clean and changes stay contained. Security (83%) is solid too.
The area that most needs attention is Readiness (51%) — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade. Code Health (59%) is the next concern — changes there are slower and more error-prone.
Leadership focus, highest impact first: 2 Leaked secret finding(s) (Secret Scanning); type checking (adopt TypeScript (Tooling); unused dependencies, declare unlisted imports explicitly,… (Dependency Hygiene).
For scale: Small (~16,437 production lines); rebuilding it from scratch would take roughly ~0.1 person-years (~1 engineer). Approximate, ±~30%.
It builds on a genuinely strong Architecture foundation (99%); the priorities above are the highest-leverage way to bring the rest up to that level.
Raise Readiness 51 → 70 (the Healthy floor) ⇒ headline 60 → ~67.
New since the last scan (16+)
- D1 · onPointerMove (cyclomatic 16) assets/salad_ui/components/toast.js
- D2 · onPointerMove (cognitive 18) assets/salad_ui/components/toast.js
- D3 · FileTooLong: components/toast.js assets/salad_ui/components/toast.js
- D15 · Hotspot: assets/salad_ui/components/toast.js assets/salad_ui/components/toast.js
- D31 · Medium IaC: CKV_DOCKER_2 storybook/Dockerfile
- D35 · Change coupling: collapsible.ex ↔ sidebar.ex lib/salad_ui/collapsible.ex
- D38 · High CVE: [GHSA redacted] assets/package-lock.json
- R10 · Duplicated block (18 lines × 2 locations) assets/salad_ui/components/hover-card.js
- R10 · Duplicated block (15 lines × 2 locations) assets/salad_ui/components/hover-card.js
- R10 · Duplicated block (12 lines × 2 locations) assets/salad_ui/components/dropdown_menu.js
- R10 · Duplicated block (12 lines × 2 locations) assets/salad_ui/components/hover-card.js
- R10 · Duplicated block (12 lines × 2 locations) assets/salad_ui/core/positioner.js
- R2 · Complex function onPointerMove (cyclomatic 16, cognitive 18) assets/salad_ui/components/toast.js
- R2 · Complex function populateCard (cyclomatic 11, cognitive 12) assets/salad_ui/components/toast.js
- R2 · Complex function endDrag (cyclomatic 11, cognitive 10) assets/salad_ui/components/toast.js
- R3 · Large Files
Rebuild cost & value ~ Modeled — €7,100–€36,000
| Cost to rebuild | €7,100–€36,000 |
| Domain complexity | Standard |
| Quality factor | 0.8× (at 60% quality) |
| Size & shape | Small · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk) |
This codebase represents roughly ~0.1 person-years of build effort (about ~€21,000 to rebuild). Its weakest lens is Readiness at 51% — the part of that asset most exposed by the findings below.
Top priorities
Diagnosis — what's actually going on
Architecture — module dependency matrix
At a glance — Code Health
At a glance — Architecture
At a glance — Maturity
At a glance — Readiness
At a glance — Security
Security & Compliance — OWASP Top-10 mapping
| OWASP category | Findings | Severity |
|---|---|---|
| A06:2021 — Vulnerable & Outdated Components | 10 | High / Critical |
| A05:2021 — Security Misconfiguration | 3 | High / Critical |
| A02:2021 — Cryptographic Failures | 2 | High / Critical |
| A03:2021 — Injection | 2 | High / Critical |
Roadmap
First, resolve the two leaked secrets in test.exs and dev.exs to secure the codebase. Next, enforce type safety by adding a TypeScript check to the CI pipeline and begin migrating the frontend JavaScript. Then, clean up the project by removing unused dependencies and explicitly declaring all imports. Finally, implement an approval gate for releases to prevent bad builds from reaching users.
| Do this | Helps | Effort | Dimension |
|---|---|---|---|
| Resolve the 2 Leaked secret finding(s) in Secret Scanning — start with test.exs, dev.exs. | +9.8 pts | Low | Secret Scanning |
| Add type checking (adopt TypeScript, or type-check the existing JavaScript with `checkJs`) as package.json scripts and run them in CI. | +8.6 pts | Medium | Tooling |
| Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies. | +7.5 pts | Medium | Dependency Hygiene |
| Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it. | +6.7 pts | Medium | Deployment & Rollback |
| Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up. | +5.8 pts | Medium | Type Safety |
| Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package. | +5.6 pts | Medium | Large Files |
| Add an 'Architecture' / 'How it works' section to the root README — the high-level shape. | +3.4 pts | Medium | Documentation (README) |
| Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form). | +3.4 pts | Medium | Architecture documentation |
File quality
| File | Score | Band | Worst signal |
|---|---|---|---|
| assets/package-lock.json | 2.4 | Slop | OSV Dependency Vulnerabilities: High CVE: [GHSA redacted] |
| storybook/Dockerfile | 4.1 | Mixed | IaC & Container Security: High IaC: DS-0029 |
| .github/workflows/sobelow.yml | 5.8 | Mixed | Static Analysis (SAST): High: github-actions-mutable-action-tag |
| storybook/mix.lock | 6.3 | Mixed | OSV Dependency Vulnerabilities: Medium CVE: EEF-[CVE redacted] |
| storybook/config/test.exs | 7.2 | Near-clean | Secret Scanning: Leaked secret: high-entropy-secret |
| storybook/config/dev.exs | 7.2 | Near-clean | Secret Scanning: Leaked secret: high-entropy-secret |
| assets/salad_ui/components/toast.js | 7.4 | Near-clean | Cyclomatic Complexity: onPointerMove (cyclomatic 16) |
| assets/salad_ui/core/collection.js | 8.5 | Near-clean | Cognitive Complexity: getItem (cognitive 18) |
| lib/salad_ui/sidebar.ex | 8.5 | Near-clean | God Classes: FileTooLong: salad_ui/sidebar.ex |
| storybook/storybook/salad_ui_component/hover_card.story.exs | 8.5 | Near-clean | Code Duplication: Duplicated block (37 lines × 2) |
| storybook/storybook/salad_ui_component/badge.story.exs | 8.5 | Near-clean | Code Duplication: Duplicated block (18 lines × 2) |
| lib/mix/tasks/salad.install.ex | 8.5 | Near-clean | Code Duplication: Duplicated block (16 lines × 2) |
| lib/salad_ui/collapsible.ex | 8.5 | Near-clean | Change Coupling: Change coupling: collapsible.ex ↔ sidebar.ex |
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 32 of 34 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 2 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.6 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
What we checked — 34 dimensions across the health lenses
- Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 27 of 33 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line.
- Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
- Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
Tools & methods
| Method | Backs | Version | Evaluator |
|---|---|---|---|
| Roslyn static analysis | Complexity, cohesion, coupling, dead code, API surface, layering | 5.3.0 | ✓ deterministic |
| Native secret scanner | Hardcoded secrets / credentials | 1.0.0 | ✓ deterministic |
| jscpd | Code duplication | — | ✓ deterministic |
| Coverage (coverlet / dotnet-coverage) | Line & branch coverage | 10.0.302 | ✓ deterministic |
| NuGet / dotnet | Outdated, vulnerable & deprecated dependencies | 10.0.302 | ✓ deterministic |
| git / LibGit2Sharp | Churn hotspots, knowledge concentration, history | 2.43.0 · 0.31.0 | ✓ deterministic |
| gitleaks · semgrep · trivy · checkov | Secrets in history, SAST, CVEs, IaC & container, PII / GDPR | 1.86.0 · 0.69.3 · 3.2.533 | ✓ deterministic |
| LLM (sampled · advisory) | Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement | Local LLM | ◐ LLM · sampled · advisory |
Run transparency — what happened this run
- D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
- D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
- D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
- D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
- D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
- D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
- D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
- D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
- D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
- D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
- D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
- D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
- D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
- D33 JS/npm Dependency Vulnerabilities: JS/npm CVE matching reads package manifests and lockfiles — risk from how a dependency is used, and advisories not yet published, fall outside this scan.
- D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
- D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
- M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
- P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
- P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
Dimensions
D1 · Cyclomatic Complexity
1 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was onPointerMove at 16.
D2 · Cognitive Complexity
2 method(s) exceeded the cognitive complexity threshold of 15; the worst was getItem at 18.
D3 · God Classes
2 god class(es) detected.
D4 · Code Duplication
3 duplicated block group(s) detected.
D13 · Secret Scanning
2 secret(s) detected.
What to do
- Resolve the 2 Leaked secret finding(s) in Secret Scanning — start with test.exs, dev.exs. — One of this dimension's main actionable groups (2 issue-level).
- Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
D15 · Churn × Complexity Hotspots
Top hotspots: assets/salad_ui/components/toast.js (2×16=32)
D16 · Bus Factor
36 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is lib/salad_ui/dropdown_menu.ex.
What to do
- Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
- Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
D19 · Documentation Quality
SaladUI's documentation is clear and complete: a single README with links to the live storybook (v1), hex docs, and a support link plus badges for tests, version, total downloads, and last-commit; a dedicated SaladStorybook README explaining how to clone the repo, install node modules, run phx.server, and visit localhost:4000; an assets/salad_ui/core README covering the core module's files, exports, and responsibilities (component base class, state-machine engine, factory) plus links to component-lifecycle.md and architecture-overview.md; a manual-installation guide that is nearly complete with color-config steps and Tailwind plugin configuration before being cut by the scanner; and an exhaustive JavaScript documentation index covering quick-start guides, core concepts, architecture overview, component lifecycle, state transition flow, implementation guides, patterns, and reference for every SaladUI JS component. The outline is fully present in each clipped doc body. SaladUI's documentation is clear and complete for a component framework: three README-style quick-start guides (quick_simple_component.md, quick_complex_component.md) cover the four-step create-and-use pattern with code examples for both Elixir and JavaScript components plus an import step, and a detailed lifecycle guide (component_lifecycle.md) that explains construction, setupEvents(), afterMount(), and teardown. A dedicated configuration reference (component_config_guide.md) defines state-machine/transition structure, event-handling by-state, aria attributes, and transition-function syntax with worked examples. Communication between client/server and client/client is explained in a separate guide (communication_guide.md). The Documentation Site Plan restructures the docs into an organized file tree that mirrors the content.
D21 · Naming Consistency
0 naming inconsistencies across 0 sampled symbols.
D28 · Secrets (history)
gitleaks scanned the full history AND the current working tree and found no secrets.
D29 · Static Analysis (SAST)
2 finding(s): 0 critical, 2 high, 0 medium, 0 low.
What to do
- Resolve the 2 High finding(s) in Static Analysis (SAST) — start with sobelow.yml (2). — One of this dimension's main actionable groups (2 issue-level).
D31 · IaC & Container Security
4 finding(s): 0 critical, 2 high, 2 medium, 0 low.
D33 · JS/npm Dependency Vulnerabilities
No known-vulnerable JS/npm dependencies.
D34 · Knowledge Freshness
Every significant source file has living knowledge — recently and meaningfully worked.
D35 · Change Coupling
Strongest change-coupling: collapsible.ex↔sidebar.ex 53%
D38 · OSV Dependency Vulnerabilities
10 finding(s): 0 critical, 6 high, 4 medium, 0 low.
What to do
- Resolve the 6 High CVE finding(s) in OSV Dependency Vulnerabilities — start with package-lock.json (6). — One of this dimension's main actionable groups (6 issue-level).
- Resolve the 4 Medium CVE finding(s) in OSV Dependency Vulnerabilities — start with mix.lock (3), package-lock.json. — One of this dimension's main actionable groups (4 warning-level).
Frontend & cross-cutting dimensions
M1 · Documentation (README)
- 91 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
What to do
- Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
- Add a README to the 2 of 3 project(s) that lack one — worth up to 1.3 pts.
- Review the README against recent changes; refresh the parts that drifted.
M2 · Architecture documentation
- No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
- Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
M3 · Folder & project structure
M4 · Documentation accuracy
- Carousel component is listed as present in the table but not implemented
- README advertises a RAG / ML engine, but no ML/RAG code or dependency exists
What to do
- Reconcile the README with reality: Carousel component is listed as present in the table but not implemented; README advertises a RAG / ML engine, but no ML/RAG code or dependency exists.
P1 · CI/CD gates
P3 · Security & performance tooling
What to do
- Enable Dependabot/Renovate or a dependency-review gate.
- Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback
What to do
- Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P6 · Release Hygiene
R1 · Type Safety
- 0 typed · 61 plain JS — the untyped files are assets/salad_ui/components/accordion.js, assets/salad_ui/components/chart.js, assets/salad_ui/components/collapsible.js, assets/salad_ui/components/command.js, assets/salad_ui/components/dialog.js, assets/salad_ui/components/dropdown_menu.js (+55 more).
What to do
- Adopt TypeScript for the frontend: add a typecheck step to the build, then either type-check the existing JavaScript in place (`checkJs`/JSDoc types) or convert the highest-traffic modules first — no file is typed today, so this is an adoption, not a clean-up.
R10 · Code Duplication
- assets/salad_ui/components/hover-card.js:86 · assets/salad_ui/components/popover.js:59 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same names written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents. — hover-card.js:86
- assets/salad_ui/components/hover-card.js:35 · assets/salad_ui/components/tooltip.js:47 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same names written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents. — hover-card.js:35
- assets/salad_ui/components/dropdown_menu.js:36 · assets/salad_ui/components/popover.js:18 — the 2 copies are spread across 2 files, and what repeats is a LIST OF ENTRIES rather than behaviour — the same names written out more than once. Extract them into one shared, exported constant and spread that constant into each site, rather than into a function the sites call: a list like this often lives in declarative metadata (a decorator's options object, a static configuration table) that a build step must be able to read statically, where a function call is not allowed. Adding an entry to one copy and not the other is the failure this prevents. — dropdown_menu.js:36
- assets/salad_ui/components/collapsible.js:47 · assets/salad_ui/components/tooltip.js:85 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — collapsible.js:47
- assets/salad_ui/components/hover-card.js:183 · assets/salad_ui/components/tooltip.js:195 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — hover-card.js:183
- assets/salad_ui/components/dropdown_menu.js:91 · assets/salad_ui/components/popover.js:69 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — dropdown_menu.js:91
- assets/salad_ui/components/hover-card.js:9 · assets/salad_ui/components/tooltip.js:8 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — hover-card.js:9
- assets/salad_ui/core/positioner.js:217 · assets/salad_ui/core/scroll-manager.js:148 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — positioner.js:217
What to do
- Extract the duplicated blocks into shared functions/components.
R2 · Cyclomatic Complexity
- Branch-heavy code is where defects cluster — extract decisions into smaller functions. (×8) — toast.js:818, collection.js:62, positioner.js:105, …
R3 · Large Files
- 3 file(s) over 400 lines (counted as significant lines — blank lines excluded — over production source only, tests excluded), largest first: assets/salad_ui/components/toast.js (807), assets/salad_ui/core/component.js (557), assets/salad_ui/components/select.js (504).
What to do
- Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
R4 · Test Coverage
- No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×2) — app.js, storybook.js
What to do
- Add tests that import the unreached modules (directly or through their public entry).
R5 · Dependency Freshness
R6 · Tooling
- test ✓ · lint ✓ · typecheck ✗
What to do
- Add type checking (adopt TypeScript, or type-check the existing JavaScript with `checkJs`) as package.json scripts and run them in CI.
R7 · Dead Code
- 3 file(s) (~228 LoC) were excluded from dead-code analysis. This package's entry point(s) resolved, but the walk stopped one hop in: storybook/assets/js/app.js imports '../vendor/topbar', which is not in the scanned tree. That is usually a generated or build-output module, so reachability cannot see past it and no dead-code claim is made about this package. Nothing is necessarily wrong here. — assets
R8 · Dependency Hygiene
- Imported but not declared in any reachable package.json — installs work only by hoisting accident. — chart.js:4
- Declared in storybook/assets/package.json but never imported anywhere in that package or its workspace members — dead weight and attack surface. Verify against build tooling before removing.
What to do
- Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
R9 · Circular Imports
Reference — by lens
| Lens | Score | Rating | Impact |
|---|---|---|---|
| Code Health | 59% | Adequate — gated by R1 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Architecture | 99% | Exemplary | Strongest area. |
| Maturity | 68% | Adequate — gated by D16 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Readiness | 51% | Adequate — gated by D13 | Capped at Fair by a Critical contributor — resolve it before relying on this lens. |
| Security | 83% | Strong | Solid. |
Not included — 72 check(s) not relevant to this codebase
- AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
- AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
- AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
- AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
- AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
- AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
- AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
- AX1 Captive dependencies — no DI registrations detected
- AX10 Code composition — not assessed — code composition is computed by ROLE over a document set that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX2 Stateful singletons — no singleton implementations detected
- AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX7 Slice cohesion — not applicable — not a vertical-slice architecture
- AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
- AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
- C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- D10 Test Quality — ~3292 lines of test source are present (.exs, .mjs) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
- D11 Test Reliability — Test reliability not included
- D12 Dependency Hygiene — Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
- D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (package.json), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
- D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
- D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
- D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
- D22 Internal API Consistency — No exposed public API
- D23 Boundary Type-Coupling — Production source is present (.ex, .exs) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
- D24 Comment Value — No inline comments to assess — comment value is not applicable here.
- D25 ADR Conformance — no ADRs to check
- D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
- D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
- D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (package.json — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
- D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
- D36 Supply-chain Provenance & Signing — The CI pipeline builds and tests but publishes no released artifact — no package publish, container push, GitHub release or deployment step. Supply-chain provenance, signing and SBOM attest RELEASED artifacts, so there is nothing to attest here. Add them to the release pipeline when this repo starts shipping artifacts (a published package, a container image, a deployed service or a tagged release).
- D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
- D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
- D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
- D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
- D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
- D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
- D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .ex, .exs, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
- D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
- D8 Code Coverage — Coverage not included — suite not readable by the collector
- D9 Test Distribution — Test source is present (.exs, .mjs) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
- DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this check looks for (1 value object(s))
- ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
- ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
- ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
- GD1 Unfinished & placeholder code — no source files
- IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
- P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
- P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
- P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
- P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (lcov — `mix test --cover` with `excoveralls` (`mix coveralls.lcov`)) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
- PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
- PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
- PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
- R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
- S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
- SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
- X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
- X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
Appendix A — Findings (grouped)
Issue — 11 finding(s)
- High CVE: [GHSA redacted] assets/package-lock.json
- High CVE: [GHSA redacted] assets/package-lock.json
- High CVE: [GHSA redacted] assets/package-lock.json
- High CVE: [GHSA redacted] assets/package-lock.json
- High CVE: [GHSA redacted] assets/package-lock.json
- High CVE: [GHSA redacted] assets/package-lock.json
- Leaked secret: high-entropy-secret storybook/config/test.exs:20
- Leaked secret: high-entropy-secret storybook/config/dev.exs:26
- High: github-actions-mutable-action-tag .github/workflows/sobelow.yml:35
- High: github-actions-mutable-action-tag .github/workflows/sobelow.yml:39
- High IaC: DS-0029 storybook/Dockerfile
Warning — 16 finding(s)
- Medium CVE: EEF-[CVE redacted] storybook/mix.lock
- Medium CVE: EEF-[CVE redacted] storybook/mix.lock
- Medium CVE: EEF-[CVE redacted] storybook/mix.lock
- Medium CVE: [GHSA redacted] assets/package-lock.json
- FileTooLong: salad_ui/sidebar.ex lib/salad_ui/sidebar.ex:0
- FileTooLong: components/toast.js assets/salad_ui/components/toast.js:0
- Medium IaC: DS-0013 storybook/Dockerfile
- Medium IaC: CKV_DOCKER_2 storybook/Dockerfile:1
- onPointerMove (cyclomatic 16) assets/salad_ui/components/toast.js:818
- Hotspot: assets/salad_ui/components/toast.js assets/salad_ui/components/toast.js
- getItem (cognitive 18) assets/salad_ui/core/collection.js:62
- onPointerMove (cognitive 18) assets/salad_ui/components/toast.js:818
- Change coupling: collapsible.ex ↔ sidebar.ex lib/salad_ui/collapsible.ex
- Duplicated block (37 lines × 2) storybook/storybook/salad_ui_component/hover_card.story.exs:86
- Duplicated block (18 lines × 2) storybook/storybook/salad_ui_component/badge.story.exs:16
- Duplicated block (16 lines × 2) lib/mix/tasks/salad.install.ex:205
Recommendation — 4 finding(s)
- Test reliability not included
- Off-boarding risk: anonymized user #1
- Further sole-owners (lower concentration)
- Coverage not included — suite not readable by the collector
Info — 2 finding(s)
- Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
- No exposed public API
Appendix B — Reproduction & audit trail
| Dimension | Tool | Version | Command | Findings | Raw output |
|---|---|---|---|---|---|
| D28 · Secrets (history) | gitleaks | — | gitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source . | 0 | artifacts/raw/gitleaks-history.json |
| D29 · Static Analysis (SAST) | semgrep | — | semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --json --quiet --timeout 0 --metrics off . | 2 | artifacts/raw/semgrep.json |
| D30 · Dependency Vulnerabilities | none (no readable dependency manifest) | — | none (no readable dependency manifest): not present in this environment | 0 | — |
| D31 · IaC & Container Security | trivy | — | trivy config --format json --quiet . | 4 | artifacts/raw/trivy-config.json |
| D32 · Data Compliance (PII/GDPR) | semgrep | — | semgrep: not applicable — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess. | 0 | — |
| D33 · JS/npm Dependency Vulnerabilities | trivy | — | trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update | 0 | — |
| D36 · Supply-chain Provenance & Signing | provenance | — | provenance: not applicable — The CI pipeline builds and tests but publishes no released artifact — no package publish, container push, GitHub release or deployment step. Supply-chain provenance, signing and SBOM attest RELEASED artifacts, so there is nothing to attest here. Add them to the release pipeline when this repo starts shipping artifacts (a published package, a container image, a deployed service or a tagged release). | 0 | — |
| D37 · Vulnerability-disclosure Policy | disclosure | — | disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed. | 0 | — |
| D38 · OSV Dependency Vulnerabilities | osv-scanner | — | osv-scanner --format json --recursive . | 10 | artifacts/raw/osv-scanner.json |
| D40 · Network Egress Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here. | 0 | — |
| D41 · Kernel & Syscall Confinement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here. | 0 | — |
| D42 · Runtime Threat Enforcement | runtime-hardening | — | runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here. | 0 | — |