# Changelog

## Score

- CAI 64 → 60 (-4.1)
- Rubric changed (rubric-2026.10.1 → rubric-2026.10.5) — scores are not directly comparable.

## Lenses

- Code Health 100 → 76 (-24.3)
- Architecture 69 → 69 (+0.0)
- Maturity 67 → 57 (-9.5)
- Readiness 54 → 54 (+0.0)
- Security 89 → 88 (-1.3)

## Resolved (2)

- Ambiguous naming convention. `scan?` typically implies a boolean check (is scanning?), while `scan` implies an action (start scanning). However, without documentation, it is unclear if `scan?` is a getter for the scanning state or a deprecated/alias method. If `scan?` is a getter, it should likely be `scanning?` or `scan_enabled?` to distinguish from the action `scan`.
- Workflow token permissions not restricted

## New (6)

- Ambiguous naming convention. `scan?` typically implies a predicate (boolean check) in Ruby conventions, while `scan` implies an action. However, without documentation, it is unclear if `scan?` checks if scanning is active or if it triggers a scan. If `scan?` is a predicate, it duplicates the intent of checking state which might be better served by `enabled?` or a specific `scanning?` method. If it triggers a scan, the `?` suffix is misleading.
- High CVE: [GHSA redacted] (Gemfile.lock)
- Inconsistent verb usage for state toggles. `start_raise`/`stop_raise` use imperative verbs, while `raise?` is a predicate. This is a minor inconsistency but `raise?` likely checks the state of the `raise` property, whereas `start_raise`/`stop_raise` modify it. The naming `start_raise` is slightly awkward compared to `enable_raise` or `set_raise(true)`.
- Orphaned file (lib/prosopite.rb)
- Orphaned files with no living knowledge
- Workflow token permissions not restricted (.github/workflows/ci.yml)
