Public report — orleans, published 23 Sep 2026.
Concrete security findings (which rule fired, in which file, on which line; CVE IDs, secret matches,
dependency versions) are REDACTED in this version; ask the repo owner for the full report.
Public
Codebase surveyMeasured under the Code Assurance Index · rubric rubric-2026.09.15 (frozen) · verify this surveyFiledcd_7ff4d5c7729f42d38c7e69d66b3c756a
Filed 25 September 2026, 05:09 UTC
Public
Large · 229,312 LoC · 293 projects · rebuild ~9.5 person-years · weakest lens: Accessibility (45%)
Findings by grade
196 critical1523 serious444 minor1 could not be resolved — could be critical — see Limitations
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
23 September 2026, 02:49 UTC
A measurement, not a certificate. The Code Assurance Index does not certify,
approve or guarantee this codebase; it records a reproducible number and the evidence it was computed from. The
standard is authored by Canine Development, who also build Watchdog — its only implementation today. That is said
here so the number is checked rather than believed.
Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸
1948findings with an exact file:lineof 2163 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
95/130dimensions across the health lenses229312 LoC · 293 projects — wide & deep
The platform holds an adequate overall standing of 54%, reflecting a large, complex asset that is functional but carries significant operational risk. With nearly 230,000 lines of production code and a rebuild cost estimated at €1.4 million, the system represents a substantial investment. However, its current state suggests that while the core logic is stable, critical gaps in user experience and compliance threaten long-term viability and regulatory exposure.
The most pressing issue is accessibility, which scores a low 45%. For a system of this magnitude, this is not merely a technical debt item but a direct business liability. Poor accessibility exposes the organization to legal risk, excludes a significant portion of users, and damages brand reputation. Remediation here offers the highest protection for the asset’s value, ensuring that the platform remains usable and compliant for all stakeholders. Ignoring this lens means the system, despite its size, fails to serve its full audience effectively.
A secondary concern is the fragmented operational readiness, indicated by a 66% score. The system lacks robust testing coverage and clear documentation, making it difficult for new teams to onboard or for existing teams to maintain stability. This ambiguity increases the cost of change and the likelihood of defects slipping into production. Without improved observability and standardized practices, every modification carries a higher risk of unintended side effects, slowing delivery speed and increasing support costs.
On the positive side, the architecture is relatively strong at 79%, and the codebase contains a healthy proportion of branching logic, indicating sophisticated business rules are well-implemented. The foundation is solid, but it is undermined by surface-level failures. To maximize leverage, the immediate focus must be on making custom controls keyboard-operable and ensuring all interactive elements have proper labels. These specific actions address the highest-impact risks with minimal effort, providing quick wins that significantly reduce exposure and improve user trust without requiring a full system overhaul.
How the score is built — each lens's share of the headlineWidth is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Business logic 16%Plumbing 22%Tests 59%Generated 0%Analyzers 3%
New since the last scan (100+)
1113 finding(s) are new versus the previous scan (2026-08-05) — surfaced by this scheduled scan itself, no pull request required. Showing the first 100; the full set is in the report.
A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.
Rebuild cost & value ~ Modeled — €460,000–€2,300,000
0.7× (at 54% quality) — the last 20% of quality is most of the work
Size & shape
Large · effort split not classified for 11,483 line(s) outside the .NET model (the tier breakdown is a C#-only syntax walk)
This codebase represents roughly ~9.5 person-years of build effort (about ~€1,400,000 to rebuild). Its weakest lens is Accessibility at 45% — the part of that asset most exposed by the findings below.
How we model this: boilerplate at a scaffolding rate + logic × domain Very high (×1.9) — microservices, CQRS, event-driven integration, high decision density × a 0.7× quality factor, at €60–95/h; indicative, ±~30%. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).
Top priorities
The highest-leverage moves; the full ranked list is in the Roadmap below.
1
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Value concentrated against a weak lens · REDACTED · Value at risk
This is a Large asset (~9.5 person-years to rebuild), and its weakest lens is Accessibility at 45%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
→ Direct remediation budget at Accessibility first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · REDACTED · Leverage
Of everything flagged, the best return on effort is: Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Architecture — bounded-context dependency graph
Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.
Architecture — module dependency matrix
Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)
268 modules, 562 dependencies. 8 dependency cycles across 84 modules, marked above the diagonal.
Showing the 40 most-connected modules; 228 more are not drawn.
Module dependency matrix. The row depends on the column; the number is how many type pairs create the dependency. A cell above the diagonal is part of a dependency cycle.
Metadata uses Configuration. Changing Configuration can break Metadata, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
5→24 Providers.Streams.Common depends on Streamscycle✕
Type pairs
41 distinct (type in Providers.Streams.Common → type in Streams) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Runtime.ConsistentRing uses Runtime. Changing Runtime can break Runtime.ConsistentRing, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
7→2 Serialization.Codecs depends on Serialization.WireProtocol✕
Type pairs
76 distinct (type in Serialization.Codecs → type in Serialization.WireProtocol) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization.Codecs uses Serialization.WireProtocol. Changing Serialization.WireProtocol can break Serialization.Codecs, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
7→13 Serialization.Codecs depends on Serialization.Serializerscycle✕
Type pairs
33 distinct (type in Serialization.Codecs → type in Serialization.Serializers) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization.Codecs uses Serialization.Serializers. Changing Serialization.Serializers can break Serialization.Codecs, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
7→16 Serialization.Codecs depends on Serialization.Cloningcycle✕
Type pairs
148 distinct (type in Serialization.Codecs → type in Serialization.Cloning) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization.Codecs uses Serialization.Session. Changing Serialization.Session can break Serialization.Codecs, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
7→20 Serialization.Codecs depends on Serialization.Bufferscycle✕
Type pairs
143 distinct (type in Serialization.Codecs → type in Serialization.Buffers) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Runtime.GrainDirectory uses Metadata. Changing Metadata can break Runtime.GrainDirectory, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
11→25 Runtime.GrainDirectory depends on Runtimecycle✕
Type pairs
63 distinct (type in Runtime.GrainDirectory → type in Runtime) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Streaming.EventHubs uses Providers.Streams.Common. Changing Providers.Streams.Common can break Streaming.EventHubs, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
14→24 Streaming.EventHubs depends on Streamscycle✕
Type pairs
56 distinct (type in Streaming.EventHubs → type in Streams) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Runtime.MembershipService uses Core.Diagnostics. Changing Core.Diagnostics can break Runtime.MembershipService, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
15→25 Runtime.MembershipService depends on Runtimecycle✕
Type pairs
78 distinct (type in Runtime.MembershipService → type in Runtime) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
27 distinct (type in Runtime.Placement → type in Runtime) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization uses Serialization.TypeSystem. Changing Serialization.TypeSystem can break Serialization, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
21→13 Serialization depends on Serialization.Serializers✕
Type pairs
31 distinct (type in Serialization → type in Serialization.Serializers) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization uses Serialization.Serializers. Changing Serialization.Serializers can break Serialization, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
21→16 Serialization depends on Serialization.Cloning✕
Type pairs
46 distinct (type in Serialization → type in Serialization.Cloning) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Serialization uses Serialization.Session. Changing Serialization.Session can break Serialization, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
21→20 Serialization depends on Serialization.Buffers✕
Type pairs
46 distinct (type in Serialization → type in Serialization.Buffers) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Messaging uses Orleans. Changing Orleans can break Messaging, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
29→9 Transactions depends on Transactions.Abstractions✕
Type pairs
45 distinct (type in Transactions → type in Transactions.Abstractions) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
70 distinct (type in Runtime.Messaging → type in Runtime) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Runtime.MembershipService.SiloMetadata uses Runtime.MembershipService. Changing Runtime.MembershipService can break Runtime.MembershipService.SiloMetadata, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
37→25 Runtime.MembershipService.SiloMetadata depends on Runtime✕
Type pairs
4 distinct (type in Runtime.MembershipService.SiloMetadata → type in Runtime) references.
26 distinct (type in Runtime.ReminderService → type in Orleans) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Dashboard.Implementation.Grains uses Runtime.MembershipService.SiloMetadata. Changing Runtime.MembershipService.SiloMetadata can break Dashboard.Implementation.Grains, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A02:2021 — Cryptographic Failures
9
REDACTED / Critical
A03:2021 — Injection
9
REDACTED / Critical
A06:2021 — Vulnerable & Outdated Components
1
REDACTED / Critical
Roadmap
First, ensure all interactive elements are fully keyboard-operable and every form control has a proper programmatic label. Next, enforce accessibility standards by integrating linting and automated testing into the development toolchain. Finally, solidify the foundation by correcting page structure, maintaining visible focus styles, and ensuring sufficient color contrast and motion safety.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Enforce authorization at every handler — call the guard method (throw-on-violation) from each one, or adopt [Authorize] so protected-by-default is demonstrable.
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 196
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 1523
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 444
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 1
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 88 of 95 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 7 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 95 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1948 of 2163 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 7,874 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 18 test source file(s) (.ts, .fs, .mjs) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: this repository's test suite spans .NET and JavaScript/TypeScript, and the JavaScript/TypeScript half could not be re-run — unit: not included — too large to re-run within its budget; integration: measured (0 flaky); other: not included — too large to re-run within its budget; JavaScript/TypeScript (vitest via `npm ci --ignore-scripts` in docs/site/): not included — the dependency install for docs/site/ could not reach packagefeedproxy.microsoft.io, which the analyzer sandbox's egress allowlist does not carry (npm error 403 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/@astrojs%2fmarkdown-remark), so the suite never ran. No partial figure is published as if it were the whole: reliability is excluded from the score rather than counted as a near-zero.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability for the vitest suite in docs/site/ was NOT MEASURED: the dependency install for docs/site/ could not reach packagefeedproxy.microsoft.io, which the analyzer sandbox's egress allowlist does not carry (npm error 403 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/@astrojs%2fmarkdown-remark), so the suite never ran. This is OUR limitation, not a defect in the repository, and the suite is excluded from the measurement rather than counted against it.
D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A scan analyzes ONE solution. Every score, lens, and finding here reflects only `Orleans.slnx`; 29 further solution(s) found in this tree (`docs/Docs.slnx`, `docs/site/src/content/docs/grains/snippets/transactions/transactions.sln`, `docs/site/src/content/docs/host/snippets/snippets.sln`, `docs/site/src/content/docs/quickstarts/snippets/hello-world/OrleansHelloWorld.slnx`, `docs/site/src/content/docs/streaming/snippets/broadcastchannel/broadcastchannel.sln`, `samples/Adventure/Adventure.sln`, +23 more) are not covered by it, were not analyzed, and are not represented in the headline. (This is a count of the solutions discovery found and could not show to be covered by the analyzed one — not a claim about how many solution files the repository contains.) If one of them is an archived or vendored tree, declaring it — `.gitattributes` (`path/** linguist-vendored`) or `.editorconfig` (`[path/**] generated_code = true`) — excludes it from discovery the same way generated code is. You can widen what we reach: scan each solution separately.
D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. At 261767 LoC across 293 projects this is a massive multi-module system that far exceeds both the size and project-count thresholds for needing explicit bounded contexts. Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D30 Dependency Vulnerabilities — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan. 2 of 3 declared ecosystem(s) (npm,osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `docs/site/scripts/audit-links.mjs`, `docs/site/scripts/audit-output.mjs`, `docs/site/scripts/generate-legacy-redirects.mjs`, `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, … (+331 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D39 IL Efficiency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. `dotnet build` exited 1 with a compiler/MSBuild diagnostic, so there were no assemblies to read IL from. The build itself is D18's row, with the ask; nothing further is charged here.
D43 Malicious Dependencies — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan. 2 of 3 declared ecosystem(s) (npm,osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
AX2 Stateful singletons — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 17 further occurrence(s) are not listed individually; the score already reflects all 57.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 56 further occurrence(s) are not listed individually; the score already reflects all 96.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 446 further occurrence(s) are not listed individually; the score already reflects all 486.
Package restore incomplete — third-party types were unresolved in part of the solution — NuGet restore did not complete for playground/ActivationSheddingToy/ActivationSheddingToy.csproj, playground/ActivationRebalancing/ActivationRebalancing.AppHost/ActivationRebalancing.AppHost.csproj, playground/ActivationRebalancing/ActivationRebalancing.Cluster/ActivationRebalancing.Cluster.csproj, playground/ActivationRebalancing/ActivationRebalancing.Frontend/ActivationRebalancing.Frontend.csproj, playground/ActivationRepartitioning/ActivationRepartitioning.AppHost/ActivationRepartitioning.AppHost.csproj and 147 more, so those projects were analysed with framework references only: every check keyed on a third-party type saw an error type there and reported nothing. Findings on those projects are a lower bound; run `dotnet restore` on them and rescan.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (7): D19, D21, D22, D24, D26, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
123 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was JournaledStateManager.WorkLoop at 59. A further 7 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Identifier.IsCSharpKeyword at 103 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs (Identifier.IsCSharpKeyword at 103), src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs (TransactionRecoveryEventObserver.TryCreateTransition at 67), src/Orleans.Reminders.TestKit/ReminderServiceTestRunner.cs (ReminderServiceTestRunner.RunReminderService_UpdateReplacesScheduleAndETagWithoutDuplicate at 38), src/Orleans.Reminders.TestKit/ReminderTableModelBasedTestRunner.cs (ReminderTableBehavioralSpec.CanApply at 19), src/Orleans.Core/Caching/Internal/TypeProps.cs (TypeProps.IsWriteAtomicPrivate at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 117 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) finding(s) in Cyclomatic Complexity — start with IDeepCopier.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 JournaledStateManager.WorkLoop (cyclomatic 59) finding(s) in Cyclomatic Complexity — start with JournaledStateManager.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 ActivationData.RunMessageLoop (cyclomatic 51) finding(s) in Cyclomatic Complexity — start with ActivationData.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 264 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) finding(s) in Cognitive Complexity — start with OrleansGeneratedCodeHelper.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 JournaledStateManager.WorkLoop (cognitive 195) finding(s) in Cognitive Complexity — start with JournaledStateManager.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 PersistentStreamPullingAgent.RunConsumerCursor (cognitive 82) finding(s) in Cognitive Complexity — start with PersistentStreamPullingAgent.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.3 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 64 TooManyMethods finding(s) in God Classes — start with Serializer.cs (2), ActivationData.cs, LocalReminderService.cs. — One of this dimension's main actionable groups (64 warning-level).
Resolve the 32 FileTooLong finding(s) in God Classes — start with ActivationData.cs, docfx.mjs, GrainInterfaceVersionCodeFix.cs. — One of this dimension's main actionable groups (32 warning-level).
Resolve the 22 MethodTooLong finding(s) in God Classes — start with TransactionRecoveryTestsRunner.cs (2), ActivationData.cs (2), JournaledStateManager.cs. — One of this dimension's main actionable groups (22 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
352 duplicated block group(s) detected. A further 29 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 39 of the 381 are in trees this repository does not ship — vendored, example/demo, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×14src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102
+ 124 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 22 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with TupleCodec.cs (7), GenerateSerializationAttributesCodeFix.cs, MetadataAggregateModelBuilder.cs. — One of this dimension's main actionable groups (22 warning-level).
Resolve the 19 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with TupleCodec.cs (2), ArcBufferWriter.cs (2), GrainInterfaceVersionAnalyzer.cs. — One of this dimension's main actionable groups (19 warning-level).
Resolve the 19 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with TupleCodec.cs (3), InvokableBaseTypeResolver.cs (2), ProxySourceOutputGenerator.cs. — One of this dimension's main actionable groups (19 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling9.8 / 10Stronggated by 9 serious findings✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
Off the main sequence: ChaoticCluster.ServiceDefaults · ×9
What to do
Resolve the 9 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (9 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 5 Low cohesion finding(s) in Cohesion (LCOM4) — start with MessagingProcessingInstruments.cs, SiloControl.cs, SiloGrainService.cs. — One of this dimension's main actionable groups (5 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
15930 test methods: 14316 unit, 1614 integration, 0 BDD, 0 e2e. The JavaScript/TypeScript suite contributes 189 `it`/`test` case(s) across 13 test file(s) declaring at least one beside 15741 .NET test method(s); its tier split is read from package names and paths only.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality9.8 / 10Adequategated by 7 critical findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
46 skipped (20 with a documented reason), 62 zero-assertion, 7 synchronised by a fixed sleep, 7 mock references across 7874 tests. Measured on the C# suite only — at least 18 test source file(s) (.ts, .fs, .mjs) went unread, so its test quality is unmeasured and is not in these counts.
No assertions (empty test): RemindersTable_MySql_Init · ×7test/Extensions/Orleans.AdoNet.Tests/Reminders/MySqlRemindersTableTests.cs:59
No assertions: MembershipTable_ModelBased_GeneratedConformance · ×55test/Orleans.Core.Tests/Membership/SystemTargetMembershipTableConformanceTests.cs:36
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 7 No assertions (empty test) finding(s) in Test Quality — start with MySqlRemindersTableTests.cs, PostgreSqlRemindersTableTests.cs, SqlServerRemindersTableTests.cs. — One of this dimension's main actionable groups (7 issue-level).
Resolve the 55 No assertions finding(s) in Test Quality — start with TestClusterTests.cs (9), ReminderServiceLifecycleTestsBase.cs (8), MemoryGrainStorageTests.cs (3). — One of this dimension's main actionable groups (55 warning-level).
Resolve the 26 Skipped test finding(s) in Test Quality — start with ElasticPlacementTest.cs (4), ReentrancyTests.cs (3), ProgrammaticSubscribeTestsRunner.cs (2). — One of this dimension's main actionable groups (26 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
0 outdated, 0 vulnerable, 0 deprecated packages. Those are the NuGet packages; this repository's npm dependencies were read too — 174 outdated of 591 package(s) across 2 lockfile(s).
Outdated (npm): @antfu/install-pkg · ×174
What to do
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 2 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Enforce REDACTED Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 344 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 177 direct `PackageReference`(s), and 151 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs (18×40=720); src/Orleans.Runtime/Catalog/ActivationData.cs (11×51=561); src/Orleans.Journaling/JournaledStateManager.cs (6×59=354) Repeated repair below the complexity floor: src/Orleans.Reminders/ReminderService/LocalReminderService.cs (15 of 20 changes were fixes); src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs (8 of 14 changes were fixes); src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs (8 of 11 changes were fixes)
Resolve the 83 Hotspot finding(s) in Churn × Complexity Hotspots — start with PersistentStreamPullingAgent.cs, ActivationData.cs, JournaledStateManager.cs. — One of this dimension's main actionable groups (83 warning-level).
Resolve the 28 Repeated repair finding(s) in Churn × Complexity Hotspots — start with LocalReminderService.cs, GrainDirectoryPartition.cs, DistributedGrainDirectory.cs. — One of this dimension's main actionable groups (28 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor7.4 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
288 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/Orleans.Reminders/ReminderService/LocalReminderService.cs. Counted over 1119 of the 2005 production source files in this repository: 880 are under the ~2,400-byte size floor this dimension measures over, and the remaining 6 have no attributable history left to measure.
Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)
What to do
Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
NoWarnInCsproj repeated across 13 filestest/Orleans.Journaling.Tests/Orleans.Journaling.Tests.csproj:11
+ 12 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 110 WriteOnlyPrivateField finding(s) in Explicit Debt — start with DefaultCacheMonitor.cs (11), DirectoryInstruments.cs (6), DefaultBlockPoolMonitor.cs (5). — One of this dimension's main actionable groups (110 issue-level).
Resolve the 36 EmptyCatchBlock finding(s) in Explicit Debt — start with TestClusterPortAllocator.cs (4), DashboardHost.cs (3), ActivationData.cs (3). — One of this dimension's main actionable groups (36 issue-level).
Resolve the 11 NoWarnInCsproj finding(s) in Explicit Debt — start with Orleans.Serialization.csproj, Microsoft.Orleans.Templates.csproj, Orleans.Sdk.csproj. — One of this dimension's main actionable groups (11 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
293 projects, 7580 source files, 568757 hand-written lines of code (261767 production / 306990 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 691 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 827 inter-project edges (build status unknown — did not finish).
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
The repository is well documented with a strong README and architecture/Docs markdown set. The README covers the Orleans framework's purpose, grain model, samples, distributed tests, project templates, and serialization guidance, while architecture/Docs files document runtime features like clustering, persistence, streaming, and testing projects. XML-doc coverage (0-100%) is high for Orleans.Serialization.* but low for most assemblies, reflecting a focused documentation effort on the serialization layer. The Orleans serialization family is well documented with READMEs for each test/serializer package (e.g. SystemTextJson, Newtonsoft.Json, MessagePack, F#), covering installation, a runnable example, and cross-package references plus links to the main Orleans docs. The repository-wide overview is sparse but present: the XML-doc coverage shows 0% for most serialization packages, while the READMEs are complete within their own scope. The Orleans project is well documented with comprehensive READMEs for each major package (Runtime, Reminders.TestKit, Persistence.TestKit, Journaling, Event Sourcing, Durable Jobs) covering installation, usage examples, architecture overview, and contribution guidance. The XML-doc coverage is low (<10%) but the visible documents are complete per their outlines: no missing-overview, no missing-installation, no missing-usage, and all four contributing categories (missing license, missing architecture docs, internal-focused, outdated) are absent from the visible text. The Orleans.Core.Abstractions README is exemplary: it states what the package is (core abstractions for grains and client code), gives a one-line install command, shows an example defining a grain interface with IGrainWithStringKey, and links to comprehensive external documentation plus contribution channels. The accompanying architecture/Docs markdown files cover the full suite of Orleans subsystems, while XML-doc coverage reflects the package's own internal API surface.
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
0 naming inconsistencies across 200 sampled symbols.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md.
Do you agree with this assessment?
D22 · Internal API ConsistencyExemplary◐ Sampled · advisory
What it measures: Whether the internal API surface is consistent and coherent.
Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
76 % of calls cross a namespace and 4 % go through an interface, but 99 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged REDACTED. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
6 finding(s): 0 critical, 6 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
REDACTED
What to do
Resolve the 4 REDACTED secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
9 finding(s): 0 critical, 3 high, 6 medium, 0 low. semgrep hit a parse error in 388 file(s) — `docs/site/scripts/audit-links.mjs` (line 10), `docs/site/scripts/audit-output.mjs` (line 4, line 5, line 6), `docs/site/scripts/generate-legacy-redirects.mjs` (line 4, line 5, line 6), `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs` (lines 9–10, line 11), … (+383 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 314 of those file(s) — `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansStatelessService.cs`, `docs/site/src/content/docs/grains/journaling/snippets/journaling/JournalingBasics.cs`, `docs/site/src/content/docs/grains/journaling/snippets/redis-journaling/Program.cs`, `docs/site/src/content/docs/grains/snippets/interceptors/GrainFactoryInjection.cs`, … (+309 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 26 of those file(s) — `docs/site/src/content/docs/grains/journaling/snippets/redis-journaling/Program.cs`, `docs/site/src/content/docs/grains/snippets/placement/CustomPlacement.cs`, `docs/site/src/content/docs/grains/snippets/placement/CustomPlacementFilter.cs`, `docs/site/src/content/docs/snippets/compiled/Grains/RequestsAndVersioningSnippets.cs`, `docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs`, … (+21 more) — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 7 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
What to do
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir/Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex, Go, Java and Kotlin via Maven/Gradle, npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Partial dependency scan: 2 of 3 declared ecosystem(s) were scanned (npm,osv), and the findings above are real and complete for them. nuget was not scanned (nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan), so this is not the whole dependency surface and the result is reported at reduced confidence.
REDACTED
What to do
Resolve the 1 REDACTED CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
83 of 1125 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Orleans.Core/Runtime/RingRange.cs. Counted over 1125 of the 2005 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Orphaned files with no living knowledge
✓ On the Gold path — maintain.
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 6 Change coupling finding(s) in Change Coupling — start with ConsistentRingProvider.cs, SerializableTypeDescription.cs, SimpleQueueCache.cs. — One of this dimension's main actionable groups (6 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
No known-vulnerable dependencies in the 2 ecosystem(s) that were scanned (npm,osv). Partial dependency scan: 2 of 3 declared ecosystem(s) were scanned (npm,osv), and the findings above are real and complete for them. nuget was not scanned (nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan), so this is not the whole dependency surface and the result is reported at reduced confidence.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 200 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
Do you agree with this assessment?
AC2 · Forms & labels5.2 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label. (×7) — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:109, src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:119, src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:130, …
This control has no associated label. Add a <label htmlFor> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:69
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×3) — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:2, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:2, playground/DurableJobsJournaling/DurableJobsJournaling.Web/wwwroot/index.html:2
The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). — src/Dashboard/Orleans.Dashboard.App/index.html:2
user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta. — src/Dashboard/Orleans.Dashboard.App/index.html:7
A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). — src/Dashboard/Orleans.Dashboard.App/src/components/grain-method-table.tsx:42
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: interactive elements plus elements the markup gives a click/key handler or the repo's own CSS styles `cursor: pointer`, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler. (×5) — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:178, src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:189, src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:203, …
An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. — src/Dashboard/Orleans.Dashboard.App/src/logstream/log-stream.tsx:129
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This stylesheet animates but never checks prefers-reduced-motion, so motion-sensitive users can't opt out. Wrap motion in @media (prefers-reduced-motion: no-preference). — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:8
`.absolute-button` sets color: white on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:15
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Do you agree with this assessment?
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified
Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.
Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.
Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.
No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 37 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
What to do
Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with vitest-axe in tests, then gate axe/pa11y/Lighthouse in CI.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
`DhtGrainLocator` is registered as a SINGLETON but its constructor takes `IGrainContext grainContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGrainContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Orleans.Runtime/GrainDirectory/DhtGrainLocator.cs:15
What to do
Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`ClusterDiagnosticsService` is a singleton (one shared instance) but mutates instance state outside any lock (_version; e.g. `_version` at line 25). — playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:7
`LoadDriver` is a singleton (one shared instance) but mutates instance state outside any lock (_enabled, _startedAt; e.g. `_enabled` at line 22). — playground/DurableJobsJournaling/DurableJobsJournaling.Web/LoadDriver.cs:7
`EnvironmentStatisticsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_maximumAvailableMemoryBytes, _availableMemoryBytes; e.g. `_maximumAvailableMemoryBytes` at line 70). — src/Orleans.Core/Statistics/EnvironmentStatisticsProvider.cs:11
`GrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 341). — src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:286
`UntypedGrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 143). — src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:105
`SocketSchedulers` is a singleton (one shared instance) but mutates instance state outside any lock (nextScheduler; e.g. `nextScheduler` at line 33). — src/Orleans.Core/Networking/Shared/SocketSchedulers.cs:6
`GatewayManager` is a singleton (one shared instance) but mutates instance state outside any lock (gatewayListProviderInitialized, roundRobinCounter, knownGateways, cachedLiveGateways, cachedLiveGatewaysSet, lastRefreshTime; e.g. `gatewayListProviderInitialized` at line 68). — src/Orleans.Core/Messaging/GatewayManager.cs:24
`ClientClusterManifestProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 77). — src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:22
`LocalDurableJobManager` is a singleton (one shared instance) but mutates instance state outside any lock (_startTimestamp, _listenForClusterChangesTask, _periodicCheckTask, _totalClaimedShards; e.g. `_startTimestamp` at line 216). — src/Orleans.DurableJobs/LocalDurableJobManager.cs:22
`LocalReminderService` is a singleton (one shared instance) but mutates instance state outside any lock (localTableSequence, localReminders, runTask, initialReadCallCount; e.g. `localTableSequence` at line 395). — src/Orleans.Reminders/ReminderService/LocalReminderService.cs:19
`ReminderRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (serviceProvider; e.g. `serviceProvider` at line 107). — src/Orleans.Reminders/ReminderService/ReminderRegistry.cs:13
`InMemoryReminderTable` is a singleton (one shared instance) but mutates instance state outside any lock (isAvailable; e.g. `isAvailable` at line 88). — src/Orleans.Reminders/ReminderService/InMemoryReminderTable.cs:7
`ActivationRebalancerMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_monitorTimer, _latestReport, _lastHeartbeatTimestamp, _statusListeners; e.g. `_monitorTimer` at line 82). — src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs:16
`ActivationRepartitioner` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCountOffset, _currentExchangeSilo, _enableMessageSampling, _processPendingEdgesTask; e.g. `_activationCountOffset` at line 163). — src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:24
`SystemTargetBasedMembershipTable` is a singleton (one shared instance) but mutates instance state outside any lock (grain, membershipManager; e.g. `grain` at line 38). — src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:14
`MembershipTableSystemTarget` is a singleton (one shared instance) but mutates instance state outside any lock (table; e.g. `table` at line 258). — src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:210
`Watchdog` is a singleton (one shared instance) but mutates instance state outside any lock (_platformWatchdogTimestamp, _cumulativeGCPauseDuration, _platformWatchdogThread, _componentWatchdogTimestamp, _lastComponentHealthCheckTime, _componentWatchdogThread; e.g. `_platformWatchdogTimestamp` at line 53). — src/Orleans.Runtime/Silo/Watchdog.cs:18
`ActivationCollector` is a singleton (one shared instance) but mutates instance state outside any lock (_collectionLoopTask, _memBasedDeactivationLoopTask; e.g. `_collectionLoopTask` at line 673). — src/Orleans.Runtime/Catalog/ActivationCollector.cs:22
`ActivationWorkingSet` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 200). — src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:18
`GrainLocatorResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_clientGrainLocator; e.g. `_clientGrainLocator` at line 38). — src/Orleans.Runtime/GrainDirectory/GrainLocatorResolver.cs:8
`GenericGrainDirectoryResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_resolver; e.g. `_resolver` at line 35). — src/Orleans.Runtime/GrainDirectory/GenericGrainDirectoryResolver.cs:9
`CachedGrainLocator` is a singleton (one shared instance) but mutates instance state outside any lock (listenToClusterChangeTask; e.g. `listenToClusterChangeTask` at line 151). — src/Orleans.Runtime/GrainDirectory/CachedGrainLocator.cs:17
`DeploymentLoadPublisher` is a singleton (one shared instance) but mutates instance state outside any lock (_publishTimer, _lastUpdateDateTimeTicks, LocalRuntimeStatistics; e.g. `_publishTimer` at line 82). — src/Orleans.Runtime/Placement/DeploymentLoadPublisher.cs:20
`MembershipGossiper` is a singleton (one shared instance) but mutates instance state outside any lock (_membershipSystemTarget; e.g. `_membershipSystemTarget` at line 26). — src/Orleans.Runtime/MembershipService/MembershipGossiper.cs:10
`LocalSiloHealthMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_lastDegradationLogTimestamp, _runTask, _isActive; e.g. `_lastDegradationLogTimestamp` at line 620). — src/Orleans.Runtime/MembershipService/LocalSiloHealthMonitor.cs:126
`MembershipAgent` is a singleton (one shared instance) but mutates instance state outside any lock (getUtcDateTime; e.g. `getUtcDateTime` at line 64). — src/Orleans.Runtime/MembershipService/MembershipAgent.cs:18
`MembershipTableCleanupAgent` is a singleton (one shared instance) but mutates instance state outside any lock (_lastDefunctSiloCleanupTime, _cleanupDefunctSiloEntriesUnsupported; e.g. `_lastDefunctSiloCleanupTime` at line 170). — src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs:16
`GrainVersionStore` is a singleton (one shared instance) but mutates instance state outside any lock (IsEnabled; e.g. `IsEnabled` at line 124). — src/Orleans.Runtime/Versions/GrainVersionStore.cs:13
`Catalog` is a singleton (one shared instance) but mutates instance state outside any lock (_siloStatusOracle; e.g. `_siloStatusOracle` at line 353). — src/Orleans.Runtime/Catalog/Catalog.cs:12
`IncomingRequestMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask, _enabled; e.g. `_runTask` at line 50). — src/Orleans.Runtime/Catalog/IncomingRequestMonitor.cs:14
`ClusterManifestProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask, _grainFactory; e.g. `_runTask` at line 670). — src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:21
`ClusterManifestSystemTarget` is a singleton (one shared instance) but mutates instance state outside any lock (_cachedHashSummary, _cachedHashSummaryVersion, _cachedUpdate, _cachedMembershipVersion; e.g. `_cachedHashSummary` at line 54). — src/Orleans.Runtime/GrainTypeManager/ClusterManifestSystemTarget.cs:9
`GrainMigratabilityChecker` is a singleton (one shared instance) but mutates instance state outside any lock (_lastRegeneratedCacheTimestamp; e.g. `_lastRegeneratedCacheTimestamp` at line 57). — src/Orleans.Runtime/Placement/GrainMigratabilityChecker.cs:12
`GrainCallCancellationManager` is a singleton (one shared instance) but mutates instance state outside any lock (_grainFactory; e.g. `_grainFactory` at line 93). — src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:46
`SiloMetadataCache` is a singleton (one shared instance) but mutates instance state outside any lock (negativeCachePeriod, _negativeCache; e.g. `negativeCachePeriod` at line 31). — src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadaCache.cs:13
`ClientStreamingProviderRuntime` is a singleton (one shared instance) but mutates instance state outside any lock (streamDirectory; e.g. `streamDirectory` at line 54). — src/Orleans.Streaming/Providers/ClientStreamingProviderRuntime.cs:10
`TestHooksEnvironmentStatisticsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_currentStats; e.g. `_currentStats` at line 37). — src/Orleans.Runtime/Silo/TestHooks/TestHooksSystemTarget.cs:20
`TestClusterHostTerminator` is a singleton (one shared instance) but mutates instance state outside any lock (_host; e.g. `_host` at line 40). — src/Orleans.TestingHost/TestClusterFatalErrorHandler.cs:35
`DashboardTelemetryExporter` is a singleton (one shared instance) but mutates instance state outside any lock (_metrics; e.g. `_metrics` at line 113). — src/Dashboard/Orleans.Dashboard/Implementation/DashboardTelemetryExporter.cs:14
`GrainProfiler` is a singleton (one shared instance) but mutates instance state outside any lock (_timer, _siloAddress, _dashboardGrain, _isEnabled; e.g. `_timer` at line 47). — src/Dashboard/Orleans.Dashboard/Metrics/GrainProfiler.cs:19
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. Deterministic, type-level.
`IGrainFactory` declares 17 members under just 3 distinct name(s): `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `CreateObjectReference`, `DeleteObjectReference`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Orleans.Core.Abstractions/Core/IGrainFactory.cs:47
`IMembershipTable` declares 16 members: `InitializeMembershipTable`, `InitializeMembershipTableAsync`, `DeleteMembershipTableEntries`, `DeleteMembershipTableEntriesAsync`, `CleanupDefunctSiloEntries`, `CleanupDefunctSiloEntriesAsync`, `ReadRow`, `ReadRowAsync`, `ReadAll`, `ReadAllAsync`, `InsertRow`, `InsertRowAsync`, `UpdateRow`, `UpdateRowAsync`, `UpdateIAmAlive`, `UpdateIAmAliveAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Core/SystemTargetInterfaces/IMembershipTable.cs:24
`IManagementGrain` declares 34 members under just 15 distinct name(s): `GetHosts`, `GetHosts`, `GetDetailedHosts`, `GetDetailedHosts`, `ForceGarbageCollection`, `ForceGarbageCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceRuntimeStatisticsCollection`, `ForceRuntimeStatisticsCollection`, `GetRuntimeStatistics`, `GetRuntimeStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetDetailedGrainStatistics`, `GetDetailedGrainStatistics`, `GetGrainActivationCount`, `GetGrainActivationCount`, `GetTotalActivationCount`, `GetTotalActivationCount`, `SendControlCommandToProvider`, `SendControlCommandToProvider`, `GetActivationAddress`, `GetActivationAddress`, `GetActiveGrains`, `GetActiveGrains`, `GetGrainCallFrequencies`, `GetGrainCallFrequencies`, `ResetGrainCallFrequencies`, `ResetGrainCallFrequencies`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 34 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 34 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Orleans.Core/SystemTargetInterfaces/IManagementGrain.cs:13
`IReminderServiceLifecycleHarness` declares 22 members: `GrainFactory`, `ReminderTable`, `UtcNow`, `ReminderLoadingWindow`, `ReminderRefreshPeriod`, `ActiveSilos`, `WaitForStartupReadinessAsync`, `AdvanceAsync`, `RefreshAsync`, `WaitForOwnerCountAsync`, `GetOwners`, `IsOwner`, `WaitForScheduleAsync`, `GetLocalStartCount`, `GetLocalStopCount`, `GetScheduleChangeCount`, `WaitForScheduleChangeCountAsync`, `WaitForTickCountAsync`, `GetTickCount`, `JoinOneSiloAsync`, `LeaveSiloAsync`, `WaitForTopologyReconciliationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:16
`IStreamPubSub` declares 17 members under just 9 distinct name(s): `RegisterProducer`, `RegisterProducer`, `UnregisterProducer`, `UnregisterProducer`, `RegisterConsumer`, `RegisterConsumer`, `UnregisterConsumer`, `UnregisterConsumer`, `ProducerCount`, `ProducerCount`, `ConsumerCount`, `ConsumerCount`, `GetAllSubscriptions`, `GetAllSubscriptions`, `CreateSubscriptionId`, `FaultSubscription`, `FaultSubscription`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Orleans.Streaming/Providers/IStreamProviderRuntime.cs:72
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C2 · Access Controls3.0 / 10Weak✓ Tool-verified
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Authorization machinery exists but no [Authorize] usage and no imperative guard calls were found at handlers.
What to do
Enforce authorization at every handler — call the guard method (throw-on-violation) from each one, or adopt [Authorize] so protected-by-default is demonstrable.
Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.
Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.
`Journaling.DurableList.AddRange` mutates persistent state (a repository write) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write. — src/Orleans.Journaling/DurableList.cs:170
What to do
Make retry-prone mutations idempotent — guard each write with an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write, so a re-run doesn't double-apply.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×10) — src/Orleans.Core/Runtime/InvokableObjectManager.cs:152, src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs:85, src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
Control only reaches here when `enumerator.MoveNext()` is true, because the guard on line 36 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test. — src/Orleans.Core.Abstractions/Utils/Utils.cs:40
`Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×3) — src/Orleans.Core/Runtime/InvokableObjectManager.cs:152, src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84, src/Orleans.Runtime/Core/HostedClient.cs:102
`ActivationServices` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80
`ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82, src/Orleans.Runtime/Core/HostedClient.cs:100
`GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137, src/Orleans.Runtime/Core/HostedClient.cs:426
Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored. (×2) — src/Orleans.Runtime/Core/InsideRuntimeClient.cs:261, src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:254
`OnRuntimeServicesStart` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — src/Orleans.Runtime/Silo/Silo.cs:190
`ThrowIfNull` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — src/Orleans.Serialization/Codecs/ArgumentNullExceptionPolyfill.cs:41
`WriteField` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14
A test is skipped with reason "Flaky test. Needs to be investigated." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten. — test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:416
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×21) — playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:24, playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:25, playground/DurableJobsJournaling/DurableJobsJournaling.Silo/WorkflowGrains.cs:41, …
`GetEvents`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:432
`ImportRequestContext`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:433
`Lease` has an empty body — confirm it's an intentional no-op and not an unfinished method. — src/Orleans.Core/Networking/Shared/MemoryPoolBlock.cs:52
`ReceiveMessage`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — src/Orleans.Core/Runtime/ClientGrainContext.cs:174
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a 'Testing' section to the root README — how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 98 of 154 project(s) that lack one — worth up to 1.3 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree, with each file named `NNNN-title` in whatever markup those docs already use, is the most discoverable form).
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
README omits the Orleans.Dashboard.App project (admin dashboard) — reported by the model that read the README against this repository; no term search was run for this one, so nothing here has been checked against the tree. Treat it as a reading to confirm, not as a measured contradiction: verify it against the code before acting on it, and if the footprint it describes does exist, this row is wrong.
What to do
Reconcile the README with reality: README omits the Orleans.Dashboard.App project (admin dashboard).
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries. Exhaustive, deterministic.
No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.
What to do
Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.
Only 56/81 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 81, 11 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
What to do
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
Dependabot is configured but does not watch `github-actions`, `nuget`, `npm` — add those `package-ecosystem` entries to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Do you agree with this assessment?
P5 · DR & Backup10.0 / 10Exemplary✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Raise allocation-aware density on the hot paths — currently 1620 use(s) across 278,118 production line(s) (~5.8/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) that wastes threads and risks deadlock, and, where the code is a reusable library, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) counted everywhere, and — for a library with ≥5 awaits — the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
43 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Only 564/3422 awaits use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
In library code, append .ConfigureAwait(false) to every await (or set <ConfigureAwait>false</ConfigureAwait> / use the analyzer CA2007) so the library never captures the host's context.
Do you agree with this assessment?
R1 · Type Safety10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.
Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.
8 duplicated blocks under src/Dashboard/Orleans.Dashboard.App/src/ have copies in at least two of the sibling directories components, grains, lifecycle, overview, silos — 7 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103
src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 · src/Dashboard/Orleans.Dashboard.App/src/grains/silo-table.tsx:33 — the two spans are one implementation copied and then locally edited — 342 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103
src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:121 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138
src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:70 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66
src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:45 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:64 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:45
src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24 · src/Dashboard/Orleans.Dashboard.App/src/components/time-series-chart.tsx:72 — the two spans are one implementation copied and then locally edited — 90 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24
src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108 · src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108
src/Dashboard/Orleans.Dashboard.App/src/index.tsx:212 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:234 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:212
src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71 · src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71
src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:196 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180
src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36 · src/Dashboard/Orleans.Dashboard.App/src/silos/silos.tsx:28 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36
src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:196 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:231 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:196
src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:202 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:216 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:230 — all 4 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188
src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:284 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158
src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15 · src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:16 — the two spans are one implementation copied and then locally edited — 65 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15
src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41
src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31 · src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:21 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31
src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:39 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11
What to do
Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
parseSuffix has cyclomatic complexity 14 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:55
parseType has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:79
formatMemberName has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:13
Do you agree with this assessment?
R3 · Large Files8.9 / 10Strong✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
What to do
Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
React / JS · Readiness — How outdated the npm dependencies are (a maturity signal). JS/npm CVEs are scored separately in D30 (JS/npm Dependency Vulnerabilities).
Method: npm dependency staleness from manifest/registry metadata (a maturity signal; JS/npm CVEs are scored separately in D30, which answers dependency vulnerabilities for every ecosystem). Deterministic.
What to do
Bump outdated dependencies to current versions to limit upgrade debt.
Do you agree with this assessment?
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.
Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.
Do you agree with this assessment?
R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.
Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored. Markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself — a page handed to a consumer runs in that consumer's origin.
`https://d3js.org/d3.v7.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository. — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:7
What to do
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×16) — src/Orleans.Core/Async/TaskExtensions.cs:213, src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:120, src/Orleans.Runtime/MembershipService/MembershipAgent.cs:236, …
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback. (×9) — src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:275, src/Orleans.Journaling/JournaledStateManager.cs:1097, src/Orleans.Runtime/Catalog/ActivationData.cs:975, …
This blocks on a Task **while holding a `lock`**, which is worse than an ordinary sync-over-async in two ways. `await` is illegal inside a `lock` body, so the usual fix — make the caller `async` and await it — cannot be applied where this block stands. And the thread parks while still holding the lock, so it occupies the critical section doing no work: every other caller serialises behind an operation that is only waiting, and if the awaited task itself needs a thread the pool has run out of, they wait forever. Do the async work OUTSIDE the critical section: take the lock only to read the shared state, release it, await the call, then re-take the lock to publish the result — re-checking on re-entry whether another caller won the race and, if so, discarding your result rather than overwriting theirs. Where the critical section genuinely has to span the async call, `lock` is the wrong primitive: use an async-aware one (`SemaphoreSlim` with `await WaitAsync()`) so waiters yield their thread instead of parking it. — src/Orleans.Reminders/ReminderService/LocalReminderService.cs:551
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. Deterministic, provable per finding. Advisory.
`MembershipTableTestFixture` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializationGate` itself (line 31), which makes that instance its own. But `_initializationGate` is named in none of the methods the disposal search covered: `DisposeAsync` (line 399), `DisposeAsync` (line 401), `DisposeAsync` (line 399), `DisposeAsync` (line 401), `CompleteDisposalAsync` (line 431), `ObserveLateCleanupFailureAsync` (line 460) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializationGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Clustering.TestKit/MembershipTableTestFixture.cs:31
`task` is a `Task`, which implements `IDisposable`, and it is created here (line 178). Every use of it in `StartClosing` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Core/Networking/Connection.cs:178
`JobShard` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_mutationLock` itself (line 158), which makes that instance its own. But `_mutationLock` is named in none of the methods the disposal search covered: `DisposeAsync` (line 389) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_mutationLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.DurableJobs/JobShard.cs:158
`_stateManager` is never created by `JournaledJobShard` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 272). Its declared type `IJournaledStateManager` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Orleans.DurableJobs/JournaledJobShard.cs:272
`cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 346). Every use of it in `CreateWorker` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:346
`ClusterManifestProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_peerProbeSlots` itself (line 33), which makes that instance its own. But `_peerProbeSlots` is named in none of the methods the disposal search covered: `DisposeAsync` (line 708), `Dispose` (line 710), `StopAsync` (line 682), `DisposeAsync` (line 708) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_peerProbeSlots?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:33
`cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Participate` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/MembershipService/ClusterMembershipService.cs:108
`MembershipAgent` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `cancellation` itself (line 23), which makes that instance its own. But `cancellation` is named in none of the methods the disposal search covered: `Dispose` (line 449) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`cancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Runtime/MembershipService/MembershipAgent.cs:23
`task` is a `Task`, which implements `IDisposable`, and it is created here (line 15). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:15
`task` is a `Task`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:24
`manager` is a `PersistentStreamPullingManager`, which implements `IDisposable`, and it is created here (line 80). Every use of it in `InitializePullingAgents` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var manager = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Streaming/Providers/SiloStreamProviderRuntime.cs:80
`SiloHandle` declares a finalizer (line 73), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Orleans.TestingHost/SiloHandle.cs:73
`TestClusterPortAllocator` declares a finalizer (line 77), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Orleans.TestingHost/TestClusterPortAllocator.cs:77
`signal` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 191). Every use of it in `Acquire` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var signal = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.TestingHost/TestClusterPortAllocator.cs:191
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage.
Only 763/1248 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×34) — playground/ActivationRebalancing/ActivationRebalancing.Frontend/Controllers/StatsController.cs:11, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:18, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:106, …
No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×5) — src/Orleans.Analyzers/GenerateAliasAttributesCodeFix.cs:48, src/Orleans.Core/Async/BatchWorker.cs:95, src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:106, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
The guard on line 73 rejects `value` and line 73 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Core.Abstractions/Manifest/MajorMinorVersion.cs:73
The guard on line 81 rejects `reminderName` and line 81 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Reminders/GrainReminderExtensions.cs:81
The guard on line 160 rejects `reminderName` and line 160 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Reminders/GrainReminderExtensions.cs:160
The guard on line 275 rejects `assembly` and line 277 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(assembly)` is true of a value that is NOT null: it is satisfied by an EMPTY `assembly`, and on that path `assembly` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Serialization/TypeSystem/TypeSpec.cs:277
The guard on line 378 rejects `value` and line 380 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Serialization/TypeSystem/TypeSpec.cs:380
The guard on line 31 rejects `name` and line 33 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/GrainStreamingExtensions.cs:33
The guard on line 61 rejects `name` and line 63 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/GrainStreamingExtensions.cs:63
The guard on line 109 rejects `name` and line 109 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:109
The guard on line 65 rejects `strProviderName` and line 67 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(strProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `strProviderName`, and on that path `strProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:67
The guard on line 41 rejects `batchContainers` and line 43 reports that rejection as `ArgumentNullException` — but the condition's own test `!batchContainers.Any()` is true of a value that is NOT null: it is satisfied by an EMPTY `batchContainers`, and on that path `batchContainers` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/QueueAdapters/BatchContainerBatch.cs:43
The guard on line 43 rejects `invariantName` and line 45 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:45
The guard on line 105 rejects `invariantName` and line 107 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:107
The guard on line 110 rejects `connectionString` and line 112 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:112
The guard on line 78 rejects `dataConnectionString` and line 78 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(dataConnectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `dataConnectionString`, and on that path `dataConnectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:78
The guard on line 35 rejects `serviceId` and line 35 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapter.cs:35
The guard on line 34 rejects `serviceId` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapterReceiver.cs:34
The guard on line 128 rejects `connectionString` and line 128 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Shared/Storage/AzureStorageOperationOptions.cs:128
The guard on line 77 rejects `connectionString` and line 77 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamOptions.cs:77
The guard on line 34 rejects `clusterId` and line 36 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(clusterId)` is true of a value that is NOT null: it is satisfied by an EMPTY `clusterId`, and on that path `clusterId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:36
The guard on line 102 rejects `streamProviderName` and line 104 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(streamProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `streamProviderName`, and on that path `streamProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:104
What to do
Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated7.9 / 10Strong✓ Tool-verified
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
`_cache` is enumerated directly, and line 84 calls `_cache.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen. — src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:80
`_cache` is enumerated directly, and line 93 calls `_cache.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen. — src/Orleans.Core/Messaging/CachingSiloAddressCodec.cs:89
`localReminders` is enumerated directly, and line 456 calls `localReminders.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen. — src/Orleans.Reminders/ReminderService/LocalReminderService.cs:447
`_inProgress` is enumerated directly, and line 444 calls `_inProgress.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen. — src/Orleans.Runtime/Placement/PlacementService.cs:438
What to do
Each finding names the two spans that cannot both stand — the `foreach` source, and the call inside the body that structurally changes that same collection. Confirm from those two, then pick one: enumerate a snapshot (`foreach (var x in c.ToList())`), collect what needs changing and apply it after the loop, or — where the loop was only ever meant to act on the first match — `break` immediately after the mutation, which is the one shape that is already safe.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×22) — src/Orleans.Core.Abstractions/Utils/Utils.cs:204, src/Orleans.Core.Abstractions/Utils/Utils.cs:241, src/Orleans.Core/Caching/ConcurrentLruCache.cs:1056, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch. (×13) — src/Orleans.Core/Async/AsyncLock.cs:111, src/Orleans.Core/Networking/ConnectionManager.cs:335, src/Orleans.Core/Networking/ConnectionManager.cs:370, …
`catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — src/Orleans.Core/Lifecycle/LifecycleSubject.cs:84, src/Orleans.TestingHost/Utils/StorageEmulator.cs:120, src/Orleans.TestingHost/Utils/StorageEmulator.cs:143
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×11) — playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:34, playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:35, playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:105, …
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
~1.7 `!` suppressions per 1k syntax nodes — 1817 suppression(s) across the 1092195 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not included — 33 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AX4 Dependency direction — not applicable to a CQRS architecture (the inward-dependency rule is for layered/clean styles)
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D11 Test Reliability — Test reliability not measured — polyglot suite, one half not re-run
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D32 Data Compliance (PII/GDPR) — 336 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the target did not build
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: the .NET half could not be measured — the repository wires up no coverage collector for `--collect:"XPlat Code Coverage"` to use; the JavaScript/TypeScript half could not be measured — docs/site/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 10 strongly-typed id(s); 23 value object(s)
ED1 Handler temporal coupling — no events and no event/broker handlers detected — event-driven integration not assessable
ED2 Event/command shape — no events and no event/broker handlers detected — event-driven integration not assessable
ED3 Event naming — no events and no event/broker handlers detected — event-driven integration not assessable
ED4 Outbox / dual-write — no events and no event/broker handlers detected — event-driven integration not assessable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R4 Test Coverage — the JS/TS workspace (37 production file(s)) has no JavaScript/TypeScript test, but it is 3.87% of this repository's production source and the other 96.13% carries 314,092 line(s) of test code this pass cannot read — an incidental frontend's reachability is not the repository's test posture, so it is not scored as one
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
WriteOnlyPrivateField src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisAdapterFactory.cs:31— private ILogger<KinesisAdapterFactory> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:44— private string[] InsertStatisticsMultiupdateColumns — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:184— private ObservableGauge<int>? _activationCount — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:191— private ObservableGauge<int>? _activationWorkingSet — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ClientInstruments.cs:8— private ObservableGauge<int>? _connectedGatewayCount — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:8— private ObservableGauge<int>? _ringSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:59— private ObservableGauge<int>? _ringSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:9— private ObservableGauge<float>? _myRangeRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:10— private ObservableGauge<float>? _averageRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:43— private ObservableGauge<int>? _directoryPartitionSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:49— private ObservableGauge<int> _cacheSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:65— private ObservableGauge<long>? _myPortionRingDistance — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:71— private ObservableGauge<float>? _myPortionRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:77— private ObservableGauge<float>? _myPortionAverageRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/MessagingInstruments.cs:36— private ObservableCounter<long> LocalMessagesSentCounter — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:29— private ObservableGauge<long>? _activationDataAll — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ReminderInstruments.cs:10— private ObservableGauge<int>? _activeReminders — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/StreamInstruments.cs:15— private ObservableGauge<int>? _persistentStreamPullingAgents — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/StreamInstruments.cs:23— private ObservableGauge<int>? _persistentStreamPubSubCacheSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:32— private IServiceProvider _serviceProvider — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Messaging/MessageSerializer.cs:37— private DictionaryCodec<string, object> _requestContextCodec — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Core/Timers/TimerManager.cs:89— private Timer QueueChecker — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:38— private string? primaryCluster — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Runtime/GrainDirectory/DhtGrainLocator.cs:92— private Task _runTask — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Orleans.Runtime/Networking/GatewayConnectionListener.cs:20— private ILogger<GatewayConnectionListener> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
EmptyCatchBlock src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs:144— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:86— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:100— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:123— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs:204— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs:241— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Async/AsyncLock.cs:111— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Caching/ConcurrentLruCache.cs:1056— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Lifecycle/LifecycleSubject.cs:75— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Networking/ConnectionManager.cs:335— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Networking/ConnectionManager.cs:370— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Networking/Shared/SocketExtensions.cs:20— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Core/Networking/Shared/SocketExtensions.cs:60— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:157— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:283— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationData.cs:1046— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationData.cs:1594— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationData.cs:2584— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Core/SystemTarget.cs:154— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Silo/Silo.cs:507— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Silo/Watchdog.cs:206— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Silo/Watchdog.cs:215— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Runtime/Silo/Watchdog.cs:224— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs:84— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
EmptyCatchBlock src/Orleans.TestingHost/InProcessSiloHandle.cs:142— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
NoWarnInCsproj — 10 warning codes suppressed in one element src/Orleans.Serialization/Orleans.Serialization.csproj:18— A single <NoWarn> suppresses 10 warning codes (IL2026;IL2055;IL2057;IL2060;IL2071;IL2077;IL2090;IL2096;IL3050;IL4000) in one stroke — one team-wide decision, not 10 independent debts. Review the set centrally rather than code-by-code; each code you can re-enable is one less blanket suppression. (Every code still counts toward the score and metrics.)
NoWarnInCsproj templates/Microsoft.Orleans.Templates/Microsoft.Orleans.Templates.csproj:53— NU5128 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj src/Orleans.Sdk/Orleans.Sdk.csproj:14— MSB3277 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj src/Orleans.Analyzers/Orleans.Analyzers.csproj:9— RS1038 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/Orleans.Analyzers.Contracts/Orleans.Analyzers.Contracts.csproj:18— RS1038 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/Grains/TestInternalGrains/TestInternalGrains.csproj:6— 618 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/Grains/TestGrains/TestGrains.csproj:6— 618 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/AdoNet/Orleans.GrainDirectory.AdoNet/Orleans.GrainDirectory.AdoNet.csproj:15— CA2007 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj samples/DurableJobsMigration/DurableJobsMigration/DurableJobsMigration.csproj:8— ORLEANSEXP003 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj docs/tools/PackageJsonGenerator/PackageJsonGenerator.csproj:7— CS1570 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj test/Directory.Build.props:13— FS2003 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
AC2 · Forms & labels· <input> without a programmatic label · ×7
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:109— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:119— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:130— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:140— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:150— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:79— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
<input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/logstream/log-stream.tsx:109— This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
D10 · Test Quality· No assertions (empty test) · ×7
No assertions (empty test): RemindersTable_MySql_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/MySqlRemindersTableTests.cs:59— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_PostgreSql_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/PostgreSqlRemindersTableTests.cs:57— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_SqlServer_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/SqlServerRemindersTableTests.cs:58— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_AWS_Init test/Extensions/Orleans.AWS.Tests/Reminder/DynamoDBRemindersTableTests.cs:107— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_Azure_Init test/Extensions/Orleans.Azure.Tests/AzureRemindersTableTests.cs:55— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_Cosmos_Init test/Extensions/Orleans.Cosmos.Tests/CosmosRemindersTableTests.cs:55— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): RemindersTable_Redis_Init test/Extensions/Orleans.Redis.Tests/Reminders/RedisReminderTableTests.cs:120— Test method has an empty body — it asserts nothing and exercises no code.
AC4 · Keyboard semantics· Click handler on a non-interactive <th> · ×5
Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:178— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:189— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:203— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:217— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:231— A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
FileScopedPragmaDisable test/Orleans.Core.Tests/DurableJobs/DurableJobsOptionsTests.cs:15— #pragma warning disable ORLEANSEXP005 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable test/Orleans.Core.Tests/DurableJobs/LocalDurableJobManagerTests.cs:2— #pragma warning disable ORLEANSEXP005 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
AC2 · Forms & labels· <select> without a programmatic label · ×1
<select> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:69— This control has no associated label. Add a <label htmlFor> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<html> without a lang src/Dashboard/Orleans.Dashboard.App/index.html:2— The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
Viewport restricts zoom src/Dashboard/Orleans.Dashboard.App/index.html:7— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
Captive dependency: singleton DhtGrainLocator captures scoped IGrainContext src/Orleans.Runtime/GrainDirectory/DhtGrainLocator.cs:15— `DhtGrainLocator` is registered as a SINGLETON but its constructor takes `IGrainContext grainContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGrainContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
NoWarnInCsproj repeated across 13 files test/Orleans.Journaling.Tests/Orleans.Journaling.Tests.csproj:11— The identical NoWarnInCsproj (`ORLEANSEXP005`) appears in 13 files (13 occurrences) — a single repo-wide policy (e.g. a Directory.Build.props decision or an idiomatic suppression), not 13 independent debts. Decide it once centrally rather than file-by-file. (Every occurrence still counts toward the score and metrics.)
X1 · Async correctness· Blocking wait while holding a `lock` · ×1
Blocking wait while holding a `lock` src/Orleans.Reminders/ReminderService/LocalReminderService.cs:551— This blocks on a Task **while holding a `lock`**, which is worse than an ordinary sync-over-async in two ways. `await` is illegal inside a `lock` body, so the usual fix — make the caller `async` and await it — cannot be applied where this block stands. And the thread parks while still holding the lock, so it occupies the critical section doing no work: every other caller serialises behind an operation that is only waiting, and if the awaited task itself needs a thread the pool has run out of, they wait forever. Do the async work OUTSIDE the critical section: take the lock only to read the shared state, release it, await the call, then re-take the lock to publish the result — re-checking on re-entry whether another caller won the race and, if so, discarding your result rather than overwriting theirs. Where the critical section genuinely has to span the async call, `lock` is the wrong primitive: use an async-aware one (`SemaphoreSlim` with `await WaitAsync()`) so waiters yield their thread instead of parking it.
Hotspot: src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248— src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs changed 18 times in last 90 days, max cyclomatic complexity 40 in PersistentStreamPullingAgent.RunConsumerCursor at line 1248. 9 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Runtime/Catalog/ActivationData.cs src/Orleans.Runtime/Catalog/ActivationData.cs:1111— src/Orleans.Runtime/Catalog/ActivationData.cs changed 11 times in last 90 days, max cyclomatic complexity 51 in ActivationData.RunMessageLoop at line 1111. 2 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Catalog/ActivationData.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Journaling/JournaledStateManager.cs src/Orleans.Journaling/JournaledStateManager.cs:187— src/Orleans.Journaling/JournaledStateManager.cs changed 6 times in last 90 days, max cyclomatic complexity 59 in JournaledStateManager.WorkLoop at line 187. 4 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Journaling/JournaledStateManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs:335— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs changed 5 times in last 90 days, max cyclomatic complexity 67 in TransactionRecoveryEventObserver.TryCreateTransition at line 335. 3 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs:7— src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs changed 2 times in last 90 days, max cyclomatic complexity 103 in Identifier.IsCSharpKeyword at line 7. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:518— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs changed 6 times in last 90 days, max cyclomatic complexity 30 in GrainInterfaceVersionCodeFix.AppendHistoricalContracts at line 518. 2 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs changed 9 times in last 90 days, max cyclomatic complexity 19 in TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase at line 229. 4 of those changes were fix/bug commits, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502— src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs changed 7 times in last 90 days, max cyclomatic complexity 24 in PooledQueueCache.TryGetNextMessageWithResult at line 502. 2 of those changes were fix/bug commits, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Transactions/State/TransactionQueue.cs src/Orleans.Transactions/State/TransactionQueue.cs:310— src/Orleans.Transactions/State/TransactionQueue.cs changed 7 times in last 90 days, max cyclomatic complexity 23 in TransactionQueue.NotifyOfAbort at line 310. 3 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Transactions/State/TransactionQueue.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389— src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs changed 8 times in last 90 days, max cyclomatic complexity 20 in ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles at line 389. 4 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22— src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs changed 3 times in last 90 days, max cyclomatic complexity 49 in ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData at line 22. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Runtime/Core/InsideRuntimeClient.cs src/Orleans.Runtime/Core/InsideRuntimeClient.cs:290— src/Orleans.Runtime/Core/InsideRuntimeClient.cs changed 9 times in last 90 days, max cyclomatic complexity 16 in InsideRuntimeClient.Invoke at line 290. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Core/InsideRuntimeClient.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63— src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs changed 5 times in last 90 days, max cyclomatic complexity 28 in RedisJournalStorageProvider.ListAsync at line 63. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Transactions/State/ReaderWriterLock.cs src/Orleans.Transactions/State/ReaderWriterLock.cs:66— src/Orleans.Transactions/State/ReaderWriterLock.cs changed 6 times in last 90 days, max cyclomatic complexity 23 in ReadWriteLock.EnterLock at line 66. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Transactions/State/ReaderWriterLock.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308— src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs changed 6 times in last 90 days, max cyclomatic complexity 23 in Impl.AnalyzeNamedType at line 308. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/AWS/Shared/Storage/DynamoDBStorage.cs src/AWS/Shared/Storage/DynamoDBStorage.cs:272— src/AWS/Shared/Storage/DynamoDBStorage.cs changed 7 times in last 90 days, max cyclomatic complexity 19 in DynamoDBStorage.UpdateTableAsync at line 272. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/AWS/Shared/Storage/DynamoDBStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Core/Networking/ConnectionManager.cs src/Orleans.Core/Networking/ConnectionManager.cs:344— src/Orleans.Core/Networking/ConnectionManager.cs changed 7 times in last 90 days, max cyclomatic complexity 19 in ConnectionManager.Close at line 344. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Core/Networking/ConnectionManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs:48— src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs changed 5 times in last 90 days, max cyclomatic complexity 25 in S3JournalStorageProvider.ListAsync at line 48. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:413— src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs changed 5 times in last 90 days, max cyclomatic complexity 23 in BatchOperation.Flush at line 413. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.DurableJobs/JournaledJobShard.cs src/Orleans.DurableJobs/JournaledJobShard.cs:393— src/Orleans.DurableJobs/JournaledJobShard.cs changed 5 times in last 90 days, max cyclomatic complexity 22 in JournaledJobShard.ProcessMutationBatchAsync at line 393. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/JournaledJobShard.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.DurableJobs/ShardExecutor.cs src/Orleans.DurableJobs/ShardExecutor.cs:309— src/Orleans.DurableJobs/ShardExecutor.cs changed 5 times in last 90 days, max cyclomatic complexity 21 in ShardExecutor.ExecuteJobAsync at line 309. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/ShardExecutor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.DurableJobs/JournaledJobShardManager.cs src/Orleans.DurableJobs/JournaledJobShardManager.cs:196— src/Orleans.DurableJobs/JournaledJobShardManager.cs changed 5 times in last 90 days, max cyclomatic complexity 20 in JournaledJobShardManager.TryAssignShardAsync at line 196. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/JournaledJobShardManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.TestingHost/Utils/TestingUtils.cs src/Orleans.TestingHost/Utils/TestingUtils.cs:176— src/Orleans.TestingHost/Utils/TestingUtils.cs changed 5 times in last 90 days, max cyclomatic complexity 20 in TestingUtils.WaitUntilSucceededAsync at line 176. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.TestingHost/Utils/TestingUtils.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.CodeGenerator/ProxyGenerator.cs src/Orleans.CodeGenerator/ProxyGenerator.cs:85— src/Orleans.CodeGenerator/ProxyGenerator.cs changed 2 times in last 90 days, max cyclomatic complexity 49 in ProxyGenerator.CreateProxyMethods at line 85. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.CodeGenerator/ProxyGenerator.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Orleans.Serialization/TypeSystem/TypeConverter.cs src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151— src/Orleans.Serialization/TypeSystem/TypeConverter.cs changed 6 times in last 90 days, max cyclomatic complexity 16 in TypeConverter.ConsumeMetadata at line 151. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Serialization/TypeSystem/TypeConverter.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
TooManyMethods: ActivationData src/Orleans.Runtime/Catalog/ActivationData.cs— TooManyMethods — 1374 significant lines (blank, comment-only and punctuation-only lines excluded), 118 methods. The bar is 30 methods; this is 88 over it, 3.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalReminderService src/Orleans.Reminders/ReminderService/LocalReminderService.cs— TooManyMethods — 773 significant lines (blank, comment-only and punctuation-only lines excluded), 101 methods. The bar is 30 methods; this is 71 over it, 3.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GrainDirectoryPartition src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs— TooManyMethods — 927 significant lines (blank, comment-only and punctuation-only lines excluded), 89 methods, declared across 2 files: GrainDirectory/GrainDirectoryPartition.cs (78), GrainDirectory/GrainDirectoryPartition.Interface.cs (11). The bar is 30 methods; this is 59 over it, 2.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MembershipTableManager src/Orleans.Runtime/MembershipService/MembershipTableManager.cs— TooManyMethods — 820 significant lines (blank, comment-only and punctuation-only lines excluded), 85 methods. The bar is 30 methods; this is 55 over it, 2.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PersistentStreamPullingAgent src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs— TooManyMethods — 1108 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. The bar is 30 methods; this is 42 over it, 2.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: S3JournalStorage src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs— TooManyMethods — 944 significant lines (blank, comment-only and punctuation-only lines excluded), 65 methods. The bar is 30 methods; this is 35 over it, 2.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalGrainDirectory src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs— TooManyMethods — 578 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TransactionQueue src/Orleans.Transactions/State/TransactionQueue.cs— TooManyMethods — 1004 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: InProcessTestCluster src/Orleans.TestingHost/InProcTestCluster.cs— TooManyMethods — 513 significant lines (blank, comment-only and punctuation-only lines excluded), 62 methods. The bar is 30 methods; this is 32 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DynamoDBStorage src/AWS/Shared/Storage/DynamoDBStorage.cs— TooManyMethods — 574 significant lines (blank, comment-only and punctuation-only lines excluded), 58 methods. The bar is 30 methods; this is 28 over it, 1.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GrainInterfaceVersionCodeFix src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs— TooManyMethods — 1135 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: TestCluster src/Orleans.TestingHost/TestCluster.cs— TooManyMethods — 498 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AzureTableJournalStorage src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs— TooManyMethods — 689 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ManagementGrain src/Orleans.Runtime/Core/ManagementGrain.cs— TooManyMethods — 356 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ActivationRepartitioner src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs— TooManyMethods — 540 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods, declared across 3 files: Repartitioning/ActivationRepartitioner.cs (23), Repartitioning/ActivationRepartitioner.Log.cs (20), Repartitioning/ActivationRepartitioner.MessageSink.cs (9). The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalDurableJobManager src/Orleans.DurableJobs/LocalDurableJobManager.Log.cs— TooManyMethods — 494 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods, declared across 2 files: Orleans.DurableJobs/LocalDurableJobManager.Log.cs (27), Orleans.DurableJobs/LocalDurableJobManager.cs (25). The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AzureTableDataManager src/Azure/Shared/Storage/AzureTableDataManager.cs— TooManyMethods — 455 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Silo src/Orleans.Runtime/Silo/Silo.cs— TooManyMethods — 358 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: JournaledStateManager src/Orleans.Journaling/JournaledStateManager.cs— TooManyMethods — 588 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ActivationCollector src/Orleans.Runtime/Catalog/ActivationCollector.cs— TooManyMethods — 459 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AzureBlobJournalStorage src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs— TooManyMethods — 628 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DynamoDBMembershipTable src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs— TooManyMethods — 462 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PrimaryBasedLogViewAdaptor src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs— TooManyMethods — 360 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CosmosMembershipTable src/Azure/Orleans.Clustering.Cosmos/Membership/CosmosMembershipTable.cs— TooManyMethods — 394 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ConcurrentLruCache src/Orleans.Core/Caching/ConcurrentLruCache.cs— TooManyMethods — 378 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
No assertions: MembershipTable_ModelBased_GeneratedConformance test/Orleans.Core.Tests/Membership/SystemTargetMembershipTableConformanceTests.cs:36— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: MembershipTable_ModelBased_GeneratedConformance test/Orleans.Runtime.Internal.Tests/MembershipTests/MembershipTableConformanceTestsBase.cs:151— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ObserverTest_Disconnect test/Orleans.DefaultCluster.Tests/ErrorGrainTest.cs:329— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ObserverTest_Disconnect2 test/Orleans.DefaultCluster.Tests/ErrorGrainTest.cs:342— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: SimpleGrainGetGrain test/Orleans.DefaultCluster.Tests/SimpleGrainTests.cs:35— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: PersistenceStorage_WriteReadWriteReadStatesInParallel test/Orleans.Journaling.Tests/S3JournalStoragePersistenceTestKitTests.cs:47— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: PersistenceStorage_ModelBasedGeneratedConformance test/Orleans.Journaling.Tests/S3JournalStoragePersistenceTestKitTests.cs:115— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: PersistenceStorage_WriteReadWriteReadStatesInParallel test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:187— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: GrainStorage_ModelBasedGeneratedConformance test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:289— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: GrainStorageWithLatency_ModelBasedGeneratedConformance test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:296— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Oracle_ModelBasedGeneratedConformance test/Orleans.Reminders.TestKit.Tests/IdealizedReminderTableTests.cs:124— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: InMemoryReminderTable_ModelBasedGeneratedConformance test/Orleans.Reminders.TestKit.Tests/InMemoryReminderTableConformanceTests.cs:128— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_StartupReadiness test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:38— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_RegistrationHasSingleOwner test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:42— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_UpdateDoesNotRestartLocalOwner test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:46— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_RemovalReachesQuiescence test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:50— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_ExactDueRecovery test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:54— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_StaleOwnerRegistrationReconciles test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:58— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_OneSiloJoinLeaveTransfersOwnership test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:62— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderService_CleanupIsIsolated test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:66— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ConsistentRingProvider_Test1 test/Orleans.Runtime.Internal.Tests/LivenessTests/ConsistentRingProviderTests.cs:22— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReminderTable_ModelBasedGeneratedConformance test/Orleans.Runtime.Internal.Tests/RemindersTest/ReminderTableTestsBase.cs:185— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: DisposeGrainDirectoryCacheAsync_NonDisposableCacheCompletes test/Orleans.Runtime.Tests/Directories/GrainDirectoryCacheFactoryTests.cs:202— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ActiveImplicitSubscriptionAllowsObserverReplacementWithoutToken test/Orleans.Streaming.Tests/StreamingTests/StreamSubscriptionHandleImplTests.cs:260— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ActiveExplicitSubscriptionAllowsOlderAcknowledgedToken test/Orleans.Streaming.Tests/StreamingTests/StreamSubscriptionHandleImplTests.cs:270— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
TodoComment src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:420— //TODO: Note that this error message should be canonical across back-ends. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/AdoNet/Shared/Storage/DbStoredQueries.cs:217— //TODO: This is a bit of hack way to check in the current version if there's membership data or not, but if there's a start time, there's member. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Azure/Orleans.Streaming.AzureStorage/Storage/AzureQueueDataManager.cs:415— // TODO: pending on https://github.com/dotnet/runtime/issues/110570
TodoComment src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:161— //TODO: Add a queue specific default failure handler with reasonable error reporting. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:213— //TODO: CreateAdapter must be called first. Figure out how to safely enforce this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Analyzers/AlwaysInterleaveDiagnosticAnalyzer.cs:50— // TODO: Check that interface inherits from IGrain — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Core.Abstractions/IDs/Legacy/LegacyGrainId.cs:381— // TODO Get name of system/target grain + name of the grain type — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Core/Core/DefaultClientServices.cs:123— // TODO: abstract or move into some options. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:40— // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:56— // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:74— // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:340— // TODO: Remember silo addresses for pods that are restarting/terminating — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Journaling/JournaledStateManager.cs:292— // TODO: decide whether it's best to snapshot or append. Eg, by summing the size of the most recent snapshots and the current journal length. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:299— // TODO: make this not sux - jbragg — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Runtime/Silo/SiloControl.cs:142— // TODO: generic type expansion — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:146— // TODO: No support yet for DeliveryDisabled, only Stopped and Started — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Streaming/PubSub/ImplicitStreamPubSub.cs:58— // TODO BPETIT filter data? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Streaming/QueueBalancer/LeaseBasedQueueBalancer.cs:241— // TODO: mark for removal instead so we don't renew, and only remove leases that have not expired. - jbragg — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions.TestKit.Base/Grains/RemoteCommitService.cs:38— // TODO : Replace with more complete service implementation which: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:52— // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:59— // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:94— // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions/DistributedTM/TransactionClient.cs:143— // TODO: this should be a configurable parameter — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions/TransactionAttribute.cs:305— // TODO: this should be a configurable parameter — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Orleans.Transactions/ErrorCodes.cs:13— // TODO - jbragg - add error codes for transaction errors — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
DeadPreprocessorBranch src/Orleans.Core/Caching/Internal/Padding.cs:7— #if TARGET_ARM64 || TARGET_LOONGARCH64 — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Runtime/Utilities/StripedMpscBuffer.cs:422— #if TARGET_ARM64 || TARGET_LOONGARCH64 — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Core/Networking/Shared/SlabMemoryPool.cs:133— #if BLOCK_LEASE_TRACKING — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Core/Networking/Shared/SlabMemoryPool.cs:155— #if BLOCK_LEASE_TRACKING — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:254— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Orleans.DependencyInjection.Tests/Autofac/DependencyInjectionGrainTestsUsingAutofac.cs:11— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:24— #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:35— #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:98— #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:48— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:111— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:128— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:380— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:427— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:460— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:487— #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:371— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:416— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:731— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1094— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1100— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1107— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1158— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1260— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1422— #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
Stateful singleton: ClusterDiagnosticsService playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:7— `ClusterDiagnosticsService` is a singleton (one shared instance) but mutates instance state outside any lock (_version; e.g. `_version` at line 25).
Stateful singleton: LoadDriver playground/DurableJobsJournaling/DurableJobsJournaling.Web/LoadDriver.cs:7— `LoadDriver` is a singleton (one shared instance) but mutates instance state outside any lock (_enabled, _startedAt; e.g. `_enabled` at line 22).
Stateful singleton: EnvironmentStatisticsProvider src/Orleans.Core/Statistics/EnvironmentStatisticsProvider.cs:11— `EnvironmentStatisticsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_maximumAvailableMemoryBytes, _availableMemoryBytes; e.g. `_maximumAvailableMemoryBytes` at line 70).
Stateful singleton: GrainReferenceActivatorProvider src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:286— `GrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 341).
Stateful singleton: UntypedGrainReferenceActivatorProvider src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:105— `UntypedGrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 143).
Stateful singleton: SocketSchedulers src/Orleans.Core/Networking/Shared/SocketSchedulers.cs:6— `SocketSchedulers` is a singleton (one shared instance) but mutates instance state outside any lock (nextScheduler; e.g. `nextScheduler` at line 33).
Stateful singleton: GatewayManager src/Orleans.Core/Messaging/GatewayManager.cs:24— `GatewayManager` is a singleton (one shared instance) but mutates instance state outside any lock (gatewayListProviderInitialized, roundRobinCounter, knownGateways, cachedLiveGateways, cachedLiveGatewaysSet, lastRefreshTime; e.g. `gatewayListProviderInitialized` at line 68).
Stateful singleton: ClientClusterManifestProvider src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:22— `ClientClusterManifestProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 77).
Stateful singleton: LocalDurableJobManager src/Orleans.DurableJobs/LocalDurableJobManager.cs:22— `LocalDurableJobManager` is a singleton (one shared instance) but mutates instance state outside any lock (_startTimestamp, _listenForClusterChangesTask, _periodicCheckTask, _totalClaimedShards; e.g. `_startTimestamp` at line 216).
Stateful singleton: LocalReminderService src/Orleans.Reminders/ReminderService/LocalReminderService.cs:19— `LocalReminderService` is a singleton (one shared instance) but mutates instance state outside any lock (localTableSequence, localReminders, runTask, initialReadCallCount; e.g. `localTableSequence` at line 395).
Stateful singleton: ReminderRegistry src/Orleans.Reminders/ReminderService/ReminderRegistry.cs:13— `ReminderRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (serviceProvider; e.g. `serviceProvider` at line 107).
Stateful singleton: InMemoryReminderTable src/Orleans.Reminders/ReminderService/InMemoryReminderTable.cs:7— `InMemoryReminderTable` is a singleton (one shared instance) but mutates instance state outside any lock (isAvailable; e.g. `isAvailable` at line 88).
Stateful singleton: ActivationRebalancerMonitor src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs:16— `ActivationRebalancerMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_monitorTimer, _latestReport, _lastHeartbeatTimestamp, _statusListeners; e.g. `_monitorTimer` at line 82).
Stateful singleton: ActivationRepartitioner src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:24— `ActivationRepartitioner` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCountOffset, _currentExchangeSilo, _enableMessageSampling, _processPendingEdgesTask; e.g. `_activationCountOffset` at line 163).
Stateful singleton: SystemTargetBasedMembershipTable src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:14— `SystemTargetBasedMembershipTable` is a singleton (one shared instance) but mutates instance state outside any lock (grain, membershipManager; e.g. `grain` at line 38).
Stateful singleton: MembershipTableSystemTarget src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:210— `MembershipTableSystemTarget` is a singleton (one shared instance) but mutates instance state outside any lock (table; e.g. `table` at line 258).
Stateful singleton: Watchdog src/Orleans.Runtime/Silo/Watchdog.cs:18— `Watchdog` is a singleton (one shared instance) but mutates instance state outside any lock (_platformWatchdogTimestamp, _cumulativeGCPauseDuration, _platformWatchdogThread, _componentWatchdogTimestamp, _lastComponentHealthCheckTime, _componentWatchdogThread; e.g. `_platformWatchdogTimestamp` at line 53).
Stateful singleton: ActivationCollector src/Orleans.Runtime/Catalog/ActivationCollector.cs:22— `ActivationCollector` is a singleton (one shared instance) but mutates instance state outside any lock (_collectionLoopTask, _memBasedDeactivationLoopTask; e.g. `_collectionLoopTask` at line 673).
Stateful singleton: ActivationWorkingSet src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:18— `ActivationWorkingSet` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 200).
Stateful singleton: GrainLocatorResolver src/Orleans.Runtime/GrainDirectory/GrainLocatorResolver.cs:8— `GrainLocatorResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_clientGrainLocator; e.g. `_clientGrainLocator` at line 38).
Stateful singleton: GenericGrainDirectoryResolver src/Orleans.Runtime/GrainDirectory/GenericGrainDirectoryResolver.cs:9— `GenericGrainDirectoryResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_resolver; e.g. `_resolver` at line 35).
Stateful singleton: CachedGrainLocator src/Orleans.Runtime/GrainDirectory/CachedGrainLocator.cs:17— `CachedGrainLocator` is a singleton (one shared instance) but mutates instance state outside any lock (listenToClusterChangeTask; e.g. `listenToClusterChangeTask` at line 151).
Stateful singleton: DeploymentLoadPublisher src/Orleans.Runtime/Placement/DeploymentLoadPublisher.cs:20— `DeploymentLoadPublisher` is a singleton (one shared instance) but mutates instance state outside any lock (_publishTimer, _lastUpdateDateTimeTicks, LocalRuntimeStatistics; e.g. `_publishTimer` at line 82).
Stateful singleton: MembershipGossiper src/Orleans.Runtime/MembershipService/MembershipGossiper.cs:10— `MembershipGossiper` is a singleton (one shared instance) but mutates instance state outside any lock (_membershipSystemTarget; e.g. `_membershipSystemTarget` at line 26).
Stateful singleton: LocalSiloHealthMonitor src/Orleans.Runtime/MembershipService/LocalSiloHealthMonitor.cs:126— `LocalSiloHealthMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_lastDegradationLogTimestamp, _runTask, _isActive; e.g. `_lastDegradationLogTimestamp` at line 620).
Swallowed exception (empty catch) src/Orleans.Core.Abstractions/Utils/Utils.cs:204— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Core.Abstractions/Utils/Utils.cs:241— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Core/Async/AsyncLock.cs:111— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Core/Caching/ConcurrentLruCache.cs:1056— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Core/Lifecycle/LifecycleSubject.cs:75— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Core/Networking/ConnectionManager.cs:335— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Core/Networking/ConnectionManager.cs:370— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Core/Networking/Shared/SocketExtensions.cs:20— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Core/Networking/Shared/SocketExtensions.cs:60— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:157— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:283— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1046— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1594— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:2584— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Runtime/Core/SystemTarget.cs:154— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.Runtime/Silo/Silo.cs:507— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Runtime/Silo/Watchdog.cs:206— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Runtime/Silo/Watchdog.cs:215— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Runtime/Silo/Watchdog.cs:224— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs:84— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.TestingHost/InProcessSiloHandle.cs:142— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.TestingHost/StandaloneSiloHandle.cs:138— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.TestingHost/StandaloneSiloHandle.cs:270— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Orleans.TestingHost/StandaloneSiloHandle.cs:355— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Swallowed exception (empty catch) src/Orleans.TestingHost/StandaloneSiloHost.cs:124— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
FileTooLong: Catalog/ActivationData.cs src/Orleans.Runtime/Catalog/ActivationData.cs— FileTooLong — 1496 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 996 over it, 2.99× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: lib/docfx.mjs docs/site/scripts/lib/docfx.mjs— FileTooLong — 1308 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 808 over it, 2.62× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs— FileTooLong — 1219 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 719 over it, 2.44× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: PersistentStreams/PersistentStreamPullingAgent.cs src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs— FileTooLong — 1150 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 650 over it, 2.30× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: ReminderService/LocalReminderService.cs src/Orleans.Reminders/ReminderService/LocalReminderService.cs— FileTooLong — 1041 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 541 over it, 2.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: State/TransactionQueue.cs src/Orleans.Transactions/State/TransactionQueue.cs— FileTooLong — 1030 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 530 over it, 2.06× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Journaling.S3/S3JournalStorage.cs src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs— FileTooLong — 992 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 492 over it, 1.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: lib/link-audit.mjs docs/site/scripts/lib/link-audit.mjs— FileTooLong — 935 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 435 over it, 1.87× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs— FileTooLong — 912 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 412 over it, 1.82× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs— FileTooLong — 897 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 397 over it, 1.79× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: MembershipService/MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipTableManager.cs— FileTooLong — 864 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 364 over it, 1.73× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Codecs/TupleCodec.cs src/Orleans.Serialization/Codecs/TupleCodec.cs— FileTooLong — 855 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 355 over it, 1.71× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: GrainDirectory/GrainDirectoryPartition.cs src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs— FileTooLong — 835 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 335 over it, 1.67× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Diagnostics/TransactionDiagnosticEvents.cs src/Orleans.Transactions/Diagnostics/TransactionDiagnosticEvents.cs— FileTooLong — 826 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 326 over it, 1.65× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.CodeGenerator/SerializerGenerator.cs src/Orleans.CodeGenerator/SerializerGenerator.cs— FileTooLong — 793 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 293 over it, 1.59× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs— FileTooLong — 753 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 253 over it, 1.51× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: lib/source-quality.mjs docs/site/scripts/lib/source-quality.mjs— FileTooLong — 740 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 240 over it, 1.48× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Buffers/ArcBufferWriter.cs src/Orleans.Serialization/Buffers/ArcBufferWriter.cs— FileTooLong — 730 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 230 over it, 1.46× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs— FileTooLong — 693 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 193 over it, 1.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Journaling/JournaledStateManager.cs src/Orleans.Journaling/JournaledStateManager.cs— FileTooLong — 693 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 193 over it, 1.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Serialization.FSharp/FSharpCodecs.cs src/Orleans.Serialization.FSharp/FSharpCodecs.cs— FileTooLong — 688 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 188 over it, 1.38× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: TestRunners/TransactionRecoveryTestsRunner.cs src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs— FileTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 165 over it, 1.33× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Codecs/ValueTupleCodec.cs src/Orleans.Serialization/Codecs/ValueTupleCodec.cs— FileTooLong — 661 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 161 over it, 1.32× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.CodeGenerator/InvokableGenerator.cs src/Orleans.CodeGenerator/InvokableGenerator.cs— FileTooLong — 655 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 155 over it, 1.31× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Orleans.Serialization/Serializer.cs src/Orleans.Serialization/Serializer.cs— FileTooLong — 637 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 137 over it, 1.27× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
BarePragmaDisable playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:9— #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Placement.Tests/ActivationRebalancingTests/RebalancerFixture.cs:18— #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Placement.Tests/ActivationRebalancingTests/StatePreservationRebalancingTests.cs:193— #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Runtime.Internal.Tests/DependencyInjection/GenericRegistrationTests.cs:90— #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:173— #pragma warning disable SYSLIB0058 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Connections.Security/Security/TlsConnectionFeature.cs:25— #pragma warning disable SYSLIB0058 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:200— #pragma warning disable SYSLIB0058 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Core/Core/DefaultClientServices.cs:75— #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Core/Statistics/SiloRuntimeStatistics.cs:106— #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:105— #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Extensions/Orleans.Azure.Tests/Streaming/PullingAgentManagementTests.cs:51— #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestGrainInterfaces/CodegenTestInterfaces.cs:220— #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Benchmarks/Serialization/Utilities/MethodResultColumn.cs:66— #pragma warning disable CS8766 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Extensions/Orleans.DurableJobs.AzureStorage.Tests/DurableJobs/AzureStorageDurableJobsConfigurationTests.cs:13— #pragma warning disable ORLEANSEXP005 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:278— #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:294— #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:371— #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:387— #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Grains/TestInternalGrains/ReminderTestGrain2.cs:11— #pragma warning disable 612,618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Connections.Security.Tests/CertificateCreator.cs:58— #pragma warning disable SYSLIB0057 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Connections.Security.Tests/CertificateCreator.cs:71— #pragma warning disable SYSLIB0057 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs:142— #pragma warning disable 693 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs:151— #pragma warning disable 693 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Serialization.UnitTests/InvokableTestInterfaces.cs:219— #pragma warning disable 693 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable test/Orleans.Placement.Tests/PlacementFilterTests/SiloMetadataPlacementFilterTests.cs:239— #pragma warning disable ORLEANSEXP004 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
Repeated repair: src/Orleans.Reminders/ReminderService/LocalReminderService.cs src/Orleans.Reminders/ReminderService/LocalReminderService.cs:1406— src/Orleans.Reminders/ReminderService/LocalReminderService.cs changed 20 times in last 90 days and 15 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 14 (its worst body is LocalReminderData.WaitForNextTick at line 1406), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(analyzers): enforce ordinal string comparisons (#11150)”; “fix(reminders): await queued startup range changes (#11132)”; “fix(reminders): order topology reconciliation admission (#11118)”; “fix(testing): separate reminder refresh barriers (#11021)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Reminders/ReminderService/LocalReminderService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:672— src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs changed 14 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is GrainDirectoryPartition.TransferSnapshotAsync at line 672), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: report exact ring cardinality and cover range boundaries (#11221)”; “fix(directory): deactivate recovery duplicates (#11030)”; “fix(directory): preserve newer recovery registrations (#10533)”; “fix(directory): strengthen single-activation guarantees (#9958)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:518— src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs changed 11 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is DistributedGrainDirectory.ProcessMembershipUpdates at line 518), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(directory): wait for active membership during startup (#10613)”; “fix(runtime): refresh stale empty directory views (#10625)”; “fix(directory): arm lease retry before notification (#10447)”; “fix(directory): strengthen single-activation guarantees (#9958)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/MembershipService/MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipTableManager.cs:724— src/Orleans.Runtime/MembershipService/MembershipTableManager.cs changed 10 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is MembershipTableManager.GossipToOthers at line 724), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve canonical membership views (#11296)”; “fix(streaming): remove defunct stream publishers (#10532)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/MembershipService/MembershipTableManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Core/Runtime/OutsideRuntimeClient.cs src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:334— src/Orleans.Core/Runtime/OutsideRuntimeClient.cs changed 10 times in last 90 days and 7 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is OutsideRuntimeClient.ReceiveResponse at line 334), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: drain admitted client observer invocations during shutdown (#11264)”; “fix(runtime): use messaging clock for callback expiry (#11180)”; “fix(core): enforce disposable ownership (#11052)”; “fix(runtime): close callback admission during shutdown (#10290)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Core/Runtime/OutsideRuntimeClient.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:620— src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs changed 8 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is ZooKeeperBasedMembershipTable.CleanupRowAsync at line 620), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(zookeeper): make membership reads sequential and resilient (#11338)”; “fix(zookeeper): preserve membership consistency (#11316)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(zookeeper): validate clustering inputs (#11138)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs:172— src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is OrleansSiloInstanceManager.DumpSiloInstanceTable at line 172), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(azure): preserve membership consistency (#11309)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(azure): use invariant clustering text (#11107)”; “fix(azure): fence paginated membership reads (#10381)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs:61— src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is AzureBasedReminderTable.StartAsync at line 61), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(reminders): preserve cleanup failures (#11195)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”; “fix(azure): validate reminder options (#11101)”; “fix(build): resolve analyzer enforcement blockers (#11080)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs:66— src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is StreamConsumerData.SafeDisposeCursor at line 66), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert(streaming): revert drained-subscription checkpoint advancement (#11330)”; “fix(streaming): drain detached pulling-agent work (#11268)”; “fix(streaming): advance checkpoints past drained subscriptions (#11249)”; “fix(streaming): preserve prefetched recovery batches (#11149)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.DurableJobs/LocalDurableJobManager.cs src/Orleans.DurableJobs/LocalDurableJobManager.cs:310— src/Orleans.DurableJobs/LocalDurableJobManager.cs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is LocalDurableJobManager.CancelAsync at line 310), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(durable-jobs): unregister running shards during shutdown (#11301)”; “fix(durable-jobs): drain scheduling and activation on shutdown (#11256)”; “fix(durable-jobs): treat shutdown cancellation as normal (#10285)”; “fix: resolve TimeProvider via keyed DI per subsystem (#10271)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/LocalDurableJobManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs:84— src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is StreamConsumerCollection.IsInactive at line 84), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert(streaming): revert drained-subscription checkpoint advancement (#11330)”; “fix(streaming): drain detached pulling-agent work (#11268)”; “fix(streaming): advance checkpoints past drained subscriptions (#11249)”; “fix(streaming): release ADO.NET messages during queue handoff (#10574)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:73— src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is FirestoreMembershipTable.CleanupDefunctSiloEntriesAsync at line 73), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(firestore): preserve atomic membership reads (#11342)”; “fix(firestore): preserve membership consistency (#11311)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:410— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is DynamoDBMembershipTable.ParseRecord at line 410), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(aws): preserve DynamoDB membership consistency (#11310)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(aws): use invariant DynamoDB clustering text (#11051)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Azure/Shared/Storage/AzureTableDataManager.cs src/Azure/Shared/Storage/AzureTableDataManager.cs:472— src/Azure/Shared/Storage/AzureTableDataManager.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is AzureTableDataManager.DeleteTableEntriesAsync at line 472), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(build): resolve analyzer enforcement blockers (#11080)”; “fix(azure): fence paginated membership reads (#10381)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Azure/Shared/Storage/AzureTableDataManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:245— src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore at line 245), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(serialization): validate support contracts (#11174)”; “fix(serialization): validate codec arguments (#11168)”; “fix(serialization): make reflection trim-safe (#11115)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Serialization.FSharp/FSharpCodecs.cs src/Orleans.Serialization.FSharp/FSharpCodecs.cs:931— src/Orleans.Serialization.FSharp/FSharpCodecs.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is FSharpChoiceCodec.ReadValue at line 931), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(serialization): validate codec arguments (#11168)”; “fix: define CA1815 value semantics (#11166)”; “fix(analyzers): expand CA1062 library coverage (#11160)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Serialization.FSharp/FSharpCodecs.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Journaling/IJournaledStateManager.cs src/Orleans.Journaling/IJournaledStateManager.cs:16— src/Orleans.Journaling/IJournaledStateManager.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is IJournaledStateManager.DisposeAsync at line 16), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(journaling): serialize recovery retries and preserve persistence failures (#11326)”; “fix(journaling)!: recover failed operations in new activations (#11276)”; “fix(journaling): make snapshot commits and rollback atomic (#10681)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Journaling/IJournaledStateManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:194— src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is Table.Update at line 194), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve core membership invariants (#11307)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs:88— src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is ZooKeeperGatewayListProvider.GetGateways at line 88), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(zookeeper): make membership reads sequential and resilient (#11338)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(zookeeper): validate clustering inputs (#11138)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:58— src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is InMemoryMembershipTable.Update at line 58), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve core membership invariants (#11307)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”; “fix(membership): retain recently-declared-dead entries during pruning (#10269)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:64— src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is SystemTargetBasedMembershipTable.WaitForTableGrainToInit at line 64), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve core membership invariants (#11307)”; “fix(membership): preserve canonical membership views (#11296)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Core/Runtime/CallbackData.cs src/Orleans.Core/Runtime/CallbackData.cs:40— src/Orleans.Core/Runtime/CallbackData.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is CallbackData.SubscribeForCancellation at line 40), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): use messaging clock for callback expiry (#11180)”; “fix(runtime): close callback admission during shutdown (#10290)”; “fix(runtime): fault outstanding callbacks when a host shuts down (#10275)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Core/Runtime/CallbackData.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Core/Core/ClientBuilderExtensions.cs src/Orleans.Core/Core/ClientBuilderExtensions.cs:231— src/Orleans.Core/Core/ClientBuilderExtensions.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is ClientBuilderExtensions.UseLocalhostClustering at line 231), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(core): validate boundary arguments (#11178)”; “fix(core): preserve DI constructors when trimming (#11170)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Core/Core/ClientBuilderExtensions.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs:176— src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is DistributedRemoteGrainDirectory.ProcessSplitPartitionRegistrationsAsync at line 176), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(directory): strengthen single-activation guarantees (#9958)”; “fix(directory): make rolling upgrade handoffs durable (#10323)”; “fix(directory): support rolling upgrades to distributed directory (#10309)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs:78— src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is ActivationRebalancerMonitor.OnStart at line 78), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): preserve rebalancer state on shutdown (#10573)”; “fix: resolve TimeProvider via keyed DI per subsystem (#10271)”; “fix: use explicit address equality (#10257)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-23..2026-09-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-23 14:48:44 -07:00' --until='2026-09-21 14:48:44 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Sync-over-async (deadlock risk) src/Orleans.Core/Async/TaskExtensions.cs:213— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:275— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.Journaling/JournaledStateManager.cs:1097— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.Runtime/Catalog/ActivationData.cs:975— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:120— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:712— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:236— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Runtime/Placement/PlacementService.cs:491— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Runtime/Silo/Silo.cs:504— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcessSiloHandle.cs:140— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:511— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:530— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:680— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/SiloHandle.cs:65— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/StandaloneSiloHandle.cs:353— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:324— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:553— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:708— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:1246— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Orleans.Connections.Security/Security/DuplexPipeStream.cs:47— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Connections.Security/Security/DuplexPipeStream.cs:63— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Connections.Security/Security/DuplexPipeStream.cs:136— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Connections.Security/Security/DuplexPipeStream.cs:189— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Connections.Security/Security/DuplexPipeStream.cs:202— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs:619— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
MethodTooLong: JournaledStateManager.WorkLoop src/Orleans.Journaling/JournaledStateManager.cs:187— MethodTooLong — WorkLoop runs 202 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 102 over it, 2.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:438— MethodTooLong — TransactionWillRecoverAfterRandomSiloFailure runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: LibraryTypes.LibraryTypes(…) src/Orleans.CodeGenerator/LibraryTypes.cs:15— MethodTooLong — LibraryTypes(…) runs 167 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 67 over it, 1.67× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Silo.render src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:132— MethodTooLong — render runs 164 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 64 over it, 1.64× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ActivationData.ActivateAsync src/Orleans.Runtime/Catalog/ActivationData.cs:1760— MethodTooLong — ActivateAsync runs 162 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 62 over it, 1.62× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22— MethodTooLong — ExtractReferenceAssemblyData runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ServiceCollectionExtensions.MapOrleansDashboard src/Dashboard/Orleans.Dashboard/ServiceCollectionExtensions.cs:93— MethodTooLong — MapOrleansDashboard runs 149 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 49 over it, 1.49× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ActivationData.RunMessageLoop src/Orleans.Runtime/Catalog/ActivationData.cs:1111— MethodTooLong — RunMessageLoop runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PersistentStreamPullingAgent.RunConsumerCursor src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248— MethodTooLong — RunConsumerCursor runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: OrleansSerializationSourceGenerator.Initialize src/Orleans.CodeGenerator/OrleansSourceGenerator.cs:32— MethodTooLong — Initialize runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TransactionQueue.NotifyOfAbort src/Orleans.Transactions/State/TransactionQueue.cs:310— MethodTooLong — NotifyOfAbort runs 133 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 33 over it, 1.33× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ShardExecutor.ExecuteJobAsync src/Orleans.DurableJobs/ShardExecutor.cs:309— MethodTooLong — ExecuteJobAsync runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ProxyGenerator.CreateProxyMethods src/Orleans.CodeGenerator/ProxyGenerator.cs:85— MethodTooLong — CreateProxyMethods runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Overview.render src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:85— MethodTooLong — render runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Impl.AnalyzeNamedType src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308— MethodTooLong — AnalyzeNamedType runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229— MethodTooLong — TransactionWillRecoverAfterTargetedPhase runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: TransactionRecoveryEventObserver.TryCreateTransition src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs:335— MethodTooLong — TryCreateTransition runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Identifier.IsCSharpKeyword src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs:7— MethodTooLong — IsCSharpKeyword runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SerializerGenerator.GenerateDeserializeMethod src/Orleans.CodeGenerator/SerializerGenerator.cs:539— MethodTooLong — GenerateDeserializeMethod runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DynamoDBTransactionalStateStorage.Store src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144— MethodTooLong — Store runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: InvokableBaseTypeResolver.SatisfiesConstraints src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:628— MethodTooLong — SatisfiesConstraints runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ActivationRepartitioner.AcceptExchangeRequest src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:270— MethodTooLong — AcceptExchangeRequest runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Duplicated block (8 lines × 2) src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:57— src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:57-64 | src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:80-87 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169— src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169-176 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:204-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:421— src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:421-428 | src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:436-443 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:57— src/Orleans.Core/Core/DefaultClientServices.cs:57-65 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:78-85 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:52— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:52-59 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:46-53 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 117 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `IOptions<MessagePackCodecOptions>` in one and `IOptions<JsonCodecOptions>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:20— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:20-27 | src/Orleans.Serialization/Codecs/DictionaryCodec.cs:229-236 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:20` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:164— src/Orleans.Serialization/Codecs/TupleCodec.cs:164-171 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:184-191 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:164` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:313— src/Orleans.Serialization/Codecs/TupleCodec.cs:313-320 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:302-309 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:313` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1097— src/Orleans.Serialization/Codecs/TupleCodec.cs:1097-1104 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:921-928 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1097` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1183— src/Orleans.Serialization/Codecs/TupleCodec.cs:1183-1190 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1427-1434 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1336— src/Orleans.Serialization/Codecs/TupleCodec.cs:1336-1343 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1112-1119 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1336` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1428— src/Orleans.Serialization/Codecs/TupleCodec.cs:1428-1435 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1173-1180 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:979— src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:979-986 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1172-1179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:979` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:60— src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:60-67 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:68-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86— src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86-93 | src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:115-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:49— src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:49-56 | src/Orleans.Streaming/PubSub/DefaultStreamNamespacePredicateProvider.cs:49-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:204— src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:204-211 | src/Orleans.Runtime/Catalog/IncomingRequestMonitor.cs:54-61 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:979— src/Orleans.Serialization/Codecs/TupleCodec.cs:979-986 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:824-831 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) src/Orleans.TestingHost/InProcessSiloHandle.cs:93— src/Orleans.TestingHost/InProcessSiloHandle.cs:93-101 | src/Orleans.TestingHost/StandaloneSiloHandle.cs:302-309 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisBatchContainer.cs:74— src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisBatchContainer.cs:74-81 | src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubBatchContainer.cs:90-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:95— src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:95-103 | src/Orleans.Transactions.TestKit.Base/TestRunners/GrainFaultTransactionTestRunner.cs:128-135 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:82— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:82-89 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:99-106 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
X20 · Mistyped argument guard· Argument guard throws the exception its own condition disproves · ×20
Argument guard throws the exception its own condition disproves src/Orleans.Core.Abstractions/Manifest/MajorMinorVersion.cs:73— The guard on line 73 rejects `value` and line 73 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Reminders/GrainReminderExtensions.cs:81— The guard on line 81 rejects `reminderName` and line 81 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Reminders/GrainReminderExtensions.cs:160— The guard on line 160 rejects `reminderName` and line 160 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Serialization/TypeSystem/TypeSpec.cs:277— The guard on line 275 rejects `assembly` and line 277 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(assembly)` is true of a value that is NOT null: it is satisfied by an EMPTY `assembly`, and on that path `assembly` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Serialization/TypeSystem/TypeSpec.cs:380— The guard on line 378 rejects `value` and line 380 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Streaming/GrainStreamingExtensions.cs:33— The guard on line 31 rejects `name` and line 33 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Streaming/GrainStreamingExtensions.cs:63— The guard on line 61 rejects `name` and line 63 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:109— The guard on line 109 rejects `name` and line 109 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:67— The guard on line 65 rejects `strProviderName` and line 67 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(strProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `strProviderName`, and on that path `strProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Orleans.Streaming/QueueAdapters/BatchContainerBatch.cs:43— The guard on line 41 rejects `batchContainers` and line 43 reports that rejection as `ArgumentNullException` — but the condition's own test `!batchContainers.Any()` is true of a value that is NOT null: it is satisfied by an EMPTY `batchContainers`, and on that path `batchContainers` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:45— The guard on line 43 rejects `invariantName` and line 45 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:107— The guard on line 105 rejects `invariantName` and line 107 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:112— The guard on line 110 rejects `connectionString` and line 112 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:78— The guard on line 78 rejects `dataConnectionString` and line 78 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(dataConnectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `dataConnectionString`, and on that path `dataConnectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapter.cs:35— The guard on line 35 rejects `serviceId` and line 35 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapterReceiver.cs:34— The guard on line 34 rejects `serviceId` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Azure/Shared/Storage/AzureStorageOperationOptions.cs:128— The guard on line 128 rejects `connectionString` and line 128 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamOptions.cs:77— The guard on line 77 rejects `connectionString` and line 77 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:36— The guard on line 34 rejects `clusterId` and line 36 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(clusterId)` is true of a value that is NOT null: it is satisfied by an EMPTY `clusterId`, and on that path `clusterId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:104— The guard on line 102 rejects `streamProviderName` and line 104 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(streamProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `streamProviderName`, and on that path `streamProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Duplicated block (10 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470— src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470-1479 | src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1510-1521 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:97— src/Orleans.BroadcastChannel/ChannelId.cs:97-106 | src/Orleans.Streaming/StreamId.cs:104-113 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/ChannelId.cs:97` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `ns` to `string` in one and `string?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:247— src/Orleans.Core/Core/DefaultClientServices.cs:247-256 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:531-540 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) src/Orleans.Runtime/Silo/SiloControl.cs:133— src/Orleans.Runtime/Silo/SiloControl.cs:133-143 | src/Orleans.Runtime/Silo/SiloControl.cs:374-383 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Silo/SiloControl.cs:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1308— src/Orleans.Serialization/Codecs/TupleCodec.cs:1308-1317 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1088-1097 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1457— src/Orleans.Serialization/Codecs/TupleCodec.cs:1457-1466 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1202-1211 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:183— src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:183-192 | src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:203-212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:183` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:23— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:23-32 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:24-33 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:23` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:517— src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:517-526 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:441-451 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:517` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:210— src/Orleans.CodeGenerator/CopierGenerator.cs:210-219 | src/Orleans.CodeGenerator/SerializerGenerator.cs:238-247 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:78— src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:78-87 | src/Orleans.Core/Messaging/CachingSiloAddressCodec.cs:87-96 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/Orleans.Core/Runtime/ClientGrainContext.cs:135— src/Orleans.Core/Runtime/ClientGrainContext.cs:135-144 | src/Orleans.Runtime/Core/HostedClient.cs:387-396 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:255— src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:255-264 | src/Orleans.Runtime/MembershipService/ClusterMembershipSnapshot.cs:189-198 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:918— src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:918-927 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:908-917 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:936— src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:936-945 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:920-929 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Serialization/Codecs/ObjectCodec.cs:69— src/Orleans.Serialization/Codecs/ObjectCodec.cs:69-78 | src/Orleans.Serialization/Serializers/AbstractTypeSerializer.cs:63-72 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) src/Orleans.Streaming/Common/EventSequenceToken.cs:110— src/Orleans.Streaming/Common/EventSequenceToken.cs:110-119 | src/Orleans.Streaming/Common/EventSequenceTokenV2.cs:109-118 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:220— src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:220-229 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:228-237 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Orleans.TestingHost/TestClusterHostFactory.cs:136— src/Orleans.TestingHost/TestClusterHostFactory.cs:136-145 | src/Orleans.TestingHost/TestClusterHostFactory.cs:153-162 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/TestClusterHostFactory.cs:136` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:447— src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:447-455 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:1347-1355 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:447` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:915— src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:915-923 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:954-962 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:915` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:27— src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:27-35 | src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:115-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:757— src/Orleans.CodeGenerator/SerializerGenerator.cs:757-765 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1006-1014 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerGenerator.cs:757` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:35— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:35-43 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:33-41 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:23— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:23-31 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:21-29 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) src/Orleans.Serialization/Buffers/Writer.cs:378— src/Orleans.Serialization/Buffers/Writer.cs:378-386 | src/Orleans.Serialization/Buffers/Writer.cs:407-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:378` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `uint` in one and `ulong` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:107— src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:107-115 | src/Orleans.Serialization/Codecs/SortedListCodec.cs:115-123 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:107` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:278— src/Orleans.Serialization/Codecs/TupleCodec.cs:278-286 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:268-276 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:278` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1070— src/Orleans.Serialization/Codecs/TupleCodec.cs:1070-1078 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:899-907 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1210— src/Orleans.Serialization/Codecs/TupleCodec.cs:1210-1218 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1006-1014 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:223— src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:223-231 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:238-246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:238` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:237` calls `WriteField`, `Format`, `GetType` and `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:222` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:193— src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:193-201 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:197-205 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:118— src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:118-126 | src/Redis/Orleans.Clustering.Redis/Providers/RedisGatewayListProvider.cs:29-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:128— src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:128-136 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:116-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:213— src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:213-221 | src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:337-345 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:213` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/Orleans.Core/Manifest/ClientManifestProvider.cs:59— src/Orleans.Core/Manifest/ClientManifestProvider.cs:59-67 | src/Orleans.Runtime/Manifest/SiloManifestProvider.cs:95-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:285— src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:285-293 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:55-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) src/Orleans.Runtime/Catalog/GrainTypeSharedContext.cs:214— src/Orleans.Runtime/Catalog/GrainTypeSharedContext.cs:214-222 | src/Orleans.Runtime/Core/SystemTarget.cs:133-146 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:990— src/Orleans.CodeGenerator/SerializerGenerator.cs:990-1002 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1073-1085 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerGenerator.cs:990` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:739— src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:739-751 | src/Orleans.Transactions/TransactionAttribute.cs:617-629 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:739` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:90— src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:90-102 | src/Orleans.Core/Manifest/ImplementedInterfaceProvider.cs:52-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102-114 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:97-109 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableDictionaryCommandHandler<TKey, TValue>` in one and `IDurableSetCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:110— src/Orleans.Serialization/Codecs/CollectionCodec.cs:110-122 | src/Orleans.Serialization/Codecs/ListCodec.cs:109-121 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:110` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:132— src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:132-144 | src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:165-177 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:132` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:250— src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:250-262 | src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:253-265 — before extracting anything, compare `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs` and `src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 139 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38-50 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:52-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:74— src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:74-86 | src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs:71-83 — before extracting anything, compare `src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs` and `src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:125— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:125-137 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:159-171 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:218— src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:218-230 | src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:252-264 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:218` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 2) src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:284— src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:284-296 | src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:304-316 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:284` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:30— src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:30-42 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:39-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:30` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) src/Orleans.Streaming/Internal/PeriodicAction.cs:12— src/Orleans.Streaming/Internal/PeriodicAction.cs:12-24 | src/Orleans.Transactions/Utilities/PeriodicAction.cs:12-24 — before extracting anything, compare `src/Orleans.Streaming/Internal/PeriodicAction.cs` and `src/Orleans.Transactions/Utilities/PeriodicAction.cs` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs:102— src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs:102-114 | src/Orleans.Streaming/QueueAdapters/IQueueCacheCursor.cs:42-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13 lines × 2) samples/Deployment/AzureAppService/Silo/Components/ProductTable.razor:61— samples/Deployment/AzureAppService/Silo/Components/ProductTable.razor:61-73 | samples/ShoppingCart/Silo/Components/ProductTable.razor:70-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241-253 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:345-357 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×14
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102-1172 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1405-1459 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1468-1531 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1538-1585 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129— src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129-140 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:56-67 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:59-70 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:88-99 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:639— src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:639-655 | src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:785-801 | src/Orleans.Transactions/TransactionAttribute.cs:500-516 | src/Orleans.Transactions/TransactionAttribute.cs:669-686 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:119— src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:119-161 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:244-274 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:362-392 | src/Orleans.Journaling/Formats/Json/JsonDurableDictionaryCommandCodec.cs:103-136 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57-75 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:82-100 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:53-71 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:55-73 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64-97 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:60-82 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:58-96 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:243-275 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101-157 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:85-130 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:100-173 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:168-232 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ArrayCodec.cs:58— src/Orleans.Serialization/Codecs/ArrayCodec.cs:58-116 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:213-265 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:373-425 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:536-588 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:1210— src/Orleans.Serialization/Codecs/TupleCodec.cs:1210-1218 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1457-1466 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1006-1014 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1202-1211 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:18— src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:18-39 | src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:42-63 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:18-45 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:17-38 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:15— src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:15-79 | src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:82-146 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:18-106 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:13-77 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:288— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:288-380 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:473-590 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:321-391 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:470-568 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89— src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89-104 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:124-137 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:200-218 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:270-286 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:92— src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:92-115 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:124-154 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:188-210 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:219-241 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (7 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:120— src/Orleans.BroadcastChannel/ChannelId.cs:120-126 | src/Orleans.Streaming/StreamId.cs:132-138 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `ns` to `string` in one and `string?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:239— src/Orleans.Core/Core/DefaultClientServices.cs:239-245 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:523-529 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) src/Orleans.Runtime/Catalog/ActivationData.cs:1927— src/Orleans.Runtime/Catalog/ActivationData.cs:1927-1933 | src/Orleans.Runtime/Catalog/ActivationData.cs:2079-2085 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Catalog/ActivationData.cs:1927` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Runtime/Catalog/ActivationData.cs:2086` calls `SetTag`, `ToString` and `src/Orleans.Runtime/Catalog/ActivationData.cs:1934` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:50— src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:50-56 | src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:62-68 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:50` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/StackCodec.cs:151— src/Orleans.Serialization/Codecs/StackCodec.cs:151-157 | src/Orleans.Serialization/Codecs/StackCodec.cs:167-174 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:482— src/Orleans.Serialization/Codecs/TupleCodec.cs:482-488 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:437-443 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:482` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:670— src/Orleans.Serialization/Codecs/TupleCodec.cs:670-676 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:584-590 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:670` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:875— src/Orleans.Serialization/Codecs/TupleCodec.cs:875-881 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:745-752 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:875` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:112— src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:112-118 | src/Orleans.Streaming/MemoryStreams/MemoryAdapterFactory.cs:118-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:253— src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:253-259 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:261-267 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:138— src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:138-144 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:129-135 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:766— src/Orleans.Serialization/Codecs/TupleCodec.cs:766-772 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:657-663 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) src/Orleans.Clustering.ZooKeeper/MembershipSerializerSettings.cs:67— src/Orleans.Clustering.ZooKeeper/MembershipSerializerSettings.cs:67-73 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:82-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:14— class BufferTestHelper — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:36— class BufferTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:66— class MultiSegmentBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:86— class StructBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:114— class PooledBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/CopierTester.cs:19— class CopierTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/FieldCodecTester.cs:27— class FieldCodecTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/ReadOnlySequenceHelper.cs:12— class ReadOnlySequenceHelper — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/SerializationTester.cs:11— class SerializationTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/SerializationTester.cs:138— class SerializationTesterFixture — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/TestBufferWriterStruct.cs:12— struct TestBufferWriterStruct — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Orleans.Serialization.TestKit/TestMultiSegmentBufferWriter.cs:13— class TestMultiSegmentBufferWriter — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
Duplicated block (11 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:288— src/Orleans.CodeGenerator/CopierGenerator.cs:288-298 | src/Orleans.CodeGenerator/SerializerGenerator.cs:379-389 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:339— src/Orleans.CodeGenerator/CopierGenerator.cs:339-349 | src/Orleans.CodeGenerator/SerializerGenerator.cs:336-346 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:339` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:183— src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:183-193 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:256-266 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:183` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:27— src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:27-37 | src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1310-1320 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:27` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1260— src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1260-1270 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:545-555 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1260` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) src/Orleans.Serialization/Invocation/Response.cs:264— src/Orleans.Serialization/Invocation/Response.cs:264-274 | src/Orleans.Serialization/Invocation/Response.cs:287-297 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Invocation/Response.cs:264` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:128— src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:128-138 | src/Orleans.Streaming/MemoryStreams/MemoryAdapterFactory.cs:131-141 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:341— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:341-351 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:547-557 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:341` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (11 lines × 2) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476— src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476-486 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:509-519 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:122— src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:122-132 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:123-133 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:578— src/Orleans.TestingHost/InProcTestCluster.cs:578-588 | src/Orleans.TestingHost/TestCluster.cs:589-599 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:578` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionAzureTableTransactionStateStorage.cs:56— src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionAzureTableTransactionStateStorage.cs:56-66 | src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionDynamoDBTransactionStateStorage.cs:58-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:29— src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:29-50 | src/Orleans.Streaming/Core/DefaultStreamIdMapper.cs:27-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:29` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `streamId` to `ChannelId` in one and `StreamId` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (22 lines × 2) src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:51— src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:51-72 | src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:128-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:128` calls `GetGeneratedInvokables`, `ToImmutableArray` and `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:51` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (22 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryJournalFormat.cs:200— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryJournalFormat.cs:200-221 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryV0JournalReader.cs:58-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryJournalFormat.cs:200` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) src/Orleans.Runtime/Catalog/ActivationData.cs:1057— src/Orleans.Runtime/Catalog/ActivationData.cs:1057-1078 | src/Orleans.Runtime/Core/SystemTarget.cs:273-294 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:413— src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:413-434 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:546-567 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:413` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/Orleans.Serialization/Codecs/QueueCodec.cs:32— src/Orleans.Serialization/Codecs/QueueCodec.cs:32-53 | src/Orleans.Serialization/Codecs/StackCodec.cs:35-56 — before extracting anything, compare `src/Orleans.Serialization/Codecs/QueueCodec.cs` and `src/Orleans.Serialization/Codecs/StackCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/Codecs/StackCodec.cs:33` calls `MethodImpl` and `src/Orleans.Serialization/Codecs/QueueCodec.cs:28` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (22 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:57— src/Orleans.Serialization/Codecs/TupleCodec.cs:57-78 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:79-100 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (22 lines × 2) src/Orleans.Serialization/Serializer.cs:117— src/Orleans.Serialization/Serializer.cs:117-138 | src/Orleans.Serialization/Serializer.cs:151-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) src/Orleans.Serialization/Serializer.cs:1210— src/Orleans.Serialization/Serializer.cs:1210-1231 | src/Orleans.Serialization/Serializer.cs:1243-1264 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:1210` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:565— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:565-586 | src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:348-369 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:565` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:371` calls `ConstructRowKey` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:588` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (22 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:652— src/Orleans.TestingHost/InProcTestCluster.cs:652-673 | src/Orleans.TestingHost/TestCluster.cs:680-701 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:189— src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:189-202 | src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:385-398 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:220— src/Orleans.Core/Core/DefaultClientServices.cs:220-233 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:504-517 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Core/DefaultClientServices.cs:220` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14 lines × 2) src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:88— src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:88-101 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:157-170 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:88` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:65— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:65-78 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:59-78 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 117 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Orleans.Serialization/Buffers/Writer.cs:482— src/Orleans.Serialization/Buffers/Writer.cs:482-495 | src/Orleans.Serialization/Buffers/Writer.cs:507-520 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:482` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `uint` in one and `ulong` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1144— src/Orleans.Serialization/Codecs/TupleCodec.cs:1144-1157 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1384-1397 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:1399` calls `ReadValue` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:1158` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:43— src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:43-56 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:37-50 — before extracting anything, compare `src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123— src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123-136 | src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:160-173 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:93— src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:93-106 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:87-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:93` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:11— src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:11-24 | src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1294-1307 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (14 lines × 2) samples/Deployment/AzureAppService/Silo/Components/PurchasableProductTable.razor:53— samples/Deployment/AzureAppService/Silo/Components/PurchasableProductTable.razor:53-66 | samples/ShoppingCart/Silo/Components/PurchasableProductTable.razor:53-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `samples/Deployment/AzureAppService/Silo/Components/PurchasableProductTable.razor:53` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:60— src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:60-71 | src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:74-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Orleans.Serialization/Buffers/Reader.cs:1187— src/Orleans.Serialization/Buffers/Reader.cs:1187-1198 | src/Orleans.Serialization/Buffers/Reader.cs:1202-1213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Reader.cs:1187` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 2) src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:100— src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:100-111 | src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:124-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) src/Orleans.Serialization/ISerializableSerializer/SerializationCallbacksFactory.cs:141— src/Orleans.Serialization/ISerializableSerializer/SerializationCallbacksFactory.cs:141-152 | src/Orleans.Serialization/ISerializableSerializer/SerializationConstructorFactory.cs:120-131 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/ISerializableSerializer/SerializationConstructorFactory.cs:131` calls `Emit` and `src/Orleans.Serialization/ISerializableSerializer/SerializationCallbacksFactory.cs:152` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/Orleans.Serialization/Serializer.cs:1469— src/Orleans.Serialization/Serializer.cs:1469-1480 | src/Orleans.Serialization/Serializer.cs:1501-1512 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:1469` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134— src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134-145 | src/Orleans.Serialization/TypeSystem/TypeCodec.cs:164-175 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 2) src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:54— src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:54-65 | src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs:51-62 — before extracting anything, compare `src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs` and `src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:684— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:684-695 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:695-706 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:684` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:385— src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:385-396 | src/Redis/Orleans.Streaming.Redis/Storage/RedisStreamStorage.cs:176-187 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:42— src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:42-53 | src/Orleans.TestingHost/TestClusterOptions.cs:199-210 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs` and `src/Orleans.TestingHost/TestClusterOptions.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:42` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `testCluster` to `InProcessTestCluster` in one and `TestCluster` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor:27— samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor:27-38 | samples/ShoppingCart/Silo/Shared/NavMenu.razor:21-32 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor` and `samples/ShoppingCart/Silo/Shared/NavMenu.razor` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Unfinished stub — throws NotImplementedException src/Orleans.Core/Runtime/InvokableObjectManager.cs:152— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs:85— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:100— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:102— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:426— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Duplicated block (17 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:181— src/Orleans.CodeGenerator/CopierGenerator.cs:181-197 | src/Orleans.CodeGenerator/SerializerGenerator.cs:210-226 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:181` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Orleans.CodeGenerator/InvokableGenerator.cs:450— src/Orleans.CodeGenerator/InvokableGenerator.cs:450-466 | src/Orleans.CodeGenerator/InvokableGenerator.cs:511-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/InvokableGenerator.cs:450` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.CodeGenerator/InvokableGenerator.cs:510` calls `IdentifierName` and `src/Orleans.CodeGenerator/InvokableGenerator.cs:448` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:63— src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:63-79 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:159-175 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17 lines × 2) src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:56— src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:56-72 | src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:84-100 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:84` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91-107 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:544-560 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:93— src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:93-109 | src/Orleans.Serialization/Codecs/ImmutableSortedDictionaryCodec.cs:98-114 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:289— src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:289-305 | src/Orleans.Serialization/Codecs/ListCodec.cs:59-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:289` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1034— src/Orleans.Serialization/Codecs/TupleCodec.cs:1034-1050 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:863-879 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1034` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:491— src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:491-507 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:266-282 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68— playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68-83 | playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:96-111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:67` calls `AddSample` and `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:95` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:60— src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:60-75 | src/Orleans.Streaming/PubSub/DefaultStreamNamespacePredicateProvider.cs:60-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `predicate` to `out IChannelNamespacePredicate?` in one and `out IStreamNamespacePredicate` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:873— src/Orleans.CodeGenerator/SerializerGenerator.cs:873-888 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1036-1051 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerGenerator.cs:873` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:688— src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:688-703 | src/Orleans.Transactions/TransactionAttribute.cs:557-572 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:56— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:56-71 | src/Orleans.Serialization/Codecs/DictionaryCodec.cs:258-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2) src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:70— src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:70-85 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:72-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1271— src/Orleans.Serialization/Codecs/TupleCodec.cs:1271-1286 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1051-1066 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (16 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:357— src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:357-372 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:518-533 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:357` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (16 lines × 2) samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor:37— samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor:37-52 | samples/ShoppingCart/Silo/Components/ShoppingCartItem.razor:37-52 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor` and `samples/ShoppingCart/Silo/Components/ShoppingCartItem.razor` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1179— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1179-1193 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1221-1235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1179` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:639— src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:639-653 | src/Orleans.Transactions/TransactionAttribute.cs:500-514 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:639` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/Orleans.Core/Async/TaskExtensions.cs:217— src/Orleans.Core/Async/TaskExtensions.cs:217-231 | src/Orleans.TestingHost/StandaloneSiloHost.cs:166-180 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (15 lines × 2) src/Orleans.Core/Runtime/ClientGrainContext.cs:117— src/Orleans.Core/Runtime/ClientGrainContext.cs:117-131 | src/Orleans.Runtime/Core/HostedClient.cs:369-383 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:83— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:83-97 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:82-96 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 117 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:83` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Orleans.Serialization/Codecs/ArrayCodec.cs:308— src/Orleans.Serialization/Codecs/ArrayCodec.cs:308-322 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:468-482 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ArrayCodec.cs:308` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `input` to `ReadOnlyMemory<T>` in one and `Memory<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15 lines × 2) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77— src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77-91 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:376-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:399— src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:399-413 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:163-177 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:399` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:157— src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:157-171 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:161-175 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414— src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414-419 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:1347-1352 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162— src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162-167 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:197-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entries` to `ImmutableArray<SerializableTypeModel>` in one and `ImmutableArray<ProxyInterfaceModel>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77— src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77-82 | src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:85-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/ActivatorGenerator.cs:107— src/Orleans.CodeGenerator/ActivatorGenerator.cs:107-112 | src/Orleans.CodeGenerator/ProxyGenerator.cs:548-553 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:221— src/Orleans.CodeGenerator/CopierGenerator.cs:221-226 | src/Orleans.CodeGenerator/SerializerGenerator.cs:249-254 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:27— src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:27-32 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:28-33 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:297— src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:297-302 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:66-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:570— src/Orleans.Serialization/Codecs/TupleCodec.cs:570-575 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:505-510 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1089— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1089-1094 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1227-1232 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Off the main sequence: ChaoticCluster.ServiceDefaults — ChaoticCluster.ServiceDefaults: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: DurableJobsJournaling.ServiceDefaults — DurableJobsJournaling.ServiceDefaults: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: Orleans.Dashboard.Abstractions(net8.0) — Orleans.Dashboard.Abstractions(net8.0): abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: Orleans.Analyzers.Contracts — Orleans.Analyzers.Contracts: abstractness 0.04, instability 0.00, distance 0.96 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: Orleans.Serialization.Abstractions(net8.0) — Orleans.Serialization.Abstractions(net8.0): abstractness 0.06, instability 0.00, distance 0.94 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: Orleans.CodeGenerator — Orleans.CodeGenerator: abstractness 0.08, instability 0.00, distance 0.92 — zone of pain — concrete and depended on by 6 project(s), so it's rigid to change.
Off the main sequence: Orleans.Persistence.Memory(net8.0) — Orleans.Persistence.Memory(net8.0): abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: Orleans.Runtime(net8.0) — Orleans.Runtime(net8.0): abstractness 0.20, instability 0.02, distance 0.78 — zone of pain — concrete and depended on by 40 project(s), so it's rigid to change.
Off the main sequence: Orleans.Serialization(net8.0) — Orleans.Serialization(net8.0): abstractness 0.15, instability 0.11, distance 0.74 — zone of pain — concrete and depended on by 8 project(s), so it's rigid to change.
Unfinished stub — throws NotImplementedException src/Orleans.Core/Runtime/InvokableObjectManager.cs:152— `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80— `ActivationServices` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82— `ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84— `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137— `GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:100— `ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:102— `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:426— `GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14— `WriteField` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Duplicated block (21 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:124— src/Orleans.CodeGenerator/CopierGenerator.cs:124-144 | src/Orleans.CodeGenerator/SerializerGenerator.cs:160-180 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:124` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:535— src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:535-555 | src/Orleans.Runtime/Core/InsideRuntimeClient.cs:624-644 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:535` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:286— src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:286-306 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:254-274 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 47 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/ArrayCodec.cs:188— src/Orleans.Serialization/Codecs/ArrayCodec.cs:188-208 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:348-368 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:80— src/Orleans.Serialization/Codecs/CollectionCodec.cs:80-100 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:88-108 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:80` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/HashSetCodec.cs:66— src/Orleans.Serialization/Codecs/HashSetCodec.cs:66-86 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:407-427 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/HashSetCodec.cs:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1406— src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1406-1426 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1000-1020 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:43— playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:43-63 | playground/DurableJobsJournaling/DurableJobsJournaling.ServiceDefaults/Extensions.cs:53-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D10 · Test Quality· Fixed-sleep synchronisation · ×7
Fixed-sleep synchronisation: RequestContext_MultiThreads_ExportToMessage test/Orleans.Core.Tests/General/RequestContextTestsNonSiloRequired.cs:43— This test starts a background task and then orders itself against it with `Thread.Sleep(1)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: ObservableGrain_AsyncEnumerable_CancelBeforeYield test/Orleans.DefaultCluster.Tests/AsyncEnumerableGrainCallTests.cs:92— This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(10))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: DeactivateOnIdleTest_Stress_2_NonReentrant test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/DeactivateOnIdleTests.cs:91— This test starts a background task and then orders itself against it with `Task.Delay(1)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: DeactivateOnIdleTest_Stress_3_Reentrant test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/DeactivateOnIdleTests.cs:117— This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(1))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: Halo_RequestContextShouldBeMaintainedWhenThreadHoppingOccurs test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs:346— This test starts a background task and then orders itself against it with `Task.Delay(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: Halo_LogicalCallContextShouldBeMaintainedWhenThreadHoppingOccurs test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs:397— This test starts a background task and then orders itself against it with `Task.Delay(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: StuckGrainTest_StuckDetectionOnDeactivation test/Orleans.Runtime.Internal.Tests/OrleansRuntime/StuckGrainTests.cs:109— This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(500))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
ClassTooLong: SerializerGenerator src/Orleans.CodeGenerator/SerializerGenerator.cs— ClassTooLong — 639 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 239 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TransactionRecoveryTestsRunner src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs— ClassTooLong — 613 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 213 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: InvokableGenerator src/Orleans.CodeGenerator/InvokableGenerator.cs— ClassTooLong — 588 significant lines (blank, comment-only and punctuation-only lines excluded), 29 methods. The bar is 400 significant lines; this is 188 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Reader src/Orleans.Serialization/Buffers/Reader.cs— ClassTooLong — 461 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. The bar is 400 significant lines; this is 61 over it, 1.15× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ClusterManifestProvider src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs— ClassTooLong — 445 significant lines (blank, comment-only and punctuation-only lines excluded), 29 methods. The bar is 400 significant lines; this is 45 over it, 1.11× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TransactionalStateStorageTestRunner src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs— ClassTooLong — 426 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 26 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CopierGenerator src/Orleans.CodeGenerator/CopierGenerator.cs— ClassTooLong — 411 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 11 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Duplicated block (18 lines × 2) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:441— src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:441-458 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:323-340 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:61— src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:61-78 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:244-261 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18 lines × 2) src/Orleans.Serialization/Serializers/CodecProvider.cs:113— src/Orleans.Serialization/Serializers/CodecProvider.cs:113-130 | src/Orleans.Serialization/TypeSystem/TypeConverter.cs:175-192 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializers/CodecProvider.cs:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29-46 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:36-53 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (18 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36-53 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:39-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:40— src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:40-57 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:81-98 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:388— src/Orleans.TestingHost/InProcTestCluster.cs:388-405 | src/Orleans.TestingHost/TestCluster.cs:473-490 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:388` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93— src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93-97 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:166-170 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:109— src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:109-113 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:76-81 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:76` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (5 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:56— src/Orleans.BroadcastChannel/ChannelId.cs:56-60 | src/Orleans.Streaming/StreamId.cs:63-67 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:266— src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:266-270 | src/Orleans.Runtime/MembershipService/ClusterMembershipSnapshot.cs:200-204 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/Orleans.EventSourcing/Hosting/LogStorageSiloBuilderExtensions.cs:38— src/Orleans.EventSourcing/Hosting/LogStorageSiloBuilderExtensions.cs:38-42 | src/Orleans.EventSourcing/Hosting/StateStorageSiloBuilderExtensions.cs:38-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (5 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:174— src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:174-178 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:178-182 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:381— src/Orleans.TestingHost/InProcTestCluster.cs:381-385 | src/Orleans.TestingHost/InProcTestCluster.cs:412-416 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:381` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×7
Disposable created and abandoned in the method that made it src/Orleans.Core/Networking/Connection.cs:178— `task` is a `Task`, which implements `IDisposable`, and it is created here (line 178). Every use of it in `StartClosing` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:346— `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 346). Every use of it in `CreateWorker` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.Runtime/MembershipService/ClusterMembershipService.cs:108— `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Participate` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:15— `task` is a `Task`, which implements `IDisposable`, and it is created here (line 15). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:24— `task` is a `Task`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.Streaming/Providers/SiloStreamProviderRuntime.cs:80— `manager` is a `PersistentStreamPullingManager`, which implements `IDisposable`, and it is created here (line 80). Every use of it in `InitializePullingAgents` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var manager = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Orleans.TestingHost/TestClusterPortAllocator.cs:191— `signal` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 191). Every use of it in `Acquire` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var signal = …;`), which releases it at the end of the scope on every path including a throw.
BareSuppressMessage src/Azure/Orleans.Streaming.AzureStorage/Storage/AzureQueueDataManager.cs:63— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Azure/Shared/Storage/AzureTableUtils.cs:100— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Orleans.Core.Abstractions/IDs/Legacy/LegacyGrainId.cs:22— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Orleans.Core/Messaging/GatewayManager.cs:237— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Orleans.Runtime/Silo/SiloControl.cs:94— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage test/Orleans.Runtime.Internal.Tests/StorageTests/CommonStorageTests.cs:32— System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
Change coupling: ConsistentRingProvider.cs ↔ VirtualBucketsRingProvider.cs src/Orleans.Runtime/ConsistentRing/ConsistentRingProvider.cs— `src/Orleans.Runtime/ConsistentRing/ConsistentRingProvider.cs` and `src/Orleans.Runtime/ConsistentRing/VirtualBucketsRingProvider.cs` change together 67% of the time (8 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `cad1d512` fix(runtime): order ring range notifications (#11182); `70085a8f` Unsubscribe `ConsistentRingProvider` & `VirtualBucketsRingProvider` f…; `bbf13919` IConsistentRingProvider implementations should notify immediately on … — run `git show` on any of them.
Change coupling: SerializableTypeDescription.cs ↔ SerializerGenerator.cs src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs— `src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs` and `src/Orleans.CodeGenerator/SerializerGenerator.cs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `e81a265c` CodeGenerator: clean up attribute handling and remove obsolete custom…; `62b0b27c` Fix serialization for records which have no properties of their own (…; `e0d3073c` Add new SerializerTransparentAttribute for abstract classes (#8015) — run `git show` on any of them.
Change coupling: SimpleQueueCache.cs ↔ PersistentStreamPullingAgent.cs src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCache.cs— `src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCache.cs` and `src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs` change together 57% of the time (12 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `d42e0183` fix(streaming): recover legacy sequence tokens (#11155); `5b42a3a7` refactor(streaming): add typed cache cursor results (#9714); `a1c73151` chore(Orleans.Streaming): Use [LoggerMessage] (#9423) — run `git show` on any of them.
Change coupling: SimpleQueueCacheCursor.cs ↔ PersistentStreamPullingAgent.cs src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs— `src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs` and `src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `5b42a3a7` refactor(streaming): add typed cache cursor results (#9714); `da77fd69` fix(streaming): defer acknowledgements for batched delivery (#10655); `a1c73151` chore(Orleans.Streaming): Use [LoggerMessage] (#9423) — run `git show` on any of them.
Change coupling: MembershipAgent.cs ↔ MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipAgent.cs— `src/Orleans.Runtime/MembershipService/MembershipAgent.cs` and `src/Orleans.Runtime/MembershipService/MembershipTableManager.cs` change together 53% of the time (10 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `d9656aaa` fix(storage): reduce Azure table retry pressure (#10192); `65d3733e` fix: validate connectivity before silo activation (#10153); `c4c03246` chore(Orleans.Runtime): Use [LoggerMessage] p3 (#9498) — run `git show` on any of them.
Change coupling: MembershipSystemTarget.cs ↔ SiloHealthMonitor.cs src/Orleans.Runtime/MembershipService/MembershipSystemTarget.cs— `src/Orleans.Runtime/MembershipService/MembershipSystemTarget.cs` and `src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `15fc1fed` feat(membership): retain local health history (#10502); `84a82bef` chore: use IMeterFactory for MessagingInstruments (#10179); `c4c03246` chore(Orleans.Runtime): Use [LoggerMessage] p3 (#9498) — run `git show` on any of them.
Duplicated block (19 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:41— src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:41-59 | src/Orleans.Streaming/PubSub/ImplicitStreamSubscriberTable.cs:41-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (19 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:148— src/Orleans.CodeGenerator/CopierGenerator.cs:148-166 | src/Orleans.CodeGenerator/SerializerGenerator.cs:184-202 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:148` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257— src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257-275 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:225-243 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 47 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143— src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143-161 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:374-392 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableListCommandHandler<T>` in one and `IDurableSetCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:754— src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:754-772 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:607-625 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (19 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:43— src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:43-61 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:41-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:43` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 4) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129— src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129-139 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:56-66 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:59-69 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:88-98 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 4) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:141— src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:141-151 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:254-264 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:372-382 | src/Orleans.Journaling/Formats/Json/JsonDurableDictionaryCommandCodec.cs:115-125 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:141` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableListCommandHandler<T>` in one and `IDurableQueueCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 4) src/Orleans.Serialization/Codecs/TupleCodec.cs:684— src/Orleans.Serialization/Codecs/TupleCodec.cs:684-694 | src/Orleans.Serialization/Codecs/TupleCodec.cs:889-899 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1112-1122 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1351-1361 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:684` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:900` calls `default` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:695` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39-49 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:48-58 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:75-85 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:53-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:61` calls `LogInformationInitializingMembershipTable` and `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:88` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 4) src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:105— src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:105-115 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:143-153 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:200-210 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:231-241 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:105` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 4) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286-296 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:316-326 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:403-413 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:537-547 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:86— src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:86-108 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:179-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:203` calls `DeduplicateSourceOutputs` and `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:109` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (23 lines × 2) src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:38— src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:38-60 | src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:79-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (23 lines × 2) src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:33— src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:33-55 | src/Orleans.Serialization/Utilities/ServiceCollectionExtensions.cs:32-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:33` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:31` calls `ThrowIfNull` and `src/Orleans.Serialization/Utilities/ServiceCollectionExtensions.cs:30` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (23 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:319— src/Orleans.TestingHost/InProcTestCluster.cs:319-341 | src/Orleans.TestingHost/TestCluster.cs:400-422 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:319` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:769— src/Orleans.TestingHost/InProcTestCluster.cs:769-791 | src/Orleans.TestingHost/TestCluster.cs:815-837 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (20 lines × 2) src/Orleans.Core/Core/ClientBuilderExtensions.cs:237— src/Orleans.Core/Core/ClientBuilderExtensions.cs:237-256 | src/Orleans.Runtime/Hosting/CoreHostingExtensions.cs:69-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Core/ClientBuilderExtensions.cs:237` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:38— src/Orleans.Core/Core/DefaultClientServices.cs:38-57 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:53-72 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Core/DefaultClientServices.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (20 lines × 2) src/Orleans.Serialization/Serializer.cs:746— src/Orleans.Serialization/Serializer.cs:746-765 | src/Orleans.Serialization/Serializer.cs:777-796 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:746` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:253— src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:253-272 | src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:282-301 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:253` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:439— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:439-458 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:586-605 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:439` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:585` calls `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:438` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Low cohesion: MessagingProcessingInstruments (LCOM4 6) src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:6— MessagingProcessingInstruments's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: SiloControl (LCOM4 6) src/Orleans.Runtime/Silo/SiloControl.cs:26— SiloControl's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: SiloGrainService (LCOM4 5) src/Dashboard/Orleans.Dashboard/Implementation/SiloGrainService.cs:16— SiloGrainService's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: CatalogInstruments (LCOM4 5) src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:9— CatalogInstruments's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: MessagingInstruments (LCOM4 5) src/Orleans.Core/Diagnostics/Metrics/MessagingInstruments.cs:9— MessagingInstruments's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Duplicated block (24 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:81— src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:81-104 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:82-105 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (24 lines × 2) src/Orleans.Core/Utils/ObserverManager.cs:160— src/Orleans.Core/Utils/ObserverManager.cs:160-183 | src/Orleans.Core/Utils/ObserverManager.cs:208-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Utils/ObserverManager.cs:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:111— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:111-134 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:97-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:111` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (24 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77— src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77-100 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:108-131 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 3) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129— src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129-140 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:59-70 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:88-99 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:694— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:694-705 | src/Orleans.Serialization/Codecs/TupleCodec.cs:620-631 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:539-550 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:694` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 3) src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:149— src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:149-160 | src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:248-259 | src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:359-370 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:30— src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:30-41 | src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:34-45 | src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:69-80 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:47` calls `MultiGrainAdd`, `FailOperation`, `Should` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:43` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 3) src/Orleans.Serialization/Codecs/IntegerCodec.cs:506— src/Orleans.Serialization/Codecs/IntegerCodec.cs:506-514 | src/Orleans.Serialization/Codecs/IntegerCodec.cs:531-539 | src/Orleans.Serialization/Codecs/IntegerCodec.cs:557-565 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/IntegerCodec.cs:506` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:26— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:26-34 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:27-35 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:27-35 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233-241 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:265-273 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:371-379 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:380` calls `MakePendingState`, `stateFactory`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:275` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:313— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:313-321 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:534-542 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:695-703 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:322` calls `Should`, `Be` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:704` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X18 · Disposal-pattern correctness· Owned disposable field is never released · ×4
Owned disposable field is never released src/Orleans.Clustering.TestKit/MembershipTableTestFixture.cs:31— `MembershipTableTestFixture` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializationGate` itself (line 31), which makes that instance its own. But `_initializationGate` is named in none of the methods the disposal search covered: `DisposeAsync` (line 399), `DisposeAsync` (line 401), `DisposeAsync` (line 399), `DisposeAsync` (line 401), `CompleteDisposalAsync` (line 431), `ObserveLateCleanupFailureAsync` (line 460) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializationGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released src/Orleans.DurableJobs/JobShard.cs:158— `JobShard` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_mutationLock` itself (line 158), which makes that instance its own. But `_mutationLock` is named in none of the methods the disposal search covered: `DisposeAsync` (line 389) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_mutationLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:33— `ClusterManifestProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_peerProbeSlots` itself (line 33), which makes that instance its own. But `_peerProbeSlots` is named in none of the methods the disposal search covered: `DisposeAsync` (line 708), `Dispose` (line 710), `StopAsync` (line 682), `DisposeAsync` (line 708) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_peerProbeSlots?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released src/Orleans.Runtime/MembershipService/MembershipAgent.cs:23— `MembershipAgent` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `cancellation` itself (line 23), which makes that instance its own. But `cancellation` is named in none of the methods the disposal search covered: `Dispose` (line 449) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`cancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
X27 · Collection changed while being enumerated· Collection is structurally changed while it is being enumerated · ×4
Collection is structurally changed while it is being enumerated src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:80— `_cache` is enumerated directly, and line 84 calls `_cache.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen.
Collection is structurally changed while it is being enumerated src/Orleans.Core/Messaging/CachingSiloAddressCodec.cs:89— `_cache` is enumerated directly, and line 93 calls `_cache.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen.
Collection is structurally changed while it is being enumerated src/Orleans.Reminders/ReminderService/LocalReminderService.cs:447— `localReminders` is enumerated directly, and line 456 calls `localReminders.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen.
Collection is structurally changed while it is being enumerated src/Orleans.Runtime/Placement/PlacementService.cs:438— `_inProgress` is enumerated directly, and line 444 calls `_inProgress.Remove(…)` inside the loop body — a structural change to a `Dictionary`. The next `MoveNext` throws `InvalidOperationException: Collection was modified; enumeration operation may not execute`, so every pass that reaches this call ends the loop by exception instead of by running out of items, and the remaining items are never seen.
AC3 · Page structure· Page without a main landmark · ×3
Page without a main landmark playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark playground/DurableJobsJournaling/DurableJobsJournaling.Web/wwwroot/index.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D4 · Code Duplication· Members sharing a duplicated core (7 members, 50+ identical tokens) · ×3
Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898-905 | src/Orleans.Serialization/Codecs/TupleCodec.cs:850-857 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1070-1078 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1308-1317 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:725-732 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:899-907 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1088-1097 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:176— src/Orleans.Serialization/Codecs/TupleCodec.cs:176-214 | src/Orleans.Serialization/Codecs/TupleCodec.cs:325-367 | src/Orleans.Serialization/Codecs/TupleCodec.cs:493-539 | src/Orleans.Serialization/Codecs/TupleCodec.cs:681-731 | src/Orleans.Serialization/Codecs/TupleCodec.cs:886-940 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1109-1167 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1348-1410 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:196— src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:196-221 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:314-340 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:448-475 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:595-623 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:757-786 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:934-964 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1125-1156 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Duplicated block (29 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/ImplicitChannelSubscriptionAttribute.cs:74— src/Orleans.BroadcastChannel/SubscriberTable/Predicates/ImplicitChannelSubscriptionAttribute.cs:74-102 | src/Orleans.Streaming/Predicates/StreamSubscriptionAttributes.cs:75-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (29 lines × 2) src/Orleans.Serialization/ISerializableSerializer/DotNetSerializableCodec.cs:149— src/Orleans.Serialization/ISerializableSerializer/DotNetSerializableCodec.cs:149-177 | src/Orleans.Serialization/ISerializableSerializer/ValueTypeSerializer.cs:99-127 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (29 lines × 2) src/Orleans.Transactions.TestKit.Base/Grains/ExclusiveLockTransactionTestGrain.cs:77— src/Orleans.Transactions.TestKit.Base/Grains/ExclusiveLockTransactionTestGrain.cs:77-105 | src/Orleans.Transactions.TestKit.Base/Grains/MultiStateTransactionalGrain.cs:205-233 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (16 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:89— src/Orleans.Serialization/Codecs/CollectionCodec.cs:89-104 | src/Orleans.Serialization/Codecs/ListCodec.cs:88-103 | src/Orleans.Serialization/Codecs/QueueCodec.cs:92-107 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:89` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 3) src/Orleans.Serialization/Codecs/HashSetCodec.cs:69— src/Orleans.Serialization/Codecs/HashSetCodec.cs:69-84 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:143-159 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:410-425 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/HashSetCodec.cs:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 3) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:82— src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:82-97 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:70-85 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:82-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `ImmutableHashSet<T>` in one and `ImmutableSortedSet<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 3) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1446— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1446-1459 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1518-1531 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1572-1585 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1446` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (14 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:598— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:598-611 | src/Orleans.Serialization.FSharp/FSharpCodecs.cs:763-776 | src/Orleans.Serialization.FSharp/FSharpCodecs.cs:942-955 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:598` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:11— src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:11-24 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs:21-34 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs:21-34 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:868— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:868-880 | src/Orleans.Serialization/Codecs/TupleCodec.cs:820-832 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:695-707 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (13 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:37— src/Orleans.Serialization/Codecs/CollectionCodec.cs:37-49 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:43-55 | src/Orleans.Serialization/Codecs/ListCodec.cs:36-48 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:550— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:550-562 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:360-372 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:521-533 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:550` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:113— src/Orleans.Serialization/Codecs/CollectionCodec.cs:113-123 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:127-137 | src/Orleans.Serialization/Codecs/ListCodec.cs:112-122 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:113` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs:96— src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs:96-106 | src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:97-107 | src/Orleans.Serialization/Codecs/ImmutableSortedDictionaryCodec.cs:102-112 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:467— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:467-477 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:514-524 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:555-565 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:467` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (5 lines × 3) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169— src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169-173 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:204-208 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:141-145 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:409— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:409-413 | src/Orleans.Serialization/Codecs/TupleCodec.cs:298-302 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:288-292 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (5 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342-346 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:632-640 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:687-695 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:632` calls `stateFactory` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Swallowed exception (caught, then discarded) src/Orleans.Core/Lifecycle/LifecycleSubject.cs:84— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Orleans.TestingHost/Utils/StorageEmulator.cs:120— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Orleans.TestingHost/Utils/StorageEmulator.cs:143— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) src/Orleans.Serialization/Cloning/IDeepCopier.cs:332— ShallowCopyableTypes.IsShallowCopyableInternal has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: one other method here (ShallowCopyableTypes.IsShallowCopyableInternal) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) src/Orleans.Serialization/Cloning/IDeepCopier.cs:337— ShallowCopyableTypes.IsShallowCopyableInternal has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: one other method here (ShallowCopyableTypes.IsShallowCopyableInternal) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
XxxComment src/Orleans.TestingHost/InProcTestCluster.cs:294— // As a result, we will get "MSTest: Unit Test Adapter threw exception: Type is not resolved for member XXX"
XxxComment src/Orleans.TestingHost/TestCluster.cs:375— // As a result, we will get "MSTest: Unit Test Adapter threw exception: Type is not resolved for member XXX"
OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:245— OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:250— OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (5 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:79— src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:79-100 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:67-88 | src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:67-88 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:79-100 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:69-90 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Members sharing a duplicated core (5 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38-63 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:46-84 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:65-115 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:52-104 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:96-147 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (36 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:160— src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:160-195 | src/Orleans.Streaming/Checkpointers/StreamQueueCheckpointer.cs:121-156 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (36 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:268— src/Orleans.TestingHost/InProcTestCluster.cs:268-303 | src/Orleans.TestingHost/TestCluster.cs:349-384 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:268` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (35 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:31— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:31-65 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:40-74 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:31` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (35 lines × 2) src/Orleans.Transactions/State/TransactionalState.cs:138— src/Orleans.Transactions/State/TransactionalState.cs:138-172 | src/Orleans.Transactions/TOC/TransactionCommitter.cs:75-109 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions/State/TransactionalState.cs:138` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (33 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16— src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16-48 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:21-53 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:14-46 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 87 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (33 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:45— src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:45-77 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:56-88 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:43-75 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 87 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:45` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (31 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:133— src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:133-163 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:177-207 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (31 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:45— src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:45-75 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:643-673 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:45` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (27 lines × 2) src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:552— src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:552-578 | src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:593-619 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (27 lines × 2) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:59— src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:59-85 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:66-92 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:59` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (26 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:199— src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:199-224 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:260-285 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (26 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:234— src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:234-259 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:352-377 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:234` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91-115 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:70-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25 lines × 2) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:45— src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:45-69 | src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:59-83 — before extracting anything, compare `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs` and `src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 139 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22–23 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:170— src/Orleans.BroadcastChannel/ChannelId.cs:170-191 | src/Orleans.Streaming/StreamId.cs:186-208 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 45 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22–23 lines × 2) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:127— src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:127-149 | src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:211-232 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:209` calls `DelayBeforeRetry` and `src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:126` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (20 lines × 3) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1405— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1405-1424 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1468-1487 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1538-1557 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1405` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:975— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:975-994 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1132-1151 | src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:894-913 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 3) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:82— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:82-100 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:53-71 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:55-73 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (19 lines × 3) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19— src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19-37 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:19-37 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:18-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 4) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1128— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1128-1142 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1407-1423 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1470-1486 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1540-1556 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1487` calls `StringBuilder` and `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1143` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (15 lines × 4) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:77— src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:77-91 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:96-110 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:67-81 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:74-88 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:77` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 3) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:230— src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:230-244 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:348-362 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:478-492 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:230` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:953— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:953-967 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1115-1129 | src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:877-891 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11–12 lines × 2) src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46— src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46-56 | src/Orleans.Analyzers/IdClashAttributeCodeFix.cs:41-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:469— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:469-479 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:516-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 5) src/Orleans.Serialization/Codecs/TupleCodec.cs:496— src/Orleans.Serialization/Codecs/TupleCodec.cs:496-505 | src/Orleans.Serialization/Codecs/TupleCodec.cs:684-693 | src/Orleans.Serialization/Codecs/TupleCodec.cs:889-898 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1112-1121 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1351-1360 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:496` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:694` calls `default` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:506` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 5) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41-50 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:50-59 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77-86 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:55-64 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:108-117 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:61` calls `LogInformationInitializingMembershipTable` and `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:88` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9–10 lines × 2) src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68— src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68-77 | src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs:90-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–10 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113— src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113-121 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:91-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898-905 | src/Orleans.Serialization/Codecs/TupleCodec.cs:850-857 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:725-732 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (8 lines × 3) src/Orleans.Serialization/Buffers/Writer.cs:451— src/Orleans.Serialization/Buffers/Writer.cs:451-458 | src/Orleans.Serialization/Buffers/Writer.cs:485-492 | src/Orleans.Serialization/Buffers/Writer.cs:510-517 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:451` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 4) src/Orleans.Serialization/Codecs/TupleCodec.cs:1184— src/Orleans.Serialization/Codecs/TupleCodec.cs:1184-1190 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1428-1434 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:980-986 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1173-1179 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 4) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:47— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:47-53 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:72-78 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:43-49 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:45-51 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 4) src/Orleans.Serialization/Serializer.cs:82— src/Orleans.Serialization/Serializer.cs:82-87 | src/Orleans.Serialization/Serializer.cs:99-104 | src/Orleans.Serialization/Serializer.cs:234-239 | src/Orleans.Serialization/Serializer.cs:251-256 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:82` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 4) src/Orleans.Serialization/Serializer.cs:80— src/Orleans.Serialization/Serializer.cs:80-85 | src/Orleans.Serialization/Serializer.cs:182-187 | src/Orleans.Serialization/Serializer.cs:232-237 | src/Orleans.Serialization/Serializer.cs:266-271 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:80` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58-63 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:67-72 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:59-64 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:558— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:558-563 | src/Orleans.Serialization/Codecs/TupleCodec.cs:464-469 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:420-425 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (7 lines × 3) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:300— src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:300-306 | src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:312-318 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:280-286 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 47 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (7 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:721— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:721-727 | src/Orleans.Serialization/Codecs/TupleCodec.cs:647-653 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:566-572 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
IC1 · Incompleteness & stubs· Dead `#if false` region · ×2
Dead `#if false` region src/Orleans.Runtime/Core/InsideRuntimeClient.cs:261— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Dead `#if false` region src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:254— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
IC1 · Incompleteness & stubs· Empty method body · ×2
Empty method body — does nothing with its inputs src/Orleans.Runtime/Silo/Silo.cs:190— `OnRuntimeServicesStart` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Empty method body — does nothing with its inputs src/Orleans.Serialization/Codecs/ArgumentNullExceptionPolyfill.cs:41— `ThrowIfNull` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Duplicated block (15 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36— src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36 · src/Dashboard/Orleans.Dashboard.App/src/silos/silos.tsx:28 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (15 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:196— src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:196 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:231 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
X18 · Disposal-pattern correctness· Finalizer on a type that owns no unmanaged resource · ×2
Finalizer on a type that owns no unmanaged resource src/Orleans.TestingHost/SiloHandle.cs:73— `SiloHandle` declares a finalizer (line 73), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource src/Orleans.TestingHost/TestClusterPortAllocator.cs:77— `TestClusterPortAllocator` declares a finalizer (line 77), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
AC3 · Page structure· Data table has no header cells · ×1
Data table has no header cells src/Dashboard/Orleans.Dashboard.App/src/components/grain-method-table.tsx:42— A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
AC4 · Keyboard semantics· Link used as a button (placeholder href) · ×1
Link used as a button (placeholder href) src/Dashboard/Orleans.Dashboard.App/src/logstream/log-stream.tsx:129— An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×1
Animation without a prefers-reduced-motion guard playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:8— This stylesheet animates but never checks prefers-reduced-motion, so motion-sensitive users can't opt out. Wrap motion in @media (prefers-reduced-motion: no-preference).
Low contrast colour pair in CSS (4.0:1) playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:15— `.absolute-button` sets color: white on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC7 · A11y enforcement· Accessibility enforcement below the top rung · ×1
Accessibility enforcement below the top rung — No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 37 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
JournaledStateManager.WorkLoop (cyclomatic 59) src/Orleans.Journaling/JournaledStateManager.cs:187— JournaledStateManager.WorkLoop has cyclomatic complexity 59 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActivationData.RunMessageLoop (cyclomatic 51) src/Orleans.Runtime/Catalog/ActivationData.cs:1111— ActivationData.RunMessageLoop has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cyclomatic 49) src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22— ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ProxyGenerator.CreateProxyMethods (cyclomatic 49) src/Orleans.CodeGenerator/ProxyGenerator.cs:85— ProxyGenerator.CreateProxyMethods has cyclomatic complexity 49 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
InvokableBaseTypeResolver.SatisfiesConstraints (cyclomatic 48) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:628— InvokableBaseTypeResolver.SatisfiesConstraints has cyclomatic complexity 48 (threshold 15). Of this number, 44 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
PersistentStreamPullingAgent.RunConsumerCursor (cyclomatic 40) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248— PersistentStreamPullingAgent.RunConsumerCursor has cyclomatic complexity 40 (threshold 15). Of this number, 38 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PersistentStreamPullingAgent.DoHandshakeWithConsumer (cyclomatic 39) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:403— PersistentStreamPullingAgent.DoHandshakeWithConsumer has cyclomatic complexity 39 (threshold 15). Of this number, 37 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MembershipModelExecutionContext.ExecuteAsync (cyclomatic 38) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:314— MembershipModelExecutionContext.ExecuteAsync has cyclomatic complexity 38 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
link-audit.probeExternalTargets (cyclomatic 34) docs/site/scripts/lib/link-audit.mjs:1141— link-audit.probeExternalTargets has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
link-audit.auditRenderedInternalLinks (cyclomatic 33) docs/site/scripts/lib/link-audit.mjs:692— link-audit.auditRenderedInternalLinks has cyclomatic complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Silo.render (cyclomatic 33) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:132— Silo.render has cyclomatic complexity 33 (threshold 15). Of this number, 31 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cyclomatic 30) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:518— GrainInterfaceVersionCodeFix.AppendHistoricalContracts has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LibraryTypes.IsShallowCopyable (cyclomatic 30) src/Orleans.CodeGenerator/LibraryTypes.cs:315— LibraryTypes.IsShallowCopyable has cyclomatic complexity 30 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ActivationData.ActivateAsync (cyclomatic 30) src/Orleans.Runtime/Catalog/ActivationData.cs:1760— ActivationData.ActivateAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MembershipModel.CanApply (cyclomatic 29) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:95— MembershipModel.CanApply has cyclomatic complexity 29 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
RuntimeTypeNameParser.ParseInternal (cyclomatic 29) src/Orleans.Serialization/TypeSystem/RuntimeTypeNameParser.cs:53— RuntimeTypeNameParser.ParseInternal has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActivationData.FinishDeactivating (cyclomatic 28) src/Orleans.Runtime/Catalog/ActivationData.cs:2054— ActivationData.FinishDeactivating has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RedisJournalStorageProvider.ListAsync (cyclomatic 28) src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63— RedisJournalStorageProvider.ListAsync has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GrainInterfaceVersionCodeFix.SortContractEntries (cyclomatic 27) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1670— GrainInterfaceVersionCodeFix.SortContractEntries has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
link-audit.auditSourceLinks (cyclomatic 27) docs/site/scripts/lib/link-audit.mjs:418— link-audit.auditSourceLinks has cyclomatic complexity 27 (threshold 15). Of this number, 26 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GrainInterfaceUtils.GetMethods (cyclomatic 26) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:22— GrainInterfaceUtils.GetMethods has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ClusterManifestProvider.UpdateManifest (cyclomatic 26) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:179— ClusterManifestProvider.UpdateManifest has cyclomatic complexity 26 (threshold 15). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
markdown-ranges.fallbackProtectedLineRanges (cyclomatic 26) docs/site/scripts/lib/markdown-ranges.mjs:238— markdown-ranges.fallbackProtectedLineRanges has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
include-closure.collectIncludeTargets (cyclomatic 26) docs/site/scripts/lib/include-closure.mjs:28— include-closure.collectIncludeTargets has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ProxyInterfaceDescription.ValidateBaseClass (cyclomatic 25) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:116— ProxyInterfaceDescription.ValidateBaseClass has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SerializerGenerator.GetFieldDescriptions (cyclomatic 25) src/Orleans.CodeGenerator/SerializerGenerator.cs:257— SerializerGenerator.GetFieldDescriptions has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Striped64.LongAccumulate (cyclomatic 25) src/Orleans.Core/Caching/Internal/Striped64.cs:151— Striped64.LongAccumulate has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActivationRepartitioner.AcceptExchangeRequest (cyclomatic 25) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:270— ActivationRepartitioner.AcceptExchangeRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
S3JournalStorageProvider.ListAsync (cyclomatic 25) src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs:48— S3JournalStorageProvider.ListAsync has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cyclomatic 25) src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:23— DynamoDBReminderStorageOptionsExtensions.ParseConnectionString has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PooledQueueCache.TryGetNextMessageWithResult (cyclomatic 24) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502— PooledQueueCache.TryGetNextMessageWithResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
project-policy.validateProjectEvaluations (cyclomatic 24) docs/site/scripts/lib/project-policy.mjs:184— project-policy.validateProjectEvaluations has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Impl.AnalyzeNamedType (cyclomatic 23) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308— Impl.AnalyzeNamedType has cyclomatic complexity 23 (threshold 15). Of this number, 22 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BatchOperation.Flush (cyclomatic 23) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:413— BatchOperation.Flush has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReadWriteLock.EnterLock (cyclomatic 23) src/Orleans.Transactions/State/ReaderWriterLock.cs:66— ReadWriteLock.EnterLock has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionQueue.NotifyOfAbort (cyclomatic 23) src/Orleans.Transactions/State/TransactionQueue.cs:310— TransactionQueue.NotifyOfAbort has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MembershipTableTestRunner.ConcurrentReads (cyclomatic 22) src/Orleans.Clustering.TestKit/MembershipTableTestRunner.cs:695— MembershipTableTestRunner.ConcurrentReads has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JournaledJobShard.ProcessMutationBatchAsync (cyclomatic 22) src/Orleans.DurableJobs/JournaledJobShard.cs:393— JournaledJobShard.ProcessMutationBatchAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ClientDirectory.UpdateRoutingTable (cyclomatic 22) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:230— ClientDirectory.UpdateRoutingTable has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PersistentStreamPullingAgent.ReadFromQueue (cyclomatic 22) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:884— PersistentStreamPullingAgent.ReadFromQueue has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SiloInstanceRecord.SiloInstanceRecord.ctor (cyclomatic 22) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:50— SiloInstanceRecord.SiloInstanceRecord.ctor has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
source-quality.parseDocumentedPackageTable (cyclomatic 22) docs/site/scripts/lib/source-quality.mjs:562— source-quality.parseDocumentedPackageTable has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GrainInterfaceVersionCodeFix.CreateProjectRegenerationAsync (cyclomatic 21) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:148— GrainInterfaceVersionCodeFix.CreateProjectRegenerationAsync has cyclomatic complexity 21 (threshold 15). Of this number, 15 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cyclomatic 21) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:617— GrainInterfaceVersionCodeFix.MergeHistoricalMembers has cyclomatic complexity 21 (threshold 15). Of this number, 19 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CopierGenerator.GenerateCopier (cyclomatic 21) src/Orleans.CodeGenerator/CopierGenerator.cs:26— CopierGenerator.GenerateCopier has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ProxyGenerator.CreateAsyncProxyMethodBody (cyclomatic 21) src/Orleans.CodeGenerator/ProxyGenerator.cs:279— ProxyGenerator.CreateAsyncProxyMethodBody has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShardExecutor.ExecuteJobAsync (cyclomatic 21) src/Orleans.DurableJobs/ShardExecutor.cs:309— ShardExecutor.ExecuteJobAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LocalSiloHealthEventHistory.Aggregate (cyclomatic 21) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:53— LocalSiloHealthEventHistory.Aggregate has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MembershipAgent.ValidateInitialConnectivity (cyclomatic 21) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:140— MembershipAgent.ValidateInitialConnectivity has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ResourceOptimizedPlacementDirector.OnAddActivation (cyclomatic 21) src/Orleans.Runtime/Placement/ResourceOptimizedPlacementDirector.cs:47— ResourceOptimizedPlacementDirector.OnAddActivation has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamoDBTransactionalStateStorage.Store (cyclomatic 21) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144— DynamoDBTransactionalStateStorage.Store has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cyclomatic 20) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1254— GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync has cyclomatic complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cyclomatic 20) src/Orleans.Clustering.TestKit/MembershipTableModelBasedTestRunner.cs:45— MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests has cyclomatic complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SerializerGenerator.GenerateDeserializeMethod (cyclomatic 20) src/Orleans.CodeGenerator/SerializerGenerator.cs:539— SerializerGenerator.GenerateDeserializeMethod has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Utils.EnumerableToString (cyclomatic 20) src/Orleans.Core.Abstractions/Utils/Utils.cs:26— Utils.EnumerableToString has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DurableJobsOptionsValidator.ValidateConfiguration (cyclomatic 20) src/Orleans.DurableJobs/Hosting/DurableJobsOptions.cs:227— DurableJobsOptionsValidator.ValidateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
JournaledJobShardManager.TryAssignShardAsync (cyclomatic 20) src/Orleans.DurableJobs/JournaledJobShardManager.cs:196— JournaledJobShardManager.TryAssignShardAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShardExecutor.RunShardAsync (cyclomatic 20) src/Orleans.DurableJobs/ShardExecutor.cs:72— ShardExecutor.RunShardAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cyclomatic 20) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389— ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 2 of the 20 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 410, 496). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SiloClusteringValidator.ValidateConfiguration (cyclomatic 20) src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs:25— SiloClusteringValidator.ValidateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PersistentStreamPullingAgent.RegisterStream (cyclomatic 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1076— PersistentStreamPullingAgent.RegisterStream has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TestingUtils.WaitUntilSucceededAsync (cyclomatic 20) src/Orleans.TestingHost/Utils/TestingUtils.cs:176— TestingUtils.WaitUntilSucceededAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
markdown-ranges.startsHtmlBlock (cyclomatic 20) docs/site/scripts/lib/markdown-ranges.mjs:183— markdown-ranges.startsHtmlBlock has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
compatibility-paths.compatibilityOutputPath (cyclomatic 20) docs/site/scripts/lib/compatibility-paths.mjs:5— compatibility-paths.compatibilityOutputPath has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
InvokableMethodDescription.InvokableMethodDescription.ctor (cyclomatic 19) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:17— InvokableMethodDescription.InvokableMethodDescription.ctor has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cyclomatic 19) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:249— SerializableTypeModelExtractor.TryExtractSerializableTypeModel has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cyclomatic 19) src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:208— AsyncExecutorWithRetries.ExecuteWithRetriesHelper has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Message.TryFormat (cyclomatic 19) src/Orleans.Core/Messaging/Message.cs:335— Message.TryFormat has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConnectionManager.Close (cyclomatic 19) src/Orleans.Core/Networking/ConnectionManager.cs:344— ConnectionManager.Close has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
DynamoDBMembershipHelper.ParseDataConnectionString (cyclomatic 19) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:23— DynamoDBMembershipHelper.ParseDataConnectionString has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamoDBStorage.UpdateTableAsync (cyclomatic 19) src/AWS/Shared/Storage/DynamoDBStorage.cs:272— DynamoDBStorage.UpdateTableAsync has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
RedisJournalStorage.CreateStorageState (cyclomatic 19) src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:723— RedisJournalStorage.CreateStorageState has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cyclomatic 19) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229— TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase has cyclomatic complexity 19 (threshold 15). Of this number, 12 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
source-quality.validateReferenceInventories (cyclomatic 19) docs/site/scripts/lib/source-quality.mjs:747— source-quality.validateReferenceInventories has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InvokableBaseTypeResolver.TryConstructAndValidate (cyclomatic 18) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:548— InvokableBaseTypeResolver.TryConstructAndValidate has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SerializerGenerator.Generate (cyclomatic 18) src/Orleans.CodeGenerator/SerializerGenerator.cs:30— SerializerGenerator.Generate has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cyclomatic 18) src/Orleans.Serialization/Hosting/SerializerConfigurationAnalyzer.cs:29— SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LifecycleStageInspector.CleanMethodName (cyclomatic 18) src/Dashboard/Orleans.Dashboard/Implementation/LifecycleStageInspector.cs:210— LifecycleStageInspector.CleanMethodName has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AzureTableTransactionalStateStorage.StoreCore (cyclomatic 18) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:165— AzureTableTransactionalStateStorage.StoreCore has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReadWriteLock.LockWork (cyclomatic 18) src/Orleans.Transactions/State/ReaderWriterLock.cs:336— ReadWriteLock.LockWork has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
docfx.collectMarkdownLinks (cyclomatic 18) docs/site/scripts/lib/docfx.mjs:1075— docfx.collectMarkdownLinks has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
docfx.collectUidMap (cyclomatic 18) docs/site/scripts/lib/docfx.mjs:1622— docfx.collectUidMap has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
link-audit.renderedDocument (cyclomatic 18) docs/site/scripts/lib/link-audit.mjs:573— link-audit.renderedDocument has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 5 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 604). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
MembershipModel.Apply (cyclomatic 17) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:121— MembershipModel.Apply has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ProxyGenerator.GenerateConstructors (cyclomatic 17) src/Orleans.CodeGenerator/ProxyGenerator.cs:438— ProxyGenerator.GenerateConstructors has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
ClientMessageCenter.GetGatewayConnection (cyclomatic 17) src/Orleans.Core/Messaging/ClientMessageCenter.cs:231— ClientMessageCenter.GetGatewayConnection has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShardCatalogProperties.From (cyclomatic 17) src/Orleans.DurableJobs/JournaledJobShardManager.cs:744— ShardCatalogProperties.From has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
JournalCatalogRange.JournalCatalogRange.ctor (cyclomatic 17) src/Orleans.Journaling/JournalCatalogRange.cs:5— JournalCatalogRange.JournalCatalogRange.ctor has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ClusterHealthMonitor.UpdateMonitoredSilos (cyclomatic 17) src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:164— ClusterHealthMonitor.UpdateMonitoredSilos has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SiloHealthMonitor.Run (cyclomatic 17) src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs:174— SiloHealthMonitor.Run has cyclomatic complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AsyncTimer.NextTick (cyclomatic 17) src/Orleans.Runtime/Timers/AsyncTimer.cs:39— AsyncTimer.NextTick has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
CodecProvider.CreateCodecInstance (cyclomatic 17) src/Orleans.Serialization/Serializers/CodecProvider.cs:522— CodecProvider.CreateCodecInstance has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TlsServerConnectionMiddleware.InnerOnConnectionAsync (cyclomatic 17) src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:56— TlsServerConnectionMiddleware.InnerOnConnectionAsync has cyclomatic complexity 17 (threshold 15). Of this number, 10 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
S3JournalStorage.ReplaceAsync (cyclomatic 17) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:548— S3JournalStorage.ReplaceAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionQueue.StorageWork (cyclomatic 17) src/Orleans.Transactions/State/TransactionQueue.cs:839— TransactionQueue.StorageWork has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
docfx.convertTabs (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:67— docfx.convertTabs has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
docfx.convertLinkTarget (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:1210— docfx.convertLinkTarget has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
docfx.convertHubYaml (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:1752— docfx.convertHubYaml has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Impl.OnCompilationEnd (cyclomatic 16) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:493— Impl.OnCompilationEnd has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MetadataGenerator.GenerateIncrementalMetadata (cyclomatic 16) src/Orleans.CodeGenerator/MetadataGenerator.cs:26— MetadataGenerator.GenerateIncrementalMetadata has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This is NOT this file's highest cyclomatic complexity: MetadataGenerator.GetOpenTypeSyntax (cyclomatic 18) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
SymbolExtensions.ToTypeSyntaxInner (cyclomatic 16) src/Orleans.CodeGenerator/SyntaxGeneration/SymbolExtensions.cs:129— SymbolExtensions.ToTypeSyntaxInner has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LocalObjectData.CancelRequestAsync (cyclomatic 16) src/Orleans.Core/Runtime/InvokableObjectManager.cs:527— LocalObjectData.CancelRequestAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
JournalingHostingExtensions.AddJournalStorage (cyclomatic 16) src/Orleans.Journaling/JournalingHostingExtensions.cs:140— JournalingHostingExtensions.AddJournalStorage has cyclomatic complexity 16 (threshold 15). Of this number, 12 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActivationData.CancelRequestAsyncCore (cyclomatic 16) src/Orleans.Runtime/Catalog/ActivationData.cs:2369— ActivationData.CancelRequestAsyncCore has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InsideRuntimeClient.Invoke (cyclomatic 16) src/Orleans.Runtime/Core/InsideRuntimeClient.cs:290— InsideRuntimeClient.Invoke has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cyclomatic 16) src/Orleans.Runtime/GrainDirectory/DirectoryMembershipSnapshot.cs:34— DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor has cyclomatic complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
MembershipTableCleanupAgent.CleanupDefunctSilos (cyclomatic 16) src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs:110— MembershipTableCleanupAgent.CleanupDefunctSilos has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageCenter.SendMessage (cyclomatic 16) src/Orleans.Runtime/Messaging/MessageCenter.cs:144— MessageCenter.SendMessage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TypeConverter.ConsumeMetadata (cyclomatic 16) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151— TypeConverter.ConsumeMetadata has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PersistentStreamPullingAgent.GetBatchForConsumer (cyclomatic 16) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1496— PersistentStreamPullingAgent.GetBatchForConsumer has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ServiceCollectionExtensions.MapOrleansDashboard (cyclomatic 16) src/Dashboard/Orleans.Dashboard/ServiceCollectionExtensions.cs:93— ServiceCollectionExtensions.MapOrleansDashboard has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 14 function literals inside it that branch (lines 108, 141, 157, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TlsClientConnectionMiddleware.InnerOnConnectionAsync (cyclomatic 16) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:43— TlsClientConnectionMiddleware.InnerOnConnectionAsync has cyclomatic complexity 16 (threshold 15). Of this number, 9 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
KubernetesClusterAgent.MonitorOrleansClustering (cyclomatic 16) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:227— KubernetesClusterAgent.MonitorOrleansClustering has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
KubernetesClusterAgent.MonitorKubernetesPods (cyclomatic 16) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:302— KubernetesClusterAgent.MonitorKubernetesPods has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cyclomatic 16) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:22— DynamoDBGatewayListProviderHelper.ParseDataConnectionString has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamoDBGrainStorageProviderBuilder.Configure (cyclomatic 16) src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:17— DynamoDBGrainStorageProviderBuilder.Configure has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to one function literal inside it that branches (line 21). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
AzureBasedMembershipTable.Parse (cyclomatic 16) src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:247— AzureBasedMembershipTable.Parse has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cyclomatic 16) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/IAzureQueueDataAdapter.cs:321— AzureQueueJsonDataAdapter.RemoveUnreferencedIds has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ReadWriteLock.LockExits (cyclomatic 16) src/Orleans.Transactions/State/ReaderWriterLock.cs:577— ReadWriteLock.LockExits has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
gallery.validateGallery (cyclomatic 16) docs/site/scripts/lib/gallery.mjs:22— gallery.validateGallery has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 28). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
GrainTable.render (cyclomatic 16) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:139— GrainTable.render has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D17 · Explicit Debt· BareSuppressMessage repeated 13 times in 6 files · ×1
BareSuppressMessage repeated 13 times in 6 files src/Azure/Orleans.Clustering.AzureStorage/Utilities/TableStorageErrorCode.cs:5— The identical BareSuppressMessage (`SuppressMessage`) appears 13 times in 6 files — one decision applied repeatedly (e.g. the same rule silenced on every overload of a fluent API), not 13 independent debts. Decide it once — at the type or project level, or by fixing the underlying pattern — rather than occurrence-by-occurrence. (Every occurrence still counts toward the score and metrics.)
D17 · Explicit Debt· BarePragmaDisable repeated 13 times in 8 files · ×1
BarePragmaDisable repeated 13 times in 8 files src/Orleans.TestingHost/InProcTestCluster.cs:988— The identical BarePragmaDisable (`#pragma warning disable ORLEANSEXP003`) appears 13 times in 8 files — one decision applied repeatedly (e.g. the same rule silenced on every overload of a fluent API), not 13 independent debts. Decide it once — at the type or project level, or by fixing the underlying pattern — rather than occurrence-by-occurrence. (Every occurrence still counts toward the score and metrics.)
HackComment test/Grains/TestInternalGrains/PersistenceTestGrains.cs:898— // // HACK for testing — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
JournaledStateManager.WorkLoop (cognitive 195) src/Orleans.Journaling/JournaledStateManager.cs:187— JournaledStateManager.WorkLoop has cognitive complexity 195 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.RunConsumerCursor (cognitive 82) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248— PersistentStreamPullingAgent.RunConsumerCursor has cognitive complexity 82 (threshold 15). Of this number, 81 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
link-audit.auditRenderedInternalLinks (cognitive 80) docs/site/scripts/lib/link-audit.mjs:692— link-audit.auditRenderedInternalLinks has cognitive complexity 80 (threshold 15). Drivers by points: if/else 18 (57 pts), error handling 3 (10 pts), boolean chains 7, loops 2 (3 pts), ternaries 2 (3 pts) (nesting depth added 48). Of this number, 78 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cognitive 79) src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22— ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData has cognitive complexity 79 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationData.RunMessageLoop (cognitive 76) src/Orleans.Runtime/Catalog/ActivationData.cs:1111— ActivationData.RunMessageLoop has cognitive complexity 76 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RedisJournalStorageProvider.ListAsync (cognitive 73) src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63— RedisJournalStorageProvider.ListAsync has cognitive complexity 73 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReadWriteLock.LockWork (cognitive 73) src/Orleans.Transactions/State/ReaderWriterLock.cs:336— ReadWriteLock.LockWork has cognitive complexity 73 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ActivationData.ActivateAsync (cognitive 64) src/Orleans.Runtime/Catalog/ActivationData.cs:1760— ActivationData.ActivateAsync has cognitive complexity 64 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BatchOperation.Flush (cognitive 60) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:413— BatchOperation.Flush has cognitive complexity 60 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
link-audit.probeExternalTargets (cognitive 59) docs/site/scripts/lib/link-audit.mjs:1141— link-audit.probeExternalTargets has cognitive complexity 59 (threshold 15). Drivers by points: if/else 18 (35 pts), boolean chains 9, error handling 3 (7 pts), loops 4 (5 pts), ternaries 1 (3 pts) (nesting depth added 24). Of this number, 58 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.DoHandshakeWithConsumer (cognitive 53) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:403— PersistentStreamPullingAgent.DoHandshakeWithConsumer has cognitive complexity 53 (threshold 15). Of this number, 52 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InvokableBaseTypeResolver.SatisfiesConstraints (cognitive 51) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:628— InvokableBaseTypeResolver.SatisfiesConstraints has cognitive complexity 51 (threshold 15). Of this number, 47 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.collectUidMap (cognitive 50) docs/site/scripts/lib/docfx.mjs:1622— docfx.collectUidMap has cognitive complexity 50 (threshold 15). Drivers by points: if/else 8 (25 pts), loops 6 (18 pts), ternaries 1 (5 pts), boolean chains 2 (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cognitive 49) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:518— GrainInterfaceVersionCodeFix.AppendHistoricalContracts has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
source-quality.parseDocumentedPackageTable (cognitive 47) docs/site/scripts/lib/source-quality.mjs:562— source-quality.parseDocumentedPackageTable has cognitive complexity 47 (threshold 15). Drivers by points: if/else 13 (32 pts), ternaries 3 (9 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Striped64.LongAccumulate (cognitive 46) src/Orleans.Core/Caching/Internal/Striped64.cs:151— Striped64.LongAccumulate has cognitive complexity 46 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
KubernetesClusterAgent.MonitorOrleansClustering (cognitive 46) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:227— KubernetesClusterAgent.MonitorOrleansClustering has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InvokableMethodDescription.InvokableMethodDescription.ctor (cognitive 45) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:17— InvokableMethodDescription.InvokableMethodDescription.ctor has cognitive complexity 45 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ProxyInterfaceModelExtractor.ExtractCustomInitializers (cognitive 45) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:400— ProxyInterfaceModelExtractor.ExtractCustomInitializers has cognitive complexity 45 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
markdown-ranges.fallbackProtectedLineRanges (cognitive 45) docs/site/scripts/lib/markdown-ranges.mjs:238— markdown-ranges.fallbackProtectedLineRanges has cognitive complexity 45 (threshold 15). Drivers by points: if/else 15 (34 pts), boolean chains 10, loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProxyInterfaceDescription.ValidateBaseClass (cognitive 44) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:116— ProxyInterfaceDescription.ValidateBaseClass has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReadWriteLock.EnterLock (cognitive 44) src/Orleans.Transactions/State/ReaderWriterLock.cs:66— ReadWriteLock.EnterLock has cognitive complexity 44 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MembershipTableTestRunner.ConcurrentReads (cognitive 43) src/Orleans.Clustering.TestKit/MembershipTableTestRunner.cs:695— MembershipTableTestRunner.ConcurrentReads has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RuntimeTypeNameParser.ParseInternal (cognitive 43) src/Orleans.Serialization/TypeSystem/RuntimeTypeNameParser.cs:53— RuntimeTypeNameParser.ParseInternal has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertTabs (cognitive 43) docs/site/scripts/lib/docfx.mjs:67— docfx.convertTabs has cognitive complexity 43 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 6 (14 pts), ternaries 3 (10 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceUtils.GetMethods (cognitive 42) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:22— GrainInterfaceUtils.GetMethods has cognitive complexity 42 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionQueue.StorageWork (cognitive 42) src/Orleans.Transactions/State/TransactionQueue.cs:839— TransactionQueue.StorageWork has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
link-audit.auditSourceLinks (cognitive 41) docs/site/scripts/lib/link-audit.mjs:418— link-audit.auditSourceLinks has cognitive complexity 41 (threshold 15). Drivers by points: if/else 11 (26 pts), boolean chains 6, error handling 2 (5 pts), loops 2, ternaries 2 (nesting depth added 18). Of this number, 40 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProxyGenerator.CreateProxyMethods (cognitive 40) src/Orleans.CodeGenerator/ProxyGenerator.cs:85— ProxyGenerator.CreateProxyMethods has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cognitive 40) src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:208— AsyncExecutorWithRetries.ExecuteWithRetriesHelper has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientDirectory.UpdateRoutingTable (cognitive 40) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:230— ClientDirectory.UpdateRoutingTable has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClusterManifestProvider.UpdateManifest (cognitive 40) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:179— ClusterManifestProvider.UpdateManifest has cognitive complexity 40 (threshold 15). Of this number, 39 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReadWriteLock.LockExits (cognitive 40) src/Orleans.Transactions/State/ReaderWriterLock.cs:577— ReadWriteLock.LockExits has cognitive complexity 40 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PooledQueueCache.TryGetNextMessageWithResult (cognitive 39) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502— PooledQueueCache.TryGetNextMessageWithResult has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionQueue.NotifyOfAbort (cognitive 39) src/Orleans.Transactions/State/TransactionQueue.cs:310— TransactionQueue.NotifyOfAbort has cognitive complexity 39 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DistributedGrainDirectory.ProcessMembershipUpdates (cognitive 37) src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:518— DistributedGrainDirectory.ProcessMembershipUpdates has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationRepartitioner.AcceptExchangeRequest (cognitive 37) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:270— ActivationRepartitioner.AcceptExchangeRequest has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.EnumerableToString (cognitive 36) src/Orleans.Core.Abstractions/Utils/Utils.cs:26— Utils.EnumerableToString has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MessageCenter.SendMessage (cognitive 36) src/Orleans.Runtime/Messaging/MessageCenter.cs:144— MessageCenter.SendMessage has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PersistentStreamPullingAgent.GetBatchForConsumer (cognitive 36) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1496— PersistentStreamPullingAgent.GetBatchForConsumer has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShardExecutor.ExecuteJobAsync (cognitive 35) src/Orleans.DurableJobs/ShardExecutor.cs:309— ShardExecutor.ExecuteJobAsync has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ActivationData.FinishDeactivating (cognitive 35) src/Orleans.Runtime/Catalog/ActivationData.cs:2054— ActivationData.FinishDeactivating has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FieldIdAssignmentHelper.ExtractFieldIdAnnotations (cognitive 34) src/Orleans.CodeGenerator/FieldIdAssignmentHelper.cs:99— FieldIdAssignmentHelper.ExtractFieldIdAnnotations has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalSiloHealthEventHistory.Aggregate (cognitive 34) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:53— LocalSiloHealthEventHistory.Aggregate has cognitive complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
KubernetesClusterAgent.MonitorKubernetesPods (cognitive 34) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:302— KubernetesClusterAgent.MonitorKubernetesPods has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Silo.render (cognitive 34) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:132— Silo.render has cognitive complexity 34 (threshold 15). Drivers by points: boolean chains 27, if/else 7. Of this number, 32 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
MembershipAgent.ValidateInitialConnectivity (cognitive 33) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:140— MembershipAgent.ValidateInitialConnectivity has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TestClusterPortAllocator.GetAvailableConsecutiveServerPorts (cognitive 33) src/Orleans.TestingHost/TestClusterPortAllocator.cs:82— TestClusterPortAllocator.GetAvailableConsecutiveServerPorts has cognitive complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
TestingUtils.WaitUntilSucceededAsync (cognitive 33) src/Orleans.TestingHost/Utils/TestingUtils.cs:176— TestingUtils.WaitUntilSucceededAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
S3JournalStorage.ReplaceAsync (cognitive 33) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:548— S3JournalStorage.ReplaceAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceVersionCodeFix.SortContractEntries (cognitive 32) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1670— GrainInterfaceVersionCodeFix.SortContractEntries has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConnectionManager.Close (cognitive 32) src/Orleans.Core/Networking/ConnectionManager.cs:344— ConnectionManager.Close has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ActivationRepartitioner.ProcessPendingEdges (cognitive 32) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.MessageSink.cs:40— ActivationRepartitioner.ProcessPendingEdges has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ResourceOptimizedPlacementDirector.OnAddActivation (cognitive 32) src/Orleans.Runtime/Placement/ResourceOptimizedPlacementDirector.cs:47— ResourceOptimizedPlacementDirector.OnAddActivation has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cognitive 32) src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:23— DynamoDBReminderStorageOptionsExtensions.ParseConnectionString has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializerGenerator.Generate (cognitive 31) src/Orleans.CodeGenerator/SerializerGenerator.cs:30— SerializerGenerator.Generate has cognitive complexity 31 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SerializerGenerator.GetFieldDescriptions (cognitive 31) src/Orleans.CodeGenerator/SerializerGenerator.cs:257— SerializerGenerator.GetFieldDescriptions has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializerGenerator.GenerateDeserializeMethod (cognitive 31) src/Orleans.CodeGenerator/SerializerGenerator.cs:539— SerializerGenerator.GenerateDeserializeMethod has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShardExecutor.RunShardAsync (cognitive 31) src/Orleans.DurableJobs/ShardExecutor.cs:72— ShardExecutor.RunShardAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClusterHealthMonitor.UpdateMonitoredSilos (cognitive 31) src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:164— ClusterHealthMonitor.UpdateMonitoredSilos has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.collectMarkdownLinks (cognitive 31) docs/site/scripts/lib/docfx.mjs:1075— docfx.collectMarkdownLinks has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (24 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
project-policy.validateProjectEvaluations (cognitive 31) docs/site/scripts/lib/project-policy.mjs:184— project-policy.validateProjectEvaluations has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 12, loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Impl.AnalyzeNamedType (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308— Impl.AnalyzeNamedType has cognitive complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Impl.OnCompilationEnd (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:493— Impl.OnCompilationEnd has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1254— GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync has cognitive complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
S3JournalStorage.DeleteAsync (cognitive 30) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:319— S3JournalStorage.DeleteAsync has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamoDBTransactionalStateStorage.Store (cognitive 30) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144— DynamoDBTransactionalStateStorage.Store has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceFileParser.Parse (cognitive 29) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1444— GrainInterfaceFileParser.Parse has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cognitive 29) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:617— GrainInterfaceVersionCodeFix.MergeHistoricalMembers has cognitive complexity 29 (threshold 15). Of this number, 28 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GenerateAliasAttributesAnalyzer.AnalyzeNamedType (cognitive 29) src/Orleans.Analyzers/GenerateAliasAttributesAnalyzer.cs:47— GenerateAliasAttributesAnalyzer.AnalyzeNamedType has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueKey.CompareTo (cognitive 29) src/Orleans.Core.Abstractions/IDs/Legacy/UniqueKey.cs:326— UniqueKey.CompareTo has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AsyncEnumerableGrainExtension.MoveNextCore (cognitive 29) src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:156— AsyncEnumerableGrainExtension.MoveNextCore has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DashboardGrain.GetGrainState (cognitive 29) src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs:302— DashboardGrain.GetGrainState has cognitive complexity 29 (threshold 15). Of this number, 28 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cognitive 29) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/IAzureQueueDataAdapter.cs:321— AzureQueueJsonDataAdapter.RemoveUnreferencedIds has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CopierGenerator.GenerateCopier (cognitive 28) src/Orleans.CodeGenerator/CopierGenerator.cs:26— CopierGenerator.GenerateCopier has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalObjectData.CancelRequestAsync (cognitive 28) src/Orleans.Core/Runtime/InvokableObjectManager.cs:527— LocalObjectData.CancelRequestAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JournaledJobShard.ProcessMutationBatchAsync (cognitive 28) src/Orleans.DurableJobs/JournaledJobShard.cs:393— JournaledJobShard.ProcessMutationBatchAsync has cognitive complexity 28 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SiloMetadataCache.ProcessMembershipUpdates (cognitive 28) src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadaCache.cs:53— SiloMetadataCache.ProcessMembershipUpdates has cognitive complexity 28 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
TlsServerConnectionMiddleware.InnerOnConnectionAsync (cognitive 28) src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:56— TlsServerConnectionMiddleware.InnerOnConnectionAsync has cognitive complexity 28 (threshold 15). Most of this is not in the body itself: 12 of the 28 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 91, 137). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
CommitQueue.Find (cognitive 28) src/Orleans.Transactions/Utilities/CommitQueue.cs:111— CommitQueue.Find has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
include-closure.collectIncludeTargets (cognitive 28) docs/site/scripts/lib/include-closure.mjs:28— include-closure.collectIncludeTargets has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 4, loops 2, ternaries 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceTypeToGrainTypeResolver.BuildCache (cognitive 27) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:201— GrainInterfaceTypeToGrainTypeResolver.BuildCache has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Connection.ProcessIncoming (cognitive 27) src/Orleans.Core/Networking/Connection.cs:307— Connection.ProcessIncoming has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Reader.Skip (cognitive 27) src/Orleans.Serialization/Buffers/Reader.cs:498— Reader.Skip has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cognitive 27) src/Orleans.Serialization/Hosting/SerializerConfigurationAnalyzer.cs:29— SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.ReadFromQueue (cognitive 27) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:884— PersistentStreamPullingAgent.ReadFromQueue has cognitive complexity 27 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
TlsClientConnectionMiddleware.InnerOnConnectionAsync (cognitive 27) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:43— TlsClientConnectionMiddleware.InnerOnConnectionAsync has cognitive complexity 27 (threshold 15). Most of this is not in the body itself: 11 of the 27 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 76, 119). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
S3JournalStorageProvider.ListAsync (cognitive 27) src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs:48— S3JournalStorageProvider.ListAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureTableTransactionalStateStorage.StoreCore (cognitive 27) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:165— AzureTableTransactionalStateStorage.StoreCore has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImplicitChannelSubscriberTable.BuildCache (cognitive 26) src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:61— ImplicitChannelSubscriberTable.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainBindingsResolver.BuildCache (cognitive 26) src/Orleans.Core/Manifest/GrainBindings.cs:131— GrainBindingsResolver.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainVersionManifest.BuildCache (cognitive 26) src/Orleans.Core/Manifest/GrainVersionManifest.cs:217— GrainVersionManifest.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DurableJobsDiagnostics.StartPersistBatchActivity (cognitive 26) src/Orleans.DurableJobs/DurableJobsDiagnostics.cs:166— DurableJobsDiagnostics.StartPersistBatchActivity has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.TransferSnapshotAsync (cognitive 26) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:672— GrainDirectoryPartition.TransferSnapshotAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementWorker.ProcessLoop (cognitive 26) src/Orleans.Runtime/Placement/PlacementService.cs:398— PlacementWorker.ProcessLoop has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImplicitStreamSubscriberTable.BuildCache (cognitive 26) src/Orleans.Streaming/PubSub/ImplicitStreamSubscriberTable.cs:61— ImplicitStreamSubscriberTable.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
markdown-ranges.startsHtmlBlock (cognitive 26) docs/site/scripts/lib/markdown-ranges.mjs:183— markdown-ranges.startsHtmlBlock has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (11 pts), ternaries 4 (10 pts), boolean chains 4, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Message.TryFormat (cognitive 25) src/Orleans.Core/Messaging/Message.cs:335— Message.TryFormat has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JournaledJobShardManager.DiscoverJobShardsAsync (cognitive 25) src/Orleans.DurableJobs/JournaledJobShardManager.cs:118— JournaledJobShardManager.DiscoverJobShardsAsync has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
docfx.convertHubYaml (cognitive 25) docs/site/scripts/lib/docfx.mjs:1752— docfx.convertHubYaml has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 3 (5 pts), boolean chains 1, ternaries 1 (nesting depth added 10). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceVersionCodeFix.GetProjectsToRegenerateAsync (cognitive 24) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:848— GrainInterfaceVersionCodeFix.GetProjectsToRegenerateAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MembershipModelExecutionContext.ExecuteAsync (cognitive 24) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:314— MembershipModelExecutionContext.ExecuteAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ProxyGenerator.CreateAsyncProxyMethodBody (cognitive 24) src/Orleans.CodeGenerator/ProxyGenerator.cs:279— ProxyGenerator.CreateAsyncProxyMethodBody has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LocalReminderData.WaitForNextTick (cognitive 24) src/Orleans.Reminders/ReminderService/LocalReminderService.cs:1406— LocalReminderData.WaitForNextTick has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.CleanupExpiredLeasesCore (cognitive 24) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:1259— GrainDirectoryPartition.CleanupExpiredLeasesCore has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MembershipTableCleanupAgent.CleanupDefunctSilos (cognitive 24) src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs:110— MembershipTableCleanupAgent.CleanupDefunctSilos has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MembershipTableManager.ProcessSuspectOrKillLists (cognitive 24) src/Orleans.Runtime/MembershipService/MembershipTableManager.cs:828— MembershipTableManager.ProcessSuspectOrKillLists has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamoDBMembershipHelper.ParseDataConnectionString (cognitive 24) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:23— DynamoDBMembershipHelper.ParseDataConnectionString has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureBlobJournalStorage.ReplaceAsync (cognitive 24) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:472— AzureBlobJournalStorage.ReplaceAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertCodeDirectives (cognitive 24) docs/site/scripts/lib/docfx.mjs:650— docfx.convertCodeDirectives has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (15 pts), ternaries 4 (8 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertImages (cognitive 24) docs/site/scripts/lib/docfx.mjs:887— docfx.convertImages has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
source-quality.validateReferenceInventories (cognitive 24) docs/site/scripts/lib/source-quality.mjs:747— source-quality.validateReferenceInventories has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 6, boolean chains 3, ternaries 1 (nesting depth added 6). Of this number, 23 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InMemoryJobQueue.GetAsyncEnumerator (cognitive 23) src/Orleans.DurableJobs/InMemoryJobQueue.cs:258— InMemoryJobQueue.GetAsyncEnumerator has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationData.AnalyzeWorkload (cognitive 23) src/Orleans.Runtime/Catalog/ActivationData.cs:841— ActivationData.AnalyzeWorkload has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SiloClusteringValidator.ValidateConfiguration (cognitive 23) src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs:25— SiloClusteringValidator.ValidateConfiguration has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
InsideRuntimeClient.Invoke (cognitive 23) src/Orleans.Runtime/Core/InsideRuntimeClient.cs:290— InsideRuntimeClient.Invoke has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.RegisterAsync (cognitive 23) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.Interface.cs:10— GrainDirectoryPartition.RegisterAsync has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
StreamSubscriptionHandleImpl.DeliverBatch (cognitive 23) src/Orleans.Streaming/Internal/StreamSubscriptionHandleImpl.cs:159— StreamSubscriptionHandleImpl.DeliverBatch has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureTableJournalStorageProvider.GetCatalogFilter (cognitive 23) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageProvider.cs:114— AzureTableJournalStorageProvider.GetCatalogFilter has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionRequestBase.Invoke (cognitive 23) src/Orleans.Transactions/TransactionAttribute.cs:296— TransactionRequestBase.Invoke has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SerializationAttributesHelper.AnalyzeTypeDeclaration (cognitive 22) src/Orleans.Analyzers/SerializationAttributesHelper.cs:24— SerializationAttributesHelper.AnalyzeTypeDeclaration has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cognitive 22) src/Orleans.Clustering.TestKit/MembershipTableModelBasedTestRunner.cs:45— MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests has cognitive complexity 22 (threshold 15). Of this number, 17 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LibraryTypes.IsShallowCopyable (cognitive 22) src/Orleans.CodeGenerator/LibraryTypes.cs:315— LibraryTypes.IsShallowCopyable has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cognitive 22) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:249— SerializableTypeModelExtractor.TryExtractSerializableTypeModel has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LogFormatter.PrintException_Helper (cognitive 22) src/Orleans.Core.Abstractions/Logging/LogFormatter.cs:77— LogFormatter.PrintException_Helper has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CustomStorageAdaptor.WriteAsync (cognitive 22) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:158— CustomStorageAdaptor.WriteAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JsonLinesJournalFormat.ReadEntryPayload (cognitive 22) src/Orleans.Journaling/Formats/Json/JsonLinesJournalFormat.cs:152— JsonLinesJournalFormat.ReadEntryPayload has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReminderTableRetryPolicy.ExecuteUntilAsync (cognitive 22) src/Orleans.Reminders.TestKit/ReminderTableRetryPolicy.cs:106— ReminderTableRetryPolicy.ExecuteUntilAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RingRange.Intersections (cognitive 22) src/Orleans.Runtime/GrainDirectory/RingRange.cs:177— RingRange.Intersections has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SiloHealthMonitor.Run (cognitive 22) src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs:174— SiloHealthMonitor.Run has cognitive complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
KubernetesClusterAgent.OnStart (cognitive 22) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:102— KubernetesClusterAgent.OnStart has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
S3JournalStorage.UpdateMetadataAsync (cognitive 22) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:131— S3JournalStorage.UpdateMetadataAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureBlobJournalStorageProvider.ListAsync (cognitive 22) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageProvider.cs:57— AzureBlobJournalStorageProvider.ListAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionQueue.CheckProgressOfCommitQueue (cognitive 22) src/Orleans.Transactions/State/TransactionQueue.cs:1188— TransactionQueue.CheckProgressOfCommitQueue has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.transformOutsideInlineCode (cognitive 22) docs/site/scripts/lib/docfx.mjs:1363— docfx.transformOutsideInlineCode has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 5 (10 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TypeSymbolResolver.TryGetAssembly (cognitive 21) src/Orleans.CodeGenerator/TypeSymbolResolver.cs:198— TypeSymbolResolver.TryGetAssembly has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientClusterManifestProvider.RunAsync (cognitive 21) src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:106— ClientClusterManifestProvider.RunAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalDurableJobManager.CancelAsync (cognitive 21) src/Orleans.DurableJobs/LocalDurableJobManager.cs:310— LocalDurableJobManager.CancelAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationData.CancelRequestAsyncCore (cognitive 21) src/Orleans.Runtime/Catalog/ActivationData.cs:2369— ActivationData.CancelRequestAsyncCore has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodecProvider.TryCreateBaseCodec (cognitive 21) src/Orleans.Serialization/Serializers/CodecProvider.cs:229— CodecProvider.TryCreateBaseCodec has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.TryGetDeliveryProgress (cognitive 21) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1023— PersistentStreamPullingAgent.TryGetDeliveryProgress has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PubSubRendezvousGrain.RegisterProducer (cognitive 21) src/Orleans.Streaming/PubSub/PubSubRendezvousGrain.cs:122— PubSubRendezvousGrain.RegisterProducer has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InMemoryLogBuffer.PrintException (cognitive 21) src/Orleans.TestingHost/Logging/InMemoryLoggerProvider.cs:191— InMemoryLogBuffer.PrintException has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SiloInstanceRecord.SiloInstanceRecord.ctor (cognitive 21) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:50— SiloInstanceRecord.SiloInstanceRecord.ctor has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
TransactionRecoveryTestsRunner.ValidateResults (cognitive 21) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:920— TransactionRecoveryTestsRunner.ValidateResults has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionAgent.CollateParticipants (cognitive 21) src/Orleans.Transactions/DistributedTM/TransactionAgent.cs:244— TransactionAgent.CollateParticipants has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.findRegion (cognitive 21) docs/site/scripts/lib/docfx.mjs:513— docfx.findRegion has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (3 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 11). Of this number, 18 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertZones (cognitive 21) docs/site/scripts/lib/docfx.mjs:961— docfx.convertZones has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (18 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProxyInterfaceModelExtractor.ExtractInterfaceMethods (cognitive 20) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:204— ProxyInterfaceModelExtractor.ExtractInterfaceMethods has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProxyGenerationContext.GetProxyMethodDescription (cognitive 20) src/Orleans.CodeGenerator/ProxyGenerationContext.cs:183— ProxyGenerationContext.GetProxyMethodDescription has cognitive complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceTypeToGrainTypeResolver.GetGrainType (cognitive 20) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:41— GrainInterfaceTypeToGrainTypeResolver.GetGrainType has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainInterfaceTypeToGrainTypeResolver.TryGetGrainType (cognitive 20) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:117— GrainInterfaceTypeToGrainTypeResolver.TryGetGrainType has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
JournaledJobShardManager.TryAssignShardAsync (cognitive 20) src/Orleans.DurableJobs/JournaledJobShardManager.cs:196— JournaledJobShardManager.TryAssignShardAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cognitive 20) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389— ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles has cognitive complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 496, 410). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
LocalGrainDirectory.CalculateGrainDirectoryPartition (cognitive 20) src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs:498— LocalGrainDirectory.CalculateGrainDirectoryPartition has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MultiDimensionalArrayCopier.DeepCopy (cognitive 20) src/Orleans.Serialization/Codecs/MultiDimensionalArrayCodec.cs:215— MultiDimensionalArrayCopier.DeepCopy has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
TypeConverter.ConsumeMetadata (cognitive 20) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151— TypeConverter.ConsumeMetadata has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.GetRecoveryCursor (cognitive 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:617— PersistentStreamPullingAgent.GetRecoveryCursor has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PersistentStreamPullingAgent.RegisterStream (cognitive 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1076— PersistentStreamPullingAgent.RegisterStream has cognitive complexity 20 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cognitive 20) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:22— DynamoDBGatewayListProviderHelper.ParseDataConnectionString has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
link-audit.collectYamlLinkReferences (cognitive 20) docs/site/scripts/lib/link-audit.mjs:285— link-audit.collectYamlLinkReferences has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (4 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
link-audit.renderedDocument (cognitive 20) docs/site/scripts/lib/link-audit.mjs:573— link-audit.renderedDocument has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 5). Most of this is not in the body itself: 7 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 604). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
source-quality.renderedText (cognitive 20) docs/site/scripts/lib/source-quality.mjs:72— source-quality.renderedText has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (7 pts), ternaries 3 (7 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 7). Most of this is not in the body itself: 8 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 75). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
GrainTable.render (cognitive 20) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:139— GrainTable.render has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 10 (15 pts), if/else 4, boolean chains 1 (nesting depth added 5). Of this number, 17 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClusterDiagnosticsService.GetGrainCallFrequencies (cognitive 19) playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:18— ClusterDiagnosticsService.GetGrainCallFrequencies has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializableTypeDescription.SerializableTypeDescription.ctor (cognitive 19) src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:12— SerializableTypeDescription.SerializableTypeDescription.ctor has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SymbolExtensions.ToTypeSyntaxInner (cognitive 19) src/Orleans.CodeGenerator/SyntaxGeneration/SymbolExtensions.cs:129— SymbolExtensions.ToTypeSyntaxInner has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DurableJobsStorageInspector.InspectAsync (cognitive 19) src/Orleans.DurableJobs/DurableJobsStorageInspector.cs:10— DurableJobsStorageInspector.InspectAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DurableJobsOptionsValidator.ValidateConfiguration (cognitive 19) src/Orleans.DurableJobs/Hosting/DurableJobsOptions.cs:227— DurableJobsOptionsValidator.ValidateConfiguration has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
StatelessWorkerGrainContext.ReceiveMessageInternal (cognitive 19) src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:250— StatelessWorkerGrainContext.ReceiveMessageInternal has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientDirectory.PublishUpdates (cognitive 19) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:505— ClientDirectory.PublishUpdates has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.CheckIntegrityAsync (cognitive 19) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:1058— GrainDirectoryPartition.CheckIntegrityAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalSiloHealthEventHistory.RemoveExpired (cognitive 19) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:178— LocalSiloHealthEventHistory.RemoveExpired has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Gateway.DropDisconnectedClients (cognitive 19) src/Orleans.Runtime/Messaging/Gateway.cs:232— Gateway.DropDisconnectedClients has cognitive complexity 19 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ActivationCountPlacementDirector.SelectSiloPowerOfK (cognitive 19) src/Orleans.Runtime/Placement/ActivationCountPlacementDirector.cs:42— ActivationCountPlacementDirector.SelectSiloPowerOfK has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationRepartitioner.FinalizeProtocol (cognitive 19) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:542— ActivationRepartitioner.FinalizeProtocol has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StreamSubscriptionHandleImpl.DeliverItem (cognitive 19) src/Orleans.Streaming/Internal/StreamSubscriptionHandleImpl.cs:217— StreamSubscriptionHandleImpl.DeliverItem has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamoDBStorage.UpdateTableAsync (cognitive 19) src/AWS/Shared/Storage/DynamoDBStorage.cs:272— DynamoDBStorage.UpdateTableAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AzureBlobJournalStorage.UpdateMetadataAsync (cognitive 19) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:120— AzureBlobJournalStorage.UpdateMetadataAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureBlobJournalStorage.DeleteAsync (cognitive 19) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:287— AzureBlobJournalStorage.DeleteAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureTableJournalStorage.UpdateMetadataAsync (cognitive 19) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:154— AzureTableJournalStorage.UpdateMetadataAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureTableTransactionalStateStorage.Load (cognitive 19) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:58— AzureTableTransactionalStateStorage.Load has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NatsStreamConsumer.GetMessages (cognitive 19) src/Orleans.Streaming.NATS/Providers/NatsStreamConsumer.cs:40— NatsStreamConsumer.GetMessages has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionalStateStorageProviderWrapper.Store (cognitive 19) src/Orleans.Transactions/State/TransactionalStateStorageProviderWrapper.cs:37— TransactionalStateStorageProviderWrapper.Store has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertLearnBlocks (cognitive 19) docs/site/scripts/lib/docfx.mjs:782— docfx.convertLearnBlocks has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), error handling 1 (3 pts), ternaries 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
source-quality.validatePackageInventory (cognitive 19) docs/site/scripts/lib/source-quality.mjs:675— source-quality.validatePackageInventory has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), ternaries 2 (5 pts), loops 3, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IdClashAttributeAnalyzer.AnalyzeNamedType (cognitive 18) src/Orleans.Analyzers/IdClashAttributeAnalyzer.cs:42— IdClashAttributeAnalyzer.AnalyzeNamedType has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivityPropagationIncomingGrainCallFilter.Invoke (cognitive 18) src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs:147— ActivityPropagationIncomingGrainCallFilter.Invoke has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GatewayManager.UpdateLiveGatewaysSnapshot (cognitive 18) src/Orleans.Core/Messaging/GatewayManager.cs:275— GatewayManager.UpdateLiveGatewaysSnapshot has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationCollector.DeactivateInDueTimeOrder (cognitive 18) src/Orleans.Runtime/Catalog/ActivationCollector.cs:407— ActivationCollector.DeactivateInDueTimeOrder has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Catalog.GetOrCreateActivation (cognitive 18) src/Orleans.Runtime/Catalog/Catalog.cs:133— Catalog.GetOrCreateActivation has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cognitive 18) src/Orleans.Runtime/GrainDirectory/DirectoryMembershipSnapshot.cs:34— DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor has cognitive complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DistributedGrainDirectory.GetRegisteredActivations (cognitive 18) src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:382— DistributedGrainDirectory.GetRegisteredActivations has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReferencedAssemblyProvider.AddFromDependencyContext (cognitive 18) src/Orleans.Serialization/Hosting/ReferencedAssemblyProvider.cs:131— ReferencedAssemblyProvider.AddFromDependencyContext has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodecProvider.CreateCodecInstance (cognitive 18) src/Orleans.Serialization/Serializers/CodecProvider.cs:522— CodecProvider.CreateCodecInstance has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
ReferencedObjectCollection.AddToReferences (cognitive 18) src/Orleans.Serialization/Session/ReferencedObjectCollection.cs:192— ReferencedObjectCollection.AddToReferences has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IPAddressSelector.PickIPAddress (cognitive 18) src/Orleans.Hosting.Kubernetes/ConfigureKubernetesHostingOptions.cs:118— IPAddressSelector.PickIPAddress has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CosmosGrainStorage.TryCreateResources (cognitive 18) src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:331— CosmosGrainStorage.TryCreateResources has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureQueueStreamProviderBuilder.GetQueueOptionBuilder (cognitive 18) src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:44— AzureQueueStreamProviderBuilder.GetQueueOptionBuilder has cognitive complexity 18 (threshold 15). Most of this is not in the body itself: 0 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 48). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ConsistencyTestGrain.Recurse (cognitive 18) src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestGrain.cs:162— ConsistencyTestGrain.Recurse has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReadWriteLock.Find (cognitive 18) src/Orleans.Transactions/State/ReaderWriterLock.cs:490— ReadWriteLock.Find has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
packages.assertUniqueApiRoutes (cognitive 18) docs/site/src/lib/api/packages.ts:362— packages.assertUniqueApiRoutes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
clean-markdown-output.publishMarkdownOverview (cognitive 18) docs/site/src/plugins/clean-markdown-output.mjs:86— clean-markdown-output.publishMarkdownOverview has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 3, ternaries 2, boolean chains 1 (nesting depth added 4). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationSheddingToyHostedService.ExecuteAsync (cognitive 17) playground/ActivationSheddingToy/ActivationSheddingToyHostedService.cs:8— ActivationSheddingToyHostedService.ExecuteAsync has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
InvokableBaseTypeResolver.TryConstructAndValidate (cognitive 17) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:548— InvokableBaseTypeResolver.TryConstructAndValidate has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AliasClashAttributeAnalyzer.CheckMethodAliases (cognitive 17) src/Orleans.Analyzers/AliasClashAttributeAnalyzer.cs:110— AliasClashAttributeAnalyzer.CheckMethodAliases has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
CopierGenerator.GetFieldDescriptions (cognitive 17) src/Orleans.CodeGenerator/CopierGenerator.cs:229— CopierGenerator.GetFieldDescriptions has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MetadataGenerator.GenerateIncrementalMetadata (cognitive 17) src/Orleans.CodeGenerator/MetadataGenerator.cs:26— MetadataGenerator.GenerateIncrementalMetadata has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
SerializerGenerator.AddSerializationMembers (cognitive 17) src/Orleans.CodeGenerator/SerializerGenerator.cs:465— SerializerGenerator.AddSerializationMembers has cognitive complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConfigUtilities.GetLocalIPAddress (cognitive 17) src/Orleans.Core/Configuration/ConfigUtilities.cs:167— ConfigUtilities.GetLocalIPAddress has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientMessageCenter.GetGatewayConnection (cognitive 17) src/Orleans.Core/Messaging/ClientMessageCenter.cs:231— ClientMessageCenter.GetGatewayConnection has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Connection.ProcessOutgoing (cognitive 17) src/Orleans.Core/Networking/Connection.cs:383— Connection.ProcessOutgoing has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
OutsideRuntimeClient.ReceiveResponse (cognitive 17) src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:334— OutsideRuntimeClient.ReceiveResponse has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationMigrationManager.PumpMigrationQueue (cognitive 17) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs:185— ActivationMigrationManager.PumpMigrationQueue has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
IncomingRequestMonitor.Run (cognitive 17) src/Orleans.Runtime/Catalog/IncomingRequestMonitor.cs:64— IncomingRequestMonitor.Run has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StatelessWorkerGrainContext.RunMessageLoop (cognitive 17) src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:139— StatelessWorkerGrainContext.RunMessageLoop has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientDirectory.Run (cognitive 17) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:362— ClientDirectory.Run has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.OnSiloRemovedFromCluster (cognitive 17) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:317— GrainDirectoryPartition.OnSiloRemovedFromCluster has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalGrainDirectory.LookupAsync (cognitive 17) src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs:839— LocalGrainDirectory.LookupAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SiloStatusListenerManager.NotifyObservers (cognitive 17) src/Orleans.Runtime/MembershipService/SiloStatusListenerManager.cs:112— SiloStatusListenerManager.NotifyObservers has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UnknownSiloStatusCache.ValidateSiloStatuses (cognitive 17) src/Orleans.Runtime/MembershipService/UnknownSiloStatusCache.cs:42— UnknownSiloStatusCache.ValidateSiloStatuses has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JsonCodec.ReadValue (cognitive 17) src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:99— JsonCodec.ReadValue has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PooledBufferStream.SetLength (cognitive 17) src/Orleans.Serialization/Buffers/Adaptors/PooledBufferStream.cs:240— PooledBufferStream.SetLength has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Reader.ForkFrom (cognitive 17) src/Orleans.Serialization/Buffers/Reader.cs:586— Reader.ForkFrom has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WellKnownStringComparerCodec.ReadValue (cognitive 17) src/Orleans.Serialization/Codecs/WellKnownStringComparerCodec.cs:67— WellKnownStringComparerCodec.ReadValue has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TypeConverter.InspectTypeCore (cognitive 17) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:563— TypeConverter.InspectTypeCore has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BitStreamFormatter.FormatField (cognitive 17) src/Orleans.Serialization/Utilities/BitStreamFormatter.cs:115— BitStreamFormatter.FormatField has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryObserver.HasConverged (cognitive 17) src/Orleans.TestingHost/GrainDirectoryObserver.cs:123— GrainDirectoryObserver.HasConverged has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StandaloneSiloHandle.StandaloneSiloHandle.ctor (cognitive 17) src/Orleans.TestingHost/StandaloneSiloHandle.cs:46— StandaloneSiloHandle.StandaloneSiloHandle.ctor has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 79, 130, 114). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
LifecycleStageInspector.CleanMethodName (cognitive 17) src/Dashboard/Orleans.Dashboard/Implementation/LifecycleStageInspector.cs:210— LifecycleStageInspector.CleanMethodName has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZooKeeperBasedMembershipTable.ReadCoreAsync (cognitive 17) src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:218— ZooKeeperBasedMembershipTable.ReadCoreAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SQSStorage.ParseDataConnectionString (cognitive 17) src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:76— SQSStorage.ParseDataConnectionString has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureBasedMembershipTable.Parse (cognitive 17) src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:247— AzureBasedMembershipTable.Parse has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
AzureTableJournalStorageProvider.ListAsync (cognitive 17) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageProvider.cs:69— AzureTableJournalStorageProvider.ListAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConsistencyTestHarness.RunRandomTransactionSequence (cognitive 17) src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestHarness.cs:162— ConsistencyTestHarness.RunRandomTransactionSequence has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cognitive 17) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229— TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase has cognitive complexity 17 (threshold 15). Of this number, 13 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
docfx.convertLinkTarget (cognitive 17) docs/site/scripts/lib/docfx.mjs:1210— docfx.convertLinkTarget has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (9 pts), boolean chains 7, ternaries 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
CopierGenerator.GenerateMemberwiseDeepCopyMethod (cognitive 16) src/Orleans.CodeGenerator/CopierGenerator.cs:380— CopierGenerator.GenerateMemberwiseDeepCopyMethod has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializableSourceOutputGenerator.CreateReferencedSerializableSourceOutputs (cognitive 16) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:122— SerializableSourceOutputGenerator.CreateReferencedSerializableSourceOutputs has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultOptionsFormatter.FormatProperty (cognitive 16) src/Orleans.Core/Configuration/OptionLogger/DefaultOptionsFormatter.cs:88— DefaultOptionsFormatter.FormatProperty has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JournalCatalogRange.JournalCatalogRange.ctor (cognitive 16) src/Orleans.Journaling/JournalCatalogRange.cs:5— JournalCatalogRange.JournalCatalogRange.ctor has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JournalingHostingExtensions.AddJournalStorage (cognitive 16) src/Orleans.Journaling/JournalingHostingExtensions.cs:140— JournalingHostingExtensions.AddJournalStorage has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationCollector.TryRescheduleCollection (cognitive 16) src/Orleans.Runtime/Catalog/ActivationCollector.cs:157— ActivationCollector.TryRescheduleCollection has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationCollector.RunMemoryBasedDeactivationLoop (cognitive 16) src/Orleans.Runtime/Catalog/ActivationCollector.cs:730— ActivationCollector.RunMemoryBasedDeactivationLoop has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
VirtualBucketsRingProvider.CalculateTargetSilo (cognitive 16) src/Orleans.Runtime/ConsistentRing/VirtualBucketsRingProvider.cs:245— VirtualBucketsRingProvider.CalculateTargetSilo has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.GetSnapshotAsync (cognitive 16) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:115— GrainDirectoryPartition.GetSnapshotAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrainDirectoryPartition.AcquireRangeAsync (cognitive 16) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:522— GrainDirectoryPartition.AcquireRangeAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RingRangeCollection.Difference (cognitive 16) src/Orleans.Runtime/GrainDirectory/RingRangeCollection.cs:156— RingRangeCollection.Difference has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClusterManifestProvider.ProcessMembershipUpdates (cognitive 16) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:118— ClusterManifestProvider.ProcessMembershipUpdates has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClusterManifestProvider.TryFillMissingManifestsFromPeers (cognitive 16) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:356— ClusterManifestProvider.TryFillMissingManifestsFromPeers has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PlacementService.GetCompatibleSilos (cognitive 16) src/Orleans.Runtime/Placement/PlacementService.cs:169— PlacementService.GetCompatibleSilos has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActivationRebalancerWorker.RunRebalancingCycle (cognitive 16) src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerWorker.cs:235— ActivationRebalancerWorker.RunRebalancingCycle has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
BufferSliceReaderInput.GetNext (cognitive 16) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:41— BufferSliceReaderInput.GetNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SpanEnumerator.MoveNext (cognitive 16) src/Orleans.Serialization/Buffers/PooledBuffer.cs:639— SpanEnumerator.MoveNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (MemoryEnumerator.MoveNext) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
MemoryEnumerator.MoveNext (cognitive 16) src/Orleans.Serialization/Buffers/PooledBuffer.cs:753— MemoryEnumerator.MoveNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (SpanEnumerator.MoveNext) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FieldHeaderCodec.ReadTypeForAnalysis (cognitive 16) src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:191— FieldHeaderCodec.ReadTypeForAnalysis has cognitive complexity 16 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DictionaryBaseCodec.Deserialize (cognitive 16) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:276— DictionaryBaseCodec.Deserialize has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CodecProvider.ConsumeMetadata (cognitive 16) src/Orleans.Serialization/Serializers/CodecProvider.cs:95— CodecProvider.ConsumeMetadata has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PooledQueueCache.SetCursor (cognitive 16) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:269— PooledQueueCache.SetCursor has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
PersistentStreamPullingManager.AddNewQueues (cognitive 16) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:275— PersistentStreamPullingManager.AddNewQueues has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PubSubRendezvousGrain.RemoveDefunctSystemTargetProducers (cognitive 16) src/Orleans.Streaming/PubSub/PubSubRendezvousGrain.cs:217— PubSubRendezvousGrain.RemoveDefunctSystemTargetProducers has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AzureTableJournalStorage.ReplaceAsync (cognitive 16) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:469— AzureTableJournalStorage.ReplaceAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CassandraClusteringTable.ReadConsistentAsync (cognitive 16) src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs:269— CassandraClusteringTable.ReadConsistentAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure (cognitive 16) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:438— TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionRecoveryTestsRunner.RecoverTransactions (cognitive 16) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:691— TransactionRecoveryTestsRunner.RecoverTransactions has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.expandIncludesInternal (cognitive 16) docs/site/scripts/lib/docfx.mjs:426— docfx.expandIncludesInternal has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 3 (6 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
docfx.convertLinks (cognitive 16) docs/site/scripts/lib/docfx.mjs:1257— docfx.convertLinks has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 4, ternaries 2 (nesting depth added 2). Most of this is not in the body itself: 0 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 1258). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
packages.buildTypeSignature (cognitive 16) docs/site/src/lib/api/packages.ts:247— packages.buildTypeSignature has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 7 (9 pts), if/else 3 (4 pts), boolean chains 2, loops 1 (nesting depth added 3). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
FunctionTooLong: link-audit.auditSourceLinks docs/site/scripts/lib/link-audit.mjs:418— FunctionTooLong — auditSourceLinks runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Near-duplicate member pair (33 shared lines) src/Orleans.CodeGenerator/CopierGenerator.cs:170— src/Orleans.CodeGenerator/CopierGenerator.cs:170-227 | src/Orleans.CodeGenerator/SerializerGenerator.cs:206-255 — These two members are variants of one another: 33 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (43 corresponding lines) · ×1
Edited copy of a member (43 corresponding lines) src/Orleans.CodeGenerator/CopierGenerator.cs:120— src/Orleans.CodeGenerator/CopierGenerator.cs:120-166 | src/Orleans.CodeGenerator/SerializerGenerator.cs:142-202 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (37 corresponding lines) · ×1
Edited copy of a member (37 corresponding lines) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:72— src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:72-112 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:367-449 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×1
Edited copy of a member (9 corresponding lines) src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:87— src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:87-97 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:160-170 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Members sharing a duplicated core (19 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (19 members, 50+ identical tokens) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:20— src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:20-60 | src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:63-103 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16-63 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:66-114 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:18-58 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:13-61 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:13-68 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:18-64 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:20-66 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:20-60 | src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:45-101 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:23-53 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:56-86 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:20-51 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:15-75 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:21-58 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:19-49 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:20-58 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:61-99 — These 19 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 19 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 19 times.
D4 · Code Duplication· Members sharing a duplicated core (14 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (14 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:158— src/Orleans.Serialization/Codecs/TupleCodec.cs:158-171 | src/Orleans.Serialization/Codecs/TupleCodec.cs:306-320 | src/Orleans.Serialization/Codecs/TupleCodec.cs:473-488 | src/Orleans.Serialization/Codecs/TupleCodec.cs:660-676 | src/Orleans.Serialization/Codecs/TupleCodec.cs:864-881 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1085-1104 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1324-1343 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:183-191 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:300-309 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:433-443 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:579-590 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:739-752 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:914-928 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1105-1119 — These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times.
D4 · Code Duplication· Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (8 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:108— src/Orleans.Serialization/Codecs/TupleCodec.cs:108-128 | src/Orleans.Serialization/Codecs/TupleCodec.cs:246-268 | src/Orleans.Serialization/Codecs/TupleCodec.cs:406-429 | src/Orleans.Serialization/Codecs/TupleCodec.cs:583-607 | src/Orleans.Serialization/Codecs/TupleCodec.cs:780-805 | src/Orleans.Serialization/Codecs/TupleCodec.cs:994-1020 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1226-1253 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1474-1502 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (6 members, 50+ identical tokens) src/Orleans.Serialization/Serializer.cs:80— src/Orleans.Serialization/Serializer.cs:80-87 | src/Orleans.Serialization/Serializer.cs:98-104 | src/Orleans.Serialization/Serializer.cs:182-190 | src/Orleans.Serialization/Serializer.cs:232-239 | src/Orleans.Serialization/Serializer.cs:250-256 | src/Orleans.Serialization/Serializer.cs:266-273 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
Duplicated block (69–103 lines × 2) src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs:1708— src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs:1708-1776 | src/Orleans.Reminders/ErrorCodes.cs:10-112 — before extracting anything, compare `src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs` and `src/Orleans.Reminders/ErrorCodes.cs` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (63 lines × 2) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:144— src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:144-206 | src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:171-233 — before extracting anything, compare `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs` and `src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 139 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:144` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (48 lines × 2) src/Orleans.Serialization/Buffers/PooledBuffer.cs:649— src/Orleans.Serialization/Buffers/PooledBuffer.cs:649-696 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:763-810 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/PooledBuffer.cs:649` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (47 lines × 4) src/Orleans.Serialization/Codecs/ArrayCodec.cs:61— src/Orleans.Serialization/Codecs/ArrayCodec.cs:61-107 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:216-262 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:376-422 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:539-585 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ArrayCodec.cs:61` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (37–45 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageOptions.cs:121— src/AWS/Orleans.Journaling.S3/S3JournalStorageOptions.cs:121-157 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageOptions.cs:72-116 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageOptions.cs:86-130 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
Duplicated block (45 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:121— src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:121-165 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:195-239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:121` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (36–41 lines × 2) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:398— src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:398-438 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:387-422 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (38 lines × 2) src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:69— src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:69-106 | src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs:84-121 — before extracting anything, compare `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs` and `src/Orleans.Connections.Security/Security/TlsServerConnectionMiddleware.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 139 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Connections.Security/Security/TlsClientConnectionMiddleware.cs:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (37 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs:11— src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs:11-47 | src/AWS/Orleans.Transactions.DynamoDB/Options/DynamoDBTransactionalStorageOptions.cs:21-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs:11` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (36–37 lines × 2) src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16— src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16-51 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:66-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (33–36 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:127— src/Orleans.Serialization/Codecs/CollectionCodec.cs:127-159 | src/Orleans.Serialization/Codecs/ListCodec.cs:126-161 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (32–33 lines × 4) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101-132 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:85-116 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:100-131 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:168-200 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (32 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs:8— src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs:8-39 | src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBGatewayOptions.cs:8-39 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptions.cs:8-39 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBGatewayOptions.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs:8` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (27 lines × 3) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:51— src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:51-77 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:649-675 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:763-789 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (26 lines × 4) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26— src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26-51 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:23-48 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:24-49 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:22-47 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 69 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24–25 lines × 2) src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:200— src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:200-223 | src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:242-266 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (24 lines × 4) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:21— src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:21-44 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:19-42 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:21-44 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:21-44 — before extracting anything, compare `src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs` and `src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:21` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 3) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:162— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:162-185 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:139-162 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:183-206 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18–24 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:684— src/Orleans.CodeGenerator/CopierGenerator.cs:684-707 | src/Orleans.CodeGenerator/SerializerGenerator.cs:736-753 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:684` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 3) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:79— src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:79-101 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:204-226 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:322-344 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (20–23 lines × 2) src/Azure/Shared/Storage/AzureTableDataManager.cs:674— src/Azure/Shared/Storage/AzureTableDataManager.cs:674-696 | src/Azure/Shared/Storage/AzureTableDataManager.cs:734-753 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Shared/Storage/AzureTableDataManager.cs:674` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (22 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34— src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34-55 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:43-64 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:35-56 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (21 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:49— src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:49-69 | src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:116-136 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:60-80 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:47-67 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 87 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (18–21 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:115— src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:115-135 | src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:185-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:183` calls `DelayBeforeRetry` and `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:114` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 7) src/Orleans.Serialization/Codecs/TupleCodec.cs:186— src/Orleans.Serialization/Codecs/TupleCodec.cs:186-204 | src/Orleans.Serialization/Codecs/TupleCodec.cs:336-354 | src/Orleans.Serialization/Codecs/TupleCodec.cs:505-523 | src/Orleans.Serialization/Codecs/TupleCodec.cs:694-712 | src/Orleans.Serialization/Codecs/TupleCodec.cs:900-918 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1124-1142 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1364-1382 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:186` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:502` calls `default` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:184` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17–18 lines × 6) src/Orleans.Serialization/Codecs/CollectionCodec.cs:63— src/Orleans.Serialization/Codecs/CollectionCodec.cs:63-80 | src/Orleans.Serialization/Codecs/ListCodec.cs:62-79 | src/Orleans.Serialization/Codecs/QueueCodec.cs:67-83 | src/Orleans.Serialization/Codecs/StackCodec.cs:71-88 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:80-97 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:71-88 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18 lines × 4) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:92— src/Orleans.Serialization/Codecs/DictionaryCodec.cs:92-109 | src/Orleans.Serialization/Codecs/DictionaryCodec.cs:286-303 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:71-88 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:146-163 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:86— src/Orleans.Serialization/Codecs/CollectionCodec.cs:86-103 | src/Orleans.Serialization/Codecs/ListCodec.cs:85-102 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:94-111 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:86` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (16–17 lines × 8) src/Orleans.Serialization/Codecs/CollectionCodec.cs:63— src/Orleans.Serialization/Codecs/CollectionCodec.cs:63-78 | src/Orleans.Serialization/Codecs/CollectionCodec.cs:132-148 | src/Orleans.Serialization/Codecs/ListCodec.cs:62-77 | src/Orleans.Serialization/Codecs/ListCodec.cs:131-147 | src/Orleans.Serialization/Codecs/QueueCodec.cs:67-82 | src/Orleans.Serialization/Codecs/StackCodec.cs:71-86 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:80-95 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:71-86 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 142 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/CollectionCodec.cs:81` calls `RecordObject` and `src/Orleans.Serialization/Codecs/CollectionCodec.cs:150` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:50— src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:50-66 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs:50-66 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs:50-66 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (16 lines × 7) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26— src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26-41 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:59-74 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:23-38 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:24-39 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:22-37 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:25-40 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:66-81 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 69 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:26` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 4) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19— src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19-34 | src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:43-58 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:19-34 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:18-33 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:19` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `ISiloBuilder` in one and `IClientBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15–16 lines × 2) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89— src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89-103 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:200-215 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14–15 lines × 10) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34— src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34-48 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:46-59 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:32-46 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:32-46 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:34-48 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:34-48 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:34-48 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:31-45 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:32-46 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:30-44 — before extracting anything, compare `src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs` and `src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 8) src/Orleans.Serialization/Codecs/TupleCodec.cs:111— src/Orleans.Serialization/Codecs/TupleCodec.cs:111-125 | src/Orleans.Serialization/Codecs/TupleCodec.cs:249-263 | src/Orleans.Serialization/Codecs/TupleCodec.cs:409-423 | src/Orleans.Serialization/Codecs/TupleCodec.cs:586-600 | src/Orleans.Serialization/Codecs/TupleCodec.cs:783-797 | src/Orleans.Serialization/Codecs/TupleCodec.cs:997-1011 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1229-1243 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1477-1491 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:249` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:425` calls `DeepCopy` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:265` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (15 lines × 7) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:199— src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:199-213 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:317-331 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:451-465 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:598-612 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:760-774 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:937-951 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1128-1142 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:199` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `reader` to `T2) ReadValue<TInput>(ref Reader<TInput>` in one and `T3) ReadValue<TInput>(ref Reader<TInput>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:332` calls `ReadValue` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:214` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–15 lines × 4) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29-43 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:36-50 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:24-37 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:33-47 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14–15 lines × 3) src/Orleans.Core/Networking/ClientOutboundConnection.cs:128— src/Orleans.Core/Networking/ClientOutboundConnection.cs:128-141 | src/Orleans.Runtime/Networking/GatewayInboundConnection.cs:188-202 | src/Orleans.Runtime/Networking/SiloConnection.cs:304-317 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Networking/ClientOutboundConnection.cs:128` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14–15 lines × 2) src/Google/Shared/Storage/FirestoreDataManager.cs:309— src/Google/Shared/Storage/FirestoreDataManager.cs:309-322 | src/Google/Shared/Storage/FirestoreDataManager.cs:382-396 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Google/Shared/Storage/FirestoreDataManager.cs:309` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14 lines × 4) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:642— src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:642-655 | src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:788-801 | src/Orleans.Transactions/TransactionAttribute.cs:503-516 | src/Orleans.Transactions/TransactionAttribute.cs:673-686 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:642` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–14 lines × 4) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:91— src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:91-103 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:125-136 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:202-215 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:271-283 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:90` calls `ConfigureComponent` and `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:124` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13–14 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:438— src/Orleans.CodeGenerator/SerializerGenerator.cs:438-451 | src/Orleans.CodeGenerator/SerializerGenerator.cs:618-630 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.CodeGenerator/SerializerGenerator.cs:631` calls `AddTypeParameterListParameters`, `TypeParameter` and `src/Orleans.CodeGenerator/SerializerGenerator.cs:452` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 4) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64— src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64-76 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:60-75 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:58-73 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:243-259 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 8) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40— src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40-51 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:73-84 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:37-48 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:29-40 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:38-49 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:36-47 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:39-50 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:80-91 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 69 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 5) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:82— src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:82-93 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:70-81 | src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:70-81 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:82-93 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:72-83 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `ImmutableHashSet<T>` in one and `ImmutableSortedSet<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9–12 lines × 3) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85— src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85-93 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:684-695 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:798-809 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9–12 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102— src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102-1110 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1259-1270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 7) src/Orleans.Serialization/Codecs/TupleCodec.cs:158— src/Orleans.Serialization/Codecs/TupleCodec.cs:158-168 | src/Orleans.Serialization/Codecs/TupleCodec.cs:306-316 | src/Orleans.Serialization/Codecs/TupleCodec.cs:473-483 | src/Orleans.Serialization/Codecs/TupleCodec.cs:660-670 | src/Orleans.Serialization/Codecs/TupleCodec.cs:864-874 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1085-1095 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1324-1334 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:158` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:317` calls `WriteField` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:170` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 5) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35— src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35-45 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:42-52 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:38-48 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:40-50 | src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:72-82 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 4) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57— src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57-66 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:82-91 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:53-62 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:55-64 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `items` to `IReadOnlyCollection<KeyValuePair<TKey, TValue>>` in one and `IReadOnlyCollection<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8–10 lines × 3) src/Orleans.Runtime/Storage/StateStorageBridge.cs:313— src/Orleans.Runtime/Storage/StateStorageBridge.cs:313-320 | src/Orleans.Runtime/Storage/StateStorageBridge.cs:350-357 | src/Orleans.Runtime/Storage/StateStorageBridge.cs:386-395 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Storage/StateStorageBridge.cs:313` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:535— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:535-544 | src/Orleans.Serialization/Codecs/TupleCodec.cs:441-450 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:397-406 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:535` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–9 lines × 7) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867-875 | src/Orleans.Serialization/Codecs/TupleCodec.cs:819-827 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1035-1042 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1269-1276 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:694-702 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:864-871 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1049-1056 — there are 7 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 4) src/Orleans.Serialization/Codecs/TupleCodec.cs:1210— src/Orleans.Serialization/Codecs/TupleCodec.cs:1210-1217 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1457-1464 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1006-1013 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1202-1209 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1210` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 7) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898— src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898-904 | src/Orleans.Serialization/Codecs/TupleCodec.cs:850-856 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1070-1076 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1308-1314 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:725-731 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:899-905 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1088-1094 — there are 7 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:1077` calls `UnwrapService` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:857` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 12) src/Orleans.Serialization/Codecs/TupleCodec.cs:312— src/Orleans.Serialization/Codecs/TupleCodec.cs:312-317 | src/Orleans.Serialization/Codecs/TupleCodec.cs:479-484 | src/Orleans.Serialization/Codecs/TupleCodec.cs:666-671 | src/Orleans.Serialization/Codecs/TupleCodec.cs:870-875 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1091-1096 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1330-1335 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:301-306 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:434-439 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:580-585 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:740-745 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:915-920 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1106-1111 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 283 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:485` calls `WriteField` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:319` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 7) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:183— src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:183-188 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:300-305 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:433-438 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:579-584 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:739-744 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:914-919 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1105-1110 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:183` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:306` calls `WriteField` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:190` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (2–5 lines × 3) src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:192— src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:192-196 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:254-255 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:317-321 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:192` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication· Edited copy of a member (28 corresponding lines) · ×1
Edited copy of a member (28 corresponding lines) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:57— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:57-90 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:98-125 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Members sharing a duplicated core (11 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (11 members, 50+ identical tokens) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233-257 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:265-296 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:303-326 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:333-361 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:371-413 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:421-458 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:467-506 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:514-547 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:555-605 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613-663 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:670-713 — These 11 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 11 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 11 times.
Duplicated block (40–42 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613-654 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:670-709 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25–30 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61-90 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:101-125 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:60` calls `RandomTestGrain` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:99` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–19 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:521— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:521-534 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:568-586 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17–18 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:486— src/Orleans.TestingHost/InProcTestCluster.cs:486-503 | src/Orleans.TestingHost/TestCluster.cs:529-545 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 151 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9–11 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:33— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:33-41 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:66-76 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:105-114 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:76` calls `MultiGrainAdd` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:41` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 6) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:242— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:242-251 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:313-322 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:346-355 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:439-448 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:534-543 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:586-595 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 5) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:242— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:242-250 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:346-354 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:439-447 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:586-594 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:640-648 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 8) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244-251 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:285-292 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:315-322 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:348-355 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:402-409 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441-448 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:536-543 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:588-595 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 5) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:251— src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:251-255 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:355-359 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:652-656 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:657-661 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:707-711 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:649` calls `AssertTState`, `Should`, `Be` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:250` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Coverage not measured — .NET and JavaScript/TypeScript suite — Coverage NOT MEASURED: the .NET half could not be measured — the repository wires up no coverage collector for `--collect:"XPlat Code Coverage"` to use; the JavaScript/TypeScript half could not be measured — docs/site/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
Non-idempotent mutation: Journaling.DurableList.AddRange src/Orleans.Journaling/DurableList.cs:170— `Journaling.DurableList.AddRange` mutates persistent state (a repository write) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write.
Condition was already decided — an earlier guard makes this test constant src/Orleans.Core.Abstractions/Utils/Utils.cs:40— Control only reaches here when `enumerator.MoveNext()` is true, because the guard on line 36 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test.
IC1 · Incompleteness & stubs· Skipped test marks a known-real bug · ×1
Skipped test marks a known-real bug test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:416— A test is skipped with reason "Flaky test. Needs to be investigated." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten.
Sync-over-async blocking — 43 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Awaits without ConfigureAwait(false) — Only 564/3422 awaits use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
Duplication concentrated across 5 sibling directories (8 clone groups) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103— 8 duplicated blocks under src/Dashboard/Orleans.Dashboard.App/src/ have copies in at least two of the sibling directories components, grains, lifecycle, overview, silos — 7 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication· Duplicated block with local edits (51 matched lines × 2 locations) · ×1
Duplicated block with local edits (51 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103— src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 · src/Dashboard/Orleans.Dashboard.App/src/grains/silo-table.tsx:33 — the two spans are one implementation copied and then locally edited — 342 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (35 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138— src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:121 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
Duplicated block (31 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66— src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:70 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (21 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:45— src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:45 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:64 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication· Duplicated block with local edits (20 matched lines × 2 locations) · ×1
Duplicated block with local edits (20 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24— src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24 · src/Dashboard/Orleans.Dashboard.App/src/components/time-series-chart.tsx:72 — the two spans are one implementation copied and then locally edited — 90 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (20 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108— src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108 · src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx:212— src/Dashboard/Orleans.Dashboard.App/src/index.tsx:212 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:234 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (17 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71— src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71 · src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180— src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:196 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (14 lines × 4 locations) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188— src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:202 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:216 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:230 — all 4 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
Duplicated block (13 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158— src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:284 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication· Duplicated block with local edits (9 matched lines × 2 locations) · ×1
Duplicated block with local edits (9 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15— src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15 · src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:16 — the two spans are one implementation copied and then locally edited — 65 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (9 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41— src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31— src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31 · src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:21 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Duplicated block (6 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11— src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:39 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
Complex function parseSuffix (cyclomatic 14, cognitive 14) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:55— parseSuffix has cyclomatic complexity 14 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function parseType (cyclomatic 11, cognitive 11) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:79— parseType has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function formatMemberName (cyclomatic 11, cognitive 10) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:13— formatMemberName has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Third-party script without Subresource Integrity playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:7— `https://d3js.org/d3.v7.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×1
Disposes a dependency it does not own src/Orleans.DurableJobs/JournaledJobShard.cs:272— `_stateManager` is never created by `JournaledJobShard` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 272). Its declared type `IJournaledStateManager` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Commented-out code playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:24— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:25— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code playground/DurableJobsJournaling/DurableJobsJournaling.Silo/WorkflowGrains.cs:41— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/Orleans3CompatibleStringKeyHasher.cs:35— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/Orleans3CompatibleStringKeyHasher.cs:36— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Azure/Orleans.Reminders.AzureStorage/Storage/RemindersTableManager.cs:49— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Azure/Orleans.Reminders.AzureStorage/Storage/RemindersTableManager.cs:172— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueBatchContainer.cs:78— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/CopierGenerator.cs:135— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/InvokableGenerator.cs:419— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/InvokableGenerator.cs:420— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/InvokableGenerator.cs:422— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/SerializerGenerator.cs:171— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.CodeGenerator/SyntaxGeneration/SymbolSyntaxExtensions.cs:73— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Manifest/GrainPropertiesResolver.cs:39— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:381— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Utils/SetExtensions.cs:35— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Utils/SetExtensions.cs:37— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Utils/SetExtensions.cs:39— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Utils/SetExtensions.cs:41— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Orleans.Core/Utils/SetExtensions.cs:43— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:34— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:35— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:105— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:107— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:111— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:113— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:120— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:203— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:293— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:333— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:398— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Fat interface: IGrainFactory (17 members) src/Orleans.Core.Abstractions/Core/IGrainFactory.cs:47— `IGrainFactory` declares 17 members under just 3 distinct name(s): `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `CreateObjectReference`, `DeleteObjectReference`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IMembershipTable (16 members) src/Orleans.Core/SystemTargetInterfaces/IMembershipTable.cs:24— `IMembershipTable` declares 16 members: `InitializeMembershipTable`, `InitializeMembershipTableAsync`, `DeleteMembershipTableEntries`, `DeleteMembershipTableEntriesAsync`, `CleanupDefunctSiloEntries`, `CleanupDefunctSiloEntriesAsync`, `ReadRow`, `ReadRowAsync`, `ReadAll`, `ReadAllAsync`, `InsertRow`, `InsertRowAsync`, `UpdateRow`, `UpdateRowAsync`, `UpdateIAmAlive`, `UpdateIAmAliveAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IManagementGrain (34 members) src/Orleans.Core/SystemTargetInterfaces/IManagementGrain.cs:13— `IManagementGrain` declares 34 members under just 15 distinct name(s): `GetHosts`, `GetHosts`, `GetDetailedHosts`, `GetDetailedHosts`, `ForceGarbageCollection`, `ForceGarbageCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceRuntimeStatisticsCollection`, `ForceRuntimeStatisticsCollection`, `GetRuntimeStatistics`, `GetRuntimeStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetDetailedGrainStatistics`, `GetDetailedGrainStatistics`, `GetGrainActivationCount`, `GetGrainActivationCount`, `GetTotalActivationCount`, `GetTotalActivationCount`, `SendControlCommandToProvider`, `SendControlCommandToProvider`, `GetActivationAddress`, `GetActivationAddress`, `GetActiveGrains`, `GetActiveGrains`, `GetGrainCallFrequencies`, `GetGrainCallFrequencies`, `ResetGrainCallFrequencies`, `ResetGrainCallFrequencies`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 34 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 34 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IReminderServiceLifecycleHarness (22 members) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:16— `IReminderServiceLifecycleHarness` declares 22 members: `GrainFactory`, `ReminderTable`, `UtcNow`, `ReminderLoadingWindow`, `ReminderRefreshPeriod`, `ActiveSilos`, `WaitForStartupReadinessAsync`, `AdvanceAsync`, `RefreshAsync`, `WaitForOwnerCountAsync`, `GetOwners`, `IsOwner`, `WaitForScheduleAsync`, `GetLocalStartCount`, `GetLocalStopCount`, `GetScheduleChangeCount`, `WaitForScheduleChangeCountAsync`, `WaitForTickCountAsync`, `GetTickCount`, `JoinOneSiloAsync`, `LeaveSiloAsync`, `WaitForTopologyReconciliationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IStreamPubSub (17 members) src/Orleans.Streaming/Providers/IStreamProviderRuntime.cs:72— `IStreamPubSub` declares 17 members under just 9 distinct name(s): `RegisterProducer`, `RegisterProducer`, `UnregisterProducer`, `UnregisterProducer`, `RegisterConsumer`, `RegisterConsumer`, `UnregisterConsumer`, `UnregisterConsumer`, `ProducerCount`, `ProducerCount`, `ConsumerCount`, `ConsumerCount`, `GetAllSubscriptions`, `GetAllSubscriptions`, `CreateSubscriptionId`, `FaultSubscription`, `FaultSubscription`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Documentation: no project overview README.md— The overview section names Orleans as 'a cross-platform framework for building robust, scalable distributed applications' and lists features like multi-server environments but does not describe what the project is or what it does beyond this line. Add a one-paragraph description of the Orleans runtime's purpose (single-server to globally distributed cloud apps) so readers can skip the overview section if they already know the framework.
Documentation: no installation or build instructions README.md— There are no installation, build, or setup instructions in the README. Add a short 'Getting started' block covering how to install Orleans and run the first sample (Hello World).
Documentation: no architecture or design documentation src/Orleans.Serialization.TestKit/README.md— The Orleans Serialization Test Kit README is a usage example with no architecture or design documentation for the test framework itself. Add an Architecture section describing how tests are written and run, where test data lives, and any constraints.
Documentation: no architecture or design documentation src/Orleans.Serialization.Abstractions/README.md— The Orleans Serialization Abstractions README is a usage example with no architecture or design documentation for the serialization abstractions. Add an Architecture section describing what interfaces and attributes are exposed, how they work together, and any constraints.
Documentation: written for insiders src/Orleans.Runtime/README.md— The 'Getting Started' section is a NuGet install line with no context for new readers (no description of what Orleans Runtime does, its role in the grain lifecycle, or how it differs from Orleans.Serialization). Add an overview paragraph explaining what Orleans Runtime is and its role as the server-side runtime component hosting grains, managing lifecycles, and providing all runtime services.
IC1 · Incompleteness & stubs· Member throws NotSupportedException · ×3
Member throws NotSupportedException src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:432— `GetEvents`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
Member throws NotSupportedException src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:433— `ImportRequestContext`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
Member throws NotSupportedException src/Orleans.Core/Runtime/ClientGrainContext.cs:174— `ReceiveMessage`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
Duplicated predicate src/Orleans.Core/Core/DefaultClientServices.cs:272— `assemblyName is { Length: > 0 } && assemblyName.Contains("Orleans")` appears character-identically in 2 files — src/Orleans.Core/Core/DefaultClientServices.cs, src/Orleans.Runtime/Hosting/DefaultSiloServices.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Orleans.Core/Core/DefaultClientServices.cs:190— `bool.TryParse(cfg["EnableDistributedTracing"], out var enableDistributedTracing) && enableDistributedTracing` appears character-identically in 2 files — src/Orleans.Core/Core/DefaultClientServices.cs, src/Orleans.Runtime/Hosting/DefaultSiloServices.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:36— `grainBinding.TryGetValue(WellKnownGrainTypeProperties.StreamBindingIncludeNamespaceKey, out var value) && string.Equals(value, "true", Strin…` appears character-identically in 2 files — src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs, src/Orleans.Streaming/Core/DefaultStreamIdMapper.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 282 significant file(s) lose their only recent owner: src/Orleans.Reminders/ReminderService/LocalReminderService.cs, src/Orleans.Transactions/State/TransactionQueue.cs, src/Orleans.Runtime/MembershipService/MembershipTableManager.cs, src/Orleans.Serialization.FSharp/FSharpCodecs.cs, src/Orleans.Serialization/Buffers/ArcBufferWriter.cs, src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs, src/Orleans.Journaling/JournaledStateManager.cs, src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs (+274 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 3 significant file(s) lose their only recent owner: src/Orleans.Streaming/Common/Monitors/DefaultCacheMonitor.cs, src/Orleans.Streaming/Common/Monitors/DefaultQueueAdapterReceiverMonitor.cs, src/Orleans.Streaming/Common/Monitors/DefaultBlockPoolMonitor.cs. Pair on, review, or document these before any departure.
Shell project: ChaoticCluster.AppHost playground/ChaoticCluster/ChaoticCluster.AppHost/ChaoticCluster.AppHost.csproj— `ChaoticCluster.AppHost` contributes only 4 significant line(s) — an empty/placeholder project is structural noise. Remove it or fold its contents into a real project.
Shell project: Orleans.Dashboard.Abstractions(net8.0) src/Dashboard/Orleans.Dashboard.Abstractions/Orleans.Dashboard.Abstractions.csproj— `Orleans.Dashboard.Abstractions(net8.0)` contributes only 6 significant line(s) — an empty/placeholder project is structural noise. Remove it or fold its contents into a real project.
Thin authorization enforcement — Authorization machinery exists but no [Authorize] usage and no imperative guard calls were found at handlers.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 2 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (288 single-owned of 1119 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1119 of the 2005 production source files in this repository met that bar). They are anonymized user #3 (1 file(s)), anonymized user #4 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above.
Thin analysable surface across projects — 1 project(s) carry only a thin slice of real code (e.g. `ActivationRebalancing.Frontend` with 42 significant line(s)). The mean analysable-surface weight is 98 %, lowering Solution Shape by about 0.13 point(s). Consolidate thin projects or grow them into substantial, well-scoped assemblies.
No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
redundant comment test/Orleans.Runtime.Internal.Tests/StorageTests/LocalStoreTests.cs:64— "TestContext.TestName;" — delete - generated test-naming placeholder restating the call site
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 5 of 154 project(s) overshoot their size bounds, lowering Project Cohesion to 9.4/10. The most over is `Orleans.Runtime(net8.0)` (43301 LoC, 149 public types across 20 namespaces). Review these for cohesion — split a project that spans unrelated responsibilities.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
REDACTED
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 83 of 1125 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1125 of the 2005 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: src/Orleans.Core/Runtime/RingRange.cs, src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs, src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs, src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs, src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs, src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs, src/Orleans.Streaming/QueueBalancer/BestFitBalancer.cs, src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventHubPartitionDataGenerator.cs (and 75 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body src/Orleans.Core/Networking/Shared/MemoryPoolBlock.cs:52— `Lease` has an empty body — confirm it's an intentional no-op and not an unfinished method.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
README/code drift — README omits the Orleans.Dashboard.App project (admin dashboard) — reported by the model that read the README against this repository; no term search was run for this one, so nothing here has been checked against the tree. Treat it as a reading to confirm, not as a measured contradiction: verify it against the code before acting on it, and if the footprint it describes does exist, this row is wrong.
P10 · Library API & versioning· No explicit versioning · ×1
No explicit versioning — No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 175 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
Logging is not universal — Only 56/81 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 81, 11 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 763/1248 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~1.7 `!` suppressions per 1k syntax nodes — 1817 suppression(s) across the 1092195 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Skipped (documented): Generic_PartiallySpecifyingGenericGrainFulfilsInterface test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:944— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_GenericGrainCanReuseOwnGenArgRepeatedly test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:958— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_RepeatedRearrangedGenArgsResolved test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1003— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_RearrangedGenArgsOfCorrectArityAreResolved test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1061— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_GenArgsCanBeFurtherSpecialized test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1159— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_GenArgsCanBeFurtherSpecializedIntoArrays test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1173— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_CanCastBetweenInterfacesWithFurtherSpecializedGenArgs test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1187— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): Generic_CanCastBetweenInterfacesWithFurtherSpecializedGenArgs_Activating test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1202— Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
Skipped (documented): GrainReference_Interning_Sys_StoreGrain test/Orleans.DefaultCluster.Tests/GrainReferenceTest.cs:181— Skipped with a documented reason — a deferral, not lazy debt: GrainReference interning is not currently implemented.
Skipped (documented): RequestContextCalleeToCallerFlow test/Orleans.DefaultCluster.Tests/RequestContextTest.cs:52— Skipped with a documented reason — a deferral, not lazy debt: Was failing before (just masked as a Pass), needs fixing or removing
Skipped (documented): GettingGrainWithMultipleConstructorsActivesViaDefaultConstructor test/Orleans.DefaultCluster.Tests/SimpleGrainTests.cs:91— Skipped with a documented reason — a deferral, not lazy debt: Grains with multiple constructors are not supported without being explicitly registered.
Skipped (documented): StatelessWorkerFastActivationsDontFailInMultiSiloDeployment test/Orleans.DefaultCluster.Tests/StatelessWorkerTests.cs:154— Skipped with a documented reason — a deferral, not lazy debt: Skipping test for now, since there seems to be a bug
Skipped (documented): ActivationCollectorShouldNotCollectBusyStatelessWorkers test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:414— Skipped with a documented reason — a deferral, not lazy debt: Flaky test. Needs to be investigated.
Skipped (documented): ReconstructClientIdPartitionTest_Observer test/Orleans.Runtime.Internal.Tests/MembershipTests/ClientIdPartitionDataRebuildTests.cs:47— Skipped with a documented reason — a deferral, not lazy debt: Not reliable in PR build, skipping for now
Skipped (documented): ReconstructClientIdPartitionTest_Request test/Orleans.Runtime.Internal.Tests/MembershipTests/ClientIdPartitionDataRebuildTests.cs:73— Skipped with a documented reason — a deferral, not lazy debt: Not reliable in PR build, skipping for now
Skipped (documented): ExceptionPropagationForwardsEntireAggregateException test/Orleans.Runtime.Tests/ExceptionPropagationTests.cs:242— Skipped with a documented reason — a deferral, not lazy debt: Implementation of issue #1378 is still pending
Skipped (documented): RegisterProducerFaultTest test/Orleans.Streaming.Tests/StreamingTests/PubSubRendezvousGrainTests.cs:711— Skipped with a documented reason — a deferral, not lazy debt: This test fails because the producer must be grain reference which is not implied by the IStreamProducerExtension
Skipped (documented): UnregisterProducerFaultTest test/Orleans.Streaming.Tests/StreamingTests/PubSubRendezvousGrainTests.cs:742— Skipped with a documented reason — a deferral, not lazy debt: This test fails because the producer must be grain reference which is not implied by the IStreamProducerExtension
Skipped (documented): AQStreamConsumerOnDroppedClientTest test/Extensions/Orleans.Azure.Tests/Streaming/AQClientStreamTests.cs:111— Skipped with a documented reason — a deferral, not lazy debt: AzureQueue has unpredictable event delivery counts - re-enable when we figure out how to handle this.
Skipped (documented): EH100StreamsTo4PartitionStreamsTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHStreamPerPartitionTests.cs:83— Skipped with a documented reason — a deferral, not lazy debt: Not sure what this test is testing, also the hacky test approach would make this test fail if there's any messages in the hubleft from previous tests
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 336 file(s) — `docs/site/scripts/audit-links.mjs`, `docs/site/scripts/audit-output.mjs`, `docs/site/scripts/generate-legacy-redirects.mjs`, `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, … (+331 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
Run 01a0cc2b-42a0-7b33-9a1b-ade93fea3c4e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 196 · Warnings: 1523 · Recommendations: 167 · Info: 277 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 23-09-2026 @ 02:49 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.