Public report of dotnet/orleans, published 23 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 23 October 2026, 13:17 UTC · Survey ID cd_8f5457dbab2549f38d63579fbab63d61

dotnet/orleans

Measured 23 October 2026, 12:33 UTC, at code version 845672b

A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.

Code coverage is not measured: .NET and JavaScript/TypeScript suite (CouldNotMeasureNoCollector, CouldNotMeasureNoCollector).

Boundary Type-Coupling is not measured: Bounded contexts not declared.

IL efficiency is not measured: The target did not build.

CAI score 55out of 100 At risk Down 2 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A large codebase: 301,355 lines of product code in 418 projects, tests not counted · Estimated rebuild effort: about 10.9 person-years · Weakest lens: Accessibility, 44

Findings by how serious they are

240 critical 1715 serious 537 minor

5 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
23 October 2026, 12:33 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

96of 102 dimensions measured by tools. The other 6 are advisory notes from an AI model, which explain the code but don't count towards the score.
2461of 2492 findings point to an exact file and line, so you can open each one in the code. The other 31 concern the repository as a whole, such as missing documentation.
102dimensions across 8 lenses, read from 301,355 lines of product code in 418 projects.
Chapters

Executive summary

dotnet/orleans scores 55 out of 100, but it is rated At risk while a critical security finding is open; the score itself is unchanged.

The weakest lens counts most in the score, and here that is Accessibility, which scores 44 and is rated Weak. Its Keyboard semantics dimension scores 1 out of 10, and until that reaches 4, Accessibility can't be rated higher than Adequate. The first actions are to make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href and to resolve the 4 Leaked secret finding(s) in REDACTED Scanning, and if Accessibility rose to 70, the score would rise from 55 to about 63.

240 findings are critical: 179 in Explicit Debt, eight in Forms & labels, eight in Project dependency cycles, seven in Dependency Vulnerabilities, seven in Test Quality, six in Secrets (history), six in Static Analysis (SAST), five in Keyboard semantics, four in Captive dependencies, four in REDACTED Scanning, two in Page structure, two in Test isolation, one in Async correctness and one in Knowledge Freshness.

Watchdog couldn't measure 4 dimensions in this code, among them Test Reliability, Dependency Hygiene and Dependency Freshness, so they are left out of the score. The product code is 301,355 lines, which would take an estimated 10.9 person-years, around €1,600,000, to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Accessibility 44 · counts for 45%Production Readiness 58 · counts for 25%Security and Compliance 62 · counts for 14%Code Health 67 · counts for 8%Architecture 71 · counts for 4%Maturity 71 · counts for 2%Performance 78 · counts for 1%Event-Driven 100 · counts for 1%

If Accessibility rose from 44 to 70, the lowest score rated Strong, the score would rise from 55 to about 63.

Code composition: what the lines of code are
Business logic 15%Supporting code 22%Tests 59%Generated by tools 0%Code analyzers 3%
New since the last survey: 209 findings

These 209 critical or serious findings weren't in the previous survey, on 9 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Cyclomatic Complexity · Catalog.GetOrCreateActivation (cyclomatic 22) src/Orleans.Runtime/Catalog/Catalog.cs
  • Cyclomatic Complexity · S3JournalStorage.UpdateMetadataAsync (cyclomatic 17) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs
  • Cyclomatic Complexity · TypeConverter.InspectTypeCore (cyclomatic 16) src/Orleans.Serialization/TypeSystem/TypeConverter.cs
  • Cyclomatic Complexity · S3JournalStorage.ReadAsync (cyclomatic 16) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs
  • Cognitive Complexity · S3JournalStorage.AppendAsync (cognitive 21) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs
  • Cognitive Complexity · SyntaxHelpers.IsGrainClass (cognitive 20) src/Orleans.Analyzers/SyntaxHelpers.cs
  • Cognitive Complexity · ActivationMigrationManager.AcceptMigratingGrains (cognitive 20) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs
  • Cognitive Complexity · ActivationMigrationManager.StartMigration (cognitive 20) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs
  • Cognitive Complexity · S3JournalStorage.ReadAsync (cognitive 16) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs
  • God Classes · MethodTooLong: ActivationData.FinishDeactivating src/Orleans.Runtime/Catalog/ActivationData.cs
  • God Classes · FileTooLong: Manifest/ClusterManifestProvider.cs src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • God Classes · MethodTooLong: ClusterManifestProvider.UpdateManifest src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • God Classes · TooManyMethods: ClusterManifestProvider src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • God Classes · TooManyMethods: Reader src/Orleans.Serialization/Buffers/Reader.cs
  • God Classes · MethodTooLong: SerializerFactoryGenerator.Describe src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs
  • Code Duplication · Members sharing a duplicated core (19 members, 50+ identical tokens) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs
  • Code Duplication · Duplicated block (30–31 lines × 2) src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs
  • Code Duplication · Duplicated block (14–16 lines × 2) src/Orleans.Core/Runtime/GrainReferenceRuntime.cs
  • Code Duplication · Duplicated block (14 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Code Duplication · Duplicated block (9 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Test Quality · No assertions: RandomOperations_WithInjectedFailures_MatchModel test/Orleans.Journaling.Tests/Conformance/JournalStorageConformanceTests.cs
  • REDACTED Scanning · REDACTED
  • REDACTED Scanning · REDACTED
  • Churn × Complexity Hotspots · Hotspot: src/Orleans.Core/Networking/Connection.cs src/Orleans.Core/Networking/Connection.cs
  • Churn × Complexity Hotspots · Hotspot: src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • Churn × Complexity Hotspots · Hotspot: src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs
  • Churn × Complexity Hotspots · Hotspot: src/Orleans.Core/Messaging/Message.cs src/Orleans.Core/Messaging/Message.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Serialization/Codecs/ByteArrayCodec.cs src/Orleans.Serialization/Codecs/ByteArrayCodec.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs
  • Explicit Debt · BarePragmaDisable repeated across 10 files docs/site/src/content/docs/host/snippets/hosting/HostingExamples.cs
  • Explicit Debt · EmptyCatchBlock samples/Chirper/Chirper.Grains/ChirperAccount.cs
  • Explicit Debt · EmptyCatchBlock samples/GPSTracker/GPSTracker.Service/HubListUpdater.cs
  • Explicit Debt · EmptyCatchBlock samples/Voting/Data/PollService.PollWatcherSubscription.cs
  • Explicit Debt · EmptyCatchBlock src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs
  • Explicit Debt · EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/GrainProfilerFilter.cs
  • Explicit Debt · EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs
  • Explicit Debt · EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs
  • Explicit Debt · EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/TraceWriter.cs
  • Explicit Debt · EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/TraceWriter.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Async/TaskExtensions.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Networking/Transport/Sockets/SocketExtensions.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Networking/Transport/Streams/StreamMessageTransport.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Core/Timers/TimerManager.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationData.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationData.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationDirectory.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Catalog/ActivationDirectory.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Core/ManagementGrain.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Runtime/Timers/GrainTimer.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Serialization/Hosting/ReferencedAssemblyProvider.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Streaming/Checkpointers/StreamQueueCheckpointer.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs
  • Explicit Debt · EmptyCatchBlock src/Orleans.Transactions/Diagnostics/TransactionDiagnosticEvents.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Serialization/Buffers/ArcBufferWriter.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestHarness.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/MultipleStreamsTestRunner.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamTestHelperClasses.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamTestHelperClasses.cs
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Knowledge Freshness · Orphaned knowledge src/AdoNet/Shared/Storage/DbStoredQueries.cs
  • Code Duplication · Duplicated block (19 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx
  • Code Duplication · Duplicated block (11 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx
  • Code Duplication · Duplicated block (8 lines × 3 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx
  • Large Files · src/Dashboard/Orleans.Dashboard.App/src/index.tsx: 589 lines of code src/Dashboard/Orleans.Dashboard.App/src/index.tsx
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.Core.Abstractions/Runtime/GrainRequest.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.DurableJobs/IDurableJobReceiverExtension.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/Core/ManagementGrain.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/Core/ManagementGrain.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/GrainDirectory/GrainDirectoryHandoffManager.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs
  • Async correctness · Blocking `SemaphoreSlim.Wait` inside an `async` method src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.TestingHost/InProcTestCluster.cs
  • Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Orleans.TestingHost/TestCluster.cs

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 594 findings

These 594 critical or serious findings were in the previous survey, on 9 October 2026, and are gone from this one. The first 100 are listed here.

  • Cyclomatic Complexity · SendWorker.Execute (cyclomatic 16) src/Orleans.Core/Networking/Connection.cs
  • Cyclomatic Complexity · DynamoDBGrainStorageProviderBuilder.Configure (cyclomatic 16) src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs
  • Cognitive Complexity · StatelessWorkerGrainContext.ReceiveMessageInternal (cognitive 19) src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs
  • God Classes · ClassTooLong: Reader src/Orleans.Serialization/Buffers/Reader.cs
  • God Classes · ClassTooLong: ClusterManifestProvider src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs
  • Code Duplication · Members sharing a duplicated core (19 members, 50+ identical tokens) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs
  • Code Duplication · Duplicated block (36–37 lines × 2) src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs
  • Code Duplication · Duplicated block (30 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Code Duplication · Duplicated block (21 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs
  • Code Duplication · Duplicated block (18 lines × 2) src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs
  • Coupling · Off the main sequence: ChaoticCluster.ServiceDefaults
  • Coupling · Off the main sequence: DurableJobsJournaling.ServiceDefaults
  • Coupling · Off the main sequence: ServiceDefaults
  • Coupling · Off the main sequence: Orleans.CodeGenerator
  • Coupling · Off the main sequence: BroadcastChannel.GrainInterfaces
  • Test Quality · No assertions: SimpleGrainGetGrain test/Orleans.DefaultCluster.Tests/SimpleGrainTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Test Quality · No assertions: CanInitialize test/TestInfrastructure/Orleans.TestingHost.Tests/TestClusterTests.cs
  • Churn × Complexity Hotspots · Hotspot: src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs
  • Churn × Complexity Hotspots · Hotspot: src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Core/Runtime/OutsideRuntimeClient.cs src/Orleans.Core/Runtime/OutsideRuntimeClient.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Serialization/Configuration/TypeManifestOptions.cs src/Orleans.Serialization/Configuration/TypeManifestOptions.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Core/Runtime/CallbackData.cs src/Orleans.Core/Runtime/CallbackData.cs
  • Churn × Complexity Hotspots · Repeated repair: src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs
  • Explicit Debt · BarePragmaDisable repeated 15 times in 9 files docs/site/src/content/docs/host/snippets/hosting/HostingExamples.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs
  • Explicit Debt · WriteOnlyPrivateField test/Grains/TestGrains/StatelessWorkerStreamProducerGrain.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Streaming/Core/StreamSubscriptionManager.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestHarness.cs
  • Explicit Debt · WriteOnlyPrivateField src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestHarness.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.AWS.Tests/StorageTests/DynamoDBStorageProviderTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.AWS.Tests/Streaming/SQSClientStreamTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.Streaming.Kinesis.Tests/KinesisClientStreamTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Core.Tests/Directory/DhtGrainLocatorTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Core.Tests/General/UtilsTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Core.Tests/OrleansRuntime/Streams/ResourceSelectorTestRunner.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Core.Tests/Serialization/BuiltInSerializerTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Runtime.Internal.Tests/MembershipTests/ClientIdPartitionDataRebuildTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamingCacheMissTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/TestInfrastructure/TestExtensions/Runners/GoldenPathLeaseProviderTestRunner.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.Azure.Tests/Streaming/HaloStreamSubscribeTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.Redis.Tests/Persistence/RedisStorageTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.Redis.Tests/Persistence/RedisStorageTests_DeleteStateOnClear.cs
  • Explicit Debt · WriteOnlyPrivateField test/Extensions/Orleans.Streaming.EventHubs.Tests/SlowConsumingTests/EHSlowConsumingTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Grains/TestInternalGrains/StressTestGrain.cs
  • Explicit Debt · WriteOnlyPrivateField test/Grains/TestInternalGrains/StressTestGrain.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Serialization.UnitTests/SerializationSupportContractTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Serialization.UnitTests/SerializationSupportContractTests.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/MultipleStreamsTestRunner.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/MultipleStreamsTestRunner.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamTestHelperClasses.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamTestHelperClasses.cs
  • Explicit Debt · WriteOnlyPrivateField test/Orleans.Streaming.Tests/StreamingTests/StreamTestHelperClasses.cs
  • Static Analysis (SAST) · Medium: watchdog-controllerbase-missing-or-broken-authorization-csharp playground/ActivationRebalancing/ActivationRebalancing.Frontend/Controllers/StatsController.cs
  • Static Analysis (SAST) · Medium: REDACTED REDACTED
  • Static Analysis (SAST) · Medium: REDACTED REDACTED
  • Static Analysis (SAST) · Medium: REDACTED samples/Voting/Controllers/HomeController.cs
  • Static Analysis (SAST) · Medium: REDACTED samples/Voting/Controllers/VotesController.cs
  • Code Duplication · Duplicated block (21 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx
  • Large Files · src/Dashboard/Orleans.Dashboard.App/src/index.tsx: 556 lines of code src/Dashboard/Orleans.Dashboard.App/src/index.tsx
  • Cancellation propagation · Async method without CancellationToken: ExecuteNext src/Orleans.Core/Async/AsyncSerialExecutor.cs
  • Cancellation propagation · Async method without CancellationToken: Wrap src/Orleans.Core/Async/AsyncSerialExecutor.cs
  • Cancellation propagation · Async method without CancellationToken: SafeExecute src/Orleans.Core/Async/TaskExtensions.cs
  • Cancellation propagation · Async method without CancellationToken: ExecuteAndIgnoreException src/Orleans.Core/Async/TaskExtensions.cs
  • Cancellation propagation · Async method without CancellationToken: CancelTokenAsync src/Orleans.Core/Lifecycle/ServiceLifecycleNotificationStage.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessIncoming src/Orleans.Core/Networking/Connection.cs
  • Cancellation propagation · Async method without CancellationToken: CloseAsync src/Orleans.Core/Networking/ConnectionManager.cs
  • Cancellation propagation · Async method without CancellationToken: Write src/Orleans.Core/Networking/ConnectionPreamble.cs
  • Cancellation propagation · Async method without CancellationToken: Read src/Orleans.Core/Networking/ConnectionPreamble.cs
  • Cancellation propagation · Async method without CancellationToken: CreateAndStartAsync src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessConnectionAsync src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessReads src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessWrites src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs
  • Cancellation propagation · Async method without CancellationToken: UnbindCoreAsync src/Orleans.Core/Networking/Transport/Sockets/TcpMessageTransportListener.cs
  • Cancellation propagation · Async method without CancellationToken: RemoveEnumeratorAsync src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs
  • Cancellation propagation · Async method without CancellationToken: OnTerminateAsync src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs
  • Cancellation propagation · Async method without CancellationToken: CancelTokenWithRetries src/Orleans.Core/Runtime/GrainCancellationTokenRuntime.cs
  • Cancellation propagation · Async method without CancellationToken: InvokeMethodWithFiltersAsync src/Orleans.Core/Runtime/GrainReferenceRuntime.cs
  • Cancellation propagation · Async method without CancellationToken: InvokeMethodWithFiltersAsync src/Orleans.Core/Runtime/GrainReferenceRuntime.cs
  • Cancellation propagation · Async method without CancellationToken: StopAsync src/Orleans.Core/Runtime/InvokableObjectManager.cs
  • Cancellation propagation · Async method without CancellationToken: LocalObjectMessagePumpAsync src/Orleans.Core/Runtime/InvokableObjectManager.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessMessageAsync src/Orleans.Core/Runtime/InvokableObjectManager.cs
  • Cancellation propagation · Async method without CancellationToken: MonitorCallbackExpiry src/Orleans.Core/Runtime/OutsideRuntimeClient.cs
  • Cancellation propagation · Async method without CancellationToken: Notify src/Orleans.Core/Utils/ObserverManager.cs
  • Cancellation propagation · Async method without CancellationToken: ProcessOperationsAsync src/Orleans.DurableJobs/JournaledJobShard.cs
  • Cancellation propagation · Async method without CancellationToken: DisposeShardAsync src/Orleans.DurableJobs/LocalDurableJobManager.cs
  • Cancellation propagation · Async method without CancellationToken: SlowStartRampUpAsync src/Orleans.DurableJobs/ShardExecutor.cs
Rebuild cost: about €1,600,000 · Estimate
Cost to rebuild€520,000 to €2,700,000, for 8,671 to 27,947 hours of work, about 10.9 person-years for 6 to 21 engineers
Difficulty of the problemVery high, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 55. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeLarge: 301,355 lines of product code
Comment linesThe estimate prices 254,224 lines. Comment lines count towards the size of 301,355 lines but aren't priced as work.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Raises the score by about 7 points · Medium effort · Keyboard semantics
2
Resolve the 4 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.
Raises the score by about 2 points · Low effort · REDACTED Scanning
3
Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with @axe-core/playwright in tests, then gate axe/pa11y/Lighthouse in CI.
Raises the score by about 3 points · Medium effort · A11y enforcement

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €1,600,000 to build again, about 10.9 person-years of work. Its weakest lens is Accessibility, at 44 (Weak). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — bounded-context dependency graph

Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.

arch AppHost AppHost Cluster Cluster ctx:Orleans.Server Orleans.Server 1 project Cluster->ctx:Orleans.Server Frontend Frontend Frontend->ctx:Orleans.Server ActivationRepartitioning.AppHost ActivationRepartitioning.AppHost ActivationRepartitioning.Frontend ActivationRepartitioning.Frontend ctx:Runtime Runtime 1 project ActivationRepartitioning.Frontend->ctx:Runtime ActivationSheddingToy ActivationSheddingToy ActivationSheddingToy->ctx:Orleans.Server AdventureClient AdventureClient ctx:samples samples 15 projects AdventureClient->ctx:samples AdventureServer AdventureServer AdventureServer->ctx:samples AppHost (2) AppHost (2) AzureStorage AzureStorage BankClient BankClient BankClient->ctx:samples BankServer BankServer BankServer->ctx:samples BasicClustering.AppHost BasicClustering.AppHost Silo Silo BlazorServer BlazorServer Client Client Server Server BroadcastChannel.Client BroadcastChannel.Client ctx:site site 17 projects BroadcastChannel.Client->ctx:site BroadcastChannel.Silo BroadcastChannel.Silo BroadcastChannel.Silo->ctx:site ChaoticCluster.AppHost ChaoticCluster.AppHost ChaoticCluster.Silo ChaoticCluster.Silo ctx:Azure Azure 12 projects ChaoticCluster.Silo->ctx:Azure ChaoticCluster.Silo->ctx:Orleans.Server ctx:playground playground 3 projects ChaoticCluster.Silo->ctx:playground ChatRoom.Client ChatRoom.Client ChatRoom.Client->ctx:samples Service Service Service->ctx:samples Chirper.Client Chirper.Client Chirper.Client->ctx:samples Chirper.Server Chirper.Server Chirper.Server->ctx:samples Client (docs/site/src/content/docs/grains/snippets/transactions/Client) Client (docs/site/src/content/docs/grains/snippets/transactions/Client) ctx:Abstractions (docs/site/src/content/docs/grains/snippets/transactions/Abstractions) Abstractions (docs/site/src/content/docs/grains/snippets/transactions/Abstractions) 1 project Client (docs/site/src/content/docs/grains/snippets/transactions/Client)->ctx:Abstractions (docs/site/src/content/docs/grains/snippets/transactions/Abstractions) Client (docs/site/src/content/docs/host/snippets) Client (docs/site/src/content/docs/host/snippets) Client (docs/site/src/content/docs/host/snippets/aspire/Client) Client (docs/site/src/content/docs/host/snippets/aspire/Client) Client (docs/site/src/content/docs/host/snippets/aspire/Client)->ctx:site Client (docs/site/src/content/docs/quickstarts/snippets/hello-world/Client) Client (docs/site/src/content/docs/quickstarts/snippets/hello-world/Client) Client (samples/Streaming/Simple/Client) Client (samples/Streaming/Simple/Client) Client (samples/Streaming/Simple/Client)->ctx:samples ClientExample ClientExample MinimalApi MinimalApi ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) Abstractions (samples/Deployment/AzureContainerApps/Abstractions) 1 project MinimalApi->ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) MinimalApi->ctx:samples WorkerService WorkerService WorkerService->ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) ctx:Grains (samples/Deployment/AzureContainerApps/Grains) Grains (samples/Deployment/AzureContainerApps/Grains) 1 project WorkerService->ctx:Grains (samples/Deployment/AzureContainerApps/Grains) WorkerService->ctx:samples Cosmos Cosmos CustomGrainCallReturnType CustomGrainCallReturnType Dashboard Dashboard Dashboard->ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) Dashboard->ctx:Grains (samples/Deployment/AzureContainerApps/Grains) Dashboard->ctx:samples DashboardCohosted DashboardCohosted ctx:Dashboard Dashboard 2 projects DashboardCohosted->ctx:Dashboard ctx:Orleans.Client Orleans.Client 1 project DashboardCohosted->ctx:Orleans.Client ctx:Persistence.Memory Persistence.Memory 1 project DashboardCohosted->ctx:Persistence.Memory DashboardSeparateHost DashboardSeparateHost DashboardSeparateHost->ctx:Dashboard DashboardSeparateHost->ctx:Orleans.Client DashboardSeparateHost->ctx:Persistence.Memory DurableJobsJournaling.AppHost DurableJobsJournaling.AppHost DurableJobsJournaling.Silo DurableJobsJournaling.Silo DurableJobsJournaling.Silo->ctx:Azure DurableJobsJournaling.Silo->ctx:Dashboard ctx:Sdk Sdk 1 project DurableJobsJournaling.Silo->ctx:Sdk DurableJobsJournaling.Silo->ctx:Orleans.Server DurableJobsJournaling.Silo->ctx:playground Web Web Web->ctx:Azure Web->ctx:Orleans.Client Web->ctx:Sdk Web->ctx:playground DurableJobsMigration DurableJobsMigration DurableJobsMigration.AppHost DurableJobsMigration.AppHost Firestore (docs/site/src/content/docs/host/snippets/google-firestore) Firestore (docs/site/src/content/docs/host/snippets/google-firestore) Firestore (samples/GoogleFirestore) Firestore (samples/GoogleFirestore) FakeDeviceGateway FakeDeviceGateway FakeDeviceGateway->ctx:samples GPSTracker.Service GPSTracker.Service GPSTracker.Service->ctx:samples GrainStorage GrainStorage HelloWorld (docs/site/src/content/docs/tutorials-and-samples/snippets/hello-world) HelloWorld (docs/site/src/content/docs/tutorials-and-samples/snippets/hello-world) HelloWorld (samples/FSharpHelloWorld/HelloWorld) HelloWorld (samples/FSharpHelloWorld/HelloWorld) HelloWorld (samples/FSharpHelloWorld/HelloWorld)->ctx:samples HelloWorld (samples/HelloWorld) HelloWorld (samples/HelloWorld) HelloWorld (samples/VBHelloWorld/HelloWorld) HelloWorld (samples/VBHelloWorld/HelloWorld) HelloWorld (samples/VBHelloWorld/HelloWorld)->ctx:samples JournaledTodoList.AppHost JournaledTodoList.AppHost WebApp WebApp WebApp->ctx:samples JournalingAzureBlobJson JournalingAzureBlobJson JournalingAzureBlobJson.AppHost JournalingAzureBlobJson.AppHost KinesisDynamoDB KinesisDynamoDB LoadGenerator LoadGenerator NonOrleansClient NonOrleansClient NonOrleansClient->ctx:samples Observability Observability ShoppingCart.Silo (samples/Deployment/AzureAppService/Silo) ShoppingCart.Silo (samples/Deployment/AzureAppService/Silo) ShoppingCart.Silo (samples/ShoppingCart/Silo) ShoppingCart.Silo (samples/ShoppingCart/Silo) OrleansApp.AppHost OrleansApp.AppHost OrleansApp.Client OrleansApp.Client OrleansApp.Silo OrleansApp.Silo OrleansWebApp OrleansWebApp PackageJsonGenerator PackageJsonGenerator PlayerWatcher PlayerWatcher PresenceService PresenceService RedisJournaling RedisJournaling Scaler Scaler Scaler->ctx:samples SecureDashboard SecureDashboard Server (2) Server (2) Server (2)->ctx:Abstractions (docs/site/src/content/docs/grains/snippets/transactions/Abstractions) ServiceFabricSilo ServiceFabricSilo Silo (docs/site/src/content/docs/host/snippets/aspire/Silo) Silo (docs/site/src/content/docs/host/snippets/aspire/Silo) Silo (docs/site/src/content/docs/host/snippets/aspire/Silo)->ctx:site Silo (docs/site/src/content/docs/quickstarts/snippets/hello-world/Silo) Silo (docs/site/src/content/docs/quickstarts/snippets/hello-world/Silo) Silo (samples/Deployment/AzureContainerApps/Silo) Silo (samples/Deployment/AzureContainerApps/Silo) Silo (samples/Deployment/AzureContainerApps/Silo)->ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) Silo (samples/Deployment/AzureContainerApps/Silo)->ctx:Grains (samples/Deployment/AzureContainerApps/Grains) Silo (samples/Deployment/AzureContainerApps/Silo)->ctx:samples Silo (samples/Streaming/CustomDataAdapter/Silo) Silo (samples/Streaming/CustomDataAdapter/Silo) Silo (samples/Streaming/CustomDataAdapter/Silo)->ctx:samples SiloExample SiloExample SiloHost SiloHost SiloHost->ctx:samples Stocks Stocks TLS.Client TLS.Client TLS.Client->ctx:samples TLS.Server TLS.Server TLS.Server->ctx:samples TicTacToe TicTacToe Voting Voting orleansurlshortener orleansurlshortener serialization serialization ctx:Dashboard->ctx:Runtime ctx:Dashboard->ctx:Sdk ctx:Grains (samples/Deployment/AzureContainerApps/Grains)->ctx:Abstractions (samples/Deployment/AzureContainerApps/Abstractions) ctx:Orleans.Client->ctx:Sdk ctx:Persistence.Memory->ctx:Runtime ctx:Serialization Serialization 1 project ctx:Orleans.Server->ctx:Persistence.Memory ctx:Orleans.Server->ctx:Runtime ctx:Orleans.Server->ctx:Sdk ctx:playground->ctx:Sdk ctx:samples->ctx:Grains (samples/Deployment/AzureContainerApps/Grains) __more__ +42 more contexts

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

361 modules, with 626 dependencies between them. 8 loops run through 86 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 321 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 Orleans.BroadcastChannel2 Orleans.Dashboard.Model3 Orleans.EventSourcing4 Orleans.Serialization.WireProtocol5 Orleans.Internal6 Orleans.Metadata7 Orleans.Providers.Streams.Common8 Orleans.Runtime.ConsistentRing9 Orleans.Runtime.MembershipService10 Orleans.Serialization.Serializers11 Orleans.Runtime.GrainDirectory12 Orleans.Runtime.Versions13 Orleans.Serialization.Codecs14 Orleans.Streaming.EventHubs15 Orleans.Runtime.Placement16 Orleans.Serialization.Invocation17 Orleans.Streams18 Orleans.Serialization.Cloning19 Orleans.Serialization.Configuration20 Orleans.Serialization.Session21 Orleans.Serialization.Buffers22 Orleans.Serialization23 Orleans.Storage24 Orleans.Runtime25 Orleans.Dashboard.Implementation26 Orleans.Journaling27 Orleans.Messaging28 Orleans.Transactions29 Orleans.Runtime.Messaging30 Orleans.Configuration31 Orleans.DurableJobs32 Orleans.Providers33 Orleans.Hosting34 Orleans35 Orleans.Dashboard36 Orleans.Runtime.MembershipService.SiloMetadata37 Orleans.Runtime.Placement.Repartitioning38 Orleans.Runtime.ReminderService39 GrainPlacement40 Orleans.Dashboard.Implementation.Grains
1 Orleans.BroadcastChannel
2 Orleans.Dashboard.Model
3 Orleans.EventSourcing
4 Orleans.Serialization.WireProtocol
5 Orleans.Internal1
6 Orleans.Metadata261
7 Orleans.Providers.Streams.Common41833
8 Orleans.Runtime.ConsistentRing14
9 Orleans.Runtime.MembershipService7821021
10 Orleans.Serialization.Serializers614103161
11 Orleans.Runtime.GrainDirectory2163811
12 Orleans.Runtime.Versions5121
13 Orleans.Serialization.Codecs77331503147
14 Orleans.Streaming.EventHubs23561012
15 Orleans.Runtime.Placement1112273
16 Orleans.Serialization.Invocation22124
17 Orleans.Streams22215610
18 Orleans.Serialization.Cloning31
19 Orleans.Serialization.Configuration111
20 Orleans.Serialization.Session311
21 Orleans.Serialization.Buffers13
22 Orleans.Serialization1632194737461
23 Orleans.Storage2773
24 Orleans.Runtime112732532421418221362663
25 Orleans.Dashboard.Implementation441
26 Orleans.Journaling81317161
27 Orleans.Messaging10442
28 Orleans.Transactions12
29 Orleans.Runtime.Messaging211796164
30 Orleans.Configuration22213
31 Orleans.DurableJobs19282152
32 Orleans.Providers20307434
33 Orleans.Hosting2111242531123
34 Orleans116231431631
35 Orleans.Dashboard121
36 Orleans.Runtime.MembershipService.SiloMetadata15111
37 Orleans.Runtime.Placement.Repartitioning11911
38 Orleans.Runtime.ReminderService11251226
39 GrainPlacement1482121
40 Orleans.Dashboard.Implementation.Grains8221
Uses a module listed above itPart of a loopThe module itself
1 Orleans.BroadcastChannel2 Orleans.Dashboard.Model3 Orleans.EventSourcing4 Orleans.Serialization.WireProtocol5 Orleans.Internal6 Orleans.Metadata7 Orleans.Providers.Streams.Common8 Orleans.Runtime.ConsistentRing9 Orleans.Runtime.MembershipService10 Orleans.Serialization.Serializers11 Orleans.Runtime.GrainDirectory12 Orleans.Runtime.Versions13 Orleans.Serialization.Codecs14 Orleans.Streaming.EventHubs15 Orleans.Runtime.Placement16 Orleans.Serialization.Invocation17 Orleans.Streams18 Orleans.Serialization.Cloning19 Orleans.Serialization.Configuration20 Orleans.Serialization.Session21 Orleans.Serialization.Buffers22 Orleans.Serialization23 Orleans.Storage24 Orleans.Runtime25 Orleans.Dashboard.Implementation26 Orleans.Journaling27 Orleans.Messaging28 Orleans.Transactions29 Orleans.Runtime.Messaging30 Orleans.Configuration31 Orleans.DurableJobs32 Orleans.Providers33 Orleans.Hosting34 Orleans35 Orleans.Dashboard36 Orleans.Runtime.MembershipService.SiloMetadata37 Orleans.Runtime.Placement.Repartitioning38 Orleans.Runtime.ReminderService39 GrainPlacement40 Orleans.Dashboard.Implementation.GrainsOrleans.BroadcastChannel1Orleans.Dashboard.Model2Orleans.EventSourcing3Orleans.Serialization.WireProtocol4Orleans.Internal5Orleans.Metadata6Orleans.Providers.Streams.Common7Orleans.Runtime.ConsistentRing8Orleans.Runtime.MembershipService9Orleans.Serialization.Serializers10Orleans.Runtime.GrainDirectory11Orleans.Runtime.Versions12Orleans.Serialization.Codecs13Orleans.Streaming.EventHubs14Orleans.Runtime.Placement15Orleans.Serialization.Invocation16Orleans.Streams17Orleans.Serialization.Cloning18Orleans.Serialization.Configuration19Orleans.Serialization.Session20Orleans.Serialization.Buffers21Orleans.Serialization22Orleans.Storage23Orleans.Runtime24Orleans.Dashboard.Implementation25Orleans.Journaling26Orleans.Messaging27Orleans.Transactions28Orleans.Runtime.Messaging29Orleans.Configuration30Orleans.DurableJobs31Orleans.Providers32Orleans.Hosting33Orleans34Orleans.Dashboard35Orleans.Runtime.MembershipService.SiloMetadata36Orleans.Runtime.Placement.Repartitioning37Orleans.Runtime.ReminderService38GrainPlacement39Orleans.Dashboard.Implementation.Grains4012614183314782102161410316121638115121773315031472356101211122732212422215610311113111316321947374612773112732532421418221362663441813171611044212211796164222131928215220307434211124253112311623143163112115111119111125122614821218221+321 more modules (most-connected shown)

At a glance — Code Health · 67% · Adequate ·

At a glance — Architecture · 71% · Strong ·

At a glance — Maturity · 71% · Strong ·

At a glance — Readiness · 58% · Adequate · gated by D13, P7 ·

At a glance — Security · 62% · Adequate · gated by D29, D36, C1 ·

At a glance — Event-Driven · 100% · Exemplary ·

At a glance — Accessibility · 44% · Weak · gated by AC4 ·

At a glance — Performance · 78% · Strong ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection22High / Critical
A03:2025 — Software Supply Chain Failures12High / Critical
A07:2025 — Authentication Failures11High / Critical

Roadmap

First, fix keyboard navigation by making custom controls operable and ensuring anchors have valid hrefs, while simultaneously adding programmatic labels to all form controls and buttons. Next, establish robust accessibility enforcement by integrating linting, automated testing, and CI gates to catch issues early. Concurrently, resolve the four leaked secrets in configuration and key files to secure the codebase. Finally, improve page structure by declaring language, titles, and landmarks, and ensuring proper heading hierarchy and iframe accessibility.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.+6.9 ptsMediumKeyboard semantics
Resolve the 4 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED.+2.3 ptsLowREDACTED Scanning
Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with @axe-core/playwright in tests, then gate axe/pa11y/Lighthouse in CI.+3.4 ptsMediumA11y enforcement
Resolve the 7 No assertions (empty test) finding(s) in Test Quality — start with MySqlRemindersTableTests.cs, PostgreSqlRemindersTableTests.cs, SqlServerRemindersTableTests.cs.+1.6 ptsLowTest Quality
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.+2.2 ptsMediumForms & labels
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.+2.2 ptsMediumPage structure
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.+1.7 ptsMediumOutbound HTTP resilience
Resolve the 4 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED.+0.7 ptsLowSecrets (history)

File quality

Per-file score 0–10 — a quality signature. Of 626 files carrying findings, judged against the Production bar: 1% slop · 56% mixed · 43% near-clean.

FileScoreBandWorst signal
src/Orleans.Runtime/Catalog/ActivationData.cs2.4SlopExplicit Debt: EmptyCatchBlock
src/Orleans.TestingHost/InMemoryTransport/InMemoryMessageTransport.cs3.2SlopExplicit Debt: WriteOnlyPrivateField
src/Orleans.TestingHost/TestClusterPortAllocator.cs3.3SlopExplicit Debt: EmptyCatchBlock
test/Benchmarks/TopK/TopKBenchmark.cs3.3SlopExplicit Debt: WriteOnlyPrivateField
src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs3.5SlopExplicit Debt: EmptyCatchBlock
src/Orleans.Core.Abstractions/Utils/Utils.cs3.6SlopExplicit Debt: EmptyCatchBlock
test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs3.6SlopExplicit Debt: WriteOnlyPrivateField
REDACTED3.7SlopDependency Vulnerabilities: Critical vulnerability: REDACTED
samples/TicTacToe/Grains/GameGrain.cs4.2MixedExplicit Debt: WriteOnlyPrivateField
src/Orleans.Core/Networking/ConnectionManager.cs4.2MixedExplicit Debt: EmptyCatchBlock
src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs4.2MixedExplicit Debt: EmptyCatchBlock
src/Orleans.TestingHost/StandaloneSiloHandle.cs4.3MixedExplicit Debt: EmptyCatchBlock
REDACTED4.4MixedREDACTED Scanning: Leaked secret: REDACTED
REDACTED4.4MixedREDACTED Scanning: Leaked secret: REDACTED
src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs4.6MixedExplicit Debt: EmptyCatchBlock
samples/Voting/Data/PollService.PollWatcherSubscription.cs4.6MixedExplicit Debt: EmptyCatchBlock
test/Grains/TestInternalGrains/ReminderTestGrain2.cs4.6MixedExplicit Debt: WriteOnlyPrivateField
src/Orleans.Serialization/Buffers/Reader.cs4.7MixedExplicit Debt: WriteOnlyPrivateField
src/Orleans.Serialization/Buffers/ArcBufferWriter.cs4.8MixedExplicit Debt: WriteOnlyPrivateField
src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs4.9MixedExplicit Debt: EmptyCatchBlock

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 240

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 1715

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 537

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 5

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 96 of 102 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 6 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 102 dimensions across the health lenses
D1D2D3D4D5D6D9D10D13D14D15D16D17D18D19D20D21D22D24D26D27D28D29D30D31D34D35D36D43D44AC1AC2AC3AC4AC5AC6AC7AX1AX10AX2AX3AX5AX6AX8C1C2C3C4ED1ED4ED5GD1IC1M1M2M3M4P1P10P2P3P4P5P6P7PF1PF2PF3R1R10R2R3R6R7R8R9S1X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X32X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 2461 of 2492 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a168c0-e008-741a-b50d-92e8c4f40374.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 8,606 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 20 test source file(s) (.ts, .fs, .mjs) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: this repository's test suite spans .NET and JavaScript/TypeScript, and the JavaScript/TypeScript half could not be re-run — unit: not included — too large to re-run within its budget; integration: measured (0 flaky); other: not included — too large to re-run within its budget; JavaScript/TypeScript (vitest via `npm ci --ignore-scripts` in docs/site/): not included — the dependency install for docs/site/ could not reach packagefeedproxy.microsoft.io, which the analyzer sandbox's egress allowlist does not carry (npm error 403 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/zwitch/-/zwitch-2.0.4.tgz), so the suite never ran. No partial figure is published as if it were the whole: reliability is excluded from the score rather than counted as a near-zero.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability for the vitest suite in docs/site/ was NOT MEASURED: the dependency install for docs/site/ could not reach packagefeedproxy.microsoft.io, which the analyzer sandbox's egress allowlist does not carry (npm error 403 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/zwitch/-/zwitch-2.0.4.tgz), so the suite never ran. This is OUR limitation, not a defect in the repository, and the suite is excluded from the measurement rather than counted against it.
  • D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Dependency Hygiene couldn't be assessed within its 5-minute budget on a solution this large — not included in this run.
  • D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: solution references project 'src\Orleans.Clustering.TestKit\Orleans.Clustering.TestKit.csproj' but the on-disk path is 'src/Orleans.Clustering.TestKit/Orleans.Clustering.TestKit.csproj' (separator/casing mismatch); on a case-sensitive file system MSBuildWorkspace would load 0 of these projects. Loading a corrected copy of the solution.
  • D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
  • D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (289,415 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D30 Dependency Vulnerabilities — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Packagefeedproxy.microsoft.io could not be reached (NU1301: Unable to load the service index for source https://packagefeedproxy.microsoft.io/nuget/v3/index.json. The proxy tunnel request to proxy 'http://egress:3128/' failed with status code '403'.). 2 of 3 declared ecosystem(s) (npm,osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
  • D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `docs/site/scripts/audit-links.mjs`, `docs/site/scripts/audit-output.mjs`, `docs/site/scripts/generate-legacy-redirects.mjs`, `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, … (+355 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • D39 IL Efficiency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. `dotnet build` exited 1 with a compiler/MSBuild diagnostic, so there were no assemblies to read IL from. The build itself is D18's row, with the ask; nothing further is charged here.
  • AX2 Stateful singletons — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 39 further occurrence(s) are not listed individually; the score already reflects all 79.
  • AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via AspireAppHost (playground/ActivationRebalancing/ActivationRebalancing.AppHost/ActivationRebalancing.AppHost.csproj). the Aspire AppHost did not expose a crawlable HTTP endpoint in time (or only the dashboard) — no runtime evidence.
  • IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 66 further occurrence(s) are not listed individually; the score already reflects all 106.
  • M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 4 further occurrence(s) are not listed individually; the score already reflects all 44.
  • PF3 Async & latency hygiene — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 3 further occurrence(s) are not listed individually; the score already reflects all 43.
  • R5 Dependency Freshness — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `npm outdated` failed and answered nothing (E403: 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/@astrojs%2fmarkdown-remark); nothing here is a statement about the repository.
  • X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 929 further occurrence(s) are not listed individually; the score already reflects all 969.
  • X3 Exception handling — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 38 further occurrence(s) are not listed individually; the score already reflects all 78.
  • Package restore incomplete — third-party types were unresolved in part of the solution — NuGet restore did not complete for playground/ActivationSheddingToy/ActivationSheddingToy.csproj, playground/ActivationRebalancing/ActivationRebalancing.AppHost/ActivationRebalancing.AppHost.csproj, playground/ActivationRebalancing/ActivationRebalancing.Cluster/ActivationRebalancing.Cluster.csproj, playground/ActivationRebalancing/ActivationRebalancing.Frontend/ActivationRebalancing.Frontend.csproj, playground/ActivationRepartitioning/ActivationRepartitioning.AppHost/ActivationRepartitioning.AppHost.csproj and 218 more, so those projects were analysed with framework references only: every check keyed on a third-party type saw an error type there and reported nothing. Findings on those projects are a lower bound; run `dotnet restore` on them and rescan.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
  • D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • C3 Audit Trail: This control is scored from in-repo evidence only — a working control configured outside the repository leaves no signal a static scan can credit.
  • C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
  • ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (6): D19, D21, D22, D24, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity6.6 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.6 / 10 · rule-coverage 100% · ceiling Prevented

143 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was JournaledStateManager.WorkLoop at 59. A further 8 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Identifier.IsCSharpKeyword at 103 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs (Identifier.IsCSharpKeyword at 103), src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs (TransactionRecoveryEventObserver.TryCreateTransition at 67), src/Orleans.Reminders.TestKit/ReminderServiceTestRunner.cs (ReminderServiceTestRunner.RunReminderService_UpdateReplacesScheduleAndETagWithoutDuplicate at 38), src/Orleans.Reminders.TestKit/ReminderTableModelBasedTestRunner.cs (ReminderTableBehavioralSpec.CanApply at 19), src/Orleans.Core/Caching/Internal/TypeProps.cs (TypeProps.IsWriteAtomicPrivate at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) · ×2src/Orleans.Serialization/Cloning/IDeepCopier.cs:332
JournaledStateManager.WorkLoop (cyclomatic 59)src/Orleans.Journaling/JournaledStateManager.cs:187
ActivationData.RunMessageLoop (cyclomatic 57)src/Orleans.Runtime/Catalog/ActivationData.cs:1119
ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cyclomatic 50)src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22
ProxyGenerator.CreateProxyMethods (cyclomatic 49)src/Orleans.CodeGenerator/ProxyGenerator.cs:85

+ 137 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 19 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with JournaledStateManager.WorkLoop (cyclomatic 59), ActivationData.RunMessageLoop (cyclomatic 57), ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cyclomatic 50). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 19 together lifts Cyclomatic Complexity from 6.6 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.3 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.3 / 10 · rule-coverage 100% · ceiling Prevented

311 method(s) exceeded the cognitive complexity threshold of 15; the worst was JournaledStateManager.WorkLoop at 195.

CodecProvider.TryGetSurrogateCodec (cognitive 25) · ×2src/Orleans.Serialization/Serializers/CodecProvider.cs:1106
OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) · ×2src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:308
ProxyInterfaceDescription.ValidateBaseClass::ValidateGenericInvokeAsync (cognitive 22) · ×2src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:121
JournaledStateManager.WorkLoop (cognitive 195)src/Orleans.Journaling/JournaledStateManager.cs:187
SocketMessageTransport.ProcessWrites (cognitive 101)src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:532

+ 303 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 120 down to 120 or less in Cognitive Complexity — start with JournaledStateManager.WorkLoop (cognitive 195). — Refactoring it lifts Cognitive Complexity from 5.3 to about 5.8/10.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.5 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

136 god class(es) detected.

TooManyMethods: ActivationData · ×65src/Orleans.Runtime/Catalog/ActivationData.cs
FileTooLong: Catalog/ActivationData.cs · ×37src/Orleans.Runtime/Catalog/ActivationData.cs
MethodTooLong: JournaledStateManager.WorkLoop · ×27src/Orleans.Journaling/JournaledStateManager.cs:187
ClassTooLong: SerializerGenerator · ×6src/Orleans.CodeGenerator/SerializerGenerator.cs
FunctionTooLong: link-audit.auditSourceLinksdocs/site/scripts/lib/link-audit.mjs:418

What to do

  1. Resolve the 65 TooManyMethods finding(s) in God Classes — start with Serializer.cs (2), ActivationData.cs, LocalReminderService.cs. — One of this dimension's main actionable groups (65 warning-level).
  2. Resolve the 37 FileTooLong finding(s) in God Classes — start with ActivationData.cs, docfx.mjs, GrainInterfaceVersionCodeFix.cs. — One of this dimension's main actionable groups (37 warning-level).
  3. Resolve the 27 MethodTooLong finding(s) in God Classes — start with ActivationData.cs (3), TransactionRecoveryTestsRunner.cs (2), SerializerFactoryGenerator.cs (2). — One of this dimension's main actionable groups (27 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.3 / 10Stronggated by 412 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Verified

379 duplicated block group(s) detected. A further 33 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 50 of the 412 are in trees this repository does not ship — vendored, example/demo, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Duplicated block (8 lines × 2) · ×28src/Orleans.CodeGenerator/CopierGenerator.cs:255
Duplicated block (5 lines × 2) · ×23src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:180
Duplicated block (10 lines × 2) · ×21src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:68
Duplicated block (7 lines × 2) · ×21src/Orleans.Serialization/Codecs/ArrayCodec.cs:316
Duplicated block (9 lines × 2) · ×17src/Orleans.CodeGenerator/CopierGenerator.cs:306

+ 125 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 28 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with TupleCodec.cs (6), DefaultClientServices.cs (2), CopierGenerator.cs. — One of this dimension's main actionable groups (28 warning-level).
  2. Resolve the 23 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with ChannelId.cs (2), SiloInstanceRecord.cs (2), FileGrainStorage.cs (2). — One of this dimension's main actionable groups (23 warning-level).
  3. Resolve the 21 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with AzureBlobJournalStorage.cs (2), FileGrainStorage.cs (2), SerializableSourceOutputGenerator.cs. — One of this dimension's main actionable groups (21 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling9.9 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

418 projects, 0 dependency cycle(s), 1 unstable depended-on project(s).

Off the main sequence: Orleans.Persistence.Memory(net8.0) · ×3src/Orleans.Persistence.Memory/Orleans.Persistence.Memory.csproj:1
Unstable project SerializerContextsdocs/site/src/content/docs/host/configuration-guide/snippets/serializer-contexts/SerializerContexts.csproj:1
Off the main sequence: Orleans.Dashboard.Abstractions(net8.0) · ×3src/Dashboard/Orleans.Dashboard.Abstractions/Orleans.Dashboard.Abstractions.csproj:1

What to do

  1. Resolve the 3 Off the main sequence finding(s) in Coupling — start with Orleans.Persistence.Memory.csproj, Orleans.Runtime.csproj, Orleans.Serialization.csproj. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 Unstable project SerializerContexts finding(s) in Coupling — start with SerializerContexts.csproj. — One of this dimension's main actionable groups (1 warning-level).
  3. Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.9 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

6 of 832 classes have LCOM4 above 3.

Low cohesion: MessagingProcessingInstruments (LCOM4 6) · ×6src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:6

What to do

  1. Resolve the 6 Low cohesion finding(s) in Cohesion (LCOM4) — start with MessagingProcessingInstruments.cs, SiloControl.cs, SiloGrainService.cs. — One of this dimension's main actionable groups (6 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

17488 test methods: 15738 unit, 1750 integration, 0 BDD, 0 e2e. The JavaScript/TypeScript suite contributes 207 `it`/`test` case(s) across 15 test file(s) declaring at least one beside 17281 .NET test method(s); its tier split is read from package names and paths only.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality9.8 / 10Adequategated by 7 critical findings✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

46 skipped (20 with a documented reason), 53 zero-assertion, 8 synchronised by a fixed sleep, 15 racing the wall clock, 7 mock references across 8606 tests. Measured on the C# suite only — at least 20 test source file(s) (.ts, .fs, .mjs) went unread, so its test quality is unmeasured and is not in these counts.

No assertions (empty test): RemindersTable_MySql_Init · ×7test/Extensions/Orleans.AdoNet.Tests/Reminders/MySqlRemindersTableTests.cs:59
No assertions: MembershipTable_ModelBased_GeneratedConformance · ×46test/Orleans.Core.Tests/Membership/SystemTargetMembershipTableConformanceTests.cs:36
Skipped test: AccountWithLog · ×26test/Orleans.EventSourcing.Tests/EventSourcingTests/AccountGrainTests.cs:61
Races the wall clock: MembershipAgent_LifecycleStages_ValidateInitialConnectivity_WaitsForStaleSilosToBeEvicted · ×15test/Orleans.Core.Tests/Membership/MembershipAgentTests.cs:462
Fixed-sleep synchronisation: RequestContext_MultiThreads_ExportToMessage · ×8test/Orleans.Core.Tests/General/RequestContextTestsNonSiloRequired.cs:43

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 7 No assertions (empty test) finding(s) in Test Quality — start with MySqlRemindersTableTests.cs, PostgreSqlRemindersTableTests.cs, SqlServerRemindersTableTests.cs. — One of this dimension's main actionable groups (7 issue-level).
  2. Resolve the 46 No assertions finding(s) in Test Quality — start with ReminderServiceLifecycleTestsBase.cs (8), MemoryGrainStorageTests.cs (3), StreamSubscriptionHandleImplTests.cs (3). — One of this dimension's main actionable groups (46 warning-level).
  3. Resolve the 26 Skipped test finding(s) in Test Quality — start with ElasticPlacementTest.cs (4), ReentrancyTests.cs (3), ProgrammaticSubscribeTestsRunner.cs (2). — One of this dimension's main actionable groups (26 warning-level).
  4. Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Prevented

3 secret(s) detected.

REDACTED

What to do

  1. Resolve the 4 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
  2. Enforce REDACTED Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 341 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 174 direct `PackageReference`(s), and 153 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Stronggated by 76 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/Orleans.Runtime/Catalog/ActivationData.cs (17×57=969); src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs (18×40=720); src/Orleans.Journaling/JournaledStateManager.cs (7×59=413) Repeated repair below the complexity floor: src/Orleans.Reminders/ReminderService/LocalReminderService.cs (12 of 17 changes were fixes); src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs (8 of 11 changes were fixes); src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs (7 of 13 changes were fixes)

Hotspot: src/Orleans.Runtime/Catalog/ActivationData.cs · ×47src/Orleans.Runtime/Catalog/ActivationData.cs:1119
Repeated repair: src/Orleans.Reminders/ReminderService/LocalReminderService.cs · ×29src/Orleans.Reminders/ReminderService/LocalReminderService.cs:1406

What to do

  1. Resolve the 47 Hotspot finding(s) in Churn × Complexity Hotspots — start with ActivationData.cs, PersistentStreamPullingAgent.cs, JournaledStateManager.cs. — One of this dimension's main actionable groups (47 warning-level).
  2. Resolve the 29 Repeated repair finding(s) in Churn × Complexity Hotspots — start with LocalReminderService.cs, DistributedGrainDirectory.cs, GrainDirectoryPartition.cs. — One of this dimension's main actionable groups (29 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor7.3 / 10Strong✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Documented

302 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/Orleans.Reminders/ReminderService/LocalReminderService.cs. Counted over 1131 of the 2017 production source files in this repository: 881 are under the ~2,400-byte size floor this dimension measures over, and the remaining 5 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2

What to do

  1. Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt7.9 / 10Adequategated by 179 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 7.9 / 10 · rule-coverage 100% · ceiling Prevented

545 deducted debt markers + unmeasured dead symbols across 289415 LoC in the .NET projects (1.0/KLoC) → score 7.9. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.

WriteOnlyPrivateField · ×98docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/GrainExamples.cs:18
EmptyCatchBlock · ×66samples/Chirper/Chirper.Grains/ChirperAccount.cs:231
NoWarnInCsproj — 10 warning codes suppressed in one element · ×11src/Orleans.Serialization/Orleans.Serialization.csproj:18
FileScopedPragmaDisable · ×3docs/site/src/content/docs/snippets/compiled/Grains/JournalingSnippets.cs:8
NoWarnInCsproj repeated across 13 filestest/Orleans.Journaling.Tests/Orleans.Journaling.Tests.csproj:11

+ 13 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 98 WriteOnlyPrivateField finding(s) in Explicit Debt — start with DefaultCacheMonitor.cs (11), DirectoryInstruments.cs (6), DefaultBlockPoolMonitor.cs (5). — One of this dimension's main actionable groups (98 issue-level).
  2. Resolve the 66 EmptyCatchBlock finding(s) in Explicit Debt — start with ActivationData.cs (5), TestClusterPortAllocator.cs (4), DashboardHost.cs (3). — One of this dimension's main actionable groups (66 issue-level).
  3. Resolve the 11 NoWarnInCsproj finding(s) in Explicit Debt — start with Orleans.Serialization.csproj, Microsoft.Orleans.Templates.csproj, Orleans.Sdk.csproj. — One of this dimension's main actionable groups (11 issue-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape7.0 / 10Strong✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.0 / 10 · rule-coverage 100% · ceiling Documented

418 projects, 8217 source files, 629811 hand-written lines of code (289415 production / 340396 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 691 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 721 inter-project edges (build status unknown — did not finish). Measured across 4 solutions loaded as one workspace: `Orleans.slnx`, `samples/Samples.slnx`, `docs/Docs.slnx`, `templates/Microsoft.Orleans.Templates/templates/orleans/OrleansApp.slnx`.

Thin analysable surface across projects: SharedContracts · ×4docs/site/src/content/docs/host/snippets/aspire/SharedContracts/SharedContracts.csproj
Shell project: Interfaces · ×2samples/VBHelloWorld/Interfaces/Interfaces.vbproj

What to do

  1. Resolve the 4 Thin analysable surface across projects finding(s) in Solution Shape — start with SharedContracts.csproj, Client.csproj, versioning.csproj. — One of this dimension's main actionable groups (4 recommendation-level).
  2. Resolve the 2 Shell project finding(s) in Solution Shape — start with Interfaces.vbproj, VBGrains.vbproj. — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation QualityStrong◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Strong / 10 · rule-coverage 100% · ceiling Documented

The repository's root README and the docs/site/README are both excellent cross-platform Orleans documentation for developers. The root README is a clear overview of what Orleans is (a distributed framework), its origins (Microsoft Research, Virtual Actor Model), and why it matters ('Distributed .NET'), plus an overview of grains, features like persistence, timers/reminders, flexible grain placement, and the samples directory. It also gives installation/build steps for the core Orleans assemblies and links to the repository's NuGet profile, Twitter, Discord, and a sample cohosted dashboard walkthrough. The docs/site/README is a focused documentation site that explains API generation, build commands (npm install npm run api:generate npm run dev), and how it indexes static content with Pagefind, plus validation steps for the site itself. The repository's READMEs and architecture/Docs markdown files are well documented for the deployment tier: each directory has a README that states what it is for and how to use its contents (e.g. 'select Table journaling on the emulator', 'run `dotnet run --project ...`'), with clear installation, usage, and contribution guidance all present in the root repository README. The XML-doc coverage reflects an internal analyzer's scope rather than a human-authored documentation set; the visible content is complete and well-structured for its audience. This is a comprehensive repository documentation set: READMEs for each Orleans project (including Chirper, CustomGrainCallReturnType, DurableJobsMigration, F# sample app, GPS tracker, and Google Firestore) are complete within the body of the document. The XML-doc coverage figures reflect no missing docs in this set; all visible documents are present and cover the scope they claim. There is a thin gap between the summary and the actual documentation (the Chirper README ends with '## Sample prerequisites' before clipping), but it does not expose any real gaps. The repository's READMEs and architecture/Docs markdown files are well documented for their respective tiers (e.g. Orleans Hello World samples, durable journaling with Azure Blob JSON), covering what each directory does, installation/build steps, usage examples, and contribution guidance. The XML-doc coverage is low across most Orleans assemblies (0-16%), reflecting the project's focus on code rather than documentation. The repository's READMEs and architecture/Docs markdown files are well documented for their respective tiers. The root README gives an overview of what the project is and where to find installation/contribution guidance, while each sample README (e.g., Orleans Streaming samples, Orleans TicTacToe web-based game) documents its own directory and shows how to build/run it with a clear prerequisites section plus steps.

XML-doc coverage: ActivationSheddingToy · ×164playground/ActivationSheddingToy/ActivationSheddingToy.csproj

What to do

  1. Improve Documentation Quality — currently 8.4/10. — The repository's root README and the docs/site/README are both excellent cross-platform Orleans documentation for developers. The root README is a clear overview of what Orleans is (a distributed framework), its origins (Microsoft Research, Virtual Actor Model), and why it matters ('Distributed .NET'), plus an overview of grains, features like persistence, timers/reminders, flexible grain placement, and the samples directory. It also gives installation/build steps for the core Orleans assemblies and links to the repository's NuGet profile, Twitter, Discord, and a sample cohosted dashboard walkthrough. The docs/site/README is a focused documentation site that explains API generation, build commands (npm install npm run api:generate npm run dev), and how it indexes static content with Pagefind, plus validation steps for the site itself. The repository's READMEs and architecture/Docs markdown files are well documented for the deployment tier: each directory has a README that states what it is for and how to use its contents (e.g. 'select Table journaling on the emulator', 'run `dotnet run --project ...`'), with clear installation, usage, and contribution guidance all present in the root repository README. The XML-doc coverage reflects an internal analyzer's scope rather than a human-authored documentation set; the visible content is complete and well-structured for its audience. This is a comprehensive repository documentation set: READMEs for each Orleans project (including Chirper, CustomGrainCallReturnType, DurableJobsMigration, F# sample app, GPS tracker, and Google Firestore) are complete within the body of the document. The XML-doc coverage figures reflect no missing docs in this set; all visible documents are present and cover the scope they claim. There is a thin gap between the summary and the actual documentation (the Chirper README ends with '## Sample prerequisites' before clipping), but it does not expose any real gaps. The repository's READMEs and architecture/Docs markdown files are well documented for their respective tiers (e.g. Orleans Hello World samples, durable journaling with Azure Blob JSON), covering what each directory does, installation/build steps, usage examples, and contribution guidance. The XML-doc coverage is low across most Orleans assemblies (0-16%), reflecting the project's focus on code rather than documentation. The repository's READMEs and architecture/Docs markdown files are well documented for their respective tiers. The root README gives an overview of what the project is and where to find installation/contribution guidance, while each sample README (e.g., Orleans Streaming samples, Orleans TicTacToe web-based game) documents its own directory and shows how to build/run it with a clear prerequisites section plus steps.

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 200 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D22 · Internal API ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether the internal API surface is consistent and coherent.

Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 API inconsistencies across 17 exposed types.

✓ On the Gold path — maintain.

Detailed fixes: d22_recommendation.md.

D24 · Comment ValueExemplary◐ Sampled · advisory

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

104 valuable / 1 redundant across 200 sampled comments; 1 shown with locations.

redundant commentdocs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:86

✓ On the Gold path — maintain.

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion9.6 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Documented

6 of 280 projects flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.3 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

76 % of calls cross a namespace and 4 % go through an interface, but 99 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.

Pass-through layer · ×10src/Orleans.Core/Networking/ConnectionTrace.cs:8

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)4.0 / 10Weak✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 4.0 / 10 · rule-coverage 100% · ceiling Documented

6 finding(s): 0 critical, 6 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 4 High secret finding(s) in Secrets (history) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
  2. Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  3. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)1.5 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 1.5 / 10 · rule-coverage 100% · ceiling Documented

22 finding(s): 0 critical, 6 high, 16 medium, 0 low. semgrep hit a parse error in 413 file(s) — `docs/site/scripts/audit-links.mjs` (line 10), `docs/site/scripts/audit-output.mjs` (line 4, line 5, line 6), `docs/site/scripts/generate-legacy-redirects.mjs` (line 4, line 5, line 6), `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs` (lines 9–10, line 11), … (+408 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 336 of those file(s) — `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansStatelessService.cs`, `docs/site/src/content/docs/grains/journaling/snippets/journaling/GrainJournalProviders.cs`, `docs/site/src/content/docs/grains/journaling/snippets/journaling/JournalingBasics.cs`, `docs/site/src/content/docs/grains/journaling/snippets/redis-journaling/Program.cs`, … (+331 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 27 of those file(s) — `docs/site/src/content/docs/grains/journaling/snippets/redis-journaling/Program.cs`, `docs/site/src/content/docs/grains/snippets/placement/CustomPlacement.cs`, `docs/site/src/content/docs/grains/snippets/placement/CustomPlacementFilter.cs`, `docs/site/src/content/docs/snippets/compiled/Grains/RequestsAndVersioningSnippets.cs`, `docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs`, … (+22 more) — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 7 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 3 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities5.0 / 10Weak✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

8 finding(s): 1 critical, 6 high, 0 medium, 1 low. Partial dependency scan: 2 of 3 declared ecosystem(s) were scanned (npm,osv), and the findings above are real and complete for them. nuget was not scanned (nuget: packagefeedproxy.microsoft.io could not be reached (NU1301: Unable to load the service index for source https://packagefeedproxy.microsoft.io/nuget/v3/index.json. The proxy tunnel request to proxy 'http://egress:3128/' failed with status code '403'.)), so this is not the whole dependency surface and the result is reported at reduced confidence.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 6 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (6). — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 1 Critical vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 Low CVE finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (Dockerfile/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

trivy and checkov found no infrastructure-as-code or container misconfigurations.

✓ On the Gold path — maintain.

Detailed fixes: d31_recommendation.md.

D34 · Knowledge Freshness9.3 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

85 of 1136 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/AdoNet/Shared/Storage/DbStoredQueries.cs. Counted over 1136 of the 2017 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledgesrc/AdoNet/Shared/Storage/DbStoredQueries.cs:1
Orphaned file · ×84src/Orleans.Core/Runtime/RingRange.cs:1
Further orphaned files (smaller)

What to do

  1. Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with DbStoredQueries.cs. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 84 Orphaned file finding(s) in Knowledge Freshness — start with LogViewAdaptor.cs (2), SerializationHostingExtensions.cs (2), RingRange.cs. — One of this dimension's main actionable groups (84 recommendation-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: ConsistentRingProvider.cs↔VirtualBucketsRingProvider.cs 67%; SimpleQueueCacheCursor.cs↔PersistentStreamPullingAgent.cs 62%; SerializableTypeDescription.cs↔SerializerGenerator.cs 60%

Change coupling: ConsistentRingProvider.cs ↔ VirtualBucketsRingProvider.cs · ×6src/Orleans.Runtime/ConsistentRing/ConsistentRingProvider.cs:1

What to do

  1. Resolve the 6 Change coupling finding(s) in Change Coupling — start with ConsistentRingProvider.cs, SimpleQueueCacheCursor.cs, SerializableTypeDescription.cs. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 200 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

AC2 · Forms & labels5.2 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label. (×7) — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:109, src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:119, src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:130, …
  • This control has no associated label. Add a <label htmlFor> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:69

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure5.2 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×3) — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:2, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:2, playground/DurableJobsJournaling/DurableJobsJournaling.Web/wwwroot/index.html:2
  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). — src/Dashboard/Orleans.Dashboard.App/index.html:2
  • user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta. — src/Dashboard/Orleans.Dashboard.App/index.html:7
  • A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). — src/Dashboard/Orleans.Dashboard.App/src/components/grain-method-table.tsx:42

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC4 · Keyboard semantics1.0 / 10Critical✓ Tool-verified

Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".

  • A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler. (×5) — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:178, src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:189, src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:203, …
  • An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. — REDACTED:129

What to do

  • Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety6.8 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.loading` moves (`animation: pulse 2s infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:276
  • `.absolute-button` sets color: white on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:15
  • `.log-filter` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/Dashboard/Orleans.Dashboard.App/src/custom.css:56
  • `.alert .close:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — src/Dashboard/Orleans.Dashboard.App/src/custom.css:91

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified

Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.

Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.

Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.

  • No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 37 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.

What to do

  • Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with @axe-core/playwright in tests, then gate axe/pa11y/Lighthouse in CI.
AX1 · Captive dependencies7.9 / 10Strong✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

  • `SiloHostedService` is registered as a SINGLETON but its constructor takes `IEnumerable configurationValidators`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IConfigurationValidator` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Orleans.Runtime/Hosting/SiloHostedService.cs:17
  • `DhtGrainLocator` is registered as a SINGLETON but its constructor takes `IGrainContext grainContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGrainContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Orleans.Runtime/GrainDirectory/DhtGrainLocator.cs:29
  • `PlayerWatcherHostedService` is registered as a SINGLETON but its constructor takes `IGameObserver observer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGameObserver` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — samples/Presence/src/PlayerWatcher/PlayerWatcherHostedService.cs:19
  • `StockWorker` is registered as a SINGLETON but its constructor takes `StockClient stockClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `StockClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — docs/site/src/content/docs/streaming/snippets/broadcastchannel/BroadcastChannel.Silo/Services/StockWorker.cs:16

What to do

  • Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
AX10 · Code composition8.7 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons5.0 / 10Adequate✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `ClusterDiagnosticsService` is a singleton (one shared instance) but mutates instance state outside any lock (_version; e.g. `_version` at line 25). — playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:7
  • `LoadDriver` is a singleton (one shared instance) but mutates instance state outside any lock (_enabled, _startedAt; e.g. `_enabled` at line 22). — playground/DurableJobsJournaling/DurableJobsJournaling.Web/LoadDriver.cs:7
  • `ClientInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_connectedGatewayCount; e.g. `_connectedGatewayCount` at line 11). — src/Orleans.Core/Diagnostics/Metrics/ClientInstruments.cs:6
  • `MessagingProcessingInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_activationDataAll; e.g. `_activationDataAll` at line 126). — src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:6
  • `EnvironmentStatisticsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_maximumAvailableMemoryBytes, _availableMemoryBytes; e.g. `_maximumAvailableMemoryBytes` at line 70). — src/Orleans.Core/Statistics/EnvironmentStatisticsProvider.cs:11
  • `OutsideRuntimeClient` is a singleton (one shared instance) but mutates instance state outside any lock (_statusObservers, _manifestProvider, InternalGrainFactory, _cancellationManager, messageFactory, localObjects; e.g. `_statusObservers` at line 112). — src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:21
  • `ClientGrainContext` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReference; e.g. `_grainReference` at line 25). — src/Orleans.Core/Runtime/ClientGrainContext.cs:8
  • `GrainFactory` is a singleton (one shared instance) but mutates instance state outside any lock (grainReferenceRuntime; e.g. `grainReferenceRuntime` at line 38). — src/Orleans.Core/Core/GrainFactory.cs:12
  • `GrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 350). — src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:291
  • `UntypedGrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 144). — src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:106
  • `LinearBackoffClientConnectionRetryFilter` is a singleton (one shared instance) but mutates instance state outside any lock (_retryCount; e.g. `_retryCount` at line 40). — src/Orleans.Core/Core/IClientConnectionRetryFilter.cs:23
  • `ClientMessageCenter` is a singleton (one shared instance) but mutates instance state outside any lock (Running, messageHandler; e.g. `Running` at line 103). — src/Orleans.Core/Messaging/ClientMessageCenter.cs:40
  • `GatewayManager` is a singleton (one shared instance) but mutates instance state outside any lock (gatewayListProviderInitialized, roundRobinCounter, knownGateways, cachedLiveGateways, cachedLiveGatewaysSet, lastRefreshTime; e.g. `gatewayListProviderInitialized` at line 68). — src/Orleans.Core/Messaging/GatewayManager.cs:24
  • `ClientClusterManifestProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 77). — src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:22
  • `LocalDurableJobManager` is a singleton (one shared instance) but mutates instance state outside any lock (_startTimestamp, _listenForClusterChangesTask, _periodicCheckTask, _totalClaimedShards; e.g. `_startTimestamp` at line 220). — src/Orleans.DurableJobs/LocalDurableJobManager.cs:22
  • `LocalReminderService` is a singleton (one shared instance) but mutates instance state outside any lock (localTableSequence, localReminders, runTask, initialReadCallCount; e.g. `localTableSequence` at line 395). — src/Orleans.Reminders/ReminderService/LocalReminderService.cs:19
  • `ReminderRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (serviceProvider; e.g. `serviceProvider` at line 107). — src/Orleans.Reminders/ReminderService/ReminderRegistry.cs:13
  • `InMemoryReminderTable` is a singleton (one shared instance) but mutates instance state outside any lock (isAvailable; e.g. `isAvailable` at line 88). — src/Orleans.Reminders/ReminderService/InMemoryReminderTable.cs:7
  • `ActivationRebalancerMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_monitorTimer, _latestReport, _lastHeartbeatTimestamp, _statusListeners; e.g. `_monitorTimer` at line 82). — src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs:16
  • `ActivationRepartitioner` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCountOffset, _currentExchangeSilo, _enableMessageSampling, _processPendingEdgesTask; e.g. `_activationCountOffset` at line 163). — src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:24
  • `SystemTargetBasedMembershipTable` is a singleton (one shared instance) but mutates instance state outside any lock (grain, membershipManager; e.g. `grain` at line 38). — src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:14
  • `MembershipTableSystemTarget` is a singleton (one shared instance) but mutates instance state outside any lock (table; e.g. `table` at line 256). — src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:208
  • `ConsistentRingInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_ringSize, _myRangeRingPercentage, _averageRingPercentage; e.g. `_ringSize` at line 14). — src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:6
  • `CatalogInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCount, _activationWorkingSet; e.g. `_activationCount` at line 188). — src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:9
  • `DirectoryInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_directoryPartitionSize, _ringSize, _myPortionRingDistance, _myPortionRingPercentage, _myPortionAverageRingPercentage; e.g. `_directoryPartitionSize` at line 46). — src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:9
  • `Watchdog` is a singleton (one shared instance) but mutates instance state outside any lock (_platformWatchdogTimestamp, _cumulativeGCPauseDuration, _platformWatchdogThread, _componentWatchdogTimestamp, _lastComponentHealthCheckTime, _componentWatchdogThread; e.g. `_platformWatchdogTimestamp` at line 53). — src/Orleans.Runtime/Silo/Watchdog.cs:18
  • `SiloLifecycleSubject` is a singleton (one shared instance) but mutates instance state outside any lock (observers; e.g. `observers` at line 119). — src/Orleans.Runtime/Lifecycle/SiloLifecycleSubject.cs:15
  • `OverloadDetector` is a singleton (one shared instance) but mutates instance state outside any lock (_isOverloaded; e.g. `_isOverloaded` at line 60). — src/Orleans.Runtime/Messaging/OverloadDetector.cs:22
  • `ActivationCollector` is a singleton (one shared instance) but mutates instance state outside any lock (_collectionLoopTask, _memBasedDeactivationLoopTask; e.g. `_collectionLoopTask` at line 673). — src/Orleans.Runtime/Catalog/ActivationCollector.cs:22
  • `ActivationWorkingSet` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 200). — src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:18
  • `LocalGrainDirectory` is a singleton (one shared instance) but mutates instance state outside any lock (Running, membershipUpdatesTask, directoryMembership, appliedClusterMembershipSnapshot, hasAppliedClusterMembershipSnapshot, grainDirectoryResolver; e.g. `Running` at line 127). — src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs:20
  • `GrainLocatorResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_clientGrainLocator; e.g. `_clientGrainLocator` at line 38). — src/Orleans.Runtime/GrainDirectory/GrainLocatorResolver.cs:8
  • `GenericGrainDirectoryResolver` is a singleton (one shared instance) but mutates instance state outside any lock (_resolver; e.g. `_resolver` at line 35). — src/Orleans.Runtime/GrainDirectory/GenericGrainDirectoryResolver.cs:9
  • `CachedGrainLocator` is a singleton (one shared instance) but mutates instance state outside any lock (listenToClusterChangeTask; e.g. `listenToClusterChangeTask` at line 151). — src/Orleans.Runtime/GrainDirectory/CachedGrainLocator.cs:17
  • `MessageCenter` is a singleton (one shared instance) but mutates instance state outside any lock (hostedClient, stopped, IsBlockingApplicationMessages, sniffIncomingMessageHandler; e.g. `hostedClient` at line 75). — src/Orleans.Runtime/Messaging/MessageCenter.cs:16
  • `InsideRuntimeClient` is a singleton (one shared instance) but mutates instance state outside any lock (grainLocator, grainCallFilters, messageCenter, grainReferenceRuntime, hostedClient, _cancellationManager; e.g. `grainLocator` at line 129). — src/Orleans.Runtime/Core/InsideRuntimeClient.cs:28
  • `DeploymentLoadPublisher` is a singleton (one shared instance) but mutates instance state outside any lock (_publishTimer, _lastUpdateDateTimeTicks, LocalRuntimeStatistics; e.g. `_publishTimer` at line 85). — src/Orleans.Runtime/Placement/DeploymentLoadPublisher.cs:20
  • `MembershipTableManager` is a singleton (one shared instance) but mutates instance state outside any lock (pendingRefresh; e.g. `pendingRefresh` at line 157). — src/Orleans.Runtime/MembershipService/MembershipTableManager.cs:22
  • `MembershipGossiper` is a singleton (one shared instance) but mutates instance state outside any lock (_membershipSystemTarget; e.g. `_membershipSystemTarget` at line 26). — src/Orleans.Runtime/MembershipService/MembershipGossiper.cs:10
  • `ClusterHealthMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (createMonitor, onProbeResult, observedMembershipVersion; e.g. `createMonitor` at line 75). — src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:24

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces Orleans.BroadcastChannel ↔ Orleans.BroadcastChannel.SubscriberTable depend on each other. The lightest dependency in the cycle is Orleans.BroadcastChannel → Orleans.BroadcastChannel.SubscriberTable (Orleans.BroadcastChannel.BroadcastChannelProvider → Orleans.BroadcastChannel.SubscriberTable.ImplicitChannelSubscriberTable, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Orleans.BroadcastChannel/BroadcastChannelProvider.cs:5
  • The namespaces Orleans.Caching ↔ Orleans.Caching.Internal depend on each other. The lightest dependency in the cycle is Orleans.Caching.Internal → Orleans.Caching (Orleans.Caching.Internal.CacheDebugView → Orleans.Caching.ConcurrentLruCache, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Orleans.Core/Caching/Internal/CacheDebugView.cs:10
  • The namespaces Orleans.Clustering.Cosmos ↔ Orleans.Clustering.Cosmos.Models depend on each other. The lightest dependency in the cycle is Orleans.Clustering.Cosmos.Models → Orleans.Clustering.Cosmos (Orleans.Clustering.Cosmos.Models.SiloEntity → Orleans.Clustering.Cosmos.BaseClusterEntity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Azure/Orleans.Clustering.Cosmos/Models/SiloEntity.cs:5
  • The namespaces Orleans.GrainDirectory.AdoNet ↔ Orleans.GrainDirectory.AdoNet.Storage depend on each other. The lightest dependency in the cycle is Orleans.GrainDirectory.AdoNet → Orleans.GrainDirectory.AdoNet.Storage (Orleans.GrainDirectory.AdoNet.AdoNetGrainDirectory → Orleans.GrainDirectory.AdoNet.Storage.RelationalOrleansQueries, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/AdoNet/Orleans.GrainDirectory.AdoNet/AdoNetGrainDirectory.cs:3
  • The namespaces Orleans ↔ Orleans.AzureUtils ↔ Orleans.ClientObservers ↔ Orleans.Clustering.DynamoDB ↔ Orleans.CodeGeneration ↔ Orleans.Configuration ↔ Orleans.Connections.Transport ↔ Orleans.Connections.Transport.Security ↔ Orleans.Connections.Transport.Streams ↔ Orleans.Core ↔ Orleans.Core.Diagnostics ↔ Orleans.DurableJobs ↔ Orleans.GrainDirectory ↔ Orleans.GrainDirectory.AzureStorage ↔ Orleans.GrainDirectory.Firestore ↔ Orleans.GrainReferences ↔ Orleans.Hosting ↔ Orleans.Hosting.Kubernetes ↔ Orleans.Internal ↔ Orleans.Journaling ↔ Orleans.Messaging ↔ Orleans.Metadata ↔ Orleans.Persistence ↔ Orleans.Persistence.Firestore ↔ Orleans.Placement ↔ Orleans.Placement.Repartitioning ↔ Orleans.Providers ↔ Orleans.Providers.Streams.Common ↔ Orleans.Providers.Streams.Generator ↔ Orleans.Reminders.DynamoDB ↔ Orleans.Reminders.Firestore ↔ Orleans.Runtime ↔ Orleans.Runtime.ConsistentRing ↔ Orleans.Runtime.Diagnostics ↔ Orleans.Runtime.GrainDirectory ↔ Orleans.Runtime.MembershipService ↔ Orleans.Runtime.MembershipService.SiloMetadata ↔ Orleans.Runtime.Messaging ↔ Orleans.Runtime.Placement ↔ Orleans.Runtime.Placement.Filtering ↔ Orleans.Runtime.Providers ↔ Orleans.Runtime.Scheduler ↔ Orleans.Runtime.Utilities ↔ Orleans.Runtime.Versions ↔ Orleans.Runtime.Versions.Compatibility ↔ Orleans.Runtime.Versions.Selector ↔ Orleans.Serialization ↔ Orleans.Serialization.Buffers ↔ Orleans.Serialization.Buffers.Adaptors ↔ Orleans.Serialization.Cloning ↔ Orleans.Serialization.Codecs ↔ Orleans.Serialization.Configuration ↔ Orleans.Serialization.Invocation ↔ Orleans.Serialization.Serializers ↔ Orleans.Serialization.Session ↔ Orleans.Serialization.TypeSystem ↔ Orleans.Services ↔ Orleans.Statistics ↔ Orleans.Storage ↔ Orleans.Streaming.EventHubs ↔ Orleans.Streaming.Kinesis ↔ Orleans.Streaming.SQS.Streams ↔ Orleans.Streams ↔ Orleans.Streams.Core ↔ Orleans.Streams.Filtering ↔ Orleans.Timers ↔ Orleans.Transactions ↔ Orleans.Transactions.Abstractions ↔ Orleans.Transactions.AzureStorage ↔ Orleans.Transactions.Diagnostics ↔ Orleans.Transactions.State depend on each other. The lightest dependency in the cycle is Orleans → Orleans.ClientObservers (Orleans.OutsideRuntimeClient → Orleans.ClientObservers.ClientGatewayObserver, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:10
  • The namespaces Orleans.Dashboard ↔ Orleans.Dashboard.Implementation ↔ Orleans.Dashboard.Metrics depend on each other. The lightest dependency in the cycle is Orleans.Dashboard.Implementation → Orleans.Dashboard (Orleans.Dashboard.Implementation.SiloGrainService → Orleans.Dashboard.DashboardOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Dashboard/Orleans.Dashboard/Implementation/SiloGrainService.cs:16
  • The namespaces Orleans.Reminders.Cosmos ↔ Orleans.Reminders.Cosmos.Models depend on each other. The lightest dependency in the cycle is Orleans.Reminders.Cosmos → Orleans.Reminders.Cosmos.Models (Orleans.Reminders.Cosmos.CosmosReminderTable → Orleans.Reminders.Cosmos.Models.ReminderEntity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Azure/Orleans.Reminders.Cosmos/CosmosReminderTable.cs:3
  • The namespaces Orleans.Streaming.AdoNet ↔ Orleans.Streaming.AdoNet.Storage depend on each other. The lightest dependency in the cycle is Orleans.Streaming.AdoNet.Storage → Orleans.Streaming.AdoNet (Orleans.Streaming.AdoNet.Storage.RelationalOrleansQueries → Orleans.Streaming.AdoNet.AdoNetStreamConfirmation, 4 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:23

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `IGrainFactory` declares 17 members under just 3 distinct name(s): `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `CreateObjectReference`, `DeleteObjectReference`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Orleans.Core.Abstractions/Core/IGrainFactory.cs:47
  • `IGrainContext` declares 16 members: `GrainReference`, `GrainId`, `GrainInstance`, `ActivationId`, `Address`, `ActivationServices`, `ObservableLifecycle`, `Scheduler`, `Deactivated`, `SetComponent`, `ReceiveMessage`, `ReceiveLocalRequest`, `Activate`, `Deactivate`, `Rehydrate`, `Migrate`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Core.Abstractions/Core/IGrainContext.cs:12
  • `IMembershipTable` declares 16 members: `InitializeMembershipTable`, `InitializeMembershipTableAsync`, `DeleteMembershipTableEntries`, `DeleteMembershipTableEntriesAsync`, `CleanupDefunctSiloEntries`, `CleanupDefunctSiloEntriesAsync`, `ReadRow`, `ReadRowAsync`, `ReadAll`, `ReadAllAsync`, `InsertRow`, `InsertRowAsync`, `UpdateRow`, `UpdateRowAsync`, `UpdateIAmAlive`, `UpdateIAmAliveAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Core/SystemTargetInterfaces/IMembershipTable.cs:24
  • `IManagementGrain` declares 35 members: `DeactivateGrain`, `GetHosts`, `GetHosts`, `GetDetailedHosts`, `GetDetailedHosts`, `ForceGarbageCollection`, `ForceGarbageCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceRuntimeStatisticsCollection`, `ForceRuntimeStatisticsCollection`, `GetRuntimeStatistics`, `GetRuntimeStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetDetailedGrainStatistics`, `GetDetailedGrainStatistics`, `GetGrainActivationCount`, `GetGrainActivationCount`, `GetTotalActivationCount`, `GetTotalActivationCount`, `SendControlCommandToProvider`, `SendControlCommandToProvider`, `GetActivationAddress`, `GetActivationAddress`, `GetActiveGrains`, `GetActiveGrains`, `GetGrainCallFrequencies`, `GetGrainCallFrequencies`, `ResetGrainCallFrequencies`, `ResetGrainCallFrequencies`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 35 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Core/SystemTargetInterfaces/IManagementGrain.cs:13
  • `IReminderServiceLifecycleHarness` declares 22 members: `GrainFactory`, `ReminderTable`, `UtcNow`, `ReminderLoadingWindow`, `ReminderRefreshPeriod`, `ActiveSilos`, `WaitForStartupReadinessAsync`, `AdvanceAsync`, `RefreshAsync`, `WaitForOwnerCountAsync`, `GetOwners`, `IsOwner`, `WaitForScheduleAsync`, `GetLocalStartCount`, `GetLocalStopCount`, `GetScheduleChangeCount`, `WaitForScheduleChangeCountAsync`, `WaitForTickCountAsync`, `GetTickCount`, `JoinOneSiloAsync`, `LeaveSiloAsync`, `WaitForTopologyReconciliationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:16
  • `IStreamPubSub` declares 17 members under just 9 distinct name(s): `RegisterProducer`, `RegisterProducer`, `UnregisterProducer`, `UnregisterProducer`, `RegisterConsumer`, `RegisterConsumer`, `UnregisterConsumer`, `UnregisterConsumer`, `ProducerCount`, `ProducerCount`, `ConsumerCount`, `ConsumerCount`, `GetAllSubscriptions`, `GetAllSubscriptions`, `CreateSubscriptionId`, `FaultSubscription`, `FaultSubscription`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Orleans.Streaming/Providers/IStreamProviderRuntime.cs:72

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
  • Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
AX8 · Test isolation5.0 / 10Adequate✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

  • `Orleans.Connections.Security.Tests` (production) references the test project `TestExtensions`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference. — test/Orleans.Connections.Security.Tests/Orleans.Connections.Security.Tests.csproj:14
  • `Orleans.Dashboard.UnitTests` (production) references the test project `TestExtensions`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference. — test/Orleans.Dashboard.Tests/Orleans.Dashboard.UnitTests/Orleans.Dashboard.UnitTests.csproj:15

What to do

  • Remove every production → test project reference: extract any shared test helper into a production support library (which the tests reference), or invert the dependency so the test project depends on production — not the reverse.
C1 · Data Protection3.0 / 10Weak✓ Tool-verified

Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.

Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.

  • No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.

What to do

  • Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.).
C2 · Access Controls10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.

Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.

C3 · Audit Trail7.5 / 10Strong✓ Tool-verified

Other · Security — Whether changes to sensitive data are recorded (who, what, when) for compliance + incident response.

Method: Roslyn scan: audit-trail mechanism graded (SaveChanges interceptor/immutable AuditLog/[Audited] strong; bare IAuditable/AddAuditing weak). Deterministic.

  • An audit mechanism is present, but the trail is not yet complete — missing: a write-side hook (the one code path every change to the sensitive data flows through, recording who changed what), [Audited] per-entity coverage.

What to do

  • Back the audit convention with a structural mechanism: route every sensitive change through one write path that records it to an immutable audit log with the acting user and time, and apply [Audited] to the entities that need a who-changed-what trail.
C4 · Data Retention10.0 / 10Exemplary✓ Tool-verified

Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).

Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.

ED1 · Handler temporal coupling10.0 / 10Exemplary✓ Tool-verified

Other · Event-Driven — Whether event handlers stay asynchronous (no blocking remote HTTP/gRPC calls awaited inside a handler).

Method: Roslyn semantic scan (event-driven gated): event-handler bodies scanned for HTTP/gRPC invocations by resolved symbol type, not substring. Deterministic, semantic-resolved.

ED4 · Outbox / dual-write10.0 / 10Exemplary○ Nothing flagged

Other · Event-Driven — Whether state changes and message publishes are atomic (a transactional outbox) rather than a crash-unsafe dual write.

Method: Roslyn semantic scan (event-driven gated): event-handler methods scanned for DB-save plus bus-publish without a transactional outbox reference. Deterministic, semantic-resolved.

ED5 · Idempotency7.7 / 10Strong◐ Sampled · advisory

Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.

Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.

Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.

  • `Journaling.DurableList.AddRange` mutates persistent state (a repository write) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write. — src/Orleans.Journaling/DurableList.cs:170

What to do

  • Make retry-prone mutations idempotent — guard each write with an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write, so a re-run doesn't double-apply.
GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×15) — src/Orleans.Core/Runtime/InvokableObjectManager.cs:152, src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs:85, src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80, …

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs6.3 / 10Adequate✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `Serialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:10
  • `Deserialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:11
  • `DoWorkAsync` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — docs/site/src/content/docs/migration/snippets/Orleans10MigrationExamples.cs:79
  • `ReadStateFromStorage` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:69
  • `ApplyUpdatesToStorage` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:72
  • `ClearStoredState` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:77
  • Both arms of `backtickIdx >= 0 ? … : …` are `containingTypeName`, so no input can make the condition matter. Implement the distinction that was intended, or drop the condition. — docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:630
  • Control only reaches here when `enumerator.MoveNext()` is true, because the guard on line 36 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test. — src/Orleans.Core.Abstractions/Utils/Utils.cs:40
  • The only thing establishing that `buffers` is long enough before it is indexed is a `Debug.Assert`, which is `[Conditional("DEBUG")]` — the compiler deletes the call from Release, so the build your users install indexes `buffers` with no length check at all and throws at the indexer instead of failing diagnosably. `buffers` comes from outside this method, so its length is a contract, not something this code can see. Bound it with a check that ships (`if (buffers.Count < n) throw …`, or `ArgumentOutOfRangeException.ThrowIfLessThan`), and keep the assert for the invariant you believe holds. — src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:807
  • The `if` and its `else` contain the same 2 statements, so no input can make the condition matter. Implement the distinction that was intended, or drop the branch and keep the body. — src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:838
  • `IsLocallyActivated` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — src/Orleans.Core/Runtime/ClientLocalActivationStatusChecker.cs:5
  • `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×3) — src/Orleans.Core/Runtime/InvokableObjectManager.cs:152, src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84, src/Orleans.Runtime/Core/HostedClient.cs:102
  • `ActivationServices` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80
  • `ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82, src/Orleans.Runtime/Core/HostedClient.cs:100
  • `GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137, src/Orleans.Runtime/Core/HostedClient.cs:426
  • Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored. (×2) — src/Orleans.Runtime/Core/InsideRuntimeClient.cs:270, src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:250
  • `OnRuntimeServicesStart` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — src/Orleans.Runtime/Silo/Silo.cs:190
  • `ThrowIfNull` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — src/Orleans.Serialization/Codecs/ArgumentNullExceptionPolyfill.cs:41
  • `WriteField` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14
  • A test is skipped with reason "Flaky test. Needs to be investigated." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten. — test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:416
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×12) — docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/StorageConfiguration.cs:137, docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/StorageConfiguration.cs:158, playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:24, …
  • `WorkerAsync` has an empty body — confirm it's an intentional no-op and not an unfinished method. — docs/site/src/content/docs/snippets/compiled/Grains/GeneralSnippets.cs:66
  • `GetEvents`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:432
  • `ImportRequestContext`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional. — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:433

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)7.1 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 214 of 280 project(s) that lack one — worth up to 1.5 pts.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

  • Only 118/280 projects share a common root namespace — the code's module identity is inconsistent.

What to do

  • Adopt a consistent root-namespace convention (a shared prefix, e.g. Acme.*); short project-file/directory names are fine as long as the RootNamespace is uniform.
M4 · Documentation accuracy9.6 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • src/Orleans.Clustering.TestKit/README.md names the project `Microsoft.Orleans.Clustering.TestKit`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Clustering.TestKit/README.md:3
  • src/Orleans.DurableJobs/README.md installs the package `Microsoft.Orleans.DurableJobs.AzureStorage` (`dotnet add package Microsoft.Orleans.DurableJobs.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.DurableJobs/README.md:26
  • src/Orleans.Serialization.Abstractions/README.md installs the package `Microsoft.Orleans.Serialization.Abstractions` (`dotnet add package Microsoft.Orleans.Serialization.Abstractions`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Serialization.Abstractions/README.md:10
  • src/Orleans.Serialization.FSharp/README.md installs the package `Microsoft.Orleans.Serialization.FSharp` (`dotnet add package Microsoft.Orleans.Serialization.FSharp`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Serialization.FSharp/README.md:10
  • src/Orleans.Serialization.TestKit/README.md installs the package `Microsoft.Orleans.Serialization.TestKit` (`dotnet add package Microsoft.Orleans.Serialization.TestKit`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Serialization.TestKit/README.md:10
  • src/Orleans.Serialization/README.md installs the package `Microsoft.Orleans.Serialization` (`dotnet add package Microsoft.Orleans.Serialization`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Serialization/README.md:10
  • src/Orleans.Streaming.NATS/README.md installs the package `Microsoft.Orleans.Streaming.NATS` (`dotnet add package Microsoft.Orleans.Streaming.NATS`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Orleans.Streaming.NATS/README.md:10
  • src/AWS/Orleans.Streaming.SQS/README.md installs the package `Microsoft.Orleans.Streaming.SQS` (`dotnet add package Microsoft.Orleans.Streaming.SQS`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/AWS/Orleans.Streaming.SQS/README.md:8
  • src/AWS/Orleans.Transactions.DynamoDB/README.md installs the package `Microsoft.Orleans.Transactions.DynamoDB` (`dotnet add package Microsoft.Orleans.Transactions.DynamoDB`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/AWS/Orleans.Transactions.DynamoDB/README.md:13
  • src/AdoNet/Orleans.Streaming.AdoNet/README.md installs the package `Microsoft.Orleans.Streaming.AdoNet` (`dotnet add package Microsoft.Orleans.Streaming.AdoNet`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/AdoNet/Orleans.Streaming.AdoNet/README.md:10
  • src/Azure/Orleans.DurableJobs.AzureStorage/README.md installs the package `Microsoft.Orleans.DurableJobs.AzureStorage` (`dotnet add package Microsoft.Orleans.DurableJobs.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Azure/Orleans.DurableJobs.AzureStorage/README.md:13
  • src/Azure/Orleans.GrainDirectory.AzureStorage/README.md installs the package `Microsoft.Orleans.GrainDirectory.AzureStorage` (`dotnet add package Microsoft.Orleans.GrainDirectory.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Azure/Orleans.GrainDirectory.AzureStorage/README.md:10
  • src/Dashboard/Orleans.Dashboard.Abstractions/README.md installs the package `Microsoft.Orleans.Dashboard.Abstractions` (`dotnet add package Microsoft.Orleans.Dashboard.Abstractions`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Dashboard/Orleans.Dashboard.Abstractions/README.md:12
  • src/Redis/Orleans.Journaling.Redis/README.md installs the package `Microsoft.Orleans.Journaling.Redis` (`dotnet add package Microsoft.Orleans.Journaling.Redis`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Redis/Orleans.Journaling.Redis/README.md:14
  • src/Serializers/Orleans.Serialization.Protobuf/README.md installs the package `Microsoft.Orleans.Serialization.Protobuf` (`dotnet add package Microsoft.Orleans.Serialization.Protobuf`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — src/Serializers/Orleans.Serialization.Protobuf/README.md:10
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/benefits/`, but `orleans/docs/benefits` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:54
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/grains/grain-persistence/`, but `orleans/docs/grains/grain-persistence` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:55
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/grains/timers-and-reminders/`, but `orleans/docs/grains/timers-and-reminders` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:56
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/host/monitoring/`, but `orleans/docs/host/monitoring` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:57
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/implementation/testing/`, but `orleans/docs/implementation/testing` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:58
  • docs/site/src/site-pages/docs.mdx links to `/orleans/docs/migration-guide/`, but `orleans/docs/migration-guide` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/docs.mdx:59
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/`, but `orleans/docs/grains` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:35
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/grain-persistence/`, but `orleans/docs/grains/grain-persistence` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:38
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/streaming/`, but `orleans/docs/streaming` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:41
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/timers-and-reminders/`, but `orleans/docs/grains/timers-and-reminders` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:44
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/resources/nuget-packages/#reminders-and-durable-jobs`, but `orleans/docs/resources/nuget-packages` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:44
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/transactions/`, but `orleans/docs/grains/transactions` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:47
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/event-sourcing/`, but `orleans/docs/grains/event-sourcing` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:50
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/grain-placement/`, but `orleans/docs/grains/grain-placement` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:53
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/overview/#silos-and-clusters`, but `orleans/docs/overview` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:56
  • docs/site/src/site-pages/home.mdx links to `/orleans/docs/scenarios/`, but `orleans/docs/scenarios` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/site-pages/home.mdx:62
  • docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md documents the environment variable `CONTAINER_APP_REPLICA_NAME`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md:55
  • docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md documents the environment variable `CONTAINER_APP_HOSTNAME`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md:55
  • docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md documents the environment variable `CONTAINER_APP_NAME`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md:152
  • docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md documents the environment variable `CONTAINER_APP_REVISION`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/deploy-to-azure-container-apps.md:152
  • docs/site/src/content/docs/deployment/networking.md names the project `Microsoft.Orleans.Clustering.ZooKeeper`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/networking.md:65
  • docs/site/src/content/docs/deployment/networking.md names the project `Microsoft.Orleans.Clustering.Consul`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/deployment/networking.md:66
  • docs/site/src/content/docs/host/grain-directory.md names the project `Microsoft.Orleans.GrainDirectory.AzureStorage`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/host/grain-directory.md:31
  • docs/site/src/content/docs/host/grain-directory.md names the project `Microsoft.Orleans.GrainDirectory.AdoNet`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/host/grain-directory.md:33
  • docs/site/src/content/docs/implementation/provider-authoring.md names the project `Microsoft.Orleans.Clustering.TestKit`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/site/src/content/docs/implementation/provider-authoring.md:109

What to do

  • Reconcile the README with reality: src/Orleans.Clustering.TestKit/README.md names the project `Microsoft.Orleans.Clustering.TestKit`, but no project, folder or namespace of that name exists; src/Orleans.DurableJobs/README.md installs the package `Microsoft.Orleans.DurableJobs.AzureStorage` (`dotnet add package Microsoft.Orleans.DurableJobs.AzureStorage`), but no project or props file references it; src/Orleans.Serialization.Abstractions/README.md installs the package `Microsoft.Orleans.Serialization.Abstractions` (`dotnet add package Microsoft.Orleans.Serialization.Abstractions`), but no project or props file references it; src/Orleans.Serialization.FSharp/README.md installs the package `Microsoft.Orleans.Serialization.FSharp` (`dotnet add package Microsoft.Orleans.Serialization.FSharp`), but no project or props file references it; src/Orleans.Serialization.TestKit/README.md installs the package `Microsoft.Orleans.Serialization.TestKit` (`dotnet add package Microsoft.Orleans.Serialization.TestKit`), but no project or props file references it.
P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.

What to do

  • Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.
P2 · Observability9.2 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 91/126 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 126, 53 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
  • `src/Orleans.Runtime/Core/FatalErrorHandler.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Orleans.Runtime/Core/FatalErrorHandler.cs:33
  • `docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs` reports through `Console.Write…` at line 119 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs:119

What to do

  • Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
  • Replace `Console.Write…` in service code with the project's injected `ILogger<T>` (message templates with named properties), so delivery outcomes and failures reach the log pipeline with a level and a category.
P3 · Security & performance tooling8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • Dependabot is configured but does not watch `github-actions`, `nuget`, `npm` — add those `package-ecosystem` entries to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P5 · DR & Backup10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `new()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — REDACTED:9

What to do

  • Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
PF1 · Benchmark discipline9.5 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

PF2 · Allocation hygiene8.9 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 1766 use(s) across 308,577 production line(s) (~5.7/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • 42 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×34) — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:655, src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:752, src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:801, …
  • `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/Orleans.Reminders.TestKit/ReminderTableModelBasedTestRunner.cs:178
  • `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×3) — src/Orleans.Runtime/Catalog/ActivationData.cs:983, src/Orleans.Runtime/Silo/Silo.cs:504, src/Orleans.TestingHost/TestCluster.cs:1257
  • `notification.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:83

What to do

  • Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
R1 · Type Safety10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

R10 · Code Duplication7.9 / 10Strong✓ Tool-verified

React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.

  • 8 duplicated blocks under src/Dashboard/Orleans.Dashboard.App/src/ have copies in at least two of the sibling directories components, grains, lifecycle, overview, silos — 7 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103
  • src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 · src/Dashboard/Orleans.Dashboard.App/src/grains/silo-table.tsx:33 — the two spans are one implementation copied and then locally edited — 342 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103
  • src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:121 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138
  • src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:80 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66
  • src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24 · src/Dashboard/Orleans.Dashboard.App/src/components/time-series-chart.tsx:72 — the two spans are one implementation copied and then locally edited — 90 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24
  • src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108 · src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108
  • src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:47 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:76 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:47
  • src/Dashboard/Orleans.Dashboard.App/src/index.tsx:214 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:236 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:214
  • src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71 · src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71
  • src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:196 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180
  • src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36 · src/Dashboard/Orleans.Dashboard.App/src/silos/silos.tsx:28 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36
  • src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:203 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:238 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:203
  • src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:202 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:216 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:230 — all 4 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188
  • src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:291 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158
  • src/Dashboard/Orleans.Dashboard.App/src/index.tsx:264 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:391 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:264
  • src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15 · src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:16 — the two spans are one implementation copied and then locally edited — 65 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15
  • src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41
  • src/Dashboard/Orleans.Dashboard.App/src/index.tsx:286 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:294 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:302 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:286
  • src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31 · src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:21 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31
  • src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:39 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11

What to do

  • Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
R2 · Cyclomatic Complexity10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

  • parseSuffix has cyclomatic complexity 14 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:55
  • parseType has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:79
  • formatMemberName has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:13
R3 · Large Files8.9 / 10Strong✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

  • src/Dashboard/Orleans.Dashboard.App/src/index.tsx has 589 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:1

What to do

  • Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.

Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.

R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

R8 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.

Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.

R9 · Circular Imports10.0 / 10Exemplary✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

S1 · Web-Security Posture7.0 / 10Strong✓ Tool-verified

Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • `https://d3js.org/d3.v7.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository. — playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:7
  • Set: Content-Security-Policy, X-Frame-Options. Missing: Strict-Transport-Security, X-Content-Type-Options — the four headers that carry the points of this card's security-headers term (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options), 0.5 each. (−1.0 on this card.) — samples/ShoppingCart/Silo/Program.cs:56

What to do

  • Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
  • Add Strict-Transport-Security, X-Content-Type-Options beside the headers already set; Content-Security-Policy is the one that pays for itself first, then Strict-Transport-Security, then nosniff and a frame policy.
X1 · Async correctness7.4 / 10Strong✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×10) — src/Orleans.Core.Abstractions/Runtime/GrainRequest.cs:90, src/Orleans.DurableJobs/IDurableJobReceiverExtension.cs:224, src/Orleans.Runtime/Core/ManagementGrain.cs:235, …
  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×15) — src/Orleans.Core/Async/TaskExtensions.cs:213, src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:59, src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:68, …
  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback. (×10) — src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:275, src/Orleans.Core/Networking/ConnectionFactory.cs:51, src/Orleans.Journaling/JournaledStateManager.cs:1100, …
  • This blocks on a Task **while holding a `lock`**, which is worse than an ordinary sync-over-async in two ways. `await` is illegal inside a `lock` body, so the usual fix — make the caller `async` and await it — cannot be applied where this block stands. And the thread parks while still holding the lock, so it occupies the critical section doing no work: every other caller serialises behind an operation that is only waiting, and if the awaited task itself needs a thread the pool has run out of, they wait forever. Do the async work OUTSIDE the critical section: take the lock only to read the shared state, release it, await the call, then re-take the lock to publish the result — re-checking on re-entry whether another caller won the race and, if so, discarding your result rather than overwriting theirs. Where the critical section genuinely has to span the async call, `lock` is the wrong primitive: use an async-aware one (`SemaphoreSlim` with `await WaitAsync()`) so waiters yield their thread instead of parking it. — src/Orleans.Reminders/ReminderService/LocalReminderService.cs:551
  • `SemaphoreSlim.Wait` parks the thread while it queues for the semaphore. `await semaphore.WaitAsync(…)` yields the thread instead. — src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:511

What to do

  • Sync-over-async (deadlock risk) through `.Result`
X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness6.7 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `MembershipTableTestFixture` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializationGate` itself (line 31), which makes that instance its own. But `_initializationGate` is named in none of the methods the disposal search covered: `DisposeAsync` (line 399), `DisposeAsync` (line 401), `DisposeAsync` (line 399), `DisposeAsync` (line 401), `CompleteDisposalAsync` (line 431), `ObserveLateCleanupFailureAsync` (line 460) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializationGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Clustering.TestKit/MembershipTableTestFixture.cs:31
  • `task` is a `Task`, which implements `IDisposable`, and it is created here (line 154). Every use of it in `StartClosing` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Core/Networking/Connection.cs:154
  • `TlsMessageTransport` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_networkTransportStream` itself (line 24), which makes that instance its own. But `_networkTransportStream` is named in none of the methods the disposal search covered: `DisposeAsync` (line 209), `CloseAsync` (line 98) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_networkTransportStream?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Core/Networking/Transport/Security/TlsMessageTransport.cs:24
  • `JobShard` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_mutationLock` itself (line 158), which makes that instance its own. But `_mutationLock` is named in none of the methods the disposal search covered: `DisposeAsync` (line 389) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_mutationLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.DurableJobs/JobShard.cs:158
  • `_stateManager` is never created by `JournaledJobShard` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 252). Its declared type `IJournaledStateManager` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Orleans.DurableJobs/JournaledJobShard.cs:252
  • `StatelessWorkerGrainContext` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_inspectionTimer` itself (line 38), which makes that instance its own. But `_inspectionTimer` is named in none of the methods the disposal search covered: `DisposeAsync` (line 107), `EnqueueWorkItem` (line 113) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_inspectionTimer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:38
  • `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 335). Every use of it in `CreateWorker` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:335
  • `ClusterManifestProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_peerProbeSlots` itself (line 33), which makes that instance its own. But `_peerProbeSlots` is named in none of the methods the disposal search covered: `DisposeAsync` (line 793), `Dispose` (line 795), `StopAsync` (line 767), `DisposeAsync` (line 793) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_peerProbeSlots?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:33
  • `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Participate` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/MembershipService/ClusterMembershipService.cs:108
  • `MembershipAgent` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `cancellation` itself (line 23), which makes that instance its own. But `cancellation` is named in none of the methods the disposal search covered: `Dispose` (line 449) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`cancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — src/Orleans.Runtime/MembershipService/MembershipAgent.cs:23
  • `task` is a `Task`, which implements `IDisposable`, and it is created here (line 15). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:15
  • `task` is a `Task`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:24
  • `manager` is a `PersistentStreamPullingManager`, which implements `IDisposable`, and it is created here (line 80). Every use of it in `InitializePullingAgents` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var manager = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.Streaming/Providers/SiloStreamProviderRuntime.cs:80
  • `SiloHandle` declares a finalizer (line 73), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Orleans.TestingHost/SiloHandle.cs:73
  • `TestClusterPortAllocator` declares a finalizer (line 110), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Orleans.TestingHost/TestClusterPortAllocator.cs:110
  • `signal` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 330). Every use of it in `Acquire` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var signal = …;`), which releases it at the end of the scope on every path including a throw. — src/Orleans.TestingHost/TestClusterPortAllocator.cs:330

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation7.0 / 10Adequate✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 948/1900 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×25) — playground/ActivationRebalancing/ActivationRebalancing.Frontend/Controllers/StatsController.cs:12, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:18, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:106, …
  • This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on. (×6) — playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:38, playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:42, playground/DurableJobsJournaling/DurableJobsJournaling.Web/Program.cs:66, …
  • No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×6) — src/Orleans.Analyzers/GenerateAliasAttributesCodeFix.cs:48, src/Orleans.Core.Abstractions/Runtime/GrainRequest.cs:34, src/Orleans.Core/Async/BatchWorker.cs:95, …
  • Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one. (×2) — src/Orleans.Core/Lifecycle/ServiceLifecycleNotificationStage.cs:89, src/Orleans.Core/Messaging/ClientMessageCenter.cs:197

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard5.8 / 10Adequate✓ Tool-verified

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

  • The guard on line 73 rejects `value` and line 73 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Core.Abstractions/Manifest/MajorMinorVersion.cs:73
  • The guard on line 81 rejects `reminderName` and line 81 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Reminders/GrainReminderExtensions.cs:81
  • The guard on line 160 rejects `reminderName` and line 160 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Reminders/GrainReminderExtensions.cs:160
  • The guard on line 275 rejects `assembly` and line 277 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(assembly)` is true of a value that is NOT null: it is satisfied by an EMPTY `assembly`, and on that path `assembly` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Serialization/TypeSystem/TypeSpec.cs:277
  • The guard on line 378 rejects `value` and line 380 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Serialization/TypeSystem/TypeSpec.cs:380
  • The guard on line 31 rejects `name` and line 33 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/GrainStreamingExtensions.cs:33
  • The guard on line 61 rejects `name` and line 63 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/GrainStreamingExtensions.cs:63
  • The guard on line 109 rejects `name` and line 109 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:109
  • The guard on line 65 rejects `strProviderName` and line 67 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(strProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `strProviderName`, and on that path `strProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:67
  • The guard on line 41 rejects `batchContainers` and line 43 reports that rejection as `ArgumentNullException` — but the condition's own test `!batchContainers.Any()` is true of a value that is NOT null: it is satisfied by an EMPTY `batchContainers`, and on that path `batchContainers` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Orleans.Streaming/QueueAdapters/BatchContainerBatch.cs:43
  • The guard on line 43 rejects `invariantName` and line 45 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:45
  • The guard on line 105 rejects `invariantName` and line 107 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:107
  • The guard on line 110 rejects `connectionString` and line 112 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AdoNet/Shared/Storage/DbConnectionFactory.cs:112
  • The guard on line 78 rejects `dataConnectionString` and line 78 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(dataConnectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `dataConnectionString`, and on that path `dataConnectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:78
  • The guard on line 35 rejects `serviceId` and line 35 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapter.cs:35
  • The guard on line 34 rejects `serviceId` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapterReceiver.cs:34
  • The guard on line 128 rejects `connectionString` and line 128 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Shared/Storage/AzureStorageOperationOptions.cs:128
  • The guard on line 77 rejects `connectionString` and line 77 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamOptions.cs:77
  • The guard on line 34 rejects `clusterId` and line 36 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(clusterId)` is true of a value that is NOT null: it is satisfied by an EMPTY `clusterId`, and on that path `clusterId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:36
  • The guard on line 102 rejects `streamProviderName` and line 104 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(streamProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `streamProviderName`, and on that path `streamProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:104

What to do

  • Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped3.5 / 10Weak✓ Tool-verified

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

  • `svg` is text this program did not author, and it is written into the text of an element through `dangerouslySetInnerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:284

What to do

  • Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling6.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×24) — src/Orleans.Core.Abstractions/Utils/Utils.cs:204, src/Orleans.Core.Abstractions/Utils/Utils.cs:241, src/Orleans.Core.Abstractions/Utils/Utils.cs:256, …
  • `catch (OverflowException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:388
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else). (×13) — src/Orleans.Core/Async/AsyncLock.cs:111, src/Orleans.Core/Networking/ConnectionManager.cs:336, src/Orleans.Core/Networking/ConnectionManager.cs:371, …
  • `catch (Exception) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/Orleans.Runtime/MembershipService/UnknownSiloStatusCache.cs:114
  • `catch (ObjectDisposedException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/Orleans.Serialization/Invocation/Pools/ConcurrentObjectPool.cs:52

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.

Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.

X4 · Structured logging5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×16) — playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:34, playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:35, playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:105, …

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types8.7 / 10Strong✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 209/210 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
  • ~1.5 `!` suppressions per 1k syntax nodes — 1892 suppression(s) across the 1221106 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

WCAG coverage — what static analysis assessed

Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC4 · Keyboard semantics2.1.1, 2.4.3Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only
AC7 · A11y enforcementenforcement — no page criterionEnforcement posture (process)

Not statically assessed — these 40 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health67%AdequateAcceptable, with room to improve.
Architecture71%StrongSolid.
Maturity71%StrongSolid.
Readiness58%Adequate — gated by D13, P7Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security62%Adequate — gated by D29, D36, C1Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Event-Driven100%ExemplaryStrongest area.
Accessibility44%Weak — gated by AC4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance78%StrongSolid.
Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • P12 CI test-gate honesty — 3 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 15 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 29 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AX4 Dependency direction — not applicable to a CQRS architecture (the inward-dependency rule is for layered/clean styles)
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Aspire AppHost did not expose a crawlable HTTP endpoint in time (or only the dashboard) — no runtime evidence This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • D11 Test Reliability — Test reliability not measured — polyglot suite, one half not re-run
  • D12 Dependency Hygiene — Dependency Hygiene not included (time budget)
  • D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
  • D25 ADR Conformance — no ADRs to check
  • D32 Data Compliance (PII/GDPR) — 360 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — IL not measured — the target did not build
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage NOT MEASURED: the .NET half could not be measured — the repository runs its tests on Microsoft.Testing.Platform and wires up no coverage extension for it; the JavaScript/TypeScript half could not be measured — docs/site/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
  • DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 10 strongly-typed id(s); 33 value object(s)
  • ED2 Event/command shape — no command-shaped messages detected — single-handler-per-command check not applicable
  • ED3 Event naming — no domain or integration events detected — event-naming check not applicable
  • ES1 Event Sourcing — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 projection(s))
  • P8 Schema migrations — no EF Core usage detected
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
  • R4 Test Coverage — 1 test file(s) reach none of 38 production file(s) via imports — exercised outside the JS import graph (integration/bundled), not import-reachable
  • R5 Dependency Freshness — `npm outdated` failed (E403: 403 Forbidden - GET https://packagefeedproxy.microsoft.io/npm/@astrojs%2fmarkdown-remark) — dependency freshness not measured; JS/npm CVEs are scored in D30 (Dependency Vulnerabilities), which answers every ecosystem
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 240 finding(s)
D17 · Explicit Debt · WriteOnlyPrivateField · ×98
  • WriteOnlyPrivateField docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/GrainExamples.cs:18 — private IPersistentState<CartState> _cart — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/grains/snippets/timers/TimerExamples.cs:10 — private IGrainTimer? _timer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/grains/snippets/timers/TimerExamples.cs:40 — private IGrainTimer? _timer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/migration/snippets/Orleans10MigrationExamples.cs:62 — private IGrainTimer? _timer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/snippets/compiled/Grains/WorkersAndTimersSnippets.cs:58 — private IGrainTimer? _timer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/host/snippets/ClusterClientHostedService.cs:8 — private IClusterClient _client — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/snippets/compiled/Grains/GeneralSnippets.cs:40 — private Item? _cachedItem — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/snippets/compiled/Grains/GeneralSnippets.cs:41 — private int _lastCompressedSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField docs/site/src/content/docs/snippets/compiled/Grains/GrainSnippets.cs:243 — private IDeviceConnection? _connection — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField samples/Deployment/AzureContainerApps/Clients.WorkerService/Worker.cs:8 — private ILogger<Worker> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField samples/TicTacToe/Grains/GameGrain.cs:18 — private Guid _winnerId — assigned 2 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField samples/TicTacToe/Grains/GameGrain.cs:19 — private Guid _loserId — assigned 2 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField samples/Voting/Pages/Error.cshtml.cs:15 — private ILogger<ErrorModel> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisAdapterFactory.cs:31 — private ILogger<KinesisAdapterFactory> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:44 — private string[] InsertStatisticsMultiupdateColumns — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:184 — private ObservableGauge<int>? _activationCount — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:191 — private ObservableGauge<int>? _activationWorkingSet — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ClientInstruments.cs:8 — private ObservableGauge<int>? _connectedGatewayCount — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:8 — private ObservableGauge<int>? _ringSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:59 — private ObservableGauge<int>? _ringSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:9 — private ObservableGauge<float>? _myRangeRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:10 — private ObservableGauge<float>? _averageRingPercentage — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:43 — private ObservableGauge<int>? _directoryPartitionSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:49 — private ObservableGauge<int> _cacheSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:65 — private ObservableGauge<long>? _myPortionRingDistance — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • + 73 more in this group — see findings.md.
D17 · Explicit Debt · EmptyCatchBlock · ×66
  • EmptyCatchBlock samples/Chirper/Chirper.Grains/ChirperAccount.cs:231 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock samples/GPSTracker/GPSTracker.Service/HubListUpdater.cs:57 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock samples/Voting/Data/PollService.PollWatcherSubscription.cs:39 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock samples/Voting/Data/PollService.PollWatcherSubscription.cs:62 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock samples/Voting/Helpers/ObserverManager.cs:23 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs:144 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:180 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:111 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:125 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/DashboardHost.cs:148 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/GrainProfilerFilter.cs:82 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs:371 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs:381 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/TraceWriter.cs:44 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Dashboard/Orleans.Dashboard/Implementation/TraceWriter.cs:59 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs:204 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs:241 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core.Abstractions/Utils/Utils.cs:256 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Async/AsyncLock.cs:111 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Async/TaskExtensions.cs:60 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Caching/ConcurrentLruCache.cs:1056 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Lifecycle/LifecycleSubject.cs:75 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Networking/ConnectionManager.cs:336 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Networking/ConnectionManager.cs:371 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • EmptyCatchBlock src/Orleans.Core/Networking/Transport/Sockets/SocketExtensions.cs:62 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
  • + 41 more in this group — see findings.md.
D17 · Explicit Debt · NoWarnInCsproj · ×11
  • NoWarnInCsproj — 10 warning codes suppressed in one element src/Orleans.Serialization/Orleans.Serialization.csproj:18 — A single <NoWarn> suppresses 10 warning codes (IL2026;IL2055;IL2057;IL2060;IL2071;IL2077;IL2090;IL2096;IL3050;IL4000) in one stroke — one team-wide decision, not 10 independent debts. Review the set centrally rather than code-by-code; each code you can re-enable is one less blanket suppression. (Every code still counts toward the score and metrics.)
  • NoWarnInCsproj templates/Microsoft.Orleans.Templates/Microsoft.Orleans.Templates.csproj:53 — NU5128 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
  • NoWarnInCsproj src/Orleans.Sdk/Orleans.Sdk.csproj:14 — MSB3277 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
  • NoWarnInCsproj src/Orleans.Analyzers/Orleans.Analyzers.csproj:9 — RS1038 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj src/Orleans.Analyzers.Contracts/Orleans.Analyzers.Contracts.csproj:18 — RS1038 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj test/Grains/TestInternalGrains/TestInternalGrains.csproj:6 — 618 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj test/Grains/TestGrains/TestGrains.csproj:6 — 618 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj src/AdoNet/Orleans.GrainDirectory.AdoNet/Orleans.GrainDirectory.AdoNet.csproj:15 — CA2007 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj samples/DurableJobsMigration/DurableJobsMigration/DurableJobsMigration.csproj:8 — ORLEANSEXP003 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj docs/tools/PackageJsonGenerator/PackageJsonGenerator.csproj:7 — CS1570 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj test/Directory.Build.props:13 — FS2003 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
AX3 · Project dependency cycles · Namespace dependency cycle · ×8
  • Namespace dependency cycle src/Orleans.BroadcastChannel/BroadcastChannelProvider.cs:5 — The namespaces Orleans.BroadcastChannel ↔ Orleans.BroadcastChannel.SubscriberTable depend on each other. The lightest dependency in the cycle is Orleans.BroadcastChannel → Orleans.BroadcastChannel.SubscriberTable (Orleans.BroadcastChannel.BroadcastChannelProvider → Orleans.BroadcastChannel.SubscriberTable.ImplicitChannelSubscriberTable, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/Orleans.Core/Caching/Internal/CacheDebugView.cs:10 — The namespaces Orleans.Caching ↔ Orleans.Caching.Internal depend on each other. The lightest dependency in the cycle is Orleans.Caching.Internal → Orleans.Caching (Orleans.Caching.Internal.CacheDebugView → Orleans.Caching.ConcurrentLruCache, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/Azure/Orleans.Clustering.Cosmos/Models/SiloEntity.cs:5 — The namespaces Orleans.Clustering.Cosmos ↔ Orleans.Clustering.Cosmos.Models depend on each other. The lightest dependency in the cycle is Orleans.Clustering.Cosmos.Models → Orleans.Clustering.Cosmos (Orleans.Clustering.Cosmos.Models.SiloEntity → Orleans.Clustering.Cosmos.BaseClusterEntity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/AdoNet/Orleans.GrainDirectory.AdoNet/AdoNetGrainDirectory.cs:3 — The namespaces Orleans.GrainDirectory.AdoNet ↔ Orleans.GrainDirectory.AdoNet.Storage depend on each other. The lightest dependency in the cycle is Orleans.GrainDirectory.AdoNet → Orleans.GrainDirectory.AdoNet.Storage (Orleans.GrainDirectory.AdoNet.AdoNetGrainDirectory → Orleans.GrainDirectory.AdoNet.Storage.RelationalOrleansQueries, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:10 — The namespaces Orleans ↔ Orleans.AzureUtils ↔ Orleans.ClientObservers ↔ Orleans.Clustering.DynamoDB ↔ Orleans.CodeGeneration ↔ Orleans.Configuration ↔ Orleans.Connections.Transport ↔ Orleans.Connections.Transport.Security ↔ Orleans.Connections.Transport.Streams ↔ Orleans.Core ↔ Orleans.Core.Diagnostics ↔ Orleans.DurableJobs ↔ Orleans.GrainDirectory ↔ Orleans.GrainDirectory.AzureStorage ↔ Orleans.GrainDirectory.Firestore ↔ Orleans.GrainReferences ↔ Orleans.Hosting ↔ Orleans.Hosting.Kubernetes ↔ Orleans.Internal ↔ Orleans.Journaling ↔ Orleans.Messaging ↔ Orleans.Metadata ↔ Orleans.Persistence ↔ Orleans.Persistence.Firestore ↔ Orleans.Placement ↔ Orleans.Placement.Repartitioning ↔ Orleans.Providers ↔ Orleans.Providers.Streams.Common ↔ Orleans.Providers.Streams.Generator ↔ Orleans.Reminders.DynamoDB ↔ Orleans.Reminders.Firestore ↔ Orleans.Runtime ↔ Orleans.Runtime.ConsistentRing ↔ Orleans.Runtime.Diagnostics ↔ Orleans.Runtime.GrainDirectory ↔ Orleans.Runtime.MembershipService ↔ Orleans.Runtime.MembershipService.SiloMetadata ↔ Orleans.Runtime.Messaging ↔ Orleans.Runtime.Placement ↔ Orleans.Runtime.Placement.Filtering ↔ Orleans.Runtime.Providers ↔ Orleans.Runtime.Scheduler ↔ Orleans.Runtime.Utilities ↔ Orleans.Runtime.Versions ↔ Orleans.Runtime.Versions.Compatibility ↔ Orleans.Runtime.Versions.Selector ↔ Orleans.Serialization ↔ Orleans.Serialization.Buffers ↔ Orleans.Serialization.Buffers.Adaptors ↔ Orleans.Serialization.Cloning ↔ Orleans.Serialization.Codecs ↔ Orleans.Serialization.Configuration ↔ Orleans.Serialization.Invocation ↔ Orleans.Serialization.Serializers ↔ Orleans.Serialization.Session ↔ Orleans.Serialization.TypeSystem ↔ Orleans.Services ↔ Orleans.Statistics ↔ Orleans.Storage ↔ Orleans.Streaming.EventHubs ↔ Orleans.Streaming.Kinesis ↔ Orleans.Streaming.SQS.Streams ↔ Orleans.Streams ↔ Orleans.Streams.Core ↔ Orleans.Streams.Filtering ↔ Orleans.Timers ↔ Orleans.Transactions ↔ Orleans.Transactions.Abstractions ↔ Orleans.Transactions.AzureStorage ↔ Orleans.Transactions.Diagnostics ↔ Orleans.Transactions.State depend on each other. The lightest dependency in the cycle is Orleans → Orleans.ClientObservers (Orleans.OutsideRuntimeClient → Orleans.ClientObservers.ClientGatewayObserver, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/Dashboard/Orleans.Dashboard/Implementation/SiloGrainService.cs:16 — The namespaces Orleans.Dashboard ↔ Orleans.Dashboard.Implementation ↔ Orleans.Dashboard.Metrics depend on each other. The lightest dependency in the cycle is Orleans.Dashboard.Implementation → Orleans.Dashboard (Orleans.Dashboard.Implementation.SiloGrainService → Orleans.Dashboard.DashboardOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/Azure/Orleans.Reminders.Cosmos/CosmosReminderTable.cs:3 — The namespaces Orleans.Reminders.Cosmos ↔ Orleans.Reminders.Cosmos.Models depend on each other. The lightest dependency in the cycle is Orleans.Reminders.Cosmos → Orleans.Reminders.Cosmos.Models (Orleans.Reminders.Cosmos.CosmosReminderTable → Orleans.Reminders.Cosmos.Models.ReminderEntity, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:23 — The namespaces Orleans.Streaming.AdoNet ↔ Orleans.Streaming.AdoNet.Storage depend on each other. The lightest dependency in the cycle is Orleans.Streaming.AdoNet.Storage → Orleans.Streaming.AdoNet (Orleans.Streaming.AdoNet.Storage.RelationalOrleansQueries → Orleans.Streaming.AdoNet.AdoNetStreamConfirmation, 4 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
AC2 · Forms & labels · <input> without a programmatic label · ×7
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:109 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:119 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:130 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:140 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:150 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:79 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label REDACTED:109 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label htmlFor>, a wrapping <label>, or aria-label.
D10 · Test Quality · No assertions (empty test) · ×7
  • No assertions (empty test): RemindersTable_MySql_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/MySqlRemindersTableTests.cs:59 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_PostgreSql_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/PostgreSqlRemindersTableTests.cs:57 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_SqlServer_Init test/Extensions/Orleans.AdoNet.Tests/Reminders/SqlServerRemindersTableTests.cs:58 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_AWS_Init test/Extensions/Orleans.AWS.Tests/Reminder/DynamoDBRemindersTableTests.cs:107 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_Azure_Init test/Extensions/Orleans.Azure.Tests/AzureRemindersTableTests.cs:55 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_Cosmos_Init test/Extensions/Orleans.Cosmos.Tests/CosmosRemindersTableTests.cs:55 — Test method has an empty body — it asserts nothing and exercises no code.
  • No assertions (empty test): RemindersTable_Redis_Init test/Extensions/Orleans.Redis.Tests/Reminders/RedisReminderTableTests.cs:120 — Test method has an empty body — it asserts nothing and exercises no code.
D30 · Dependency Vulnerabilities · High CVE · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC4 · Keyboard semantics · Click handler on a non-interactive <th> · ×5
  • Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:178 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
  • Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:189 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
  • Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:203 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
  • Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:217 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
  • Click handler on a non-interactive <th> src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:231 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
AX1 · Captive dependencies · Captive dependency · ×4
  • Captive dependency: singleton SiloHostedService captures transient IConfigurationValidator src/Orleans.Runtime/Hosting/SiloHostedService.cs:17 — `SiloHostedService` is registered as a SINGLETON but its constructor takes `IEnumerable configurationValidators`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IConfigurationValidator` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton DhtGrainLocator captures scoped IGrainContext src/Orleans.Runtime/GrainDirectory/DhtGrainLocator.cs:29 — `DhtGrainLocator` is registered as a SINGLETON but its constructor takes `IGrainContext grainContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGrainContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton PlayerWatcherHostedService captures transient IGameObserver samples/Presence/src/PlayerWatcher/PlayerWatcherHostedService.cs:19 — `PlayerWatcherHostedService` is registered as a SINGLETON but its constructor takes `IGameObserver observer`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IGameObserver` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton StockWorker captures transient StockClient docs/site/src/content/docs/streaming/snippets/broadcastchannel/BroadcastChannel.Silo/Services/StockWorker.cs:16 — `StockWorker` is registered as a SINGLETON but its constructor takes `StockClient stockClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `StockClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
D13 · REDACTED Scanning · Leaked secret · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · High secret · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · FileScopedPragmaDisable · ×3
  • FileScopedPragmaDisable docs/site/src/content/docs/snippets/compiled/Grains/JournalingSnippets.cs:8 — #pragma warning disable ORLEANSEXP005 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
  • FileScopedPragmaDisable test/Orleans.Core.Tests/DurableJobs/DurableJobsOptionsTests.cs:15 — #pragma warning disable ORLEANSEXP005 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
  • FileScopedPragmaDisable test/Orleans.Core.Tests/DurableJobs/LocalDurableJobManagerTests.cs:2 — #pragma warning disable ORLEANSEXP005 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
AX8 · Test isolation · Production project references a test project · ×2
  • Production project references a test project: Orleans.Connections.Security.Tests → TestExtensions test/Orleans.Connections.Security.Tests/Orleans.Connections.Security.Tests.csproj:14 — `Orleans.Connections.Security.Tests` (production) references the test project `TestExtensions`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference.
  • Production project references a test project: Orleans.Dashboard.UnitTests → TestExtensions test/Orleans.Dashboard.Tests/Orleans.Dashboard.UnitTests/Orleans.Dashboard.UnitTests.csproj:15 — `Orleans.Dashboard.UnitTests` (production) references the test project `TestExtensions`. Production must never depend on test code — it pulls a unit-test framework and test fixtures into the shipped product and inverts the only correct direction (tests depend on production, never the reverse). Move any shared helper into a production support library, or invert the reference.
D28 · Secrets (history) · REDACTED · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · <select> without a programmatic label · ×1
  • <select> without a programmatic label src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:69 — This control has no associated label. Add a <label htmlFor> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC3 · Page structure · <html> without a lang · ×1
  • <html> without a lang src/Dashboard/Orleans.Dashboard.App/index.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
AC3 · Page structure · Viewport restricts zoom · ×1
  • Viewport restricts zoom src/Dashboard/Orleans.Dashboard.App/index.html:7 — user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
D17 · Explicit Debt · NoWarnInCsproj repeated across 13 files · ×1
  • NoWarnInCsproj repeated across 13 files test/Orleans.Journaling.Tests/Orleans.Journaling.Tests.csproj:11 — The identical NoWarnInCsproj (`ORLEANSEXP005`) appears in 13 files (13 occurrences) — a single repo-wide policy (e.g. a Directory.Build.props decision or an idiomatic suppression), not 13 independent debts. Decide it once centrally rather than file-by-file. (Every occurrence still counts toward the score and metrics.)
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Critical vulnerability · ×1
  • REDACTED
D34 · Knowledge Freshness · Orphaned knowledge · ×1
  • Orphaned knowledge src/AdoNet/Shared/Storage/DbStoredQueries.cs:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
X1 · Async correctness · Blocking wait while holding a `lock` · ×1
  • Blocking wait while holding a `lock` src/Orleans.Reminders/ReminderService/LocalReminderService.cs:551 — This blocks on a Task **while holding a `lock`**, which is worse than an ordinary sync-over-async in two ways. `await` is illegal inside a `lock` body, so the usual fix — make the caller `async` and await it — cannot be applied where this block stands. And the thread parks while still holding the lock, so it occupies the critical section doing no work: every other caller serialises behind an operation that is only waiting, and if the awaited task itself needs a thread the pool has run out of, they wait forever. Do the async work OUTSIDE the critical section: take the lock only to read the shared state, release it, await the call, then re-take the lock to publish the result — re-checking on re-entry whether another caller won the race and, if so, discarding your result rather than overwriting theirs. Where the critical section genuinely has to span the async call, `lock` is the wrong primitive: use an async-aware one (`SemaphoreSlim` with `await WaitAsync()`) so waiters yield their thread instead of parking it.
Serious — 1715 finding(s)
D3 · God Classes · TooManyMethods · ×65
  • TooManyMethods: ActivationData src/Orleans.Runtime/Catalog/ActivationData.cs — TooManyMethods — 1474 significant lines (blank, comment-only and punctuation-only lines excluded), 125 methods, declared across 2 files: Catalog/ActivationData.cs (123), Catalog/ActivationData.Migration.cs (2). The bar is 30 methods; this is 95 over it, 4.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LocalReminderService src/Orleans.Reminders/ReminderService/LocalReminderService.cs — TooManyMethods — 773 significant lines (blank, comment-only and punctuation-only lines excluded), 101 methods. The bar is 30 methods; this is 71 over it, 3.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GrainDirectoryPartition src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs — TooManyMethods — 927 significant lines (blank, comment-only and punctuation-only lines excluded), 89 methods, declared across 2 files: GrainDirectory/GrainDirectoryPartition.cs (78), GrainDirectory/GrainDirectoryPartition.Interface.cs (11). The bar is 30 methods; this is 59 over it, 2.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MembershipTableManager src/Orleans.Runtime/MembershipService/MembershipTableManager.cs — TooManyMethods — 820 significant lines (blank, comment-only and punctuation-only lines excluded), 85 methods. The bar is 30 methods; this is 55 over it, 2.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PersistentStreamPullingAgent src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs — TooManyMethods — 1108 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. The bar is 30 methods; this is 42 over it, 2.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: S3JournalStorage src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs — TooManyMethods — 943 significant lines (blank, comment-only and punctuation-only lines excluded), 66 methods. The bar is 30 methods; this is 36 over it, 2.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LocalGrainDirectory src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs — TooManyMethods — 579 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TransactionQueue src/Orleans.Transactions/State/TransactionQueue.cs — TooManyMethods — 1004 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: InProcessTestCluster src/Orleans.TestingHost/InProcTestCluster.cs — TooManyMethods — 510 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DynamoDBStorage src/AWS/Shared/Storage/DynamoDBStorage.cs — TooManyMethods — 574 significant lines (blank, comment-only and punctuation-only lines excluded), 58 methods. The bar is 30 methods; this is 28 over it, 1.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: LocalDurableJobManager src/Orleans.DurableJobs/LocalDurableJobManager.cs — TooManyMethods — 534 significant lines (blank, comment-only and punctuation-only lines excluded), 57 methods, declared across 2 files: Orleans.DurableJobs/LocalDurableJobManager.cs (29), Orleans.DurableJobs/LocalDurableJobManager.Log.cs (28). The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GrainInterfaceVersionCodeFix src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs — TooManyMethods — 1135 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • TooManyMethods: TestCluster src/Orleans.TestingHost/TestCluster.cs — TooManyMethods — 498 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AzureTableJournalStorage src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs — TooManyMethods — 693 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CodecProvider src/Orleans.Serialization/Serializers/CodecProvider.cs — TooManyMethods — 657 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ManagementGrain src/Orleans.Runtime/Core/ManagementGrain.cs — TooManyMethods — 362 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AzureTableDataManager src/Azure/Shared/Storage/AzureTableDataManager.cs — TooManyMethods — 462 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ActivationRepartitioner src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs — TooManyMethods — 540 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods, declared across 3 files: Repartitioning/ActivationRepartitioner.cs (23), Repartitioning/ActivationRepartitioner.Log.cs (20), Repartitioning/ActivationRepartitioner.MessageSink.cs (9). The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ActivationCollector src/Orleans.Runtime/Catalog/ActivationCollector.cs — TooManyMethods — 482 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Silo src/Orleans.Runtime/Silo/Silo.cs — TooManyMethods — 358 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AzureBlobJournalStorage src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs — TooManyMethods — 643 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: JournaledStateManager src/Orleans.Journaling/JournaledStateManager.cs — TooManyMethods — 589 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DynamoDBMembershipTable src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs — TooManyMethods — 449 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PrimaryBasedLogViewAdaptor src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs — TooManyMethods — 360 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CosmosMembershipTable src/Azure/Orleans.Clustering.Cosmos/Membership/CosmosMembershipTable.cs — TooManyMethods — 388 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • + 40 more in this group — see findings.md.
D17 · Explicit Debt · TodoComment · ×50
  • TodoComment docs/site/src/content/docs/grains/snippets/timers/ReminderConfiguration.cs:14 — // TODO replace with your connection string — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment samples/Voting/Data/PollService.PollWatcherSubscription.cs:64 — // TODO: log — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment samples/Voting/Helpers/ObserverManager.cs:25 — // TODO: This should probably log. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:435 — //TODO: Note that this error message should be canonical across back-ends. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/AdoNet/Shared/Storage/DbStoredQueries.cs:217 — //TODO: This is a bit of hack way to check in the current version if there's membership data or not, but if there's a start time, there's member. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Azure/Orleans.Streaming.AzureStorage/Storage/AzureQueueDataManager.cs:415 — // TODO: pending on https://github.com/dotnet/runtime/issues/110570
  • TodoComment src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:161 — //TODO: Add a queue specific default failure handler with reasonable error reporting. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:213 — //TODO: CreateAdapter must be called first. Figure out how to safely enforce this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Analyzers/AlwaysInterleaveDiagnosticAnalyzer.cs:50 — // TODO: Check that interface inherits from IGrain — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Core.Abstractions/IDs/Legacy/LegacyGrainId.cs:381 — // TODO Get name of system/target grain + name of the grain type — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:40 — // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:56 — // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:74 — // TODO: Remove expensive interface type check — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:340 — // TODO: Remember silo addresses for pods that are restarting/terminating — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Journaling/JournaledStateManager.cs:292 — // TODO: decide whether it's best to snapshot or append. Eg, by summing the size of the most recent snapshots and the current journal length. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:301 — // TODO: make this not sux - jbragg — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Runtime/Silo/SiloControl.cs:160 — // TODO: generic type expansion — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:146 — // TODO: No support yet for DeliveryDisabled, only Stopped and Started — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Streaming/PubSub/ImplicitStreamPubSub.cs:58 — // TODO BPETIT filter data? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Streaming/QueueBalancer/LeaseBasedQueueBalancer.cs:241 — // TODO: mark for removal instead so we don't renew, and only remove leases that have not expired. - jbragg — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Transactions.TestKit.Base/Grains/RemoteCommitService.cs:38 — // TODO : Replace with more complete service implementation which: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:52 — // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:59 — // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:94 — // TODO : Add verification that commit service receive call with proper args. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Orleans.Transactions/DistributedTM/TransactionClient.cs:143 — // TODO: this should be a configurable parameter — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 25 more in this group — see findings.md.
D15 · Churn × Complexity Hotspots · Hotspot · ×47
  • Hotspot: src/Orleans.Runtime/Catalog/ActivationData.cs src/Orleans.Runtime/Catalog/ActivationData.cs:1119 — src/Orleans.Runtime/Catalog/ActivationData.cs changed 17 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 57 in ActivationData.RunMessageLoop at line 1119. 5 of those changes were fix/bug commits, and the other 12 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Catalog/ActivationData.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248 — src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs changed 18 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 40 in PersistentStreamPullingAgent.RunConsumerCursor at line 1248. 9 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Journaling/JournaledStateManager.cs src/Orleans.Journaling/JournaledStateManager.cs:187 — src/Orleans.Journaling/JournaledStateManager.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 59 in JournaledStateManager.WorkLoop at line 187. 5 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Journaling/JournaledStateManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Serialization/TypeSystem/TypeConverter.cs src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151 — src/Orleans.Serialization/TypeSystem/TypeConverter.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in TypeConverter.ConsumeMetadata at line 151. 6 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Serialization/TypeSystem/TypeConverter.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Serialization/Serializers/CodecProvider.cs src/Orleans.Serialization/Serializers/CodecProvider.cs:94 — src/Orleans.Serialization/Serializers/CodecProvider.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in CodecProvider.ConsumeMetadata at line 94. 3 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Serialization/Serializers/CodecProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22 — src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 50 in ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData at line 22. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.DurableJobs/JournaledJobShardManager.cs src/Orleans.DurableJobs/JournaledJobShardManager.cs:200 — src/Orleans.DurableJobs/JournaledJobShardManager.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in JournaledJobShardManager.TryAssignShardAsync at line 200. 5 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/JournaledJobShardManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase at line 229. 4 of those changes were fix/bug commits, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: docs/site/scripts/lib/link-audit.mjs docs/site/scripts/lib/link-audit.mjs:692 — docs/site/scripts/lib/link-audit.mjs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in link-audit.auditRenderedInternalLinks at line 692. 2 of those changes were fix/bug commits, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- docs/site/scripts/lib/link-audit.mjs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Transactions/State/TransactionQueue.cs src/Orleans.Transactions/State/TransactionQueue.cs:310 — src/Orleans.Transactions/State/TransactionQueue.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in TransactionQueue.NotifyOfAbort at line 310. 3 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Transactions/State/TransactionQueue.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389 — src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles at line 389. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Runtime/Core/InsideRuntimeClient.cs src/Orleans.Runtime/Core/InsideRuntimeClient.cs:299 — src/Orleans.Runtime/Core/InsideRuntimeClient.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in InsideRuntimeClient.Invoke at line 299. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Core/InsideRuntimeClient.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.DurableJobs/JournaledJobShard.cs src/Orleans.DurableJobs/JournaledJobShard.cs:374 — src/Orleans.DurableJobs/JournaledJobShard.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in JournaledJobShard.ProcessMutationBatchAsync at line 374. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/JournaledJobShard.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Core/Networking/ConnectionManager.cs src/Orleans.Core/Networking/ConnectionManager.cs:345 — src/Orleans.Core/Networking/ConnectionManager.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in ConnectionManager.Close at line 345. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Core/Networking/ConnectionManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502 — src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in PooledQueueCache.TryGetNextMessageWithResult at line 502. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Transactions/State/ReaderWriterLock.cs src/Orleans.Transactions/State/ReaderWriterLock.cs:66 — src/Orleans.Transactions/State/ReaderWriterLock.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in ReadWriteLock.EnterLock at line 66. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Transactions/State/ReaderWriterLock.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1670 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in GrainInterfaceVersionCodeFix.SortContractEntries at line 1670. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.CodeGenerator/MetadataGenerator.cs src/Orleans.CodeGenerator/MetadataGenerator.cs:29 — src/Orleans.CodeGenerator/MetadataGenerator.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in MetadataGenerator.GenerateIncrementalMetadata at line 29. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.CodeGenerator/MetadataGenerator.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/AWS/Shared/Storage/DynamoDBStorage.cs src/AWS/Shared/Storage/DynamoDBStorage.cs:272 — src/AWS/Shared/Storage/DynamoDBStorage.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in DynamoDBStorage.UpdateTableAsync at line 272. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/AWS/Shared/Storage/DynamoDBStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Runtime/Catalog/Catalog.cs src/Orleans.Runtime/Catalog/Catalog.cs:135 — src/Orleans.Runtime/Catalog/Catalog.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in Catalog.GetOrCreateActivation at line 135. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Catalog/Catalog.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Core/Networking/Connection.cs src/Orleans.Core/Networking/Connection.cs:293 — src/Orleans.Core/Networking/Connection.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in SendWorker.Execute at line 293. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Core/Networking/Connection.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308 — src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in Impl.AnalyzeNamedType at line 308. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Journaling/JournalingHostingExtensions.cs src/Orleans.Journaling/JournalingHostingExtensions.cs:166 — src/Orleans.Journaling/JournalingHostingExtensions.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in JournalingHostingExtensions.AddJournalStorage at line 166. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Journaling/JournalingHostingExtensions.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Orleans.Core/Runtime/InvokableObjectManager.cs src/Orleans.Core/Runtime/InvokableObjectManager.cs:533 — src/Orleans.Core/Runtime/InvokableObjectManager.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in LocalObjectData.CancelRequestAsync at line 533. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Core/Runtime/InvokableObjectManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63 — src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in RedisJournalStorageProvider.ListAsync at line 63. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • + 22 more in this group — see findings.md.
D17 · Explicit Debt · DeadPreprocessorBranch · ×47
  • DeadPreprocessorBranch docs/tools/PackageJsonGenerator/Program.cs:6 — #if LAUNCH_DEBUGGER — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Core/Caching/Internal/Padding.cs:7 — #if TARGET_ARM64 || TARGET_LOONGARCH64 — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Core/Utils/StripedMpscBuffer.cs:422 — #if TARGET_ARM64 || TARGET_LOONGARCH64 — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:250 — #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Orleans.DependencyInjection.Tests/Autofac/DependencyInjectionGrainTestsUsingAutofac.cs:11 — #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:24 — #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:35 — #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch src/Orleans.Runtime/Scheduler/ActivationTaskScheduler.cs:98 — #if EXTRA_STATS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:48 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:111 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:128 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:380 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:427 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:460 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:487 — #if DELETE_AFTER_TEST — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:371 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:416 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:731 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1094 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1100 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1107 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1158 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1260 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1422 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • DeadPreprocessorBranch test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:1482 — #if USE_GENERICS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
  • + 22 more in this group — see findings.md.
D10 · Test Quality · No assertions · ×46
  • No assertions: MembershipTable_ModelBased_GeneratedConformance test/Orleans.Core.Tests/Membership/SystemTargetMembershipTableConformanceTests.cs:36 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: MembershipTable_ModelBased_GeneratedConformance test/Orleans.Runtime.Internal.Tests/MembershipTests/MembershipTableConformanceTestsBase.cs:150 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ObserverTest_Disconnect test/Orleans.DefaultCluster.Tests/ErrorGrainTest.cs:329 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ObserverTest_Disconnect2 test/Orleans.DefaultCluster.Tests/ErrorGrainTest.cs:342 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: RandomOperations_WithInjectedFailures_MatchModel test/Orleans.Journaling.Tests/Conformance/JournalStorageConformanceTests.cs:543 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: PersistenceStorage_WriteReadWriteReadStatesInParallel test/Orleans.Journaling.Tests/S3JournalStoragePersistenceTestKitTests.cs:47 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: PersistenceStorage_ModelBasedGeneratedConformance test/Orleans.Journaling.Tests/S3JournalStoragePersistenceTestKitTests.cs:115 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: PersistenceStorage_WriteReadWriteReadStatesInParallel test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:187 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: GrainStorage_ModelBasedGeneratedConformance test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:289 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: GrainStorageWithLatency_ModelBasedGeneratedConformance test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:296 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: Oracle_ModelBasedGeneratedConformance test/Orleans.Reminders.TestKit.Tests/IdealizedReminderTableTests.cs:124 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: InMemoryReminderTable_ModelBasedGeneratedConformance test/Orleans.Reminders.TestKit.Tests/InMemoryReminderTableConformanceTests.cs:128 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_StartupReadiness test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:38 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_RegistrationHasSingleOwner test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:42 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_UpdateDoesNotRestartLocalOwner test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:46 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_RemovalReachesQuiescence test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:50 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_ExactDueRecovery test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:54 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_StaleOwnerRegistrationReconciles test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:58 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_OneSiloJoinLeaveTransfersOwnership test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:62 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderService_CleanupIsIsolated test/Orleans.Reminders.Tests/TimerTests/ReminderServiceLifecycleTestsBase.cs:66 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ConsistentRingProvider_Test1 test/Orleans.Runtime.Internal.Tests/LivenessTests/ConsistentRingProviderTests.cs:22 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ReminderTable_ModelBasedGeneratedConformance test/Orleans.Runtime.Internal.Tests/RemindersTest/ReminderTableTestsBase.cs:185 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: DisposeGrainDirectoryCacheAsync_NonDisposableCacheCompletes test/Orleans.Runtime.Tests/Directories/GrainDirectoryCacheFactoryTests.cs:202 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ActiveImplicitSubscriptionAllowsObserverReplacementWithoutToken test/Orleans.Streaming.Tests/StreamingTests/StreamSubscriptionHandleImplTests.cs:260 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: ActiveExplicitSubscriptionAllowsOlderAcknowledgedToken test/Orleans.Streaming.Tests/StreamingTests/StreamSubscriptionHandleImplTests.cs:270 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • + 21 more in this group — see findings.md.
AX2 · Stateful singletons · Stateful singleton · ×40
  • Stateful singleton: ClusterDiagnosticsService playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:7 — `ClusterDiagnosticsService` is a singleton (one shared instance) but mutates instance state outside any lock (_version; e.g. `_version` at line 25).
  • Stateful singleton: LoadDriver playground/DurableJobsJournaling/DurableJobsJournaling.Web/LoadDriver.cs:7 — `LoadDriver` is a singleton (one shared instance) but mutates instance state outside any lock (_enabled, _startedAt; e.g. `_enabled` at line 22).
  • Stateful singleton: ClientInstruments src/Orleans.Core/Diagnostics/Metrics/ClientInstruments.cs:6 — `ClientInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_connectedGatewayCount; e.g. `_connectedGatewayCount` at line 11).
  • Stateful singleton: MessagingProcessingInstruments src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:6 — `MessagingProcessingInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_activationDataAll; e.g. `_activationDataAll` at line 126).
  • Stateful singleton: EnvironmentStatisticsProvider src/Orleans.Core/Statistics/EnvironmentStatisticsProvider.cs:11 — `EnvironmentStatisticsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_maximumAvailableMemoryBytes, _availableMemoryBytes; e.g. `_maximumAvailableMemoryBytes` at line 70).
  • Stateful singleton: OutsideRuntimeClient src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:21 — `OutsideRuntimeClient` is a singleton (one shared instance) but mutates instance state outside any lock (_statusObservers, _manifestProvider, InternalGrainFactory, _cancellationManager, messageFactory, localObjects; e.g. `_statusObservers` at line 112).
  • Stateful singleton: ClientGrainContext src/Orleans.Core/Runtime/ClientGrainContext.cs:8 — `ClientGrainContext` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReference; e.g. `_grainReference` at line 25).
  • Stateful singleton: GrainFactory src/Orleans.Core/Core/GrainFactory.cs:12 — `GrainFactory` is a singleton (one shared instance) but mutates instance state outside any lock (grainReferenceRuntime; e.g. `grainReferenceRuntime` at line 38).
  • Stateful singleton: GrainReferenceActivatorProvider src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:291 — `GrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 350).
  • Stateful singleton: UntypedGrainReferenceActivatorProvider src/Orleans.Core/GrainReferences/GrainReferenceActivator.cs:106 — `UntypedGrainReferenceActivatorProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_grainReferenceRuntime; e.g. `_grainReferenceRuntime` at line 144).
  • Stateful singleton: LinearBackoffClientConnectionRetryFilter src/Orleans.Core/Core/IClientConnectionRetryFilter.cs:23 — `LinearBackoffClientConnectionRetryFilter` is a singleton (one shared instance) but mutates instance state outside any lock (_retryCount; e.g. `_retryCount` at line 40).
  • Stateful singleton: ClientMessageCenter src/Orleans.Core/Messaging/ClientMessageCenter.cs:40 — `ClientMessageCenter` is a singleton (one shared instance) but mutates instance state outside any lock (Running, messageHandler; e.g. `Running` at line 103).
  • Stateful singleton: GatewayManager src/Orleans.Core/Messaging/GatewayManager.cs:24 — `GatewayManager` is a singleton (one shared instance) but mutates instance state outside any lock (gatewayListProviderInitialized, roundRobinCounter, knownGateways, cachedLiveGateways, cachedLiveGatewaysSet, lastRefreshTime; e.g. `gatewayListProviderInitialized` at line 68).
  • Stateful singleton: ClientClusterManifestProvider src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:22 — `ClientClusterManifestProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_runTask; e.g. `_runTask` at line 77).
  • Stateful singleton: LocalDurableJobManager src/Orleans.DurableJobs/LocalDurableJobManager.cs:22 — `LocalDurableJobManager` is a singleton (one shared instance) but mutates instance state outside any lock (_startTimestamp, _listenForClusterChangesTask, _periodicCheckTask, _totalClaimedShards; e.g. `_startTimestamp` at line 220).
  • Stateful singleton: LocalReminderService src/Orleans.Reminders/ReminderService/LocalReminderService.cs:19 — `LocalReminderService` is a singleton (one shared instance) but mutates instance state outside any lock (localTableSequence, localReminders, runTask, initialReadCallCount; e.g. `localTableSequence` at line 395).
  • Stateful singleton: ReminderRegistry src/Orleans.Reminders/ReminderService/ReminderRegistry.cs:13 — `ReminderRegistry` is a singleton (one shared instance) but mutates instance state outside any lock (serviceProvider; e.g. `serviceProvider` at line 107).
  • Stateful singleton: InMemoryReminderTable src/Orleans.Reminders/ReminderService/InMemoryReminderTable.cs:7 — `InMemoryReminderTable` is a singleton (one shared instance) but mutates instance state outside any lock (isAvailable; e.g. `isAvailable` at line 88).
  • Stateful singleton: ActivationRebalancerMonitor src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerMonitor.cs:16 — `ActivationRebalancerMonitor` is a singleton (one shared instance) but mutates instance state outside any lock (_monitorTimer, _latestReport, _lastHeartbeatTimestamp, _statusListeners; e.g. `_monitorTimer` at line 82).
  • Stateful singleton: ActivationRepartitioner src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:24 — `ActivationRepartitioner` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCountOffset, _currentExchangeSilo, _enableMessageSampling, _processPendingEdgesTask; e.g. `_activationCountOffset` at line 163).
  • Stateful singleton: SystemTargetBasedMembershipTable src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:14 — `SystemTargetBasedMembershipTable` is a singleton (one shared instance) but mutates instance state outside any lock (grain, membershipManager; e.g. `grain` at line 38).
  • Stateful singleton: MembershipTableSystemTarget src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:208 — `MembershipTableSystemTarget` is a singleton (one shared instance) but mutates instance state outside any lock (table; e.g. `table` at line 256).
  • Stateful singleton: ConsistentRingInstruments src/Orleans.Core/Diagnostics/Metrics/ConsistentRingInstruments.cs:6 — `ConsistentRingInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_ringSize, _myRangeRingPercentage, _averageRingPercentage; e.g. `_ringSize` at line 14).
  • Stateful singleton: CatalogInstruments src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:9 — `CatalogInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_activationCount, _activationWorkingSet; e.g. `_activationCount` at line 188).
  • Stateful singleton: DirectoryInstruments src/Orleans.Core/Diagnostics/Metrics/DirectoryInstruments.cs:9 — `DirectoryInstruments` is a singleton (one shared instance) but mutates instance state outside any lock (_directoryPartitionSize, _ringSize, _myPortionRingDistance, _myPortionRingPercentage, _myPortionAverageRingPercentage; e.g. `_directoryPartitionSize` at line 46).
  • + 15 more in this group — see findings.md.
PF3 · Async & latency hygiene · Sync-over-async blocking · ×40
  • Sync-over-async blocking — 42 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:655 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:752 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:801 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Async/TaskExtensions.cs:24 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Async/TaskExtensions.cs:213 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:275 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Networking/ConnectionFactory.cs:51 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:59 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:68 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:101 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:278 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Journaling/JournaledStateManager.cs:1100 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Reminders.TestKit/ReminderTableModelBasedTestRunner.cs:161 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Reminders.TestKit/ReminderTableModelBasedTestRunner.cs:178 — `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Reminders/ReminderService/LocalReminderService.cs:551 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Reminders/ReminderService/LocalReminderService.cs:957 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/Catalog/ActivationData.cs:983 — `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:120 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:83 — `notification.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/GrainDirectory/DirectoryMembershipService.cs:32 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:797 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/MembershipService/MembershipAgent.cs:236 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/Placement/PlacementService.cs:491 — `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • Sync-over-async blocking src/Orleans.Runtime/Silo/Silo.cs:504 — `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
  • + 15 more in this group — see findings.md.
D17 · Explicit Debt · CommentedOutCode · ×37
  • CommentedOutCode playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:75 — 5 consecutive commented-code lines
  • CommentedOutCode samples/JournaledTodoList/JournaledTodoList.ServiceDefaults/Extensions.cs:86 — 5 consecutive commented-code lines
  • CommentedOutCode test/Extensions/Orleans.Redis.Tests/Persistence/RedisPersistenceGrainTests.cs:103 — 5 consecutive commented-code lines
  • CommentedOutCode test/Grains/TestGrains/ActivationCancellationTestGrains.cs:176 — 5 consecutive commented-code lines
  • CommentedOutCode test/Grains/TestInternalGrains/StreamReliabilityTestGrains.cs:338 — 5 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Core.Tests/ManagementAgentTests.cs:33 — 5 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Serialization.UnitTests/RecordSerializationTests.cs:293 — 5 consecutive commented-code lines
  • CommentedOutCode src/Orleans.CodeGenerator/InvokableGenerator.cs:444 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Runtime.Internal.Tests/General/ConsistentRingProviderTests_Silo.cs:257 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:694 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:706 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:718 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:728 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:738 — 8 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:748 — 8 consecutive commented-code lines
  • CommentedOutCode src/Orleans.Transactions/State/TransactionQueue.cs:141 — 4 consecutive commented-code lines
  • CommentedOutCode test/Grains/TestInternalGrains/StreamReliabilityTestGrains.cs:325 — 4 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Runtime.Internal.Tests/StorageTests/PersistenceGrainTests.cs:1388 — 4 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Runtime.Tests/MembershipTests/LivenessTests.cs:228 — 4 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:656 — 4 consecutive commented-code lines
  • CommentedOutCode test/Benchmarks/TopK/TopKBenchmark.cs:86 — 3 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs:117 — 3 consecutive commented-code lines
  • CommentedOutCode test/Orleans.Streaming.Tests/StreamingTests/SingleStreamTestRunner.cs:363 — 3 consecutive commented-code lines
  • CommentedOutCode test/Benchmarks/TopK/TopKBenchmark.cs:96 — 7 consecutive commented-code lines
  • CommentedOutCode test/Benchmarks/TopK/TopKBenchmark.cs:108 — 7 consecutive commented-code lines
  • + 12 more in this group — see findings.md.
D3 · God Classes · FileTooLong · ×37
  • FileTooLong: Catalog/ActivationData.cs src/Orleans.Runtime/Catalog/ActivationData.cs — FileTooLong — 1573 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1073 over it, 3.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: lib/docfx.mjs docs/site/scripts/lib/docfx.mjs — FileTooLong — 1308 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 808 over it, 2.62× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs — FileTooLong — 1219 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 719 over it, 2.44× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: PersistentStreams/PersistentStreamPullingAgent.cs src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs — FileTooLong — 1150 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 650 over it, 2.30× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: ReminderService/LocalReminderService.cs src/Orleans.Reminders/ReminderService/LocalReminderService.cs — FileTooLong — 1041 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 541 over it, 2.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: State/TransactionQueue.cs src/Orleans.Transactions/State/TransactionQueue.cs — FileTooLong — 1030 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 530 over it, 2.06× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Journaling.S3/S3JournalStorage.cs src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs — FileTooLong — 991 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 491 over it, 1.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: lib/link-audit.mjs docs/site/scripts/lib/link-audit.mjs — FileTooLong — 931 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 431 over it, 1.86× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs — FileTooLong — 912 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 412 over it, 1.82× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs — FileTooLong — 897 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 397 over it, 1.79× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Codecs/TupleCodec.cs src/Orleans.Serialization/Codecs/TupleCodec.cs — FileTooLong — 871 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 371 over it, 1.74× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: MembershipService/MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipTableManager.cs — FileTooLong — 864 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 364 over it, 1.73× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: GrainDirectory/GrainDirectoryPartition.cs src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs — FileTooLong — 835 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 335 over it, 1.67× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Diagnostics/TransactionDiagnosticEvents.cs src/Orleans.Transactions/Diagnostics/TransactionDiagnosticEvents.cs — FileTooLong — 826 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 326 over it, 1.65× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.CodeGenerator/SerializerGenerator.cs src/Orleans.CodeGenerator/SerializerGenerator.cs — FileTooLong — 808 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 308 over it, 1.62× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Serializers/CodecProvider.cs src/Orleans.Serialization/Serializers/CodecProvider.cs — FileTooLong — 796 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 296 over it, 1.59× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs — FileTooLong — 761 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 261 over it, 1.52× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: lib/source-quality.mjs docs/site/scripts/lib/source-quality.mjs — FileTooLong — 740 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 240 over it, 1.48× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Buffers/ArcBufferWriter.cs src/Orleans.Serialization/Buffers/ArcBufferWriter.cs — FileTooLong — 716 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 216 over it, 1.43× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Helpers/CanonicalModelBuilder.cs docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs — FileTooLong — 714 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 214 over it, 1.43× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs — FileTooLong — 708 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 208 over it, 1.42× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Journaling/JournaledStateManager.cs src/Orleans.Journaling/JournaledStateManager.cs — FileTooLong — 694 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 194 over it, 1.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.Serialization.FSharp/FSharpCodecs.cs src/Orleans.Serialization.FSharp/FSharpCodecs.cs — FileTooLong — 688 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 188 over it, 1.38× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Codecs/ValueTupleCodec.cs src/Orleans.Serialization/Codecs/ValueTupleCodec.cs — FileTooLong — 685 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 185 over it, 1.37× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Orleans.CodeGenerator/InvokableGenerator.cs src/Orleans.CodeGenerator/InvokableGenerator.cs — FileTooLong — 670 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 170 over it, 1.34× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • + 12 more in this group — see findings.md.
X3 · Exception handling · Swallowed exception (empty catch) · ×37
  • Swallowed exception (empty catch) src/Orleans.Core.Abstractions/Utils/Utils.cs:204 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core.Abstractions/Utils/Utils.cs:241 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core.Abstractions/Utils/Utils.cs:256 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Async/AsyncLock.cs:111 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Core/Async/TaskExtensions.cs:60 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Caching/ConcurrentLruCache.cs:1056 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Lifecycle/LifecycleSubject.cs:75 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/ConnectionManager.cs:336 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/ConnectionManager.cs:371 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/Transport/Sockets/SocketExtensions.cs:62 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/Transport/Sockets/SocketExtensions.cs:77 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:181 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:220 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Networking/Transport/Streams/StreamMessageTransport.cs:106 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Core/Timers/TimerManager.cs:286 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:157 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Runtime/Cancellation/GrainCallCancellationManager.cs:283 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1016 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1031 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1054 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:1644 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationData.cs:2761 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationDirectory.cs:80 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Catalog/ActivationDirectory.cs:104 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
  • Swallowed exception (empty catch) src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs:38 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • + 12 more in this group — see findings.md.
D17 · Explicit Debt · BarePragmaDisable · ×32
  • BarePragmaDisable docs/site/src/content/docs/snippets/compiled/Grains/PlacementSnippets.cs:87 — #pragma warning disable ORLEANSEXP001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable docs/site/src/content/docs/snippets/compiled/Grains/PlacementSnippets.cs:112 — #pragma warning disable ORLEANSEXP001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.Runtime.Internal.Tests/DependencyInjection/GenericRegistrationTests.cs:108 — #pragma warning disable ORLEANSEXP001 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable docs/site/src/content/docs/snippets/compiled/Grains/PlacementSnippets.cs:116 — #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:9 — #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.Placement.Tests/ActivationRebalancingTests/RebalancerFixture.cs:18 — #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.Placement.Tests/ActivationRebalancingTests/StatePreservationRebalancingTests.cs:193 — #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.Runtime.Internal.Tests/DependencyInjection/GenericRegistrationTests.cs:90 — #pragma warning disable ORLEANSEXP002 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable src/Orleans.Core/Core/DefaultClientServices.cs:74 — #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable src/Orleans.Core/Statistics/SiloRuntimeStatistics.cs:117 — #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:107 — #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Extensions/Orleans.Azure.Tests/Streaming/PullingAgentManagementTests.cs:51 — #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestGrainInterfaces/CodegenTestInterfaces.cs:220 — #pragma warning disable 618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable src/Orleans.Core/Networking/Transport/Security/TlsConnectionFeature.cs:25 — #pragma warning disable SYSLIB0058 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable src/Orleans.Core/Networking/Transport/Security/TlsMessageTransport.cs:168 — #pragma warning disable SYSLIB0058 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Benchmarks/Ping/ProcessPingBenchmark.cs:351 — #pragma warning disable SYSLIB0057 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.Connections.Security.Tests/CertificateCreator.cs:58 — #pragma warning disable SYSLIB0057 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Benchmarks/Serialization/Utilities/MethodResultColumn.cs:66 — #pragma warning disable CS8766 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Extensions/Orleans.DurableJobs.AzureStorage.Tests/DurableJobs/AzureStorageDurableJobsConfigurationTests.cs:13 — #pragma warning disable ORLEANSEXP005 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:278 — #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:294 — #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:371 — #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestInternalGrains/EchoTaskGrain.cs:387 — #pragma warning disable 1998 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Grains/TestInternalGrains/ReminderTestGrain2.cs:11 — #pragma warning disable 612,618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • BarePragmaDisable test/Orleans.DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs:142 — #pragma warning disable 693 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
  • + 7 more in this group — see findings.md.
D15 · Churn × Complexity Hotspots · Repeated repair · ×29
  • Repeated repair: src/Orleans.Reminders/ReminderService/LocalReminderService.cs src/Orleans.Reminders/ReminderService/LocalReminderService.cs:1406 — src/Orleans.Reminders/ReminderService/LocalReminderService.cs changed 17 times in last 90 days and 12 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 14 (its worst body is LocalReminderData.WaitForNextTick at line 1406), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(analyzers): enforce ordinal string comparisons (#11150)”; “fix(reminders): await queued startup range changes (#11132)”; “fix(reminders): order topology reconciliation admission (#11118)”; “fix(testing): separate reminder refresh barriers (#11021)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Reminders/ReminderService/LocalReminderService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:520 — src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs changed 11 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 14 (its worst body is DistributedGrainDirectory.ProcessMembershipUpdates at line 520), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): preserve default directory with named distributed registration (#11553)”; “fix(directory)!: expose immutable partition boundaries (#11425)”; “fix(directory): wait for active membership during startup (#10613)”; “fix(runtime): refresh stale empty directory views (#10625)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:672 — src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs changed 13 times in last 90 days and 7 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is GrainDirectoryPartition.TransferSnapshotAsync at line 672), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: report exact ring cardinality and cover range boundaries (#11221)”; “fix(directory): deactivate recovery duplicates (#11030)”; “fix(directory): preserve newer recovery registrations (#10533)”; “fix(directory): strengthen single-activation guarantees (#9958)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:610 — src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs changed 10 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is ZooKeeperBasedMembershipTable.CleanupRowAsync at line 610), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(zookeeper): preserve snapshot reads under contention (#11387)”; “fix(zookeeper): make membership reads sequential and resilient (#11338)”; “fix(zookeeper): preserve membership consistency (#11316)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/MembershipService/MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipTableManager.cs:724 — src/Orleans.Runtime/MembershipService/MembershipTableManager.cs changed 8 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is MembershipTableManager.GossipToOthers at line 724), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve canonical membership views (#11296)”; “fix(streaming): remove defunct stream publishers (#10532)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/MembershipService/MembershipTableManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.DurableJobs/LocalDurableJobManager.cs src/Orleans.DurableJobs/LocalDurableJobManager.cs:314 — src/Orleans.DurableJobs/LocalDurableJobManager.cs changed 7 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is LocalDurableJobManager.CancelAsync at line 314), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(durable-jobs): adopt a dead silo's shards when membership declares it dead (#11528)”; “fix(durable-jobs): retire faulted shards (#11442)”; “fix(durable-jobs): handle cancellation during shard retirement (#11441)”; “fix(durable-jobs): unregister running shards during shutdown (#11301)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.DurableJobs/LocalDurableJobManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorage.cs src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorage.cs:296 — src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorage.cs changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is AzureTableGrainStorage.ReadBinaryDataChunks at line 296), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: forward cancellation tokens in Azure Table grain storage (#11415)”; “fix(azure): validate grain storage inputs (#11139)”; “fix(build): resolve analyzer enforcement blockers (#11080)”; “fix(persistence): flow grain storage cancellation tokens (#10641)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs:172 — src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is OrleansSiloInstanceManager.DumpSiloInstanceTable at line 172), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(azure): preserve membership consistency (#11309)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(azure): use invariant clustering text (#11107)”; “fix(azure): fence paginated membership reads (#10381)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs:61 — src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is AzureBasedReminderTable.StartAsync at line 61), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(reminders): preserve cleanup failures (#11195)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”; “fix(azure): validate reminder options (#11101)”; “fix(build): resolve analyzer enforcement blockers (#11080)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Orleans.Reminders.AzureStorage/Storage/AzureBasedReminderTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Shared/Storage/AzureTableDataManager.cs src/Azure/Shared/Storage/AzureTableDataManager.cs:501 — src/Azure/Shared/Storage/AzureTableDataManager.cs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is AzureTableDataManager.DeleteTableEntriesAsync at line 501), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: forward cancellation tokens in Azure Table grain storage (#11415)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(build): resolve analyzer enforcement blockers (#11080)”; “fix(azure): fence paginated membership reads (#10381)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Shared/Storage/AzureTableDataManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:73 — src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is FirestoreMembershipTable.CleanupDefunctSiloEntriesAsync at line 73), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(firestore): preserve atomic row membership reads (#11400)”; “fix(firestore): preserve atomic membership reads (#11342)”; “fix(firestore): preserve membership consistency (#11311)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs:66 — src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is StreamConsumerData.SafeDisposeCursor at line 66), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert(streaming): revert drained-subscription checkpoint advancement (#11330)”; “fix(streaming): drain detached pulling-agent work (#11268)”; “fix(streaming): advance checkpoints past drained subscriptions (#11249)”; “fix(streaming): preserve prefetched recovery batches (#11149)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/QueueStreamDataStructures.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Journaling/IJournaledStateManager.cs src/Orleans.Journaling/IJournaledStateManager.cs:16 — src/Orleans.Journaling/IJournaledStateManager.cs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is IJournaledStateManager.DisposeAsync at line 16), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(journaling): discard pending entries after state deletion (#11552)”; “fix(journaling): serialize recovery retries and preserve persistence failures (#11326)”; “fix(journaling)!: recover failed operations in new activations (#11276)”; “fix(journaling): make snapshot commits and rollback atomic (#10681)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Journaling/IJournaledStateManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs:176 — src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is DistributedRemoteGrainDirectory.ProcessSplitPartitionRegistrationsAsync at line 176), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): preserve default directory with named distributed registration (#11553)”; “fix(directory): strengthen single-activation guarantees (#9958)”; “fix(directory): make rolling upgrade handoffs durable (#10323)”; “fix(directory): support rolling upgrades to distributed directory (#10309)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/GrainDirectory/DistributedRemoteGrainDirectory.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs:84 — src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is StreamConsumerCollection.IsInactive at line 84), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert(streaming): revert drained-subscription checkpoint advancement (#11330)”; “fix(streaming): drain detached pulling-agent work (#11268)”; “fix(streaming): advance checkpoints past drained subscriptions (#11249)”; “fix(streaming): release ADO.NET messages during queue handoff (#10574)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Streaming/PersistentStreams/StreamConsumerCollection.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:139 — src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is StatelessWorkerGrainContext.RunMessageLoop at line 139), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): migrate queued requests with activations during silo retirement (#11460)”; “fix(runtime): synchronize stateless worker status (#10968)”; “fix(runtime)!: configure grain context before construction (#10565)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Serialization/Codecs/ByteArrayCodec.cs src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:38 — src/Orleans.Serialization/Codecs/ByteArrayCodec.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is BitArrayCodec.ReadValue at line 38), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(runtime): migrate queued requests with activations during silo retirement (#11460)”; “fix(serialization): validate codec arguments (#11168)”; “fix(serialization): cap codec allocations (#10340)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Serialization/Codecs/ByteArrayCodec.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:400 — src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is AzureTableJournalStorage.ReadAsync at line 400), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(journaling): state and verify the journal storage contract (#11537)”; “fix(journaling): resolve trimming and NativeAOT warnings (#11513)”; “fix(journaling): use ordinal identifier comparisons (#11177)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs:118 — src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is RedisMembershipTable.InitializeMembershipTableCoreAsync at line 118), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(redis): require primary command routing (#11484)”; “fix(redis): preserve membership consistency (#11313)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:59 — src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is AzureBlobGrainStorage.ReadStateAsync at line 59), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: forward cancellation tokens in Azure Blob grain storage (#11411)”; “fix(azure): validate grain storage inputs (#11139)”; “fix(persistence): flow grain storage cancellation tokens (#10641)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:64 — src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 9 (its worst body is SystemTargetBasedMembershipTable.WaitForTableGrainToInit at line 64), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve core membership invariants (#11307)”; “fix(membership): preserve canonical membership views (#11296)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:186 — src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is Table.Update at line 186), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(membership): preserve core membership invariants (#11307)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Serialization.FSharp/FSharpCodecs.cs src/Orleans.Serialization.FSharp/FSharpCodecs.cs:931 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is FSharpChoiceCodec.ReadValue at line 931), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(serialization): validate codec arguments (#11168)”; “fix: define CA1815 value semantics (#11166)”; “fix(analyzers): expand CA1062 library coverage (#11160)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Serialization.FSharp/FSharpCodecs.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:121 — src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is InterfaceCollectionCodecHelpers.TryGetInterfaceTypeForCodecType at line 121), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(serialization): reuse interface collection codec metadata (#11455)”; “fix(serialization): validate codec arguments (#11168)”; “fix(serialization): defer interface collection codec dependencies (#10301)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs:271 — src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 14 (its worst body is CassandraClusteringTable.ReadConsistentAsync at line 271), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(cassandra): preserve membership consistency (#11315)”; “fix(runtime): honor membership and load cancellation lifetimes (#11237)”; “fix(analyzers): enforce ordinal string comparisons (#11150)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 14:58:47 -07:00' --until='2026-10-21 14:58:47 -07:00' --full-history --no-merges -- src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • + 4 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×28
  • Duplicated block (8 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:255 — src/Orleans.CodeGenerator/CopierGenerator.cs:255-262 | src/Orleans.CodeGenerator/SerializerGenerator.cs:394-401 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:247 — src/Orleans.Core/Core/DefaultClientServices.cs:247-254 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:555-562 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:145 — docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:145-152 | docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:266-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:145` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:275` calls `WriteString` and `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:154` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:916 — src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:916-923 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:955-962 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:916` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (8 lines × 2) src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:28 — src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:28-35 | src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:116-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:36 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:36-43 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:34-41 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:24 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:24-31 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:22-29 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Buffers/Writer.cs:379 — src/Orleans.Serialization/Buffers/Writer.cs:379-386 | src/Orleans.Serialization/Buffers/Writer.cs:408-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:379` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `uint` in one and `ulong` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:108 — src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:108-115 | src/Orleans.Serialization/Codecs/SortedListCodec.cs:116-123 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/SortedDictionaryCodec.cs:108` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1083 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1083-1090 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:924-931 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1224 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1224-1231 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1032-1039 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1443 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1443-1450 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1202-1209 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1004 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1004-1011 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1201-1208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:224 — src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:224-231 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:239-246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:224` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:237` calls `WriteField`, `Format`, `GetType` and `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:222` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:194 — src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:194-201 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:198-205 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:213 — src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:213-220 | src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterFactory.cs:337-344 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:56 — src/Orleans.Core/Core/DefaultClientServices.cs:56-64 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:80-87 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:317 — src/Orleans.Serialization/Codecs/TupleCodec.cs:317-324 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:310-317 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:317` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1109 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1109-1116 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:945-952 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1109` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1350 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1350-1357 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1140-1147 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:1350` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86 — src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86-93 | src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:115-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Reminders.Redis/Storage/RedisReminderTable.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) src/Orleans.Core/Manifest/ClientManifestProvider.cs:60 — src/Orleans.Core/Manifest/ClientManifestProvider.cs:60-67 | src/Orleans.Runtime/Manifest/SiloManifestProvider.cs:96-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:286 — src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:286-293 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:56-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:204 — src/Orleans.Runtime/Catalog/ActivationWorkingSet.cs:204-211 | src/Orleans.Runtime/Catalog/IncomingRequestMonitor.cs:54-61 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) src/Orleans.TestingHost/InProcessSiloHandle.cs:93 — src/Orleans.TestingHost/InProcessSiloHandle.cs:93-101 | src/Orleans.TestingHost/StandaloneSiloHandle.cs:302-309 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • + 3 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×27
  • MethodTooLong: JournaledStateManager.WorkLoop src/Orleans.Journaling/JournaledStateManager.cs:187 — MethodTooLong — WorkLoop runs 203 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 103 over it, 2.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:438 — MethodTooLong — TransactionWillRecoverAfterRandomSiloFailure runs 172 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 72 over it, 1.72× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: LibraryTypes.LibraryTypes(…) src/Orleans.CodeGenerator/LibraryTypes.cs:19 — MethodTooLong — LibraryTypes(…) runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ActivationData.ActivateAsync src/Orleans.Runtime/Catalog/ActivationData.cs:1881 — MethodTooLong — ActivateAsync runs 165 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 65 over it, 1.65× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22 — MethodTooLong — ExtractReferenceAssemblyData runs 162 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 62 over it, 1.62× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Silo.render src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:142 — MethodTooLong — render runs 161 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 61 over it, 1.61× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: OrleansSerializationSourceGenerator.Initialize src/Orleans.CodeGenerator/OrleansSourceGenerator.cs:34 — MethodTooLong — Initialize runs 160 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 60 over it, 1.60× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ActivationData.RunMessageLoop src/Orleans.Runtime/Catalog/ActivationData.cs:1119 — MethodTooLong — RunMessageLoop runs 159 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 59 over it, 1.59× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ServiceCollectionExtensions.MapOrleansDashboard src/Dashboard/Orleans.Dashboard/ServiceCollectionExtensions.cs:99 — MethodTooLong — MapOrleansDashboard runs 149 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 49 over it, 1.49× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SocketMessageTransport.ProcessWrites src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:532 — MethodTooLong — ProcessWrites runs 142 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 42 over it, 1.42× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PersistentStreamPullingAgent.RunConsumerCursor src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248 — MethodTooLong — RunConsumerCursor runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TransactionQueue.NotifyOfAbort src/Orleans.Transactions/State/TransactionQueue.cs:310 — MethodTooLong — NotifyOfAbort runs 133 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 33 over it, 1.33× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ShardExecutor.ExecuteJobAsync src/Orleans.DurableJobs/ShardExecutor.cs:309 — MethodTooLong — ExecuteJobAsync runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ProxyGenerator.CreateProxyMethods src/Orleans.CodeGenerator/ProxyGenerator.cs:85 — MethodTooLong — CreateProxyMethods runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Overview.render src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:85 — MethodTooLong — render runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SerializerFactoryGenerator.TryCreate src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:34 — MethodTooLong — TryCreate runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Impl.AnalyzeNamedType src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308 — MethodTooLong — AnalyzeNamedType runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229 — MethodTooLong — TransactionWillRecoverAfterTargetedPhase runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TransactionRecoveryEventObserver.TryCreateTransition src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs:335 — MethodTooLong — TryCreateTransition runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ActivationData.FinishDeactivating src/Orleans.Runtime/Catalog/ActivationData.cs:2180 — MethodTooLong — FinishDeactivating runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Identifier.IsCSharpKeyword src/Orleans.CodeGenerator/SyntaxGeneration/Identifier.cs:7 — MethodTooLong — IsCSharpKeyword runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SerializerGenerator.GenerateDeserializeMethod src/Orleans.CodeGenerator/SerializerGenerator.cs:553 — MethodTooLong — GenerateDeserializeMethod runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DynamoDBTransactionalStateStorage.Store src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144 — MethodTooLong — Store runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: InvokableBaseTypeResolver.SatisfiesConstraints src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:628 — MethodTooLong — SatisfiesConstraints runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ClusterManifestProvider.UpdateManifest src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:241 — MethodTooLong — UpdateManifest runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • + 2 more in this group — see findings.md.
D10 · Test Quality · Skipped test · ×26
  • Skipped test: AccountWithLog test/Orleans.EventSourcing.Tests/EventSourcingTests/AccountGrainTests.cs:61 — Skipped — https://github.com/dotnet/orleans/issues/5605
  • Skipped test: ElasticityTest_CatchingUp test/Orleans.Placement.Tests/General/ElasticPlacementTest.cs:43 — Skipped — https://github.com/dotnet/orleans/issues/4008
  • Skipped test: ElasticityTest_StoppingSilos test/Orleans.Placement.Tests/General/ElasticPlacementTest.cs:97 — Skipped — https://github.com/dotnet/orleans/issues/4008
  • Skipped test: ElasticityTest_AllSilosCPUTooHigh test/Orleans.Placement.Tests/General/ElasticPlacementTest.cs:142 — Skipped — https://github.com/dotnet/orleans/issues/4008
  • Skipped test: ElasticityTest_AllSilosOverloaded test/Orleans.Placement.Tests/General/ElasticPlacementTest.cs:161 — Skipped — https://github.com/dotnet/orleans/issues/4008
  • Skipped test: Reentrancy_Deadlock_2 test/Orleans.Runtime.Internal.Tests/MessageScheduling/ReentrancyTests.cs:205 — Skipped — Ignore
  • Skipped test: FanOut_Task_NonReentrant_Chain test/Orleans.Runtime.Internal.Tests/MessageScheduling/ReentrancyTests.cs:268 — Skipped — Ignore
  • Skipped test: FanOut_AC_NonReentrant_Chain test/Orleans.Runtime.Internal.Tests/MessageScheduling/ReentrancyTests.cs:304 — Skipped — Ignore
  • Skipped test: CallThatShouldHaveBeenDroppedNotExecutedTest test/Orleans.Runtime.Internal.Tests/TimeoutTests.cs:142 — Skipped — https://github.com/dotnet/orleans/issues/3995
  • Skipped test: SiloGracefulShutdown_ForwardPendingRequest test/Orleans.Runtime.Tests/Forwarding/ShutdownSiloTests.cs:83 — Skipped — https://github.com/dotnet/orleans/issues/6423
  • Skipped test: StreamingTests_Consumer_Producer_UnSubscribe test/Orleans.Streaming.Tests/StreamingTests/ProgrammaticSubscribeTests/ProgrammaticSubscribeTestsRunner.cs:69 — Skipped — https://github.com/dotnet/orleans/issues/5635
  • Skipped test: StreamingTests_Consumer_Producer_SubscribeToTwoStream_MessageWithPolymorphism test/Orleans.Streaming.Tests/StreamingTests/ProgrammaticSubscribeTests/ProgrammaticSubscribeTestsRunner.cs:179 — Skipped — https://github.com/dotnet/orleans/issues/5650
  • Skipped test: SingleSendBatchConsume test/Orleans.Streaming.Tests/StreamingTests/StreamBatchingTestRunner.cs:23 — Skipped — https://github.com/dotnet/orleans/issues/5649
  • Skipped test: BatchSendBatchConsume test/Orleans.Streaming.Tests/StreamingTests/StreamBatchingTestRunner.cs:63 — Skipped — https://github.com/dotnet/orleans/issues/5632
  • Skipped test: PersistentStreamingOverSingleGatewayTest test/Orleans.Streaming.Tests/StreamingTests/SystemTargetRouteTests.cs:58 — Skipped — https://github.com/dotnet/orleans/issues/4320
  • Skipped test: AQStreamProducerOnDroppedClientTest test/Extensions/Orleans.Azure.Tests/Streaming/AQClientStreamTests.cs:101 — Skipped — https://github.com/dotnet/orleans/issues/5639
  • Skipped test: AQ_07_ManyDifferent_ManyProducerClientsManyConsumerGrains test/Extensions/Orleans.Azure.Tests/Streaming/AQStreamingTests.cs:195 — Skipped — https://github.com/dotnet/orleans/issues/5648
  • Skipped test: AQ_21_GenericConsumerImplicitlySubscribedToProducerGrain test/Extensions/Orleans.Azure.Tests/Streaming/AQStreamingTests.cs:294 — Skipped — Ignored
  • Skipped test: SMS_AddMany_Consumers test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:222 — Skipped — Ignore
  • Skipped test: AQ_AddMany_Consumers test/Extensions/Orleans.Azure.Tests/Streaming/StreamReliabilityTests.cs:230 — Skipped — Ignore
  • Skipped test: EHStreamProducerOnDroppedClientTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHClientStreamTests.cs:93 — Skipped — https://github.com/dotnet/orleans/issues/5657
  • Skipped test: EHStreamConsumerOnDroppedClientTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHClientStreamTests.cs:103 — Skipped — https://github.com/dotnet/orleans/issues/5634
  • Skipped test: Recoverable100EventStreamsWithTransientErrorsTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHImplicitSubscriptionStreamRecoveryTests.cs:89 — Skipped — https://github.com/dotnet/orleans/issues/5633
  • Skipped test: Recoverable100EventStreamsWith1NonTransientErrorTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHImplicitSubscriptionStreamRecoveryTests.cs:96 — Skipped — https://github.com/dotnet/orleans/issues/5638
  • Skipped test: ReloadFromCheckpointTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHStreamProviderCheckpointTests.cs:88 — Skipped — https://github.com/dotnet/orleans/issues/5356
  • + 1 more in this group — see findings.md.
X1 · Async correctness · Sync-over-async (deadlock risk) · ×25
  • Sync-over-async (deadlock risk) src/Orleans.Core/Async/TaskExtensions.cs:213 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:275 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Core/Networking/ConnectionFactory.cs:51 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:59 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:68 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Core/Networking/Transport/Streams/MessageTransportStream.cs:101 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Journaling/JournaledStateManager.cs:1100 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/Catalog/ActivationData.cs:983 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/ConsistentRing/RingRangeListenerManager.cs:120 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/GrainDirectory/DirectoryMembershipService.cs:32 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:797 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:236 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/Placement/PlacementService.cs:491 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.Runtime/Silo/Silo.cs:504 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcessSiloHandle.cs:140 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:556 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:575 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/InProcTestCluster.cs:718 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/SiloHandle.cs:65 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/StandaloneSiloHandle.cs:353 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:327 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:555 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:710 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
  • Sync-over-async (deadlock risk) src/Orleans.TestingHost/TestCluster.cs:1257 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
  • Sync-over-async (deadlock risk) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryEventObserver.cs:619 — Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
X2 · Cancellation propagation · Async method without CancellationToken · ×25
  • Async method without CancellationToken: GetStats playground/ActivationRebalancing/ActivationRebalancing.Frontend/Controllers/StatsController.cs:12 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetGrainCallFrequencies playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:18 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ResetAsync playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:106 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: AddForest playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:89 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Reset playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:96 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Ping playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:139 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: TryKillSiloAsync playground/DurableJobsJournaling/DurableJobsJournaling.Silo/ChaosGrain.cs:12 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Invoke playground/DurableJobsJournaling/DurableJobsJournaling.Silo/GrainRequestMetricsFilter.cs:12 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartAsync playground/DurableJobsJournaling/DurableJobsJournaling.Silo/WorkflowGrains.cs:18 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ClearStateAsync src/Orleans.Core.Abstractions/Core/Grain.cs:241 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: WriteStateAsync src/Orleans.Core.Abstractions/Core/Grain.cs:249 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ReadStateAsync src/Orleans.Core.Abstractions/Core/Grain.cs:260 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Register src/Orleans.Core.Abstractions/GrainDirectory/IGrainDirectory.cs:111 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteWithRetries src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:41 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: LockAsync src/Orleans.Core/Async/AsyncLock.cs:71 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Start src/Orleans.Core/Async/BatchWorker.cs:105 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunExpirationLoop src/Orleans.Core/Caching/ConcurrentLruCache.cs:1045 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Invoke src/Orleans.Core/Core/GrainMethodInvoker.cs:82 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Process src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs:48 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: StartAsync src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:75 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: PeriodicallyRefreshGatewaySnapshot src/Orleans.Core/Messaging/GatewayManager.cs:238 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RefreshGatewaySnapshot src/Orleans.Core/Messaging/GatewayManager.cs:253 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: UpdateLiveGatewaysSnapshot src/Orleans.Core/Messaging/GatewayManager.cs:275 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CloseEvictedGatewayConnections src/Orleans.Core/Messaging/GatewayManager.cs:365 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetConnectionAsync src/Orleans.Core/Networking/ConnectionManager.cs:111 — No CancellationToken parameter — this work can't be stopped early once started.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×23
  • Duplicated block (5 lines × 2) src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:180 — src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:180-184 | src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:200-204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:180` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:426 — docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:426-430 | docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:446-450 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:426` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:425 — src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:425-429 | src/Orleans.Core.Abstractions/IDs/SiloAddress.cs:440-444 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:122 — src/Orleans.BroadcastChannel/ChannelId.cs:122-126 | src/Orleans.Streaming/StreamId.cs:134-138 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `ns` to `string` in one and `string?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:239 — src/Orleans.Core/Core/DefaultClientServices.cs:239-243 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:547-551 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:52 — src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:52-56 | src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:64-68 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/MembershipService/InMemoryMembershipTable.cs:52` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (5 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:140 — src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:140-144 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:131-135 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162 — src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162-166 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:197-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:162` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entries` to `ImmutableArray<SerializableTypeModel>` in one and `ImmutableArray<ProxyInterfaceModel>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93 — src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93-97 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:166-170 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:93` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:109 — src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:109-113 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:76-81 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:76` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (5 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:56 — src/Orleans.BroadcastChannel/ChannelId.cs:56-60 | src/Orleans.Streaming/StreamId.cs:63-67 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:28 — src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:28-32 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:29-33 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:266 — src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:266-270 | src/Orleans.Runtime/MembershipService/ClusterMembershipSnapshot.cs:200-204 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:298 — src/Orleans.Core/Serialization/OrleansJsonSerializer.cs:298-302 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:67-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) src/Orleans.EventSourcing/Hosting/LogStorageSiloBuilderExtensions.cs:38 — src/Orleans.EventSourcing/Hosting/LogStorageSiloBuilderExtensions.cs:38-42 | src/Orleans.EventSourcing/Hosting/StateStorageSiloBuilderExtensions.cs:38-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:132 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:132-136 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:191-195 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:170 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:170-174 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:228-232 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:399 — src/Orleans.Serialization/Codecs/TupleCodec.cs:399-403 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:375-379 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:578 — src/Orleans.Serialization/Codecs/TupleCodec.cs:578-582 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:519-523 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:174 — src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:174-178 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:178-182 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) src/Orleans.Clustering.ZooKeeper/MembershipSerializerSettings.cs:69 — src/Orleans.Clustering.ZooKeeper/MembershipSerializerSettings.cs:69-73 | src/Redis/Orleans.Clustering.Redis/Storage/JsonSettings.cs:84-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Clustering.ZooKeeper/MembershipSerializerSettings.cs:69` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1108 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1108-1112 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1225-1229 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:384 — src/Orleans.TestingHost/InProcTestCluster.cs:384-388 | src/Orleans.TestingHost/InProcTestCluster.cs:414-418 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:384` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×21
  • Duplicated block (10 lines × 2) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:68 — src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:68-77 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:164-173 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:96 — src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:96-105 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:90-99 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:134 — src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:134-143 | src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:167-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Streaming/Internal/StreamConsumerExtension.cs:134` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:693 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:693-702 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:692-701 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:693` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:184 — src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:184-193 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:257-266 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:184` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:68 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:68-77 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:121-130 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:28 — src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:28-37 | src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1268-1277 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:120 — src/Orleans.Serialization/Codecs/DictionaryCodec.cs:120-129 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:85-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) src/Orleans.Serialization/Invocation/Response.cs:265 — src/Orleans.Serialization/Invocation/Response.cs:265-274 | src/Orleans.Serialization/Invocation/Response.cs:288-297 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Invocation/Response.cs:265` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:129 — src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:129-138 | src/Orleans.Streaming/MemoryStreams/MemoryAdapterFactory.cs:132-141 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:352 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:352-361 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:572-581 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:352` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476 — src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476-485 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:509-518 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:476` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470 — src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470-1479 | src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1510-1521 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1470` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:12 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:12-21 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:18-27 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:12` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Orleans.Runtime/Silo/SiloControl.cs:151 — src/Orleans.Runtime/Silo/SiloControl.cs:151-161 | src/Orleans.Runtime/Silo/SiloControl.cs:392-401 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Silo/SiloControl.cs:151` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:551 — src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:551-560 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:464-474 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:551` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:184 — src/Orleans.CodeGenerator/CopierGenerator.cs:184-193 | src/Orleans.CodeGenerator/SerializerGenerator.cs:245-254 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (10 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:123 — src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:123-132 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:124-133 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:255 — src/Orleans.Core/Runtime/MembershipTableSnapshot.cs:255-264 | src/Orleans.Runtime/MembershipService/ClusterMembershipSnapshot.cs:189-198 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:618 — src/Orleans.TestingHost/InProcTestCluster.cs:618-627 | src/Orleans.TestingHost/TestCluster.cs:592-601 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:618` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionAzureTableTransactionStateStorage.cs:57 — src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionAzureTableTransactionStateStorage.cs:57-66 | src/Orleans.Transactions.TestKit.Base/FaultInjection/ControlledInjection/FaultInjectionDynamoDBTransactionStateStorage.cs:59-68 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×21
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/ArrayCodec.cs:316 — src/Orleans.Serialization/Codecs/ArrayCodec.cs:316-322 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:476-482 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ArrayCodec.cs:316` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Buffers/Reader.cs:1227 — src/Orleans.Serialization/Buffers/Reader.cs:1227-1233 | src/Orleans.Serialization/Buffers/Reader.cs:1242-1248 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:99 — src/Orleans.BroadcastChannel/ChannelId.cs:99-105 | src/Orleans.Streaming/StreamId.cs:106-112 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/ChannelId.cs:99` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `ns` to `string` in one and `string?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:122 — src/Orleans.Core/Core/DefaultClientServices.cs:122-128 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:408-414 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:449 — src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:449-455 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:1349-1355 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:449` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:284 — src/Orleans.Serialization/Codecs/TupleCodec.cs:284-290 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:278-284 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:58 — src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:58-64 | src/Orleans.Analyzers/GenerateSerializationAttributesCodeFix.cs:81-87 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169 — src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169-175 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:204-210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:53 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:53-59 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:47-53 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `IOptions<MessagePackCodecOptions>` in one and `IOptions<JsonCodecOptions>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:167 — src/Orleans.Serialization/Codecs/TupleCodec.cs:167-173 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:189-195 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:167` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:991 — src/Orleans.Serialization/Codecs/TupleCodec.cs:991-997 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:846-852 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:61 — src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:61-67 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/JenkinsHash.cs:69-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/Orleans.Runtime/Catalog/ActivationData.cs:2052 — src/Orleans.Runtime/Catalog/ActivationData.cs:2052-2058 | src/Orleans.Runtime/Catalog/ActivationData.cs:2206-2212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Catalog/ActivationData.cs:2052` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Runtime/Catalog/ActivationData.cs:2213` calls `SetTag`, `ToString` and `src/Orleans.Runtime/Catalog/ActivationData.cs:2059` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/StackCodec.cs:151 — src/Orleans.Serialization/Codecs/StackCodec.cs:151-157 | src/Orleans.Serialization/Codecs/StackCodec.cs:167-174 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:488 — src/Orleans.Serialization/Codecs/TupleCodec.cs:488-494 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:449-455 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:488` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:678 — src/Orleans.Serialization/Codecs/TupleCodec.cs:678-684 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:600-606 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:678` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:885 — src/Orleans.Serialization/Codecs/TupleCodec.cs:885-891 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:765-772 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:885` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:253 — src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:253-259 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:261-267 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) src/Orleans.Streaming/Internal/PeriodicAction.cs:18 — src/Orleans.Streaming/Internal/PeriodicAction.cs:18-24 | src/Orleans.Transactions/Utilities/PeriodicAction.cs:18-24 — before extracting anything, compare `src/Orleans.Streaming/Internal/PeriodicAction.cs` and `src/Orleans.Transactions/Utilities/PeriodicAction.cs` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:50 — src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:50-56 | src/Orleans.Streaming/PubSub/DefaultStreamNamespacePredicateProvider.cs:50-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisBatchContainer.cs:75 — src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisBatchContainer.cs:75-81 | src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubBatchContainer.cs:91-97 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X20 · Mistyped argument guard · Argument guard throws the exception its own condition disproves · ×20
  • Argument guard throws the exception its own condition disproves src/Orleans.Core.Abstractions/Manifest/MajorMinorVersion.cs:73 — The guard on line 73 rejects `value` and line 73 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Reminders/GrainReminderExtensions.cs:81 — The guard on line 81 rejects `reminderName` and line 81 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Reminders/GrainReminderExtensions.cs:160 — The guard on line 160 rejects `reminderName` and line 160 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(reminderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `reminderName`, and on that path `reminderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Serialization/TypeSystem/TypeSpec.cs:277 — The guard on line 275 rejects `assembly` and line 277 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(assembly)` is true of a value that is NOT null: it is satisfied by an EMPTY `assembly`, and on that path `assembly` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Serialization/TypeSystem/TypeSpec.cs:380 — The guard on line 378 rejects `value` and line 380 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(value)` is true of a value that is NOT null: it is satisfied by an EMPTY `value`, and on that path `value` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Streaming/GrainStreamingExtensions.cs:33 — The guard on line 31 rejects `name` and line 33 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Streaming/GrainStreamingExtensions.cs:63 — The guard on line 61 rejects `name` and line 63 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Streaming/PersistentStreams/PersistentStreamProvider.cs:109 — The guard on line 109 rejects `name` and line 109 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:67 — The guard on line 65 rejects `strProviderName` and line 67 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(strProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `strProviderName`, and on that path `strProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Orleans.Streaming/QueueAdapters/BatchContainerBatch.cs:43 — The guard on line 41 rejects `batchContainers` and line 43 reports that rejection as `ArgumentNullException` — but the condition's own test `!batchContainers.Any()` is true of a value that is NOT null: it is satisfied by an EMPTY `batchContainers`, and on that path `batchContainers` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:45 — The guard on line 43 rejects `invariantName` and line 45 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:107 — The guard on line 105 rejects `invariantName` and line 107 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(invariantName)` is true of a value that is NOT null: it is satisfied by an EMPTY `invariantName`, and on that path `invariantName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AdoNet/Shared/Storage/DbConnectionFactory.cs:112 — The guard on line 110 rejects `connectionString` and line 112 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:78 — The guard on line 78 rejects `dataConnectionString` and line 78 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(dataConnectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `dataConnectionString`, and on that path `dataConnectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapter.cs:35 — The guard on line 35 rejects `serviceId` and line 35 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/AWS/Orleans.Streaming.SQS/Streams/SQSAdapterReceiver.cs:34 — The guard on line 34 rejects `serviceId` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(serviceId)` is true of a value that is NOT null: it is satisfied by an EMPTY `serviceId`, and on that path `serviceId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Azure/Shared/Storage/AzureStorageOperationOptions.cs:128 — The guard on line 128 rejects `connectionString` and line 128 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamOptions.cs:77 — The guard on line 77 rejects `connectionString` and line 77 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(connectionString)` is true of a value that is NOT null: it is satisfied by an EMPTY `connectionString`, and on that path `connectionString` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:36 — The guard on line 34 rejects `clusterId` and line 36 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(clusterId)` is true of a value that is NOT null: it is satisfied by an EMPTY `clusterId`, and on that path `clusterId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/PersistentStreams/AzureTableStorageStreamFailureHandler.cs:104 — The guard on line 102 rejects `streamProviderName` and line 104 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(streamProviderName)` is true of a value that is NOT null: it is satisfied by an EMPTY `streamProviderName`, and on that path `streamProviderName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×17
  • Duplicated block (9 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:306 — src/Orleans.CodeGenerator/CopierGenerator.cs:306-314 | src/Orleans.CodeGenerator/SerializerGenerator.cs:336-344 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:306` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:158 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:158-166 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:216-224 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1323 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1323-1331 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1117-1125 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1473 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1473-1481 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1232-1240 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:24 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:24-32 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:25-33 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (9 lines × 2) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:321 — src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:321-329 | src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:430-438 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:321` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:128 — src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:128-136 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:116-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:79 — src/Orleans.Core/Messaging/CachingIdSpanCodec.cs:79-87 | src/Orleans.Core/Messaging/CachingSiloAddressCodec.cs:89-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Core/Runtime/ClientGrainContext.cs:136 — src/Orleans.Core/Runtime/ClientGrainContext.cs:136-144 | src/Orleans.Runtime/Core/HostedClient.cs:388-396 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Runtime/Catalog/GrainTypeSharedContext.cs:214 — src/Orleans.Runtime/Catalog/GrainTypeSharedContext.cs:214-222 | src/Orleans.Runtime/Core/SystemTarget.cs:133-146 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:853 — src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:853-861 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:909-917 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:871 — src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:871-879 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:921-929 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Serialization/Codecs/ObjectCodec.cs:70 — src/Orleans.Serialization/Codecs/ObjectCodec.cs:70-78 | src/Orleans.Serialization/Serializers/AbstractTypeSerializer.cs:64-72 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Streaming/Common/EventSequenceToken.cs:111 — src/Orleans.Streaming/Common/EventSequenceToken.cs:111-119 | src/Orleans.Streaming/Common/EventSequenceTokenV2.cs:110-118 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:221 — src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:221-229 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:229-237 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244-252 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:348-356 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) samples/Deployment/AzureAppService/Silo/Shared/MainLayout.razor.cs:80 — samples/Deployment/AzureAppService/Silo/Shared/MainLayout.razor.cs:80-88 | samples/ShoppingCart/Silo/Shared/MainLayout.razor.cs:82-90 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Shared/MainLayout.razor.cs` and `samples/ShoppingCart/Silo/Shared/MainLayout.razor.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D10 · Test Quality · Races the wall clock · ×15
  • Races the wall clock: MembershipAgent_LifecycleStages_ValidateInitialConnectivity_WaitsForStaleSilosToBeEvicted test/Orleans.Core.Tests/Membership/MembershipAgentTests.cs:462 — This test reads `DateTime.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipAgent_LifecycleStages_ValidateInitialConnectivity_Failure test/Orleans.Core.Tests/Membership/MembershipAgentTests.cs:511 — This test reads `DateTime.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_Restarted test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:218 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_Superseded test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:317 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_AlreadyDeclaredDead test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:365 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_DeclaredDead_AfterJoining test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:409 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_TrySuspectOrKill_ButIAmKill test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:650 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_TrySuspectOrKill_AlreadyDead test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:696 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_TrySuspectOrKill_DeclareDead_SmallCluster test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:733 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_TrySuspectOrKill_ClocksNotSynchronized test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:772 — This test reads `DateTime.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_TrySuspectOrKill_DeclareDead_LargerCluster test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:851 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: MembershipTableManager_Refresh test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs:941 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: DeactivateInDueTimeOrder_OnlyOldestAndEligibleAreDeactivated test/Orleans.Core.Tests/Runtime/ActivationCollectorTests.cs:766 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: DeactivateInDueTimeOrder_ConcurrentModification_ShouldNotThrow test/Orleans.Core.Tests/Runtime/ActivationCollectorTests.cs:801 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
  • Races the wall clock: DeactivateInDueTimeOrder_SkipsActiveAndInvalidActivations test/Orleans.Core.Tests/Runtime/ActivationCollectorTests.cs:916 — This test reads `DateTimeOffset.UtcNow` and compares it against the real system clock (`TimeProvider.System`) handed to the code under test. Those are two independent clock reads, so the test passes only while no boundary falls between them — a second ticking over between the code's read and the test's, or, for a date, a day that differs between the machine's local zone and UTC. It passes or fails on the time of day and the build agent's time zone, and re-running the suite on one machine cannot reveal it. Read the clock once: give the code under test a clock the test controls (a fake time provider, fake timers with a fixed system time) and build the expectation from that same instant, or assert a range rather than an exact value.
GD1 · Unfinished & placeholder code · Unfinished stub · ×15
  • Unfinished stub — throws NotImplementedException src/Orleans.Core/Runtime/InvokableObjectManager.cs:152 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.EventSourcing/Common/PrimaryBasedLogViewAdaptor.cs:85 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:100 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:102 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:426 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:10 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:11 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:69 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:72 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:77 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×14
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102-1172 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1405-1459 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1468-1531 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1538-1585 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129 — src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:129-140 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:56-67 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:59-70 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:88-99 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:649 — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:649-665 | src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:795-811 | src/Orleans.Transactions/TransactionAttribute.cs:500-516 | src/Orleans.Transactions/TransactionAttribute.cs:669-686 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:119 — src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:119-161 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:244-274 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:362-392 | src/Orleans.Journaling/Formats/Json/JsonDurableDictionaryCommandCodec.cs:103-136 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:57-75 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:82-100 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:53-71 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:55-73 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64-97 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:60-82 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:58-96 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:243-275 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101-157 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:85-130 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:100-173 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:168-232 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ArrayCodec.cs:58 — src/Orleans.Serialization/Codecs/ArrayCodec.cs:58-116 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:213-265 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:373-425 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:536-588 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/CollectionCodec.cs:54 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:54-104 | src/Orleans.Serialization/Codecs/ListCodec.cs:53-103 | src/Orleans.Serialization/Codecs/QueueCodec.cs:58-107 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:62-112 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:18 — src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:18-39 | src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:42-63 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:18-45 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:17-38 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:15 — src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:15-60 | src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:63-108 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:18-84 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:13-58 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:285 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:285-390 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:497-614 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:317-398 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:489-588 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89 — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89-104 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:124-137 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:200-218 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:270-286 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:92 — src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:92-115 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:124-154 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:188-210 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:219-241 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×14
  • Duplicated block (12 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:86 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:86-97 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:85-96 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:90 — src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:90-101 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:159-170 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:90` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) src/Orleans.Serialization/Buffers/Writer.cs:484 — src/Orleans.Serialization/Buffers/Writer.cs:484-495 | src/Orleans.Serialization/Buffers/Writer.cs:509-520 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:484` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:236 — src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:236-247 | src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:271-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:236` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (12 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:750 — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:750-761 | src/Orleans.Transactions/TransactionAttribute.cs:618-629 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:750` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:111 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:111-122 | src/Orleans.Serialization/Codecs/ListCodec.cs:110-121 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (12 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39-50 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:53-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:75 — src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:75-86 | src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs:72-83 — before extracting anything, compare `src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs` and `src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:126 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:126-137 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:158-169 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:126` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:100 — src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:100-111 | src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:124-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) src/Orleans.Serialization/Serializer.cs:1469 — src/Orleans.Serialization/Serializer.cs:1469-1480 | src/Orleans.Serialization/Serializer.cs:1501-1512 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:1469` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs:103 — src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs:103-114 | src/Orleans.Streaming/QueueAdapters/IQueueCacheCursor.cs:43-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:385 — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:385-396 | src/Redis/Orleans.Streaming.Redis/Storage/RedisStreamStorage.cs:176-187 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:39 — src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:39-50 | src/Orleans.TestingHost/TestClusterOptions.cs:199-210 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs` and `src/Orleans.TestingHost/TestClusterOptions.cs` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestSiloSpecificOptions.cs:39` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `testCluster` to `InProcessTestCluster` in one and `TestCluster` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
IC1 · Incompleteness & stubs · Unfinished stub · ×14
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:10 — `Serialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/host/configuration-guide/snippets/serialization/GrainStorageExamples.cs:11 — `Deserialize` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:69 — `ReadStateFromStorage` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:72 — `ApplyUpdatesToStorage` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException docs/site/src/content/docs/snippets/compiled/EventSourcing/EventSourcingSnippets.cs:77 — `ClearStoredState` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Core/Runtime/InvokableObjectManager.cs:152 — `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:80 — `ActivationServices` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:82 — `ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:84 — `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:137 — `GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:100 — `ObservableLifecycle` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:102 — `Scheduler` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Runtime/Core/HostedClient.cs:426 — `GetTarget` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException src/Orleans.Serialization/Codecs/SkipFieldExtension.cs:14 — `WriteField` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×13
  • Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:772 — src/Orleans.CodeGenerator/SerializerGenerator.cs:772-777 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1021-1026 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:122 — src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:122-127 | src/Redis/Orleans.Clustering.Redis/Providers/RedisGatewayListProvider.cs:31-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:122` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/Orleans.Serialization/Serializers/CodecProvider.cs:98 — src/Orleans.Serialization/Serializers/CodecProvider.cs:98-103 | src/Orleans.Serialization/TypeSystem/TypeConverter.cs:158-163 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:113 — src/Orleans.Streaming/Generator/GeneratorAdapterFactory.cs:113-118 | src/Orleans.Streaming/MemoryStreams/MemoryAdapterFactory.cs:119-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414 — src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414-419 | src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:1347-1352 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:414` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (6 lines × 2) src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77 — src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77-82 | src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:85-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Dashboard/Orleans.Dashboard/Implementation/Helpers/GrainStateHelper.cs:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (6 lines × 2) src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:83 — src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:83-88 | src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:226-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:82` calls `PartitionKey` and `src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:225` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/ActivatorGenerator.cs:107 — src/Orleans.CodeGenerator/ActivatorGenerator.cs:107-112 | src/Orleans.CodeGenerator/ProxyGenerator.cs:548-553 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:195 — src/Orleans.CodeGenerator/CopierGenerator.cs:195-200 | src/Orleans.CodeGenerator/SerializerGenerator.cs:256-261 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:100 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:100-105 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:157-162 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:776 — src/Orleans.Serialization/Codecs/TupleCodec.cs:776-781 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:675-680 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 2) src/Orleans.TestingHost/TestClusterHostFactory.cs:137 — src/Orleans.TestingHost/TestClusterHostFactory.cs:137-142 | src/Orleans.TestingHost/TestClusterHostFactory.cs:154-159 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/TestClusterHostFactory.cs:137` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor:33 — samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor:33-38 | samples/ShoppingCart/Silo/Shared/NavMenu.razor:27-32 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Shared/NavMenu.razor` and `samples/ShoppingCart/Silo/Shared/NavMenu.razor` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D17 · Explicit Debt · ObsoleteWithCallers · ×12
  • ObsoleteWithCallers src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:167 — [Obsolete] GetQueueMessagesAsync
  • ObsoleteWithCallers src/Orleans.Streaming/QueueAdapters/IQueueAdapterReceiver.cs:34 — [Obsolete] GetQueueMessagesAsync
  • ObsoleteWithCallers src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubCheckpointer.cs:119 — [Obsolete] Update
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:28 — [Obsolete] CipherAlgorithm
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:33 — [Obsolete] CipherStrength
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:38 — [Obsolete] HashAlgorithm
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:43 — [Obsolete] HashStrength
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:48 — [Obsolete] KeyExchangeAlgorithm
  • ObsoleteWithCallers src/Orleans.Core/Networking/Transport/Security/ITlsHandshakeFeature.cs:53 — [Obsolete] KeyExchangeStrength
  • ObsoleteWithCallers src/Orleans.Serialization/Exceptions.cs:48 — [Obsolete] .ctor
  • ObsoleteWithCallers src/Orleans.Streaming/QueueAdapters/IQueueAdapterFactory.cs:15 — [Obsolete] CreateAdapter
  • ObsoleteWithCallers src/Orleans.Streaming/QueueAdapters/IQueueAdapterReceiver.cs:56 — [Obsolete] MessagesDeliveredAsync
D17 · Explicit Debt · CoverageExclusion · ×12
  • CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:14 — class BufferTestHelper — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:36 — class BufferTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:66 — class MultiSegmentBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:86 — class StructBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/BufferTestHelper.cs:114 — class PooledBufferWriterTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/CopierTester.cs:19 — class CopierTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/FieldCodecTester.cs:27 — class FieldCodecTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/ReadOnlySequenceHelper.cs:12 — class ReadOnlySequenceHelper — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/SerializationTester.cs:11 — class SerializationTester — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/SerializationTester.cs:138 — class SerializationTesterFixture — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/TestBufferWriterStruct.cs:12 — struct TestBufferWriterStruct — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion src/Orleans.Serialization.TestKit/TestMultiSegmentBufferWriter.cs:13 — class TestMultiSegmentBufferWriter — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×12
  • Duplicated block (16 lines × 2) src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:96 — src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:96-111 | src/Orleans.Serialization/Codecs/ImmutableSortedDictionaryCodec.cs:101-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:756 — src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:756-771 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:609-624 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (16 lines × 2) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:443 — src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:443-458 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:325-340 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:443` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:155 — src/Orleans.CodeGenerator/CopierGenerator.cs:155-170 | src/Orleans.CodeGenerator/SerializerGenerator.cs:217-232 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:57 — src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:57-72 | src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:85-100 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/JournalStorageConsumerExtensions.cs:57` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:887 — src/Orleans.CodeGenerator/SerializerGenerator.cs:887-902 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1050-1065 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerGenerator.cs:887` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1285 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1285-1300 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1079-1094 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (16 lines × 2) playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:95 — playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:95-110 | samples/JournaledTodoList/JournaledTodoList.ServiceDefaults/Extensions.cs:106-121 — before extracting anything, compare `playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs` and `samples/JournaledTodoList/JournaledTodoList.ServiceDefaults/Extensions.cs` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:492 — src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:492-507 | src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:267-282 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:393 — src/Orleans.TestingHost/InProcTestCluster.cs:393-408 | src/Orleans.TestingHost/TestCluster.cs:478-493 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:393` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) REDACTED.cs:6 — REDACTED.cs:6-21 | samples/ShoppingCart/Silo/Pages/Shop.razor.cs:6-21 — before extracting anything, compare `REDACTED.cs` and `samples/ShoppingCart/Silo/Pages/Shop.razor.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED.cs:6` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor:37 — samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor:37-52 | samples/ShoppingCart/Silo/Components/ShoppingCartItem.razor:37-52 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Components/ShoppingCartItem.razor` and `samples/ShoppingCart/Silo/Components/ShoppingCartItem.razor` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×11
  • Duplicated block (14 lines × 2) playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68 — playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68-81 | playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:96-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:67` calls `AddSample` and `playground/DurableJobsJournaling/DurableJobsJournaling.Web/WorkflowMetrics.cs:95` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1180 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1180-1193 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1222-1235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:650 — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:650-663 | src/Orleans.Transactions/TransactionAttribute.cs:501-514 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:650` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) src/Orleans.Core/Async/TaskExtensions.cs:218 — src/Orleans.Core/Async/TaskExtensions.cs:218-231 | src/Orleans.TestingHost/StandaloneSiloHost.cs:167-180 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) src/Orleans.Core/Runtime/ClientGrainContext.cs:118 — src/Orleans.Core/Runtime/ClientGrainContext.cs:118-131 | src/Orleans.Runtime/Core/HostedClient.cs:370-383 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77 — src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77-90 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:376-389 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:189 — src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:189-202 | src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:385-398 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:65 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:65-78 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:59-78 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (14 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1156 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1156-1169 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1398-1411 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:1413` calls `ReadValue` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:1170` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123 — src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123-136 | src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:160-173 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Dashboard/Orleans.Dashboard/Metrics/History/TraceHistory.cs:123` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:158 — src/Orleans.Streaming/Generator/GeneratorPooledCache.cs:158-171 | src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs:162-175 — before extracting anything, compare `src/Orleans.Streaming/Generator/GeneratorPooledCache.cs` and `src/Orleans.Streaming/MemoryStreams/MemoryPooledCache.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×10
  • Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:126 — src/Orleans.Serialization/Codecs/DictionaryCodec.cs:126-146 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:98-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:126` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:35 — src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:35-55 | src/Orleans.Serialization/Utilities/ServiceCollectionExtensions.cs:34-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:35` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Core/Configuration/ServiceCollectionExtensions.cs:31` calls `ThrowIfNull` and `src/Orleans.Serialization/Utilities/ServiceCollectionExtensions.cs:30` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (21 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryJournalFormat.cs:201 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryJournalFormat.cs:201-221 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryV0JournalReader.cs:59-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (21 lines × 2) src/Orleans.Runtime/Catalog/ActivationData.cs:1066 — src/Orleans.Runtime/Catalog/ActivationData.cs:1066-1086 | src/Orleans.Runtime/Core/SystemTarget.cs:274-294 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/QueueCodec.cs:33 — src/Orleans.Serialization/Codecs/QueueCodec.cs:33-53 | src/Orleans.Serialization/Codecs/StackCodec.cs:36-56 — before extracting anything, compare `src/Orleans.Serialization/Codecs/QueueCodec.cs` and `src/Orleans.Serialization/Codecs/StackCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/Codecs/StackCodec.cs:33` calls `MethodImpl` and `src/Orleans.Serialization/Codecs/QueueCodec.cs:28` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:58 — src/Orleans.Serialization/Codecs/TupleCodec.cs:58-78 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:80-100 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (21 lines × 2) src/Orleans.Core/Networking/Transport/Sockets/TcpMessageTransportListener.cs:138 — src/Orleans.Core/Networking/Transport/Sockets/TcpMessageTransportListener.cs:138-158 | src/Orleans.TestingHost/UnixSocketTransport/UnixDomainSocketMessageTransportListener.cs:126-146 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Networking/Transport/Sockets/TcpMessageTransportListener.cs:138` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (21 lines × 2) src/Orleans.Serialization/Codecs/HashSetCodec.cs:66 — src/Orleans.Serialization/Codecs/HashSetCodec.cs:66-86 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:367-387 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/HashSetCodec.cs:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (21 lines × 2) playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:43 — playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/Extensions.cs:43-63 | playground/DurableJobsJournaling/DurableJobsJournaling.ServiceDefaults/Extensions.cs:53-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (21 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:691 — src/Orleans.TestingHost/InProcTestCluster.cs:691-711 | src/Orleans.TestingHost/TestCluster.cs:683-703 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:691` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×10
  • Duplicated block (18 lines × 2) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:91 — src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:91-108 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:184-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:91` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:203` calls `DeduplicateSourceOutputs` and `src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:109` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (18 lines × 2) src/Orleans.Serialization/Serializers/CodecProvider.cs:180 — src/Orleans.Serialization/Serializers/CodecProvider.cs:180-197 | src/Orleans.Serialization/TypeSystem/TypeConverter.cs:221-238 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializers/CodecProvider.cs:180` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (18 lines × 2) src/Orleans.Core/Core/ClientBuilderExtensions.cs:239 — src/Orleans.Core/Core/ClientBuilderExtensions.cs:239-256 | src/Orleans.Runtime/Hosting/CoreHostingExtensions.cs:71-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Core/ClientBuilderExtensions.cs:239` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:42 — src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:42-59 | src/Orleans.Streaming/PubSub/ImplicitStreamSubscriberTable.cs:42-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (18 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:112 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:112-129 | src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs:171-188 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileGrainStorage.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileGrainStorage.cs:112` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:57 — src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:57-74 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:41-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:57` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:61 — src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:61-78 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:244-261 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (18 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36-53 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:39-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:36` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441-458 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:588-605 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:585` calls `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:438` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (18 lines × 2) samples/Deployment/AzureAppService/Silo/Services/BaseClusterService.cs:13 — samples/Deployment/AzureAppService/Silo/Services/BaseClusterService.cs:13-30 | samples/ShoppingCart/Silo/Services/BaseClusterService.cs:13-30 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Services/BaseClusterService.cs` and `samples/ShoppingCart/Silo/Services/BaseClusterService.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×10
  • Duplicated block (11 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:221 — src/Orleans.Core/Core/DefaultClientServices.cs:221-231 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:529-539 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:75 — src/Orleans.Serialization/Codecs/DictionaryCodec.cs:75-85 | src/Orleans.Serialization/Codecs/DictionaryCodec.cs:280-290 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:92 — src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:92-102 | src/Orleans.Core/Manifest/ImplementedInterfaceProvider.cs:54-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:92` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:29 — src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:29-39 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:39-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:29` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:61 — src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:61-71 | src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:75-85 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Diagnostics/DispatcherEvents.cs:61` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (11 lines × 2) src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134 — src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134-144 | src/Orleans.Serialization/TypeSystem/TypeCodec.cs:164-174 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/TypeSystem/TypeCodec.cs:134` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:55 — src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs:55-65 | src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs:52-62 — before extracting anything, compare `src/AWS/Orleans.Journaling.S3/S3ReadOnlySequenceStream.cs` and `src/Azure/Orleans.Journaling.AzureStorage/ReadOnlySequenceStream.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:304 — src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:304-314 | src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs:324-334 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1217 — src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1217-1227 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:545-555 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1217` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1216` calls `CheckValidity` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs:544` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) samples/Deployment/AzureAppService/Silo/Components/ProductTable.razor:63 — samples/Deployment/AzureAppService/Silo/Components/ProductTable.razor:63-73 | samples/ShoppingCart/Silo/Components/ProductTable.razor:72-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
X1 · Async correctness · Sync-over-async (deadlock risk) through `.Result` · ×10
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.Core.Abstractions/Runtime/GrainRequest.cs:90 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.DurableJobs/IDurableJobReceiverExtension.cs:224 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/Core/ManagementGrain.cs:235 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/Core/ManagementGrain.cs:311 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/GrainDirectory/GrainDirectoryHandoffManager.cs:166 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:564 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.TestingHost/InProcTestCluster.cs:644 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Orleans.TestingHost/TestCluster.cs:620 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs:146 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
  • Sync-over-async (deadlock risk) through `.Result` src/AdoNet/Shared/Storage/OrleansRelationalDownloadStream.cs:144 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
D10 · Test Quality · Fixed-sleep synchronisation · ×8
  • Fixed-sleep synchronisation: RequestContext_MultiThreads_ExportToMessage test/Orleans.Core.Tests/General/RequestContextTestsNonSiloRequired.cs:43 — This test starts a background task and then orders itself against it with `Thread.Sleep(1)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: MessageHandlerShared_DisposeWaitsForBorrowedSerializer test/Orleans.Core.Tests/Networking/MessageTransportLifecycleTests.cs:385 — This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(50))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: MessageHandlerShared_DisposeWaitsForQueuedSendWorker test/Orleans.Core.Tests/Networking/MessageTransportLifecycleTests.cs:493 — This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(50))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: MessageHandlerShared_DisposeAllowsLeasedSendWorkToFinish test/Orleans.Core.Tests/Networking/MessageTransportLifecycleTests.cs:517 — This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(50))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: DeactivateOnIdleTest_Stress_2_NonReentrant test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/DeactivateOnIdleTests.cs:91 — This test starts a background task and then orders itself against it with `Task.Delay(1)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: DeactivateOnIdleTest_Stress_3_Reentrant test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/DeactivateOnIdleTests.cs:117 — This test starts a background task and then orders itself against it with `Task.Delay(TimeSpan.FromMilliseconds(1))` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: Halo_RequestContextShouldBeMaintainedWhenThreadHoppingOccurs test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs:346 — This test starts a background task and then orders itself against it with `Task.Delay(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
  • Fixed-sleep synchronisation: Halo_LogicalCallContextShouldBeMaintainedWhenThreadHoppingOccurs test/Orleans.Runtime.Internal.Tests/General/RequestContextTest.cs:397 — This test starts a background task and then orders itself against it with `Task.Delay(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×8
  • Duplicated block (15 lines × 2) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:188 — docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:188-202 | docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:307-321 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:188` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (15 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:31 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:31-45 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:52-66 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:31` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) src/Orleans.CodeGenerator/InvokableGenerator.cs:480 — src/Orleans.CodeGenerator/InvokableGenerator.cs:480-494 | src/Orleans.CodeGenerator/InvokableGenerator.cs:541-555 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/InvokableGenerator.cs:480` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.CodeGenerator/InvokableGenerator.cs:538` calls `IdentifierName` and `src/Orleans.CodeGenerator/InvokableGenerator.cs:476` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) src/Orleans.Serialization/Codecs/TupleCodec.cs:1048 — src/Orleans.Serialization/Codecs/TupleCodec.cs:1048-1062 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:889-903 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (15 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:61 — src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:61-75 | src/Orleans.Streaming/PubSub/DefaultStreamNamespacePredicateProvider.cs:61-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/SubscriberTable/Predicates/DefaultStreamNamespacePredicateProvider.cs:61` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `predicate` to `out IChannelNamespacePredicate?` in one and `out IStreamNamespacePredicate` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (15 lines × 2) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:699 — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:699-713 | src/Orleans.Transactions/TransactionAttribute.cs:558-572 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15 lines × 2) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:365 — src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:365-379 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:538-552 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:365` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (15 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:414 — src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:414-428 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:163-177 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:414` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×8
  • Duplicated block (13 lines × 2) src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:73 — src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:73-85 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:75-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:154 — docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:154-166 | docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:276-288 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:154` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:275` calls `WriteString` and `docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:153` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:44 — src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:44-56 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:38-50 — before extracting anything, compare `src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:1004 — src/Orleans.CodeGenerator/SerializerGenerator.cs:1004-1016 | src/Orleans.CodeGenerator/SerializerGenerator.cs:1087-1099 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/SerializerGenerator.cs:1004` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102-114 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:97-109 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableDictionaryCommandHandler<TKey, TValue>` in one and `IDurableSetCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:12 — src/Orleans.Serialization/Buffers/Adaptors/BufferWriterExtensions.cs:12-24 | src/Orleans.Serialization/Buffers/ArcBufferWriter.cs:1252-1264 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) samples/Deployment/AzureAppService/Silo/Components/PurchasableProductTable.razor:54 — samples/Deployment/AzureAppService/Silo/Components/PurchasableProductTable.razor:54-66 | samples/ShoppingCart/Silo/Components/PurchasableProductTable.razor:54-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (13 lines × 2) samples/Deployment/AzureAppService/Grains/ShoppingCartGrain.cs:18 — samples/Deployment/AzureAppService/Grains/ShoppingCartGrain.cs:18-30 | samples/ShoppingCart/Grains/ShoppingCartGrain.cs:15-27 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `samples/Deployment/AzureAppService/Grains/ShoppingCartGrain.cs:18` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `samples/Deployment/AzureAppService/Grains/ShoppingCartGrain.cs:17` calls `ThrowIfNull` and `samples/ShoppingCart/Grains/ShoppingCartGrain.cs:14` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×7
  • Disposable created and abandoned in the method that made it src/Orleans.Core/Networking/Connection.cs:154 — `task` is a `Task`, which implements `IDisposable`, and it is created here (line 154). Every use of it in `StartClosing` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:335 — `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 335). Every use of it in `CreateWorker` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.Runtime/MembershipService/ClusterMembershipService.cs:108 — `cancellation` is a `CancellationTokenSource`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Participate` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cancellation = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:15 — `task` is a `Task`, which implements `IDisposable`, and it is created here (line 15). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.Runtime/Scheduler/TaskSchedulerUtils.cs:24 — `task` is a `Task`, which implements `IDisposable`, and it is created here (line 24). Every use of it in `QueueAction` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var task = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.Streaming/Providers/SiloStreamProviderRuntime.cs:80 — `manager` is a `PersistentStreamPullingManager`, which implements `IDisposable`, and it is created here (line 80). Every use of it in `InitializePullingAgents` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var manager = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it src/Orleans.TestingHost/TestClusterPortAllocator.cs:330 — `signal` is a `ManualResetEventSlim`, which implements `IDisposable`, and it is created here (line 330). Every use of it in `Acquire` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var signal = …;`), which releases it at the end of the scope on every path including a throw.
D17 · Explicit Debt · BareSuppressMessage · ×6
  • BareSuppressMessage src/Azure/Orleans.Streaming.AzureStorage/Storage/AzureQueueDataManager.cs:63 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage src/Azure/Shared/Storage/AzureTableUtils.cs:100 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage src/Orleans.Core.Abstractions/IDs/Legacy/LegacyGrainId.cs:22 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage src/Orleans.Core/Messaging/GatewayManager.cs:237 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage src/Orleans.Runtime/Silo/SiloControl.cs:97 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
  • BareSuppressMessage test/Orleans.Runtime.Internal.Tests/StorageTests/CommonStorageTests.cs:32 — System.Diagnostics.CodeAnalysis.SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
D3 · God Classes · ClassTooLong · ×6
  • ClassTooLong: SerializerGenerator src/Orleans.CodeGenerator/SerializerGenerator.cs — ClassTooLong — 643 significant lines (blank, comment-only and punctuation-only lines excluded), 21 methods. The bar is 400 significant lines; this is 243 over it, 1.61× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: TransactionRecoveryTestsRunner src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs — ClassTooLong — 613 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 213 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: InvokableGenerator src/Orleans.CodeGenerator/InvokableGenerator.cs — ClassTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. The bar is 400 significant lines; this is 203 over it, 1.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SocketMessageTransport src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs — ClassTooLong — 434 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 34 over it, 1.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: JournaledJobShardManager src/Orleans.DurableJobs/JournaledJobShardManager.cs — ClassTooLong — 426 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 26 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: TransactionalStateStorageTestRunner src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs — ClassTooLong — 426 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The bar is 400 significant lines; this is 26 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D35 · Change Coupling · Change coupling · ×6
  • Change coupling: ConsistentRingProvider.cs ↔ VirtualBucketsRingProvider.cs src/Orleans.Runtime/ConsistentRing/ConsistentRingProvider.cs:1 — `src/Orleans.Runtime/ConsistentRing/ConsistentRingProvider.cs` and `src/Orleans.Runtime/ConsistentRing/VirtualBucketsRingProvider.cs` change together 67% of the time (8 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `cad1d512` fix(runtime): order ring range notifications (#11182); `70085a8f` Unsubscribe `ConsistentRingProvider` & `VirtualBucketsRingProvider` f…; `bbf13919` IConsistentRingProvider implementations should notify immediately on … — run `git show` on any of them.
  • Change coupling: SimpleQueueCacheCursor.cs ↔ PersistentStreamPullingAgent.cs src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs:1 — `src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCacheCursor.cs` and `src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs` change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `5b42a3a7` refactor(streaming): add typed cache cursor results (#9714); `da77fd69` fix(streaming): defer acknowledgements for batched delivery (#10655); `a1c73151` chore(Orleans.Streaming): Use [LoggerMessage] (#9423) — run `git show` on any of them.
  • Change coupling: SerializableTypeDescription.cs ↔ SerializerGenerator.cs src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:1 — `src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs` and `src/Orleans.CodeGenerator/SerializerGenerator.cs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `e81a265c` CodeGenerator: clean up attribute handling and remove obsolete custom…; `62b0b27c` Fix serialization for records which have no properties of their own (…; `e0d3073c` Add new SerializerTransparentAttribute for abstract classes (#8015) — run `git show` on any of them.
  • Change coupling: SimpleQueueCache.cs ↔ PersistentStreamPullingAgent.cs src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCache.cs:1 — `src/Orleans.Streaming/Common/SimpleCache/SimpleQueueCache.cs` and `src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs` change together 57% of the time (12 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `d42e0183` fix(streaming): recover legacy sequence tokens (#11155); `5b42a3a7` refactor(streaming): add typed cache cursor results (#9714); `a1c73151` chore(Orleans.Streaming): Use [LoggerMessage] (#9423) — run `git show` on any of them.
  • Change coupling: MembershipAgent.cs ↔ MembershipTableManager.cs src/Orleans.Runtime/MembershipService/MembershipAgent.cs:1 — `src/Orleans.Runtime/MembershipService/MembershipAgent.cs` and `src/Orleans.Runtime/MembershipService/MembershipTableManager.cs` change together 53% of the time (10 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `d9656aaa` fix(storage): reduce Azure table retry pressure (#10192); `65d3733e` fix: validate connectivity before silo activation (#10153); `c4c03246` chore(Orleans.Runtime): Use [LoggerMessage] p3 (#9498) — run `git show` on any of them.
  • Change coupling: MembershipSystemTarget.cs ↔ SiloHealthMonitor.cs src/Orleans.Runtime/MembershipService/MembershipSystemTarget.cs:1 — `src/Orleans.Runtime/MembershipService/MembershipSystemTarget.cs` and `src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `15fc1fed` feat(membership): retain local health history (#10502); `84a82bef` chore: use IMeterFactory for MessagingInstruments (#10179); `c4c03246` chore(Orleans.Runtime): Use [LoggerMessage] p3 (#9498) — run `git show` on any of them.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×6
  • Duplicated block (22 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:373 — src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:373-394 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:506-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:373` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (22 lines × 2) src/Orleans.Serialization/Serializer.cs:117 — src/Orleans.Serialization/Serializer.cs:117-138 | src/Orleans.Serialization/Serializer.cs:151-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) src/Orleans.Serialization/Serializer.cs:1210 — src/Orleans.Serialization/Serializer.cs:1210-1231 | src/Orleans.Serialization/Serializer.cs:1243-1264 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:1210` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:541 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:541-562 | src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:338-359 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:541` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:361` calls `ConstructRowKey` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:564` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (22 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:323 — src/Orleans.TestingHost/InProcTestCluster.cs:323-344 | src/Orleans.TestingHost/TestCluster.cs:404-425 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:323` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:808 — src/Orleans.TestingHost/InProcTestCluster.cs:808-829 | src/Orleans.TestingHost/TestCluster.cs:818-839 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D6 · Cohesion (LCOM4) · Low cohesion · ×6
  • Low cohesion: MessagingProcessingInstruments (LCOM4 6) src/Orleans.Core/Diagnostics/Metrics/MessagingProcessingInstruments.cs:6 — MessagingProcessingInstruments's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SiloControl (LCOM4 6) src/Orleans.Runtime/Silo/SiloControl.cs:26 — SiloControl's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SiloGrainService (LCOM4 5) src/Dashboard/Orleans.Dashboard/Implementation/SiloGrainService.cs:16 — SiloGrainService's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CatalogInstruments (LCOM4 5) src/Orleans.Core/Diagnostics/Metrics/CatalogInstruments.cs:9 — CatalogInstruments's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MessagingInstruments (LCOM4 5) src/Orleans.Core/Diagnostics/Metrics/MessagingInstruments.cs:9 — MessagingInstruments's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: TypeManifestOptions (LCOM4 4) src/Orleans.Serialization/Configuration/TypeManifestOptions.cs:18 — TypeManifestOptions's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
X18 · Disposal-pattern correctness · Owned disposable field is never released · ×6
  • Owned disposable field is never released src/Orleans.Clustering.TestKit/MembershipTableTestFixture.cs:31 — `MembershipTableTestFixture` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_initializationGate` itself (line 31), which makes that instance its own. But `_initializationGate` is named in none of the methods the disposal search covered: `DisposeAsync` (line 399), `DisposeAsync` (line 401), `DisposeAsync` (line 399), `DisposeAsync` (line 401), `CompleteDisposalAsync` (line 431), `ObserveLateCleanupFailureAsync` (line 460) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_initializationGate?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released src/Orleans.Core/Networking/Transport/Security/TlsMessageTransport.cs:24 — `TlsMessageTransport` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_networkTransportStream` itself (line 24), which makes that instance its own. But `_networkTransportStream` is named in none of the methods the disposal search covered: `DisposeAsync` (line 209), `CloseAsync` (line 98) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_networkTransportStream?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released src/Orleans.DurableJobs/JobShard.cs:158 — `JobShard` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_mutationLock` itself (line 158), which makes that instance its own. But `_mutationLock` is named in none of the methods the disposal search covered: `DisposeAsync` (line 389) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_mutationLock?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:38 — `StatelessWorkerGrainContext` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_inspectionTimer` itself (line 38), which makes that instance its own. But `_inspectionTimer` is named in none of the methods the disposal search covered: `DisposeAsync` (line 107), `EnqueueWorkItem` (line 113) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_inspectionTimer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:33 — `ClusterManifestProvider` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_peerProbeSlots` itself (line 33), which makes that instance its own. But `_peerProbeSlots` is named in none of the methods the disposal search covered: `DisposeAsync` (line 793), `Dispose` (line 795), `StopAsync` (line 767), `DisposeAsync` (line 793) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_peerProbeSlots?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released src/Orleans.Runtime/MembershipService/MembershipAgent.cs:23 — `MembershipAgent` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `cancellation` itself (line 23), which makes that instance its own. But `cancellation` is named in none of the methods the disposal search covered: `Dispose` (line 449) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`cancellation?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
X2 · Cancellation propagation · Async endpoint handler without CancellationToken · ×6
  • Async endpoint handler without CancellationToken: /reset playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:38 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
  • Async endpoint handler without CancellationToken: /add playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Program.cs:42 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
  • Async endpoint handler without CancellationToken: /api/workflows/{workflowId:guid} playground/DurableJobsJournaling/DurableJobsJournaling.Web/Program.cs:66 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
  • Async endpoint handler without CancellationToken: /api/workflows/start playground/DurableJobsJournaling/DurableJobsJournaling.Web/Program.cs:71 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
  • Async endpoint handler without CancellationToken: /api/chaos/silo/kill playground/DurableJobsJournaling/DurableJobsJournaling.Web/Program.cs:79 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
  • Async endpoint handler without CancellationToken: /api/chaos/last playground/DurableJobsJournaling/DurableJobsJournaling.Web/Program.cs:85 — This endpoint's handler takes no CancellationToken, while it calls something that takes one — a client that disconnects leaves that work running. Add a `CancellationToken` parameter (minimal APIs bind it to the request's) and pass it on.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×5
  • Duplicated block (23 lines × 2) src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:82 — src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:82-104 | src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs:83-105 — before extracting anything, compare `src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs` and `src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (23 lines × 2) src/Orleans.Core/Utils/ObserverManager.cs:161 — src/Orleans.Core/Utils/ObserverManager.cs:161-183 | src/Orleans.Core/Utils/ObserverManager.cs:209-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Utils/ObserverManager.cs:161` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (23 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77 — src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77-99 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:108-130 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (23 lines × 2) docs/site/src/content/docs/grains/snippets/interceptors/LoggingFilters.cs:17 — docs/site/src/content/docs/grains/snippets/interceptors/LoggingFilters.cs:17-39 | docs/site/src/content/docs/grains/snippets/interceptors/LoggingFilters.cs:55-77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `context` to `IIncomingGrainCallContext` in one and `IOutgoingGrainCallContext` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (23 lines × 2) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:86 — docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:86-108 | docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:291-313 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×5
  • Duplicated block (17 lines × 2) src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:42 — src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:42-58 | src/Orleans.CodeGenerator/SyntaxGeneration/FSharpUtils.cs:83-99 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (17 lines × 2) src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:34 — src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:34-50 | src/Orleans.Streaming/Core/DefaultStreamIdMapper.cs:32-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:34` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `streamId` to `ChannelId` in one and `StreamId` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/ArrayCodec.cs:192 — src/Orleans.Serialization/Codecs/ArrayCodec.cs:192-208 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:352-368 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ArrayCodec.cs:192` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:124 — src/Orleans.CodeGenerator/CopierGenerator.cs:124-140 | src/Orleans.CodeGenerator/SerializerGenerator.cs:160-176 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:124` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:249 — src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:249-265 | src/Orleans.Serialization/Codecs/ListCodec.cs:59-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:249` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×5
  • Duplicated block (19 lines × 2) src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:52 — src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:52-70 | src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:129-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:128` calls `GetGeneratedInvokables`, `ToImmutableArray` and `src/Orleans.CodeGenerator/ProxySourceOutputGenerator.cs:51` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (19 lines × 2) src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:259 — src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:259-277 | src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:288-306 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.GrainDirectory.Redis/RedisGrainDirectory.cs:259` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257 — src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257-275 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:225-243 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 45 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:257` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143 — src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143-161 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:374-392 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:143` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableListCommandHandler<T>` in one and `IDurableSetCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (19 lines × 2) REDACTED.cs:31 — REDACTED.cs:31-49 | samples/ShoppingCart/Silo/Pages/Shop.razor.cs:31-49 — before extracting anything, compare `REDACTED.cs` and `samples/ShoppingCart/Silo/Pages/Shop.razor.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×5
  • Duplicated block (20 lines × 2) src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:546 — src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:546-565 | src/Orleans.Runtime/Core/InsideRuntimeClient.cs:673-692 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:546` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:287 — src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:287-306 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:255-274 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 45 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:81 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:81-100 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:89-108 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:81` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (20 lines × 2) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1422 — src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1422-1441 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:1019-1038 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) src/Orleans.Serialization/Serializer.cs:746 — src/Orleans.Serialization/Serializer.cs:746-765 | src/Orleans.Serialization/Serializer.cs:777-796 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:746` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×5
  • Duplicated block (11 lines × 3) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1449 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1449-1459 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1521-1531 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1575-1585 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1449` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (11 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:695 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:695-705 | src/Orleans.Serialization/Codecs/TupleCodec.cs:629-639 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:556-566 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
  • Duplicated block (11 lines × 3) src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:150 — src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:150-160 | src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:249-259 | src/Orleans.Serialization/Codecs/ByteArrayCodec.cs:360-370 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:113 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:113-123 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:127-137 | src/Orleans.Serialization/Codecs/ListCodec.cs:112-122 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:113` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:31 — src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:31-41 | src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:35-45 | src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:70-80 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TocFaultTransactionTestRunner.cs:47` calls `MultiGrainAdd`, `FailOperation`, `Should` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TOCGoldenPathTestRunner.cs:43` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×5
  • Duplicated block (6 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:27 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:27-32 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:28-33 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:28-33 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58-63 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:67-72 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:59-64 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 3) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:301 — src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:301-306 | src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:313-318 | src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs:281-286 — `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs` and `src/Orleans.EventSourcing/StateStorage/LogViewAdaptor.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 3 separate duplicated blocks between them, totalling at least 45 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:722 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:722-727 | src/Orleans.Serialization/Codecs/TupleCodec.cs:656-661 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:583-588 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:315 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:315-320 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:536-541 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:697-702 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:322` calls `Should`, `Be` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:704` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×4
  • Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:898-905 | src/Orleans.Serialization/Codecs/TupleCodec.cs:860-867 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1082-1090 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1322-1331 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:745-752 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:923-931 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1116-1125 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
  • Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:178 — src/Orleans.Serialization/Codecs/TupleCodec.cs:178-216 | src/Orleans.Serialization/Codecs/TupleCodec.cs:329-371 | src/Orleans.Serialization/Codecs/TupleCodec.cs:499-545 | src/Orleans.Serialization/Codecs/TupleCodec.cs:689-739 | src/Orleans.Serialization/Codecs/TupleCodec.cs:896-950 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1121-1179 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1362-1424 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
  • Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:200 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:200-225 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:322-348 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:460-487 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:611-639 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:777-806 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:958-988 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1153-1184 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
  • Members sharing a duplicated core (7 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:260 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:260-266 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:390-397 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:534-542 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:691-700 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:863-873 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1050-1061 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1251-1263 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×4
  • Duplicated block (14 lines × 3) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:191 — src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:191-204 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:309-322 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:439-452 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:191` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:972 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:972-985 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1113-1126 | src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:889-902 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:42 — src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:42-55 | src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:90-103 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:40-53 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (14 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:11 — src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:11-24 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs:21-34 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs:21-34 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×4
  • Duplicated block (5 lines × 3) src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169 — src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169-173 | src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:204-208 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:141-145 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs:169` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:409 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:409-413 | src/Orleans.Serialization/Codecs/TupleCodec.cs:302-306 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:296-300 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
  • Duplicated block (5 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:559 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:559-563 | src/Orleans.Serialization/Codecs/TupleCodec.cs:471-475 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:433-437 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342-346 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:632-640 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:687-695 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:632` calls `stateFactory` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:342` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
AC3 · Page structure · Page without a main landmark · ×3
  • Page without a main landmark playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark playground/DurableJobsJournaling/DurableJobsJournaling.Web/wwwroot/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×3
  • Duplicated block (28 lines × 2) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:48 — src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:48-75 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:646-673 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (28 lines × 2) src/Orleans.BroadcastChannel/SubscriberTable/Predicates/ImplicitChannelSubscriptionAttribute.cs:75 — src/Orleans.BroadcastChannel/SubscriberTable/Predicates/ImplicitChannelSubscriptionAttribute.cs:75-102 | src/Orleans.Streaming/Predicates/StreamSubscriptionAttributes.cs:76-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (28 lines × 2) samples/Blazor/BlazorServer/Grains/TodoGrain.cs:45 — samples/Blazor/BlazorServer/Grains/TodoGrain.cs:45-72 | samples/Blazor/BlazorWasm/BlazorWasm.Server/Grains/TodoGrain.cs:46-73 — before extracting anything, compare `samples/Blazor/BlazorServer/Grains/TodoGrain.cs` and `samples/Blazor/BlazorWasm/BlazorWasm.Server/Grains/TodoGrain.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×3
  • Duplicated block (25 lines × 2) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:61 — src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:61-85 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:68-92 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (25 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:200 — src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:200-224 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:261-285 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 122 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (25 lines × 2) samples/Blazor/BlazorServer/Grains/TodoGrain.cs:17 — samples/Blazor/BlazorServer/Grains/TodoGrain.cs:17-41 | samples/Blazor/BlazorWasm/BlazorWasm.Server/Grains/TodoGrain.cs:18-42 — before extracting anything, compare `samples/Blazor/BlazorServer/Grains/TodoGrain.cs` and `samples/Blazor/BlazorWasm/BlazorWasm.Server/Grains/TodoGrain.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×3
  • Duplicated block (24 lines × 2) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:631 — src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:631-654 | src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:667-690 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:631` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (24 lines × 2) src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:196 — src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:196-219 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:314-337 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:196` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (24 lines × 2) samples/Deployment/AzureAppService/Silo/Services/ShoppingCartService.cs:14 — samples/Deployment/AzureAppService/Silo/Services/ShoppingCartService.cs:14-37 | samples/ShoppingCart/Silo/Services/ShoppingCartService.cs:14-37 — before extracting anything, compare `samples/Deployment/AzureAppService/Silo/Services/ShoppingCartService.cs` and `samples/ShoppingCart/Silo/Services/ShoppingCartService.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×3
  • Duplicated block (17 lines × 3) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:167 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:167-183 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:144-160 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:188-204 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (17 lines × 3) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:21 — src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:21-37 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:21-37 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:20-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
  • Duplicated block (17 lines × 3) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:304 — src/Orleans.Serialization/Codecs/DictionaryCodec.cs:304-320 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:72-88 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:147-163 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/DictionaryCodec.cs:304` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×3
  • Duplicated block (13 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:89 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:89-101 | src/Orleans.Serialization/Codecs/ListCodec.cs:88-100 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:97-109 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:89` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 3) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:85 — src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:85-97 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:73-85 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:85-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `ImmutableHashSet<T>` in one and `ImmutableSortedSet<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:868 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:868-880 | src/Orleans.Serialization/Codecs/TupleCodec.cs:830-842 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:715-727 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (14–16 lines × 2) · ×3
  • Duplicated block (14–16 lines × 2) src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:117 — src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:117-132 | src/Orleans.Runtime/Cancellation/CancellationSourcesExtension.cs:64-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Runtime/GrainReferenceRuntime.cs:117` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14–16 lines × 2) docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileSiloBuilderExtensions.cs:35 — docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileSiloBuilderExtensions.cs:35-50 | src/Orleans.Runtime/Persistence/FileStorage/FileSiloBuilderExtensions.cs:65-78 — before extracting anything, compare `docs/site/src/content/docs/tutorials-and-samples/snippets/custom-grain-storage/FileSiloBuilderExtensions.cs` and `src/Orleans.Runtime/Persistence/FileStorage/FileSiloBuilderExtensions.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (14–16 lines × 2) src/Azure/Shared/Storage/AzureTableDataManager.cs:178 — src/Azure/Shared/Storage/AzureTableDataManager.cs:178-191 | src/Azure/Shared/Storage/AzureTableDataManager.cs:335-350 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Shared/Storage/AzureTableDataManager.cs:178` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×3
  • Duplicated block (13 lines × 4) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:79 — src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:79-91 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:86-98 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:69-81 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:76-88 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:79` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 4) src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:653 — src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:653-665 | src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:799-811 | src/Orleans.Transactions/TransactionAttribute.cs:504-516 | src/Orleans.Transactions/TransactionAttribute.cs:674-686 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core.Abstractions/Runtime/GrainReference.cs:653` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 4) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64-76 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:60-75 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:58-73 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:243-259 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:64` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×3
  • Duplicated block (12 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:599 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:599-610 | src/Orleans.Serialization.FSharp/FSharpCodecs.cs:764-775 | src/Orleans.Serialization.FSharp/FSharpCodecs.cs:943-954 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:599` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:38 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:38-49 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:44-55 | src/Orleans.Serialization/Codecs/ListCodec.cs:37-48 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 3) src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs:99 — src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs:99-110 | src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs:100-111 | src/Orleans.Serialization/Codecs/ImmutableSortedDictionaryCodec.cs:105-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×3
  • Duplicated block (9 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:576 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:576-584 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:369-377 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:542-550 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:536 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:536-544 | src/Orleans.Serialization/Codecs/TupleCodec.cs:448-456 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:410-418 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
  • Duplicated block (9 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:468 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:468-476 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:515-523 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:556-564 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:468` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×3
  • Duplicated block (8 lines × 4) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:131 — src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:131-138 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:58-65 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:61-68 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:90-97 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once.
  • Duplicated block (8 lines × 4) src/Orleans.Serialization/Codecs/TupleCodec.cs:695 — src/Orleans.Serialization/Codecs/TupleCodec.cs:695-702 | src/Orleans.Serialization/Codecs/TupleCodec.cs:902-909 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1127-1134 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1368-1375 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:910` calls `default` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:703` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 4) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:58 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:58-65 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:83-90 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:54-61 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:56-63 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `items` to `IReadOnlyCollection<KeyValuePair<TKey, TValue>>` in one and `IReadOnlyCollection<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D5 · Coupling · Off the main sequence · ×3
  • Off the main sequence: Orleans.Persistence.Memory(net8.0) src/Orleans.Persistence.Memory/Orleans.Persistence.Memory.csproj:1 — Orleans.Persistence.Memory(net8.0): abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: Orleans.Runtime(net8.0) src/Orleans.Runtime/Orleans.Runtime.csproj:1 — Orleans.Runtime(net8.0): abstractness 0.20, instability 0.03, distance 0.77 — zone of pain — concrete and depended on by 28 project(s), so it's rigid to change.
  • Off the main sequence: Orleans.Serialization(net8.0) src/Orleans.Serialization/Orleans.Serialization.csproj:1 — Orleans.Serialization(net8.0): abstractness 0.16, instability 0.11, distance 0.73 — zone of pain — concrete and depended on by 8 project(s), so it's rigid to change.
IC1 · Incompleteness & stubs · Empty method body · ×3
  • Empty method body — does nothing with its inputs docs/site/src/content/docs/migration/snippets/Orleans10MigrationExamples.cs:79 — `DoWorkAsync` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs src/Orleans.Runtime/Silo/Silo.cs:190 — `OnRuntimeServicesStart` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs src/Orleans.Serialization/Codecs/ArgumentNullExceptionPolyfill.cs:41 — `ThrowIfNull` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×3
  • Swallowed exception (caught, then discarded) src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:388 — `catch (OverflowException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
  • Swallowed exception (caught, then discarded) src/Orleans.Runtime/MembershipService/UnknownSiloStatusCache.cs:114 — `catch (Exception) when (…)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
  • Swallowed exception (caught, then discarded) src/Orleans.Serialization/Invocation/Pools/ConcurrentObjectPool.cs:52 — `catch (ObjectDisposedException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
AC6 · Visual & motion safety · Focus outline removed in CSS without a · ×2
  • Focus outline removed in CSS without a :focus replacement src/Dashboard/Orleans.Dashboard.App/src/custom.css:56 — `.log-filter` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement src/Dashboard/Orleans.Dashboard.App/src/custom.css:91 — `.alert .close:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D1 · Cyclomatic Complexity · ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) · ×2
  • ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) src/Orleans.Serialization/Cloning/IDeepCopier.cs:332 — ShallowCopyableTypes.IsShallowCopyableInternal has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: one other method here (ShallowCopyableTypes.IsShallowCopyableInternal) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • ShallowCopyableTypes.IsShallowCopyableInternal (cyclomatic 19) src/Orleans.Serialization/Cloning/IDeepCopier.cs:337 — ShallowCopyableTypes.IsShallowCopyableInternal has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: one other method here (ShallowCopyableTypes.IsShallowCopyableInternal) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D17 · Explicit Debt · XxxComment · ×2
  • XxxComment src/Orleans.TestingHost/InProcTestCluster.cs:297 — // As a result, we will get "MSTest: Unit Test Adapter threw exception: Type is not resolved for member XXX"
  • XxxComment src/Orleans.TestingHost/TestCluster.cs:378 — // As a result, we will get "MSTest: Unit Test Adapter threw exception: Type is not resolved for member XXX"
D2 · Cognitive Complexity · CodecProvider.TryGetSurrogateCodec (cognitive 25) · ×2
  • CodecProvider.TryGetSurrogateCodec (cognitive 25) src/Orleans.Serialization/Serializers/CodecProvider.cs:1106 — CodecProvider.TryGetSurrogateCodec has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (CodecProvider.TryGetSurrogateCodec) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • CodecProvider.TryGetSurrogateCodec (cognitive 25) src/Orleans.Serialization/Serializers/CodecProvider.cs:1111 — CodecProvider.TryGetSurrogateCodec has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (CodecProvider.TryGetSurrogateCodec) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) · ×2
  • OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:308 — OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore (cognitive 23) src/Orleans.Serialization/GeneratedCodeHelpers/OrleansGeneratedCodeHelper.cs:313 — OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (OrleansGeneratedCodeHelper.GetMethodInfoOrDefaultCore) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ProxyInterfaceDescription.ValidateBaseClass · ×2
  • ProxyInterfaceDescription.ValidateBaseClass::ValidateGenericInvokeAsync (cognitive 22) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:121 — ProxyInterfaceDescription.ValidateBaseClass::ValidateGenericInvokeAsync has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ProxyInterfaceDescription.ValidateBaseClass::ValidateNonGenericInvokeAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • ProxyInterfaceDescription.ValidateBaseClass::ValidateNonGenericInvokeAsync (cognitive 22) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:195 — ProxyInterfaceDescription.ValidateBaseClass::ValidateNonGenericInvokeAsync has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 2 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ProxyInterfaceDescription.ValidateBaseClass::ValidateGenericInvokeAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:990 — src/Orleans.Serialization/Codecs/TupleCodec.cs:990-997 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1223-1231 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1472-1481 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:845-852 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1031-1039 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1231-1240 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
  • Members sharing a duplicated core (6 members, 50+ identical tokens) src/Orleans.Serialization/Serializer.cs:80 — src/Orleans.Serialization/Serializer.cs:80-87 | src/Orleans.Serialization/Serializer.cs:98-104 | src/Orleans.Serialization/Serializer.cs:182-190 | src/Orleans.Serialization/Serializer.cs:232-239 | src/Orleans.Serialization/Serializer.cs:250-256 | src/Orleans.Serialization/Serializer.cs:266-273 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:81 — src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:81-102 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:69-90 | src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:69-90 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:81-102 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:71-92 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:38-63 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:46-84 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:65-115 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:52-104 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:96-147 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×2
  • Duplicated block (42 lines × 2) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:123 — src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:123-164 | src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:197-238 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (42 lines × 2) samples/Streaming/CustomDataAdapter/Grains/ConsumerGrain.cs:28 — samples/Streaming/CustomDataAdapter/Grains/ConsumerGrain.cs:28-69 | samples/Streaming/Simple/Grains/ConsumerGrain.cs:28-70 — before extracting anything, compare `samples/Streaming/CustomDataAdapter/Grains/ConsumerGrain.cs` and `samples/Streaming/Simple/Grains/ConsumerGrain.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `samples/Streaming/CustomDataAdapter/Grains/ConsumerGrain.cs:28` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×2
  • Duplicated block (30 lines × 2) src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:134 — src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:134-163 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:178-207 — before extracting anything, compare `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` and `src/Orleans.Serialization.SystemTextJson/JsonCodec.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 122 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (30 lines × 2) REDACTED.cs:16 — REDACTED.cs:16-45 | samples/ShoppingCart/Silo/Pages/Cart.razor.cs:16-45 — before extracting anything, compare `REDACTED.cs` and `samples/ShoppingCart/Silo/Pages/Cart.razor.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×2
  • Duplicated block (26 lines × 2) src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:553 — src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:553-578 | src/AdoNet/Shared/Storage/RelationalOrleansQueries.cs:594-619 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (26 lines × 2) src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs:27 — src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs:27-52 | src/AWS/Orleans.Transactions.DynamoDB/Options/DynamoDBTransactionalStorageOptions.cs:31-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (22–23 lines × 2) · ×2
  • Duplicated block (22–23 lines × 2) src/Orleans.BroadcastChannel/ChannelId.cs:170 — src/Orleans.BroadcastChannel/ChannelId.cs:170-191 | src/Orleans.Streaming/StreamId.cs:186-208 — before extracting anything, compare `src/Orleans.BroadcastChannel/ChannelId.cs` and `src/Orleans.Streaming/StreamId.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (22–23 lines × 2) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:127 — src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:127-149 | src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:211-232 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:209` calls `DelayBeforeRetry` and `src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:126` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 3) · ×2
  • Duplicated block (19 lines × 3) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1406 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1406-1424 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1469-1487 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1539-1557 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (19 lines × 3) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:994 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:994-1012 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:1130-1148 | src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:906-924 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×2
  • Duplicated block (16 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:51 — src/AWS/Orleans.Journaling.S3/S3JournalStorageInstruments.cs:51-66 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs:51-66 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs:51-66 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageInstruments.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageInstruments.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 3) src/Orleans.Serialization/Codecs/HashSetCodec.cs:69 — src/Orleans.Serialization/Codecs/HashSetCodec.cs:69-84 | src/Orleans.Serialization/Codecs/HashSetCodec.cs:143-159 | src/Orleans.Serialization/Codecs/InterfaceCollectionCodecs.cs:370-385 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/HashSetCodec.cs:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 7) · ×2
  • Duplicated block (14 lines × 7) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:28 — src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:28-41 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:61-74 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:25-38 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:26-39 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:24-37 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:27-40 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:68-81 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 7) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:204 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:204-217 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:326-339 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:464-477 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:615-628 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:781-794 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:962-975 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1157-1170 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:204` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `reader` to `T2) ReadValue<TInput>(ref Reader<TInput>` in one and `T3) ReadValue<TInput>(ref Reader<TInput>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:340` calls `ReadValue` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:218` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 8) · ×2
  • Duplicated block (12 lines × 8) src/Orleans.Serialization/Codecs/TupleCodec.cs:114 — src/Orleans.Serialization/Codecs/TupleCodec.cs:114-125 | src/Orleans.Serialization/Codecs/TupleCodec.cs:254-265 | src/Orleans.Serialization/Codecs/TupleCodec.cs:416-427 | src/Orleans.Serialization/Codecs/TupleCodec.cs:595-606 | src/Orleans.Serialization/Codecs/TupleCodec.cs:794-805 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1010-1021 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1244-1255 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1494-1505 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:431` calls `IsShallowCopyable`, `DeepCopy` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:269` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 8) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40 — src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40-51 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:73-84 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:37-48 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:28-39 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:38-49 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:36-47 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:39-50 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:80-91 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×2
  • Duplicated block (15 lines × 4) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1128 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1128-1142 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1407-1423 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1470-1486 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1540-1556 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1487` calls `StringBuilder` and `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1143` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 4) docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:13 — docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:13-30 | docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:35-52 | docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:225-239 | docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:244-264 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×2
  • Duplicated block (11–12 lines × 2) src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46 — src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46-56 | src/Orleans.Analyzers/IdClashAttributeCodeFix.cs:41-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/AliasClashAttributeCodeFix.cs:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11–12 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:469 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:469-479 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:516-527 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×2
  • Duplicated block (10 lines × 4) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:142 — src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:142-151 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:255-264 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:373-382 | src/Orleans.Journaling/Formats/Json/JsonDurableDictionaryCommandCodec.cs:116-125 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:142` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `consumer` to `IDurableListCommandHandler<T>` in one and `IDurableQueueCommandHandler<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (10 lines × 4) src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:106 — src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:106-115 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:144-153 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:201-210 | src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:232-241 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:106` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×2
  • Duplicated block (11 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39-49 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:48-58 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:75-85 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:53-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:39` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:61` calls `LogInformationInitializingMembershipTable` and `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:88` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 4) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286-296 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:316-326 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:403-413 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:537-547 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:286` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×2
  • Duplicated block (9–10 lines × 2) src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68 — src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68-77 | src/Orleans.Clustering.ZooKeeper/ZooKeeperGatewayListProvider.cs:90-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Clustering.Consul/ConsulGatewayListProvider.cs:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9–10 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113 — src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113-121 | src/Azure/Orleans.Clustering.AzureStorage/SiloInstanceTableEntry.cs:91-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:113` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) src/Orleans.Serialization/Codecs/IntegerCodec.cs:507 — src/Orleans.Serialization/Codecs/IntegerCodec.cs:507-514 | src/Orleans.Serialization/Codecs/IntegerCodec.cs:532-539 | src/Orleans.Serialization/Codecs/IntegerCodec.cs:558-565 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (8 lines × 3) src/Orleans.Serialization/Buffers/Writer.cs:451 — src/Orleans.Serialization/Buffers/Writer.cs:451-458 | src/Orleans.Serialization/Buffers/Writer.cs:485-492 | src/Orleans.Serialization/Buffers/Writer.cs:510-517 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Writer.cs:451` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×2
  • Duplicated block (7 lines × 3) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:899 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:899-905 | src/Orleans.Serialization/Codecs/TupleCodec.cs:861-867 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:746-752 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:234 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:234-240 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:266-272 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:372-378 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:380` calls `MakePendingState`, `stateFactory`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:275` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 7) · ×2
  • Duplicated block (5 lines × 7) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:188 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:188-192 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:309-313 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:446-450 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:596-600 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:760-764 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:939-943 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1134-1138 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:314` calls `WriteField` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:194` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 7) src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:260 — src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:260-264 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:390-394 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:534-538 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:691-695 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:863-867 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1050-1054 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1251-1255 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `input` to `ValueTuple<T1, T2>` in one and `ValueTuple<T1, T2, T3>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:395` calls `IsShallowCopyable`, `DeepCopy` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:265` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×2
  • Duplicated block (6 lines × 4) src/Orleans.Serialization/Serializer.cs:82 — src/Orleans.Serialization/Serializer.cs:82-87 | src/Orleans.Serialization/Serializer.cs:99-104 | src/Orleans.Serialization/Serializer.cs:234-239 | src/Orleans.Serialization/Serializer.cs:251-256 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Serializer.cs:82` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 4) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:48 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs:48-53 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:73-78 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:44-49 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:46-51 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableDictionaryCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
IC1 · Incompleteness & stubs · Both branches are identical · ×2
  • Both branches are identical — the condition decides nothing docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:630 — Both arms of `backtickIdx >= 0 ? … : …` are `containingTypeName`, so no input can make the condition matter. Implement the distinction that was intended, or drop the condition.
  • Both branches are identical — the condition decides nothing src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:838 — The `if` and its `else` contain the same 2 statements, so no input can make the condition matter. Implement the distinction that was intended, or drop the branch and keep the body.
IC1 · Incompleteness & stubs · Dead `#if false` region · ×2
  • Dead `#if false` region src/Orleans.Runtime/Core/InsideRuntimeClient.cs:270 — Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
  • Dead `#if false` region src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:250 — Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
P12 · CI test-gate honesty · Test sources removed from compilation · ×2
  • Test sources removed from compilation docs/site/src/content/docs/grains/snippets/testing/orleans-testing/Sample.OrleansTesting/Sample.OrleansTesting.csproj:21 — `<Compile Remove="MSTestClusterFixture.cs" />` in a test project removes 1 file(s) that declare tests (`docs/site/src/content/docs/grains/snippets/testing/orleans-testing/Sample.OrleansTesting/MSTestClusterFixture.cs`) — they are never built, so no gate runs them. Delete the tests or bring them back into the build.
  • Test sources removed from compilation test/Extensions/Orleans.Streaming.EventHubs.Tests/Orleans.Streaming.EventHubs.Tests.csproj:28 — `<Compile Remove="EventHubsAspireIntegrationTests.cs" />` in a test project removes 1 file(s) that declare tests (`test/Extensions/Orleans.Streaming.EventHubs.Tests/EventHubsAspireIntegrationTests.cs`) — they are never built, so no gate runs them. Delete the tests or bring them back into the build.
R10 · Code Duplication · Duplicated block (15 lines × 2 locations) · ×2
  • Duplicated block (15 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36 — src/Dashboard/Orleans.Dashboard.App/src/grains/grains.tsx:36 · src/Dashboard/Orleans.Dashboard.App/src/silos/silos.tsx:28 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
  • Duplicated block (15 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:203 — src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:203 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:238 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
X18 · Disposal-pattern correctness · Finalizer on a type that owns no unmanaged resource · ×2
  • Finalizer on a type that owns no unmanaged resource src/Orleans.TestingHost/SiloHandle.cs:73 — `SiloHandle` declares a finalizer (line 73), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
  • Finalizer on a type that owns no unmanaged resource src/Orleans.TestingHost/TestClusterPortAllocator.cs:110 — `TestClusterPortAllocator` declares a finalizer (line 110), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
X2 · Cancellation propagation · Async local function without CancellationToken · ×2
  • Async local function without CancellationToken: ExecuteLateCallback src/Orleans.Core/Lifecycle/ServiceLifecycleNotificationStage.cs:89 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
  • Async local function without CancellationToken: SendAsync src/Orleans.Core/Messaging/ClientMessageCenter.cs:197 — Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
AC3 · Page structure · Data table has no header cells · ×1
  • Data table has no header cells src/Dashboard/Orleans.Dashboard.App/src/components/grain-method-table.tsx:42 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
AC4 · Keyboard semantics · Link used as a button (placeholder href) · ×1
  • Link used as a button (placeholder href) REDACTED:129 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
AC6 · Visual & motion safety · Animation without a prefers-reduced-motion guard · ×1
  • Animation without a prefers-reduced-motion guard playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:276 — `.loading` moves (`animation: pulse 2s infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (4.0 · ×1
  • Low contrast colour pair in CSS (4.0:1) playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:15 — `.absolute-button` sets color: white on background-color: #007bff — 4.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC7 · A11y enforcement · Accessibility enforcement below the top rung · ×1
  • Accessibility enforcement below the top rung — No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 37 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
C1 · Data Protection · No data-protection/encryption · ×1
  • No data-protection/encryption — No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.
D1 · Cyclomatic Complexity · JournaledStateManager.WorkLoop (cyclomatic 59) · ×1
  • JournaledStateManager.WorkLoop (cyclomatic 59) src/Orleans.Journaling/JournaledStateManager.cs:187 — JournaledStateManager.WorkLoop has cyclomatic complexity 59 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ActivationData.RunMessageLoop (cyclomatic 57) · ×1
  • ActivationData.RunMessageLoop (cyclomatic 57) src/Orleans.Runtime/Catalog/ActivationData.cs:1119 — ActivationData.RunMessageLoop has cyclomatic complexity 57 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cyclomatic 50) · ×1
  • ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cyclomatic 50) src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22 — ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProxyGenerator.CreateProxyMethods (cyclomatic 49) · ×1
  • ProxyGenerator.CreateProxyMethods (cyclomatic 49) src/Orleans.CodeGenerator/ProxyGenerator.cs:85 — ProxyGenerator.CreateProxyMethods has cyclomatic complexity 49 (threshold 15). Of this number, 19 points are the body's own statements and 30 belong to 4 function items inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · SerializerFactoryGenerator.Describe (cyclomatic 44) · ×1
  • SerializerFactoryGenerator.Describe (cyclomatic 44) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:205 — SerializerFactoryGenerator.Describe has cyclomatic complexity 44 (threshold 15). Of this number, 43 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SocketMessageTransport.ProcessWrites (cyclomatic 40) · ×1
  • SocketMessageTransport.ProcessWrites (cyclomatic 40) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:532 — SocketMessageTransport.ProcessWrites has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersistentStreamPullingAgent.RunConsumerCursor (cyclomatic 40) · ×1
  • PersistentStreamPullingAgent.RunConsumerCursor (cyclomatic 40) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248 — PersistentStreamPullingAgent.RunConsumerCursor has cyclomatic complexity 40 (threshold 15). Of this number, 38 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PackageJsonGenerator.GeneratePackageJson (cyclomatic 40) · ×1
  • PackageJsonGenerator.GeneratePackageJson (cyclomatic 40) docs/tools/PackageJsonGenerator/PackageJsonGenerator.cs:17 — PackageJsonGenerator.GeneratePackageJson has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MembershipModelExecutionContext.ExecuteAsync (cyclomatic 39) · ×1
  • MembershipModelExecutionContext.ExecuteAsync (cyclomatic 39) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:314 — MembershipModelExecutionContext.ExecuteAsync has cyclomatic complexity 39 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PersistentStreamPullingAgent.DoHandshakeWithConsumer (cyclomatic 39) · ×1
  • PersistentStreamPullingAgent.DoHandshakeWithConsumer (cyclomatic 39) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:403 — PersistentStreamPullingAgent.DoHandshakeWithConsumer has cyclomatic complexity 39 (threshold 15). Of this number, 37 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PdbSourceReader.GetMemberSource (cyclomatic 37) · ×1
  • PdbSourceReader.GetMemberSource (cyclomatic 37) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:403 — PdbSourceReader.GetMemberSource has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ActivationData.FinishDeactivating (cyclomatic 35) · ×1
  • ActivationData.FinishDeactivating (cyclomatic 35) src/Orleans.Runtime/Catalog/ActivationData.cs:2180 — ActivationData.FinishDeactivating has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializerFactoryGenerator.DescribeReferenced (cyclomatic 34) · ×1
  • SerializerFactoryGenerator.DescribeReferenced (cyclomatic 34) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:334 — SerializerFactoryGenerator.DescribeReferenced has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializerFactoryGenerator.AppendTypeMetadata (cyclomatic 34) · ×1
  • SerializerFactoryGenerator.AppendTypeMetadata (cyclomatic 34) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:474 — SerializerFactoryGenerator.AppendTypeMetadata has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CanonicalModelBuilder.ExtractDocumentation (cyclomatic 34) · ×1
  • CanonicalModelBuilder.ExtractDocumentation (cyclomatic 34) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:371 — CanonicalModelBuilder.ExtractDocumentation has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · link-audit.auditRenderedInternalLinks (cyclomatic 33) · ×1
  • link-audit.auditRenderedInternalLinks (cyclomatic 33) docs/site/scripts/lib/link-audit.mjs:692 — link-audit.auditRenderedInternalLinks has cyclomatic complexity 33 (threshold 15). Of this number, 29 points are the body's own statements and 4 belong to 4 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SchemaEmitter.EmitType (cyclomatic 32) · ×1
  • SchemaEmitter.EmitType (cyclomatic 32) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:69 — SchemaEmitter.EmitType has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializerFactoryGenerator.TryCreate (cyclomatic 31) · ×1
  • SerializerFactoryGenerator.TryCreate (cyclomatic 31) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:34 — SerializerFactoryGenerator.TryCreate has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SchemaEmitter.EmitMember (cyclomatic 31) · ×1
  • SchemaEmitter.EmitMember (cyclomatic 31) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:231 — SchemaEmitter.EmitMember has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cyclomatic 30) · ×1
  • GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cyclomatic 30) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:518 — GrainInterfaceVersionCodeFix.AppendHistoricalContracts has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryTypes.IsShallowCopyable (cyclomatic 30) · ×1
  • LibraryTypes.IsShallowCopyable (cyclomatic 30) src/Orleans.CodeGenerator/LibraryTypes.cs:325 — LibraryTypes.IsShallowCopyable has cyclomatic complexity 30 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · ActivationData.ActivateAsync (cyclomatic 30) · ×1
  • ActivationData.ActivateAsync (cyclomatic 30) src/Orleans.Runtime/Catalog/ActivationData.cs:1881 — ActivationData.ActivateAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CodecProvider.ConsumeMetadata (cyclomatic 29) · ×1
  • CodecProvider.ConsumeMetadata (cyclomatic 29) src/Orleans.Serialization/Serializers/CodecProvider.cs:94 — CodecProvider.ConsumeMetadata has cyclomatic complexity 29 (threshold 15). Of this number, 25 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RuntimeTypeNameParser.ParseInternal (cyclomatic 29) · ×1
  • RuntimeTypeNameParser.ParseInternal (cyclomatic 29) src/Orleans.Serialization/TypeSystem/RuntimeTypeNameParser.cs:53 — RuntimeTypeNameParser.ParseInternal has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CanonicalModelBuilder.CollectNodes (cyclomatic 29) · ×1
  • CanonicalModelBuilder.CollectNodes (cyclomatic 29) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:771 — CanonicalModelBuilder.CollectNodes has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RedisJournalStorageProvider.ListAsync (cyclomatic 28) · ×1
  • RedisJournalStorageProvider.ListAsync (cyclomatic 28) src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63 — RedisJournalStorageProvider.ListAsync has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Silo.render (cyclomatic 28) · ×1
  • Silo.render (cyclomatic 28) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:142 — Silo.render has cyclomatic complexity 28 (threshold 15). Of this number, 26 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · GrainInterfaceVersionCodeFix.SortContractEntries (cyclomatic 27) · ×1
  • GrainInterfaceVersionCodeFix.SortContractEntries (cyclomatic 27) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1670 — GrainInterfaceVersionCodeFix.SortContractEntries has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ClusterManifestProvider.UpdateManifest (cyclomatic 27) · ×1
  • ClusterManifestProvider.UpdateManifest (cyclomatic 27) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:241 — ClusterManifestProvider.UpdateManifest has cyclomatic complexity 27 (threshold 15). Of this number, 26 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GrainInterfaceUtils.GetMethods (cyclomatic 26) · ×1
  • GrainInterfaceUtils.GetMethods (cyclomatic 26) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:22 — GrainInterfaceUtils.GetMethods has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 4 of the 26 points are its own statements and the rest belongs to 3 function items inside it that branch (GetMethodsImpl, IsGrainInterface, GetGrainInterfaces). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · TypeConverter.ConsumeMetadata (cyclomatic 26) · ×1
  • TypeConverter.ConsumeMetadata (cyclomatic 26) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151 — TypeConverter.ConsumeMetadata has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellHostedService.ExecuteAsync (cyclomatic 26) · ×1
  • ShellHostedService.ExecuteAsync (cyclomatic 26) samples/Chirper/Chirper.Client/ShellHostedService.cs:24 — ShellHostedService.ExecuteAsync has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · markdown-ranges.fallbackProtectedLineRanges (cyclomatic 26) · ×1
  • markdown-ranges.fallbackProtectedLineRanges (cyclomatic 26) docs/site/scripts/lib/markdown-ranges.mjs:238 — markdown-ranges.fallbackProtectedLineRanges has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProxyInterfaceDescription.ValidateBaseClass (cyclomatic 25) · ×1
  • ProxyInterfaceDescription.ValidateBaseClass (cyclomatic 25) src/Orleans.CodeGenerator/Model/ProxyInterfaceDescription.cs:116 — ProxyInterfaceDescription.ValidateBaseClass has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to 2 function items inside it that branch (ValidateGenericInvokeAsync, ValidateNonGenericInvokeAsync). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · Striped64.LongAccumulate (cyclomatic 25) · ×1
  • Striped64.LongAccumulate (cyclomatic 25) src/Orleans.Core/Caching/Internal/Striped64.cs:151 — Striped64.LongAccumulate has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ActivationRepartitioner.AcceptExchangeRequest (cyclomatic 25) · ×1
  • ActivationRepartitioner.AcceptExchangeRequest (cyclomatic 25) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:270 — ActivationRepartitioner.AcceptExchangeRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · S3JournalStorageProvider.ListAsync (cyclomatic 25) · ×1
  • S3JournalStorageProvider.ListAsync (cyclomatic 25) src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs:48 — S3JournalStorageProvider.ListAsync has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cyclomatic 25) · ×1
  • DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cyclomatic 25) src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:23 — DynamoDBReminderStorageOptionsExtensions.ParseConnectionString has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PooledQueueCache.TryGetNextMessageWithResult (cyclomatic 24) · ×1
  • PooledQueueCache.TryGetNextMessageWithResult (cyclomatic 24) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502 — PooledQueueCache.TryGetNextMessageWithResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · project-policy.validateProjectEvaluations (cyclomatic 24) · ×1
  • project-policy.validateProjectEvaluations (cyclomatic 24) docs/site/scripts/lib/project-policy.mjs:184 — project-policy.validateProjectEvaluations has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Impl.AnalyzeNamedType (cyclomatic 23) · ×1
  • Impl.AnalyzeNamedType (cyclomatic 23) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308 — Impl.AnalyzeNamedType has cyclomatic complexity 23 (threshold 15). Of this number, 22 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SerializerGenerator.GetFieldDescriptions (cyclomatic 23) · ×1
  • SerializerGenerator.GetFieldDescriptions (cyclomatic 23) src/Orleans.CodeGenerator/SerializerGenerator.cs:264 — SerializerGenerator.GetFieldDescriptions has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BatchOperation.Flush (cyclomatic 23) · ×1
  • BatchOperation.Flush (cyclomatic 23) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:413 — BatchOperation.Flush has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReadWriteLock.EnterLock (cyclomatic 23) · ×1
  • ReadWriteLock.EnterLock (cyclomatic 23) src/Orleans.Transactions/State/ReaderWriterLock.cs:66 — ReadWriteLock.EnterLock has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TransactionQueue.NotifyOfAbort (cyclomatic 23) · ×1
  • TransactionQueue.NotifyOfAbort (cyclomatic 23) src/Orleans.Transactions/State/TransactionQueue.cs:310 — TransactionQueue.NotifyOfAbort has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · link-audit.auditSourceLinks (cyclomatic 23) · ×1
  • link-audit.auditSourceLinks (cyclomatic 23) docs/site/scripts/lib/link-audit.mjs:418 — link-audit.auditSourceLinks has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JournaledJobShard.ProcessMutationBatchAsync (cyclomatic 22) · ×1
  • JournaledJobShard.ProcessMutationBatchAsync (cyclomatic 22) src/Orleans.DurableJobs/JournaledJobShard.cs:374 — JournaledJobShard.ProcessMutationBatchAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · Catalog.GetOrCreateActivation (cyclomatic 22) · ×1
  • Catalog.GetOrCreateActivation (cyclomatic 22) src/Orleans.Runtime/Catalog/Catalog.cs:135 — Catalog.GetOrCreateActivation has cyclomatic complexity 22 (threshold 15). Of this number, 16 points are the body's own statements and 6 belong to 2 function items inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · InsideRuntimeClient.Invoke (cyclomatic 22) · ×1
  • InsideRuntimeClient.Invoke (cyclomatic 22) src/Orleans.Runtime/Core/InsideRuntimeClient.cs:299 — InsideRuntimeClient.Invoke has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ClientDirectory.UpdateRoutingTable (cyclomatic 22) · ×1
  • ClientDirectory.UpdateRoutingTable (cyclomatic 22) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:230 — ClientDirectory.UpdateRoutingTable has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersistentStreamPullingAgent.ReadFromQueue (cyclomatic 22) · ×1
  • PersistentStreamPullingAgent.ReadFromQueue (cyclomatic 22) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:884 — PersistentStreamPullingAgent.ReadFromQueue has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SiloInstanceRecord.SiloInstanceRecord.ctor (cyclomatic 22) · ×1
  • SiloInstanceRecord.SiloInstanceRecord.ctor (cyclomatic 22) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:50 — SiloInstanceRecord.SiloInstanceRecord.ctor has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · GameGrain.MakeMove (cyclomatic 22) · ×1
  • GameGrain.MakeMove (cyclomatic 22) samples/TicTacToe/Grains/GameGrain.cs:69 — GameGrain.MakeMove has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · source-quality.parseDocumentedPackageTable (cyclomatic 22) · ×1
  • source-quality.parseDocumentedPackageTable (cyclomatic 22) docs/site/scripts/lib/source-quality.mjs:562 — source-quality.parseDocumentedPackageTable has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GrainInterfaceVersionCodeFix.CreateProjectRegenerationAsync (cyclomatic 21) · ×1
  • GrainInterfaceVersionCodeFix.CreateProjectRegenerationAsync (cyclomatic 21) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:148 — GrainInterfaceVersionCodeFix.CreateProjectRegenerationAsync has cyclomatic complexity 21 (threshold 15). Of this number, 15 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cyclomatic 21) · ×1
  • GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cyclomatic 21) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:617 — GrainInterfaceVersionCodeFix.MergeHistoricalMembers has cyclomatic complexity 21 (threshold 15). Of this number, 19 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CopierGenerator.GenerateCopier (cyclomatic 21) · ×1
  • CopierGenerator.GenerateCopier (cyclomatic 21) src/Orleans.CodeGenerator/CopierGenerator.cs:26 — CopierGenerator.GenerateCopier has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializationContractModelExtractor.Extract (cyclomatic 21) · ×1
  • SerializationContractModelExtractor.Extract (cyclomatic 21) src/Orleans.CodeGenerator/Model/SerializationContractModel.cs:24 — SerializationContractModelExtractor.Extract has cyclomatic complexity 21 (threshold 15). Of this number, 15 points are the body's own statements and 6 belong to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProxyGenerator.CreateAsyncProxyMethodBody (cyclomatic 21) · ×1
  • ProxyGenerator.CreateAsyncProxyMethodBody (cyclomatic 21) src/Orleans.CodeGenerator/ProxyGenerator.cs:279 — ProxyGenerator.CreateAsyncProxyMethodBody has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Message.TryFormat (cyclomatic 21) · ×1
  • Message.TryFormat (cyclomatic 21) src/Orleans.Core/Messaging/Message.cs:416 — Message.TryFormat has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JournaledJobShardManager.TryAssignShardAsync (cyclomatic 21) · ×1
  • JournaledJobShardManager.TryAssignShardAsync (cyclomatic 21) src/Orleans.DurableJobs/JournaledJobShardManager.cs:200 — JournaledJobShardManager.TryAssignShardAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShardExecutor.ExecuteJobAsync (cyclomatic 21) · ×1
  • ShardExecutor.ExecuteJobAsync (cyclomatic 21) src/Orleans.DurableJobs/ShardExecutor.cs:309 — ShardExecutor.ExecuteJobAsync has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LocalSiloHealthEventHistory.Aggregate (cyclomatic 21) · ×1
  • LocalSiloHealthEventHistory.Aggregate (cyclomatic 21) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:53 — LocalSiloHealthEventHistory.Aggregate has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MembershipAgent.ValidateInitialConnectivity (cyclomatic 21) · ×1
  • MembershipAgent.ValidateInitialConnectivity (cyclomatic 21) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:140 — MembershipAgent.ValidateInitialConnectivity has cyclomatic complexity 21 (threshold 15). Of this number, 17 points are the body's own statements and 4 belong to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ResourceOptimizedPlacementDirector.OnAddActivation (cyclomatic 21) · ×1
  • ResourceOptimizedPlacementDirector.OnAddActivation (cyclomatic 21) src/Orleans.Runtime/Placement/ResourceOptimizedPlacementDirector.cs:47 — ResourceOptimizedPlacementDirector.OnAddActivation has cyclomatic complexity 21 (threshold 15). Of this number, 18 points are the body's own statements and 3 belong to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DynamoDBTransactionalStateStorage.Store (cyclomatic 21) · ×1
  • DynamoDBTransactionalStateStorage.Store (cyclomatic 21) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144 — DynamoDBTransactionalStateStorage.Store has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cyclomatic 20) · ×1
  • GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cyclomatic 20) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1254 — GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync has cyclomatic complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cyclomatic 20) · ×1
  • MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cyclomatic 20) src/Orleans.Clustering.TestKit/MembershipTableModelBasedTestRunner.cs:45 — MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests has cyclomatic complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SerializerGenerator.GenerateDeserializeMethod (cyclomatic 20) · ×1
  • SerializerGenerator.GenerateDeserializeMethod (cyclomatic 20) src/Orleans.CodeGenerator/SerializerGenerator.cs:553 — SerializerGenerator.GenerateDeserializeMethod has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Utils.EnumerableToString (cyclomatic 20) · ×1
  • Utils.EnumerableToString (cyclomatic 20) src/Orleans.Core.Abstractions/Utils/Utils.cs:26 — Utils.EnumerableToString has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DurableJobsOptionsValidator.ValidateConfiguration (cyclomatic 20) · ×1
  • DurableJobsOptionsValidator.ValidateConfiguration (cyclomatic 20) src/Orleans.DurableJobs/Hosting/DurableJobsOptions.cs:228 — DurableJobsOptionsValidator.ValidateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ShardExecutor.RunShardAsync (cyclomatic 20) · ×1
  • ShardExecutor.RunShardAsync (cyclomatic 20) src/Orleans.DurableJobs/ShardExecutor.cs:72 — ShardExecutor.RunShardAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cyclomatic 20) · ×1
  • ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cyclomatic 20) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389 — ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 2 of the 20 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 410, 496). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · SiloClusteringValidator.ValidateConfiguration (cyclomatic 20) · ×1
  • SiloClusteringValidator.ValidateConfiguration (cyclomatic 20) src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs:25 — SiloClusteringValidator.ValidateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PersistentStreamPullingAgent.RegisterStream (cyclomatic 20) · ×1
  • PersistentStreamPullingAgent.RegisterStream (cyclomatic 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1076 — PersistentStreamPullingAgent.RegisterStream has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · TestClusterPortAllocator.GetAvailableConsecutiveServerPorts (cyclomatic 20) · ×1
  • TestClusterPortAllocator.GetAvailableConsecutiveServerPorts (cyclomatic 20) src/Orleans.TestingHost/TestClusterPortAllocator.cs:115 — TestClusterPortAllocator.GetAvailableConsecutiveServerPorts has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TestingUtils.WaitUntilSucceededAsync (cyclomatic 20) · ×1
  • TestingUtils.WaitUntilSucceededAsync (cyclomatic 20) src/Orleans.TestingHost/Utils/TestingUtils.cs:176 — TestingUtils.WaitUntilSucceededAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · markdown-ranges.startsHtmlBlock (cyclomatic 20) · ×1
  • markdown-ranges.startsHtmlBlock (cyclomatic 20) docs/site/scripts/lib/markdown-ranges.mjs:183 — markdown-ranges.startsHtmlBlock has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · include-closure.collectIncludeTargets · ×1
  • include-closure.collectIncludeTargets::collect (cyclomatic 20) docs/site/scripts/lib/include-closure.mjs:53 — include-closure.collectIncludeTargets::collect has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · compatibility-paths.compatibilityOutputPath (cyclomatic 20) · ×1
  • compatibility-paths.compatibilityOutputPath (cyclomatic 20) docs/site/scripts/lib/compatibility-paths.mjs:5 — compatibility-paths.compatibilityOutputPath has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · InvokableBaseTypeResolver.SatisfiesConstraints · ×1
  • InvokableBaseTypeResolver.SatisfiesConstraints::SatisfiesSpecialConstraints (cyclomatic 19) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:660 — InvokableBaseTypeResolver.SatisfiesConstraints::SatisfiesSpecialConstraints has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · MetadataGenerator.GenerateIncrementalMetadata (cyclomatic 19) · ×1
  • MetadataGenerator.GenerateIncrementalMetadata (cyclomatic 19) src/Orleans.CodeGenerator/MetadataGenerator.cs:29 — MetadataGenerator.GenerateIncrementalMetadata has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · InvokableMethodDescription.InvokableMethodDescription.ctor (cyclomatic 19) · ×1
  • InvokableMethodDescription.InvokableMethodDescription.ctor (cyclomatic 19) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:17 — InvokableMethodDescription.InvokableMethodDescription.ctor has cyclomatic complexity 19 (threshold 15). Of this number, 16 points are the body's own statements and 3 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cyclomatic 19) · ×1
  • SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cyclomatic 19) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:249 — SerializableTypeModelExtractor.TryExtractSerializableTypeModel has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cyclomatic 19) · ×1
  • AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cyclomatic 19) src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:208 — AsyncExecutorWithRetries.ExecuteWithRetriesHelper has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConnectionManager.Close (cyclomatic 19) · ×1
  • ConnectionManager.Close (cyclomatic 19) src/Orleans.Core/Networking/ConnectionManager.cs:345 — ConnectionManager.Close has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · DynamoDBMembershipHelper.ParseDataConnectionString (cyclomatic 19) · ×1
  • DynamoDBMembershipHelper.ParseDataConnectionString (cyclomatic 19) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:23 — DynamoDBMembershipHelper.ParseDataConnectionString has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DynamoDBStorage.UpdateTableAsync (cyclomatic 19) · ×1
  • DynamoDBStorage.UpdateTableAsync (cyclomatic 19) src/AWS/Shared/Storage/DynamoDBStorage.cs:272 — DynamoDBStorage.UpdateTableAsync has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · RedisJournalStorage.CreateStorageState (cyclomatic 19) · ×1
  • RedisJournalStorage.CreateStorageState (cyclomatic 19) src/Redis/Orleans.Journaling.Redis/RedisJournalStorage.cs:731 — RedisJournalStorage.CreateStorageState has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cyclomatic 19) · ×1
  • TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cyclomatic 19) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229 — TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase has cyclomatic complexity 19 (threshold 15). Of this number, 12 points are the body's own statements and 7 belong to 2 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · CanonicalModelBuilder.PrependModifiers (cyclomatic 19) · ×1
  • CanonicalModelBuilder.PrependModifiers (cyclomatic 19) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:302 — CanonicalModelBuilder.PrependModifiers has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · link-audit.probeExternalTargets · ×1
  • link-audit.probeExternalTargets::worker (cyclomatic 19) docs/site/scripts/lib/link-audit.mjs:1196 — link-audit.probeExternalTargets::worker has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · source-quality.validateReferenceInventories (cyclomatic 19) · ×1
  • source-quality.validateReferenceInventories (cyclomatic 19) docs/site/scripts/lib/source-quality.mjs:747 — source-quality.validateReferenceInventories has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InvokableBaseTypeResolver.TryConstructAndValidate (cyclomatic 18) · ×1
  • InvokableBaseTypeResolver.TryConstructAndValidate (cyclomatic 18) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:548 — InvokableBaseTypeResolver.TryConstructAndValidate has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SerializerGenerator.Generate (cyclomatic 18) · ×1
  • SerializerGenerator.Generate (cyclomatic 18) src/Orleans.CodeGenerator/SerializerGenerator.cs:30 — SerializerGenerator.Generate has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cyclomatic 18) · ×1
  • DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cyclomatic 18) src/Orleans.Runtime/GrainDirectory/DirectoryMembershipSnapshot.cs:34 — DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor has cyclomatic complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SiloHealthMonitor.Run (cyclomatic 18) · ×1
  • SiloHealthMonitor.Run (cyclomatic 18) src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs:174 — SiloHealthMonitor.Run has cyclomatic complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cyclomatic 18) · ×1
  • SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cyclomatic 18) src/Orleans.Serialization/Hosting/SerializerConfigurationAnalyzer.cs:29 — SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CodecProvider.BindTypeArguments (cyclomatic 18) · ×1
  • CodecProvider.BindTypeArguments (cyclomatic 18) src/Orleans.Serialization/Serializers/CodecProvider.cs:1238 — CodecProvider.BindTypeArguments has cyclomatic complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to one function item inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · LifecycleStageInspector.CleanMethodName (cyclomatic 18) · ×1
  • LifecycleStageInspector.CleanMethodName (cyclomatic 18) src/Dashboard/Orleans.Dashboard/Implementation/LifecycleStageInspector.cs:210 — LifecycleStageInspector.CleanMethodName has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AzureTableTransactionalStateStorage.StoreCore (cyclomatic 18) · ×1
  • AzureTableTransactionalStateStorage.StoreCore (cyclomatic 18) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:165 — AzureTableTransactionalStateStorage.StoreCore has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReadWriteLock.LockWork (cyclomatic 18) · ×1
  • ReadWriteLock.LockWork (cyclomatic 18) src/Orleans.Transactions/State/ReaderWriterLock.cs:336 — ReadWriteLock.LockWork has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SchemaEmitter.EmitDocumentation (cyclomatic 18) · ×1
  • SchemaEmitter.EmitDocumentation (cyclomatic 18) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:343 — SchemaEmitter.EmitDocumentation has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · docfx.collectMarkdownLinks (cyclomatic 18) · ×1
  • docfx.collectMarkdownLinks (cyclomatic 18) docs/site/scripts/lib/docfx.mjs:1075 — docfx.collectMarkdownLinks has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · docfx.collectUidMap (cyclomatic 18) · ×1
  • docfx.collectUidMap (cyclomatic 18) docs/site/scripts/lib/docfx.mjs:1622 — docfx.collectUidMap has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · link-audit.renderedDocument (cyclomatic 18) · ×1
  • link-audit.renderedDocument (cyclomatic 18) docs/site/scripts/lib/link-audit.mjs:573 — link-audit.renderedDocument has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 2 function items inside it that branch (a function literal at line 604, addUrl). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · MembershipModel.Apply (cyclomatic 17) · ×1
  • MembershipModel.Apply (cyclomatic 17) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:121 — MembershipModel.Apply has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table. This is NOT this file's highest cyclomatic complexity: MembershipModel.CanApply (cyclomatic 29) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · ProxyGenerator.GenerateConstructors (cyclomatic 17) · ×1
  • ProxyGenerator.GenerateConstructors (cyclomatic 17) src/Orleans.CodeGenerator/ProxyGenerator.cs:438 — ProxyGenerator.GenerateConstructors has cyclomatic complexity 17 (threshold 15). Of this number, 9 points are the body's own statements and 8 belong to 2 function items inside it that branch. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ClientMessageCenter.GetGatewayConnection (cyclomatic 17) · ×1
  • ClientMessageCenter.GetGatewayConnection (cyclomatic 17) src/Orleans.Core/Messaging/ClientMessageCenter.cs:232 — ClientMessageCenter.GetGatewayConnection has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShardCatalogProperties.From (cyclomatic 17) · ×1
  • ShardCatalogProperties.From (cyclomatic 17) src/Orleans.DurableJobs/JournaledJobShardManager.cs:844 — ShardCatalogProperties.From has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · JournalCatalogRange.JournalCatalogRange.ctor (cyclomatic 17) · ×1
  • JournalCatalogRange.JournalCatalogRange.ctor (cyclomatic 17) src/Orleans.Journaling/JournalCatalogRange.cs:5 — JournalCatalogRange.JournalCatalogRange.ctor has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ClusterHealthMonitor.UpdateMonitoredSilos (cyclomatic 17) · ×1
  • ClusterHealthMonitor.UpdateMonitoredSilos (cyclomatic 17) src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:201 — ClusterHealthMonitor.UpdateMonitoredSilos has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AsyncTimer.NextTick (cyclomatic 17) · ×1
  • AsyncTimer.NextTick (cyclomatic 17) src/Orleans.Runtime/Timers/AsyncTimer.cs:39 — AsyncTimer.NextTick has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · S3JournalStorage.UpdateMetadataAsync (cyclomatic 17) · ×1
  • S3JournalStorage.UpdateMetadataAsync (cyclomatic 17) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:131 — S3JournalStorage.UpdateMetadataAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · S3JournalStorage.ReplaceAsync (cyclomatic 17) · ×1
  • S3JournalStorage.ReplaceAsync (cyclomatic 17) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:597 — S3JournalStorage.ReplaceAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TransactionQueue.StorageWork (cyclomatic 17) · ×1
  • TransactionQueue.StorageWork (cyclomatic 17) src/Orleans.Transactions/State/TransactionQueue.cs:839 — TransactionQueue.StorageWork has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · docfx.convertTabs (cyclomatic 17) · ×1
  • docfx.convertTabs (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:67 — docfx.convertTabs has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · docfx.convertLinkTarget (cyclomatic 17) · ×1
  • docfx.convertLinkTarget (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:1210 — docfx.convertLinkTarget has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · docfx.convertHubYaml (cyclomatic 17) · ×1
  • docfx.convertHubYaml (cyclomatic 17) docs/site/scripts/lib/docfx.mjs:1752 — docfx.convertHubYaml has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · index.html.renderGraph (cyclomatic 17) · ×1
  • index.html.renderGraph (cyclomatic 17) playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/wwwroot/index.html:181 — index.html.renderGraph has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 2 of the 17 points are its own statements and the rest belongs to 10 function literals inside it that branch (lines 278, 281, 258, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · Impl.OnCompilationEnd (cyclomatic 16) · ×1
  • Impl.OnCompilationEnd (cyclomatic 16) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:493 — Impl.OnCompilationEnd has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SymbolExtensions.ToTypeSyntaxInner (cyclomatic 16) · ×1
  • SymbolExtensions.ToTypeSyntaxInner (cyclomatic 16) src/Orleans.CodeGenerator/SyntaxGeneration/SymbolExtensions.cs:129 — SymbolExtensions.ToTypeSyntaxInner has cyclomatic complexity 16 (threshold 15). Of this number, 8 points are the body's own statements and 8 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LocalObjectData.CancelRequestAsync (cyclomatic 16) · ×1
  • LocalObjectData.CancelRequestAsync (cyclomatic 16) src/Orleans.Core/Runtime/InvokableObjectManager.cs:533 — LocalObjectData.CancelRequestAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JournalingHostingExtensions.AddJournalStorage (cyclomatic 16) · ×1
  • JournalingHostingExtensions.AddJournalStorage (cyclomatic 16) src/Orleans.Journaling/JournalingHostingExtensions.cs:166 — JournalingHostingExtensions.AddJournalStorage has cyclomatic complexity 16 (threshold 15). Of this number, 12 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ActivationData.CancelRequestAsyncCore (cyclomatic 16) · ×1
  • ActivationData.CancelRequestAsyncCore (cyclomatic 16) src/Orleans.Runtime/Catalog/ActivationData.cs:2541 — ActivationData.CancelRequestAsyncCore has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MembershipTableCleanupAgent.CleanupDefunctSilos (cyclomatic 16) · ×1
  • MembershipTableCleanupAgent.CleanupDefunctSilos (cyclomatic 16) src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs:110 — MembershipTableCleanupAgent.CleanupDefunctSilos has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MessageCenter.SendMessage (cyclomatic 16) · ×1
  • MessageCenter.SendMessage (cyclomatic 16) src/Orleans.Runtime/Messaging/MessageCenter.cs:144 — MessageCenter.SendMessage has cyclomatic complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CodecProvider.TryGetConstructedService (cyclomatic 16) · ×1
  • CodecProvider.TryGetConstructedService (cyclomatic 16) src/Orleans.Serialization/Serializers/CodecProvider.cs:907 — CodecProvider.TryGetConstructedService has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TypeConverter.InspectTypeCore (cyclomatic 16) · ×1
  • TypeConverter.InspectTypeCore (cyclomatic 16) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:615 — TypeConverter.InspectTypeCore has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PersistentStreamPullingAgent.GetBatchForConsumer (cyclomatic 16) · ×1
  • PersistentStreamPullingAgent.GetBatchForConsumer (cyclomatic 16) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1496 — PersistentStreamPullingAgent.GetBatchForConsumer has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InMemoryMessageTransport.ProcessWrites (cyclomatic 16) · ×1
  • InMemoryMessageTransport.ProcessWrites (cyclomatic 16) src/Orleans.TestingHost/InMemoryTransport/InMemoryMessageTransport.cs:314 — InMemoryMessageTransport.ProcessWrites has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ServiceCollectionExtensions.MapOrleansDashboard (cyclomatic 16) · ×1
  • ServiceCollectionExtensions.MapOrleansDashboard (cyclomatic 16) src/Dashboard/Orleans.Dashboard/ServiceCollectionExtensions.cs:99 — ServiceCollectionExtensions.MapOrleansDashboard has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 14 function literals inside it that branch (lines 114, 147, 163, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · KubernetesClusterAgent.MonitorOrleansClustering (cyclomatic 16) · ×1
  • KubernetesClusterAgent.MonitorOrleansClustering (cyclomatic 16) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:227 — KubernetesClusterAgent.MonitorOrleansClustering has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · KubernetesClusterAgent.MonitorKubernetesPods (cyclomatic 16) · ×1
  • KubernetesClusterAgent.MonitorKubernetesPods (cyclomatic 16) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:302 — KubernetesClusterAgent.MonitorKubernetesPods has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cyclomatic 16) · ×1
  • DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cyclomatic 16) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:22 — DynamoDBGatewayListProviderHelper.ParseDataConnectionString has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · S3JournalStorage.ReadAsync (cyclomatic 16) · ×1
  • S3JournalStorage.ReadAsync (cyclomatic 16) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:455 — S3JournalStorage.ReadAsync has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AzureBasedMembershipTable.Parse (cyclomatic 16) · ×1
  • AzureBasedMembershipTable.Parse (cyclomatic 16) src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:237 — AzureBasedMembershipTable.Parse has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cyclomatic 16) · ×1
  • AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cyclomatic 16) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/IAzureQueueDataAdapter.cs:321 — AzureQueueJsonDataAdapter.RemoveUnreferencedIds has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReadWriteLock.LockExits (cyclomatic 16) · ×1
  • ReadWriteLock.LockExits (cyclomatic 16) src/Orleans.Transactions/State/ReaderWriterLock.cs:577 — ReadWriteLock.LockExits has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · gallery.validateGallery (cyclomatic 16) · ×1
  • gallery.validateGallery (cyclomatic 16) docs/site/scripts/lib/gallery.mjs:22 — gallery.validateGallery has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 28). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · GrainTable.render (cyclomatic 16) · ×1
  • GrainTable.render (cyclomatic 16) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:139 — GrainTable.render has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D17 · Explicit Debt · Whole file has no live code · ×1
  • Whole file has no live code — 15 debt markers inside it test/Orleans.Core.Tests/Serialization/MessageSerializerTests.cs:2 — Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 15 debt markers (15 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 15 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
D17 · Explicit Debt · BarePragmaDisable repeated across 10 files · ×1
  • BarePragmaDisable repeated across 10 files docs/site/src/content/docs/host/snippets/hosting/HostingExamples.cs:344 — The identical BarePragmaDisable (`#pragma warning disable ORLEANSEXP003`) appears in 10 files (16 occurrences) — a single repo-wide policy (e.g. a Directory.Build.props decision or an idiomatic suppression), not 16 independent debts. Decide it once centrally rather than file-by-file. (Every occurrence still counts toward the score and metrics.)
D17 · Explicit Debt · BareSuppressMessage repeated 13 times in 6 files · ×1
  • BareSuppressMessage repeated 13 times in 6 files src/Azure/Orleans.Clustering.AzureStorage/Utilities/TableStorageErrorCode.cs:5 — The identical BareSuppressMessage (`SuppressMessage`) appears 13 times in 6 files — one decision applied repeatedly (e.g. the same rule silenced on every overload of a fluent API), not 13 independent debts. Decide it once — at the type or project level, or by fixing the underlying pattern — rather than occurrence-by-occurrence. (Every occurrence still counts toward the score and metrics.)
D17 · Explicit Debt · HackComment · ×1
  • HackComment test/Grains/TestInternalGrains/PersistenceTestGrains.cs:898 — // // HACK for testing — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D2 · Cognitive Complexity · JournaledStateManager.WorkLoop (cognitive 195) · ×1
  • JournaledStateManager.WorkLoop (cognitive 195) src/Orleans.Journaling/JournaledStateManager.cs:187 — JournaledStateManager.WorkLoop has cognitive complexity 195 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SocketMessageTransport.ProcessWrites (cognitive 101) · ×1
  • SocketMessageTransport.ProcessWrites (cognitive 101) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:532 — SocketMessageTransport.ProcessWrites has cognitive complexity 101 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationData.RunMessageLoop (cognitive 88) · ×1
  • ActivationData.RunMessageLoop (cognitive 88) src/Orleans.Runtime/Catalog/ActivationData.cs:1119 — ActivationData.RunMessageLoop has cognitive complexity 88 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cognitive 83) · ×1
  • ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData (cognitive 83) src/Orleans.CodeGenerator/Model/ReferenceAssemblyModelExtractor.cs:22 — ReferenceAssemblyModelExtractor.ExtractReferenceAssemblyData has cognitive complexity 83 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.RunConsumerCursor (cognitive 82) · ×1
  • PersistentStreamPullingAgent.RunConsumerCursor (cognitive 82) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1248 — PersistentStreamPullingAgent.RunConsumerCursor has cognitive complexity 82 (threshold 15). Of this number, 81 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · link-audit.auditRenderedInternalLinks (cognitive 80) · ×1
  • link-audit.auditRenderedInternalLinks (cognitive 80) docs/site/scripts/lib/link-audit.mjs:692 — link-audit.auditRenderedInternalLinks has cognitive complexity 80 (threshold 15). Drivers by points: if/else 18 (57 pts), error handling 3 (10 pts), boolean chains 7, loops 2 (3 pts), ternaries 2 (3 pts) (nesting depth added 48). Of this number, 75 points are the body's own statements and 5 belong to 4 function items inside it that branch. To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · RedisJournalStorageProvider.ListAsync (cognitive 73) · ×1
  • RedisJournalStorageProvider.ListAsync (cognitive 73) src/Redis/Orleans.Journaling.Redis/RedisJournalStorageProvider.cs:63 — RedisJournalStorageProvider.ListAsync has cognitive complexity 73 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadWriteLock.LockWork (cognitive 73) · ×1
  • ReadWriteLock.LockWork (cognitive 73) src/Orleans.Transactions/State/ReaderWriterLock.cs:336 — ReadWriteLock.LockWork has cognitive complexity 73 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · CanonicalModelBuilder.CollectNodes (cognitive 73) · ×1
  • CanonicalModelBuilder.CollectNodes (cognitive 73) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:771 — CanonicalModelBuilder.CollectNodes has cognitive complexity 73 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SerializerFactoryGenerator.TryCreate (cognitive 72) · ×1
  • SerializerFactoryGenerator.TryCreate (cognitive 72) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:34 — SerializerFactoryGenerator.TryCreate has cognitive complexity 72 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PackageJsonGenerator.GeneratePackageJson (cognitive 71) · ×1
  • PackageJsonGenerator.GeneratePackageJson (cognitive 71) docs/tools/PackageJsonGenerator/PackageJsonGenerator.cs:17 — PackageJsonGenerator.GeneratePackageJson has cognitive complexity 71 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · CodecProvider.ConsumeMetadata (cognitive 68) · ×1
  • CodecProvider.ConsumeMetadata (cognitive 68) src/Orleans.Serialization/Serializers/CodecProvider.cs:94 — CodecProvider.ConsumeMetadata has cognitive complexity 68 (threshold 15). Of this number, 65 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ShellHostedService.ExecuteAsync (cognitive 65) · ×1
  • ShellHostedService.ExecuteAsync (cognitive 65) samples/Chirper/Chirper.Client/ShellHostedService.cs:24 — ShellHostedService.ExecuteAsync has cognitive complexity 65 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationData.ActivateAsync (cognitive 64) · ×1
  • ActivationData.ActivateAsync (cognitive 64) src/Orleans.Runtime/Catalog/ActivationData.cs:1881 — ActivationData.ActivateAsync has cognitive complexity 64 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · TypeConverter.ConsumeMetadata (cognitive 61) · ×1
  • TypeConverter.ConsumeMetadata (cognitive 61) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:151 — TypeConverter.ConsumeMetadata has cognitive complexity 61 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BatchOperation.Flush (cognitive 60) · ×1
  • BatchOperation.Flush (cognitive 60) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:413 — BatchOperation.Flush has cognitive complexity 60 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerFactoryGenerator.DescribeReferenced (cognitive 58) · ×1
  • SerializerFactoryGenerator.DescribeReferenced (cognitive 58) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:334 — SerializerFactoryGenerator.DescribeReferenced has cognitive complexity 58 (threshold 15). Of this number, 57 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SchemaEmitter.EmitType (cognitive 56) · ×1
  • SchemaEmitter.EmitType (cognitive 56) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:69 — SchemaEmitter.EmitType has cognitive complexity 56 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PdbSourceReader.GetMemberSource (cognitive 54) · ×1
  • PdbSourceReader.GetMemberSource (cognitive 54) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:403 — PdbSourceReader.GetMemberSource has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.DoHandshakeWithConsumer (cognitive 53) · ×1
  • PersistentStreamPullingAgent.DoHandshakeWithConsumer (cognitive 53) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:403 — PersistentStreamPullingAgent.DoHandshakeWithConsumer has cognitive complexity 53 (threshold 15). Of this number, 52 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SchemaEmitter.EmitMember (cognitive 53) · ×1
  • SchemaEmitter.EmitMember (cognitive 53) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:231 — SchemaEmitter.EmitMember has cognitive complexity 53 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.collectUidMap (cognitive 50) · ×1
  • docfx.collectUidMap (cognitive 50) docs/site/scripts/lib/docfx.mjs:1622 — docfx.collectUidMap has cognitive complexity 50 (threshold 15). Drivers by points: if/else 8 (25 pts), loops 6 (18 pts), ternaries 1 (5 pts), boolean chains 2 (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cognitive 49) · ×1
  • GrainInterfaceVersionCodeFix.AppendHistoricalContracts (cognitive 49) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:518 — GrainInterfaceVersionCodeFix.AppendHistoricalContracts has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerFactoryGenerator.Describe (cognitive 49) · ×1
  • SerializerFactoryGenerator.Describe (cognitive 49) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:205 — SerializerFactoryGenerator.Describe has cognitive complexity 49 (threshold 15). Of this number, 48 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · source-quality.parseDocumentedPackageTable (cognitive 47) · ×1
  • source-quality.parseDocumentedPackageTable (cognitive 47) docs/site/scripts/lib/source-quality.mjs:562 — source-quality.parseDocumentedPackageTable has cognitive complexity 47 (threshold 15). Drivers by points: if/else 13 (32 pts), ternaries 3 (9 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerFactoryGenerator.AppendTypeMetadata (cognitive 46) · ×1
  • SerializerFactoryGenerator.AppendTypeMetadata (cognitive 46) src/Orleans.CodeGenerator/SerializerFactoryGenerator.cs:474 — SerializerFactoryGenerator.AppendTypeMetadata has cognitive complexity 46 (threshold 15). Of this number, 45 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Striped64.LongAccumulate (cognitive 46) · ×1
  • Striped64.LongAccumulate (cognitive 46) src/Orleans.Core/Caching/Internal/Striped64.cs:151 — Striped64.LongAccumulate has cognitive complexity 46 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · KubernetesClusterAgent.MonitorOrleansClustering (cognitive 46) · ×1
  • KubernetesClusterAgent.MonitorOrleansClustering (cognitive 46) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:227 — KubernetesClusterAgent.MonitorOrleansClustering has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CanonicalModelBuilder.ExtractDocumentation (cognitive 46) · ×1
  • CanonicalModelBuilder.ExtractDocumentation (cognitive 46) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:371 — CanonicalModelBuilder.ExtractDocumentation has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InvokableMethodDescription.InvokableMethodDescription.ctor (cognitive 45) · ×1
  • InvokableMethodDescription.InvokableMethodDescription.ctor (cognitive 45) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:17 — InvokableMethodDescription.InvokableMethodDescription.ctor has cognitive complexity 45 (threshold 15). Of this number, 41 points are the body's own statements and 4 belong to 2 function items inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ProxyInterfaceModelExtractor.ExtractCustomInitializers (cognitive 45) · ×1
  • ProxyInterfaceModelExtractor.ExtractCustomInitializers (cognitive 45) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:400 — ProxyInterfaceModelExtractor.ExtractCustomInitializers has cognitive complexity 45 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · markdown-ranges.fallbackProtectedLineRanges (cognitive 45) · ×1
  • markdown-ranges.fallbackProtectedLineRanges (cognitive 45) docs/site/scripts/lib/markdown-ranges.mjs:238 — markdown-ranges.fallbackProtectedLineRanges has cognitive complexity 45 (threshold 15). Drivers by points: if/else 15 (34 pts), boolean chains 10, loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadWriteLock.EnterLock (cognitive 44) · ×1
  • ReadWriteLock.EnterLock (cognitive 44) src/Orleans.Transactions/State/ReaderWriterLock.cs:66 — ReadWriteLock.EnterLock has cognitive complexity 44 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · RuntimeTypeNameParser.ParseInternal (cognitive 43) · ×1
  • RuntimeTypeNameParser.ParseInternal (cognitive 43) src/Orleans.Serialization/TypeSystem/RuntimeTypeNameParser.cs:53 — RuntimeTypeNameParser.ParseInternal has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertTabs (cognitive 43) · ×1
  • docfx.convertTabs (cognitive 43) docs/site/scripts/lib/docfx.mjs:67 — docfx.convertTabs has cognitive complexity 43 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 6 (14 pts), ternaries 3 (10 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionQueue.StorageWork (cognitive 42) · ×1
  • TransactionQueue.StorageWork (cognitive 42) src/Orleans.Transactions/State/TransactionQueue.cs:839 — TransactionQueue.StorageWork has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ProxyGenerator.CreateProxyMethods (cognitive 40) · ×1
  • ProxyGenerator.CreateProxyMethods (cognitive 40) src/Orleans.CodeGenerator/ProxyGenerator.cs:85 — ProxyGenerator.CreateProxyMethods has cognitive complexity 40 (threshold 15). Most of this is not in the body itself: 13 of the 40 points are its own statements and the rest belongs to 4 function items inside it that branch (AreEquivalentMethodTypes, HaveEquivalentConstraintTypes, HaveEquivalentMethodConstraints, …). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cognitive 40) · ×1
  • AsyncExecutorWithRetries.ExecuteWithRetriesHelper (cognitive 40) src/Orleans.Core/Async/AsyncExecutorWithRetries.cs:208 — AsyncExecutorWithRetries.ExecuteWithRetriesHelper has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientDirectory.UpdateRoutingTable (cognitive 40) · ×1
  • ClientDirectory.UpdateRoutingTable (cognitive 40) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:230 — ClientDirectory.UpdateRoutingTable has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistributedGrainDirectory.ProcessMembershipUpdates (cognitive 40) · ×1
  • DistributedGrainDirectory.ProcessMembershipUpdates (cognitive 40) src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:520 — DistributedGrainDirectory.ProcessMembershipUpdates has cognitive complexity 40 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadWriteLock.LockExits (cognitive 40) · ×1
  • ReadWriteLock.LockExits (cognitive 40) src/Orleans.Transactions/State/ReaderWriterLock.cs:577 — ReadWriteLock.LockExits has cognitive complexity 40 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ActivationData.FinishDeactivating (cognitive 39) · ×1
  • ActivationData.FinishDeactivating (cognitive 39) src/Orleans.Runtime/Catalog/ActivationData.cs:2180 — ActivationData.FinishDeactivating has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterManifestProvider.UpdateManifest (cognitive 39) · ×1
  • ClusterManifestProvider.UpdateManifest (cognitive 39) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:241 — ClusterManifestProvider.UpdateManifest has cognitive complexity 39 (threshold 15). Of this number, 38 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CodecProvider.TrySelectImplementation (cognitive 39) · ×1
  • CodecProvider.TrySelectImplementation (cognitive 39) src/Orleans.Serialization/Serializers/CodecProvider.cs:1164 — CodecProvider.TrySelectImplementation has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PooledQueueCache.TryGetNextMessageWithResult (cognitive 39) · ×1
  • PooledQueueCache.TryGetNextMessageWithResult (cognitive 39) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:502 — PooledQueueCache.TryGetNextMessageWithResult has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionQueue.NotifyOfAbort (cognitive 39) · ×1
  • TransactionQueue.NotifyOfAbort (cognitive 39) src/Orleans.Transactions/State/TransactionQueue.cs:310 — TransactionQueue.NotifyOfAbort has cognitive complexity 39 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MessageCenter.SendMessage (cognitive 37) · ×1
  • MessageCenter.SendMessage (cognitive 37) src/Orleans.Runtime/Messaging/MessageCenter.cs:144 — MessageCenter.SendMessage has cognitive complexity 37 (threshold 15). Of this number, 32 points are the body's own statements and 5 belong to one function item inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ActivationRepartitioner.AcceptExchangeRequest (cognitive 37) · ×1
  • ActivationRepartitioner.AcceptExchangeRequest (cognitive 37) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:270 — ActivationRepartitioner.AcceptExchangeRequest has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TestClusterPortAllocator.GetAvailableConsecutiveServerPorts (cognitive 37) · ×1
  • TestClusterPortAllocator.GetAvailableConsecutiveServerPorts (cognitive 37) src/Orleans.TestingHost/TestClusterPortAllocator.cs:115 — TestClusterPortAllocator.GetAvailableConsecutiveServerPorts has cognitive complexity 37 (threshold 15). Of this number, 35 points are the body's own statements and 2 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Utils.EnumerableToString (cognitive 36) · ×1
  • Utils.EnumerableToString (cognitive 36) src/Orleans.Core.Abstractions/Utils/Utils.cs:26 — Utils.EnumerableToString has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.GetBatchForConsumer (cognitive 36) · ×1
  • PersistentStreamPullingAgent.GetBatchForConsumer (cognitive 36) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1496 — PersistentStreamPullingAgent.GetBatchForConsumer has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · link-audit.auditSourceLinks (cognitive 36) · ×1
  • link-audit.auditSourceLinks (cognitive 36) docs/site/scripts/lib/link-audit.mjs:418 — link-audit.auditSourceLinks has cognitive complexity 36 (threshold 15). Drivers by points: if/else 10 (24 pts), boolean chains 6, error handling 2 (5 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShardExecutor.ExecuteJobAsync (cognitive 35) · ×1
  • ShardExecutor.ExecuteJobAsync (cognitive 35) src/Orleans.DurableJobs/ShardExecutor.cs:309 — ShardExecutor.ExecuteJobAsync has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · link-audit.probeExternalTargets · ×1
  • link-audit.probeExternalTargets::worker (cognitive 35) docs/site/scripts/lib/link-audit.mjs:1196 — link-audit.probeExternalTargets::worker has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (22 pts), boolean chains 4, error handling 1 (3 pts), loops 2 (3 pts), ternaries 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (link-audit.probeExternalTargets) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · FieldIdAssignmentHelper.ExtractFieldIdAnnotations (cognitive 34) · ×1
  • FieldIdAssignmentHelper.ExtractFieldIdAnnotations (cognitive 34) src/Orleans.CodeGenerator/FieldIdAssignmentHelper.cs:99 — FieldIdAssignmentHelper.ExtractFieldIdAnnotations has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalSiloHealthEventHistory.Aggregate (cognitive 34) · ×1
  • LocalSiloHealthEventHistory.Aggregate (cognitive 34) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:53 — LocalSiloHealthEventHistory.Aggregate has cognitive complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KubernetesClusterAgent.MonitorKubernetesPods (cognitive 34) · ×1
  • KubernetesClusterAgent.MonitorKubernetesPods (cognitive 34) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:302 — KubernetesClusterAgent.MonitorKubernetesPods has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InsideRuntimeClient.Invoke (cognitive 33) · ×1
  • InsideRuntimeClient.Invoke (cognitive 33) src/Orleans.Runtime/Core/InsideRuntimeClient.cs:299 — InsideRuntimeClient.Invoke has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MembershipAgent.ValidateInitialConnectivity (cognitive 33) · ×1
  • MembershipAgent.ValidateInitialConnectivity (cognitive 33) src/Orleans.Runtime/MembershipService/MembershipAgent.cs:140 — MembershipAgent.ValidateInitialConnectivity has cognitive complexity 33 (threshold 15). Of this number, 29 points are the body's own statements and 4 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TestingUtils.WaitUntilSucceededAsync (cognitive 33) · ×1
  • TestingUtils.WaitUntilSucceededAsync (cognitive 33) src/Orleans.TestingHost/Utils/TestingUtils.cs:176 — TestingUtils.WaitUntilSucceededAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · S3JournalStorage.ReplaceAsync (cognitive 33) · ×1
  • S3JournalStorage.ReplaceAsync (cognitive 33) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:597 — S3JournalStorage.ReplaceAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceVersionCodeFix.SortContractEntries (cognitive 32) · ×1
  • GrainInterfaceVersionCodeFix.SortContractEntries (cognitive 32) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1670 — GrainInterfaceVersionCodeFix.SortContractEntries has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceUtils.GetMethods · ×1
  • GrainInterfaceUtils.GetMethods::GetMethodsImpl (cognitive 32) src/Orleans.Core/CodeGeneration/GrainInterfaceUtils.cs:41 — GrainInterfaceUtils.GetMethods::GetMethodsImpl has cognitive complexity 32 (threshold 15). Drivers by points: if/else 5 (19 pts), loops 4 (12 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConnectionManager.Close (cognitive 32) · ×1
  • ConnectionManager.Close (cognitive 32) src/Orleans.Core/Networking/ConnectionManager.cs:345 — ConnectionManager.Close has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ActivationRepartitioner.ProcessPendingEdges (cognitive 32) · ×1
  • ActivationRepartitioner.ProcessPendingEdges (cognitive 32) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.MessageSink.cs:40 — ActivationRepartitioner.ProcessPendingEdges has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ResourceOptimizedPlacementDirector.OnAddActivation (cognitive 32) · ×1
  • ResourceOptimizedPlacementDirector.OnAddActivation (cognitive 32) src/Orleans.Runtime/Placement/ResourceOptimizedPlacementDirector.cs:47 — ResourceOptimizedPlacementDirector.OnAddActivation has cognitive complexity 32 (threshold 15). Of this number, 28 points are the body's own statements and 4 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cognitive 32) · ×1
  • DynamoDBReminderStorageOptionsExtensions.ParseConnectionString (cognitive 32) src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:23 — DynamoDBReminderStorageOptionsExtensions.ParseConnectionString has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerGenerator.Generate (cognitive 31) · ×1
  • SerializerGenerator.Generate (cognitive 31) src/Orleans.CodeGenerator/SerializerGenerator.cs:30 — SerializerGenerator.Generate has cognitive complexity 31 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SerializerGenerator.GenerateDeserializeMethod (cognitive 31) · ×1
  • SerializerGenerator.GenerateDeserializeMethod (cognitive 31) src/Orleans.CodeGenerator/SerializerGenerator.cs:553 — SerializerGenerator.GenerateDeserializeMethod has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShardExecutor.RunShardAsync (cognitive 31) · ×1
  • ShardExecutor.RunShardAsync (cognitive 31) src/Orleans.DurableJobs/ShardExecutor.cs:72 — ShardExecutor.RunShardAsync has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterHealthMonitor.UpdateMonitoredSilos (cognitive 31) · ×1
  • ClusterHealthMonitor.UpdateMonitoredSilos (cognitive 31) src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:201 — ClusterHealthMonitor.UpdateMonitoredSilos has cognitive complexity 31 (threshold 15). Of this number, 30 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.collectMarkdownLinks (cognitive 31) · ×1
  • docfx.collectMarkdownLinks (cognitive 31) docs/site/scripts/lib/docfx.mjs:1075 — docfx.collectMarkdownLinks has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (24 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · project-policy.validateProjectEvaluations (cognitive 31) · ×1
  • project-policy.validateProjectEvaluations (cognitive 31) docs/site/scripts/lib/project-policy.mjs:184 — project-policy.validateProjectEvaluations has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 12, loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Impl.AnalyzeNamedType (cognitive 30) · ×1
  • Impl.AnalyzeNamedType (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:308 — Impl.AnalyzeNamedType has cognitive complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · Impl.OnCompilationEnd (cognitive 30) · ×1
  • Impl.OnCompilationEnd (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:493 — Impl.OnCompilationEnd has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cognitive 30) · ×1
  • GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync (cognitive 30) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1254 — GrainInterfaceVersionCodeFix.AddInterfaceToFileAsync has cognitive complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MembershipTableTestRunner.ConcurrentReads (cognitive 30) · ×1
  • MembershipTableTestRunner.ConcurrentReads (cognitive 30) src/Orleans.Clustering.TestKit/MembershipTableTestRunner.cs:735 — MembershipTableTestRunner.ConcurrentReads has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalDurableJobManager.CancelAsync (cognitive 30) · ×1
  • LocalDurableJobManager.CancelAsync (cognitive 30) src/Orleans.DurableJobs/LocalDurableJobManager.cs:314 — LocalDurableJobManager.CancelAsync has cognitive complexity 30 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · SiloMetadataCache.ProcessMembershipUpdates (cognitive 30) · ×1
  • SiloMetadataCache.ProcessMembershipUpdates (cognitive 30) src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadaCache.cs:56 — SiloMetadataCache.ProcessMembershipUpdates has cognitive complexity 30 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · DynamoDBTransactionalStateStorage.Store (cognitive 30) · ×1
  • DynamoDBTransactionalStateStorage.Store (cognitive 30) src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:144 — DynamoDBTransactionalStateStorage.Store has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceFileParser.Parse (cognitive 29) · ×1
  • GrainInterfaceFileParser.Parse (cognitive 29) src/Orleans.Analyzers/GrainInterfaceVersionAnalyzer.cs:1444 — GrainInterfaceFileParser.Parse has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cognitive 29) · ×1
  • GrainInterfaceVersionCodeFix.MergeHistoricalMembers (cognitive 29) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:617 — GrainInterfaceVersionCodeFix.MergeHistoricalMembers has cognitive complexity 29 (threshold 15). Of this number, 28 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GenerateAliasAttributesAnalyzer.AnalyzeNamedType (cognitive 29) · ×1
  • GenerateAliasAttributesAnalyzer.AnalyzeNamedType (cognitive 29) src/Orleans.Analyzers/GenerateAliasAttributesAnalyzer.cs:47 — GenerateAliasAttributesAnalyzer.AnalyzeNamedType has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UniqueKey.CompareTo (cognitive 29) · ×1
  • UniqueKey.CompareTo (cognitive 29) src/Orleans.Core.Abstractions/IDs/Legacy/UniqueKey.cs:326 — UniqueKey.CompareTo has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · AsyncEnumerableGrainExtension.MoveNextCore (cognitive 29) · ×1
  • AsyncEnumerableGrainExtension.MoveNextCore (cognitive 29) src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:156 — AsyncEnumerableGrainExtension.MoveNextCore has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · DashboardGrain.GetGrainState (cognitive 29) · ×1
  • DashboardGrain.GetGrainState (cognitive 29) src/Dashboard/Orleans.Dashboard/Implementation/Grains/DashboardGrain.cs:302 — DashboardGrain.GetGrainState has cognitive complexity 29 (threshold 15). Of this number, 28 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · S3JournalStorage.UpdateMetadataAsync (cognitive 29) · ×1
  • S3JournalStorage.UpdateMetadataAsync (cognitive 29) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:131 — S3JournalStorage.UpdateMetadataAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · S3JournalStorage.DeleteAsync (cognitive 29) · ×1
  • S3JournalStorage.DeleteAsync (cognitive 29) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:338 — S3JournalStorage.DeleteAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cognitive 29) · ×1
  • AzureQueueJsonDataAdapter.RemoveUnreferencedIds (cognitive 29) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/IAzureQueueDataAdapter.cs:321 — AzureQueueJsonDataAdapter.RemoveUnreferencedIds has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Silo.render (cognitive 29) · ×1
  • Silo.render (cognitive 29) src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:142 — Silo.render has cognitive complexity 29 (threshold 15). Drivers by points: boolean chains 22, if/else 7. Of this number, 27 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · CopierGenerator.GenerateCopier (cognitive 28) · ×1
  • CopierGenerator.GenerateCopier (cognitive 28) src/Orleans.CodeGenerator/CopierGenerator.cs:26 — CopierGenerator.GenerateCopier has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SocketMessageTransport.ProcessReads (cognitive 28) · ×1
  • SocketMessageTransport.ProcessReads (cognitive 28) src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:358 — SocketMessageTransport.ProcessReads has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalObjectData.CancelRequestAsync (cognitive 28) · ×1
  • LocalObjectData.CancelRequestAsync (cognitive 28) src/Orleans.Core/Runtime/InvokableObjectManager.cs:533 — LocalObjectData.CancelRequestAsync has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JournaledJobShard.ProcessMutationBatchAsync (cognitive 28) · ×1
  • JournaledJobShard.ProcessMutationBatchAsync (cognitive 28) src/Orleans.DurableJobs/JournaledJobShard.cs:374 — JournaledJobShard.ProcessMutationBatchAsync has cognitive complexity 28 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · Catalog.GetOrCreateActivation (cognitive 28) · ×1
  • Catalog.GetOrCreateActivation (cognitive 28) src/Orleans.Runtime/Catalog/Catalog.cs:135 — Catalog.GetOrCreateActivation has cognitive complexity 28 (threshold 15). Of this number, 20 points are the body's own statements and 8 belong to 2 function items inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · InMemoryMessageTransport.ProcessWrites (cognitive 28) · ×1
  • InMemoryMessageTransport.ProcessWrites (cognitive 28) src/Orleans.TestingHost/InMemoryTransport/InMemoryMessageTransport.cs:314 — InMemoryMessageTransport.ProcessWrites has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CommitQueue.Find (cognitive 28) · ×1
  • CommitQueue.Find (cognitive 28) src/Orleans.Transactions/Utilities/CommitQueue.cs:111 — CommitQueue.Find has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SchemaEmitter.EmitDocumentation (cognitive 28) · ×1
  • SchemaEmitter.EmitDocumentation (cognitive 28) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:343 — SchemaEmitter.EmitDocumentation has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerGenerator.GetFieldDescriptions (cognitive 27) · ×1
  • SerializerGenerator.GetFieldDescriptions (cognitive 27) src/Orleans.CodeGenerator/SerializerGenerator.cs:264 — SerializerGenerator.GetFieldDescriptions has cognitive complexity 27 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · GrainInterfaceTypeToGrainTypeResolver.BuildCache (cognitive 27) · ×1
  • GrainInterfaceTypeToGrainTypeResolver.BuildCache (cognitive 27) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:201 — GrainInterfaceTypeToGrainTypeResolver.BuildCache has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StreamMessageTransport.ProcessReads (cognitive 27) · ×1
  • StreamMessageTransport.ProcessReads (cognitive 27) src/Orleans.Core/Networking/Transport/Streams/StreamMessageTransport.cs:255 — StreamMessageTransport.ProcessReads has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Reader.Skip (cognitive 27) · ×1
  • Reader.Skip (cognitive 27) src/Orleans.Serialization/Buffers/Reader.cs:536 — Reader.Skip has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cognitive 27) · ×1
  • SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability (cognitive 27) src/Orleans.Serialization/Hosting/SerializerConfigurationAnalyzer.cs:29 — SerializerConfigurationAnalyzer.AnalyzeSerializerAvailability has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.ReadFromQueue (cognitive 27) · ×1
  • PersistentStreamPullingAgent.ReadFromQueue (cognitive 27) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:884 — PersistentStreamPullingAgent.ReadFromQueue has cognitive complexity 27 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · S3JournalStorageProvider.ListAsync (cognitive 27) · ×1
  • S3JournalStorageProvider.ListAsync (cognitive 27) src/AWS/Orleans.Journaling.S3/S3JournalStorageProvider.cs:48 — S3JournalStorageProvider.ListAsync has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureTableTransactionalStateStorage.StoreCore (cognitive 27) · ×1
  • AzureTableTransactionalStateStorage.StoreCore (cognitive 27) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:165 — AzureTableTransactionalStateStorage.StoreCore has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImplicitChannelSubscriberTable.BuildCache (cognitive 26) · ×1
  • ImplicitChannelSubscriberTable.BuildCache (cognitive 26) src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:61 — ImplicitChannelSubscriberTable.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MembershipModelExecutionContext.ExecuteAsync (cognitive 26) · ×1
  • MembershipModelExecutionContext.ExecuteAsync (cognitive 26) src/Orleans.Clustering.TestKit/MembershipTableModel.cs:314 — MembershipModelExecutionContext.ExecuteAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · GrainBindingsResolver.BuildCache (cognitive 26) · ×1
  • GrainBindingsResolver.BuildCache (cognitive 26) src/Orleans.Core/Manifest/GrainBindings.cs:131 — GrainBindingsResolver.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainVersionManifest.BuildCache (cognitive 26) · ×1
  • GrainVersionManifest.BuildCache (cognitive 26) src/Orleans.Core/Manifest/GrainVersionManifest.cs:217 — GrainVersionManifest.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DurableJobsDiagnostics.StartPersistBatchActivity (cognitive 26) · ×1
  • DurableJobsDiagnostics.StartPersistBatchActivity (cognitive 26) src/Orleans.DurableJobs/DurableJobsDiagnostics.cs:166 — DurableJobsDiagnostics.StartPersistBatchActivity has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.TransferSnapshotAsync (cognitive 26) · ×1
  • GrainDirectoryPartition.TransferSnapshotAsync (cognitive 26) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:672 — GrainDirectoryPartition.TransferSnapshotAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PlacementWorker.ProcessLoop (cognitive 26) · ×1
  • PlacementWorker.ProcessLoop (cognitive 26) src/Orleans.Runtime/Placement/PlacementService.cs:398 — PlacementWorker.ProcessLoop has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImplicitStreamSubscriberTable.BuildCache (cognitive 26) · ×1
  • ImplicitStreamSubscriberTable.BuildCache (cognitive 26) src/Orleans.Streaming/PubSub/ImplicitStreamSubscriberTable.cs:61 — ImplicitStreamSubscriberTable.BuildCache has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · markdown-ranges.startsHtmlBlock (cognitive 26) · ×1
  • markdown-ranges.startsHtmlBlock (cognitive 26) docs/site/scripts/lib/markdown-ranges.mjs:183 — markdown-ranges.startsHtmlBlock has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (11 pts), ternaries 4 (10 pts), boolean chains 4, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Message.TryFormat (cognitive 25) · ×1
  • Message.TryFormat (cognitive 25) src/Orleans.Core/Messaging/Message.cs:416 — Message.TryFormat has cognitive complexity 25 (threshold 15). Of this number, 24 points are the body's own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JournaledJobShardManager.DiscoverJobShardsAsync (cognitive 25) · ×1
  • JournaledJobShardManager.DiscoverJobShardsAsync (cognitive 25) src/Orleans.DurableJobs/JournaledJobShardManager.cs:122 — JournaledJobShardManager.DiscoverJobShardsAsync has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · InMemoryMessageTransport.ProcessReads (cognitive 25) · ×1
  • InMemoryMessageTransport.ProcessReads (cognitive 25) src/Orleans.TestingHost/InMemoryTransport/InMemoryMessageTransport.cs:216 — InMemoryMessageTransport.ProcessReads has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertHubYaml (cognitive 25) · ×1
  • docfx.convertHubYaml (cognitive 25) docs/site/scripts/lib/docfx.mjs:1752 — docfx.convertHubYaml has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 3 (5 pts), boolean chains 1, ternaries 1 (nesting depth added 10). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceVersionCodeFix.GetProjectsToRegenerateAsync (cognitive 24) · ×1
  • GrainInterfaceVersionCodeFix.GetProjectsToRegenerateAsync (cognitive 24) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:848 — GrainInterfaceVersionCodeFix.GetProjectsToRegenerateAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MetadataGenerator.GenerateIncrementalMetadata (cognitive 24) · ×1
  • MetadataGenerator.GenerateIncrementalMetadata (cognitive 24) src/Orleans.CodeGenerator/MetadataGenerator.cs:29 — MetadataGenerator.GenerateIncrementalMetadata has cognitive complexity 24 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ProxyGenerator.CreateAsyncProxyMethodBody (cognitive 24) · ×1
  • ProxyGenerator.CreateAsyncProxyMethodBody (cognitive 24) src/Orleans.CodeGenerator/ProxyGenerator.cs:279 — ProxyGenerator.CreateAsyncProxyMethodBody has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LocalReminderData.WaitForNextTick (cognitive 24) · ×1
  • LocalReminderData.WaitForNextTick (cognitive 24) src/Orleans.Reminders/ReminderService/LocalReminderService.cs:1406 — LocalReminderData.WaitForNextTick has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.CleanupExpiredLeasesCore (cognitive 24) · ×1
  • GrainDirectoryPartition.CleanupExpiredLeasesCore (cognitive 24) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:1259 — GrainDirectoryPartition.CleanupExpiredLeasesCore has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MembershipTableCleanupAgent.CleanupDefunctSilos (cognitive 24) · ×1
  • MembershipTableCleanupAgent.CleanupDefunctSilos (cognitive 24) src/Orleans.Runtime/MembershipService/MembershipTableCleanupAgent.cs:110 — MembershipTableCleanupAgent.CleanupDefunctSilos has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MembershipTableManager.ProcessSuspectOrKillLists (cognitive 24) · ×1
  • MembershipTableManager.ProcessSuspectOrKillLists (cognitive 24) src/Orleans.Runtime/MembershipService/MembershipTableManager.cs:828 — MembershipTableManager.ProcessSuspectOrKillLists has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SiloHealthMonitor.Run (cognitive 24) · ×1
  • SiloHealthMonitor.Run (cognitive 24) src/Orleans.Runtime/MembershipService/SiloHealthMonitor.cs:174 — SiloHealthMonitor.Run has cognitive complexity 24 (threshold 15). Of this number, 23 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DynamoDBMembershipHelper.ParseDataConnectionString (cognitive 24) · ×1
  • DynamoDBMembershipHelper.ParseDataConnectionString (cognitive 24) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:23 — DynamoDBMembershipHelper.ParseDataConnectionString has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureBlobJournalStorage.ReplaceAsync (cognitive 24) · ×1
  • AzureBlobJournalStorage.ReplaceAsync (cognitive 24) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:496 — AzureBlobJournalStorage.ReplaceAsync has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertCodeDirectives (cognitive 24) · ×1
  • docfx.convertCodeDirectives (cognitive 24) docs/site/scripts/lib/docfx.mjs:650 — docfx.convertCodeDirectives has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (15 pts), ternaries 4 (8 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertImages (cognitive 24) · ×1
  • docfx.convertImages (cognitive 24) docs/site/scripts/lib/docfx.mjs:887 — docfx.convertImages has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · source-quality.validateReferenceInventories (cognitive 24) · ×1
  • source-quality.validateReferenceInventories (cognitive 24) docs/site/scripts/lib/source-quality.mjs:747 — source-quality.validateReferenceInventories has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 6, boolean chains 3, ternaries 1 (nesting depth added 6). Of this number, 23 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InMemoryJobQueue.GetAsyncEnumerator (cognitive 23) · ×1
  • InMemoryJobQueue.GetAsyncEnumerator (cognitive 23) src/Orleans.DurableJobs/InMemoryJobQueue.cs:258 — InMemoryJobQueue.GetAsyncEnumerator has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JournaledJobShardManager.TryAssignShardAsync (cognitive 23) · ×1
  • JournaledJobShardManager.TryAssignShardAsync (cognitive 23) src/Orleans.DurableJobs/JournaledJobShardManager.cs:200 — JournaledJobShardManager.TryAssignShardAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationData.AnalyzeWorkload (cognitive 23) · ×1
  • ActivationData.AnalyzeWorkload (cognitive 23) src/Orleans.Runtime/Catalog/ActivationData.cs:849 — ActivationData.AnalyzeWorkload has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SiloClusteringValidator.ValidateConfiguration (cognitive 23) · ×1
  • SiloClusteringValidator.ValidateConfiguration (cognitive 23) src/Orleans.Runtime/Configuration/Validators/SiloClusteringValidator.cs:25 — SiloClusteringValidator.ValidateConfiguration has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · GrainDirectoryPartition.RegisterAsync (cognitive 23) · ×1
  • GrainDirectoryPartition.RegisterAsync (cognitive 23) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.Interface.cs:10 — GrainDirectoryPartition.RegisterAsync has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · StreamSubscriptionHandleImpl.DeliverBatch (cognitive 23) · ×1
  • StreamSubscriptionHandleImpl.DeliverBatch (cognitive 23) src/Orleans.Streaming/Internal/StreamSubscriptionHandleImpl.cs:159 — StreamSubscriptionHandleImpl.DeliverBatch has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureTableJournalStorageProvider.GetCatalogFilter (cognitive 23) · ×1
  • AzureTableJournalStorageProvider.GetCatalogFilter (cognitive 23) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageProvider.cs:114 — AzureTableJournalStorageProvider.GetCatalogFilter has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionRequestBase.Invoke (cognitive 23) · ×1
  • TransactionRequestBase.Invoke (cognitive 23) src/Orleans.Transactions/TransactionAttribute.cs:296 — TransactionRequestBase.Invoke has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · GameGrain.MakeMove (cognitive 23) · ×1
  • GameGrain.MakeMove (cognitive 23) samples/TicTacToe/Grains/GameGrain.cs:69 — GameGrain.MakeMove has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · CanonicalModelBuilder.ExtractDocExample (cognitive 23) · ×1
  • CanonicalModelBuilder.ExtractDocExample (cognitive 23) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:969 — CanonicalModelBuilder.ExtractDocExample has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializationAttributesHelper.AnalyzeTypeDeclaration (cognitive 22) · ×1
  • SerializationAttributesHelper.AnalyzeTypeDeclaration (cognitive 22) src/Orleans.Analyzers/SerializationAttributesHelper.cs:24 — SerializationAttributesHelper.AnalyzeTypeDeclaration has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cognitive 22) · ×1
  • MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests (cognitive 22) src/Orleans.Clustering.TestKit/MembershipTableModelBasedTestRunner.cs:45 — MembershipTableModelBasedTestRunner.RunGeneratedConformanceTests has cognitive complexity 22 (threshold 15). Of this number, 17 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LibraryTypes.IsShallowCopyable (cognitive 22) · ×1
  • LibraryTypes.IsShallowCopyable (cognitive 22) src/Orleans.CodeGenerator/LibraryTypes.cs:325 — LibraryTypes.IsShallowCopyable has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cognitive 22) · ×1
  • SerializableTypeModelExtractor.TryExtractSerializableTypeModel (cognitive 22) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:249 — SerializableTypeModelExtractor.TryExtractSerializableTypeModel has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LogFormatter.PrintException_Helper (cognitive 22) · ×1
  • LogFormatter.PrintException_Helper (cognitive 22) src/Orleans.Core.Abstractions/Logging/LogFormatter.cs:77 — LogFormatter.PrintException_Helper has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CustomStorageAdaptor.WriteAsync (cognitive 22) · ×1
  • CustomStorageAdaptor.WriteAsync (cognitive 22) src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:158 — CustomStorageAdaptor.WriteAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JsonLinesJournalFormat.ReadEntryPayload (cognitive 22) · ×1
  • JsonLinesJournalFormat.ReadEntryPayload (cognitive 22) src/Orleans.Journaling/Formats/Json/JsonLinesJournalFormat.cs:152 — JsonLinesJournalFormat.ReadEntryPayload has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReminderTableRetryPolicy.ExecuteUntilAsync (cognitive 22) · ×1
  • ReminderTableRetryPolicy.ExecuteUntilAsync (cognitive 22) src/Orleans.Reminders.TestKit/ReminderTableRetryPolicy.cs:106 — ReminderTableRetryPolicy.ExecuteUntilAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RingRange.Intersections (cognitive 22) · ×1
  • RingRange.Intersections (cognitive 22) src/Orleans.Runtime/GrainDirectory/RingRange.cs:177 — RingRange.Intersections has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KubernetesClusterAgent.OnStart (cognitive 22) · ×1
  • KubernetesClusterAgent.OnStart (cognitive 22) src/Orleans.Hosting.Kubernetes/KubernetesClusterAgent.cs:102 — KubernetesClusterAgent.OnStart has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · AzureBlobJournalStorageProvider.ListAsync (cognitive 22) · ×1
  • AzureBlobJournalStorageProvider.ListAsync (cognitive 22) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageProvider.cs:57 — AzureBlobJournalStorageProvider.ListAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionQueue.CheckProgressOfCommitQueue (cognitive 22) · ×1
  • TransactionQueue.CheckProgressOfCommitQueue (cognitive 22) src/Orleans.Transactions/State/TransactionQueue.cs:1188 — TransactionQueue.CheckProgressOfCommitQueue has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · include-closure.collectIncludeTargets · ×1
  • include-closure.collectIncludeTargets::collect (cognitive 22) docs/site/scripts/lib/include-closure.mjs:53 — include-closure.collectIncludeTargets::collect has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 2, loops 1, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.transformOutsideInlineCode (cognitive 22) · ×1
  • docfx.transformOutsideInlineCode (cognitive 22) docs/site/scripts/lib/docfx.mjs:1363 — docfx.transformOutsideInlineCode has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 5 (10 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InvokableBaseTypeResolver.SatisfiesConstraints (cognitive 21) · ×1
  • InvokableBaseTypeResolver.SatisfiesConstraints (cognitive 21) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:628 — InvokableBaseTypeResolver.SatisfiesConstraints has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (InvokableBaseTypeResolver.SatisfiesConstraints::SatisfiesSpecialConstraints) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · TypeSymbolResolver.TryGetAssembly (cognitive 21) · ×1
  • TypeSymbolResolver.TryGetAssembly (cognitive 21) src/Orleans.CodeGenerator/TypeSymbolResolver.cs:198 — TypeSymbolResolver.TryGetAssembly has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientClusterManifestProvider.RunAsync (cognitive 21) · ×1
  • ClientClusterManifestProvider.RunAsync (cognitive 21) src/Orleans.Core/Manifest/ClientClusterManifestProvider.cs:106 — ClientClusterManifestProvider.RunAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationData.CancelRequestAsyncCore (cognitive 21) · ×1
  • ActivationData.CancelRequestAsyncCore (cognitive 21) src/Orleans.Runtime/Catalog/ActivationData.cs:2541 — ActivationData.CancelRequestAsyncCore has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationMigrationManager.PumpMigrationQueue (cognitive 21) · ×1
  • ActivationMigrationManager.PumpMigrationQueue (cognitive 21) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs:698 — ActivationMigrationManager.PumpMigrationQueue has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cognitive 21) · ×1
  • DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor (cognitive 21) src/Orleans.Runtime/GrainDirectory/DirectoryMembershipSnapshot.cs:34 — DirectoryMembershipSnapshot.DirectoryMembershipSnapshot.ctor has cognitive complexity 21 (threshold 15). Of this number, 19 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CodecProvider.TryCreateBaseCodecInner (cognitive 21) · ×1
  • CodecProvider.TryCreateBaseCodecInner (cognitive 21) src/Orleans.Serialization/Serializers/CodecProvider.cs:324 — CodecProvider.TryCreateBaseCodecInner has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConstructionServiceProvider.GetService (cognitive 21) · ×1
  • ConstructionServiceProvider.GetService (cognitive 21) src/Orleans.Serialization/Serializers/CodecProvider.cs:937 — ConstructionServiceProvider.GetService has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TypeConverter.InspectTypeCore (cognitive 21) · ×1
  • TypeConverter.InspectTypeCore (cognitive 21) src/Orleans.Serialization/TypeSystem/TypeConverter.cs:615 — TypeConverter.InspectTypeCore has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.TryGetDeliveryProgress (cognitive 21) · ×1
  • PersistentStreamPullingAgent.TryGetDeliveryProgress (cognitive 21) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1023 — PersistentStreamPullingAgent.TryGetDeliveryProgress has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PubSubRendezvousGrain.RegisterProducer (cognitive 21) · ×1
  • PubSubRendezvousGrain.RegisterProducer (cognitive 21) src/Orleans.Streaming/PubSub/PubSubRendezvousGrain.cs:122 — PubSubRendezvousGrain.RegisterProducer has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InMemoryLogBuffer.PrintException (cognitive 21) · ×1
  • InMemoryLogBuffer.PrintException (cognitive 21) src/Orleans.TestingHost/Logging/InMemoryLoggerProvider.cs:191 — InMemoryLogBuffer.PrintException has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SiloInstanceRecord.SiloInstanceRecord.ctor (cognitive 21) · ×1
  • SiloInstanceRecord.SiloInstanceRecord.ctor (cognitive 21) src/AWS/Orleans.Clustering.DynamoDB/Membership/SiloInstanceRecord.cs:50 — SiloInstanceRecord.SiloInstanceRecord.ctor has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · S3JournalStorage.AppendAsync (cognitive 21) · ×1
  • S3JournalStorage.AppendAsync (cognitive 21) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:262 — S3JournalStorage.AppendAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureBlobJournalStorage.DeleteAsync (cognitive 21) · ×1
  • AzureBlobJournalStorage.DeleteAsync (cognitive 21) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:284 — AzureBlobJournalStorage.DeleteAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionRecoveryTestsRunner.ValidateResults (cognitive 21) · ×1
  • TransactionRecoveryTestsRunner.ValidateResults (cognitive 21) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:920 — TransactionRecoveryTestsRunner.ValidateResults has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionAgent.CollateParticipants (cognitive 21) · ×1
  • TransactionAgent.CollateParticipants (cognitive 21) src/Orleans.Transactions/DistributedTM/TransactionAgent.cs:244 — TransactionAgent.CollateParticipants has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PackageJsonGenerator.AdjustSourceLinesForTypeDeclarations (cognitive 21) · ×1
  • PackageJsonGenerator.AdjustSourceLinesForTypeDeclarations (cognitive 21) docs/tools/PackageJsonGenerator/PackageJsonGenerator.cs:286 — PackageJsonGenerator.AdjustSourceLinesForTypeDeclarations has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.findRegion (cognitive 21) · ×1
  • docfx.findRegion (cognitive 21) docs/site/scripts/lib/docfx.mjs:513 — docfx.findRegion has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (3 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 11). Of this number, 18 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertZones (cognitive 21) · ×1
  • docfx.convertZones (cognitive 21) docs/site/scripts/lib/docfx.mjs:961 — docfx.convertZones has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (18 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SyntaxHelpers.IsGrainClass (cognitive 20) · ×1
  • SyntaxHelpers.IsGrainClass (cognitive 20) src/Orleans.Analyzers/SyntaxHelpers.cs:182 — SyntaxHelpers.IsGrainClass has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProxyInterfaceModelExtractor.ExtractInterfaceMethods (cognitive 20) · ×1
  • ProxyInterfaceModelExtractor.ExtractInterfaceMethods (cognitive 20) src/Orleans.CodeGenerator/Model/ProxyInterfaceModelExtractor.cs:204 — ProxyInterfaceModelExtractor.ExtractInterfaceMethods has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProxyGenerationContext.GetProxyMethodDescription (cognitive 20) · ×1
  • ProxyGenerationContext.GetProxyMethodDescription (cognitive 20) src/Orleans.CodeGenerator/ProxyGenerationContext.cs:183 — ProxyGenerationContext.GetProxyMethodDescription has cognitive complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceTypeToGrainTypeResolver.GetGrainType (cognitive 20) · ×1
  • GrainInterfaceTypeToGrainTypeResolver.GetGrainType (cognitive 20) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:41 — GrainInterfaceTypeToGrainTypeResolver.GetGrainType has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainInterfaceTypeToGrainTypeResolver.TryGetGrainType (cognitive 20) · ×1
  • GrainInterfaceTypeToGrainTypeResolver.TryGetGrainType (cognitive 20) src/Orleans.Core/Core/GrainInterfaceTypeToGrainTypeResolver.cs:117 — GrainInterfaceTypeToGrainTypeResolver.TryGetGrainType has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cognitive 20) · ×1
  • ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles (cognitive 20) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:389 — ReminderServiceLifecycleTestRunner.RunReminderService_StaleOwnerRegistrationReconciles has cognitive complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 496, 410). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · ActivationMigrationManager.AcceptMigratingGrains (cognitive 20) · ×1
  • ActivationMigrationManager.AcceptMigratingGrains (cognitive 20) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs:384 — ActivationMigrationManager.AcceptMigratingGrains has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ActivationMigrationManager.StartMigration (cognitive 20) · ×1
  • ActivationMigrationManager.StartMigration (cognitive 20) src/Orleans.Runtime/Catalog/ActivationMigrationManager.cs:522 — ActivationMigrationManager.StartMigration has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalGrainDirectory.CalculateGrainDirectoryPartition (cognitive 20) · ×1
  • LocalGrainDirectory.CalculateGrainDirectoryPartition (cognitive 20) src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs:497 — LocalGrainDirectory.CalculateGrainDirectoryPartition has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterHealthMonitor.ProcessMembershipUpdates (cognitive 20) · ×1
  • ClusterHealthMonitor.ProcessMembershipUpdates (cognitive 20) src/Orleans.Runtime/MembershipService/ClusterHealthMonitor.cs:84 — ClusterHealthMonitor.ProcessMembershipUpdates has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MultiDimensionalArrayCopier.DeepCopy (cognitive 20) · ×1
  • MultiDimensionalArrayCopier.DeepCopy (cognitive 20) src/Orleans.Serialization/Codecs/MultiDimensionalArrayCodec.cs:227 — MultiDimensionalArrayCopier.DeepCopy has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · CodecProvider.TryGetConstructedService (cognitive 20) · ×1
  • CodecProvider.TryGetConstructedService (cognitive 20) src/Orleans.Serialization/Serializers/CodecProvider.cs:907 — CodecProvider.TryGetConstructedService has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.GetRecoveryCursor (cognitive 20) · ×1
  • PersistentStreamPullingAgent.GetRecoveryCursor (cognitive 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:617 — PersistentStreamPullingAgent.GetRecoveryCursor has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PersistentStreamPullingAgent.RegisterStream (cognitive 20) · ×1
  • PersistentStreamPullingAgent.RegisterStream (cognitive 20) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:1076 — PersistentStreamPullingAgent.RegisterStream has cognitive complexity 20 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cognitive 20) · ×1
  • DynamoDBGatewayListProviderHelper.ParseDataConnectionString (cognitive 20) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:22 — DynamoDBGatewayListProviderHelper.ParseDataConnectionString has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CanonicalModelBuilder.AppendPlainText (cognitive 20) · ×1
  • CanonicalModelBuilder.AppendPlainText (cognitive 20) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:1053 — CanonicalModelBuilder.AppendPlainText has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · link-audit.renderedDocument (cognitive 20) · ×1
  • link-audit.renderedDocument (cognitive 20) docs/site/scripts/lib/link-audit.mjs:573 — link-audit.renderedDocument has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 5). None of this is in the body itself: all 20 points belong to 2 function items inside it that branch (a function literal at line 604, addUrl). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · source-quality.renderedText (cognitive 20) · ×1
  • source-quality.renderedText (cognitive 20) docs/site/scripts/lib/source-quality.mjs:72 — source-quality.renderedText has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (7 pts), ternaries 3 (7 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 7). Most of this is not in the body itself: 8 of the 20 points are its own statements and the rest belongs to one function item inside it that branches (append). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · GrainTable.render (cognitive 20) · ×1
  • GrainTable.render (cognitive 20) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:139 — GrainTable.render has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 10 (15 pts), if/else 4, boolean chains 1 (nesting depth added 5). Of this number, 17 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterDiagnosticsService.GetGrainCallFrequencies (cognitive 19) · ×1
  • ClusterDiagnosticsService.GetGrainCallFrequencies (cognitive 19) playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/Data/ClusterDiagnosticsService.cs:18 — ClusterDiagnosticsService.GetGrainCallFrequencies has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InvokableBaseTypeResolver.SatisfiesConstraints · ×1
  • InvokableBaseTypeResolver.SatisfiesConstraints::SatisfiesSpecialConstraints (cognitive 19) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:660 — InvokableBaseTypeResolver.SatisfiesConstraints::SatisfiesSpecialConstraints has cognitive complexity 19 (threshold 15). Drivers by points: boolean chains 11, if/else 6 (8 pts) (nesting depth added 2). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: one other method here (InvokableBaseTypeResolver.SatisfiesConstraints) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · SerializableTypeDescription.SerializableTypeDescription.ctor (cognitive 19) · ×1
  • SerializableTypeDescription.SerializableTypeDescription.ctor (cognitive 19) src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:12 — SerializableTypeDescription.SerializableTypeDescription.ctor has cognitive complexity 19 (threshold 15). Most of this is not in the body itself: 8 of the 19 points are its own statements and the rest belongs to 2 function items inside it that branch (TryGetActivatorConstructor, GetTypeParameterName). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · SymbolExtensions.ToTypeSyntaxInner (cognitive 19) · ×1
  • SymbolExtensions.ToTypeSyntaxInner (cognitive 19) src/Orleans.CodeGenerator/SyntaxGeneration/SymbolExtensions.cs:129 — SymbolExtensions.ToTypeSyntaxInner has cognitive complexity 19 (threshold 15). Most of this is not in the body itself: 7 of the 19 points are its own statements and the rest belongs to 2 function items inside it that branch (OnNamedTypeSymbol, AddFullNamespace). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · DurableJobsStorageInspector.InspectAsync (cognitive 19) · ×1
  • DurableJobsStorageInspector.InspectAsync (cognitive 19) src/Orleans.DurableJobs/DurableJobsStorageInspector.cs:10 — DurableJobsStorageInspector.InspectAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DurableJobsOptionsValidator.ValidateConfiguration (cognitive 19) · ×1
  • DurableJobsOptionsValidator.ValidateConfiguration (cognitive 19) src/Orleans.DurableJobs/Hosting/DurableJobsOptions.cs:228 — DurableJobsOptionsValidator.ValidateConfiguration has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ClientDirectory.PublishUpdates (cognitive 19) · ×1
  • ClientDirectory.PublishUpdates (cognitive 19) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:505 — ClientDirectory.PublishUpdates has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.CheckIntegrityAsync (cognitive 19) · ×1
  • GrainDirectoryPartition.CheckIntegrityAsync (cognitive 19) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:1058 — GrainDirectoryPartition.CheckIntegrityAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalSiloHealthEventHistory.RemoveExpired (cognitive 19) · ×1
  • LocalSiloHealthEventHistory.RemoveExpired (cognitive 19) src/Orleans.Runtime/MembershipService/LocalSiloHealthEventHistory.cs:178 — LocalSiloHealthEventHistory.RemoveExpired has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Gateway.DropDisconnectedClients (cognitive 19) · ×1
  • Gateway.DropDisconnectedClients (cognitive 19) src/Orleans.Runtime/Messaging/Gateway.cs:234 — Gateway.DropDisconnectedClients has cognitive complexity 19 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · ActivationCountPlacementDirector.SelectSiloPowerOfK (cognitive 19) · ×1
  • ActivationCountPlacementDirector.SelectSiloPowerOfK (cognitive 19) src/Orleans.Runtime/Placement/ActivationCountPlacementDirector.cs:42 — ActivationCountPlacementDirector.SelectSiloPowerOfK has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationRepartitioner.FinalizeProtocol (cognitive 19) · ×1
  • ActivationRepartitioner.FinalizeProtocol (cognitive 19) src/Orleans.Runtime/Placement/Repartitioning/ActivationRepartitioner.cs:542 — ActivationRepartitioner.FinalizeProtocol has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StreamSubscriptionHandleImpl.DeliverItem (cognitive 19) · ×1
  • StreamSubscriptionHandleImpl.DeliverItem (cognitive 19) src/Orleans.Streaming/Internal/StreamSubscriptionHandleImpl.cs:217 — StreamSubscriptionHandleImpl.DeliverItem has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DynamoDBStorage.UpdateTableAsync (cognitive 19) · ×1
  • DynamoDBStorage.UpdateTableAsync (cognitive 19) src/AWS/Shared/Storage/DynamoDBStorage.cs:272 — DynamoDBStorage.UpdateTableAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · AzureBlobJournalStorage.UpdateMetadataAsync (cognitive 19) · ×1
  • AzureBlobJournalStorage.UpdateMetadataAsync (cognitive 19) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs:120 — AzureBlobJournalStorage.UpdateMetadataAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureTableJournalStorage.UpdateMetadataAsync (cognitive 19) · ×1
  • AzureTableJournalStorage.UpdateMetadataAsync (cognitive 19) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:152 — AzureTableJournalStorage.UpdateMetadataAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureTableTransactionalStateStorage.Load (cognitive 19) · ×1
  • AzureTableTransactionalStateStorage.Load (cognitive 19) src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs:58 — AzureTableTransactionalStateStorage.Load has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NatsStreamConsumer.GetMessages (cognitive 19) · ×1
  • NatsStreamConsumer.GetMessages (cognitive 19) src/Orleans.Streaming.NATS/Providers/NatsStreamConsumer.cs:40 — NatsStreamConsumer.GetMessages has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionalStateStorageProviderWrapper.Store (cognitive 19) · ×1
  • TransactionalStateStorageProviderWrapper.Store (cognitive 19) src/Orleans.Transactions/State/TransactionalStateStorageProviderWrapper.cs:37 — TransactionalStateStorageProviderWrapper.Store has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SchemaEmitter.EmitDocNode (cognitive 19) · ×1
  • SchemaEmitter.EmitDocNode (cognitive 19) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:453 — SchemaEmitter.EmitDocNode has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertLearnBlocks (cognitive 19) · ×1
  • docfx.convertLearnBlocks (cognitive 19) docs/site/scripts/lib/docfx.mjs:782 — docfx.convertLearnBlocks has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), error handling 1 (3 pts), ternaries 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · link-audit.collectYamlLinkReferences · ×1
  • link-audit.collectYamlLinkReferences::visit (cognitive 19) docs/site/scripts/lib/link-audit.mjs:295 — link-audit.collectYamlLinkReferences::visit has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 2 (4 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · source-quality.validatePackageInventory (cognitive 19) · ×1
  • source-quality.validatePackageInventory (cognitive 19) docs/site/scripts/lib/source-quality.mjs:675 — source-quality.validatePackageInventory has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), ternaries 2 (5 pts), loops 3, boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IdClashAttributeAnalyzer.AnalyzeNamedType (cognitive 18) · ×1
  • IdClashAttributeAnalyzer.AnalyzeNamedType (cognitive 18) src/Orleans.Analyzers/IdClashAttributeAnalyzer.cs:42 — IdClashAttributeAnalyzer.AnalyzeNamedType has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivityPropagationIncomingGrainCallFilter.Invoke (cognitive 18) · ×1
  • ActivityPropagationIncomingGrainCallFilter.Invoke (cognitive 18) src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs:147 — ActivityPropagationIncomingGrainCallFilter.Invoke has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GatewayManager.UpdateLiveGatewaysSnapshot (cognitive 18) · ×1
  • GatewayManager.UpdateLiveGatewaysSnapshot (cognitive 18) src/Orleans.Core/Messaging/GatewayManager.cs:275 — GatewayManager.UpdateLiveGatewaysSnapshot has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationCollector.DeactivateInDueTimeOrder (cognitive 18) · ×1
  • ActivationCollector.DeactivateInDueTimeOrder (cognitive 18) src/Orleans.Runtime/Catalog/ActivationCollector.cs:407 — ActivationCollector.DeactivateInDueTimeOrder has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DistributedGrainDirectory.GetRegisteredActivations (cognitive 18) · ×1
  • DistributedGrainDirectory.GetRegisteredActivations (cognitive 18) src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:378 — DistributedGrainDirectory.GetRegisteredActivations has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReferencedAssemblyProvider.AddFromDependencyContext (cognitive 18) · ×1
  • ReferencedAssemblyProvider.AddFromDependencyContext (cognitive 18) src/Orleans.Serialization/Hosting/ReferencedAssemblyProvider.cs:131 — ReferencedAssemblyProvider.AddFromDependencyContext has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReferencedObjectCollection.AddToReferences (cognitive 18) · ×1
  • ReferencedObjectCollection.AddToReferences (cognitive 18) src/Orleans.Serialization/Session/ReferencedObjectCollection.cs:192 — ReferencedObjectCollection.AddToReferences has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IPAddressSelector.PickIPAddress (cognitive 18) · ×1
  • IPAddressSelector.PickIPAddress (cognitive 18) src/Orleans.Hosting.Kubernetes/ConfigureKubernetesHostingOptions.cs:118 — IPAddressSelector.PickIPAddress has cognitive complexity 18 (threshold 15). Most of this is not in the body itself: 7 of the 18 points are its own statements and the rest belongs to 3 function items inside it that branch (CompareIPAddresses, GetPreferredSubnetRank, And). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CosmosGrainStorage.TryCreateResources (cognitive 18) · ×1
  • CosmosGrainStorage.TryCreateResources (cognitive 18) src/Azure/Orleans.Persistence.Cosmos/CosmosGrainStorage.cs:349 — CosmosGrainStorage.TryCreateResources has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureQueueStreamProviderBuilder.GetQueueOptionBuilder (cognitive 18) · ×1
  • AzureQueueStreamProviderBuilder.GetQueueOptionBuilder (cognitive 18) src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:44 — AzureQueueStreamProviderBuilder.GetQueueOptionBuilder has cognitive complexity 18 (threshold 15). None of this is in the body itself: all 18 points belong to one function literal inside it that branches (line 48). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · ConsistencyTestGrain.Recurse (cognitive 18) · ×1
  • ConsistencyTestGrain.Recurse (cognitive 18) src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestGrain.cs:162 — ConsistencyTestGrain.Recurse has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadWriteLock.Find (cognitive 18) · ×1
  • ReadWriteLock.Find (cognitive 18) src/Orleans.Transactions/State/ReaderWriterLock.cs:490 — ReadWriteLock.Find has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GameGrain.UpdateGameStatusAsync (cognitive 18) · ×1
  • GameGrain.UpdateGameStatusAsync (cognitive 18) samples/Presence/src/Grains/GameGrain.cs:28 — GameGrain.UpdateGameStatusAsync has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · PdbSourceReader.StripGenericArity (cognitive 18) · ×1
  • PdbSourceReader.StripGenericArity (cognitive 18) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:259 — PdbSourceReader.StripGenericArity has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · link-audit.probeExternalTargets (cognitive 18) · ×1
  • link-audit.probeExternalTargets (cognitive 18) docs/site/scripts/lib/link-audit.mjs:1141 — link-audit.probeExternalTargets has cognitive complexity 18 (threshold 15). Drivers by points: if/else 16 (31 pts), boolean chains 8, error handling 3 (7 pts), loops 4 (5 pts), ternaries 1 (3 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (link-audit.probeExternalTargets::worker) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · packages.assertUniqueApiRoutes (cognitive 18) · ×1
  • packages.assertUniqueApiRoutes (cognitive 18) docs/site/src/lib/api/packages.ts:362 — packages.assertUniqueApiRoutes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · clean-markdown-output.publishMarkdownOverview (cognitive 18) · ×1
  • clean-markdown-output.publishMarkdownOverview (cognitive 18) docs/site/src/plugins/clean-markdown-output.mjs:86 — clean-markdown-output.publishMarkdownOverview has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 3, ternaries 2, boolean chains 1 (nesting depth added 4). Of this number, 14 points are the body's own statements and 4 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationSheddingToyHostedService.ExecuteAsync (cognitive 17) · ×1
  • ActivationSheddingToyHostedService.ExecuteAsync (cognitive 17) playground/ActivationSheddingToy/ActivationSheddingToyHostedService.cs:8 — ActivationSheddingToyHostedService.ExecuteAsync has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · InvokableBaseTypeResolver.TryConstructAndValidate (cognitive 17) · ×1
  • InvokableBaseTypeResolver.TryConstructAndValidate (cognitive 17) src/Orleans.CodeGenerator.Shared/InvokableBaseTypeResolver.cs:548 — InvokableBaseTypeResolver.TryConstructAndValidate has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · AliasClashAttributeAnalyzer.CheckMethodAliases (cognitive 17) · ×1
  • AliasClashAttributeAnalyzer.CheckMethodAliases (cognitive 17) src/Orleans.Analyzers/AliasClashAttributeAnalyzer.cs:110 — AliasClashAttributeAnalyzer.CheckMethodAliases has cognitive complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · SerializationContractModelExtractor.Extract (cognitive 17) · ×1
  • SerializationContractModelExtractor.Extract (cognitive 17) src/Orleans.CodeGenerator/Model/SerializationContractModel.cs:24 — SerializationContractModelExtractor.Extract has cognitive complexity 17 (threshold 15). Of this number, 10 points are the body's own statements and 7 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializerGenerator.AddSerializationMembers (cognitive 17) · ×1
  • SerializerGenerator.AddSerializationMembers (cognitive 17) src/Orleans.CodeGenerator/SerializerGenerator.cs:479 — SerializerGenerator.AddSerializationMembers has cognitive complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConfigUtilities.GetLocalIPAddress (cognitive 17) · ×1
  • ConfigUtilities.GetLocalIPAddress (cognitive 17) src/Orleans.Core/Configuration/ConfigUtilities.cs:167 — ConfigUtilities.GetLocalIPAddress has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientMessageCenter.GetGatewayConnection (cognitive 17) · ×1
  • ClientMessageCenter.GetGatewayConnection (cognitive 17) src/Orleans.Core/Messaging/ClientMessageCenter.cs:232 — ClientMessageCenter.GetGatewayConnection has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OutsideRuntimeClient.ReceiveResponse (cognitive 17) · ×1
  • OutsideRuntimeClient.ReceiveResponse (cognitive 17) src/Orleans.Core/Runtime/OutsideRuntimeClient.cs:342 — OutsideRuntimeClient.ReceiveResponse has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalDurableJobManager.ScheduleJobAsync (cognitive 17) · ×1
  • LocalDurableJobManager.ScheduleJobAsync (cognitive 17) src/Orleans.DurableJobs/LocalDurableJobManager.cs:81 — LocalDurableJobManager.ScheduleJobAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IncomingRequestMonitor.Run (cognitive 17) · ×1
  • IncomingRequestMonitor.Run (cognitive 17) src/Orleans.Runtime/Catalog/IncomingRequestMonitor.cs:64 — IncomingRequestMonitor.Run has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StatelessWorkerGrainContext.RunMessageLoop (cognitive 17) · ×1
  • StatelessWorkerGrainContext.RunMessageLoop (cognitive 17) src/Orleans.Runtime/Catalog/StatelessWorkerGrainContext.cs:139 — StatelessWorkerGrainContext.RunMessageLoop has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientDirectory.Run (cognitive 17) · ×1
  • ClientDirectory.Run (cognitive 17) src/Orleans.Runtime/GrainDirectory/ClientDirectory.cs:362 — ClientDirectory.Run has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.OnSiloRemovedFromCluster (cognitive 17) · ×1
  • GrainDirectoryPartition.OnSiloRemovedFromCluster (cognitive 17) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:317 — GrainDirectoryPartition.OnSiloRemovedFromCluster has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LocalGrainDirectory.LookupAsync (cognitive 17) · ×1
  • LocalGrainDirectory.LookupAsync (cognitive 17) src/Orleans.Runtime/GrainDirectory/LocalGrainDirectory.cs:838 — LocalGrainDirectory.LookupAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SiloStatusListenerManager.NotifyObservers (cognitive 17) · ×1
  • SiloStatusListenerManager.NotifyObservers (cognitive 17) src/Orleans.Runtime/MembershipService/SiloStatusListenerManager.cs:112 — SiloStatusListenerManager.NotifyObservers has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnknownSiloStatusCache.ValidateSiloStatuses (cognitive 17) · ×1
  • UnknownSiloStatusCache.ValidateSiloStatuses (cognitive 17) src/Orleans.Runtime/MembershipService/UnknownSiloStatusCache.cs:42 — UnknownSiloStatusCache.ValidateSiloStatuses has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JsonCodec.ReadValue (cognitive 17) · ×1
  • JsonCodec.ReadValue (cognitive 17) src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:99 — JsonCodec.ReadValue has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PooledBufferStream.SetLength (cognitive 17) · ×1
  • PooledBufferStream.SetLength (cognitive 17) src/Orleans.Serialization/Buffers/Adaptors/PooledBufferStream.cs:240 — PooledBufferStream.SetLength has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Reader.ForkFrom (cognitive 17) · ×1
  • Reader.ForkFrom (cognitive 17) src/Orleans.Serialization/Buffers/Reader.cs:624 — Reader.ForkFrom has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WellKnownStringComparerCodec.ReadValue (cognitive 17) · ×1
  • WellKnownStringComparerCodec.ReadValue (cognitive 17) src/Orleans.Serialization/Codecs/WellKnownStringComparerCodec.cs:67 — WellKnownStringComparerCodec.ReadValue has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BitStreamFormatter.FormatField (cognitive 17) · ×1
  • BitStreamFormatter.FormatField (cognitive 17) src/Orleans.Serialization/Utilities/BitStreamFormatter.cs:115 — BitStreamFormatter.FormatField has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryObserver.HasConverged (cognitive 17) · ×1
  • GrainDirectoryObserver.HasConverged (cognitive 17) src/Orleans.TestingHost/GrainDirectoryObserver.cs:123 — GrainDirectoryObserver.HasConverged has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StandaloneSiloHandle.StandaloneSiloHandle.ctor (cognitive 17) · ×1
  • StandaloneSiloHandle.StandaloneSiloHandle.ctor (cognitive 17) src/Orleans.TestingHost/StandaloneSiloHandle.cs:46 — StandaloneSiloHandle.StandaloneSiloHandle.ctor has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 79, 130, 114). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · LifecycleStageInspector.CleanMethodName (cognitive 17) · ×1
  • LifecycleStageInspector.CleanMethodName (cognitive 17) src/Dashboard/Orleans.Dashboard/Implementation/LifecycleStageInspector.cs:210 — LifecycleStageInspector.CleanMethodName has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ZooKeeperBasedMembershipTable.ReadCoreAsync (cognitive 17) · ×1
  • ZooKeeperBasedMembershipTable.ReadCoreAsync (cognitive 17) src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:210 — ZooKeeperBasedMembershipTable.ReadCoreAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SQSStorage.ParseDataConnectionString (cognitive 17) · ×1
  • SQSStorage.ParseDataConnectionString (cognitive 17) src/AWS/Orleans.Streaming.SQS/Storage/SQSStorage.cs:76 — SQSStorage.ParseDataConnectionString has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AzureBasedMembershipTable.Parse (cognitive 17) · ×1
  • AzureBasedMembershipTable.Parse (cognitive 17) src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:237 — AzureBasedMembershipTable.Parse has cognitive complexity 17 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · AzureTableJournalStorageProvider.ListAsync (cognitive 17) · ×1
  • AzureTableJournalStorageProvider.ListAsync (cognitive 17) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageProvider.cs:69 — AzureTableJournalStorageProvider.ListAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConsistencyTestHarness.RunRandomTransactionSequence (cognitive 17) · ×1
  • ConsistencyTestHarness.RunRandomTransactionSequence (cognitive 17) src/Orleans.Transactions.TestKit.Base/Consistency/ConsistencyTestHarness.cs:162 — ConsistencyTestHarness.RunRandomTransactionSequence has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cognitive 17) · ×1
  • TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase (cognitive 17) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:229 — TransactionRecoveryTestsRunner.TransactionWillRecoverAfterTargetedPhase has cognitive complexity 17 (threshold 15). Of this number, 13 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · CanonicalModelBuilder.MergeInheritedDocs (cognitive 17) · ×1
  • CanonicalModelBuilder.MergeInheritedDocs (cognitive 17) docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:518 — CanonicalModelBuilder.MergeInheritedDocs has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PdbSourceReader.BuildMethodIndex (cognitive 17) · ×1
  • PdbSourceReader.BuildMethodIndex (cognitive 17) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:87 — PdbSourceReader.BuildMethodIndex has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PdbSourceReader.BuildNamespaceDirMapping (cognitive 17) · ×1
  • PdbSourceReader.BuildNamespaceDirMapping (cognitive 17) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:151 — PdbSourceReader.BuildNamespaceDirMapping has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PdbSourceReader.InferTypeSourceFile (cognitive 17) · ×1
  • PdbSourceReader.InferTypeSourceFile (cognitive 17) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:340 — PdbSourceReader.InferTypeSourceFile has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertLinkTarget (cognitive 17) · ×1
  • docfx.convertLinkTarget (cognitive 17) docs/site/scripts/lib/docfx.mjs:1210 — docfx.convertLinkTarget has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (9 pts), boolean chains 7, ternaries 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · CopierGenerator.GenerateMemberwiseDeepCopyMethod (cognitive 16) · ×1
  • CopierGenerator.GenerateMemberwiseDeepCopyMethod (cognitive 16) src/Orleans.CodeGenerator/CopierGenerator.cs:346 — CopierGenerator.GenerateMemberwiseDeepCopyMethod has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MetadataGenerator.AddCompoundTypeAliases (cognitive 16) · ×1
  • MetadataGenerator.AddCompoundTypeAliases (cognitive 16) src/Orleans.CodeGenerator/MetadataGenerator.cs:234 — MetadataGenerator.AddCompoundTypeAliases has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializableSourceOutputGenerator.CreateReferencedSerializableSourceOutputs (cognitive 16) · ×1
  • SerializableSourceOutputGenerator.CreateReferencedSerializableSourceOutputs (cognitive 16) src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:122 — SerializableSourceOutputGenerator.CreateReferencedSerializableSourceOutputs has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultOptionsFormatter.FormatProperty (cognitive 16) · ×1
  • DefaultOptionsFormatter.FormatProperty (cognitive 16) src/Orleans.Core/Configuration/OptionLogger/DefaultOptionsFormatter.cs:88 — DefaultOptionsFormatter.FormatProperty has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SendWorker.Execute (cognitive 16) · ×1
  • SendWorker.Execute (cognitive 16) src/Orleans.Core/Networking/Connection.cs:293 — SendWorker.Execute has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · MessageReadRequest.Execute (cognitive 16) · ×1
  • MessageReadRequest.Execute (cognitive 16) src/Orleans.Core/Networking/MessageReadRequest.cs:130 — MessageReadRequest.Execute has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · JournalCatalogRange.JournalCatalogRange.ctor (cognitive 16) · ×1
  • JournalCatalogRange.JournalCatalogRange.ctor (cognitive 16) src/Orleans.Journaling/JournalCatalogRange.cs:5 — JournalCatalogRange.JournalCatalogRange.ctor has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · JournalingHostingExtensions.AddJournalStorage (cognitive 16) · ×1
  • JournalingHostingExtensions.AddJournalStorage (cognitive 16) src/Orleans.Journaling/JournalingHostingExtensions.cs:166 — JournalingHostingExtensions.AddJournalStorage has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationCollector.TryRescheduleCollection (cognitive 16) · ×1
  • ActivationCollector.TryRescheduleCollection (cognitive 16) src/Orleans.Runtime/Catalog/ActivationCollector.cs:157 — ActivationCollector.TryRescheduleCollection has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationCollector.RunMemoryBasedDeactivationLoop (cognitive 16) · ×1
  • ActivationCollector.RunMemoryBasedDeactivationLoop (cognitive 16) src/Orleans.Runtime/Catalog/ActivationCollector.cs:730 — ActivationCollector.RunMemoryBasedDeactivationLoop has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VirtualBucketsRingProvider.CalculateTargetSilo (cognitive 16) · ×1
  • VirtualBucketsRingProvider.CalculateTargetSilo (cognitive 16) src/Orleans.Runtime/ConsistentRing/VirtualBucketsRingProvider.cs:245 — VirtualBucketsRingProvider.CalculateTargetSilo has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.GetSnapshotAsync (cognitive 16) · ×1
  • GrainDirectoryPartition.GetSnapshotAsync (cognitive 16) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:115 — GrainDirectoryPartition.GetSnapshotAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GrainDirectoryPartition.AcquireRangeAsync (cognitive 16) · ×1
  • GrainDirectoryPartition.AcquireRangeAsync (cognitive 16) src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs:522 — GrainDirectoryPartition.AcquireRangeAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RingRangeCollection.Difference (cognitive 16) · ×1
  • RingRangeCollection.Difference (cognitive 16) src/Orleans.Runtime/GrainDirectory/RingRangeCollection.cs:156 — RingRangeCollection.Difference has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterManifestProvider.ProcessMembershipUpdates (cognitive 16) · ×1
  • ClusterManifestProvider.ProcessMembershipUpdates (cognitive 16) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:180 — ClusterManifestProvider.ProcessMembershipUpdates has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClusterManifestProvider.TryFillMissingManifestsFromPeers (cognitive 16) · ×1
  • ClusterManifestProvider.TryFillMissingManifestsFromPeers (cognitive 16) src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:441 — ClusterManifestProvider.TryFillMissingManifestsFromPeers has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PlacementService.GetCompatibleSilos (cognitive 16) · ×1
  • PlacementService.GetCompatibleSilos (cognitive 16) src/Orleans.Runtime/Placement/PlacementService.cs:169 — PlacementService.GetCompatibleSilos has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivationRebalancerWorker.RunRebalancingCycle (cognitive 16) · ×1
  • ActivationRebalancerWorker.RunRebalancingCycle (cognitive 16) src/Orleans.Runtime/Placement/Rebalancing/ActivationRebalancerWorker.cs:235 — ActivationRebalancerWorker.RunRebalancingCycle has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · BufferSliceReaderInput.GetNext (cognitive 16) · ×1
  • BufferSliceReaderInput.GetNext (cognitive 16) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:41 — BufferSliceReaderInput.GetNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SpanEnumerator.MoveNext (cognitive 16) · ×1
  • SpanEnumerator.MoveNext (cognitive 16) src/Orleans.Serialization/Buffers/PooledBuffer.cs:639 — SpanEnumerator.MoveNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (MemoryEnumerator.MoveNext) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · MemoryEnumerator.MoveNext (cognitive 16) · ×1
  • MemoryEnumerator.MoveNext (cognitive 16) src/Orleans.Serialization/Buffers/PooledBuffer.cs:753 — MemoryEnumerator.MoveNext has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (SpanEnumerator.MoveNext) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · FieldHeaderCodec.ReadTypeForAnalysis (cognitive 16) · ×1
  • FieldHeaderCodec.ReadTypeForAnalysis (cognitive 16) src/Orleans.Serialization/Buffers/Writer.FieldHeader.cs:191 — FieldHeaderCodec.ReadTypeForAnalysis has cognitive complexity 16 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DictionaryBaseCodec.Deserialize (cognitive 16) · ×1
  • DictionaryBaseCodec.Deserialize (cognitive 16) src/Orleans.Serialization/Codecs/DictionaryCodec.cs:293 — DictionaryBaseCodec.Deserialize has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PooledQueueCache.SetCursor (cognitive 16) · ×1
  • PooledQueueCache.SetCursor (cognitive 16) src/Orleans.Streaming/Common/PooledCache/PooledQueueCache.cs:269 — PooledQueueCache.SetCursor has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PersistentStreamPullingManager.AddNewQueues (cognitive 16) · ×1
  • PersistentStreamPullingManager.AddNewQueues (cognitive 16) src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:275 — PersistentStreamPullingManager.AddNewQueues has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PubSubRendezvousGrain.RemoveDefunctSystemTargetProducers (cognitive 16) · ×1
  • PubSubRendezvousGrain.RemoveDefunctSystemTargetProducers (cognitive 16) src/Orleans.Streaming/PubSub/PubSubRendezvousGrain.cs:217 — PubSubRendezvousGrain.RemoveDefunctSystemTargetProducers has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · S3JournalStorage.ReadAsync (cognitive 16) · ×1
  • S3JournalStorage.ReadAsync (cognitive 16) src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:455 — S3JournalStorage.ReadAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · AzureTableJournalStorage.ReplaceAsync (cognitive 16) · ×1
  • AzureTableJournalStorage.ReplaceAsync (cognitive 16) src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs:488 — AzureTableJournalStorage.ReplaceAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CassandraClusteringTable.ReadConsistentAsync (cognitive 16) · ×1
  • CassandraClusteringTable.ReadConsistentAsync (cognitive 16) src/Cassandra/Orleans.Clustering.Cassandra/CassandraClusteringTable.cs:271 — CassandraClusteringTable.ReadConsistentAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure (cognitive 16) · ×1
  • TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure (cognitive 16) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:438 — TransactionRecoveryTestsRunner.TransactionWillRecoverAfterRandomSiloFailure has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransactionRecoveryTestsRunner.RecoverTransactions (cognitive 16) · ×1
  • TransactionRecoveryTestsRunner.RecoverTransactions (cognitive 16) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionRecoveryTestsRunner.cs:691 — TransactionRecoveryTestsRunner.RecoverTransactions has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PdbSourceReader.NormalizeGenericName (cognitive 16) · ×1
  • PdbSourceReader.NormalizeGenericName (cognitive 16) docs/tools/PackageJsonGenerator/Helpers/PdbSourceReader.cs:226 — PdbSourceReader.NormalizeGenericName has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.expandIncludesInternal (cognitive 16) · ×1
  • docfx.expandIncludesInternal (cognitive 16) docs/site/scripts/lib/docfx.mjs:426 — docfx.expandIncludesInternal has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 3 (6 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · docfx.convertLinks (cognitive 16) · ×1
  • docfx.convertLinks (cognitive 16) docs/site/scripts/lib/docfx.mjs:1257 — docfx.convertLinks has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 4, ternaries 2 (nesting depth added 2). None of this is in the body itself: all 16 points belong to one function literal inside it that branches (line 1258). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · packages.buildTypeSignature (cognitive 16) · ×1
  • packages.buildTypeSignature (cognitive 16) docs/site/src/lib/api/packages.ts:247 — packages.buildTypeSignature has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 7 (9 pts), if/else 3 (4 pts), boolean chains 2, loops 1 (nesting depth added 3). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · FunctionTooLong · ×1
  • FunctionTooLong: link-audit.auditSourceLinks docs/site/scripts/lib/link-audit.mjs:418 — FunctionTooLong — auditSourceLinks runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (3 members, 32 shared lines) · ×1
  • Near-duplicate member family (3 members, 32 shared lines) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:23 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:23-65 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:24-74 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:24-90 — These 3 members are variants of one another: a block of 32 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication · Near-duplicate member pair (52 shared lines) · ×1
  • Near-duplicate member pair (52 shared lines) docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:70 — docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:70-229 | docs/tools/PackageJsonGenerator/Helpers/SchemaEmitter.cs:232-341 — These two members are variants of one another: 52 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (32 shared lines) · ×1
  • Near-duplicate member pair (32 shared lines) src/Orleans.CodeGenerator/CopierGenerator.cs:144 — src/Orleans.CodeGenerator/CopierGenerator.cs:144-201 | src/Orleans.CodeGenerator/SerializerGenerator.cs:213-262 — These two members are variants of one another: 32 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×1
  • Edited copy of a member (17 corresponding lines) src/Orleans.CodeGenerator/CopierGenerator.cs:120 — src/Orleans.CodeGenerator/CopierGenerator.cs:120-140 | src/Orleans.CodeGenerator/SerializerGenerator.cs:142-176 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (37 corresponding lines) · ×1
  • Edited copy of a member (37 corresponding lines) src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:72 — src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:72-112 | src/Orleans.Serialization/ISerializableSerializer/ExceptionCodec.cs:367-449 — These two members are one piece of code written twice and then edited apart: 37 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×1
  • Edited copy of a member (9 corresponding lines) src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:87 — src/Orleans.CodeGenerator/Model/GeneratedInvokableDescription.cs:87-97 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:160-170 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (19 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (19 members, 50+ identical tokens) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:20 — src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:20-60 | src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:63-103 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16-57 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:60-102 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:18-58 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:13-61 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:14-82 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:18-64 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:20-66 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:20-60 | src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:45-100 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:23-53 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:56-86 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:20-51 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:14-59 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:21-58 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:19-49 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:20-58 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:61-99 — These 19 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 19 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 19 times.
D4 · Code Duplication · Members sharing a duplicated core (14 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (14 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:160 — src/Orleans.Serialization/Codecs/TupleCodec.cs:160-173 | src/Orleans.Serialization/Codecs/TupleCodec.cs:310-324 | src/Orleans.Serialization/Codecs/TupleCodec.cs:479-494 | src/Orleans.Serialization/Codecs/TupleCodec.cs:668-684 | src/Orleans.Serialization/Codecs/TupleCodec.cs:874-891 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1097-1116 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1338-1357 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:187-195 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:308-317 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:445-455 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:595-606 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:759-772 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:938-952 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1133-1147 — These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times.
D4 · Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (8 members, 50+ identical tokens) src/Orleans.Serialization/Codecs/TupleCodec.cs:110 — src/Orleans.Serialization/Codecs/TupleCodec.cs:110-130 | src/Orleans.Serialization/Codecs/TupleCodec.cs:250-272 | src/Orleans.Serialization/Codecs/TupleCodec.cs:412-435 | src/Orleans.Serialization/Codecs/TupleCodec.cs:591-615 | src/Orleans.Serialization/Codecs/TupleCodec.cs:790-815 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1006-1032 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1240-1267 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1490-1518 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication · Duplicated block (69–103 lines × 2) · ×1
  • Duplicated block (69–103 lines × 2) src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs:1708 — src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs:1708-1776 | src/Orleans.Reminders/ErrorCodes.cs:10-112 — before extracting anything, compare `src/Orleans.Core.Abstractions/Logging/ErrorCodes.cs` and `src/Orleans.Reminders/ErrorCodes.cs` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (45 lines × 2) · ×1
  • Duplicated block (45 lines × 2) src/Orleans.Serialization/Buffers/PooledBuffer.cs:651 — src/Orleans.Serialization/Buffers/PooledBuffer.cs:651-695 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:765-809 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/PooledBuffer.cs:651` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (44 lines × 4) · ×1
  • Duplicated block (44 lines × 4) src/Orleans.Serialization/Codecs/ArrayCodec.cs:64 — src/Orleans.Serialization/Codecs/ArrayCodec.cs:64-107 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:219-262 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:379-422 | src/Orleans.Serialization/Codecs/ArrayCodec.cs:542-585 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (37–45 lines × 3) · ×1
  • Duplicated block (37–45 lines × 3) src/AWS/Orleans.Journaling.S3/S3JournalStorageOptions.cs:121 — src/AWS/Orleans.Journaling.S3/S3JournalStorageOptions.cs:121-157 | src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorageOptions.cs:72-116 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorageOptions.cs:86-130 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (36–41 lines × 2) · ×1
  • Duplicated block (36–41 lines × 2) src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:398 — src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:398-438 | src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs:387-422 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (33–36 lines × 2) · ×1
  • Duplicated block (33–36 lines × 2) src/Orleans.Serialization/Codecs/CollectionCodec.cs:127 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:127-159 | src/Orleans.Serialization/Codecs/ListCodec.cs:126-161 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:161 — src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:161-193 | src/Orleans.Streaming/Checkpointers/StreamQueueCheckpointer.cs:122-154 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/AzureTableStreamQueueCheckpointer.cs:161` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (32 lines × 2) · ×1
  • Duplicated block (32 lines × 2) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34-65 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:43-74 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:34` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (34 lines × 2) · ×1
  • Duplicated block (34 lines × 2) src/Orleans.Transactions/State/TransactionalState.cs:139 — src/Orleans.Transactions/State/TransactionalState.cs:139-172 | src/Orleans.Transactions/TOC/TransactionCommitter.cs:76-109 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions/State/TransactionalState.cs:139` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (33–34 lines × 3) · ×1
  • Duplicated block (33–34 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16 — src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16-48 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:21-54 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:14-46 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:16` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (32–33 lines × 4) · ×1
  • Duplicated block (32–33 lines × 4) src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101 — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101-132 | src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:85-116 | src/Orleans.Serialization.SystemTextJson/JsonCodec.cs:100-131 | src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs:168-200 — before extracting anything, compare `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs` and `src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 67 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:101` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (29 lines × 3) · ×1
  • Duplicated block (29 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs:10 — src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs:10-38 | src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBGatewayOptions.cs:10-38 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptions.cs:10-38 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBClusteringOptions.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Options/DynamoDBGatewayOptions.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (30–31 lines × 2) · ×1
  • Duplicated block (30–31 lines × 2) src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16 — src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16-45 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:60-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:16` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) src/Orleans.Serialization/ISerializableSerializer/DotNetSerializableCodec.cs:151 — src/Orleans.Serialization/ISerializableSerializer/DotNetSerializableCodec.cs:151-177 | src/Orleans.Serialization/ISerializableSerializer/ValueTypeSerializer.cs:101-127 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (25 lines × 3) · ×1
  • Duplicated block (25 lines × 3) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:53 — src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:53-77 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:651-675 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:765-789 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:53` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (24 lines × 4) · ×1
  • Duplicated block (24 lines × 4) src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:28 — src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:28-51 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:25-48 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:26-49 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:24-47 — before extracting anything, compare `src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs` and `src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (24–25 lines × 2) · ×1
  • Duplicated block (24–25 lines × 2) src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:174 — src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:174-197 | src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:216-240 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (23 lines × 4) · ×1
  • Duplicated block (23 lines × 4) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:22 — src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:22-44 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:20-42 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:22-44 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:22-44 — before extracting anything, compare `src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs` and `src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:22` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18–24 lines × 2) · ×1
  • Duplicated block (18–24 lines × 2) src/Orleans.CodeGenerator/CopierGenerator.cs:650 — src/Orleans.CodeGenerator/CopierGenerator.cs:650-673 | src/Orleans.CodeGenerator/SerializerGenerator.cs:750-767 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.CodeGenerator/CopierGenerator.cs:650` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 3) · ×1
  • Duplicated block (22 lines × 3) src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:80 — src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:80-101 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:205-226 | src/Orleans.Journaling/Formats/Json/JsonDurableCollectionCommandCodecs.cs:323-344 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (20–23 lines × 2) · ×1
  • Duplicated block (20–23 lines × 2) src/Azure/Shared/Storage/AzureTableDataManager.cs:703 — src/Azure/Shared/Storage/AzureTableDataManager.cs:703-725 | src/Azure/Shared/Storage/AzureTableDataManager.cs:763-782 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Shared/Storage/AzureTableDataManager.cs:703` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (20 lines × 3) · ×1
  • Duplicated block (20 lines × 3) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:35 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:35-54 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs:44-63 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDbReminderStorageOptionsExtensions.cs:36-55 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs` and `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipHelper.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProviderHelper.cs:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `DynamoDBGatewayOptions` in one and `DynamoDBClusteringOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (18–21 lines × 2) · ×1
  • Duplicated block (18–21 lines × 2) src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:115 — src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:115-135 | src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:185-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:183` calls `DelayBeforeRetry` and `src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:114` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (17–20 lines × 2) · ×1
  • Duplicated block (17–20 lines × 2) src/Orleans.Core/Core/DefaultClientServices.cs:40 — src/Orleans.Core/Core/DefaultClientServices.cs:40-56 | src/Orleans.Runtime/Hosting/DefaultSiloServices.cs:55-74 — before extracting anything, compare `src/Orleans.Core/Core/DefaultClientServices.cs` and `src/Orleans.Runtime/Hosting/DefaultSiloServices.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Core/DefaultClientServices.cs:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `builder` to `IClientBuilder` in one and `ISiloBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (18 lines × 7) · ×1
  • Duplicated block (18 lines × 7) src/Orleans.Serialization/Codecs/TupleCodec.cs:189 — src/Orleans.Serialization/Codecs/TupleCodec.cs:189-206 | src/Orleans.Serialization/Codecs/TupleCodec.cs:341-358 | src/Orleans.Serialization/Codecs/TupleCodec.cs:512-529 | src/Orleans.Serialization/Codecs/TupleCodec.cs:703-720 | src/Orleans.Serialization/Codecs/TupleCodec.cs:911-928 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1137-1154 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1379-1396 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/TupleCodec.cs:189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:83 — src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs:83-100 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs:54-71 | src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableSetCommandCodec.cs:56-73 — before extracting anything, compare `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableListCommandCodec.cs` and `src/Orleans.Journaling/Formats/OrleansBinary/OrleansBinaryDurableQueueCommandCodec.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (17–18 lines × 6) · ×1
  • Duplicated block (17–18 lines × 6) src/Orleans.Serialization/Codecs/CollectionCodec.cs:63 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:63-80 | src/Orleans.Serialization/Codecs/ListCodec.cs:62-79 | src/Orleans.Serialization/Codecs/QueueCodec.cs:67-83 | src/Orleans.Serialization/Codecs/StackCodec.cs:71-88 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:80-97 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:71-88 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (16–17 lines × 8) · ×1
  • Duplicated block (16–17 lines × 8) src/Orleans.Serialization/Codecs/CollectionCodec.cs:63 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:63-78 | src/Orleans.Serialization/Codecs/CollectionCodec.cs:132-148 | src/Orleans.Serialization/Codecs/ListCodec.cs:62-77 | src/Orleans.Serialization/Codecs/ListCodec.cs:131-147 | src/Orleans.Serialization/Codecs/QueueCodec.cs:67-82 | src/Orleans.Serialization/Codecs/StackCodec.cs:71-86 | src/Serializers/Orleans.Serialization.Protobuf/MapFieldCodec.cs:80-95 | src/Serializers/Orleans.Serialization.Protobuf/RepeatedFieldCodec.cs:71-86 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/CollectionCodec.cs:81` calls `RecordObject` and `src/Orleans.Serialization/Codecs/CollectionCodec.cs:150` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (14 lines × 4) · ×1
  • Duplicated block (14 lines × 4) src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:21 — src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:21-34 | src/AdoNet/Orleans.Clustering.AdoNet/AdoNetClusteringProviderBuilder.cs:45-58 | src/AdoNet/Orleans.Persistence.AdoNet/AdoNetGrainStorageProviderBuilder.cs:21-34 | src/AdoNet/Orleans.Reminders.AdoNet/AdoNetRemindersProviderBuilder.cs:20-33 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) src/Orleans.Serialization/Codecs/CollectionCodec.cs:90 — src/Orleans.Serialization/Codecs/CollectionCodec.cs:90-104 | src/Orleans.Serialization/Codecs/ListCodec.cs:89-103 | src/Orleans.Serialization/Codecs/QueueCodec.cs:93-107 — before extracting anything, compare `src/Orleans.Serialization/Codecs/CollectionCodec.cs` and `src/Orleans.Serialization/Codecs/ListCodec.cs` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 134 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Codecs/CollectionCodec.cs:90` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×1
  • Duplicated block (15–16 lines × 2) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89 — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89-103 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:200-215 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:89` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (14–15 lines × 10) · ×1
  • Duplicated block (14–15 lines × 10) src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34 — src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34-48 | src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs:40-53 | src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs:32-46 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:32-46 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs:34-48 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:34-48 | src/Redis/Orleans.Clustering.Redis/Hosting/RedisClusteringProviderBuilder.cs:34-48 | src/Redis/Orleans.GrainDirectory.Redis/Hosting/RedisGrainDirectoryProviderBuilder.cs:31-45 | src/Redis/Orleans.Persistence.Redis/Hosting/RedisGrainStorageProviderBuilder.cs:32-46 | src/Redis/Orleans.Reminders.Redis/Hosting/RedisRemindersProviderBuilder.cs:30-44 — before extracting anything, compare `src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs` and `src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureTableStorageGrainStorageProviderBuilder.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:34` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (14–15 lines × 4) · ×1
  • Duplicated block (14–15 lines × 4) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29-43 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:50-64 | src/Redis/Orleans.Journaling.Redis/RedisJournalingProviderBuilder.cs:23-36 | src/Redis/Orleans.Streaming.Redis/Hosting/RedisStreamingProviderBuilder.cs:33-47 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (14–15 lines × 3) · ×1
  • Duplicated block (14–15 lines × 3) src/Orleans.Core/Networking/ClientOutboundConnection.cs:127 — src/Orleans.Core/Networking/ClientOutboundConnection.cs:127-140 | src/Orleans.Runtime/Networking/GatewayInboundConnection.cs:195-209 | src/Orleans.Runtime/Networking/SiloConnection.cs:311-324 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Core/Networking/ClientOutboundConnection.cs:127` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×1
  • Duplicated block (14–15 lines × 2) REDACTED:309 — REDACTED:309-322 | REDACTED:382-396 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:309` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (12–14 lines × 4) · ×1
  • Duplicated block (12–14 lines × 4) src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:91 — src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:91-103 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:125-136 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:202-215 | src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:271-283 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:90` calls `ConfigureComponent` and `src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueStreamBuilder.cs:124` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) src/Orleans.CodeGenerator/SerializerGenerator.cs:452 — src/Orleans.CodeGenerator/SerializerGenerator.cs:452-465 | src/Orleans.CodeGenerator/SerializerGenerator.cs:632-644 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.CodeGenerator/SerializerGenerator.cs:645` calls `AddTypeParameterListParameters`, `TypeParameter` and `src/Orleans.CodeGenerator/SerializerGenerator.cs:466` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:85 — src/Orleans.Serialization/Codecs/ImmutableHashSetCodec.cs:85-93 | src/Orleans.Serialization/Codecs/ImmutableListCodec.cs:73-81 | src/Orleans.Serialization/Codecs/ImmutableQueueCodec.cs:73-81 | src/Orleans.Serialization/Codecs/ImmutableSortedSetCodec.cs:85-93 | src/Orleans.Serialization/Codecs/ImmutableStackCodec.cs:75-83 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 5 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `ImmutableHashSet<T>` in one and `ImmutableSortedSet<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:48 — src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:48-56 | src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs:96-104 | src/AWS/Orleans.Persistence.DynamoDB/Hosting/DynamoDBGrainStorageProviderBuilder.cs:60-68 | src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs:46-54 — before extracting anything, compare `src/AWS/Orleans.Clustering.DynamoDB/DynamoDBClusteringProviderBuilder.cs` and `src/AWS/Orleans.Reminders.DynamoDB/DynamoDBRemindersProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 57 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:131 — src/Orleans.CodeGenerator/Model/InvokableMethodDescription.cs:131-140 | src/Orleans.CodeGenerator/Model/ProxyMethodDescription.cs:61-70 | src/Orleans.CodeGenerator/Model/SerializableTypeDescription.cs:90-99 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9–12 lines × 3) · ×1
  • Duplicated block (9–12 lines × 3) src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85 — src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85-93 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:684-695 | src/Orleans.Serialization/Buffers/PooledBuffer.cs:798-809 — before extracting anything, compare `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs` and `src/Orleans.Serialization/Buffers/PooledBuffer.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 65 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization/Buffers/Adaptors/BufferSliceReaderInput.cs:85` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (9–12 lines × 2) · ×1
  • Duplicated block (9–12 lines × 2) src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102 — src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102-1110 | src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1259-1270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Analyzers/GrainInterfaceVersionCodeFix.cs:1102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 7) · ×1
  • Duplicated block (10 lines × 7) src/Orleans.Serialization/Codecs/TupleCodec.cs:161 — src/Orleans.Serialization/Codecs/TupleCodec.cs:161-170 | src/Orleans.Serialization/Codecs/TupleCodec.cs:311-320 | src/Orleans.Serialization/Codecs/TupleCodec.cs:480-489 | src/Orleans.Serialization/Codecs/TupleCodec.cs:669-678 | src/Orleans.Serialization/Codecs/TupleCodec.cs:875-884 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1098-1107 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1339-1348 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:321` calls `WriteField` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:172` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11 lines × 5) · ×1
  • Duplicated block (11 lines × 5) src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35 — src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35-45 | src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs:56-66 | src/Azure/Orleans.Persistence.AzureStorage/Hosting/AzureBlobStorageGrainStorageProviderBuilder.cs:38-48 | src/Azure/Orleans.Reminders.AzureStorage/AzureTableStorageRemindersProviderBuilder.cs:40-50 | src/Azure/Orleans.Streaming.AzureStorage/Hosting/AzureQueueStreamProviderBuilder.cs:71-81 — before extracting anything, compare `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs` and `src/Azure/Orleans.Journaling.AzureStorage/AzureTableStorageJournalingProviderBuilder.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs:35` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 5) · ×1
  • Duplicated block (7 lines × 5) src/Orleans.Serialization/Codecs/TupleCodec.cs:505 — src/Orleans.Serialization/Codecs/TupleCodec.cs:505-511 | src/Orleans.Serialization/Codecs/TupleCodec.cs:695-701 | src/Orleans.Serialization/Codecs/TupleCodec.cs:902-908 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1127-1133 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1368-1374 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:702` calls `default` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:512` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10 lines × 5) · ×1
  • Duplicated block (10 lines × 5) src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41 — src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41-50 | src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:50-59 | src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:77-86 | src/AWS/Orleans.Reminders.DynamoDB/Reminders/DynamoDBReminderTable.cs:55-64 | src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorageFactory.cs:108-117 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBGatewayListProvider.cs:41` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:61` calls `LogInformationInitializingMembershipTable` and `src/AWS/Orleans.Persistence.DynamoDB/Provider/DynamoDBGrainStorage.cs:88` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–10 lines × 3) · ×1
  • Duplicated block (8–10 lines × 3) src/Orleans.Runtime/Storage/StateStorageBridge.cs:313 — src/Orleans.Runtime/Storage/StateStorageBridge.cs:313-320 | src/Orleans.Runtime/Storage/StateStorageBridge.cs:350-357 | src/Orleans.Runtime/Storage/StateStorageBridge.cs:386-395 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Runtime/Storage/StateStorageBridge.cs:313` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–9 lines × 7) · ×1
  • Duplicated block (8–9 lines × 7) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867-875 | src/Orleans.Serialization/Codecs/TupleCodec.cs:829-837 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1047-1054 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1283-1290 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:714-722 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:888-895 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1077-1084 — there are 7 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Serialization.FSharp/FSharpCodecs.cs:867` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (6 lines × 7) · ×1
  • Duplicated block (6 lines × 7) src/Orleans.Serialization.FSharp/FSharpCodecs.cs:899 — src/Orleans.Serialization.FSharp/FSharpCodecs.cs:899-904 | src/Orleans.Serialization/Codecs/TupleCodec.cs:861-866 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1083-1088 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1323-1328 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:746-751 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:924-929 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1117-1122 — there are 7 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:1089` calls `UnwrapService` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:867` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 6) · ×1
  • Duplicated block (6 lines × 6) src/Orleans.Serialization/Codecs/TupleCodec.cs:991 — src/Orleans.Serialization/Codecs/TupleCodec.cs:991-996 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1224-1229 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1473-1478 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:846-851 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1032-1037 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1232-1237 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:1230` calls `UnwrapService` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:997` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 12) · ×1
  • Duplicated block (5 lines × 12) src/Orleans.Serialization/Codecs/TupleCodec.cs:317 — src/Orleans.Serialization/Codecs/TupleCodec.cs:317-321 | src/Orleans.Serialization/Codecs/TupleCodec.cs:486-490 | src/Orleans.Serialization/Codecs/TupleCodec.cs:675-679 | src/Orleans.Serialization/Codecs/TupleCodec.cs:881-885 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1104-1108 | src/Orleans.Serialization/Codecs/TupleCodec.cs:1345-1349 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:310-314 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:447-451 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:597-601 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:761-765 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:940-944 | src/Orleans.Serialization/Codecs/ValueTupleCodec.cs:1135-1139 — before extracting anything, compare `src/Orleans.Serialization/Codecs/TupleCodec.cs` and `src/Orleans.Serialization/Codecs/ValueTupleCodec.cs` as WHOLE FILES: this scan already matched 31 separate duplicated blocks between them, totalling at least 259 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Serialization/Codecs/TupleCodec.cs:491` calls `WriteField` and `src/Orleans.Serialization/Codecs/TupleCodec.cs:323` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×1
  • Duplicated block (5 lines × 4) src/Orleans.Serialization/Serializer.cs:81 — src/Orleans.Serialization/Serializer.cs:81-85 | src/Orleans.Serialization/Serializer.cs:183-187 | src/Orleans.Serialization/Serializer.cs:233-237 | src/Orleans.Serialization/Serializer.cs:267-271 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (2–5 lines × 3) · ×1
  • Duplicated block (2–5 lines × 3) src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:197 — src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:197-201 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:264-265 | src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:332-336 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/AdoNetGrainStorage.cs:197` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (54 lines × 2) · ×1
  • Duplicated block (54 lines × 2) docs/site/src/content/docs/host/snippets/transport-layer-security/csharp/ClientExample/Program.cs:11 — docs/site/src/content/docs/host/snippets/transport-layer-security/csharp/ClientExample/Program.cs:11-64 | docs/site/src/content/docs/host/snippets/transport-layer-security/csharp/SiloExample/Program.cs:12-109 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×1
  • Edited copy of a member (28 corresponding lines) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:57 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:57-90 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:98-125 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (10 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (10 members, 50+ identical tokens) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:233-257 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:265-296 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:303-326 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:333-361 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:371-413 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:421-458 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:514-547 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:555-605 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613-663 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:670-713 — These 10 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 10 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 10 times.
D4 · Code Duplication · Duplicated block (40–42 lines × 2) · ×1
  • Duplicated block (40–42 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613-654 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:670-709 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:613` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×1
  • Duplicated block (31 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:276 — src/Orleans.TestingHost/InProcTestCluster.cs:276-306 | src/Orleans.TestingHost/TestCluster.cs:357-387 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.TestingHost/InProcTestCluster.cs:276` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25–30 lines × 2) · ×1
  • Duplicated block (25–30 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61-90 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:101-125 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:61` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:60` calls `RandomTestGrain` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:99` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (29 lines × 2) · ×1
  • Duplicated block (29 lines × 2) src/Orleans.Transactions.TestKit.Base/Grains/ExclusiveLockTransactionTestGrain.cs:77 — src/Orleans.Transactions.TestKit.Base/Grains/ExclusiveLockTransactionTestGrain.cs:77-105 | src/Orleans.Transactions.TestKit.Base/Grains/MultiStateTransactionalGrain.cs:205-233 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (14–19 lines × 2) · ×1
  • Duplicated block (14–19 lines × 2) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:521 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:521-534 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:568-586 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (17–18 lines × 2) · ×1
  • Duplicated block (17–18 lines × 2) src/Orleans.TestingHost/InProcTestCluster.cs:531 — src/Orleans.TestingHost/InProcTestCluster.cs:531-548 | src/Orleans.TestingHost/TestCluster.cs:531-547 — before extracting anything, compare `src/Orleans.TestingHost/InProcTestCluster.cs` and `src/Orleans.TestingHost/TestCluster.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 140 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (9–11 lines × 3) · ×1
  • Duplicated block (9–11 lines × 3) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:33 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:33-41 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:66-76 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:105-114 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:76` calls `MultiGrainAdd` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionConcurrencyTestRunner.cs:41` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (7 lines × 6) · ×1
  • Duplicated block (7 lines × 6) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244-250 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:315-321 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:348-354 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441-447 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:536-542 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:588-594 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 5) · ×1
  • Duplicated block (6 lines × 5) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244-249 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:348-353 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441-446 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:588-593 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:642-647 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 8) · ×1
  • Duplicated block (6 lines × 8) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:244-249 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:285-290 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:315-320 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:348-353 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:402-407 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:441-446 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:536-541 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:588-593 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:343` calls `MakePendingState`, `Store` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:241` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:251 — src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:251-255 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:355-359 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:652-656 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:657-661 | src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:707-711 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:649` calls `AssertTState`, `Should`, `Be` and `src/Orleans.Transactions.TestKit.Base/TestRunners/TransactionalStateStorageTestRunner.cs:250` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D5 · Coupling · Unstable project SerializerContexts · ×1
  • Unstable project SerializerContexts docs/site/src/content/docs/host/configuration-guide/snippets/serializer-contexts/SerializerContexts.csproj:1 — SerializerContexts has instability 0.50 with 1 dependents.
D8 · Code Coverage · Coverage not measured · ×1
  • Coverage not measured — .NET and JavaScript/TypeScript suite — Coverage NOT MEASURED: the .NET half could not be measured — the repository runs its tests on Microsoft.Testing.Platform and wires up no coverage extension for it; the JavaScript/TypeScript half could not be measured — docs/site/ runs vitest but declares no coverage provider, so the suite can run and still produce no lcov — add `@vitest/coverage-v8` (or `@vitest/coverage-istanbul`) as a devDependency. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. The named suite step is one the repository's maintainers can perform; once it passes, the real number is measured on the next scan. Alternatively, commit the lcov/Cobertura report your CI produces and it is read without a re-run.
ED5 · Idempotency · Non-idempotent mutation · ×1
  • Non-idempotent mutation: Journaling.DurableList.AddRange src/Orleans.Journaling/DurableList.cs:170 — `Journaling.DurableList.AddRange` mutates persistent state (a repository write) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write.
IC1 · Incompleteness & stubs · Condition was already decided · ×1
  • Condition was already decided — an earlier guard makes this test constant src/Orleans.Core.Abstractions/Utils/Utils.cs:40 — Control only reaches here when `enumerator.MoveNext()` is true, because the guard on line 36 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test.
IC1 · Incompleteness & stubs · Bound check compiled out of the shipping build · ×1
  • Bound check compiled out of the shipping build src/Orleans.Core/Networking/Transport/Sockets/SocketMessageTransport.cs:807 — The only thing establishing that `buffers` is long enough before it is indexed is a `Debug.Assert`, which is `[Conditional("DEBUG")]` — the compiler deletes the call from Release, so the build your users install indexes `buffers` with no length check at all and throws at the indexer instead of failing diagnosably. `buffers` comes from outside this method, so its length is a contract, not something this code can see. Bound it with a check that ships (`if (buffers.Count < n) throw …`, or `ArgumentOutOfRangeException.ThrowIfLessThan`), and keep the assert for the invariant you believe holds.
IC1 · Incompleteness & stubs · Hollow method · ×1
  • Hollow method — returns a constant without doing the work src/Orleans.Core/Runtime/ClientLocalActivationStatusChecker.cs:5 — `IsLocallyActivated` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
IC1 · Incompleteness & stubs · Skipped test marks a known-real bug · ×1
  • Skipped test marks a known-real bug test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:416 — A test is skipped with reason "Flaky test. Needs to be investigated." — the behavior it asserts is UNVERIFIED and this skip is likely the only marker of a real bug. It ages invisibly: fix the flakiness or track the bug somewhere that can't be forgotten.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×1
  • Outbound HTTP without resilience REDACTED:9 — `new()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
R10 · Code Duplication · Duplication concentrated across 5 sibling directories (8 clone groups) · ×1
  • Duplication concentrated across 5 sibling directories (8 clone groups) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 — 8 duplicated blocks under src/Dashboard/Orleans.Dashboard.App/src/ have copies in at least two of the sibling directories components, grains, lifecycle, overview, silos — 7 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 8 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 8 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 8 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplicated block with local edits (51 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (51 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:103 · src/Dashboard/Orleans.Dashboard.App/src/grains/silo-table.tsx:33 — the two spans are one implementation copied and then locally edited — 342 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (35 lines × 2 locations) · ×1
  • Duplicated block (35 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138 — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:138 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:121 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (31 lines × 2 locations) · ×1
  • Duplicated block (31 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66 — src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:66 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:80 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (20 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (20 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24 — src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:24 · src/Dashboard/Orleans.Dashboard.App/src/components/time-series-chart.tsx:72 — the two spans are one implementation copied and then locally edited — 90 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (20 lines × 2 locations) · ×1
  • Duplicated block (20 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108 — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:108 · src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:129 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (19 lines × 2 locations) · ×1
  • Duplicated block (19 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:47 — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:47 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:76 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (18 lines × 2 locations) · ×1
  • Duplicated block (18 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx:214 — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:214 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:236 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (17 lines × 2 locations) · ×1
  • Duplicated block (17 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71 — src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:71 · src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (16 lines × 2 locations) · ×1
  • Duplicated block (16 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180 — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:180 · src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:196 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (14 lines × 4 locations) · ×1
  • Duplicated block (14 lines × 4 locations) src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188 — src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:188 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:202 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:216 · src/Dashboard/Orleans.Dashboard.App/src/components/grain-table.tsx:230 — all 4 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block (13 lines × 2 locations) · ×1
  • Duplicated block (13 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158 — src/Dashboard/Orleans.Dashboard.App/src/overview/overview.tsx:158 · src/Dashboard/Orleans.Dashboard.App/src/silos/silo.tsx:291 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (11 lines × 2 locations) · ×1
  • Duplicated block (11 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx:264 — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:264 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:391 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (9 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (9 matched lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15 — src/Dashboard/Orleans.Dashboard.App/src/components/gauge-widget.tsx:15 · src/Dashboard/Orleans.Dashboard.App/src/components/multi-series-chart-widget.tsx:16 — the two spans are one implementation copied and then locally edited — 65 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (9 lines × 2 locations) · ×1
  • Duplicated block (9 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41 — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:41 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (8 lines × 3 locations) · ×1
  • Duplicated block (8 lines × 3 locations) src/Dashboard/Orleans.Dashboard.App/src/index.tsx:286 — src/Dashboard/Orleans.Dashboard.App/src/index.tsx:286 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:294 · src/Dashboard/Orleans.Dashboard.App/src/index.tsx:302 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
R10 · Code Duplication · Duplicated block (7 lines × 2 locations) · ×1
  • Duplicated block (7 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31 — src/Dashboard/Orleans.Dashboard.App/src/components/reminder-table.tsx:31 · src/Dashboard/Orleans.Dashboard.App/src/grains/grain-details.tsx:21 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (6 lines × 2 locations) · ×1
  • Duplicated block (6 lines × 2 locations) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11 — src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:11 · src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:39 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R2 · Cyclomatic Complexity · Complex function parseSuffix (cyclomatic 14, cognitive 14) · ×1
  • Complex function parseSuffix (cyclomatic 14, cognitive 14) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:55 — parseSuffix has cyclomatic complexity 14 and cognitive complexity 14; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function parseType (cyclomatic 11, cognitive 11) · ×1
  • Complex function parseType (cyclomatic 11, cognitive 11) src/Dashboard/Orleans.Dashboard.App/src/lib/typeName.ts:79 — parseType has cyclomatic complexity 11 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function formatMemberName (cyclomatic 11, cognitive 10) · ×1
  • Complex function formatMemberName (cyclomatic 11, cognitive 10) src/Dashboard/Orleans.Dashboard.App/src/grains/grain.tsx:13 — formatMemberName has cyclomatic complexity 11 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R3 · Large Files · src/Dashboard/Orleans.Dashboard.App/src/index.tsx · ×1
  • src/Dashboard/Orleans.Dashboard.App/src/index.tsx: 589 lines of code src/Dashboard/Orleans.Dashboard.App/src/index.tsx:1 — src/Dashboard/Orleans.Dashboard.App/src/index.tsx has 589 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
S1 · Web-Security Posture · Third-party script without Subresource Integrity · ×1
  • Third-party script without Subresource Integrity playground/ActivationRebalancing/ActivationRebalancing.Frontend/wwwroot/index.html:7 — `https://d3js.org/d3.v7.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository.
X1 · Async correctness · Blocking `SemaphoreSlim.Wait` inside an `async` method · ×1
  • Blocking `SemaphoreSlim.Wait` inside an `async` method src/Orleans.Runtime/Manifest/ClusterManifestProvider.cs:511 — `SemaphoreSlim.Wait` parks the thread while it queues for the semaphore. `await semaphore.WaitAsync(…)` yields the thread instead.
X18 · Disposal-pattern correctness · Disposes a dependency it does not own · ×1
  • Disposes a dependency it does not own src/Orleans.DurableJobs/JournaledJobShard.cs:252 — `_stateManager` is never created by `JournaledJobShard` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 252). Its declared type `IJournaledStateManager` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
X24 · Document value interpolated into markup unescaped · Untrusted text written into markup unescaped · ×1
  • Untrusted text written into markup unescaped src/Dashboard/Orleans.Dashboard.App/src/lifecycle/lifecycle.tsx:284 — `svg` is text this program did not author, and it is written into the text of an element through `dangerouslySetInnerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
Minor — 343 finding(s)
D17 · Explicit Debt · ObsoleteWithoutCallers · ×102
  • ObsoleteWithoutCallers src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:42 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:38 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.Cosmos/Membership/CosmosMembershipTable.cs:35 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:37 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:35 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs:62 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/InMemoryMembershipTable.cs:98 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/LegacyMembershipTable.cs:19 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/MembershipTableCancellationTests.cs:440 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/SiloBuilderTests.cs:41 — [Obsolete] InitializeMembershipTable
  • ObsoleteWithoutCallers src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:146 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:63 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.Cosmos/Membership/CosmosMembershipTable.cs:90 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:54 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:44 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/Redis/Orleans.Clustering.Redis/Storage/RedisMembershipTable.cs:46 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/InMemoryMembershipTable.cs:84 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/LegacyMembershipTable.cs:21 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/Membership/MembershipTableCancellationTests.cs:442 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers test/Orleans.Core.Tests/SiloBuilderTests.cs:32 — [Obsolete] DeleteMembershipTableEntries
  • ObsoleteWithoutCallers src/AWS/Orleans.Clustering.DynamoDB/Membership/DynamoDBMembershipTable.cs:174 — [Obsolete] ReadRow
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.AzureStorage/AzureBasedMembershipTable.cs:81 — [Obsolete] ReadRow
  • ObsoleteWithoutCallers src/Azure/Orleans.Clustering.Cosmos/Membership/CosmosMembershipTable.cs:177 — [Obsolete] ReadRow
  • ObsoleteWithoutCallers src/Google/Orleans.Clustering.Firestore/FirestoreMembershipTable.cs:123 — [Obsolete] ReadRow
  • ObsoleteWithoutCallers src/Orleans.Runtime/MembershipService/SystemTargetBasedMembershipTable.cs:111 — [Obsolete] ReadRow
  • + 77 more in this group — see findings.md.
D34 · Knowledge Freshness · Orphaned file · ×84
  • Orphaned file src/Orleans.Core/Runtime/RingRange.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/AdoNet/Shared/Storage/DbConstantsStore.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Streaming/QueueBalancer/BestFitBalancer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/AdoNet/Shared/Storage/DbConnectionFactory.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventHubPartitionDataGenerator.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Transactions/DistributedTM/TransactionClient.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.TestingHost/Utils/StorageEmulator.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Azure/Orleans.Streaming.AzureStorage/Providers/Lease/AzureBlobLeaseProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/AdoNet/Orleans.GrainDirectory.AdoNet/AdoNetGrainDirectory.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubDataAdapter.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Runtime/Development/InMemoryLeaseProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/AdoNet/Shared/Storage/IRelationalStorage.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/CachePressureMonitors/SlowConsumingPressureMonitor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Redis/Orleans.Streaming.Redis/Streams/RedisStreamBuilder.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Core/Providers/ILeaseProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.EventSourcing/LogConsistency/ILogViewAdaptor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/AdoNet/Shared/Storage/OracleDatabaseCommandInterceptor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Transactions/Utilities/CommitQueue.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file src/Orleans.Core.Abstractions/Logging/LogFormatter.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 59 more in this group — see findings.md.
M4 · Documentation accuracy · README/code drift · ×40
  • README/code drift src/Orleans.Clustering.TestKit/README.md:3 — src/Orleans.Clustering.TestKit/README.md names the project `Microsoft.Orleans.Clustering.TestKit`, but no project, folder or namespace of that name exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.DurableJobs/README.md:26 — src/Orleans.DurableJobs/README.md installs the package `Microsoft.Orleans.DurableJobs.AzureStorage` (`dotnet add package Microsoft.Orleans.DurableJobs.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.Serialization.Abstractions/README.md:10 — src/Orleans.Serialization.Abstractions/README.md installs the package `Microsoft.Orleans.Serialization.Abstractions` (`dotnet add package Microsoft.Orleans.Serialization.Abstractions`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.Serialization.FSharp/README.md:10 — src/Orleans.Serialization.FSharp/README.md installs the package `Microsoft.Orleans.Serialization.FSharp` (`dotnet add package Microsoft.Orleans.Serialization.FSharp`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.Serialization.TestKit/README.md:10 — src/Orleans.Serialization.TestKit/README.md installs the package `Microsoft.Orleans.Serialization.TestKit` (`dotnet add package Microsoft.Orleans.Serialization.TestKit`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.Serialization/README.md:10 — src/Orleans.Serialization/README.md installs the package `Microsoft.Orleans.Serialization` (`dotnet add package Microsoft.Orleans.Serialization`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Orleans.Streaming.NATS/README.md:10 — src/Orleans.Streaming.NATS/README.md installs the package `Microsoft.Orleans.Streaming.NATS` (`dotnet add package Microsoft.Orleans.Streaming.NATS`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/AWS/Orleans.Streaming.SQS/README.md:8 — src/AWS/Orleans.Streaming.SQS/README.md installs the package `Microsoft.Orleans.Streaming.SQS` (`dotnet add package Microsoft.Orleans.Streaming.SQS`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/AWS/Orleans.Transactions.DynamoDB/README.md:13 — src/AWS/Orleans.Transactions.DynamoDB/README.md installs the package `Microsoft.Orleans.Transactions.DynamoDB` (`dotnet add package Microsoft.Orleans.Transactions.DynamoDB`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/AdoNet/Orleans.Streaming.AdoNet/README.md:10 — src/AdoNet/Orleans.Streaming.AdoNet/README.md installs the package `Microsoft.Orleans.Streaming.AdoNet` (`dotnet add package Microsoft.Orleans.Streaming.AdoNet`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Azure/Orleans.DurableJobs.AzureStorage/README.md:13 — src/Azure/Orleans.DurableJobs.AzureStorage/README.md installs the package `Microsoft.Orleans.DurableJobs.AzureStorage` (`dotnet add package Microsoft.Orleans.DurableJobs.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Azure/Orleans.GrainDirectory.AzureStorage/README.md:10 — src/Azure/Orleans.GrainDirectory.AzureStorage/README.md installs the package `Microsoft.Orleans.GrainDirectory.AzureStorage` (`dotnet add package Microsoft.Orleans.GrainDirectory.AzureStorage`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Dashboard/Orleans.Dashboard.Abstractions/README.md:12 — src/Dashboard/Orleans.Dashboard.Abstractions/README.md installs the package `Microsoft.Orleans.Dashboard.Abstractions` (`dotnet add package Microsoft.Orleans.Dashboard.Abstractions`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Redis/Orleans.Journaling.Redis/README.md:14 — src/Redis/Orleans.Journaling.Redis/README.md installs the package `Microsoft.Orleans.Journaling.Redis` (`dotnet add package Microsoft.Orleans.Journaling.Redis`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift src/Serializers/Orleans.Serialization.Protobuf/README.md:10 — src/Serializers/Orleans.Serialization.Protobuf/README.md installs the package `Microsoft.Orleans.Serialization.Protobuf` (`dotnet add package Microsoft.Orleans.Serialization.Protobuf`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:54 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/benefits/`, but `orleans/docs/benefits` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:55 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/grains/grain-persistence/`, but `orleans/docs/grains/grain-persistence` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:56 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/grains/timers-and-reminders/`, but `orleans/docs/grains/timers-and-reminders` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:57 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/host/monitoring/`, but `orleans/docs/host/monitoring` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:58 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/implementation/testing/`, but `orleans/docs/implementation/testing` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/docs.mdx:59 — docs/site/src/site-pages/docs.mdx links to `/orleans/docs/migration-guide/`, but `orleans/docs/migration-guide` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/home.mdx:35 — docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/`, but `orleans/docs/grains` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/home.mdx:38 — docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/grain-persistence/`, but `orleans/docs/grains/grain-persistence` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/home.mdx:41 — docs/site/src/site-pages/home.mdx links to `/orleans/docs/streaming/`, but `orleans/docs/streaming` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/site/src/site-pages/home.mdx:44 — docs/site/src/site-pages/home.mdx links to `/orleans/docs/grains/timers-and-reminders/`, but `orleans/docs/grains/timers-and-reminders` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • + 15 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×25
  • Duplicated predicate src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs:55 — `!Utf8Parser.TryParse(key, out Guid guidKey, out var len, 'N') || len < key.Length` appears character-identically in 2 files — src/Orleans.BroadcastChannel/IdMapping/DefaultChannelIdMapper.cs, src/Orleans.Streaming/Core/DefaultStreamIdMapper.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Core.Abstractions/IDs/SiloAddressCodec.cs:54 — `!header.HasFieldId || header.FieldIdDelta != 0` appears character-identically in 2 files — src/Orleans.Core.Abstractions/IDs/SiloAddressCodec.cs, src/Orleans.Serialization/Codecs/IPEndPointCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1432 — `!metadata.TryGetValue(propertyName, out var currentValue) || !string.Equals(currentValue, value, StringComparison.Ordinal)` appears character-identically in 3 files — src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs, src/Azure/Orleans.Journaling.AzureStorage/AzureBlobJournalStorage.cs, src/Azure/Orleans.Journaling.AzureStorage/AzureTableJournalStorage.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs:408 — `!potentialPrimaryConstructor.IsImplicitlyDeclared && !potentialPrimaryConstructor.IsCompilerGenerated()` appears character-identically in 2 files — src/Orleans.CodeGenerator/Model/SerializableTypeModelExtractor.cs, src/Orleans.CodeGenerator/SerializableSourceOutputGenerator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Streaming/JsonConverters/EventSequenceTokenJsonConverter.cs:58 — `!reader.Read() || reader.TokenType != JsonTokenType.EndArray` appears character-identically in 2 files — src/Orleans.Streaming/JsonConverters/EventSequenceTokenJsonConverter.cs, src/Orleans.Streaming/StreamId.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Core/Serialization/SystemTextJson/GrainReferenceConverter.cs:31 — `!reader.Read() || reader.TokenType != JsonTokenType.String` appears character-identically in 3 files — src/Orleans.Core/Serialization/SystemTextJson/GrainReferenceConverter.cs, src/Orleans.Streaming.NATS/Providers/StreamIdJsonConverter.cs, src/Orleans.Streaming/StreamId.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs:96 — `!right.TryGetValue(entry.Key, out var value) || !string.Equals(entry.Value, value, StringComparison.Ordinal)` appears character-identically in 2 files — src/Orleans.Core.Abstractions/Manifest/GrainInterfaceProperties.cs, src/Orleans.Core.Abstractions/Manifest/GrainProperties.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs:41 — `!string.IsNullOrEmpty(connectionName) && string.IsNullOrEmpty(connectionString)` appears character-identically in 17 files — src/Azure/Orleans.Clustering.AzureStorage/AzureTableStorageClusteringProviderBuilder.cs, src/Azure/Orleans.Clustering.Cosmos/CosmosClusteringProviderBuilder.cs, src/Azure/Orleans.GrainDirectory.AzureStorage/Hosting/AzureTableStorageGrainDirectoryProviderBuilder.cs, src/Azure/Orleans.Journaling.AzureStorage/AzureBlobStorageJournalingProviderBuilder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/AWS/Orleans.Streaming.Kinesis/Streams/DynamoDBStreamQueueCheckpointerFactory.cs:144 — `!string.IsNullOrEmpty(options.AccessKey) && !string.IsNullOrEmpty(options.SecretKey)` appears character-identically in 2 files — src/AWS/Orleans.Streaming.Kinesis/Streams/DynamoDBStreamQueueCheckpointerFactory.cs, src/AWS/Orleans.Streaming.Kinesis/Streams/KinesisAdapterFactory.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.CodeGenerator/MetadataGenerator.cs:753 — `!type.IsAbstractType && !type.IsEnumType && (!type.IsValueType && type.IsEmptyConstructable && !type.UseActivator || type.HasActivatorConstr…` appears character-identically in 2 files — src/Orleans.CodeGenerator/MetadataGenerator.cs, src/Orleans.CodeGenerator/Model/MetadataAggregateModelBuilder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs:157 — `(!string.IsNullOrWhiteSpace(keyETag) || !string.IsNullOrWhiteSpace(expectedETag)) && keyETag != expectedETag` appears character-identically in 2 files — src/AWS/Orleans.Transactions.DynamoDB/TransactionalState/DynamoDBTransactionalStateStorage.cs, src/Azure/Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs:240 — `((IGeneralizedCodec)this).IsSupportedType(type) || ((IGeneralizedCopier)this).IsSupportedType(type)` appears character-identically in 2 files — src/Orleans.Serialization.NewtonsoftJson/NewtonsoftJsonCodec.cs, src/Serializers/Orleans.Serialization.Protobuf/ProtobufCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization.MessagePack/MessagePackCodec.cs:242 — `((IGeneralizedCopier)this).IsSupportedType(type) || ((IGeneralizedCodec)this).IsSupportedType(type)` appears character-identically in 2 files — src/Orleans.Serialization.MessagePack/MessagePackCodec.cs, src/Orleans.Serialization.SystemTextJson/JsonCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Core/Core/DefaultClientServices.cs:188 — `ConfigurationValueParser.TryParseValue<bool>(cfg, "EnableDistributedTracing", out var enableDistributedTracing) && enableDistributedTracing` appears character-identically in 2 files — src/Orleans.Core/Core/DefaultClientServices.cs, src/Orleans.Runtime/Hosting/DefaultSiloServices.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.CodeGenerator/CopierGenerator.cs:24 — `HotReloadSafe && !type.IsEnumType && type.SupportsHotReloadMemberAddition` appears character-identically in 2 files — src/Orleans.CodeGenerator/CopierGenerator.cs, src/Orleans.CodeGenerator/SerializerGenerator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Runtime/Placement/Repartitioning/FrequentItemCollection.cs:69 — `Log2Arity > 0 && Math.Pow(2, Log2Arity) == Arity` appears character-identically in 2 files — src/Orleans.Runtime/Placement/Repartitioning/FrequentItemCollection.cs, src/Orleans.Runtime/Placement/Repartitioning/MaxHeap.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:245 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2)` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:407 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:586 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:785 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:1001 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:1235 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/TupleCodec.cs:1485 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier1) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._copier2) && OrleansGenerat…` appears character-identically in 2 files — src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs:86 — `OrleansGeneratedCodeHelper.IsShallowCopyable(self._keyCopier) && OrleansGeneratedCodeHelper.IsShallowCopyable(self._valueCopier)` appears character-identically in 4 files — src/Orleans.Serialization/Codecs/FrozenDictionaryCodec.cs, src/Orleans.Serialization/Codecs/ImmutableDictionaryCodec.cs, src/Orleans.Serialization/Codecs/ImmutableSortedDictionaryCodec.cs, src/Orleans.Serialization/Codecs/KeyValuePairCodec.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate src/Orleans.Core.Abstractions/Manifest/ClusterManifest.cs:161 — `ReferenceEquals(dictionary.KeyComparer, EqualityComparer<TKey>.Default) && ReferenceEquals(dictionary.ValueComparer, EqualityComparer<TValue…` appears character-identically in 2 files — src/Orleans.Core.Abstractions/Manifest/ClusterManifest.cs, src/Orleans.Core.Abstractions/Manifest/GrainManifest.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
X4 · Structured logging · Interpolated log message defeats structured logging · ×16
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:34 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:35 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:105 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:107 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:111 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:113 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging playground/ChaoticCluster/ChaoticCluster.Silo/Program.cs:120 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:203 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:293 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingAgent.cs:333 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging src/Orleans.Streaming/PersistentStreams/PersistentStreamPullingManager.cs:398 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging samples/Blazor/BlazorServer/Services/TodoService.cs:66 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging samples/Deployment/AzureContainerApps/Grains/SensorTwinGrain.cs:17 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging samples/Deployment/AzureContainerApps/Scaler/Services/ExternalScalerService.cs:48 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging samples/Deployment/AzureContainerApps/Scaler/Services/ExternalScalerService.cs:100 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging samples/Deployment/AzureContainerApps/Scaler/Services/ExternalScalerService.cs:139 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
IC1 · Incompleteness & stubs · Commented-out code · ×12
  • Commented-out code docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/StorageConfiguration.cs:137 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/StorageConfiguration.cs:158 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:24 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code playground/ActivationRebalancing/ActivationRebalancing.Cluster/Program.cs:25 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code playground/DurableJobsJournaling/DurableJobsJournaling.Silo/WorkflowGrains.cs:41 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/Orleans3CompatibleStringKeyHasher.cs:35 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/AdoNet/Orleans.Persistence.AdoNet/Storage/Provider/Orleans3CompatibleStringKeyHasher.cs:36 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/Azure/Orleans.Reminders.AzureStorage/Storage/RemindersTableManager.cs:49 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/Azure/Orleans.Reminders.AzureStorage/Storage/RemindersTableManager.cs:172 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/Azure/Orleans.Streaming.AzureStorage/Providers/Streams/AzureQueue/AzureQueueBatchContainer.cs:78 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/Orleans.CodeGenerator/InvokableGenerator.cs:447 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code src/Orleans.CodeGenerator/InvokableGenerator.cs:448 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
D27 · Navigability · Pass-through layer · ×10
  • Pass-through layer src/Orleans.Core/Networking/ConnectionTrace.cs:8 — ConnectionTrace: all 3 public methods forward their arguments unchanged to _log and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _log directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:5 — JsonDurableDictionaryCommandCodecService: all 5 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:22 — JsonDurableListCommandCodecService: all 7 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:43 — JsonDurableQueueCommandCodecService: all 5 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:60 — JsonDurableSetCommandCodecService: all 5 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:88 — JsonPersistentStateCommandCodecService: all 3 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Journaling/Formats/Json/JsonCommandCodecServices.cs:101 — JsonDurableTaskCompletionSourceCommandCodecService: all 5 public methods forward their arguments unchanged to _inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _inner directly, or give the layer a job.
  • Pass-through layer src/Orleans.Runtime/Core/InternalClusterClient.cs:8 — InternalClusterClient: all 22 public methods forward their arguments unchanged to grainFactory and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call grainFactory directly, or give the layer a job.
  • Pass-through layer src/Orleans.Serialization/Buffers/Adaptors/BufferWriterBox.cs:10 — BufferWriterBox: all 3 public methods forward their arguments unchanged to _bufferWriter and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call _bufferWriter directly, or give the layer a job.
  • Pass-through layer src/AdoNet/Orleans.Streaming.AdoNet/AdoNetQueueAdapterReceiver.cs:231 — RelationalStreamMessageQueries: all 3 public methods forward their arguments unchanged to queries and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call queries directly, or give the layer a job.
X7 · Silent fallback defaults · Silent fallback default in catch · ×10
  • Silent fallback default in catch src/Orleans.Core/Networking/Transport/Security/TlsMessageTransport.cs:202 — `GetOptionalTlsPropertyOrDefault` swallows `NotSupportedException` into `return default;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/Orleans.TestingHost/ClusterManifestStabilizationHelper.cs:47 — `WaitForExpectedClusterManifestAsync` swallows `TimeoutException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/Orleans.TestingHost/LivenessStabilizationHelper.cs:62 — `WaitForExpectedActiveSilosAsync` swallows `TimeoutException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:327 — `InsertRowCoreAsync` swallows `KeeperException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs:391 — `UpdateRowCoreAsync` swallows `KeeperException.BadVersionException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1095 — `ObjectExistsAsync` swallows `AmazonS3Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs:1300 — `GetWalPartsCountAsync` swallows `AmazonS3Exception` into `return MaxAppendPartsPerObject;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch REDACTED:120 — `DoesTableAlreadyExistAsync` swallows `UnauthorizedException` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch samples/Streaming/CustomDataAdapter/Silo/CustomDataAdapter.cs:58 — `GetEvents` swallows every exception into `return Array.Empty<Tuple<T, StreamSequenceToken>>();` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
  • Silent fallback default in catch docs/tools/PackageJsonGenerator/Helpers/CanonicalModelBuilder.cs:1153 — `ExtractSummary` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
AX6 · Interface segregation · Fat interface · ×6
  • Fat interface: IGrainFactory (17 members) src/Orleans.Core.Abstractions/Core/IGrainFactory.cs:47 — `IGrainFactory` declares 17 members under just 3 distinct name(s): `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `CreateObjectReference`, `DeleteObjectReference`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`, `GetGrain`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: IGrainContext (16 members) src/Orleans.Core.Abstractions/Core/IGrainContext.cs:12 — `IGrainContext` declares 16 members: `GrainReference`, `GrainId`, `GrainInstance`, `ActivationId`, `Address`, `ActivationServices`, `ObservableLifecycle`, `Scheduler`, `Deactivated`, `SetComponent`, `ReceiveMessage`, `ReceiveLocalRequest`, `Activate`, `Deactivate`, `Rehydrate`, `Migrate`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IMembershipTable (16 members) src/Orleans.Core/SystemTargetInterfaces/IMembershipTable.cs:24 — `IMembershipTable` declares 16 members: `InitializeMembershipTable`, `InitializeMembershipTableAsync`, `DeleteMembershipTableEntries`, `DeleteMembershipTableEntriesAsync`, `CleanupDefunctSiloEntries`, `CleanupDefunctSiloEntriesAsync`, `ReadRow`, `ReadRowAsync`, `ReadAll`, `ReadAllAsync`, `InsertRow`, `InsertRowAsync`, `UpdateRow`, `UpdateRowAsync`, `UpdateIAmAlive`, `UpdateIAmAliveAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IManagementGrain (35 members) src/Orleans.Core/SystemTargetInterfaces/IManagementGrain.cs:13 — `IManagementGrain` declares 35 members: `DeactivateGrain`, `GetHosts`, `GetHosts`, `GetDetailedHosts`, `GetDetailedHosts`, `ForceGarbageCollection`, `ForceGarbageCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceActivationCollection`, `ForceRuntimeStatisticsCollection`, `ForceRuntimeStatisticsCollection`, `GetRuntimeStatistics`, `GetRuntimeStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetSimpleGrainStatistics`, `GetDetailedGrainStatistics`, `GetDetailedGrainStatistics`, `GetGrainActivationCount`, `GetGrainActivationCount`, `GetTotalActivationCount`, `GetTotalActivationCount`, `SendControlCommandToProvider`, `SendControlCommandToProvider`, `GetActivationAddress`, `GetActivationAddress`, `GetActiveGrains`, `GetActiveGrains`, `GetGrainCallFrequencies`, `GetGrainCallFrequencies`, `ResetGrainCallFrequencies`, `ResetGrainCallFrequencies`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 35 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IReminderServiceLifecycleHarness (22 members) src/Orleans.Reminders.TestKit/ReminderServiceLifecycleTestRunner.cs:16 — `IReminderServiceLifecycleHarness` declares 22 members: `GrainFactory`, `ReminderTable`, `UtcNow`, `ReminderLoadingWindow`, `ReminderRefreshPeriod`, `ActiveSilos`, `WaitForStartupReadinessAsync`, `AdvanceAsync`, `RefreshAsync`, `WaitForOwnerCountAsync`, `GetOwners`, `IsOwner`, `WaitForScheduleAsync`, `GetLocalStartCount`, `GetLocalStopCount`, `GetScheduleChangeCount`, `WaitForScheduleChangeCountAsync`, `WaitForTickCountAsync`, `GetTickCount`, `JoinOneSiloAsync`, `LeaveSiloAsync`, `WaitForTopologyReconciliationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IStreamPubSub (17 members) src/Orleans.Streaming/Providers/IStreamProviderRuntime.cs:72 — `IStreamPubSub` declares 17 members under just 9 distinct name(s): `RegisterProducer`, `RegisterProducer`, `UnregisterProducer`, `UnregisterProducer`, `RegisterConsumer`, `RegisterConsumer`, `UnregisterConsumer`, `UnregisterConsumer`, `ProducerCount`, `ProducerCount`, `ConsumerCount`, `ConsumerCount`, `GetAllSubscriptions`, `GetAllSubscriptions`, `CreateSubscriptionId`, `FaultSubscription`, `FaultSubscription`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×5
  • Silent fallback default on parse failure src/Orleans.Core/Networking/Transport/Sockets/SocketAwaitableEventArgs.cs:68 — `GetStatus` falls back to `ValueTaskSourceStatus.Faulted` when `SocketError == SocketError.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/Orleans.DurableJobs/JournaledJobShardManager.cs:861 — `From` falls back to `MembershipVersion.MinValue` when `values.TryGetValue(MembershipVersionProperty, out var membershipVersionValue) &&…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/Orleans.Runtime/GrainDirectory/DistributedGrainDirectory.cs:729 — `GetToken` falls back to `CanceledToken` when `entries.TryGetValue(siloAddress, out var entry)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure src/Orleans.TestingHost/InProcess/InProcessMembershipTable.cs:152 — `GetSiloStatus` falls back to `SiloStatus.None` when `_table.TryGetValue(key, out var data)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
  • Silent fallback default on parse failure docs/tools/PackageJsonGenerator/PackageJsonGenerator.cs:460 — `ParseStartLine` falls back to `0` when `dash > 0 && int.TryParse(sourceLines[..dash], out var line)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
D18 · Solution Shape · Thin analysable surface across projects · ×4
  • Thin analysable surface across projects: SharedContracts docs/site/src/content/docs/host/snippets/aspire/SharedContracts/SharedContracts.csproj — 4 project(s) carry only a thin slice of real code; `SharedContracts` has 5 significant line(s). The mean analysable-surface weight is 96 %; this project lowers Solution Shape by about 0.06 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
  • Thin analysable surface across projects: Client docs/site/src/content/docs/host/snippets/aspire/Client/Client.csproj — 4 project(s) carry only a thin slice of real code; `Client` has 13 significant line(s). The mean analysable-surface weight is 96 %; this project lowers Solution Shape by about 0.06 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
  • Thin analysable surface across projects: versioning docs/site/src/content/docs/grains/grain-versioning/snippets/versioning/versioning.csproj — 4 project(s) carry only a thin slice of real code; `versioning` has 21 significant line(s). The mean analysable-surface weight is 96 %; this project lowers Solution Shape by about 0.04 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
  • Thin analysable surface across projects: subscription-start-positions docs/site/src/content/docs/streaming/snippets/subscription-start-positions/subscription-start-positions.csproj — 4 project(s) carry only a thin slice of real code; `subscription-start-positions` has 28 significant line(s). The mean analysable-surface weight is 96 %; this project lowers Solution Shape by about 0.03 point(s). Consolidate it or grow it into a substantial, well-scoped assembly.
D16 · Bus Factor · Off-boarding risk · ×2
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 299 significant file(s) lose their only recent owner: src/Orleans.Reminders/ReminderService/LocalReminderService.cs, src/Orleans.Serialization/Codecs/TupleCodec.cs, src/Orleans.Transactions/State/TransactionQueue.cs, src/Orleans.Runtime/MembershipService/MembershipTableManager.cs, src/Orleans.Serialization.FSharp/FSharpCodecs.cs, src/Orleans.Serialization/Codecs/ValueTupleCodec.cs, src/AWS/Orleans.Journaling.S3/S3JournalStorage.cs, src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.cs (+291 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 3 significant file(s) lose their only recent owner: src/Orleans.Streaming/Common/Monitors/DefaultCacheMonitor.cs, src/Orleans.Streaming/Common/Monitors/DefaultQueueAdapterReceiverMonitor.cs, src/Orleans.Streaming/Common/Monitors/DefaultBlockPoolMonitor.cs. Pair on, review, or document these before any departure.
D18 · Solution Shape · Shell project · ×2
  • Shell project: Interfaces samples/VBHelloWorld/Interfaces/Interfaces.vbproj — `Interfaces` contributes only 4 significant line(s) — an empty/placeholder project is structural noise. Remove it or fold its contents into a real project.
  • Shell project: VBGrains samples/VBHelloWorld/VBGrains/VBGrains.vbproj — `VBGrains` contributes only 8 significant line(s) — an empty/placeholder project is structural noise. Remove it or fold its contents into a real project.
IC1 · Incompleteness & stubs · Member throws NotSupportedException · ×2
  • Member throws NotSupportedException src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:432 — `GetEvents`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
  • Member throws NotSupportedException src/Azure/Orleans.Streaming.EventHubs/Providers/Streams/EventHub/EventHubAdapterReceiver.cs:433 — `ImportRequestContext`'s body only throws NotSupportedException — sometimes a deliberate contract, often an unfinished stub. Confirm it's intentional.
P2 · Observability · Console output used as the logging channel · ×2
  • Console output used as the logging channel src/Orleans.Runtime/Core/FatalErrorHandler.cs:33 — `src/Orleans.Runtime/Core/FatalErrorHandler.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
  • Console output used as the logging channel docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs:119 — `docs/site/src/content/docs/snippets/compiled/Grains/ServicesAndObserversSnippets.cs` reports through `Console.Write…` at line 119 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
C3 · Audit Trail · Partial audit-trail evidence · ×1
  • Partial audit-trail evidence — An audit mechanism is present, but the trail is not yet complete — missing: a write-side hook (the one code path every change to the sensitive data flows through, recording who changed what), [Audited] per-entity coverage.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D24 · Comment Value · redundant comment · ×1
  • redundant comment docs/site/src/content/docs/host/snippets/aspire/AppHost/AppHostExamples.cs:86 — "Add Azure Storage for Orleans" — weak keep - explains why AddAzureStorage is present; could be trimmed if it restates the builder call
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 6 of 280 project(s) overshoot their size bounds, lowering Project Cohesion to 9.6/10. The most over is `Orleans.Runtime(net8.0)` (44338 LoC, 147 public types across 20 namespaces). Review these for cohesion — split a project that spans unrelated responsibilities.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Low CVE · ×1
  • REDACTED
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 84 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: src/Orleans.Core/Runtime/RingRange.cs, src/Orleans.EventSourcing/LogStorage/LogViewAdaptor.cs, src/Orleans.EventSourcing/CustomStorage/LogViewAdaptor.cs, src/Orleans.BroadcastChannel/SubscriberTable/ImplicitChannelSubscriberTable.cs, src/Azure/Orleans.Streaming.EventHubs/Providers/EventDataGeneratorStreamProvider/EventDataGeneratorAdapterFactory.cs, src/Orleans.Transactions.TestKit.Base/TestRunners/GoldenPathTransactionTestRunner.cs, src/AdoNet/Shared/Storage/DbConstantsStore.cs, src/Orleans.Serialization.MessagePack/MessagePackCodec.cs (and 76 more) (85 orphaned of 1136 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1136 of the 2017 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
IC1 · Incompleteness & stubs · Empty method body · ×1
  • Empty method body docs/site/src/content/docs/snippets/compiled/Grains/GeneralSnippets.cs:66 — `WorkerAsync` has an empty body — confirm it's an intentional no-op and not an unfinished method.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M3 · Folder & project structure · Inconsistent root namespaces · ×1
  • Inconsistent root namespaces — Only 118/280 projects share a common root namespace — the code's module identity is inconsistent.
P10 · Library API & versioning · No explicit versioning · ×1
  • No explicit versioning — No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.
P12 · CI test-gate honesty · Sleep-based test synchronization · ×1
  • Sleep-based test synchronization — 191 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 91/126 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 126, 53 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
S1 · Web-Security Posture · Security headers incomplete · ×1
  • Security headers incomplete samples/ShoppingCart/Silo/Program.cs:56 — Set: Content-Security-Policy, X-Frame-Options. Missing: Strict-Transport-Security, X-Content-Type-Options — the four headers that carry the points of this card's security-headers term (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options), 0.5 each. (−1.0 on this card.)
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 948/1900 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X5 · Nullable reference types · Nullable reference types not enabled everywhere · ×1
  • Nullable reference types not enabled everywhere — 209/210 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
X5 · Nullable reference types · Null-forgiving operator (`!`) suppressions reduce the NRT score · ×1
  • Null-forgiving operator (`!`) suppressions reduce the NRT score — ~1.5 `!` suppressions per 1k syntax nodes — 1892 suppression(s) across the 1221106 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Minor — 194 finding(s)
D19 · Documentation Quality · XML-doc coverage · ×164
  • XML-doc coverage: ActivationSheddingToy playground/ActivationSheddingToy/ActivationSheddingToy.csproj — ActivationSheddingToy: 0 % XML-doc coverage (0/1).
  • XML-doc coverage: ActivationRebalancing.Cluster playground/ActivationRebalancing/ActivationRebalancing.Cluster/ActivationRebalancing.Cluster.csproj — ActivationRebalancing.Cluster: 0 % XML-doc coverage (0/3).
  • XML-doc coverage: ActivationRebalancing.Frontend playground/ActivationRebalancing/ActivationRebalancing.Frontend/ActivationRebalancing.Frontend.csproj — ActivationRebalancing.Frontend: 0 % XML-doc coverage (0/3).
  • XML-doc coverage: ActivationRepartitioning.Frontend playground/ActivationRepartitioning/ActivationRepartitioning.Frontend/ActivationRepartitioning.Frontend.csproj — ActivationRepartitioning.Frontend: 0 % XML-doc coverage (0/19).
  • XML-doc coverage: ChaoticCluster.ServiceDefaults playground/ChaoticCluster/ChaoticCluster.ServiceDefaults/ChaoticCluster.ServiceDefaults.csproj — ChaoticCluster.ServiceDefaults: 0 % XML-doc coverage (0/5).
  • XML-doc coverage: ChaoticCluster.Silo playground/ChaoticCluster/ChaoticCluster.Silo/ChaoticCluster.Silo.csproj — ChaoticCluster.Silo: 0 % XML-doc coverage (0/2).
  • XML-doc coverage: DurableJobsJournaling.Abstractions playground/DurableJobsJournaling/DurableJobsJournaling.Abstractions/DurableJobsJournaling.Abstractions.csproj — DurableJobsJournaling.Abstractions: 0 % XML-doc coverage (0/22).
  • XML-doc coverage: DurableJobsJournaling.AppHost playground/DurableJobsJournaling/DurableJobsJournaling.AppHost/DurableJobsJournaling.AppHost.csproj — DurableJobsJournaling.AppHost: 0 % XML-doc coverage (0/6).
  • XML-doc coverage: DurableJobsJournaling.ServiceDefaults playground/DurableJobsJournaling/DurableJobsJournaling.ServiceDefaults/DurableJobsJournaling.ServiceDefaults.csproj — DurableJobsJournaling.ServiceDefaults: 0 % XML-doc coverage (0/5).
  • XML-doc coverage: DurableJobsJournaling.Silo playground/DurableJobsJournaling/DurableJobsJournaling.Silo/DurableJobsJournaling.Silo.csproj — DurableJobsJournaling.Silo: 0 % XML-doc coverage (0/15).
  • XML-doc coverage: DurableJobsJournaling.Web playground/DurableJobsJournaling/DurableJobsJournaling.Web/DurableJobsJournaling.Web.csproj — DurableJobsJournaling.Web: 0 % XML-doc coverage (0/23).
  • XML-doc coverage: Orleans.Analyzers.Contracts src/Orleans.Analyzers.Contracts/Orleans.Analyzers.Contracts.csproj — Orleans.Analyzers.Contracts: 29 % XML-doc coverage (42/146).
  • XML-doc coverage: Orleans.Analyzers src/Orleans.Analyzers/Orleans.Analyzers.csproj — Orleans.Analyzers: 14 % XML-doc coverage (25/179).
  • XML-doc coverage: Orleans.BroadcastChannel(net8.0) src/Orleans.BroadcastChannel/Orleans.BroadcastChannel.csproj — Orleans.BroadcastChannel(net8.0): 64 % XML-doc coverage (82/128).
  • XML-doc coverage: Orleans.CodeGenerator src/Orleans.CodeGenerator/Orleans.CodeGenerator.csproj — Orleans.CodeGenerator: 16 % XML-doc coverage (139/852).
  • XML-doc coverage: Orleans.Core.Abstractions(net8.0) src/Orleans.Core.Abstractions/Orleans.Core.Abstractions.csproj — Orleans.Core.Abstractions(net8.0): 95 % XML-doc coverage (938/986).
  • XML-doc coverage: Orleans.Core(net8.0) src/Orleans.Core/Orleans.Core.csproj — Orleans.Core(net8.0): 57 % XML-doc coverage (1191/2100).
  • XML-doc coverage: Orleans.DurableJobs(net8.0) src/Orleans.DurableJobs/Orleans.DurableJobs.csproj — Orleans.DurableJobs(net8.0): 51 % XML-doc coverage (149/293).
  • XML-doc coverage: Orleans.EventSourcing(net8.0) src/Orleans.EventSourcing/Orleans.EventSourcing.csproj — Orleans.EventSourcing(net8.0): 91 % XML-doc coverage (157/172).
  • XML-doc coverage: Orleans.Journaling(net8.0) src/Orleans.Journaling/Orleans.Journaling.csproj — Orleans.Journaling(net8.0): 49 % XML-doc coverage (238/490).
  • XML-doc coverage: Orleans.Persistence.Memory(net8.0) src/Orleans.Persistence.Memory/Orleans.Persistence.Memory.csproj — Orleans.Persistence.Memory(net8.0): 83 % XML-doc coverage (40/48).
  • XML-doc coverage: Orleans.Reminders(net8.0) src/Orleans.Reminders/Orleans.Reminders.csproj — Orleans.Reminders(net8.0): 57 % XML-doc coverage (102/179).
  • XML-doc coverage: Orleans.Runtime(net8.0) src/Orleans.Runtime/Orleans.Runtime.csproj — Orleans.Runtime(net8.0): 35 % XML-doc coverage (703/1982).
  • XML-doc coverage: Orleans.Serialization.Abstractions(net8.0) src/Orleans.Serialization.Abstractions/Orleans.Serialization.Abstractions.csproj — Orleans.Serialization.Abstractions(net8.0): 100 % XML-doc coverage (82/82).
  • XML-doc coverage: Orleans.Serialization.FSharp(net8.0) src/Orleans.Serialization.FSharp/Orleans.Serialization.FSharp.csproj — Orleans.Serialization.FSharp(net8.0): 100 % XML-doc coverage (82/82).
  • + 139 more in this group — see findings.md.
D10 · Test Quality · Skipped (documented) · ×20
  • Skipped (documented): Generic_PartiallySpecifyingGenericGrainFulfilsInterface test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:944 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_GenericGrainCanReuseOwnGenArgRepeatedly test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:958 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_RepeatedRearrangedGenArgsResolved test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1003 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_RearrangedGenArgsOfCorrectArityAreResolved test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1061 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_GenArgsCanBeFurtherSpecialized test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1159 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_GenArgsCanBeFurtherSpecializedIntoArrays test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1173 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_CanCastBetweenInterfacesWithFurtherSpecializedGenArgs test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1187 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): Generic_CanCastBetweenInterfacesWithFurtherSpecializedGenArgs_Activating test/Orleans.DefaultCluster.Tests/GenericGrainTests.cs:1202 — Skipped with a documented reason — a deferral, not lazy debt: Currently unsupported
  • Skipped (documented): GrainReference_Interning_Sys_StoreGrain test/Orleans.DefaultCluster.Tests/GrainReferenceTest.cs:181 — Skipped with a documented reason — a deferral, not lazy debt: GrainReference interning is not currently implemented.
  • Skipped (documented): RequestContextCalleeToCallerFlow test/Orleans.DefaultCluster.Tests/RequestContextTest.cs:52 — Skipped with a documented reason — a deferral, not lazy debt: Was failing before (just masked as a Pass), needs fixing or removing
  • Skipped (documented): GettingGrainWithMultipleConstructorsActivesViaDefaultConstructor test/Orleans.DefaultCluster.Tests/SimpleGrainTests.cs:91 — Skipped with a documented reason — a deferral, not lazy debt: Grains with multiple constructors are not supported without being explicitly registered.
  • Skipped (documented): StatelessWorkerFastActivationsDontFailInMultiSiloDeployment test/Orleans.DefaultCluster.Tests/StatelessWorkerTests.cs:154 — Skipped with a documented reason — a deferral, not lazy debt: Skipping test for now, since there seems to be a bug
  • Skipped (documented): ActivationCollectorShouldNotCollectBusyStatelessWorkers test/Orleans.Runtime.Internal.Tests/ActivationsLifeCycleTests/ActivationCollectorTests.cs:414 — Skipped with a documented reason — a deferral, not lazy debt: Flaky test. Needs to be investigated.
  • Skipped (documented): ReconstructClientIdPartitionTest_Observer test/Orleans.Runtime.Internal.Tests/MembershipTests/ClientIdPartitionDataRebuildTests.cs:47 — Skipped with a documented reason — a deferral, not lazy debt: Not reliable in PR build, skipping for now
  • Skipped (documented): ReconstructClientIdPartitionTest_Request test/Orleans.Runtime.Internal.Tests/MembershipTests/ClientIdPartitionDataRebuildTests.cs:73 — Skipped with a documented reason — a deferral, not lazy debt: Not reliable in PR build, skipping for now
  • Skipped (documented): ExceptionPropagationForwardsEntireAggregateException test/Orleans.Runtime.Tests/ExceptionPropagationTests.cs:242 — Skipped with a documented reason — a deferral, not lazy debt: Implementation of issue #1378 is still pending
  • Skipped (documented): RegisterProducerFaultTest test/Orleans.Streaming.Tests/StreamingTests/PubSubRendezvousGrainTests.cs:711 — Skipped with a documented reason — a deferral, not lazy debt: This test fails because the producer must be grain reference which is not implied by the IStreamProducerExtension
  • Skipped (documented): UnregisterProducerFaultTest test/Orleans.Streaming.Tests/StreamingTests/PubSubRendezvousGrainTests.cs:742 — Skipped with a documented reason — a deferral, not lazy debt: This test fails because the producer must be grain reference which is not implied by the IStreamProducerExtension
  • Skipped (documented): AQStreamConsumerOnDroppedClientTest test/Extensions/Orleans.Azure.Tests/Streaming/AQClientStreamTests.cs:111 — Skipped with a documented reason — a deferral, not lazy debt: AzureQueue has unpredictable event delivery counts - re-enable when we figure out how to handle this.
  • Skipped (documented): EH100StreamsTo4PartitionStreamsTest test/Extensions/Orleans.Streaming.EventHubs.Tests/Streaming/EHStreamPerPartitionTests.cs:83 — Skipped with a documented reason — a deferral, not lazy debt: Not sure what this test is testing, also the hacky test approach would make this test fail if there's any messages in the hubleft from previous tests
D10 · Test Quality · Mock framework · ×7
  • Mock framework: NSubstitute — Orleans.Core.Tests(net8.0) references NSubstitute.
  • Mock framework: NSubstitute — Orleans.Journaling.Tests(net8.0) references NSubstitute.
  • Mock framework: NSubstitute — Orleans.Runtime.Internal.Tests(net8.0) references NSubstitute.
  • Mock framework: NSubstitute — Orleans.Streaming.Tests(net8.0) references NSubstitute.
  • Mock framework: NSubstitute — Orleans.AdoNet.Tests(net8.0) references NSubstitute.
  • Mock framework: NSubstitute — Orleans.Streaming.Kinesis.Tests(net8.0) references NSubstitute.
  • Mock framework: Moq — Sample.OrleansTesting references Moq.
D5 · Coupling · Off the main sequence · ×3
  • Off the main sequence: Orleans.Dashboard.Abstractions(net8.0) src/Dashboard/Orleans.Dashboard.Abstractions/Orleans.Dashboard.Abstractions.csproj:1 — Orleans.Dashboard.Abstractions(net8.0): abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
  • Off the main sequence: Orleans.Analyzers.Contracts src/Orleans.Analyzers.Contracts/Orleans.Analyzers.Contracts.csproj:1 — Orleans.Analyzers.Contracts: abstractness 0.04, instability 0.00, distance 0.96 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
  • Off the main sequence: Orleans.Serialization.Abstractions(net8.0) src/Orleans.Serialization.Abstractions/Orleans.Serialization.Abstractions.csproj:1 — Orleans.Serialization.Abstractions(net8.0): abstractness 0.06, instability 0.00, distance 0.94 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-e9c95346e3dc467b83bc2939013b05ed/history.json --exit-code 0 --source .5artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-e9c95346e3dc467b83bc2939013b05ed/tree.json --exit-code 0 --source .1artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .22artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesdotnet—dotnet list Orleans.slnx package --vulnerable --include-transitive --format json0artifacts/raw/dotnet-vulnerable.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update8artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .0artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 360 file(s) — `docs/site/scripts/audit-links.mjs`, `docs/site/scripts/audit-output.mjs`, `docs/site/scripts/generate-legacy-redirects.mjs`, `docs/site/scripts/lib/docfx.mjs`, `docs/site/src/content/docs/deployment/snippets/service-fabric/ServiceFabricSilo/OrleansCommunicationListener.cs`, … (+355 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update0artifacts/raw/trivy-fs.json

Run 01a168c0-e008-741a-b50d-92e8c4f40374 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Appendix C — Personal-data map

Every field, property and record parameter whose name is conventional personal data — 2 field(s) across 2 categories, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.

Date of birth — 1 field(s)
  • ProfileState.DateOfBirth docs/site/src/content/docs/grains/grain-persistence/snippets/persistence/StateTypes.cs:12
Name — 1 field(s)
  • CanonicalType.FullName docs/tools/PackageJsonGenerator/Helpers/CanonicalModels.cs:10

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md