facebook/fresco

Executive summary

facebook/fresco scores 50 out of 100 and is rated Adequate, while three of its six lenses score higher still: Architecture at 96, rated Exemplary, Code Health at 85, rated Strong, and Performance at 69, rated Adequate.

The score is lower than those three because the weakest lens counts most, and here that is Maturity, which scores 45 and is rated Weak. Its Architecture documentation dimension scores 0 out of 10, and until that reaches 4, Maturity can't be rated higher than Adequate. The first actions are to record your significant design decisions and to resolve the 22 High secret finding(s) in Secrets (history). The weakest lenses score close to each other, so improving any of them moves the score.

40 findings are critical: 23 in Secrets (history), 11 in Static Analysis (SAST), four in Change Coupling and two in Knowledge Freshness.

Watchdog couldn't measure 11 dimensions in this code, among them Code Coverage, Test Reliability and Navigability, so they are left out of the score. The product code is 97,605 lines, which would take an estimated 0.9 person-years, around €130,000, to rebuild.

Code Health 85 Strong Architecture 96 ★ Exemplary Maturity 45 Weak, capped by Architecture documentation Production Readiness 47 Weak, capped by Security & performance tooling Security and Compliance 46 Weak, capped by Secrets (history) and Supply-chain Provenance & Signing Performance 69 Adequate

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.

Maturity 45 · counts for 46%Security and Compliance 46 · counts for 25%Production Readiness 47 · counts for 14%Performance 69 · counts for 8%Code Health 85 · counts for 4%Architecture 96 · counts for 2%

The weakest lenses score close to each other, so improving any of them moves the score.

Code composition: what the lines of code are

Product code 69%Tests 31%

New since the last survey: 32 findings

These 32 critical or serious findings weren't in the previous survey, on 10 October 2026.

Cyclomatic Complexity · ProgressiveDecoder.doDecode (cyclomatic 19) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
Cognitive Complexity · ProgressiveDecoder.doDecode (cognitive 23) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
God Classes · MethodTooLong: ProgressiveDecoder.doDecode imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
God Classes · TooManyMethods: BaseProducerContext imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BaseProducerContext.java
God Classes · FileTooLong: fresco/FrescoFlipperPlugin.java tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java
Code Duplication · Duplicated block (11 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java
Churn × Complexity Hotspots · Hotspot: imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Secrets (history) · REDACTED
Supply-chain Provenance & Signing · REDACTED
Supply-chain Provenance & Signing · REDACTED
Supply-chain Provenance & Signing · REDACTED

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 6 findings

These 6 critical or serious findings were in the previous survey, on 10 October 2026, and are gone from this one.

Cognitive Complexity · SampleDownloader.downloadImageAsync (cognitive 17) ig-image-loader-sample/src/main/java/com/facebook/fresco/ig/imageloader/sample/SampleDownloader.kt
Cognitive Complexity · ProgressiveDecoder.doDecodeWithSession (cognitive 16) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
God Classes · FileTooLong: producers/DecodeProducer.kt imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt
Code Duplication · Duplicated block (11 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java
Knowledge Freshness · Orphaned knowledge tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java
Supply-chain Provenance & Signing REDACTED

Rebuild cost: about €130,000 · Estimate

Cost to rebuild	€44,000 to €220,000, for 733 to 2,326 hours of work, about 0.9 person-years for 1 to 2 engineers
Difficulty of the problem	Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor	×0.7 at a score of 50. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size	Medium: 97,605 lines of product code

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

Record your significant design decisions.

Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Raises the score by about 4 points · Medium effort · Architecture documentation

Resolve the 22 High secret finding(s) in Secrets (history) — start with REDACTED (22).

Raises the score by about 3 points · Medium effort · Secrets (history)

Resolve the 2 Orphaned knowledge finding(s) in Knowledge Freshness — start with GenericDraweeHierarchy.java, GenericDraweeHierarchyBuilder.java.

Raises the score by about 1 point · Low effort · Knowledge Freshness

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk

This code would cost about €130,000 to build again, about 0.9 person-years of work. Its weakest lens is Maturity, at 45 (Weak). Maturity is about how well the project explains and looks after itself, which decides whether a new developer, or a new supplier, can take over. Because the weakest lens counts most in the score, work on Maturity also moves the score most.

Based on: the rebuild estimate · the Maturity grade · how much each lens counts

What to do: Start with the Maturity actions in Top priorities.

If you do one thing first · First action

Record your significant design decisions. Of all the actions in this report, it raises the score most for the work it takes: about 4 points for medium effort. The next survey will show the change in the score.

Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

320 modules, with 549 dependencies between them. 9 loops run through 46 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 280 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →	1 cache.common	2 common.internal	3 common.references	4 drawee.components	5 fresco.ui.common.ControllerListener2	6 imageformat	7 imagepipeline.transformation	8 cache.disk	9 common.memory	10 fresco.ui.common	11 imagepipeline.animated.base	12 imagepipeline.listener	13 drawee.controller	14 drawee.drawable	15 fresco.vito.listener	16 imagepipeline.image	17 imagepipeline.memory	18 fresco.vito.source	19 imagepipeline.bitmaps	20 imagepipeline.producers	21 fresco.urimod	22 imagepipeline.core.ImagePipelineExperiments	23 imagepipeline.core.ImagePipelineConfig	24 imagepipeline.core	25 imagepipeline.request	26 drawee.view	28 imagepipeline.decoder	29 imagepipeline.common	30 fresco.vito.options	31 imagepipeline.cache	34 fresco.vito.core	35 fresco.animation.bitmap	36 fresco.vito.core.impl.debug	39 fresco.vito.core.impl
1 cache.common
2 common.internal
3 common.references
4 drawee.components
5 fresco.ui.common.ControllerListener2
6 imageformat
7 imagepipeline.transformation
8 cache.disk	9	3
9 common.memory			2
10 fresco.ui.common					5
11 imagepipeline.animated.base			3				2
12 imagepipeline.listener																				5					1
13 drawee.controller		2		3	1					5
14 drawee.drawable										1
15 fresco.vito.listener										3
16 imagepipeline.image		1	9			2			1		2																	1
17 imagepipeline.memory			6						12
18 fresco.vito.source														1
19 imagepipeline.bitmaps			2						1								5
20 imagepipeline.producers	13	6	12			2			20			1				38								18	16		1	14		28
21 fresco.urimod														1				2
22 imagepipeline.core.ImagePipelineExperiments									2											1			2	11			2			4
23 imagepipeline.core.ImagePipelineConfig							1		1								1					1		7			2			5
24 imagepipeline.core	1	2	5			1	2	4	7							1	3		1	19		2	1				6	1		21
25 imagepipeline.request	2	2	2									2							2					2				10
26 drawee.view		1		1									1	2											1
27 flipper.plugins.fresco	3	2	1					1	1	4		1				1			1						1
28 imagepipeline.decoder		1				2	1		1							10									4			2
29 imagepipeline.common		1					2																				2
30 fresco.vito.options							1																	1				3
31 imagepipeline.cache	9	6	4					1	7							2									1			3
32 drawee.backends.pipeline	3	9	2	2						7		2	6	1		6								6	3					2
33 drawee.span													1			1		1								1			1
34 fresco.vito.core					2					10				1	3			3			3								7
35 fresco.animation.bitmap																													2		2
36 fresco.vito.core.impl.debug					9																										5			4
37 fresco.vito.litho										2				1	2			2			1								2		2
38 fresco.animation.factory																								1					2		2	2
39 fresco.vito.core.impl				1	6					7				9	5			2			3			3					23		51		7
40 fresco.vito.tools.liveeditor																		2											5		9		2	1

Uses a module listed above itPart of a loopThe module itself

At a glance — Code Health · 85% · Strong ·

The Good

D1 · Kotlin Cyclomatic Complexity 7.7 D3 · Kotlin God Classes 8.2 D4 · Kotlin Code Duplication 9.7 D17 · Kotlin Explicit Debt 9.9 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X18 · Repo Disposal-pattern correctness 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 7.4 X30 · Repo Support guard that admits what it rejects 10.0 X5 · Repo Nullable reference types 9.1

The Bad

D2 · Kotlin Cognitive Complexity 6.6

At a glance — Architecture · 96% · Exemplary ·

The Good

D5 · Kotlin Coupling 7.8 D6 · Kotlin Cohesion (LCOM4) 9.7 D26 · Kotlin Project Cohesion 8.8 D35 · Kotlin Change Coupling 9.9 AX10 · Repo Code composition 9.9 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX6 · Repo Interface segregation 9.9

The Bad

D22 · Kotlin Internal API Consistency 6.0

At a glance — Maturity · 45% · Weak · gated by M2 ·

The Good

D15 · Kotlin Churn × Complexity Hotspots 9.8 D16 · Kotlin Bus Factor 9.3 D19 · Kotlin Documentation Quality 9.7 D21 · Kotlin Naming Consistency 10.0 M3 · Repo Folder & project structure 10.0

The Bad

D34 · Kotlin Knowledge Freshness 6.2 M1 · Repo Documentation (README) 6.1

The Ugly

M2 · Repo Architecture documentation 0.0 M4 · Repo Documentation accuracy 4.8

At a glance — Readiness · 47% · Weak · gated by P3 ·

The Good

D9 · Kotlin Test Distribution 10.0 D12 · Kotlin Dependency Hygiene 9.8 D13 · Kotlin REDACTED Scanning 10.0 D14 · Kotlin License Compliance 10.0 P1 · Repo CI/CD gates 10.0

The Bad

P10 · Repo Library API & versioning 6.0 P2 · Repo Observability 5.5 P4 · Repo Deployment & Rollback 5.0 P6 · Repo Release Hygiene 5.0

The Ugly

P3 · Repo Security & performance tooling 0.0

At a glance — Security · 46% · Weak · gated by D28, D36 ·

The Good

D44 · Kotlin Platform End-of-Life 10.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0

The Bad

D29 · Kotlin Static Analysis (SAST) 6.0

The Ugly

D28 · Kotlin Secrets (history) 0.0 D36 · Kotlin Supply-chain Provenance & Signing 2.5

At a glance — Performance · 69% · Adequate ·

The Bad

PF2 · Repo Allocation hygiene 6.9

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP category	Findings	Severity
A07:2025 — Authentication Failures	24	High / Critical
A05:2025 — Injection	14	High / Critical
A03:2025 — Software Supply Chain Failures	7	Medium

Roadmap

Begin by documenting significant design decisions in a centralized ADR folder and resolving the 22 high-severity secrets found in the repository history. Next, integrate a SAST step into the CI pipeline to automatically block security regressions, and address the 122 orphaned files to improve codebase freshness. Finally, optimize allocation hygiene on hot paths by adopting idioms that reduce unnecessary object creation.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do this	Helps	Effort	Dimension
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.	+3.9 pts	Medium	Architecture documentation
Resolve the 22 High secret finding(s) in Secrets (history) — start with REDACTED (22).	+3.2 pts	Medium	Secrets (history)
Resolve the 2 Orphaned knowledge finding(s) in Knowledge Freshness — start with GenericDraweeHierarchy.java, GenericDraweeHierarchyBuilder.java.	+1.3 pts	Low	Knowledge Freshness
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.	+2.5 pts	Medium	Security & performance tooling
Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED.	+1.1 pts	Low	Supply-chain Provenance & Signing
Raise allocation-aware density on the hot paths — currently 158 use(s) across 91,143 production line(s) (~1.7/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.	+1.8 pts	Medium	Allocation hygiene
Reconcile the README with reality: docs/_docs/animations.md links to `index.html`, but `docs/_docs/index.html` does not exist; docs/_docs/animations.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist; docs/_docs/building-from-source.md links to `index.html#_`, but `docs/_docs/index.html` does not exist; docs/_docs/caching.md links to `modifying-image.html`, but `docs/_docs/modifying-image.html` does not exist; docs/_docs/caching.md links to `customizing-image-formats.html`, but `docs/_docs/customizing-image-formats.html` does not exist.	+1.8 pts	Medium	Documentation accuracy
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED.	+0.7 pts	Low	Secrets (history)

File quality

Per-file score 0–10 — a quality signature. Of 115 files carrying findings, judged against the Production bar: 3% slop · 36% mixed · 61% near-clean.

File	Score	Band	Worst signal
REDACTED	2.5	Slop	Static Analysis (SAST): High: REDACTED
REDACTED	2.7	Slop	Static Analysis (SAST): High: REDACTED
REDACTED	3.7	Slop	Static Analysis (SAST): High: REDACTED
REDACTED	4.4	Mixed	Secrets (history): High secret: REDACTED
REDACTED	4.4	Mixed	Secrets (history): High secret: REDACTED
REDACTED	4.5	Mixed	Secrets (history): High secret: REDACTED
vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt	5.6	Mixed	Cyclomatic Complexity: FrescoController2Impl.fetch (cyclomatic 26)
vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt	6.0	Mixed	Explicit Debt: TodoComment
vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt	6.0	Mixed	Explicit Debt: FixmeComment
tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java	6.0	Mixed	Explicit Debt: TodoComment
imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt	6.0	Mixed	Explicit Debt: TodoComment
vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt	6.3	Mixed	Cognitive Complexity: DebugDataProviderKt.createWastedMemoryProvider (cognitive 18)
samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/pjpeg/ImageFormatProgressiveJpegFragment.java	6.7	Mixed	Explicit Debt: TodoComment
vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageLayerDataModel.kt	6.9	Mixed	Explicit Debt: TodoComment
REDACTED	6.9	Mixed	Static Analysis (SAST): Medium: REDACTED
urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt	7.0	Mixed	Change Coupling: Boundary-crossing change coupling: NopUriModifier.kt ↔ VitoImagePipelineImpl.kt
imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java	7.1	Mixed	Cognitive Complexity: 1.getResult (cognitive 27)
samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java	7.1	Mixed	Code Duplication: Duplicated block (24 lines × 2)
samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java	7.1	Mixed	Code Duplication: Duplicated block (18 lines × 2)
imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt	7.2	Mixed	Cyclomatic Complexity: DefaultRawBitmapDecoder.decode (cyclomatic 33)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 40

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 221

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 196

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 12

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 56 of 60 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 60 dimensions across the health lenses

D1D2D3D4D5D6D9D12D13D14D15D16D17D19D21D22D26D28D29D34D35D36D44AX10AX3AX4AX6M1M2M3M4P1P10P2P3P4P6PF2X1X12X13X14X15X16X17X18X19X20X21X22X23X24X25X26X27X28X29X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions

Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 420 of 457 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

Method	Backs	Version	Evaluator
Roslyn static analysis	Complexity, cohesion, coupling, dead code, API surface, layering	5.3.0	✓ deterministic
Native secret scanner	Hardcoded secrets / credentials	1.0.0	✓ deterministic
Watchdog duplication detector (in-process)	Code duplication	1.0.0	✓ deterministic
Coverage (coverlet / dotnet-coverage)	Line & branch coverage	10.0.400	✓ deterministic
NuGet / dotnet	Outdated, vulnerable & deprecated dependencies	10.0.400	✓ deterministic
git / LibGit2Sharp	Churn hotspots, knowledge concentration, history	2.43.0 · 0.31.0	✓ deterministic
gitleaks · semgrep · trivy	Secrets in history, SAST, CVEs, IaC & container, PII / GDPR	1.86.0 · 0.69.3	✓ deterministic
LLM (sampled · advisory)	Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement	Local LLM	◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a16f51-0556-732e-8978-22057ddff75d.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java, .kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java, .kt) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Gradle build (build.gradle/build.gradle.kts), but the licence verdict published here was taken over its gem dependencies. Nothing was read about its Gradle dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `animated-base/src/main/java/com/facebook/imagepipeline/animated/factory/AnimatedImageDecoderBase.kt`, `animated-drawable/src/main/java/com/facebook/fresco/animation/drawable/AnimatedDrawable2.kt`, `animated-gif-lite/src/main/java/com/facebook/animated/giflite/drawable/GifAnimationBackend.kt`, `drawee/src/main/java/com/facebook/drawee/components/DeferredReleaser.kt`, `drawee/src/main/java/com/facebook/drawee/drawable/ArrayDrawable.kt`, … (+29 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (animated-base/src/main/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Java, Kotlin, Python, c, cpp is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Kotlin, Python, c, cpp is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 14 further occurrence(s) are not listed individually; the score already reflects all 54.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
S1 Web-Security Posture — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
X2 Cancellation propagation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (4): D19, D21, D22, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity7.7 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.7 / 10 · rule-coverage 100% · ceiling Prevented

13 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was GenericDraweeHierarchyInflater.updateBuilder at 48. A further 1 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ImageOriginUtils.mapProducerNameToImageOrigin at 18 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: drawee-backends/drawee-pipeline/src/main/java/com/facebook/drawee/backends/pipeline/info/ImageOriginUtils.java (ImageOriginUtils.mapProducerNameToImageOrigin at 18). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

GenericDraweeHierarchyInflater.updateBuilder (cyclomatic 48)drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:102

VitoViewInflater.inflateImageOptionsBuilder (cyclomatic 37)vito/drawee-support/src/main/java/com/facebook/fresco/vito/draweesupport/VitoViewInflater.kt:26

DefaultRawBitmapDecoder.decode (cyclomatic 33)imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:202

KFrescoController.fetch (cyclomatic 27)vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132

FrescoController2Impl.fetch (cyclomatic 26)vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83

+ 8 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Bring the 13 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with GenericDraweeHierarchyInflater.updateBuilder (cyclomatic 48), VitoViewInflater.inflateImageOptionsBuilder (cyclomatic 37), DefaultRawBitmapDecoder.decode (cyclomatic 33). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 13 together lifts Cyclomatic Complexity from 7.7 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D2 · Cognitive Complexity6.6 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.6 / 10 · rule-coverage 100% · ceiling Prevented

33 method(s) exceeded the cognitive complexity threshold of 15; the worst was GenericDraweeHierarchyInflater.updateBuilder at 56.

GenericDraweeHierarchyInflater.updateBuilder (cognitive 56)drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:102

VitoViewInflater.inflateImageOptionsBuilder (cognitive 51)vito/drawee-support/src/main/java/com/facebook/fresco/vito/draweesupport/VitoViewInflater.kt:26

DefaultRawBitmapDecoder.decode (cognitive 45)imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:202

BitmapPreparingImageFetchSubscriber.onNewResult (cognitive 39)vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:40

FrescoController2Impl.fetch (cognitive 35)vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83

+ 28 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Bring the 33 bodies over 15 down to 15 or less in Cognitive Complexity — start with GenericDraweeHierarchyInflater.updateBuilder (cognitive 56), VitoViewInflater.inflateImageOptionsBuilder (cognitive 51), DefaultRawBitmapDecoder.decode (cognitive 45). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 33 together lifts Cognitive Complexity from 6.6 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D3 · God Classes8.2 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Prevented

46 god class(es) detected.

TooManyMethods: FLog · ×26fbcore/src/main/java/com/facebook/common/logging/FLog.kt:13

ClassTooLong: ImagePipeline · ×9imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipeline.kt:54

MethodTooLong: FrescoFlipperPlugin.onConnect · ×7tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java:144

FileTooLong: core/ImagePipeline.kt · ×4imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipeline.kt

What to do

Resolve the 26 TooManyMethods finding(s) in God Classes — start with FLog.kt, ImagePipeline.kt, AbstractDraweeController.java. — One of this dimension's main actionable groups (26 warning-level).
Resolve the 9 ClassTooLong finding(s) in God Classes — start with ImagePipeline.kt, AbstractDraweeController.java, DiskStorageCache.kt. — One of this dimension's main actionable groups (9 warning-level).
Resolve the 7 MethodTooLong finding(s) in God Classes — start with FrescoFlipperPlugin.java, FrescoController2Impl.kt, KFrescoController.kt. — One of this dimension's main actionable groups (7 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D4 · Code Duplication9.7 / 10Stronggated by 58 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

58 duplicated block group(s) detected. 23 of the 58 are in trees this repository does not ship — vendored, example/demo, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Duplicated block (7 lines × 2) · ×8fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:50

Duplicated block (5 lines × 2) · ×5fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:63

Duplicated block (15 lines × 2) · ×3imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:81

Duplicated block (11 lines × 2) · ×3vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:126

Duplicated block (10 lines × 2) · ×3vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:275

+ 26 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 8 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with CustomScaleTypes.java (2), HashCodeUtil.kt, AshmemMemoryChunk.kt. — One of this dimension's main actionable groups (8 warning-level).
Resolve the 5 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with ImmutableMap.java, VolleyNetworkFetcher.java, ScalingUtils.java. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 3 Duplicated block (15 lines × 2) finding(s) in Code Duplication — start with BufferedDiskCache.kt, BitmapProbeProducer.java, DefaultCloseableImage.java. — One of this dimension's main actionable groups (3 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D5 · Coupling7.8 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 7.8 / 10 · rule-coverage 100% · ceiling Prevented

53 production modules (Gradle+Maven), 0 dependency cycle(s), 5 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 9 module(s) off the main sequence, with abstractness counted on 50 of the 53 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: :ui-core · ×8

Unstable project :animated-drawable · ×5

Off the main sequence: :ui-common

What to do

Resolve the 8 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (8 warning-level).
Resolve the 5 Unstable project finding(s) in Coupling. — One of this dimension's main actionable groups (5 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D6 · Cohesion (LCOM4)9.7 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

4 of 149 classes have LCOM4 above 3.

Low cohesion: Builder (LCOM4 12) · ×4imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolConfig.kt:61

What to do

Resolve the 4 Low cohesion finding(s) in Cohesion (LCOM4) — start with PoolConfig.kt, FrescoDrawable2.kt, HierarcherImpl.kt. — One of this dimension's main actionable groups (4 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

617 test methods: 617 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

Do you agree with this assessment?

D12 · Dependency Hygiene9.8 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Verified

0 outdated direct gem(s), 1 pinning defect(s). 1 declaration(s) graded against rubygems.org, none of them against a committed Gemfile.lock — this repository commits none, which a published gem correctly does not, so currency is read off the declared requirements: a declaration that does not cap below the current release resolves to it on `bundle install`. 1 declaration(s) carry a requirement that EXCLUDES the current release; that is a deliberate constraint (a supported-version ceiling or a held-back CI pin) and is counted, not charged. Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.

No Gemfile.lock committed by an application

What to do

Resolve the 1 No Gemfile.lock committed by an application finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (1 warning-level).
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

Do you agree with this assessment?

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 1 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 1 runtime gem(s) this repository declares. It commits no Gemfile.lock to close that set over, so the verdict covers the declarations rather than the whole resolved graph. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. ★ COVERAGE OF THIS VERDICT: it grades this repository's gem dependencies and nothing else. The repository also declares a Gradle build (build.gradle/build.gradle.kts), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

Do you agree with this assessment?

D15 · Churn × Complexity Hotspots9.8 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt (10×27=270); imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt (8×19=152); vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt (5×26=130)

Hotspot: vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt · ×4vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132

What to do

Resolve the 4 Hotspot finding(s) in Churn × Complexity Hotspots — start with KFrescoController.kt, DecodeProducer.kt, FrescoController2Impl.kt. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D16 · Bus Factor9.3 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

24 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is fbcore/src/main/java/com/facebook/common/logging/FLog.kt. Counted over 321 of the 860 production source files in this repository: 530 are under the ~2,400-byte size floor this dimension measures over, and the remaining 9 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2

Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D17 · Explicit Debt9.9 / 10Stronggated by 30 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Prevented

30 deducted task-comment markers across 97605 LoC (0.0/KLoC) → score 9.9. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×27animated-base/src/main/java/com/facebook/fresco/animation/bitmap/cache/FrescoFrameCache.kt:134

FixmeComment · ×3vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ExtrasUtils.kt:31

What to do

Resolve the 27 TodoComment finding(s) in Explicit Debt — start with BufferedDiskCache.kt (8), KFrescoController.kt (3), ImageLayerDataModel.kt (3). — One of this dimension's main actionable groups (27 warning-level).
Resolve the 3 FixmeComment finding(s) in Explicit Debt — start with VitoImagePipelineImpl.kt (2), ExtrasUtils.kt. — One of this dimension's main actionable groups (3 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D19 · Documentation QualityExemplary◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

This repository's documentation is comprehensive and well-structured: the READMEs for each Fresco module (from concepts to gotchas) cover what a given class does with code examples, plus architecture/Docs markdown files that are extremely detailed. The documents are all present and complete within their outlines; there is no missing section in any of them. This repository's documentation is strong for its subject matter: a focused listening-to-events guide that explains the two instrumentation interfaces (RequestListener and BaseControllerListener) with code examples and adds an onFinalImageSet usage note. The accompanying architecture/Docs directory is huge (892 markdown files), so much of the project's broader design, build, and contribution guidance resides there rather than the READMEs. (14 of 25 sampled documents could not be assessed: 1 of 3 evaluation groups failed.)

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

Do you agree with this assessment?

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

Do you agree with this assessment?

D22 · Internal API ConsistencyAdequate◐ Sampled · advisory

What it measures: Whether the internal API surface is consistent and coherent.

Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.

Maturity: Documented → Verified → Prevented · effective Adequate / 10 · rule-coverage 100% · ceiling Verified

5 API inconsistencies across a 400-member sample of 1034 exposed types.

Redundant overloads for Uri vs ImageSource: The API exposes separate overloads for `Uri` and `ImageSource` that perform the same logical operation (loading an image). Since `ImageSource` is the internal abstraction and `Uri` is a common input, forcing users to choose between `show(uri, ...)` and `show(ImageSource.fromUri(...), ...)` creates confusion. The `Uri` overloads are essentially wrappers around `ImageSource` creation.

Dual entry points for image loading: `VitoView` exposes both `show(ImageSource)` and `show(VitoImageRequest)`. While `VitoImageRequest` is a higher-level abstraction, exposing both on the same view class creates ambiguity about which should be used for standard use cases. It suggests a split in the API design between 'simple' and 'advanced' loading without clear separation of concerns.

Implementation class exposes same dual entry point inconsistency: `VitoViewImpl2` (likely an internal implementation detail exposed in the public surface) repeats the `ImageSource` vs `VitoImageRequest` overload pattern found in `VitoView`, compounding the confusion.

Inconsistent naming and parameter structure for fetching: `ImageLiveEditor` has two `fetch` methods with different signatures. One takes explicit `ImageSource` and `ImageOptions`, the other takes a pre-built `VitoImageRequest`. This mirrors the `VitoView` inconsistency but is even more confusing because `fetch` implies a lower-level operation than `show`, yet it accepts the high-level `VitoImageRequest`.

Same dual entry point inconsistency in `VitoSpanLoader`: The text span loader also exposes both `ImageSource` and `VitoImageRequest` variants for `show`, creating a parallel inconsistency across different view components (`VitoView`, `VitoSpanLoader`).

What to do

Resolve the 1 Redundant overloads for Uri vs ImageSource finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Dual entry points for image loading finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Implementation class exposes same dual entry point inconsistency finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d22_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D26 · Project Cohesion8.8 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Documented

3 of 50 build units (Bundler, Gradle, Maven) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

23 finding(s): 0 critical, 23 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED

What to do

Resolve the 22 High secret finding(s) in Secrets (history) — start with REDACTED (22). — One of this dimension's main actionable groups (22 issue-level).
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D29 · Static Analysis (SAST)6.0 / 10Adequate✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Documented

14 finding(s): 0 critical, 11 high, 3 medium, 0 low. 9 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 29 file(s) — `docs/_includes/blog_pagination.html` (line 2, line 28), `docs/_includes/powered_by.html` (line 1, line 22), `docs/javadoc/reference/classes.html` (line 1260, line 3345, lines 4419–4420), `docs/javadoc/reference/com/facebook/common/internal/Objects.ToStringHelper.html` (line 497), `docs/javadoc/reference/com/facebook/common/internal/Objects.html` (line 547), … (+24 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED

What to do

Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
No action in Static Analysis (SAST) — all 9 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (9 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D34 · Knowledge Freshness6.2 / 10Adequate✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Documented

124 of 330 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchy.java. Counted over 330 of the 860 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledge · ×2drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchy.java:1

Orphaned file · ×122imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:1

Further orphaned files (smaller)

What to do

Resolve the 122 Orphaned file finding(s) in Knowledge Freshness — start with PartialDiskCacheProducer.java, AnimatedDrawableBackendImpl.java, FLog.kt. — One of this dimension's main actionable groups (122 recommendation-level).
Resolve the 2 Orphaned knowledge finding(s) in Knowledge Freshness — start with GenericDraweeHierarchy.java, GenericDraweeHierarchyBuilder.java. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D35 · Change Coupling9.9 / 10Adequategated by 4 critical findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: DebugDataProvider.kt↔DebugOverlayHandler.kt 80%; NopUriModifier.kt↔VitoImagePipelineImpl.kt 77%; ResizeAndRotateProducer.java↔NativeJpegTranscoder.java 69%

Boundary-crossing change coupling: NopUriModifier.kt ↔ VitoImagePipelineImpl.kt · ×4urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt:1

Change coupling: DebugDataProvider.kt ↔ DebugOverlayHandler.kt · ×2vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:1

What to do

Resolve the 4 Boundary-crossing change coupling finding(s) in Change Coupling — start with NopUriModifier.kt (2), ResizeAndRotateProducer.java, AnimationLoaderFactory.kt. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 2 Change coupling finding(s) in Change Coupling — start with DebugDataProvider.kt, CombinedImageListenerImpl.kt. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED

What to do

Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 57 platform declaration(s) and 6 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Do you agree with this assessment?

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.

Do you agree with this assessment?

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

Do you agree with this assessment?

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

Do you agree with this assessment?

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

`LoggingDelegate` declares 16 abstract methods under just 10 distinct name(s): `d`, `d`, `e`, `e`, `getMinimumLoggingLevel`, `i`, `i`, `isLoggable`, `log`, `setMinimumLoggingLevel`, `v`, `v`, `w`, `w`, `wtf`, `wtf`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 10 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — fbcore/src/main/java/com/facebook/common/logging/LoggingDelegate.java:14
`ZoomableController` declares 16 abstract methods: `computeHorizontalScrollExtent`, `computeHorizontalScrollOffset`, `computeHorizontalScrollRange`, `computeVerticalScrollExtent`, `computeVerticalScrollOffset`, `computeVerticalScrollRange`, `getScaleFactor`, `getTransform`, `isEnabled`, `isIdentity`, `onTouchEvent`, `setEnabled`, `setImageBounds`, `setListener`, `setViewBounds`, `wasTransformCorrected`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableController.java:18
`AnimatedDrawableBackend` declares 20 abstract methods: `dropCaches`, `forNewBounds`, `getAnimatedImageResult`, `getDurationMs`, `getDurationMsForFrame`, `getFrameCount`, `getFrameForPreview`, `getFrameForTimestampMs`, `getFrameInfo`, `getHeight`, `getLoopCount`, `getMemoryUsage`, `getPreDecodedFrame`, `getRenderedHeight`, `getRenderedWidth`, `getTimestampMsForFrame`, `getWidth`, `hasPreDecodedFrame`, `renderDeltas`, `renderFrame`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — animated-base/src/main/java/com/facebook/imagepipeline/animated/base/AnimatedDrawableBackend.java:22

What to do

Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.

Do you agree with this assessment?

M1 · Documentation (README)6.1 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 58 of 60 project(s) that lack one — worth up to 1.9 pts.

Do you agree with this assessment?

M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.

Do you agree with this assessment?

M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

Do you agree with this assessment?

M4 · Documentation accuracy4.8 / 10Weak◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

docs/_docs/animations.md links to `index.html`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/animations.md:12
docs/_docs/animations.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/animations.md:16
docs/_docs/building-from-source.md links to `index.html#_`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/building-from-source.md:8
docs/_docs/caching.md links to `modifying-image.html`, but `docs/_docs/modifying-image.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/caching.md:12
docs/_docs/caching.md links to `customizing-image-formats.html`, but `docs/_docs/customizing-image-formats.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/caching.md:20
docs/_docs/caching.md links to `configure-image-pipeline.html#configuring-the-disk-cache`, but `docs/_docs/configure-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/caching.md:36
docs/_docs/caching.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/caching.md:102
docs/_docs/closeable-references.md links to `using-simpledraweeview.html`, but `docs/_docs/using-simpledraweeview.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/closeable-references.md:10
docs/_docs/concepts.md links to `index.html`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/concepts.md:16
docs/_docs/concepts.md links to `using-simpledraweeview.html`, but `docs/_docs/using-simpledraweeview.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/concepts.md:18
docs/_docs/concepts.md links to `using-controllerbuilder.html`, but `docs/_docs/using-controllerbuilder.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/concepts.md:34
docs/_docs/concepts.md links to `listening-to-events.html`, but `docs/_docs/listening-to-events.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/concepts.md:38
docs/_docs/configure-image-pipeline.md links to `using-other-network-layers.html`, but `docs/_docs/using-other-network-layers.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/configure-image-pipeline.md:65
docs/_docs/datasources-datasubscribers.md links to `closeable-references.html`, but `docs/_docs/closeable-references.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/datasources-datasubscribers.md:95
docs/_docs/datasources-datasubscribers.md links to `../javadoc/reference/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber`, but `docs/javadoc/reference/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/datasources-datasubscribers.md:149
docs/_docs/drawee-branches.md links to `scaletypes.html`, but `docs/_docs/scaletypes.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/drawee-branches.md:20
docs/_docs/drawee-branches.md links to `using-controllerbuilder.html`, but `docs/_docs/using-controllerbuilder.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/drawee-branches.md:28
docs/_docs/drawee-branches.md links to `progress-bars.html`, but `docs/_docs/progress-bars.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/drawee-branches.md:81
docs/_docs/faq.md links to `using-image-pipeline.html`, but `docs/_docs/using-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/faq.md:52
docs/_docs/faq.md links to `datasources-datasubscribers.html`, but `docs/_docs/datasources-datasubscribers.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/faq.md:52
docs/_docs/faq.md links to `post-processor.html`, but `docs/_docs/post-processor.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/faq.md:56
docs/_docs/faq.md links to `proguard.html`, but `docs/_docs/proguard.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/faq.md:60
docs/_docs/gotchas.md links to `writing-custom-views.html`, but `docs/_docs/writing-custom-views.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/gotchas.md:22
docs/_docs/image-requests.md links to `requesting-multiple-images.html`, but `docs/_docs/requesting-multiple-images.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:8
docs/_docs/image-requests.md links to `supported-uris.html`, but `docs/_docs/supported-uris.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:32
docs/_docs/image-requests.md links to `rotation.html`, but `docs/_docs/rotation.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:33
docs/_docs/image-requests.md links to `progressive-jpegs.html`, but `docs/_docs/progressive-jpegs.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:34
docs/_docs/image-requests.md links to `modifying-image.html`, but `docs/_docs/modifying-image.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:35
docs/_docs/image-requests.md links to `resizing.html`, but `docs/_docs/resizing.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:36
docs/_docs/image-requests.md links to `intro-image-pipeline.html`, but `docs/_docs/intro-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/image-requests.md:40
docs/_docs/intro-image-pipeline.md links to `caching.html`, but `docs/_docs/caching.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/intro-image-pipeline.md:22
docs/_docs/intro-image-pipeline.md links to `supported-uris.html`, but `docs/_docs/supported-uris.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/intro-image-pipeline.md:25
docs/_docs/placeholder-failure-retry.md links to `progress-bars.html`, but `docs/_docs/progress-bars.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/placeholder-failure-retry.md:8
docs/_docs/placeholder-failure-retry.md links to `scaletypes.html`, but `docs/_docs/scaletypes.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/placeholder-failure-retry.md:8
docs/_docs/post-processor.md links to `/static/images/docs/02-post-processor-blur.png`, but `static/images/docs/02-post-processor-blur.png` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/post-processor.md:114
docs/_docs/post-processor.md links to `/static/images/docs/02-post-processor-scaling-blur.png`, but `static/images/docs/02-post-processor-scaling-blur.png` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/post-processor.md:158
docs/_docs/requesting-multiple-images.md links to `using-controllerbuilder.html`, but `docs/_docs/using-controllerbuilder.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/requesting-multiple-images.md:8
docs/_docs/resizing.md links to `scaletypes.html`, but `docs/_docs/scaletypes.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/resizing.md:12
docs/_docs/resizing.md links to `configure-image-pipeline.html`, but `docs/_docs/configure-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/resizing.md:41
docs/_docs/sample-apps.md links to `building-from-source.html`, but `docs/_docs/building-from-source.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/_docs/sample-apps.md:12

What to do

Reconcile the README with reality: docs/_docs/animations.md links to `index.html`, but `docs/_docs/index.html` does not exist; docs/_docs/animations.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist; docs/_docs/building-from-source.md links to `index.html#_`, but `docs/_docs/index.html` does not exist; docs/_docs/caching.md links to `modifying-image.html`, but `docs/_docs/modifying-image.html` does not exist; docs/_docs/caching.md links to `customizing-image-formats.html`, but `docs/_docs/customizing-image-formats.html` does not exist.

Do you agree with this assessment?

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

Do you agree with this assessment?

P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

1127/1275 types (88%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

What to do

Keep implementation types off the public surface (Java: package-private (no modifier), or leave its package out of `module-info` exports; Kotlin: `internal`) so internals can change without breaking consumers.

Do you agree with this assessment?

P2 · Observability5.5 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

Only 1/2 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`.

What to do

Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.

Do you agree with this assessment?

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2907 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.

Do you agree with this assessment?

P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.

What to do

Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.

Do you agree with this assessment?

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.

Do you agree with this assessment?

PF2 · Allocation hygiene6.9 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

Raise allocation-aware density on the hot paths — currently 158 use(s) across 91,143 production line(s) (~1.7/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
Kotlin: on hot paths, use primitive arrays (IntArray, LongArray …) and @JvmInline value classes instead of boxed values, primitive collections (androidx.collection, fastutil) instead of boxed ones, and presize collections and StringBuilders.

Do you agree with this assessment?

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

Do you agree with this assessment?

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X3 · Exception handling7.4 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

`catch (exception: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:176, imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:216
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — static-webp/src/main/java/com/facebook/webpsupport/WebpBitmapFactoryImpl.kt:368
`catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:197
`catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt:265

What to do

Swallowed exception (caught, then discarded)

Do you agree with this assessment?

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X5 · Nullable reference types9.1 / 10Exemplary✓ Tool-verified

Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

Do you agree with this assessment?

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

Lens	Score	Rating	Impact
Code Health	85%	Strong	Solid.
Architecture	96%	Exemplary	Strongest area.
Maturity	45%	Weak — gated by M2	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness	47%	Weak — gated by P3	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security	46%	Weak — gated by D28, D36	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance	69%	Adequate	Acceptable, with room to improve.

Unscored — 1 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

X10 Duplicated predicate — 14 observation(s) recorded · Advisory — this card reports evidence and never carries a score.

Not evidenced — 1 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control

Not included — 57 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

AC1 Text alternatives — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC2 Forms & labels — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC3 Page structure — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC4 Keyboard semantics — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC5 ARIA correctness — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC6 Visual & motion safety — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AC7 A11y enforcement — Frontend below the scale floor (1 DOM element(s) < 25) — too little surface to assess accessibility.
AX1 Captive dependencies — Not applicable: this repository's Java imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Python imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Java code is a Spring, JSR-330 or CDI singleton bean. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no data at rest for these controls to protect.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Room, JPA or MongoDB entity, an Exposed or Ktorm table, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (Room, Exposed, SQLDelight, Realm, JPA, JDBC, MongoDB, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
D10 Test Quality — ~43341 lines of test source are present (.java, .kt) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .kt suite was found but not re-run
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — No inline comments to assess — comment value is not applicable here.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 reads resolved call sites in the languages it reads only — this repository's production source is .c, .cpp, .java, .py, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D30 Dependency Vulnerabilities — osv: the scanner produced no output at all, so no dependency was actually scanned
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 34 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — osv: the scanner produced no output at all, so no dependency was actually scanned
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 93 value object(s); 1 domain event(s); its domain events are published by services or handlers — no domain entity raises one
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, JavaScript/TypeScript, Python source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 40 finding(s)

D28 · Secrets (history) · High secret · ×22

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D35 · Change Coupling · Boundary-crossing change coupling · ×4

Boundary-crossing change coupling: NopUriModifier.kt ↔ VitoImagePipelineImpl.kt urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt:1 — `urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt` (context urimod) and `vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt` (context vito) sit in DIFFERENT parts of the tree yet change together 77% of the time (10 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `cc4d169b` Extract logic in Vito Spec; `9be22e85` Unregister URIs from Reverse MBP Fallback; `5c2cb443` Add forLoggingOnly flag to modifyUri — run `git show` on any of them.
Boundary-crossing change coupling: ResizeAndRotateProducer.java ↔ NativeJpegTranscoder.java imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducer.java:1 — `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducer.java` (context imagepipeline) and `native-imagetranscoder/src/main/java/com/facebook/imagepipeline/nativecode/NativeJpegTranscoder.java` (context native-imagetranscoder) sit in DIFFERENT parts of the tree yet change together 69% of the time (11 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `a19f4cd5` enable to transform avif -> on client; `a9d08c49` Add colorspace argument to image transcoders; `28cd1b6a` JpegTranscoderUtils conversion to Kotlin — run `git show` on any of them.
Boundary-crossing change coupling: NopUriModifier.kt ↔ VitoImagePipeline.kt urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt:1 — `urimod/src/main/java/com/facebook/fresco/urimod/NopUriModifier.kt` (context urimod) and `vito/core/src/main/java/com/facebook/fresco/vito/core/VitoImagePipeline.kt` (context vito) sit in DIFFERENT parts of the tree yet change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `cc4d169b` Extract logic in Vito Spec; `9be22e85` Unregister URIs from Reverse MBP Fallback; `5c2cb443` Add forLoggingOnly flag to modifyUri — run `git show` on any of them.
Boundary-crossing change coupling: AnimationLoaderFactory.kt ↔ AnimatedFactoryProvider.kt animated-drawable/src/main/java/com/facebook/fresco/animation/bitmap/preparation/ondemandanimation/AnimationLoaderFactory.kt:1 — `animated-drawable/src/main/java/com/facebook/fresco/animation/bitmap/preparation/ondemandanimation/AnimationLoaderFactory.kt` (context animated-drawable) and `imagepipeline-base/src/main/java/com/facebook/imagepipeline/animated/factory/AnimatedFactoryProvider.kt` (context imagepipeline-base) sit in DIFFERENT parts of the tree yet change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `762ed58d` Synchronize + release displaced FrameLoader in on-demand animation cache; `a5230d1e` Add single frame render logging via unified FrameLoaderListener; `247550a7` Fix single frame errors with images tagged as animated with gating — run `git show` on any of them.

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED

D34 · Knowledge Freshness · Orphaned knowledge · ×2

Orphaned knowledge drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchy.java:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyBuilder.java:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.

D28 · Secrets (history) · REDACTED · ×1

REDACTED

Serious — 221 finding(s)

D17 · Explicit Debt · TodoComment · ×27

TodoComment animated-base/src/main/java/com/facebook/fresco/animation/bitmap/cache/FrescoFrameCache.kt:134 — // TODO (t15557326) Not supported for now — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment animated-drawable/src/main/java/com/facebook/fresco/animation/drawable/AnimationFrameScheduler.kt:109 — // TODO Add log info here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment drawee/src/test/java/com/facebook/drawee/drawable/ScaleTypeDrawableTest.java:306 — // TODO(5469563): enable this once we have a decent implementation of ShadowMatrix — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/StagingArea.java:144 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/StagingArea.java:171 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:91 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:238 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:276 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:306 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:335 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:408 — // TODO: 3697790 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:381 — // TODO: 3697790 log failures — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:382 — // TODO: 5258772 - uncomment line below — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:317 — // TODO 19247361 Consider merging of non-final results — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:339 — // TODO 19247425 Delete cached file and request full image — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/pjpeg/ImageFormatProgressiveJpegFragment.java:49 — // TODO add new VIto API — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/ImageSourceConfigurator.kt:65 — // TODO: low res — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java:531 — // TODO (t19034797): properly load images — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java:628 — // TODO (t31947746): scan times — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:87 — // TODO(T105148151): handle rotation for closeable static bitmap, handle other — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:179 — // TODO(T105148151): move to new package so that no legacy impl dep — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:412 — // TODO(T105148151): trigger listeners — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageLayerDataModel.kt:77 — // TODO(T105148151): only invalidate if changed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageLayerDataModel.kt:144 — // TODO: Do we need to invalidate? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageLayerDataModel.kt:188 — // TODO use fadeAnimator.reverse() and reuse — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
+ 2 more in this group — see findings.md.

D3 · God Classes · TooManyMethods · ×26

TooManyMethods: FLog fbcore/src/main/java/com/facebook/common/logging/FLog.kt:13 — TooManyMethods — 76 methods. The bar is 30 methods; this is 46 over it, 2.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImagePipeline imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipeline.kt:54 — TooManyMethods — 66 methods. The bar is 30 methods; this is 36 over it, 2.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AbstractDraweeController drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeController.java:58 — TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImageRequestBuilder imagepipeline/src/main/java/com/facebook/imagepipeline/request/ImageRequestBuilder.java:35 — TooManyMethods — 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Builder imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineExperiments.kt:105 — TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DefaultFrescoVitoConfig vito/core/src/main/java/com/facebook/fresco/vito/core/DefaultFrescoVitoConfig.kt:16 — TooManyMethods — 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. Most of these members implement core.FrescoVitoConfig (54 of 55 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: GenericDraweeHierarchy drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchy.java:87 — TooManyMethods — 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GenericDraweeHierarchyBuilder drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyBuilder.java:33 — TooManyMethods — 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EncodedImage imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/EncodedImage.java:55 — TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Builder imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineConfig.kt:217 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AbstractAdaptiveCountingMemoryCache imagepipeline-base/src/main/java/com/facebook/imagepipeline/cache/AbstractAdaptiveCountingMemoryCache.java:42 — TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImageRequest imagepipeline/src/main/java/com/facebook/imagepipeline/request/ImageRequest.java:52 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AbstractDraweeControllerBuilder drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeControllerBuilder.java:34 — TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GifImage animated-gif/src/main/java/com/facebook/animated/gif/GifImage.java:31 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImagePipelineFactory imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineFactory.java:68 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Companion static-webp/src/main/java/com/facebook/webpsupport/WebpBitmapFactoryImpl.kt:61 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DraweeView drawee/src/main/java/com/facebook/drawee/view/DraweeView.java:47 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Builder vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:274 — TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LruCountingMemoryCache imagepipeline-base/src/main/java/com/facebook/imagepipeline/cache/LruCountingMemoryCache.kt:41 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ProducerFactory imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerFactory.kt:71 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: WebPImage animated-webp/src/main/java/com/facebook/animated/webp/WebPImage.java:33 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImageDecodeOptionsBuilder imagepipeline-base/src/main/java/com/facebook/imagepipeline/common/ImageDecodeOptionsBuilder.java:20 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BitmapAnimationBackend animated-drawable/src/main/java/com/facebook/fresco/animation/bitmap/BitmapAnimationBackend.kt:51 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PipelineDraweeController drawee-backends/drawee-pipeline/src/main/java/com/facebook/drawee/backends/pipeline/PipelineDraweeController.java:65 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ForwardingDrawable drawee/src/main/java/com/facebook/drawee/drawable/ForwardingDrawable.java:30 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
+ 1 more in this group — see findings.md.

D3 · God Classes · ClassTooLong · ×9

ClassTooLong: ImagePipeline imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipeline.kt:54 — ClassTooLong — 739 significant lines (blank, comment-only and punctuation-only lines excluded), 66 methods. The bar is 400 significant lines; this is 339 over it, 1.85× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AbstractDraweeController drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeController.java:58 — ClassTooLong — 529 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 400 significant lines; this is 129 over it, 1.32× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DiskStorageCache imagepipeline-base/src/main/java/com/facebook/cache/disk/DiskStorageCache.kt:36 — ClassTooLong — 462 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 62 over it, 1.16× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: AbstractAdaptiveCountingMemoryCache imagepipeline-base/src/main/java/com/facebook/imagepipeline/cache/AbstractAdaptiveCountingMemoryCache.java:42 — ClassTooLong — 457 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 400 significant lines; this is 57 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FrescoFlipperPlugin tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java:69 — ClassTooLong — 446 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 46 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: DecodeProducer imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt:50 — ClassTooLong — 444 significant lines (blank, comment-only and punctuation-only lines excluded), 2 methods. The bar is 400 significant lines; this is 44 over it, 1.11× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FrescoController2Impl vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:56 — ClassTooLong — 439 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 39 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ScalingUtils ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:19 — ClassTooLong — 427 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 27 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ProducerSequenceFactory imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt:34 — ClassTooLong — 407 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 7 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.

D4 · Code Duplication · Duplicated block (7 lines × 2) · ×8

Duplicated block (7 lines × 2) fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:50 — fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:50-56 | fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:68-74 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:50` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:75` calls `hashCode` and `fbcore/src/main/java/com/facebook/common/util/HashCodeUtil.kt:57` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) memory-types/ashmem/src/main/java/com/facebook/imagepipeline/memory/AshmemMemoryChunk.kt:104 — memory-types/ashmem/src/main/java/com/facebook/imagepipeline/memory/AshmemMemoryChunk.kt:104-110 | memory-types/simple/src/main/java/com/facebook/imagepipeline/memory/BufferMemoryChunk.kt:76-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/common/CustomScaleTypes.java:32 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/common/CustomScaleTypes.java:32-38 | ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:458-464 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/common/CustomScaleTypes.java:53 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/common/CustomScaleTypes.java:53-59 | ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:486-492 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:495` calls `getDescription` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/common/CustomScaleTypes.java:60` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/EncodedImage.java:571 — imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/EncodedImage.java:571-578 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BaseProducerContext.java:358-364 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BaseProducerContext.java:357` calls `SuppressWarnings` and `imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/EncodedImage.java:570` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) samples/animation2/src/main/java/com/facebook/samples/animation2/AnimationApplication.java:23 — samples/animation2/src/main/java/com/facebook/samples/animation2/AnimationApplication.java:23-29 | samples/zoomableapp/src/main/java/com/facebook/samples/zoomableapp/ZoomableApplication.java:24-30 — before extracting anything, compare `samples/animation2/src/main/java/com/facebook/samples/animation2/AnimationApplication.java` and `samples/zoomableapp/src/main/java/com/facebook/samples/zoomableapp/ZoomableApplication.java` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `samples/zoomableapp/src/main/java/com/facebook/samples/zoomableapp/ZoomableApplication.java:31` calls `initialize` and `samples/animation2/src/main/java/com/facebook/samples/animation2/AnimationApplication.java:30` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/holders/BaseViewHolder.java:52 — samples/comparison/src/main/java/com/facebook/samples/comparison/holders/BaseViewHolder.java:52-58 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/util/SizeUtil.java:37-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:375 — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:375-381 | samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:295-301 — before extracting anything, compare `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.

D5 · Coupling · Off the main sequence · ×8

Off the main sequence: :ui-core — :ui-core: abstractness 0.13, instability 0.00, distance 0.88 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: :memory-types:ashmem — :memory-types:ashmem: abstractness 0.00, instability 0.20, distance 0.80 — zone of pain — concrete and depended on by 8 project(s), so it's rigid to change.
Off the main sequence: :vito:renderer — :vito:renderer: abstractness 0.20, instability 0.00, distance 0.80 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: :vito:options — :vito:options: abstractness 0.06, instability 0.15, distance 0.79 — zone of pain — concrete and depended on by 17 project(s), so it's rigid to change.
Off the main sequence: :imagepipeline-native — :imagepipeline-native: abstractness 0.00, instability 0.23, distance 0.77 — zone of pain — concrete and depended on by 10 project(s), so it's rigid to change.
Off the main sequence: :memory-types:nativememory — :memory-types:nativememory: abstractness 0.00, instability 0.27, distance 0.73 — zone of pain — concrete and depended on by 8 project(s), so it's rigid to change.
Off the main sequence: :memory-types:simple — :memory-types:simple: abstractness 0.00, instability 0.27, distance 0.73 — zone of pain — concrete and depended on by 8 project(s), so it's rigid to change.
Off the main sequence: :vito:source — :vito:source: abstractness 0.18, instability 0.11, distance 0.71 — zone of pain — concrete and depended on by 16 project(s), so it's rigid to change.

D3 · God Classes · MethodTooLong · ×7

MethodTooLong: FrescoFlipperPlugin.onConnect tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java:144 — MethodTooLong — onConnect runs 186 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 86 over it, 1.86× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: FrescoController2Impl.fetch vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83 — MethodTooLong — fetch runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: KFrescoController.fetch vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132 — MethodTooLong — fetch runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DefaultRawBitmapDecoder.decode imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:202 — MethodTooLong — decode runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: LiveEditorOnScreenButtonController.createOnScreenButtons vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt:660 — MethodTooLong — createOnScreenButtons runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ProgressiveDecoder.doDecode imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt:190 — MethodTooLong — doDecode runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: GenericDraweeHierarchyInflater.updateBuilder drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:102 — MethodTooLong — updateBuilder runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.

D4 · Code Duplication · Duplicated block (5 lines × 2) · ×5

Duplicated block (5 lines × 2) fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:63 — fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:63-67 | fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:74-78 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:80` calls `put` and `fbcore/src/main/java/com/facebook/common/internal/ImmutableMap.java:69` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) imagepipeline-backends/imagepipeline-volley/src/main/java/com/facebook/imagepipeline/backends/volley/VolleyNetworkFetcher.java:127 — imagepipeline-backends/imagepipeline-volley/src/main/java/com/facebook/imagepipeline/backends/volley/VolleyNetworkFetcher.java:127-131 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/HttpUrlConnectionNetworkFetcher.java:243-247 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline-backends/imagepipeline-volley/src/main/java/com/facebook/imagepipeline/backends/volley/VolleyNetworkFetcher.java:127` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `fetchState` to `VolleyNetworkFetchState` in one and `HttpUrlConnectionNetworkFetchState` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:283 — ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:283-287 | ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:362-366 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui-core/src/main/java/com/facebook/drawee/drawable/ScalingUtils.java:283` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:369 — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:369-373 | samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:289-293 — before extracting anything, compare `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/VitoRoundedCornersFragment.java:89 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/VitoRoundedCornersFragment.java:89-93 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/VitoScaleTypeFragment.java:86-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.

D5 · Coupling · Unstable project · ×5

Unstable project :animated-drawable — :animated-drawable has instability 0.90 with 1 dependents.
Unstable project :tools:flipper — :tools:flipper has instability 0.88 with 1 dependents.
Unstable project :vito:core-impl — :vito:core-impl has instability 0.81 with 3 dependents.
Unstable project :vito:nativecode — :vito:nativecode has instability 0.83 with 1 dependents.
Unstable project :vito:textspan — :vito:textspan has instability 0.89 with 1 dependents.

D15 · Churn × Complexity Hotspots · Hotspot · ×4

Hotspot: vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132 — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in KFrescoController.fetch at line 132. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:24:50 -07:00' --until='2026-10-23 16:24:50 -07:00' --full-history --no-merges -- vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt:190 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in ProgressiveDecoder.doDecode at line 190. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:24:50 -07:00' --until='2026-10-23 16:24:50 -07:00' --full-history --no-merges -- imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83 — vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in FrescoController2Impl.fetch at line 83. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:24:50 -07:00' --until='2026-10-23 16:24:50 -07:00' --full-history --no-merges -- vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt:235 — imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in ProducerSequenceFactory.getDefaultBasicDecodedImageSequence at line 235. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:24:50 -07:00' --until='2026-10-23 16:24:50 -07:00' --full-history --no-merges -- imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.

D3 · God Classes · FileTooLong · ×4

FileTooLong: core/ImagePipeline.kt imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipeline.kt — FileTooLong — 782 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: ImagePipeline (54-1391). The bar is 500 significant lines; this is 282 over it, 1.56× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: liveeditor/LiveEditorOnScreenButtonController.kt vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt — FileTooLong — 590 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 90 over it, 1.18× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: controller/AbstractDraweeController.java drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeController.java — FileTooLong — 567 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: AbstractDraweeController (58-876). The bar is 500 significant lines; this is 67 over it, 1.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: fresco/FrescoFlipperPlugin.java tools/flipper-fresco-plugin/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java — FileTooLong — 501 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: FrescoFlipperPlugin (69-673). The bar is 500 significant lines; this is 1 over it, 1.00× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.

D6 · Cohesion (LCOM4) · Low cohesion · ×4

Low cohesion: Builder (LCOM4 12) imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolConfig.kt:61 — Builder's methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: FrescoDrawable2 (LCOM4 7) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoDrawable2.kt:26 — FrescoDrawable2's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: HierarcherImpl (LCOM4 6) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/HierarcherImpl.kt:24 — HierarcherImpl's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: FrescoController2Impl (LCOM4 4) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:56 — FrescoController2Impl's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.

X3 · Exception handling · Swallowed exception (caught, then discarded) · ×4

Swallowed exception (caught, then discarded) imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:176 — `catch (exception: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:216 — `catch (exception: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:197 — `catch (t: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt:265 — `catch (_: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.

D17 · Explicit Debt · FixmeComment · ×3

FixmeComment vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ExtrasUtils.kt:31 — // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:100 — // FIXME: no smart fetch — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:104 — // probably should be null (and above) FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.

D36 · Supply-chain Provenance & Signing REDACTED · ×3

REDACTED
REDACTED
REDACTED

D4 · Code Duplication · Duplicated block (15 lines × 2) · ×3

Duplicated block (15 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:81 — imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:81-95 | imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:228-242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/cache/BufferedDiskCache.kt:81` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapProbeProducer.java:71 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapProbeProducer.java:71-85 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedProbeProducer.java:62-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapProbeProducer.java:71` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/DefaultCloseableImage.java:20 — imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/DefaultCloseableImage.java:20-34 | imagepipeline-base/src/main/java/com/facebook/imagepipeline/image/DefaultCloseableStaticBitmap.java:41-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.

D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3

Duplicated block (11 lines × 2) vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:126 — vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:126-136 | vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:156-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:124` calls `equal` and `vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:154` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java:25 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java:25-35 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java:40-50 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/SettableProducerContext.java:25` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:58 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:58-68 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java:62-72 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (10 lines × 2) · ×3

Duplicated block (10 lines × 2) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:275 — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:275-284 | vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageFetchSubscriber.kt:139-148 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) fbcore/src/main/java/com/facebook/datasource/FirstAvailableDataSourceSupplier.java:53 — fbcore/src/main/java/com/facebook/datasource/FirstAvailableDataSourceSupplier.java:53-62 | fbcore/src/main/java/com/facebook/datasource/IncreasingQualityDataSourceSupplier.java:90-99 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:88 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:88-97 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java:92-101 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.

D4 · Code Duplication · Duplicated block (16 lines × 2) · ×3

Duplicated block (16 lines × 2) fbcore/src/main/java/com/facebook/common/references/DefaultCloseableReference.java:45 — fbcore/src/main/java/com/facebook/common/references/DefaultCloseableReference.java:45-60 | fbcore/src/main/java/com/facebook/common/references/FinalizerCloseableReference.java:41-56 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `fbcore/src/main/java/com/facebook/common/references/DefaultCloseableReference.java:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/DefaultImageDecoder.java:210 — imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/DefaultImageDecoder.java:210-225 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/FrescoVitoRegionDecoder.java:63-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/DefaultImageDecoder.java:210` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/DefaultImageDecoder.java:209` calls `checkNotNull` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/FrescoVitoRegionDecoder.java:61` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:140 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:140-155 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java:104-119 — before extracting anything, compare `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java` and `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:140` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.

D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3

Duplicated block (13 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:227 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:227-239 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:239-251 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedMemoryCacheProducer.java:205 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedMemoryCacheProducer.java:205-217 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedProbeProducer.java:107-119 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedMemoryCacheProducer.java:205` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:32 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:32-44 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt:31-43 — before extracting anything, compare `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt:44` calls `RoundedRectShape`, `dpToPx` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:45` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (9 lines × 2) · ×3

Duplicated block (9 lines × 2) drawee/src/main/java/com/facebook/drawee/drawable/RoundedColorDrawable.java:134 — drawee/src/main/java/com/facebook/drawee/drawable/RoundedColorDrawable.java:134-142 | drawee/src/main/java/com/facebook/drawee/drawable/RoundedCornersDrawable.java:116-124 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:242 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:242-250 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:254-262 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:242` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (9 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineBitmapFactoryFragment.java:202 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineBitmapFactoryFragment.java:202-210 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/VitoRotationFragment.java:103-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.

D4 · Code Duplication · Duplicated block (8 lines × 2) · ×3

Duplicated block (8 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/keyframes/ImageFormatKeyframesFragment.java:48 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/keyframes/ImageFormatKeyframesFragment.java:48-55 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/svg/ImageFormatSvgFragment.java:48-55 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:70 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:70-77 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java:74-81 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:79 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:79-86 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java:83-90 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED

D35 · Change Coupling · Change coupling · ×2

Change coupling: DebugDataProvider.kt ↔ DebugOverlayHandler.kt vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:1 — `vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt` and `vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugOverlayHandler.kt` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `7e6827e0` Add logcat dump for image I:D ratio and wasted memory; `2cb773ef` Add Wasted Memory field; `2e31c9ed` Add I:D ratio Visualization in Fresco/Vito debug overlay — run `git show` on any of them.
Change coupling: CombinedImageListenerImpl.kt ↔ KFrescoController.kt vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/CombinedImageListenerImpl.kt:1 — `vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/CombinedImageListenerImpl.kt` and `vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `bb517b5f` Added new perf logging callback when an image is displayed; `bad03fac` Added options to reset various Vito listeners when the FrescoDrawable…; `70edbf58` Create ImagePerfLoggingListener interface — run `git show` on any of them.

D4 · Code Duplication · Duplicated block (14 lines × 2) · ×2

Duplicated block (14 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/listener/RequestLoggingListener.kt:68 — imagepipeline/src/main/java/com/facebook/imagepipeline/listener/RequestLoggingListener.kt:68-81 | imagepipeline/src/main/java/com/facebook/imagepipeline/listener/RequestLoggingListener.kt:115-128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/listener/RequestLoggingListener.kt:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/fragments/SettingsFragment.java:429 — samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/fragments/SettingsFragment.java:429-442 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/svg/ImageFormatSvgFragment.java:81-94 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `R` names `com.facebook.fresco.samples.showcase.R` in one and `com.facebook.samples.scrollperf.R` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D4 · Code Duplication · Duplicated block (18 lines × 2) · ×2

Duplicated block (18 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:70 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:70-87 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java:64-81 — before extracting anything, compare `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java` and `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:70` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:69` calls `CancellationSignal` and `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java:63` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18 lines × 2) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:299 — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:299-316 | samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:222-239 — before extracting anything, compare `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:299` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:240` calls `getParent` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:317` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D1 · Cyclomatic Complexity · GenericDraweeHierarchyInflater.updateBuilder (cyclomatic 48) · ×1

GenericDraweeHierarchyInflater.updateBuilder (cyclomatic 48) drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:102 — GenericDraweeHierarchyInflater.updateBuilder has cyclomatic complexity 48 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · VitoViewInflater.inflateImageOptionsBuilder (cyclomatic 37) · ×1

VitoViewInflater.inflateImageOptionsBuilder (cyclomatic 37) vito/drawee-support/src/main/java/com/facebook/fresco/vito/draweesupport/VitoViewInflater.kt:26 — VitoViewInflater.inflateImageOptionsBuilder has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · DefaultRawBitmapDecoder.decode (cyclomatic 33) · ×1

DefaultRawBitmapDecoder.decode (cyclomatic 33) imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:202 — DefaultRawBitmapDecoder.decode has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · KFrescoController.fetch (cyclomatic 27) · ×1

KFrescoController.fetch (cyclomatic 27) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132 — KFrescoController.fetch has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · FrescoController2Impl.fetch (cyclomatic 26) · ×1

FrescoController2Impl.fetch (cyclomatic 26) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83 — FrescoController2Impl.fetch has cyclomatic complexity 26 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · BitmapPreparingImageFetchSubscriber.onNewResult (cyclomatic 26) · ×1

BitmapPreparingImageFetchSubscriber.onNewResult (cyclomatic 26) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:40 — BitmapPreparingImageFetchSubscriber.onNewResult has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · VitoImagePipelineImpl.determineFetchStrategy (cyclomatic 23) · ×1

VitoImagePipelineImpl.determineFetchStrategy (cyclomatic 23) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:226 — VitoImagePipelineImpl.determineFetchStrategy has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ProgressiveJpegParser.doParseMoreData (cyclomatic 21) · ×1

ProgressiveJpegParser.doParseMoreData (cyclomatic 21) imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/ProgressiveJpegParser.java:140 — ProgressiveJpegParser.doParseMoreData has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · LiveEditorOnScreenButtonController.createOnScreenButtons (cyclomatic 20) · ×1

LiveEditorOnScreenButtonController.createOnScreenButtons (cyclomatic 20) vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt:660 — LiveEditorOnScreenButtonController.createOnScreenButtons has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ProgressiveDecoder.doDecode (cyclomatic 19) · ×1

ProgressiveDecoder.doDecode (cyclomatic 19) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt:190 — ProgressiveDecoder.doDecode has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · ImageDecodeOptions.equals (cyclomatic 19) · ×1

ImageDecodeOptions.equals (cyclomatic 19) imagepipeline-base/src/main/java/com/facebook/imagepipeline/common/ImageDecodeOptions.java:122 — ImageDecodeOptions.equals has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · FrescoController2Impl.setActualImage (cyclomatic 16) · ×1

FrescoController2Impl.setActualImage (cyclomatic 16) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:359 — FrescoController2Impl.setActualImage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ProducerSequenceFactory.getDefaultBasicDecodedImageSequence (cyclomatic 16) · ×1

ProducerSequenceFactory.getDefaultBasicDecodedImageSequence (cyclomatic 16) imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt:235 — ProducerSequenceFactory.getDefaultBasicDecodedImageSequence has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D12 · Dependency Hygiene · No Gemfile.lock committed by an application · ×1

No Gemfile.lock committed by an application — This repository declares 1 gem(s) across 1 Bundler manifest(s) and ships no application `.gemspec`, so it is an APPLICATION — but no `Gemfile.lock` is committed. Nothing records the versions a working build resolved to, so `bundle install` re-resolves against whatever rubygems.org serves today and two deploys of this commit are not guaranteed to be the same deploy. Run `bundle install` and commit the resulting `Gemfile.lock`. (A published GEM correctly omits its lock, which is why this is asked only of a repository that ships no .gemspec.)

D2 · Cognitive Complexity · GenericDraweeHierarchyInflater.updateBuilder (cognitive 56) · ×1

GenericDraweeHierarchyInflater.updateBuilder (cognitive 56) drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:102 — GenericDraweeHierarchyInflater.updateBuilder has cognitive complexity 56 (threshold 15). Drivers by points: if/else 34 (37 pts), boolean chains 9, ternaries 4 (8 pts), loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · VitoViewInflater.inflateImageOptionsBuilder (cognitive 51) · ×1

VitoViewInflater.inflateImageOptionsBuilder (cognitive 51) vito/drawee-support/src/main/java/com/facebook/fresco/vito/draweesupport/VitoViewInflater.kt:26 — VitoViewInflater.inflateImageOptionsBuilder has cognitive complexity 51 (threshold 15). Drivers by points: if/else 16 (40 pts), boolean chains 8, match/switch 1 (2 pts), loops 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DefaultRawBitmapDecoder.decode (cognitive 45) · ×1

DefaultRawBitmapDecoder.decode (cognitive 45) imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:202 — DefaultRawBitmapDecoder.decode has cognitive complexity 45 (threshold 15). Drivers by points: if/else 19 (29 pts), boolean chains 9, error handling 5 (7 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · BitmapPreparingImageFetchSubscriber.onNewResult (cognitive 39) · ×1

BitmapPreparingImageFetchSubscriber.onNewResult (cognitive 39) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:40 — BitmapPreparingImageFetchSubscriber.onNewResult has cognitive complexity 39 (threshold 15). Drivers by points: if/else 20 (27 pts), error handling 4 (8 pts), boolean chains 4 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · FrescoController2Impl.fetch (cognitive 35) · ×1

FrescoController2Impl.fetch (cognitive 35) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:83 — FrescoController2Impl.fetch has cognitive complexity 35 (threshold 15). Drivers by points: if/else 23 (30 pts), boolean chains 5 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · ProgressiveJpegParser.doParseMoreData (cognitive 34) · ×1

ProgressiveJpegParser.doParseMoreData (cognitive 34) imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/ProgressiveJpegParser.java:140 — ProgressiveJpegParser.doParseMoreData has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (28 pts), boolean chains 2, match/switch 1 (2 pts), error handling 1, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · VitoImagePipelineImpl.determineFetchStrategy (cognitive 33) · ×1

VitoImagePipelineImpl.determineFetchStrategy (cognitive 33) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:226 — VitoImagePipelineImpl.determineFetchStrategy has cognitive complexity 33 (threshold 15). Drivers by points: if/else 19 (28 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · KFrescoController.fetch (cognitive 30) · ×1

KFrescoController.fetch (cognitive 30) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:132 — KFrescoController.fetch has cognitive complexity 30 (threshold 15). Drivers by points: if/else 19 (23 pts), boolean chains 6, match/switch 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · 1.getResult (cognitive 27) · ×1

1.getResult (cognitive 27) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:88 — 1.getResult has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (14 pts), ternaries 2 (7 pts), error handling 2 (5 pts), boolean chains 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.

D2 · Cognitive Complexity · ProgressiveDecoder.doDecode (cognitive 23) · ×1

ProgressiveDecoder.doDecode (cognitive 23) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DecodeProducer.kt:190 — ProgressiveDecoder.doDecode has cognitive complexity 23 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 7, error handling 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · RoundedDrawable.updateTransform (cognitive 23) · ×1

RoundedDrawable.updateTransform (cognitive 23) drawee/src/main/java/com/facebook/drawee/drawable/RoundedDrawable.kt:208 — RoundedDrawable.updateTransform has cognitive complexity 23 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · FrescoController2Impl.setActualImage (cognitive 22) · ×1

FrescoController2Impl.setActualImage (cognitive 22) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt:359 — FrescoController2Impl.setActualImage has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 6 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · LightweightDebugOverlayFactory2.buildDebugTextFromConfig (cognitive 22) · ×1

LightweightDebugOverlayFactory2.buildDebugTextFromConfig (cognitive 22) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/debug/LightweightDebugOverlayFactory2.kt:135 — LightweightDebugOverlayFactory2.buildDebugTextFromConfig has cognitive complexity 22 (threshold 15). Drivers by points: if/else 15 (22 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · ProducerSequenceFactory.getDefaultBasicDecodedImageSequence (cognitive 20) · ×1

ProducerSequenceFactory.getDefaultBasicDecodedImageSequence (cognitive 20) imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.kt:235 — ProducerSequenceFactory.getDefaultBasicDecodedImageSequence has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 1 (3 pts), match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.

D2 · Cognitive Complexity · DefaultRawBitmapDecoder.decodeByteArray (cognitive 20) · ×1

DefaultRawBitmapDecoder.decodeByteArray (cognitive 20) imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt:63 — DefaultRawBitmapDecoder.decodeByteArray has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 3, error handling 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · RoundedDrawable.updatePath (cognitive 20) · ×1

RoundedDrawable.updatePath (cognitive 20) drawee/src/main/java/com/facebook/drawee/drawable/RoundedDrawable.kt:269 — RoundedDrawable.updatePath has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · AnimatedDrawable2.draw (cognitive 20) · ×1

AnimatedDrawable2.draw (cognitive 20) animated-drawable/src/main/java/com/facebook/fresco/animation/drawable/AnimatedDrawable2.kt:162 — AnimatedDrawable2.draw has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · RoundedCornersDrawable.draw (cognitive 20) · ×1

RoundedCornersDrawable.draw (cognitive 20) drawee/src/main/java/com/facebook/drawee/drawable/RoundedCornersDrawable.java:272 — RoundedCornersDrawable.draw has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (19 pts), match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · Fresco.initialize (cognitive 19) · ×1

Fresco.initialize (cognitive 19) drawee-backends/drawee-pipeline/src/main/java/com/facebook/drawee/backends/pipeline/Fresco.java:61 — Fresco.initialize has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (11 pts), error handling 4 (8 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · LiveEditorOnScreenButtonController.createOnScreenButtons (cognitive 18) · ×1

LiveEditorOnScreenButtonController.createOnScreenButtons (cognitive 18) vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorOnScreenButtonController.kt:660 — LiveEditorOnScreenButtonController.createOnScreenButtons has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 4, match/switch 2 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DebugDataProviderKt.createWastedMemoryProvider (cognitive 18) · ×1

DebugDataProviderKt.createWastedMemoryProvider (cognitive 18) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:170 — DebugDataProviderKt.createWastedMemoryProvider has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · ImageDecodeOptions.equals (cognitive 18) · ×1

ImageDecodeOptions.equals (cognitive 18) imagepipeline-base/src/main/java/com/facebook/imagepipeline/common/ImageDecodeOptions.java:122 — ImageDecodeOptions.equals has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15, boolean chains 3. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D2 · Cognitive Complexity · SimpleDraweeView.init (cognitive 18) · ×1

SimpleDraweeView.init (cognitive 18) drawee/src/main/java/com/facebook/drawee/view/SimpleDraweeView.java:85 — SimpleDraweeView.init has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (18 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · VitoImagePipelineImpl.createImageRequest (cognitive 17) · ×1

VitoImagePipelineImpl.createImageRequest (cognitive 17) vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt:53 — VitoImagePipelineImpl.createImageRequest has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (16 pts), match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · ImageFormatCheckerUtils.indexOfPattern (cognitive 17) · ×1

ImageFormatCheckerUtils.indexOfPattern (cognitive 17) imagepipeline-base/src/main/java/com/facebook/imageformat/ImageFormatCheckerUtils.kt:68 — ImageFormatCheckerUtils.indexOfPattern has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · BitmapMemoryCacheProducer.produceResults (cognitive 17) · ×1

BitmapMemoryCacheProducer.produceResults (cognitive 17) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapMemoryCacheProducer.java:47 — BitmapMemoryCacheProducer.produceResults has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (10 pts), ternaries 4 (7 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · 1.onNewResultImpl (cognitive 17) · ×1

1.onNewResultImpl (cognitive 17) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapMemoryCacheProducer.java:136 — 1.onNewResultImpl has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · VitoDrawableChangedListener.onFinalImageSet (cognitive 17) · ×1

VitoDrawableChangedListener.onFinalImageSet (cognitive 17) drawee-span/src/main/java/com/facebook/drawee/span/DraweeSpanStringBuilder.java:297 — VitoDrawableChangedListener.onFinalImageSet has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 3 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.

D2 · Cognitive Complexity · ShapeCalculator.getShape (cognitive 16) · ×1

ShapeCalculator.getShape (cognitive 16) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ShapeCalculator.kt:22 — ShapeCalculator.getShape has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 1 (4 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.

D2 · Cognitive Complexity · HttpUrlConnectionNetworkFetcher.downloadFrom (cognitive 16) · ×1

HttpUrlConnectionNetworkFetcher.downloadFrom (cognitive 16) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/HttpUrlConnectionNetworkFetcher.java:161 — HttpUrlConnectionNetworkFetcher.downloadFrom has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (8 pts), ternaries 2 (5 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · AbstractDraweeController.onFailureInternal (cognitive 16) · ×1

AbstractDraweeController.onFailureInternal (cognitive 16) drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeController.java:655 — AbstractDraweeController.onFailureInternal has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 1, ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DefaultDrawableFactory.createDrawable (cognitive 16) · ×1

DefaultDrawableFactory.createDrawable (cognitive 16) drawee-backends/drawee-pipeline/src/main/java/com/facebook/drawee/backends/pipeline/DefaultDrawableFactory.java:52 — DefaultDrawableFactory.createDrawable has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 4, error handling 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · AnimatedImageCompositor.prepareCanvasWithClosestCachedFrame (cognitive 16) · ×1

AnimatedImageCompositor.prepareCanvasWithClosestCachedFrame (cognitive 16) animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedImageCompositor.java:164 — AnimatedImageCompositor.prepareCanvasWithClosestCachedFrame has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (13 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D22 · Internal API Consistency · Redundant overloads for Uri vs ImageSource · ×1

Redundant overloads for Uri vs ImageSource: The API exposes separate overloads for `Uri` and `ImageSource` that perform the same logical operation (loading an image). Since `ImageSource` is the internal abstraction and `Uri` is a common input, forcing users to choose between `show(uri, ...)` and `show(ImageSource.fromUri(...), ...)` creates confusion. The `Uri` overloads are essentially wrappers around `ImageSource` creation. — Remove the `Uri`-specific overloads from the public API. Require users to construct an `ImageSource` (e.g., via `ImageSourceProvider.forUri` or a static factory) before calling `show`. This unifies the entry point to a single `show(imageSource: ImageSource, ...)` family of methods. (signatures: VitoView.show(uri: Uri?, target: View) | VitoView.show(imageSource: ImageSource, target: View) | VitoView.show(uri: Uri?, imageOptions: ImageOptions, target: View) | VitoView.show(imageSource: ImageSource, imageOptions: ImageOptions, target: View))

D22 · Internal API Consistency · Dual entry points for image loading · ×1

Dual entry points for image loading: `VitoView` exposes both `show(ImageSource)` and `show(VitoImageRequest)`. While `VitoImageRequest` is a higher-level abstraction, exposing both on the same view class creates ambiguity about which should be used for standard use cases. It suggests a split in the API design between 'simple' and 'advanced' loading without clear separation of concerns. — Deprecate `show(VitoImageRequest)` on `VitoView` in favor of `show(ImageSource)`, or move `VitoImageRequest` support to a separate, more advanced view/controller interface. If both are needed, ensure the documentation clearly distinguishes their use cases, but ideally, one should be the primary public API. (signatures: VitoView.show(vitoImageRequest: VitoImageRequest, ...) | VitoView.show(imageSource: ImageSource, ...))

D22 · Internal API Consistency · Implementation class exposes same dual entry point inconsistency · ×1

Implementation class exposes same dual entry point inconsistency: `VitoViewImpl2` (likely an internal implementation detail exposed in the public surface) repeats the `ImageSource` vs `VitoImageRequest` overload pattern found in `VitoView`, compounding the confusion. — Align `VitoViewImpl2` with the recommended unification of `VitoView`. If `VitoViewImpl2` is internal, it should not be part of the public API surface review, or it should mirror the unified API. (signatures: VitoViewImpl2.show(imageRequest: VitoImageRequest, ...) | VitoViewImpl2.show(imageSource: ImageSource, ...))

D22 · Internal API Consistency · Inconsistent naming and parameter structure for fetching · ×1

Inconsistent naming and parameter structure for fetching: `ImageLiveEditor` has two `fetch` methods with different signatures. One takes explicit `ImageSource` and `ImageOptions`, the other takes a pre-built `VitoImageRequest`. This mirrors the `VitoView` inconsistency but is even more confusing because `fetch` implies a lower-level operation than `show`, yet it accepts the high-level `VitoImageRequest`. — Unify to a single `fetch` signature. If `VitoImageRequest` is the preferred way to configure complex loads, use that. If `ImageSource` + `ImageOptions` is preferred, use that. Remove the redundant overload. (signatures: ImageLiveEditor.fetch(context: Context, imageSource: ImageSource, imageOptions: ImageOptions) | ImageLiveEditor.fetch(request: VitoImageRequest))

D22 · Internal API Consistency · Same dual entry point inconsistency in `VitoSpanLoader` · ×1

Same dual entry point inconsistency in `VitoSpanLoader`: The text span loader also exposes both `ImageSource` and `VitoImageRequest` variants for `show`, creating a parallel inconsistency across different view components (`VitoView`, `VitoSpanLoader`). — Unify `VitoSpanLoader` to use only `ImageSource` (or only `VitoImageRequest`) to match the recommended standard for `VitoView`. (signatures: VitoSpanLoader.show(imageSource: ImageSource, ...) | VitoSpanLoader.show(imageRequest: VitoImageRequest, ...))

D29 · Static Analysis (SAST) · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D4 · Code Duplication · Duplicated block (13–21 lines × 3) · ×1

Duplicated block (13–21 lines × 3) memory-types/ashmem/src/main/java/com/facebook/imagepipeline/memory/AshmemMemoryChunk.kt:138 — memory-types/ashmem/src/main/java/com/facebook/imagepipeline/memory/AshmemMemoryChunk.kt:138-158 | memory-types/nativememory/src/main/java/com/facebook/imagepipeline/memory/NativeMemoryChunk.kt:147-167 | memory-types/simple/src/main/java/com/facebook/imagepipeline/memory/BufferMemoryChunk.kt:100-112 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `memory-types/ashmem/src/main/java/com/facebook/imagepipeline/memory/AshmemMemoryChunk.kt:138` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1

Duplicated block (17 lines × 2) vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorUiUtils.kt:237 — vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorUiUtils.kt:237-253 | vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorUiUtils.kt:268-284 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `vito/tools/liveeditor/src/main/java/com/facebook/fresco/vito/tools/liveeditor/LiveEditorUiUtils.kt:237` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1

Duplicated block (14 lines × 3) vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:111 — vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:111-124 | vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:142-155 | vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:175-188 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:126` calls `equal` and `vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:157` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (7–8 lines × 3) · ×1

Duplicated block (7–8 lines × 3) vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:130 — vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:130-137 | vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:160-166 | vito/options/src/main/java/com/facebook/fresco/vito/options/ImageOptions.kt:193-199 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.

D4 · Code Duplication · Duplicated block (6 lines × 2) · ×1

Duplicated block (6 lines × 2) vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/debug/DebugOverlayDrawable.kt:142 — vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/debug/DebugOverlayDrawable.kt:142-147 | vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/debug/DebugOverlayDrawable.kt:172-177 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `vito/core-common-impl/src/main/java/com/facebook/fresco/vito/core/impl/debug/DebugOverlayDrawable.kt:142` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.

D4 · Code Duplication · Duplicated block (4–5 lines × 3) · ×1

Duplicated block (4–5 lines × 3) vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:153 — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:153-156 | vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:180-184 | vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugOverlayHandler.kt:79-83 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.

D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1

Duplicated block (20 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:161 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:161-180 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java:119-138 — before extracting anything, compare `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java` and `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:161` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (15–17 lines × 2) · ×1

Duplicated block (15–17 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineFactory.java:576 — imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineFactory.java:576-590 | imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineFactory.java:598-614 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/core/ImagePipelineFactory.java:576` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.

D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1

Duplicated block (13–14 lines × 2) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:104 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:104-116 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalThumbnailBitmapSdk29Producer.java:119-132 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.

D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1

Duplicated block (13 lines × 3) imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapMemoryCacheProducer.java:115 — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapMemoryCacheProducer.java:115-127 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapProbeProducer.java:77-89 | imagepipeline/src/main/java/com/facebook/imagepipeline/producers/EncodedProbeProducer.java:68-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapMemoryCacheProducer.java:115` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1

Duplicated block (10–11 lines × 2) animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java:317 — animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java:317-327 | animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java:408-417 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java:317` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (20–21 lines × 2) · ×1

Duplicated block (20–21 lines × 2) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:43 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:43-63 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt:44-63 — before extracting anything, compare `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:43` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererShapeExampleFragment.kt:43` calls `RoundedRectShape`, `dpToPx` and `samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/vito/renderer/RendererColorFilterExampleFragment.kt:43` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (27–29 lines × 2) · ×1

Duplicated block (27–29 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/InstrumentedDraweeView.java:57 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/InstrumentedDraweeView.java:57-83 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/InstrumentedVitoView.java:46-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/InstrumentedDraweeView.java:57` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Nullable` names `androidx.annotation.Nullable` in one and `javax.annotation.Nullable` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/InstrumentedVitoView.java:75` calls `setBgColor` and `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/InstrumentedDraweeView.java:85` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1

Duplicated block (24 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:101 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java:101-124 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java:105-128 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/Instrumentation.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/Instrumentation.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (18–21 lines × 2) · ×1

Duplicated block (18–21 lines × 2) samples/animation2/src/main/java/com/facebook/samples/animation2/bitmap/BitmapAnimationFragment.java:58 — samples/animation2/src/main/java/com/facebook/samples/animation2/bitmap/BitmapAnimationFragment.java:58-75 | samples/animation2/src/main/java/com/facebook/samples/animation2/color/SimpleColorFragment.java:53-73 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `samples/animation2/src/main/java/com/facebook/samples/animation2/bitmap/BitmapAnimationFragment.java:58` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (13–18 lines × 2) · ×1

Duplicated block (13–18 lines × 2) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:319 — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:319-336 | samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:244-256 — before extracting anything, compare `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:319` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1

Duplicated block (9 lines × 3) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineDownsampleFragment.java:104 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineDownsampleFragment.java:104-112 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineResizingFragment.java:195-203 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelineResizingFragment.java:251-259 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.

D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1

Duplicated block (7 lines × 3) samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/pjpeg/ImageFormatProgressiveJpegFragment.java:203 — samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/pjpeg/ImageFormatProgressiveJpegFragment.java:203-211 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imageformat/xml/ImageFormatXmlFragment.java:104-110 | samples/showcase/src/main/java/com/facebook/fresco/samples/showcase/imagepipeline/ImagePipelinePostProcessorFragment.java:143-151 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.

D4 · Code Duplication · Duplicated block (63 lines × 2) · ×1

Duplicated block (63 lines × 2) samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/PerfListener.java:18 — samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/PerfListener.java:18-80 | samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/PerfListener.java:21-83 — before extracting anything, compare `samples/comparison/src/main/java/com/facebook/samples/comparison/instrumentation/PerfListener.java` and `samples/scrollperf/src/main/java/com/facebook/samples/scrollperf/instrumentation/PerfListener.java` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D4 · Code Duplication · Duplicated block (12 lines × 2) · ×1

Duplicated block (12 lines × 2) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:394 — samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:394-405 | samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:313-324 — before extracting anything, compare `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableDraweeView.java:390` calls `maybeSetHugeImageController` and `samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableVitoView.java:309` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

X3 · Exception handling · Swallowed exception (empty catch) · ×1

Swallowed exception (empty catch) static-webp/src/main/java/com/facebook/webpsupport/WebpBitmapFactoryImpl.kt:368 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.

Minor — 195 finding(s)

D34 · Knowledge Freshness · Orphaned file · ×122

Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file fbcore/src/main/java/com/facebook/common/logging/FLog.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedImageCompositor.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file fbcore/src/main/java/com/facebook/common/statfs/StatFsHelper.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file run_comparison.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file drawee/src/main/java/com/facebook/drawee/drawable/RoundedCornersDrawable.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file animated-gif-lite/src/main/java/com/facebook/animated/giflite/decoder/GifMetadataDecoder.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/decoder/ProgressiveJpegParser.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file native-imagetranscoder/src/main/java/com/facebook/imagepipeline/nativecode/NativeJpegTranscoder.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline-base/src/main/java/com/facebook/cache/disk/DiskCacheConfig.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline-base/src/main/java/com/facebook/imagepipeline/transcoder/JpegTranscoderUtils.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalExifThumbnailProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file fbcore/src/main/java/com/facebook/datasource/FirstAvailableDataSourceSupplier.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file animated-base/src/main/java/com/facebook/imagepipeline/animated/factory/AnimatedImageDecoderBase.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline-base/src/main/java/com/facebook/imageutils/BitmapUtil.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/BitmapProbeProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalContentUriThumbnailFetchProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/producers/LocalVideoThumbnailProducer.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline/src/main/java/com/facebook/imagepipeline/listener/RequestLoggingListener.kt:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file imagepipeline-base/src/main/java/com/facebook/cache/disk/DiskStorage.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
+ 97 more in this group — see findings.md.

M4 · Documentation accuracy · README/code drift · ×40

README/code drift docs/_docs/animations.md:12 — docs/_docs/animations.md links to `index.html`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/animations.md:16 — docs/_docs/animations.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/building-from-source.md:8 — docs/_docs/building-from-source.md links to `index.html#_`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/caching.md:12 — docs/_docs/caching.md links to `modifying-image.html`, but `docs/_docs/modifying-image.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/caching.md:20 — docs/_docs/caching.md links to `customizing-image-formats.html`, but `docs/_docs/customizing-image-formats.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/caching.md:36 — docs/_docs/caching.md links to `configure-image-pipeline.html#configuring-the-disk-cache`, but `docs/_docs/configure-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/caching.md:102 — docs/_docs/caching.md links to `image-requests.html`, but `docs/_docs/image-requests.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/closeable-references.md:10 — docs/_docs/closeable-references.md links to `using-simpledraweeview.html`, but `docs/_docs/using-simpledraweeview.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/concepts.md:16 — docs/_docs/concepts.md links to `index.html`, but `docs/_docs/index.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/concepts.md:18 — docs/_docs/concepts.md links to `using-simpledraweeview.html`, but `docs/_docs/using-simpledraweeview.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/concepts.md:34 — docs/_docs/concepts.md links to `using-controllerbuilder.html`, but `docs/_docs/using-controllerbuilder.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/concepts.md:38 — docs/_docs/concepts.md links to `listening-to-events.html`, but `docs/_docs/listening-to-events.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/configure-image-pipeline.md:65 — docs/_docs/configure-image-pipeline.md links to `using-other-network-layers.html`, but `docs/_docs/using-other-network-layers.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/datasources-datasubscribers.md:95 — docs/_docs/datasources-datasubscribers.md links to `closeable-references.html`, but `docs/_docs/closeable-references.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/datasources-datasubscribers.md:149 — docs/_docs/datasources-datasubscribers.md links to `../javadoc/reference/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber`, but `docs/javadoc/reference/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/drawee-branches.md:20 — docs/_docs/drawee-branches.md links to `scaletypes.html`, but `docs/_docs/scaletypes.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/drawee-branches.md:28 — docs/_docs/drawee-branches.md links to `using-controllerbuilder.html`, but `docs/_docs/using-controllerbuilder.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/drawee-branches.md:81 — docs/_docs/drawee-branches.md links to `progress-bars.html`, but `docs/_docs/progress-bars.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/faq.md:52 — docs/_docs/faq.md links to `using-image-pipeline.html`, but `docs/_docs/using-image-pipeline.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/faq.md:52 — docs/_docs/faq.md links to `datasources-datasubscribers.html`, but `docs/_docs/datasources-datasubscribers.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/faq.md:56 — docs/_docs/faq.md links to `post-processor.html`, but `docs/_docs/post-processor.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/faq.md:60 — docs/_docs/faq.md links to `proguard.html`, but `docs/_docs/proguard.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/gotchas.md:22 — docs/_docs/gotchas.md links to `writing-custom-views.html`, but `docs/_docs/writing-custom-views.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/image-requests.md:8 — docs/_docs/image-requests.md links to `requesting-multiple-images.html`, but `docs/_docs/requesting-multiple-images.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/_docs/image-requests.md:32 — docs/_docs/image-requests.md links to `supported-uris.html`, but `docs/_docs/supported-uris.html` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
+ 15 more in this group — see findings.md.

X10 · Duplicated predicate · Duplicated predicate · ×14

Duplicated predicate fbcore/src/main/java/com/facebook/datasource/FirstAvailableDataSourceSupplier.java:92 — `(dataSourceWithResult != null) && dataSourceWithResult.hasResult()` appears character-identically in 2 files — fbcore/src/main/java/com/facebook/datasource/FirstAvailableDataSourceSupplier.java, fbcore/src/main/java/com/facebook/datasource/IncreasingQualityDataSourceSupplier.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate drawee/src/main/java/com/facebook/drawee/generic/RoundingParams.java:302 — `other == null || getClass() != other.getClass()` appears character-identically in 2 files — drawee/src/main/java/com/facebook/drawee/generic/RoundingParams.java, imagepipeline-base/src/main/java/com/facebook/imagepipeline/common/ImageDecodeOptions.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java:205 — `task.isCancelled() || (task.isFaulted() && task.getError() instanceof CancellationException)` appears character-identically in 2 files — imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java, imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate imagepipeline/src/main/java/com/facebook/imagepipeline/postprocessors/BlurPostProcessor.kt:41 — `blurRadius > 0 && blurRadius <= RenderScriptBlurFilter.BLUR_MAX_RADIUS` appears character-identically in 2 files — imagepipeline/src/main/java/com/facebook/imagepipeline/postprocessors/BlurPostProcessor.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/postprocessors/DownScaleBlurPostProcessor.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core/src/main/java/com/facebook/fresco/vito/drawable/BitmapDrawableFactory.kt:65 — `borderOptions != null && borderOptions.width > 0` appears character-identically in 2 files — vito/core/src/main/java/com/facebook/fresco/vito/drawable/BitmapDrawableFactory.kt, vito/core/src/main/java/com/facebook/fresco/vito/drawable/RoundingUtils.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate imagepipeline/src/main/java/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber.kt:48 — `closeableImageRef != null && closeableImageRef.get() is CloseableBitmap` appears character-identically in 2 files — imagepipeline/src/main/java/com/facebook/imagepipeline/datasource/BaseBitmapDataSubscriber.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/datasource/BaseListBitmapDataSubscriber.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt:268 — `config.useIntermediateImagesAsPlaceholder() && cachedImage?.get()?.qualityInfo?.isOfFullQuality != true` appears character-identically in 2 files — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/KFrescoController.kt, vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageFetchSubscriber.kt:135 — `dataSource == null || dataSource.isFinished || dataSource.hasMultipleResults()` appears character-identically in 2 files — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageFetchSubscriber.kt, vito/core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/FrescoController2Impl.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt:93 — `fadeListener != null && fadeDurationMs > 0` appears character-identically in 2 files — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/BitmapPreparingImageFetchSubscriber.kt, vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/ImageFetchSubscriber.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate imagepipeline-base/src/main/java/com/facebook/imageutils/BitmapUtil.kt:76 — `options.outWidth == -1 || options.outHeight == -1` appears character-identically in 2 files — imagepipeline-base/src/main/java/com/facebook/imageutils/BitmapUtil.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/platform/DefaultRawBitmapDecoder.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate animated-base/src/main/java/com/facebook/fresco/animation/bitmap/cache/AnimationFrameCacheKey.kt:35 — `other == null || javaClass != other.javaClass` appears character-identically in 5 files — animated-base/src/main/java/com/facebook/fresco/animation/bitmap/cache/AnimationFrameCacheKey.kt, vito/core/src/main/java/com/facebook/fresco/vito/core/VitoImageRequest.kt, vito/options/src/main/java/com/facebook/fresco/vito/options/DecodedImageOptions.kt, vito/options/src/main/java/com/facebook/fresco/vito/options/EncodedImageOptions.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate drawee/src/main/java/com/facebook/drawee/drawable/MatrixDrawable.kt:102 — `underlyingWidth <= 0 || underlyingHeight <= 0` appears character-identically in 2 files — drawee/src/main/java/com/facebook/drawee/drawable/MatrixDrawable.kt, drawee/src/main/java/com/facebook/drawee/drawable/ScaleTypeDrawable.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:157 — `viewport != null && viewport.height() > 0` appears character-identically in 2 files — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt, vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugOverlayHandler.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt:155 — `viewport != null && viewport.width() > 0` appears character-identically in 2 files — vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugDataProvider.kt, vito/core-impl/src/main/java/com/facebook/fresco/vito/core/impl/DebugOverlayHandler.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.

AX6 · Interface segregation · Fat interface · ×3

Fat interface: LoggingDelegate (16 abstract methods) fbcore/src/main/java/com/facebook/common/logging/LoggingDelegate.java:14 — `LoggingDelegate` declares 16 abstract methods under just 10 distinct name(s): `d`, `d`, `e`, `e`, `getMinimumLoggingLevel`, `i`, `i`, `isLoggable`, `log`, `setMinimumLoggingLevel`, `v`, `v`, `w`, `w`, `wtf`, `wtf`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 10 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: ZoomableController (16 abstract methods) samples/zoomable/src/main/java/com/facebook/samples/zoomable/ZoomableController.java:18 — `ZoomableController` declares 16 abstract methods: `computeHorizontalScrollExtent`, `computeHorizontalScrollOffset`, `computeHorizontalScrollRange`, `computeVerticalScrollExtent`, `computeVerticalScrollOffset`, `computeVerticalScrollRange`, `getScaleFactor`, `getTransform`, `isEnabled`, `isIdentity`, `onTouchEvent`, `setEnabled`, `setImageBounds`, `setListener`, `setViewBounds`, `wasTransformCorrected`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: AnimatedDrawableBackend (20 abstract methods) animated-base/src/main/java/com/facebook/imagepipeline/animated/base/AnimatedDrawableBackend.java:22 — `AnimatedDrawableBackend` declares 20 abstract methods: `dropCaches`, `forNewBounds`, `getAnimatedImageResult`, `getDurationMs`, `getDurationMsForFrame`, `getFrameCount`, `getFrameForPreview`, `getFrameForTimestampMs`, `getFrameInfo`, `getHeight`, `getLoopCount`, `getMemoryUsage`, `getPreDecodedFrame`, `getRenderedHeight`, `getRenderedWidth`, `getTimestampMsForFrame`, `getWidth`, `hasPreDecodedFrame`, `renderDeltas`, `renderFrame`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.

D16 · Bus Factor · Off-boarding risk · ×2

Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 4 significant file(s) lose their only recent owner: imagepipeline-backends/imagepipeline-volley/src/main/java/com/facebook/imagepipeline/backends/volley/VolleyNetworkFetcher.java, imagepipeline/src/main/java/com/facebook/imagepipeline/producers/CustomProducerSequenceFactory.java, imagepipeline/src/main/java/com/facebook/imagepipeline/memory/BitmapCounter.java, imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ProducerContext.kt. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 3 significant file(s) lose their only recent owner: imagepipeline/src/main/java/com/facebook/imagepipeline/cache/UnifiedCacheKeyFactory.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/cache/CacheKeyConfig.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/cache/UnifiedCacheKeyGenerator.kt. Pair on, review, or document these before any departure.

D16 · Bus Factor · Further sole-owners (lower concentration) · ×1

Further sole-owners (lower concentration) — 9 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (24 single-owned of 321 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 321 of the 860 production source files in this repository met that bar). They are anonymized user #3 (2 file(s)), anonymized user #4 (2 file(s)), anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)), anonymized user #8 (1 file(s)) (+3 more) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: imagepipeline/src/main/java/com/facebook/imagepipeline/datasource/AbstractProducerToDataSourceAdapter.kt, vito/core/src/main/java/com/facebook/fresco/vito/listener/ForwardingImageListener.kt, drawee-backends/drawee-pipeline/src/main/java/com/facebook/drawee/backends/pipeline/info/ImageOriginUtils.java, animated-drawable/src/main/java/com/facebook/fresco/animation/bitmap/preparation/ondemandanimation/FrameLoader.kt, fbcore/src/main/java/com/facebook/common/logging/FLog.kt, fbcore/src/main/java/com/facebook/datasource/IncreasingQualityDataSourceSupplier.java, vito/core/src/main/java/com/facebook/fresco/vito/drawable/RoundingUtils.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/postprocessors/DownScaleBlurPostProcessor.kt (+3 more).

D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1

Projects may be oversized for their cohesion — 3 of 50 project(s) overshoot their size bounds, lowering Project Cohesion to 8.8/10. The most over is `imagepipeline` (23075 LoC, 284 module-visible types across 15 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.

D28 · Secrets (history) · Rotate the exposed credentials · ×1

REDACTED

D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1

Further orphaned files (smaller) — 122 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: imagepipeline/src/main/java/com/facebook/imagepipeline/producers/PartialDiskCacheProducer.java, animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedDrawableBackendImpl.java, fbcore/src/main/java/com/facebook/common/logging/FLog.kt, imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducer.java, drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchyInflater.java, fbcore/src/main/java/com/facebook/datasource/AbstractDataSource.java, imagepipeline/src/main/java/com/facebook/imagepipeline/producers/DiskCacheReadProducer.java, animated-base/src/main/java/com/facebook/imagepipeline/animated/impl/AnimatedImageCompositor.java (and 114 more) (124 orphaned of 330 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 330 of the 860 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

M2 · Architecture documentation · No ADRs · ×1

No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

M2 · Architecture documentation · No architecture diagram/doc · ×1

No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

P10 · Library API & versioning · Large public API surface · ×1

Large public API surface — 1127/1275 types (88%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

P2 · Observability · Logging is not universal · ×1

Logging is not universal — Only 1/2 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`.

P3 · Security & performance tooling · No SAST · ×1

No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 2907 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

P4 · Deployment & Rollback · No release approval gate · ×1

No release approval gate — The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.

P6 · Release Hygiene · No changelog · ×1

No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

Minor — 1 finding(s)

D5 · Coupling · Off the main sequence · ×1

Off the main sequence: :ui-common — :ui-common: abstractness 0.20, instability 0.05, distance 0.76 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

Dimension	Tool	Version	Command	Findings	Raw output
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-44231e2468e94cef80fc1b91f2758921/history.json --exit-code 0 --source .	3	artifacts/raw/gitleaks-history.json
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-44231e2468e94cef80fc1b91f2758921/tree.json --exit-code 0 --source .	2	artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)	semgrep	—	semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .	14	artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilities	osv-scanner	—	osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .	0	—
D31 · IaC & Container Security	trivy	—	trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.	0	—
D32 · Data Compliance (PII/GDPR)	semgrep	—	semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 34 file(s) — `animated-base/src/main/java/com/facebook/imagepipeline/animated/factory/AnimatedImageDecoderBase.kt`, `animated-drawable/src/main/java/com/facebook/fresco/animation/drawable/AnimatedDrawable2.kt`, `animated-gif-lite/src/main/java/com/facebook/animated/giflite/drawable/GifAnimationBackend.kt`, `drawee/src/main/java/com/facebook/drawee/components/DeferredReleaser.kt`, `drawee/src/main/java/com/facebook/drawee/drawable/ArrayDrawable.kt`, … (+29 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.	0	—
D37 · Vulnerability-disclosure Policy	disclosure	—	disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.	0	—
D40 · Network Egress Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.	0	—
D41 · Kernel & Syscall Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.	0	—
D42 · Runtime Threat Enforcement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.	0	—
D43 · Malicious Dependencies	osv-scanner	—	osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .	0	—

Run 01a16f51-0556-732e-8978-22057ddff75d · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Findings by how serious they are

This survey was produced by

Executive summary

Top priorities

Diagnosis: what the measurements show together

Architecture — module dependency graph

Architecture: which parts of the code depend on which

At a glance — Code Health · 85% · Strong ·

At a glance — Architecture · 96% · Exemplary ·

At a glance — Maturity · 45% · Weak · gated by M2 ·

At a glance — Readiness · 47% · Weak · gated by P3 ·

At a glance — Security · 46% · Weak · gated by D28, D36 ·

At a glance — Performance · 69% · Adequate ·

Security & Compliance — OWASP Top-10 mapping

Roadmap

File quality

How the grades work

Methodology & how to trust this report

Tools & methods

Run transparency — what happened this run

Limitations & what we did not check

Per-dimension blind spots

The LLM boundary

Dimensions

Frontend & cross-cutting dimensions

Reference — by lens

Appendix A — Findings (grouped)

Appendix B — Reproduction & audit trail

Downloadable artifacts