Public report of feathr-ai/feathr, published 26 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 26 October 2026, 06:55 UTC · Survey ID cd_ebf220ed722a4e41b481912bd17fa209

feathr-ai/feathr

Measured 26 October 2026, 06:53 UTC, at code version 45e44af

Regression: 1 dimension fell since the last survey Test reliability: not measuredBus factor: not measured

A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.

Test reliability is not measured: The suite could not be re-run, but the repository declares tests of its own unreliable.

Bus factor is not measured: No living knowledge left to concentrate.

CAI score 51out of 100 At risk No change since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

Architecture 89 Strong Performance 70 Strong Maturity 68 Adequate Security and Compliance 65 Adequate Accessibility 60 Adequate Code Health 49 Weak Production Readiness 44 Weak

A medium codebase: 72,121 lines of product code in 10 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Production Readiness, 44

Findings by how serious they are

145 critical 491 serious 452 minor

15 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
26 October 2026, 06:53 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

81of 81 dimensions measured by tools.
1065of 1088 findings point to an exact file and line, so you can open each one in the code. The other 23 concern the repository as a whole, such as missing documentation.
81dimensions across 7 lenses, read from 72,121 lines of product code in 10 projects.
Chapters

Executive summary

feathr-ai/feathr is rated At risk because critical security findings are open, most of them in the build pipeline. It scores 51 out of 100, which the At risk rating leaves unchanged.

Production Readiness, at 44, is the weakest lens and counts most in the score. The best first step is replacing the three exposed passwords or keys and switching the old ones off, worth about 6 points. Declaring which values may be missing comes next, worth about 3 points. Raising Production Readiness to 70 would lift the score to about 57.

Fifty-two pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Forty-nine known security holes in the packages the code depends on can be used by attackers, and fifteen secrets can leak from the build pipeline. Pinning each tool to an exact version, updating the vulnerable packages and limiting each secret to its own step would close these risks. The six pipeline steps that install packages without pinning their versions need the packages they install pinned to exact versions. The six unsafe settings in infrastructure or container files need changing to safe values. The four tests the project itself marks as unreliable need fixing or deleting.

The product code is 72,121 lines, about €96,000 to rebuild. The check for the health of its packages couldn't finish, so that result is missing, not a clean pass.

Code Health 49 Weak, capped by Structured logging and Nullable reference types Architecture 89 Strong Maturity 68 Adequate, capped by Knowledge Freshness Production Readiness 44 Weak, capped by Outbound HTTP resilience and Schema migrations Security and Compliance 65 Adequate, capped by Static Analysis (SAST), Dependency Vulnerabilities and Supply-chain Provenance & Signing Accessibility 60 Adequate Performance 70 Strong

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 44 · counts for 46%Code Health 49 · counts for 25%Accessibility 60 · counts for 14%Security and Compliance 65 · counts for 8%Maturity 68 · counts for 4%Performance 70 · counts for 2%Architecture 89 · counts for 1%

If Production Readiness rose from 44 to 70, the lowest score rated Strong, the score would rise from 51 to about 57.

Code composition: what the lines of code are
Product code 72%Tests 28%
New since the last survey: 44 findings

These 44 critical or serious findings weren't in the previous survey, on 12 October 2026.

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 12 findings

These 12 critical or serious findings were in the previous survey, on 12 October 2026, and are gone from this one.

  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High vulnerability: REDACTED REDACTED
  • Dependency Vulnerabilities · High vulnerability: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Supply-chain Provenance & Signing REDACTED
  • Supply-chain Provenance & Signing REDACTED
  • Supply-chain Provenance & Signing REDACTED
  • Outbound HTTP resilience · Outbound HTTP without resilience feathr_project/feathr/registry/_feathr_registry_client.py
  • Outbound HTTP resilience · Outbound HTTP without resilience REDACTED
  • Outbound HTTP resilience · Outbound HTTP without resilience registry/access_control/api.py
Rebuild cost: about €96,000 · Estimate
Cost to rebuild€32,000 to €160,000, for 529 to 1,677 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 51. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 72,121 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 3 Leaked secret finding(s) in Secret Scanning — start with REDACTED (3).
Raises the score by about 6 points · Low effort · Secret Scanning
2
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`.
Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.
Raises the score by about 3 points · Medium effort · Nullable reference types
3
Pass `timeout=` on every `requests`/`httpx` call (requests has no default and will wait forever), mount an `HTTPAdapter(max_retries=Retry(...))` on shared sessions, and wrap calls to flaky dependencies in `tenacity` retries or a `pybreaker` circuit breaker.
Raises the score by about 2 points · Medium effort · Outbound HTTP resilience

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €96,000 to build again, about 0.7 person-years of work. Its weakest lens is Production Readiness, at 44 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 3 Leaked secret finding(s) in Secret Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 6 points for low effort, because it clears the 3 Secret Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch :feathr-compute :feathr-compute :feathr-config :feathr-config :feathr-compute->:feathr-config :feathr-data-models :feathr-data-models :feathr-compute->:feathr-data-models :feathr-config->:feathr-data-models :feathr-impl :feathr-impl :feathr-impl->:feathr-compute :feathr-impl->:feathr-config :feathr-impl->:feathr-data-models feathr (Gradle) feathr (Gradle) feathr (Gradle)->:feathr-compute feathr (Gradle)->:feathr-config feathr (Gradle)->:feathr-data-models feathr (Gradle)->:feathr-impl feathr (Python) feathr (Python) feathr-ui feathr-ui

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

221 modules, with 351 dependencies between them. 3 loops run through 28 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 181 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 com.linkedin.feathr.core.config2 com.linkedin.feathr.offline.mvel.plugins3 com.linkedin.feathr.swj.aggregate4 feathr_project.feathr.definition.feathrconfig5 com.linkedin.feathr.core.config.producer.common6 com.linkedin.feathr.offline.config.location7 com.linkedin.feathr.offline.derived8 com.linkedin.feathr.sparkcommon9 com.linkedin.feathr.swj10 feathr_project.feathr.definition.dtype11 com.linkedin.feathr.core.config.producer.anchors12 com.linkedin.feathr.core.config.producer.derivations13 com.linkedin.feathr.offline.source14 com.linkedin.feathr.offline.source.dataloader15 feathr_project.feathr.definition.feature16 com.linkedin.feathr.core.config.producer17 com.linkedin.feathr.offline.anchored.feature18 feathr_project.feathr.definition.feature_derivations19 com.linkedin.feathr.core.configvalidator.typesafe20 com.linkedin.feathr.offline.logical21 feathr_project.feathr.registry22 com.linkedin.feathr.offline.config23 com.linkedin.feathr.offline.anchored.anchorExtractor24 com.linkedin.feathr.offline.util.datetime25 com.linkedin.feathr.offline.source.accessor26 com.linkedin.feathr.offline.swa27 com.linkedin.feathr.offline.util28 com.linkedin.feathr.offline.client29 com.linkedin.feathr.offline.client.FeathrClient30 com.linkedin.feathr.offline.job31 com.linkedin.feathr.offline.generation32 com.linkedin.feathr.offline.transformation33 com.linkedin.feathr.offline34 com.linkedin.feathr.common35 com.linkedin.feathr.offline.graph36 com.linkedin.feathr.offline.derived.strategies37 com.linkedin.feathr.offline.evaluator38 com.linkedin.feathr.offline.join39 com.linkedin.feathr.offline.evaluator.aggregation40 com.linkedin.feathr.offline.join.workflow
1 com.linkedin.feathr.core.config
2 com.linkedin.feathr.offline.mvel.plugins
3 com.linkedin.feathr.swj.aggregate
4 feathr_project.feathr.definition.feathrconfig
5 com.linkedin.feathr.core.config.producer.common1
6 com.linkedin.feathr.offline.config.location9
7 com.linkedin.feathr.offline.derived21
8 com.linkedin.feathr.sparkcommon4
9 com.linkedin.feathr.swj1
10 feathr_project.feathr.definition.dtype1
11 com.linkedin.feathr.core.config.producer.anchors565
12 com.linkedin.feathr.core.config.producer.derivations252
13 com.linkedin.feathr.offline.source1
14 com.linkedin.feathr.offline.source.dataloader3
15 feathr_project.feathr.definition.feature12
16 com.linkedin.feathr.core.config.producer111
17 com.linkedin.feathr.offline.anchored.feature11112
18 feathr_project.feathr.definition.feature_derivations11
19 com.linkedin.feathr.core.configvalidator.typesafe417
20 com.linkedin.feathr.offline.logical2222
21 feathr_project.feathr.registry222
22 com.linkedin.feathr.offline.config322241112
23 com.linkedin.feathr.offline.anchored.anchorExtractor123112
24 com.linkedin.feathr.offline.util.datetime14
25 com.linkedin.feathr.offline.source.accessor113
26 com.linkedin.feathr.offline.swa13215212
27 com.linkedin.feathr.offline.util111121134
28 com.linkedin.feathr.offline.client12122246
29 com.linkedin.feathr.offline.client.FeathrClient11111
30 com.linkedin.feathr.offline.job22243151321427
31 com.linkedin.feathr.offline.generation11454126
32 com.linkedin.feathr.offline.transformation1111232214152
33 com.linkedin.feathr.offline11
34 com.linkedin.feathr.common13
35 com.linkedin.feathr.offline.graph1121112
36 com.linkedin.feathr.offline.derived.strategies55111121
37 com.linkedin.feathr.offline.evaluator1111
38 com.linkedin.feathr.offline.join322111
39 com.linkedin.feathr.offline.evaluator.aggregation1311121
40 com.linkedin.feathr.offline.join.workflow212143
Uses a module listed above itPart of a loopThe module itself
1 com.linkedin.feathr.core.config2 com.linkedin.feathr.offline.mvel.plugins3 com.linkedin.feathr.swj.aggregate4 feathr_project.feathr.definition.feathrconfig5 com.linkedin.feathr.core.config.producer.common6 com.linkedin.feathr.offline.config.location7 com.linkedin.feathr.offline.derived8 com.linkedin.feathr.sparkcommon9 com.linkedin.feathr.swj10 feathr_project.feathr.definition.dtype11 com.linkedin.feathr.core.config.producer.anchors12 com.linkedin.feathr.core.config.producer.derivations13 com.linkedin.feathr.offline.source14 com.linkedin.feathr.offline.source.dataloader15 feathr_project.feathr.definition.feature16 com.linkedin.feathr.core.config.producer17 com.linkedin.feathr.offline.anchored.feature18 feathr_project.feathr.definition.feature_derivations19 com.linkedin.feathr.core.configvalidator.typesafe20 com.linkedin.feathr.offline.logical21 feathr_project.feathr.registry22 com.linkedin.feathr.offline.config23 com.linkedin.feathr.offline.anchored.anchorExtractor24 com.linkedin.feathr.offline.util.datetime25 com.linkedin.feathr.offline.source.accessor26 com.linkedin.feathr.offline.swa27 com.linkedin.feathr.offline.util28 com.linkedin.feathr.offline.client29 com.linkedin.feathr.offline.client.FeathrClient30 com.linkedin.feathr.offline.job31 com.linkedin.feathr.offline.generation32 com.linkedin.feathr.offline.transformation33 com.linkedin.feathr.offline34 com.linkedin.feathr.common35 com.linkedin.feathr.offline.graph36 com.linkedin.feathr.offline.derived.strategies37 com.linkedin.feathr.offline.evaluator38 com.linkedin.feathr.offline.join39 com.linkedin.feathr.offline.evaluator.aggregation40 com.linkedin.feathr.offline.join.workflowcom.linkedin.feathr.core.config1com.linkedin.feathr.offline.mvel.plugins2com.linkedin.feathr.swj.aggregate3feathr_project.feathr.definition.feathrconfig4com.linkedin.feathr.core.config.producer.common5com.linkedin.feathr.offline.config.location6com.linkedin.feathr.offline.derived7com.linkedin.feathr.sparkcommon8com.linkedin.feathr.swj9feathr_project.feathr.definition.dtype10com.linkedin.feathr.core.config.producer.anchors11com.linkedin.feathr.core.config.producer.derivations12com.linkedin.feathr.offline.source13com.linkedin.feathr.offline.source.dataloader14feathr_project.feathr.definition.feature15com.linkedin.feathr.core.config.producer16com.linkedin.feathr.offline.anchored.feature17feathr_project.feathr.definition.feature_derivations18com.linkedin.feathr.core.configvalidator.typesafe19com.linkedin.feathr.offline.logical20feathr_project.feathr.registry21com.linkedin.feathr.offline.config22com.linkedin.feathr.offline.anchored.anchorExtractor23com.linkedin.feathr.offline.util.datetime24com.linkedin.feathr.offline.source.accessor25com.linkedin.feathr.offline.swa26com.linkedin.feathr.offline.util27com.linkedin.feathr.offline.client28com.linkedin.feathr.offline.client.FeathrClient29com.linkedin.feathr.offline.job30com.linkedin.feathr.offline.generation31com.linkedin.feathr.offline.transformation32com.linkedin.feathr.offline33com.linkedin.feathr.common34com.linkedin.feathr.offline.graph35com.linkedin.feathr.offline.derived.strategies36com.linkedin.feathr.offline.evaluator37com.linkedin.feathr.offline.join38com.linkedin.feathr.offline.evaluator.aggregation39com.linkedin.feathr.offline.join.workflow4019214115652521312111111121141722222223222411121231121411313215212111121134121222461111122243151321427114541261111232214152111311211125511112111113221111311121212143+181 more modules (most-connected shown)

At a glance — Code Health · 49% · Weak · gated by X4, X5 ·

The Good
D1 · Scala Cyclomatic Complexity 7.0 D3 · Scala God Classes 8.6 D4 · Scala Code Duplication 9.1 D17 · Scala Explicit Debt 9.8 R1 · React / TS Type Safety 10.0 R10 · React / TS Code Duplication 8.4 R2 · React / TS Cyclomatic Complexity 10.0 R3 · React / TS Large Files 10.0 R7 · React / TS Dead Code 9.7 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0
The Bad
D2 · Scala Cognitive Complexity 6.3 X23 · Repo Unguarded diagnostic materialisation 6.8 X3 · Repo Exception handling 5.4 X30 · Repo Support guard that admits what it rejects 5.4
The Ugly
X18 · Repo Disposal-pattern correctness 4.0 X2 · Repo Cancellation propagation 4.0 X4 · Repo Structured logging 2.9 X5 · Repo Nullable reference types 2.0

At a glance — Architecture · 89% · Strong ·

The Good
D5 · Scala Coupling 10.0 D6 · Scala Cohesion (LCOM4) 10.0 D35 · Scala Change Coupling 10.0 AX10 · Repo Code composition 8.7 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX6 · Repo Interface segregation 9.9 R9 · React / TS Circular Imports 8.1
The Ugly
D26 · Scala Project Cohesion 4.5

At a glance — Maturity · 68% · Adequate · gated by D34 ·

The Good
D15 · Scala Churn × Complexity Hotspots 10.0 D19 · Scala Documentation Quality 10.0 M1 · Repo Documentation (README) 8.0 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0
The Bad
M2 · Repo Architecture documentation 5.0
The Ugly
D20 · Scala ADR Quality 0.0 D34 · Scala Knowledge Freshness 0.0

At a glance — Readiness · 44% · Weak · gated by P7, P8 ·

The Good
D9 · Scala Test Distribution 9.5 D14 · Scala License Compliance 10.0 P1 · Repo CI/CD gates 10.0 P2 · Repo Observability 7.0 P5 · Repo DR & Backup 7.0 R5 · React / TS Dependency Freshness 8.2 R8 · React / TS Dependency Hygiene 8.0
The Bad
D13 · Scala Secret Scanning 5.0 P10 · Repo Library API & versioning 6.0 P4 · Repo Deployment & Rollback 5.0 P6 · Repo Release Hygiene 5.0 R6 · React / TS Tooling 6.7
The Ugly
P3 · Repo Security & performance tooling 4.0 P7 · Repo Outbound HTTP resilience 3.0 P8 · Repo Schema migrations 3.0

At a glance — Security · 65% · Adequate · gated by D29, D30, D36 ·

The Good
D28 · Scala Secrets (history) 8.0 D31 · Scala IaC & Container Security 7.1 D43 · Scala Malicious Dependencies 10.0 D44 · Scala Platform End-of-Life 10.0 S1 · Repo Web-Security Posture 8.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0
The Ugly
D29 · Scala Static Analysis (SAST) 0.0 D30 · Scala Dependency Vulnerabilities 0.0 D36 · Scala Supply-chain Provenance & Signing 2.5

At a glance — Accessibility · 60% · Adequate ·

The Good
AC6 · Repo Visual & motion safety 10.0
The Bad
AC2 · Repo Forms & labels 5.4 AC7 · Repo A11y enforcement 6.0
The Ugly
AC3 · Repo Page structure 4.8

At a glance — Performance · 70% · Strong ·

The Good
PF2 · Repo Allocation hygiene 7.0 PF3 · Repo Async & latency hygiene 7.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection99High / Critical
A03:2025 — Software Supply Chain Failures99High / Critical
A02:2025 — Security Misconfiguration16High / Critical
A07:2025 — Authentication Failures6High / Critical

Roadmap

Immediately resolve the three leaked secrets in Azure resource provisioning to secure credentials. Strengthen code reliability by enabling strict null checking in Scala, enforcing timeouts and retries on all outbound HTTP calls, and replacing ad-hoc database creation with versioned Alembic migrations. Finally, refactor the 133 instances of interpolated logging to support structured data collection.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 3 Leaked secret finding(s) in Secret Scanning — start with REDACTED (3).+5.9 ptsLowSecret Scanning
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.+2.6 ptsMediumNullable reference types
Pass `timeout=` on every `requests`/`httpx` call (requests has no default and will wait forever), mount an `HTTPAdapter(max_retries=Retry(...))` on shared sessions, and wrap calls to flaky dependencies in `tenacity` retries or a `pybreaker` circuit breaker.+2.3 ptsMediumOutbound HTTP resilience
Replace SQLAlchemy create_all() with Alembic (`alembic revision --autogenerate` + `alembic upgrade head`) so the production schema can evolve safely and reproducibly.+2.3 ptsMediumSchema migrations
Interpolated log message defeats structured logging+2.1 ptsMediumStructured logging
Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.+1.5 ptsMediumCancellation propagation
Enable Dependabot/Renovate or a dependency-review gate.+1.5 ptsMediumSecurity & performance tooling
Resolve the 1 No ADRs found finding(s) in ADR Quality.+0.7 ptsLowADR Quality

File quality

Per-file score 0–10 — a quality signature. Of 164 files carrying findings, judged against the Production bar: 9% slop · 45% mixed · 46% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED0.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.9SlopSecret Scanning: Leaked secret: REDACTED
REDACTED1.2SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.4SlopStatic Analysis (SAST): High: REDACTED
REDACTED1.6SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.7SlopIaC & Container Security: High IaC: REDACTED
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedIaC & Container Security: High IaC: REDACTED
REDACTED4.5MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedDependency Vulnerabilities: High CVE: REDACTED
REDACTED5.1MixedIaC & Container Security: High IaC: REDACTED
feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 145

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 491

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 452

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 15

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 81 of 81 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); none rely on LLM judgement. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 81 dimensions across the health lenses
D1D2D3D4D5D6D9D13D14D15D17D19D20D26D28D29D30D31D34D35D36D43D44AC2AC3AC6AC7AX10AX2AX3AX4AX6M1M2M3M4P1P10P2P3P4P5P6P7P8PF2PF3R1R10R2R3R5R6R7R8R9S1X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1065 of 1088 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement—◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a176fc-0238-7bcd-898a-68b44c53e194.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT READ here — but this repository measures it: a coverage step in CI (`pytest -n 6 --cov-report term-missing --cov=feathr_project/f…`) shows that coverage is collected and tracked in your own CI. The built-in collector has no runner for this ecosystem (.py, .scala, .java), so the analyzer could not read the number — a gap in the analyzer's language coverage, not an unmeasured repo. Not scored. To have the real number read, produce a coverage report in a standard format (`coverage run -m pytest` then `coverage xml`, or `addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`, or JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (`coverage run -m pytest` then `coverage xml`, or `addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`, or JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository declares 4 of its own test(s) unreliable. The built-in reliability runner does not support this repository's ecosystem (.py, .scala, .java), so the suite was not re-run and no reliability score is given — these are the repository's own declarations, not our measurement.
  • D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository's dependency manifests WERE read and their pinning discipline assessed; what went unanswered is the currency half, because packages.confluent.io — the registry that answers it — was asked and did not reply (the build stopped because packages.confluent.io, a repository this project declares, refused it with HTTP 403 — what this scan's egress allowlist returns for a host that is not on it, so the dependency graph was not resolved). This is OUR side and it is an ENVIRONMENT fault, not a missing collector: the collector exists and ran. An HTTP 403 here is what this scan's egress allowlist returns for a host that is not on it, so the remedy is to add packages.confluent.io to the allowlist and re-run — not to build anything.
  • D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Python pyproject.toml/requirements.txt (pip/uv/Poetry), but the licence verdict published here was taken over its JVM dependencies. Nothing was read about its Python dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares package.json, but the licence verdict published here was taken over its JVM dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. All 349 significant source file(s) were last meaningfully changed so long ago that no living knowledge remains — nothing since has been substantial enough to re-establish ownership (a broad, mechanical sweep that touches many files shallowly does not count, and neither does no activity at all). There is no concentration to measure, so the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness). Counted over 274 of the 773 production source files in this repository: 424 are under the ~2,400-byte size floor this dimension measures over, and the remaining 75 have no attributable history left to measure.
  • D19 Documentation Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
  • D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: it declares a published package (feathr_project/pyproject.toml), but no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict. For npm the surface is what a published package.json's entry points (exports, main, module, types) export, followed through the source; an entry that names build output the tree does not commit (dist/, build/) is not followed back to source, because only a tsconfig outDir/rootDir pair states that mapping and a bundler's input lives in executable configuration this engine does not evaluate.
  • D24 Comment Value — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureDefinition.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfig.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/TimeWindowFeatureDefinition.scala`, `registry/data-models/models.py`, `registry/data-models/transformation/models.py` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AX1 Captive dependencies — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository defines its own container in feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureDependencyGraph.java, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via REDACTED (REDACTED). docker build failed (exit 1) — -------------------- 2 | 3 | # Stage 1: build frontend ui 4 | >>> FROM node:16-alpine as ui-build 5 | WORKDIR /usr/src/ui 6 | COPY ./ui . -------------------- ERROR: failed to solve: node:16-alpine: failed to resolve source metadata for docker.io/library/node:16-alpine: failed to do request: Head "https://registry-1.docker.io/v2/library/node/manifests/16-alpine": Forbidden; runtime evidence skipped.
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Java, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9). Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • X4 Structured logging — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 93 further occurrence(s) are not listed individually; the score already reflects all 133.

Repo exclusion declarations: 14 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned REDACTED, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity7.0 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.0 / 10 · rule-coverage 100% · ceiling Prevented

30 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SchemaConverters.createConverterToSQL at 39. A further 5 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being RedisOutputUtils.getConversionFunction at 19 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/outputProcessor/RedisOutputUtils.scala (RedisOutputUtils.getConversionFunction at 19). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

SchemaConverters.createConverterToSQL (cyclomatic 39)feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:140
AnchorLoader.deserialize (cyclomatic 34)feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:205
SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cyclomatic 29)feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:75
FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow (cyclomatic 26)feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:309
FeathrClient.materialize_features (cyclomatic 26)feathr_project/feathr/client.py:780

+ 25 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with SchemaConverters.createConverterToSQL (cyclomatic 39), AnchorLoader.deserialize (cyclomatic 34). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 7.0 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.3 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.3 / 10 · rule-coverage 100% · ceiling Prevented

68 method(s) exceeded the cognitive complexity threshold of 15; the worst was SchemaConverters.createConverterToSQL at 75.

models._to_type (cognitive 16) · ×3registry/access_control/rbac/models.py:130
SchemaConverters.createConverterToSQL (cognitive 75)feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:140
dsl_generator.gen_dsl (cognitive 60)feathr_project/feathr/utils/dsl/dsl_generator.py:327
SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cognitive 55)feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:75
FeathrClient.materialize_features (cognitive 54)feathr_project/feathr/client.py:780

+ 61 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 60 down to 60 or less in Cognitive Complexity — start with SchemaConverters.createConverterToSQL (cognitive 75). — Refactoring it lifts Cognitive Complexity from 6.3 to about 6.5/10.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.6 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

25 god class(es) detected.

FunctionTooLong: index.FeatureForm · ×9ui/src/pages/NewFeature/components/FeatureForm/index.tsx:27
FileTooLong: registry/_feature_registry_purview.py · ×8feathr_project/feathr/registry/_feature_registry_purview.py
TooManyMethods: FeatureValue · ×6feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureValue.java:59
MethodTooLong: RedisOutputUtils.getConversionFunction · ×2feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/outputProcessor/RedisOutputUtils.scala:89

What to do

  1. Resolve the 9 FunctionTooLong finding(s) in God Classes — start with index.tsx (7), FlowGraph.tsx, useForm.ts. — One of this dimension's main actionable groups (9 warning-level).
  2. Resolve the 8 FileTooLong finding(s) in God Classes — start with models.py (2), _feature_registry_purview.py, FeatureTransformation.scala. — One of this dimension's main actionable groups (8 warning-level).
  3. Resolve the 6 TooManyMethods finding(s) in God Classes — start with FeatureValue.java, SourceUtils.scala, client.py. — One of this dimension's main actionable groups (6 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.1 / 10Stronggated by 133 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Verified

127 duplicated block group(s) detected. A further 6 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (8 lines × 2) · ×18feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:181
Duplicated block (5 lines × 2) · ×14feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:125
Duplicated block (7 lines × 2) · ×11feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:102
Duplicated block (6 lines × 2) · ×11feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:94
Duplicated block (9 lines × 2) · ×8feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:859

+ 41 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 18 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with models.py (7), SeqJoinAggregator.scala (3), AvroJsonDataLoader.scala. — One of this dimension's main actionable groups (18 warning-level).
  2. Resolve the 14 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with models.py (2), SeqJoinAggregator.scala, FeatureGenJob.scala. — One of this dimension's main actionable groups (14 warning-level).
  3. Resolve the 11 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with SeqJoinAggregator.scala (2), FeatureGroupsUpdater.scala, AggregationNodeEvaluator.scala. — One of this dimension's main actionable groups (11 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

7 production modules (Gradle+npm+Python), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 0 module(s) off the main sequence, with abstractness counted on 6 of the 7 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 61 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D9 · Test Distribution9.5 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Documented

832 test methods: 803 unit, 0 integration, 0 BDD, 29 e2e. The Python suite contributes 111 test function(s) across 34 file(s) declaring at least one — every `def test…` in a file pytest or unittest would collect, which is those frameworks' own definition of a case; a parametrize table counts once, so this is a floor. Its tier split is read from file names and paths only. The Scala suite contributes 448 test case(s) across 72 file(s) in a test source set declaring at least one — every `test("…")`, `it("…")`, `property("…")` and `"…" in {…}` registration and every JUnit `@Test`, which is how munit, ScalaTest, utest, ZIO Test and specs2 declare a case; a case registered under a computed name is not counted, so this is a floor. Its tier split is INFERRED from paths and file names, except sbt's src/it source set, which the build declares.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D13 · Secret Scanning5.0 / 10Adequate✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Prevented

1 secret(s) detected.

REDACTED

What to do

  1. Resolve the 3 Leaked secret finding(s) in Secret Scanning — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
  2. Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 10 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 5 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. ★ COVERAGE OF THIS VERDICT: it grades this repository's JVM dependencies and nothing else. The repository also declares a Python pyproject.toml/requirements.txt (pip/uv/Poetry) and package.json, and the licences of those dependency graphs were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt9.8 / 10Stronggated by 91 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

91 deducted task-comment markers across 72121 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×89ui/src/api/api.tsx:235
HackComment · ×2feathr-impl/src/test/java/com/linkedin/feathr/common/value/TestFeatureValues.java:135

What to do

  1. Resolve the 89 TodoComment finding(s) in Explicit Debt — start with test_job_utils.py (6), _feature_registry_purview.py (5), db_registry.py (3). — One of this dimension's main actionable groups (89 warning-level).
  2. Resolve the 2 HackComment finding(s) in Explicit Debt — start with TestFeatureValues.java, BufferUtils.java. — One of this dimension's main actionable groups (2 warning-level).
  3. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 73 document(s) read across 1 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion4.5 / 10Weak✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 4.5 / 10 · rule-coverage 100% · ceiling Documented

3 of 10 build units (Gradle, Python, npm) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)8.0 / 10Adequategated by 2 critical findings✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Documented

2 finding(s): 0 critical, 2 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 2 High secret finding(s) in Secrets (history) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.0 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

99 finding(s): 0 critical, 79 high, 14 medium, 6 low. 52 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 7 file(s) — `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureDefinition.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfig.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/TimeWindowFeatureDefinition.scala`, `feathr_project/feathr/protobuf/featureValue_pb2.py`, `gradlew` (line 72, line 173), … (+2 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 8 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 12 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (8), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (12 issue-level).
  2. Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4), REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
  3. No action in Static Analysis (SAST) — all 52 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (52 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.0 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

82 finding(s): 6 critical, 43 high, 26 medium, 7 low.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 41 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (40), REDACTED. — One of this dimension's main actionable groups (41 issue-level).
  2. Resolve the 6 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (6). — One of this dimension's main actionable groups (6 issue-level).
  3. Resolve the 2 High vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security7.1 / 10Adequategated by 6 critical findings✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 7.1 / 10 · rule-coverage 100% · ceiling Documented

16 finding(s): 0 critical, 6 high, 8 medium, 2 low.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 6 High IaC finding(s) in IaC & Container Security — start with REDACTED (2), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 8 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (4), REDACTED (2), REDACTED (2). — One of this dimension's main actionable groups (8 warning-level).
  3. Resolve the 2 Low IaC finding(s) in IaC & Container Security — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

349 of 349 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala. Counted over 349 of the 773 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×346feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:1
Most significant orphaned file · ×3feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1
Dormant codebase

What to do

  1. Resolve the 346 Orphaned file finding(s) in Knowledge Freshness — start with index.tsx (11), models.py (6), build.gradle (2). — One of this dimension's main actionable groups (346 recommendation-level).
  2. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with FeatureTransformation.scala, _feature_registry_purview.py, client.py. — One of this dimension's main actionable groups (3 recommendation-level).
  3. Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 7 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
  3. Resolve the 3 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 0 platform declaration(s) and 52 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC2 · Forms & labels5.4 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • This UI-library field component is named only by a placeholder — a placeholder is not a label (it vanishes as soon as the user types, and many assistive technologies ignore it). Give it a real name whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed. — ui/src/pages/Management/components/SearchBar/index.tsx:48

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure4.8 / 10Weak✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. This document's body is only the mount point <div id="root">, so there is no content here to wrap — render the <main> from the component mounted into it. — ui/public/index.html:2

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC6 · Visual & motion safety10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC7 · A11y enforcement6.0 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.

Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.

Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.

  • An a11y linter is configured (Documented) but there's no automated a11y test or CI gate. Add your test runner's axe binding (jest-axe, vitest-axe, cypress-axe or @axe-core/playwright) to verify at runtime, then gate it in CI. What was searched, so you can tell an absence from a miss: the 49 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.

What to do

  • Accessibility linting is already configured — assert with your test runner's axe binding (jest-axe, vitest-axe, cypress-axe or @axe-core/playwright) in tests, then gate axe/pa11y/Lighthouse in CI.
AX10 · Code composition8.7 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `FeatureValueOrBuilder` declares 52 abstract methods: `getBooleanArray`, `getBooleanArrayOrBuilder`, `getBooleanValue`, `getByteArray`, `getByteArrayOrBuilder`, `getDoubleArray`, `getDoubleArrayOrBuilder`, `getDoubleValue`, `getFloatArray`, `getFloatArrayOrBuilder`, `getFloatValue`, `getIntArray`, `getIntArrayOrBuilder`, `getIntValue`, `getLongArray`, `getLongArrayOrBuilder`, `getLongValue`, `getSparseBoolArray`, `getSparseBoolArrayOrBuilder`, `getSparseDoubleArray`, `getSparseDoubleArrayOrBuilder`, `getSparseFloatArray`, `getSparseFloatArrayOrBuilder`, `getSparseIntegerArray`, `getSparseIntegerArrayOrBuilder`, `getSparseLongArray`, `getSparseLongArrayOrBuilder`, `getSparseStringArray`, `getSparseStringArrayOrBuilder`, `getStringArray`, `getStringArrayOrBuilder`, `getStringValue`, `getStringValueBytes`, `hasBooleanArray`, `hasBooleanValue`, `hasByteArray`, `hasDoubleArray`, `hasDoubleValue`, `hasFloatArray`, `hasFloatValue`, and 12 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — feathr-impl/src/main/java/com/linkedin/feathr/common/types/protobuf/FeatureValueOuterClass.java:11

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
M1 · Documentation (README)8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add a README to the 4 of 6 project(s) that lack one — worth up to 1.3 pts.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • 256/330 types (78%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

What to do

  • Keep implementation types off the public surface (Java: package-private (no modifier), or leave its package out of `module-info` exports) so internals can change without breaking consumers.
P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Consider OpenTelemetry tracing/metrics (opentelemetry-java or Micrometer) and a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) for operability.
P3 · Security & performance tooling4.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
P7 · Outbound HTTP resilience3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.

Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.

  • `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×13) — feathr_project/feathr/datasets/utils.py:38, feathr_project/feathr/registry/_feathr_registry_client.py:197, registry/access_control/api.py:18, …
  • `requests.delete(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×2) — feathr_project/feathr/registry/_feathr_registry_client.py:201, registry/access_control/api.py:70
  • `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×7) — feathr_project/feathr/registry/_feathr_registry_client.py:206, REDACTED:101, registry/access_control/api.py:89, …
  • `urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. — REDACTED:96
  • `urllib.request.urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout. (×3) — REDACTED:406, REDACTED:464, feathr_project/feathrcli/cli.py:212

What to do

  • Pass `timeout=` on every `requests`/`httpx` call (requests has no default and will wait forever), mount an `HTTPAdapter(max_retries=Retry(...))` on shared sessions, and wrap calls to flaky dependencies in `tenacity` retries or a `pybreaker` circuit breaker.
P8 · Schema migrations3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether database schema changes go through versioned migrations rather than being auto-created from the model at startup.

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

  • SQLAlchemy create_all() builds the schema from the model at startup and keeps no migration history, so there is no reviewed, repeatable upgrade path for an existing production database — a renamed column is dropped and re-added rather than migrated. Adopt Alembic (`alembic revision --autogenerate` + `alembic upgrade head`), so every schema change is a versioned file applied the same way in every environment. — registry/sql-registry/registry/db_registry.py:78

What to do

  • Replace SQLAlchemy create_all() with Alembic (`alembic revision --autogenerate` + `alembic upgrade head`) so the production schema can evolve safely and reproducibly.
PF2 · Allocation hygiene7.0 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 122 use(s) across 60,997 production line(s) (~2.0/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
  • Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
  • Scala: on hot paths, make small wrappers value classes (extends AnyVal), @specialized generic code over primitives, use primitive collections, and presize builders.
PF3 · Async & latency hygiene7.0 / 10Strong✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • `get_projects` is async and calls requests.get — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs. — registry/access_control/api.py:16
  • `get_project` is async and calls requests.get — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs. — registry/access_control/api.py:23

What to do

  • Python: await the async equivalent (asyncio.sleep, an async HTTP client such as httpx.AsyncClient or aiohttp, asyncio.create_subprocess_exec), or move the blocking call off the loop with `await asyncio.to_thread(...)`; never call asyncio.run inside a coroutine — await the coroutine.
R1 · Type Safety10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

R10 · Code Duplication8.4 / 10Strong✓ Tool-verified

React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.

  • 13 duplicated blocks under ui/src/pages/ have copies in at least two of the sibling directories 403, 404, DataSourceDetails, DataSources, FeatureDetails, Features (+5 more sibling(s) not listed) — 12 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 13 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 13 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 13 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20
  • ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20 · ui/src/pages/Features/components/FeatureTable/index.tsx:21 — the two spans are one implementation copied and then locally edited — 417 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20
  • ui/src/pages/NewFeature/components/FeatureForm/index.tsx:161 · ui/src/pages/NewSource/components/SourceForm/index.tsx:47 — the two spans are one implementation copied and then locally edited — 267 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:161
  • ui/src/pages/DataSources/components/DataSourceTable/index.tsx:136 · ui/src/pages/Features/components/FeatureTable/index.tsx:141 · ui/src/pages/Projects/components/ProjectTable/index.tsx:91 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:136
  • ui/src/pages/DataSourceDetails/index.tsx:32 · ui/src/pages/FeatureDetails/index.tsx:124 — the two spans are one implementation copied and then locally edited — 172 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — ui/src/pages/DataSourceDetails/index.tsx:32
  • ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:99 · ui/src/pages/NewSource/components/SourceForm/useForm.ts:47 — the two spans are one implementation copied and then locally edited — 189 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:99
  • ui/src/pages/FeatureDetails/index.tsx:66 · ui/src/pages/ProjectLineage/index.tsx:26 — the two spans are one implementation copied and then locally edited — 118 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — ui/src/pages/FeatureDetails/index.tsx:66
  • ui/src/pages/FeatureDetails/index.tsx:153 · ui/src/pages/Features/components/NodeDetails/FeatureNodeDetail.tsx:23 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — ui/src/pages/FeatureDetails/index.tsx:153
  • ui/src/pages/NewFeature/components/FeatureForm/index.tsx:38 · ui/src/pages/NewSource/components/SourceForm/index.tsx:31 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:38
  • ui/src/routes/config.tsx:89 · ui/src/routes/config.tsx:106 — all 2 copies are in the same file, and the CITED SPAN is a run of DECLARATIONS inside a construct — the members of a type, or the entries of an object or array literal — with no statement anywhere in it. Do not read this as an extract-a-helper row: nothing here executes, so there is no call site, and a call expression cannot stand where a member declaration or a literal's entry was. What repeats is a SHAPE, and which shape decides the move. Where the copies declare the same members, the repetition is a missing common ancestor: give it a base type, an interface both extend, a generic instantiated twice, or — where the copies are a literal's entries rather than a type's members — one shared constant each site spreads or refers to, so the set is written once. Where they declare DIFFERENT members and only the form is shared — a decorator and its options, an annotation, a registration table's keys — the form is prescribed by a framework or a schema rather than copied, and the only collapse available is to generate the declarations from that schema; where you do not own the generator, this is the cost of the framework and there is nothing to extract. Check which of the two it is before acting: these copies still drift apart the first time only one of them is edited, which is why the repetition is reported, but the sentence to act on is not the same in both cases. — ui/src/routes/config.tsx:89
  • ui/src/components/AddTags/index.tsx:168 · ui/src/components/AddTags/index.tsx:181 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — ui/src/components/AddTags/index.tsx:168
  • ui/src/pages/DataSources/components/DataSourceTable/index.tsx:158 · ui/src/pages/Features/components/FeatureTable/index.tsx:164 · ui/src/pages/Management/components/UserRolesTable/index.tsx:175 · ui/src/pages/Projects/components/ProjectTable/index.tsx:115 — the 4 copies are spread across 4 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:158
  • ui/src/pages/NewFeature/components/FeatureForm/index.tsx:14 · ui/src/pages/NewSource/components/SourceForm/index.tsx:14 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:14
  • ui/src/pages/NewFeature/index.tsx:9 · ui/src/pages/NewSource/index.tsx:9 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — ui/src/pages/NewFeature/index.tsx:9
  • ui/src/pages/FeatureDetails/index.tsx:29 · ui/src/pages/FeatureDetails/index.tsx:51 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — ui/src/pages/FeatureDetails/index.tsx:29
  • ui/src/api/api.tsx:29 · ui/src/api/api.tsx:75 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — ui/src/api/api.tsx:29
  • ui/src/pages/NewFeature/components/FeatureForm/index.tsx:91 · ui/src/pages/NewSource/components/SourceForm/index.tsx:131 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:91

What to do

  • Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
R2 · Cyclomatic Complexity10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

R3 · Large Files10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

R5 · Dependency Freshness8.2 / 10Strong✓ Tool-verified

React / JS · Readiness — How outdated the npm dependencies are (a maturity signal). JS/npm CVEs are scored separately in D30 (JS/npm Dependency Vulnerabilities).

Method: npm dependency staleness from manifest/registry metadata (a maturity signal; JS/npm CVEs are scored separately in D30, which answers dependency vulnerabilities for every ecosystem). Deterministic.

What to do

  • Bump outdated dependencies to current versions to limit upgrade debt.
R6 · Tooling6.7 / 10Adequate✓ Tool-verified

React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.

Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.

  • test ✓ · lint ✓ · typecheck ✗ — read from this repository's package.json scripts and corroborated against its CI workflows. A script counts when its name or command matches the step: `test` for the suite, `lint` or `prettier` for linting, `typecheck`/`type-check`/`tsc` for type checking. ✗ therefore means no script or CI step under those names was found, NOT that the step is absent from your pipeline — a task invoked by a runner this check does not read, or named something else entirely, is not seen and is worth confirming before acting on a cross. A ✓ means the wiring is DECLARED — a script or CI step under those names exists. It is not a statement that the step passes, or that it runs at all: nothing here installs a dependency or executes a suite.

What to do

  • Add `tsc --noEmit` as package.json scripts and run them in CI.
R7 · Dead Code9.7 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

  • Unreachable from the 1 application, 3 tooling and 0 test entry point(s) detected in this repo. Gate removals on `npm run build` — an undetected custom entry would make these reachable.
  • no import path from any entry point (1 application, 3 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make (×2) — ui/src/components/HeaderBar/index.ts, ui/src/components/SiderMenu/index.ts
  • Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/api/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/api/index.ts in the same commit, or the barrel will import a name that no longer exists. (×4) — ui/src/api/api.tsx:112, ui/src/api/api.tsx:120, ui/src/api/api.tsx:139, …
  • Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/hooks/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/hooks/index.ts in the same commit, or the barrel will import a name that no longer exists. (×2) — ui/src/hooks/useForceUpdate.ts:3, ui/src/hooks/useFullScreen.ts:3

What to do

  • Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
R8 · Dependency Hygiene8.0 / 10Strong✓ Tool-verified

React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.

Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.

  • Declared in ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it. (×3)

What to do

  • Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
R9 · Circular Imports8.1 / 10Strong✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

  • ui/src/api/api.tsx → ui/src/store/index.ts → ui/src/store/globalStore.ts → ui/src/api/index.ts → ui/src/api/api.tsx — ui/src/api/api.tsx:13

What to do

  • Break each cycle by extracting the shared piece into a module both sides can import.
S1 · Web-Security Posture8.0 / 10Strong✓ Tool-verified

Other · Security — Only what this repository's own non-C# files could be read for was assessed — and because this repository commits the configuration that serves its own HTTP surface, that configuration could be read in full for the security response headers it sets. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `nginx.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.) — deploy/nginx.conf:8

What to do

  • Set security response headers on the surface this repository serves: an `add_header` directive per header in the nginx/Caddy/Apache config, a `_headers` / `vercel.json` / `netlify.toml` entry for a static host, or `helmet()` in the HTTP server. `Content-Security-Policy` is the one that pays for itself first — it is what contains an injected script once one reaches the page — followed by `X-Content-Type-Options: nosniff` and a frame policy (`X-Frame-Options: DENY`, or CSP `frame-ancestors`). Where the app is served from a build container, the header configuration belongs in the image beside the built assets, so it ships with them rather than depending on where it lands.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.mkString` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. (×3) — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:771, feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:798, feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/datasource/DataSourceConfigUtils.scala:20
  • `Source.fromResource(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `source`, and every later use of `source` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromResource(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:108

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/9 async functions that make a cancellable request (fetch, axios, ky, ofetch) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
  • `createFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`. — ui/src/api/api.tsx:112
  • `updateFeature` awaits `axios.put(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.put(url, { signal })`. — ui/src/api/api.tsx:120
  • `addUserRole` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`. — ui/src/api/api.tsx:148
  • `deleteUserRole` awaits `axios.delete(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.delete(url, { signal })`. — ui/src/api/api.tsx:164
  • `deleteEntity` awaits `axios.delete(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.delete(url, { signal })`. — ui/src/api/api.tsx:241
  • `getDependent` awaits `axios.get(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.get(url, { signal })`. — ui/src/api/api.tsx:246
  • `createAnchorFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`. — ui/src/api/api.tsx:253
  • `createDerivedFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`. — ui/src/api/api.tsx:266
  • `createSource` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`. — ui/src/api/api.tsx:275

What to do

  • Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation6.8 / 10Adequate✓ Tool-verified

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

  • `debug` at line 205 is called with an argument built by `json.dumps(body, indent = 2)` (line 205), whose cost grows with the collection it walks. Python evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isEnabledFor(logging.DEBUG)` test, no debug flag, no `lambda` the logger calls only when the level is on. — feathr_project/feathr/registry/_feathr_registry_client.py:205
  • `trace` at line 249 is called with an argument built by `rightJoinColumns.mkString("…")` (line 249), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because trace is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:249
  • `trace` at line 260 is called with an argument built by `rightJoinColumns.mkString("…")` (line 260), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because trace is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:260
  • `debug` at line 115 is called with an argument built by `pathList.mkString("…")` (line 115), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:115

What to do

  • In Python, put the construction behind the logger's own check (`if logger.isEnabledFor(logging.DEBUG):`), or pass the collection itself with a `%s` placeholder (`logger.debug("Items %s", items)`) so the logging module renders it only when the record is emitted. The placeholder alone is not the fix when the argument is still built first: it defers the formatting, not a `json.dumps`, a `join` or a comprehension in the argument, and an f-string defers nothing at all. In Scala, put the construction behind the logger's own check (`if (log.isDebugEnabled)`), or log through a logger that takes the message by name or by macro and so builds it only when the level is on — scala-logging's `LazyLogging`/`StrictLogging` (`logger.debug(s"rows: ${rows.mkString(", ")}")` expands to that check), log4s or log4cats. Interpolating into an `s"…"` is not the fix on SLF4J or Akka's `LoggingAdapter`: their `debug` takes a `String`, so the interpolation and every `mkString` inside it run before the call is entered.
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for` comprehension or `foreach` leaves the mutable collection it is walking alone — an `ArrayBuffer` or `ListBuffer` counts its changes and its iterator checks the count, an `ArrayDeque` (and `mutable.Queue`/`mutable.Stack`) is walked by index up to its starting length, and a `java.util` collection walked through `asScala` is fail-fast, so a body that adds to or removes from the very collection the loop is walking makes a later step throw `ConcurrentModificationException` (`IndexOutOfBoundsException` for a deque) and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×8) — ui/src/store/globalStore.ts:68, ui/src/pages/ProjectLineage/index.tsx:47, ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:92, …
  • `except` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — feathr_project/feathr/utils/job_utils.py:241, REDACTED:359
  • `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×5) — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/CmdLineParser.scala:59, feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:987, feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:134, …
  • `case e: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:710

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

  • `!(nonBucketedFeatures.size != transformer.features || transformer.features.isEmpty)` does not say what its shape suggests. By De Morgan a negated `||` distributes as `!transformer.features.isEmpty && nonBucketedFeatures.size == transformer.features`, so this guard fires only where `transformer.features.isEmpty` is ABSENT — and where `nonBucketedFeatures.size` is EXACTLY `transformer.features`, which is the one value the term `nonBucketedFeatures.size != transformer.features` was written to refuse. The two halves disagree about what they are for: `transformer.features.isEmpty` names something the code needs, and `nonBucketedFeatures.size != transformer.features` names a value it cannot handle, and one `!(…)` cannot mean both. Everything with a `nonBucketedFeatures.size` other than `transformer.features` now passes this guard untested, including the values `transformer.features.isEmpty` was there to admit. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:212

What to do

  • Each finding expands the condition by De Morgan and names the two terms that disagree — a capability the body needs, and a value the guard refuses. Confirm from the expansion, then decide where the parentheses belong. Almost always the fault term was meant to be conjoined with the capabilities rather than listed beside them: `!((a || b) && x == k)` rejects anything that is neither a nor b, AND anything whose x is not k, which is what a support guard is for. Leaving it as written is the one arrangement that admits exactly the values the guard names.
X4 · Structured logging2.9 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `warning` at line 102 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog. — registry/sql-registry/registry/database.py:102
  • `debug` at line 135 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog. — registry/sql-registry/registry/database.py:135
  • `warning` at line 182 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog. — registry/sql-registry/registry/database.py:182
  • `debug` at line 85 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/auth.py:85
  • `info` at line 89 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/auth.py:89
  • `debug` at line 70 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/database.py:70
  • `warning` at line 136 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/database.py:136
  • `info` at line 38 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:38
  • `warning` at line 103 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:103
  • `info` at line 112 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:112
  • `info` at line 128 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:128
  • `warning` at line 147 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:147
  • `info` at line 162 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — registry/access_control/rbac/db_rbac.py:162
  • `info` at line 115 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — feathr_project/feathr/registry/_feathr_registry_client.py:115
  • `info` at line 32 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — feathr_project/feathr/datasets/utils.py:32
  • `info` at line 40 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog. — feathr_project/feathr/datasets/utils.py:40
  • `info` at line 72 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/AclCheckUtils.scala:72
  • `info` at line 79 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/AclCheckUtils.scala:79
  • `warn` at line 147 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:147
  • `info` at line 212 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:212
  • `info` at line 216 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:216
  • `info` at line 338 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:338
  • `info` at line 342 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:342
  • `info` at line 457 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:457
  • `info` at line 593 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:593
  • `info` at line 608 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:608
  • `info` at line 623 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:623
  • `info` at line 999 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:999
  • `info` at line 156 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. (×2) — feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:156, feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowFeatureUtils.scala:156
  • `warn` at line 180 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:180
  • `warn` at line 215 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:215
  • `info` at line 76 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/BatchDataLoader.scala:76
  • `info` at line 112 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/BatchDataLoader.scala:112
  • `info` at line 21 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/BatchDataLoaderFactory.scala:21
  • `debug` at line 44 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:44
  • `debug` at line 46 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:46
  • `debug` at line 53 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:53
  • `info` at line 16 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/JDBCDataLoaderFactory.scala:16
  • `info` at line 25 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/LocalDataLoaderFactory.scala:25

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Scala's null is held to the type system and not undermined by assertions — a file compiled with `-Yexplicit-nulls` is one where `String` excludes null and `String | Null` admits it, a file under WartRemover's `Null` wart or Scalafix's `DisableSyntax.noNulls` is one whose code cannot write `null` and must say `Option`, and each `.nn`, `import scala.language.unsafeNulls` or null-lint suppression is the author overruling that.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • No build over this repository's 290 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.

What to do

  • On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.

WCAG coverage — what static analysis assessed

Statically assessed 10 of 55 WCAG 2.2 Level A/AA success criteria (18%; ≈20% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 45 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only
AC7 · A11y enforcementenforcement — no page criterionEnforcement posture (process)

Not statically assessed — these 45 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.1, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health49%Weak — gated by X4, X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture89%StrongStrongest area.
Maturity68%Adequate — gated by D34Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness44%Weak — gated by P7, P8Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security65%Adequate — gated by D29, D30, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility60%AdequateAcceptable, with room to improve.
Performance70%StrongSolid.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • D11 Test Reliability — 4 observation(s) recorded · This repository declares 4 of its own test(s) unreliable. The built-in reliability runner does not support this repository's ecosystem (.py, .scala, .java), so the suite was not re-run and no reliability score is given — these are the repository's own declarations, not our measurement.
  • X10 Duplicated predicate — 21 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
Not included — 46 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No image/media element found in the parsed markup — AC1 not applicable here.
  • AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
  • AC5 ARIA correctness — No ARIA usage found in the parsed markup — AC5 not applicable here.
  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — docker build failed (exit 1) — -------------------- 2 | 3 | # Stage 1: build frontend ui 4 | >>> FROM node:16-alpine as ui-build 5 | WORKDIR /usr/src/ui 6 | COPY ./ui . -------------------- ERROR: failed to solve: node:16-alpine: failed to resolve source metadata for docker.io/library/node:16-alpine: failed to do request: Head "https://registry-1.docker.io/v2/library/node/manifests/16-alpine": Forbidden; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~28422 lines of test source are present (.py, .scala, .java) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D12 Dependency Hygiene — Dependency currency not established — packages.confluent.io did not answer
  • D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D21 Naming Consistency — Naming consistency is measured on C# only; Java, Python, Scala, TypeScript not measured.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C# and Visual Basic comments only — this repository's production source is .java, .py, .scala, .ts, .tsx, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — D27 reads resolved call sites in the languages it reads only — this repository's production source is .java, .py, .ts, .tsx, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D32 Data Compliance (PII/GDPR) — 5 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 signals for this style, 2 needed — the count is met but a required primary signal is absent): 10 aggregate root(s) (types guarding their own state behind command methods — this language has no AggregateRoot base to inherit); 65 value object(s)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
  • R4 Test Coverage — the JS/TS workspace (62 production file(s)) has no JavaScript/TypeScript test, but it is 6.06% of this repository's production source and the other 93.94% carries 28,422 line(s) of test code this pass cannot read — an incidental frontend's reachability is not the repository's test posture, so it is not scored as one
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 145 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 27 more in this group — see findings.md.
D30 · Dependency Vulnerabilities · High CVE · ×41
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 16 more in this group — see findings.md.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D31 · IaC & Container Security · High IaC · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D11 · Test Reliability · Test declared unreliable · ×4
  • Test declared unreliable: test_feathr_online_store_agg_features feathr_project/test/test_azure_snowflake_e2e.py:17 — This test is disabled or skipped with a reason naming unreliability — the repository's own words: "All snowflake tests are skipped for now due to budget restriction.". A test that is skipped for flakiness is neither passing nor protecting the code it covers; either stabilise it or delete it, but do not leave it disabled indefinitely. (Found by reading the repository's own test source — the suite itself was not re-run, since the reliability runner does not support this ecosystem.)
  • Test declared unreliable: test_feathr_get_offline_features feathr_project/test/test_azure_snowflake_e2e.py:59 — This test is disabled or skipped with a reason naming unreliability — the repository's own words: "All snowflake tests are skipped for now due to budget restriction.". A test that is skipped for flakiness is neither passing nor protecting the code it covers; either stabilise it or delete it, but do not leave it disabled indefinitely. (Found by reading the repository's own test source — the suite itself was not re-run, since the reliability runner does not support this ecosystem.)
  • Test declared unreliable: test_client_get_snowflake_observation_path feathr_project/test/test_azure_snowflake_e2e.py:111 — This test is disabled or skipped with a reason naming unreliability — the repository's own words: "All snowflake tests are skipped for now due to budget restriction.". A test that is skipped for flakiness is neither passing nor protecting the code it covers; either stabilise it or delete it, but do not leave it disabled indefinitely. (Found by reading the repository's own test source — the suite itself was not re-run, since the reliability runner does not support this ecosystem.)
  • Test declared unreliable: test_feathr_get_offline_features_from_snowflake feathr_project/test/test_pyduf_preprocessing_e2e.py:450 — This test is disabled or skipped with a reason naming unreliability — the repository's own words: "All snowflake tests are skipped for now due to budget restriction.". A test that is skipped for flakiness is neither passing nor protecting the code it covers; either stabilise it or delete it, but do not leave it disabled indefinitely. (Found by reading the repository's own test source — the suite itself was not re-run, since the reliability runner does not support this ecosystem.)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D13 · Secret Scanning · Leaked secret · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · High secret · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High vulnerability · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing REDACTED · ×1
  • REDACTED
R9 · Circular Imports · Import cycle (4 files) · ×1
  • Import cycle (4 files) ui/src/api/api.tsx:13 — ui/src/api/api.tsx → ui/src/store/index.ts → ui/src/store/globalStore.ts → ui/src/api/index.ts → ui/src/api/api.tsx
Serious — 491 finding(s)
D17 · Explicit Debt · TodoComment · ×89
  • TodoComment ui/src/api/api.tsx:235 — //TODO: handle other response errors — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment registry/sql-registry/registry/db_registry.py:525 — # TODO: More detailed error — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment registry/sql-registry/registry/db_registry.py:538 — # TODO: More detailed error — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment registry/sql-registry/registry/db_registry.py:568 — # TODO: might not be a safe solution since it's not transactional — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment registry/access_control/rbac/access.py:85 — # TODO: Update purview project-ids API to realtime one and remove below patch. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment registry/access_control/rbac/database.py:8 — # TODO: refactor common utils in registry folder — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:76 — # TODO upgrade the version once pyspark publishes new release to resolve `AttributeError: module 'numpy' has no attribute 'bool'` — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:104 — # TODO: This has been depricated — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/test_secrets_read.py:29 — # TODO: need to test get_environment_variable() as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:1 — # TODO with, without optional args — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:2 — # TODO test with no data files exception and unsupported format exception — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:170 — # TODO add a header to the csv file and change expected_count to 5 after fixing the bug https://github.com/feathr-ai/feathr/issues/811
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:196 — # TODO currently pass the delta table test on Synapse result due to the delta table package bug. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:281 — # TODO currently pass the delta table test on Synapse result due to the delta table package bug. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/test/unit/utils/test_job_utils.py:217 — # ), # TODO add a header to the csv file and change expected_count = 5 after fixing the bug https://github.com/feathr-ai/feathr/issues/811
  • TodoComment feathr_project/test/unit/datasets/test_datasets.py:43 — # TODO check this is called w/ file extension added — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/feathr/constants.py:21 — # TODO: change the name from feathr_workspace_ to feathr_project_ — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/feathr/utils/job_utils.py:114 — # TODO Loading Synapse Delta table result into pandas has a bug: https://github.com/delta-io/delta-rs/issues/582
  • TodoComment feathr_project/feathr/utils/job_utils.py:243 — # TODO: support loading other formats files — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/feathr/udf/feathr_pyspark_driver_template.py:66 — # TODO: Add data handler support here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:219 — # TODO we should fail fast -- maybe check this in config verification while initializing the client. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:229 — # TODO: find a proper way deal with unresolved dependencies — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/feathr/spark_provider/_localspark_submission.py:298 — # TODO: automate this process, e.g. read from pom.xml — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment feathr_project/feathr/spark_provider/_localspark_submission.py:299 — # TODO: dynamical modularization: add package only when it's used in the job, e.g. data source dependencies. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment REDACTED:496 — # TODO: add handling for only tar_dir_client or tar_dir_path is provided — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `# REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 64 more in this group — see findings.md.
D30 · Dependency Vulnerabilities · Medium CVE · ×26
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 1 more in this group — see findings.md.
P7 · Outbound HTTP resilience · Outbound HTTP without resilience · ×26
  • Outbound HTTP without resilience feathr_project/feathr/datasets/utils.py:38 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience feathr_project/feathr/registry/_feathr_registry_client.py:197 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience feathr_project/feathr/registry/_feathr_registry_client.py:201 — `requests.delete(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience feathr_project/feathr/registry/_feathr_registry_client.py:206 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:96 — `urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:101 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:406 — `urllib.request.urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience REDACTED:464 — `urllib.request.urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience feathr_project/feathrcli/cli.py:212 — `urllib.request.urlopen(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:18 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:24 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:31 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:38 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:45 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:52 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:59 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:70 — `requests.delete(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:77 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:89 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:96 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:103 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:110 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/api.py:117 — `requests.post(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/rbac/access.py:104 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • Outbound HTTP without resilience registry/access_control/rbac/auth.py:119 — `requests.get(` makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service's request, thread or connection until the call gives up on its own — or never, for a client with no default timeout.
  • + 1 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×18
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:181 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:181-188 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:365-372 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:181` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:193 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:193-200 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:377-384 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:193` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89-96 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:685-692 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:98 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:98-105 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:757-764 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/CsvDataLoader.scala:98` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:22 — feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:22-29 | feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/SumAggregate.scala:20-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:22` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:29 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:29-36 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:187-194 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/OperationalConfigBuilder.java:53 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/OperationalConfigBuilder.java:53-60 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/OperationalConfigBuilder.java:47-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `OfflineOperationalConfig` names `com.linkedin.feathr.common.configObj.generation.OfflineOperationalConfig` in one and `com.linkedin.feathr.core.config.generation.OfflineOperationalConfig` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java:51 — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java:51-58 | feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExpressionBasedFeatureConfig.java:49-56 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java` and `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExpressionBasedFeatureConfig.java` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java:51` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:800 — registry/purview-registry/registry/models.py:800-807 | registry/sql-registry/registry/models.py:755-762 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) feathr_project/feathr/definition/sink.py:275 — feathr_project/feathr/definition/sink.py:275-282 | feathr_project/feathr/definition/source.py:546-553 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (8 lines × 2) feathr_project/feathr/registry/_feathr_registry_client.py:373 — feathr_project/feathr/registry/_feathr_registry_client.py:373-380 | feathr_project/feathr/registry/registry_utils.py:178-185 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (8 lines × 2) registry/access_control/rbac/database.py:48 — registry/access_control/rbac/database.py:48-56 | registry/sql-registry/registry/database.py:114-121 — before extracting anything, compare `registry/access_control/rbac/database.py` and `registry/sql-registry/registry/database.py` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:204 — registry/purview-registry/registry/models.py:204-211 | registry/sql-registry/registry/models.py:195-202 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:245 — registry/purview-registry/registry/models.py:245-252 | registry/sql-registry/registry/models.py:236-243 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:337 — registry/purview-registry/registry/models.py:337-344 | registry/sql-registry/registry/models.py:328-335 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:516 — registry/purview-registry/registry/models.py:516-523 | registry/sql-registry/registry/models.py:483-490 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:597 — registry/purview-registry/registry/models.py:597-604 | registry/sql-registry/registry/models.py:562-569 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) registry/purview-registry/registry/models.py:810 — registry/purview-registry/registry/models.py:810-817 | registry/sql-registry/registry/models.py:765-772 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×14
  • Duplicated block (5 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:125 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:125-129 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:319-323 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:125` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:38 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:38-42 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:263-267 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:44` calls `OptionParam` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:269` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) feathr-compute/src/main/java/com/linkedin/feathr/compute/ComputeGraphs.java:254 — feathr-compute/src/main/java/com/linkedin/feathr/compute/ComputeGraphs.java:254-260 | feathr-compute/src/main/java/com/linkedin/feathr/compute/ComputeGraphs.java:475-479 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-compute/src/main/java/com/linkedin/feathr/compute/ComputeGraphs.java:254` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) feathr-compute/src/main/java/com/linkedin/feathr/compute/Resolver.java:143 — feathr-compute/src/main/java/com/linkedin/feathr/compute/Resolver.java:143-148 | feathr-compute/src/main/java/com/linkedin/feathr/compute/Resolver.java:233-237 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExprConverter.java:57 — feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExprConverter.java:57-61 | feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExtractorConverter.java:51-55 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:67 — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:67-71 | feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/SimpleFeatureConfig.java:69-73 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java` and `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/SimpleFeatureConfig.java` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:67` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java:35 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java:35-39 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/DateTimeConfigBuilder.java:34-38 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/DateTimeConfigBuilder.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: `DateTimeConfig` names `com.linkedin.feathr.common.configObj.DateTimeConfig` in one and `com.linkedin.feathr.core.config.common.DateTimeConfig` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java:117 — feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java:117-121 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/DateTimeConfig.java:74-78 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/DateTimeConfig.java` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/OperationalConfigBuilder.java:39 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/OperationalConfigBuilder.java:39-43 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/OperationalConfigBuilder.java:37-41 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `OperationalConfig` names `com.linkedin.feathr.common.configObj.generation.OperationalConfig` in one and `com.linkedin.feathr.core.config.generation.OperationalConfig` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:734 — feathr_project/feathr/registry/_feature_registry_purview.py:734-738 | feathr_project/feathr/registry/_feature_registry_purview.py:823-827 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feature_registry_purview.py:734` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `s` to `FeatureAnchor` in one and `DerivedFeature` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) registry/access_control/rbac/database.py:149 — registry/access_control/rbac/database.py:149-153 | registry/sql-registry/registry/database.py:198-202 — before extracting anything, compare `registry/access_control/rbac/database.py` and `registry/sql-registry/registry/database.py` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) registry/purview-registry/registry/models.py:174 — registry/purview-registry/registry/models.py:174-178 | registry/sql-registry/registry/models.py:165-169 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) registry/purview-registry/registry/models.py:181 — registry/purview-registry/registry/models.py:181-185 | registry/sql-registry/registry/models.py:172-176 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (5 lines × 2) registry/sql-registry/registry/db_registry.py:67 — registry/sql-registry/registry/db_registry.py:67-71 | registry/sql-registry/registry/db_registry.py:73-77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `registry/sql-registry/registry/db_registry.py:67` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×11
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:102 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:102-108 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:147-153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:216 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:216-222 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:400-406 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:420 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:420-426 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:604-610 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:420` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/aggregation/AggregationNodeEvaluator.scala:80 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/aggregation/AggregationNodeEvaluator.scala:80-86 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowFeatureUtils.scala:192-198 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/aggregation/AggregationNodeEvaluator.scala:80` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowFeatureUtils.scala:191` calls `CountDistinctAggregate` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/aggregation/AggregationNodeEvaluator.scala:79` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:109 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:109-115 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:121-127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:109` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MaxPooling.scala:153 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MaxPooling.scala:153-159 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MinPooling.scala:153-159 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MaxPooling.scala:153` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:110 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:110-116 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:962-968 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/AnchorToDataSourceMapper.scala:43 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/AnchorToDataSourceMapper.scala:43-49 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/AnchorToDataSourceMapper.scala:178-186 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/AnchorToDataSourceMapper.scala:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:52 — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:52-58 | feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/SimpleFeatureConfig.java:54-60 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java` and `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/SimpleFeatureConfig.java` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:52` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (7 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:125 — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:125-131 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:124-130 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) registry/purview-registry/registry/models.py:391 — registry/purview-registry/registry/models.py:391-397 | registry/sql-registry/registry/models.py:375-381 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×11
  • Duplicated block (6 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:94 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:94-99 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/sources/FeatureGroupsUpdater.scala:131-136 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java:41 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java:41-46 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/DateTimeConfigBuilder.java:40-45 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/DateTimeConfigBuilder.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/DateTimeConfigBuilder.java:41` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: `DateTimeConfig` names `com.linkedin.feathr.common.configObj.DateTimeConfig` in one and `com.linkedin.feathr.core.config.common.DateTimeConfig` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:345 — feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:345-350 | feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:378-384 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:345` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) feathr_project/feathr/definition/sink.py:192 — feathr_project/feathr/definition/sink.py:192-197 | feathr_project/feathr/definition/source.py:301-306 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/purview_registry.py:372 — registry/purview-registry/registry/purview_registry.py:372-377 | registry/purview-registry/registry/purview_registry.py:436-441 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `registry/purview-registry/registry/purview_registry.py:372` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `definition` to `AnchorDef` in one and `DerivedFeatureDef` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) feathr_project/feathr/definition/sink.py:267 — feathr_project/feathr/definition/sink.py:267-272 | feathr_project/feathr/definition/source.py:556-561 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/models.py:237 — registry/purview-registry/registry/models.py:237-242 | registry/sql-registry/registry/models.py:228-233 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note what the matched lines are: every one of them assigns one field to another, so the block is a hand-written mapper between two data shapes rather than behaviour with a helper inside it. Extracting one shared function only works if both sites map the SAME pair of types in the same direction — check that first, because inverse or differently-typed mappers have no single function they can both call. Where they do not, the moves that exist are a generated or reflective mapper, a common embedded/base type the fields live on once, or accepting the run and covering it with a test that fails when a field is added to one side only.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/models.py:292 — registry/purview-registry/registry/models.py:292-297 | registry/sql-registry/registry/models.py:283-288 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/models.py:564 — registry/purview-registry/registry/models.py:564-569 | registry/sql-registry/registry/models.py:529-534 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/models.py:774 — registry/purview-registry/registry/models.py:774-779 | registry/sql-registry/registry/models.py:729-734 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) registry/purview-registry/registry/models.py:782 — registry/purview-registry/registry/models.py:782-787 | registry/sql-registry/registry/models.py:737-742 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D3 · God Classes · FunctionTooLong · ×9
  • FunctionTooLong: index.FeatureForm ui/src/pages/NewFeature/components/FeatureForm/index.tsx:27 — FunctionTooLong — FeatureForm runs 188 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 88 over it, 1.88× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.AddTags ui/src/components/AddTags/index.tsx:24 — FunctionTooLong — AddTags runs 132 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 32 over it, 1.32× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.Home ui/src/pages/Home/index.tsx:42 — FunctionTooLong — Home runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: FlowGraph.FlowGraph ui/src/components/FlowGraph/FlowGraph.tsx:46 — FunctionTooLong — FlowGraph runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.FeatureTable ui/src/pages/Features/components/FeatureTable/index.tsx:16 — FunctionTooLong — FeatureTable runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.SourceForm ui/src/pages/NewSource/components/SourceForm/index.tsx:27 — FunctionTooLong — SourceForm runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: useForm.useForm ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:38 — FunctionTooLong — useForm runs 111 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 11 over it, 1.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.DataSourceTable ui/src/pages/DataSources/components/DataSourceTable/index.tsx:15 — FunctionTooLong — DataSourceTable runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: index.UserRolesTable ui/src/pages/Management/components/UserRolesTable/index.tsx:29 — FunctionTooLong — UserRolesTable runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
X2 · Cancellation propagation · Async function without AbortSignal · ×9
  • Async function without AbortSignal: createFeature ui/src/api/api.tsx:112 — `createFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`.
  • Async function without AbortSignal: updateFeature ui/src/api/api.tsx:120 — `updateFeature` awaits `axios.put(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.put(url, { signal })`.
  • Async function without AbortSignal: addUserRole ui/src/api/api.tsx:148 — `addUserRole` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`.
  • Async function without AbortSignal: deleteUserRole ui/src/api/api.tsx:164 — `deleteUserRole` awaits `axios.delete(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.delete(url, { signal })`.
  • Async function without AbortSignal: deleteEntity ui/src/api/api.tsx:241 — `deleteEntity` awaits `axios.delete(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.delete(url, { signal })`.
  • Async function without AbortSignal: getDependent ui/src/api/api.tsx:246 — `getDependent` awaits `axios.get(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.get(url, { signal })`.
  • Async function without AbortSignal: createAnchorFeature ui/src/api/api.tsx:253 — `createAnchorFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`.
  • Async function without AbortSignal: createDerivedFeature ui/src/api/api.tsx:266 — `createDerivedFeature` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`.
  • Async function without AbortSignal: createSource ui/src/api/api.tsx:275 — `createSource` awaits `axios.post(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `axios.post(url, { signal })`.
D3 · God Classes · FileTooLong · ×8
  • FileTooLong: registry/_feature_registry_purview.py feathr_project/feathr/registry/_feature_registry_purview.py — FileTooLong — 936 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 436 over it, 1.87× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: job/FeatureTransformation.scala feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala — FileTooLong — 800 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 300 over it, 1.60× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: feathr/client.py feathr_project/feathr/client.py — FileTooLong — 701 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 201 over it, 1.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: registry/models.py registry/purview-registry/registry/models.py — FileTooLong — 667 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 167 over it, 1.33× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: registry/models.py registry/sql-registry/registry/models.py — FileTooLong — 625 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 125 over it, 1.25× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: util/SourceUtils.scala feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala — FileTooLong — 561 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 61 over it, 1.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: registry/purview_registry.py registry/purview-registry/registry/purview_registry.py — FileTooLong — 540 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 40 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: config/FeathrConfigLoader.scala feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala — FileTooLong — 536 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 36 over it, 1.07× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D31 · IaC & Container Security · Medium IaC · ×8
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×8
  • Duplicated block (9 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:859 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:859-867 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1406-1414 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:859` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/hdfs/FileFormat.scala:45 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/hdfs/FileFormat.scala:45-53 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/hdfs/FileFormat.scala:84-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/hdfs/FileFormat.scala:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:37 — feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:37-45 | feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/SumAggregate.scala:37-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/CountAggregate.scala:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:236 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:236-244 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:420-428 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java:125 — feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java:125-133 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/DateTimeConfig.java:82-90 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/DateTimeConfig.java` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/FeatureGenConfig.java:62 — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/FeatureGenConfig.java:62-70 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/FeatureGenConfig.java:38-46 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/FeatureGenConfig.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/FeatureGenConfig.java` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:139 — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:139-147 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:138-146 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) registry/purview-registry/registry/purview_registry.py:92 — registry/purview-registry/registry/purview_registry.py:92-100 | registry/sql-registry/registry/db_registry.py:627-635 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×8
  • Duplicated block (14 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OfflineOperationalConfig.java:82 — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OfflineOperationalConfig.java:82-95 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OfflineOperationalConfig.java:80-93 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OfflineOperationalConfig.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OfflineOperationalConfig.java` as WHOLE FILES: 97% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:156 — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:156-169 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:155-168 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:156` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/FeatureGenConfigBuilder.java:19 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/generation/FeatureGenConfigBuilder.java:19-32 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/FeatureGenConfigBuilder.java:20-33 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: `FeatureGenConfig` names `com.linkedin.feathr.common.configObj.generation.FeatureGenConfig` in one and `com.linkedin.feathr.core.config.generation.FeatureGenConfig` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (14 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:104 — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:104-117 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:103-116 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:1236 — feathr_project/feathr/registry/_feature_registry_purview.py:1236-1249 | feathr_project/feathr/registry/_feature_registry_purview.py:1463-1476 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (14 lines × 2) registry/access_control/rbac/database.py:29 — registry/access_control/rbac/database.py:29-42 | registry/sql-registry/registry/database.py:34-47 — before extracting anything, compare `registry/access_control/rbac/database.py` and `registry/sql-registry/registry/database.py` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) registry/access_control/rbac/db_rbac.py:53 — registry/access_control/rbac/db_rbac.py:53-66 | registry/access_control/rbac/db_rbac.py:69-82 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (14 lines × 2) registry/purview-registry/registry/models.py:255 — registry/purview-registry/registry/models.py:255-268 | registry/sql-registry/registry/models.py:246-259 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
X3 · Exception handling · Swallowed exception (empty catch) · ×8
  • Swallowed exception (empty catch) ui/src/store/globalStore.ts:68 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) ui/src/pages/ProjectLineage/index.tsx:47 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:92 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) ui/src/pages/Management/components/UserRolesTable/index.tsx:58 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:17 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:18 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:12 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:656 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×8
  • Swallowed exception (caught, then discarded) feathr_project/feathr/utils/job_utils.py:241 — `except` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) REDACTED:359 — `except` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/CmdLineParser.scala:59 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:710 — `case e: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:987 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:134 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/OptimizerUtils.scala:187 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/OptimizerUtils.scala:198 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×7
  • Duplicated block (10 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:841 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:841-850 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1389-1398 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:841` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:855` calls `flatMap` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1403` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OperationalConfig.java:55 — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OperationalConfig.java:55-64 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OperationalConfig.java:33-42 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OperationalConfig.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OperationalConfig.java` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/ConfigValidator.java:56 — feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/ConfigValidator.java:56-65 | feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/ConfigValidatorFactory.java:36-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (10 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:183 — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:183-192 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:182-191 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) feathr_project/feathr/definition/sink.py:239 — feathr_project/feathr/definition/sink.py:239-248 | feathr_project/feathr/definition/source.py:359-368 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (10 lines × 2) feathr_project/feathr/registry/registry_utils.py:28 — feathr_project/feathr/registry/registry_utils.py:28-37 | REDACTED:23-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) registry/purview-registry/registry/models.py:531 — registry/purview-registry/registry/models.py:531-540 | registry/sql-registry/registry/models.py:498-507 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D29 · Static Analysis (SAST) · REDACTED · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · TooManyMethods · ×6
  • TooManyMethods: FeatureValue feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureValue.java:59 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SourceUtils feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:59 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: FeathrClient feathr_project/feathr/client.py:45 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: _PurviewRegistry feathr_project/feathr/registry/_feature_registry_purview.py:65 — TooManyMethods — 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MvelContextUDFs feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:35 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: FeatureTransformation feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:80 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D36 · Supply-chain Provenance & Signing REDACTED · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×4
  • Duplicated block (17 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/functions/MvelFeatureDerivationFunction.scala:44 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/functions/MvelFeatureDerivationFunction.scala:44-60 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/functions/MvelFeatureDerivationFunction1.scala:41-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (17 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:291 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:291-307 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:475-491 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:291` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:419 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:419-435 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1332-1348 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (17 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:130 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:130-146 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:340-356 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:130` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×4
  • Duplicated block (11 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:500 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:500-510 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:519-529 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/TransformationOperatorUtils.scala:48 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/TransformationOperatorUtils.scala:48-58 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/DataFrameBasedSqlEvaluator.scala:93-103 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/TransformationOperatorUtils.scala:48` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:144 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/testfwk/TestFwkUtils.scala:144-154 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:943-953 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) registry/purview-registry/registry/models.py:188 — registry/purview-registry/registry/models.py:188-198 | registry/sql-registry/registry/models.py:179-189 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the function that made it · ×4
  • Disposable created and abandoned in the function that made it feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:771 — `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.mkString` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:798 — `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.mkString` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:108 — `Source.fromResource(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `source`, and every later use of `source` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromResource(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/datasource/DataSourceConfigUtils.scala:20 — `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.mkString` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
D2 · Cognitive Complexity · models._to_type (cognitive 16) · ×3
  • models._to_type (cognitive 16) registry/access_control/rbac/models.py:130 — models._to_type has cognitive complexity 16 (threshold 15). Drivers by points: error handling 3 (8 pts), if/else 6 (8 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • models._to_type (cognitive 16) registry/purview-registry/registry/models.py:28 — models._to_type has cognitive complexity 16 (threshold 15). Drivers by points: error handling 3 (8 pts), if/else 6 (8 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • models._to_type (cognitive 16) registry/sql-registry/registry/models.py:28 — models._to_type has cognitive complexity 16 (threshold 15). Drivers by points: error handling 3 (8 pts), if/else 6 (8 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D36 · Supply-chain Provenance & Signing REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (6–7 lines × 2) · ×3
  • Duplicated block (6–7 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:334 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:334-340 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:357-362 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:334` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6–7 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/FeatureDefConfigSemanticValidator.java:318 — feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/FeatureDefConfigSemanticValidator.java:318-324 | feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/FeatureDefConfigSemanticValidator.java:402-407 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6–7 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:1285 — feathr_project/feathr/registry/_feature_registry_purview.py:1285-1290 | feathr_project/feathr/registry/_feature_registry_purview.py:1353-1359 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feature_registry_purview.py:1353` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×3
  • Duplicated block (6 lines × 3) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:46 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:46-51 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:111-116 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:123-128 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:46` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 3) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89-94 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:685-690 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:810-815 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:89` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 3) feathr_project/feathr/registry/_feathr_registry_client.py:235 — feathr_project/feathr/registry/_feathr_registry_client.py:235-240 | feathr_project/feathr/registry/_feathr_registry_client.py:247-252 | feathr_project/feathr/registry/_feathr_registry_client.py:261-266 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feathr_registry_client.py:235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D17 · Explicit Debt · HackComment · ×2
  • HackComment feathr-impl/src/test/java/com/linkedin/feathr/common/value/TestFeatureValues.java:135 — // hack to clone the expected value — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment feathr-impl/src/main/scala/com/linkedin/feathr/common/tensorbuilder/BufferUtils.java:122 — // Hack, the cleaner way is for this method to only work with strings, but this creates even more overhead for deserializer. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D29 · Static Analysis (SAST) · REDACTED · ×2
  • REDACTED
  • REDACTED
D3 · God Classes · MethodTooLong · ×2
  • MethodTooLong: RedisOutputUtils.getConversionFunction feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/outputProcessor/RedisOutputUtils.scala:89 — MethodTooLong — getConversionFunction runs 144 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 44 over it, 1.44× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SchemaConverters.createConverterToSQL feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:140 — MethodTooLong — createConverterToSQL runs 135 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 35 over it, 1.35× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×2
  • Duplicated block (33 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:62 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:62-94 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:703-735 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (33 lines × 2) registry/access_control/rbac/database.py:110 — registry/access_control/rbac/database.py:110-142 | registry/sql-registry/registry/database.py:156-188 — before extracting anything, compare `registry/access_control/rbac/database.py` and `registry/sql-registry/registry/database.py` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `registry/sql-registry/registry/database.py:192` calls `get` and `registry/access_control/rbac/database.py:145` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×2
  • Duplicated block (20 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:108 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:108-127 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:318-337 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:108` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/MaxPoolingAggregate.scala:20 — feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/MaxPoolingAggregate.scala:20-39 | feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/MinPoolingAggregate.scala:20-39 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×2
  • Duplicated block (15–16 lines × 2) feathr-compute/src/main/java/com/linkedin/feathr/compute/builder/FeatureVersionBuilder.java:37 — feathr-compute/src/main/java/com/linkedin/feathr/compute/builder/FeatureVersionBuilder.java:37-51 | feathr-compute/src/main/java/com/linkedin/feathr/compute/builder/FeatureVersionBuilder.java:63-78 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (15–16 lines × 2) feathr_project/feathrcli/cli.py:100 — feathr_project/feathrcli/cli.py:100-115 | feathr_project/feathrcli/cli.py:130-144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/derivations/DerivationConfigWithExtractor.java:37 — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/derivations/DerivationConfigWithExtractor.java:37-51 | feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/derivations/DerivationConfigWithExtractor.java:67-81 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/derivations/DerivationConfigWithExtractor.java:37` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) feathr-config/src/main/java/com/linkedin/feathr/exception/FeathrException.java:7 — feathr-config/src/main/java/com/linkedin/feathr/exception/FeathrException.java:7-21 | feathr-impl/src/main/java/com/linkedin/feathr/common/exception/FeathrException.java:8-22 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×2
  • Duplicated block (13 lines × 3) feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExprConverter.java:103 — feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExprConverter.java:103-115 | feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExtractorConverter.java:61-73 | feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/SimpleDerivationConfigConverter.java:67-79 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/DerivationConfigWithExprConverter.java:103` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `configObject` to `DerivationConfigWithExpr` in one and `DerivationConfigWithExtractor` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 3) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:204 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:204-216 | feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:161-175 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:160-174 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:204` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×2
  • Duplicated block (21 lines × 2) registry/access_control/rbac/database.py:67 — registry/access_control/rbac/database.py:67-87 | registry/sql-registry/registry/database.py:132-152 — before extracting anything, compare `registry/access_control/rbac/database.py` and `registry/sql-registry/registry/database.py` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 82 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (21 lines × 2) registry/purview-registry/registry/models.py:616 — registry/purview-registry/registry/models.py:616-636 | registry/sql-registry/registry/models.py:581-601 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) registry/purview-registry/registry/purview_registry.py:203 — registry/purview-registry/registry/purview_registry.py:203-214 | registry/sql-registry/registry/db_registry.py:193-204 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) registry/purview-registry/registry/purview_registry.py:189 — registry/purview-registry/registry/purview_registry.py:189-200 | registry/sql-registry/registry/db_registry.py:151-162 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
PF3 · Async & latency hygiene · Sync-over-async blocking · ×2
  • Sync-over-async blocking registry/access_control/api.py:16 — `get_projects` is async and calls requests.get — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs.
  • Sync-over-async blocking registry/access_control/api.py:23 — `get_project` is async and calls requests.get — a blocking call inside async code stalls the event loop — every other task on it waits for as long as it runs.
R10 · Code Duplication · Duplicated block with local edits (29 matched lines × 2 locations) · ×2
  • Duplicated block with local edits (29 matched lines × 2 locations) ui/src/pages/DataSourceDetails/index.tsx:32 — ui/src/pages/DataSourceDetails/index.tsx:32 · ui/src/pages/FeatureDetails/index.tsx:124 — the two spans are one implementation copied and then locally edited — 172 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
  • Duplicated block with local edits (29 matched lines × 2 locations) ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:99 — ui/src/pages/NewFeature/components/FeatureForm/useForm.ts:99 · ui/src/pages/NewSource/components/SourceForm/useForm.ts:47 — the two spans are one implementation copied and then locally edited — 189 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (13 lines × 2 locations) · ×2
  • Duplicated block (13 lines × 2 locations) ui/src/components/AddTags/index.tsx:168 — ui/src/components/AddTags/index.tsx:168 · ui/src/components/AddTags/index.tsx:181 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
  • Duplicated block (13 lines × 2 locations) ui/src/pages/NewFeature/components/FeatureForm/index.tsx:14 — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:14 · ui/src/pages/NewSource/components/SourceForm/index.tsx:14 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R7 · Dead Code · Dead file (~1 LoC) · ×2
  • Dead file (~1 LoC) ui/src/components/HeaderBar/index.ts — no import path from any entry point (1 application, 3 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
  • Dead file (~1 LoC) ui/src/components/SiderMenu/index.ts — no import path from any entry point (1 application, 3 tooling, 0 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
AC2 · Forms & labels · <Select> field component without a label · ×1
  • <Select> field component without a label ui/src/pages/Management/components/SearchBar/index.tsx:48 — This UI-library field component is named only by a placeholder — a placeholder is not a label (it vanishes as soon as the user types, and many assistive technologies ignore it). Give it a real name whichever way this library supports: a label prop, an aria-label, or an id on the rendered control with a <label htmlFor> pointing at it. For a group of controls, name the group itself (aria-label, or a fieldset with a legend) — labelling each item leaves the set unnamed.
AC3 · Page structure · Page without a main landmark · ×1
  • Page without a main landmark ui/public/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. This document's body is only the mount point <div id="root">, so there is no content here to wrap — render the <main> from the component mounted into it.
D1 · Cyclomatic Complexity · SchemaConverters.createConverterToSQL (cyclomatic 39) · ×1
  • SchemaConverters.createConverterToSQL (cyclomatic 39) feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:140 — SchemaConverters.createConverterToSQL has cyclomatic complexity 39 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · AnchorLoader.deserialize (cyclomatic 34) · ×1
  • AnchorLoader.deserialize (cyclomatic 34) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:205 — AnchorLoader.deserialize has cyclomatic complexity 34 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cyclomatic 29) · ×1
  • SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cyclomatic 29) feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:75 — SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow (cyclomatic 26) · ×1
  • FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow (cyclomatic 26) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:309 — FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FeathrClient.materialize_features (cyclomatic 26) · ×1
  • FeathrClient.materialize_features (cyclomatic 26) feathr_project/feathr/client.py:780 — FeathrClient.materialize_features has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DataSourceLoader.deserialize (cyclomatic 25) · ×1
  • DataSourceLoader.deserialize (cyclomatic 25) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:719 — DataSourceLoader.deserialize has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FeatureTypeConfigDeserializer.deserialize (cyclomatic 25) · ×1
  • FeatureTypeConfigDeserializer.deserialize (cyclomatic 25) feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureTypeConfigDeserializer.java:62 — FeatureTypeConfigDeserializer.deserialize has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SlidingWindowJoinIterator.compareJoinKey (cyclomatic 24) · ×1
  • SlidingWindowJoinIterator.compareJoinKey (cyclomatic 24) feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:358 — SlidingWindowJoinIterator.compareJoinKey has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · dsl_generator.gen_dsl (cyclomatic 24) · ×1
  • dsl_generator.gen_dsl (cyclomatic 24) feathr_project/feathr/utils/dsl/dsl_generator.py:327 — dsl_generator.gen_dsl has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FlowGraph.FlowGraph (cyclomatic 23) · ×1
  • FlowGraph.FlowGraph (cyclomatic 23) ui/src/components/FlowGraph/FlowGraph.tsx:46 — FlowGraph.FlowGraph has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 8 function literals inside it that branch (lines 99, 70, 92, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · CoercionUtilsScala.coerceFieldToFeatureValue (cyclomatic 22) · ×1
  • CoercionUtilsScala.coerceFieldToFeatureValue (cyclomatic 22) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/CoercionUtilsScala.scala:78 — CoercionUtilsScala.coerceFieldToFeatureValue has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FeaturizedDatasetUtils.tensorToDataFrameRow (cyclomatic 22) · ×1
  • FeaturizedDatasetUtils.tensorToDataFrameRow (cyclomatic 22) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:82 — FeaturizedDatasetUtils.tensorToDataFrameRow has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions. This shape REPEATS in the file: one other method here (FeaturizedDatasetUtils.tensorToFDSDataFrameRow) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D1 · Cyclomatic Complexity · FeaturizedDatasetUtils.tensorToFDSDataFrameRow (cyclomatic 22) · ×1
  • FeaturizedDatasetUtils.tensorToFDSDataFrameRow (cyclomatic 22) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:292 — FeaturizedDatasetUtils.tensorToFDSDataFrameRow has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions. This shape REPEATS in the file: one other method here (FeaturizedDatasetUtils.tensorToDataFrameRow) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D1 · Cyclomatic Complexity · job_utils.get_result_df (cyclomatic 22) · ×1
  • job_utils.get_result_df (cyclomatic 22) feathr_project/feathr/utils/job_utils.py:70 — job_utils.get_result_df has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SeqJoinAggregator.applyElementWiseAggregation (cyclomatic 20) · ×1
  • SeqJoinAggregator.applyElementWiseAggregation (cyclomatic 20) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:286 — SeqJoinAggregator.applyElementWiseAggregation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SequentialJoinAsDerivation.applyElementWiseAggregation (cyclomatic 20) · ×1
  • SequentialJoinAsDerivation.applyElementWiseAggregation (cyclomatic 20) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:470 — SequentialJoinAsDerivation.applyElementWiseAggregation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AnchorUDFOperator.computeUDFResult (cyclomatic 20) · ×1
  • AnchorUDFOperator.computeUDFResult (cyclomatic 20) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:28 — AnchorUDFOperator.computeUDFResult has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FeatureValueToRawColumnConverter.convert (cyclomatic 20) · ×1
  • FeatureValueToRawColumnConverter.convert (cyclomatic 20) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FeatureValueToColumnConverter.scala:54 — FeatureValueToRawColumnConverter.convert has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SlidingWindowJoinIterator.compareJoinKeyStructSubField (cyclomatic 20) · ×1
  • SlidingWindowJoinIterator.compareJoinKeyStructSubField (cyclomatic 20) feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:460 — SlidingWindowJoinIterator.compareJoinKeyStructSubField has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SchemaConverters.toSqlType (cyclomatic 19) · ×1
  • SchemaConverters.toSqlType (cyclomatic 19) feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:44 — SchemaConverters.toSqlType has cyclomatic complexity 19 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · ObservationDataTimeSettingDefinitionDeserializer.deserialize (cyclomatic 19) · ×1
  • ObservationDataTimeSettingDefinitionDeserializer.deserialize (cyclomatic 19) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfigDeserializer.scala:97 — ObservationDataTimeSettingDefinitionDeserializer.deserialize has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · registry_utils.source_to_def (cyclomatic 19) · ×1
  • registry_utils.source_to_def (cyclomatic 19) feathr_project/feathr/registry/registry_utils.py:42 — registry_utils.source_to_def has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · FCMGraphTraverser.traverseGraph (cyclomatic 18) · ×1
  • FCMGraphTraverser.traverseGraph (cyclomatic 18) feathr-impl/src/main/scala/com/linkedin/feathr/offline/graph/FCMGraphTraverser.scala:148 — FCMGraphTraverser.traverseGraph has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FeathrClient.get_offline_features (cyclomatic 18) · ×1
  • FeathrClient.get_offline_features (cyclomatic 18) feathr_project/feathr/client.py:525 — FeathrClient.get_offline_features has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: FeathrClient._decode_proto (cyclomatic 19) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · SumPoolingAggregate.aggValue (cyclomatic 17) · ×1
  • SumPoolingAggregate.aggValue (cyclomatic 17) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/SumPoolingAggregate.scala:60 — SumPoolingAggregate.aggValue has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · CoercionUtils.coerceToVector (cyclomatic 17) · ×1
  • CoercionUtils.coerceToVector (cyclomatic 17) feathr-impl/src/main/java/com/linkedin/feathr/common/util/CoercionUtils.java:98 — CoercionUtils.coerceToVector has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Equal.apply (cyclomatic 17) · ×1
  • Equal.apply (cyclomatic 17) feathr-impl/src/main/java/com/linkedin/feathr/common/Equal.java:23 — Equal.apply has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · _PurviewRegistry.get_features_from_registry (cyclomatic 17) · ×1
  • _PurviewRegistry.get_features_from_registry (cyclomatic 17) feathr_project/feathr/registry/_feature_registry_purview.py:1157 — _PurviewRegistry.get_features_from_registry has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TimeWindowFeatureDefinitionDeserializer.deserialize (cyclomatic 16) · ×1
  • TimeWindowFeatureDefinitionDeserializer.deserialize (cyclomatic 16) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/TimeWindowFeatureDefinition.scala:52 — TimeWindowFeatureDefinitionDeserializer.deserialize has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · _PurviewRegistry._parse_source (cyclomatic 16) · ×1
  • _PurviewRegistry._parse_source (cyclomatic 16) feathr_project/feathr/registry/_feature_registry_purview.py:330 — _PurviewRegistry._parse_source has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · SchemaConverters.createConverterToSQL (cognitive 75) · ×1
  • SchemaConverters.createConverterToSQL (cognitive 75) feathr-impl/src/main/scala/com/databricks/spark/avro/SchemaConverters.scala:140 — SchemaConverters.createConverterToSQL has cognitive complexity 75 (threshold 15). Drivers by points: if/else 28 (50 pts), match/switch 5 (16 pts), loops 2 (5 pts), boolean chains 4 (nesting depth added 36). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · dsl_generator.gen_dsl (cognitive 60) · ×1
  • dsl_generator.gen_dsl (cognitive 60) feathr_project/feathr/utils/dsl/dsl_generator.py:327 — dsl_generator.gen_dsl has cognitive complexity 60 (threshold 15). Drivers by points: if/else 10 (37 pts), loops 9 (20 pts), error handling 1 (3 pts) (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cognitive 55) · ×1
  • SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF (cognitive 55) feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala:75 — SlidingWindowAggregationJoiner.joinWindowAggFeaturesAsDF has cognitive complexity 55 (threshold 15). Drivers by points: if/else 20 (38 pts), match/switch 5 (11 pts), boolean chains 6 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeathrClient.materialize_features (cognitive 54) · ×1
  • FeathrClient.materialize_features (cognitive 54) feathr_project/feathr/client.py:780 — FeathrClient.materialize_features has cognitive complexity 54 (threshold 15). Drivers by points: if/else 14 (32 pts), loops 7 (17 pts), boolean chains 5 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ObservationDataTimeSettingDefinitionDeserializer.deserialize (cognitive 48) · ×1
  • ObservationDataTimeSettingDefinitionDeserializer.deserialize (cognitive 48) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfigDeserializer.scala:97 — ObservationDataTimeSettingDefinitionDeserializer.deserialize has cognitive complexity 48 (threshold 15). Drivers by points: if/else 16 (24 pts), match/switch 9 (22 pts), boolean chains 2 (nesting depth added 21). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FeatureTypeConfigDeserializer.deserialize (cognitive 45) · ×1
  • FeatureTypeConfigDeserializer.deserialize (cognitive 45) feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureTypeConfigDeserializer.java:62 — FeatureTypeConfigDeserializer.deserialize has cognitive complexity 45 (threshold 15). Drivers by points: if/else 15 (27 pts), loops 4 (11 pts), boolean chains 4, match/switch 1 (2 pts), ternaries 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeWindowFeatureDefinitionDeserializer.deserialize (cognitive 43) · ×1
  • TimeWindowFeatureDefinitionDeserializer.deserialize (cognitive 43) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/TimeWindowFeatureDefinition.scala:52 — TimeWindowFeatureDefinitionDeserializer.deserialize has cognitive complexity 43 (threshold 15). Drivers by points: match/switch 14 (27 pts), if/else 13, error handling 1 (3 pts) (nesting depth added 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DataSourceLoader.deserialize (cognitive 42) · ×1
  • DataSourceLoader.deserialize (cognitive 42) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:719 — DataSourceLoader.deserialize has cognitive complexity 42 (threshold 15). Drivers by points: match/switch 11 (22 pts), if/else 17 (18 pts), boolean chains 2 (nesting depth added 12). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AnchorLoader.deserialize (cognitive 39) · ×1
  • AnchorLoader.deserialize (cognitive 39) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:205 — AnchorLoader.deserialize has cognitive complexity 39 (threshold 15). Drivers by points: match/switch 16 (21 pts), if/else 16 (17 pts), boolean chains 1 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AnchorUDFOperator.computeUDFResult (cognitive 34) · ×1
  • AnchorUDFOperator.computeUDFResult (cognitive 34) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/AnchorUDFOperator.scala:28 — AnchorUDFOperator.computeUDFResult has cognitive complexity 34 (threshold 15). Drivers by points: if/else 14 (19 pts), match/switch 7 (15 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FCMGraphTraverser.traverseGraph (cognitive 33) · ×1
  • FCMGraphTraverser.traverseGraph (cognitive 33) feathr-impl/src/main/scala/com/linkedin/feathr/offline/graph/FCMGraphTraverser.scala:148 — FCMGraphTraverser.traverseGraph has cognitive complexity 33 (threshold 15). Drivers by points: if/else 10 (22 pts), match/switch 2 (10 pts), loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeaturizedDatasetUtils.tensorToDataFrameRow (cognitive 33) · ×1
  • FeaturizedDatasetUtils.tensorToDataFrameRow (cognitive 33) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:82 — FeaturizedDatasetUtils.tensorToDataFrameRow has cognitive complexity 33 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (10 pts), match/switch 3 (10 pts), boolean chains 2 (nesting depth added 19). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (FeaturizedDatasetUtils.tensorToFDSDataFrameRow) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · FeaturizedDatasetUtils.tensorToFDSDataFrameRow (cognitive 33) · ×1
  • FeaturizedDatasetUtils.tensorToFDSDataFrameRow (cognitive 33) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:292 — FeaturizedDatasetUtils.tensorToFDSDataFrameRow has cognitive complexity 33 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (10 pts), match/switch 3 (10 pts), boolean chains 2 (nesting depth added 19). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (FeaturizedDatasetUtils.tensorToDataFrameRow) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · AnchorLoader.loadSourceKeyExtractor (cognitive 32) · ×1
  • AnchorLoader.loadSourceKeyExtractor (cognitive 32) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:377 — AnchorLoader.loadSourceKeyExtractor has cognitive complexity 32 (threshold 15). Drivers by points: if/else 11 (21 pts), match/switch 4 (9 pts), boolean chains 2 (nesting depth added 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SeqJoinAggregator.applyElementWiseAggregation (cognitive 31) · ×1
  • SeqJoinAggregator.applyElementWiseAggregation (cognitive 31) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:286 — SeqJoinAggregator.applyElementWiseAggregation has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17 (26 pts), match/switch 4 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SequentialJoinAsDerivation.applyElementWiseAggregation (cognitive 31) · ×1
  • SequentialJoinAsDerivation.applyElementWiseAggregation (cognitive 31) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:470 — SequentialJoinAsDerivation.applyElementWiseAggregation has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17 (26 pts), match/switch 4 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeathrClient.get_offline_features (cognitive 30) · ×1
  • FeathrClient.get_offline_features (cognitive 30) feathr_project/feathr/client.py:525 — FeathrClient.get_offline_features has cognitive complexity 30 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 6, loops 3 (6 pts), ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · job_utils.get_result_df (cognitive 30) · ×1
  • job_utils.get_result_df (cognitive 30) feathr_project/feathr/utils/job_utils.py:70 — job_utils.get_result_df has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18 (25 pts), boolean chains 4, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AnchoredFeatureJoinStep.joinFeaturesOnSingleDF (cognitive 28) · ×1
  • AnchoredFeatureJoinStep.joinFeaturesOnSingleDF (cognitive 28) feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:210 — AnchoredFeatureJoinStep.joinFeaturesOnSingleDF has cognitive complexity 28 (threshold 15). Drivers by points: if/else 16 (27 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow (cognitive 27) · ×1
  • FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow (cognitive 27) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:309 — FDSConversionUtils.convertRawValueTo1DFDSSparseTensorRow has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (12 pts), match/switch 4 (10 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlidingWindowJoinIterator.compareJoinKey (cognitive 27) · ×1
  • SlidingWindowJoinIterator.compareJoinKey (cognitive 27) feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:358 — SlidingWindowJoinIterator.compareJoinKey has cognitive complexity 27 (threshold 15). Drivers by points: match/switch 7 (13 pts), if/else 8 (11 pts), loops 1 (3 pts) (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · TimeWindowJoinConfigSettingDefinitionDeserializer.deserialize (cognitive 26) · ×1
  • TimeWindowJoinConfigSettingDefinitionDeserializer.deserialize (cognitive 26) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfig.scala:182 — TimeWindowJoinConfigSettingDefinitionDeserializer.deserialize has cognitive complexity 26 (threshold 15). Drivers by points: match/switch 6 (16 pts), if/else 8 (10 pts) (nesting depth added 12). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · JoinTimeConfigSettingDefinitionDeserializer.deserialize (cognitive 26) · ×1
  • JoinTimeConfigSettingDefinitionDeserializer.deserialize (cognitive 26) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfigDeserializer.scala:200 — JoinTimeConfigSettingDefinitionDeserializer.deserialize has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 5 (11 pts), boolean chains 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FeatureValueToRawColumnConverter.convert (cognitive 26) · ×1
  • FeatureValueToRawColumnConverter.convert (cognitive 26) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FeatureValueToColumnConverter.scala:54 — FeatureValueToRawColumnConverter.convert has cognitive complexity 26 (threshold 15). Drivers by points: if/else 14 (23 pts), match/switch 2 (3 pts) (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · _PurviewRegistry._parse_source (cognitive 26) · ×1
  • _PurviewRegistry._parse_source (cognitive 26) feathr_project/feathr/registry/_feature_registry_purview.py:330 — _PurviewRegistry._parse_source has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (15 pts), ternaries 5 (10 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PurviewRegistry._upload_single_entity (cognitive 26) · ×1
  • PurviewRegistry._upload_single_entity (cognitive 26) registry/purview-registry/registry/purview_registry.py:623 — PurviewRegistry._upload_single_entity has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 2 (5 pts), error handling 3, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CoercionUtilsScala.coerceFieldToFeatureValue (cognitive 25) · ×1
  • CoercionUtilsScala.coerceFieldToFeatureValue (cognitive 25) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/CoercionUtilsScala.scala:78 — CoercionUtilsScala.coerceFieldToFeatureValue has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 5 (19 pts), if/else 5 (6 pts) (nesting depth added 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DbRegistry.create_project_derived_feature (cognitive 25) · ×1
  • DbRegistry.create_project_derived_feature (cognitive 25) registry/sql-registry/registry/db_registry.py:480 — DbRegistry.create_project_derived_feature has cognitive complexity 25 (threshold 15). Drivers by points: if/else 16 (23 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FlowGraph.FlowGraph (cognitive 25) · ×1
  • FlowGraph.FlowGraph (cognitive 25) ui/src/components/FlowGraph/FlowGraph.tsx:46 — FlowGraph.FlowGraph has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 9, ternaries 1 (2 pts) (nesting depth added 4). None of this is in the body itself: all 25 points belong to 8 function literals inside it that branch (lines 99, 150, 169, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · CoercionUtils.coerceToVector (cognitive 24) · ×1
  • CoercionUtils.coerceToVector (cognitive 24) feathr-impl/src/main/java/com/linkedin/feathr/common/util/CoercionUtils.java:98 — CoercionUtils.coerceToVector has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (16 pts), error handling 1 (4 pts), ternaries 1 (3 pts), match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FeathrClient.joinFeaturesAsDF (cognitive 23) · ×1
  • FeathrClient.joinFeaturesAsDF (cognitive 23) feathr-impl/src/main/scala/com/linkedin/feathr/offline/client/FeathrClient.scala:293 — FeathrClient.joinFeaturesAsDF has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (18 pts), loops 2 (3 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DerivationLoader.deserialize (cognitive 23) · ×1
  • DerivationLoader.deserialize (cognitive 23) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:554 — DerivationLoader.deserialize has cognitive complexity 23 (threshold 15). Drivers by points: if/else 12 (17 pts), match/switch 2 (4 pts), boolean chains 1, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _PurviewRegistry.upload_single_entity_to_purview (cognitive 23) · ×1
  • _PurviewRegistry.upload_single_entity_to_purview (cognitive 23) feathr_project/feathr/registry/_feature_registry_purview.py:601 — _PurviewRegistry.upload_single_entity_to_purview has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 1 (3 pts), error handling 2, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AvgAggregate.genRow (cognitive 22) · ×1
  • AvgAggregate.genRow (cognitive 22) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/AvgAggregate.scala:111 — AvgAggregate.genRow has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (20 pts), match/switch 2 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AnchorConfigConverter.buildDataSource (cognitive 22) · ×1
  • AnchorConfigConverter.buildDataSource (cognitive 22) feathr-compute/src/main/java/com/linkedin/feathr/compute/converter/AnchorConfigConverter.java:199 — AnchorConfigConverter.buildDataSource has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (21 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PurviewRegistry.get_project (cognitive 22) · ×1
  • PurviewRegistry.get_project (cognitive 22) registry/purview-registry/registry/purview_registry.py:263 — PurviewRegistry.get_project has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 2, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DataFrameFeatureJoiner.joinFeaturesAsDF (cognitive 21) · ×1
  • DataFrameFeatureJoiner.joinFeaturesAsDF (cognitive 21) feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/DataFrameFeatureJoiner.scala:128 — DataFrameFeatureJoiner.joinFeaturesAsDF has cognitive complexity 21 (threshold 15). Drivers by points: if/else 16, boolean chains 3, match/switch 2. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SumPoolingAggregate.aggValue (cognitive 21) · ×1
  • SumPoolingAggregate.aggValue (cognitive 21) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/SumPoolingAggregate.scala:60 — SumPoolingAggregate.aggValue has cognitive complexity 21 (threshold 15). Drivers by points: match/switch 4 (10 pts), if/else 8, boolean chains 3 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FeatureValue.<init> (cognitive 21) · ×1
  • FeatureValue.<init> (cognitive 21) feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureValue.java:147 — FeatureValue.<init> has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14 (20 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _PurviewRegistry.get_features_from_registry (cognitive 21) · ×1
  • _PurviewRegistry.get_features_from_registry (cognitive 21) feathr_project/feathr/registry/_feature_registry_purview.py:1157 — _PurviewRegistry.get_features_from_registry has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _PurviewRegistry._get_transformation_from_dict (cognitive 21) · ×1
  • _PurviewRegistry._get_transformation_from_dict (cognitive 21) feathr_project/feathr/registry/_feature_registry_purview.py:1407 — _PurviewRegistry._get_transformation_from_dict has cognitive complexity 21 (threshold 15). Drivers by points: ternaries 9 (18 pts), if/else 2, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeatureValueTypeValidator.validate (cognitive 20) · ×1
  • FeatureValueTypeValidator.validate (cognitive 20) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeatureValueTypeValidator.scala:44 — FeatureValueTypeValidator.validate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlidingWindowJoinIterator.generateFeatureColumn (cognitive 20) · ×1
  • SlidingWindowJoinIterator.generateFeatureColumn (cognitive 20) feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:231 — SlidingWindowJoinIterator.generateFeatureColumn has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _FeathrLocalSparkJobLauncher.wait_for_completion (cognitive 20) · ×1
  • _FeathrLocalSparkJobLauncher.wait_for_completion (cognitive 20) feathr_project/feathr/spark_provider/_localspark_submission.py:158 — _FeathrLocalSparkJobLauncher.wait_for_completion has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 2, error handling 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SumPoolingAggregate.calculateAggregateWithCount (cognitive 19) · ×1
  • SumPoolingAggregate.calculateAggregateWithCount (cognitive 19) feathr-impl/src/main/scala/com/linkedin/feathr/swj/aggregate/SumPoolingAggregate.scala:27 — SumPoolingAggregate.calculateAggregateWithCount has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (12 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeathrClient._valid_materialize_keys (cognitive 19) · ×1
  • FeathrClient._valid_materialize_keys (cognitive 19) feathr_project/feathr/client.py:755 — FeathrClient._valid_materialize_keys has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _FeathrDatabricksJobLauncher.submit_feathr_job (cognitive 19) · ×1
  • _FeathrDatabricksJobLauncher.submit_feathr_job (cognitive 19) REDACTED:154 — _FeathrDatabricksJobLauncher.submit_feathr_job has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (15 pts), loops 1 (3 pts), error handling 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · FeatureTransformation.applyBloomFilterRdd (cognitive 18) · ×1
  • FeatureTransformation.applyBloomFilterRdd (cognitive 18) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:743 — FeatureTransformation.applyBloomFilterRdd has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimizerUtils.generateBloomFilters (cognitive 18) · ×1
  • OptimizerUtils.generateBloomFilters (cognitive 18) feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/OptimizerUtils.scala:117 — OptimizerUtils.generateBloomFilters has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Equal.apply (cognitive 18) · ×1
  • Equal.apply (cognitive 18) feathr-impl/src/main/java/com/linkedin/feathr/common/Equal.java:23 — Equal.apply has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (9 pts), boolean chains 6, loops 2, ternaries 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · TensorTypeTensorFeatureFormatBuilder.validCheck (cognitive 18) · ×1
  • TensorTypeTensorFeatureFormatBuilder.validCheck (cognitive 18) feathr-compute/src/main/java/com/linkedin/feathr/compute/builder/TensorTypeTensorFeatureFormatBuilder.java:58 — TensorTypeTensorFeatureFormatBuilder.validCheck has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PegasusRecordSettingsConverter.convertInputDataTimeSettings (cognitive 17) · ×1
  • PegasusRecordSettingsConverter.convertInputDataTimeSettings (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/join/converters/PegasusRecordSettingsConverter.scala:66 — PegasusRecordSettingsConverter.convertInputDataTimeSettings has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DataSourceNodeEvaluator.processEventNode (cognitive 17) · ×1
  • DataSourceNodeEvaluator.processEventNode (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/datasource/DataSourceNodeEvaluator.scala:51 — DataSourceNodeEvaluator.processEventNode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12, match/switch 2 (5 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · BaseDerivedFeatureOperator.applyDerivationFunction (cognitive 17) · ×1
  • BaseDerivedFeatureOperator.applyDerivationFunction (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/offline/evaluator/transformation/BaseDerivedFeatureOperator.scala:29 — BaseDerivedFeatureOperator.applyDerivationFunction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 1, error handling 1, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · AnchorToDataSourceMapper.getBasicAnchorDFMapForJoin (cognitive 17) · ×1
  • AnchorToDataSourceMapper.getBasicAnchorDFMapForJoin (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/AnchorToDataSourceMapper.scala:35 — AnchorToDataSourceMapper.getBasicAnchorDFMapForJoin has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 3, match/switch 1 (2 pts), error handling 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CoercionUtilsScala.coerceFeatureValueToStringKey (cognitive 17) · ×1
  • CoercionUtilsScala.coerceFeatureValueToStringKey (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/CoercionUtilsScala.scala:48 — CoercionUtilsScala.coerceFeatureValueToStringKey has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SlidingWindowJoinIterator.compareJoinKeyStructSubField (cognitive 17) · ×1
  • SlidingWindowJoinIterator.compareJoinKeyStructSubField (cognitive 17) feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:460 — SlidingWindowJoinIterator.compareJoinKeyStructSubField has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 6 (11 pts), if/else 6 (nesting depth added 5). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CompatibilityUtils.getCategoricalString (cognitive 17) · ×1
  • CompatibilityUtils.getCategoricalString (cognitive 17) feathr-impl/src/main/java/com/linkedin/feathr/common/CompatibilityUtils.java:96 — CompatibilityUtils.getCategoricalString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FeatureDefConfigSemanticValidator.validateApprovedExtractorWithParameters (cognitive 17) · ×1
  • FeatureDefConfigSemanticValidator.validateApprovedExtractorWithParameters (cognitive 17) feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/FeatureDefConfigSemanticValidator.java:157 — FeatureDefConfigSemanticValidator.validateApprovedExtractorWithParameters has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MvelValidator.getFeatureMvels (cognitive 17) · ×1
  • MvelValidator.getFeatureMvels (cognitive 17) feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/MvelValidator.java:88 — MvelValidator.getFeatureMvels has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BatchDataLoader.loadDataFrameWithRetry (cognitive 16) · ×1
  • BatchDataLoader.loadDataFrameWithRetry (cognitive 16) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/BatchDataLoader.scala:70 — BatchDataLoader.loadDataFrameWithRetry has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), error handling 3 (6 pts), loops 1, match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeBasedHdfsPathAnalyzer.analyze (cognitive 16) · ×1
  • TimeBasedHdfsPathAnalyzer.analyze (cognitive 16) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/pathutil/TimeBasedHdfsPathAnalyzer.scala:28 — TimeBasedHdfsPathAnalyzer.analyze has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (14 pts), loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MvelContextUDFs.extract_term_value_from_array (cognitive 16) · ×1
  • MvelContextUDFs.extract_term_value_from_array (cognitive 16) feathr-impl/src/main/java/com/linkedin/feathr/common/util/MvelContextUDFs.java:455 — MvelContextUDFs.extract_term_value_from_array has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), boolean chains 4, ternaries 1 (2 pts), loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · registry_utils.source_to_def (cognitive 16) · ×1
  • registry_utils.source_to_def (cognitive 16) feathr_project/feathr/registry/registry_utils.py:42 — registry_utils.source_to_def has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 4 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · _FeathrSynapseJobLauncher.submit_feathr_job (cognitive 16) · ×1
  • _FeathrSynapseJobLauncher.submit_feathr_job (cognitive 16) REDACTED:128 — _FeathrSynapseJobLauncher.submit_feathr_job has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12 (15 pts), loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (3 members, 6 shared lines) · ×1
  • Near-duplicate member family (3 members, 6 shared lines) feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:80 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/source/dataloader/AvroJsonDataLoader.scala:80-96 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:674-692 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:792-818 — These 3 members are variants of one another: a block of 6 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×1
  • Edited copy of a member (26 corresponding lines) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:177 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:177-206 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:361-390 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×1
  • Edited copy of a member (27 corresponding lines) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:250 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:250-276 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:434-460 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×1
  • Edited copy of a member (36 corresponding lines) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:60 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:60-97 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:701-738 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) registry/sql-registry/registry/db_registry.py:281 — registry/sql-registry/registry/db_registry.py:281-311 | registry/sql-registry/registry/db_registry.py:314-360 | registry/sql-registry/registry/db_registry.py:363-422 | registry/sql-registry/registry/db_registry.py:425-478 | registry/sql-registry/registry/db_registry.py:481-561 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:202 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:202-216 | feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/HdfsConfigWithRegularDataBuilder.java:37-53 | feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:155-175 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:154-174 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (98 lines × 2) · ×1
  • Duplicated block (98 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:308 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:308-405 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:492-589 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:308` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×1
  • Duplicated block (28 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala:22 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala:22-49 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:166-193 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:903 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:903-929 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1437-1463 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:903` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×1
  • Duplicated block (25 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:83 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:83-107 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:293-317 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeaturizedDatasetUtils.scala:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:254 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:254-276 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:438-460 — before extracting anything, compare `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala` and `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:254` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureGroupsGenerator.scala:49 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureGroupsGenerator.scala:49-64 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureGroupsGenerator.scala:97-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureGroupsGenerator.scala:49` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala:138 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala:138-151 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala:167-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/location/GenericLocation.scala:167` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×1
  • Duplicated block (12–13 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:52 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:52-63 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:287-299 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:52` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:223 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala:223-232 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:373-383 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:793 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:793-799 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:801-808 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:801` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/AvgPooling.scala:63 — feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/AvgPooling.scala:63-69 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MaxPooling.scala:63-69 | feathr-impl/src/main/scala/com/linkedin/feathr/offline/generation/aggregations/MinPooling.scala:63-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:203 — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:203-212 | feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/HdfsConfigWithRegularDataBuilder.java:38-49 | feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:160-171 | feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java:159-170 — before extracting anything, compare `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java` and `feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/derivations/DerivationConfigBuilder.java:203` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:156` calls `hasPath` and `feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/HdfsConfigWithRegularDataBuilder.java:37` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (31 lines × 3) · ×1
  • Duplicated block (31 lines × 3) registry/access_control/rbac/models.py:131 — registry/access_control/rbac/models.py:131-161 | registry/purview-registry/registry/models.py:29-59 | registry/sql-registry/registry/models.py:29-59 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (27–30 lines × 2) · ×1
  • Duplicated block (27–30 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:194 — feathr_project/feathr/registry/_feature_registry_purview.py:194-223 | feathr_project/feathr/registry/_feature_registry_purview.py:444-470 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feature_registry_purview.py:194` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:1319 — feathr_project/feathr/registry/_feature_registry_purview.py:1319-1342 | feathr_project/feathr/registry/registry_utils.py:119-142 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (16–19 lines × 2) · ×1
  • Duplicated block (16–19 lines × 2) feathr_project/feathr/registry/_feature_registry_purview.py:545 — feathr_project/feathr/registry/_feature_registry_purview.py:545-563 | feathr_project/feathr/registry/_feature_registry_purview.py:566-581 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feature_registry_purview.py:545` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14–17 lines × 2) · ×1
  • Duplicated block (14–17 lines × 2) feathr_project/feathr/registry/_feathr_registry_client.py:92 — feathr_project/feathr/registry/_feathr_registry_client.py:92-108 | feathr_project/feathr/registry/_feature_registry_purview.py:875-888 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feathr_project/feathr/registry/_feathr_registry_client.py:92` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `feathr_project/feathr/registry/_feature_registry_purview.py:873` calls `_register_feathr_feature_types`, `_create_project` and `feathr_project/feathr/registry/_feathr_registry_client.py:92` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16 lines × 3) · ×1
  • Duplicated block (16 lines × 3) feathr_project/feathr/registry/_feature_registry_purview.py:268 — feathr_project/feathr/registry/_feature_registry_purview.py:268-283 | feathr_project/feathr/registry/_feature_registry_purview.py:286-301 | feathr_project/feathr/registry/_feature_registry_purview.py:497-512 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) registry/access_control/rbac/models.py:111 — registry/access_control/rbac/models.py:111-125 | registry/purview-registry/registry/models.py:10-24 | registry/sql-registry/registry/models.py:10-24 — before extracting anything, compare `registry/purview-registry/registry/models.py` and `registry/sql-registry/registry/models.py` as WHOLE FILES: this scan already matched 21 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) registry/sql-registry/registry/db_registry.py:286 — registry/sql-registry/registry/db_registry.py:286-294 | registry/sql-registry/registry/db_registry.py:321-330 | registry/sql-registry/registry/db_registry.py:370-379 | registry/sql-registry/registry/db_registry.py:432-441 | registry/sql-registry/registry/db_registry.py:488-497 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `definition` to `ProjectDef` in one and `SourceDef` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (3–6 lines × 5) · ×1
  • Duplicated block (3–6 lines × 5) registry/sql-registry/registry/db_registry.py:282 — registry/sql-registry/registry/db_registry.py:282-284 | registry/sql-registry/registry/db_registry.py:314-319 | registry/sql-registry/registry/db_registry.py:363-368 | registry/sql-registry/registry/db_registry.py:425-430 | registry/sql-registry/registry/db_registry.py:481-486 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `definition` to `SourceDef` in one and `AnchorDef` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1
  • Duplicated block (5 lines × 3) registry/purview-registry/registry/purview_registry.py:374 — registry/purview-registry/registry/purview_registry.py:374-378 | registry/purview-registry/registry/purview_registry.py:402-409 | registry/purview-registry/registry/purview_registry.py:438-442 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `registry/purview-registry/registry/purview_registry.py:374` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `definition` to `AnchorDef` in one and `AnchorFeatureDef` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
P8 · Schema migrations · Schema created by SQLAlchemy create_all() (no migration path) · ×1
  • Schema created by SQLAlchemy create_all() (no migration path) registry/sql-registry/registry/db_registry.py:78 — SQLAlchemy create_all() builds the schema from the model at startup and keeps no migration history, so there is no reviewed, repeatable upgrade path for an existing production database — a renamed column is dropped and re-added rather than migrated. Adopt Alembic (`alembic revision --autogenerate` + `alembic upgrade head`), so every schema change is a versioned file applied the same way in every environment.
R10 · Code Duplication · Duplication concentrated across 11 sibling directories (13 clone groups) · ×1
  • Duplication concentrated across 11 sibling directories (13 clone groups) ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20 — 13 duplicated blocks under ui/src/pages/ have copies in at least two of the sibling directories 403, 404, DataSourceDetails, DataSources, FeatureDetails, Features (+5 more sibling(s) not listed) — 12 of them are reported below, and 1 is counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 13 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 13 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 13 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplicated block with local edits (102 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (102 matched lines × 2 locations) ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20 — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:20 · ui/src/pages/Features/components/FeatureTable/index.tsx:21 — the two spans are one implementation copied and then locally edited — 417 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (55 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (55 matched lines × 2 locations) ui/src/pages/NewFeature/components/FeatureForm/index.tsx:161 — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:161 · ui/src/pages/NewSource/components/SourceForm/index.tsx:47 — the two spans are one implementation copied and then locally edited — 267 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (34 lines × 3 locations) · ×1
  • Duplicated block (34 lines × 3 locations) ui/src/pages/DataSources/components/DataSourceTable/index.tsx:136 — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:136 · ui/src/pages/Features/components/FeatureTable/index.tsx:141 · ui/src/pages/Projects/components/ProjectTable/index.tsx:91 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (24 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (24 matched lines × 2 locations) ui/src/pages/FeatureDetails/index.tsx:66 — ui/src/pages/FeatureDetails/index.tsx:66 · ui/src/pages/ProjectLineage/index.tsx:26 — the two spans are one implementation copied and then locally edited — 118 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (19 lines × 2 locations) · ×1
  • Duplicated block (19 lines × 2 locations) ui/src/pages/FeatureDetails/index.tsx:153 — ui/src/pages/FeatureDetails/index.tsx:153 · ui/src/pages/Features/components/NodeDetails/FeatureNodeDetail.tsx:23 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (18 lines × 2 locations) · ×1
  • Duplicated block (18 lines × 2 locations) ui/src/pages/NewFeature/components/FeatureForm/index.tsx:38 — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:38 · ui/src/pages/NewSource/components/SourceForm/index.tsx:31 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (17 lines × 2 locations) · ×1
  • Duplicated block (17 lines × 2 locations) ui/src/routes/config.tsx:89 — ui/src/routes/config.tsx:89 · ui/src/routes/config.tsx:106 — all 2 copies are in the same file, and the CITED SPAN is a run of DECLARATIONS inside a construct — the members of a type, or the entries of an object or array literal — with no statement anywhere in it. Do not read this as an extract-a-helper row: nothing here executes, so there is no call site, and a call expression cannot stand where a member declaration or a literal's entry was. What repeats is a SHAPE, and which shape decides the move. Where the copies declare the same members, the repetition is a missing common ancestor: give it a base type, an interface both extend, a generic instantiated twice, or — where the copies are a literal's entries rather than a type's members — one shared constant each site spreads or refers to, so the set is written once. Where they declare DIFFERENT members and only the form is shared — a decorator and its options, an annotation, a registration table's keys — the form is prescribed by a framework or a schema rather than copied, and the only collapse available is to generate the declarations from that schema; where you do not own the generator, this is the cost of the framework and there is nothing to extract. Check which of the two it is before acting: these copies still drift apart the first time only one of them is edited, which is why the repetition is reported, but the sentence to act on is not the same in both cases.
R10 · Code Duplication · Duplicated block (13 lines × 4 locations) · ×1
  • Duplicated block (13 lines × 4 locations) ui/src/pages/DataSources/components/DataSourceTable/index.tsx:158 — ui/src/pages/DataSources/components/DataSourceTable/index.tsx:158 · ui/src/pages/Features/components/FeatureTable/index.tsx:164 · ui/src/pages/Management/components/UserRolesTable/index.tsx:175 · ui/src/pages/Projects/components/ProjectTable/index.tsx:115 — the 4 copies are spread across 4 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block (12 lines × 2 locations) · ×1
  • Duplicated block (12 lines × 2 locations) ui/src/pages/NewFeature/index.tsx:9 — ui/src/pages/NewFeature/index.tsx:9 · ui/src/pages/NewSource/index.tsx:9 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (11 lines × 2 locations) · ×1
  • Duplicated block (11 lines × 2 locations) ui/src/pages/FeatureDetails/index.tsx:29 — ui/src/pages/FeatureDetails/index.tsx:29 · ui/src/pages/FeatureDetails/index.tsx:51 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (10 lines × 2 locations) · ×1
  • Duplicated block (10 lines × 2 locations) ui/src/api/api.tsx:29 — ui/src/api/api.tsx:29 · ui/src/api/api.tsx:75 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (7 lines × 2 locations) · ×1
  • Duplicated block (7 lines × 2 locations) ui/src/pages/NewFeature/components/FeatureForm/index.tsx:91 — ui/src/pages/NewFeature/components/FeatureForm/index.tsx:91 · ui/src/pages/NewSource/components/SourceForm/index.tsx:131 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R6 · Tooling · No typecheck script · ×1
  • No typecheck script — test ✓ · lint ✓ · typecheck ✗ — read from this repository's package.json scripts and corroborated against its CI workflows. A script counts when its name or command matches the step: `test` for the suite, `lint` or `prettier` for linting, `typecheck`/`type-check`/`tsc` for type checking. ✗ therefore means no script or CI step under those names was found, NOT that the step is absent from your pipeline — a task invoked by a runner this check does not read, or named something else entirely, is not seen and is worth confirming before acting on a cross. A ✓ means the wiring is DECLARED — a script or CI step under those names exists. It is not a statement that the step passes, or that it runs at all: nothing here installs a dependency or executes a suite.
R8 · Dependency Hygiene · Unused dependency '@testing-library/react' · ×1
  • Unused dependency '@testing-library/react' — Declared in ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency '@testing-library/user-event' · ×1
  • Unused dependency '@testing-library/user-event' — Declared in ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'web-vitals' · ×1
  • Unused dependency 'web-vitals' — Declared in ui/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
X30 · Support guard that admits what it rejects · Support guard that admits what it rejects · ×1
  • Support guard that admits what it rejects feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:212 — `!(nonBucketedFeatures.size != transformer.features || transformer.features.isEmpty)` does not say what its shape suggests. By De Morgan a negated `||` distributes as `!transformer.features.isEmpty && nonBucketedFeatures.size == transformer.features`, so this guard fires only where `transformer.features.isEmpty` is ABSENT — and where `nonBucketedFeatures.size` is EXACTLY `transformer.features`, which is the one value the term `nonBucketedFeatures.size != transformer.features` was written to refuse. The two halves disagree about what they are for: `transformer.features.isEmpty` names something the code needs, and `nonBucketedFeatures.size != transformer.features` names a value it cannot handle, and one `!(…)` cannot mean both. Everything with a `nonBucketedFeatures.size` other than `transformer.features` now passes this guard untested, including the values `transformer.features.isEmpty` was there to admit.
Minor — 452 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×346
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file registry/sql-registry/registry/db_registry.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/common/tensor/Primitive.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file registry/purview-registry/registry/purview_registry.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/client/FeathrClient.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/swj/join/SlidingWindowJoinIterator.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/common/tensorbuilder/UniversalTensor.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file registry/purview-registry/registry/models.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file registry/sql-registry/registry/models.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/java/com/linkedin/feathr/common/FeatureValue.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr_project/feathr/definition/source.py:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/MultiLevelAggregationTransform.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/HdfsUtils.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-config/src/main/java/com/linkedin/feathr/core/configvalidator/typesafe/FeatureDefConfigSemanticValidator.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/DataFrameFeatureJoiner.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-compute/src/main/java/com/linkedin/feathr/compute/ComputeGraphs.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/logical/MultiStageJoinPlanner.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/transformation/FDSConversionUtils.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 321 more in this group — see findings.md.
X4 · Structured logging · Interpolated log message defeats structured logging · ×40
  • Interpolated log message defeats structured logging registry/sql-registry/registry/database.py:102 — `warning` at line 102 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/sql-registry/registry/database.py:135 — `debug` at line 135 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/sql-registry/registry/database.py:182 — `warning` at line 182 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/auth.py:85 — `debug` at line 85 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/auth.py:89 — `info` at line 89 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/database.py:70 — `debug` at line 70 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.debug("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.debug("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/database.py:136 — `warning` at line 136 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:38 — `info` at line 38 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:103 — `warning` at line 103 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:112 — `info` at line 112 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:128 — `info` at line 128 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:147 — `warning` at line 147 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.warning("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.warning("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging registry/access_control/rbac/db_rbac.py:162 — `info` at line 162 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging feathr_project/feathr/registry/_feathr_registry_client.py:115 — `info` at line 115 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging feathr_project/feathr/datasets/utils.py:32 — `info` at line 32 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging feathr_project/feathr/datasets/utils.py:40 — `info` at line 40 is handed an f-string as its message, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the record is filtered out. Pass the values beside a constant message instead: `logger.info("order %s moved to %s", order_id, status)` with the standard library's `logging`, which keeps the message and its arguments apart on the record, or `log.info("order moved", order_id=order_id, status=status)` with structlog.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/AclCheckUtils.scala:72 — `info` at line 72 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/AclCheckUtils.scala:79 — `info` at line 79 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:147 — `warn` at line 147 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:212 — `info` at line 212 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/FeathrUtils.scala:216 — `info` at line 216 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:338 — `info` at line 338 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:342 — `info` at line 342 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:457 — `info` at line 457 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:593 — `info` at line 593 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • + 15 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×21
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java:156 — `Objects.equals(_featureExpr, that._featureExpr) && _exprType == that._exprType && Objects.equals( _defaultValue, that._defaultValue) && Obje…` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ComplexFeatureConfig.java, feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExpressionBasedFeatureConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java:90 — `Objects.equals(_featureName, that._featureName) && Objects.equals(_featureTypeConfig, that._featureTypeConfig) && Objects.equals(_defaultVal…` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/ExtractorBasedFeatureConfig.java, feathr-config/src/main/java/com/linkedin/feathr/core/config/producer/anchors/SimpleFeatureConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/FeatureGenConfig.java:69 — `Objects.equals(_operationalConfig, that._operationalConfig) && Objects.equals(_features, that._features)` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/FeatureGenConfig.java, feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/FeatureGenConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OperationalConfig.java:62 — `Objects.equals(_outputProcessorsListConfig, that._outputProcessorsListConfig) && Objects.equals(_name, that._name)` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OperationalConfig.java, feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OperationalConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OfflineOperationalConfig.java:92 — `Objects.equals(_timeSetting, that._timeSetting) && Objects.equals(_retention, that._retention) && Objects.equals(_simulateTimeDelay, that._s…` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/generation/OfflineOperationalConfig.java, feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/generation/OfflineOperationalConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java:132 — `_length == that._length && Objects.equals(_referenceEndTime, that._referenceEndTime) && Objects.equals( _referenceEndTimeFormat, that._refer…` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/config/common/DateTimeConfig.java, feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/DateTimeConfig.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/anchors/AnchorConfigWithKeyBuilder.java:43 — `hasTimeWindowFeatureConfig(features) && config.hasPath(LATERAL_VIEW_PARAMS)` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/anchors/AnchorConfigWithKeyBuilder.java, feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/anchors/AnchorConfigWithKeyExtractorBuilder.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/KafkaConfigBuilder.java:25 — `sourceConfig.hasPath(IS_TIME_SERIES) && sourceConfig.getBoolean(IS_TIME_SERIES)` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/KafkaConfigBuilder.java, feathr-config/src/main/java/com/linkedin/feathr/core/configbuilder/typesafe/producer/sources/SlidingWindowAggrConfigBuilder.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java:126 — `timestampPattern.equalsIgnoreCase(TIMESTAMP_FORMAT_EPOCH) || timestampPattern.equalsIgnoreCase(TIMESTAMP_FORMAT_EPOCH_MILLIS)` appears character-identically in 2 files — feathr-config/src/main/java/com/linkedin/feathr/core/utils/ConfigUtils.java, feathr-impl/src/main/java/com/linkedin/feathr/common/configObj/configbuilder/ConfigUtils.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr_project/feathr/registry/_feathr_registry_client.py:101 — `(source.name == INPUT_CONTEXT) or (not hasattr(source, "_registry_id"))` appears character-identically in 2 files — feathr_project/feathr/registry/_feathr_registry_client.py, feathr_project/feathr/registry/_feature_registry_purview.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate REDACTED:273 — `(timeout_seconds is None) or (time.time() - start_time < timeout_seconds)` appears character-identically in 2 files — REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr_project/feathr/client.py:301 — `dbtable is not None and query is not None` appears character-identically in 2 files — feathr_project/feathr/client.py, feathr_project/feathr/definition/source.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate registry/purview-registry/registry/models.py:247 — `self.def_expr == o.def_expr and self.agg_func == o.agg_func and self.window == o.window and self.group_by == o.group_by and self.filter == o…` appears character-identically in 2 files — registry/purview-registry/registry/models.py, registry/sql-registry/registry/models.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate registry/purview-registry/registry/models.py:673 — `self.from_id == o.from_id and self.to_id == o.to_id and self.conn_type == o.conn_type` appears character-identically in 2 files — registry/purview-registry/registry/models.py, registry/sql-registry/registry/models.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate registry/purview-registry/registry/models.py:183 — `self.key_column == o.key_column and self.key_column_type == o.key_column_type and self.key_column_alias == o.key_column_alias` appears character-identically in 2 files — registry/purview-registry/registry/models.py, registry/sql-registry/registry/models.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate registry/purview-registry/registry/models.py:153 — `self.type == o.type and self.tensor_category == o.tensor_category and self.dimension_type == o.dimension_type and self.val_type == o.val_typ…` appears character-identically in 2 files — registry/purview-registry/registry/models.py, registry/sql-registry/registry/models.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala:218 — `!colName.equals(groupByCol) && !colName.equals(excludeColumn)` appears character-identically in 2 files — feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SeqJoinAggregator.scala, feathr-impl/src/main/scala/com/linkedin/feathr/offline/derived/strategies/SequentialJoinAsDerivation.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala:525 — `dateParam.startDate.nonEmpty && dateParam.endDate.nonEmpty` appears character-identically in 2 files — feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/SourceUtils.scala, feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/datetime/OfflineDateTimeUtils.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala:60 — `featureConfig.isDefined && jobContext.featureConfOverride.isDefined` appears character-identically in 2 files — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala, feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala:65 — `localFeatureConfig.isDefined && jobContext.featureConfOverride.isDefined` appears character-identically in 2 files — feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenConfigOverrider.scala, feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureGenJob.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate feathr-impl/src/main/scala/com/linkedin/feathr/offline/graph/FCMGraphTraverser.scala:100 — `node.isLookup || node.isAggregation || node.isTransformation` appears character-identically in 2 files — feathr-impl/src/main/scala/com/linkedin/feathr/offline/graph/FCMGraphTraverser.scala, feathr-impl/src/main/scala/com/linkedin/feathr/offline/graph/NodeUtils.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D30 · Dependency Vulnerabilities · Low CVE · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
X23 · Unguarded diagnostic materialisation · Diagnostic log message is built whether or not it is wanted · ×4
  • Diagnostic log message is built whether or not it is wanted feathr_project/feathr/registry/_feathr_registry_client.py:205 — `debug` at line 205 is called with an argument built by `json.dumps(body, indent = 2)` (line 205), whose cost grows with the collection it walks. Python evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `isEnabledFor(logging.DEBUG)` test, no debug flag, no `lambda` the logger calls only when the level is on.
  • Diagnostic log message is built whether or not it is wanted feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:249 — `trace` at line 249 is called with an argument built by `rightJoinColumns.mkString("…")` (line 249), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because trace is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
  • Diagnostic log message is built whether or not it is wanted feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala:260 — `trace` at line 260 is called with an argument built by `rightJoinColumns.mkString("…")` (line 260), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because trace is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
  • Diagnostic log message is built whether or not it is wanted feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureJoinJob.scala:115 — `debug` at line 115 is called with an argument built by `pathList.mkString("…")` (line 115), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
D29 · Static Analysis (SAST) · REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×3
  • REDACTED
  • REDACTED
  • REDACTED
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file feathr-impl/src/main/scala/com/linkedin/feathr/offline/job/FeatureTransformation.scala:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file feathr_project/feathr/registry/_feature_registry_purview.py:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file feathr_project/feathr/client.py:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
D31 · IaC & Container Security · Low IaC · ×2
  • REDACTED
  • REDACTED
AC7 · A11y enforcement · Accessibility enforcement below the top rung · ×1
  • Accessibility enforcement below the top rung — An a11y linter is configured (Documented) but there's no automated a11y test or CI gate. Add your test runner's axe binding (jest-axe, vitest-axe, cypress-axe or @axe-core/playwright) to verify at runtime, then gate it in CI. What was searched, so you can tell an absence from a miss: the 49 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
AX6 · Interface segregation · Fat interface · ×1
  • Fat interface: FeatureValueOrBuilder (52 abstract methods) feathr-impl/src/main/java/com/linkedin/feathr/common/types/protobuf/FeatureValueOuterClass.java:11 — `FeatureValueOrBuilder` declares 52 abstract methods: `getBooleanArray`, `getBooleanArrayOrBuilder`, `getBooleanValue`, `getByteArray`, `getByteArrayOrBuilder`, `getDoubleArray`, `getDoubleArrayOrBuilder`, `getDoubleValue`, `getFloatArray`, `getFloatArrayOrBuilder`, `getFloatValue`, `getIntArray`, `getIntArrayOrBuilder`, `getIntValue`, `getLongArray`, `getLongArrayOrBuilder`, `getLongValue`, `getSparseBoolArray`, `getSparseBoolArrayOrBuilder`, `getSparseDoubleArray`, `getSparseDoubleArrayOrBuilder`, `getSparseFloatArray`, `getSparseFloatArrayOrBuilder`, `getSparseIntegerArray`, `getSparseIntegerArrayOrBuilder`, `getSparseLongArray`, `getSparseLongArrayOrBuilder`, `getSparseStringArray`, `getSparseStringArrayOrBuilder`, `getStringArray`, `getStringArrayOrBuilder`, `getStringValue`, `getStringValueBytes`, `hasBooleanArray`, `hasBooleanValue`, `hasByteArray`, `hasDoubleArray`, `hasDoubleValue`, `hasFloatArray`, `hasFloatValue`, and 12 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 3 of 10 project(s) overshoot their size bounds, lowering Project Cohesion to 4.5/10. The most over is `feathr-impl` (40832 LoC, 337 module-visible types across 52 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D34 · Knowledge Freshness · Dormant codebase · ×1
  • Dormant codebase — 349 of 349 significant files have no living knowledge — the codebase as a whole is dormant, not 349 separate risks. Counted over 349 of the 773 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P10 · Library API & versioning · Large public API surface · ×1
  • Large public API surface — 256/330 types (78%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.
P4 · Deployment & Rollback · No release approval gate · ×1
  • No release approval gate — The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY'S PIPELINE FILES. What was read: every file under `.github/workflows/`, `.forgejo/workflows/`, `.gitea/workflows/`, `.azuredevops/` and `.azure-pipelines/`, plus `.gitlab-ci*` and `azure-pipelines*` — with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab's `when: manual`, CircleCI's `type: approval`, an Azure `ManualValidation@` task or an `approvals:` block, a Jenkins `input` step, a `uses:` step naming an approval action, an `environment:` paired with `reviewers` / `required_reviewers` / `protection` / `wait-timer` / `deployment_branch_policy`, a draft-release step, a `workflow_dispatch` promotion, or a release-event gate. ★ What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy — all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
R7 · Dead Code · Unused export 'createFeature' · ×1
  • Unused export 'createFeature' ui/src/api/api.tsx:112 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/api/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/api/index.ts in the same commit, or the barrel will import a name that no longer exists.
R7 · Dead Code · Unused export 'updateFeature' · ×1
  • Unused export 'updateFeature' ui/src/api/api.tsx:120 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/api/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/api/index.ts in the same commit, or the barrel will import a name that no longer exists.
R7 · Dead Code · Unused export 'getUserRole' · ×1
  • Unused export 'getUserRole' ui/src/api/api.tsx:139 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/api/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/api/index.ts in the same commit, or the barrel will import a name that no longer exists.
R7 · Dead Code · Unused export 'getDependent' · ×1
  • Unused export 'getDependent' ui/src/api/api.tsx:246 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/api/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/api/index.ts in the same commit, or the barrel will import a name that no longer exists.
R7 · Dead Code · Unused export 'default' · ×1
  • Unused export 'default' ui/src/hooks/useForceUpdate.ts:3 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/hooks/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/hooks/index.ts in the same commit, or the barrel will import a name that no longer exists.
R7 · Dead Code · Unused export 'useFullScreen' · ×1
  • Unused export 'useFullScreen' ui/src/hooks/useFullScreen.ts:3 — Nothing ultimately consumes this binding: its only referrer is the re-export in ui/src/hooks/index.ts, whose re-exported name has no consumer either. Removing it is therefore not a one-file change — drop the re-export line in ui/src/hooks/index.ts in the same commit, or the barrel will import a name that no longer exists.
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected deploy/nginx.conf:8 — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `nginx.conf` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.)
X2 · Cancellation propagation · Not all async functions that make a request accept an AbortSignal · ×1
  • Not all async functions that make a request accept an AbortSignal — Only 0/9 async functions that make a cancellable request (fetch, axios, ky, ofetch) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
X5 · Nullable reference types · Scala's null is not held to the type system everywhere · ×1
  • Scala's null is not held to the type system everywhere — No build over this repository's 290 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-25be968c3fef46ccb188c6ef5da47360/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-25be968c3fef46ccb188c6ef5da47360/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt --exclude feathr-impl/src/main/java/com/linkedin/feathr/common/types/protobuf --exclude feathr-impl/src/test/java/com/linkedin/feathr/offline/data .99artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update82artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .16artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 5 file(s) — `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureDefinition.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfig.scala`, `feathr-impl/src/main/scala/com/linkedin/feathr/offline/config/TimeWindowFeatureDefinition.scala`, `registry/data-models/models.py`, `registry/data-models/transformation/models.py` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update0artifacts/raw/trivy-fs.json

Run 01a176fc-0238-7bcd-898a-68b44c53e194 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 145 · Warnings: 491 · Recommendations: 452 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 26-10-2026 @ 06:53 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md