Public report — Files, published 5 Aug 2026. Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version; ask the repo owner for the full report.
Watchdog 05-08-2026 @ 00:58 UTC Public
Code Health Audit

Files-Community/Files

58% Adequate
CriticalWeakAdequateStrongExemplary
middle

Large · 109,326 LoC · 11 projects · rebuild ~2.4 person-years · weakest lens: Security (54%)

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

49/52dimensions tool-verifieddeterministic · confidence 1.0 · 3 LLM-assisted, advisory
589findings with an exact file:lineof 607 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
52/97dimensions across the health lenses109326 LoC · 11 projects — wide & deep

Executive summary

Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.

files-community/Files is sound in substance but carries real gaps (58%). It is not in crisis, but the issues below raise the cost of changing it — friction its consumers ultimately inherit.

The area that most needs attention is Security (54%) — exposure to security and compliance incidents is elevated. Code Health (59%) is the next concern — changes there are slower and more error-prone.

Leadership focus, highest impact first: 44 High finding(s) (Static Analysis (SAST)); Name the access rules (Access Controls); 1 No SBOM finding(s) in Supply-chain Provenance & Signing (Supply-chain Provenance & Signing).

For scale: Large (~109,326 production lines); rebuilding it from scratch would take roughly ~2.4 person-years (~1–5 engineers). Approximate, ±~30%.

How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Security 54% · 46% weightCode Health 59% · 25% weightMaturity 61% · 14% weightPerformance 61% · 8% weightReadiness 62% · 4% weightArchitecture 78% · 2% weight

Raise Security 54 → 70 (the Healthy floor) ⇒ headline 58 → ~61.

Code composition — where the lines go
Business logic 44%Plumbing 54%Tests 1%Analyzers 2%
Rebuild cost & value ~ Modeled — €110,000–€590,000
Cost to rebuild€110,000–€590,000 (1.1–3.7 person-years (1,898–6,190 h), ~1–5 engineers)
Domain complexityStandard — harder problems cost more per line
Quality factor0.8× (at 58% quality) — the last 20% of quality is most of the work
Size & shapeLarge · 36% boilerplate · 18% straight-line · 45% branching logic

This codebase represents roughly ~2.4 person-years of build effort (about ~€350,000 to rebuild). Its weakest lens is Security at 54% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.2) — desktop/game, high decision density × a 0.8× quality factor, at €60–95/h; indicative, ±~30%. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Resolve the 1 No SBOM finding(s) in Supply-chain Provenance & Signing.
+2.9 pts · Low effort · Supply-chain Provenance & Signing
2
Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing.
+2.9 pts · Low effort · Supply-chain Provenance & Signing
3
Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing.
+2.9 pts · Low effort · Supply-chain Provenance & Signing

Diagnosis — what's actually going on

Value concentrated against a weak lens · Medium · Value at risk
This is a Large asset (~2.4 person-years to rebuild), and its weakest lens is Security at 54%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
Evidence: valuation: Large, ~2.4 person-years rebuild (109,326 LoC) · weakest lens: Security 54%
→ Direct remediation budget at Security first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Resolve the 44 High finding(s) in Static Analysis (SAST) — start with ci.yml (12), cd-sideload-preview.yml (8), cd-sideload-stable.yml (8). The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Resolve the 44 High finding(s) in Static Analysis (SAST) — start with ci.yml (12), cd-sideload-preview.yml (8), cd-sideload-stable.yml (8).

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

arch Files.App App Files.App.BackgroundTasks BackgroundTasks Files.App->Files.App.BackgroundTasks Files.App.Controls Controls Files.App->Files.App.Controls Files.App.CsWin32 CsWin32 Files.App->Files.App.CsWin32 Files.App.Storage Storage Files.App->Files.App.Storage Files.Core.Storage Storage Files.App->Files.Core.Storage Files.Shared Shared Files.App->Files.Shared Files.App.Controls->Files.Shared Files.App.CsWin32->Files.Shared Files.App.Server Server Files.App.Server->Files.App.CsWin32 Files.App.Server->Files.Shared Files.App.Storage->Files.App.CsWin32 Files.App.Storage->Files.Core.Storage Files.App.Storage->Files.Shared

Architecture — module dependency matrix

137 modules, 502 dependencies — 3 dependency cycles, shown as the red cell(s) above the diagonal. Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)

Files.App.ControlsFiles.App.Data.EnumsFiles.Shared.Utils…dows.Win32.Foundation…ces.DateTimeFormatter…p.UserControls.TabBar…pp.ViewModels.Dialogs…ViewModels.Properties…p.ViewModels.Settings…dows.Win32.System.Com…I.WindowsAndMessagingFiles.App.Utils…logs.FileSystemDialogWindows.Win32.UI.ShellFiles.App.DialogsFiles.App.ViewModelsWindows.Win32Files.App.StorageFiles.App.Utils.Shell…ewModels.UserControls…pp.Utils.StatusCenterFiles.App.UserControls…les.App.Views.Layouts…s.App.Data.ParametersFiles.App.Helpers…les.App.Utils.StorageFiles.App.Data.Items…p.Data.EventArgumentsFiles.App.Views.Shells…es.App.Data.Contracts…p.ViewModels.PreviewsFiles.App.Views…les.App.Data.ContextsFiles.App.Actions…les.App.Data.CommandsFiles.App.Data.ModelsFiles.App…es.App.Data.FactoriesFiles.App.Services….UserControls.WidgetsFiles.App.Controls1Files.App.Data.Enums2Files.Shared.Utils3…dows.Win32.Foundation4…ces.DateTimeFormatter5…p.UserControls.TabBar6…pp.ViewModels.Dialogs7…ViewModels.Properties8…p.ViewModels.Settings9…dows.Win32.System.Com10…I.WindowsAndMessaging11Files.App.Utils12…logs.FileSystemDialog13Windows.Win32.UI.Shell14Files.App.Dialogs15Files.App.ViewModels16Windows.Win3217Files.App.Storage18Files.App.Utils.Shell19…ewModels.UserControls20…pp.Utils.StatusCenter21Files.App.UserControls22…les.App.Views.Layouts23…s.App.Data.Parameters24Files.App.Helpers25…les.App.Utils.Storage26Files.App.Data.Items27…p.Data.EventArguments28Files.App.Views.Shells29…es.App.Data.Contracts30…p.ViewModels.Previews31Files.App.Views32…les.App.Data.Contexts33Files.App.Actions34…les.App.Data.Commands35Files.App.Data.Models36Files.App37…es.App.Data.Factories38Files.App.Services39….UserControls.Widgets4051142213123123583281710314171813738132123721444111115772222221212511253215211684317602031211251318651112111121151738621181115154342156441211771811111263311623111793162527113111114316182195431114125263311211316123329531332111111111311416514215112162323141218311042121829111871011242167179616213821121121146111116111331321111713531221129+97 more modules (most-connected shown)

At a glance — Code Health · 59% · Adequate

At a glance — Architecture · 78% · Adequate · gated by AX2

At a glance — Maturity · 61% · Adequate · gated by M2

At a glance — Readiness · 62% · Adequate · gated by P3

At a glance — Security · 54% · Adequate · gated by D29, D36

At a glance — Performance · 61% · Adequate

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2021 — Injection44High / Critical

Roadmap

Begin by resolving the 44 high-severity findings in static analysis, focusing first on the CI and CD pipeline configurations. Next, improve access control by explicitly naming and isolating authorization policies for independent review and testing. Finally, address the three supply-chain risks by generating a software bill of materials, establishing build provenance, and pinning build actions to ensure integrity.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No SBOM finding(s) in Supply-chain Provenance & Signing.+2.9 ptsLowSupply-chain Provenance & Signing
Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing.+2.9 ptsLowSupply-chain Provenance & Signing
Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing.+2.9 ptsLowSupply-chain Provenance & Signing
Resolve the 44 High finding(s) in Static Analysis (SAST) — start with ci.yml (12), cd-sideload-preview.yml (8), cd-sideload-stable.yml (8).+3.8 ptsMediumStatic Analysis (SAST)
Name the access rules — give each one a named predicate/policy object your guards consult, so the rule set can be reviewed and unit-tested independently of the call sites that enforce it.+3.8 ptsMediumAccess Controls
Resolve the 40 EmptyCatchBlock finding(s) in Explicit Debt — start with ShellFileOperations2.cs (3), ShellViewModel.cs (3), UpdateTask.cs (2).+1.3 ptsMediumExplicit Debt
Resolve the 1 No ADRs found finding(s) in ADR Quality.+1.2 ptsLowADR Quality
Thread a CancellationToken through async methods so work stops promptly on cancellation.+1.7 ptsMediumCancellation propagation

File quality

Per-file score 0–10 — a quality signature. Of 189 files carrying findings, judged against the Production bar: 2% slop · 60% mixed · 38% near-clean.

FileScoreBandWorst signal
src/Files.App/ViewModels/ShellViewModel.cs1.0SlopExplicit Debt: EmptyCatchBlock
src/Files.App/Views/Layouts/BaseLayoutPage.cs1.3SlopExplicit Debt: EmptyCatchBlock
src/Files.App/ViewModels/Settings/AdvancedViewModel.cs1.5SlopExplicit Debt: EmptyCatchBlock
src/Files.App/Helpers/Win32/Win32Helper.Storage.cs3.5SlopExplicit Debt: EmptyCatchBlock
src/Files.App/ViewModels/MainPageViewModel.cs4.2MixedExplicit Debt: EmptyCatchBlock
.github/workflows/ci.yml4.4MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
.github/workflows/cd-sideload-preview.yml4.4MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
.github/workflows/cd-sideload-stable.yml4.4MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
.github/workflows/cd-store-preview.yml4.5MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
.github/workflows/cd-store-stable.yml4.5MixedStatic Analysis (SAST): High: github-actions-mutable-action-tag
src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs4.6MixedExplicit Debt: EmptyCatchBlock
src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs4.6MixedExplicit Debt: EmptyCatchBlock
src/Files.App/Services/App/AppUpdateStoreService.cs4.6MixedExplicit Debt: EmptyCatchBlock
tests/Files.InteractionTests/Tests/SettingsTests.cs4.6MixedTest Quality: No assertions (empty test): VerifySettingsAreAccessible
src/Files.App/ViewModels/UserControls/SidebarViewModel.cs4.8MixedCyclomatic Complexity: SidebarViewModel.HandleLocationItemDragOverAsync (cyclomatic 24)
src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs4.8MixedExplicit Debt: EmptyCatchBlock
src/Files.App/Services/Windows/WindowsJumpListService.cs4.9MixedExplicit Debt: EmptyCatchBlock
src/Files.App/Services/App/AppUpdateSideloadService.cs4.9MixedExplicit Debt: EmptyCatchBlock
src/Files.App/UserControls/TabBar/TabBar.xaml.cs4.9MixedExplicit Debt: EmptyCatchBlock
src/Files.App/Program.cs5.0MixedExplicit Debt: EmptyCatchBlock

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 49 of 52 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 3 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.6 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 52 dimensions across the health lenses
D1D2D3D4D5D6D9D10D12D13D14D15D16D17D18D19D20D21D26D27D28D29D34D35D36AX1AX10AX2AX3AX4AX5AX6AX8C2GD1IC1M1M2M3M4P1P2P3P4PF1PF2PF3X1X2X3X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 589 of 607 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
jscpdCode duplication✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.302✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.302✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 019fcf6e-0a81-7e33-ac36-288598739630.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D24 Comment Value — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".

The LLM boundary

LLM-set scores this run (4): D19, D20, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity6.4 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Prevented

92 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ContentPageContextFlyoutFactory.GetBaseItemMenuItems at 71. A further 13 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being DetailsLayoutPage.ResizeColumnToFit at 35 — they are counted neither in the figure above nor in this dimension's score.

ContentPageContextFlyoutFactory.GetBaseItemMenuItems (cyclomatic 71)src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:78
FolderSearch.SearchWithWin32Async (cyclomatic 45)src/Files.App/Utils/Storage/Search/FolderSearch.cs:390
MainWindow.InitializeApplicationAsync (cyclomatic 43)src/Files.App/MainWindow.xaml.cs:53
ShellViewModel.LoadExtendedItemPropertiesAsync (cyclomatic 43)src/Files.App/ViewModels/ShellViewModel.cs:1350
StatusCenterHelper.UpdateCardStrings (cyclomatic 42)src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:614

+ 87 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 ContentPageContextFlyoutFactory.GetBaseItemMenuItems (cyclomatic 71) finding(s) in Cyclomatic Complexity — start with ContentPageContextFlyoutFactory.cs. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 FolderSearch.SearchWithWin32Async (cyclomatic 45) finding(s) in Cyclomatic Complexity — start with FolderSearch.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 MainWindow.InitializeApplicationAsync (cyclomatic 43) finding(s) in Cyclomatic Complexity — start with MainWindow.xaml.cs. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.7 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Prevented

171 method(s) exceeded the cognitive complexity threshold of 15; the worst was FilesystemOperations.MoveAsync at 93.

FilesystemOperations.MoveAsync (cognitive 93)src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:300
FilesystemOperations.CopyAsync (cognitive 83)src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:114
FolderSearch.SearchWithWin32Async (cognitive 83)src/Files.App/Utils/Storage/Search/FolderSearch.cs:390
NavigationHelpers.OpenFile (cognitive 80)src/Files.App/Helpers/Navigation/NavigationHelpers.cs:635
LaunchHelper.HandleApplicationLaunch (cognitive 72)src/Files.App/Utils/Shell/LaunchHelper.cs:57

+ 166 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 FilesystemOperations.MoveAsync (cognitive 93) finding(s) in Cognitive Complexity — start with FilesystemOperations.cs. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 FilesystemOperations.CopyAsync (cognitive 83) finding(s) in Cognitive Complexity — start with FilesystemOperations.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 FolderSearch.SearchWithWin32Async (cognitive 83) finding(s) in Cognitive Complexity — start with FolderSearch.cs. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.2 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Prevented

51 god class(es) detected.

TooManyMethods: SidebarViewModel · ×31src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:0
FileTooLong: ViewModels/ShellViewModel.cs · ×11src/Files.App/ViewModels/ShellViewModel.cs:0
ClassTooLong: NavigationToolbarViewModel · ×9src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:0

What to do

  1. Resolve the 31 TooManyMethods finding(s) in God Classes — start with SidebarViewModel.cs, ShellViewModel.cs, DetailsLayoutPage.xaml.cs. — One of this dimension's main actionable groups (31 warning-level).
  2. Resolve the 11 FileTooLong finding(s) in God Classes — start with ShellViewModel.cs, BaseLayoutPage.cs, SidebarViewModel.cs. — One of this dimension's main actionable groups (11 warning-level).
  3. Resolve the 9 ClassTooLong finding(s) in God Classes — start with NavigationToolbarViewModel.cs, DigitalSignaturesUtil.cs, StatusCenterHelper.cs. — One of this dimension's main actionable groups (9 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.7 / 10Exemplary✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

58 duplicated block group(s) detected.

Duplicated block (12 lines × 2) · ×11src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:159
Duplicated block (14 lines × 2) · ×6src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:359
Duplicated block (9 lines × 2) · ×6src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:348
Duplicated block (10 lines × 2) · ×4src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:48
Duplicated block (8 lines × 2) · ×4src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:703

+ 14 more group(s) — more in Appendix A; the complete list is findings.md.

✓ On the Gold path — maintain.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling9.3 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: DocumentedVerifiedPrevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Prevented

11 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: Files.App.BackgroundTasks · ×2

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: DocumentedVerifiedPrevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Verified

19 of 231 classes have LCOM4 above 3.

Low cohesion: DetailsLayoutPage (LCOM4 16) · ×19src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:26

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

3 test methods: 3 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality6.2 / 10Adequate✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Prevented

0 skipped, 1 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 3 tests.

No assertions (empty test): VerifySettingsAreAccessibletests/Files.InteractionTests/Tests/SettingsTests.cs:19

What to do

  1. Resolve the 1 No assertions (empty test) finding(s) in Test Quality — start with SettingsTests.cs. — One of this dimension's main actionable groups (1 issue-level).
  2. Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D12 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 outdated, 0 vulnerable, 0 deprecated packages.

✓ On the Gold path — maintain.

Detailed fixes: d12_recommendation.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 16 packages use a banned license.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.7 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: DocumentedVerifiedPrevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: src/Files.App/ViewModels/ShellViewModel.cs (7×43=301); src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs (3×71=213); src/Files.App/Views/Layouts/BaseLayoutPage.cs (5×41=205)

Hotspot: src/Files.App/ViewModels/ShellViewModel.cs · ×10src/Files.App/ViewModels/ShellViewModel.cs

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor9.2 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: DocumentedVerifiedPrevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Documented

32 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs.

Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.0 / 10Strong✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: DocumentedVerifiedPrevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Prevented

128 deducted debt markers + 0 dead symbols across 109326 LoC (0.5/KLoC) → score 9.0.

EmptyCatchBlock · ×40src/Files.App.BackgroundTasks/UpdateTask.cs:23
TodoComment · ×59src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Storage.cs:90
CommentedOutCode · ×12src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:82
ObsoleteWithCallers · ×9src/Files.App.Storage/Legacy/NativeStorageLegacy/NativeStorageService.cs:9
BarePragmaDisable · ×3src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:901

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 40 EmptyCatchBlock finding(s) in Explicit Debt — start with ShellFileOperations2.cs (3), ShellViewModel.cs (3), UpdateTask.cs (2). — One of this dimension's main actionable groups (40 issue-level).
  2. Resolve the 59 TodoComment finding(s) in Explicit Debt — start with ContextMenu.cs (4), App.xaml.cs (3), FilesystemOperations.cs (3). — One of this dimension's main actionable groups (59 warning-level).
  3. Resolve the 12 CommentedOutCode finding(s) in Explicit Debt — start with StorageRing.Properties.cs (2), CopyEngineResult.cs (2), SettingsTests.cs (2). — One of this dimension's main actionable groups (12 warning-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

11 projects, 1129 source files, 110162 hand-written lines of code (109326 production / 836 test), 14 inter-project edges (build status unknown — did not finish).

Thin analysable surface across projects
Build status unknown

✓ On the Gold path — maintain.

Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality / 10Adequate◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Adequate / 10 · rule-coverage 100% · ceiling Documented

Files has a strong README that explains the project and its community-driven install model plus links to the website, GitHub CI, Crowdin localization, and Discord. The architecture/Docs markdown files are thin (only one file), but the interop/unmarshaled-conversion doc is solid with goal, workflow, and call-site examples. XML-doc coverage is low across most assemblies: 11% for the app assembly as a whole and 0% for server, background tasks, and storage.

XML-doc coverage: Files.Core.SourceGenerator · ×9src/Files.Core.SourceGenerator/Files.Core.SourceGenerator.csproj

What to do

  1. Improve Documentation Quality — currently 6.0/10. — Files has a strong README that explains the project and its community-driven install model plus links to the website, GitHub CI, Crowdin localization, and Discord. The architecture/Docs markdown files are thin (only one file), but the interop/unmarshaled-conversion doc is solid with goal, workflow, and call-site examples. XML-doc coverage is low across most assemblies: 11% for the app assembly as a whole and 0% for server, background tasks, and storage.

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality / 10Critical◐ Sampled · advisory

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: DocumentedVerifiedPrevented · effective Critical / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency / 10Exemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 200 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D26 · Project Cohesion8.2 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: DocumentedVerifiedPrevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Documented

1 of 11 projects flagged as possibly oversized/incoherent.

Split Files.App

What to do

  1. Resolve the 1 Split Files.App finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.3 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: DocumentedVerifiedPrevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

72 % of calls cross a namespace and 5 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)0.0 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: DocumentedVerifiedPrevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

44 finding(s): 0 critical, 44 high, 0 medium, 0 low.

High: dependabot-missing-cooldown · ×44.github/dependabot.yml:3detected by semgrep finding

What to do

  1. Resolve the 44 High finding(s) in Static Analysis (SAST) — start with ci.yml (12), cd-sideload-preview.yml (8), cd-sideload-stable.yml (8). — One of this dimension's main actionable groups (44 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness9.1 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: DocumentedVerifiedPrevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Documented

34 of 380 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs.

Further orphaned files (smaller)

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: CommandManager.cs↔IContentPageContext.cs 71%; LayoutPreferencesDatabase.cs↔FileTagsDatabase.cs 60%; ISidebarViewModel.cs↔SidebarItem.cs 60%

Change coupling: CommandManager.cs ↔ IContentPageContext.cs · ×6src/Files.App/Data/Commands/Manager/CommandManager.cs

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: DocumentedVerifiedPrevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

Unpinned build actions
No build provenance
No SBOM

What to do

  1. Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 No SBOM finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

AX10 · Code composition8.5 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).
AX2 · Stateful singletons3.9 / 10Weak✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `AppModel` is a singleton (one shared instance) but mutates instance state outside any lock (_TabStripSelectedIndex, _IsAppElevated, _IsPasteEnabled, _ForceProcessTermination, _GoogleDrivePath, _PCloudDrivePath; e.g. `_TabStripSelectedIndex` at line 41). — AppModel.cs:12
  • `StorageHistoryWrapper` is a singleton (one shared instance) but mutates instance state outside any lock (index, histories; e.g. `index` at line 21). — StorageHistoryWrapper.cs:6
  • `QuickAccessManager` is a singleton (one shared instance) but mutates instance state outside any lock (PinnedItemsWatcher; e.g. `PinnedItemsWatcher` at line 34). — QuickAccessManager.cs:8
  • `RecentFilesWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsEmptyRecentFilesTextVisible, _IsRecentFilesDisabledInWindows; e.g. `_IsEmptyRecentFilesTextVisible` at line 38). — RecentFilesWidgetViewModel.cs:16
  • `FileTagsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_isInitialized, _updateCTS; e.g. `_isInitialized` at line 52). — FileTagsWidgetViewModel.cs:13
  • `NetworkLocationsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsNoNetworkLocations; e.g. `_IsNoNetworkLocations` at line 38). — NetworkLocationsWidgetViewModel.cs:16
  • `ToolbarCustomizationViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (SelectedToolbarContextId, isSessionActive, HasToolbarChanges, searchGeneration, isApplyingItems, toolbarItemsByContext; e.g. `SelectedToolbarContextId` at line 51). — ToolbarCustomizationViewModel.cs:10
  • `AppearanceViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (selectedAppThemeResources, selectedThemeIndex, selectedBackdropMaterial, selectedImageStretchType, selectedImageVerticalAlignmentType, selectedImageHorizontalAlignmentType; e.g. `selectedAppThemeResources` at line 188). — AppearanceViewModel.cs:12
  • `StatusCenterViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_AverageOperationProgressValue, _ShowProgressRing; e.g. `_AverageOperationProgressValue` at line 16). — StatusCenterViewModel.cs:6
  • `ShelfViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_watchers; e.g. `_watchers` at line 70). — ShelfViewModel.cs:14
  • `DrivesViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (drives, showUserConsentOnInit; e.g. `drives` at line 15). — DrivesViewModel.cs:10
  • `SidebarViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (paneHolder, sidebarDisplayMode, currentPath, selectedSidebarItem, dispatcherQueue, rightClickedItem; e.g. `paneHolder` at line 36). — SidebarViewModel.cs:24
  • `InfoPaneViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (isEnabled, selectedItem, selectedDriveItem, previewPaneState, _DirectoryItemCount, showCloudItemButton; e.g. `isEnabled` at line 36). — InfoPaneViewModel.cs:16
  • `MainPageViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsSidebarPaneOpen, _IsSidebarPaneOpenToggleButtonVisible, selectedTabItem, shouldPreviewPaneBeActive, shouldPreviewPaneBeDisplayed; e.g. `_IsSidebarPaneOpen` at line 46). — MainPageViewModel.cs:20
  • `LibGit2Service` is a singleton (one shared instance) but mutates instance state outside any lock (_isExecutingGitAction; e.g. `_isExecutingGitAction` at line 38). — LibGit2Service.cs:9
  • `NetworkService` is a singleton (one shared instance) but mutates instance state outside any lock (_Computers, _Shortcuts; e.g. `_Computers` at line 34). — StorageNetworkService.cs:14
  • `UserSizeProvider` is a singleton (one shared instance) but mutates instance state outside any lock (provider; e.g. `provider` at line 52). — UserSizeProvider.cs:8
  • `UserDateTimeFormatter` is a singleton (one shared instance) but mutates instance state outside any lock (formatter; e.g. `formatter` at line 36). — UserDateTimeFormatter.cs:6
  • `AddItemService` is a singleton (one shared instance) but mutates instance state outside any lock (_cached; e.g. `_cached` at line 13). — WindowsShellService.cs:7
  • `ShelfContext` is a singleton (one shared instance) but mutates instance state outside any lock (_SelectedItems; e.g. `_SelectedItems` at line 23). — ShelfContext.cs:7
  • `SidebarContext` is a singleton (one shared instance) but mutates instance state outside any lock (_RightClickedItem; e.g. `_RightClickedItem` at line 37). — SideBarContext.cs:7
  • `TagsContext` is a singleton (one shared instance) but mutates instance state outside any lock (_TaggedItems; e.g. `_TaggedItems` at line 21). — TagsContext.cs:8
  • `MultitaskingContext` is a singleton (one shared instance) but mutates instance state outside any lock (control, isPopupOpen, selectedTabIndex, tabCount, currentTabIndex; e.g. `control` at line 52). — MultitaskingContext.cs:10
  • `WindowContext` is a singleton (one shared instance) but mutates instance state outside any lock (isCompactOverlay; e.g. `isCompactOverlay` at line 36). — WindowContext.cs:9
  • `HomePageContext` is a singleton (one shared instance) but mutates instance state outside any lock (selectedTaggedItems, rightClickedItem, itemContextFlyoutMenu; e.g. `selectedTaggedItems` at line 27). — HomePageContext.cs:9
  • `DisplayPageContext` is a singleton (one shared instance) but mutates instance state outside any lock (_LayoutType, _SortOption, _SortDirection, _GroupOption, _GroupDirection, _GroupByDateUnit; e.g. `_LayoutType` at line 159). — DisplayPageContext.cs:6
  • `ContentPageContext` is a singleton (one shared instance) but mutates instance state outside any lock (filesystemViewModel, pageType, selectedItems; e.g. `filesystemViewModel` at line 99). — ContentPageContext.cs:10
  • `MultiPanesContext` is a singleton (one shared instance) but mutates instance state outside any lock (_ShellPaneArrangement, _mainPanesPage, _ActivePane, _ActivePaneOrColumn; e.g. `_ShellPaneArrangement` at line 68). — MultiPanesContext.cs:7
  • `UserSettingsService` is a singleton (one shared instance) but mutates instance state outside any lock (_GeneralSettingsService, _FoldersSettingsService, _AppearanceSettingsService, _InfoPaneSettingsService, _LayoutSettingsService, _ApplicationSettingsService; e.g. `_GeneralSettingsService` at line 15). — UserSettingsService.cs:10
  • `SideloadUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_isUpdateAvailable, _isUpdating, _updateProgress, _areReleaseNotesAvailable; e.g. `_isUpdateAvailable` at line 44). — AppUpdateSideloadService.cs:17
  • `StoreUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_isUpdateAvailable, _isUpdating, _updateProgress, _areReleaseNotesAvailable, _storeContext, _updatePackages; e.g. `_isUpdateAvailable` at line 27). — AppUpdateStoreService.cs:16
  • `DummyUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_areReleaseNotesAvailable; e.g. `_areReleaseNotesAvailable` at line 19). — AppUpdateNoneService.cs:5

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.5 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface member counts; fat-interface threshold (over 15 members) flagged per type. Deterministic, type-level.

  • `IRichCommand` declares 22 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IRichCommand.cs:15
  • `IContentPageContext` declares 18 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IContentPageContext.cs:6
  • `IAppearanceSettingsService` declares 24 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IAppearanceSettingsService.cs:9
  • `IFoldersSettingsService` declares 18 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IFoldersSettingsService.cs:6
  • `IGeneralSettingsService` declares 71 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IGeneralSettingsService.cs:6
  • `ILayoutSettingsService` declares 44 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — ILayoutSettingsService.cs:6
  • `IShellPage` declares 29 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IShellPage.cs:8
  • `IShellPanesPage` declares 17 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IShellPanesPage.cs:9
  • `IVersionControlService` declares 23 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IVersionControlService.cs:15
  • `IListedItem` declares 65 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IListedItem.cs:10
  • `IFilesystemHelpers` declares 24 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IFilesystemHelpers.cs:9
  • `IFilesystemOperations` declares 20 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IFilesystemOperations.cs:14
  • `IBaseStorageFolder` declares 23 members. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — IBaseStorageFolder.cs:11

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

C2 · Access Controls7.0 / 10Strong✓ Tool-verified

Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.

Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.

  • Authorization IS enforced here (by imperative guard methods that throw on violation) — this is NOT a claim that the code is unprotected. What's missing is a NAMED rule set: the guards encode the access rules inline, so the rules can't be listed, reviewed or tested apart from the call sites that apply them. Recommendation, not a defect.

What to do

  • Name the access rules — give each one a named predicate/policy object your guards consult, so the rule set can be reviewed and unit-tested independently of the call sites that enforce it.
GD1 · Unfinished & placeholder code9.9 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×16) — AdaptiveHeightValueConverter.cs:42, WindowsFile.cs:19, EnumToBoolConverter.cs:20, …

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs6.7 / 10Adequate✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `AutoSuggestBox_KeyDown` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — Omnibar.Events.cs:76
  • `ItemBorder_DragOver` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — SidebarItem.cs:482
  • `OpenStreamAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — WindowsFile.cs:17
  • `ExecuteAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — OpenItemAction.cs:134
  • `SwitchPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — PowerToysPeekProvider.cs:20
  • `DoPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — PowerToysPeekProvider.cs:25
  • `DetectAvailability` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. (×2) — PowerToysPeekProvider.cs:49, SeerProProvider.cs:80
  • `TogglePreviewPopupAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — SeerProProvider.cs:37
  • `IsEncodingUndeterminedAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — StorageArchiveService.cs:381
  • `DetectEncodingAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — StorageArchiveService.cs:399
  • `FetchOrigin` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — GitHelpers.cs:37
  • `RenameAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — VirtualStorageItem.cs:101, VirtualStorageItem.cs:106
  • `DeleteAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — VirtualStorageItem.cs:111, VirtualStorageItem.cs:116
  • `ClearThumbnailCacheAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — AdvancedViewModel.cs:402
  • `UpdateCacheSizeAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — AdvancedViewModel.cs:407
  • `AddPageAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — GeneralViewModel.cs:361
  • `LoadPreviewAndDetailsAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — HtmlPreviewViewModel.cs:15
  • `SaveChangesAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — HashesPage.xaml.cs:56
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×9) — GripperHoverWrapper.cs:84, GripperHoverWrapper.cs:96, GripperHoverWrapper.cs:120, …

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)5.2 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

  • 504 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.

What to do

  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 11 of 11 project(s) that lack one — worth up to 2 pts.
  • Review the README against recent changes; refresh the parts that drifted.
M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P2 · Observability5.3 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 4/9 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 9, 2 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.

What to do

  • Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
  • Consider OpenTelemetry tracing/metrics and a health-check endpoint for operability.
P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add CodeQL's csharp pack (it analyses VB.NET too), or a security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step.

What to do

  • Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack (it analyses VB.NET too), or a security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

PF1 · Benchmark discipline6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the library protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

  • No benchmark suite was found. Where code is performance-sensitive, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.

What to do

  • Add a benchmarking harness for the hot paths and run it in CI to catch regressions (for .NET, a BenchmarkDotNet project with [MemoryDiagnoser] to track allocations).
PF2 · Allocation hygiene6.3 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 63 use(s) across 109,503 production line(s) (~0.6/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code keeps its host responsive — a library awaits with ConfigureAwait(false) (so it never captures and stalls the host's context) and avoids sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) that wastes threads and risks deadlock.

Method: Production-source scan: sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) counted everywhere, and — for a library with ≥5 awaits — the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • 4 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock in a consumer with a synchronization context.

What to do

  • Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult() in library code.
X1 · Async correctness6.1 / 10Adequate✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×4) — AsyncManualResetEvent.cs:46, Program.cs:288, Program.cs:298, …
  • `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. (×21) — UpdateTask.cs:16, BladeView.cs:110, BaseSetAsAction.cs:41, …

What to do

  • Sync-over-async (deadlock risk)
X2 · Cancellation propagation5.1 / 10Adequate✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage.

  • Only 107/594 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×25) — LinqExtensions.cs:101, SafetyExtensions.cs:32, SafetyExtensions.cs:72, …

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X3 · Exception handling5.6 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×25) — UpdateTask.cs:23, UpdateTask.cs:26, SidebarItem.cs:211, …

What to do

  • Swallowed exception (empty catch)
X4 · Structured logging5.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. Deterministic.

  • Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×25) — App.xaml.cs:120, App.xaml.cs:166, App.xaml.cs:178, …

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types8.6 / 10Strong✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 8/9 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
  • ~0.7 `!` suppressions per 1k syntax nodes — 48 suppression(s) across the 65390 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health59%AdequateAcceptable, with room to improve.
Architecture78%Adequate — gated by AX2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity61%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness62%Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security54%Adequate — gated by D29, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance61%AdequateStrongest area.
Not included — 45 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • D11 Test Reliability — Test reliability not measured — no test run produced results
  • D22 Internal API Consistency — No exposed public API
  • D23 Boundary Type-Coupling — Bounded contexts not declared
  • D24 Comment Value — LLM evaluation failed
  • D25 ADR Conformance — no ADRs to check
  • D30 Dependency Vulnerabilities — the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan for NuGet CVEs — excluded rather than scored; re-run on an SDK that can restore this solution
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
  • D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D38 OSV Dependency Vulnerabilities — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.
  • D39 IL Efficiency — The target did not build, so no IL was available to measure.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage not measured
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this check looks for (1 value object(s))
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
  • P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
  • P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
  • P8 Schema migrations — no EF Core usage detected
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
  • S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X6 Hand-rolled structured-format parsing — Reported, not scored — this card publishes what it found rather than grading it. Its content is the findings and the key metric above.
  • X7 Silent fallback defaults — Reported, not scored — this card publishes what it found rather than grading it. Its content is the findings and the key metric above.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Issue — 85 finding(s)
D29 · Static Analysis (SAST) · High · ×44
  • High: dependabot-missing-cooldown .github/dependabot.yml:3 — This Dependabot configuration does not set a cooldown period. Newly published packages can be malicious or unstable. Add a `cooldown` block with `default-days: 7` to each `package-ecosystem` entry under `updates` to wait 7 days before proposing updates to newly published package versions. Reference: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#cooldown. This is a semgrep security-AUDIT rule reporting a POLICY that is absent or weaker than its recommendation, not an exploitable defect. Confirm whether the current setting is a deliberate decision for this repository — and apply the change where it is not; where it is (a policy your release process already enforces elsewhere, or one this repository has consciously opted out of), record the decision and leave the configuration as it is.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:44 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:46 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: microsoft/setup-msbuild@<40-character SHA>`. This step references `microsoft/setup-msbuild@v3`; resolve the SHA it points at today with `gh api repos/microsoft/setup-msbuild/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:48 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: NuGet/setup-nuget@<40-character SHA>`. This step references `NuGet/setup-nuget@v3`; resolve the SHA it points at today with `gh api repos/NuGet/setup-nuget/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:50 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-dotnet@<40-character SHA>`. This step references `actions/setup-dotnet@v5`; resolve the SHA it points at today with `gh api repos/actions/setup-dotnet/commits/v5 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:102 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/artifact-signing-action@<40-character SHA>`. This step references `Azure/artifact-signing-action@v1`; resolve the SHA it points at today with `gh api repos/Azure/artifact-signing-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:158 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/artifact-signing-action@<40-character SHA>`. This step references `Azure/artifact-signing-action@v1`; resolve the SHA it points at today with `gh api repos/Azure/artifact-signing-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:180 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: ryand56/r2-upload-action@<40-character SHA>`. This step references `ryand56/r2-upload-action@latest`; resolve the SHA it points at today with `gh api repos/ryand56/r2-upload-action/commits/latest --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-preview.yml:190 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/upload-artifact@<40-character SHA>`. This step references `actions/upload-artifact@v7`; resolve the SHA it points at today with `gh api repos/actions/upload-artifact/commits/v7 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:44 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:46 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: microsoft/setup-msbuild@<40-character SHA>`. This step references `microsoft/setup-msbuild@v3`; resolve the SHA it points at today with `gh api repos/microsoft/setup-msbuild/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:48 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: NuGet/setup-nuget@<40-character SHA>`. This step references `NuGet/setup-nuget@v3`; resolve the SHA it points at today with `gh api repos/NuGet/setup-nuget/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:50 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-dotnet@<40-character SHA>`. This step references `actions/setup-dotnet@v5`; resolve the SHA it points at today with `gh api repos/actions/setup-dotnet/commits/v5 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:102 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/artifact-signing-action@<40-character SHA>`. This step references `Azure/artifact-signing-action@v1`; resolve the SHA it points at today with `gh api repos/Azure/artifact-signing-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:158 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/artifact-signing-action@<40-character SHA>`. This step references `Azure/artifact-signing-action@v1`; resolve the SHA it points at today with `gh api repos/Azure/artifact-signing-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:180 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: ryand56/r2-upload-action@<40-character SHA>`. This step references `ryand56/r2-upload-action@latest`; resolve the SHA it points at today with `gh api repos/ryand56/r2-upload-action/commits/latest --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-sideload-stable.yml:190 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/upload-artifact@<40-character SHA>`. This step references `actions/upload-artifact@v7`; resolve the SHA it points at today with `gh api repos/actions/upload-artifact/commits/v7 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:41 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:43 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: microsoft/setup-msbuild@<40-character SHA>`. This step references `microsoft/setup-msbuild@v3`; resolve the SHA it points at today with `gh api repos/microsoft/setup-msbuild/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:45 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: NuGet/setup-nuget@<40-character SHA>`. This step references `NuGet/setup-nuget@v3`; resolve the SHA it points at today with `gh api repos/NuGet/setup-nuget/commits/v3 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:47 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-dotnet@<40-character SHA>`. This step references `actions/setup-dotnet@v5`; resolve the SHA it points at today with `gh api repos/actions/setup-dotnet/commits/v5 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:99 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/artifact-signing-action@<40-character SHA>`. This step references `Azure/artifact-signing-action@v1`; resolve the SHA it points at today with `gh api repos/Azure/artifact-signing-action/commits/v1 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-preview.yml:149 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/upload-artifact@<40-character SHA>`. This step references `actions/upload-artifact@v7`; resolve the SHA it points at today with `gh api repos/actions/upload-artifact/commits/v7 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-stable.yml:41 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
  • High: github-actions-mutable-action-tag .github/workflows/cd-store-stable.yml:43 — GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: microsoft/setup-msbuild@<40-character SHA>`. This step references `microsoft/setup-msbuild@v3`; resolve the SHA it points at today with `gh api repos/microsoft/setup-msbuild/commits/v3 --jq .sha`.
  • + 19 more in this group — see findings.md.
D17 · Explicit Debt · EmptyCatchBlock · ×40
  • EmptyCatchBlock src/Files.App.BackgroundTasks/UpdateTask.cs:23 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App.BackgroundTasks/UpdateTask.cs:26 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App.Controls/Sidebar/SidebarItem.cs:211 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Actions/Open/OpenTerminalAction.cs:118 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Converters/DoubleArrayToStringConverter.cs:39 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Converters/GenericEnumConverter.cs:45 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Converters/GenericEnumConverter.cs:51 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs:438 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Data/Items/DriveItem.cs:305 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Helpers/Dialog/DialogDisplayHelper.cs:54 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Shell.cs:76 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:976 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:991 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Program.cs:109 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/App/AppUpdateSideloadService.cs:150 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/App/AppUpdateSideloadService.cs:159 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/App/AppUpdateStoreService.cs:243 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/App/AppUpdateStoreService.cs:252 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:42 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/Windows/WindowsJumpListService.cs:100 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Services/Windows/WindowsJumpListService.cs:124 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/UserControls/FilePreviews/CodePreview.xaml.cs:52 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/UserControls/TabBar/TabBar.xaml.cs:313 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/UserControls/TabBar/TabBar.xaml.cs:345 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • EmptyCatchBlock src/Files.App/Utils/Shell/ShellFileOperations2.cs:679 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
  • + 15 more in this group — see findings.md.
D10 · Test Quality · No assertions (empty test) · ×1
  • No assertions (empty test): VerifySettingsAreAccessible tests/Files.InteractionTests/Tests/SettingsTests.cs:19 — Test method has an empty body — it asserts nothing and exercises no code.
Warning — 497 finding(s)
D17 · Explicit Debt · TodoComment · ×59
  • TodoComment src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Storage.cs:90 — // TODO: Use shell32.dll!CMountPointRename (CLSID: 60173D16-A550-47f0-A14B-C6F9E4DA0831, IID: 92F8D886-AB61-4113-BD4F-2E894397386F)
  • TodoComment src/Files.App/Actions/FileSystem/EmptyRecycleBinAction.cs:43 — // TODO: Use AppDialogService — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Actions/FileSystem/RestoreAllRecycleBinAction.cs:32 — // TODO: Use AppDialogService — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Actions/Show/ToggleShelfPaneAction.cs:23 — // TODO Remove IsAccessibleGlobally when shelf feature is ready — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Actions/Show/ToggleShelfPaneAction.cs:27 — // TODO Remove IsExecutable when shelf feature is ready — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/App.xaml.cs:39 — // TODO: Replace with DI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/App.xaml.cs:108 — // TODO: Replace with DI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/App.xaml.cs:183 — // TODO(s): Is this code still needed? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Contracts/IShellPanesPage.cs:19 — // TODO: Remove this our of this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Contracts/IShellPanesPage.cs:22 — // TODO: Remove this our of this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Contracts/IStartMenuService.cs:8 — // TODO(s) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:390 — // TODO add back text and icon when https://github.com/microsoft/microsoft-ui-xaml/issues/9409 is resolved
  • TodoComment src/Files.App/Data/Items/ListedItem.cs:91 — // TODO: eventually we should remove this b/c it's not thread safe — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Models/AppModel.cs:19 — // TODO: Refactor this method — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Data/Models/CurrentInstanceViewModel.cs:8 — // TODO: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Extensions/MessageFormatExtensions.cs:123 — //TODO: Could replace `GetLocalizedResource()` in the future — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Helpers/UI/UIFilesystemHelpers.cs:15 — // TODO: Remove this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Helpers/UI/UIFilesystemHelpers.cs:99 — // TODO: handle libraries with multiple folders — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Helpers/Win32/Win32Helper.Process.cs:29 — // TODO In the long run, we should consider modifying HandleApplicationLaunch to handle this correctly. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Services/App/AppUpdateStoreService.cs:207 — //TODO: Use IDialogService in future. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Services/Git/LibGit2Service.cs:34 — // TODO: Make set method private again when move finished — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Services/Git/LibGit2Service.cs:394 — // TODO: This is a temp fix to avoid an issue where Files would create many branches in a loop — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Utils/Git/GitHelpers.cs:605 — // TODO: This is a temp fix to avoid an issue where Files would create many branches in a loop — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Services/Storage/StorageArchiveService.cs:191 — // TODO: Get this method return result — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment src/Files.App/Services/Storage/StorageTrashBinService.cs:102 — // TODO: Use IFileOperation instead of its wrapper for the operation status to be reported. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 34 more in this group — see findings.md.
D3 · God Classes · TooManyMethods · ×31
  • TooManyMethods: SidebarViewModel src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:0 — TooManyMethods — 1307 significant lines (blank, comment-only and punctuation-only lines excluded), 94 methods, declared across 3 files: UserControls/SidebarViewModel.cs (48), UserControls/SidebarViewModel.FlatTree.cs (26), UserControls/SidebarViewModel.TabExpansion.cs (20). To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShellViewModel src/Files.App/ViewModels/ShellViewModel.cs:0 — TooManyMethods — 1683 significant lines (blank, comment-only and punctuation-only lines excluded), 76 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DetailsLayoutPage src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:0 — TooManyMethods — 652 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BaseLayoutPage src/Files.App/Views/Layouts/BaseLayoutPage.cs:0 — TooManyMethods — 863 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ZipStorageFolder src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:0 — TooManyMethods — 359 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BaseStorageFolder src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFolder.cs:0 — TooManyMethods — 123 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Win32Helper src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:0 — TooManyMethods — 697 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods, declared across 4 files: Win32/Win32Helper.Storage.cs (48), Win32/Win32Helper.Process.cs (3), Win32/Win32Helper.Shell.cs (2), Win32/Win32Helper.WindowManagement.cs (2). The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • TooManyMethods: Toolbar src/Files.App.Controls/Toolbar/Toolbar.cs:0 — TooManyMethods — 318 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods, declared across 2 files: Toolbar/Toolbar.cs (50), Toolbar/Toolbar.Properties.cs (5). To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BaseShellPage src/Files.App/Views/Shells/BaseShellPage.cs:0 — TooManyMethods — 440 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: FtpStorageFolder src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:0 — TooManyMethods — 220 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShellStorageFolder src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs:0 — TooManyMethods — 135 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: VirtualStorageFolder src/Files.App/Utils/Storage/StorageItems/VirtualStorageFolder.cs:0 — TooManyMethods — 81 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ColumnLayoutPage src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:0 — TooManyMethods — 332 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MainPage src/Files.App/Views/MainPage.xaml.cs:0 — TooManyMethods — 304 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShellPanesPage src/Files.App/Views/ShellPanesPage.xaml.cs:0 — TooManyMethods — 571 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SidebarItem src/Files.App.Controls/Sidebar/SidebarItem.cs:0 — TooManyMethods — 396 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods, declared across 2 files: Sidebar/SidebarItem.cs (36), Sidebar/SidebarItem.Properties.cs (3). To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BaseStorageFile src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFile.cs:0 — TooManyMethods — 101 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GridLayoutPage src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:0 — TooManyMethods — 413 significant lines (blank, comment-only and punctuation-only lines excluded), 37 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ZipStorageFile src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:0 — TooManyMethods — 277 significant lines (blank, comment-only and punctuation-only lines excluded), 37 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GridSplitter src/Files.App.Controls/GridSplitter/GridSplitter.Helper.cs:0 — TooManyMethods — 458 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods, declared across 4 files: GridSplitter/GridSplitter.Helper.cs (14), GridSplitter/GridSplitter.Events.cs (9), GridSplitter/GridSplitter.cs (8), GridSplitter/GridSplitter.Options.cs (5). To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ToolbarItem src/Files.App.Controls/Toolbar/ToolbarItem/ToolbarItem.cs:0 — TooManyMethods — 182 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods, declared across 2 files: ToolbarItem/ToolbarItem.cs (24), ToolbarItem/ToolbarItem.Properties.cs (12). The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • TooManyMethods: FilesystemHelpers src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:0 — TooManyMethods — 473 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BulkConcurrentObservableCollection src/Files.App/Utils/Storage/Collection/BulkConcurrentObservableCollection.cs:0 — TooManyMethods — 277 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: RingShape src/Files.App.Controls/Storage/RingShape/RingShape.cs:0 — TooManyMethods — 269 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods, declared across 2 files: RingShape/RingShape.cs (26), RingShape/RingShape.Properties.cs (8). To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BaseGroupableLayoutPage src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:0 — TooManyMethods — 238 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • + 6 more in this group — see findings.md.
D6 · Cohesion (LCOM4) · Low cohesion · ×19
  • Low cohesion: DetailsLayoutPage (LCOM4 16) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:26 — DetailsLayoutPage's methods form 16 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: GridLayoutPage (LCOM4 13) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:22 — GridLayoutPage's methods form 13 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: ColumnLayoutPage (LCOM4 12) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:23 — ColumnLayoutPage's methods form 12 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: TabBar (LCOM4 11) src/Files.App/UserControls/TabBar/TabBar.xaml.cs:15 — TabBar's methods form 11 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: SidebarView (LCOM4 9) src/Files.App.Controls/Sidebar/SidebarView.xaml.cs:13 — SidebarView's methods form 9 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: ResourcesService (LCOM4 9) src/Files.App/Services/App/AppResourcesService.cs:10 — ResourcesService's methods form 9 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: BaseLayoutPage (LCOM4 9) src/Files.App/Views/Layouts/BaseLayoutPage.cs:36 — BaseLayoutPage's methods form 9 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: NetworkLocationsWidgetViewModel (LCOM4 6) src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:16 — NetworkLocationsWidgetViewModel's methods form 6 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: BaseGroupableLayoutPage (LCOM4 6) src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:21 — BaseGroupableLayoutPage's methods form 6 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: ColumnsLayoutPage (LCOM4 6) src/Files.App/Views/Layouts/ColumnsLayoutPage.xaml.cs:18 — ColumnsLayoutPage's methods form 6 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: StorageArchiveService (LCOM4 5) src/Files.App/Services/Storage/StorageArchiveService.cs:19 — StorageArchiveService's methods form 5 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: InfoPane (LCOM4 5) src/Files.App/UserControls/Pane/InfoPane.xaml.cs:17 — InfoPane's methods form 5 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: GeneralViewModel (LCOM4 5) src/Files.App/ViewModels/Settings/GeneralViewModel.cs:12 — GeneralViewModel's methods form 5 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: NavigationToolbarViewModel (LCOM4 5) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:19 — NavigationToolbarViewModel's methods form 5 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: DrivesWidgetViewModel (LCOM4 5) src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:16 — DrivesWidgetViewModel's methods form 5 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: NetworkService (LCOM4 4) src/Files.App/Services/Storage/StorageNetworkService.cs:14 — NetworkService's methods form 4 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: NavigationToolbar (LCOM4 4) src/Files.App/UserControls/NavigationToolbar.xaml.cs:18 — NavigationToolbar's methods form 4 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: AdvancedViewModel (LCOM4 4) src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:18 — AdvancedViewModel's methods form 4 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
  • Low cohesion: RecentFilesWidgetViewModel (LCOM4 4) src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs:16 — RecentFilesWidgetViewModel's methods form 4 groups that share no state and don't call each other — a sign it may have several responsibilities. Review whether it splits into focused classes.
D17 · Explicit Debt · CommentedOutCode · ×12
  • CommentedOutCode src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:82 — 4 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Data/Enums/CopyEngineResult.cs:40 — 4 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Helpers/Navigation/NavigationHelpers.cs:743 — 4 consecutive commented-code lines
  • CommentedOutCode src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:42 — 4 consecutive commented-code lines
  • CommentedOutCode src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:89 — 3 consecutive commented-code lines
  • CommentedOutCode src/Files.App.Controls/Toolbar/Toolbar.cs:619 — 3 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Data/Models/DisposableArray.cs:51 — 3 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Services/Git/LibGit2Service.cs:398 — 3 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Utils/Git/GitHelpers.cs:609 — 3 consecutive commented-code lines
  • CommentedOutCode tests/Files.InteractionTests/Tests/SettingsTests.cs:51 — 3 consecutive commented-code lines
  • CommentedOutCode src/Files.App/Data/Enums/CopyEngineResult.cs:47 — 5 consecutive commented-code lines
  • CommentedOutCode tests/Files.InteractionTests/Tests/SettingsTests.cs:44 — 6 consecutive commented-code lines
D3 · God Classes · FileTooLong · ×11
  • FileTooLong: ViewModels/ShellViewModel.cs src/Files.App/ViewModels/ShellViewModel.cs:0 — FileTooLong — 1729 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Layouts/BaseLayoutPage.cs src/Files.App/Views/Layouts/BaseLayoutPage.cs:0 — FileTooLong — 897 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: UserControls/SidebarViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:0 — FileTooLong — 891 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: UserControls/NavigationToolbarViewModel.cs src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:0 — FileTooLong — 728 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Signatures/DigitalSignaturesUtil.cs src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:0 — FileTooLong — 681 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Layouts/DetailsLayoutPage.xaml.cs src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:0 — FileTooLong — 669 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Operations/FileOperationsHelpers.cs src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:0 — FileTooLong — 620 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Win32/Win32Helper.Storage.cs src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:0 — FileTooLong — 614 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Views/ShellPanesPage.xaml.cs src/Files.App/Views/ShellPanesPage.xaml.cs:0 — FileTooLong — 588 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: StatusCenter/StatusCenterHelper.cs src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:0 — FileTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: Factories/ContentPageContextFlyoutFactory.cs src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:0 — FileTooLong — 524 significant lines (blank, comment-only and punctuation-only lines excluded). To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×11
  • Duplicated block (12 lines × 2) src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:159 — src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:159-170 | src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:190-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/Files.App/Data/Commands/ActionCommand.cs:197 — src/Files.App/Data/Commands/ActionCommand.cs:197-208 | src/Files.App/Data/Commands/ModifiableCommand.cs:143-154 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/Files.App/Data/Commands/ActionCommand.cs:222 — src/Files.App/Data/Commands/ActionCommand.cs:222-233 | src/Files.App/Data/Commands/ModifiableCommand.cs:168-179 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/Files.App/Program.cs:172 — src/Files.App/Program.cs:172-184 | src/Files.App/Program.cs:212-223 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Program.cs:172` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:229 — src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:229-240 | src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:263-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:229` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:1397 — src/Files.App/ViewModels/ShellViewModel.cs:1397-1408 | src/Files.App/ViewModels/ShellViewModel.cs:1465-1476 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/ShellViewModel.cs:1397` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:86 — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:86-97 | src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:91-102 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:472 — src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:472-483 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:547-558 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:472` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:534 — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:534-545 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:536-547 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:534` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1026 — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1026-1037 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:693-704 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1026` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) src/Files.App/Views/ReleaseNotesPage.xaml.cs:32 — src/Files.App/Views/ReleaseNotesPage.xaml.cs:32-43 | src/Files.App/Views/Settings/SettingsPage.xaml.cs:36-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D15 · Churn × Complexity Hotspots · Hotspot · ×10
  • Hotspot: src/Files.App/ViewModels/ShellViewModel.cs src/Files.App/ViewModels/ShellViewModel.cs — src/Files.App/ViewModels/ShellViewModel.cs changed 7 times in last 90 days, max complexity 43. 1 of those changes was a fix/bug commit, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs — src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs changed 3 times in last 90 days, max complexity 71. 1 of those changes was a fix/bug commit, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/Views/Layouts/BaseLayoutPage.cs src/Files.App/Views/Layouts/BaseLayoutPage.cs — src/Files.App/Views/Layouts/BaseLayoutPage.cs changed 5 times in last 90 days, max complexity 41. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs changed 5 times in last 90 days, max complexity 35. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, behind tests written first.
  • Hotspot: src/Files.App/Helpers/Navigation/NavigationHelpers.cs src/Files.App/Helpers/Navigation/NavigationHelpers.cs — src/Files.App/Helpers/Navigation/NavigationHelpers.cs changed 6 times in last 90 days, max complexity 26. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs — src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs changed 5 times in last 90 days, max complexity 28. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs — src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs changed 4 times in last 90 days, max complexity 27. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, behind tests written first.
  • Hotspot: src/Files.App/ViewModels/UserControls/SidebarViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs — src/Files.App/ViewModels/UserControls/SidebarViewModel.cs changed 4 times in last 90 days, max complexity 24. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, behind tests written first.
  • Hotspot: src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs — src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs changed 3 times in last 90 days, max complexity 30. 3 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
  • Hotspot: src/Files.App/ViewModels/MainPageViewModel.cs src/Files.App/ViewModels/MainPageViewModel.cs — src/Files.App/ViewModels/MainPageViewModel.cs changed 3 times in last 90 days, max complexity 30. 1 of those changes was a fix/bug commit, so the churn is repair rather than feature work. Before the next change lands here, cover the area it touches with tests, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time.
D17 · Explicit Debt · ObsoleteWithCallers · ×9
  • ObsoleteWithCallers src/Files.App.Storage/Legacy/NativeStorageLegacy/NativeStorageService.cs:9 — [Obsolete] NativeStorageLegacyService
  • ObsoleteWithCallers src/Files.App.Storage/Legacy/RecycleBinWatcher.cs:9 — [Obsolete] RecycleBinWatcher
  • ObsoleteWithCallers src/Files.App/Data/Contracts/IImageService.cs:21 — [Obsolete] GetImageModelFromDataAsync
  • ObsoleteWithCallers src/Files.App/Data/Items/NavigationBarSuggestionItem.cs:10 — [Obsolete] NavigationBarSuggestionItem
  • ObsoleteWithCallers src/Files.App/Helpers/MenuFlyout/MenuFlyoutHelper.cs:10 — [Obsolete] MenuFlyoutHelper
  • ObsoleteWithCallers src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:185 — [Obsolete] PathControlDisplayText
  • ObsoleteWithCallers src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:377 — [Obsolete] PathBoxItem_DragLeave
  • ObsoleteWithCallers src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:393 — [Obsolete] PathBoxItem_Drop
  • ObsoleteWithCallers src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:432 — [Obsolete] PathBoxItem_DragOver
D3 · God Classes · ClassTooLong · ×9
  • ClassTooLong: NavigationToolbarViewModel src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:0 — ClassTooLong — 715 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DigitalSignaturesUtil src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:0 — ClassTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: StatusCenterHelper src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:0 — ClassTooLong — 581 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: FileOperationsHelpers src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:0 — ClassTooLong — 576 significant lines (blank, comment-only and punctuation-only lines excluded), 19 methods. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: ContentPageContextFlyoutFactory src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:0 — ClassTooLong — 516 significant lines (blank, comment-only and punctuation-only lines excluded), 7 methods. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
  • ClassTooLong: ShellFilesystemOperations src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:0 — ClassTooLong — 488 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: FilesystemOperations src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:0 — ClassTooLong — 480 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SelectedItemsPropertiesViewModel src/Files.App/Data/Models/SelectedItemsPropertiesViewModel.cs:0 — ClassTooLong — 477 significant lines (blank, comment-only and punctuation-only lines excluded), 2 methods. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: NavigationHelpers src/Files.App/Helpers/Navigation/NavigationHelpers.cs:0 — ClassTooLong — 438 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
D35 · Change Coupling · Change coupling · ×6
  • Change coupling: CommandManager.cs ↔ IContentPageContext.cs src/Files.App/Data/Commands/Manager/CommandManager.cs — `src/Files.App/Data/Commands/Manager/CommandManager.cs` and `src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs` change together 71% of the time (12 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking.
  • Change coupling: LayoutPreferencesDatabase.cs ↔ FileTagsDatabase.cs src/Files.App/Helpers/Layout/LayoutPreferencesDatabase.cs — `src/Files.App/Helpers/Layout/LayoutPreferencesDatabase.cs` and `src/Files.App/Utils/FileTags/FileTagsDatabase.cs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking.
  • Change coupling: ISidebarViewModel.cs ↔ SidebarItem.cs src/Files.App.Controls/Sidebar/ISidebarViewModel.cs — `src/Files.App.Controls/Sidebar/ISidebarViewModel.cs` and `src/Files.App.Controls/Sidebar/SidebarItem.cs` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: SidebarViewModel.cs ↔ NetworkLocationsWidgetViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs — `src/Files.App/ViewModels/UserControls/SidebarViewModel.cs` and `src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs` change together 53% of the time (10 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking.
  • Change coupling: SidebarViewModel.cs ↔ DrivesWidgetViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs — `src/Files.App/ViewModels/UserControls/SidebarViewModel.cs` and `src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs` change together 50% of the time (13 of the 26 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking.
  • Change coupling: WidgetDriveCardItem.cs ↔ ShellViewModel.cs src/Files.App/Data/Items/WidgetDriveCardItem.cs — `src/Files.App/Data/Items/WidgetDriveCardItem.cs` and `src/Files.App/ViewModels/ShellViewModel.cs` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×6
  • Duplicated block (14 lines × 2) src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:359 — src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:359-372 | src/Files.App.Controls/Storage/StorageRing/StorageRing.cs:559-572 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:359` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs:60 — src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs:60-75 | src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveToChildFolderAction.cs:46-59 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) src/Files.App/Services/Git/LibGit2Service.cs:392 — src/Files.App/Services/Git/LibGit2Service.cs:392-405 | src/Files.App/Utils/Git/GitHelpers.cs:603-616 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (14 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:224 — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:224-237 | src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:232-245 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:224` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:233 — src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:233-246 | src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:262-275 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:233` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) src/Files.App/Views/Layouts/BaseLayoutPage.cs:936 — src/Files.App/Views/Layouts/BaseLayoutPage.cs:936-949 | src/Files.App/Views/Layouts/BaseLayoutPage.cs:969-982 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/BaseLayoutPage.cs:936` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×6
  • Duplicated block (9 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:348 — src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:348-356 | src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:357-365 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:318 — src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:318-326 | src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:459-467 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:318` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:868 — src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:868-876 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:911-919 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:868` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:89 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:89-97 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:527-536 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:167 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:167-176 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:612-620 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:167` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) src/Files.App/Views/Shells/BaseShellPage.cs:545 — src/Files.App/Views/Shells/BaseShellPage.cs:545-553 | src/Files.App/Views/Shells/BaseShellPage.cs:563-571 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Shells/BaseShellPage.cs:545` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×4
  • Duplicated block (10 lines × 2) src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:48 — src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:48-57 | src/Files.App/Actions/Navigation/OpenInOtherPane/BaseOpenInOtherPaneAction.cs:49-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Files.App/Actions/Start/PinToStartAction.cs:39 — src/Files.App/Actions/Start/PinToStartAction.cs:39-48 | src/Files.App/Actions/Start/UnpinFromStartAction.cs:36-45 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Start/PinToStartAction.cs:39` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:220 — src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:220-229 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:433-442 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:220` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:86 — src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:86-95 | src/Files.App/Utils/Storage/StorageItems/VirtualStorageFile.cs:123-132 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×4
  • Duplicated block (8 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:703 — src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:703-710 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:725-732 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:703` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:182 — src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:182-189 | src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:195-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:260 — src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:260-267 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:353-360 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55 — src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55-63 | src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:116-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×4
  • Duplicated block (7 lines × 2) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:191 — src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:191-197 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:354-360 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:191` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:52 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:52-58 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:494-500 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:52` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:69 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:69-76 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:510-516 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:69` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:40 — src/Files.App/ViewModels/Properties/Items/FileProperties.cs:40-46 | src/Files.App/ViewModels/Properties/Items/FolderProperties.cs:42-48 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
D17 · Explicit Debt · BarePragmaDisable · ×3
  • BarePragmaDisable src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:901 — #pragma warning disable CS8625 — the disable has no matching restore, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later. Close it with the matching restore directive immediately after the construct it covers, or fix the cause and drop the directive entirely.
  • BarePragmaDisable src/Files.Core.SourceGenerator/Utilities/HashCode.cs:9 — #pragma warning disable CS0809 — the disable has no matching restore, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later. Close it with the matching restore directive immediately after the construct it covers, or fix the cause and drop the directive entirely.
  • BarePragmaDisable src/Files.Core.SourceGenerator/Utilities/HashCode.cs:10 — #pragma warning disable CA1066 — the disable has no matching restore, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later. Close it with the matching restore directive immediately after the construct it covers, or fix the cause and drop the directive entirely.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:82 — src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:82-92 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:70-80 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:82` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:220 — src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:220-230 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:298-308 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:220` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:241 — src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:241-251 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:583-593 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:241` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×2
  • Duplicated block (19 lines × 2) src/Files.App/Services/App/AppUpdateSideloadService.cs:139 — src/Files.App/Services/App/AppUpdateSideloadService.cs:139-157 | src/Files.App/Services/App/AppUpdateStoreService.cs:232-250 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/App/AppUpdateSideloadService.cs:139` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (19 lines × 2) src/Files.App/Services/Git/LibGit2Service.cs:369 — src/Files.App/Services/Git/LibGit2Service.cs:369-387 | src/Files.App/Utils/Git/GitHelpers.cs:579-597 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Git/LibGit2Service.cs:369` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×2
  • Duplicated block (18 lines × 2) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:404 — src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:404-421 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:540-557 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (18 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:184 — src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:184-203 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:401-418 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:184` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×2
  • Duplicated block (17 lines × 2) src/Files.App/Actions/Open/OpenLogFileAction.cs:42 — src/Files.App/Actions/Open/OpenLogFileAction.cs:42-58 | src/Files.App/Actions/Open/OpenSettingsFileAction.cs:37-53 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Open/OpenLogFileAction.cs:42` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:123 — src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:123-139 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:324-341 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:134 — src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:134-149 | src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:156-171 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:134` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16 lines × 2) src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:242 — src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:242-257 | src/Files.App/ViewModels/Properties/SecurityViewModel.cs:135-150 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:242` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:128 — src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:128-142 | src/Files.App/ViewModels/Properties/SecurityViewModel.cs:74-88 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:128` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (15 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:631 — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:631-648 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:622-636 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:631` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×2
  • Duplicated block (13 lines × 2) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:98 — src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:98-110 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:270-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:474 — src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:474-486 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:579-591 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:474` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×2
  • Duplicated block (11 lines × 3) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:646 — src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:646-656 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:665-675 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:684-694 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:646` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 3) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:445 — src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:445-455 | src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:495-505 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:509-519 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×2
  • Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:184 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:184-190 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:620-625 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:184` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:589 — src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:589-594 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:626-631 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D5 · Coupling · Off the main sequence · ×2
  • Off the main sequence: Files.App.BackgroundTasks — Files.App.BackgroundTasks: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
  • Off the main sequence: Files.Shared — Files.Shared: abstractness 0.19, instability 0.00, distance 0.81 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
D1 · Cyclomatic Complexity · ContentPageContextFlyoutFactory.GetBaseItemMenuItems (cyclomatic 71) · ×1
  • ContentPageContextFlyoutFactory.GetBaseItemMenuItems (cyclomatic 71) src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:78 — ContentPageContextFlyoutFactory.GetBaseItemMenuItems has cyclomatic complexity 71 (threshold 15). Of this number, 56 points are the body's own statements and 15 belong to 4 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · FolderSearch.SearchWithWin32Async (cyclomatic 45) · ×1
  • FolderSearch.SearchWithWin32Async (cyclomatic 45) src/Files.App/Utils/Storage/Search/FolderSearch.cs:390 — FolderSearch.SearchWithWin32Async has cyclomatic complexity 45 (threshold 15). Of this number, 18 points are the body's own statements and 27 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MainWindow.InitializeApplicationAsync (cyclomatic 43) · ×1
  • MainWindow.InitializeApplicationAsync (cyclomatic 43) src/Files.App/MainWindow.xaml.cs:53 — MainWindow.InitializeApplicationAsync has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellViewModel.LoadExtendedItemPropertiesAsync (cyclomatic 43) · ×1
  • ShellViewModel.LoadExtendedItemPropertiesAsync (cyclomatic 43) src/Files.App/ViewModels/ShellViewModel.cs:1350 — ShellViewModel.LoadExtendedItemPropertiesAsync has cyclomatic complexity 43 (threshold 15). Of this number, 33 points are the body's own statements and 10 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StatusCenterHelper.UpdateCardStrings (cyclomatic 42) · ×1
  • StatusCenterHelper.UpdateCardStrings (cyclomatic 42) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:614 — StatusCenterHelper.UpdateCardStrings has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellViewModel.EnumerateItemsFromStandardFolderAsync (cyclomatic 41) · ×1
  • ShellViewModel.EnumerateItemsFromStandardFolderAsync (cyclomatic 41) src/Files.App/ViewModels/ShellViewModel.cs:1877 — ShellViewModel.EnumerateItemsFromStandardFolderAsync has cyclomatic complexity 41 (threshold 15). Of this number, 40 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseLayoutPage.AddShellMenuItemsAsync (cyclomatic 41) · ×1
  • BaseLayoutPage.AddShellMenuItemsAsync (cyclomatic 41) src/Files.App/Views/Layouts/BaseLayoutPage.cs:829 — BaseLayoutPage.AddShellMenuItemsAsync has cyclomatic complexity 41 (threshold 15). Of this number, 25 points are the body's own statements and 16 belong to 10 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · CloudDrivesDetector.DetectGenericCloudDrive (cyclomatic 39) · ×1
  • CloudDrivesDetector.DetectGenericCloudDrive (cyclomatic 39) src/Files.App/Utils/Cloud/CloudDrivesDetector.cs:57 — CloudDrivesDetector.DetectGenericCloudDrive has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellContextFlyoutFactory.LoadShellMenuItemsAsync (cyclomatic 36) · ×1
  • ShellContextFlyoutFactory.LoadShellMenuItemsAsync (cyclomatic 36) src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs:278 — ShellContextFlyoutFactory.LoadShellMenuItemsAsync has cyclomatic complexity 36 (threshold 15). Of this number, 28 points are the body's own statements and 8 belong to 7 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DetailsLayoutPage.FileList_PreviewKeyDown (cyclomatic 34) · ×1
  • DetailsLayoutPage.FileList_PreviewKeyDown (cyclomatic 34) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:486 — DetailsLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CssPreviewRenderer.Render (cyclomatic 32) · ×1
  • CssPreviewRenderer.Render (cyclomatic 32) src/Files.App/UserControls/FilePreviews/CssPreviewRenderer.cs:13 — CssPreviewRenderer.Render has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DigitalSignaturesUtil.ParseDERFindType (cyclomatic 32) · ×1
  • DigitalSignaturesUtil.ParseDERFindType (cyclomatic 32) src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:516 — DigitalSignaturesUtil.ParseDERFindType has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FilesystemOperations.MoveAsync (cyclomatic 32) · ×1
  • FilesystemOperations.MoveAsync (cyclomatic 32) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:300 — FilesystemOperations.MoveAsync has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PropertiesNavigationItemsFactory.Initialize (cyclomatic 31) · ×1
  • PropertiesNavigationItemsFactory.Initialize (cyclomatic 31) src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs:14 — PropertiesNavigationItemsFactory.Initialize has cyclomatic complexity 31 (threshold 15). Of this number, 29 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Program.Main (cyclomatic 31) · ×1
  • Program.Main (cyclomatic 31) src/Files.App/Program.cs:75 — Program.Main has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MainPageViewModel.OnNavigatedToAsync (cyclomatic 30) · ×1
  • MainPageViewModel.OnNavigatedToAsync (cyclomatic 30) src/Files.App/ViewModels/MainPageViewModel.cs:222 — MainPageViewModel.OnNavigatedToAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellViewModel.ProcessOperationQueueAsync (cyclomatic 30) · ×1
  • ShellViewModel.ProcessOperationQueueAsync (cyclomatic 30) src/Files.App/ViewModels/ShellViewModel.cs:2581 — ShellViewModel.ProcessOperationQueueAsync has cyclomatic complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationToolbarViewModel.HandleItemNavigationAsync (cyclomatic 30) · ×1
  • NavigationToolbarViewModel.HandleItemNavigationAsync (cyclomatic 30) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:536 — NavigationToolbarViewModel.HandleItemNavigationAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilesystemOperations.CopyAsync (cyclomatic 29) · ×1
  • FilesystemOperations.CopyAsync (cyclomatic 29) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:114 — FilesystemOperations.CopyAsync has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationToolbarViewModel.CheckPathInputAsync (cyclomatic 29) · ×1
  • NavigationToolbarViewModel.CheckPathInputAsync (cyclomatic 29) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:800 — NavigationToolbarViewModel.CheckPathInputAsync has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ContextFlyoutModelToElementHelper.GetCommandBarButton (cyclomatic 28) · ×1
  • ContextFlyoutModelToElementHelper.GetCommandBarButton (cyclomatic 28) src/Files.App/Helpers/MenuFlyout/ContextFlyoutModelToElementHelper.cs:218 — ContextFlyoutModelToElementHelper.GetCommandBarButton has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LaunchHelper.HandleApplicationLaunch (cyclomatic 28) · ×1
  • LaunchHelper.HandleApplicationLaunch (cyclomatic 28) src/Files.App/Utils/Shell/LaunchHelper.cs:57 — LaunchHelper.HandleApplicationLaunch has cyclomatic complexity 28 (threshold 15). Of this number, 23 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.CopyItemsAsync (cyclomatic 28) · ×1
  • ShellFilesystemOperations.CopyItemsAsync (cyclomatic 28) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:41 — ShellFilesystemOperations.CopyItemsAsync has cyclomatic complexity 28 (threshold 15). Of this number, 19 points are the body's own statements and 9 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ColumnLayoutPage.FileList_PreviewKeyDown (cyclomatic 28) · ×1
  • ColumnLayoutPage.FileList_PreviewKeyDown (cyclomatic 28) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:429 — ColumnLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UniversalStorageEnumerator.ListEntries (cyclomatic 27) · ×1
  • UniversalStorageEnumerator.ListEntries (cyclomatic 27) src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs:16 — UniversalStorageEnumerator.ListEntries has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.MoveItemsAsync (cyclomatic 27) · ×1
  • ShellFilesystemOperations.MoveItemsAsync (cyclomatic 27) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:484 — ShellFilesystemOperations.MoveItemsAsync has cyclomatic complexity 27 (threshold 15). Of this number, 19 points are the body's own statements and 8 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GridLayoutPage.FileList_PreviewKeyDown (cyclomatic 27) · ×1
  • GridLayoutPage.FileList_PreviewKeyDown (cyclomatic 27) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:501 — GridLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationHelpers.OpenFile (cyclomatic 26) · ×1
  • NavigationHelpers.OpenFile (cyclomatic 26) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:635 — NavigationHelpers.OpenFile has cyclomatic complexity 26 (threshold 15). Most of this is not in the body itself: 9 of the 26 points are its own statements and the rest belongs to one function literal inside it that branches (line 671). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · MainWindow.InitializeFromCmdLineArgsAsync (cyclomatic 26) · ×1
  • MainWindow.InitializeFromCmdLineArgsAsync (cyclomatic 26) src/Files.App/MainWindow.xaml.cs:263 — MainWindow.InitializeFromCmdLineArgsAsync has cyclomatic complexity 26 (threshold 15). Of this number, 24 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseDecompressArchiveAction.DecompressArchiveHereAsync (cyclomatic 25) · ×1
  • BaseDecompressArchiveAction.DecompressArchiveHereAsync (cyclomatic 25) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:53 — BaseDecompressArchiveAction.DecompressArchiveHereAsync has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 11 of the 25 points are its own statements and the rest belongs to one function literal inside it that branches (line 94). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · ShellContextFlyoutFactory.LoadMenuFlyoutItem (cyclomatic 25) · ×1
  • ShellContextFlyoutFactory.LoadMenuFlyoutItem (cyclomatic 25) src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs:121 — ShellContextFlyoutFactory.LoadMenuFlyoutItem has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LayoutPreferencesManager.SetLayoutPreferencesForPath (cyclomatic 25) · ×1
  • LayoutPreferencesManager.SetLayoutPreferencesForPath (cyclomatic 25) src/Files.App/Helpers/Layout/LayoutPreferencesManager.cs:379 — LayoutPreferencesManager.SetLayoutPreferencesForPath has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StatusCenterItem.ReportProgress (cyclomatic 25) · ×1
  • StatusCenterItem.ReportProgress (cyclomatic 25) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:281 — StatusCenterItem.ReportProgress has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.DeleteItemsAsync (cyclomatic 25) · ×1
  • ShellFilesystemOperations.DeleteItemsAsync (cyclomatic 25) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:346 — ShellFilesystemOperations.DeleteItemsAsync has cyclomatic complexity 25 (threshold 15). Of this number, 21 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseLayoutViewModel.DragOverAsync (cyclomatic 25) · ×1
  • BaseLayoutViewModel.DragOverAsync (cyclomatic 25) src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs:92 — BaseLayoutViewModel.DragOverAsync has cyclomatic complexity 25 (threshold 15). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GeneralPage.SaveChangesAsync (cyclomatic 25) · ×1
  • GeneralPage.SaveChangesAsync (cyclomatic 25) src/Files.App/Views/Properties/GeneralPage.xaml.cs:56 — GeneralPage.SaveChangesAsync has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NavigationHelpers.OpenPath (cyclomatic 24) · ×1
  • NavigationHelpers.OpenPath (cyclomatic 24) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:461 — NavigationHelpers.OpenPath has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Toolbar.CreateToolbarElement (cyclomatic 24) · ×1
  • Toolbar.CreateToolbarElement (cyclomatic 24) src/Files.App/UserControls/Toolbar.xaml.cs:167 — Toolbar.CreateToolbarElement has cyclomatic complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFolderExtensions.GetShellFileItem (cyclomatic 24) · ×1
  • ShellFolderExtensions.GetShellFileItem (cyclomatic 24) src/Files.App/Utils/Shell/ShellFolderExtensions.cs:45 — ShellFolderExtensions.GetShellFileItem has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · Win32StorageEnumerator.ListEntries (cyclomatic 24) · ×1
  • Win32StorageEnumerator.ListEntries (cyclomatic 24) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:21 — Win32StorageEnumerator.ListEntries has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SidebarViewModel.HandleLocationItemDragOverAsync (cyclomatic 24) · ×1
  • SidebarViewModel.HandleLocationItemDragOverAsync (cyclomatic 24) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1223 — SidebarViewModel.HandleLocationItemDragOverAsync has cyclomatic complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExpandableSidebarItemBase.ResyncSubfoldersAsync (cyclomatic 23) · ×1
  • ExpandableSidebarItemBase.ResyncSubfoldersAsync (cyclomatic 23) src/Files.App/Data/Items/ExpandableSidebarItemBase.cs:199 — ExpandableSidebarItemBase.ResyncSubfoldersAsync has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 9 of the 23 points are its own statements and the rest belongs to one function literal inside it that branches (line 231). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · NavigationHelpers.GetSelectedTabInfoAsync (cyclomatic 23) · ×1
  • NavigationHelpers.GetSelectedTabInfoAsync (cyclomatic 23) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:249 — NavigationHelpers.GetSelectedTabInfoAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Win32Helper.GetIcon (cyclomatic 23) · ×1
  • Win32Helper.GetIcon (cyclomatic 23) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:145 — Win32Helper.GetIcon has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellViewModel.LoadThumbnailAsync (cyclomatic 23) · ×1
  • ShellViewModel.LoadThumbnailAsync (cyclomatic 23) src/Files.App/ViewModels/ShellViewModel.cs:1189 — ShellViewModel.LoadThumbnailAsync has cyclomatic complexity 23 (threshold 15). Of this number, 16 points are the body's own statements and 7 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InfoPaneViewModel.GetBuiltInPreviewControlAsync (cyclomatic 23) · ×1
  • InfoPaneViewModel.GetBuiltInPreviewControlAsync (cyclomatic 23) src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:243 — InfoPaneViewModel.GetBuiltInPreviewControlAsync has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Win32StorageEnumerator.GetFile (cyclomatic 21) · ×1
  • Win32StorageEnumerator.GetFile (cyclomatic 21) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:225 — Win32StorageEnumerator.GetFile has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BasePropertiesPage.OnNavigatedTo (cyclomatic 21) · ×1
  • BasePropertiesPage.OnNavigatedTo (cyclomatic 21) src/Files.App/ViewModels/Properties/BasePropertiesPage.cs:28 — BasePropertiesPage.OnNavigatedTo has cyclomatic complexity 21 (threshold 15). Of this number, 14 points are the body's own statements and 7 belong to 4 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · StorageFileExtensions.ResolvePath (cyclomatic 20) · ×1
  • StorageFileExtensions.ResolvePath (cyclomatic 20) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:346 — StorageFileExtensions.ResolvePath has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StorageHistoryOperations.Undo (cyclomatic 20) · ×1
  • StorageHistoryOperations.Undo (cyclomatic 20) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:23 — StorageHistoryOperations.Undo has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StorageHistoryOperations.Redo (cyclomatic 20) · ×1
  • StorageHistoryOperations.Redo (cyclomatic 20) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:107 — StorageHistoryOperations.Redo has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilesystemHelpers.GetDraggedStorageItems (cyclomatic 20) · ×1
  • FilesystemHelpers.GetDraggedStorageItems (cyclomatic 20) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:738 — FilesystemHelpers.GetDraggedStorageItems has cyclomatic complexity 20 (threshold 15). Of this number, 19 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.CreateAsync (cyclomatic 20) · ×1
  • ShellFilesystemOperations.CreateAsync (cyclomatic 20) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:205 — ShellFilesystemOperations.CreateAsync has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.RenameAsync (cyclomatic 20) · ×1
  • ShellFilesystemOperations.RenameAsync (cyclomatic 20) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:643 — ShellFilesystemOperations.RenameAsync has cyclomatic complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellFilesystemOperations.RestoreItemsFromTrashAsync (cyclomatic 20) · ×1
  • ShellFilesystemOperations.RestoreItemsFromTrashAsync (cyclomatic 20) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:747 — ShellFilesystemOperations.RestoreItemsFromTrashAsync has cyclomatic complexity 20 (threshold 15). Of this number, 13 points are the body's own statements and 7 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SidebarViewModel.CreateSectionAsync (cyclomatic 20) · ×1
  • SidebarViewModel.CreateSectionAsync (cyclomatic 20) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:539 — SidebarViewModel.CreateSectionAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseLayoutPage.FileListItem_PointerEntered (cyclomatic 20) · ×1
  • BaseLayoutPage.FileListItem_PointerEntered (cyclomatic 20) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1362 — BaseLayoutPage.FileListItem_PointerEntered has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 6 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 1377). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · DetailsLayoutPage.FileList_ItemTapped (cyclomatic 20) · ×1
  • DetailsLayoutPage.FileList_ItemTapped (cyclomatic 20) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:606 — DetailsLayoutPage.FileList_ItemTapped has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged (cyclomatic 20) · ×1
  • BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged (cyclomatic 20) src/Files.App/Views/Shells/BaseShellPage.cs:592 — BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RegistrySerializationGenerator.EmitBindValues (cyclomatic 19) · ×1
  • RegistrySerializationGenerator.EmitBindValues (cyclomatic 19) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:81 — RegistrySerializationGenerator.EmitBindValues has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · RegistrySerializationGenerator.EmitSaveValues (cyclomatic 19) · ×1
  • RegistrySerializationGenerator.EmitSaveValues (cyclomatic 19) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:245 — RegistrySerializationGenerator.EmitSaveValues has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · WindowsStorableHelpers.TryConvertGpBitmapToByteArray (cyclomatic 19) · ×1
  • WindowsStorableHelpers.TryConvertGpBitmapToByteArray (cyclomatic 19) src/Files.App.Storage/Windows/Helpers/WindowsStorableHelpers.Icon.cs:152 — WindowsStorableHelpers.TryConvertGpBitmapToByteArray has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StorageHelpers.ToStorageItem (cyclomatic 19) · ×1
  • StorageHelpers.ToStorageItem (cyclomatic 19) src/Files.App/Utils/Storage/Helpers/StorageHelpers.cs:21 — StorageHelpers.ToStorageItem has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FolderSearch.SearchTagsAsync (cyclomatic 19) · ×1
  • FolderSearch.SearchTagsAsync (cyclomatic 19) src/Files.App/Utils/Storage/Search/FolderSearch.cs:293 — FolderSearch.SearchTagsAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BaseLayoutPage.Item_DragOver (cyclomatic 19) · ×1
  • BaseLayoutPage.Item_DragOver (cyclomatic 19) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1109 — BaseLayoutPage.Item_DragOver has cyclomatic complexity 19 (threshold 15). Of this number, 16 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StorageBar.UpdateColumnWidths (cyclomatic 18) · ×1
  • StorageBar.UpdateColumnWidths (cyclomatic 18) src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:144 — StorageBar.UpdateColumnWidths has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ThemedIcon.OnIconColorTypeChanged (cyclomatic 18) · ×1
  • ThemedIcon.OnIconColorTypeChanged (cyclomatic 18) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:181 — ThemedIcon.OnIconColorTypeChanged has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
D1 · Cyclomatic Complexity · TransferHelpers.ExecuteTransferAsync (cyclomatic 18) · ×1
  • TransferHelpers.ExecuteTransferAsync (cyclomatic 18) src/Files.App/Helpers/TransferHelpers.cs:77 — TransferHelpers.ExecuteTransferAsync has cyclomatic complexity 18 (threshold 15). Of this number, 11 points are the body's own statements and 7 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SortingHelper.OrderFileList (cyclomatic 18) · ×1
  • SortingHelper.OrderFileList (cyclomatic 18) src/Files.App/Utils/Storage/Collection/SortingHelper.cs:31 — SortingHelper.OrderFileList has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilesystemHelpers.DeleteItemsAsync (cyclomatic 18) · ×1
  • FilesystemHelpers.DeleteItemsAsync (cyclomatic 18) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:86 — FilesystemHelpers.DeleteItemsAsync has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilesystemOperations.RenameAsync (cyclomatic 18) · ×1
  • FilesystemOperations.RenameAsync (cyclomatic 18) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:582 — FilesystemOperations.RenameAsync has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode (cyclomatic 18) · ×1
  • NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode (cyclomatic 18) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:942 — NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 3 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 944). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · SidebarViewModel.GetLocationItemMenuItems (cyclomatic 18) · ×1
  • SidebarViewModel.GetLocationItemMenuItems (cyclomatic 18) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1037 — SidebarViewModel.GetLocationItemMenuItems has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · ColumnLayoutPage.FileList_ItemTapped (cyclomatic 18) · ×1
  • ColumnLayoutPage.FileList_ItemTapped (cyclomatic 18) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:560 — ColumnLayoutPage.FileList_ItemTapped has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibraryManager.UpdateLibrary (cyclomatic 17) · ×1
  • LibraryManager.UpdateLibrary (cyclomatic 17) src/Files.App/Utils/Library/LibraryManager.cs:175 — LibraryManager.UpdateLibrary has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 8 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 181). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · FileOperationsHelpers.UpdateFileTagsDb (cyclomatic 17) · ×1
  • FileOperationsHelpers.UpdateFileTagsDb (cyclomatic 17) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:966 — FileOperationsHelpers.UpdateFileTagsDb has cyclomatic complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FilesystemHelpers.GetCollisions (cyclomatic 17) · ×1
  • FilesystemHelpers.GetCollisions (cyclomatic 17) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:647 — FilesystemHelpers.GetCollisions has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FileProperties.GetBaseProperties (cyclomatic 17) · ×1
  • FileProperties.GetBaseProperties (cyclomatic 17) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:32 — FileProperties.GetBaseProperties has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ActionsViewModel.ExecuteSaveCommand (cyclomatic 17) · ×1
  • ActionsViewModel.ExecuteSaveCommand (cyclomatic 17) src/Files.App/ViewModels/Settings/ActionsViewModel.cs:307 — ActionsViewModel.ExecuteSaveCommand has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ShellViewModel.LoadGitPropertiesAsync (cyclomatic 17) · ×1
  • ShellViewModel.LoadGitPropertiesAsync (cyclomatic 17) src/Files.App/ViewModels/ShellViewModel.cs:1613 — ShellViewModel.LoadGitPropertiesAsync has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 6 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 1641, 1625). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · SidebarViewModel.SyncSidebarItemsAsync (cyclomatic 17) · ×1
  • SidebarViewModel.SyncSidebarItemsAsync (cyclomatic 17) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:394 — SidebarViewModel.SyncSidebarItemsAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SidebarViewModel.HandleItemInvokedAsync (cyclomatic 17) · ×1
  • SidebarViewModel.HandleItemInvokedAsync (cyclomatic 17) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:851 — SidebarViewModel.HandleItemInvokedAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GridLayoutPage.StartRenameItem (cyclomatic 17) · ×1
  • GridLayoutPage.StartRenameItem (cyclomatic 17) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:365 — GridLayoutPage.StartRenameItem has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GridLayoutPage.FileList_ItemTapped (cyclomatic 17) · ×1
  • GridLayoutPage.FileList_ItemTapped (cyclomatic 17) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:608 — GridLayoutPage.FileList_ItemTapped has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LayoutCycler.Cycle (cyclomatic 16) · ×1
  • LayoutCycler.Cycle (cyclomatic 16) src/Files.App/Actions/Display/LayoutAction.cs:345 — LayoutCycler.Cycle has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LibGit2Service.Checkout (cyclomatic 16) · ×1
  • LibGit2Service.Checkout (cyclomatic 16) src/Files.App/Services/Git/LibGit2Service.cs:163 — LibGit2Service.Checkout has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · StorageArchiveService.DecompressAsyncWithSharpZipLib (cyclomatic 16) · ×1
  • StorageArchiveService.DecompressAsyncWithSharpZipLib (cyclomatic 16) src/Files.App/Services/Storage/StorageArchiveService.cs:230 — StorageArchiveService.DecompressAsyncWithSharpZipLib has cyclomatic complexity 16 (threshold 15). Of this number, 11 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · WindowsRecentItemsService.UpdateRecentItems (cyclomatic 16) · ×1
  • WindowsRecentItemsService.UpdateRecentItems (cyclomatic 16) src/Files.App/Services/Windows/WindowsRecentItemsService.cs:186 — WindowsRecentItemsService.UpdateRecentItems has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationToolbar.Omnibar_QuerySubmitted (cyclomatic 16) · ×1
  • NavigationToolbar.Omnibar_QuerySubmitted (cyclomatic 16) src/Files.App/UserControls/NavigationToolbar.xaml.cs:172 — NavigationToolbar.Omnibar_QuerySubmitted has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StatusCenterItemProgressModel.Report (cyclomatic 16) · ×1
  • StatusCenterItemProgressModel.Report (cyclomatic 16) src/Files.App/Utils/StatusCenter/StatusCenterItemProgressModel.cs:155 — StatusCenterItemProgressModel.Report has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CombinedProperties.GetSpecialPropertiesAsync (cyclomatic 16) · ×1
  • CombinedProperties.GetSpecialPropertiesAsync (cyclomatic 16) src/Files.App/ViewModels/Properties/Items/CombinedProperties.cs:51 — CombinedProperties.GetSpecialPropertiesAsync has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NavigationToolbarViewModel.PathBoxItem_DragOver (cyclomatic 16) · ×1
  • NavigationToolbarViewModel.PathBoxItem_DragOver (cyclomatic 16) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:432 — NavigationToolbarViewModel.PathBoxItem_DragOver has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D11 · Test Reliability · Test reliability not measured · ×1
  • Test reliability not measured — no test run produced results — Test reliability NOT MEASURED: the test run produced no results fo...

    Downloadable artifacts

    Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.