Public report of files-community/Files, published 22 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 22 October 2026, 23:54 UTC · Survey ID cd_f84357197f074e4cafab610328e160e6
files-community/Files
Measured 22 October 2026, 23:46 UTC, at code version ee399b0
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
Code coverage is not measured: No coverage collector is wired up.
Test reliability is not measured: No test run produced results.
Boundary Type-Coupling is not measured: Bounded contexts not declared.
CAI scoreAdequate
CriticalWeakAdequateStrongExemplary
No change since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 121,347 lines of product code in 9 projects, tests not counted · Estimated rebuild effort: about 2.6 person-years · Weakest lens: Maturity, 56
Findings by how serious they are
168 critical925 serious225 minor
4 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
22 October 2026, 23:46 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
71of 76 dimensions measured by tools. The other 5 are advisory notes from an AI model, which explain the code but don't count towards the score.
1297of 1318 findings point to an exact file and line, so you can open each one in the code. The other 21 concern the repository as a whole, such as missing documentation.
76dimensions across 6 lenses, read from 121,347 lines of product code in 9 projects.
files-community/Files scores 58 out of 100 and is rated Adequate, while three of its six lenses score higher still: Architecture at 77, Security and Compliance at 68 and Performance at 61, all rated Adequate.
The score is lower than those three because the weakest lens counts most, and here that is Maturity, which scores 56 and is rated Adequate. Its Architecture documentation dimension scores 2 out of 10, and until that reaches 4, Maturity can't be rated higher than Adequate. The first actions are to resolve the 1 No ADRs found finding(s) in ADR Quality and to resolve the 3 FileScopedPragmaDisable finding(s) in Explicit Debt. The weakest lenses score close to each other, so improving any of them moves the score.
168 findings are critical: 90 in Static Analysis (SAST), 72 in Explicit Debt, two in Project dependency cycles, one in Change Coupling, one in REDACTED Scanning, one in Secrets (history) and one in Test Quality.
Watchdog couldn't measure Dependency Hygiene, IL Efficiency and Runtime evidence locked — no reproducible boot in this code, so those dimensions are left out of the score. The product code is 121,347 lines, which would take an estimated 2.6 person-years, around €380,000, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
The weakest lenses score close to each other, so improving any of them moves the score.
Code composition: what the lines of code are
Business logic 49%Supporting code 48%Tests 2%Code analyzers 1%
New since the last survey: 126 findings
These 126 critical or serious findings weren't in the previous survey, on 8 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 749 findings
These 749 critical or serious findings were in the previous survey, on 8 October 2026, and are gone from this one. The first 100 are listed here.
€120,000 to €640,000, for 2,053 to 6,711 hours of work, about 2.6 person-years for 1 to 5 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 58. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 121,347 lines of product code
Comment lines
The estimate prices 108,528 lines. Comment lines count towards the size of 121,347 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Raises the score by about 2 points · Low effort · ADR Quality
2
Resolve the 3 FileScopedPragmaDisable finding(s) in Explicit Debt — start with HashCode.cs (2), FilesystemHelpers.cs.
Raises the score by about 1 point · Low effort · Explicit Debt
3
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €380,000 to build again, about 2.6 person-years of work. Its weakest lens is Maturity, at 56 (Adequate). Maturity is about how well the project explains and looks after itself, which decides whether a new developer, or a new supplier, can take over. Because the weakest lens counts most in the score, work on Maturity also moves the score most.
Based on: the rebuild estimate · the Maturity grade · how much each lens counts
What to do: Start with the Maturity actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 2 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
87 modules, with 386 dependencies between them. 2 loops run through 39 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 47 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
App.Services.DateTimeFormatter uses App.Data.Enums, so a change to App.Data.Enums can break App.Services.DateTimeFormatter, while a change to App.Services.DateTimeFormatter can't break App.Data.Enums.
Position
Below the diagonal: App.Services.DateTimeFormatter uses a module listed above it, which is the healthy direction.
6→26 App.Services.DateTimeFormatter uses App.Data.EventArgumentspart of a loop✕
Connections
1 pair of types, where a type in App.Services.DateTimeFormatter uses a type in App.Data.EventArguments.
App.Services.DateTimeFormatter uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Services.DateTimeFormatter, while a change to App.Services.DateTimeFormatter can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
6→28 App.Services.DateTimeFormatter uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.Services.DateTimeFormatter uses a type in App.Data.Contracts.
App.Services.DateTimeFormatter uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Services.DateTimeFormatter, while a change to App.Services.DateTimeFormatter can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
7→23 App.UserControls.TabBar uses App.Data.Parameterspart of a loop✕
Connections
4 pairs of types, where a type in App.UserControls.TabBar uses a type in App.Data.Parameters.
App.UserControls.TabBar uses App.Data.Parameters, so a change to App.Data.Parameters can break App.UserControls.TabBar, while a change to App.UserControls.TabBar can't break App.Data.Parameters.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
7→26 App.UserControls.TabBar uses App.Data.EventArgumentspart of a loop✕
Connections
2 pairs of types, where a type in App.UserControls.TabBar uses a type in App.Data.EventArguments.
App.UserControls.TabBar uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.UserControls.TabBar, while a change to App.UserControls.TabBar can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
7→28 App.UserControls.TabBar uses App.Data.Contractspart of a loop✕
Connections
2 pairs of types, where a type in App.UserControls.TabBar uses a type in App.Data.Contracts.
App.UserControls.TabBar uses App.Data.Contracts, so a change to App.Data.Contracts can break App.UserControls.TabBar, while a change to App.UserControls.TabBar can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
7→31 App.UserControls.TabBar uses App.Data.Contextspart of a loop✕
Connections
1 pair of types, where a type in App.UserControls.TabBar uses a type in App.Data.Contexts.
App.UserControls.TabBar uses App.Data.Contexts, so a change to App.Data.Contexts can break App.UserControls.TabBar, while a change to App.UserControls.TabBar can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Utils.Shell uses App.Data.Enums, so a change to App.Data.Enums can break App.Utils.Shell, while a change to App.Utils.Shell can't break App.Data.Enums.
Position
Below the diagonal: App.Utils.Shell uses a module listed above it, which is the healthy direction.
App.Utils.Shell uses App.Data.Items, so a change to App.Data.Items can break App.Utils.Shell, while a change to App.Utils.Shell can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Dialogs uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels.Dialogs uses a module listed above it, which is the healthy direction.
App.ViewModels.Dialogs uses Shared.Utils, so a change to Shared.Utils can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break Shared.Utils.
Position
Below the diagonal: App.ViewModels.Dialogs uses a module listed above it, which is the healthy direction.
9→15 App.ViewModels.Dialogs uses App.Utils.Storagepart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Dialogs uses a type in App.Utils.Storage.
App.ViewModels.Dialogs uses App.Utils.Storage, so a change to App.Utils.Storage can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Utils.Storage.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
9→25 App.ViewModels.Dialogs uses App.Data.Modelspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels.Dialogs uses a type in App.Data.Models.
App.ViewModels.Dialogs uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
9→28 App.ViewModels.Dialogs uses App.Data.Contractspart of a loop✕
Connections
3 pairs of types, where a type in App.ViewModels.Dialogs uses a type in App.Data.Contracts.
App.ViewModels.Dialogs uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
9→31 App.ViewModels.Dialogs uses App.Data.Contextspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Dialogs uses a type in App.Data.Contexts.
App.ViewModels.Dialogs uses App.Data.Contexts, so a change to App.Data.Contexts can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
9→34 App.ViewModels.Dialogs uses App.Data.Itemspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels.Dialogs uses a type in App.Data.Items.
App.ViewModels.Dialogs uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels.Dialogs, while a change to App.ViewModels.Dialogs can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Dialogs.AddItemDialog uses Shared, so a change to Shared can break App.ViewModels.Dialogs.AddItemDialog, while a change to App.ViewModels.Dialogs.AddItemDialog can't break Shared.
Position
Below the diagonal: App.ViewModels.Dialogs.AddItemDialog uses a module listed above it, which is the healthy direction.
App.ViewModels.Dialogs.AddItemDialog uses Shared.Utils, so a change to Shared.Utils can break App.ViewModels.Dialogs.AddItemDialog, while a change to App.ViewModels.Dialogs.AddItemDialog can't break Shared.Utils.
Position
Below the diagonal: App.ViewModels.Dialogs.AddItemDialog uses a module listed above it, which is the healthy direction.
10→25 App.ViewModels.Dialogs.AddItemDialog uses App.Data.Modelspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels.Dialogs.AddItemDialog uses a type in App.Data.Models.
App.ViewModels.Dialogs.AddItemDialog uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.Dialogs.AddItemDialog, while a change to App.ViewModels.Dialogs.AddItemDialog can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
10→28 App.ViewModels.Dialogs.AddItemDialog uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Dialogs.AddItemDialog uses a type in App.Data.Contracts.
App.ViewModels.Dialogs.AddItemDialog uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Dialogs.AddItemDialog, while a change to App.ViewModels.Dialogs.AddItemDialog can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Settings uses App.Controls, so a change to App.Controls can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Controls.
Position
Below the diagonal: App.ViewModels.Settings uses a module listed above it, which is the healthy direction.
App.ViewModels.Settings uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels.Settings uses a module listed above it, which is the healthy direction.
11→24 App.ViewModels.Settings uses App.Helperspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Settings uses a type in App.Helpers.
App.ViewModels.Settings uses App.Helpers, so a change to App.Helpers can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Helpers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
11→25 App.ViewModels.Settings uses App.Data.Modelspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Settings uses a type in App.Data.Models.
App.ViewModels.Settings uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
11→28 App.ViewModels.Settings uses App.Data.Contractspart of a loop✕
Connections
18 pairs of types, where a type in App.ViewModels.Settings uses a type in App.Data.Contracts.
App.ViewModels.Settings uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
11→34 App.ViewModels.Settings uses App.Data.Itemspart of a loop✕
Connections
7 pairs of types, where a type in App.ViewModels.Settings uses a type in App.Data.Items.
App.ViewModels.Settings uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels.Settings, while a change to App.ViewModels.Settings can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels, while a change to App.ViewModels can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels uses a module listed above it, which is the healthy direction.
App.ViewModels uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.ViewModels, while a change to App.ViewModels can't break App.UserControls.TabBar.
Position
Below the diagonal: App.ViewModels uses a module listed above it, which is the healthy direction.
12→15 App.ViewModels uses App.Utils.Storagepart of a loop✕
Connections
5 pairs of types, where a type in App.ViewModels uses a type in App.Utils.Storage.
App.ViewModels uses App.Utils.Storage, so a change to App.Utils.Storage can break App.ViewModels, while a change to App.ViewModels can't break App.Utils.Storage.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→17 App.ViewModels uses App.Utilspart of a loop✕
Connections
5 pairs of types, where a type in App.ViewModels uses a type in App.Utils.
App.ViewModels uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.ViewModels, while a change to App.ViewModels can't break App.ViewModels.UserControls.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→21 App.ViewModels uses App.UserControlspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels uses a type in App.UserControls.
App.ViewModels uses App.UserControls, so a change to App.UserControls can break App.ViewModels, while a change to App.ViewModels can't break App.UserControls.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→24 App.ViewModels uses App.Helperspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels uses a type in App.Helpers.
App.ViewModels uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels, while a change to App.ViewModels can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→26 App.ViewModels uses App.Data.EventArgumentspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels uses a type in App.Data.EventArguments.
App.ViewModels uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.ViewModels, while a change to App.ViewModels can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→28 App.ViewModels uses App.Data.Contractspart of a loop✕
Connections
16 pairs of types, where a type in App.ViewModels uses a type in App.Data.Contracts.
App.ViewModels uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels, while a change to App.ViewModels can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→31 App.ViewModels uses App.Data.Contextspart of a loop✕
Connections
2 pairs of types, where a type in App.ViewModels uses a type in App.Data.Contexts.
App.ViewModels uses App.Data.Contexts, so a change to App.Data.Contexts can break App.ViewModels, while a change to App.ViewModels can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
12→34 App.ViewModels uses App.Data.Itemspart of a loop✕
Connections
3 pairs of types, where a type in App.ViewModels uses a type in App.Data.Items.
App.ViewModels uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels, while a change to App.ViewModels can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Dialogs.FileSystemDialog uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels.Dialogs.FileSystemDialog, while a change to App.ViewModels.Dialogs.FileSystemDialog can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels.Dialogs.FileSystemDialog uses a module listed above it, which is the healthy direction.
App.ViewModels.Dialogs.FileSystemDialog uses Shared.Utils, so a change to Shared.Utils can break App.ViewModels.Dialogs.FileSystemDialog, while a change to App.ViewModels.Dialogs.FileSystemDialog can't break Shared.Utils.
Position
Below the diagonal: App.ViewModels.Dialogs.FileSystemDialog uses a module listed above it, which is the healthy direction.
App.ViewModels.Dialogs.FileSystemDialog uses App.ViewModels.Dialogs, so a change to App.ViewModels.Dialogs can break App.ViewModels.Dialogs.FileSystemDialog, while a change to App.ViewModels.Dialogs.FileSystemDialog can't break App.ViewModels.Dialogs.
Position
Below the diagonal: App.ViewModels.Dialogs.FileSystemDialog uses a module listed above it, which is the healthy direction.
13→28 App.ViewModels.Dialogs.FileSystemDialog uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.Dialogs.FileSystemDialog uses a type in App.Data.Contracts.
App.ViewModels.Dialogs.FileSystemDialog uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Dialogs.FileSystemDialog, while a change to App.ViewModels.Dialogs.FileSystemDialog can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Dialogs uses App.ViewModels.Dialogs, so a change to App.ViewModels.Dialogs can break App.Dialogs, while a change to App.Dialogs can't break App.ViewModels.Dialogs.
Position
Below the diagonal: App.Dialogs uses a module listed above it, which is the healthy direction.
App.Dialogs uses App.ViewModels.Dialogs.AddItemDialog, so a change to App.ViewModels.Dialogs.AddItemDialog can break App.Dialogs, while a change to App.Dialogs can't break App.ViewModels.Dialogs.AddItemDialog.
Position
Below the diagonal: App.Dialogs uses a module listed above it, which is the healthy direction.
App.Dialogs uses App.ViewModels.Settings, so a change to App.ViewModels.Settings can break App.Dialogs, while a change to App.Dialogs can't break App.ViewModels.Settings.
Position
Below the diagonal: App.Dialogs uses a module listed above it, which is the healthy direction.
App.Dialogs uses App.ViewModels.Dialogs.FileSystemDialog, so a change to App.ViewModels.Dialogs.FileSystemDialog can break App.Dialogs, while a change to App.Dialogs can't break App.ViewModels.Dialogs.FileSystemDialog.
Position
Below the diagonal: App.Dialogs uses a module listed above it, which is the healthy direction.
14→28 App.Dialogs uses App.Data.Contractspart of a loop✕
Connections
2 pairs of types, where a type in App.Dialogs uses a type in App.Data.Contracts.
App.Dialogs uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Dialogs, while a change to App.Dialogs can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
14→34 App.Dialogs uses App.Data.Itemspart of a loop✕
Connections
2 pairs of types, where a type in App.Dialogs uses a type in App.Data.Items.
27 pairs of types, where a type in App.Utils.Storage uses a type in App.Data.Enums. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Utils.Storage uses App.Data.Enums, so a change to App.Data.Enums can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Data.Enums.
Position
Below the diagonal: App.Utils.Storage uses a module listed above it, which is the healthy direction.
App.Utils.Storage uses App.Services.DateTimeFormatter, so a change to App.Services.DateTimeFormatter can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Services.DateTimeFormatter.
Position
Below the diagonal: App.Utils.Storage uses a module listed above it, which is the healthy direction.
App.Utils.Storage uses App.Utils.Shell, so a change to App.Utils.Shell can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Utils.Shell.
Position
Below the diagonal: App.Utils.Storage uses a module listed above it, which is the healthy direction.
App.Utils.Storage uses App.ViewModels, so a change to App.ViewModels can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.ViewModels.
Position
Below the diagonal: App.Utils.Storage uses a module listed above it, which is the healthy direction.
App.Utils.Storage uses App.ViewModels.Dialogs.FileSystemDialog, so a change to App.ViewModels.Dialogs.FileSystemDialog can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.ViewModels.Dialogs.FileSystemDialog.
Position
Below the diagonal: App.Utils.Storage uses a module listed above it, which is the healthy direction.
15→17 App.Utils.Storage uses App.Utilspart of a loop✕
Connections
12 pairs of types, where a type in App.Utils.Storage uses a type in App.Utils.
App.Utils.Storage uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.ViewModels.UserControls.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→20 App.Utils.Storage uses App.Utils.StatusCenterpart of a loop✕
Connections
4 pairs of types, where a type in App.Utils.Storage uses a type in App.Utils.StatusCenter.
App.Utils.Storage uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Utils.StatusCenter.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→24 App.Utils.Storage uses App.Helperspart of a loop✕
Connections
3 pairs of types, where a type in App.Utils.Storage uses a type in App.Helpers.
App.Utils.Storage uses App.Helpers, so a change to App.Helpers can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Helpers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→25 App.Utils.Storage uses App.Data.Modelspart of a loop✕
Connections
2 pairs of types, where a type in App.Utils.Storage uses a type in App.Data.Models.
App.Utils.Storage uses App.Data.Models, so a change to App.Data.Models can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→28 App.Utils.Storage uses App.Data.Contractspart of a loop✕
Connections
18 pairs of types, where a type in App.Utils.Storage uses a type in App.Data.Contracts.
App.Utils.Storage uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
15→34 App.Utils.Storage uses App.Data.Itemspart of a loop✕
Connections
17 pairs of types, where a type in App.Utils.Storage uses a type in App.Data.Items.
App.Utils.Storage uses App.Data.Items, so a change to App.Data.Items can break App.Utils.Storage, while a change to App.Utils.Storage can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Properties uses App.Controls, so a change to App.Controls can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Controls.
Position
Below the diagonal: App.ViewModels.Properties uses a module listed above it, which is the healthy direction.
App.ViewModels.Properties uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels.Properties uses a module listed above it, which is the healthy direction.
App.ViewModels.Properties uses App.Utils.Storage, so a change to App.Utils.Storage can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Utils.Storage.
Position
Below the diagonal: App.ViewModels.Properties uses a module listed above it, which is the healthy direction.
16→17 App.ViewModels.Properties uses App.Utilspart of a loop✕
Connections
8 pairs of types, where a type in App.ViewModels.Properties uses a type in App.Utils.
App.ViewModels.Properties uses App.Utils, so a change to App.Utils can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Utils.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→23 App.ViewModels.Properties uses App.Data.Parameterspart of a loop✕
Connections
3 pairs of types, where a type in App.ViewModels.Properties uses a type in App.Data.Parameters.
App.ViewModels.Properties uses App.Data.Parameters, so a change to App.Data.Parameters can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Data.Parameters.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→25 App.ViewModels.Properties uses App.Data.Modelspart of a loop✕
Connections
10 pairs of types, where a type in App.ViewModels.Properties uses a type in App.Data.Models.
App.ViewModels.Properties uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→28 App.ViewModels.Properties uses App.Data.Contractspart of a loop✕
Connections
17 pairs of types, where a type in App.ViewModels.Properties uses a type in App.Data.Contracts.
App.ViewModels.Properties uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
16→34 App.ViewModels.Properties uses App.Data.Itemspart of a loop✕
Connections
8 pairs of types, where a type in App.ViewModels.Properties uses a type in App.Data.Items.
App.ViewModels.Properties uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels.Properties, while a change to App.ViewModels.Properties can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Utils uses App.Services.DateTimeFormatter, so a change to App.Services.DateTimeFormatter can break App.Utils, while a change to App.Utils can't break App.Services.DateTimeFormatter.
Position
Below the diagonal: App.Utils uses a module listed above it, which is the healthy direction.
App.Utils uses App.ViewModels.Properties, so a change to App.ViewModels.Properties can break App.Utils, while a change to App.Utils can't break App.ViewModels.Properties.
Position
Below the diagonal: App.Utils uses a module listed above it, which is the healthy direction.
17→25 App.Utils uses App.Data.Modelspart of a loop✕
Connections
4 pairs of types, where a type in App.Utils uses a type in App.Data.Models.
App.Utils uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Utils, while a change to App.Utils can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
17→28 App.Utils uses App.Data.Contractspart of a loop✕
Connections
4 pairs of types, where a type in App.Utils uses a type in App.Data.Contracts.
App.ViewModels.UserControls uses App.Controls, so a change to App.Controls can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Controls.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.Data.Enums, so a change to App.Data.Enums can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.Enums.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses Shared.Utils, so a change to Shared.Utils can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break Shared.Utils.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses Storage, so a change to Storage can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break Storage.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.UserControls.TabBar.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.ViewModels.Settings, so a change to App.ViewModels.Settings can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.ViewModels.Settings.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.ViewModels, so a change to App.ViewModels can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.ViewModels.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.Utils.Storage, so a change to App.Utils.Storage can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Utils.Storage.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls uses App.Utils, so a change to App.Utils can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Utils.
Position
Below the diagonal: App.ViewModels.UserControls uses a module listed above it, which is the healthy direction.
18→20 App.ViewModels.UserControls uses App.Utils.StatusCenterpart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.UserControls uses a type in App.Utils.StatusCenter.
App.ViewModels.UserControls uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Utils.StatusCenter.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→21 App.ViewModels.UserControls uses App.UserControlspart of a loop✕
Connections
1 pair of types, where a type in App.ViewModels.UserControls uses a type in App.UserControls.
App.ViewModels.UserControls uses App.UserControls, so a change to App.UserControls can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.UserControls.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→25 App.ViewModels.UserControls uses App.Data.Modelspart of a loop✕
Connections
9 pairs of types, where a type in App.ViewModels.UserControls uses a type in App.Data.Models.
App.ViewModels.UserControls uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→26 App.ViewModels.UserControls uses App.Data.EventArgumentspart of a loop✕
Connections
5 pairs of types, where a type in App.ViewModels.UserControls uses a type in App.Data.EventArguments.
App.ViewModels.UserControls uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→28 App.ViewModels.UserControls uses App.Data.Contractspart of a loop✕
Connections
18 pairs of types, where a type in App.ViewModels.UserControls uses a type in App.Data.Contracts.
App.ViewModels.UserControls uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→31 App.ViewModels.UserControls uses App.Data.Contextspart of a loop✕
Connections
3 pairs of types, where a type in App.ViewModels.UserControls uses a type in App.Data.Contexts.
App.ViewModels.UserControls uses App.Data.Contexts, so a change to App.Data.Contexts can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→34 App.ViewModels.UserControls uses App.Data.Itemspart of a loop✕
Connections
12 pairs of types, where a type in App.ViewModels.UserControls uses a type in App.Data.Items.
App.ViewModels.UserControls uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels.UserControls, while a change to App.ViewModels.UserControls can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Utils.Git uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Utils.Git, while a change to App.Utils.Git can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Utils.Git uses a module listed above it, which is the healthy direction.
19→20 App.Utils.Git uses App.Utils.StatusCenterpart of a loop✕
Connections
2 pairs of types, where a type in App.Utils.Git uses a type in App.Utils.StatusCenter.
App.Utils.Git uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.Utils.Git, while a change to App.Utils.Git can't break App.Utils.StatusCenter.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→25 App.Utils.Git uses App.Data.Modelspart of a loop✕
Connections
1 pair of types, where a type in App.Utils.Git uses a type in App.Data.Models.
App.Utils.Git uses App.Data.Models, so a change to App.Data.Models can break App.Utils.Git, while a change to App.Utils.Git can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→28 App.Utils.Git uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.Utils.Git uses a type in App.Data.Contracts.
App.Utils.Git uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Utils.Git, while a change to App.Utils.Git can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→34 App.Utils.Git uses App.Data.Itemspart of a loop✕
Connections
1 pair of types, where a type in App.Utils.Git uses a type in App.Data.Items.
App.Utils.StatusCenter uses App.Data.Enums, so a change to App.Data.Enums can break App.Utils.StatusCenter, while a change to App.Utils.StatusCenter can't break App.Data.Enums.
Position
Below the diagonal: App.Utils.StatusCenter uses a module listed above it, which is the healthy direction.
App.Utils.StatusCenter uses App.Utils.Storage, so a change to App.Utils.Storage can break App.Utils.StatusCenter, while a change to App.Utils.StatusCenter can't break App.Utils.Storage.
Position
Below the diagonal: App.Utils.StatusCenter uses a module listed above it, which is the healthy direction.
App.Utils.StatusCenter uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Utils.StatusCenter, while a change to App.Utils.StatusCenter can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Utils.StatusCenter uses a module listed above it, which is the healthy direction.
App.Utils.StatusCenter uses App.Utils.Git, so a change to App.Utils.Git can break App.Utils.StatusCenter, while a change to App.Utils.StatusCenter can't break App.Utils.Git.
Position
Below the diagonal: App.Utils.StatusCenter uses a module listed above it, which is the healthy direction.
20→24 App.Utils.StatusCenter uses App.Helperspart of a loop✕
Connections
1 pair of types, where a type in App.Utils.StatusCenter uses a type in App.Helpers.
App.Utils.StatusCenter uses App.Helpers, so a change to App.Helpers can break App.Utils.StatusCenter, while a change to App.Utils.StatusCenter can't break App.Helpers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.UserControls uses App.Controls, so a change to App.Controls can break App.UserControls, while a change to App.UserControls can't break App.Controls.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
App.UserControls uses App.Data.Enums, so a change to App.Data.Enums can break App.UserControls, while a change to App.UserControls can't break App.Data.Enums.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
App.UserControls uses App.Utils.Shell, so a change to App.Utils.Shell can break App.UserControls, while a change to App.UserControls can't break App.Utils.Shell.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
App.UserControls uses App.ViewModels, so a change to App.ViewModels can break App.UserControls, while a change to App.UserControls can't break App.ViewModels.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
App.UserControls uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.UserControls, while a change to App.UserControls can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
App.UserControls uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.UserControls, while a change to App.UserControls can't break App.Utils.StatusCenter.
Position
Below the diagonal: App.UserControls uses a module listed above it, which is the healthy direction.
21→25 App.UserControls uses App.Data.Modelspart of a loop✕
Connections
2 pairs of types, where a type in App.UserControls uses a type in App.Data.Models.
App.UserControls uses App.Data.Models, so a change to App.Data.Models can break App.UserControls, while a change to App.UserControls can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
21→28 App.UserControls uses App.Data.Contractspart of a loop✕
Connections
4 pairs of types, where a type in App.UserControls uses a type in App.Data.Contracts.
App.UserControls uses App.Data.Contracts, so a change to App.Data.Contracts can break App.UserControls, while a change to App.UserControls can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
21→31 App.UserControls uses App.Data.Contextspart of a loop✕
Connections
3 pairs of types, where a type in App.UserControls uses a type in App.Data.Contexts.
App.UserControls uses App.Data.Contexts, so a change to App.Data.Contexts can break App.UserControls, while a change to App.UserControls can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
21→33 App.UserControls uses App.Data.Commandspart of a loop✕
Connections
4 pairs of types, where a type in App.UserControls uses a type in App.Data.Commands.
App.UserControls uses App.Data.Commands, so a change to App.Data.Commands can break App.UserControls, while a change to App.UserControls can't break App.Data.Commands.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
21→34 App.UserControls uses App.Data.Itemspart of a loop✕
Connections
4 pairs of types, where a type in App.UserControls uses a type in App.Data.Items.
App.UserControls uses App.Data.Items, so a change to App.Data.Items can break App.UserControls, while a change to App.UserControls can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Views.Layouts uses App.Controls, so a change to App.Controls can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Controls.
Position
Below the diagonal: App.Views.Layouts uses a module listed above it, which is the healthy direction.
App.Views.Layouts uses App.Data.Enums, so a change to App.Data.Enums can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Enums.
Position
Below the diagonal: App.Views.Layouts uses a module listed above it, which is the healthy direction.
App.Views.Layouts uses App.ViewModels, so a change to App.ViewModels can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.ViewModels.
Position
Below the diagonal: App.Views.Layouts uses a module listed above it, which is the healthy direction.
App.Views.Layouts uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Views.Layouts uses a module listed above it, which is the healthy direction.
App.Views.Layouts uses App.UserControls, so a change to App.UserControls can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.UserControls.
Position
Below the diagonal: App.Views.Layouts uses a module listed above it, which is the healthy direction.
22→23 App.Views.Layouts uses App.Data.Parameterspart of a loop✕
Connections
2 pairs of types, where a type in App.Views.Layouts uses a type in App.Data.Parameters.
App.Views.Layouts uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Parameters.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→24 App.Views.Layouts uses App.Helperspart of a loop✕
Connections
1 pair of types, where a type in App.Views.Layouts uses a type in App.Helpers.
App.Views.Layouts uses App.Helpers, so a change to App.Helpers can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Helpers.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→25 App.Views.Layouts uses App.Data.Modelspart of a loop✕
Connections
7 pairs of types, where a type in App.Views.Layouts uses a type in App.Data.Models.
App.Views.Layouts uses App.Data.Models, so a change to App.Data.Models can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Models.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→26 App.Views.Layouts uses App.Data.EventArgumentspart of a loop✕
Connections
7 pairs of types, where a type in App.Views.Layouts uses a type in App.Data.EventArguments.
App.Views.Layouts uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→28 App.Views.Layouts uses App.Data.Contractspart of a loop✕
Connections
7 pairs of types, where a type in App.Views.Layouts uses a type in App.Data.Contracts.
App.Views.Layouts uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→31 App.Views.Layouts uses App.Data.Contextspart of a loop✕
Connections
1 pair of types, where a type in App.Views.Layouts uses a type in App.Data.Contexts.
App.Views.Layouts uses App.Data.Contexts, so a change to App.Data.Contexts can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
22→34 App.Views.Layouts uses App.Data.Itemspart of a loop✕
Connections
1 pair of types, where a type in App.Views.Layouts uses a type in App.Data.Items.
App.Views.Layouts uses App.Data.Items, so a change to App.Data.Items can break App.Views.Layouts, while a change to App.Views.Layouts can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Data.Parameters uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Parameters, while a change to App.Data.Parameters can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Parameters uses a module listed above it, which is the healthy direction.
App.Data.Parameters uses App.Views.Layouts, so a change to App.Views.Layouts can break App.Data.Parameters, while a change to App.Data.Parameters can't break App.Views.Layouts.
Position
Below the diagonal: App.Data.Parameters uses a module listed above it, which is the healthy direction.
23→26 App.Data.Parameters uses App.Data.EventArgumentspart of a loop✕
Connections
1 pair of types, where a type in App.Data.Parameters uses a type in App.Data.EventArguments.
App.Data.Parameters uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Data.Parameters, while a change to App.Data.Parameters can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
23→28 App.Data.Parameters uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.Data.Parameters uses a type in App.Data.Contracts.
App.Data.Parameters uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Parameters, while a change to App.Data.Parameters can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
27 pairs of types, where a type in App.Helpers uses a type in App.Data.Enums. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Helpers uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.Helpers, while a change to App.Helpers can't break App.UserControls.TabBar.
Position
Below the diagonal: App.Helpers uses a module listed above it, which is the healthy direction.
App.Helpers uses App.ViewModels.Dialogs, so a change to App.ViewModels.Dialogs can break App.Helpers, while a change to App.Helpers can't break App.ViewModels.Dialogs.
Position
Below the diagonal: App.Helpers uses a module listed above it, which is the healthy direction.
App.Helpers uses App.Utils.Storage, so a change to App.Utils.Storage can break App.Helpers, while a change to App.Helpers can't break App.Utils.Storage.
Position
Below the diagonal: App.Helpers uses a module listed above it, which is the healthy direction.
App.Helpers uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Helpers, while a change to App.Helpers can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Helpers uses a module listed above it, which is the healthy direction.
App.Helpers uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Helpers, while a change to App.Helpers can't break App.Data.Parameters.
Position
Below the diagonal: App.Helpers uses a module listed above it, which is the healthy direction.
24→25 App.Helpers uses App.Data.Modelspart of a loop✕
Connections
6 pairs of types, where a type in App.Helpers uses a type in App.Data.Models.
App.Helpers uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Helpers, while a change to App.Helpers can't break App.Data.EventArguments.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
24→28 App.Helpers uses App.Data.Contractspart of a loop✕
Connections
17 pairs of types, where a type in App.Helpers uses a type in App.Data.Contracts.
App.Helpers uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Helpers, while a change to App.Helpers can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
24→31 App.Helpers uses App.Data.Contextspart of a loop✕
Connections
2 pairs of types, where a type in App.Helpers uses a type in App.Data.Contexts.
App.Helpers uses App.Data.Contexts, so a change to App.Data.Contexts can break App.Helpers, while a change to App.Helpers can't break App.Data.Contexts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
24→34 App.Helpers uses App.Data.Itemspart of a loop✕
Connections
8 pairs of types, where a type in App.Helpers uses a type in App.Data.Items.
App.Data.Models uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Models, while a change to App.Data.Models can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Models uses a module listed above it, which is the healthy direction.
App.Data.Models uses App.Services.DateTimeFormatter, so a change to App.Services.DateTimeFormatter can break App.Data.Models, while a change to App.Data.Models can't break App.Services.DateTimeFormatter.
Position
Below the diagonal: App.Data.Models uses a module listed above it, which is the healthy direction.
App.Data.Models uses App.ViewModels.Settings, so a change to App.ViewModels.Settings can break App.Data.Models, while a change to App.Data.Models can't break App.ViewModels.Settings.
Position
Below the diagonal: App.Data.Models uses a module listed above it, which is the healthy direction.
App.Data.Models uses App.ViewModels.Properties, so a change to App.ViewModels.Properties can break App.Data.Models, while a change to App.Data.Models can't break App.ViewModels.Properties.
Position
Below the diagonal: App.Data.Models uses a module listed above it, which is the healthy direction.
App.Data.Models uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.Data.Models, while a change to App.Data.Models can't break App.Utils.StatusCenter.
Position
Below the diagonal: App.Data.Models uses a module listed above it, which is the healthy direction.
App.Data.Models uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Models, while a change to App.Data.Models can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
25→33 App.Data.Models uses App.Data.Commandspart of a loop✕
Connections
1 pair of types, where a type in App.Data.Models uses a type in App.Data.Commands.
App.Data.Models uses App.Data.Commands, so a change to App.Data.Commands can break App.Data.Models, while a change to App.Data.Models can't break App.Data.Commands.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
25→34 App.Data.Models uses App.Data.Itemspart of a loop✕
Connections
3 pairs of types, where a type in App.Data.Models uses a type in App.Data.Items.
App.Data.Models uses App.Data.Items, so a change to App.Data.Items can break App.Data.Models, while a change to App.Data.Models can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Data.EventArguments uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.Data.Enums.
Position
Below the diagonal: App.Data.EventArguments uses a module listed above it, which is the healthy direction.
App.Data.EventArguments uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.UserControls.TabBar.
Position
Below the diagonal: App.Data.EventArguments uses a module listed above it, which is the healthy direction.
App.Data.EventArguments uses App.Helpers, so a change to App.Helpers can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.Helpers.
Position
Below the diagonal: App.Data.EventArguments uses a module listed above it, which is the healthy direction.
App.Data.EventArguments uses App.Data.Models, so a change to App.Data.Models can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.Data.Models.
Position
Below the diagonal: App.Data.EventArguments uses a module listed above it, which is the healthy direction.
26→28 App.Data.EventArguments uses App.Data.Contractspart of a loop✕
Connections
1 pair of types, where a type in App.Data.EventArguments uses a type in App.Data.Contracts.
App.Data.EventArguments uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
26→34 App.Data.EventArguments uses App.Data.Itemspart of a loop✕
Connections
2 pairs of types, where a type in App.Data.EventArguments uses a type in App.Data.Items.
App.Data.EventArguments uses App.Data.Items, so a change to App.Data.Items can break App.Data.EventArguments, while a change to App.Data.EventArguments can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Views.Shells uses App.Data.Enums, so a change to App.Data.Enums can break App.Views.Shells, while a change to App.Views.Shells can't break App.Data.Enums.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.ViewModels, so a change to App.ViewModels can break App.Views.Shells, while a change to App.Views.Shells can't break App.ViewModels.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.Utils.Storage, so a change to App.Utils.Storage can break App.Views.Shells, while a change to App.Views.Shells can't break App.Utils.Storage.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Views.Shells, while a change to App.Views.Shells can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.Views.Layouts, so a change to App.Views.Layouts can break App.Views.Shells, while a change to App.Views.Shells can't break App.Views.Layouts.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Views.Shells, while a change to App.Views.Shells can't break App.Data.Parameters.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.Data.Models, so a change to App.Data.Models can break App.Views.Shells, while a change to App.Views.Shells can't break App.Data.Models.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
App.Views.Shells uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Views.Shells, while a change to App.Views.Shells can't break App.Data.EventArguments.
Position
Below the diagonal: App.Views.Shells uses a module listed above it, which is the healthy direction.
27→28 App.Views.Shells uses App.Data.Contractspart of a loop✕
Connections
5 pairs of types, where a type in App.Views.Shells uses a type in App.Data.Contracts.
App.Views.Shells uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Views.Shells, while a change to App.Views.Shells can't break App.Data.Contracts.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.Data.Contracts uses App.Controls, so a change to App.Controls can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Controls.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
34 pairs of types, where a type in App.Data.Contracts uses a type in App.Data.Enums. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Data.Contracts uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses Shared.Utils, so a change to Shared.Utils can break App.Data.Contracts, while a change to App.Data.Contracts can't break Shared.Utils.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.UserControls.TabBar.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.ViewModels.Dialogs, so a change to App.ViewModels.Dialogs can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.ViewModels.Dialogs.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.ViewModels, so a change to App.ViewModels can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.ViewModels.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Utils.Storage, so a change to App.Utils.Storage can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Utils.Storage.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Utils.StatusCenter, so a change to App.Utils.StatusCenter can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Utils.StatusCenter.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Views.Layouts, so a change to App.Views.Layouts can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Views.Layouts.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Data.Parameters.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Data.Models, so a change to App.Data.Models can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Data.Models.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Data.EventArguments.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
App.Data.Contracts uses App.Views.Shells, so a change to App.Views.Shells can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Views.Shells.
Position
Below the diagonal: App.Data.Contracts uses a module listed above it, which is the healthy direction.
28→34 App.Data.Contracts uses App.Data.Itemspart of a loop✕
Connections
10 pairs of types, where a type in App.Data.Contracts uses a type in App.Data.Items.
App.Data.Contracts uses App.Data.Items, so a change to App.Data.Items can break App.Data.Contracts, while a change to App.Data.Contracts can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
App.ViewModels.Previews uses App.Utils.Shell, so a change to App.Utils.Shell can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.Utils.Shell.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.ViewModels.Previews uses App.Utils.Storage, so a change to App.Utils.Storage can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.Utils.Storage.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.ViewModels.Previews uses App.ViewModels.Properties, so a change to App.ViewModels.Properties can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.ViewModels.Properties.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.ViewModels.Previews uses App.Utils, so a change to App.Utils can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.Utils.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.ViewModels.Previews uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.ViewModels.Previews uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.Previews, while a change to App.ViewModels.Previews can't break App.Data.Contracts.
Position
Below the diagonal: App.ViewModels.Previews uses a module listed above it, which is the healthy direction.
App.Views uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.Views, while a change to App.Views can't break App.UserControls.TabBar.
Position
Below the diagonal: App.Views uses a module listed above it, which is the healthy direction.
App.Views uses App.ViewModels.Settings, so a change to App.ViewModels.Settings can break App.Views, while a change to App.Views can't break App.ViewModels.Settings.
Position
Below the diagonal: App.Views uses a module listed above it, which is the healthy direction.
App.Views uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Views, while a change to App.Views can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Views uses a module listed above it, which is the healthy direction.
App.Views uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Views, while a change to App.Views can't break App.Data.Parameters.
Position
Below the diagonal: App.Views uses a module listed above it, which is the healthy direction.
App.Views uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Views, while a change to App.Views can't break App.Data.EventArguments.
Position
Below the diagonal: App.Views uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.UserControls.TabBar, so a change to App.UserControls.TabBar can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.UserControls.TabBar.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.ViewModels, so a change to App.ViewModels can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.ViewModels.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.Parameters, so a change to App.Data.Parameters can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.Parameters.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Helpers, so a change to App.Helpers can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Helpers.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.Models, so a change to App.Data.Models can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.Models.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.EventArguments.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.Contracts.
Position
Below the diagonal: App.Data.Contexts uses a module listed above it, which is the healthy direction.
App.Data.Contexts uses App.Data.Items, so a change to App.Data.Items can break App.Data.Contexts, while a change to App.Data.Contexts can't break App.Data.Items.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
187 pairs of types, where a type in App.Actions uses a type in App.Data.Enums. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Actions uses App.ViewModels.Dialogs.AddItemDialog, so a change to App.ViewModels.Dialogs.AddItemDialog can break App.Actions, while a change to App.Actions can't break App.ViewModels.Dialogs.AddItemDialog.
Position
Below the diagonal: App.Actions uses a module listed above it, which is the healthy direction.
App.Actions uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Actions, while a change to App.Actions can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Actions uses a module listed above it, which is the healthy direction.
App.Actions uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Actions, while a change to App.Actions can't break App.Data.EventArguments.
Position
Below the diagonal: App.Actions uses a module listed above it, which is the healthy direction.
42 pairs of types, where a type in App.Actions uses a type in App.Data.Contracts. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Actions uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Actions, while a change to App.Actions can't break App.Data.Contracts.
Position
Below the diagonal: App.Actions uses a module listed above it, which is the healthy direction.
168 pairs of types, where a type in App.Actions uses a type in App.Data.Contexts. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Actions uses App.Data.Contexts, so a change to App.Data.Contexts can break App.Actions, while a change to App.Actions can't break App.Data.Contexts.
Position
Below the diagonal: App.Actions uses a module listed above it, which is the healthy direction.
32→33 App.Actions uses App.Data.Commandspart of a loop✕
Connections
179 pairs of types, where a type in App.Actions uses a type in App.Data.Commands. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Actions uses App.Data.Commands, so a change to App.Data.Commands can break App.Actions, while a change to App.Actions can't break App.Data.Commands.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
32→34 App.Actions uses App.Data.Itemspart of a loop✕
Connections
1 pair of types, where a type in App.Actions uses a type in App.Data.Items.
App.Data.Commands uses App.Controls, so a change to App.Controls can break App.Data.Commands, while a change to App.Data.Commands can't break App.Controls.
Position
Below the diagonal: App.Data.Commands uses a module listed above it, which is the healthy direction.
App.Data.Commands uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Commands, while a change to App.Data.Commands can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Commands uses a module listed above it, which is the healthy direction.
App.Data.Commands uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Commands, while a change to App.Data.Commands can't break App.Data.Contracts.
Position
Below the diagonal: App.Data.Commands uses a module listed above it, which is the healthy direction.
App.Data.Commands uses App.Actions, so a change to App.Actions can break App.Data.Commands, while a change to App.Data.Commands can't break App.Actions.
Position
Below the diagonal: App.Data.Commands uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Items, while a change to App.Data.Items can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Utils.Storage, so a change to App.Utils.Storage can break App.Data.Items, while a change to App.Data.Items can't break App.Utils.Storage.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.Models, so a change to App.Data.Models can break App.Data.Items, while a change to App.Data.Items can't break App.Data.Models.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Data.Items, while a change to App.Data.Items can't break App.Data.EventArguments.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Items, while a change to App.Data.Items can't break App.Data.Contracts.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.Contexts, so a change to App.Data.Contexts can break App.Data.Items, while a change to App.Data.Items can't break App.Data.Contexts.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Items uses App.Data.Commands, so a change to App.Data.Commands can break App.Data.Items, while a change to App.Data.Items can't break App.Data.Commands.
Position
Below the diagonal: App.Data.Items uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.Data.Enums, so a change to App.Data.Enums can break App.Data.Factories, while a change to App.Data.Factories can't break App.Data.Enums.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.ViewModels, so a change to App.ViewModels can break App.Data.Factories, while a change to App.Data.Factories can't break App.ViewModels.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.ViewModels.Properties, so a change to App.ViewModels.Properties can break App.Data.Factories, while a change to App.Data.Factories can't break App.ViewModels.Properties.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.Data.Models, so a change to App.Data.Models can break App.Data.Factories, while a change to App.Data.Factories can't break App.Data.Models.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Data.Factories, while a change to App.Data.Factories can't break App.Data.Contracts.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.Data.Commands, so a change to App.Data.Commands can break App.Data.Factories, while a change to App.Data.Factories can't break App.Data.Commands.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Data.Factories uses App.Data.Items, so a change to App.Data.Items can break App.Data.Factories, while a change to App.Data.Factories can't break App.Data.Items.
Position
Below the diagonal: App.Data.Factories uses a module listed above it, which is the healthy direction.
App.Services uses App.ViewModels.Dialogs, so a change to App.ViewModels.Dialogs can break App.Services, while a change to App.Services can't break App.ViewModels.Dialogs.
Position
Below the diagonal: App.Services uses a module listed above it, which is the healthy direction.
App.Services uses App.ViewModels.UserControls, so a change to App.ViewModels.UserControls can break App.Services, while a change to App.Services can't break App.ViewModels.UserControls.
Position
Below the diagonal: App.Services uses a module listed above it, which is the healthy direction.
App.Services uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Services, while a change to App.Services can't break App.Data.EventArguments.
Position
Below the diagonal: App.Services uses a module listed above it, which is the healthy direction.
34 pairs of types, where a type in App.Services uses a type in App.Data.Contracts. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Services uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Services, while a change to App.Services can't break App.Data.Contracts.
Position
Below the diagonal: App.Services uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in App.Services.Settings uses a type in App.Data.Enums. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
App.Services.Settings uses App.Data.Enums, so a change to App.Data.Enums can break App.Services.Settings, while a change to App.Services.Settings can't break App.Data.Enums.
Position
Below the diagonal: App.Services.Settings uses a module listed above it, which is the healthy direction.
App.Services.Settings uses App.Data.Models, so a change to App.Data.Models can break App.Services.Settings, while a change to App.Services.Settings can't break App.Data.Models.
Position
Below the diagonal: App.Services.Settings uses a module listed above it, which is the healthy direction.
App.Services.Settings uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.Services.Settings, while a change to App.Services.Settings can't break App.Data.EventArguments.
Position
Below the diagonal: App.Services.Settings uses a module listed above it, which is the healthy direction.
App.Services.Settings uses App.Data.Contracts, so a change to App.Data.Contracts can break App.Services.Settings, while a change to App.Services.Settings can't break App.Data.Contracts.
Position
Below the diagonal: App.Services.Settings uses a module listed above it, which is the healthy direction.
App.Services.Settings uses App.Data.Items, so a change to App.Data.Items can break App.Services.Settings, while a change to App.Services.Settings can't break App.Data.Items.
Position
Below the diagonal: App.Services.Settings uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses Storage, so a change to Storage can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break Storage.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses App.Data.Models, so a change to App.Data.Models can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break App.Data.Models.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses App.Data.EventArguments, so a change to App.Data.EventArguments can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break App.Data.EventArguments.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses App.Data.Contracts, so a change to App.Data.Contracts can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break App.Data.Contracts.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses App.Data.Contexts, so a change to App.Data.Contexts can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break App.Data.Contexts.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
App.ViewModels.UserControls.Widgets uses App.Data.Items, so a change to App.Data.Items can break App.ViewModels.UserControls.Widgets, while a change to App.ViewModels.UserControls.Widgets can't break App.Data.Items.
Position
Below the diagonal: App.ViewModels.UserControls.Widgets uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
91
High / Critical
A03:2025 — Software Supply Chain Failures
8
Medium
A07:2025 — Authentication Failures
3
High / Critical
Roadmap
Immediately resolve the leaked secret in REDACTED and address the missing Architecture Decision Records by documenting significant design choices in a dedicated folder. Enhance the project's accessibility by adding a Testing section to the README that explains how to run the test suite. Finally, improve the overall documentation quality by ensuring all standard sections, such as building from source and contributing, are fully visible and complete.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 168
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 925
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 225
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 4
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 71 of 76 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 5 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 76 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1297 of 1318 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: the test run produced no results for any test tier, so no test ever ran and flakiness could not be exercised. The cause could not be attributed, so it is excluded from the score rather than read as an absence of tests.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The NuGet registry this repository's packages resolve from could not be reached on this run, so no outdated, vulnerable or deprecated package could be read. The tool said: NU1301: Unable to load the service index for source https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-Labs/nuget/v3/index.json. [Files.slnx] The proxy tunnel request to proxy 'http://egress:3128/' failed with status code '403'." [Files.slnx]. This is OUR side and an ENVIRONMENT fault — the collector exists and ran — so the remedy is the scan's network path to pkgs.dev.azure.com, and a re-run with it reachable measures this repository.
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Msbuild failed when processing the file 'src/Files.Storage/Files.Storage.csproj' with message: Reference path not found src/Files.Shared/bin/Debug/net10.0/Files.Shared.dll.
D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (117,577 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D28 Secrets (history) — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `src/Files.App/Assets/Resources/PropertiesInformation.json`, `src/Files.App/Assets/Resources/PreviewPanePropertiesInformation.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
D30 Dependency Vulnerabilities — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Pkgs.dev.azure.com could not be reached (NU1301: Unable to load the service index for source https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-Labs/nuget/v3/index.json. The proxy tunnel request to proxy 'http://egress:3128/' failed with status code '403'.). 1 of 2 declared ecosystem(s) (nuget packages.config) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/Files.App.Server/Initialization/CachedTask.cs`, `src/Files.App.Server/Initialization/InitializationCache.cs`, `src/Files.App.Server/Initialization/RegistryChangeMonitor.cs`, `src/Files.App/Actions/Display/LayoutAction.cs`, `src/Files.App/Data/Commands/Manager/CommandGroupManager.cs`, … (+17 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's build of this repository exited 1 and the cause could not be attributed, so no assemblies were produced and there was no IL to read. We do not read it as a defect in the repository: an unattributed failure leans OURS. D18 owns the question of whether this repository builds; it was not answered here.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (src/Files.App.Controls/BladeView/BladeView.xaml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 177 further occurrence(s) are not listed individually; the score already reflects all 217.
X1 Async correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 118 further occurrence(s) are not listed individually; the score already reflects all 158.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 350 further occurrence(s) are not listed individually; the score already reflects all 390.
X3 Exception handling — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 53 further occurrence(s) are not listed individually; the score already reflects all 93.
Package restore incomplete — third-party types were unresolved in part of the solution — NuGet restore did not complete for src/Files.App.Controls/Files.App.Controls.csproj, src/Files.App/Files.App.csproj, tests/Files.App.UITests/Files.App.UITests.csproj, so those projects were analysed with framework references only: every check keyed on a third-party type saw an error type there and reported nothing. Findings on those projects are a lower bound; run `dotnet restore` on them and rescan.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (5): D19, D21, D24, D26, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
103 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was ShellViewModel.LoadExtendedItemPropertiesAsync at 51. A further 16 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ContentPageContextFlyoutFactory.GetBaseItemMenuItems at 69 — they are counted neither in the figure above nor in this dimension's score. 9 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs (ContentPageContextFlyoutFactory.GetBaseItemMenuItems at 69), src/Files.App/Data/Enums/CopyEngineResult.cs (CopyEngineResult.Convert at 32), src/Files.App/Converters/ActionCategoryConverter.cs (ActionCategoryConverter.ToLocalizedCategoryPath at 23), src/Files.App/Helpers/Layout/LayoutSizeKindHelper.cs (LayoutSizeKindHelper.GetIconSize at 23), src/Files.App/Dialogs/CreateArchiveDialog.xaml.cs (DialogViewModel.GetEffectiveDictionaryBytes at 22), and 4 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 98 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 15 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with ShellViewModel.LoadExtendedItemPropertiesAsync (cyclomatic 51), StatusCenterHelper.UpdateCardStrings (cyclomatic 46), MainWindow.InitializeApplicationAsync (cyclomatic 44). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 15 together lifts Cyclomatic Complexity from 6.7 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 184 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 10 bodies over 60 down to 60 or less in Cognitive Complexity — start with FilesystemOperations.MoveAsync (cognitive 103), LaunchHelper.HandleApplicationLaunch (cognitive 102), FilesystemOperations.CopyAsync (cognitive 97). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 10 together lifts Cognitive Complexity from 6.0 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.0 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 34 TooManyMethods finding(s) in God Classes — start with SidebarViewModel.cs, ShellViewModel.cs, DetailsLayoutPage.xaml.cs. — One of this dimension's main actionable groups (34 warning-level).
Resolve the 17 FileTooLong finding(s) in God Classes — start with ShellViewModel.cs, BaseLayoutPage.cs, SidebarViewModel.cs. — One of this dimension's main actionable groups (17 warning-level).
Resolve the 13 MethodTooLong finding(s) in God Classes — start with ShellViewModel.cs (2), RegistrySerializationGenerator.cs (2), ContentPageContextFlyoutFactory.cs. — One of this dimension's main actionable groups (13 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
186 duplicated block group(s) detected. A further 10 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 74 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 21 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with ZipStorageFile.cs (3), ShellFilesystemOperations.cs (3), ShellViewModel.cs (2). — One of this dimension's main actionable groups (21 warning-level).
Resolve the 10 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with ZipStorageFile.cs (2), STATask.cs, TransferHelpers.cs. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 10 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with ShellFilesystemOperations.cs (2), ZipStorageFolder.cs, MainPageViewModel.cs. — One of this dimension's main actionable groups (10 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 11 Low cohesion finding(s) in Cohesion (LCOM4) — start with DetailsLayoutPage.xaml.cs, TabBar.xaml.cs, SidebarView.xaml.cs. — One of this dimension's main actionable groups (11 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
13 test methods: 13 unit, 0 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality7.7 / 10Adequategated by 1 critical finding✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
Resolve the 1 Assertions commented out finding(s) in Test Quality — start with SettingsTests.cs. — One of this dimension's main actionable groups (1 issue-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Enforce REDACTED Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 246 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 49 direct `PackageReference`(s), and 201 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 42 Hotspot finding(s) in Churn × Complexity Hotspots — start with ShellViewModel.cs, MainWindow.xaml.cs, NavigationToolbarViewModel.cs. — One of this dimension's main actionable groups (42 warning-level).
Resolve the 1 Repeated repair finding(s) in Churn × Complexity Hotspots — start with FilePropertiesHelpers.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor9.5 / 10Exemplary✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
20 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs. Counted over 399 of the 1107 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1
Further sole-owners (lower concentration)
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
151 deducted debt markers + unmeasured dead symbols across 117577 LoC in the .NET projects (0.7/KLoC) → score 8.6. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.
+ 5 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 66 EmptyCatchBlock finding(s) in Explicit Debt — start with ShellViewModel.cs (6), BaseShellPage.cs (3), UpdateTask.cs (2). — One of this dimension's main actionable groups (66 issue-level).
Resolve the 3 FileScopedPragmaDisable finding(s) in Explicit Debt — start with HashCode.cs (2), FilesystemHelpers.cs. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 WriteOnlyPrivateField finding(s) in Explicit Debt — start with EditPathAction.cs, StickyHeaderBehavior.cs. — One of this dimension's main actionable groups (2 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
9 projects, 1145 source files, 119468 hand-written lines of code (117577 production / 1891 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 8 inter-project edges (build status unknown — did not finish).
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
Files is a modern file manager written by the open-source community with an overview stating it is 'a community-driven project that depends on your support to grow and improve'. The README gives a strong hero image, links to GitHub actions, Crowdin localization status, Discord, and Microsoft Store purchase options. It documents installing and running Files (with store badge), but only one of the four standard sections exists: the outline lists Installing and running Files; Building from source; Contributing to Files; Screenshots — only the first is shown. The remaining three are clipped by the scanner before any judgment can be made.
Improve Documentation Quality — currently 6.0/10. — Files is a modern file manager written by the open-source community with an overview stating it is 'a community-driven project that depends on your support to grow and improve'. The README gives a strong hero image, links to GitHub actions, Crowdin localization status, Discord, and Microsoft Store purchase options. It documents installing and running Files (with store badge), but only one of the four standard sections exists: the outline lists Installing and running Files; Building from source; Contributing to Files; Screenshots — only the first is shown. The remaining three are clipped by the scanner before any judgment can be made.
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
0 naming inconsistencies across 200 sampled symbols.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md.
Do you agree with this assessment?
D24 · Comment ValueExemplary◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
1 of 9 projects flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D27 · Navigability7.5 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
78 % of calls cross a namespace and 6 % go through an interface, but 87 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
Resolve the 4 Pass-through layer finding(s) in Navigability — start with UserDateTimeFormatter.cs, StreamWithContentType.cs, SystemStorageFile.cs. — One of this dimension's main actionable groups (4 recommendation-level).
Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
91 finding(s): 0 critical, 90 high, 1 medium, 0 low. 46 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 22 file(s) — `src/Files.App.Server/Initialization/CachedTask.cs` (line 6), `src/Files.App.Server/Initialization/InitializationCache.cs` (line 169), `src/Files.App.Server/Initialization/RegistryChangeMonitor.cs` (line 12), `src/Files.App/Actions/Display/LayoutAction.cs`, `src/Files.App/Data/Commands/Manager/CommandGroupManager.cs` (lines 30–35, lines 57–62, lines 86–91, …), … (+17 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 9 of those file(s) — `src/Files.App.Server/Initialization/CachedTask.cs`, `src/Files.App.Server/Initialization/InitializationCache.cs`, `src/Files.App.Server/Initialization/RegistryChangeMonitor.cs`, `src/Files.App/Data/Items/ToolbarItemDescriptor.cs`, `src/Files.App/Utils/Shell/ContextMenuWorkerPool.cs`, … (+4 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 5 of those file(s) — `src/Files.App/Actions/Display/LayoutAction.cs`, `src/Files.App/Data/Models/ColumnsViewModel.cs`, `src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs`, `src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs`, `src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 6 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 38 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (14), REDACTED (14), REDACTED (5). — One of this dimension's main actionable groups (38 issue-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
No action in Static Analysis (SAST) — all 46 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (46 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
No known-vulnerable dependencies in the 1 ecosystem(s) that were scanned (nuget packages.config). Partial dependency scan: 1 of 2 declared ecosystem(s) were scanned (nuget packages.config), and the findings above are real and complete for them. nuget was not scanned (nuget: pkgs.dev.azure.com could not be reached (NU1301: Unable to load the service index for source https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-Labs/nuget/v3/index.json. The proxy tunnel request to proxy 'http://egress:3128/' failed with status code '403'.)), so this is not the whole dependency surface and the result is reported at reduced confidence.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
64 of 399 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Files.Core.SourceGenerator/Utilities/SourceGeneratorHelper.cs. Counted over 399 of the 1107 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 64 Orphaned file finding(s) in Knowledge Freshness — start with SourceGeneratorHelper.cs, IFilesystemHelpers.cs, IFilesystemOperations.cs. — One of this dimension's main actionable groups (64 recommendation-level).
Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 1 Boundary-crossing change coupling finding(s) in Change Coupling — start with SystemTrayIcon.cs. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 14 Change coupling finding(s) in Change Coupling — start with SidebarViewModel.cs (2), CloudDrivesManager.cs (2), IContentPageContext.cs (2). — One of this dimension's main actionable groups (14 warning-level).
Resolve the 5 Change-coupling hub finding(s) in Change Coupling — start with CommandManager.cs, SidebarLibraryItem.cs, ShortcutPreviewViewModel.cs. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 9 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`AppModel` is a singleton (one shared instance) but mutates instance state outside any lock (_TabStripSelectedIndex, _IsAppElevated, _IsPasteEnabled, _GoogleDrivePath, _PCloudDrivePath, _AppWindowDPI; e.g. `_TabStripSelectedIndex` at line 43). — src/Files.App/Data/Models/AppModel.cs:13
`StorageHistoryWrapper` is a singleton (one shared instance) but mutates instance state outside any lock (index, histories; e.g. `index` at line 21). — src/Files.App/Utils/Storage/History/StorageHistoryWrapper.cs:6
`QuickAccessManager` is a singleton (one shared instance) but mutates instance state outside any lock (PinnedItemsWatcher; e.g. `PinnedItemsWatcher` at line 34). — src/Files.App/Utils/Global/QuickAccessManager.cs:8
`RecentFilesWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsEmptyRecentFilesTextVisible, _IsRecentFilesDisabledInWindows; e.g. `_IsEmptyRecentFilesTextVisible` at line 38). — src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs:16
`FileTagsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_isInitialized, _updateCTS; e.g. `_isInitialized` at line 52). — src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs:13
`NetworkLocationsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsNoNetworkLocations; e.g. `_IsNoNetworkLocations` at line 38). — src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:16
`QuickAccessWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_refreshVersion; e.g. `_refreshVersion` at line 84). — src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:21
`ToolbarCustomizationViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (SelectedToolbarContextId, isSessionActive, HasToolbarChanges, searchGeneration, isApplyingItems, toolbarItemsByContext; e.g. `SelectedToolbarContextId` at line 32). — src/Files.App/ViewModels/Settings/ToolbarCustomizationViewModel.cs:10
`AppearanceViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (selectedAppThemeResources, selectedThemeIndex, selectedBackdropMaterial, selectedImageStretchType, selectedImageVerticalAlignmentType, selectedImageHorizontalAlignmentType; e.g. `selectedAppThemeResources` at line 197). — src/Files.App/ViewModels/Settings/AppearanceViewModel.cs:12
`StatusCenterViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_AverageOperationProgressValue, _ShowProgressRing; e.g. `_AverageOperationProgressValue` at line 16). — src/Files.App/ViewModels/UserControls/StatusCenterViewModel.cs:6
`ShelfViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_watchers; e.g. `_watchers` at line 70). — src/Files.App/ViewModels/UserControls/ShelfViewModel.cs:14
`DrivesViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (drives, showUserConsentOnInit; e.g. `drives` at line 15). — src/Files.App/Data/Models/DrivesViewModel.cs:10
`SidebarViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (paneHolder, sidebarDisplayMode, currentPath, selectedSidebarItem, dispatcherQueue, rightClickedItem; e.g. `paneHolder` at line 37). — src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:25
`InfoPaneViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (isEnabled, selectedItem, selectedDriveItem, previewPaneState, _DirectoryItemCount, showCloudItemButton; e.g. `isEnabled` at line 37). — src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:17
`MainPageViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsSidebarPaneOpen, _IsSidebarPaneOpenToggleButtonVisible, selectedTabItem, shouldPreviewPaneBeActive, shouldPreviewPaneBeDisplayed, canShowPrompts; e.g. `_IsSidebarPaneOpen` at line 53). — src/Files.App/ViewModels/MainPageViewModel.cs:20
`LibGit2Service` is a singleton (one shared instance) but mutates instance state outside any lock (_isExecutingGitAction; e.g. `_isExecutingGitAction` at line 38). — src/Files.App/Services/Git/LibGit2Service.cs:10
`NetworkService` is a singleton (one shared instance) but mutates instance state outside any lock (_Computers, _Shortcuts; e.g. `_Computers` at line 32). — src/Files.App/Services/Storage/StorageNetworkService.cs:12
`UserSizeProvider` is a singleton (one shared instance) but mutates instance state outside any lock (provider; e.g. `provider` at line 52). — src/Files.App/Services/SizeProvider/UserSizeProvider.cs:8
`UserDateTimeFormatter` is a singleton (one shared instance) but mutates instance state outside any lock (formatter; e.g. `formatter` at line 36). — src/Files.App/Services/DateTimeFormatter/UserDateTimeFormatter.cs:6
`AddItemService` is a singleton (one shared instance) but mutates instance state outside any lock (_cached; e.g. `_cached` at line 13). — src/Files.App/Services/Windows/WindowsShellService.cs:7
`ShelfContext` is a singleton (one shared instance) but mutates instance state outside any lock (_SelectedItems; e.g. `_SelectedItems` at line 23). — src/Files.App/Data/Contexts/Shelf/ShelfContext.cs:7
`SidebarContext` is a singleton (one shared instance) but mutates instance state outside any lock (_RightClickedItem; e.g. `_RightClickedItem` at line 37). — src/Files.App/Data/Contexts/SideBar/SideBarContext.cs:7
`TagsContext` is a singleton (one shared instance) but mutates instance state outside any lock (_TaggedItems; e.g. `_TaggedItems` at line 21). — src/Files.App/Data/Contexts/Tags/TagsContext.cs:8
`MultitaskingContext` is a singleton (one shared instance) but mutates instance state outside any lock (control, isPopupOpen, selectedTabIndex, tabCount, currentTabIndex; e.g. `control` at line 66). — src/Files.App/Data/Contexts/Multitasking/MultitaskingContext.cs:11
`WindowContext` is a singleton (one shared instance) but mutates instance state outside any lock (isCompactOverlay, isFullScreen; e.g. `isCompactOverlay` at line 44). — src/Files.App/Data/Contexts/Window/WindowContext.cs:9
`HomePageContext` is a singleton (one shared instance) but mutates instance state outside any lock (selectedTaggedItems, rightClickedItem, itemContextFlyoutMenu; e.g. `selectedTaggedItems` at line 27). — src/Files.App/Data/Contexts/HomePage/HomePageContext.cs:9
`DisplayPageContext` is a singleton (one shared instance) but mutates instance state outside any lock (_LayoutType, _DisplayedLayoutType, _SortOption, _SortDirection, _GroupOption, _GroupDirection; e.g. `_LayoutType` at line 162). — src/Files.App/Data/Contexts/DisplayPage/DisplayPageContext.cs:6
`ContentPageContext` is a singleton (one shared instance) but mutates instance state outside any lock (filesystemViewModel, pageType, selectedItems; e.g. `filesystemViewModel` at line 99). — src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs:10
`MultiPanesContext` is a singleton (one shared instance) but mutates instance state outside any lock (_ShellPaneArrangement, _mainPanesPage, _ActivePane, _ActivePaneOrColumn; e.g. `_ShellPaneArrangement` at line 68). — src/Files.App/Data/Contexts/MultiPanes/MultiPanesContext.cs:7
`UserSettingsService` is a singleton (one shared instance) but mutates instance state outside any lock (_GeneralSettingsService, _FoldersSettingsService, _AppearanceSettingsService, _InfoPaneSettingsService, _LayoutSettingsService, _ApplicationSettingsService; e.g. `_GeneralSettingsService` at line 53). — src/Files.App/Services/Settings/UserSettingsService.cs:48
`SideloadUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_isUpdateAvailable, _isUpdating, _updateProgress, _areReleaseNotesAvailable; e.g. `_isUpdateAvailable` at line 44). — src/Files.App/Services/App/AppUpdateSideloadService.cs:17
`StoreUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_isUpdateAvailable, _isUpdating, _updateProgress, _areReleaseNotesAvailable, _storeContext, _updatePackages; e.g. `_isUpdateAvailable` at line 27). — src/Files.App/Services/App/AppUpdateStoreService.cs:16
`DummyUpdateService` is a singleton (one shared instance) but mutates instance state outside any lock (_areReleaseNotesAvailable; e.g. `_areReleaseNotesAvailable` at line 19). — src/Files.App/Services/App/AppUpdateNoneService.cs:5
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces Files.App ↔ Files.App.Actions ↔ Files.App.Data.Commands ↔ Files.App.Data.Contexts ↔ Files.App.Data.Contracts ↔ Files.App.Data.EventArguments ↔ Files.App.Data.Items ↔ Files.App.Data.Messages ↔ Files.App.Data.Models ↔ Files.App.Data.Parameters ↔ Files.App.Dialogs ↔ Files.App.Helpers ↔ Files.App.Helpers.ContextFlyouts ↔ Files.App.Services.DateTimeFormatter ↔ Files.App.Services.Git ↔ Files.App.UserControls ↔ Files.App.UserControls.Menus ↔ Files.App.UserControls.TabBar ↔ Files.App.Utils ↔ Files.App.Utils.Cloud ↔ Files.App.Utils.FileTags ↔ Files.App.Utils.Git ↔ Files.App.Utils.Library ↔ Files.App.Utils.Shell ↔ Files.App.Utils.StatusCenter ↔ Files.App.Utils.Storage ↔ Files.App.ViewModels ↔ Files.App.ViewModels.Dialogs ↔ Files.App.ViewModels.Dialogs.AddItemDialog ↔ Files.App.ViewModels.Dialogs.FileSystemDialog ↔ Files.App.ViewModels.Layouts ↔ Files.App.ViewModels.Properties ↔ Files.App.ViewModels.Settings ↔ Files.App.ViewModels.UserControls ↔ Files.App.Views ↔ Files.App.Views.Layouts ↔ Files.App.Views.Shells depend on each other. The lightest dependency in the cycle is Files.App → Files.App.Data.Items (Files.App.MainWindow → Files.App.Data.Items.WindowEx, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Files.App/MainWindow.xaml.cs:22
The namespaces Files.App.UserControls.FilePreviews ↔ Files.App.ViewModels.Previews depend on each other. The lightest dependency in the cycle is Files.App.ViewModels.Previews → Files.App.UserControls.FilePreviews (Files.App.ViewModels.Previews.TextPreviewViewModel → Files.App.UserControls.FilePreviews.TextPreview, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Files.App/ViewModels/UserControls/Previews/TextPreviewViewModel.cs:4
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IStorageProviderStatusUI` declares 19 members: `GetIids`, `GetRuntimeClassName`, `GetTrustLevel`, `GetProviderState`, `PutProviderState`, `GetProviderStateLabel`, `PutProviderStateLabel`, `GetProviderStateIcon`, `PutProviderStateIcon`, `GetSyncStatusCommand`, `PutSyncStatusCommand`, `GetQuotaUI`, `PutQuotaUI`, `GetMoreInfoUI`, `PutMoreInfoUI`, `GetProviderPrimaryCommand`, `PutProviderPrimaryCommand`, `GetProviderSecondaryCommands`, `PutProviderSecondaryCommands`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.Storage/Windows/Interop/IStorageProviderStatusUI.cs:12
`IRichCommand` declares 22 members: `Code`, `Label`, `ExtendedLabel`, `LabelWithHotKey`, `AutomationName`, `Description`, `Glyph`, `Icon`, `FontIcon`, `ThemedIconStyle`, `IsCustomHotKeys`, `HotKeyText`, `AccessKey`, `HotKeys`, `DefaultHotKeys`, `IsToggle`, `IsOn`, `IsExecutable`, `IsAccessibleGlobally`, `AutomationId`, `ExecuteAsync`, `ExecuteTapped`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Commands/IRichCommand.cs:15
`IContentPageContext` declares 18 members: `ShellPage`, `PageType`, `PageLayoutType`, `Folder`, `HasItem`, `HasSelection`, `CanRefresh`, `SelectedItem`, `SelectedItems`, `CanGoBack`, `CanGoForward`, `CanNavigateToParent`, `CanCreateItem`, `IsMultiPaneAvailable`, `IsMultiPaneActive`, `IsGitRepository`, `CanExecuteGitAction`, `SolutionFilePath`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs:6
`IAppearanceSettingsService` declares 25 members: `SidebarWidth`, `IsSidebarOpen`, `AppThemeMode`, `AppThemeBackgroundColor`, `AppThemeAddressBarBackgroundColor`, `AppThemeToolbarBackgroundColor`, `AppThemeSidebarBackgroundColor`, `AppThemeFileAreaBackgroundColor`, `AppThemeFileAreaSecondaryBackgroundColor`, `AppThemeInfoPaneBackgroundColor`, `AppThemeFontFamily`, `AppThemeBackdropMaterial`, `AppThemeBackgroundImageSource`, `AppThemeBackgroundImageFit`, `AppThemeBackgroundImageOpacity`, `AppThemeBackgroundImageVerticalAlignment`, `AppThemeBackgroundImageHorizontalAlignment`, `ShowToolbar`, `ShowStatusBar`, `StatusBarItemCountFormat`, `ShowTabActions`, `ShowShelfPaneToggleButton`, `StatusCenterVisibility`, `CustomToolbarItems`, `LastKnownToolbarDefaults`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IAppearanceSettingsService.cs:9
`ICompressArchiveModel` declares 16 members: `ArchivePath`, `Directory`, `FileName`, `Password`, `Sources`, `FileFormat`, `CompressionLevel`, `SplittingSize`, `DictionarySize`, `WordSize`, `CPUThreads`, `Progress`, `CancellationToken`, `IsCancelled`, `GetArchivePath`, `RunCreationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/ICompressArchiveModel.cs:9
`IFoldersSettingsService` declares 18 members: `ShowHiddenItems`, `ShowProtectedSystemFiles`, `AreAlternateStreamsVisible`, `ShowDotFiles`, `OpenFilesWithSingleClick`, `OpenFoldersWithSingleClick`, `OpenFoldersInColumnsViewWithSingleClick`, `OpenFoldersInNewTab`, `CalculateFolderSizes`, `ScrollToPreviousFolderWhenNavigatingUp`, `ShowFileExtensions`, `ShowThumbnails`, `DeleteConfirmationPolicy`, `SelectFilesOnHover`, `DoubleClickToGoUp`, `ShowFileExtensionWarning`, `ShowCheckboxesWhenSelectingItems`, `SizeUnitFormat`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IFoldersSettingsService.cs:6
`IGeneralSettingsService` declares 72 members: `OpenSpecificPageOnStartup`, `OpenSpecificPageOnStartupPath`, `ContinueLastSessionOnStartUp`, `OpenNewTabOnStartup`, `OpenTabInExistingInstance`, `TabsOnStartupList`, `LastSessionTabList`, `LastSessionSelectedTabIndex`, `LastCrashedTabList`, `PathHistoryList`, `PreviousSearchQueriesList`, `PreviousArchiveExtractionLocations`, `DateTimeFormat`, `AlwaysOpenDualPaneInNewTab`, `AlwaysSwitchToNewlyOpenedTab`, `ReverseTabScrollDirection`, `ShowQuickAccessWidget`, `ShowRecentFilesWidget`, `ShowDrivesWidget`, `ShowNetworkLocationsWidget`, `ShowFileTagsWidget`, `FoldersWidgetExpanded`, `RecentFilesWidgetExpanded`, `DrivesWidgetExpanded`, `NetworkLocationsWidgetExpanded`, `FileTagsWidgetExpanded`, `ShowPinnedSection`, `ShowLibrarySection`, `ShowDrivesSection`, `ShowCloudDrivesSection`, `ShowNetworkSection`, `ShowWslSection`, `ShowFileTagsSection`, `IsPinnedSectionExpanded`, `IsLibrarySectionExpanded`, `IsDriveSectionExpanded`, `IsCloudDriveSectionExpanded`, `IsNetworkSectionExpanded`, `IsWslSectionExpanded`, `IsFileTagsSectionExpanded`, and 32 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IGeneralSettingsService.cs:6
`ILayoutSettingsService` declares 44 members: `SyncFolderPreferencesAcrossDirectories`, `DefaultLayoutMode`, `DefaultSortOption`, `DefaultDirectorySortDirection`, `DefaultSortDirectoriesAlongsideFiles`, `DefaultSortFilesFirst`, `DefaultGroupOption`, `DefaultDirectoryGroupDirection`, `DefaultGroupByDateUnit`, `ShowDateColumn`, `ShowDateCreatedColumn`, `ShowTypeColumn`, `ShowSizeColumn`, `ShowGitStatusColumn`, `ShowGitLastCommitDateColumn`, `ShowGitLastCommitMessageColumn`, `ShowGitCommitAuthorColumn`, `ShowGitLastCommitShaColumn`, `ShowFileTagColumn`, `ShowDateDeletedColumn`, `ShowPathColumn`, `ShowOriginalPathColumn`, `ShowSyncStatusColumn`, `GitStatusColumnWidth`, `GitLastCommitDateColumnWidth`, `GitLastCommitMessageColumnWidth`, `GitCommitAuthorColumnWidth`, `GitLastCommitShaColumnWidth`, `TagColumnWidth`, `NameColumnWidth`, `DateModifiedColumnWidth`, `TypeColumnWidth`, `DateCreatedColumnWidth`, `SizeColumnWidth`, `DateDeletedColumnWidth`, `SyncStatusColumnWidth`, `PathColumnWidth`, `OriginalPathColumnWidth`, `AutoSizeColumnsInDetailsLayout`, `DetailsViewSize`, and 4 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/ILayoutSettingsService.cs:6
`IShellPage` declares 29 members: `ShellViewModel`, `InstanceViewModel`, `StorageHistoryHelpers`, `ForwardStack`, `BackwardStack`, `SlimContentPage`, `CurrentPageType`, `FilesystemHelpers`, `ToolbarViewModel`, `CanNavigateBackward`, `CanNavigateForward`, `IsCurrentPane`, `WhenIsCurrent`, `RefreshIfNoWatcherExistsAsync`, `Refresh_Click`, `Back_Click`, `Forward_Click`, `Up_Click`, `UpdatePathUIToWorkingDirectoryAsync`, `NavigateToPath`, `NavigateToPath`, `NavigateHome`, `NavigateToReleaseNotes`, `NavigateToSettings`, `NavigateWithArguments`, `RemoveLastPageFromBackStack`, `ResetNavigationStackLayoutMode`, `SubmitSearch`, `IsColumnView`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 29 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IShellPage.cs:8
`IShellPanesPage` declares 17 members: `IsLeftPaneActive`, `IsRightPaneActive`, `IsMultiPaneActive`, `IsMultiPaneAvailable`, `FilesystemHelpers`, `TabBarItemParameter`, `ShellPaneArrangement`, `ActivePane`, `ActivePaneOrColumn`, `OpenSecondaryPane`, `OpenInOtherPane`, `ArrangePanes`, `CloseActivePane`, `CloseOtherPane`, `FocusOtherPane`, `FocusActivePane`, `GetPanes`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IShellPanesPage.cs:9
`IVersionControlService` declares 24 members: `GetGitRepositoryPath`, `GetOriginRepositoryName`, `GetBranchNames`, `GetRepositoryHead`, `GetRepositoryHeadName`, `Checkout`, `CreateNewBranchAsync`, `DeleteBranchAsync`, `ValidateBranchNameForRepository`, `FetchOriginAsync`, `PullOriginAsync`, `PushToOriginAsync`, `RequireGitAuthenticationAsync`, `IsRepositoryEx`, `GetGitInformationForItem`, `RemoveSavedCredentials`, `GetSavedCredentials`, `InitializeRepositoryAsync`, `GetRepoInfo`, `IsValidRepoUrl`, `CloneRepoAsync`, `IsExecutingGitAction`, `IsExecutingGitActionChanged`, `GitFetchCompleted`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Contracts/IVersionControlService.cs:16
`IListedItem` declares 64 members: `AsGitItem`, `AsRecycleBinItem`, `ContainsFilesOrFolders`, `ContextualProperty`, `CustomIcon`, `CustomIconSource`, `FileDetails`, `FileExtension`, `FileFRN`, `FileImage`, `FileSize`, `FileSizeBytes`, `FileSizeDisplay`, `FileTags`, `FileTagsUI`, `FileVersion`, `FolderRelativeId`, `HasTags`, `IconOverlay`, `ImageDimensions`, `IsAlternateStream`, `IsArchive`, `IsDriveRoot`, `IsElevationRequired`, `IsExecutable`, `IsFolder`, `IsFtpItem`, `IsGitItem`, `IsHiddenItem`, `IsItemPinnedToStart`, `IsLibrary`, `IsLinkItem`, `IsPinned`, `IsRecycleBinItem`, `IsScriptFile`, `IsShortcut`, `ItemDateAccessed`, `ItemDateAccessedReal`, `ItemDateCreated`, `ItemDateCreatedReal`, and 24 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Data/Items/IListedItem.cs:11
`IFilesystemHelpers` declares 24 members under just 15 distinct name(s): `CreateAsync`, `DeleteItemsAsync`, `DeleteItemAsync`, `DeleteItemsAsync`, `DeleteItemAsync`, `RestoreItemFromTrashAsync`, `RestoreItemsFromTrashAsync`, `RestoreItemFromTrashAsync`, `RestoreItemsFromTrashAsync`, `PerformOperationTypeAsync`, `CopyItemsAsync`, `CopyItemAsync`, `CopyItemsAsync`, `CopyItemAsync`, `CopyItemsFromClipboard`, `RecycleItemsFromClipboard`, `CreateShortcutFromClipboard`, `MoveItemsAsync`, `MoveItemAsync`, `MoveItemsAsync`, `MoveItemAsync`, `MoveItemsFromClipboard`, `RenameAsync`, `RenameAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 24 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 24 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Files.App/Utils/Storage/Operations/IFilesystemHelpers.cs:9
`IFilesystemOperations` declares 20 members under just 11 distinct name(s): `CreateAsync`, `CreateShortcutItemsAsync`, `CopyAsync`, `CopyAsync`, `CopyItemsAsync`, `CopyItemsAsync`, `MoveAsync`, `MoveAsync`, `MoveItemsAsync`, `MoveItemsAsync`, `DeleteAsync`, `DeleteAsync`, `DeleteItemsAsync`, `DeleteItemsAsync`, `RenameAsync`, `RenameAsync`, `RestoreItemsFromTrashAsync`, `RestoreFromTrashAsync`, `RestoreItemsFromTrashAsync`, `RestoreFromTrashAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Files.App/Utils/Storage/Operations/IFilesystemOperations.cs:14
`IBaseStorageFolder` declares 27 members: `Properties`, `ToStorageFolderAsync`, `GetParentAsync`, `GetBasicPropertiesAsync`, `GetItemAsync`, `TryGetItemAsync`, `GetItemsAsync`, `GetFileAsync`, `GetFilesAsync`, `GetFilesAsync`, `GetFilesAsync`, `GetFolderAsync`, `GetFoldersAsync`, `GetFoldersAsync`, `GetFoldersAsync`, `CreateFileAsync`, `CreateFileAsync`, `CreateFolderAsync`, `CreateFolderAsync`, `MoveAsync`, `MoveAsync`, `GetThumbnailAsync`, `GetThumbnailAsync`, `GetThumbnailAsync`, `CreateItemQueryWithOptions`, `CreateFileQueryWithOptions`, `CreateFolderQueryWithOptions`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 27 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Files.App/Utils/Storage/StorageBaseItems/IBaseStorageFolder.cs:11
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C2 · Access Controls7.0 / 10Strong✓ Tool-verified
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Authorization IS enforced here (by imperative guard methods that throw on violation) — this is NOT a claim that the code is unprotected. What's missing is a NAMED rule set: the guards encode the access rules inline, so the rules can't be listed, reviewed or tested apart from the call sites that apply them. Recommendation, not a defect.
What to do
Name the access rules — give each one a named predicate/policy object your guards consult, so the rule set can be reviewed and unit-tested independently of the call sites that enforce it.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×14) — src/Files.Storage/Windows/WindowsFile.cs:17, src/Files.App.Controls/AdaptiveGridView/AdaptiveHeightValueConverter.cs:42, src/Files.App/Converters/EnumToBoolConverter.cs:18, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`AutoSuggestBox_KeyDown` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App.Controls/Omnibar/Omnibar.Events.cs:90
`ItemBorder_DragOver` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App.Controls/Sidebar/SidebarItem.cs:550
`ExecuteAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Actions/FileSystem/OpenItemAction.cs:134
`OnZipEncodingChangedAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Data/Models/DirectoryPropertiesViewModel.cs:329
`SwitchPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:20
`DoPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:25
`DetectAvailability` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. (×2) — src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:49, src/Files.App/Services/PreviewPopupProviders/SeerProProvider.cs:81
`IsEncodingUndeterminedAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Services/Storage/StorageArchiveService.cs:429
`DetectEncodingAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Services/Storage/StorageArchiveService.cs:449
`RenameAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:101, src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:106
`DeleteAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:111, src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:116
`AddPageAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/ViewModels/Settings/GeneralViewModel.cs:362
`LoadPreviewAndDetailsAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/ViewModels/UserControls/Previews/HtmlPreviewViewModel.cs:15
`SaveChangesAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Files.App/Views/Properties/HashesPage.xaml.cs:59
1 guard above `return false;` also returns `false`, so no input can make it matter. Implement the distinction that was intended, or delete the guard. — src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:295
`TryRenameVolumeLabel` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Storage.cs:88
`OpenStreamAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Files.Storage/Windows/WindowsFile.cs:17
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×20) — src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:84, src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:96, src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:120, …
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
833 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 9 of 9 project(s) that lack one — worth up to 2 pts.
Review the README against recent changes; refresh the parts that drifted.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
For more than a log file, an `ActivitySource`/`EventSource` the user can switch on gives you a structured trace to attach to a bug report. A health-check endpoint does not apply here: nothing orchestrates or load-balances a binary the user launches.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 46611 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
What to do
Add a SAST step to CI running what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Dependabot is configured but does not watch `github-actions` — add that `package-ecosystem` entry to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
No benchmark suite was found by the two searches this check runs. FIRST, a BenchmarkDotNet package reference in any project file — every project the workspace loaded, plus a walk of project files on disk that never loaded, because a benchmark suite is exactly the project a partial load drops. SECOND, a script harness: a file whose name contains `benchmark` and ends `.py`, `.sh`, `.ps1`, `.bash`, `.rb`, `.js` or `.mjs`, credited ONLY when this repository's CI text also mentions benchmarks — a harness no pipeline runs is read as a fixture, deliberately. Neither search can see a benchmark suite in another ecosystem's idiom (a Go `testing.B` file, a JMH or criterion project, a pytest-benchmark run), so this is 'no benchmark found by those two searches', not a verdict that the repository has none. Where code is performance-sensitive, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.
What to do
Add a benchmarking harness for the hot paths and run it in CI to catch regressions (for .NET, a BenchmarkDotNet project with [MemoryDiagnoser] to track allocations).
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 97 use(s) across 117,729 production line(s) (~0.8/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
9 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`Task.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/Files.Shared/Helpers/AsyncManualResetEvent.cs:46
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×6) — src/Files.Storage/Windows/Managers/STATask.cs:42, src/Files.Storage/Windows/Managers/STATask.cs:170, src/Files.Storage/Windows/Managers/STATask.cs:215, …
`completed.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/Files.Storage/Windows/Managers/STATask.cs:276
`.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — src/Files.App/Program.cs:228
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×7) — src/Files.Shared/Helpers/AsyncManualResetEvent.cs:46, src/Files.Storage/Windows/Managers/STATask.cs:42, src/Files.Storage/Windows/Managers/STATask.cs:170, …
`.Wait(…)` blocks this thread until the task completes or the bound expires — sync-over-async: it can deadlock under a synchronization context and it parks a thread while it waits. `await` the task (with `.WaitAsync(timeout, token)` where the bound matters). (×2) — src/Files.Shared/Utils/Logger/FileLogger.cs:151, src/Files.App/Helpers/Application/AppLifecycleHelper.cs:609
`async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. (×31) — src/Files.App.BackgroundTasks/UpdateTask.cs:16, src/Files.App.Controls/BladeView/BladeView.cs:110, src/Files.App.Controls/Omnibar/Omnibar.Events.cs:90, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`p` is a `Process`, which implements `IDisposable`, and it is created here (line 25). Every use of it in `TryGetFullPath` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var p = …;`), which releases it at the end of the scope on every path including a throw. — src/Files.Shared/Helpers/PathHelpers.cs:25
`folder` is a `IFolder`, which implements `IDisposable`, and it is created here (line 44). Every use of it in `GetQuickAccessFolderAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var folder = …;`), which releases it at the end of the scope on every path including a throw. — src/Files.Storage/Legacy/HomeFolder/HomeFolder.cs:44
`folder` is a `IFolder`, which implements `IDisposable`, and it is created here (line 87). Every use of it in `GetNetworkLocationsAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var folder = …;`), which releases it at the end of the scope on every path including a throw. — src/Files.Storage/Legacy/HomeFolder/HomeFolder.cs:87
`process` is a `Process`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `TrySetShortcutIconOnPowerShellAsElevatedAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var process = …;`), which releases it at the end of the scope on every path including a throw. — src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.PowerShell.cs:28
`Item` is never created by `WidgetFolderCardItem` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 76). Its declared type `IWindowsStorable` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Files.App/Data/Items/WidgetFolderCardItem.cs:76
`NavigationInteractionTracker` declares a finalizer (line 159), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Files.App/Helpers/Navigation/NavigationInteractionTracker.cs:159
`GeneralViewModel` declares a finalizer (line 616), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — src/Files.App/ViewModels/Settings/GeneralViewModel.cs:616
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 105/491 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×39) — src/Files.Shared/Extensions/EnumerableExtensions.cs:71, src/Files.Shared/Helpers/AsyncManualResetEvent.cs:24, src/Files.Shared/Utils/Logger/FileLogger.cs:66, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped4.3 / 10Weak✓ Tool-verified
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
`exampleValue` carries text this program read out of the document being converted, and it is written straight into the text of an element of generated markup with nothing escaping it on the way. The value is chosen by whoever authored the file, not by this program, so it can close the attribute it sits in and open another — a crafted document becomes markup in the output this renderer produces. Escape `exampleValue` at this site, or validate it against the shape the attribute accepts before interpolating it. — src/Files.Core.SourceGenerator/Generators/StringsPropertyGenerator.cs:110
What to do
Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard5.4 / 10Adequate✓ Tool-verified
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
This condition tests `parsedArgs` for emptiness and then indexes it on a branch that test does not reach. `parsedArgs[0]` is evaluated whenever the guarded half is false — which includes the case the guard exists to anticipate, `parsedArgs` being empty — so an empty `parsedArgs` indexes position 0 of nothing and throws. This same condition already shows the intended bracketing at line 153: `parsedArgs[2]` sits INSIDE the guard. Either the guard is load-bearing, in which case this access escapes it and crashes, or `parsedArgs` cannot be empty here, in which case the guard beside it is dead code — the condition is wrong under both readings. Move the parenthesis so the emptiness test brackets every access to `parsedArgs`. — src/Files.App/MainWindow.xaml.cs:152
What to do
Each finding names the index access that escapes the guard and the line of the correctly bracketed access beside it. Compare the two: they differ only in where one parenthesis sits. Move it so the emptiness test brackets every access to that symbol — and if the value provably cannot be empty at this point, delete the test rather than leave a condition that guards one access and not its neighbour.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×27) — src/Files.App.BackgroundTasks/UpdateTask.cs:23, src/Files.App.BackgroundTasks/UpdateTask.cs:26, src/Files.App.Controls/Sidebar/SidebarItem.cs:275, …
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×10) — src/Files.App/Data/Models/AppModel.cs:28, src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:40, src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:52, …
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×2) — src/Files.App/Data/Models/CompressArchiveModel.cs:286, src/Files.App/Services/Git/LibGit2Service.cs:126
`catch (LibGit2SharpException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — src/Files.App/Services/Git/LibGit2Service.cs:511
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×27) — src/Files.App/Actions/FileSystem/FlattenFolderAction.cs:133, src/Files.App/App.xaml.cs:200, src/Files.App/App.xaml.cs:222, …
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `flyoutItems`: line 133 writes `flyoutItems?.Add`, which says `flyoutItems` can be null, but line 113 then dereferences it directly as `flyoutItems.Clear` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `flyoutItems` truly cannot be null here, the `?.` is misleading. Settle it one way — test `flyoutItems` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Files.App/UserControls/NavigationToolbar.xaml.cs:113
This method contradicts itself about `args`: line 139 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 169 then dereferences `args` as `args.Length` AFTER the block has closed, where the guard no longer applies. A null `args` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `args` truly cannot be null by then, the guard above is misleading and should go. — src/Files.App/Utils/CommandLine/CommandLineParser.cs:169
This method contradicts itself about `input`: line 403 writes `input?.ToString`, which says `input` can be null, but line 402 then dereferences it directly as `input.GetType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `input` truly cannot be null here, the `?.` is misleading. Settle it one way — test `input` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Files.App/ViewModels/Properties/Items/FileProperty.cs:402
This method contradicts itself about `parentShellPage`: line 142 writes `parentShellPage?.SlimContentPage`, which says `parentShellPage` can be null, but line 145 then dereferences it directly as `parentShellPage.GetRequiredShellViewModel` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `parentShellPage` truly cannot be null here, the `?.` is misleading. Settle it one way — test `parentShellPage` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:145
This method contradicts itself about `parentShellPage`: line 162 writes `parentShellPage?.SlimContentPage`, which says `parentShellPage` can be null, but line 165 then dereferences it directly as `parentShellPage.GetRequiredShellViewModel` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `parentShellPage` truly cannot be null here, the `?.` is misleading. Settle it one way — test `parentShellPage` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:165
This method contradicts itself about `navArgs`: line 85 writes `navArgs?.SelectItems`, which says `navArgs` can be null, but line 42 then dereferences it directly as `navArgs.AssociatedTabInstance` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `navArgs` truly cannot be null here, the `?.` is misleading. Settle it one way — test `navArgs` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Files.App/Views/Settings/SettingsPage.xaml.cs:42
6/7 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~0.8 `!` suppressions per 1k syntax nodes — 66 suppression(s) across the 79720 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Where a method null-tests a symbol and then uses it after the guarded block closes, move the trailing work inside the block — the guard skips its body on null, it does not stop the method.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 3 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 38 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 40 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D11 Test Reliability — Test reliability not measured — no test run produced results
D12 Dependency Hygiene — Dependency hygiene not measured — pkgs.dev.azure.com could not be reached
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 22 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: this repository runs its tests on Microsoft.Testing.Platform (its global.json opts in), where coverage comes from a coverage extension the test project references — and none is wired up: no build file names `Microsoft.Testing.Extensions.CodeCoverage` or `coverlet.MTP`. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment. Add one of those PackageReferences to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 value object(s))
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock src/Files.App.BackgroundTasks/UpdateTask.cs:23— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App.BackgroundTasks/UpdateTask.cs:26— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App.Controls/Sidebar/SidebarItem.cs:275— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:72— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Actions/Open/OpenTerminalAction.cs:69— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Actions/Open/OpenTerminalAction.cs:137— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/App.xaml.cs:120— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Converters/DoubleArrayToStringConverter.cs:40— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Converters/GenericEnumConverter.cs:45— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Converters/GenericEnumConverter.cs:51— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Data/Items/DriveItem.cs:308— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Data/Items/WindowEx.cs:323— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Data/Items/WindowEx.cs:369— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Data/Models/AppModel.cs:51— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Extensions/DispatcherQueueExtensions.cs:21— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Extensions/DispatcherQueueExtensions.cs:61— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Application/AppLifecycleHelper.cs:617— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Dialog/DialogDisplayHelper.cs:56— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Navigation/NavigationHelpers.cs:214— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/PathNormalization.cs:25— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Shell.cs:76— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:1017— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:1033— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Services/App/AppUpdateSideloadService.cs:154— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Files.App/Services/App/AppUpdateSideloadService.cs:163— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
FileScopedPragmaDisable src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:957— #pragma warning disable CS8625 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable src/Files.Core.SourceGenerator/Utilities/HashCode.cs:9— #pragma warning disable CS0809 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable src/Files.Core.SourceGenerator/Utilities/HashCode.cs:10— #pragma warning disable CA1066 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
Namespace dependency cycle src/Files.App/MainWindow.xaml.cs:22— The namespaces Files.App ↔ Files.App.Actions ↔ Files.App.Data.Commands ↔ Files.App.Data.Contexts ↔ Files.App.Data.Contracts ↔ Files.App.Data.EventArguments ↔ Files.App.Data.Items ↔ Files.App.Data.Messages ↔ Files.App.Data.Models ↔ Files.App.Data.Parameters ↔ Files.App.Dialogs ↔ Files.App.Helpers ↔ Files.App.Helpers.ContextFlyouts ↔ Files.App.Services.DateTimeFormatter ↔ Files.App.Services.Git ↔ Files.App.UserControls ↔ Files.App.UserControls.Menus ↔ Files.App.UserControls.TabBar ↔ Files.App.Utils ↔ Files.App.Utils.Cloud ↔ Files.App.Utils.FileTags ↔ Files.App.Utils.Git ↔ Files.App.Utils.Library ↔ Files.App.Utils.Shell ↔ Files.App.Utils.StatusCenter ↔ Files.App.Utils.Storage ↔ Files.App.ViewModels ↔ Files.App.ViewModels.Dialogs ↔ Files.App.ViewModels.Dialogs.AddItemDialog ↔ Files.App.ViewModels.Dialogs.FileSystemDialog ↔ Files.App.ViewModels.Layouts ↔ Files.App.ViewModels.Properties ↔ Files.App.ViewModels.Settings ↔ Files.App.ViewModels.UserControls ↔ Files.App.Views ↔ Files.App.Views.Layouts ↔ Files.App.Views.Shells depend on each other. The lightest dependency in the cycle is Files.App → Files.App.Data.Items (Files.App.MainWindow → Files.App.Data.Items.WindowEx, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/Files.App/ViewModels/UserControls/Previews/TextPreviewViewModel.cs:4— The namespaces Files.App.UserControls.FilePreviews ↔ Files.App.ViewModels.Previews depend on each other. The lightest dependency in the cycle is Files.App.ViewModels.Previews → Files.App.UserControls.FilePreviews (Files.App.ViewModels.Previews.TextPreviewViewModel → Files.App.UserControls.FilePreviews.TextPreview, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
WriteOnlyPrivateField src/Files.App/Actions/Global/EditPathAction.cs:10— private IGeneralSettingsService GeneralSettingsService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Files.App/Data/Behaviors/StickyHeaderBehavior.cs:24— private bool IsXamlRootAvailable — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Assertions commented out: VerifySettingsAreAccessible tests/Files.InteractionTests/Tests/SettingsTests.cs:16— The test body contains commented-out assertion calls and no live one — it runs, verifies nothing, and still passes. Restore the assertions or delete the test; a green test that checks nothing is worse than an absent one.
NoWarnInCsproj src/Files.App/Files.App.csproj:24— CS8305 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
Boundary-crossing change coupling: SystemTrayIcon.cs ↔ AppLifecycleHelper.cs src/Files.App.Server/Tray/SystemTrayIcon.cs:1— `src/Files.App.Server/Tray/SystemTrayIcon.cs` (context Files.App.Server) and `src/Files.App/Helpers/Application/AppLifecycleHelper.cs` (context Files.App) sit in DIFFERENT parts of the tree yet change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `9566baef` Code Quality: Fix crashes from v4.2.20 (#18895) (at that commit the file was still `src/Files.App/Utils/Taskbar/SystemTrayIcon.cs`); `07268dc1` Code Quality: Added Store Preview configuration (#16566) (at that commit the file was still `src/Files.App/Utils/Taskbar/SystemTrayIcon.cs`); `6dbe8874` Code Quality: Assigned execution alias and URI for each build (#16182) (at that commit the file was still `src/Files.App/Utils/Taskbar/SystemTrayIcon.cs`) — run `git show` on any of them.
TodoComment src/Files.App/Actions/FileSystem/EmptyRecycleBinAction.cs:43— // TODO: Use AppDialogService — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Actions/FileSystem/RestoreAllRecycleBinAction.cs:32— // TODO: Use AppDialogService — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Actions/Show/ToggleShelfPaneAction.cs:23— // TODO Remove IsAccessibleGlobally when shelf feature is ready — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Actions/Show/ToggleShelfPaneAction.cs:27— // TODO Remove IsExecutable when shelf feature is ready — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/App.xaml.cs:43— // TODO: Replace with DI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/App.xaml.cs:188— // TODO: Replace with DI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Contracts/IShellPanesPage.cs:19— // TODO: Remove this our of this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Contracts/IShellPanesPage.cs:22— // TODO: Remove this our of this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Contracts/IStartMenuService.cs:8— // TODO(s) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:393— // TODO add back text and icon when https://github.com/microsoft/microsoft-ui-xaml/issues/9409 is resolved
TodoComment src/Files.App/Data/Items/ListedItem.cs:85— // TODO: eventually we should remove this b/c it's not thread safe — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Models/AppModel.cs:20— // TODO: Refactor this method — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Data/Models/CurrentInstanceViewModel.cs:9— // TODO: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Extensions/MessageFormatExtensions.cs:123— //TODO: Could replace `GetLocalizedResource()` in the future — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Helpers/UI/UIFilesystemHelpers.cs:15— // TODO: Remove this class — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Helpers/UI/UIFilesystemHelpers.cs:110— // TODO: handle libraries with multiple folders — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Helpers/Win32/Win32Helper.Process.cs:32— // TODO In the long run, we should consider modifying HandleApplicationLaunch to handle this correctly. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Services/App/AppUpdateStoreService.cs:202— //TODO: Use IDialogService in future. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Services/Git/LibGit2Service.cs:34— // TODO: Make set method private again when move finished — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Services/Git/LibGit2Service.cs:570— // TODO: This is a temp fix to avoid an issue where Files would create many branches in a loop — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Utils/Git/GitHelpers.cs:684— // TODO: This is a temp fix to avoid an issue where Files would create many branches in a loop — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Services/Storage/StorageArchiveService.cs:203— // TODO: Get this method return result — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Services/Storage/StorageTrashBinService.cs:114— // TODO: Use IFileOperation instead of its wrapper for the operation status to be reported. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Files.App/Utils/Git/GitHelpers.cs:20— // TODO: Replace with IVersionControl abstraction when it is complete
TodoComment src/Files.App/Utils/Serialization/Implementation/DefaultJsonSettingsDatabase.cs:48— // TODO Display prompt to notify user #710
Hotspot: src/Files.App/ViewModels/ShellViewModel.cs src/Files.App/ViewModels/ShellViewModel.cs:1672— src/Files.App/ViewModels/ShellViewModel.cs changed 36 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 51 in ShellViewModel.LoadExtendedItemPropertiesAsync at line 1672. 13 of those changes were fix/bug commits, and the other 23 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/ViewModels/ShellViewModel.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/MainWindow.xaml.cs src/Files.App/MainWindow.xaml.cs:95— src/Files.App/MainWindow.xaml.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 44 in MainWindow.InitializeApplicationAsync at line 95. 4 of those changes were fix/bug commits, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/MainWindow.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:598— src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in NavigationToolbarViewModel.HandleItemNavigationAsync at line 598. 5 of those changes were fix/bug commits, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Utils/Storage/Search/FolderSearch.cs src/Files.App/Utils/Storage/Search/FolderSearch.cs:550— src/Files.App/Utils/Storage/Search/FolderSearch.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in FolderSearch.SearchWithWin32 at line 550. 2 of those changes were fix/bug commits, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Search/FolderSearch.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Views/Layouts/BaseLayoutPage.cs src/Files.App/Views/Layouts/BaseLayoutPage.cs:1096— src/Files.App/Views/Layouts/BaseLayoutPage.cs changed 14 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in BaseLayoutPage.Item_DragOver at line 1096. 4 of those changes were fix/bug commits, and the other 10 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Views/Layouts/BaseLayoutPage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Helpers/Application/AppLifecycleHelper.cs src/Files.App/Helpers/Application/AppLifecycleHelper.cs:214— src/Files.App/Helpers/Application/AppLifecycleHelper.cs changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in AppLifecycleHelper.ConfigureSentry at line 214. 4 of those changes were fix/bug commits, and the other 12 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Helpers/Application/AppLifecycleHelper.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:590— src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in GridLayoutPage.FileList_PreviewKeyDown at line 590. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Helpers/Win32/Win32Helper.Storage.cs src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:156— src/Files.App/Helpers/Win32/Win32Helper.Storage.cs changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in Win32Helper.GetIcon at line 156. 3 of those changes were fix/bug commits, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Helpers/Win32/Win32Helper.Storage.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:21— src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in Win32StorageEnumerator.ListEntries at line 21. 2 of those changes were fix/bug commits, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Program.cs src/Files.App/Program.cs:48— src/Files.App/Program.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in Program.Main at line 48. 3 of those changes were fix/bug commits, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Program.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs:15— src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 37 in PropertiesNavigationItemsFactory.Initialize at line 15. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/UserControls/NavigationToolbar.xaml.cs src/Files.App/UserControls/NavigationToolbar.xaml.cs:181— src/Files.App/UserControls/NavigationToolbar.xaml.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in NavigationToolbar.Omnibar_QuerySubmitted at line 181. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/UserControls/NavigationToolbar.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Helpers/Navigation/NavigationHelpers.cs src/Files.App/Helpers/Navigation/NavigationHelpers.cs:668— src/Files.App/Helpers/Navigation/NavigationHelpers.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in NavigationHelpers.OpenFile at line 668. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Helpers/Navigation/NavigationHelpers.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:652— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in DetailsLayoutPage.FileList_ItemTapped at line 652. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Services/Git/LibGit2Service.cs src/Files.App/Services/Git/LibGit2Service.cs:193— src/Files.App/Services/Git/LibGit2Service.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in LibGit2Service.Checkout at line 193. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Services/Git/LibGit2Service.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: REDACTED REDACTED:56— REDACTED changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in LaunchHelper.HandleApplicationLaunch at line 56. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:588— src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 23 in ColumnLayoutPage.FileList_ItemTapped at line 588. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/UserControls/Toolbar.xaml.cs src/Files.App/UserControls/Toolbar.xaml.cs:193— src/Files.App/UserControls/Toolbar.xaml.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in Toolbar.CreateToolbarElement at line 193. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/UserControls/Toolbar.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/ViewModels/UserControls/SidebarViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1223— src/Files.App/ViewModels/UserControls/SidebarViewModel.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in SidebarViewModel.HandleLocationItemDragOverAsync at line 1223. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/ViewModels/UserControls/SidebarViewModel.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs:19— src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 31 in UniversalStorageEnumerator.ListEntries at line 19. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Data/Items/WindowEx.cs src/Files.App/Data/Items/WindowEx.cs:170— src/Files.App/Data/Items/WindowEx.cs changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in WindowEx.RestoreWindowPlacementData at line 170. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Data/Items/WindowEx.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Views/Properties/GeneralPage.xaml.cs src/Files.App/Views/Properties/GeneralPage.xaml.cs:91— src/Files.App/Views/Properties/GeneralPage.xaml.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in GeneralPage.SaveChangesAsync at line 91. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Views/Properties/GeneralPage.xaml.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:972— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 19 in FileOperationsHelpers.UpdateFileTagsDb at line 972. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs:105— src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in BaseLayoutViewModel.DragOverAsync at line 105. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:788— src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in FilesystemHelpers.GetDraggedStorageItems at line 788. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
+ 17 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×39
Async method without CancellationToken: ToListAsync src/Files.Shared/Extensions/EnumerableExtensions.cs:71— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Delay src/Files.Shared/Helpers/AsyncManualResetEvent.cs:24— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ProcessLogQueueAsync src/Files.Shared/Utils/Logger/FileLogger.cs:66— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetThumbnailAsync src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Icon.cs:26— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: TrySetShortcutIconOnPowerShellAsElevatedAsync src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.PowerShell.cs:8— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RunPooled src/Files.Storage/Windows/Managers/STATask.cs:29— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RunAsync src/Files.App.BackgroundTasks/UpdateTask.cs:18— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: BladeOnVisibilityChanged src/Files.App.Controls/BladeView/BladeView.cs:110— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetProviders src/Files.App.Server/Cloud/BoxCloudDetector.cs:14— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DetectCloudDrives src/Files.App.Server/Cloud/CloudDrivesDetector.cs:15— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetProviders src/Files.App.Server/Cloud/GenericCloudDetector.cs:11— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetProviders src/Files.App.Server/Cloud/GoogleDriveCloudDetector.cs:24— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetGoogleDriveIconFileAsync src/Files.App.Server/Cloud/GoogleDriveCloudDetector.cs:208— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetProviders src/Files.App.Server/Cloud/OXDriveCloudDetector.cs:15— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetAsync src/Files.App.Server/Initialization/CachedTask.cs:13— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetNewContextMenuEntries src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:17— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetNewContextMenuEntryForType src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:41— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: GetShellNewRegistryEntries src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:51— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ParseShellNewRegistryEntry src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:80— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CreateShellNewEntry src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:114— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ShutdownAsync src/Files.App.Server/ServerHost.cs:201— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExecuteAsync src/Files.App/Actions/Content/Archives/Compress/CompressIntoArchiveAction.cs:23— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DecompressArchiveHereAsync src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:53— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExecuteAsync src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs:35— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExecuteAsync src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveToChildFolderAction.cs:28— No CancellationToken parameter — this work can't be stopped early once started.
TooManyMethods: SidebarViewModel src/Files.App/ViewModels/UserControls/SidebarViewModel.cs— TooManyMethods — 1325 significant lines (blank, comment-only and punctuation-only lines excluded), 93 methods, declared across 3 files: UserControls/SidebarViewModel.cs (47), UserControls/SidebarViewModel.FlatTree.cs (26), UserControls/SidebarViewModel.TabExpansion.cs (20). The bar is 30 methods; this is 63 over it, 3.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ShellViewModel src/Files.App/ViewModels/ShellViewModel.cs— TooManyMethods — 2003 significant lines (blank, comment-only and punctuation-only lines excluded), 91 methods. The bar is 30 methods; this is 61 over it, 3.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DetailsLayoutPage src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs— TooManyMethods — 750 significant lines (blank, comment-only and punctuation-only lines excluded), 75 methods. The bar is 30 methods; this is 45 over it, 2.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseLayoutPage src/Files.App/Views/Layouts/BaseLayoutPage.cs— TooManyMethods — 958 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. The bar is 30 methods; this is 42 over it, 2.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ZipStorageFolder src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs— TooManyMethods — 488 significant lines (blank, comment-only and punctuation-only lines excluded), 71 methods. The bar is 30 methods; this is 41 over it, 2.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseStorageFolder src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFolder.cs— TooManyMethods — 146 significant lines (blank, comment-only and punctuation-only lines excluded), 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Win32Helper src/Files.App/Helpers/Win32/Win32Helper.Storage.cs— TooManyMethods — 757 significant lines (blank, comment-only and punctuation-only lines excluded), 62 methods, declared across 4 files: Win32/Win32Helper.Storage.cs (54), Win32/Win32Helper.Process.cs (3), Win32/Win32Helper.WindowManagement.cs (3), Win32/Win32Helper.Shell.cs (2). The bar is 30 methods; this is 32 over it, 2.07× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: Toolbar src/Files.App.Controls/Toolbar/Toolbar.cs— TooManyMethods — 321 significant lines (blank, comment-only and punctuation-only lines excluded), 55 methods, declared across 2 files: Toolbar/Toolbar.cs (50), Toolbar/Toolbar.Properties.cs (5). The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseShellPage src/Files.App/Views/Shells/BaseShellPage.cs— TooManyMethods — 548 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: FtpStorageFolder src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs— TooManyMethods — 230 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ShellStorageFolder src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs— TooManyMethods — 146 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ZipStorageFile src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs— TooManyMethods — 455 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MainPage src/Files.App/Views/MainPage.xaml.cs— TooManyMethods — 345 significant lines (blank, comment-only and punctuation-only lines excluded), 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: VirtualStorageFolder src/Files.App/Utils/Storage/StorageItems/VirtualStorageFolder.cs— TooManyMethods — 81 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ColumnLayoutPage src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs— TooManyMethods — 377 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SidebarItem src/Files.App.Controls/Sidebar/SidebarItem.cs— TooManyMethods — 464 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods, declared across 2 files: Sidebar/SidebarItem.cs (38), Sidebar/SidebarItem.Properties.cs (3). The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GridLayoutPage src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs— TooManyMethods — 525 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ShellPanesPage src/Files.App/Views/ShellPanesPage.xaml.cs— TooManyMethods — 583 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseStorageFile src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFile.cs— TooManyMethods — 112 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: NavigationToolbarViewModel src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs— TooManyMethods — 829 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GridSplitter src/Files.App.Controls/GridSplitter/GridSplitter.Helper.cs— TooManyMethods — 463 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods, declared across 4 files: GridSplitter/GridSplitter.Helper.cs (14), GridSplitter/GridSplitter.Events.cs (9), GridSplitter/GridSplitter.cs (8), GridSplitter/GridSplitter.Options.cs (5). The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseGroupableLayoutPage src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs— TooManyMethods — 287 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ToolbarItem src/Files.App.Controls/Toolbar/ToolbarItem/ToolbarItem.cs— TooManyMethods — 186 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods, declared across 2 files: ToolbarItem/ToolbarItem.cs (24), ToolbarItem/ToolbarItem.Properties.cs (12). The bar is 30 methods; this is 6 over it, 1.20× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: FilesystemHelpers src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs— TooManyMethods — 511 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BulkConcurrentObservableCollection src/Files.App/Utils/Storage/Collection/BulkConcurrentObservableCollection.cs— TooManyMethods — 294 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Stateful singleton: AppModel src/Files.App/Data/Models/AppModel.cs:13— `AppModel` is a singleton (one shared instance) but mutates instance state outside any lock (_TabStripSelectedIndex, _IsAppElevated, _IsPasteEnabled, _GoogleDrivePath, _PCloudDrivePath, _AppWindowDPI; e.g. `_TabStripSelectedIndex` at line 43).
Stateful singleton: StorageHistoryWrapper src/Files.App/Utils/Storage/History/StorageHistoryWrapper.cs:6— `StorageHistoryWrapper` is a singleton (one shared instance) but mutates instance state outside any lock (index, histories; e.g. `index` at line 21).
Stateful singleton: QuickAccessManager src/Files.App/Utils/Global/QuickAccessManager.cs:8— `QuickAccessManager` is a singleton (one shared instance) but mutates instance state outside any lock (PinnedItemsWatcher; e.g. `PinnedItemsWatcher` at line 34).
Stateful singleton: RecentFilesWidgetViewModel src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs:16— `RecentFilesWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsEmptyRecentFilesTextVisible, _IsRecentFilesDisabledInWindows; e.g. `_IsEmptyRecentFilesTextVisible` at line 38).
Stateful singleton: FileTagsWidgetViewModel src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs:13— `FileTagsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_isInitialized, _updateCTS; e.g. `_isInitialized` at line 52).
Stateful singleton: NetworkLocationsWidgetViewModel src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:16— `NetworkLocationsWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsNoNetworkLocations; e.g. `_IsNoNetworkLocations` at line 38).
Stateful singleton: QuickAccessWidgetViewModel src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:21— `QuickAccessWidgetViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_refreshVersion; e.g. `_refreshVersion` at line 84).
Stateful singleton: ToolbarCustomizationViewModel src/Files.App/ViewModels/Settings/ToolbarCustomizationViewModel.cs:10— `ToolbarCustomizationViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (SelectedToolbarContextId, isSessionActive, HasToolbarChanges, searchGeneration, isApplyingItems, toolbarItemsByContext; e.g. `SelectedToolbarContextId` at line 32).
Stateful singleton: AppearanceViewModel src/Files.App/ViewModels/Settings/AppearanceViewModel.cs:12— `AppearanceViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (selectedAppThemeResources, selectedThemeIndex, selectedBackdropMaterial, selectedImageStretchType, selectedImageVerticalAlignmentType, selectedImageHorizontalAlignmentType; e.g. `selectedAppThemeResources` at line 197).
Stateful singleton: StatusCenterViewModel src/Files.App/ViewModels/UserControls/StatusCenterViewModel.cs:6— `StatusCenterViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_AverageOperationProgressValue, _ShowProgressRing; e.g. `_AverageOperationProgressValue` at line 16).
Stateful singleton: ShelfViewModel src/Files.App/ViewModels/UserControls/ShelfViewModel.cs:14— `ShelfViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_watchers; e.g. `_watchers` at line 70).
Stateful singleton: DrivesViewModel src/Files.App/Data/Models/DrivesViewModel.cs:10— `DrivesViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (drives, showUserConsentOnInit; e.g. `drives` at line 15).
Stateful singleton: SidebarViewModel src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:25— `SidebarViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (paneHolder, sidebarDisplayMode, currentPath, selectedSidebarItem, dispatcherQueue, rightClickedItem; e.g. `paneHolder` at line 37).
Stateful singleton: InfoPaneViewModel src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:17— `InfoPaneViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (isEnabled, selectedItem, selectedDriveItem, previewPaneState, _DirectoryItemCount, showCloudItemButton; e.g. `isEnabled` at line 37).
Stateful singleton: MainPageViewModel src/Files.App/ViewModels/MainPageViewModel.cs:20— `MainPageViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_IsSidebarPaneOpen, _IsSidebarPaneOpenToggleButtonVisible, selectedTabItem, shouldPreviewPaneBeActive, shouldPreviewPaneBeDisplayed, canShowPrompts; e.g. `_IsSidebarPaneOpen` at line 53).
Stateful singleton: LibGit2Service src/Files.App/Services/Git/LibGit2Service.cs:10— `LibGit2Service` is a singleton (one shared instance) but mutates instance state outside any lock (_isExecutingGitAction; e.g. `_isExecutingGitAction` at line 38).
Stateful singleton: NetworkService src/Files.App/Services/Storage/StorageNetworkService.cs:12— `NetworkService` is a singleton (one shared instance) but mutates instance state outside any lock (_Computers, _Shortcuts; e.g. `_Computers` at line 32).
Stateful singleton: UserSizeProvider src/Files.App/Services/SizeProvider/UserSizeProvider.cs:8— `UserSizeProvider` is a singleton (one shared instance) but mutates instance state outside any lock (provider; e.g. `provider` at line 52).
Stateful singleton: UserDateTimeFormatter src/Files.App/Services/DateTimeFormatter/UserDateTimeFormatter.cs:6— `UserDateTimeFormatter` is a singleton (one shared instance) but mutates instance state outside any lock (formatter; e.g. `formatter` at line 36).
Stateful singleton: AddItemService src/Files.App/Services/Windows/WindowsShellService.cs:7— `AddItemService` is a singleton (one shared instance) but mutates instance state outside any lock (_cached; e.g. `_cached` at line 13).
Stateful singleton: ShelfContext src/Files.App/Data/Contexts/Shelf/ShelfContext.cs:7— `ShelfContext` is a singleton (one shared instance) but mutates instance state outside any lock (_SelectedItems; e.g. `_SelectedItems` at line 23).
Stateful singleton: SidebarContext src/Files.App/Data/Contexts/SideBar/SideBarContext.cs:7— `SidebarContext` is a singleton (one shared instance) but mutates instance state outside any lock (_RightClickedItem; e.g. `_RightClickedItem` at line 37).
Stateful singleton: TagsContext src/Files.App/Data/Contexts/Tags/TagsContext.cs:8— `TagsContext` is a singleton (one shared instance) but mutates instance state outside any lock (_TaggedItems; e.g. `_TaggedItems` at line 21).
Stateful singleton: MultitaskingContext src/Files.App/Data/Contexts/Multitasking/MultitaskingContext.cs:11— `MultitaskingContext` is a singleton (one shared instance) but mutates instance state outside any lock (control, isPopupOpen, selectedTabIndex, tabCount, currentTabIndex; e.g. `control` at line 66).
Stateful singleton: WindowContext src/Files.App/Data/Contexts/Window/WindowContext.cs:9— `WindowContext` is a singleton (one shared instance) but mutates instance state outside any lock (isCompactOverlay, isFullScreen; e.g. `isCompactOverlay` at line 44).
async void method: Run src/Files.App.BackgroundTasks/UpdateTask.cs:16— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: BladeOnVisibilityChanged src/Files.App.Controls/BladeView/BladeView.cs:110— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: AutoSuggestBox_KeyDown src/Files.App.Controls/Omnibar/Omnibar.Events.cs:90— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ItemBorder_DragOver src/Files.App.Controls/Sidebar/SidebarItem.cs:550— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ShowErrorDialog src/Files.App/Actions/Content/Background/BaseSetAsAction.cs:41— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Context_PropertyChanged src/Files.App/Actions/Content/PreviewPopup/LaunchPreviewPopupAction.cs:62— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Window_Closed src/Files.App/App.xaml.cs:248— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Execute src/Files.App/Data/Commands/ActionCommand.cs:158— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ExecuteTapped src/Files.App/Data/Commands/ActionCommand.cs:176— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Execute src/Files.App/Data/Commands/ModifiableCommand.cs:114— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ExecuteTapped src/Files.App/Data/Commands/ModifiableCommand.cs:130— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: RefreshSpaceUsed src/Files.App/Data/Items/LocationItem.cs:285— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Watcher_EnumerationCompleted src/Files.App/Data/Models/DrivesViewModel.cs:47— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Watcher_DeviceModified src/Files.App/Data/Models/DrivesViewModel.cs:53— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: LoadAsync src/Files.App/Data/Models/PinnedFoldersManager.cs:265— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: AddItemDialog_Loaded src/Files.App/Dialogs/AddItemDialog.xaml.cs:46— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ContentDialog_PrimaryButtonClick src/Files.App/Dialogs/CredentialDialog.xaml.cs:42— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: MoveItemAsync src/Files.App/Dialogs/ReorderSidebarItemsDialog.xaml.cs:32— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnSourceBytesChangedAsync src/Files.App/Extensions/ImageFromBytes.cs:29— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Control_ContentChanged src/Files.App/Helpers/Navigation/NavigationHelpers.cs:375— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnActivated src/Files.App/Program.cs:192— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: UISettings_ColorValuesChanged src/Files.App/Services/App/AppThemeModeService.cs:127— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: FolderPreferences_PropertyChanged src/Files.App/Services/SizeProvider/UserSizeProvider.cs:46— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: UpdateQuickAccessWidget_Invoked src/Files.App/Services/Windows/WindowsJumpListService.cs:206— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: WebViewControl_Loaded REDACTED:19— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
Swallowed exception (empty catch) src/Files.App.BackgroundTasks/UpdateTask.cs:23— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App.BackgroundTasks/UpdateTask.cs:26— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App.Controls/Sidebar/SidebarItem.cs:275— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App.Server/Initialization/ShellNewMenuHelper.cs:72— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Actions/Open/OpenTerminalAction.cs:69— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Actions/Open/OpenTerminalAction.cs:137— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/App.xaml.cs:120— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Converters/DoubleArrayToStringConverter.cs:40— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Converters/GenericEnumConverter.cs:45— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Converters/GenericEnumConverter.cs:51— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Data/Items/DriveItem.cs:308— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Data/Items/WindowEx.cs:323— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Data/Items/WindowEx.cs:369— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Data/Models/AppModel.cs:51— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Extensions/DispatcherQueueExtensions.cs:21— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Extensions/DispatcherQueueExtensions.cs:61— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Application/AppLifecycleHelper.cs:617— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Dialog/DialogDisplayHelper.cs:56— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:214— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/PathNormalization.cs:25— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Win32/Win32Helper.Shell.cs:76— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:1017— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:1033— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Services/App/AppUpdateSideloadService.cs:154— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Files.App/Services/App/AppUpdateSideloadService.cs:163— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:543— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:543-550 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:562-569 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:543` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:596— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:596-603 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:619-626 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:596` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:138— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:138-145 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:595-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:138` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) src/Files.App/Views/Shells/BaseShellPage.cs:661— src/Files.App/Views/Shells/BaseShellPage.cs:661-668 | src/Files.App/Views/Shells/BaseShellPage.cs:679-686 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Shells/BaseShellPage.cs:661` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App.Controls/Storage/StorageBar/StorageBar.Properties.cs:19— src/Files.App.Controls/Storage/StorageBar/StorageBar.Properties.cs:19-26 | src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:25-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App.Controls/Storage/StorageBar/StorageBar.Properties.cs:16` calls `GeneratedDependencyProperty` and `src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:22` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Constants.cs:7— src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Constants.cs:7-14 | src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.Constants.cs:7-14 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:2866— src/Files.App/ViewModels/ShellViewModel.cs:2866-2873 | src/Files.App/ViewModels/ShellViewModel.cs:2979-2986 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/ShellViewModel.cs:2866` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/ViewModels/ShellViewModel.cs:2864` calls `WriteLine` and `src/Files.App/ViewModels/ShellViewModel.cs:2977` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:264— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:264-271 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:374-381 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1148— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1148-1155 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:838-845 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:248— src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:248-255 | src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:306-313 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:248` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:147— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:147-154 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:196-203 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:147` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:604— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:604-611 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:641-648 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:604` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:390— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:390-398 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:436-443 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:390` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (8 lines × 2) src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55— src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55-63 | src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:119-126 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:1728— src/Files.App/ViewModels/ShellViewModel.cs:1728-1736 | src/Files.App/ViewModels/ShellViewModel.cs:1809-1816 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/ViewModels/ShellViewModel.cs:1738` calls `FromCloudDriveSyncStatus`, `Run`, `CheckElevationRights` and `src/Files.App/ViewModels/ShellViewModel.cs:1818` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) src/Files.App/Actions/Content/Install/InstallFontAction.cs:57— src/Files.App/Actions/Content/Install/InstallFontAction.cs:57-64 | src/Files.App/Actions/Content/Install/InstallInfDriverAction.cs:45-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Actions/FileSystem/CreateAlternateDataStreamAction.cs:115— src/Files.App/Actions/FileSystem/CreateAlternateDataStreamAction.cs:115-122 | src/Files.App/Actions/FileSystem/CreateShortcutAction.cs:45-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Actions/FileSystem/PasteItemAction.cs:55— src/Files.App/Actions/FileSystem/PasteItemAction.cs:55-62 | src/Files.App/Actions/FileSystem/PasteItemAsShortcutAction.cs:46-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Actions/Global/RedoAction.cs:41— src/Files.App/Actions/Global/RedoAction.cs:41-48 | src/Files.App/Actions/Global/UndoAction.cs:41-48 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Actions/Navigation/CloseActivePaneAction.cs:46— src/Files.App/Actions/Navigation/CloseActivePaneAction.cs:46-53 | src/Files.App/Actions/Navigation/FocusOtherPane.cs:43-50 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs:74— src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs:74-81 | src/Files.App/Actions/Sidebar/UnpinFolderToSidebarAction.cs:65-72 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
FileTooLong: ViewModels/ShellViewModel.cs src/Files.App/ViewModels/ShellViewModel.cs— FileTooLong — 2049 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1549 over it, 4.10× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Layouts/BaseLayoutPage.cs src/Files.App/Views/Layouts/BaseLayoutPage.cs— FileTooLong — 984 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 484 over it, 1.97× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: UserControls/SidebarViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs— FileTooLong — 910 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 410 over it, 1.82× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: UserControls/NavigationToolbarViewModel.cs src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs— FileTooLong — 845 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 345 over it, 1.69× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Layouts/DetailsLayoutPage.xaml.cs src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs— FileTooLong — 771 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 271 over it, 1.54× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Signatures/DigitalSignaturesUtil.cs src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs— FileTooLong — 681 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 181 over it, 1.36× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Win32/Win32Helper.Storage.cs src/Files.App/Helpers/Win32/Win32Helper.Storage.cs— FileTooLong — 662 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 162 over it, 1.32× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Operations/FileOperationsHelpers.cs src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs— FileTooLong — 616 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 116 over it, 1.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Views/ShellPanesPage.xaml.cs src/Files.App/Views/ShellPanesPage.xaml.cs— FileTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 103 over it, 1.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: StatusCenter/StatusCenterHelper.cs src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs— FileTooLong — 576 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 76 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Operations/FilesystemOperations.cs src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs— FileTooLong — 576 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 76 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Shells/BaseShellPage.cs src/Files.App/Views/Shells/BaseShellPage.cs— FileTooLong — 561 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 61 over it, 1.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Layouts/GridLayoutPage.xaml.cs src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs— FileTooLong — 540 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 40 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Search/FolderSearch.cs src/Files.App/Utils/Storage/Search/FolderSearch.cs— FileTooLong — 529 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 29 over it, 1.06× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Operations/FilesystemHelpers.cs src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs— FileTooLong — 524 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 24 over it, 1.05× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Factories/ContentPageContextFlyoutFactory.cs src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs— FileTooLong — 516 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 16 over it, 1.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: StorageItems/ZipStorageFolder.cs src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs— FileTooLong — 516 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 16 over it, 1.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Change coupling: PinToStartAction.cs ↔ UnpinFromStartAction.cs src/Files.App/Actions/Start/PinToStartAction.cs:1— `src/Files.App/Actions/Start/PinToStartAction.cs` and `src/Files.App/Actions/Start/UnpinFromStartAction.cs` change together 90% of the time (9 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `4fc8795d` Fix: Fixed an issue where folder related actions were enabled for arc…; `8674d762` Fix: Fixed issue where no error was displayed when opening corrupted …; `96143bb3` Fix: Fixed errors that occurred with shortcut items in git repositori… — run `git show` on any of them.
Change coupling: SidebarViewModel.cs ↔ NetworkLocationsWidgetViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1— `src/Files.App/ViewModels/UserControls/SidebarViewModel.cs` and `src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs` change together 73% of the time (8 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `8674d762` Fix: Fixed issue where no error was displayed when opening corrupted …; `734b2520` Feature: Added action to open selected folder in other pane (#18604); `aaaa54f1` Fix: Made Properties option primary in the sidebar and home page cont… — run `git show` on any of them.
Change coupling: CloudDrivesManager.cs ↔ WSLDistroManager.cs src/Files.App/Utils/Cloud/CloudDrivesManager.cs:1— `src/Files.App/Utils/Cloud/CloudDrivesManager.cs` and `src/Files.App/Utils/Global/WSLDistroManager.cs` change together 67% of the time (14 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 14 shared commits counted here, the most recent 3 are `12391aa2` Code Quality: Improved app startup routine 2 - Checkpoint 1 (#13854); `2806e7aa` Refactor UpdateDrives (#9082) (at that commit the files were still `src/Files.Uwp/Filesystem/CloudDrivesManager.cs` and `src/Files.Uwp/Filesystem/WSLDistroManager.cs`); `10eb8850` Refactor FileSystem (#9030) (at that commit the files were still `src/Files.Uwp/Filesystem/CloudDrivesManager.cs` and `src/Files.Uwp/Filesystem/WSLDistroManager.cs`) — run `git show` on any of them.
Change coupling: SidebarViewModel.cs ↔ DrivesWidgetViewModel.cs src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1— `src/Files.App/ViewModels/UserControls/SidebarViewModel.cs` and `src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs` change together 67% of the time (10 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `734b2520` Feature: Added action to open selected folder in other pane (#18604); `aaaa54f1` Fix: Made Properties option primary in the sidebar and home page cont…; `10de56c7` Feature: Added an option to hide 'Open in Terminal' from the context … — run `git show` on any of them.
Change coupling: DriveItem.cs ↔ LibraryProperties.cs src/Files.App/Data/Items/DriveItem.cs:1— `src/Files.App/Data/Items/DriveItem.cs` and `src/Files.App/ViewModels/Properties/Items/LibraryProperties.cs` change together 60% of the time (9 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `a3c94a2f` Feature: DPI aware icons and thumbnails in grid layout (#18892); `2fca3f34` Code Quality: Update thumbnail helper; `b4586498` Code Quality: Icon improvements (#14792) — run `git show` on any of them.
Change coupling: LayoutPreferencesItem.cs ↔ FoldersSettingsService.cs src/Files.App/Helpers/Layout/LayoutPreferencesItem.cs:1— `src/Files.App/Helpers/Layout/LayoutPreferencesItem.cs` and `src/Files.App/Services/Settings/FoldersSettingsService.cs` change together 59% of the time (10 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `e853f423` Feature: Created new "Layout" settings page (#14912); `d3f06b03` Feature: Added option to prioritize files when sorting (#14253); `4a51b243` Feature: Added path column to Details layout for search results (#12885) (at that commit the file was still `src/Files.App/Helpers/ContentLayout/LayoutPreferences.cs`) — run `git show` on any of them.
Change coupling: FileTagsWidget.xaml.cs ↔ RecentFilesWidget.xaml.cs src/Files.App/UserControls/Widgets/FileTagsWidget.xaml.cs:1— `src/Files.App/UserControls/Widgets/FileTagsWidget.xaml.cs` and `src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs` change together 58% of the time (11 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `93566ce2` Fix: Fixed issue where Open with and Send To submenus didn't appear p…; `4f8aebff` Code Quality: Refactor context flyout helpers 1 (#14609); `6718879a` Revert "Code Quality: Improved the way of instancing OpacityIconModel… — run `git show` on any of them.
Change coupling: ContentPageContextFlyoutFactory.cs ↔ ContextFlyoutModelToElementHelper.cs src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:1— `src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs` and `src/Files.App/Helpers/MenuFlyout/ContextFlyoutModelToElementHelper.cs` change together 57% of the time (13 of the 23 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `a47ab175` Feature: Improved context menu performance (#18803); `85a5b6f8` Feature: Added access key support for shell extensions (#18400); `94e40ffe` Feature: Added access keys to the right click context menu (#17196) — run `git show` on any of them.
Change coupling: DrivesWidget.xaml.cs ↔ QuickAccessWidget.xaml.cs src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:1— `src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs` and `src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs` change together 55% of the time (33 of the 60 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 33 shared commits counted here, the most recent 3 are `d12b6ba6` Feature: Added option to always switch to newly created tab (#16613); `8b9b6bfa` Code Quality: Apply CA1829 and CA1859 across the solution (#14970); `24608185` Fix: Fixed issue where new tab was selected — run `git show` on any of them.
Change coupling: AppUpdateSideloadService.cs ↔ AppUpdateStoreService.cs src/Files.App/Services/App/AppUpdateSideloadService.cs:1— `src/Files.App/Services/App/AppUpdateSideloadService.cs` and `src/Files.App/Services/App/AppUpdateStoreService.cs` change together 54% of the time (13 of the 24 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `272c4912` Code Quality: Modified update services to use appinstaller instead of…; `9f8d4926` Code Quality: Refactor launcher update logic and remove hash check (#…; `adebd0c5` Code Quality: Set IsUpdateAvailable on UI thread for update services — run `git show` on any of them.
Change coupling: CloudDrivesManager.cs ↔ LibraryProperties.cs src/Files.App/Utils/Cloud/CloudDrivesManager.cs:1— `src/Files.App/Utils/Cloud/CloudDrivesManager.cs` and `src/Files.App/ViewModels/Properties/Items/LibraryProperties.cs` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `a3c94a2f` Feature: DPI aware icons and thumbnails in grid layout (#18892); `2fca3f34` Code Quality: Update thumbnail helper; `b4586498` Code Quality: Icon improvements (#14792) — run `git show` on any of them.
Change coupling: ContentPageContext.cs ↔ BaseShellPage.cs src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs:1— `src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs` and `src/Files.App/Views/Shells/BaseShellPage.cs` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `2ea3dfee` Code Quality: Renamed AddressToolbar and InnerNavigationToolbaar (#16…; `0137194c` Code Quality: Introduced pane generation 2 (#15544); `3a3a7186` Code Quality: Renamed user control class names (#14810) — run `git show` on any of them.
Change coupling: IContentPageContext.cs ↔ BaseShellPage.cs src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs:1— `src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs` and `src/Files.App/Views/Shells/BaseShellPage.cs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `20223000` Feature: Updated query to include unindexed items in results (#14415); `1b24eb03` Feature: Git Integration - Phase 4 (#12439) (at that commit the file was still `src/Files.App/Contexts/ContentPage/IContentPageContext.cs`); `f52fda7b` RichCommands: Add Item & Edit Path (#12011) (at that commit the files were still `src/Files.App/Contexts/ContentPage/IContentPageContext.cs` and `src/Files.App/Views/BaseShellPage.cs`) — run `git show` on any of them.
Change coupling: IContentPageContext.cs ↔ ColumnShellPage.xaml.cs src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs:1— `src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs` and `src/Files.App/Views/Shells/ColumnShellPage.xaml.cs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `20223000` Feature: Updated query to include unindexed items in results (#14415); `f52fda7b` RichCommands: Add Item & Edit Path (#12011) (at that commit the files were still `src/Files.App/Contexts/ContentPage/IContentPageContext.cs` and `src/Files.App/Views/ColumnShellPage.xaml.cs`); `5ed24834` RichCommands: Search (#11837) (at that commit the files were still `src/Files.App/Contexts/ContentPage/IContentPageContext.cs` and `src/Files.App/Views/ColumnShellPage.xaml.cs`) — run `git show` on any of them.
Unfinished stub — throws NotImplementedException src/Files.Storage/Windows/WindowsFile.cs:17— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App.Controls/AdaptiveGridView/AdaptiveHeightValueConverter.cs:42— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/EnumToBoolConverter.cs:18— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/EnumToHumanizedConverter.cs:32— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/EnumToStringConverter.cs:15— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/ImageModelToImageConverter.cs:18— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/StatusCenterStateToBrushConverter.cs:124— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/StatusCenterStateToStateIconConverter.cs:43— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/StringToBrushConverter.cs:28— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Converters/VisibilityInvertConverter.cs:23— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:101— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:106— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:111— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:116— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
MethodTooLong: ContentPageContextFlyoutFactory.GetBaseItemMenuItems src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:81— MethodTooLong — GetBaseItemMenuItems runs 439 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 339 over it, 4.39× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Win32StorageEnumerator.GetFile src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:251— MethodTooLong — GetFile runs 175 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 75 over it, 1.75× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ShellViewModel.LoadExtendedItemPropertiesAsync src/Files.App/ViewModels/ShellViewModel.cs:1672— MethodTooLong — LoadExtendedItemPropertiesAsync runs 147 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 47 over it, 1.47× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ShellViewModel.EnumerateItemsFromStandardFolderAsync src/Files.App/ViewModels/ShellViewModel.cs:2279— MethodTooLong — EnumerateItemsFromStandardFolderAsync runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: StorageBar.UpdateColumnWidths src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:148— MethodTooLong — UpdateColumnWidths runs 137 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 37 over it, 1.37× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: LaunchHelper.HandleApplicationLaunch REDACTED:56— MethodTooLong — HandleApplicationLaunch runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SidebarViewModel.GetLocationItemMenuItems src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1036— MethodTooLong — GetLocationItemMenuItems runs 123 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 23 over it, 1.23× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SecurityAdvancedAccessControlItemFactory.Initialize src/Files.App/Data/Factories/SecurityAdvancedAccessControlItemFactory.cs:16— MethodTooLong — Initialize runs 121 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 21 over it, 1.21× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RegistrySerializationGenerator.EmitBindValues src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:81— MethodTooLong — EmitBindValues runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: StatusCenterHelper.UpdateCardStrings src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:593— MethodTooLong — UpdateCardStrings runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: RegistrySerializationGenerator.EmitSaveValues src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:245— MethodTooLong — EmitSaveValues runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MainWindow.InitializeApplicationAsync src/Files.App/MainWindow.xaml.cs:95— MethodTooLong — InitializeApplicationAsync runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: FilesystemOperations.CopyAsync src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:130— MethodTooLong — CopyAsync runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Fake-async — async method never awaits src/Files.App.Controls/Omnibar/Omnibar.Events.cs:90— `AutoSuggestBox_KeyDown` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App.Controls/Sidebar/SidebarItem.cs:550— `ItemBorder_DragOver` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Actions/FileSystem/OpenItemAction.cs:134— `ExecuteAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Data/Models/DirectoryPropertiesViewModel.cs:329— `OnZipEncodingChangedAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:20— `SwitchPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:25— `DoPreviewAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:49— `DetectAvailability` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/PreviewPopupProviders/SeerProProvider.cs:81— `DetectAvailability` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/Storage/StorageArchiveService.cs:429— `IsEncodingUndeterminedAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Services/Storage/StorageArchiveService.cs:449— `DetectEncodingAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/ViewModels/Settings/GeneralViewModel.cs:362— `AddPageAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/ViewModels/UserControls/Previews/HtmlPreviewViewModel.cs:15— `LoadPreviewAndDetailsAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Files.App/Views/Properties/HashesPage.xaml.cs:59— `SaveChangesAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Swallowed exception (caught, then discarded) src/Files.App/Data/Models/AppModel.cs:28— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Data/Models/CompressArchiveModel.cs:286— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:40— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:52— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:64— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:76— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:88— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:100— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Services/App/AppUpdateNoneService.cs:43— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Services/App/AppUpdateSideloadService.cs:189— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Services/App/AppUpdateStoreService.cs:141— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Services/Git/LibGit2Service.cs:126— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) src/Files.App/Services/Git/LibGit2Service.cs:511— `catch (LibGit2SharpException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Low cohesion: DetailsLayoutPage (LCOM4 17) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:30— DetailsLayoutPage's methods fall into 17 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 17 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: TabBar (LCOM4 10) src/Files.App/UserControls/TabBar/TabBar.xaml.cs:16— TabBar's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: SidebarView (LCOM4 9) src/Files.App.Controls/Sidebar/SidebarView.xaml.cs:14— SidebarView's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: ResourcesService (LCOM4 9) src/Files.App/Services/App/AppResourcesService.cs:10— ResourcesService's methods fall into 9 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 9 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: StorageArchiveService (LCOM4 5) src/Files.App/Services/Storage/StorageArchiveService.cs:19— StorageArchiveService's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: NavigationToolbar (LCOM4 5) src/Files.App/UserControls/NavigationToolbar.xaml.cs:20— NavigationToolbar's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: GeneralViewModel (LCOM4 5) src/Files.App/ViewModels/Settings/GeneralViewModel.cs:12— GeneralViewModel's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: NetworkService (LCOM4 4) src/Files.App/Services/Storage/StorageNetworkService.cs:12— NetworkService's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: InfoPane (LCOM4 4) src/Files.App/UserControls/Pane/InfoPane.xaml.cs:18— InfoPane's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: AdvancedViewModel (LCOM4 4) src/Files.App/ViewModels/Settings/AdvancedViewModel.cs:18— AdvancedViewModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: NavigationToolbarViewModel (LCOM4 4) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:22— NavigationToolbarViewModel's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Duplicated block (12 lines × 2) src/Files.Storage/Windows/Managers/STATask.cs:158— src/Files.Storage/Windows/Managers/STATask.cs:158-169 | src/Files.Storage/Windows/Managers/STATask.cs:203-214 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Storage/Windows/Managers/STATask.cs:158` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Files.App/Helpers/TransferHelpers.cs:17— src/Files.App/Helpers/TransferHelpers.cs:17-28 | src/Files.App/Helpers/TransferHelpers.cs:95-106 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Helpers/TransferHelpers.cs:17` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Files.App/Services/Git/LibGit2Service.cs:568— src/Files.App/Services/Git/LibGit2Service.cs:568-579 | src/Files.App/Utils/Git/GitHelpers.cs:682-693 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (12 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:2830— src/Files.App/ViewModels/ShellViewModel.cs:2830-2841 | src/Files.App/ViewModels/ShellViewModel.cs:2949-2960 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/ShellViewModel.cs:2830` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:606— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:606-617 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:630-641 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:606` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:53— src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:53-64 | src/Files.App/Actions/Navigation/OpenInOtherPane/BaseOpenInOtherPaneAction.cs:51-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:731— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:731-742 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:800-811 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:731` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:259— src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:259-270 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:684-695 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:672— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:672-683 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:783-794 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:672` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 2) src/Files.App/UserControls/Selection/ExtendPreviousItemSelectionStrategy.cs:19— src/Files.App/UserControls/Selection/ExtendPreviousItemSelectionStrategy.cs:19-30 | src/Files.App/UserControls/Selection/IgnorePreviousItemSelectionStrategy.cs:15-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128-133 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:585-590 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:212— src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:212-217 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:293-298 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:212` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Files.App/ViewModels/MainPageViewModel.cs:285— src/Files.App/ViewModels/MainPageViewModel.cs:285-290 | src/Files.App/ViewModels/MainPageViewModel.cs:313-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/MainPageViewModel.cs:285` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (6 lines × 2) src/Files.Storage/Windows/Managers/SystemTrayManager.cs:106— src/Files.Storage/Windows/Managers/SystemTrayManager.cs:106-111 | src/Files.Storage/Windows/Managers/WindowsFolderChangeWatcher.cs:72-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (6 lines × 2) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:283— src/Files.App/Helpers/Navigation/NavigationHelpers.cs:283-288 | src/Files.App/Services/Windows/WindowsJumpListService.cs:161-166 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/Helpers/Navigation/NavigationHelpers.cs:288` calls `Equals`, `GetLocalizedResource` and `src/Files.App/Services/Windows/WindowsJumpListService.cs:166` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:190— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:190-196 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:636-641 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:190` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Files.App/Actions/Shelf/CopyItemFromShelfAction.cs:35— src/Files.App/Actions/Shelf/CopyItemFromShelfAction.cs:35-40 | src/Files.App/Actions/Shelf/CutItemFromShelfAction.cs:35-40 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs:31— src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs:31-36 | src/Files.App/Actions/Sidebar/UnpinFolderToSidebarAction.cs:29-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/StorageItems/ShellStorageFile.cs:24— src/Files.App/Utils/Storage/StorageItems/ShellStorageFile.cs:24-29 | src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs:23-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:719— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:719-724 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:788-793 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) src/Files.App/Views/Layouts/BaseLayoutPage.cs:212— src/Files.App/Views/Layouts/BaseLayoutPage.cs:212-218 | src/Files.App/Views/Layouts/BaseLayoutPage.cs:224-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/BaseLayoutPage.cs:212` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Views/Layouts/BaseLayoutPage.cs:210` calls `SkipWhile`, `Skip` and `src/Files.App/Views/Layouts/BaseLayoutPage.cs:223` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:190— src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:190-196 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:353-359 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:190` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:368— src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:368-374 | src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:377-383 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:76— src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:76-82 | src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:103-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:14— src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:14-20 | src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:34-40 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:14` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:41` calls `predicate` and `src/Files.App/Helpers/Xaml/DependencyObjectHelpers.cs:21` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:25— src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:25-31 | src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:117-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:74— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:74-81 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:526-532 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:74` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 2) src/Files.App/Actions/Content/Archives/Compress/BaseCompressArchiveAction.cs:68— src/Files.App/Actions/Content/Archives/Compress/BaseCompressArchiveAction.cs:68-74 | src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:45-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:30— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:30-36 | src/Files.App/Utils/Storage/StorageItems/VirtualStorageFile.cs:27-33 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) src/Files.App/Views/Properties/DetailsPage.xaml.cs:17— src/Files.App/Views/Properties/DetailsPage.xaml.cs:17-23 | src/Files.App/Views/Properties/GeneralPage.xaml.cs:21-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Sync-over-async blocking — 9 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Shared/Helpers/AsyncManualResetEvent.cs:46— `Task.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Storage/Windows/Managers/STATask.cs:42— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Storage/Windows/Managers/STATask.cs:170— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Storage/Windows/Managers/STATask.cs:215— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Storage/Windows/Managers/STATask.cs:293— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.Storage/Windows/Managers/STATask.cs:276— `completed.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.App/Program.cs:211— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.App/Program.cs:228— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Files.App/ViewModels/HomeViewModel.cs:236— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:224— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:224-232 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:319-327 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:224` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:76— src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:76-84 | src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:162-170 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:76` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:83— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:83-91 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:71-79 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Files.App.Server/Cloud/CloudDrivesDetector.cs:148— src/Files.App.Server/Cloud/CloudDrivesDetector.cs:148-156 | src/Files.App.Server/Cloud/CloudDrivesDetector.cs:178-186 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App.Server/Cloud/CloudDrivesDetector.cs:148` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/StorageBaseItems/IPasswordProtectedItem.cs:17— src/Files.App/Utils/Storage/StorageBaseItems/IPasswordProtectedItem.cs:17-25 | src/Files.App/Utils/Storage/StorageBaseItems/IPasswordProtectedItem.cs:32-40 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:228— src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:228-236 | src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:241-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:228` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.cs:83— src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.cs:83-91 | src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.cs:82-90 — `src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.cs` and `src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 9 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) src/Files.App/Actions/FileSystem/CopyItemFromHomeAction.cs:100— src/Files.App/Actions/FileSystem/CopyItemFromHomeAction.cs:100-108 | src/Files.App/Actions/Sidebar/CopyItemFromSidebarAction.cs:101-109 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) src/Files.App/Actions/Open/OpenClassicPropertiesAction.cs:72— src/Files.App/Actions/Open/OpenClassicPropertiesAction.cs:72-80 | src/Files.App/Actions/Open/OpenPropertiesAction.cs:80-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
ClassTooLong: DigitalSignaturesUtil src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs— ClassTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 265 over it, 1.66× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: StatusCenterHelper src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs— ClassTooLong — 575 significant lines (blank, comment-only and punctuation-only lines excluded), 11 methods. The bar is 400 significant lines; this is 175 over it, 1.44× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: FilesystemOperations src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs— ClassTooLong — 568 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 168 over it, 1.42× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: FileOperationsHelpers src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs— ClassTooLong — 568 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 168 over it, 1.42× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: FolderSearch src/Files.App/Utils/Storage/Search/FolderSearch.cs— ClassTooLong — 515 significant lines (blank, comment-only and punctuation-only lines excluded), 30 methods. The bar is 400 significant lines; this is 115 over it, 1.29× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ContentPageContextFlyoutFactory src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs— ClassTooLong — 508 significant lines (blank, comment-only and punctuation-only lines excluded), 6 methods. The bar is 400 significant lines; this is 108 over it, 1.27× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: SelectedItemsPropertiesViewModel src/Files.App/Data/Models/SelectedItemsPropertiesViewModel.cs— ClassTooLong — 476 significant lines (blank, comment-only and punctuation-only lines excluded), 2 methods. The bar is 400 significant lines; this is 76 over it, 1.19× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: NavigationHelpers src/Files.App/Helpers/Navigation/NavigationHelpers.cs— ClassTooLong — 465 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 65 over it, 1.16× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
Duplicated block (14 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:536— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:536-549 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:589-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:536` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:243— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:243-256 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:473-486 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:243` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Files.App/Views/ReleaseNotesPage.xaml.cs:39— src/Files.App/Views/ReleaseNotesPage.xaml.cs:39-52 | src/Files.App/Views/Settings/SettingsPage.xaml.cs:40-53 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:364— src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:364-377 | src/Files.App.Controls/Storage/StorageRing/StorageRing.cs:562-575 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (14 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:1642— src/Files.App/ViewModels/ShellViewModel.cs:1642-1655 | src/Files.App/ViewModels/ShellViewModel.cs:1757-1770 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/ShellViewModel.cs:1642` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:225— src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:225-238 | src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:233-246 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:102— src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:102-115 | src/Files.App/ViewModels/Properties/Items/FileProperties.cs:216-229 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:660— src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:660-674 | src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:967-980 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:660` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:676` calls `InvalidOperationException` and `src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:981` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Sync-over-async (deadlock risk) src/Files.Shared/Helpers/AsyncManualResetEvent.cs:46— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.Storage/Windows/Managers/STATask.cs:42— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.Storage/Windows/Managers/STATask.cs:170— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.Storage/Windows/Managers/STATask.cs:215— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.Storage/Windows/Managers/STATask.cs:293— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.App/Program.cs:211— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Files.App/Program.cs:228— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Duplicated block (11 lines × 2) src/Files.App/Actions/Start/PinToStartAction.cs:41— src/Files.App/Actions/Start/PinToStartAction.cs:41-51 | src/Files.App/Actions/Start/UnpinFromStartAction.cs:40-50 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Start/PinToStartAction.cs:41` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1123— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1123-1133 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:851-861 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (11 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:155— src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:155-165 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:221-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:155` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:88— src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:88-98 | src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs:93-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:134— src/Files.App/ViewModels/Properties/Items/FileProperties.cs:134-146 | src/Files.App/ViewModels/Properties/Items/FolderProperties.cs:103-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/Items/FileProperties.cs:134` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Files.App/Views/MainPage.xaml.cs:270— src/Files.App/Views/MainPage.xaml.cs:270-280 | src/Files.App/Views/MainPage.xaml.cs:537-547 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/MainPage.xaml.cs:270` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:196— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:196-205 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:291-300 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:196` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Files.App/ViewModels/ShellViewModel.cs:500— src/Files.App/ViewModels/ShellViewModel.cs:500-509 | src/Files.App/ViewModels/ShellViewModel.cs:542-551 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:90— src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:90-100 | src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:144-153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (10 lines × 2) src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs:60— src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs:60-69 | src/Files.App/Actions/Navigation/OpenInNewWindow/BaseOpenInNewWindowAction.cs:65-74 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/Files.App/Actions/Open/OpenInIDEAction.cs:59— src/Files.App/Actions/Open/OpenInIDEAction.cs:59-68 | src/Files.App/Actions/Open/OpenRepoInIDEAction.cs:54-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:36— src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:36-45 | src/Files.App/UserControls/Widgets/NetworkLocationsWidget.xaml.cs:36-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1300— src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1300-1304 | src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1356-1360 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1300` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:684— src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:684-688 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:706-710 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:335— src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:335-339 | src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:371-376 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:56— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:56-60 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:41-45 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:312— src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:312-316 | src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:391-396 — before extracting anything, compare `src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs` and `src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:501— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:501-505 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:770-774 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:501` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Change-coupling hub: CommandManager.cs → ContentPageContext.cs, IContentPageContext.cs, ContextMenuFlyoutItemViewModelBuilder.cs src/Files.App/Data/Commands/Manager/CommandManager.cs— `src/Files.App/Data/Commands/Manager/CommandManager.cs` changes together with 3 other files — `src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs`, `src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs`, `src/Files.App/Data/Models/ContextMenuFlyoutItemViewModelBuilder.cs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: SidebarLibraryItem.cs → PinnedFoldersManager.cs, CloudDrivesManager.cs, DriveProperties.cs, LibraryProperties.cs, ShellViewModel.cs src/Files.App/Data/Items/SidebarLibraryItem.cs— `src/Files.App/Data/Items/SidebarLibraryItem.cs` changes together with 5 other files — `src/Files.App/Data/Models/PinnedFoldersManager.cs`, `src/Files.App/Utils/Cloud/CloudDrivesManager.cs`, `src/Files.App/ViewModels/Properties/Items/DriveProperties.cs`, `src/Files.App/ViewModels/Properties/Items/LibraryProperties.cs`, `src/Files.App/ViewModels/ShellViewModel.cs` — none of which declares a dependency on it: one file is the hub of 5 separate couplings, not 5 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 5.
Change-coupling hub: ShortcutPreviewViewModel.cs → DriveItem.cs, SidebarLibraryItem.cs, PinnedFoldersManager.cs, CloudDrivesManager.cs, DriveProperties.cs, ShellViewModel.cs, FolderPreviewViewModel.cs src/Files.App/ViewModels/UserControls/Previews/ShortcutPreviewViewModel.cs— `src/Files.App/ViewModels/UserControls/Previews/ShortcutPreviewViewModel.cs` changes together with 7 other files — `src/Files.App/Data/Items/DriveItem.cs`, `src/Files.App/Data/Items/SidebarLibraryItem.cs`, `src/Files.App/Data/Models/PinnedFoldersManager.cs`, `src/Files.App/Utils/Cloud/CloudDrivesManager.cs`, `src/Files.App/ViewModels/Properties/Items/DriveProperties.cs`, `src/Files.App/ViewModels/ShellViewModel.cs`, `src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs` — none of which declares a dependency on it: one file is the hub of 7 separate couplings, not 7 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 7.
Change-coupling hub: ShellViewModel.cs → LayoutPreferencesItem.cs, FoldersViewModel.cs, BasePreviewModel.cs, FolderPreviewViewModel.cs src/Files.App/ViewModels/ShellViewModel.cs— `src/Files.App/ViewModels/ShellViewModel.cs` changes together with 4 other files — `src/Files.App/Helpers/Layout/LayoutPreferencesItem.cs`, `src/Files.App/ViewModels/Settings/FoldersViewModel.cs`, `src/Files.App/ViewModels/UserControls/Previews/BasePreviewModel.cs`, `src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
Change-coupling hub: PinnedFoldersManager.cs → CloudDrivesManager.cs, DriveProperties.cs, LibraryProperties.cs src/Files.App/Data/Models/PinnedFoldersManager.cs— `src/Files.App/Data/Models/PinnedFoldersManager.cs` changes together with 3 other files — `src/Files.App/Utils/Cloud/CloudDrivesManager.cs`, `src/Files.App/ViewModels/Properties/Items/DriveProperties.cs`, `src/Files.App/ViewModels/Properties/Items/LibraryProperties.cs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Duplicated block (13 lines × 2) src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:97— src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:97-109 | src/Files.App/Utils/Storage/StorageItems/VirtualStorageFile.cs:126-138 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:97` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Constants.cs:20— src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Constants.cs:20-32 | src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.Constants.cs:30-42 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (13 lines × 2) src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFile.cs:139— src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFile.cs:139-151 | src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFolder.cs:241-253 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (13 lines × 2) src/Files.App/Utils/Storage/Search/FolderSearch.cs:95— src/Files.App/Utils/Storage/Search/FolderSearch.cs:95-107 | src/Files.App/Utils/Storage/Search/FolderSearch.cs:154-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Search/FolderSearch.cs:154` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1105— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1105-1117 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:818-830 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 3) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:248— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:248-255 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:323-330 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:413-420 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (8 lines × 3) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:762— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:762-769 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:932-939 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:978-985 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:762` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:140— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:140-147 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:597-604 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:835-842 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:140` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:170— src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:170-177 | src/Files.App/Actions/Content/Run/BaseRunAsAction.cs:38-45 | src/Files.App/Actions/Content/Run/RunWithPowershellAction.cs:49-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 3) src/Files.App/Actions/FileSystem/AddItemAction.cs:65— src/Files.App/Actions/FileSystem/AddItemAction.cs:65-72 | src/Files.App/Actions/FileSystem/CreateFileAction.cs:50-57 | src/Files.App/Actions/FileSystem/CreateFolderAction.cs:53-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:101— `RenameAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:106— `RenameAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:111— `DeleteAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.App/Utils/Storage/StorageItems/VirtualStorageItem.cs:116— `DeleteAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Files.Storage/Windows/WindowsFile.cs:17— `OpenStreamAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×5
Symbol treated as nullable, then dereferenced unguarded src/Files.App/UserControls/NavigationToolbar.xaml.cs:113— This method contradicts itself about `flyoutItems`: line 133 writes `flyoutItems?.Add`, which says `flyoutItems` can be null, but line 113 then dereferences it directly as `flyoutItems.Clear` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `flyoutItems` truly cannot be null here, the `?.` is misleading. Settle it one way — test `flyoutItems` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Files.App/ViewModels/Properties/Items/FileProperty.cs:402— This method contradicts itself about `input`: line 403 writes `input?.ToString`, which says `input` can be null, but line 402 then dereferences it directly as `input.GetType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `input` truly cannot be null here, the `?.` is misleading. Settle it one way — test `input` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:145— This method contradicts itself about `parentShellPage`: line 142 writes `parentShellPage?.SlimContentPage`, which says `parentShellPage` can be null, but line 145 then dereferences it directly as `parentShellPage.GetRequiredShellViewModel` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `parentShellPage` truly cannot be null here, the `?.` is misleading. Settle it one way — test `parentShellPage` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Files.App/Views/Layouts/BaseGroupableLayoutPage.cs:165— This method contradicts itself about `parentShellPage`: line 162 writes `parentShellPage?.SlimContentPage`, which says `parentShellPage` can be null, but line 165 then dereferences it directly as `parentShellPage.GetRequiredShellViewModel` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `parentShellPage` truly cannot be null here, the `?.` is misleading. Settle it one way — test `parentShellPage` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Files.App/Views/Settings/SettingsPage.xaml.cs:42— This method contradicts itself about `navArgs`: line 85 writes `navArgs?.SelectItems`, which says `navArgs` can be null, but line 42 then dereferences it directly as `navArgs.AssociatedTabInstance` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `navArgs` truly cannot be null here, the `?.` is misleading. Settle it one way — test `navArgs` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Duplicated block (20 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:495— src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:495-514 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:833-852 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:495` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:379— src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:379-398 | src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:535-554 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20 lines × 2) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:92— src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:92-111 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:264-283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:165— src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:165-184 | src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:191-210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:165` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Files.App/Utils/FileTags/FileTagsDatabase.cs:110— src/Files.App/Utils/FileTags/FileTagsDatabase.cs:110-127 | src/Files.App/Utils/FileTags/FileTagsDatabase.cs:139-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/FileTags/FileTagsDatabase.cs:110` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:110— src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:110-127 | src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:161-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:110` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Files.App/Services/Storage/StorageSecurityService.cs:205— src/Files.App/Services/Storage/StorageSecurityService.cs:205-222 | src/Files.App/Services/Storage/StorageSecurityService.cs:306-323 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Storage/StorageSecurityService.cs:205` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:137— src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:137-154 | src/Files.App/ViewModels/Properties/SecurityViewModel.cs:75-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (15 lines × 2) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:137— src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:137-151 | src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:159-173 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:137` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:554— src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:554-568 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:611-625 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:554` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Files.App/Services/Storage/StorageSecurityService.cs:274— src/Files.App/Services/Storage/StorageSecurityService.cs:274-288 | src/Files.App/Services/Storage/StorageSecurityService.cs:327-341 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Storage/StorageSecurityService.cs:274` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:234— src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:234-248 | src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:268-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:234` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128-133 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:585-590 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:824-829 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:123— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:123-128 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:424-430 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:819-824 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:123` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:135— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:135-140 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:172-179 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:628-634 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (6 lines × 3) src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:26— src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:26-31 | src/Files.App/UserControls/Widgets/NetworkLocationsWidget.xaml.cs:26-31 | src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs:37-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 4) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:135— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:135-144 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:220-228 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:297-304 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:369-377 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 4) src/Files.App/Actions/Navigation/ArrangePanesHorizontallyAction.cs:47— src/Files.App/Actions/Navigation/ArrangePanesHorizontallyAction.cs:47-54 | src/Files.App/Actions/Navigation/ArrangePanesVerticallyAction.cs:47-54 | src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs:47-54 | src/Files.App/Actions/Navigation/SplitPaneVerticallyAction.cs:47-54 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/Actions/Navigation/ArrangePanesHorizontallyAction.cs:56` calls `MultiPanesContext_ShellPaneArrangementChanged`, `OnPropertyChanged`, `nameof` and `src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs:55` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 4) src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromHomeAction.cs:34— src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromHomeAction.cs:34-41 | src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromHomeAction.cs:32-39 | src/Files.App/Actions/Navigation/OpenInNewWindow/OpenInNewWindowFromHomeAction.cs:29-36 | src/Files.App/Actions/Navigation/OpenInOtherPane/OpenInOtherPaneFromHomeAction.cs:33-40 — before extracting anything, compare `src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromHomeAction.cs` and `src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromHomeAction.cs` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 4) src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromSidebarAction.cs:32— src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromSidebarAction.cs:32-39 | src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromSidebarAction.cs:30-37 | src/Files.App/Actions/Navigation/OpenInNewWindow/OpenInNewWindowFromSidebarAction.cs:27-34 | src/Files.App/Actions/Navigation/OpenInOtherPane/OpenInOtherPaneFromSidebarAction.cs:31-38 — before extracting anything, compare `src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneFromSidebarAction.cs` and `src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromSidebarAction.cs` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×4
Disposable created and abandoned in the method that made it src/Files.Shared/Helpers/PathHelpers.cs:25— `p` is a `Process`, which implements `IDisposable`, and it is created here (line 25). Every use of it in `TryGetFullPath` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var p = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Files.Storage/Legacy/HomeFolder/HomeFolder.cs:44— `folder` is a `IFolder`, which implements `IDisposable`, and it is created here (line 44). Every use of it in `GetQuickAccessFolderAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var folder = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Files.Storage/Legacy/HomeFolder/HomeFolder.cs:87— `folder` is a `IFolder`, which implements `IDisposable`, and it is created here (line 87). Every use of it in `GetNetworkLocationsAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var folder = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.PowerShell.cs:28— `process` is a `Process`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `TrySetShortcutIconOnPowerShellAsElevatedAsync` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var process = …;`), which releases it at the end of the scope on every path including a throw.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×3
Members sharing a duplicated core (6 members, 50+ identical tokens) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:47— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:47-209 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:212-306 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:357-481 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:501-652 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:661-750 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:770-862 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
Members sharing a duplicated core (6 members, 50+ identical tokens) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:162— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:162-197 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:245-277 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:320-351 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:410-449 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:478-507 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:692-715 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
Members sharing a duplicated core (6 members, 50+ identical tokens) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:520— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:520-567 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:571-617 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:492-531 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:538-589 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:593-641 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:830-870 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
Duplicated block (23 lines × 2) src/Files.App/Services/Storage/StorageArchiveService.cs:215— src/Files.App/Services/Storage/StorageArchiveService.cs:215-237 | src/Files.App/Services/Storage/StorageArchiveService.cs:332-354 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Storage/StorageArchiveService.cs:215` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/Files.App/Data/Commands/ActionCommand.cs:219— src/Files.App/Data/Commands/ActionCommand.cs:219-241 | src/Files.App/Data/Commands/ModifiableCommand.cs:162-184 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23 lines × 2) src/Files.App/Services/Windows/WindowsDialogService.cs:31— src/Files.App/Services/Windows/WindowsDialogService.cs:31-53 | src/Files.App/Services/Windows/WindowsDialogService.cs:122-144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Windows/WindowsDialogService.cs:31` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/Services/Windows/WindowsDialogService.cs:57` calls `SetClientGuid` and `src/Files.App/Services/Windows/WindowsDialogService.cs:147` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (16 lines × 2) src/Files.App/Utils/Storage/StorageItems/NativeStorageFile.cs:94— src/Files.App/Utils/Storage/StorageItems/NativeStorageFile.cs:94-109 | src/Files.App/Utils/Storage/StorageItems/NativeStorageFile.cs:281-296 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/NativeStorageFile.cs:94` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:72— src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:72-87 | src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs:60-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (16 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:94— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:94-109 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:543-558 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:94` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 3) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:467— src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:467-475 | src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:541-549 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:602-610 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:537` calls `GetFocusedElement` and `src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:465` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 3) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:627— src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:627-635 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:646-654 | src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:665-673 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9 lines × 3) src/Files.App/Views/HomePage.xaml.cs:49— src/Files.App/Views/HomePage.xaml.cs:49-57 | src/Files.App/Views/ReleaseNotesPage.xaml.cs:45-53 | src/Files.App/Views/Settings/SettingsPage.xaml.cs:46-54 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note what the matched lines are: every one of them assigns one field to another, so the block is a hand-written mapper between two data shapes rather than behaviour with a helper inside it. Extracting one shared function only works if both sites map the SAME pair of types in the same direction — check that first, because inverse or differently-typed mappers have no single function they can both call. Where they do not, the moves that exist are a generated or reflective mapper, a common embedded/base type the fields live on once, or accepting the run and covering it with a test that fails when a field is added to one side only.
Duplicated block (19 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:572— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:572-590 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:594-612 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:572` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/Files.App/Actions/Open/OpenLogFileAction.cs:45— src/Files.App/Actions/Open/OpenLogFileAction.cs:45-63 | src/Files.App/Actions/Open/OpenSettingsFileAction.cs:38-56 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Open/OpenLogFileAction.cs:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:521— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:521-537 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:539-555 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:521` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:96— src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:96-112 | src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:148-164 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:96` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15–16 lines × 2) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:308— src/Files.App/ViewModels/Properties/Items/FileProperties.cs:308-323 | src/Files.App/ViewModels/Properties/Items/FolderProperties.cs:209-223 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/Items/FileProperties.cs:308` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15–16 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1164— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1164-1178 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:877-892 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1164` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `null` to `ListViewItem? lviContainer =` in one and `GridViewItem? lviContainer =` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14–15 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:57— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:57-71 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:510-523 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:57` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (14–15 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553-567 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:576-589 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:109— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:109-122 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:806-818 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:109` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13–14 lines × 2) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:30— src/Files.App/ViewModels/Properties/Items/FileProperties.cs:30-43 | src/Files.App/ViewModels/Properties/Items/FolderProperties.cs:33-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/Properties/Items/FileProperties.cs:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11–13 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:259— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:259-269 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:673-685 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:259` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11–13 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:676— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:676-688 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:187-197 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:676` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 4) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128-133 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:585-590 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:717-722 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:824-829 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:128` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 4) src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:6— src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:6-11 | src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs:6-11 | src/Files.App/Actions/Navigation/OpenInNewWindow/BaseOpenInNewWindowAction.cs:8-13 | src/Files.App/Actions/Navigation/OpenInOtherPane/BaseOpenInOtherPaneAction.cs:6-11 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs:6` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 4) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:131— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:131-135 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:168-172 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:588-592 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:624-628 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:131` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 4) src/Files.App/Dialogs/CompressSkippedItemsDialog.xaml.cs:36— src/Files.App/Dialogs/CompressSkippedItemsDialog.xaml.cs:36-41 | src/Files.App/Dialogs/FileTooLargeDialog.xaml.cs:36-41 | src/Files.App/Dialogs/FilesystemOperationDialog.xaml.cs:48-53 | src/Files.App/Views/Shells/BaseShellPage.cs:868-872 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 3) src/Files.App/Services/App/AppUpdateNoneService.cs:36— src/Files.App/Services/App/AppUpdateNoneService.cs:36-47 | src/Files.App/Services/App/AppUpdateSideloadService.cs:182-193 | src/Files.App/Services/App/AppUpdateStoreService.cs:134-145 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 3) src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:115— src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs:115-126 | src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs:163-174 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:333-344 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Sync-over-async (deadlock risk) through `.Wait(…)` src/Files.Shared/Utils/Logger/FileLogger.cs:151— `.Wait(…)` blocks this thread until the task completes or the bound expires — sync-over-async: it can deadlock under a synchronization context and it parks a thread while it waits. `await` the task (with `.WaitAsync(timeout, token)` where the bound matters).
Sync-over-async (deadlock risk) through `.Wait(…)` src/Files.App/Helpers/Application/AppLifecycleHelper.cs:609— `.Wait(…)` blocks this thread until the task completes or the bound expires — sync-over-async: it can deadlock under a synchronization context and it parks a thread while it waits. `await` the task (with `.WaitAsync(timeout, token)` where the bound matters).
X18 · Disposal-pattern correctness· Finalizer on a type that owns no unmanaged resource · ×2
Finalizer on a type that owns no unmanaged resource src/Files.App/Helpers/Navigation/NavigationInteractionTracker.cs:159— `NavigationInteractionTracker` declares a finalizer (line 159), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource src/Files.App/ViewModels/Settings/GeneralViewModel.cs:616— `GeneralViewModel` declares a finalizer (line 616), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
ShellViewModel.LoadExtendedItemPropertiesAsync (cyclomatic 51) src/Files.App/ViewModels/ShellViewModel.cs:1672— ShellViewModel.LoadExtendedItemPropertiesAsync has cyclomatic complexity 51 (threshold 15). Of this number, 39 points are the body's own statements and 12 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StatusCenterHelper.UpdateCardStrings (cyclomatic 46) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:593— StatusCenterHelper.UpdateCardStrings has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainWindow.InitializeApplicationAsync (cyclomatic 44) src/Files.App/MainWindow.xaml.cs:95— MainWindow.InitializeApplicationAsync has cyclomatic complexity 44 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellViewModel.EnumerateItemsFromStandardFolderAsync (cyclomatic 43) src/Files.App/ViewModels/ShellViewModel.cs:2279— ShellViewModel.EnumerateItemsFromStandardFolderAsync has cyclomatic complexity 43 (threshold 15). Of this number, 41 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemOperations.MoveAsync (cyclomatic 40) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:334— FilesystemOperations.MoveAsync has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CloudDrivesDetector.DetectGenericCloudDrive (cyclomatic 39) src/Files.App.Server/Cloud/CloudDrivesDetector.cs:57— CloudDrivesDetector.DetectGenericCloudDrive has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemOperations.CopyAsync (cyclomatic 39) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:130— FilesystemOperations.CopyAsync has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LaunchHelper.HandleApplicationLaunch (cyclomatic 38) REDACTED:56— LaunchHelper.HandleApplicationLaunch has cyclomatic complexity 38 (threshold 15). Of this number, 27 points are the body's own statements and 11 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PropertiesNavigationItemsFactory.Initialize (cyclomatic 37) src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs:15— PropertiesNavigationItemsFactory.Initialize has cyclomatic complexity 37 (threshold 15). Of this number, 35 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DetailsLayoutPage.FileList_PreviewKeyDown (cyclomatic 34) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:527— DetailsLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: DetailsLayoutPage.ResizeColumnToFit (cyclomatic 35) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
FolderSearch.SearchWithWin32 (cyclomatic 33) src/Files.App/Utils/Storage/Search/FolderSearch.cs:550— FolderSearch.SearchWithWin32 has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CssPreviewRenderer.Render (cyclomatic 32) src/Files.App/UserControls/FilePreviews/CssPreviewRenderer.cs:13— CssPreviewRenderer.Render has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DigitalSignaturesUtil.ParseDERFindType (cyclomatic 32) src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:516— DigitalSignaturesUtil.ParseDERFindType has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
UniversalStorageEnumerator.ListEntries (cyclomatic 31) src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs:19— UniversalStorageEnumerator.ListEntries has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainPageViewModel.OnNavigatedToAsync (cyclomatic 31) src/Files.App/ViewModels/MainPageViewModel.cs:240— MainPageViewModel.OnNavigatedToAsync has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellViewModel.ProcessOperationQueueAsync (cyclomatic 30) src/Files.App/ViewModels/ShellViewModel.cs:3046— ShellViewModel.ProcessOperationQueueAsync has cyclomatic complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationToolbarViewModel.HandleItemNavigationAsync (cyclomatic 30) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:598— NavigationToolbarViewModel.HandleItemNavigationAsync has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GeneralPage.SaveChangesAsync (cyclomatic 30) src/Files.App/Views/Properties/GeneralPage.xaml.cs:91— GeneralPage.SaveChangesAsync has cyclomatic complexity 30 (threshold 15). Of this number, 26 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NavigationToolbarViewModel.CheckPathInputAsync (cyclomatic 29) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:900— NavigationToolbarViewModel.CheckPathInputAsync has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationHelpers.OpenFile (cyclomatic 28) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:668— NavigationHelpers.OpenFile has cyclomatic complexity 28 (threshold 15). Most of this is not in the body itself: 10 of the 28 points are its own statements and the rest belongs to one function literal inside it that branches (line 705). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
StatusCenterItem.ReportProgress (cyclomatic 28) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:289— StatusCenterItem.ReportProgress has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: StatusCenterItem.StatusCenterItem.ctor (cyclomatic 29) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
ColumnLayoutPage.FileList_PreviewKeyDown (cyclomatic 28) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:449— ColumnLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GridLayoutPage.FileList_PreviewKeyDown (cyclomatic 28) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:590— GridLayoutPage.FileList_PreviewKeyDown has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Program.Main (cyclomatic 27) src/Files.App/Program.cs:48— Program.Main has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFolderExtensions.GetShellFileItem (cyclomatic 27) src/Files.App/Utils/Shell/ShellFolderExtensions.cs:44— ShellFolderExtensions.GetShellFileItem has cyclomatic complexity 27 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
BaseLayoutViewModel.DragOverAsync (cyclomatic 27) src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs:105— BaseLayoutViewModel.DragOverAsync has cyclomatic complexity 27 (threshold 15). Of this number, 26 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellViewModel.LoadThumbnailAsync (cyclomatic 27) src/Files.App/ViewModels/ShellViewModel.cs:1442— ShellViewModel.LoadThumbnailAsync has cyclomatic complexity 27 (threshold 15). Of this number, 18 points are the body's own statements and 9 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MainWindow.InitializeFromCmdLineArgsAsync (cyclomatic 26) src/Files.App/MainWindow.xaml.cs:323— MainWindow.InitializeFromCmdLineArgsAsync has cyclomatic complexity 26 (threshold 15). Of this number, 24 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.CopyItemsAsync (cyclomatic 26) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:46— ShellFilesystemOperations.CopyItemsAsync has cyclomatic complexity 26 (threshold 15). Of this number, 19 points are the body's own statements and 7 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BaseDecompressArchiveAction.DecompressArchiveHereAsync (cyclomatic 25) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:53— BaseDecompressArchiveAction.DecompressArchiveHereAsync has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 11 of the 25 points are its own statements and the rest belongs to 2 function items inside it that branch (GetFirstMeaningfulSegment, a function literal at line 93). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
ShellContextFlyoutFactory.LoadMenuFlyoutItemAsync (cyclomatic 25) src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs:118— ShellContextFlyoutFactory.LoadMenuFlyoutItemAsync has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LayoutPreferencesManager.SetLayoutPreferencesForPath (cyclomatic 25) src/Files.App/Helpers/Layout/LayoutPreferencesManager.cs:388— LayoutPreferencesManager.SetLayoutPreferencesForPath has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Toolbar.CreateToolbarElement (cyclomatic 25) src/Files.App/UserControls/Toolbar.xaml.cs:193— Toolbar.CreateToolbarElement has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Win32StorageEnumerator.ListEntries (cyclomatic 25) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:21— Win32StorageEnumerator.ListEntries has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.DeleteItemsAsync (cyclomatic 25) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:356— ShellFilesystemOperations.DeleteItemsAsync has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.MoveItemsAsync (cyclomatic 25) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:500— ShellFilesystemOperations.MoveItemsAsync has cyclomatic complexity 25 (threshold 15). Of this number, 19 points are the body's own statements and 6 belong to 4 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SidebarViewModel.HandleLocationItemDragOverAsync (cyclomatic 25) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1223— SidebarViewModel.HandleLocationItemDragOverAsync has cyclomatic complexity 25 (threshold 15). Of this number, 23 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationHelpers.OpenPath (cyclomatic 24) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:489— NavigationHelpers.OpenPath has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageHistoryOperations.Redo (cyclomatic 24) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:116— StorageHistoryOperations.Redo has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellViewModel.LoadGitPropertiesAsync (cyclomatic 24) src/Files.App/ViewModels/ShellViewModel.cs:1965— ShellViewModel.LoadGitPropertiesAsync has cyclomatic complexity 24 (threshold 15). Of this number, 15 points are the body's own statements and 9 belong to 2 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ExpandableSidebarItemBase.ResyncSubfoldersAsync (cyclomatic 23) src/Files.App/Data/Items/ExpandableSidebarItemBase.cs:199— ExpandableSidebarItemBase.ResyncSubfoldersAsync has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 9 of the 23 points are its own statements and the rest belongs to one function literal inside it that branches (line 231). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
NavigationHelpers.GetSelectedTabInfoAsync (cyclomatic 23) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:257— NavigationHelpers.GetSelectedTabInfoAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageHistoryOperations.Undo (cyclomatic 23) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:24— StorageHistoryOperations.Undo has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InfoPaneViewModel.GetBuiltInPreviewControlAsync (cyclomatic 23) src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:249— InfoPaneViewModel.GetBuiltInPreviewControlAsync has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ColumnLayoutPage.FileList_ItemTapped (cyclomatic 23) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:588— ColumnLayoutPage.FileList_ItemTapped has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WindowsRecentItemsService.UpdateRecentItems (cyclomatic 22) src/Files.App/Services/Windows/WindowsRecentItemsService.cs:188— WindowsRecentItemsService.UpdateRecentItems has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Win32StorageEnumerator.GetFile (cyclomatic 22) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:251— Win32StorageEnumerator.GetFile has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DetailsLayoutPage.FileList_ItemTapped (cyclomatic 22) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:652— DetailsLayoutPage.FileList_ItemTapped has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: DetailsLayoutPage.ResizeColumnToFit (cyclomatic 35) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
Win32Helper.GetIcon (cyclomatic 21) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:156— Win32Helper.GetIcon has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StatusBar.UpdateResponsiveState (cyclomatic 21) src/Files.App/UserControls/StatusBar.xaml.cs:132— StatusBar.UpdateResponsiveState has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FilesystemHelpers.GetDraggedStorageItems (cyclomatic 21) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:788— FilesystemHelpers.GetDraggedStorageItems has cyclomatic complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CreateShortcutDialogViewModel.ShortcutTarget.set (cyclomatic 21) src/Files.App/ViewModels/Dialogs/CreateShortcutDialogViewModel.cs:58— CreateShortcutDialogViewModel.ShortcutTarget.set has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BasePropertiesPage.OnNavigatedTo (cyclomatic 21) src/Files.App/ViewModels/Properties/BasePropertiesPage.cs:30— BasePropertiesPage.OnNavigatedTo has cyclomatic complexity 21 (threshold 15). Of this number, 14 points are the body's own statements and 7 belong to 4 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BaseLayoutPage.Item_DragOver (cyclomatic 21) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1096— BaseLayoutPage.Item_DragOver has cyclomatic complexity 21 (threshold 15). Of this number, 18 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged (cyclomatic 21) src/Files.App/Views/Shells/BaseShellPage.cs:706— BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CompressArchiveModel.RunCreationAsync (cyclomatic 20) src/Files.App/Data/Models/CompressArchiveModel.cs:155— CompressArchiveModel.RunCreationAsync has cyclomatic complexity 20 (threshold 15). Of this number, 14 points are the body's own statements and 6 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageFileExtensions.ResolvePath (cyclomatic 20) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:398— StorageFileExtensions.ResolvePath has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.RenameAsync (cyclomatic 20) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:660— ShellFilesystemOperations.RenameAsync has cyclomatic complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SidebarViewModel.CreateSectionAsync (cyclomatic 20) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:550— SidebarViewModel.CreateSectionAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BaseLayoutPage.FileListItem_PointerEntered (cyclomatic 20) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1468— BaseLayoutPage.FileListItem_PointerEntered has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 6 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 1484). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
RegistrySerializationGenerator.EmitBindValues (cyclomatic 19) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:81— RegistrySerializationGenerator.EmitBindValues has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table. This shape REPEATS in the file: one other method here (RegistrySerializationGenerator.EmitSaveValues) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
RegistrySerializationGenerator.EmitSaveValues (cyclomatic 19) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:245— RegistrySerializationGenerator.EmitSaveValues has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table. This shape REPEATS in the file: one other method here (RegistrySerializationGenerator.EmitBindValues) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
LibGit2Service.Checkout (cyclomatic 19) src/Files.App/Services/Git/LibGit2Service.cs:193— LibGit2Service.Checkout has cyclomatic complexity 19 (threshold 15). Of this number, 16 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationToolbar.Omnibar_QuerySubmitted (cyclomatic 19) src/Files.App/UserControls/NavigationToolbar.xaml.cs:181— NavigationToolbar.Omnibar_QuerySubmitted has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FileOperationsHelpers.UpdateFileTagsDb (cyclomatic 19) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:972— FileOperationsHelpers.UpdateFileTagsDb has cyclomatic complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemHelpers.DeleteItemsAsync (cyclomatic 19) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:86— FilesystemHelpers.DeleteItemsAsync has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemOperations.RenameAsync (cyclomatic 19) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:644— FilesystemOperations.RenameAsync has cyclomatic complexity 19 (threshold 15). Of this number, 17 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemOperations.RestoreFromTrashAsync (cyclomatic 19) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:797— FilesystemOperations.RestoreFromTrashAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.CreateAsync (cyclomatic 19) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:211— ShellFilesystemOperations.CreateAsync has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SidebarViewModel.SyncSidebarItemsAsync (cyclomatic 19) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:397— SidebarViewModel.SyncSidebarItemsAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GridLayoutPage.FileList_ItemTapped (cyclomatic 19) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:709— GridLayoutPage.FileList_ItemTapped has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageBar.UpdateColumnWidths (cyclomatic 18) src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:148— StorageBar.UpdateColumnWidths has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ThemedIcon.OnIconColorTypeChanged (cyclomatic 18) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:184— ThemedIcon.OnIconColorTypeChanged has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
FastContextFlyout.Flyout_Opened (cyclomatic 18) src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs:492— FastContextFlyout.Flyout_Opened has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransferHelpers.ExecuteTransferAsync (cyclomatic 18) src/Files.App/Helpers/TransferHelpers.cs:82— TransferHelpers.ExecuteTransferAsync has cyclomatic complexity 18 (threshold 15). Of this number, 11 points are the body's own statements and 7 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LibraryManager.UpdateLibrary (cyclomatic 18) src/Files.App/Utils/Library/LibraryManager.cs:172— LibraryManager.UpdateLibrary has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 8 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 178). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SortingHelper.OrderFileList (cyclomatic 18) src/Files.App/Utils/Storage/Collection/SortingHelper.cs:31— SortingHelper.OrderFileList has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemHelpers.GetCollisions (cyclomatic 18) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:696— FilesystemHelpers.GetCollisions has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ShellFilesystemOperations.RestoreItemsFromTrashAsync (cyclomatic 18) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:769— ShellFilesystemOperations.RestoreItemsFromTrashAsync has cyclomatic complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationToolbarViewModel.PathBoxItem_DragOver (cyclomatic 18) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:486— NavigationToolbarViewModel.PathBoxItem_DragOver has cyclomatic complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode (cyclomatic 18) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:1049— NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 3 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 1051). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
BaseLayoutPage.OnNavigatedTo (cyclomatic 18) src/Files.App/Views/Layouts/BaseLayoutPage.cs:507— BaseLayoutPage.OnNavigatedTo has cyclomatic complexity 18 (threshold 15). Of this number, 16 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GridLayoutPage.StartRenameItem (cyclomatic 18) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:426— GridLayoutPage.StartRenameItem has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SidebarItem.Item_PropertyChanged (cyclomatic 17) src/Files.App.Controls/Sidebar/SidebarItem.cs:207— SidebarItem.Item_PropertyChanged has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FlattenFolderAction.FlattenFolderCore (cyclomatic 17) src/Files.App/Actions/FileSystem/FlattenFolderAction.cs:88— FlattenFolderAction.FlattenFolderCore has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageArchiveService.DecompressAsyncWithSevenZip (cyclomatic 17) src/Files.App/Services/Storage/StorageArchiveService.cs:127— StorageArchiveService.DecompressAsyncWithSevenZip has cyclomatic complexity 17 (threshold 15). Of this number, 13 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
StorageArchiveService.DecompressAsyncWithSharpZipLib (cyclomatic 17) src/Files.App/Services/Storage/StorageArchiveService.cs:243— StorageArchiveService.DecompressAsyncWithSharpZipLib has cyclomatic complexity 17 (threshold 15). Of this number, 11 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
GitHelpers.GetGitInformationForItem (cyclomatic 17) src/Files.App/Utils/Git/GitHelpers.cs:522— GitHelpers.GetGitInformationForItem has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FilesystemOperations.CreateAsync (cyclomatic 17) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:32— FilesystemOperations.CreateAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FolderSearch.SearchTagsAsync (cyclomatic 17) src/Files.App/Utils/Storage/Search/FolderSearch.cs:410— FolderSearch.SearchTagsAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ActionsViewModel.ExecuteSaveCommand (cyclomatic 17) src/Files.App/ViewModels/Settings/ActionsViewModel.cs:213— ActionsViewModel.ExecuteSaveCommand has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SidebarViewModel.HandleItemInvokedAsync (cyclomatic 17) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:826— SidebarViewModel.HandleItemInvokedAsync has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: SidebarViewModel.GetLocationItemMenuItems (cyclomatic 18) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
LayoutCycler.Cycle (cyclomatic 16) src/Files.App/Actions/Display/LayoutAction.cs:357— LayoutCycler.Cycle has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WindowsJumpListService.AddFolder (cyclomatic 16) src/Files.App/Services/Windows/WindowsJumpListService.cs:132— WindowsJumpListService.AddFolder has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContextMenu.EnumMenuItems (cyclomatic 16) src/Files.App/Utils/Shell/ContextMenu.cs:237— ContextMenu.EnumMenuItems has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StatusCenterItemProgressModel.Report (cyclomatic 16) src/Files.App/Utils/StatusCenter/StatusCenterItemProgressModel.cs:155— StatusCenterItemProgressModel.Report has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageFileExtensions.DangerousGetFolderWithPathFromPathAsync (cyclomatic 16) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:271— StorageFileExtensions.DangerousGetFolderWithPathFromPathAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
FileOperationsHelpers.MoveItemAsync (cyclomatic 16) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:396— FileOperationsHelpers.MoveItemAsync has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 427, 482, 471, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest. This shape REPEATS in the file: one other method here (FileOperationsHelpers.CopyItemAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FileOperationsHelpers.CopyItemAsync (cyclomatic 16) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:534— FileOperationsHelpers.CopyItemAsync has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 565, 623, 612, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest. This shape REPEATS in the file: one other method here (FileOperationsHelpers.MoveItemAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FileProperties.GetBaseProperties (cyclomatic 16) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:29— FileProperties.GetBaseProperties has cyclomatic complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShellViewModel.SetWorkingDirectoryAsync (cyclomatic 16) src/Files.App/ViewModels/ShellViewModel.cs:228— ShellViewModel.SetWorkingDirectoryAsync has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This is NOT this file's highest cyclomatic complexity: ShellViewModel.UserSettingsService_OnSettingChangedEvent (cyclomatic 22) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
InfoPaneViewModel.UpdateSelectedItemPreviewAsync (cyclomatic 16) src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:391— InfoPaneViewModel.UpdateSelectedItemPreviewAsync has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BaseLayoutPage.SetSelectedItemsOnNavigation (cyclomatic 16) src/Files.App/Views/Layouts/BaseLayoutPage.cs:825— BaseLayoutPage.SetSelectedItemsOnNavigation has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Repeated repair: src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs:38— src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is FilePropertiesHelpers.OpenPropertiesWindow at line 38), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix: Fixed shell path normalization and window close races (#18890)”; “Code Quality: Fix property page crashing on open (#18827)”; “Code Quality: Fixed a crash when opening a Properties window from a destroyed cached window”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-23..2026-10-21, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-23 17:52:18 -04:00' --until='2026-10-21 17:52:18 -04:00' --full-history --no-merges -- src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
HackComment src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:262— // HACK: If file is dragged from zip file in windows explorer for example. The file path is empty and — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
BarePragmaDisable src/Files.Storage/Legacy/RecycleBinWatcher.cs:21— #pragma warning disable CS0067 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
FilesystemOperations.MoveAsync (cognitive 103) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:334— FilesystemOperations.MoveAsync has cognitive complexity 103 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
LaunchHelper.HandleApplicationLaunch (cognitive 102) REDACTED:56— LaunchHelper.HandleApplicationLaunch has cognitive complexity 102 (threshold 15). Of this number, 62 points are the body's own statements and 40 belong to 3 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FilesystemOperations.CopyAsync (cognitive 97) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:130— FilesystemOperations.CopyAsync has cognitive complexity 97 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellViewModel.LoadExtendedItemPropertiesAsync (cognitive 89) src/Files.App/ViewModels/ShellViewModel.cs:1672— ShellViewModel.LoadExtendedItemPropertiesAsync has cognitive complexity 89 (threshold 15). Of this number, 65 points are the body's own statements and 24 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UniversalStorageEnumerator.ListEntries (cognitive 88) src/Files.App/Utils/Storage/Enumerators/UniversalStorageEnumerator.cs:19— UniversalStorageEnumerator.ListEntries has cognitive complexity 88 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NavigationHelpers.OpenFile (cognitive 82) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:668— NavigationHelpers.OpenFile has cognitive complexity 82 (threshold 15). Of this number, 18 points are the body's own statements and 64 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellViewModel.ProcessOperationQueueAsync (cognitive 72) src/Files.App/ViewModels/ShellViewModel.cs:3046— ShellViewModel.ProcessOperationQueueAsync has cognitive complexity 72 (threshold 15). Of this number, 66 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CssPreviewRenderer.Render (cognitive 71) src/Files.App/UserControls/FilePreviews/CssPreviewRenderer.cs:13— CssPreviewRenderer.Render has cognitive complexity 71 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationToolbarViewModel.CheckPathInputAsync (cognitive 63) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:900— NavigationToolbarViewModel.CheckPathInputAsync has cognitive complexity 63 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
StatusCenterHelper.UpdateCardStrings (cognitive 62) src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs:593— StatusCenterHelper.UpdateCardStrings has cognitive complexity 62 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellViewModel.EnumerateItemsFromStandardFolderAsync (cognitive 59) src/Files.App/ViewModels/ShellViewModel.cs:2279— ShellViewModel.EnumerateItemsFromStandardFolderAsync has cognitive complexity 59 (threshold 15). Of this number, 54 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MainWindow.InitializeApplicationAsync (cognitive 58) src/Files.App/MainWindow.xaml.cs:95— MainWindow.InitializeApplicationAsync has cognitive complexity 58 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Win32StorageEnumerator.ListEntries (cognitive 58) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:21— Win32StorageEnumerator.ListEntries has cognitive complexity 58 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Program.Main (cognitive 52) src/Files.App/Program.cs:48— Program.Main has cognitive complexity 52 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DetailsLayoutPage.FileList_PreviewKeyDown (cognitive 52) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:527— DetailsLayoutPage.FileList_PreviewKeyDown has cognitive complexity 52 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MainPageViewModel.OnNavigatedToAsync (cognitive 51) src/Files.App/ViewModels/MainPageViewModel.cs:240— MainPageViewModel.OnNavigatedToAsync has cognitive complexity 51 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NavigationToolbarViewModel.HandleItemNavigationAsync (cognitive 51) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:598— NavigationToolbarViewModel.HandleItemNavigationAsync has cognitive complexity 51 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BaseDecompressArchiveAction.DecompressArchiveHereAsync (cognitive 50) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:53— BaseDecompressArchiveAction.DecompressArchiveHereAsync has cognitive complexity 50 (threshold 15). Of this number, 19 points are the body's own statements and 31 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellViewModel.LoadThumbnailAsync (cognitive 49) src/Files.App/ViewModels/ShellViewModel.cs:1442— ShellViewModel.LoadThumbnailAsync has cognitive complexity 49 (threshold 15). Of this number, 19 points are the body's own statements and 30 belong to 5 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellFilesystemOperations.DeleteItemsAsync (cognitive 47) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:356— ShellFilesystemOperations.DeleteItemsAsync has cognitive complexity 47 (threshold 15). Of this number, 46 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentPageContextFlyoutFactory.GetBaseItemMenuItems (cognitive 45) src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs:81— ContentPageContextFlyoutFactory.GetBaseItemMenuItems has cognitive complexity 45 (threshold 15). Of this number, 35 points are the body's own statements and 10 belong to 4 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
FilesystemHelpers.GetDraggedStorageItems (cognitive 45) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:788— FilesystemHelpers.GetDraggedStorageItems has cognitive complexity 45 (threshold 15). Of this number, 44 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FolderSearch.SearchWithWin32 (cognitive 45) src/Files.App/Utils/Storage/Search/FolderSearch.cs:550— FolderSearch.SearchWithWin32 has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Win32Helper.GetIcon (cognitive 42) src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:156— Win32Helper.GetIcon has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MainWindow.InitializeFromCmdLineArgsAsync (cognitive 42) src/Files.App/MainWindow.xaml.cs:323— MainWindow.InitializeFromCmdLineArgsAsync has cognitive complexity 42 (threshold 15). Of this number, 40 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertiesNavigationItemsFactory.Initialize (cognitive 41) src/Files.App/Data/Factories/PropertiesNavigationItemsFactory.cs:15— PropertiesNavigationItemsFactory.Initialize has cognitive complexity 41 (threshold 15). Of this number, 38 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CompressArchiveModel.RunCreationAsync (cognitive 40) src/Files.App/Data/Models/CompressArchiveModel.cs:155— CompressArchiveModel.RunCreationAsync has cognitive complexity 40 (threshold 15). Of this number, 24 points are the body's own statements and 16 belong to 2 function items inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContextMenu.EnumMenuItems (cognitive 40) src/Files.App/Utils/Shell/ContextMenu.cs:237— ContextMenu.EnumMenuItems has cognitive complexity 40 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Toolbar.CreateToolbarElement (cognitive 39) src/Files.App/UserControls/Toolbar.xaml.cs:193— Toolbar.CreateToolbarElement has cognitive complexity 39 (threshold 15). Of this number, 35 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LayoutPreferencesManager.SetLayoutPreferencesForPath (cognitive 38) src/Files.App/Helpers/Layout/LayoutPreferencesManager.cs:388— LayoutPreferencesManager.SetLayoutPreferencesForPath has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Win32StorageEnumerator.GetFile (cognitive 38) src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs:251— Win32StorageEnumerator.GetFile has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLayoutViewModel.DragOverAsync (cognitive 37) src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs:105— BaseLayoutViewModel.DragOverAsync has cognitive complexity 37 (threshold 15). Of this number, 36 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DetailsLayoutPage.FileList_ItemTapped (cognitive 36) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:652— DetailsLayoutPage.FileList_ItemTapped has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
StorageBar.UpdateColumnWidths (cognitive 35) src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:148— StorageBar.UpdateColumnWidths has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellContextFlyoutFactory.LoadMenuFlyoutItemAsync (cognitive 35) src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs:118— ShellContextFlyoutFactory.LoadMenuFlyoutItemAsync has cognitive complexity 35 (threshold 15). Of this number, 30 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CreateShortcutDialogViewModel.ShortcutTarget.set (cognitive 35) src/Files.App/ViewModels/Dialogs/CreateShortcutDialogViewModel.cs:58— CreateShortcutDialogViewModel.ShortcutTarget.set has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationHelpers.GetSelectedTabInfoAsync (cognitive 34) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:257— NavigationHelpers.GetSelectedTabInfoAsync has cognitive complexity 34 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SidebarViewModel.SyncSidebarItemsAsync (cognitive 34) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:397— SidebarViewModel.SyncSidebarItemsAsync has cognitive complexity 34 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
GridLayoutPage.FileList_ItemTapped (cognitive 34) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:709— GridLayoutPage.FileList_ItemTapped has cognitive complexity 34 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
WindowsRecentItemsService.UpdateRecentItems (cognitive 33) src/Files.App/Services/Windows/WindowsRecentItemsService.cs:188— WindowsRecentItemsService.UpdateRecentItems has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationToolbar.Omnibar_QuerySubmitted (cognitive 33) src/Files.App/UserControls/NavigationToolbar.xaml.cs:181— NavigationToolbar.Omnibar_QuerySubmitted has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileOperationsHelpers.UpdateFileTagsDb (cognitive 33) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:972— FileOperationsHelpers.UpdateFileTagsDb has cognitive complexity 33 (threshold 15). Of this number, 25 points are the body's own statements and 8 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FileSizeCalculator.ComputeSizeAsync (cognitive 33) src/Files.App/Utils/Storage/Operations/FileSizeCalculator.cs:28— FileSizeCalculator.ComputeSizeAsync has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellFilesystemOperations.MoveItemsAsync (cognitive 33) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:500— ShellFilesystemOperations.MoveItemsAsync has cognitive complexity 33 (threshold 15). Of this number, 27 points are the body's own statements and 6 belong to 4 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CommandLineParser.Parse (cognitive 32) src/Files.App/Utils/CommandLine/CommandLineParser.cs:132— CommandLineParser.Parse has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FilesystemOperations.CreateAsync (cognitive 32) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:32— FilesystemOperations.CreateAsync has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellFilesystemOperations.CopyItemsAsync (cognitive 32) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:46— ShellFilesystemOperations.CopyItemsAsync has cognitive complexity 32 (threshold 15). Of this number, 27 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode (cognitive 32) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:1049— NavigationToolbarViewModel.PopulateOmnibarSuggestionsForPathMode has cognitive complexity 32 (threshold 15). Most of this is not in the body itself: 2 of the 32 points are its own statements and the rest belongs to one function literal inside it that branches (line 1051). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
CloudDrivesDetector.DetectGenericCloudDrive (cognitive 31) src/Files.App.Server/Cloud/CloudDrivesDetector.cs:57— CloudDrivesDetector.DetectGenericCloudDrive has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationHelpers.OpenPath (cognitive 31) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:489— NavigationHelpers.OpenPath has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageHelpers.ToStorageItem (cognitive 31) src/Files.App/Utils/Storage/Helpers/StorageHelpers.cs:23— StorageHelpers.ToStorageItem has cognitive complexity 31 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ColumnLayoutPage.FileList_ItemTapped (cognitive 31) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:588— ColumnLayoutPage.FileList_ItemTapped has cognitive complexity 31 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FilesystemHelpers.GetCollisions (cognitive 30) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:696— FilesystemHelpers.GetCollisions has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ColumnLayoutPage.FileList_PreviewKeyDown (cognitive 30) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:449— ColumnLayoutPage.FileList_PreviewKeyDown has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GridLayoutPage.FileList_PreviewKeyDown (cognitive 30) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:590— GridLayoutPage.FileList_PreviewKeyDown has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged (cognitive 30) src/Files.App/Views/Shells/BaseShellPage.cs:706— BaseShellPage.FilesystemViewModel_ItemLoadStatusChanged has cognitive complexity 30 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
StorageFileExtensions.ResolvePath (cognitive 29) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:398— StorageFileExtensions.ResolvePath has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FilesystemHelpers.DeleteItemsAsync (cognitive 29) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:86— FilesystemHelpers.DeleteItemsAsync has cognitive complexity 29 (threshold 15). Of this number, 28 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FolderSearch.SearchTagsAsync (cognitive 29) src/Files.App/Utils/Storage/Search/FolderSearch.cs:410— FolderSearch.SearchTagsAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExpandableSidebarItemBase.ResyncSubfoldersAsync (cognitive 28) src/Files.App/Data/Items/ExpandableSidebarItemBase.cs:199— ExpandableSidebarItemBase.ResyncSubfoldersAsync has cognitive complexity 28 (threshold 15). Most of this is not in the body itself: 8 of the 28 points are its own statements and the rest belongs to one function literal inside it that branches (line 231). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
StorageHistoryOperations.Undo (cognitive 28) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:24— StorageHistoryOperations.Undo has cognitive complexity 28 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ShellFilesystemOperations.RenameAsync (cognitive 28) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:660— ShellFilesystemOperations.RenameAsync has cognitive complexity 28 (threshold 15). Of this number, 24 points are the body's own statements and 4 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SidebarViewModel.AddElementToSectionAsync (cognitive 28) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:469— SidebarViewModel.AddElementToSectionAsync has cognitive complexity 28 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SidebarViewModel.HandleLocationItemDragOverAsync (cognitive 28) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:1223— SidebarViewModel.HandleLocationItemDragOverAsync has cognitive complexity 28 (threshold 15). Of this number, 26 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GeneralPage.SaveChangesAsync (cognitive 28) src/Files.App/Views/Properties/GeneralPage.xaml.cs:91— GeneralPage.SaveChangesAsync has cognitive complexity 28 (threshold 15). Of this number, 24 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LibraryManager.UpdateLibrary (cognitive 27) src/Files.App/Utils/Library/LibraryManager.cs:172— LibraryManager.UpdateLibrary has cognitive complexity 27 (threshold 15). Most of this is not in the body itself: 7 of the 27 points are its own statements and the rest belongs to one function literal inside it that branches (line 178). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
FilesystemOperations.RestoreFromTrashAsync (cognitive 27) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:797— FilesystemOperations.RestoreFromTrashAsync has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellFilesystemOperations.CreateAsync (cognitive 27) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:211— ShellFilesystemOperations.CreateAsync has cognitive complexity 27 (threshold 15). Of this number, 26 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLayoutPage.OnNavigatedTo (cognitive 27) src/Files.App/Views/Layouts/BaseLayoutPage.cs:507— BaseLayoutPage.OnNavigatedTo has cognitive complexity 27 (threshold 15). Of this number, 25 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLayoutPage.Item_DragOver (cognitive 27) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1096— BaseLayoutPage.Item_DragOver has cognitive complexity 27 (threshold 15). Of this number, 22 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CachedSizeProvider.UpdateAsync (cognitive 26) src/Files.App/Services/SizeProvider/CachedSizeProvider.cs:25— CachedSizeProvider.UpdateAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StatusCenterItem.ReportProgress (cognitive 26) src/Files.App/Utils/StatusCenter/StatusCenterItem.cs:289— StatusCenterItem.ReportProgress has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageHistoryOperations.Redo (cognitive 26) src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:116— StorageHistoryOperations.Redo has cognitive complexity 26 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
FilesystemOperations.RenameAsync (cognitive 26) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:644— FilesystemOperations.RenameAsync has cognitive complexity 26 (threshold 15). Of this number, 21 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InfoPaneViewModel.UpdateSelectedItemPreviewAsync (cognitive 26) src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:391— InfoPaneViewModel.UpdateSelectedItemPreviewAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppLifecycleHelper.ConfigureSentry (cognitive 25) src/Files.App/Helpers/Application/AppLifecycleHelper.cs:214— AppLifecycleHelper.ConfigureSentry has cognitive complexity 25 (threshold 15). None of this is in the body itself: all 25 points belong to 4 function literals inside it that branch (lines 233, 267, 216, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
PowerToysPeekProvider.FindPeekPathFromRegistry (cognitive 25) src/Files.App/Services/PreviewPopupProviders/PowerToysPeekProvider.cs:62— PowerToysPeekProvider.FindPeekPathFromRegistry has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WindowsJumpListService.AddFolder (cognitive 25) src/Files.App/Services/Windows/WindowsJumpListService.cs:132— WindowsJumpListService.AddFolder has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StatusBar.UpdateResponsiveState (cognitive 25) src/Files.App/UserControls/StatusBar.xaml.cs:132— StatusBar.UpdateResponsiveState has cognitive complexity 25 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
FilesystemOperations.DeleteAsync (cognitive 25) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:541— FilesystemOperations.DeleteAsync has cognitive complexity 25 (threshold 15). Of this number, 19 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FolderSearch.ParseTagQuery (cognitive 25) src/Files.App/Utils/Storage/Search/FolderSearch.cs:322— FolderSearch.ParseTagQuery has cognitive complexity 25 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
CombinedFileProperties.SyncPropertyChangesAsync (cognitive 25) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:88— CombinedFileProperties.SyncPropertyChangesAsync has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FlattenFolderAction.FlattenFolderCore (cognitive 24) src/Files.App/Actions/FileSystem/FlattenFolderAction.cs:88— FlattenFolderAction.FlattenFolderCore has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LayoutHelpers.UpdateOpenTabsPreferences (cognitive 24) src/Files.App/Helpers/Layout/LayoutHelpers.cs:8— LayoutHelpers.UpdateOpenTabsPreferences has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransferHelpers.ExecuteTransferAsync (cognitive 24) src/Files.App/Helpers/TransferHelpers.cs:82— TransferHelpers.ExecuteTransferAsync has cognitive complexity 24 (threshold 15). Of this number, 12 points are the body's own statements and 12 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DigitalSignaturesUtil.ParseDERFindType (cognitive 24) src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:516— DigitalSignaturesUtil.ParseDERFindType has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellFilesystemOperations.RestoreItemsFromTrashAsync (cognitive 24) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:769— ShellFilesystemOperations.RestoreItemsFromTrashAsync has cognitive complexity 24 (threshold 15). Of this number, 19 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CombinedProperties.GetSpecialPropertiesAsync (cognitive 24) src/Files.App/ViewModels/Properties/Items/CombinedProperties.cs:54— CombinedProperties.GetSpecialPropertiesAsync has cognitive complexity 24 (threshold 15). Of this number, 21 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GridLayoutPage.StartRenameItem (cognitive 24) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:426— GridLayoutPage.StartRenameItem has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LayoutCycler.Cycle (cognitive 23) src/Files.App/Actions/Display/LayoutAction.cs:357— LayoutCycler.Cycle has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShareItemHelpers.ShareItemsAsync (cognitive 23) src/Files.App/Helpers/ShareItemHelpers.cs:18— ShareItemHelpers.ShareItemsAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Win32Helper.GetShellFolderAsync (cognitive 23) src/Files.App/Helpers/Win32/Win32Helper.Shell.cs:17— Win32Helper.GetShellFolderAsync has cognitive complexity 23 (threshold 15). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to one function literal inside it that branches (line 24). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
RectangleSelection_ListViewBase.RectangleSelection_PointerMoved (cognitive 23) src/Files.App/UserControls/Selection/RectangleSelection_ListViewBase.cs:38— RectangleSelection_ListViewBase.RectangleSelection_PointerMoved has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DriveHelpers.GetRootFromPathAsync (cognitive 23) src/Files.App/Utils/Storage/Helpers/DriveHelpers.cs:41— DriveHelpers.GetRootFromPathAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FilesystemHelpers.MoveItemsAsync (cognitive 23) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:447— FilesystemHelpers.MoveItemsAsync has cognitive complexity 23 (threshold 15). Of this number, 21 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CombinedFileProperties.ClearPropertiesAsync (cognitive 23) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:141— CombinedFileProperties.ClearPropertiesAsync has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ActionsViewModel.ExecuteSaveCommand (cognitive 23) src/Files.App/ViewModels/Settings/ActionsViewModel.cs:213— ActionsViewModel.ExecuteSaveCommand has cognitive complexity 23 (threshold 15). Of this number, 22 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InfoPaneViewModel.GetBuiltInPreviewControlAsync (cognitive 23) src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:249— InfoPaneViewModel.GetBuiltInPreviewControlAsync has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
BaseLayoutPage.FileListItem_PointerEntered (cognitive 23) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1468— BaseLayoutPage.FileListItem_PointerEntered has cognitive complexity 23 (threshold 15). Most of this is not in the body itself: 5 of the 23 points are its own statements and the rest belongs to one function literal inside it that branches (line 1484). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
AppLifecycleHelper.HandleAppUnhandledException (cognitive 22) src/Files.App/Helpers/Application/AppLifecycleHelper.cs:502— AppLifecycleHelper.HandleAppUnhandledException has cognitive complexity 22 (threshold 15). Of this number, 14 points are the body's own statements and 8 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FastContextFlyout.AddShellModels (cognitive 22) src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs:229— FastContextFlyout.AddShellModels has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageArchiveService.DecompressAsyncWithSharpZipLib (cognitive 22) src/Files.App/Services/Storage/StorageArchiveService.cs:243— StorageArchiveService.DecompressAsyncWithSharpZipLib has cognitive complexity 22 (threshold 15). Of this number, 12 points are the body's own statements and 10 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WindowsRecentItemsService.GetChangedActionEventArgs (cognitive 22) src/Files.App/Services/Windows/WindowsRecentItemsService.cs:312— WindowsRecentItemsService.GetChangedActionEventArgs has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FilesystemHelpers.CopyItemsAsync (cognitive 22) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:304— FilesystemHelpers.CopyItemsAsync has cognitive complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellItemPropertyStore.TryGetValue (cognitive 21) src/Files.Storage/Windows/Shell/ShellItem.cs:574— ShellItemPropertyStore.TryGetValue has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GridSplitter.VerticalMove (cognitive 21) src/Files.App.Controls/GridSplitter/GridSplitter.Events.cs:191— GridSplitter.VerticalMove has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (GridSplitter.HorizontalMove) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
GridSplitter.HorizontalMove (cognitive 21) src/Files.App.Controls/GridSplitter/GridSplitter.Events.cs:258— GridSplitter.HorizontalMove has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (GridSplitter.VerticalMove) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Omnibar.AutoSuggestBox_KeyDown (cognitive 21) src/Files.App.Controls/Omnibar/Omnibar.Events.cs:90— Omnibar.AutoSuggestBox_KeyDown has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageRing.UpdateRingAngles (cognitive 21) src/Files.App.Controls/Storage/StorageRing/StorageRing.cs:272— StorageRing.UpdateRingAngles has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CloudDrivesDetector.DetectSharepoint (cognitive 21) src/Files.App.Server/Cloud/CloudDrivesDetector.cs:176— CloudDrivesDetector.DetectSharepoint has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DropBoxCloudDetector.GetProviders (cognitive 21) src/Files.App.Server/Cloud/DropBoxCloudDetector.cs:15— DropBoxCloudDetector.GetProviders has cognitive complexity 21 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
CommandManager.OverwriteKeyBindings (cognitive 21) src/Files.App/Data/Commands/Manager/CommandManager.cs:47— CommandManager.OverwriteKeyBindings has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationHelpers.UpdateTabInfoAsync (cognitive 21) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:117— NavigationHelpers.UpdateTabInfoAsync has cognitive complexity 21 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
LibGit2Service.Checkout (cognitive 21) src/Files.App/Services/Git/LibGit2Service.cs:193— LibGit2Service.Checkout has cognitive complexity 21 (threshold 15). Of this number, 17 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationToolbar.AddHistoryItemsAsync (cognitive 21) src/Files.App/UserControls/NavigationToolbar.xaml.cs:105— NavigationToolbar.AddHistoryItemsAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DigitalSignaturesUtil.GetSignerCertificateInfo (cognitive 21) src/Files.App/Utils/Signatures/DigitalSignaturesUtil.cs:209— DigitalSignaturesUtil.GetSignerCertificateInfo has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FolderProperties.GetSpecialPropertiesAsync (cognitive 21) src/Files.App/ViewModels/Properties/Items/FolderProperties.cs:72— FolderProperties.GetSpecialPropertiesAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellViewModel.LoadGitPropertiesAsync (cognitive 21) src/Files.App/ViewModels/ShellViewModel.cs:1965— ShellViewModel.LoadGitPropertiesAsync has cognitive complexity 21 (threshold 15). Of this number, 16 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
ShellViewModel.UpdateFilesOrFoldersAsync (cognitive 21) src/Files.App/ViewModels/ShellViewModel.cs:3303— ShellViewModel.UpdateFilesOrFoldersAsync has cognitive complexity 21 (threshold 15). Most of this is not in the body itself: 8 of the 21 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 3353, 3325). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SidebarViewModel.HandleItemInvokedAsync (cognitive 21) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:826— SidebarViewModel.HandleItemInvokedAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileLogger.ProcessLogQueueAsync (cognitive 20) src/Files.Shared/Utils/Logger/FileLogger.cs:66— FileLogger.ProcessLogQueueAsync has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
AppThemeResourcesHelper.LoadAppResources (cognitive 20) src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs:13— AppThemeResourcesHelper.LoadAppResources has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
StorageArchiveService.DecompressAsyncWithSevenZip (cognitive 20) src/Files.App/Services/Storage/StorageArchiveService.cs:127— StorageArchiveService.DecompressAsyncWithSevenZip has cognitive complexity 20 (threshold 15). Of this number, 16 points are the body's own statements and 4 belong to 3 function literals inside it that branch. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
FolderSearch.SearchAsync (cognitive 20) src/Files.App/Utils/Storage/Search/FolderSearch.cs:203— FolderSearch.SearchAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZipStorageFolder.GetItemsAsync (cognitive 20) src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:345— ZipStorageFolder.GetItemsAsync has cognitive complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to one function literal inside it that branches (line 350). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
BasePropertiesPage.OnNavigatedTo (cognitive 20) src/Files.App/ViewModels/Properties/BasePropertiesPage.cs:30— BasePropertiesPage.OnNavigatedTo has cognitive complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 4 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
BaseProperties.CalculateFolderSizeAsync (cognitive 20) src/Files.App/ViewModels/Properties/Items/BaseProperties.cs:70— BaseProperties.CalculateFolderSizeAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellViewModel.ApplyCachedThumbnailOrPreloadedIconAsync (cognitive 20) src/Files.App/ViewModels/ShellViewModel.cs:1394— ShellViewModel.ApplyCachedThumbnailOrPreloadedIconAsync has cognitive complexity 20 (threshold 15). Of this number, 10 points are the body's own statements and 10 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
NavigationToolbarViewModel.PathBoxItem_DragOver (cognitive 20) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:486— NavigationToolbarViewModel.PathBoxItem_DragOver has cognitive complexity 20 (threshold 15). Of this number, 15 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SidebarViewModel.CreateSectionAsync (cognitive 20) src/Files.App/ViewModels/UserControls/SidebarViewModel.cs:550— SidebarViewModel.CreateSectionAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellPanesPage.SetShadow (cognitive 20) src/Files.App/Views/ShellPanesPage.xaml.cs:606— ShellPanesPage.SetShadow has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HotKey.Parse (cognitive 19) src/Files.App/Data/Commands/HotKey/HotKey.cs:279— HotKey.Parse has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FastContextFlyout.Flyout_Opened (cognitive 19) src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs:492— FastContextFlyout.Flyout_Opened has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageSecurityService.GetAcl (cognitive 19) src/Files.App/Services/Storage/StorageSecurityService.cs:96— StorageSecurityService.GetAcl has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileOperationsHelpers.MoveItemAsync (cognitive 19) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:396— FileOperationsHelpers.MoveItemAsync has cognitive complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 4 function literals inside it that branch (lines 427, 482, 471, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest. This shape REPEATS in the file: one other method here (FileOperationsHelpers.CopyItemAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FileOperationsHelpers.CopyItemAsync (cognitive 19) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:534— FileOperationsHelpers.CopyItemAsync has cognitive complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 4 function literals inside it that branch (lines 565, 623, 612, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest. This shape REPEATS in the file: one other method here (FileOperationsHelpers.MoveItemAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
FolderSearch.MatchesTagExpression (cognitive 19) src/Files.App/Utils/Storage/Search/FolderSearch.cs:373— FolderSearch.MatchesTagExpression has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActionsViewModel.ExecuteDeleteCommand (cognitive 19) src/Files.App/ViewModels/Settings/ActionsViewModel.cs:289— ActionsViewModel.ExecuteDeleteCommand has cognitive complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageRing.UpdateRingStrokes (cognitive 18) src/Files.App.Controls/Storage/StorageRing/StorageRing.cs:392— StorageRing.UpdateRingStrokes has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ThemedIcon.OnIconTypeChanged (cognitive 18) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:126— ThemedIcon.OnIconTypeChanged has cognitive complexity 18 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
ThemedIcon.OnIconColorTypeChanged (cognitive 18) src/Files.App.Controls/ThemedIcon/ThemedIcon.cs:184— ThemedIcon.OnIconColorTypeChanged has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DriveItem.UpdatePropertiesAsync (cognitive 18) src/Files.App/Data/Items/DriveItem.cs:281— DriveItem.UpdatePropertiesAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NavigationHelpers.OpenDirectory (cognitive 18) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:612— NavigationHelpers.OpenDirectory has cognitive complexity 18 (threshold 15). Of this number, 13 points are the body's own statements and 5 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Toolbar.PopulateToolbarItems (cognitive 18) src/Files.App/UserControls/Toolbar.xaml.cs:137— Toolbar.PopulateToolbarItems has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileTagsHelper.UpdateTagsDb (cognitive 18) src/Files.App/Utils/FileTags/FileTagsHelper.cs:86— FileTagsHelper.UpdateTagsDb has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GitHelpers.RequireGitAuthenticationAsync (cognitive 18) src/Files.App/Utils/Git/GitHelpers.cs:399— GitHelpers.RequireGitAuthenticationAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SortingHelper.OrderFileList (cognitive 18) src/Files.App/Utils/Storage/Collection/SortingHelper.cs:31— SortingHelper.OrderFileList has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileThumbnailHelper.GetIconAsync (cognitive 18) src/Files.App/Utils/Storage/Helpers/FileThumbnailHelper.cs:18— FileThumbnailHelper.GetIconAsync has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellPanesPage.ArrangePanes (cognitive 18) src/Files.App/Views/ShellPanesPage.xaml.cs:325— ShellPanesPage.ArrangePanes has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JsonParser.ProcessJsonObject (cognitive 17) src/Files.Core.SourceGenerator/Parser/JsonParser.cs:27— JsonParser.ProcessJsonObject has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GoogleDriveCloudDetector.GetProviders (cognitive 17) src/Files.App.Server/Cloud/GoogleDriveCloudDetector.cs:24— GoogleDriveCloudDetector.GetProviders has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CachedTask.GetAsync (cognitive 17) src/Files.App.Server/Initialization/CachedTask.cs:13— CachedTask.GetAsync has cognitive complexity 17 (threshold 15). Of this number, 14 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AppMemoryHelper.EnsureWorker (cognitive 17) src/Files.App/Helpers/Application/AppMemoryHelper.cs:40— AppMemoryHelper.EnsureWorker has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to one function literal inside it that branches (line 45). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
NaturalComparer.CompareWithoutExtension (cognitive 17) src/Files.App/Helpers/NaturalStringComparer.cs:88— NaturalComparer.CompareWithoutExtension has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LibGit2Service.FetchOriginAsync (cognitive 17) src/Files.App/Services/Git/LibGit2Service.cs:388— LibGit2Service.FetchOriginAsync has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 7 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 410, 487). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
SeerProProvider.DetectTrackSelectionSetting (cognitive 17) src/Files.App/Services/PreviewPopupProviders/SeerProProvider.cs:87— SeerProProvider.DetectTrackSelectionSetting has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageTrashBinService.RestoreAllTrashesInternal (cognitive 17) src/Files.App/Services/Storage/StorageTrashBinService.cs:154— StorageTrashBinService.RestoreAllTrashesInternal has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
KeyboardShortcut.OnHotKeysChanged (cognitive 17) src/Files.App/UserControls/KeyboardShortcut/KeyboardShortcut.cs:26— KeyboardShortcut.OnHotKeysChanged has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellFolderExtensions.GetShellFileItem (cognitive 17) src/Files.App/Utils/Shell/ShellFolderExtensions.cs:44— ShellFolderExtensions.GetShellFileItem has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
StatusCenterItemProgressModel.Report (cognitive 17) src/Files.App/Utils/StatusCenter/StatusCenterItemProgressModel.cs:155— StatusCenterItemProgressModel.Report has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BulkConcurrentObservableCollection.AddItemsToGroup (cognitive 17) src/Files.App/Utils/Storage/Collection/BulkConcurrentObservableCollection.cs:165— BulkConcurrentObservableCollection.AddItemsToGroup has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FolderHelpers.EnumerateSubfolders (cognitive 17) src/Files.App/Utils/Storage/Helpers/FolderHelpers.cs:61— FolderHelpers.EnumerateSubfolders has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageFileExtensions.DangerousGetFolderWithPathFromPathAsync (cognitive 17) src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs:271— StorageFileExtensions.DangerousGetFolderWithPathFromPathAsync has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
FileProperties.SyncPropertyChangesAsync (cognitive 17) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:208— FileProperties.SyncPropertyChangesAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLayoutPage.LoadVisibleItemsAfterScrollSettled (cognitive 17) src/Files.App/Views/Layouts/BaseLayoutPage.cs:1284— BaseLayoutPage.LoadVisibleItemsAfterScrollSettled has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ColumnLayoutPage.FileList_DoubleTapped (cognitive 17) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:533— ColumnLayoutPage.FileList_DoubleTapped has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LibraryPage.SaveChangesAsync (cognitive 17) src/Files.App/Views/Properties/LibraryPage.xaml.cs:170— LibraryPage.SaveChangesAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellPanesPage.RemovePane (cognitive 17) src/Files.App/Views/ShellPanesPage.xaml.cs:542— ShellPanesPage.RemovePane has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RegistrySerializationGenerator.EmitBindValues (cognitive 16) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:81— RegistrySerializationGenerator.EmitBindValues has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RegistrySerializationGenerator.EmitSaveValues) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
RegistrySerializationGenerator.EmitSaveValues (cognitive 16) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:245— RegistrySerializationGenerator.EmitSaveValues has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RegistrySerializationGenerator.EmitBindValues) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
WindowsStorableHelpers.TryConvertGpBitmapToByteArray (cognitive 16) src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Icon.cs:148— WindowsStorableHelpers.TryConvertGpBitmapToByteArray has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
MiddleClickScrollController.ScrollTimer_Tick (cognitive 16) src/Files.App/Extensions/ScrollViewerMiddleClickExtensions.cs:300— MiddleClickScrollController.ScrollTimer_Tick has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LayoutPreferencesDatabase.FindPreferences (cognitive 16) src/Files.App/Helpers/Layout/LayoutPreferencesDatabase.cs:138— LayoutPreferencesDatabase.FindPreferences has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContextFlyoutModelToElementHelper.GetItem (cognitive 16) src/Files.App/Helpers/MenuFlyout/ContextFlyoutModelToElementHelper.cs:112— ContextFlyoutModelToElementHelper.GetItem has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
NavigationHelpers.RefreshTabPathHints (cognitive 16) src/Files.App/Helpers/Navigation/NavigationHelpers.cs:166— NavigationHelpers.RefreshTabPathHints has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
UIFilesystemHelpers.CreateFileFromDialogResultTypeForResult (cognitive 16) src/Files.App/Helpers/UI/UIFilesystemHelpers.cs:100— UIFilesystemHelpers.CreateFileFromDialogResultTypeForResult has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LibraryManager.OnLibraryChanged (cognitive 16) src/Files.App/Utils/Library/LibraryManager.cs:371— LibraryManager.OnLibraryChanged has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FilesystemHelpers.CopyItemsFromClipboard (cognitive 16) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:373— FilesystemHelpers.CopyItemsFromClipboard has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ZipStorageFile.OpenAsync (cognitive 16) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:114— ZipStorageFile.OpenAsync has cognitive complexity 16 (threshold 15). Most of this is not in the body itself: 2 of the 16 points are its own statements and the rest belongs to one function literal inside it that branches (line 119). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
BaseLayoutViewModel.DropAsync (cognitive 16) src/Files.App/ViewModels/Layouts/BaseLayoutViewModel.cs:225— BaseLayoutViewModel.DropAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CombinedFileProperties.GetSystemFilePropertiesAsync (cognitive 16) src/Files.App/ViewModels/Properties/Items/CombinedFileProperties.cs:18— CombinedFileProperties.GetSystemFilePropertiesAsync has cognitive complexity 16 (threshold 15). Of this number, 13 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileProperties.GetBaseProperties (cognitive 16) src/Files.App/ViewModels/Properties/Items/FileProperties.cs:29— FileProperties.GetBaseProperties has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShellViewModel.OrderGroups (cognitive 16) src/Files.App/ViewModels/ShellViewModel.cs:1238— ShellViewModel.OrderGroups has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShellViewModel.GetItemTypeGroupIcon (cognitive 16) src/Files.App/ViewModels/ShellViewModel.cs:2059— ShellViewModel.GetItemTypeGroupIcon has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ShellViewModel.CheckForBackgroundImage (cognitive 16) src/Files.App/ViewModels/ShellViewModel.cs:2606— ShellViewModel.CheckForBackgroundImage has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ShellViewModel.WatchForDirectoryChanges (cognitive 16) src/Files.App/ViewModels/ShellViewModel.cs:2805— ShellViewModel.WatchForDirectoryChanges has cognitive complexity 16 (threshold 15). Most of this is not in the body itself: 3 of the 16 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 2821, 2906). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
RecentFilesWidgetViewModel.UpdateRecentFilesListAsync (cognitive 16) src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs:141— RecentFilesWidgetViewModel.UpdateRecentFilesListAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BaseLayoutPage.JumpString.set (cognitive 16) src/Files.App/Views/Layouts/BaseLayoutPage.cs:193— BaseLayoutPage.JumpString.set has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GridLayoutPage.EndRename (cognitive 16) src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:534— GridLayoutPage.EndRename has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D4 · Code Duplication· Near-duplicate member family (3 members, 71 shared lines) · ×1
Near-duplicate member family (3 members, 71 shared lines) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:192— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:192-327 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:397-532 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:535-673 — These 3 members are variants of one another: a block of 71 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
Near-duplicate member pair (89 shared lines) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:131— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:131-326 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:335-533 — These two members are variants of one another: 89 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (58 shared lines) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:82— src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:82-236 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:246-399 — These two members are variants of one another: 58 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (44 shared lines) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:599— src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:599-725 | src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:902-1015 — These two members are variants of one another: 44 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (24 corresponding lines) · ×1
Edited copy of a member (24 corresponding lines) src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:86— src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:86-112 | src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:138-164 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (22 corresponding lines) · ×1
Edited copy of a member (22 corresponding lines) src/Files.App/Utils/FileTags/FileTagsDatabase.cs:101— src/Files.App/Utils/FileTags/FileTagsDatabase.cs:101-127 | src/Files.App/Utils/FileTags/FileTagsDatabase.cs:130-156 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:115— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:115-159 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:203-242 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:280-317 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:363-407 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (29 lines × 2) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:504— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:504-532 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:645-673 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:504` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (53–54 lines × 2) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:397— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:397-449 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:535-588 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:397` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (44–45 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:139— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:139-182 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:358-402 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:139` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (42 lines × 2) src/Files.App/Actions/FileSystem/CopyItemFromHomeAction.cs:46— src/Files.App/Actions/FileSystem/CopyItemFromHomeAction.cs:46-87 | src/Files.App/Actions/Sidebar/CopyItemFromSidebarAction.cs:46-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/FileSystem/CopyItemFromHomeAction.cs:46` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (40–43 lines × 2) src/Files.App/Services/Windows/WindowsDialogService.cs:57— src/Files.App/Services/Windows/WindowsDialogService.cs:57-99 | src/Files.App/Services/Windows/WindowsDialogService.cs:144-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Windows/WindowsDialogService.cs:57` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Services/Windows/WindowsDialogService.cs:57` calls `SetClientGuid` and `src/Files.App/Services/Windows/WindowsDialogService.cs:144` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (37–38 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:931— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:931-968 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:977-1013 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (31–33 lines × 2) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:150— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:150-182 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:607-637 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:150` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (31 lines × 3) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:297— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:297-327 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:502-532 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:643-673 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:297` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (31–32 lines × 2) src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:206— src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:206-236 | src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:368-399 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs:206` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (31 lines × 2) src/Files.App/Services/Git/LibGit2Service.cs:534— src/Files.App/Services/Git/LibGit2Service.cs:534-564 | src/Files.App/Utils/Git/GitHelpers.cs:647-677 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (30–32 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:197— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:197-228 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:431-460 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:197` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (27–30 lines × 2) src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:682— src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:682-711 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:729-755 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:682` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (28 lines × 2) src/Files.App/Services/App/AppUpdateSideloadService.cs:137— src/Files.App/Services/App/AppUpdateSideloadService.cs:137-164 | src/Files.App/Services/App/AppUpdateStoreService.cs:221-248 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (27 lines × 2) src/Files.App/UserControls/NavigationToolbar.xaml.cs:337— src/Files.App/UserControls/NavigationToolbar.xaml.cs:337-363 | src/Files.App/UserControls/NavigationToolbar.xaml.cs:369-395 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (25–26 lines × 2) src/Files.App.Controls/Storage/StorageControlsHelpers.cs:40— src/Files.App.Controls/Storage/StorageControlsHelpers.cs:40-64 | src/Files.App.Controls/Storage/StorageControlsHelpers.cs:219-244 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22 lines × 2) src/Files.App/Data/Commands/ActionCommand.cs:194— src/Files.App/Data/Commands/ActionCommand.cs:194-215 | src/Files.App/Data/Commands/ModifiableCommand.cs:137-158 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (20 lines × 3) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:193— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:193-212 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:398-417 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:536-555 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:193` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/Files.App/Helpers/TransferHelpers.cs:50— src/Files.App/Helpers/TransferHelpers.cs:50-70 | src/Files.App/Helpers/TransferHelpers.cs:145-165 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Helpers/TransferHelpers.cs:50` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19–22 lines × 2) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:619— src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:619-640 | src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:932-950 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:619` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (20–21 lines × 3) src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:266— src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:266-286 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:471-490 | src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:612-631 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:266` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:492` calls `GetParsingPath` and `src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs:288` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 3) src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:483— src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:483-501 | src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:580-598 | src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs:634-652 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:483` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20–21 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:334— src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:334-353 | src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:483-503 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:483` calls `Yield` and `src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:334` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18–19 lines × 2) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:217— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:217-235 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:294-311 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:217` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (17–19 lines × 2) src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:261— src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:261-277 | src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:285-303 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs:261` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18 lines × 3) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:173— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:173-190 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:252-269 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:327-344 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:173` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17–18 lines × 2) src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:68— src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:68-85 | src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveToChildFolderAction.cs:42-58 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 3) src/Files.App/Actions/FileSystem/CopyItemPathAction.cs:44— src/Files.App/Actions/FileSystem/CopyItemPathAction.cs:44-58 | src/Files.App/Actions/FileSystem/CopyItemPathWithQuotesAction.cs:44-58 | src/Files.App/Actions/FileSystem/CopyPathAction.cs:42-56 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Actions/FileSystem/CopyItemPathAction.cs:44` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 3) src/Files.App/Services/Storage/StorageSecurityService.cs:101— src/Files.App/Services/Storage/StorageSecurityService.cs:101-116 | src/Files.App/Services/Storage/StorageSecurityService.cs:206-221 | src/Files.App/Services/Storage/StorageSecurityService.cs:307-322 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Storage/StorageSecurityService.cs:101` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16–17 lines × 2) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:584— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:584-599 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:865-881 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:584` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:583` calls `ShowDialogAsync`, `GetFor_FileInUseDialog` and `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:864` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–16 lines × 3) src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:774— src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:774-789 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:954-968 | src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:1000-1013 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemOperations.cs:774` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 5) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:169— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:169-183 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:248-262 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:323-337 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:481-495 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:695-709 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:169` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:167` calls `NotSupportedException` and `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:247` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11–15 lines × 3) src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:99— src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:99-113 | src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:381-391 | src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:537-547 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs:99` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13–14 lines × 3) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:220— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:220-233 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:297-309 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:369-382 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 3) src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:38— src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:38-48 | src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:90-100 | src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:142-152 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 6) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553-564 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:604-614 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:515-525 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:576-586 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:628-638 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:853-863 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:553` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–12 lines × 2) src/Files.App/Services/Windows/WindowsRecentItemsService.cs:126— src/Files.App/Services/Windows/WindowsRecentItemsService.cs:126-137 | src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:80-89 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Services/Windows/WindowsRecentItemsService.cs:126` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11–12 lines × 2) src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:647— src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:647-658 | src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:955-965 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs:647` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–11 lines × 6) src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:541— src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:541-550 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:594-603 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:503-513 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:560-569 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:617-626 | src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs:841-851 — there are 6 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/StorageItems/ZipStorageFile.cs:541` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 4) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:153— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:153-162 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:291-300 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:610-619 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:847-856 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:153` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (10 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:97— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:97-106 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:546-556 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:788-798 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:97` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7–8 lines × 2) src/Files.App/Views/Layouts/BaseLayoutPage.cs:558— src/Files.App/Views/Layouts/BaseLayoutPage.cs:558-565 | src/Files.App/Views/Layouts/BaseLayoutPage.cs:596-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 3) src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:157— src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:157-163 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:614-620 | src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:733-740 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App/Utils/Storage/Operations/ShellFilesystemOperations.cs:157` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (96 lines × 2) src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Properties.cs:29— src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Properties.cs:29-124 | src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.Properties.cs:29-124 — `src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Properties.cs` and `src/Files.App.Controls/Toolbar/ToolbarToggleButton/ToolbarToggleButton.Properties.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 96 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `src/Files.App.Controls/Toolbar/ToolbarButton/ToolbarButton.Properties.cs:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Coverage not measured — no coverage collector is wired up — Coverage NOT MEASURED: this repository runs its tests on Microsoft.Testing.Platform (its global.json opts in), where coverage comes from a coverage extension the test project references — and none is wired up: no build file names `Microsoft.Testing.Extensions.CodeCoverage` or `coverlet.MTP`. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment. Add one of those PackageReferences to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
IC1 · Incompleteness & stubs· Guard cannot change the result · ×1
Guard cannot change the result — returns what the code already falls through to src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Shell.cs:295— 1 guard above `return false;` also returns `false`, so no input can make it matter. Implement the distinction that was intended, or delete the guard.
Hollow method — returns a constant without doing the work src/Files.Storage/Windows/Helpers/WindowsStorableHelpers.Storage.cs:88— `TryRenameVolumeLabel` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
M1 · Documentation (README)· README may be stale · ×1
README may be stale — 833 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×1
Disposes a dependency it does not own src/Files.App/Data/Items/WidgetFolderCardItem.cs:76— `Item` is never created by `WidgetFolderCardItem` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 76). Its declared type `IWindowsStorable` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
X24 · Document value interpolated into markup unescaped· Document value reaches a markup attribute unescaped · ×1
Document value reaches a markup attribute unescaped src/Files.Core.SourceGenerator/Generators/StringsPropertyGenerator.cs:110— `exampleValue` carries text this program read out of the document being converted, and it is written straight into the text of an element of generated markup with nothing escaping it on the way. The value is chosen by whoever authored the file, not by this program, so it can close the attribute it sits in and open another — a crafted document becomes markup in the output this renderer produces. Escape `exampleValue` at this site, or validate it against the shape the attribute accepts before interpolating it.
X28 · Index access outside its own emptiness guard· Index access outside its own emptiness guard · ×1
Index access outside its own emptiness guard src/Files.App/MainWindow.xaml.cs:152— This condition tests `parsedArgs` for emptiness and then indexes it on a branch that test does not reach. `parsedArgs[0]` is evaluated whenever the guarded half is false — which includes the case the guard exists to anticipate, `parsedArgs` being empty — so an empty `parsedArgs` indexes position 0 of nothing and throws. This same condition already shows the intended bracketing at line 153: `parsedArgs[2]` sits INSIDE the guard. Either the guard is load-bearing, in which case this access escapes it and crashes, or `parsedArgs` cannot be empty here, in which case the guard beside it is dead code — the condition is wrong under both readings. Move the parenthesis so the emptiness test brackets every access to `parsedArgs`.
X5 · Nullable reference types· Null guard scopes only part of the work it protects · ×1
Null guard scopes only part of the work it protects src/Files.App/Utils/CommandLine/CommandLineParser.cs:169— This method contradicts itself about `args`: line 139 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 169 then dereferences `args` as `args.Length` AFTER the block has closed, where the guard no longer applies. A null `args` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `args` truly cannot be null by then, the guard above is misleading and should go.
Orphaned file src/Files.Core.SourceGenerator/Utilities/SourceGeneratorHelper.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/Operations/IFilesystemHelpers.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/Operations/IFilesystemOperations.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App.Controls/Storage/RingShape/RingShape.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App.Controls/Toolbar/ToolbarItem/ToolbarItem.Properties.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Converters/Converters.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/History/StorageHistoryOperations.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageItems/ShellStorageFile.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageBaseItems/BaseStorageFile.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/UserControls/StatusCenter/SpeedGraph.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Data/Behaviors/StickyHeaderBehavior.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Helpers/TransferHelpers.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App.Controls/Toolbar/ToolbarItem/ToolbarItem.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/StorageItems/VirtualStorageFile.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/Storage/Collection/GroupingHelper.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Utils/CommandLine/CommandLineParser.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Dialogs/FilesystemOperationDialog.xaml.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Views/Properties/LibraryPage.xaml.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Extensions/MessageFormatExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/ViewModels/UserControls/Previews/BasePreviewModel.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.Core.SourceGenerator/Generators/StringsPropertyGenerator.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Files.App/Views/Settings/TagsPage.xaml.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Silent fallback default in catch src/Files.Shared/Helpers/PathHelpers.cs:73— `IsInSystemFontsFolder` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.Storage/Windows/Shell/ShellItem.cs:274— `TryOpenLink` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.Storage/Windows/Shell/ShellItem.cs:425— `IsTargetFolder` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App.Server/Initialization/InitializationCache.cs:186— `HasChanged` swallows `IOException` into `return true;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Data/Models/CompressArchiveModel.cs:383— `CanOpenFile` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Data/Models/DirectoryPropertiesViewModel.cs:389— `TryConvertZipPath` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Extensions/DispatcherQueueExtensions.cs:41— `EnqueueOrInvokeAsync` swallows `InvalidOperationException` into `return default;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Extensions/DispatcherQueueExtensions.cs:81— `EnqueueOrInvokeAsync` swallows `InvalidOperationException` into `return default;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/BitmapHelper.cs:36— `ToBitmapAsync` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Environment/PolicyHelpers.cs:20— `IsShellShortcutIconRemotePathEnabled` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:138— `GetIconOverlay` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:585— `GetBitmapFromHBitmap` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:601— `GetBitmapFromHIcon` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:787— `InstallInf` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Helpers/Win32/Win32Helper.Storage.cs:984— `WriteStringToFile` swallows `Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Services/App/AppUpdateNoneService.cs:43— `CheckForReleaseNotesAsync` swallows every exception and sets `AreReleaseNotesAvailable = false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Services/App/AppUpdateSideloadService.cs:189— `CheckForReleaseNotesAsync` swallows every exception and sets `AreReleaseNotesAvailable = false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Services/App/AppUpdateStoreService.cs:141— `CheckForReleaseNotesAsync` swallows every exception and sets `AreReleaseNotesAvailable = false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Services/Git/LibGit2Service.cs:287— `Checkout` swallows every exception into `return GitOperationResult.GenericError;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Services/Git/LibGit2Service.cs:363— `DeleteBranchAsync` swallows every exception into `return GitOperationResult.GenericError;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Utils/Shell/ContextMenu.cs:96— `InvokeItem` swallows `Exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Utils/Shell/ContextMenu.cs:143— `GetContextMenuForFiles` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Utils/Shell/ContextMenu.cs:323— `LoadSubMenu` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Utils/Shell/OpenWithMenu.cs:211— `GetBitmapFromHBitmap` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch src/Files.App/Utils/Storage/Helpers/DriveHelpers.cs:114— `IsNetworkPath` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Interpolated log message defeats structured logging src/Files.App/Actions/FileSystem/FlattenFolderAction.cs:133— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/App.xaml.cs:200— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/App.xaml.cs:222— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/App.xaml.cs:234— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs:75— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Data/Models/DrivesViewModel.cs:62— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Data/Models/DrivesViewModel.cs:93— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Data/Models/PinnedFoldersManager.cs:163— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Extensions/MessageFormatExtensions.cs:92— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Services/Storage/StorageDevicesService.cs:65— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Services/Storage/StorageDevicesService.cs:71— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Services/Storage/StorageDevicesService.cs:81— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Utils/Library/LibraryManager.cs:385— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Utils/Library/LibraryManager.cs:393— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Utils/Library/LibraryManager.cs:400— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging REDACTED:300— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Utils/Storage/Helpers/FontFileHelper.cs:45— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/Utils/Storage/Helpers/FontFileHelper.cs:94— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/ShellViewModel.cs:2253— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/ShellViewModel.cs:3575— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/ShellViewModel.cs:3598— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:133— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs:601— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/UserControls/Previews/ShellPreviewViewModel.cs:141— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Files.App/ViewModels/UserControls/Previews/ShellPreviewViewModel.cs:269— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Duplicated predicate src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:225— `!HomePageContext.IsAnyItemRightClicked || item is null` appears character-identically in 3 files — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Content/Background/SetAsLockscreenBackgroundAction.cs:30— `!IsExecutable || ContentPageContext.SelectedItem is not ListedItem selectedItem` appears character-identically in 2 files — src/Files.App/Actions/Content/Background/SetAsLockscreenBackgroundAction.cs, src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Services/Git/LibGit2Service.cs:571— `!b.IsRemote && b.FriendlyName == uniqueName` appears character-identically in 2 files — src/Files.App/Services/Git/LibGit2Service.cs, src/Files.App/Utils/Git/GitHelpers.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs:36— `!e.GetCurrentPoint(null).Properties.IsMiddleButtonPressed || sender is not Button button || button.Tag.ToString() is not string path` appears character-identically in 3 files — src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs, src/Files.App/UserControls/Widgets/NetworkLocationsWidget.xaml.cs, src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:154— `!isPinned && UserSettingsService.GeneralSettingsService.ShowPinToSideBar` appears character-identically in 3 files — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:235— `!isSuccessful && option is NameCollisionOption.GenerateUniqueName` appears character-identically in 2 files — src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs, src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/Settings/AboutViewModel.cs:108— `!string.IsNullOrEmpty(command) && command.Contains("Files.App.Launcher.exe")` appears character-identically in 2 files — src/Files.App/ViewModels/Settings/AboutViewModel.cs, src/Files.App/ViewModels/Settings/AdvancedViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:698— `(item.PrimaryItemAttribute is StorageItemTypes.File && UserSettingsService.FoldersSettingsService.OpenFilesWithSingleClick.ShouldOpenWithSin…` appears character-identically in 2 files — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs, src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:31— `AccessControlList is not null && AccessControlList.IsValid` appears character-identically in 2 files — src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs, src/Files.App/ViewModels/Properties/SecurityViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs:35— `AccessControlList is not null && AccessControlList.IsValid && SelectedAccessControlEntry is not null && SelectedAccessControlEntry.IsInherit…` appears character-identically in 2 files — src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs, src/Files.App/ViewModels/Properties/SecurityViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/FileSystem/PasteItemAction.cs:56— `App.AppModel.IsPasteEnabled && context.PageType != ContentPageTypes.Home && context.PageType != ContentPageTypes.RecycleBin && context.PageT…` appears character-identically in 2 files — src/Files.App/Actions/FileSystem/PasteItemAction.cs, src/Files.App/Actions/FileSystem/PasteItemAsShortcutAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/UserControls/TabBar/BaseTabBar.cs:68— `App.AppModel.TabStripSelectedIndex >= 0 && App.AppModel.TabStripSelectedIndex < Items.Count` appears character-identically in 2 files — src/Files.App/UserControls/TabBar/BaseTabBar.cs, src/Files.App/UserControls/TabBar/TabBar.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs:27— `ContentPageContext.IsMultiPaneAvailable && !ContentPageContext.IsMultiPaneActive` appears character-identically in 2 files — src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs, src/Files.App/Actions/Navigation/SplitPaneVerticallyAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Navigation/ArrangePanesHorizontallyAction.cs:28— `ContentPageContext.IsMultiPaneAvailable && ContentPageContext.IsMultiPaneActive` appears character-identically in 2 files — src/Files.App/Actions/Navigation/ArrangePanesHorizontallyAction.cs, src/Files.App/Actions/Navigation/ArrangePanesVerticallyAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs:29— `ContentPageContext.ShellPage is not null && ContentPageContext.ShellPage.SlimContentPage is not null && ContentPageContext.PageType != Conte…` appears character-identically in 2 files — src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs, src/Files.App/Actions/Navigation/OpenInNewWindow/BaseOpenInNewWindowAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App.Controls/Storage/StorageBar/StorageBar.cs:366— `DesiredSize.Width < MinWidth || DesiredSize.Height < MinHeight || e.NewSize.Width < MinWidth || e.NewSize.Height < MinHeight` appears character-identically in 2 files — src/Files.App.Controls/Storage/StorageBar/StorageBar.cs, src/Files.App.Controls/Storage/StorageRing/StorageRing.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs:69— `FtpHelpers.IsFtpPath(path) && FtpHelpers.VerifyFtpPath(path)` appears character-identically in 2 files — src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs, src/Files.App/Utils/Storage/StorageItems/FtpStorageFolder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromHomeAction.cs:10— `HomePageContext.IsAnyItemRightClicked && HomePageContext.RightClickedItem is not null && (HomePageContext.RightClickedItem is WidgetFileTagC…` appears character-identically in 2 files — src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromHomeAction.cs, src/Files.App/Actions/Navigation/OpenInNewWindow/OpenInNewWindowFromHomeAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs:622— `IsWithinRenameDoubleClickWindow && item == RenamingItem` appears character-identically in 3 files — src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs, src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs, src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/Properties/Items/FileProperties.cs:137— `Item.IsLinkItem || string.IsNullOrWhiteSpace(((IShortcutItem)Item).TargetPath)` appears character-identically in 2 files — src/Files.App/ViewModels/Properties/Items/FileProperties.cs, src/Files.App/ViewModels/Properties/Items/FolderProperties.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:532— `ParentShellPageInstance is null || IsRenamingItem` appears character-identically in 2 files — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs, src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromSidebarAction.cs:10— `SidebarContext.IsItemRightClicked && SidebarContext.RightClickedItem is { } item && item.MenuOptions!.IsLocationItem` appears character-identically in 2 files — src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromSidebarAction.cs, src/Files.App/Actions/Navigation/OpenInNewWindow/OpenInNewWindowFromSidebarAction.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs:1260— `UserSettingsService.FoldersSettingsService.ShowCheckboxesWhenSelectingItems && control.IsSelected || isPointerOver` appears character-identically in 2 files — src/Files.App/Views/Layouts/DetailsLayoutPage.xaml.cs, src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:111— `UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && CommandManager.OpenInNewPaneFromHome.IsExecutable` appears character-identically in 3 files — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs:133— `UserSettingsService.GeneralSettingsService.ShowOpenInNewPane && CommandManager.OpenInOtherPaneFromHome.IsExecutable` appears character-identically in 3 files — src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/NetworkLocationsWidgetViewModel.cs, src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:84— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:96— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:120— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:124— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:134— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:139— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/GridSplitter/GripperHoverWrapper.cs:166— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Omnibar/Omnibar.Events.cs:160— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/RingShape/RingShape.cs:311— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageControlsHelpers.cs:202— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageControlsHelpers.cs:231— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:78— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:83— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:85— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:87— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:89— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:90— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Storage/StorageRing/StorageRing.Properties.cs:91— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Toolbar/Primitives/ToolbarLayout.cs:37— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/Files.App.Controls/Toolbar/Primitives/ToolbarLayout.cs:38— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Fat interface: IStorageProviderStatusUI (19 members) src/Files.Storage/Windows/Interop/IStorageProviderStatusUI.cs:12— `IStorageProviderStatusUI` declares 19 members: `GetIids`, `GetRuntimeClassName`, `GetTrustLevel`, `GetProviderState`, `PutProviderState`, `GetProviderStateLabel`, `PutProviderStateLabel`, `GetProviderStateIcon`, `PutProviderStateIcon`, `GetSyncStatusCommand`, `PutSyncStatusCommand`, `GetQuotaUI`, `PutQuotaUI`, `GetMoreInfoUI`, `PutMoreInfoUI`, `GetProviderPrimaryCommand`, `PutProviderPrimaryCommand`, `GetProviderSecondaryCommands`, `PutProviderSecondaryCommands`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IRichCommand (22 members) src/Files.App/Data/Commands/IRichCommand.cs:15— `IRichCommand` declares 22 members: `Code`, `Label`, `ExtendedLabel`, `LabelWithHotKey`, `AutomationName`, `Description`, `Glyph`, `Icon`, `FontIcon`, `ThemedIconStyle`, `IsCustomHotKeys`, `HotKeyText`, `AccessKey`, `HotKeys`, `DefaultHotKeys`, `IsToggle`, `IsOn`, `IsExecutable`, `IsAccessibleGlobally`, `AutomationId`, `ExecuteAsync`, `ExecuteTapped`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentPageContext (18 members) src/Files.App/Data/Contexts/ContentPage/IContentPageContext.cs:6— `IContentPageContext` declares 18 members: `ShellPage`, `PageType`, `PageLayoutType`, `Folder`, `HasItem`, `HasSelection`, `CanRefresh`, `SelectedItem`, `SelectedItems`, `CanGoBack`, `CanGoForward`, `CanNavigateToParent`, `CanCreateItem`, `IsMultiPaneAvailable`, `IsMultiPaneActive`, `IsGitRepository`, `CanExecuteGitAction`, `SolutionFilePath`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IAppearanceSettingsService (25 members) src/Files.App/Data/Contracts/IAppearanceSettingsService.cs:9— `IAppearanceSettingsService` declares 25 members: `SidebarWidth`, `IsSidebarOpen`, `AppThemeMode`, `AppThemeBackgroundColor`, `AppThemeAddressBarBackgroundColor`, `AppThemeToolbarBackgroundColor`, `AppThemeSidebarBackgroundColor`, `AppThemeFileAreaBackgroundColor`, `AppThemeFileAreaSecondaryBackgroundColor`, `AppThemeInfoPaneBackgroundColor`, `AppThemeFontFamily`, `AppThemeBackdropMaterial`, `AppThemeBackgroundImageSource`, `AppThemeBackgroundImageFit`, `AppThemeBackgroundImageOpacity`, `AppThemeBackgroundImageVerticalAlignment`, `AppThemeBackgroundImageHorizontalAlignment`, `ShowToolbar`, `ShowStatusBar`, `StatusBarItemCountFormat`, `ShowTabActions`, `ShowShelfPaneToggleButton`, `StatusCenterVisibility`, `CustomToolbarItems`, `LastKnownToolbarDefaults`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ICompressArchiveModel (16 members) src/Files.App/Data/Contracts/ICompressArchiveModel.cs:9— `ICompressArchiveModel` declares 16 members: `ArchivePath`, `Directory`, `FileName`, `Password`, `Sources`, `FileFormat`, `CompressionLevel`, `SplittingSize`, `DictionarySize`, `WordSize`, `CPUThreads`, `Progress`, `CancellationToken`, `IsCancelled`, `GetArchivePath`, `RunCreationAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IFoldersSettingsService (18 members) src/Files.App/Data/Contracts/IFoldersSettingsService.cs:6— `IFoldersSettingsService` declares 18 members: `ShowHiddenItems`, `ShowProtectedSystemFiles`, `AreAlternateStreamsVisible`, `ShowDotFiles`, `OpenFilesWithSingleClick`, `OpenFoldersWithSingleClick`, `OpenFoldersInColumnsViewWithSingleClick`, `OpenFoldersInNewTab`, `CalculateFolderSizes`, `ScrollToPreviousFolderWhenNavigatingUp`, `ShowFileExtensions`, `ShowThumbnails`, `DeleteConfirmationPolicy`, `SelectFilesOnHover`, `DoubleClickToGoUp`, `ShowFileExtensionWarning`, `ShowCheckboxesWhenSelectingItems`, `SizeUnitFormat`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IGeneralSettingsService (72 members) src/Files.App/Data/Contracts/IGeneralSettingsService.cs:6— `IGeneralSettingsService` declares 72 members: `OpenSpecificPageOnStartup`, `OpenSpecificPageOnStartupPath`, `ContinueLastSessionOnStartUp`, `OpenNewTabOnStartup`, `OpenTabInExistingInstance`, `TabsOnStartupList`, `LastSessionTabList`, `LastSessionSelectedTabIndex`, `LastCrashedTabList`, `PathHistoryList`, `PreviousSearchQueriesList`, `PreviousArchiveExtractionLocations`, `DateTimeFormat`, `AlwaysOpenDualPaneInNewTab`, `AlwaysSwitchToNewlyOpenedTab`, `ReverseTabScrollDirection`, `ShowQuickAccessWidget`, `ShowRecentFilesWidget`, `ShowDrivesWidget`, `ShowNetworkLocationsWidget`, `ShowFileTagsWidget`, `FoldersWidgetExpanded`, `RecentFilesWidgetExpanded`, `DrivesWidgetExpanded`, `NetworkLocationsWidgetExpanded`, `FileTagsWidgetExpanded`, `ShowPinnedSection`, `ShowLibrarySection`, `ShowDrivesSection`, `ShowCloudDrivesSection`, `ShowNetworkSection`, `ShowWslSection`, `ShowFileTagsSection`, `IsPinnedSectionExpanded`, `IsLibrarySectionExpanded`, `IsDriveSectionExpanded`, `IsCloudDriveSectionExpanded`, `IsNetworkSectionExpanded`, `IsWslSectionExpanded`, `IsFileTagsSectionExpanded`, and 32 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ILayoutSettingsService (44 members) src/Files.App/Data/Contracts/ILayoutSettingsService.cs:6— `ILayoutSettingsService` declares 44 members: `SyncFolderPreferencesAcrossDirectories`, `DefaultLayoutMode`, `DefaultSortOption`, `DefaultDirectorySortDirection`, `DefaultSortDirectoriesAlongsideFiles`, `DefaultSortFilesFirst`, `DefaultGroupOption`, `DefaultDirectoryGroupDirection`, `DefaultGroupByDateUnit`, `ShowDateColumn`, `ShowDateCreatedColumn`, `ShowTypeColumn`, `ShowSizeColumn`, `ShowGitStatusColumn`, `ShowGitLastCommitDateColumn`, `ShowGitLastCommitMessageColumn`, `ShowGitCommitAuthorColumn`, `ShowGitLastCommitShaColumn`, `ShowFileTagColumn`, `ShowDateDeletedColumn`, `ShowPathColumn`, `ShowOriginalPathColumn`, `ShowSyncStatusColumn`, `GitStatusColumnWidth`, `GitLastCommitDateColumnWidth`, `GitLastCommitMessageColumnWidth`, `GitCommitAuthorColumnWidth`, `GitLastCommitShaColumnWidth`, `TagColumnWidth`, `NameColumnWidth`, `DateModifiedColumnWidth`, `TypeColumnWidth`, `DateCreatedColumnWidth`, `SizeColumnWidth`, `DateDeletedColumnWidth`, `SyncStatusColumnWidth`, `PathColumnWidth`, `OriginalPathColumnWidth`, `AutoSizeColumnsInDetailsLayout`, `DetailsViewSize`, and 4 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IShellPage (29 members) src/Files.App/Data/Contracts/IShellPage.cs:8— `IShellPage` declares 29 members: `ShellViewModel`, `InstanceViewModel`, `StorageHistoryHelpers`, `ForwardStack`, `BackwardStack`, `SlimContentPage`, `CurrentPageType`, `FilesystemHelpers`, `ToolbarViewModel`, `CanNavigateBackward`, `CanNavigateForward`, `IsCurrentPane`, `WhenIsCurrent`, `RefreshIfNoWatcherExistsAsync`, `Refresh_Click`, `Back_Click`, `Forward_Click`, `Up_Click`, `UpdatePathUIToWorkingDirectoryAsync`, `NavigateToPath`, `NavigateToPath`, `NavigateHome`, `NavigateToReleaseNotes`, `NavigateToSettings`, `NavigateWithArguments`, `RemoveLastPageFromBackStack`, `ResetNavigationStackLayoutMode`, `SubmitSearch`, `IsColumnView`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 29 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IShellPanesPage (17 members) src/Files.App/Data/Contracts/IShellPanesPage.cs:9— `IShellPanesPage` declares 17 members: `IsLeftPaneActive`, `IsRightPaneActive`, `IsMultiPaneActive`, `IsMultiPaneAvailable`, `FilesystemHelpers`, `TabBarItemParameter`, `ShellPaneArrangement`, `ActivePane`, `ActivePaneOrColumn`, `OpenSecondaryPane`, `OpenInOtherPane`, `ArrangePanes`, `CloseActivePane`, `CloseOtherPane`, `FocusOtherPane`, `FocusActivePane`, `GetPanes`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IVersionControlService (24 members) src/Files.App/Data/Contracts/IVersionControlService.cs:16— `IVersionControlService` declares 24 members: `GetGitRepositoryPath`, `GetOriginRepositoryName`, `GetBranchNames`, `GetRepositoryHead`, `GetRepositoryHeadName`, `Checkout`, `CreateNewBranchAsync`, `DeleteBranchAsync`, `ValidateBranchNameForRepository`, `FetchOriginAsync`, `PullOriginAsync`, `PushToOriginAsync`, `RequireGitAuthenticationAsync`, `IsRepositoryEx`, `GetGitInformationForItem`, `RemoveSavedCredentials`, `GetSavedCredentials`, `InitializeRepositoryAsync`, `GetRepoInfo`, `IsValidRepoUrl`, `CloneRepoAsync`, `IsExecutingGitAction`, `IsExecutingGitActionChanged`, `GitFetchCompleted`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IListedItem (64 members) src/Files.App/Data/Items/IListedItem.cs:11— `IListedItem` declares 64 members: `AsGitItem`, `AsRecycleBinItem`, `ContainsFilesOrFolders`, `ContextualProperty`, `CustomIcon`, `CustomIconSource`, `FileDetails`, `FileExtension`, `FileFRN`, `FileImage`, `FileSize`, `FileSizeBytes`, `FileSizeDisplay`, `FileTags`, `FileTagsUI`, `FileVersion`, `FolderRelativeId`, `HasTags`, `IconOverlay`, `ImageDimensions`, `IsAlternateStream`, `IsArchive`, `IsDriveRoot`, `IsElevationRequired`, `IsExecutable`, `IsFolder`, `IsFtpItem`, `IsGitItem`, `IsHiddenItem`, `IsItemPinnedToStart`, `IsLibrary`, `IsLinkItem`, `IsPinned`, `IsRecycleBinItem`, `IsScriptFile`, `IsShortcut`, `ItemDateAccessed`, `ItemDateAccessedReal`, `ItemDateCreated`, `ItemDateCreatedReal`, and 24 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IFilesystemHelpers (24 members) src/Files.App/Utils/Storage/Operations/IFilesystemHelpers.cs:9— `IFilesystemHelpers` declares 24 members under just 15 distinct name(s): `CreateAsync`, `DeleteItemsAsync`, `DeleteItemAsync`, `DeleteItemsAsync`, `DeleteItemAsync`, `RestoreItemFromTrashAsync`, `RestoreItemsFromTrashAsync`, `RestoreItemFromTrashAsync`, `RestoreItemsFromTrashAsync`, `PerformOperationTypeAsync`, `CopyItemsAsync`, `CopyItemAsync`, `CopyItemsAsync`, `CopyItemAsync`, `CopyItemsFromClipboard`, `RecycleItemsFromClipboard`, `CreateShortcutFromClipboard`, `MoveItemsAsync`, `MoveItemAsync`, `MoveItemsAsync`, `MoveItemAsync`, `MoveItemsFromClipboard`, `RenameAsync`, `RenameAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 24 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 24 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IFilesystemOperations (20 members) src/Files.App/Utils/Storage/Operations/IFilesystemOperations.cs:14— `IFilesystemOperations` declares 20 members under just 11 distinct name(s): `CreateAsync`, `CreateShortcutItemsAsync`, `CopyAsync`, `CopyAsync`, `CopyItemsAsync`, `CopyItemsAsync`, `MoveAsync`, `MoveAsync`, `MoveItemsAsync`, `MoveItemsAsync`, `DeleteAsync`, `DeleteAsync`, `DeleteItemsAsync`, `DeleteItemsAsync`, `RenameAsync`, `RenameAsync`, `RestoreItemsFromTrashAsync`, `RestoreFromTrashAsync`, `RestoreItemsFromTrashAsync`, `RestoreFromTrashAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IBaseStorageFolder (27 members) src/Files.App/Utils/Storage/StorageBaseItems/IBaseStorageFolder.cs:11— `IBaseStorageFolder` declares 27 members: `Properties`, `ToStorageFolderAsync`, `GetParentAsync`, `GetBasicPropertiesAsync`, `GetItemAsync`, `TryGetItemAsync`, `GetItemsAsync`, `GetFileAsync`, `GetFilesAsync`, `GetFilesAsync`, `GetFilesAsync`, `GetFolderAsync`, `GetFoldersAsync`, `GetFoldersAsync`, `GetFoldersAsync`, `CreateFileAsync`, `CreateFileAsync`, `CreateFolderAsync`, `CreateFolderAsync`, `MoveAsync`, `MoveAsync`, `GetThumbnailAsync`, `GetThumbnailAsync`, `GetThumbnailAsync`, `CreateItemQueryWithOptions`, `CreateFileQueryWithOptions`, `CreateFolderQueryWithOptions`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 27 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Pass-through layer src/Files.App/Services/DateTimeFormatter/UserDateTimeFormatter.cs:6— UserDateTimeFormatter: all 3 public methods forward their arguments unchanged to formatter and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call formatter directly, or give the layer a job.
Pass-through layer src/Files.App/Utils/Storage/StorageItems/StreamWithContentType.cs:231— StreamWithContentType: all 8 public methods forward their arguments unchanged to baseStream and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call baseStream directly, or give the layer a job.
Pass-through layer src/Files.App/Utils/Storage/StorageItems/SystemStorageFile.cs:200— SystemFileBasicProperties: all 3 public methods forward their arguments unchanged to basicProps and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call basicProps directly, or give the layer a job.
Pass-through layer src/Files.App/Utils/Storage/StorageItems/SystemStorageFolder.cs:164— SystemFolderBasicProperties: all 3 public methods forward their arguments unchanged to basicProps and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call basicProps directly, or give the layer a job.
Silent fallback default on parse failure src/Files.App/Data/Items/ToolbarItemDescriptor.cs:151— `ResolveToolbarSectionId` falls back to `OtherContextsContextId` when `Enum.TryParse<CommandCodes>(commandCode, out var code) && code != CommandCodes.N…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/Files.App/Utils/Git/GitHelpers.cs:386— `ToReturnResult` falls back to `ReturnResult.Failed` when `result is GitOperationResult.Success` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure src/Files.App/Views/Settings/SettingsPage.xaml.cs:86— `OnNavigatedTo` falls back to `SettingsPageKind.GeneralPage` when `Enum.TryParse<SettingsPageKind>(selectedTag, out var parsedPageKind)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
C2 · Access Controls· No named authorization policies · ×1
No named authorization policies — Authorization IS enforced here (by imperative guard methods that throw on violation) — this is NOT a claim that the code is unprotected. What's missing is a NAMED rule set: the guards encode the access rules inline, so the rules can't be listed, reviewed or tested apart from the call sites that apply them. Recommendation, not a defect.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 16 significant file(s) lose their only recent owner: src/Files.Core.SourceGenerator/Generators/RegistrySerializationGenerator.cs, src/Files.App/ViewModels/UserControls/SidebarViewModel.TabExpansion.cs, src/Files.App/Data/Items/ToolbarItemDescriptor.cs, src/Files.App/Helpers/Navigation/NavigationInteractionTracker.cs, src/Files.App/ViewModels/Settings/ToolbarCustomizationViewModel.cs, src/Files.App/Views/Settings/ToolbarCustomizationPage.xaml.cs, src/Files.App/Dialogs/KeyBindingEditorDialog.xaml.cs, src/Files.App/Data/Items/ToolbarSections.cs (+8 more). Pair on, review, or document these before any departure.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 2 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (20 single-owned of 399 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 399 of the 1107 production source files in this repository met that bar). They are anonymized user #2 (2 file(s)), anonymized user #3 (2 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: src/Files.App/Services/Storage/StorageSecurityService.cs, src/Files.App/Helpers/Layout/LayoutPreferencesDatabase.cs, src/Files.Storage/Windows/Managers/WindowsFolderChangeWatcher.cs, src/Files.Storage/Windows/Managers/SystemTrayManager.cs.
No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 1 of 9 project(s) overshoot their size bounds, lowering Project Cohesion to 7.8/10. The most over is `Files.App` (98366 LoC, 736 public types across 58 namespaces). Review these for cohesion — split a project that spans unrelated responsibilities.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
REDACTED
D34 · Knowledge Freshness· Orphaned files with no living knowledge · ×1
Orphaned files with no living knowledge — 64 of 399 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 399 of the 1107 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: src/Files.Core.SourceGenerator/Utilities/SourceGeneratorHelper.cs, src/Files.App/Utils/Storage/Operations/IFilesystemHelpers.cs, src/Files.App/Utils/Storage/Operations/IFilesystemOperations.cs, src/Files.App/Utils/Storage/StorageItems/ShellStorageFolder.cs, src/Files.App/Utils/Storage/StorageItems/FtpStorageFile.cs, src/Files.App.Controls/Storage/RingShape/RingShape.cs, src/Files.App.Controls/Toolbar/ToolbarItem/ToolbarItem.Properties.cs, src/Files.App/Utils/Storage/StorageItems/BaseQueryResults.cs (and 56 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 20 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 46611 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
PF1 · Benchmark discipline· No performance benchmarks · ×1
No performance benchmarks — No benchmark suite was found by the two searches this check runs. FIRST, a BenchmarkDotNet package reference in any project file — every project the workspace loaded, plus a walk of project files on disk that never loaded, because a benchmark suite is exactly the project a partial load drops. SECOND, a script harness: a file whose name contains `benchmark` and ends `.py`, `.sh`, `.ps1`, `.bash`, `.rb`, `.js` or `.mjs`, credited ONLY when this repository's CI text also mentions benchmarks — a harness no pipeline runs is read as a fixture, deliberately. Neither search can see a benchmark suite in another ecosystem's idiom (a Go `testing.B` file, a JMH or criterion project, a pytest-benchmark run), so this is 'no benchmark found by those two searches', not a verdict that the repository has none. Where code is performance-sensitive, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 105/491 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Nullable reference types not enabled everywhere — 6/7 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~0.8 `!` suppressions per 1k syntax nodes — 66 suppression(s) across the 79720 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Silent fallback default on unknown code src/Files.App/Helpers/Layout/AdaptiveLayoutHelpers.cs:103— `GetPathLayout` maps every unrecognised code to `Layouts.Detail`, one of the real values, with no log or throw — a malformed or new code silently reads as a known one. Throw on the unknown code, or log it. If that member is the correct answer for any other code, say so in a comment on the member and the row stops firing.
Off the main sequence: Files.Shared src/Files.Shared/Files.Shared.csproj:1— Files.Shared: abstractness 0.20, instability 0.00, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 22 file(s) — `src/Files.App.Server/Initialization/CachedTask.cs`, `src/Files.App.Server/Initialization/InitializationCache.cs`, `src/Files.App.Server/Initialization/RegistryChangeMonitor.cs`, `src/Files.App/Actions/Display/LayoutAction.cs`, `src/Files.App/Data/Commands/Manager/CommandGroupManager.cs`, … (+17 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a16602-9627-743a-808e-ad1e3065a589 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 3 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 168 · Warnings: 925 · Recommendations: 217 · Info: 8 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 22-10-2026 @ 23:46 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.