Public report of filodb/FiloDB, published 26 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 26 October 2026, 07:21 UTC · Survey ID cd_6afa90d4c3224359b920614e2f30dfc8

filodb/FiloDB

Measured 26 October 2026, 07:19 UTC, at code version 2207279

No regression since the last survey Supply-chain provenance & signing: not measured

A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.

Supply-chain provenance & signing is not measured: Supply-chain provenance is not scored (this pipeline releases no artifact), but its build steps or GitHub Actions workflows have integrity defects, or nothing watches its dependency set for published advisories.

CAI score 61out of 100 At risk No change since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

Architecture 93 Exemplary Performance 81 Strong Maturity 74 Strong Security and Compliance 69 Adequate Production Readiness 66 Strong Code Health 50 Adequate

A medium codebase: 87,651 lines of product code in 4 projects, tests not counted · Estimated rebuild effort: about 1.1 person-years · Weakest lens: Code Health, 50

Findings by how serious they are

23 critical 650 serious 216 minor

13 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
26 October 2026, 07:19 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

67of 67 dimensions measured by tools.
811of 889 findings point to an exact file and line, so you can open each one in the code. The other 78 concern the repository as a whole, such as missing documentation.
67dimensions across 6 lenses, read from 87,651 lines of product code in 4 projects.
Chapters

Executive summary

filodb/FiloDB is rated At risk because critical security findings are open. It scores 61 out of 100, which the At risk rating leaves unchanged. We judged it as a preview release, against a lower bar.

Code Health, at 50, is the weakest lens and counts most in the score. The best first step is declaring which values may be missing, worth about 6 points. Writing log messages as searchable templates comes next, worth about 4 points. Raising Code Health to 67 would lift the score to about 69.

Seven known security holes in the packages the code depends on can be used by attackers. Six pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with, and eight parts of the code are no longer understood by anyone working on it. Updating the vulnerable packages, pinning each tool to an exact version and having someone learn the forgotten files would close these risks. Fixing the weaknesses the scanner points to would fix the security weakness in the code, and the pipeline step that installs packages without pinning their versions needs the packages it installs pinned to exact versions.

The product code is 87,651 lines, about €160,000 to rebuild.

Code Health 50 Adequate, capped by Structured logging and Nullable reference types Architecture 93 ★ Exemplary Maturity 74 Strong Production Readiness 66 Strong Security and Compliance 69 Adequate, capped by Dependency Vulnerabilities Performance 81 Strong

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Code Health 50 · counts for 46%Production Readiness 66 · counts for 25%Security and Compliance 69 · counts for 14%Maturity 74 · counts for 8%Performance 81 · counts for 4%Architecture 93 · counts for 2%

If Code Health rose from 50 to 67, the lowest score rated Strong, the score would rise from 61 to about 69.

Code composition: what the lines of code are
Product code 59%Tests 41%
New since the last survey: 4 findings

These 4 critical or serious findings weren't in the previous survey, on 12 October 2026.

  • Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala
  • Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala
  • Supply-chain Provenance & Signing · REDACTED

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 42 findings

These 42 critical or serious findings were in the previous survey, on 12 October 2026, and are gone from this one.

  • Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala
  • Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala
  • Supply-chain Provenance & Signing REDACTED
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError http/src/main/scala/filodb/http/PromQLGrpcServer.scala
  • Incompleteness & stubs · Skeleton type — most members are unfinished query/src/main/scala/filodb/query/LogicalPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/LogicalPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/LogicalPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/LogicalPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/PlanEnums.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/PlanEnums.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/BinaryJoinExec.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/EmptyResultExec.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/GenericRemoteExec.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/HistogramQuantileMapper.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/InProcessPlanDispatcher.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Skeleton type — most members are unfinished query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/SetOperatorExec.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/StitchRvsExec.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError spark/src/main/scala/filodb.spark/package.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError spark/src/main/scala/filodb.spark/package.scala
  • Incompleteness & stubs · Unfinished stub — body is ??? / NotImplementedError spark/src/main/scala/filodb.spark/package.scala
Rebuild cost: about €160,000 · Estimate
Cost to rebuild€54,000 to €270,000, for 896 to 2,843 hours of work, about 1.1 person-years for 1 to 3 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 61. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 87,651 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`.
Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.
Raises the score by about 6 points · Medium effort · Nullable reference types
2
Interpolated log message defeats structured logging
Raises the score by about 4 points · Medium effort · Structured logging
3
Bring the 22 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with PromQLParser.vectorExpression (cyclomatic 53), BinaryOperatorFunction.factoryMethod (cyclomatic 43), CliMain.main (cyclomatic 35).
Raises the score by about 4 points · High effort · Cyclomatic Complexity

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €160,000 to build again, about 1.1 person-years of work. Its weakest lens is Code Health, at 50 (Weak). Code Health is about how easy the code is to read and change safely, and code that is hard to read is slow and risky to change, so every future change costs more than it should. Because the weakest lens counts most in the score, work on Code Health also moves the score most.
Based on: the rebuild estimate · the Code Health grade · how much each lens counts
What to do: Start with the Code Health actions in Top priorities.
If you do one thing first · First action
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Of all the actions in this report, it raises the score most for the work it takes: about 6 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch filodb_core filodb_core tantivy_utils tantivy_utils filodb_core->tantivy_utils root root

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

202 modules, with 467 dependencies between them. One loop runs through 46 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 162 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 filodb.memory2 tantivy_utils.collectors.column_cache3 tantivy_utils.collectors.limited_collector.limit_counter4 filodb.core.memstore.ratelimit5 filodb.memory.format.vectors6 filodb_core.state7 tantivy_utils.collectors.limited_collector8 filodb.memory.format.RowReader9 filodb.memory.format10 filodb.core.memstore11 filodb.query.exec.aggregator12 filodb.core.store13 filodb.coordinator.NodeClusterActor14 filodb.query.exec.rangefn15 filodb.coordinator.ShardManager16 filodb.query.exec17 filodb.coordinator18 filodb.coordinator.client19 filodb.query20 filodb.prometheus.ast21 filodb.core.metadata.Column22 filodb.core.query23 filodb.core.binaryrecord224 filodb.core.memstore.TimeSeriesShard25 filodb.core.downsample26 filodb.core.metadata27 filodb.core28 filodb.cassandra.columnstore29 filodb.cli30 filodb.coordinator.client.QueryCommands31 filodb.coordinator.flight32 filodb.coordinator.queryplanner33 filodb.coordinator.v234 filodb.downsampler.chunk35 filodb.query.ProtoConverters36 filodb.spark37 filodb.coordinator.ProtoConverters38 filodb.coordinator.queryengine39 filodb.http40 filodb.jmh
1 filodb.memory
2 tantivy_utils.collectors.column_cache
3 tantivy_utils.collectors.limited_collector.limit_counter
4 filodb.core.memstore.ratelimit4
5 filodb.memory.format.vectors17128
6 filodb_core.state1
7 tantivy_utils.collectors.limited_collector2
8 filodb.memory.format.RowReader114
9 filodb.memory.format8133
10 filodb.core.memstore92142611422613
11 filodb.query.exec.aggregator15921
12 filodb.core.store119261613
13 filodb.coordinator.NodeClusterActor31115
14 filodb.query.exec.rangefn7680161112821
15 filodb.coordinator.ShardManager12111
16 filodb.query.exec1381124211291205317
17 filodb.coordinator5991624123728
18 filodb.coordinator.client121125
19 filodb.query12457
20 filodb.prometheus.ast421
21 filodb.core.metadata.Column12
22 filodb.core.query1324811133
23 filodb.core.binaryrecord223512
24 filodb.core.memstore.TimeSeriesShard11242
25 filodb.core.downsample33294847123
26 filodb.core.metadata571146121
27 filodb.core124151
28 filodb.cassandra.columnstore19117
29 filodb.cli11111111
30 filodb.coordinator.client.QueryCommands36616
31 filodb.coordinator.flight11841116111
32 filodb.coordinator.queryplanner115182226157
33 filodb.coordinator.v22147
34 filodb.downsampler.chunk1363131
35 filodb.query.ProtoConverters2125621
36 filodb.spark12311222
37 filodb.coordinator.ProtoConverters24210561746281321
38 filodb.coordinator.queryengine111112121
39 filodb.http112332131
40 filodb.jmh12946211
Uses a module listed above itPart of a loopThe module itself
1 filodb.memory2 tantivy_utils.collectors.column_cache3 tantivy_utils.collectors.limited_collector.limit_counter4 filodb.core.memstore.ratelimit5 filodb.memory.format.vectors6 filodb_core.state7 tantivy_utils.collectors.limited_collector8 filodb.memory.format.RowReader9 filodb.memory.format10 filodb.core.memstore11 filodb.query.exec.aggregator12 filodb.core.store13 filodb.coordinator.NodeClusterActor14 filodb.query.exec.rangefn15 filodb.coordinator.ShardManager16 filodb.query.exec17 filodb.coordinator18 filodb.coordinator.client19 filodb.query20 filodb.prometheus.ast21 filodb.core.metadata.Column22 filodb.core.query23 filodb.core.binaryrecord224 filodb.core.memstore.TimeSeriesShard25 filodb.core.downsample26 filodb.core.metadata27 filodb.core28 filodb.cassandra.columnstore29 filodb.cli30 filodb.coordinator.client.QueryCommands31 filodb.coordinator.flight32 filodb.coordinator.queryplanner33 filodb.coordinator.v234 filodb.downsampler.chunk35 filodb.query.ProtoConverters36 filodb.spark37 filodb.coordinator.ProtoConverters38 filodb.coordinator.queryengine39 filodb.http40 filodb.jmhfilodb.memory1tantivy_utils.collectors.column_cache2tantivy_utils.collectors.limited_collector.limit_counter3filodb.core.memstore.ratelimit4filodb.memory.format.vectors5filodb_core.state6tantivy_utils.collectors.limited_collector7filodb.memory.format.RowReader8filodb.memory.format9filodb.core.memstore10filodb.query.exec.aggregator11filodb.core.store12filodb.coordinator.NodeClusterActor13filodb.query.exec.rangefn14filodb.coordinator.ShardManager15filodb.query.exec16filodb.coordinator17filodb.coordinator.client18filodb.query19filodb.prometheus.ast20filodb.core.metadata.Column21filodb.core.query22filodb.core.binaryrecord223filodb.core.memstore.TimeSeriesShard24filodb.core.downsample25filodb.core.metadata26filodb.core27filodb.cassandra.columnstore28filodb.cli29filodb.coordinator.client.QueryCommands30filodb.coordinator.flight31filodb.coordinator.queryplanner32filodb.coordinator.v233filodb.downsampler.chunk34filodb.query.ProtoConverters35filodb.spark36filodb.coordinator.ProtoConverters37filodb.coordinator.queryengine38filodb.http39filodb.jmh40417128121148133921426114226131592111926161331115768016111282112111138112421129120531759916241237281211251245742112132481113323512112423329484712357114612112415119117111111113661611841116111115182226157214713631312125621123112222421056174628132111111212111233213112946211+162 more modules (most-connected shown)

At a glance — Code Health · 50% · Adequate · gated by X4, X5 ·

The Good
D1 · Scala Cyclomatic Complexity 6.9 D3 · Scala God Classes 8.5 D4 · Scala Code Duplication 9.4 D17 · Scala Explicit Debt 9.3 GD1 · Repo Unfinished & placeholder code 9.6 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 7.5 X30 · Repo Support guard that admits what it rejects 10.0
The Bad
D2 · Scala Cognitive Complexity 6.2 IC1 · Repo Incompleteness & stubs 5.3
The Ugly
X18 · Repo Disposal-pattern correctness 3.5 X4 · Repo Structured logging 3.5 X5 · Repo Nullable reference types 2.0

At a glance — Architecture · 93% · Exemplary ·

The Good
D5 · Scala Coupling 7.3 D6 · Scala Cohesion (LCOM4) 9.7 D35 · Scala Change Coupling 9.9 AX10 · Repo Code composition 9.5 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX6 · Repo Interface segregation 9.9 AX9 · Repo CQS / query purity 10.0
The Bad
D26 · Scala Project Cohesion 5.0

At a glance — Maturity · 74% · Strong ·

The Good
D15 · Scala Churn × Complexity Hotspots 9.9 D16 · Scala Bus Factor 9.3 D19 · Scala Documentation Quality 10.0 M1 · Repo Documentation (README) 7.3 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0
The Bad
D34 · Scala Knowledge Freshness 6.0 M2 · Repo Architecture documentation 5.0

At a glance — Readiness · 66% · Strong ·

The Good
D9 · Scala Test Distribution 10.0 D12 · Scala Dependency Hygiene 8.0 D13 · Scala Secret Scanning 10.0 D14 · Scala License Compliance 10.0 P1 · Repo CI/CD gates 10.0 P2 · Repo Observability 9.0
The Bad
P10 · Repo Library API & versioning 6.0 P3 · Repo Security & performance tooling 5.0 P6 · Repo Release Hygiene 5.0

At a glance — Security · 69% · Adequate · gated by D30 ·

The Good
D28 · Scala Secrets (history) 10.0 D37 · Scala Vulnerability-disclosure Policy 10.0 D43 · Scala Malicious Dependencies 10.0 D44 · Scala Platform End-of-Life 10.0 X14 · Repo Bypassable address classification 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0
The Bad
D29 · Scala Static Analysis (SAST) 6.4 S1 · Repo Web-Security Posture 6.0
The Ugly
D30 · Scala Dependency Vulnerabilities 2.1 X15 · Repo Unvalidated length from an untrusted reader 2.2

At a glance — Performance · 81% · Strong ·

The Good
PF1 · Repo Benchmark discipline 8.5 PF2 · Repo Allocation hygiene 6.8 PF3 · Repo Async & latency hygiene 10.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2025 — Software Supply Chain Failures19High / Critical
A05:2025 — Injection10High / Critical

Roadmap

First, enforce strict null safety by enabling explicit null checks in the compiler and replacing unsafe assertions with proper Option handling at Java boundaries. Next, fix interpolated log messages to ensure structured logging works correctly, and refactor the most complex code paths to reduce cyclomatic complexity below the threshold. Finally, remove or complete all unfinished stubs and resolve the backlog of technical debt comments to eliminate dead code and clarify implementation status.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.+6.5 ptsMediumNullable reference types
Interpolated log message defeats structured logging+4.5 ptsMediumStructured logging
Bring the 22 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with PromQLParser.vectorExpression (cyclomatic 53), BinaryOperatorFunction.factoryMethod (cyclomatic 43), CliMain.main (cyclomatic 35).+3.6 ptsHighCyclomatic Complexity
Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.+2.7 ptsMediumIncompleteness & stubs
Secure the server's transport: serve TLS itself (akka/pekko-http `ConnectionContext.httpsServer(sslContext)` with `newServerAt(…).enableHttps(…)`, an http4s server builder's `withTLS(…)`, Play's `https.port`), or run it behind a TLS-terminating proxy and trust it (`X-Forwarded-Proto`; Play `play.http.forwarded.trustedProxies`); send `Strict-Transport-Security` once it is HTTPS-only (http4s `HSTS(…)`, Play `RedirectHttpsFilter`).+1.6 ptsMediumWeb-Security Posture
Enable Dependabot/Renovate or a dependency-review gate.+1.3 ptsMediumSecurity & performance tooling
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.+1.3 ptsMediumRelease Hygiene
Resolve the 244 TodoComment finding(s) in Explicit Debt — start with TimeSeriesShard.scala (9), PlannerHierarchySpec.scala (7), PromQlRemoteExec.scala (6).+2.5 ptsHighExplicit Debt

File quality

Per-file score 0–10 — a quality signature. Of 203 files carrying findings, judged against the Preview bar: 1% slop · 34% mixed · 65% near-clean.

FileScoreBandWorst signal
REDACTED0.8SlopStatic Analysis (SAST): High: REDACTED
REDACTED0.8SlopDependency Vulnerabilities: Critical CVE: REDACTED
REDACTED4.5MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedDependency Vulnerabilities: Medium CVE: REDACTED
cli/src/main/scala/filodb.cli/CliMain.scala6.0MixedExplicit Debt: TodoComment
standalone/src/main/java/filodb/standalone/SimpleProfiler.java6.0MixedExplicit Debt: XxxComment
coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala6.0MixedExplicit Debt: TodoComment
core/src/main/scala/filodb.memory/format/vectors/Histogram.scala6.0MixedExplicit Debt: TodoComment
coordinator/src/main/scala/filodb.coordinator/QueryActor.scala6.0MixedExplicit Debt: TodoComment
query/src/main/scala/filodb/query/ProtoConverters.scala6.0MixedExplicit Debt: FixmeComment
query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala6.0MixedExplicit Debt: FixmeComment
core/src/main/java/filodb/memory/Latch.java6.0MixedExplicit Debt: TodoComment
coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala6.0MixedExplicit Debt: TodoComment
prometheus/src/main/scala/filodb/prometheus/ast/Expressions.scala6.0MixedExplicit Debt: TodoComment
query/src/main/scala/filodb/query/exec/ExecPlan.scala6.0MixedExplicit Debt: TodoComment
core/src/main/scala/filodb.core/memstore/PartKeyIndex.scala6.0MixedExplicit Debt: TodoComment
cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala6.0MixedExplicit Debt: TodoComment
coordinator/src/main/scala/filodb.coordinator/IngestionActor.scala6.0MixedExplicit Debt: TodoComment
core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala6.0MixedExplicit Debt: TodoComment
query/src/main/scala/filodb/query/exec/SetOperatorExec.scala6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 23

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 650

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 216

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 13

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 67 of 67 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); none rely on LLM judgement. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 67 dimensions across the health lenses
D1D2D3D4D5D6D9D12D13D14D15D16D17D19D26D28D29D30D34D35D37D43D44AX10AX2AX3AX4AX6AX9GD1IC1M1M2M3M4P1P10P2P3P6PF1PF2PF3S1X1X12X13X14X15X16X17X18X19X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 811 of 889 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement—◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a17714-2980-7712-94d4-b5d289f4ce45.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT READ here — but this repository measures it: a coverage step in CI (`scoverage`) shows that coverage is collected and tracked in your own CI. The built-in collector has no runner for this ecosystem (.scala), so the analyzer could not read the number — a gap in the analyzer's language coverage, not an unmeasured repo. Not scored. To have the real number read, produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.scala) and this repository declares an sbt build (repository root, 193 test files), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares an sbt build (REDACTED), but the licence verdict published here was taken over its crate dependencies. Nothing was read about its sbt dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D19 Documentation Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D21 Naming Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
  • D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22's deterministic call-shape rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. This says nothing about whether that surface is consistent.
  • D24 Comment Value — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `core/src/main/scala/filodb.core/metadata/ComputedColumn.scala`, `http/src/main/scala/filodb/http/PromQLGrpcServer.scala` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'com.datastax' is imported (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'com.datastax' is imported (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'com.datastax' is imported (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • GD1 Unfinished & placeholder code — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 33 further occurrence(s) are not listed individually; the score already reflects all 73.
  • IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 107 further occurrence(s) are not listed individually; the score already reflects all 147.
  • M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9). Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.9 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.9 / 10 · rule-coverage 100% · ceiling Prevented

22 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was PromQLParser.vectorExpression at 53. A further 32 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being RangeFunction.iteratingFunctionH at 37 — they are counted neither in the figure above nor in this dimension's score. 11 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: query/src/main/scala/filodb/query/exec/rangefn/RangeFunction.scala (RangeFunction.iteratingFunctionH at 37), coordinator/src/main/scala/filodb/coordinator/ProtoConverters.scala (InternalRangeFunctionFromProtoConverter.fromProto at 35), coordinator/src/main/scala/filodb.coordinator/queryplanner/LongTimeRangePlanner.scala (LongTimeRangePlanner.walkLogicalPlanTree at 34), query/src/main/scala/filodb/query/exec/InternalRangeFunction.scala (InternalRangeFunction.lpToInternalFunc at 30), query/src/main/scala/filodb/query/LogicalPlan.scala (LogicalPlan.hasOptimizeWithAgg at 29), and 6 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

PromQLParser.vectorExpression (cyclomatic 53)prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273
BinaryOperatorFunction.factoryMethod (cyclomatic 43)query/src/main/scala/filodb/query/exec/binaryOp/BinaryOperatorFunction.scala:20
CliMain.main (cyclomatic 35)cli/src/main/scala/filodb.cli/CliMain.scala:155
SimpleProfiler.examine (cyclomatic 33)standalone/src/main/java/filodb/standalone/SimpleProfiler.java:303
LogicalPlanUtils.getPeriodicSeriesPlan (cyclomatic 31)coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:343

+ 17 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 22 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with PromQLParser.vectorExpression (cyclomatic 53), BinaryOperatorFunction.factoryMethod (cyclomatic 43), CliMain.main (cyclomatic 35). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 22 together lifts Cyclomatic Complexity from 6.9 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.2 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Prevented

69 method(s) exceeded the cognitive complexity threshold of 15; the worst was Histogram.quantile at 83.

Histogram.quantile (cognitive 83)core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:71
PromQLParser.vectorExpression (cognitive 78)prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273
Latch.releaseExclusive (cognitive 60)core/src/main/java/filodb/memory/Latch.java:338
Latch.acquire (cognitive 55)core/src/main/java/filodb/memory/Latch.java:719
SimpleProfiler.examine (cognitive 51)standalone/src/main/java/filodb/standalone/SimpleProfiler.java:303

+ 64 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 60 down to 60 or less in Cognitive Complexity — start with Histogram.quantile (cognitive 83), PromQLParser.vectorExpression (cognitive 78). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 6.2 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.5 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

37 god class(es) detected.

TooManyMethods: TimeSeriesShard · ×17core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:268
FileTooLong: coordinator/ProtoConverters.scala · ×14coordinator/src/main/scala/filodb/coordinator/ProtoConverters.scala
ClassTooLong: PromQLParser · ×5prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:13
MethodTooLong: PromQLParser.vectorExpressionprometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273

What to do

  1. Resolve the 17 TooManyMethods finding(s) in God Classes — start with TimeSeriesShard.scala, PromQLParser.java, Latch.java. — One of this dimension's main actionable groups (17 warning-level).
  2. Resolve the 14 FileTooLong finding(s) in God Classes — start with ProtoConverters.scala (2), PromQLParser.java, TimeSeriesShard.scala. — One of this dimension's main actionable groups (14 warning-level).
  3. Resolve the 5 ClassTooLong finding(s) in God Classes — start with PromQLParser.java, MultiPartitionPlanner.scala, Latch.java. — One of this dimension's main actionable groups (5 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.4 / 10Stronggated by 116 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Verified

111 duplicated block group(s) detected. A further 5 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (10 lines × 2) · ×12coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:111
Duplicated block (9 lines × 2) · ×11coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:142
Duplicated block (5 lines × 2) · ×10coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:203
Duplicated block (7 lines × 2) · ×8core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:385
Duplicated block (6 lines × 2) · ×7cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:171

+ 49 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 12 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with NodeCoordinatorActor.scala, MapEncoder.scala, DownsampledTimeSeriesStore.scala. — One of this dimension's main actionable groups (12 warning-level).
  2. Resolve the 11 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with DownsampledTimeSeriesStore.scala (2), QueryActor.scala, IntBinaryVector.scala. — One of this dimension's main actionable groups (11 warning-level).
  3. Resolve the 10 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with DefaultPlanner.scala, LogicalPlanUtils.scala, MultiPartitionPlanner.scala. — One of this dimension's main actionable groups (10 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling7.3 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Prevented

3 production modules (Cargo+sbt), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; a dependsOn spread (deps: _*) and a project whose directory a helper computes are not visible there; 1 module(s) off the main sequence, with abstractness counted on 2 of the 3 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

Off the main sequence: tantivy_utils

What to do

  1. Resolve the 1 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (1 warning-level).
  2. Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.7 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

6 of 216 classes have LCOM4 above 3.

Low cohesion: CassandraColumnStore (LCOM4 6) · ×6cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:55

What to do

  1. Resolve the 6 Low cohesion finding(s) in Cohesion (LCOM4) — start with CassandraColumnStore.scala, ChunkSink.scala, PartitionSet.scala. — One of this dimension's main actionable groups (6 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2294 test methods: 2293 unit, 1 integration, 0 BDD, 0 e2e. The Rust suite contributes 101 `#[test]` function(s) across 17 file(s) declaring at least one; its unit/integration split is Cargo's own — 0 of those file(s) are integration-test targets under a crate's tests/ directory, and the rest are #[test] functions compiled into the crate they test. The Scala suite contributes 2193 test case(s) across 171 file(s) in a test source set declaring at least one — every `test("…")`, `it("…")`, `property("…")` and `"…" in {…}` registration and every JUnit `@Test`, which is how munit, ScalaTest, utest, ZIO Test and specs2 declare a case; a case registered under a computed name is not counted, so this is a floor. Its tier split is INFERRED from paths and file names, except sbt's src/it source set, which the build declares.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D12 · Dependency Hygiene8.0 / 10Strong✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Verified

65 outdated direct sbt declarations. An sbt declaration names an EXACT version, so the remedy is an edit to the build file — there is no lockfile refresh that would move it. Test-, Provided- and it-scoped declarations are excluded, because a consumer of this project never receives them. A version held in a Scala val is read only when the val is one string literal: sbt is a program rather than a manifest, and evaluating a computed version would invent the measurement rather than take it. Whether any artifact is DEPRECATED or ABANDONED is not graded and cannot be — Maven Central publishes no such marker, and release age does not stand in for one: the most widely depended-upon libraries are routinely the stalest, being finished rather than abandoned. Known CVEs in this dependency graph are D30's question.

Outdated: ch.qos.logback:logback-classic · ×65

What to do

  1. Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 176 shipped crate(s) use a banned license. Licences were resolved from crates.io over the crates a consumer compiles — this repository's REDACTED closed over its manifests' `[dependencies]` and `[build-dependencies]`. Crates it asks for ONLY under `[dev-dependencies]` are excluded: they are not compiled by anything that depends on this repository. ★ COVERAGE OF THIS VERDICT: it grades this repository's crate dependencies and nothing else. The repository also declares an sbt build (REDACTED), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala (3×20=60)

Hotspot: query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scalaquery/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala:61

What to do

  1. Resolve the 1 Hotspot finding(s) in Churn × Complexity Hotspots — start with PeriodicSamplesMapper.scala. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor9.3 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Documented

21 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is core/src/main/scala/filodb.core/memstore/PartKeyIndex.scala. Counted over 280 of the 426 production source files in this repository: 103 are under the ~2,400-byte size floor this dimension measures over, and the remaining 43 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×2
Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.3 / 10Stronggated by 292 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Prevented

292 deducted task-comment markers across 87651 LoC (0.3/KLoC) → score 9.3. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×244standalone/src/multi-jvm/scala/filodb/standalone/ClusterSingletonFailoverSpec.scala:168
FixmeComment · ×37spark-jobs/src/test/scala/filodb/downsampler/DownsamplerMainSpec.scala:2704
XxxComment · ×11standalone/src/main/java/filodb/standalone/SimpleProfiler.java:314

What to do

  1. Resolve the 244 TodoComment finding(s) in Explicit Debt — start with TimeSeriesShard.scala (9), PlannerHierarchySpec.scala (7), PromQlRemoteExec.scala (6). — One of this dimension's main actionable groups (244 warning-level).
  2. Resolve the 37 FixmeComment finding(s) in Explicit Debt — start with MultiPartitionPlanner.scala (4), BatchDownsampler.scala (3), MetadataRemoteExec.scala (3). — One of this dimension's main actionable groups (37 warning-level).
  3. Resolve the 11 XxxComment finding(s) in Explicit Debt — start with BinaryRecordSpec.scala (2), SimpleProfiler.java, RateFunctions.scala. — One of this dimension's main actionable groups (11 warning-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 documentation facets pass in full. 5 document(s) read across 1 unit(s).

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D26 · Project Cohesion5.0 / 10Adequate✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 4 build units (Cargo, sbt) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)6.4 / 10Adequate✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 6.4 / 10 · rule-coverage 100% · ceiling Documented

10 finding(s): 0 critical, 8 high, 2 medium, 0 low. 6 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 2 file(s) — `core/src/main/scala/filodb.core/metadata/ComputedColumn.scala`, `http/src/main/scala/filodb/http/PromQLGrpcServer.scala` — so no absence of findings in them is evidence of anything, and nothing in them was analysed. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 6 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (6 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities2.1 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 2.1 / 10 · rule-coverage 100% · ceiling Documented

19 finding(s): 2 critical, 5 high, 12 medium, 0 low.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 6 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3), REDACTED (3). — One of this dimension's main actionable groups (6 warning-level).
  2. Resolve the 5 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (4), REDACTED. — One of this dimension's main actionable groups (5 issue-level).
  3. Resolve the 2 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness6.0 / 10Adequate✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Documented

128 of 323 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is core/src/main/java/filodb/memory/Latch.java. Counted over 323 of the 426 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledge · ×8core/src/main/java/filodb/memory/Latch.java:1
Orphaned file · ×120standalone/src/main/java/filodb/standalone/SimpleProfiler.java:1
Further orphaned files (smaller)

What to do

  1. Resolve the 120 Orphaned file finding(s) in Knowledge Freshness — start with package.scala (2), SimpleProfiler.java, FiloRelation.scala. — One of this dimension's main actionable groups (120 recommendation-level).
  2. Resolve the 8 Orphaned knowledge finding(s) in Knowledge Freshness — start with Latch.java, BinaryVector.scala, ChunkMap.scala. — One of this dimension's main actionable groups (8 issue-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.9 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: PromQLLexer.java↔PromQLParser.java 100%; CountValuesRowAggregator.scala↔TopBottomKRowAggregator.scala 82%; InternalRangeFunction.scala↔AggrOverTimeFunctions.scala 55%

Change coupling: PromQLLexer.java ↔ PromQLParser.java · ×3prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java:1

What to do

  1. Resolve the 3 Change coupling finding(s) in Change Coupling — start with PromQLLexer.java, CountValuesRowAggregator.scala, InternalRangeFunction.scala. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D37 · Vulnerability-disclosure Policy10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.

Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

A vulnerability-disclosure policy (SECURITY.md) is published with a reporting contact.

✓ On the Gold path — maintain.

Detailed fixes: d37_recommendation.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 1 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.5 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `PromQLVisitor<T>` declares 43 abstract methods: `visitAddOp`, `visitAggregation`, `visitAndUnlessOp`, `visitAtModifier`, `visitBinaryOperation`, `visitBy`, `visitCompareOp`, `visitExpression`, `visitFunction`, `visitGroupLeft`, `visitGroupRight`, `visitGrouping`, `visitIgnoring`, `visitInstantOrRangeSelector`, `visitInstantSelector`, `visitLabelKeyword`, `visitLabelMatcher`, `visitLabelMatcherList`, `visitLabelMatcherOp`, `visitLabelName`, `visitLabelNameList`, `visitLimit`, `visitLimitOperation`, `visitLiteral`, `visitMetricKeyword`, `visitMetricName`, `visitModifier`, `visitMultOp`, `visitOffset`, `visitOn`, `visitOrOp`, `visitParameter`, `visitParameterList`, `visitParens`, `visitPowOp`, `visitSubquery`, `visitSubqueryOperation`, `visitUnaryOp`, `visitUnaryOperation`, `visitVector`, and 3 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — prometheus/src/main/java/filodb/prometheus/antlr/PromQLVisitor.java:12
  • `TimeSeriesStore` declares 22 abstract members: `store`, `metastore`, `setup`, `ingest`, `startIngestion`, `recoverIndex`, `createDataRecoveryObservable`, `indexNames`, `labelValues`, `labelNames`, `labelValuesWithFilters`, `singleLabelValueWithFilters`, `partKeysWithFilters`, `numPartitions`, `numRowsIngested`, `latestOffset`, `activeShards`, `refreshIndexForTesting`, `analyzeAndLogCorruptPtr`, `truncate`, `reset`, `shutdown`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — core/src/main/scala/filodb.core/memstore/TimeSeriesStore.scala:45
  • `BinaryAppendableVector[A]` declares 16 abstract members: `addr`, `maxBytes`, `numBytes`, `length`, `dispose`, `addNA`, `addData`, `addFromReaderNoNA`, `reader`, `copyToBuffer`, `apply`, `isAvailable`, `isAllNA`, `noNAs`, `finishCompaction`, `reset`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — core/src/main/scala/filodb.memory/format/BinaryVector.scala:266

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX9 · CQS / query purity10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.

Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.

Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.

GD1 · Unfinished & placeholder code9.6 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue in this repository's Scala: methods whose whole body is still `???` or a "not implemented" throw where nothing overrides them, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • `dispatchStreaming` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — coordinator/src/main/scala/filodb.coordinator/GrpcPlanDispatcher.scala:123, coordinator/src/main/scala/filodb/coordinator/RemoteActorPlanDispatcher.scala:34
  • `remoteExecHttpClient` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:50
  • `urlParams` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:51
  • `fromString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/KeyType.scala:165, core/src/main/scala/filodb.core/KeyType.scala:185
  • `earliestTime` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/memstore/PagedReadablePartition.scala:62
  • `params` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/metadata/ComputedColumn.scala:19
  • `setDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:309, core/src/main/scala/filodb.core/query/TransientRow.scala:408
  • `setString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:310, core/src/main/scala/filodb.core/query/TransientRow.scala:410
  • `notNull` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:311
  • `getBoolean` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:312, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:561
  • `getInt` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:313
  • `getDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:315, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:572
  • `getFloat` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:316, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:573
  • `getString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:317
  • `getAny` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:318, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:588
  • `getBlobBase` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:590, core/src/main/scala/filodb.memory/format/RowReader.scala:149, core/src/main/scala/filodb.memory/format/RowReader.scala:179, …
  • `getBlobOffset` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:591, core/src/main/scala/filodb.memory/format/RowReader.scala:150, core/src/main/scala/filodb.memory/format/RowReader.scala:180, …
  • `getBlobNumBytes` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:592, core/src/main/scala/filodb.memory/format/RowReader.scala:151, core/src/main/scala/filodb.memory/format/RowReader.scala:181, …
  • `readDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.memory/format/FastBufferReader.scala:61
  • `readFloat` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.memory/format/FastBufferReader.scala:62
  • `copyToBuffer` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:110, core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala:418
  • `apply` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:111

What to do

  • Finish or delete the members whose body is still `???` or a "not implemented" throw where nothing overrides them, and replace placeholder text before shipping.
IC1 · Incompleteness & stubs5.3 / 10Adequate✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Scala: methods whose body is `???` or only throws a "not implemented" error, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `dispatchStreaming` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — coordinator/src/main/scala/filodb.coordinator/GrpcPlanDispatcher.scala:123, coordinator/src/main/scala/filodb/coordinator/RemoteActorPlanDispatcher.scala:34
  • `PromQLFlightRemoteExec` has 2 unfinished members out of 4 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented. — coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:15
  • `remoteExecHttpClient` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:50
  • `urlParams` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:51
  • `fromString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/KeyType.scala:165, core/src/main/scala/filodb.core/KeyType.scala:185
  • `earliestTime` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/memstore/PagedReadablePartition.scala:62
  • `params` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/metadata/ComputedColumn.scala:19
  • `QuantileAggTransientRow` has 9 unfinished members out of 17 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented. — core/src/main/scala/filodb.core/query/TransientRow.scala:291
  • `setDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:309, core/src/main/scala/filodb.core/query/TransientRow.scala:408
  • `setString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:310, core/src/main/scala/filodb.core/query/TransientRow.scala:410
  • `notNull` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:311
  • `getBoolean` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:312, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:561
  • `getInt` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:313
  • `getDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:315, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:572
  • `getFloat` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:316, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:573
  • `getString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.core/query/TransientRow.scala:317
  • `getAny` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — core/src/main/scala/filodb.core/query/TransientRow.scala:318, core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:588
  • `ChunkInfoRowReader` has 7 unfinished members out of 13 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented. — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:554
  • `getBlobBase` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:590, core/src/main/scala/filodb.memory/format/RowReader.scala:149, core/src/main/scala/filodb.memory/format/RowReader.scala:179, …
  • `getBlobOffset` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:591, core/src/main/scala/filodb.memory/format/RowReader.scala:150, core/src/main/scala/filodb.memory/format/RowReader.scala:180, …
  • `getBlobNumBytes` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×4) — core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:592, core/src/main/scala/filodb.memory/format/RowReader.scala:151, core/src/main/scala/filodb.memory/format/RowReader.scala:181, …
  • `readDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.memory/format/FastBufferReader.scala:61
  • `readFloat` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — core/src/main/scala/filodb.memory/format/FastBufferReader.scala:62

What to do

  • Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
  • Clear the softer debt: re-enable or delete `ignore`d and `pending` tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace a bare `// scalastyle:off` or `@nowarn` with targeted, justified suppressions.
M1 · Documentation (README)7.3 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 4 of 4 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • 119/141 types (84%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

What to do

  • Keep implementation types off the public surface (Java: package-private (no modifier), or leave its package out of `module-info` exports; Rust: `pub(crate)`, or keep the module private) so internals can change without breaking consumers.
P2 · Observability9.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

What to do

  • Add a health-check endpoint (Spring Boot Actuator's /actuator/health, or a /health route) so orchestrators and load balancers can probe liveness/readiness.
P3 · Security & performance tooling5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
PF1 · Benchmark discipline8.5 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

  • A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured. — jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala

What to do

  • Run JMH with the GC profiler (`-prof gc`, or addProfiler(GCProfiler.class)) so allocation rate regressions are visible, not just time.
PF2 · Allocation hygiene6.8 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 145 use(s) across 89,228 production line(s) (~1.6/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
  • Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
  • Scala: on hot paths, make small wrappers value classes (extends AnyVal), @specialized generic code over primitives, use primitive collections, and presize builders.
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

S1 · Web-Security Posture6.0 / 10Adequate✓ Tool-verified

Other · Security — Read from this repository's Scala source and the Java beside it: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository serves HTTP itself (coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:13 — `NettyServerBuilder`), so its Scala source was also read for the server controls: TLS served or HSTS set, security response headers, cookie flags and inbound validation — each credited where its Scala spelling appears in production source, not proven on every route. A Play application is credited the security headers Play's default `SecurityHeadersFilter` sends unless its build or configuration switches that filter off, and its cookies the HttpOnly flag Play sets by default.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • This repository runs an HTTP server and nothing in its Scala source or committed configuration secures the transport: no HTTPS served (akka/pekko-http `ConnectionContext.httpsServer`/`enableHttps`, an http4s builder's `withTLS`, Jetty's `SslContextFactory`, zio-http's `SSLConfig`, Play's `https.port`), no `Strict-Transport-Security` header, HSTS middleware or Play `RedirectHttpsFilter`, no `X-Forwarded-Proto` read or Play `play.http.forwarded.trustedProxies` for a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:13 — `NettyServerBuilder`.
  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Scala server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:13 — `NettyServerBuilder`.

What to do

  • Secure the server's transport: serve TLS itself (akka/pekko-http `ConnectionContext.httpsServer(sslContext)` with `newServerAt(…).enableHttps(…)`, an http4s server builder's `withTLS(…)`, Play's `https.port`), or run it behind a TLS-terminating proxy and trust it (`X-Forwarded-Proto`; Play `play.http.forwarded.trustedProxies`); send `Strict-Transport-Security` once it is HTTPS-only (http4s `HSTS(…)`, Play `RedirectHttpsFilter`).
  • Set security response headers on what the server sends — keep Play's `SecurityHeadersFilter` enabled, wrap akka/pekko-http routes in `respondWithHeaders(RawHeader("X-Content-Type-Options", "nosniff"), …)`, or add an http4s middleware that sets `Content-Security-Policy`, `X-Content-Type-Options` and a frame policy on every response.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader2.2 / 10Critical✓ Tool-verified

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

  • `strLen` is read from the bytes being parsed at line 176 (`getInt`), then used to size a `new Array[Byte]` at line 177 — and nowhere in its scope is `strLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `strLen` against the bytes actually remaining and a maximum the format allows before allocating. — core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:177
  • `strLen` is read from the bytes being parsed at line 193 (`getInt`), then used to size a `new Array[Byte]` at line 194 — and nowhere in its scope is `strLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `strLen` against the bytes actually remaining and a maximum the format allows before allocating. — core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:194
  • `pkLen` is read from the bytes being parsed at line 352 (`getInt`), then used to size a `new Array[Byte]` at line 353 — and nowhere in its scope is `pkLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `pkLen` against the bytes actually remaining and a maximum the format allows before allocating. — core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:353

What to do

  • Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness3.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `scala.io.Source.fromURL(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.getLines` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(scala.io.Source.fromURL(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — stress/src/main/scala/filodb.stress/MemStoreStress.scala:45
  • `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.getLines` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — core/src/main/scala/filodb.memory/format/vectors/HistogramCompressor.scala:32

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `RefCell` it is walking alone — safe Rust rejects a body that changes the collection its loop borrows at compile time, except through interior mutability: a `RefCell` borrowed in the loop's header stays borrowed until the loop ends, so a `borrow_mut()` of it inside the body panics with `already borrowed: BorrowMutError` and the remaining elements are never seen. Whether a `for` comprehension or `foreach` leaves the mutable collection it is walking alone — an `ArrayBuffer` or `ListBuffer` counts its changes and its iterator checks the count, an `ArrayDeque` (and `mutable.Queue`/`mutable.Stack`) is walked by index up to its starting length, and a `java.util` collection walked through `asScala` is fail-fast, so a body that adds to or removes from the very collection the loop is walking makes a later step throw `ConcurrentModificationException` (`IndexOutOfBoundsException` for a deque) and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.5 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — standalone/src/main/java/filodb/standalone/SimpleProfiler.java:120
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×2) — standalone/src/main/java/filodb/standalone/SimpleProfiler.java:141, spark/src/it/scala/filodb.spark/SparkTestBase.scala:39

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging3.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `info` at line 45 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:45
  • `info` at line 66 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:66
  • `info` at line 71 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:71
  • `error` at line 243 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:243

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Scala's null is held to the type system and not undermined by assertions — a file compiled with `-Yexplicit-nulls` is one where `String` excludes null and `String | Null` admits it, a file under WartRemover's `Null` wart or Scalafix's `DisableSyntax.noNulls` is one whose code cannot write `null` and must say `Option`, and each `.nn`, `import scala.language.unsafeNulls` or null-lint suppression is the author overruling that.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • No build over this repository's 375 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.

What to do

  • On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health50%Adequate — gated by X4, X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture93%ExemplaryStrongest area.
Maturity74%StrongSolid.
Readiness66%StrongSolid.
Security69%Adequate — gated by D30Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance81%StrongSolid.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • D36 Supply-chain Provenance & Signing — 1 observation(s) recorded · The CI pipeline builds and tests but publishes no released artifact — no package publish, container push, GitHub release or deployment step. Supply-chain provenance, signing and SBOM attest RELEASED artifacts, so there is nothing to attest here. Add them to the release pipeline when this repo starts shipping artifacts (a published package, a container image, a deployed service or a tagged release). Build integrity and workflow-token hygiene are reported below: they describe what the CI runs and the token it runs with, neither of which is affected by whether the pipeline ships an artifact.
  • X10 Duplicated predicate — 11 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 5 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: this repository stores data through 'com.datastax' (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether its changes need an audit trail could not be established, and the trail's absence is not scored.
  • C4 Data Retention — Not assessed: this repository stores data through 'com.datastax' (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether a retention limit applies here could not be established, and its absence is not scored.
  • C5 Data-Subject Rights — Not assessed: this repository stores data through 'com.datastax' (spark-jobs/src/main/scala/filodb/downsampler/DownsamplerContext.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether data-subject rights apply here could not be established, and their absence is not scored.
  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 45 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — Not applicable: this repository's Java imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; Rust with no dependency-injection crate has no container to hand one lifetime's instance to another — every value is owned by the code that builds it, and the borrow checker rejects a longer-lived value keeping a borrow of a shorter-lived one; this repository's Scala imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~60830 lines of test source are present (.scala) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .scala suite was found but not re-run
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D21 Naming Consistency — Naming consistency is measured on C# only; Java, Python, Rust, Scala not measured.
  • D22 Internal API Consistency — API consistency is measured on C# only; the exposed Rust surface was not measured.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C# and Visual Basic comments only — this repository's production source is .java, .rs, .scala, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.scala), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 2 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (2 signals for this style, 2 needed — the count is met but a required primary signal is absent): 654 value object(s); 3 domain event(s); its domain events are published by services or handlers — no domain entity raises one
  • ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and a call made through an inferred or generic receiver has no resolvable owner in the source. Reported as guidance rather than measured
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, Rust source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • X2 Cancellation propagation — no C# was loaded; this repository's Scala, Java and Rust were read, and no request in it can be cancelled by a caller — a Scala request takes no token: a Future cannot be cancelled, and cats-effect, ZIO and Monix interrupt the fiber that made the request from outside the call, not through a parameter; a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter; a Rust request takes no token: a future is cancelled by dropping it, from outside the call (select!, a timeout, an aborted task), and reqwest, hyper and tonic take none
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 23 finding(s)
D34 · Knowledge Freshness · Orphaned knowledge · ×8
  • Orphaned knowledge core/src/main/java/filodb/memory/Latch.java:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge core/src/main/scala/filodb.memory/format/BinaryVector.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge core/src/main/scala/filodb.memory/data/ChunkMap.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge core/src/main/scala/filodb.core/memstore/PartitionSet.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge coordinator/src/main/scala/filodb.coordinator/NodeClusterActor.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge prometheus/src/main/scala/filodb/prometheus/parse/LegacyParser.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge core/src/main/scala/filodb.memory/format/RowReader.scala:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×5
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Critical CVE · ×2
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 650 finding(s)
D17 · Explicit Debt · TodoComment · ×244
  • TodoComment standalone/src/multi-jvm/scala/filodb/standalone/ClusterSingletonFailoverSpec.scala:168 — // TODO check second=UnknownDataset — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/multi-jvm/scala/filodb/standalone/ClusterSingletonFailoverSpec.scala:196 — // TODO use the testConductor for this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/multi-jvm/scala/filodb/standalone/StandaloneMultiJvmSpec.scala:164 — // TODO: maybe do a sum_over_time() as current windowing just gets last data point — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/main/scala/filodb.standalone/FiloServer.scala:72 — // TODO: Remove hardcoding — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/main/scala/filodb.standalone/NewFiloServerMain.scala:72 — // TODO: Remove hardcoding — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/main/scala/filodb.standalone/FiloServer.scala:97 — // TODO configure — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment standalone/src/main/scala/filodb.standalone/FiloServer.scala:117 — // TODO can remove once new-startup is tested and proven — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark-jobs/src/test/scala/filodb/repair/PartitionKeysCopierSpec.scala:152 — // TODO unused in v2; remove when migration to v2 tables is done — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopierValidator.scala:108 — // TODO PartKeys V2 Table handling is not done yet. Needs to be tasked. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark-jobs/src/main/scala/filodb/downsampler/chunk/BatchDownsampler.scala:119 — // TODO fix — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark-jobs/src/main/scala/filodb/downsampler/chunk/BatchDownsampler.scala:378 — // TODO compressChunk(bytes) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/test/scala/filodb.spark/InMemoryStoreTest.scala:39 — // TODO: test getting ingestion stats from all nodes — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/it/scala/filodb.spark/ClusterIngestTest.scala:47 — // TODO: test getting ingestion stats from all nodes — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/test/scala/filodb.spark/SaveAsFiloTest.scala:355 — // TODO: test one sided comparisons eg eventId >= 50 only — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/test/scala/filodb.spark/SparkTestBase.scala:23 — // TODO: so in theory when the dataset is setup, memStore.setup() should cause the ChunkSink — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/it/scala/filodb.spark/SparkTestBase.scala:23 — // TODO: so in theory when the dataset is setup, memStore.setup() should cause the ChunkSink — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/main/scala/filodb.spark/FiloContext.scala:151 — // TODO: actually figure out right number of nodes. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/main/scala/filodb.spark/FiloRelation.scala:26 — // TODO(velvia): Make them per-table? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment spark/src/main/scala/filodb.spark/package.scala:179 — // TODO: fix: cannot serialize CreateDataset actor message — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment query/src/test/scala/filodb/query/LogicalPlanSpec.scala:298 — // TODO: these tests (and TsCardinalities construction requirements) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment query/src/test/scala/filodb/query/PromCirceSupportSpec.scala:589 — // TODO: Would this be flaky? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment query/src/test/scala/filodb/query/ProtoConvertersSpec.scala:276 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment prometheus/src/test/scala/filodb/prometheus/parse/ParserSpec.scala:604 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment coordinator/src/test/scala/filodb.coordinator/queryplanner/PlannerHierarchySpec.scala:3015 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment coordinator/src/test/scala/filodb.coordinator/queryplanner/PlannerHierarchySpec.scala:3124 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 219 more in this group — see findings.md.
GD1 · Unfinished & placeholder code · Unfinished stub · ×40
  • Unfinished stub — body is `???` coordinator/src/main/scala/filodb.coordinator/GrpcPlanDispatcher.scala:123 — `dispatchStreaming` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` coordinator/src/main/scala/filodb/coordinator/RemoteActorPlanDispatcher.scala:34 — `dispatchStreaming` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:50 — `remoteExecHttpClient` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:51 — `urlParams` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/KeyType.scala:165 — `fromString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/KeyType.scala:185 — `fromString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/memstore/PagedReadablePartition.scala:62 — `earliestTime` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/metadata/ComputedColumn.scala:19 — `params` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:309 — `setDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:310 — `setString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:311 — `notNull` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:312 — `getBoolean` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:313 — `getInt` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:315 — `getDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:316 — `getFloat` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:317 — `getString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:318 — `getAny` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:408 — `setDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/query/TransientRow.scala:410 — `setString` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:561 — `getBoolean` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:572 — `getDouble` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:573 — `getFloat` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:588 — `getAny` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:590 — `getBlobBase` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:591 — `getBlobOffset` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • + 15 more in this group — see findings.md.
D17 · Explicit Debt · FixmeComment · ×37
  • FixmeComment spark-jobs/src/test/scala/filodb/downsampler/DownsamplerMainSpec.scala:2704 — // FIXME: Each of these will fail on GitHub when parallelism != 1. When an abundance of logs are added in order to — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment spark-jobs/src/main/scala/filodb/downsampler/Utils.scala:24 — // FIXME: need a dynamic (but efficient) way to determine this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment spark-jobs/src/main/scala/filodb/downsampler/chunk/BatchDownsampler.scala:109 — // FIXME * 4 exists to workaround an issue where we see under-allocation for metaspan due to — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment spark-jobs/src/main/scala/filodb/downsampler/chunk/BatchDownsampler.scala:367 — // FIXME if listener in chunkset below is not copied + overridden to no-op, we get a SEGV because — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment spark-jobs/src/main/scala/filodb/downsampler/chunk/BatchDownsampler.scala:411 — // FIXME if listener in chunkset below is not copied + overridden to no-op, we get a SEGV because — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment REDACTED:119 — // FIXME: scala immutable wrapper? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment REDACTED:273 — // FIXME: need a more dynamic (but efficient) solution — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/LogicalPlan.scala:404 — // FIXME - TechDebt - This class should not be a PeriodicSeriesPlan — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/PlanEnums.scala:155 — // FIXME when implemented — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/PlanEnums.scala:161 — // FIXME when implemented — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/ProtoConverters.scala:1136 — // FIXME This is behind feature flag and should not be activated in prod since performance will be bad, but we — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:122 — // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:149 — // FIXME need to send and parse query stats in remote calls — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:169 — // FIXME need to send and parse query stats in remote calls — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala:230 — // FIXME dont like that this is hardcoded; but the check is needed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment query/src/main/scala/filodb/query/exec/RemoteExec.scala:68 — // FIXME: QueryResponse should contain fields common to Result/Error — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment prometheus/src/test/scala/filodb/prometheus/parse/ParserSpec.scala:1110 — // FIXME: don't catch any exception when subquery support is finished — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.memory/format/ZeroCopyBinary.scala:117 — // FIXME Needs to use MemoryAccessor — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:392 — // FIXME why is Geo minus one using delta encoding ? Possible bug since unpack assumes double encoding. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:612 — // FIXME Use MemoryAccessor methods here instead of unsafe access. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.core/query/RangeVector.scala:214 — // FIXME remove default in numRows since many impls simply default to None. Shouldn't scalars implement this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.core/query/RangeVector.scala:827 — // FIXME since multiple RVs can be serialized into the same VSR, this may not be accurate for all RVs. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala:445 — // FIXME this API returns duplicate values because same value can be present in multiple lucene segments — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:705 — // FIXME This is non-performant and temporary fix for fetching label values based on filter criteria. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:573 — // FIXME This is non-performant and temporary fix for fetching label values based on filter criteria. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 12 more in this group — see findings.md.
IC1 · Incompleteness & stubs · Unfinished stub · ×37
  • Unfinished stub — body is ??? / NotImplementedError coordinator/src/main/scala/filodb.coordinator/GrpcPlanDispatcher.scala:123 — `dispatchStreaming` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError coordinator/src/main/scala/filodb/coordinator/RemoteActorPlanDispatcher.scala:34 — `dispatchStreaming` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:50 — `remoteExecHttpClient` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:51 — `urlParams` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/KeyType.scala:165 — `fromString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/KeyType.scala:185 — `fromString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/memstore/PagedReadablePartition.scala:62 — `earliestTime` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/metadata/ComputedColumn.scala:19 — `params` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:309 — `setDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:310 — `setString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:311 — `notNull` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:312 — `getBoolean` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:313 — `getInt` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:315 — `getDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:316 — `getFloat` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:317 — `getString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:318 — `getAny` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:408 — `setDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/query/TransientRow.scala:410 — `setString` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:561 — `getBoolean` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:572 — `getDouble` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:573 — `getFloat` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:588 — `getAny` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:590 — `getBlobBase` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:591 — `getBlobOffset` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • + 12 more in this group — see findings.md.
D3 · God Classes · TooManyMethods · ×17
  • TooManyMethods: TimeSeriesShard core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:268 — TooManyMethods — 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PromQLParser prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:13 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Latch core/src/main/java/filodb/memory/Latch.java:42 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: RecordBuilderBase core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:18 — TooManyMethods — 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShardManager coordinator/src/main/scala/filodb.coordinator/ShardManager.scala:28 — TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PromQLBaseVisitor prometheus/src/main/java/filodb/prometheus/antlr/PromQLBaseVisitor.java:14 — TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. Most of these members implement antlr.PromQLVisitor (43 of 43 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
  • TooManyMethods: PartKeyLuceneIndex core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala:69 — TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MultiPartitionPlanner coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:89 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: RecordSchema core/src/main/scala/filodb.core/binaryrecord2/RecordSchema.scala:47 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PartitionSet core/src/main/scala/filodb.core/memstore/PartitionSet.scala:40 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: UnsafeUtils core/src/main/scala/filodb.memory/format/UnsafeUtils.scala:9 — TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PartKeyIndexRaw core/src/main/scala/filodb.core/memstore/PartKeyIndex.scala:61 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ShardMapper coordinator/src/main/scala/filodb.coordinator/ShardMapper.scala:26 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TimeSeriesMemStore core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:26 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SingleClusterPlanner coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:54 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TimeSeriesPartition core/src/main/scala/filodb.core/memstore/TimeSeriesPartition.scala:64 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ChunkSetInfo core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:128 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · FileTooLong · ×14
  • FileTooLong: coordinator/ProtoConverters.scala coordinator/src/main/scala/filodb/coordinator/ProtoConverters.scala — FileTooLong — 2103 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1603 over it, 4.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: antlr/PromQLParser.java prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java — FileTooLong — 1862 significant lines (blank, comment-only and punctuation-only lines excluded), about 99% of them inside a single declaration: PromQLParser (13-2795). The bar is 500 significant lines; this is 1362 over it, 3.72× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: memstore/TimeSeriesShard.scala core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala — FileTooLong — 1224 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 724 over it, 2.45× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: rangefn/AggrOverTimeFunctions.scala query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala — FileTooLong — 1168 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 668 over it, 2.34× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: queryplanner/MultiPartitionPlanner.scala coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala — FileTooLong — 964 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: MultiPartitionPlanner (89-1552). The bar is 500 significant lines; this is 464 over it, 1.93× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: query/ProtoConverters.scala query/src/main/scala/filodb/query/ProtoConverters.scala — FileTooLong — 856 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 356 over it, 1.71× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: memstore/PartKeyLuceneIndex.scala core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala — FileTooLong — 731 significant lines (blank, comment-only and punctuation-only lines excluded), about 62% of them inside a single declaration: PartKeyLuceneIndex (69-748). The bar is 500 significant lines; this is 231 over it, 1.46× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: queryplanner/SingleClusterPlanner.scala coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala — FileTooLong — 699 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: SingleClusterPlanner (54-1179). The bar is 500 significant lines; this is 199 over it, 1.40× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: query/LogicalPlan.scala query/src/main/scala/filodb/query/LogicalPlan.scala — FileTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 103 over it, 1.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: memory/Latch.java core/src/main/java/filodb/memory/Latch.java — FileTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded), about 99% of them inside a single declaration: Latch (42-1164). The bar is 500 significant lines; this is 82 over it, 1.16× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: exec/ExecPlan.scala query/src/main/scala/filodb/query/exec/ExecPlan.scala — FileTooLong — 582 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 82 over it, 1.16× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: conversion/InputRecord.scala gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala — FileTooLong — 577 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 77 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: queryplanner/DefaultPlanner.scala coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala — FileTooLong — 547 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 47 over it, 1.09× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: columnstore/CassandraColumnStore.scala cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala — FileTooLong — 530 significant lines (blank, comment-only and punctuation-only lines excluded), about 79% of them inside a single declaration: CassandraColumnStore (55-691). The bar is 500 significant lines; this is 30 over it, 1.06× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×12
  • Duplicated block (10 lines × 2) coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:111 — coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:111-120 | coordinator/src/main/scala/filodb/coordinator/v2/NewNodeCoordinatorActor.scala:169-178 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:111` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala:255 — core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala:255-264 | core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala:287-296 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala:255` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:81 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:81-90 | core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:106-115 — before extracting anything, compare `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala` and `core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:71 — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:71-80 | core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala:360-369 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:424 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:424-433 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:631-640 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:424` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:119 — jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:119-128 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:135-144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) jmh/src/main/scala/filodb.jmh/QueryAndIngestBenchmark.scala:169 — jmh/src/main/scala/filodb.jmh/QueryAndIngestBenchmark.scala:169-178 | jmh/src/main/scala/filodb.jmh/QueryOnDemandBenchmark.scala:153-162 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:226 — query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:226-235 | query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:264-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:226` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:262` calls `setDouble` and `query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:224` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) query/src/main/scala/filodb/query/exec/ScalarFixedDoubleExec.scala:62 — query/src/main/scala/filodb/query/exec/ScalarFixedDoubleExec.scala:62-71 | query/src/main/scala/filodb/query/exec/TimeScalarGeneratorExec.scala:71-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/ScalarFixedDoubleExec.scala:62` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:31 — spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:31-40 | spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopier.scala:28-37 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) core/src/rust/filodb_core/src/ingestion/fields.rs:56 — core/src/rust/filodb_core/src/ingestion/fields.rs:56-65 | core/src/rust/filodb_core/src/ingestion/fields.rs:95-104 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) core/src/rust/tantivy_utils/src/collectors/part_key_collector.rs:21 — core/src/rust/tantivy_utils/src/collectors/part_key_collector.rs:21-30 | core/src/rust/tantivy_utils/src/collectors/part_key_record_collector.rs:31-40 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D17 · Explicit Debt · XxxComment · ×11
  • XxxComment standalone/src/main/java/filodb/standalone/SimpleProfiler.java:314 — // XXX: only profile threads which are query scheduler threads — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala:86 — // println(s"XXX: windowStart=$windowStart windowEnd=$windowEnd numSamples=$numSamples") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment jmh/src/main/scala/filodb.jmh/QueryAndIngestBenchmark.scala:95 — // println(s" XXX: --> Got ${bytes.map(_.size).sum} bytes in shard $shard") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment jmh/src/main/scala/filodb.jmh/QueryHiCardInMemoryBenchmark.scala:91 — // println(s" XXX: --> Got ${bytes.map(_.size).sum} bytes in shard $shard") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:103 — // println(s" XXX: --> Got ${bytes.map(_.size).sum} bytes in shard $shard") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment jmh/src/main/scala/filodb.jmh/QueryOnDemandBenchmark.scala:108 — // println(s" XXX: --> Got ${bytes.map(_.size).sum} bytes in shard $shard") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment core/src/test/scala/filodb.memory/BlockSpec.scala:71 — //XXX for debugging — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment core/src/test/scala/filodb.memory/format/vectors/HistogramVectorTest.scala:254 — // XXX — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment core/src/test/scala/filodb.core/memstore/PartitionSetSpec.scala:48 — // println(s"XXX container base = ${builder.allContainers.head.base}") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment core/src/test/scala/filodb.core/binaryrecord2/BinaryRecordSpec.scala:268 — // println(s"XXX: got key, ${UTF8StringMedium.toString(keyBase, keyOffset)}") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment core/src/test/scala/filodb.core/binaryrecord2/BinaryRecordSpec.scala:440 — // println(s"XXX: offset = $off hash = $lastHash") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×11
  • Duplicated block (9 lines × 2) coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:142 — coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:142-150 | coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:169-177 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:142` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:86 — core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:86-94 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:97-105 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:88 — jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:88-96 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:104-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:88` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) query/src/main/scala/filodb/query/exec/RemoteExec.scala:192 — query/src/main/scala/filodb/query/exec/RemoteExec.scala:192-200 | query/src/main/scala/filodb/query/exec/RemoteExec.scala:210-218 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:244 — query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:244-252 | query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:274-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:244` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) query/src/main/scala/filodb/query/exec/rangefn/RangeInstantFunctions.scala:232 — query/src/main/scala/filodb/query/exec/rangefn/RangeInstantFunctions.scala:232-240 | query/src/main/scala/filodb/query/exec/rangefn/RangeInstantFunctions.scala:262-270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/rangefn/RangeInstantFunctions.scala:232` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) coordinator/src/main/scala/filodb/coordinator/flight/FiloDBMultiPartitionFlightProducer.scala:51 — coordinator/src/main/scala/filodb/coordinator/flight/FiloDBMultiPartitionFlightProducer.scala:51-59 | coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:52-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (9 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:51 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:51-59 | core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:68-76 — before extracting anything, compare `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala` and `core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:51` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:162 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:162-170 | core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:254-262 — before extracting anything, compare `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala` and `core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:162` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (9 lines × 2) core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:140 — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:140-148 | core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala:574-582 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (9 lines × 2) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1667 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1667-1675 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2384-2392 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1667` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×10
  • Duplicated block (5 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:203 — coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:203-207 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:873-877 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:633 — coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:633-637 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:118-122 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:633` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1370 — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1370-1375 | coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1513-1517 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1370` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) query/src/main/scala/filodb/query/LogicalPlan.scala:245 — query/src/main/scala/filodb/query/LogicalPlan.scala:245-252 | query/src/main/scala/filodb/query/LogicalPlan.scala:411-415 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:114 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:114-118 | core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:136-140 — before extracting anything, compare `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala` and `core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) core/src/main/scala/filodb.core/memstore/EvictablePartIdQueueSet.scala:93 — core/src/main/scala/filodb.core/memstore/EvictablePartIdQueueSet.scala:93-97 | query/src/main/scala/filodb/query/util/IndexedArrayQueue.scala:53-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:150 — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:150-154 | core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala:584-588 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:160` calls `LongHistogram` and `core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala:592` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) query/src/main/scala/filodb/query/exec/SelectRawPartitionsExec.scala:23 — query/src/main/scala/filodb/query/exec/SelectRawPartitionsExec.scala:23-27 | query/src/main/scala/filodb/query/exec/SelectRawPartitionsExec.scala:31-35 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java:50 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java:50-54 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:53-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java:50` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:329 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:329-333 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2395-2399 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:329` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×8
  • Duplicated block (7 lines × 2) core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:385 — core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:385-391 | core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:416-422 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.core/binaryrecord2/RecordBuilderBase.scala:385` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:140 — gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:140-146 | gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:179-185 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:147` calls `sin`, `nextGaussian` and `gateway/src/main/scala/filodb/timeseries/TestTimeseriesProducer.scala:187` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) jmh/src/main/scala/filodb.jmh/FlightRpcBenchmark.scala:348 — jmh/src/main/scala/filodb.jmh/FlightRpcBenchmark.scala:348-354 | jmh/src/main/scala/filodb.jmh/FlightRpcBenchmark.scala:493-499 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jmh/src/main/scala/filodb.jmh/FlightRpcBenchmark.scala:348` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) query/src/main/scala/filodb/query/exec/BinaryJoinExec.scala:114 — query/src/main/scala/filodb/query/exec/BinaryJoinExec.scala:114-120 | query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:58-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/BinaryJoinExec.scala:114` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:739 — query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:739-745 | query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:906-912 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:739` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) spark-jobs/src/main/scala/filodb/labelchurnfinder/HllSketchAgg.scala:26 — spark-jobs/src/main/scala/filodb/labelchurnfinder/HllSketchAgg.scala:26-32 | spark-jobs/src/main/scala/filodb/labelchurnfinder/HllSketchMergeAgg.scala:29-35 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) query/src/main/scala/filodb/query/exec/aggregator/StddevRowAggregator.scala:32 — query/src/main/scala/filodb/query/exec/aggregator/StddevRowAggregator.scala:32-38 | query/src/main/scala/filodb/query/exec/aggregator/StdvarRowAggregator.scala:45-51 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) core/src/rust/tantivy_utils/src/collectors/part_id_collector.rs:66 — core/src/rust/tantivy_utils/src/collectors/part_id_collector.rs:66-72 | core/src/rust/tantivy_utils/src/collectors/time_collector.rs:78-84 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×7
  • Duplicated block (6 lines × 2) cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:171 — cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:171-176 | cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala:181-186 — before extracting anything, compare `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala` and `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:823 — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:823-828 | coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:872-877 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:830` calls `val` and `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:879` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:568 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:568-578 | core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:622-627 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:568` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:125 — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:125-130 | core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala:177-182 — before extracting anything, compare `core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala` and `core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 39 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:953 — query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:953-958 | query/src/main/scala/filodb/query/exec/rangefn/RateFunctions.scala:474-479 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 2) jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:147 — jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:147-152 | jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:141-146 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (6 lines × 2) query/src/main/scala/filodb/query/exec/aggregator/CountValuesRowAggregator.scala:127 — query/src/main/scala/filodb/query/exec/aggregator/CountValuesRowAggregator.scala:127-132 | query/src/main/scala/filodb/query/exec/aggregator/QuantileRowAggregator.scala:77-83 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D30 · Dependency Vulnerabilities · Medium CVE · ×6
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D6 · Cohesion (LCOM4) · Low cohesion · ×6
  • Low cohesion: CassandraColumnStore (LCOM4 6) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:55 — CassandraColumnStore's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ChunkSinkStats (LCOM4 5) core/src/main/scala/filodb.core/store/ChunkSink.scala:100 — ChunkSinkStats's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PartitionSet (LCOM4 4) core/src/main/scala/filodb.core/memstore/PartitionSet.scala:40 — PartitionSet's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CardinalityRoute (LCOM4 4) http/src/main/scala/filodb/http/CardinalityRoute.scala:61 — CardinalityRoute's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: QuantileRowAggregator (LCOM4 4) query/src/main/scala/filodb/query/exec/aggregator/QuantileRowAggregator.scala:21 — QuantileRowAggregator's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: StandaloneMultiJvmSpec (LCOM4 4) standalone/src/multi-jvm/scala/filodb/standalone/StandaloneMultiJvmSpec.scala:36 — StandaloneMultiJvmSpec's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
D3 · God Classes · ClassTooLong · ×5
  • ClassTooLong: PromQLParser prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:13 — ClassTooLong — 1852 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods. The bar is 400 significant lines; this is 1452 over it, 4.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: MultiPartitionPlanner coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:89 — ClassTooLong — 920 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 400 significant lines; this is 520 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: Latch core/src/main/java/filodb/memory/Latch.java:42 — ClassTooLong — 575 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 400 significant lines; this is 175 over it, 1.44× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: CassandraColumnStore cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:55 — ClassTooLong — 418 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 18 over it, 1.05× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DownsampledTimeSeriesShard core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesShard.scala:56 — ClassTooLong — 407 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 7 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D30 · Dependency Vulnerabilities · Medium advisory (unsound) · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×4
  • Duplicated block (22 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:831 — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:831-852 | coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:879-900 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:831` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:830` calls `val` and `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:878` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (22 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:350 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:350-371 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:443-464 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:350` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:243 — spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:243-264 | spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopierValidator.scala:202-223 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:243` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2102 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2102-2123 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2150-2171 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2102` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×4
  • Duplicated block (8 lines × 2) coordinator/src/main/scala/filodb.coordinator/KamonLogger.scala:33 — coordinator/src/main/scala/filodb.coordinator/KamonLogger.scala:33-40 | coordinator/src/main/scala/filodb.coordinator/KamonLogger.scala:43-50 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:42 — query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:42-49 | query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:52-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:42` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala:148 — query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala:148-157 | query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala:159-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala:148` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) core/src/rust/filodb_core/src/reader.rs:108 — core/src/rust/filodb_core/src/reader.rs:108-115 | core/src/rust/filodb_core/src/reader.rs:413-420 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D35 · Change Coupling · Change coupling · ×3
  • Change coupling: PromQLLexer.java ↔ PromQLParser.java prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java:1 — `prometheus/src/main/java/filodb/prometheus/antlr/PromQLLexer.java` and `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java` change together 100% of the time (10 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `72dd10c4` feat(query): More efficient Prometheus histogram_avg function (#2302); `d7e21e36` JDK21 branch merge (#2268); `707e5cc6` fix(prometheus): Add INF & NAN support in parser (#2078) — run `git show` on any of them.
  • Change coupling: CountValuesRowAggregator.scala ↔ TopBottomKRowAggregator.scala query/src/main/scala/filodb/query/exec/aggregator/CountValuesRowAggregator.scala:1 — `query/src/main/scala/filodb/query/exec/aggregator/CountValuesRowAggregator.scala` and `query/src/main/scala/filodb/query/exec/aggregator/TopBottomKRowAggregator.scala` change together 82% of the time (9 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `7c620d6c` fix potential resource leak. (#1922); `22d0b089` fix(query) Fixed mismatched schema regarding fixedVectorLen. (#1855); `b32070ce` Revert "debug(core): Restore chunk-map-lock debugging since we have a… — run `git show` on any of them.
  • Change coupling: InternalRangeFunction.scala ↔ AggrOverTimeFunctions.scala query/src/main/scala/filodb/query/exec/InternalRangeFunction.scala:1 — `query/src/main/scala/filodb/query/exec/InternalRangeFunction.scala` and `query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `fdc7fb1d` (query) implement ts_of_max|min_over_time. (#2029); `463b9761` feat(query) Range function to identify outliers using MAD (#1944); `4ec845af` feat(core): Min-max versions of histogram quantile and fraction for e… — run `git show` on any of them.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:120 — cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:120-132 | cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala:130-142 — before extracting anything, compare `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala` and `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:143 — cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala:143-155 | cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala:153-165 — before extracting anything, compare `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysTable.scala` and `cassandra/src/main/scala/filodb.cassandra/columnstore/PartitionKeysV2Table.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 2) query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:1750 — query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:1750-1762 | query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:1784-1796 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
IC1 · Incompleteness & stubs · Skeleton type · ×3
  • Skeleton type — most members are unfinished coordinator/src/main/scala/filodb/coordinator/flight/PromQLFlightRemoteExec.scala:15 — `PromQLFlightRemoteExec` has 2 unfinished members out of 4 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented.
  • Skeleton type — most members are unfinished core/src/main/scala/filodb.core/query/TransientRow.scala:291 — `QuantileAggTransientRow` has 9 unfinished members out of 17 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented.
  • Skeleton type — most members are unfinished core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:554 — `ChunkInfoRowReader` has 7 unfinished members out of 13 declared methods (whether or not each carries a body) — a scaffolded class that was never implemented.
X15 · Unvalidated length from an untrusted reader · Length read from the parsed input is spent without ever being bounded · ×3
  • Length read from the parsed input is spent without ever being bounded core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:177 — `strLen` is read from the bytes being parsed at line 176 (`getInt`), then used to size a `new Array[Byte]` at line 177 — and nowhere in its scope is `strLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `strLen` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:194 — `strLen` is read from the bytes being parsed at line 193 (`getInt`), then used to size a `new Array[Byte]` at line 194 — and nowhere in its scope is `strLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `strLen` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:353 — `pkLen` is read from the bytes being parsed at line 352 (`getInt`), then used to size a `new Array[Byte]` at line 353 — and nowhere in its scope is `pkLen` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `pkLen` against the bytes actually remaining and a maximum the format allows before allocating.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
  • Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:158 — jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:158-170 | jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:176-188 | jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:194-206 | jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:153-165 | jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:178-190 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
  • Members sharing a duplicated core (5 members, 50+ identical tokens) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:86 — jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:86-96 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:102-112 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:118-128 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:134-144 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:240-251 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×2
  • Duplicated block (18 lines × 2) query/src/main/scala/filodb/query/exec/ExecPlan.scala:294 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:294-311 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:551-568 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/ExecPlan.scala:294` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `query/src/main/scala/filodb/query/exec/ExecPlan.scala:549` calls `debug` and `query/src/main/scala/filodb/query/exec/ExecPlan.scala:293` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (18 lines × 2) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1756 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1756-1773 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1785-1802 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×2
  • Duplicated block (16 lines × 2) core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:604 — core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:604-619 | core/src/main/scala/filodb.memory/format/vectors/SimdNativeMethods.scala:41-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (16 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:402 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:402-417 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:609-624 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:402` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–15 lines × 2) · ×2
  • Duplicated block (11–15 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:140 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:140-150 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:371-385 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:140` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11–15 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:162 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:162-172 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:464-478 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:162` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–13 lines × 2) · ×2
  • Duplicated block (9–13 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:100 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:100-108 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:417-429 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9–13 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:120 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:120-128 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:624-636 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:120` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) core/src/main/scala/filodb.core/memstore/EvictablePartIdQueueSet.scala:63 — core/src/main/scala/filodb.core/memstore/EvictablePartIdQueueSet.scala:63-74 | query/src/main/scala/filodb/query/util/IndexedArrayQueue.scala:23-34 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (12 lines × 2) query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:52 — query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:52-63 | query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:62-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/MetadataRemoteExec.scala:52` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×2
  • Duplicated block (11–12 lines × 2) query/src/main/scala/filodb/query/exec/ExecPlan.scala:251 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:251-262 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:504-514 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/ExecPlan.scala:251` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11–12 lines × 2) core/src/main/java/filodb/memory/Latch.java:481 — core/src/main/java/filodb/memory/Latch.java:481-492 | core/src/main/java/filodb/memory/Latch.java:605-615 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×2
  • Duplicated block (11 lines × 2) query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:145 — query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:145-155 | query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:189-199 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:145` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (11 lines × 2) core/src/main/java/filodb/memory/Latch.java:1063 — core/src/main/java/filodb/memory/Latch.java:1063-1073 | core/src/main/java/filodb/memory/Latch.java:1152-1162 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×2
  • Duplicated block (9 lines × 4) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:167 — core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:167-175 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:295-303 | core/src/main/scala/filodb.memory/format/vectors/LongBinaryVector.scala:178-186 | core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala:132-140 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:167` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 4) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:356 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:356-364 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:449-457 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:500-508 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:558-566 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:356` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:43 — spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:43-50 | spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:48-55 | spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopier.scala:40-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 3) core/src/rust/filodb_core/src/reader.rs:334 — core/src/rust/filodb_core/src/reader.rs:334-341 | core/src/rust/filodb_core/src/reader.rs:383-390 | core/src/rust/filodb_core/src/reader.rs:459-466 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×2
  • Duplicated block (7–8 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:146 — coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:146-153 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:811-817 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:146` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7–8 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1302 — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1302-1308 | coordinator/src/main/scala/filodb.coordinator/queryplanner/ShardKeyRegexPlanner.scala:401-408 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1302` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the function that made it · ×2
  • Disposable created and abandoned in the function that made it stress/src/main/scala/filodb.stress/MemStoreStress.scala:45 — `scala.io.Source.fromURL(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.getLines` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(scala.io.Source.fromURL(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it core/src/main/scala/filodb.memory/format/vectors/HistogramCompressor.scala:32 — `Source.fromFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.getLines` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Source.fromFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
X3 · Exception handling · Swallowed exception (empty catch) · ×2
  • Swallowed exception (empty catch) standalone/src/main/java/filodb/standalone/SimpleProfiler.java:141 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) spark/src/it/scala/filodb.spark/SparkTestBase.scala:39 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
D1 · Cyclomatic Complexity · PromQLParser.vectorExpression (cyclomatic 53) · ×1
  • PromQLParser.vectorExpression (cyclomatic 53) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273 — PromQLParser.vectorExpression has cyclomatic complexity 53 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BinaryOperatorFunction.factoryMethod (cyclomatic 43) · ×1
  • BinaryOperatorFunction.factoryMethod (cyclomatic 43) query/src/main/scala/filodb/query/exec/binaryOp/BinaryOperatorFunction.scala:20 — BinaryOperatorFunction.factoryMethod has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CliMain.main (cyclomatic 35) · ×1
  • CliMain.main (cyclomatic 35) cli/src/main/scala/filodb.cli/CliMain.scala:155 — CliMain.main has cyclomatic complexity 35 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SimpleProfiler.examine (cyclomatic 33) · ×1
  • SimpleProfiler.examine (cyclomatic 33) standalone/src/main/java/filodb/standalone/SimpleProfiler.java:303 — SimpleProfiler.examine has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LogicalPlanUtils.getPeriodicSeriesPlan (cyclomatic 31) · ×1
  • LogicalPlanUtils.getPeriodicSeriesPlan (cyclomatic 31) coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:343 — LogicalPlanUtils.getPeriodicSeriesPlan has cyclomatic complexity 31 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Histogram.quantile (cyclomatic 31) · ×1
  • Histogram.quantile (cyclomatic 31) core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:71 — Histogram.quantile has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Histogram.histogramFraction (cyclomatic 29) · ×1
  • Histogram.histogramFraction (cyclomatic 29) core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:181 — Histogram.histogramFraction has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LogicalPlanUtils.getPushdownKeys (cyclomatic 26) · ×1
  • LogicalPlanUtils.getPushdownKeys (cyclomatic 26) coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:542 — LogicalPlanUtils.getPushdownKeys has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: LogicalPlanUtils.getTimeFromLogicalPlan (cyclomatic 29) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · LogicalPlanUtils.copyWithUpdatedTimeRange (cyclomatic 23) · ×1
  • LogicalPlanUtils.copyWithUpdatedTimeRange (cyclomatic 23) coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:129 — LogicalPlanUtils.copyWithUpdatedTimeRange has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file's highest cyclomatic complexity: LogicalPlanUtils.getTimeFromLogicalPlan (cyclomatic 29) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · QueryActor.execPhysicalPlan2 (cyclomatic 21) · ×1
  • QueryActor.execPhysicalPlan2 (cyclomatic 21) coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:111 — QueryActor.execPhysicalPlan2 has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FlightQueryResultStreaming.streamResults (cyclomatic 20) · ×1
  • FlightQueryResultStreaming.streamResults (cyclomatic 20) coordinator/src/main/scala/filodb/coordinator/flight/FlightQueryResultStreaming.scala:179 — FlightQueryResultStreaming.streamResults has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PlannerParamsFromProtoConverter.fromProto (cyclomatic 20) · ×1
  • PlannerParamsFromProtoConverter.fromProto (cyclomatic 20) query/src/main/scala/filodb/query/ProtoConverters.scala:460 — PlannerParamsFromProtoConverter.fromProto has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PeriodicSamplesMapper.apply (cyclomatic 20) · ×1
  • PeriodicSamplesMapper.apply (cyclomatic 20) query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala:61 — PeriodicSamplesMapper.apply has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Latch.releaseExclusive (cyclomatic 20) · ×1
  • Latch.releaseExclusive (cyclomatic 20) core/src/main/java/filodb/memory/Latch.java:338 — Latch.releaseExclusive has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MultiPartitionPlanner.materializeSplitLeafPlan (cyclomatic 19) · ×1
  • MultiPartitionPlanner.materializeSplitLeafPlan (cyclomatic 19) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1085 — MultiPartitionPlanner.materializeSplitLeafPlan has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: MultiPartitionPlanner.walkMultiPartitionPlan (cyclomatic 23) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · BinaryExpression.toSeriesPlan (cyclomatic 19) · ×1
  • BinaryExpression.toSeriesPlan (cyclomatic 19) prometheus/src/main/scala/filodb/prometheus/ast/Expressions.scala:66 — BinaryExpression.toSeriesPlan has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ExecPlan.execute (cyclomatic 19) · ×1
  • ExecPlan.execute (cyclomatic 19) query/src/main/scala/filodb/query/exec/ExecPlan.scala:400 — ExecPlan.execute has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MultiPartitionPlanner.walkLogicalPlanTree (cyclomatic 18) · ×1
  • MultiPartitionPlanner.walkLogicalPlanTree (cyclomatic 18) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:152 — MultiPartitionPlanner.walkLogicalPlanTree has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: MultiPartitionPlanner.walkMultiPartitionPlan (cyclomatic 23) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · IntBinaryVector.appendingVectorNoNA (cyclomatic 18) · ×1
  • IntBinaryVector.appendingVectorNoNA (cyclomatic 18) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:52 — IntBinaryVector.appendingVectorNoNA has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AggLpOptimization.canTranslateQueryToPreagg (cyclomatic 17) · ×1
  • AggLpOptimization.canTranslateQueryToPreagg (cyclomatic 17) query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala:122 — AggLpOptimization.canTranslateQueryToPreagg has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PartKeyQueryBuilder.visitFilter (cyclomatic 16) · ×1
  • PartKeyQueryBuilder.visitFilter (cyclomatic 16) core/src/main/scala/filodb.core/memstore/PartKeyIndex.scala:581 — PartKeyQueryBuilder.visitFilter has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ThrowableFromProtoConverter.fromProto (cyclomatic 16) · ×1
  • ThrowableFromProtoConverter.fromProto (cyclomatic 16) query/src/main/scala/filodb/query/ProtoConverters.scala:705 — ThrowableFromProtoConverter.fromProto has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D15 · Churn × Complexity Hotspots · Hotspot · ×1
  • Hotspot: query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala:61 — query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in PeriodicSamplesMapper.apply at line 61. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-07..2026-10-05, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-07 12:34:45 -07:00' --until='2026-10-05 12:34:45 -07:00' --full-history --no-merges -- query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D2 · Cognitive Complexity · Histogram.quantile (cognitive 83) · ×1
  • Histogram.quantile (cognitive 83) core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:71 — Histogram.quantile has cognitive complexity 83 (threshold 15). Drivers by points: if/else 32 (64 pts), boolean chains 10, match/switch 2 (9 pts) (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PromQLParser.vectorExpression (cognitive 78) · ×1
  • PromQLParser.vectorExpression (cognitive 78) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273 — PromQLParser.vectorExpression has cognitive complexity 78 (threshold 15). Drivers by points: if/else 16 (61 pts), match/switch 3 (8 pts), boolean chains 7, error handling 1, loops 1 (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Latch.releaseExclusive (cognitive 60) · ×1
  • Latch.releaseExclusive (cognitive 60) core/src/main/java/filodb/memory/Latch.java:338 — Latch.releaseExclusive has cognitive complexity 60 (threshold 15). Drivers by points: if/else 15 (52 pts), error handling 1 (4 pts), boolean chains 3, loops 1 (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Latch.acquire (cognitive 55) · ×1
  • Latch.acquire (cognitive 55) core/src/main/java/filodb/memory/Latch.java:719 — Latch.acquire has cognitive complexity 55 (threshold 15). Drivers by points: if/else 14 (48 pts), loops 2 (7 pts) (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SimpleProfiler.examine (cognitive 51) · ×1
  • SimpleProfiler.examine (cognitive 51) standalone/src/main/java/filodb/standalone/SimpleProfiler.java:303 — SimpleProfiler.examine has cognitive complexity 51 (threshold 15). Drivers by points: if/else 19 (47 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BinaryOperatorFunction.factoryMethod (cognitive 50) · ×1
  • BinaryOperatorFunction.factoryMethod (cognitive 50) query/src/main/scala/filodb/query/exec/binaryOp/BinaryOperatorFunction.scala:20 — BinaryOperatorFunction.factoryMethod has cognitive complexity 50 (threshold 15). Drivers by points: if/else 31 (43 pts), boolean chains 6, match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MultiPartitionPlanner.materializeSplitLeafPlan (cognitive 46) · ×1
  • MultiPartitionPlanner.materializeSplitLeafPlan (cognitive 46) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1085 — MultiPartitionPlanner.materializeSplitLeafPlan has cognitive complexity 46 (threshold 15). Drivers by points: if/else 21 (37 pts), match/switch 2 (6 pts), boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FlightQueryResultStreaming.streamResults (cognitive 46) · ×1
  • FlightQueryResultStreaming.streamResults (cognitive 46) coordinator/src/main/scala/filodb/coordinator/flight/FlightQueryResultStreaming.scala:179 — FlightQueryResultStreaming.streamResults has cognitive complexity 46 (threshold 15). Drivers by points: if/else 12 (26 pts), match/switch 4 (10 pts), loops 2 (4 pts), boolean chains 3, error handling 1 (3 pts) (nesting depth added 24). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Histogram.histogramFraction (cognitive 44) · ×1
  • Histogram.histogramFraction (cognitive 44) core/src/main/scala/filodb.memory/format/vectors/Histogram.scala:181 — Histogram.histogramFraction has cognitive complexity 44 (threshold 15). Drivers by points: if/else 19 (30 pts), boolean chains 13, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryActor.execPhysicalPlan2 (cognitive 42) · ×1
  • QueryActor.execPhysicalPlan2 (cognitive 42) coordinator/src/main/scala/filodb.coordinator/QueryActor.scala:111 — QueryActor.execPhysicalPlan2 has cognitive complexity 42 (threshold 15). Drivers by points: if/else 14 (29 pts), match/switch 5 (11 pts), boolean chains 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CassandraColumnStore.initialize (cognitive 38) · ×1
  • CassandraColumnStore.initialize (cognitive 38) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:86 — CassandraColumnStore.initialize has cognitive complexity 38 (threshold 15). Drivers by points: loops 6 (27 pts), if/else 8 (11 pts) (nesting depth added 24). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MultiPartitionPlanner.walkLogicalPlanTree (cognitive 38) · ×1
  • MultiPartitionPlanner.walkLogicalPlanTree (cognitive 38) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:152 — MultiPartitionPlanner.walkLogicalPlanTree has cognitive complexity 38 (threshold 15). Drivers by points: if/else 13 (21 pts), match/switch 4 (13 pts), boolean chains 4 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PlannerParamsFromProtoConverter.fromProto (cognitive 38) · ×1
  • PlannerParamsFromProtoConverter.fromProto (cognitive 38) query/src/main/scala/filodb/query/ProtoConverters.scala:460 — PlannerParamsFromProtoConverter.fromProto has cognitive complexity 38 (threshold 15). Drivers by points: if/else 38. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · IngestionActor.startIngestion (cognitive 33) · ×1
  • IngestionActor.startIngestion (cognitive 33) coordinator/src/main/scala/filodb.coordinator/IngestionActor.scala:211 — IngestionActor.startIngestion has cognitive complexity 33 (threshold 15). Drivers by points: loops 5 (19 pts), if/else 4 (7 pts), match/switch 2 (6 pts), error handling 1 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · FlightPlanDispatcher.executeFlightRequest (cognitive 32) · ×1
  • FlightPlanDispatcher.executeFlightRequest (cognitive 32) coordinator/src/main/scala/filodb/coordinator/flight/FlightPlanDispatcher.scala:58 — FlightPlanDispatcher.executeFlightRequest has cognitive complexity 32 (threshold 15). Drivers by points: if/else 16 (29 pts), boolean chains 1, loops 1, match/switch 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Latch.downgrade (cognitive 31) · ×1
  • Latch.downgrade (cognitive 31) core/src/main/java/filodb/memory/Latch.java:287 — Latch.downgrade has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (28 pts), loops 2 (3 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LogicalPlanUtils.getPushdownKeys (cognitive 29) · ×1
  • LogicalPlanUtils.getPushdownKeys (cognitive 29) coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala:542 — LogicalPlanUtils.getPushdownKeys has cognitive complexity 29 (threshold 15). Drivers by points: if/else 15 (21 pts), boolean chains 7, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IngestionActor.resync (cognitive 28) · ×1
  • IngestionActor.resync (cognitive 28) coordinator/src/main/scala/filodb.coordinator/IngestionActor.scala:154 — IngestionActor.resync has cognitive complexity 28 (threshold 15). Drivers by points: if/else 10 (19 pts), error handling 1 (5 pts), boolean chains 2, loops 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeSeriesShard.evictForHeadroom (cognitive 28) · ×1
  • TimeSeriesShard.evictForHeadroom (cognitive 28) core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:1802 — TimeSeriesShard.evictForHeadroom has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (24 pts), boolean chains 4 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DemandPagedChunkStore.populateRawChunks (cognitive 27) · ×1
  • DemandPagedChunkStore.populateRawChunks (cognitive 27) core/src/main/scala/filodb.core/memstore/DemandPagedChunkStore.scala:77 — DemandPagedChunkStore.populateRawChunks has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (21 pts), error handling 1 (5 pts), match/switch 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ExecPlan.execute (cognitive 26) · ×1
  • ExecPlan.execute (cognitive 26) query/src/main/scala/filodb/query/exec/ExecPlan.scala:400 — ExecPlan.execute has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (17 pts), match/switch 5, loops 2 (3 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SimpleProfiler.report (cognitive 26) · ×1
  • SimpleProfiler.report (cognitive 26) standalone/src/main/java/filodb/standalone/SimpleProfiler.java:217 — SimpleProfiler.report has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 4 (8 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CassandraColumnStore.truncate (cognitive 25) · ×1
  • CassandraColumnStore.truncate (cognitive 25) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:134 — CassandraColumnStore.truncate has cognitive complexity 25 (threshold 15). Drivers by points: loops 6 (21 pts), if/else 4 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This shape REPEATS in the file: one other method here (CassandraColumnStore.dropDataset) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · CassandraColumnStore.dropDataset (cognitive 25) · ×1
  • CassandraColumnStore.dropDataset (cognitive 25) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:167 — CassandraColumnStore.dropDataset has cognitive complexity 25 (threshold 15). Drivers by points: loops 6 (21 pts), if/else 4 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This shape REPEATS in the file: one other method here (CassandraColumnStore.truncate) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · CassandraColumnStore.copyOrDeleteChunksByIngestionTimeRange (cognitive 25) · ×1
  • CassandraColumnStore.copyOrDeleteChunksByIngestionTimeRange (cognitive 25) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:415 — CassandraColumnStore.copyOrDeleteChunksByIngestionTimeRange has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (6 pts), error handling 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SetOperatorExec.setOpAnd (cognitive 24) · ×1
  • SetOperatorExec.setOpAnd (cognitive 24) query/src/main/scala/filodb/query/exec/SetOperatorExec.scala:109 — SetOperatorExec.setOpAnd has cognitive complexity 24 (threshold 15). Drivers by points: if/else 14 (22 pts), boolean chains 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RVCursorImpl.next (cognitive 24) · ×1
  • RVCursorImpl.next (cognitive 24) query/src/main/scala/filodb/query/exec/StitchRvsExec.scala:47 — RVCursorImpl.next has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (22 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HighAvailabilityPlanner.routeExecPlanMapper (cognitive 23) · ×1
  • HighAvailabilityPlanner.routeExecPlanMapper (cognitive 23) coordinator/src/main/scala/filodb.coordinator/queryplanner/HighAvailabilityPlanner.scala:117 — HighAvailabilityPlanner.routeExecPlanMapper has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 3 (6 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BinaryExpression.toSeriesPlan (cognitive 23) · ×1
  • BinaryExpression.toSeriesPlan (cognitive 23) prometheus/src/main/scala/filodb/prometheus/ast/Expressions.scala:66 — BinaryExpression.toSeriesPlan has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (15 pts), match/switch 4 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NibblePack.unpack8 (cognitive 22) · ×1
  • NibblePack.unpack8 (cognitive 22) core/src/main/scala/filodb.memory/format/NibblePack.scala:395 — NibblePack.unpack8 has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (21 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Function.toSeriesPlan (cognitive 22) · ×1
  • Function.toSeriesPlan (cognitive 22) prometheus/src/main/scala/filodb/prometheus/ast/Functions.scala:95 — Function.toSeriesPlan has cognitive complexity 22 (threshold 15). Drivers by points: match/switch 5 (13 pts), if/else 8 (9 pts) (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PeriodicSamplesMapper.apply (cognitive 22) · ×1
  • PeriodicSamplesMapper.apply (cognitive 22) query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala:61 — PeriodicSamplesMapper.apply has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 5, match/switch 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PromQlRemoteExec.toQueryResponse (cognitive 22) · ×1
  • PromQlRemoteExec.toQueryResponse (cognitive 22) query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:78 — PromQlRemoteExec.toQueryResponse has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 1 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Latch.doReleaseShared (cognitive 22) · ×1
  • Latch.doReleaseShared (cognitive 22) core/src/main/java/filodb/memory/Latch.java:688 — Latch.doReleaseShared has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), boolean chains 2, loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (Latch.releaseShared) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · Latch.releaseShared (cognitive 22) · ×1
  • Latch.releaseShared (cognitive 22) core/src/main/java/filodb/memory/Latch.java:650 — Latch.releaseShared has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), boolean chains 2, loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (Latch.doReleaseShared) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · IngestionConfig.apply (cognitive 21) · ×1
  • IngestionConfig.apply (cognitive 21) core/src/main/scala/filodb.core/store/IngestionConfig.scala:182 — IngestionConfig.apply has cognitive complexity 21 (threshold 15). Drivers by points: loops 6 (21 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · DeltaDeltaVector.fromLongVector (cognitive 21) · ×1
  • DeltaDeltaVector.fromLongVector (cognitive 21) core/src/main/scala/filodb.memory/format/vectors/DeltaDeltaVector.scala:63 — DeltaDeltaVector.fromLongVector has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 3 (9 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MultiPartitionPlanner.materializePeriodicAndRawSeries (cognitive 20) · ×1
  • MultiPartitionPlanner.materializePeriodicAndRawSeries (cognitive 20) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:402 — MultiPartitionPlanner.materializePeriodicAndRawSeries has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeSeriesPartition.ingest (cognitive 20) · ×1
  • TimeSeriesPartition.ingest (cognitive 20) core/src/main/scala/filodb.core/memstore/TimeSeriesPartition.scala:130 — TimeSeriesPartition.ingest has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 4, match/switch 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Function.toSeriesPlanMisc (cognitive 20) · ×1
  • Function.toSeriesPlanMisc (cognitive 20) prometheus/src/main/scala/filodb/prometheus/ast/Functions.scala:147 — Function.toSeriesPlanMisc has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (15 pts), match/switch 2 (5 pts) (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CliMain.main (cognitive 19) · ×1
  • CliMain.main (cognitive 19) cli/src/main/scala/filodb.cli/CliMain.scala:155 — CliMain.main has cognitive complexity 19 (threshold 15). Drivers by points: boolean chains 10, match/switch 3 (5 pts), if/else 2 (3 pts), error handling 1 (nesting depth added 3). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ArrowSerializedRangeVectorOps.populateRvContentsIntoVsrs (cognitive 19) · ×1
  • ArrowSerializedRangeVectorOps.populateRvContentsIntoVsrs (cognitive 19) coordinator/src/main/scala/filodb/coordinator/flight/ArrowSerializedRangeVectorOps.scala:115 — ArrowSerializedRangeVectorOps.populateRvContentsIntoVsrs has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (13 pts), boolean chains 3, loops 1 (2 pts), match/switch 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ChunkMap.chunkmapDoPut (cognitive 19) · ×1
  • ChunkMap.chunkmapDoPut (cognitive 19) core/src/main/scala/filodb.memory/data/ChunkMap.scala:480 — ChunkMap.chunkmapDoPut has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (16 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IntBinaryVector.appendingVectorNoNA (cognitive 19) · ×1
  • IntBinaryVector.appendingVectorNoNA (cognitive 19) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:52 — IntBinaryVector.appendingVectorNoNA has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 6 (11 pts), if/else 4 (8 pts) (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · BinaryJoinExec.compose (cognitive 19) · ×1
  • BinaryJoinExec.compose (cognitive 19) query/src/main/scala/filodb/query/exec/BinaryJoinExec.scala:87 — BinaryJoinExec.compose has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15 (17 pts), boolean chains 2 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ExecPlan.executeStreaming (cognitive 19) · ×1
  • ExecPlan.executeStreaming (cognitive 19) query/src/main/scala/filodb/query/exec/ExecPlan.scala:149 — ExecPlan.executeStreaming has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (15 pts), match/switch 3, boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LabelValuesExec.doExecute (cognitive 19) · ×1
  • LabelValuesExec.doExecute (cognitive 19) query/src/main/scala/filodb/query/exec/MetadataExecPlan.scala:379 — LabelValuesExec.doExecute has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Shared.tryAcquire (cognitive 19) · ×1
  • Shared.tryAcquire (cognitive 19) core/src/main/java/filodb/memory/Latch.java:1095 — Shared.tryAcquire has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, ternaries 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CassandraColumnStore.copyPartitionKeysByTimeRange (cognitive 18) · ×1
  • CassandraColumnStore.copyPartitionKeysByTimeRange (cognitive 18) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:323 — CassandraColumnStore.copyPartitionKeysByTimeRange has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (7 pts), match/switch 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryFailureRoutingStrategy.splitQueryTime (cognitive 18) · ×1
  • QueryFailureRoutingStrategy.splitQueryTime (cognitive 18) coordinator/src/main/scala/filodb.coordinator/queryplanner/FailureRoutingStrategy.scala:73 — QueryFailureRoutingStrategy.splitQueryTime has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (12 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Utils.deleteRecursively (cognitive 18) · ×1
  • Utils.deleteRecursively (cognitive 18) core/src/main/scala/filodb.core/Utils.scala:24 — Utils.deleteRecursively has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (11 pts), match/switch 3 (6 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OnDemandPagingShard.scanPartitions (cognitive 18) · ×1
  • OnDemandPagingShard.scanPartitions (cognitive 18) core/src/main/scala/filodb.core/memstore/OnDemandPagingShard.scala:147 — OnDemandPagingShard.scanPartitions has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (18 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeSeriesShard.bootstrapPartKey (cognitive 18) · ×1
  • TimeSeriesShard.bootstrapPartKey (cognitive 18) core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:800 — TimeSeriesShard.bootstrapPartKey has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (18 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WindowedChunkIterator.nextWindow (cognitive 18) · ×1
  • WindowedChunkIterator.nextWindow (cognitive 18) core/src/main/scala/filodb.core/store/ChunkSetInfo.scala:480 — WindowedChunkIterator.nextWindow has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 3, error handling 1 (3 pts), loops 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RangeInstantFunctions.instantValueH (cognitive 18) · ×1
  • RangeInstantFunctions.instantValueH (cognitive 18) query/src/main/scala/filodb/query/exec/rangefn/RangeInstantFunctions.scala:97 — RangeInstantFunctions.instantValueH has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActorPlanDispatcher.dispatch (cognitive 17) · ×1
  • ActorPlanDispatcher.dispatch (cognitive 17) coordinator/src/main/scala/filodb.coordinator/ActorPlanDispatcher.scala:47 — ActorPlanDispatcher.dispatch has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 2 (6 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShardManager.updateFromExternalShardEvent (cognitive 17) · ×1
  • ShardManager.updateFromExternalShardEvent (cognitive 17) coordinator/src/main/scala/filodb.coordinator/ShardManager.scala:480 — ShardManager.updateFromExternalShardEvent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MultiPartitionPlanner.materializeAggregate (cognitive 17) · ×1
  • MultiPartitionPlanner.materializeAggregate (cognitive 17) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1006 — MultiPartitionPlanner.materializeAggregate has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FileSystemBasedIndexMetadataStore.initState (cognitive 17) · ×1
  • FileSystemBasedIndexMetadataStore.initState (cognitive 17) core/src/main/scala/filodb.core/memstore/IndexMetadataStore.scala:147 — FileSystemBasedIndexMetadataStore.initState has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (17 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScalarOperationMapper.evaluate (cognitive 17) · ×1
  • ScalarOperationMapper.evaluate (cognitive 17) query/src/main/scala/filodb/query/exec/RangeVectorTransformer.scala:223 — ScalarOperationMapper.evaluate has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 2 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · WaitNode.tryAcquire (cognitive 17) · ×1
  • WaitNode.tryAcquire (cognitive 17) core/src/main/java/filodb/memory/Latch.java:1005 — WaitNode.tryAcquire has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MapEncoder.keyMatchesAtPos (cognitive 16) · ×1
  • MapEncoder.keyMatchesAtPos (cognitive 16) core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala:337 — MapEncoder.keyMatchesAtPos has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TimeSeriesShard.evictPartitions (cognitive 16) · ×1
  • TimeSeriesShard.evictPartitions (cognitive 16) core/src/main/scala/filodb.core/memstore/TimeSeriesShard.scala:1712 — TimeSeriesShard.evictPartitions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryUtils.trackSamplesScanned (cognitive 16) · ×1
  • QueryUtils.trackSamplesScanned (cognitive 16) core/src/main/scala/filodb.core/query/QueryUtils.scala:194 — QueryUtils.trackSamplesScanned has cognitive complexity 16 (threshold 15). Drivers by points: if/else 13 (16 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · DeltaDeltaDataReader.binarySearch (cognitive 16) · ×1
  • DeltaDeltaDataReader.binarySearch (cognitive 16) core/src/main/scala/filodb.memory/format/vectors/DeltaDeltaVector.scala:159 — DeltaDeltaDataReader.binarySearch has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 4, loops 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DoubleVectorDataReader64.sum (cognitive 16) · ×1
  • DoubleVectorDataReader64.sum (cognitive 16) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:234 — DoubleVectorDataReader64.sum has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PerQueryLimitsFromProtoConverter.fromProto (cognitive 16) · ×1
  • PerQueryLimitsFromProtoConverter.fromProto (cognitive 16) query/src/main/scala/filodb/query/ProtoConverters.scala:526 — PerQueryLimitsFromProtoConverter.fromProto has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · VarOverTimeChunkedFunctionD.addTimeDoubleChunksWithTimestamp (cognitive 16) · ×1
  • VarOverTimeChunkedFunctionD.addTimeDoubleChunksWithTimestamp (cognitive 16) query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:1270 — VarOverTimeChunkedFunctionD.addTimeDoubleChunksWithTimestamp has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryCache · ×1
  • QueryCache::search (cognitive 16) core/src/rust/tantivy_utils/src/query/cache.rs:104 — QueryCache::search has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D3 · God Classes · MethodTooLong · ×1
  • MethodTooLong: PromQLParser.vectorExpression prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:273 — MethodTooLong — vectorExpression runs 188 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 88 over it, 1.88× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D30 · Dependency Vulnerabilities · Medium advisory (unmaintained) · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Medium vulnerability · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (4 members, 12 shared lines) · ×1
  • Near-duplicate member family (4 members, 12 shared lines) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:360 — core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:360-378 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:384-404 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:410-430 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:436-456 — These 4 members are variants of one another: a block of 12 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Near-duplicate member pair (118 shared lines) · ×1
  • Near-duplicate member pair (118 shared lines) query/src/main/scala/filodb/query/exec/ExecPlan.scala:151 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:151-338 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:402-597 — These two members are variants of one another: 118 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:165 — core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:165-175 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:293-303 | core/src/main/scala/filodb.memory/format/vectors/LongBinaryVector.scala:176-186 | core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala:130-140 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×1
  • Duplicated block (42 lines × 2) query/src/main/scala/filodb/query/exec/ExecPlan.scala:197 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:197-238 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:450-491 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:161 — coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:161-193 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:832-864 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (29 lines × 2) · ×1
  • Duplicated block (29 lines × 2) query/src/main/scala/filodb/query/exec/ExecPlan.scala:156 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:156-184 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:408-436 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (17–19 lines × 2) · ×1
  • Duplicated block (17–19 lines × 2) query/src/main/scala/filodb/query/exec/ExecPlan.scala:277 — query/src/main/scala/filodb/query/exec/ExecPlan.scala:277-293 | query/src/main/scala/filodb/query/exec/ExecPlan.scala:529-547 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/ExecPlan.scala:277` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `query/src/main/scala/filodb/query/exec/ExecPlan.scala:549` calls `debug` and `query/src/main/scala/filodb/query/exec/ExecPlan.scala:294` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13–18 lines × 2) · ×1
  • Duplicated block (13–18 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:238 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:238-250 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:515-532 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:238` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1
  • Duplicated block (14 lines × 2) cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:280 — cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:280-293 | cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:301-314 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cassandra/src/main/scala/filodb.cassandra/columnstore/CassandraColumnStore.scala:280` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–14 lines × 2) · ×1
  • Duplicated block (12–14 lines × 2) query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:851 — query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:851-864 | query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:915-926 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:851` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:911` calls `addTimeChunksWithTimestamp` and `query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala:849` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1
  • Duplicated block (12 lines × 3) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:378 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:378-389 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:471-482 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:585-596 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:378` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–12 lines × 2) · ×1
  • Duplicated block (8–12 lines × 2) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:185 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:185-192 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:548-559 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:185` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10–11 lines × 6) · ×1
  • Duplicated block (10–11 lines × 6) query/src/main/scala/filodb/query/ProtoConverters.scala:349 — query/src/main/scala/filodb/query/ProtoConverters.scala:349-358 | query/src/main/scala/filodb/query/ProtoConverters.scala:361-370 | query/src/main/scala/filodb/query/ProtoConverters.scala:373-382 | query/src/main/scala/filodb/query/ProtoConverters.scala:388-397 | query/src/main/scala/filodb/query/ProtoConverters.scala:400-409 | query/src/main/scala/filodb/query/ProtoConverters.scala:412-422 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `query/src/main/scala/filodb/query/ProtoConverters.scala:349` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:144 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:144-154 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:166-176 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:205-215 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:144` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1022 — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1022-1032 | coordinator/src/main/scala/filodb.coordinator/queryplanner/ShardKeyRegexPlanner.scala:451-460 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1022` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala:543 — core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala:543-551 | core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala:434-444 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (9–10 lines × 3) · ×1
  • Duplicated block (9–10 lines × 3) coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1012 — coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1012-1020 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1051-1060 | coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1104-1113 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1012` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1008` calls `indexOf`, `updated` and `coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala:1050` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:163 — spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:163-172 | spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:195-204 | spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopier.scala:148-157 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:163` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:211 — coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:211-220 | coordinator/src/main/scala/filodb/coordinator/v2/NewNodeCoordinatorActor.scala:269-277 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (3–10 lines × 3) · ×1
  • Duplicated block (3–10 lines × 3) coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:605 — coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:605-607 | coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1293-1300 | coordinator/src/main/scala/filodb.coordinator/queryplanner/ShardKeyRegexPlanner.scala:390-399 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:605` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `coordinator/src/main/scala/filodb.coordinator/queryplanner/ShardKeyRegexPlanner.scala:390` calls `convertToQuery` and `coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:605` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×1
  • Duplicated block (8–9 lines × 2) query/src/main/scala/filodb/query/exec/aggregator/HistMaxMinSumAggregator.scala:23 — query/src/main/scala/filodb/query/exec/aggregator/HistMaxMinSumAggregator.scala:23-30 | query/src/main/scala/filodb/query/exec/aggregator/HistSumRowAggregator.scala:21-29 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `query/src/main/scala/filodb/query/exec/aggregator/HistMaxMinSumAggregator.scala:31` calls `maxIgnoreNaN`, `getDouble`, `minIgnoreNaN` and `query/src/main/scala/filodb/query/exec/aggregator/HistSumRowAggregator.scala:29` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–8 lines × 6) · ×1
  • Duplicated block (6–8 lines × 6) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:235 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:235-240 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:366-373 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:412-419 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:459-466 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:512-519 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:619-626 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 5) · ×1
  • Duplicated block (8 lines × 5) jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:163 — jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:163-170 | jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:181-188 | jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:199-206 | jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:158-165 | jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:183-190 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala:163` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×1
  • Duplicated block (8 lines × 4) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:371 — core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:371-378 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:397-404 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:423-430 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:449-456 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:371` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (4–7 lines × 4) · ×1
  • Duplicated block (4–7 lines × 4) core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:361 — core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:361-364 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:385-388 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:412-418 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:438-444 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:412` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:87 — jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:87-91 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:103-107 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:119-123 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:135-139 | jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:241-245 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:246` calls `ColumnFilter`, `Equals` and `jmh/src/main/scala/filodb.jmh/PartKeyIndexBenchmark.scala:92` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1
  • Duplicated block (5 lines × 3) gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:192 — gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:192-196 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:228-232 | gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:279-283 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `gateway/src/main/scala/filodb/gateway/conversion/InputRecord.scala:192` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (4–5 lines × 3) · ×1
  • Duplicated block (4–5 lines × 3) cassandra/src/main/scala/filodb.cassandra/columnstore/TimeSeriesChunksTable.scala:203 — cassandra/src/main/scala/filodb.cassandra/columnstore/TimeSeriesChunksTable.scala:203-207 | cassandra/src/main/scala/filodb.cassandra/columnstore/TimeSeriesChunksTable.scala:224-227 | cassandra/src/main/scala/filodb.cassandra/columnstore/TimeSeriesChunksTable.scala:243-247 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `cassandra/src/main/scala/filodb.cassandra/columnstore/TimeSeriesChunksTable.scala:203` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×1
  • Duplicated block (5 lines × 4) core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:137 — core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:137-141 | core/src/main/scala/filodb.memory/format/vectors/IntBinaryVector.scala:283-287 | core/src/main/scala/filodb.memory/format/vectors/LongBinaryVector.scala:129-133 | core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala:119-123 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `core/src/main/scala/filodb.memory/format/vectors/DoubleVector.scala:124` calls `length`, `numBytes` and `core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala:107` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (19 lines × 9) · ×1
  • Duplicated block (19 lines × 9) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:547 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:547-565 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:628-646 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:673-691 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:778-796 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1217-1235 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1473-1491 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2272-2290 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2479-2497 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2526-2544 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:547` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (19 lines × 5) · ×1
  • Duplicated block (19 lines × 5) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:350 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:350-368 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:372-390 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:394-412 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:416-434 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:438-456 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:350` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (16 lines × 6) · ×1
  • Duplicated block (16 lines × 6) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:348 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:348-363 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:370-385 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:392-407 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:414-429 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:436-451 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:458-473 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:348` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10–14 lines × 2) · ×1
  • Duplicated block (10–14 lines × 2) core/src/main/java/filodb/memory/Latch.java:651 — core/src/main/java/filodb/memory/Latch.java:651-664 | core/src/main/java/filodb/memory/Latch.java:692-701 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `core/src/main/java/filodb/memory/Latch.java:651` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 7) · ×1
  • Duplicated block (10 lines × 7) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:625 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:625-634 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:720-729 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1214-1223 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1470-1479 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2269-2278 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2476-2485 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2523-2532 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1212` calls `setState`, `match` and `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:624` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1068 — prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1068-1073 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1671-1676 | prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:2388-2393 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `prometheus/src/main/java/filodb/prometheus/antlr/PromQLParser.java:1068` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: tantivy_utils — tantivy_utils: abstractness 0.14, instability 0.00, distance 0.86 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×1
  • Swallowed exception (caught, then discarded) standalone/src/main/java/filodb/standalone/SimpleProfiler.java:120 — `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Minor — 151 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×120
  • Orphaned file standalone/src/main/java/filodb/standalone/SimpleProfiler.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file spark/src/main/scala/filodb.spark/FiloRelation.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/NibblePack.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file query/src/main/scala/filodb/query/exec/rangefn/InstantFunction.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/vectors/LongBinaryVector.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/vectors/DeltaDeltaVector.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/MemFactory.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file prometheus/src/main/scala/filodb/prometheus/ast/Functions.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.core/metadata/Dataset.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file query/src/main/scala/filodb/query/exec/PromQlRemoteExec.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file coordinator/src/main/scala/filodb.coordinator/NodeCoordinatorActor.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file gateway/src/main/scala/filodb/gateway/conversion/InfluxRecord.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file jmh/src/main/scala/filodb.jmh/QueryInMemoryBenchmark.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/rust/tantivy_utils/src/collectors/string_field_collector.rs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file gateway/src/main/scala/filodb/gateway/conversion/InfluxProtocolParser.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file spark-jobs/src/main/scala/filodb/repair/ChunkCopierValidator.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/rust/filodb_core/src/query_parser/filodb_query.rs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/Section.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file spark-jobs/src/main/scala/filodb/repair/PartitionKeysCopierValidator.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/rust/tantivy_utils/src/query/range_aware_regex.rs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file core/src/main/scala/filodb.memory/format/vectors/HistogramCompressor.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file spark-jobs/src/main/scala/filodb/repair/ChunkCopier.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file project/RustPlugin.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file spark/src/main/scala/filodb.spark/package.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 95 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×11
  • Duplicated predicate query/src/main/scala/filodb/query/exec/aggregator/HistAvgRowAggregator.scala:50 — `!aggRes.getDouble(1).isNaN && !aggRes.getDouble(2).isNaN` appears character-identically in 3 files — query/src/main/scala/filodb/query/exec/aggregator/HistAvgRowAggregator.scala, query/src/main/scala/filodb/query/exec/aggregator/StddevRowAggregator.scala, query/src/main/scala/filodb/query/exec/aggregator/StdvarRowAggregator.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala:1025 — `(aggregate.operator.equals(AggregationOperator.TopK) || aggregate.operator.equals(AggregationOperator.BottomK) || aggregate.operator.equals(…` appears character-identically in 2 files — coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala, coordinator/src/main/scala/filodb.coordinator/queryplanner/ShardKeyRegexPlanner.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate akka-bootstrapper/src/main/scala/filodb/akkabootstrapper/DnsSrvClusterSeedDiscovery.scala:56 — `address != selfAddress || headOpt.contains(address)` appears character-identically in 2 files — akka-bootstrapper/src/main/scala/filodb/akkabootstrapper/DnsSrvClusterSeedDiscovery.scala, akka-bootstrapper/src/main/scala/filodb/akkabootstrapper/ExplicitListClusterSeedDiscovery.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:73 — `buf.capacity < 5 || !isValidFormatCode(h.formatCode) || h.formatCode == HistFormat_Null` appears character-identically in 2 files — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala, core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate query/src/main/scala/filodb/query/exec/aggregator/StddevRowAggregator.scala:68 — `c.name.equals("mean") || c.name.equals("count")` appears character-identically in 2 files — query/src/main/scala/filodb/query/exec/aggregator/StddevRowAggregator.scala, query/src/main/scala/filodb/query/exec/aggregator/StdvarRowAggregator.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala:490 — `ignoreIndexNames.contains(n) || n.startsWith(FACET_FIELD_PREFIX)` appears character-identically in 2 files — core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala, core/src/main/scala/filodb.core/memstore/PartKeyTantivyIndex.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala:194 — `length > 0 && start >= 0 && end < length` appears character-identically in 2 files — core/src/main/scala/filodb.memory/format/vectors/ExpHistogramVector.scala, core/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala:219 — `nameFilter.isDefined && nameFilter.head.endsWith("_bucket") && leFilter.isDefined` appears character-identically in 2 files — coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala, coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate spark-jobs/src/main/scala/filodb/cardbuster/PerShardCardinalityBuster.scala:93 — `pkKey == filterKey && filterValRegex.matcher(pkVal).matches` appears character-identically in 2 files — spark-jobs/src/main/scala/filodb/cardbuster/PerShardCardinalityBuster.scala, spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelChurnFinder.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate query/src/main/scala/filodb/query/exec/RangeVectorTransformer.scala:460 — `rangeParams.startSecs == rangeParams.endSecs || rangeParams.stepSecs == 0` appears character-identically in 2 files — query/src/main/scala/filodb/query/exec/RangeVectorTransformer.scala, query/src/main/scala/filodb/query/exec/aggregator/TopBottomKRowAggregator.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala:87 — `shards.isEmpty || shards.contains(s.shardNum)` appears character-identically in 2 files — core/src/main/scala/filodb.core/downsample/DownsampledTimeSeriesStore.scala, core/src/main/scala/filodb.core/memstore/TimeSeriesMemStore.scala. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
X4 · Structured logging · Interpolated log message defeats structured logging · ×4
  • Interpolated log message defeats structured logging spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:45 — `info` at line 45 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:66 — `info` at line 66 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:71 — `info` at line 71 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala:243 — `error` at line 243 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
AX6 · Interface segregation · Fat interface · ×3
  • Fat interface: PromQLVisitor<T> (43 abstract methods) prometheus/src/main/java/filodb/prometheus/antlr/PromQLVisitor.java:12 — `PromQLVisitor<T>` declares 43 abstract methods: `visitAddOp`, `visitAggregation`, `visitAndUnlessOp`, `visitAtModifier`, `visitBinaryOperation`, `visitBy`, `visitCompareOp`, `visitExpression`, `visitFunction`, `visitGroupLeft`, `visitGroupRight`, `visitGrouping`, `visitIgnoring`, `visitInstantOrRangeSelector`, `visitInstantSelector`, `visitLabelKeyword`, `visitLabelMatcher`, `visitLabelMatcherList`, `visitLabelMatcherOp`, `visitLabelName`, `visitLabelNameList`, `visitLimit`, `visitLimitOperation`, `visitLiteral`, `visitMetricKeyword`, `visitMetricName`, `visitModifier`, `visitMultOp`, `visitOffset`, `visitOn`, `visitOrOp`, `visitParameter`, `visitParameterList`, `visitParens`, `visitPowOp`, `visitSubquery`, `visitSubqueryOperation`, `visitUnaryOp`, `visitUnaryOperation`, `visitVector`, and 3 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: TimeSeriesStore (22 abstract members) core/src/main/scala/filodb.core/memstore/TimeSeriesStore.scala:45 — `TimeSeriesStore` declares 22 abstract members: `store`, `metastore`, `setup`, `ingest`, `startIngestion`, `recoverIndex`, `createDataRecoveryObservable`, `indexNames`, `labelValues`, `labelNames`, `labelValuesWithFilters`, `singleLabelValueWithFilters`, `partKeysWithFilters`, `numPartitions`, `numRowsIngested`, `latestOffset`, `activeShards`, `refreshIndexForTesting`, `analyzeAndLogCorruptPtr`, `truncate`, `reset`, `shutdown`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: BinaryAppendableVector[A] (16 abstract members) core/src/main/scala/filodb.memory/format/BinaryVector.scala:266 — `BinaryAppendableVector[A]` declares 16 abstract members: `addr`, `maxBytes`, `numBytes`, `length`, `dispose`, `addNA`, `addData`, `addFromReaderNoNA`, `reader`, `copyToBuffer`, `apply`, `isAvailable`, `isAllNA`, `noNAs`, `finishCompaction`, `reset`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D16 · Bus Factor · Off-boarding risk · ×2
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 10 significant file(s) lose their only recent owner: coordinator/src/main/scala/filodb/coordinator/flight/FlightQueryResultStreaming.scala, query/src/main/scala/filodb/query/lpopt/AggLpOptimization.scala, coordinator/src/main/scala/filodb/coordinator/flight/ArrowSerializedRangeVectorOps.scala, coordinator/src/main/scala/filodb/coordinator/flight/FlightClientManager.scala, coordinator/src/main/scala/filodb.coordinator/client/Serializer.scala, coordinator/src/main/scala/filodb/coordinator/flight/FlightPlanDispatcher.scala, core/src/main/scala/filodb.core/query/FlightAllocator.scala, coordinator/src/main/scala/filodb/coordinator/flight/FlightProtoSerDeser.scala (+2 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 6 significant file(s) lose their only recent owner: coordinator/src/main/scala/filodb/coordinator/v2/FiloDbClusterDiscovery.scala, http/src/main/scala/filodb/http/CardinalityRoute.scala, coordinator/src/main/scala/filodb.coordinator/ShardStatus.scala, coordinator/src/main/scala/filodb.coordinator/client/Client.scala, core/src/main/scala/filodb.core/memstore/ratelimit/CardinalityStore.scala, coordinator/src/main/scala/filodb.coordinator/client/ClusterOps.scala. Pair on, review, or document these before any departure.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 4 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (21 single-owned of 280 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 280 of the 426 production source files in this repository met that bar). They are anonymized user #3 (2 file(s)), anonymized user #4 (1 file(s)), anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: spark-jobs/src/main/scala/filodb/labelchurnfinder/LabelStatsKafkaProducer.scala, gateway/src/main/scala/filodb/timeseries/TestTimeseriesPrometheusConsumer.scala, core/src/main/scala/filodb.core/memstore/PartKeyIndex.scala, core/src/main/scala/filodb.core/binaryrecord2/MapEncoder.scala, core/src/main/scala/filodb.core/memstore/DownsamplableOnDemandPagingShard.scala.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 1 of 4 project(s) overshoot their size bounds, lowering Project Cohesion to 5.0/10. The most over is `(repository root)` (81449 LoC, 2251 module-visible types across 60 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 120 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: standalone/src/main/java/filodb/standalone/SimpleProfiler.java, spark/src/main/scala/filodb.spark/FiloRelation.scala, core/src/main/scala/filodb.memory/format/NibblePack.scala, query/src/main/scala/filodb/query/exec/rangefn/InstantFunction.scala, core/src/main/scala/filodb.memory/format/vectors/LongBinaryVector.scala, core/src/main/scala/filodb.memory/format/vectors/UTF8Vector.scala, core/src/main/scala/filodb.memory/format/vectors/DeltaDeltaVector.scala, core/src/main/scala/filodb.memory/MemFactory.scala (and 112 more) (128 orphaned of 323 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 323 of the 426 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P10 · Library API & versioning · Large public API surface · ×1
  • Large public API surface — 119/141 types (84%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
PF1 · Benchmark discipline · Benchmarks don't track allocations · ×1
  • Benchmarks don't track allocations jmh/src/main/scala/filodb.jmh/Base2ExponentialHistogramQueryBenchmark.scala — A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured.
S1 · Web-Security Posture · No app-layer HTTPS enforcement detected · ×1
  • No app-layer HTTPS enforcement detected — This repository runs an HTTP server and nothing in its Scala source or committed configuration secures the transport: no HTTPS served (akka/pekko-http `ConnectionContext.httpsServer`/`enableHttps`, an http4s builder's `withTLS`, Jetty's `SslContextFactory`, zio-http's `SSLConfig`, Play's `https.port`), no `Strict-Transport-Security` header, HSTS middleware or Play `RedirectHttpsFilter`, no `X-Forwarded-Proto` read or Play `play.http.forwarded.trustedProxies` for a TLS-terminating proxy — so its traffic may cross the network in clear text. (−2.0 on this card.) The server: coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:13 — `NettyServerBuilder`.
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is set on a response this repository's Scala server sends — defense in depth, even when a proxy could set them. (−2.0 on this card.) The server: coordinator/src/main/scala/filodb/coordinator/flight/FiloDBSinglePartitionFlightProducer.scala:13 — `NettyServerBuilder`.
X5 · Nullable reference types · Scala's null is not held to the type system everywhere · ×1
  • Scala's null is not held to the type system everywhere — No build over this repository's 375 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.
Minor — 65 finding(s)
D12 · Dependency Hygiene · Outdated · ×65
  • Outdated: ch.qos.logback:logback-classic — `ch.qos.logback %% logback-classic` is declared at 1.5.6 in REDACTED, but 1.6.6 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.5.6 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.beachape:enumeratum_2.13 — `com.beachape %% enumeratum_2.13` is declared at 1.5.13 in REDACTED, but 1.9.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.5.13 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.datastax.cassandra:cassandra-driver-core — `com.datastax.cassandra %% cassandra-driver-core` is declared at 3.7.1 in REDACTED, but 4.0.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.7.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.dorkbox:MinLog-SLF4J — `com.dorkbox %% MinLog-SLF4J` is declared at 1.12 in REDACTED, but 2.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.12 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.esotericsoftware:kryo — `com.esotericsoftware %% kryo` is declared at 4.0.2 in REDACTED, but 5.7.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 4.0.2 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.github.ben-manes.caffeine:caffeine — `com.github.ben-manes.caffeine %% caffeine` is declared at 3.0.5 in REDACTED, but 3.3.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.0.5 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.github.jnr:jnr-ffi — `com.github.jnr %% jnr-ffi` is declared at 2.2.12 in REDACTED, but 2.3.4 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.2.12 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.google.protobuf:protobuf-java — `com.google.protobuf %% protobuf-java` is declared at 3.23.1 in REDACTED, but 4.36.2 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.23.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru — `com.googlecode.concurrentlinkedhashmap %% concurrentlinkedhashmap-lru` is declared at 1.4 in REDACTED, but 1.4.2 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.4 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.opencsv:opencsv — `com.opencsv %% opencsv` is declared at 3.3 in REDACTED, but 5.12.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.softwaremill.quicklens:quicklens_2.13 — `com.softwaremill.quicklens %% quicklens_2.13` is declared at 1.9.7 in REDACTED, but 1.9.15 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.9.7 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.tdunning:t-digest — `com.tdunning %% t-digest` is declared at 3.1 in REDACTED, but 3.3 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.akka:akka-actor_2.13 — `com.typesafe.akka %% akka-actor_2.13` is declared at 2.5.32 in REDACTED, but 2.8.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.5.32 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.akka:akka-cluster_2.13 — `com.typesafe.akka %% akka-cluster_2.13` is declared at 2.5.32 in REDACTED, but 2.8.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.5.32 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.akka:akka-slf4j_2.13 — `com.typesafe.akka %% akka-slf4j_2.13` is declared at 2.5.32 in REDACTED, but 2.8.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.5.32 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.akka:akka-stream_2.13 — `com.typesafe.akka %% akka-stream_2.13` is declared at 2.5.32 in REDACTED, but 2.8.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.5.32 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.akka:akka-testkit_2.13 — `com.typesafe.akka %% akka-testkit_2.13` is declared at 2.5.32 in REDACTED, but 2.8.8 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.5.32 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.scala-logging:scala-logging_2.13 — `com.typesafe.scala-logging %% scala-logging_2.13` is declared at 3.9.5 in REDACTED, but 3.9.6 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.9.5 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: de.heikoseeberger:akka-http-circe_2.13 — `de.heikoseeberger %% akka-http-circe_2.13` is declared at 1.31.0 in REDACTED, but 1.39.2 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.31.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: de.javakaffee:kryo-serializers — `de.javakaffee %% kryo-serializers` is declared at 0.42 in REDACTED, but 0.45 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.42 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: dnsjava:dnsjava — `dnsjava %% dnsjava` is declared at 2.1.8 in REDACTED, but 3.7.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.1.8 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: io.altoo:akka-kryo-serialization_2.13 — `io.altoo %% akka-kryo-serialization_2.13` is declared at 1.1.0 in REDACTED, but 2.5.2 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.1.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: io.circe:circe-core_2.13 — `io.circe %% circe-core_2.13` is declared at 0.12.3 in REDACTED, but 0.14.17 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.12.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: io.circe:circe-generic_2.13 — `io.circe %% circe-generic_2.13` is declared at 0.12.3 in REDACTED, but 0.14.17 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.12.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: io.circe:circe-jawn_2.13 — `io.circe %% circe-jawn_2.13` is declared at 0.12.3 in REDACTED, but 0.14.17 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.12.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • + 40 more in this group — see findings.md.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-ab6fd7f09cb2432cbe99c5b5d91592ba/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-ab6fd7f09cb2432cbe99c5b5d91592ba/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt --exclude prometheus/src/main/java/remote .10artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-9e08afb60fed4c1ebe0afa71cd99a9f419artifacts/raw/osv-scanner.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 2 file(s) — `core/src/main/scala/filodb.core/metadata/ComputedColumn.scala`, `http/src/main/scala/filodb/http/PromQLGrpcServer.scala` — so the PII/GDPR sweep did not cover them at all.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm . /tmp/codehealth-osv-sbom-9e08afb60fed4c1ebe0afa71cd99a9f40artifacts/raw/osv-scanner.json

Run 01a17714-2980-7712-94d4-b5d289f4ce45 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 23 · Warnings: 650 · Recommendations: 151 · Info: 65 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 26-10-2026 @ 07:19 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md