Public report — guava, published 6 Aug 2026. Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version; ask the repo owner for the full report.
Watchdog 06-08-2026 @ 10:28 UTC Public
Code Health Audit

Google/guava

No baseline yet — first run
65% Adequate
CriticalWeakAdequateStrongExemplary
upper third — near Strong

Large · 420,988 LoC · rebuild ~7.1 person-years · weakest lens: Maturity (55%)

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

20/22dimensions tool-verifieddeterministic · confidence 1.0 · 2 LLM-assisted, advisory
173findings with an exact file:lineof 184 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
22/100dimensions across the health lenses420988 LoC — wide & deep

Executive summary

Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.

google/guava is sound in substance but carries real gaps (65%). It is not in crisis, but the issues below raise the cost of changing it — friction its consumers ultimately inherit.

It is strongest in Domain Modelling (100%) — the domain model is expressive and well-guarded. Architecture (100%) is solid too.

The area that most needs attention is Maturity (55%) — onboarding is slow — key decisions and the architecture aren't written down, so contributors have to reverse-engineer the intent. Security (64%) is the next concern — exposure to security and compliance incidents is elevated.

Leadership focus, highest impact first: Record significant decisions one document per decision (Architecture documentation); 'Testing' section to the root README (Documentation (README)); 1 The Guava Testlib README links to javadoc.io but does not… (Documentation Quality).

For scale: Large (~420,988 production lines); rebuilding it from scratch would take roughly ~7.1 person-years (~4–14 engineers). Approximate, ±~30%.

It builds on a genuinely strong Domain Modelling foundation (100%); the priorities above are the highest-leverage way to bring the rest up to that level.

How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Maturity 55% · 46% weightSecurity 64% · 25% weightReadiness 66% · 14% weightCode Health 98% · 8% weightArchitecture 100% · 4% weightDomain Modelling 100% · 2% weight

Raise Maturity 55 → 70 (the Healthy floor) ⇒ headline 65 → ~70.

Code composition — where the lines go
Tests 100%
Rebuild cost & value ~ Modeled — €340,000–€1,700,000
Cost to rebuild€340,000–€1,700,000 (3.4–10.8 person-years (5,727–18,167 h), ~4–14 engineers)
Domain complexityStandard — harder problems cost more per line
Quality factor0.9× (at 65% quality) — the last 20% of quality is most of the work
Size & shapeLarge · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)

This codebase represents roughly ~7.1 person-years of build effort (about ~€1,000,000 to rebuild). Its weakest lens is Maturity at 55% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.3) — vertical slice, domain model × a 0.9× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Resolve the 1 The Guava Testlib README links to javadoc.io but does not mention where… finding(s) in Documentation Quality — start with README.md.
+5.8 pts · Low effort · Documentation Quality
2
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
+9.2 pts · Medium effort · Architecture documentation
3
Add a 'Testing' section to the root README — how to run the test suite.
+7.5 pts · Medium effort · Documentation (README)

Diagnosis — what's actually going on

Value concentrated against a weak lens · Medium · Value at risk
This is a Large asset (~7.1 person-years to rebuild), and its weakest lens is Maturity at 55%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
Evidence: valuation: Large, ~7.1 person-years rebuild (420,988 LoC) · weakest lens: Maturity 55%
→ Direct remediation budget at Maturity first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form). The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).

Architecture — module dependency matrix

28 modules, 56 dependencies — every dependency points down the layering, so there are no cycles. Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)

(global)com.google.common…le.common.annotations….common.base.internal…l.concurrent.internalcom.google.common.base…lect.testing.featurescom.google.common.math…google.common.collect….google.common.escapecom.google.common.hash…gle.common.primitives…ommon.collect.testing…common.escape.testing…m.google.common.graphcom.google.common.htmlcom.google.common.net…ommon.util.concurrentcom.google.common.xml…irdparty.publicsuffix…m.google.common.cache…ollect.testing.google…llect.testing.testerscom.google.common.io…il.concurrent.testing…oogle.common.eventbus…google.common.reflect…google.common.testing(global)1com.google.common2…le.common.annotations3….common.base.internal4…l.concurrent.internal5com.google.common.base6…lect.testing.features7com.google.common.math8…google.common.collect9….google.common.escape10com.google.common.hash11…gle.common.primitives12…ommon.collect.testing13…common.escape.testing14…m.google.common.graph15com.google.common.html16com.google.common.net17…ommon.util.concurrent18com.google.common.xml19…irdparty.publicsuffix20…m.google.common.cache21…ollect.testing.google22…llect.testing.testers23com.google.common.io24…il.concurrent.testing25…oogle.common.eventbus26…google.common.reflect27…google.common.testing28881192177112311012281311541417421811172513115171246973413536611415463614312832722815482120

At a glance — Code Health · 98% · Exemplary

At a glance — Architecture · 100% · Exemplary

At a glance — Maturity · 55% · Adequate · gated by M2

At a glance — Readiness · 66% · Adequate

At a glance — Security · 64% · Adequate

At a glance — Domain Modelling · 100% · Exemplary

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2021 — Injection8High / Critical

Roadmap

Begin by creating a dedicated architecture decision record to document significant design choices and their consequences. Next, update the root README to include a section on how to run the test suite, and resolve existing documentation quality issues. Then, address the 17 instances of outdated or orphaned knowledge, starting with the specified Java files. Finally, implement a draft release or manual gate to prevent users from downloading bad builds.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 The Guava Testlib README links to javadoc.io but does not mention where… finding(s) in Documentation Quality — start with README.md.+5.8 ptsLowDocumentation Quality
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).+9.2 ptsMediumArchitecture documentation
Add a 'Testing' section to the root README — how to run the test suite.+7.5 ptsMediumDocumentation (README)
Resolve the 17 Orphaned knowledge finding(s) in Knowledge Freshness — start with CompactHashMap.java (2), TreeRangeSet.java (2), CompactHashSet.java (2).+4.8 ptsMediumKnowledge Freshness
Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.+4.7 ptsMediumDeployment & Rollback
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.+4.7 ptsMediumRelease Hygiene
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor.+2.3 ptsLowBus Factor
Resolve the 1 Off-boarding risk finding(s) in Bus Factor.+2.3 ptsLowBus Factor

File quality

Per-file score 0–10 — a quality signature. Of 82 files carrying findings, judged against the Production bar: 0% slop · 48% mixed · 52% near-clean.

FileScoreBandWorst signal
guava/src/com/google/common/collect/CompactLinkedHashMap.java6.3MixedCode Duplication: Duplicated block (12 lines × 2)
android/guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java6.9MixedStatic Analysis (SAST): Medium: weak-random
guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java6.9MixedStatic Analysis (SAST): Medium: weak-random
guava/src/com/google/common/cache/LocalCache.java7.0MixedCode Duplication: Duplicated block (15 lines × 2)
guava/src/com/google/common/collect/CompactHashMap.java7.0MixedCode Duplication: Duplicated block (13 lines × 2)
guava/src/com/google/common/collect/Maps.java7.1MixedCode Duplication: Duplicated block (15 lines × 2)
guava/src/com/google/common/collect/MapMakerInternalMap.java7.1MixedCode Duplication: Duplicated block (12 lines × 2)
guava/src/com/google/common/collect/ImmutableBiMap.java7.1MixedCode Duplication: Duplicated block (10 lines × 2)
guava/src/com/google/common/math/IntMath.java7.2MixedCode Duplication: Duplicated block (18 lines × 2)
guava/src/com/google/common/primitives/Booleans.java7.2MixedCode Duplication: Duplicated block (16 lines × 8)
guava/src/com/google/common/util/concurrent/ClosingFuture.java7.2MixedCode Duplication: Duplicated block (15 lines × 2)
guava/src/com/google/common/collect/Multisets.java7.2MixedCode Duplication: Duplicated block (12 lines × 2)
android/guava-testlib/src/com/google/common/collect/testing/ReserializingTestCollectionGenerator.java7.2MixedStatic Analysis (SAST): High: object-deserialization
android/guava-testlib/src/com/google/common/testing/Platform.java7.2MixedStatic Analysis (SAST): High: object-deserialization
guava-testlib/src/com/google/common/collect/testing/ReserializingTestCollectionGenerator.java7.2MixedStatic Analysis (SAST): High: object-deserialization
guava-testlib/src/com/google/common/testing/Platform.java7.2MixedStatic Analysis (SAST): High: object-deserialization
android/guava/src/com/google/common/cache/Striped64.java7.4MixedCode Duplication: Duplicated block (14 lines × 2)
guava/src/com/google/common/primitives/ImmutableDoubleArray.java7.4MixedCode Duplication: Duplicated block (11 lines × 3)
android/guava/src/com/google/common/cache/LongAdder.java7.4MixedCode Duplication: Duplicated block (11 lines × 2)
guava/src/com/google/common/math/LongMath.java7.4MixedCode Duplication: Duplicated block (10 lines × 2)

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 20 of 22 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 2 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.4 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 22 dimensions across the health lenses
D4D13D16D19D21D28D29D34D35D36AX5DM1DM5DM8M1M2M3M4P1P3P4P6

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 173 of 184 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
jscpdCode duplication✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.302✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.302✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 019fd69e-69ea-79f0-8ea3-39a01356b1c8.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (3): D19, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D4 · Code Duplication9.8 / 10Exemplary✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Verified

141 duplicated block group(s) detected.

Duplicated block (7 lines × 2) · ×19guava/src/com/google/common/cache/CacheBuilder.java:1110
Duplicated block (8 lines × 2) · ×15guava/src/com/google/common/cache/LocalCache.java:2226
Duplicated block (9 lines × 2) · ×14guava/src/com/google/common/collect/CartesianList.java:73
Duplicated block (10 lines × 2) · ×12guava/src/com/google/common/cache/LocalCache.java:3311
Duplicated block (12 lines × 2) · ×10guava/src/com/google/common/cache/LocalCache.java:2800

+ 23 more group(s) — more in Appendix A; the complete list is findings.md.

✓ On the Gold path — maintain.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D16 · Bus Factor8.0 / 10Strong✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: DocumentedVerifiedPrevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Documented

274 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is android/guava/src/com/google/common/cache/LocalCache.java.

Off-boarding risk: anonymized user #1
Further sole-owners (lower concentration)

What to do

  1. Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
  2. Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality / 10Adequate◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Adequate / 10 · rule-coverage 100% · ceiling Documented

Guava's documentation is strong and well-structured: the README for Guava itself (710 words) gives a clear overview of what it is, its two flavors, Maven/Gradle dependency syntax, and links to release, CI, and Best Practices badges. The Guava Testlib README (203 words) adds test-dependency details and links to javadoc.io, GitHub project, StackOverflow, guava-discuss, and a strong WARNINGS section about Beta APIs and the Guava Beta Checker. A third README in the futures directory is thin but present; it states only that modules are released exactly once each and no further guidance. The main weakness is the absence of architecture or design documentation for the Guava project itself (the outline lists 'Snapshots and Documentation' and 'Learn about Guava', both present), so a reader who wants to understand how Guava's libraries relate to one another would not find it in this set.

The Guava Testlib README links to javadoc.io but does not mention where the test classes live (whether they are in a separate package or namespace from the main Guava libraries).guava-testlib/README.md

What to do

  1. Resolve the 1 The Guava Testlib README links to javadoc.io but does not mention where… finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming Consistency / 10Exemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: DocumentedVerifiedPrevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.

Maturity: DocumentedVerifiedPrevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)4.1 / 10Weak✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: DocumentedVerifiedPrevented · effective 4.1 / 10 · rule-coverage 100% · ceiling Documented

8 finding(s): 0 critical, 4 high, 4 medium, 0 low.

High: object-deserialization · ×4android/guava-testlib/src/com/google/common/collect/testing/ReserializingTestCollectionGenerator.java:59detected by semgrep finding
Medium: weak-random · ×4android/guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java:104detected by semgrep finding

What to do

  1. Resolve the 4 High finding(s) in Static Analysis (SAST) — start with ReserializingTestCollectionGenerator.java (2), Platform.java (2). — One of this dimension's main actionable groups (4 issue-level).
  2. Resolve the 4 Medium finding(s) in Static Analysis (SAST) — start with MessageDigestAlgorithmBenchmark.java (4). — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness7.3 / 10Strong✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: DocumentedVerifiedPrevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Documented

373 of 1377 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is guava/src/com/google/common/collect/CompactHashMap.java.

Orphaned knowledge · ×17guava/src/com/google/common/collect/CompactHashMap.java
Further orphaned files (smaller)

What to do

  1. Resolve the 17 Orphaned knowledge finding(s) in Knowledge Freshness — start with CompactHashMap.java (2), TreeRangeSet.java (2), CompactHashSet.java (2). — One of this dimension's main actionable groups (17 issue-level).
  2. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.

Maturity: DocumentedVerifiedPrevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: StandardNetwork.java↔StandardValueGraph.java 80%; StandardNetwork.java↔StandardValueGraph.java 70%; CompactLinkedHashMap.java↔CompactLinkedHashSet.java 64%

Change coupling: StandardNetwork.java ↔ StandardValueGraph.java · ×6android/guava/src/com/google/common/graph/StandardNetwork.java

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: DocumentedVerifiedPrevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

No build provenance
No SBOM

What to do

  1. Resolve the 1 No build provenance finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  2. Resolve the 1 No SBOM finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

DM1 · Aggregate boundaries10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.

Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.

Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.

DM5 · Encapsulated state10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether entities protect their state (private/init-only setters) instead of exposing public setters that bypass invariants. Softened when a rehydration framework (Marten/EF) is present.

Method: Roslyn (DDD-gated): public setters on entities detected; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.

Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.

DM8 · Value-object opportunities10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.

Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.

M1 · Documentation (README)6.8 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 13 of 14 project(s) that lack one — worth up to 1.9 pts.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no `NNNN-title.md` documents and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/PlantUML/Mermaid diagram or architecture.md — the high-level shape isn't documented.

What to do

  • Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree with `NNNN-title.md` names is the most discoverable form).
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P3 · Security & performance tooling7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

  • Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health98%ExemplarySolid.
Architecture100%ExemplarySolid.
Maturity55%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness66%AdequateAcceptable, with room to improve.
Security64%AdequateAcceptable, with room to improve.
Domain Modelling100%ExemplaryStrongest area.
Not included — 78 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC2 Forms & labels — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC3 Page structure — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC4 Keyboard semantics — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC5 ARIA correctness — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC6 Visual & motion safety — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AC7 A11y enforcement — Frontend below the scale floor (2 DOM element(s) < 25) — too little surface to assess accessibility.
  • AX1 Captive dependencies — no DI registrations detected
  • AX10 Code composition — not assessed — code composition is computed by ROLE over a document set that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — no singleton implementations detected
  • AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX4 Dependency direction — not applicable to a vertical-slice architecture (the inward-dependency rule is for layered/clean styles)
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — vertical-slice architecture detected, but individual slices could not be resolved from namespaces or project layout
  • AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D1 Cyclomatic Complexity — Most of this repository's production source (.java) had no cyclomatic complexity computed for it, so cyclomatic complexity was not measured — whatever else this pass did read is not this repository's complexity. Not scored: no method bodies were exposed for those file kinds by any language model this pass could load. This is a gap in the analysis run, not a finding about this repository.
  • D10 Test Quality — ~283103 lines of test source are present (.java) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included
  • D12 Dependency Hygiene — Dependency hygiene not measured — dependency manifest found but not parsed for hygiene
  • D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (a Maven POM), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
  • D15 Churn × Complexity Hotspots — complexity unreadable for .java — churn × complexity hotspots could not be measured
  • D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D2 Cognitive Complexity — Most of this repository's production source (.java) had no cognitive complexity computed for it, so cognitive complexity was not measured — whatever else this pass did read is not this repository's complexity. Not scored: no method bodies were exposed for those file kinds by any language model this pass could load. This is a gap in the analysis run, not a finding about this repository.
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D22 Internal API Consistency — No exposed public API
  • D23 Boundary Type-Coupling — Production source is present (.java) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D3 God Classes — Most of this repository's production source (.java) was not read by god-class detection, so class size was not assessed for the languages that are the product — whatever else this pass did read is not this repository's class size. Not scored — this is a gap in the analyzer, not a verdict about this repository.
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Maven POM — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.
  • D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D38 OSV Dependency Vulnerabilities — Scanner failed to run — not a clean result
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
  • D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .java, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • D9 Test Distribution — Test source is present (.java) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • DM6 Domain ↔ infrastructure boundary — no domain-layer types detected — domain↔infrastructure boundary check not applicable
  • DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this check looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
  • GD1 Unfinished & placeholder code — no source files
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
  • P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Issue — 21 finding(s)
D34 · Knowledge Freshness · Orphaned knowledge · ×17
  • Orphaned knowledge guava/src/com/google/common/collect/CompactHashMap.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/collect/CompactHashMap.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/collect/TreeRangeSet.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/collect/TreeRangeSet.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/math/Stats.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/collect/CompactHashSet.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/collect/CompactHashSet.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/base/Ascii.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/hash/Crc32cHashFunction.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/hash/Crc32cHashFunction.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/util/concurrent/AbstractService.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/graph/Traverser.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/graph/Traverser.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/util/concurrent/SmoothRateLimiter.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/math/DoubleMath.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge android/guava/src/com/google/common/math/BigIntegerMath.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
  • Orphaned knowledge guava/src/com/google/common/math/BigIntegerMath.java — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
D29 · Static Analysis (SAST) · High · ×4
  • High: object-deserialization android/guava-testlib/src/com/google/common/collect/testing/ReserializingTestCollectionGenerator.java:59 — Found object deserialization using ObjectInputStream. Deserializing entire Java objects is dangerous because malicious actors can create Java object streams with unintended consequences. Ensure that the objects being deserialized are not user-controlled. If this must be done, consider using HMACs to sign the data stream to make sure it is not tampered with, or consider only transmitting object fields and populating a new object. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
  • High: object-deserialization android/guava-testlib/src/com/google/common/testing/Platform.java:46 — Found object deserialization using ObjectInputStream. Deserializing entire Java objects is dangerous because malicious actors can create Java object streams with unintended consequences. Ensure that the objects being deserialized are not user-controlled. If this must be done, consider using HMACs to sign the data stream to make sure it is not tampered with, or consider only transmitting object fields and populating a new object. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
  • High: object-deserialization guava-testlib/src/com/google/common/collect/testing/ReserializingTestCollectionGenerator.java:59 — Found object deserialization using ObjectInputStream. Deserializing entire Java objects is dangerous because malicious actors can create Java object streams with unintended consequences. Ensure that the objects being deserialized are not user-controlled. If this must be done, consider using HMACs to sign the data stream to make sure it is not tampered with, or consider only transmitting object fields and populating a new object. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
  • High: object-deserialization guava-testlib/src/com/google/common/testing/Platform.java:46 — Found object deserialization using ObjectInputStream. Deserializing entire Java objects is dangerous because malicious actors can create Java object streams with unintended consequences. Ensure that the objects being deserialized are not user-controlled. If this must be done, consider using HMACs to sign the data stream to make sure it is not tampered with, or consider only transmitting object fields and populating a new object. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Warning — 151 finding(s)
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×19
  • Duplicated block (7 lines × 2) guava/src/com/google/common/cache/CacheBuilder.java:1110 — guava/src/com/google/common/cache/CacheBuilder.java:1110-1116 | guava/src/com/google/common/collect/MapMaker.java:303-309 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/CacheBuilder.java:1110` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/Comparators.java:75 — guava/src/com/google/common/collect/Comparators.java:75-81 | guava/src/com/google/common/collect/Comparators.java:97-103 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Comparators.java:75` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/ImmutableBiMap.java:558 — guava/src/com/google/common/collect/ImmutableBiMap.java:558-564 | guava/src/com/google/common/collect/ImmutableMap.java:727-734 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableBiMap.java:558` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/Maps.java:4135 — guava/src/com/google/common/collect/Maps.java:4135-4141 | guava/src/com/google/common/collect/Maps.java:4150-4156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/Maps.java:4484 — guava/src/com/google/common/collect/Maps.java:4484-4490 | guava/src/com/google/common/collect/Sets.java:2310-2316 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Maps.java:4484` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/Multisets.java:512 — guava/src/com/google/common/collect/Multisets.java:512-519 | guava/src/com/google/common/collect/Multisets.java:661-667 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Multisets.java:512` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/TreeRangeSet.java:390 — guava/src/com/google/common/collect/TreeRangeSet.java:390-396 | guava/src/com/google/common/collect/TreeRangeSet.java:423-429 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/TreeRangeSet.java:390` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/collect/TreeRangeSet.java:802 — guava/src/com/google/common/collect/TreeRangeSet.java:802-808 | guava/src/com/google/common/collect/TreeRangeSet.java:835-841 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/TreeRangeSet.java:802` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/graph/Graphs.java:568 — guava/src/com/google/common/graph/Graphs.java:568-574 | guava/src/com/google/common/graph/Graphs.java:595-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/graph/Graphs.java:568` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava/src/com/google/common/io/BaseEncoding.java:758 — guava/src/com/google/common/io/BaseEncoding.java:758-764 | guava/src/com/google/common/io/BaseEncoding.java:1029-1035 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/io/BaseEncoding.java:758` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/AbstractListMultimapTester.java:47 — guava-testlib/src/com/google/common/collect/testing/google/AbstractListMultimapTester.java:47-53 | guava-testlib/src/com/google/common/collect/testing/google/AbstractMultimapTester.java:159-166 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/AbstractListMultimapTester.java:47` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/DerivedGoogleCollectionGenerators.java:168 — guava-testlib/src/com/google/common/collect/testing/google/DerivedGoogleCollectionGenerators.java:168-174 | guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java:213-219 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/DerivedGoogleCollectionGenerators.java:168` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultimapAsMapGetTester.java:107 — guava-testlib/src/com/google/common/collect/testing/google/MultimapAsMapGetTester.java:107-113 | guava-testlib/src/com/google/common/collect/testing/google/MultimapGetTester.java:110-116 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:113 — guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:113-119 | guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:134-140 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:113` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:475 — guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:475-481 | guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:581-587 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:475` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:50 — guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:50-56 | guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:75-81 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:50` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/testers/CollectionToArrayTester.java:129 — guava-testlib/src/com/google/common/collect/testing/testers/CollectionToArrayTester.java:129-135 | guava-testlib/src/com/google/common/collect/testing/testers/CollectionToArrayTester.java:150-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/testers/MapReplaceAllTester.java:53 — guava-testlib/src/com/google/common/collect/testing/testers/MapReplaceAllTester.java:53-59 | guava-testlib/src/com/google/common/collect/testing/testers/MapReplaceAllTester.java:70-76 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7 lines × 2) guava-testlib/src/com/google/common/collect/testing/testers/SortedMapNavigationTester.java:116 — guava-testlib/src/com/google/common/collect/testing/testers/SortedMapNavigationTester.java:116-122 | guava-testlib/src/com/google/common/collect/testing/testers/SortedMapNavigationTester.java:128-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/testers/SortedMapNavigationTester.java:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×15
  • Duplicated block (8 lines × 2) guava/src/com/google/common/cache/LocalCache.java:2226 — guava/src/com/google/common/cache/LocalCache.java:2226-2234 | guava/src/com/google/common/cache/LocalCache.java:2410-2417 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2226` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/cache/LocalCache.java:2944 — guava/src/com/google/common/cache/LocalCache.java:2944-2951 | guava/src/com/google/common/cache/LocalCache.java:3005-3012 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2944` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/cache/LocalCache.java:3071 — guava/src/com/google/common/cache/LocalCache.java:3071-3078 | guava/src/com/google/common/cache/LocalCache.java:3117-3124 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:3071` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/CompactLinkedHashMap.java:203 — guava/src/com/google/common/collect/CompactLinkedHashMap.java:203-210 | guava/src/com/google/common/collect/CompactLinkedHashSet.java:202-209 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/ForwardingSortedMultiset.java:165 — guava/src/com/google/common/collect/ForwardingSortedMultiset.java:165-172 | guava/src/com/google/common/collect/ForwardingSortedMultiset.java:188-195 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ForwardingSortedMultiset.java:165` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/ImmutableList.java:221 — guava/src/com/google/common/collect/ImmutableList.java:221-228 | guava/src/com/google/common/collect/ImmutableSortedSet.java:170-177 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/ImmutableMultiset.java:653 — guava/src/com/google/common/collect/ImmutableMultiset.java:653-660 | android/guava/src/com/google/common/collect/RegularImmutableMultiset.java:121-128 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableMultiset.java:653` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/TreeMultiset.java:795 — guava/src/com/google/common/collect/TreeMultiset.java:795-802 | guava/src/com/google/common/collect/TreeMultiset.java:812-819 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/TreeMultiset.java:795` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/collect/TreeMultiset.java:852 — guava/src/com/google/common/collect/TreeMultiset.java:852-859 | guava/src/com/google/common/collect/TreeMultiset.java:873-880 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/TreeMultiset.java:852` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/graph/DirectedGraphConnections.java:275 — guava/src/com/google/common/graph/DirectedGraphConnections.java:275-282 | guava/src/com/google/common/graph/DirectedGraphConnections.java:323-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/graph/DirectedGraphConnections.java:275` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/hash/LittleEndianByteArray.java:227 — guava/src/com/google/common/hash/LittleEndianByteArray.java:227-234 | guava/src/com/google/common/primitives/UnsignedBytes.java:379-386 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/hash/LittleEndianByteArray.java:227` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava/src/com/google/common/hash/Murmur3_32HashFunction.java:160 — guava/src/com/google/common/hash/Murmur3_32HashFunction.java:160-167 | guava/src/com/google/common/hash/Murmur3_32HashFunction.java:361-368 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/hash/Murmur3_32HashFunction.java:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/ListMultimapPutTester.java:44 — guava-testlib/src/com/google/common/collect/testing/google/ListMultimapPutTester.java:44-52 | guava-testlib/src/com/google/common/collect/testing/google/ListMultimapPutTester.java:67-74 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/ListMultimapPutTester.java:44` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:602 — guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:602-609 | guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:626-633 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapTestSuiteBuilder.java:602` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) android/guava/src/com/google/common/cache/LongAdder.java:64 — android/guava/src/com/google/common/cache/LongAdder.java:64-71 | android/guava/src/com/google/common/hash/LongAdder.java:62-69 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/LongAdder.java:64` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×14
  • Duplicated block (9 lines × 2) guava/src/com/google/common/collect/CartesianList.java:73 — guava/src/com/google/common/collect/CartesianList.java:73-81 | guava/src/com/google/common/collect/CartesianList.java:95-103 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CartesianList.java:73` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:386 — guava/src/com/google/common/collect/CompactHashMap.java:386-394 | guava/src/com/google/common/collect/CompactHashSet.java:340-348 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:386` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:412 — guava/src/com/google/common/collect/CompactHashMap.java:412-420 | guava/src/com/google/common/collect/CompactHashSet.java:364-372 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:412` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/collect/TreeMultiset.java:742 — guava/src/com/google/common/collect/TreeMultiset.java:742-750 | guava/src/com/google/common/collect/TreeMultiset.java:760-768 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/graph/AbstractBaseGraph.java:91 — guava/src/com/google/common/graph/AbstractBaseGraph.java:91-99 | guava/src/com/google/common/graph/AbstractNetwork.java:89-97 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/graph/AbstractBaseGraph.java:91` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/hash/FarmHashFingerprint64.java:104 — guava/src/com/google/common/hash/FarmHashFingerprint64.java:104-112 | guava/src/com/google/common/hash/Fingerprint2011.java:101-109 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/math/LongMath.java:598 — guava/src/com/google/common/math/LongMath.java:598-606 | guava/src/com/google/common/math/LongMath.java:716-724 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/LongMath.java:598` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/math/PairedStats.java:190 — guava/src/com/google/common/math/PairedStats.java:190-198 | guava/src/com/google/common/math/PairedStatsAccumulator.java:223-231 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/PairedStats.java:190` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/primitives/ImmutableIntArray.java:582 — guava/src/com/google/common/primitives/ImmutableIntArray.java:582-590 | guava/src/com/google/common/primitives/ImmutableLongArray.java:584-592 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/ImmutableIntArray.java:582` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/primitives/UnsignedInts.java:167 — guava/src/com/google/common/primitives/UnsignedInts.java:167-175 | guava/src/com/google/common/primitives/UnsignedLongs.java:132-140 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/UnsignedInts.java:167` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) guava/src/com/google/common/util/concurrent/AtomicDoubleArray.java:243 — guava/src/com/google/common/util/concurrent/AtomicDoubleArray.java:243-251 | guava/src/com/google/common/util/concurrent/AtomicDoubleArray.java:265-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/DerivedGoogleCollectionGenerators.java:186 — guava-testlib/src/com/google/common/collect/testing/google/DerivedGoogleCollectionGenerators.java:186-194 | guava-testlib/src/com/google/common/collect/testing/DerivedCollectionGenerators.java:231-239 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) android/guava/src/com/google/common/cache/LongAdder.java:101 — android/guava/src/com/google/common/cache/LongAdder.java:101-109 | android/guava/src/com/google/common/hash/LongAdder.java:99-107 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/LongAdder.java:101` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) android/guava/src/com/google/common/cache/Striped64.java:262 — android/guava/src/com/google/common/cache/Striped64.java:262-270 | android/guava/src/com/google/common/hash/Striped64.java:262-270 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/Striped64.java:262` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×12
  • Duplicated block (10 lines × 2) guava/src/com/google/common/cache/LocalCache.java:3311 — guava/src/com/google/common/cache/LocalCache.java:3311-3320 | guava/src/com/google/common/cache/LocalCache.java:3425-3434 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:3311` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:716 — guava/src/com/google/common/collect/CompactHashMap.java:716-725 | guava/src/com/google/common/collect/CompactHashMap.java:1038-1047 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/ImmutableBiMap.java:501 — guava/src/com/google/common/collect/ImmutableBiMap.java:501-511 | guava/src/com/google/common/collect/ImmutableMap.java:633-642 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableBiMap.java:501` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/ImmutableList.java:897 — guava/src/com/google/common/collect/ImmutableList.java:897-906 | android/guava/src/com/google/common/collect/ImmutableCollection.java:558-567 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableList.java:897` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/ImmutableSortedMap.java:329 — guava/src/com/google/common/collect/ImmutableSortedMap.java:329-338 | guava/src/com/google/common/collect/ImmutableSortedMap.java:369-378 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableSortedMap.java:369` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/MapMakerInternalMap.java:1636 — guava/src/com/google/common/collect/MapMakerInternalMap.java:1636-1645 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1683-1692 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MapMakerInternalMap.java:1636` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/collect/MapMakerInternalMap.java:1714 — guava/src/com/google/common/collect/MapMakerInternalMap.java:1714-1723 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1754-1763 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MapMakerInternalMap.java:1714` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/graph/DirectedGraphConnections.java:288 — guava/src/com/google/common/graph/DirectedGraphConnections.java:288-297 | guava/src/com/google/common/graph/DirectedGraphConnections.java:336-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/graph/DirectedGraphConnections.java:288` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/math/LongMath.java:1265 — guava/src/com/google/common/math/LongMath.java:1265-1274 | guava/src/com/google/common/math/ToDoubleRounder.java:74-83 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/LongMath.java:1265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/net/PercentEscaper.java:186 — guava/src/com/google/common/net/PercentEscaper.java:186-195 | guava/src/com/google/common/net/PercentEscaper.java:204-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/net/PercentEscaper.java:186` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) guava/src/com/google/common/util/concurrent/ClosingFuture.java:1836 — guava/src/com/google/common/util/concurrent/ClosingFuture.java:1836-1845 | guava/src/com/google/common/util/concurrent/ClosingFuture.java:2048-2057 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/util/concurrent/ClosingFuture.java:1836` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (10 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:203 — guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:203-212 | guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:165-174 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:203` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×10
  • Duplicated block (12 lines × 2) guava/src/com/google/common/cache/LocalCache.java:2800 — guava/src/com/google/common/cache/LocalCache.java:2800-2811 | guava/src/com/google/common/cache/LocalCache.java:3153-3164 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2800` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/CollectSpliterators.java:356 — guava/src/com/google/common/collect/CollectSpliterators.java:356-367 | guava/src/com/google/common/collect/CollectSpliterators.java:480-491 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CollectSpliterators.java:356` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:584 — guava/src/com/google/common/collect/CompactHashMap.java:584-595 | guava/src/com/google/common/collect/CompactHashSet.java:499-510 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:584` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/CompactLinkedHashMap.java:246 — guava/src/com/google/common/collect/CompactLinkedHashMap.java:246-257 | guava/src/com/google/common/collect/CompactLinkedHashMap.java:269-280 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/ImmutableRangeMap.java:185 — guava/src/com/google/common/collect/ImmutableRangeMap.java:185-196 | guava/src/com/google/common/collect/ImmutableRangeMap.java:202-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableRangeMap.java:185` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/MapMakerInternalMap.java:1852 — guava/src/com/google/common/collect/MapMakerInternalMap.java:1852-1863 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1944-1955 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MapMakerInternalMap.java:1852` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/Multisets.java:421 — guava/src/com/google/common/collect/Multisets.java:421-432 | guava/src/com/google/common/collect/Multisets.java:551-563 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Multisets.java:421` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/Multisets.java:440 — guava/src/com/google/common/collect/Multisets.java:440-451 | guava/src/com/google/common/collect/Multisets.java:576-587 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Multisets.java:440` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/collect/Multisets.java:465 — guava/src/com/google/common/collect/Multisets.java:465-476 | guava/src/com/google/common/collect/Multisets.java:600-611 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Multisets.java:465` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) guava/src/com/google/common/math/IntMath.java:597 — guava/src/com/google/common/math/IntMath.java:597-608 | guava/src/com/google/common/math/LongMath.java:742-753 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/IntMath.java:597` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×10
  • Duplicated block (5 lines × 2) guava/src/com/google/common/collect/FilteredEntryMultimap.java:160 — guava/src/com/google/common/collect/FilteredEntryMultimap.java:160-164 | guava/src/com/google/common/collect/FilteredEntryMultimap.java:321-326 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/FilteredEntryMultimap.java:160` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/collect/MapMakerInternalMap.java:1879 — guava/src/com/google/common/collect/MapMakerInternalMap.java:1879-1883 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1915-1919 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MapMakerInternalMap.java:1879` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/collect/Maps.java:2914 — guava/src/com/google/common/collect/Maps.java:2914-2918 | guava/src/com/google/common/collect/Maps.java:2928-2932 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Maps.java:2914` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/collect/Maps.java:3039 — guava/src/com/google/common/collect/Maps.java:3039-3043 | guava/src/com/google/common/collect/Maps.java:3053-3057 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Maps.java:3039` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/eventbus/SubscriberRegistry.java:75 — guava/src/com/google/common/eventbus/SubscriberRegistry.java:75-79 | guava/src/com/google/common/eventbus/SubscriberRegistry.java:95-99 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/eventbus/SubscriberRegistry.java:75` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/graph/Graphs.java:643 — guava/src/com/google/common/graph/Graphs.java:643-647 | guava/src/com/google/common/graph/Graphs.java:656-661 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/graph/Graphs.java:643` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) guava/src/com/google/common/hash/Murmur3_128HashFunction.java:141 — guava/src/com/google/common/hash/Murmur3_128HashFunction.java:141-145 | guava/src/com/google/common/hash/Murmur3_128HashFunction.java:158-162 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:135 — guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:135-139 | guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:230-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:149 — guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:149-153 | guava-testlib/src/com/google/common/collect/testing/google/MultisetEntrySetTester.java:216-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (5 lines × 2) guava-testlib/src/com/google/common/collect/testing/testers/ListSubListTester.java:234 — guava-testlib/src/com/google/common/collect/testing/testers/ListSubListTester.java:234-238 | guava-testlib/src/com/google/common/collect/testing/testers/ListSubListTester.java:252-256 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×9
  • Duplicated block (6 lines × 2) guava/src/com/google/common/cache/LocalCache.java:1688 — guava/src/com/google/common/cache/LocalCache.java:1688-1693 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1090-1095 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) guava/src/com/google/common/cache/LocalCache.java:3341 — guava/src/com/google/common/cache/LocalCache.java:3341-3346 | guava/src/com/google/common/cache/LocalCache.java:3419-3424 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:3341` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) guava/src/com/google/common/collect/AbstractMapEntry.java:51 — guava/src/com/google/common/collect/AbstractMapEntry.java:51-56 | guava/src/com/google/common/collect/ForwardingMapEntry.java:98-103 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/AbstractMapEntry.java:51` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) guava/src/com/google/common/collect/MinMaxPriorityQueue.java:644 — guava/src/com/google/common/collect/MinMaxPriorityQueue.java:644-654 | guava/src/com/google/common/collect/MinMaxPriorityQueue.java:684-689 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MinMaxPriorityQueue.java:644` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) guava/src/com/google/common/collect/Ordering.java:899 — guava/src/com/google/common/collect/Ordering.java:899-904 | guava/src/com/google/common/collect/Ordering.java:923-928 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Ordering.java:899` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (6 lines × 2) guava/src/com/google/common/hash/Murmur3_128HashFunction.java:132 — guava/src/com/google/common/hash/Murmur3_128HashFunction.java:132-137 | guava/src/com/google/common/hash/Murmur3_128HashFunction.java:149-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/hash/Murmur3_128HashFunction.java:132` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:62 — guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:62-67 | guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:87-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultisetIteratorTester.java:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) guava-testlib/src/com/google/common/collect/testing/google/SetMultimapTestSuiteBuilder.java:57 — guava-testlib/src/com/google/common/collect/testing/google/SetMultimapTestSuiteBuilder.java:57-62 | guava-testlib/src/com/google/common/collect/testing/google/SortedSetMultimapTestSuiteBuilder.java:56-61 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once.
  • Duplicated block (6 lines × 2) guava-testlib/src/com/google/common/collect/testing/Helpers.java:302 — guava-testlib/src/com/google/common/collect/testing/Helpers.java:302-308 | guava-testlib/src/com/google/common/collect/testing/Helpers.java:326-331 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/Helpers.java:302` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×7
  • Duplicated block (11 lines × 2) guava/src/com/google/common/collect/CartesianList.java:158 — guava/src/com/google/common/collect/CartesianList.java:158-168 | guava/src/com/google/common/collect/Sets.java:1603-1613 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:358 — guava/src/com/google/common/collect/CompactHashMap.java:358-368 | guava/src/com/google/common/collect/CompactHashSet.java:317-327 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:358` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:1078 — guava/src/com/google/common/collect/CompactHashMap.java:1078-1088 | guava/src/com/google/common/collect/CompactHashSet.java:663-673 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:1078` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) guava/src/com/google/common/collect/Sets.java:945 — guava/src/com/google/common/collect/Sets.java:945-955 | guava/src/com/google/common/collect/Sets.java:1026-1036 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Sets.java:945` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) guava/src/com/google/common/math/IntMath.java:515 — guava/src/com/google/common/math/IntMath.java:515-525 | guava/src/com/google/common/math/LongMath.java:618-628 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/IntMath.java:515` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) android/guava/src/com/google/common/cache/LongAdder.java:134 — android/guava/src/com/google/common/cache/LongAdder.java:134-144 | android/guava/src/com/google/common/hash/LongAdder.java:132-142 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/LongAdder.java:134` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) android/guava/src/com/google/common/cache/Striped64.java:295 — android/guava/src/com/google/common/cache/Striped64.java:295-305 | android/guava/src/com/google/common/hash/Striped64.java:295-305 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/Striped64.java:295` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D35 · Change Coupling · Change coupling · ×6
  • Change coupling: StandardNetwork.java ↔ StandardValueGraph.java android/guava/src/com/google/common/graph/StandardNetwork.java — `android/guava/src/com/google/common/graph/StandardNetwork.java` and `android/guava/src/com/google/common/graph/StandardValueGraph.java` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: StandardNetwork.java ↔ StandardValueGraph.java android/guava/src/com/google/common/graph/StandardNetwork.java — `android/guava/src/com/google/common/graph/StandardNetwork.java` and `guava/src/com/google/common/graph/StandardValueGraph.java` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: CompactLinkedHashMap.java ↔ CompactLinkedHashSet.java guava/src/com/google/common/collect/CompactLinkedHashMap.java — `guava/src/com/google/common/collect/CompactLinkedHashMap.java` and `guava/src/com/google/common/collect/CompactLinkedHashSet.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: CompactLinkedHashSet.java ↔ CompactLinkedHashMap.java android/guava/src/com/google/common/collect/CompactLinkedHashSet.java — `android/guava/src/com/google/common/collect/CompactLinkedHashSet.java` and `guava/src/com/google/common/collect/CompactLinkedHashMap.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: CompactLinkedHashMap.java ↔ CompactLinkedHashSet.java android/guava/src/com/google/common/collect/CompactLinkedHashMap.java — `android/guava/src/com/google/common/collect/CompactLinkedHashMap.java` and `android/guava/src/com/google/common/collect/CompactLinkedHashSet.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking.
  • Change coupling: CompactLinkedHashMap.java ↔ CompactLinkedHashSet.java android/guava/src/com/google/common/collect/CompactLinkedHashMap.java — `android/guava/src/com/google/common/collect/CompactLinkedHashMap.java` and `guava/src/com/google/common/collect/CompactLinkedHashSet.java` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×6
  • Duplicated block (14 lines × 2) guava/src/com/google/common/cache/LocalCache.java:287 — guava/src/com/google/common/cache/LocalCache.java:287-300 | guava/src/com/google/common/collect/MapMakerInternalMap.java:182-195 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:287` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) guava/src/com/google/common/cache/LocalCache.java:2700 — guava/src/com/google/common/cache/LocalCache.java:2700-2713 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1416-1429 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2700` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) guava/src/com/google/common/io/Files.java:551 — guava/src/com/google/common/io/Files.java:551-564 | guava/src/com/google/common/io/Resources.java:149-162 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/io/Files.java:551` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) guava/src/com/google/common/util/concurrent/ClosingFuture.java:1588 — guava/src/com/google/common/util/concurrent/ClosingFuture.java:1588-1601 | guava/src/com/google/common/util/concurrent/ClosingFuture.java:1644-1657 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/util/concurrent/ClosingFuture.java:1588` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) guava/src/com/google/common/util/concurrent/ClosingFuture.java:1994 — guava/src/com/google/common/util/concurrent/ClosingFuture.java:1994-2007 | guava/src/com/google/common/util/concurrent/ClosingFuture.java:2053-2066 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/util/concurrent/ClosingFuture.java:1994` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) android/guava/src/com/google/common/cache/Striped64.java:209 — android/guava/src/com/google/common/cache/Striped64.java:209-222 | android/guava/src/com/google/common/hash/Striped64.java:209-222 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `android/guava/src/com/google/common/cache/Striped64.java:209` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×5
  • Duplicated block (15 lines × 2) guava/src/com/google/common/cache/LocalCache.java:2960 — guava/src/com/google/common/cache/LocalCache.java:2960-2974 | guava/src/com/google/common/cache/LocalCache.java:3021-3035 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2960` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) guava/src/com/google/common/cache/LocalCache.java:4375 — guava/src/com/google/common/cache/LocalCache.java:4375-4389 | guava/src/com/google/common/collect/MapMakerInternalMap.java:2540-2554 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:4375` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) guava/src/com/google/common/collect/Maps.java:1153 — guava/src/com/google/common/collect/Maps.java:1153-1167 | guava/src/com/google/common/collect/Maps.java:1190-1204 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Maps.java:1153` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) guava/src/com/google/common/reflect/TypeToken.java:615 — guava/src/com/google/common/reflect/TypeToken.java:615-629 | guava/src/com/google/common/reflect/TypeToken.java:654-668 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/reflect/TypeToken.java:615` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) guava/src/com/google/common/util/concurrent/ClosingFuture.java:1783 — guava/src/com/google/common/util/concurrent/ClosingFuture.java:1783-1797 | guava/src/com/google/common/util/concurrent/ClosingFuture.java:1840-1854 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/util/concurrent/ClosingFuture.java:1783` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×5
  • Duplicated block (9 lines × 3) guava/src/com/google/common/collect/ImmutableBiMap.java:183 — guava/src/com/google/common/collect/ImmutableBiMap.java:183-191 | guava/src/com/google/common/collect/ImmutableBiMap.java:219-227 | guava/src/com/google/common/collect/ImmutableBiMap.java:258-266 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableBiMap.java:219` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 3) guava/src/com/google/common/collect/ImmutableBiMap.java:260 — guava/src/com/google/common/collect/ImmutableBiMap.java:260-268 | guava/src/com/google/common/collect/ImmutableMap.java:313-321 | guava/src/com/google/common/collect/ImmutableSortedMap.java:371-379 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableBiMap.java:260` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) guava/src/com/google/common/collect/ImmutableMap.java:236 — guava/src/com/google/common/collect/ImmutableMap.java:236-244 | guava/src/com/google/common/collect/ImmutableMap.java:272-280 | guava/src/com/google/common/collect/ImmutableMap.java:311-319 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableMap.java:272` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 3) guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:121 — guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:121-129 | guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:142-150 | guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:172-180 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapRemoveEntryTester.java:121` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java:56 — guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java:56-64 | guava-testlib/src/com/google/common/collect/testing/ListTestSuiteBuilder.java:115-123 | guava-testlib/src/com/google/common/collect/testing/SetTestSuiteBuilder.java:79-87 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/CollectionTestSuiteBuilder.java:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×5
  • Duplicated block (8 lines × 3) guava/src/com/google/common/cache/LocalCache.java:2116 — guava/src/com/google/common/cache/LocalCache.java:2116-2124 | guava/src/com/google/common/cache/LocalCache.java:3059-3066 | guava/src/com/google/common/cache/LocalCache.java:3105-3112 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) guava/src/com/google/common/collect/MapMakerInternalMap.java:1515 — guava/src/com/google/common/collect/MapMakerInternalMap.java:1515-1523 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1634-1641 | guava/src/com/google/common/collect/MapMakerInternalMap.java:1681-1688 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MapMakerInternalMap.java:1515` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) guava/src/com/google/common/math/LongMath.java:271 — guava/src/com/google/common/math/LongMath.java:271-278 | guava/src/com/google/common/math/LongMath.java:600-607 | guava/src/com/google/common/math/LongMath.java:718-725 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/LongMath.java:271` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 3) guava/src/com/google/common/primitives/ImmutableDoubleArray.java:619 — guava/src/com/google/common/primitives/ImmutableDoubleArray.java:619-626 | guava/src/com/google/common/primitives/ImmutableIntArray.java:609-616 | guava/src/com/google/common/primitives/ImmutableLongArray.java:611-618 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/ImmutableDoubleArray.java:619` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:162 — guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:162-169 | guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:182-189 | guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:210-217 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/MultimapPutTester.java:162` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D29 · Static Analysis (SAST) · Medium · ×4
  • Medium: weak-random android/guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java:104 — Detected use of the functions `Math.random()` or `java.util.Random()`. These are both not cryptographically strong random number generators (RNGs). If you are using these RNGs to create passwords or secret tokens, use `java.security.SecureRandom` instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Medium: weak-random android/guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java:111 — Detected use of the functions `Math.random()` or `java.util.Random()`. These are both not cryptographically strong random number generators (RNGs). If you are using these RNGs to create passwords or secret tokens, use `java.security.SecureRandom` instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Medium: weak-random guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java:104 — Detected use of the functions `Math.random()` or `java.util.Random()`. These are both not cryptographically strong random number generators (RNGs). If you are using these RNGs to create passwords or secret tokens, use `java.security.SecureRandom` instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
  • Medium: weak-random guava-tests/benchmark/com/google/common/hash/MessageDigestAlgorithmBenchmark.java:111 — Detected use of the functions `Math.random()` or `java.util.Random()`. These are both not cryptographically strong random number generators (RNGs). If you are using these RNGs to create passwords or secret tokens, use `java.security.SecureRandom` instead. This is a semgrep security-AUDIT rule: it reports that a sensitive pattern is present, not that it is exploitable here. Confirm whether the flagged value reaches a security decision — a credential, token, nonce, key, salt or session id, or an externally reachable surface — and apply the change where it does; where it provably does not (cosmetic, simulation, or deliberately reproducible use), record the review and leave the code as it is.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×4
  • Duplicated block (13 lines × 2) guava/src/com/google/common/base/Joiner.java:560 — guava/src/com/google/common/base/Joiner.java:560-572 | guava/src/com/google/common/collect/ImmutableCollection.java:417-429 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/base/Joiner.java:560` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) guava/src/com/google/common/collect/CollectCollectors.java:269 — guava/src/com/google/common/collect/CollectCollectors.java:269-281 | guava/src/com/google/common/collect/CollectCollectors.java:296-308 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CollectCollectors.java:296` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (13 lines × 2) guava/src/com/google/common/collect/CompactHashMap.java:434 — guava/src/com/google/common/collect/CompactHashMap.java:434-450 | guava/src/com/google/common/collect/CompactHashSet.java:385-397 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/CompactHashMap.java:434` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:201 — guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:201-213 | guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:225-237 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:201` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×3
  • Duplicated block (18 lines × 2) guava/src/com/google/common/collect/ImmutableRangeMap.java:367 — guava/src/com/google/common/collect/ImmutableRangeMap.java:367-384 | guava/src/com/google/common/collect/ImmutableRangeSet.java:508-525 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableRangeMap.java:367` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) guava/src/com/google/common/collect/MutableClassToInstanceMap.java:135 — guava/src/com/google/common/collect/MutableClassToInstanceMap.java:135-152 | guava/src/com/google/common/reflect/MutableTypeToInstanceMap.java:136-153 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/MutableClassToInstanceMap.java:135` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) guava/src/com/google/common/math/IntMath.java:333 — guava/src/com/google/common/math/IntMath.java:333-350 | guava/src/com/google/common/math/LongMath.java:401-418 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/IntMath.java:333` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×2
  • Duplicated block (10 lines × 3) guava/src/com/google/common/math/Stats.java:518 — guava/src/com/google/common/math/Stats.java:518-527 | guava/src/com/google/common/math/Stats.java:542-551 | guava/src/com/google/common/math/Stats.java:567-576 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/Stats.java:518` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 3) guava/src/com/google/common/primitives/ImmutableDoubleArray.java:539 — guava/src/com/google/common/primitives/ImmutableDoubleArray.java:539-548 | guava/src/com/google/common/primitives/ImmutableIntArray.java:534-543 | guava/src/com/google/common/primitives/ImmutableLongArray.java:536-545 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/ImmutableDoubleArray.java:539` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×2
  • Duplicated block (9 lines × 4) guava/src/com/google/common/collect/ImmutableBiMap.java:220 — guava/src/com/google/common/collect/ImmutableBiMap.java:220-228 | guava/src/com/google/common/collect/ImmutableBiMap.java:259-267 | guava/src/com/google/common/collect/ImmutableMap.java:273-281 | guava/src/com/google/common/collect/ImmutableMap.java:312-320 — there are 4 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/ImmutableBiMap.java:220` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 4) guava/src/com/google/common/collect/Streams.java:453 — guava/src/com/google/common/collect/Streams.java:453-461 | guava/src/com/google/common/collect/Streams.java:537-545 | guava/src/com/google/common/collect/Streams.java:616-624 | guava/src/com/google/common/collect/Streams.java:695-703 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Streams.java:453` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×2
  • Duplicated block (7 lines × 3) guava/src/com/google/common/net/PercentEscaper.java:177 — guava/src/com/google/common/net/PercentEscaper.java:177-183 | guava/src/com/google/common/net/PercentEscaper.java:193-199 | guava/src/com/google/common/net/PercentEscaper.java:212-218 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (7 lines × 3) guava/src/com/google/common/primitives/UnsignedBytes.java:584 — guava/src/com/google/common/primitives/UnsignedBytes.java:584-590 | guava/src/com/google/common/primitives/UnsignedInts.java:235-241 | guava/src/com/google/common/primitives/UnsignedLongs.java:201-207 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/UnsignedBytes.java:584` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 8) · ×1
  • Duplicated block (16 lines × 8) guava/src/com/google/common/primitives/Booleans.java:597 — guava/src/com/google/common/primitives/Booleans.java:597-612 | guava/src/com/google/common/primitives/Bytes.java:447-462 | guava/src/com/google/common/primitives/Chars.java:538-553 | guava/src/com/google/common/primitives/Doubles.java:511-526 | guava/src/com/google/common/primitives/Floats.java:508-523 | guava/src/com/google/common/primitives/Ints.java:591-606 | guava/src/com/google/common/primitives/Longs.java:648-663 | guava/src/com/google/common/primitives/Shorts.java:559-574 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/Booleans.java:597` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1
  • Duplicated block (16 lines × 2) guava/src/com/google/common/math/IntMath.java:160 — guava/src/com/google/common/math/IntMath.java:160-175 | guava/src/com/google/common/math/LongMath.java:168-183 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/math/IntMath.java:160` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) guava/src/com/google/common/collect/Streams.java:565 — guava/src/com/google/common/collect/Streams.java:565-578 | guava/src/com/google/common/collect/Streams.java:644-657 | guava/src/com/google/common/collect/Streams.java:723-736 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/collect/Streams.java:565` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 8) · ×1
  • Duplicated block (11 lines × 8) guava/src/com/google/common/primitives/Booleans.java:482 — guava/src/com/google/common/primitives/Booleans.java:482-492 | guava/src/com/google/common/primitives/Bytes.java:347-357 | guava/src/com/google/common/primitives/Chars.java:669-679 | guava/src/com/google/common/primitives/Doubles.java:681-691 | guava/src/com/google/common/primitives/Floats.java:669-679 | guava/src/com/google/common/primitives/Ints.java:757-767 | guava/src/com/google/common/primitives/Longs.java:814-824 | guava/src/com/google/common/primitives/Shorts.java:717-727 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/Booleans.java:482` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) guava/src/com/google/common/primitives/ImmutableDoubleArray.java:314 — guava/src/com/google/common/primitives/ImmutableDoubleArray.java:314-324 | guava/src/com/google/common/primitives/ImmutableIntArray.java:311-321 | guava/src/com/google/common/primitives/ImmutableLongArray.java:313-323 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/ImmutableDoubleArray.java:314` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (9 lines × 8) · ×1
  • Duplicated block (9 lines × 8) guava/src/com/google/common/primitives/Booleans.java:187 — guava/src/com/google/common/primitives/Booleans.java:187-195 | guava/src/com/google/common/primitives/Bytes.java:118-126 | guava/src/com/google/common/primitives/Chars.java:177-185 | guava/src/com/google/common/primitives/Doubles.java:162-170 | guava/src/com/google/common/primitives/Floats.java:159-167 | guava/src/com/google/common/primitives/Ints.java:185-193 | guava/src/com/google/common/primitives/Longs.java:146-154 | guava/src/com/google/common/primitives/Shorts.java:179-187 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/Booleans.java:187` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 7) · ×1
  • Duplicated block (9 lines × 7) guava/src/com/google/common/primitives/Booleans.java:288 — guava/src/com/google/common/primitives/Booleans.java:288-296 | guava/src/com/google/common/primitives/Doubles.java:368-376 | guava/src/com/google/common/primitives/Floats.java:365-373 | guava/src/com/google/common/primitives/Ints.java:429-437 | guava/src/com/google/common/primitives/Longs.java:511-519 | guava/src/com/google/common/primitives/Shorts.java:422-430 | guava/src/com/google/common/primitives/SignedBytes.java:143-151 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/primitives/Booleans.java:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×1
  • Duplicated block (8 lines × 4) guava-testlib/src/com/google/common/collect/testing/google/TestStringBiMapGenerator.java:54 — guava-testlib/src/com/google/common/collect/testing/google/TestStringBiMapGenerator.java:54-61 | guava-testlib/src/com/google/common/collect/testing/google/TestStringListMultimapGenerator.java:69-76 | guava-testlib/src/com/google/common/collect/testing/google/TestStringSetMultimapGenerator.java:68-75 | guava-testlib/src/com/google/common/collect/testing/TestStringMapGenerator.java:52-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `guava-testlib/src/com/google/common/collect/testing/google/TestStringBiMapGenerator.java:54` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) guava/src/com/google/common/cache/LocalCache.java:2421 — guava/src/com/google/common/cache/LocalCache.java:2421-2428 | guava/src/com/google/common/cache/LocalCache.java:3347-3352 | guava/src/com/google/common/cache/LocalCache.java:3390-3395 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `guava/src/com/google/common/cache/LocalCache.java:2421` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 7) · ×1
  • Duplicated block (5 lines × 7) guava/src/com/google/common/primitives/Bytes.java:371 — guava/src/com/google/common/primitives/Bytes.java:371-375 | guava/src/com/google/common/primitives/Chars.java:693-697 | guava/src/com/google/common/primitives/Doubles.java:705-709 | guava/src/com/google/common/primitives/Floats.java:693-697 | guava/src/com/google/common/primitives/Ints.java:781-785 | guava/src/com/google/common/primitives/Longs.java:838-842 | guava/src/com/google/common/primitives/Shorts.java:741-745 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:63 — guava-testlib/src/com/google/common/collect/testing/TestsForMapsInJavaUtil.java:63-86 | guava-testlib/src/com/google/common/collect/testing/TestsForSetsInJavaUtil.java:61-85 — the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Recommendation — 10 finding(s)
D11 · Test Reliability · Test reliability not included · ×1
  • Test reliability not included — Test source is present (.java) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D15 · Churn × Complexity Hotspots · complexity unreadable for .java · ×1
  • complexity unreadable for .java — churn × complexity hotspots could not be measured — A hotspot is churn × complexity. Churn was measured (19227 line(s) across the 90-day window), but no complexity could be computed for .java, which is most of this repository's production code — so every churned file would score as complexity 0 and the hotspot list would be empty no matter how tangled the code is. Not scored — this is a gap in the analysis run, not a finding about this repository.
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 268 significant file(s) lose their only recent owner: android/guava/src/com/google/common/cache/LocalCache.java, guava/src/com/google/common/util/concurrent/ClosingFuture.java, android/guava/src/com/google/common/util/concurrent/ClosingFuture.java, android/guava/src/com/google/common/collect/MapMakerInternalMap.java, guava/src/com/google/common/collect/MapMakerInternalMap.java, android/guava/src/com/google/common/collect/Multimaps.java, android/guava/src/com/google/common/util/concurrent/Futures.java, guava/src/com/google/common/util/concurrent/Futures.java (+260 more). Pair on, review, or document these before any departure.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 3 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (274 single-owned of 1377 analysed files in total, counted over production source files of roughly 100 lines or more, excluding tests, vendored, generated and example/demo trees, largest first). They are anonymized user #2 (2 file(s)), anonymized user #3 (2 file(s)), anonymized user #4 (2 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above.
D19 · Documentation Quality · The Guava Testlib README links to javadoc.io but does not mention where the test classes live (whether they are in a separate package or namespace from the main Guava libraries). · ×1
  • The Guava Testlib README links to javadoc.io but does not mention where the test classes live (whether they are in a separate package or namespace from the main Guava libraries). guava-testlib/README.md — Add a brief note stating where the test classes sit relative to the main Guava APIs so users can find them without opening the Javadoc.
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 356 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than listed individually (373 orphaned of 1377 analysed files in total, counted over production source files of roughly 100 lines or more, excluding tests, vendored, generated and example/demo trees, largest first).
D36 · Supply-chain Provenance & Signing · No build provenance · ×1
  • No build provenance — No SLSA provenance generation or build attestation found in CI — nothing binds a released artifact to the build that produced it, so a consumer cannot tell your artifact from a substituted one. Your release already signs its artifacts, so this is the remaining step rather than a new pipeline: attestation records HOW the artifact was built, which a signature over the finished file does not. On GitHub Actions, `actions/attest-build-provenance` (or slsa-github-generator) emits one from the job's own OIDC identity; elsewhere, run `cosign attest` over the released artifact from the release pipeline and publish the attestation beside it.
D36 · Supply-chain Provenance & Signing · No SBOM · ×1
  • No SBOM — No SBOM generation or committed SBOM found — produce one with what your ecosystem ships (the `cyclonedx-maven-plugin` bound to the package phase, `syft` (or `anchore/sbom-action` in CI) over the source tree or released image). Publish it as a release asset (`*.spdx.json` / `*.cdx.json`) so consumers can see what they are installing.
D38 · OSV Dependency Vulnerabilities · Scanner failed to run · ×1
  • Scanner failed to run — not a clean result — osv-scanner exited 128 with no findings — dependency CVEs were not measured. The scanner exited non-zero and produced no findings because it found no package sources to scan — no lockfile it can resolve is committed to this repository (a manifest alone does not pin versions, so there is nothing to match advisories against). Commit the lockfile your package manager already produces, or generate one in CI before the scan, so this is reported as a measurement gap rather than a clean pass.
D8 · Code Coverage · Coverage not included · ×1
  • Coverage not included — suite not readable by the collector — Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored.
Info — 2 finding(s)
D12 · Dependency Hygiene · Dependency hygiene not measured · ×1
  • Dependency hygiene not measured — dependency manifest found but not parsed for hygiene — This repository's dependency manifest (a Maven POM) was found, but this pass cannot parse it for hygiene, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D38 wherever the manifest is OSV-readable.
D22 · Internal API Consistency · No exposed public API · ×1
  • No exposed public API — No intentionally-exposed types (IsPackable or .Contracts) to evaluate.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaksgitleaks detect --no-banner --report-format json --report-path /dev/stdout --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D29 · Static Analysis (SAST)semgrepsemgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --json --quiet --timeout 0 --metrics off .8artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (no readable dependency manifest)none (no readable dependency manifest): not present in this environment0
D31 · IaC & Container Securitytrivytrivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.0
D32 · Data Compliance (PII/GDPR)semgrepsemgrep: not applicable — No PII/GDPR-handling patterns detected (p/gdpr ruleset) — no data-compliance surface to assess.0
D33 · JS/npm Dependency Vulnerabilitiestrivytrivy: not applicable — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.0
D37 · Vulnerability-disclosure Policydisclosuredisclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0
D38 · OSV Dependency Vulnerabilitiesosv-scannerosv-scanner --format json --recursive .0
D40 · Network Egress Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0
D41 · Kernel & Syscall Confinementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0
D42 · Runtime Threat Enforcementruntime-hardeningruntime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0

Run 019fd69e-69ea-79f0-8ea3-39a01356b1c8 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md