Public report of guardian/grid, published 26 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 26 October 2026, 08:50 UTC · Survey ID cd_8ea350fcb67f4186b60ba98a05f3868b

guardian/grid

Measured 26 October 2026, 08:45 UTC, at code version 4bcc699

Regression: 1 dimension fell since the last survey

A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.

CAI score 41out of 100 At risk No change since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

Architecture 80 Strong Maturity 67 Adequate Performance 60 Adequate Security and Compliance 48 Weak Code Health 48 Weak Accessibility 40 Weak Production Readiness 33 Weak

A medium codebase: 53,146 lines of product code in 12 projects, tests not counted · Estimated rebuild effort: about 0.4 person-years · Weakest lens: Production Readiness, 33

Findings by how serious they are

99 critical 624 serious 169 minor

15 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
26 October 2026, 08:45 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

87of 87 dimensions measured by tools.
820of 892 findings point to an exact file and line, so you can open each one in the code. The other 72 concern the repository as a whole, such as missing documentation.
87dimensions across 7 lenses, read from 53,146 lines of product code in 12 projects.
Chapters

Executive summary

guardian/grid is rated At risk because critical security findings are open. It scores 41 out of 100, which the At risk rating leaves unchanged.

Production Readiness, at 33, is the weakest lens and counts most in the score. The best first step is fixing the password or key in the code, worth about 6 points. Documenting the recovery plan would lift Production Readiness itself, worth about 4 points. Raising Production Readiness to 70 would lift the score to about 47.

Twenty known security holes in the packages the code depends on can be used by attackers. Twenty pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with, and twenty form fields can't be read by a screen reader. Updating the vulnerable packages, pinning each tool to an exact version and labelling the form fields would close these risks. Limiting each secret to its own step would fix the six secrets exposed to more of the pipeline than needed, and the three unsafe settings in infrastructure or container files need changing to safe values. The ten controls that only work with a mouse need to work with the keyboard, or to become a real button.

The product code is 53,146 lines, about €57,000 to rebuild.

Code Health 48 Weak, capped by Nullable reference types Architecture 80 Strong Maturity 67 Adequate Production Readiness 33 Weak, capped by Test Coverage, Security & performance tooling and DR & Backup Security and Compliance 48 Weak, capped by Static Analysis (SAST), Dependency Vulnerabilities, IaC & Container Security and Supply-chain Provenance & Signing Accessibility 40 Weak, capped by Keyboard semantics Performance 60 Adequate

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 33 · counts for 46%Accessibility 40 · counts for 25%Code Health 48 · counts for 14%Security and Compliance 48 · counts for 8%Performance 60 · counts for 4%Maturity 67 · counts for 2%Architecture 80 · counts for 1%

If Production Readiness rose from 33 to 70, the lowest score rated Strong, the score would rise from 41 to about 47.

Code composition: what the lines of code are
Product code 79%Tests 21%
New since the last survey: 170 findings

These 170 critical or serious findings weren't in the previous survey, on 12 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Cyclomatic Complexity · (anonymous) (cyclomatic 101) kahuna/public/js/search/results.js
  • Cyclomatic Complexity · MagickImageOperations.identifyColourModel (cyclomatic 22) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • Cognitive Complexity · (anonymous) (cognitive 79) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js
  • Cognitive Complexity · MagickImageOperations.identifyColourModel (cognitive 20) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) media-api/app/controllers/MediaApi.scala
  • Code Duplication · Duplicated block (10 lines × 2) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • Code Duplication · Duplicated block (7 lines × 2) media-api/app/lib/elasticsearch/ElasticSearchModel.scala
  • Cohesion (LCOM4) · Low cohesion: MagickImageOperations (LCOM4 4) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • REDACTED Scanning · REDACTED
  • Churn × Complexity Hotspots · Hotspot: common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala
  • Churn × Complexity Hotspots · Hotspot: e2e-tests/feature-library/app.tsx e2e-tests/feature-library/app.tsx
  • Explicit Debt · FixmeComment rest-lib/src/main/scala/com/gu/mediaservice/lib/guardian/auth/Permissions.scala
  • Explicit Debt · TodoComment common-lib/src/test/scala/com/gu/mediaservice/lib/imaging/MagickImageOperationsTest.scala
  • Explicit Debt · TodoComment common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • Explicit Debt · TodoComment common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala
  • Secrets (history) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Static Analysis (SAST) · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Dependency Vulnerabilities · REDACTED
  • Change Coupling · Change coupling: ImageOperations.scala ↔ ImageMagick.scala common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Change Coupling · Change coupling: gr-my-uploads.tsx ↔ gr-permissions-filter.tsx kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx
  • Change Coupling · Change coupling: query.js ↔ media-api.js kahuna/public/js/search/query.js
  • Supply-chain Provenance & Signing · REDACTED
  • Code Duplication · Duplicated block (12 lines × 2 locations) kahuna/public/js/upload/jobs/upload-jobs.js
  • Code Duplication · Duplicated block with local edits (10 matched lines × 2 locations) kahuna/public/js/upload/dnd-uploader.js
  • Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 28, cognitive 35) e2e-tests/feature-library/serve.ts
  • Cyclomatic Complexity · Complex function createLibrary (cyclomatic 15, cognitive 41) e2e-tests/feature-library/library.ts
  • Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 14, cognitive 12) kahuna/public/js/search/results.js
  • Cyclomatic Complexity · Complex function ScenarioDetail (cyclomatic 13, cognitive 12) e2e-tests/feature-library/app.tsx
  • Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 11, cognitive 15) e2e-tests/feature-library/app.test.ts
  • Large Files · kahuna/public/js/search/results.js: 841 lines of code kahuna/public/js/search/results.js
  • Large Files · e2e-tests/setup/stack.ts: 766 lines of code e2e-tests/setup/stack.ts
  • Large Files · kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js: 594 lines of code kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js
  • Large Files · image-embedder-lambda/src/backfiller/freeImagesFilter.ts: 558 lines of code image-embedder-lambda/src/backfiller/freeImagesFilter.ts
  • Large Files · e2e-tests/feature-library/app.tsx: 499 lines of code e2e-tests/feature-library/app.tsx
  • Web-Security Posture · Weak hash algorithm common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java
  • Web-Security Posture · Weak hash algorithm common-lib/src/main/scala/com/gu/mediaservice/lib/MD5.scala
  • Web-Security Posture · Weak hash algorithm image-loader/app/lib/BodyParsers.scala
  • Exception handling · Swallowed exception (caught, then discarded) kahuna/public/js/sentry/sentry.js
  • Exception handling · Swallowed exception (empty catch) kahuna/public/js/components/gr-downloader/gr-downloader.js
  • Exception handling · Swallowed exception (empty catch) kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js
  • Text alternatives · <img> without a text alternative kahuna/public/js/upload/jobs/upload-jobs.html
  • Forms & labels · Link with no accessible name kahuna/app/views/quotas.scala.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-filter-chip.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-filter-chooser-chip.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-text-chip.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-collections-panel/gr-collections-panel-node.html
  • Forms & labels · <button> with no accessible text kahuna/public/js/components/gr-feature-switch-panel/gr-feature-switch-panel.tsx
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gu-date-range/gu-date-range.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gu-date-range/gu-date-range.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/components/gu-date/gu-date.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/crop/view.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/crop/view.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/crop/view.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/crop/view.html
  • Forms & labels · <select> without a programmatic label kahuna/public/js/leases/leases.html
  • Forms & labels · <input> without a programmatic label kahuna/public/js/leases/leases.html
  • Forms & labels · <textarea> without a programmatic label REDACTED
  • Forms & labels · <textarea> without a programmatic label REDACTED
  • Forms & labels · <input> without a programmatic label thrall/app/views/index.scala.html
  • Forms & labels · <input> without a programmatic label thrall/app/views/index.scala.html
  • Page structure · <html> without a lang kahuna/app/views/main.scala.html
  • Page structure · Page without a main landmark kahuna/app/views/main.scala.html
  • Page structure · <html> without a lang kahuna/app/views/quotas.scala.html
  • Page structure · Data table has no header cells kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx
  • Page structure · Data table has no header cells kahuna/public/js/components/gr-sort-control/base-sort-control.tsx
  • Page structure · Data table has no header cells kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx
  • Page structure · <html> without a lang scripts/src/main/java/com/gu/typesafe/config/impl/package.html
  • Page structure · Document without a <title> scripts/src/main/java/com/gu/typesafe/config/impl/package.html
  • Page structure · Page without a main landmark scripts/src/main/java/com/gu/typesafe/config/impl/package.html
  • Page structure · <html> without a lang scripts/src/main/java/com/gu/typesafe/config/package.html
  • Page structure · Document without a <title> scripts/src/main/java/com/gu/typesafe/config/package.html
  • Page structure · Page without a main landmark scripts/src/main/java/com/gu/typesafe/config/package.html
  • Page structure · <html> without a lang scripts/src/main/java/com/gu/typesafe/config/parser/package.html

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 188 findings

These 188 critical or serious findings were in the previous survey, on 12 October 2026, and are gone from this one. The first 100 are listed here.

  • Cyclomatic Complexity · (anonymous) (cyclomatic 99) kahuna/public/js/search/results.js
  • Cyclomatic Complexity · ImageOperations.identifyColourModel (cyclomatic 22) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Cognitive Complexity · (anonymous) (cognitive 80) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js
  • Cognitive Complexity · ImageOperations.identifyColourModel (cognitive 20) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) media-api/app/controllers/MediaApi.scala
  • Code Duplication · Duplicated block (10 lines × 2) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Code Duplication · Duplicated block (8–9 lines × 2) media-api/app/controllers/UsageController.scala
  • Cohesion (LCOM4) · Low cohesion: ImageOperations (LCOM4 4) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Explicit Debt · TodoComment common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Explicit Debt · TodoComment common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala
  • Explicit Debt · TodoComment common-lib/src/test/scala/com/gu/mediaservice/lib/imaging/ImageOperationsTest.scala
  • Explicit Debt · FixmeComment rest-lib/src/main/scala/com/gu/mediaservice/lib/guardian/auth/Permissions.scala
  • Explicit Debt · FixmeComment rest-lib/src/main/scala/com/gu/mediaservice/lib/guardian/auth/Permissions.scala
  • Static Analysis (SAST) · Medium: watchdog-regex-match-index-beyond-capture-groups-js kahuna/public/js/components/gr-feature-switch-panel/gr-feature-switch-panel.tsx
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] dev/oidc-provider/package-lock.json
  • Dependency Vulnerabilities · High CVE: REDACTED dev/oidc-provider/package-lock.json
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: REDACTED dev/oidc-provider/package-lock.json
  • Dependency Vulnerabilities · Medium CVE: REDACTED dev/oidc-provider/package-lock.json
  • Dependency Vulnerabilities · Medium CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · Medium CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Change Coupling · Change coupling: media-api.js ↔ MediaApi.scala kahuna/public/js/services/api/media-api.js
  • Change Coupling · Change coupling: REDACTED ↔ global-setup.ts REDACTED
  • Supply-chain Provenance & Signing REDACTED
  • Code Duplication · Duplicated block (8 lines × 2 locations) kahuna/public/js/upload/jobs/upload-jobs.js
  • Code Duplication · Duplicated block (7 lines × 3 locations) kahuna/public/js/image/controller.js
  • Code Duplication · Duplicated block (7 lines × 2 locations) kahuna/public/js/services/image/usages.js
  • Code Duplication · Duplicated block (6 lines × 2 locations) kahuna/public/js/components/gr-image-cost-message/gr-image-cost-message.js
  • Code Duplication · Duplicated block (5 lines × 2 locations) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js
  • Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 13, cognitive 10) kahuna/public/js/search/results.js
  • Large Files · kahuna/public/js/search/results.js: 834 lines of code kahuna/public/js/search/results.js
  • Large Files · e2e-tests/setup/stack.ts: 736 lines of code e2e-tests/setup/stack.ts
  • Large Files · kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js: 572 lines of code kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js
  • Large Files · image-embedder-lambda/src/backfiller/freeImagesFilter.ts: 560 lines of code image-embedder-lambda/src/backfiller/freeImagesFilter.ts
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/services/image-logic.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js
  • Test Coverage · No test reaches this file kahuna/public/js/takedown/takedown-page.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-cql-input/gr-cql-input.ts
  • Test Coverage · No test reaches this file kahuna/public/js/takedown/index.ts
  • Test Coverage · No test reaches this file kahuna/public/js/util/crop.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-chips/gr-text-chip.js
  • Test Coverage · No test reaches this file kahuna/public/js/services/image/usages.js
  • Test Coverage · No test reaches this file kahuna/public/js/util/constants/standThemeOverride.ts
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-photoshoot/gr-photoshoot.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/search/structured-query/structured-query.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/services/image-accessor.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gu-date/gu-date.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-sort-control/gr-sort-control.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/services/telemetry.ts
  • Test Coverage · No test reaches this file kahuna/public/js/takedown/takedown-step.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-panels/gr-panels.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts
  • Test Coverage · No test reaches this file kahuna/public/js/services/image/downloads.js
  • Test Coverage · No test reaches this file kahuna/public/js/errors/global.js
  • Test Coverage · No test reaches this file kahuna/public/js/services/label.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-add-label/gr-add-label.js
  • Test Coverage · No test reaches this file kahuna/public/js/util/async.js
  • Test Coverage · No test reaches this file dev/script/generate-config/generate-config.js
  • Test Coverage · No test reaches this file kahuna/public/js/upload/recent/recent-uploads.js
  • Test Coverage · No test reaches this file kahuna/public/js/services/image-list.js
  • Test Coverage · No test reaches this file kahuna/public/js/sentry/sentry.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-archiver-status/gr-archiver-status.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-chips/gr-filter-chooser-chip.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-panel-button/gr-panel-button.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-preset-labels/gr-preset-labels.js
  • Test Coverage · No test reaches this file kahuna/public/js/directives/gr-image-fade-on-load.js
  • Test Coverage · No test reaches this file kahuna/public/js/components/gr-batch-export-original-images/gr-batch-export-original-images.js
Rebuild cost: about €57,000 · Estimate
Cost to rebuild€19,000 to €96,000, for 318 to 1,009 hours of work, about 0.4 person-years for one engineer
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 41. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 53,146 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Raises the score by about 6 points · Low effort · REDACTED Scanning
2
Codify backups + geo-recovery in IaC and document RTO/RPO and the restore procedure — a persistence guard alone is not disaster recovery.
Raises the score by about 4 points · Medium effort · DR & Backup
3
Add tests that import the unreached modules (directly or through their public entry).
Raises the score by about 3 points · Medium effort · Test Coverage

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €57,000 to build again, about 0.4 person-years of work. Its weakest lens is Production Readiness, at 33 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 6 points for low effort, because it clears the 1 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.4 out of 10. Code at that level is slower to change than clean code, and Watchdog estimates the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 29,711 lines over the last 90 days, which is about 120,495 lines a year. At that pace, the extra work comes to an estimated 6 to 40.2 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of Watchdog's own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways, which only happens where the projects form a dependency cycle. A graph without cycles has none.

arch bbcProject bbcProject restLib restLib bbcProject->restLib commonLib commonLib commonProject commonProject commonProject->restLib generate-config generate-config image-counter-lambda image-counter-lambda image-embedder-lambda image-embedder-lambda imageCachePurger imageCachePurger local-oidc-provider local-oidc-provider restLib->commonLib root root sample-images sample-images scripts scripts scripts->commonLib

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

151 modules, with 231 dependencies between them. 2 loops run through 16 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 111 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 com.gu.mediaservice.GridClient2 com.gu.mediaservice.lib.net3 com.gu.mediaservice.model.leases4 image-embedder-lambda.src.embedder.imageResolver5 com.gu.mediaservice.lib.argo.model6 com.gu.mediaservice.lib.auth.Authentication7 com.gu.mediaservice.syntax8 com.gu.mediaservice.lib.argo9 com.gu.mediaservice.lib.auth10 com.gu.mediaservice.lib.logging11 com.gu.mediaservice.lib.json12 com.gu.mediaservice.lib.management13 com.gu.mediaservice.lib.metrics14 com.gu.mediaservice.model.usage15 com.gu.mediaservice.model16 com.gu.mediaservice.lib17 com.gu.mediaservice.lib.imaging.im4jwrapper18 lib.usagerights19 com.gu.mediaservice.lib.aws20 com.gu.mediaservice.lib.imaging21 lib.imaging22 lib.querysyntax23 model.upload24 com.gu.mediaservice.lib.config25 com.gu.mediaservice.lib.metadata26 com.gu.mediaservice27 com.gu.mediaservice.lib.auth.provider28 com.gu.mediaservice.lib.cleanup29 com.gu.mediaservice.lib.elasticsearch30 com.gu.mediaservice.lib.guardian.auth31 com.gu.mediaservice.lib.play32 com.gu.mediaservice.scripts.EsScript33 lib.elasticsearch34 model35 auth36 com.gu.mediaservice.scripts37 lib38 (global)39 controllers40 lib.kinesis
1 com.gu.mediaservice.GridClient
2 com.gu.mediaservice.lib.net
3 com.gu.mediaservice.model.leases
4 image-embedder-lambda.src.embedder.imageResolver
5 com.gu.mediaservice.lib.argo.model5
6 com.gu.mediaservice.lib.auth.Authentication4
7 com.gu.mediaservice.syntax1
8 com.gu.mediaservice.lib.argo131
9 com.gu.mediaservice.lib.auth23211
10 com.gu.mediaservice.lib.logging111
11 com.gu.mediaservice.lib.json1
12 com.gu.mediaservice.lib.management221
13 com.gu.mediaservice.lib.metrics1
14 com.gu.mediaservice.model.usage22
15 com.gu.mediaservice.model231432
16 com.gu.mediaservice.lib7186
17 com.gu.mediaservice.lib.imaging.im4jwrapper22
18 lib.usagerights31
19 com.gu.mediaservice.lib.aws4101911
20 com.gu.mediaservice.lib.imaging271
21 lib.imaging471
22 lib.querysyntax11
23 model.upload262
24 com.gu.mediaservice.lib.config121
25 com.gu.mediaservice.lib.metadata161
26 com.gu.mediaservice22131
27 com.gu.mediaservice.lib.auth.provider8134
28 com.gu.mediaservice.lib.cleanup239113
29 com.gu.mediaservice.lib.elasticsearch14311
30 com.gu.mediaservice.lib.guardian.auth31113
31 com.gu.mediaservice.lib.play111122
32 com.gu.mediaservice.scripts.EsScript11
33 lib.elasticsearch31251176857
34 model11925810221524
35 auth1111
36 com.gu.mediaservice.scripts121
37 lib1664142426610543281129311113
38 (global)1111111012
39 controllers11193515763161111412612
40 lib.kinesis15124111
Uses a module listed above itPart of a loopThe module itself
1 com.gu.mediaservice.GridClient2 com.gu.mediaservice.lib.net3 com.gu.mediaservice.model.leases4 image-embedder-lambda.src.embedder.imageResolver5 com.gu.mediaservice.lib.argo.model6 com.gu.mediaservice.lib.auth.Authentication7 com.gu.mediaservice.syntax8 com.gu.mediaservice.lib.argo9 com.gu.mediaservice.lib.auth10 com.gu.mediaservice.lib.logging11 com.gu.mediaservice.lib.json12 com.gu.mediaservice.lib.management13 com.gu.mediaservice.lib.metrics14 com.gu.mediaservice.model.usage15 com.gu.mediaservice.model16 com.gu.mediaservice.lib17 com.gu.mediaservice.lib.imaging.im4jwrapper18 lib.usagerights19 com.gu.mediaservice.lib.aws20 com.gu.mediaservice.lib.imaging21 lib.imaging22 lib.querysyntax23 model.upload24 com.gu.mediaservice.lib.config25 com.gu.mediaservice.lib.metadata26 com.gu.mediaservice27 com.gu.mediaservice.lib.auth.provider28 com.gu.mediaservice.lib.cleanup29 com.gu.mediaservice.lib.elasticsearch30 com.gu.mediaservice.lib.guardian.auth31 com.gu.mediaservice.lib.play32 com.gu.mediaservice.scripts.EsScript33 lib.elasticsearch34 model35 auth36 com.gu.mediaservice.scripts37 lib38 (global)39 controllers40 lib.kinesiscom.gu.mediaservice.GridClient1com.gu.mediaservice.lib.net2com.gu.mediaservice.model.leases3image-embedder-lambda.src.embedder.imageResolver4com.gu.mediaservice.lib.argo.model5com.gu.mediaservice.lib.auth.Authentication6com.gu.mediaservice.syntax7com.gu.mediaservice.lib.argo8com.gu.mediaservice.lib.auth9com.gu.mediaservice.lib.logging10com.gu.mediaservice.lib.json11com.gu.mediaservice.lib.management12com.gu.mediaservice.lib.metrics13com.gu.mediaservice.model.usage14com.gu.mediaservice.model15com.gu.mediaservice.lib16com.gu.mediaservice.lib.imaging.im4jwrapper17lib.usagerights18com.gu.mediaservice.lib.aws19com.gu.mediaservice.lib.imaging20lib.imaging21lib.querysyntax22model.upload23com.gu.mediaservice.lib.config24com.gu.mediaservice.lib.metadata25com.gu.mediaservice26com.gu.mediaservice.lib.auth.provider27com.gu.mediaservice.lib.cleanup28com.gu.mediaservice.lib.elasticsearch29com.gu.mediaservice.lib.guardian.auth30com.gu.mediaservice.lib.play31com.gu.mediaservice.scripts.EsScript32lib.elasticsearch33model34auth35com.gu.mediaservice.scripts36lib37(global)38controllers39lib.kinesis405411312321111112211222314327186223141019112714711126212116122131813423911314311311131111221131251176857119258102215241111121166414242661054328112931111311111110121119351576316111141261215124111+111 more modules (most-connected shown)

At a glance — Code Health · 48% · Weak · gated by X5 ·

The Good
D3 · Scala God Classes 8.6 D4 · Scala Code Duplication 9.9 D17 · Scala Explicit Debt 9.5 R10 · React / TS Code Duplication 9.1 R2 · React / TS Cyclomatic Complexity 9.8 R3 · React / TS Large Files 9.0 R7 · React / TS Dead Code 10.0 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X18 · Repo Disposal-pattern correctness 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 7.3 X30 · Repo Support guard that admits what it rejects 10.0
The Bad
D1 · Scala Cyclomatic Complexity 6.0 D2 · Scala Cognitive Complexity 5.6
The Ugly
R1 · React / TS Type Safety 4.0 X2 · Repo Cancellation propagation 4.0 X4 · Repo Structured logging 4.1 X5 · Repo Nullable reference types 2.0

At a glance — Architecture · 80% · Strong ·

The Good
D5 · Scala Coupling 10.0 D6 · Scala Cohesion (LCOM4) 8.0 D35 · Scala Change Coupling 9.8 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX6 · Repo Interface segregation 9.9 AX8 · Repo Test isolation 10.0 R9 · React / TS Circular Imports 10.0
The Bad
D26 · Scala Project Cohesion 5.6 AX10 · Repo Code composition 6.8 R11 · React / TS Import Boundaries 6.3

At a glance — Maturity · 67% · Adequate ·

The Good
D15 · Scala Churn × Complexity Hotspots 9.8 D16 · Scala Bus Factor 7.7 D34 · Scala Knowledge Freshness 7.4 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0
The Bad
M2 · Repo Architecture documentation 5.0
The Ugly
D20 · Scala ADR Quality 0.0 M1 · Repo Documentation (README) 4.5

At a glance — Readiness · 33% · Weak · gated by R4, P3, P5 ·

The Good
D9 · Scala Test Distribution 9.9 D10 · Scala Test Quality 10.0 D12 · Scala Dependency Hygiene 8.0 D14 · Scala License Compliance 10.0 P1 · Repo CI/CD gates 10.0 P10 · Repo Library API & versioning 10.0 P11 · Repo BDD / executable specs 10.0 P2 · Repo Observability 7.0 R5 · React / TS Dependency Freshness 10.0 R6 · React / TS Tooling 10.0
The Bad
D13 · Scala REDACTED Scanning 5.0 P4 · Repo Deployment & Rollback 5.0 P6 · Repo Release Hygiene 5.0 R8 · React / TS Dependency Hygiene 5.5
The Ugly
P3 · Repo Security & performance tooling 3.0 P5 · Repo DR & Backup 0.0 R4 · React / TS Test Coverage 1.3

At a glance — Security · 48% · Weak · gated by D29, D30, D31, D36 ·

The Good
D28 · Scala Secrets (history) 7.0 D43 · Scala Malicious Dependencies 10.0 D44 · Scala Platform End-of-Life 10.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0
The Bad
S1 · Repo Web-Security Posture 6.0
The Ugly
D29 · Scala Static Analysis (SAST) 0.9 D30 · Scala Dependency Vulnerabilities 0.0 D31 · Scala IaC & Container Security 0.0 D36 · Scala Supply-chain Provenance & Signing 0.0 X17 · Repo Uncapped recursion over a caller-supplied document 2.2 X24 · Repo Document value interpolated into markup unescaped 4.3

At a glance — Accessibility · 40% · Weak · gated by AC4 ·

The Good
AC5 · Repo ARIA correctness 10.0
The Bad
AC1 · Repo Text alternatives 5.5 AC2 · Repo Forms & labels 5.7 AC6 · Repo Visual & motion safety 5.0
The Ugly
AC3 · Repo Page structure 4.8 AC4 · Repo Keyboard semantics 1.2 AC7 · Repo A11y enforcement 4.0

At a glance — Performance · 60% · Adequate ·

The Bad
PF3 · Repo Async & latency hygiene 6.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A02:2025 — Security Misconfiguration124High / Critical
A05:2025 — Injection53High / Critical
A03:2025 — Software Supply Chain Failures41High / Critical
A07:2025 — Authentication Failures5High / Critical

Roadmap

Immediately resolve the leaked secret in REDACTED and codify disaster recovery by documenting RTO/RPO and restore procedures in infrastructure-as-code. Expand test coverage to include unreached production modules and ensure all custom controls are fully keyboard-operable with proper semantics. Finally, integrate a static analysis security tool into the CI pipeline to automatically block security regressions.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.+5.9 ptsLowREDACTED Scanning
Codify backups + geo-recovery in IaC and document RTO/RPO and the restore procedure — a persistence guard alone is not disaster recovery.+4.3 ptsMediumDR & Backup
Add tests that import the unreached modules (directly or through their public entry).+3.5 ptsMediumTest Coverage
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.+2.4 ptsMediumKeyboard semantics
Add a SAST step to CI running what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.3 ptsMediumSecurity & performance tooling
Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with jest-axe in tests, then gate axe/pa11y/Lighthouse in CI.+1.5 ptsMediumA11y enforcement
Resolve the 1 No ADRs found finding(s) in ADR Quality.+0.6 ptsLowADR Quality
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 3 sites, not one: `common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java:13` (Hashing.sha1), `common-lib/src/main/scala/com/gu/mediaservice/lib/MD5.scala:6` (MessageDigest.getInstance("MD5")), `image-loader/app/lib/BodyParsers.scala:39` (MessageDigest.getInstance("SHA-1")). Each is a separate decision — fixing only the line this row cites leaves the others in place.+1.1 ptsMediumWeb-Security Posture

File quality

Per-file score 0–10 — a quality signature. Of 152 files carrying findings, judged against the Production bar: 4% slop · 55% mixed · 41% near-clean.

FileScoreBandWorst signal
REDACTED0.0SlopREDACTED Scanning: Leaked secret: REDACTED
REDACTED0.2SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.0SlopDependency Vulnerabilities: High CVE: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
REDACTED2.6SlopSecrets (history): REDACTED: REDACTED
REDACTED2.7SlopIaC & Container Security: High IaC: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedDependency Vulnerabilities: High CVE: REDACTED
kahuna/public/js/search/query.js5.7MixedCyclomatic Complexity: (anonymous)::watchSearchChange (cyclomatic 21)
REDACTED5.8MixedIaC & Container Security: Medium IaC: REDACTED
REDACTED5.8MixedIaC & Container Security: Medium IaC: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): Medium: REDACTED
kahuna/public/js/search/results.js5.9MixedCyclomatic Complexity: (anonymous) (cyclomatic 101)
common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala6.0MixedExplicit Debt: TodoComment
media-api/app/controllers/MediaApi.scala6.0MixedExplicit Debt: FixmeComment
image-loader/app/model/Uploader.scala6.0MixedExplicit Debt: FixmeComment
cropper/app/controllers/CropperController.scala6.0MixedExplicit Debt: TodoComment
usage/app/lib/CrierEventProcessor.scala6.0MixedExplicit Debt: TodoComment
thrall/app/lib/elasticsearch/ElasticSearch.scala6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 99

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 624

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 169

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 15

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 87 of 87 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); none rely on LLM judgement. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 87 dimensions across the health lenses
D1D2D3D4D5D6D9D10D12D13D14D15D16D17D20D26D28D29D30D31D34D35D36D43D44AC1AC2AC3AC4AC5AC6AC7AX10AX2AX3AX4AX6AX8M1M2M3M4P1P10P11P2P3P4P5P6PF3R1R10R11R2R3R4R5R6R7R8R9S1X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 820 of 892 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement—◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a17763-2b0b-79f0-87af-77f20ec02e3e.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: this repository's production source spans .ts, .tsx, .scala, and our analyzer cannot run the .scala test suite(s) — so no coverage was collected for the repository as a whole. The JavaScript/TypeScript half did build and run, and its own line coverage came back at 71.5% — but that is a figure for one half of the product, and we do not publish a partial one as if it were complete. This is OUR limitation, not a defect in the repo — coverage is excluded from the score rather than counted as a near-zero. In the meantime, produce a coverage report in a standard format (lcov — `vitest --coverage`, `jest --coverage`, `bun test --coverage --coverage-reporter=lcov`, or `nyc`, or `addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures and real coverage will be read. You can widen what we reach: optional: produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then both halves are read on the next scan.
  • D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 109 test(s) behind this row are the ones the JavaScript/TypeScript census could read, and this repository also carries at least 96 test source file(s) (.scala) that it cannot: it reads JavaScript/TypeScript test declarations off disk, so a JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT SCORED: this repository's production source includes .scala, and the scala executor ran against the .scala half and could not be re-run to completion inside our analyzer environment — so reliability was not measured for the repository as a whole. The JavaScript/TypeScript (jest via `npm ci --ignore-scripts` in cdk/ (2 tests); jest via `npm ci --ignore-scripts` in dev/oidc-provider/ (0 tests); jest via `npm ci --ignore-scripts` in image-counter-lambda/ (3 tests); jest via `npm ci --ignore-scripts` in image-embedder-lambda/ (37 tests); jest via `npm ci --ignore-scripts` in kahuna/): measured (0 flaky) suite(s) did re-run, and came back with 0 flaky across 1 measured tier(s) — but that is a figure for one half of the product, and we do not publish a partial one as if it were complete. This is OUR limitation, not a defect in the repo — test reliability is excluded from the score rather than counted. The remedy is our analyzer environment, not a runner nobody has built.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability for the jest suite in kahuna/ was NOT MEASURED: the dependency install for kahuna/ could not reach codeload.github.com, which the analyzer sandbox's egress allowlist does not carry (npm error 403 403 Forbidden - GET https://codeload.github.com/guardian/titip/legacy.tar.gz/refs/tags/1.1.0), so the suite never ran. This is OUR limitation, not a defect in the repository, and the suite is excluded from the measurement rather than counted against it.
  • D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares REDACTED, but the licence verdict published here was taken over its sbt dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D19 Documentation Quality — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Each ecosystem's manifests (what makes a folder runnable or a published package) need their own proof before D19 judges its units. Until then those folders' READMEs are judged only as documents (boilerplate, structure), never counted as complete.
  • D19 Documentation Quality — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D21's deterministic naming rules are gated on C# first (docs/plans/deterministic-engine.md, P5): each other language is switched on only after its own concept suite and A/B gate pass. Until then its declarations carry no naming verdict this run — this says nothing about whether its names are consistent.
  • D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: it declares a published package (image-embedder-lambda/package.json), but no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict. For npm the surface is what a published REDACTED's entry points (exports, main, module, types) export, followed through the source; an entry that names build output the tree does not commit (dist/, build/) is not followed back to source, because only a tsconfig outDir/rootDir pair states that mapping and a bundler's input lives in executable configuration this engine does not evaluate.
  • D24 Comment Value — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
  • D31 IaC & Container Security — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. E2e-tests/images/Dockerfile.dockerignore carries no `FROM` instruction, so it declares no build stage and every REDACTED rule this engine owns — the runtime-hardening, key-material, mutable-clone, no-op-shim, build-context, trust-anchor, install-guard, setuid and world-writable-path rules — is outside its own premise there and returned nothing. That silence is deliberate and correct: with no base image there is no image to reason about. It is reported here because it is NOT the same fact as a clean file, and coverage is stated as 7 of 8 Infrastructure-as-Code manifest(s) fully judged rather than as 100%. The vendor scanners (trivy, checkov) do read these files and their findings above stand; only this engine's own stage-keyed rules are absent. No owner action: a build file with no FROM is a legitimate include fragment.
  • D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dev/oidc-provider/app.js` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • AC4 Keyboard semantics — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 17 further occurrence(s) are not listed individually; the score already reflects all 57.
  • AX1 Captive dependencies — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Play dependency injection, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 18 — an image could not be pulled) — elasticsearch Pulling cerebro Pulling localstack Pulling localstack Error Get "https://registry-1.docker.io/v2/": Forbidden cerebro Error Get "https://registry-1.docker.io/v2/": Forbidden elasticsearch Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the earlier `compose pull` step reported: oidc-provider Skipped - No image to be pulled imgops Skipped - No image to be pulled elasticsearch Pulling cerebro Pulling localstack Pulling localstack Error Get "https://registry-1.docker.io/v2/": Forbidden cerebro Error Get "https://registry-1.docker.io/v2/": Forbidden elasticsearch Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped.
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'software.amazon.awssdk.services.dynamodb' is imported (usage/app/model/UsageRecord.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'software.amazon.awssdk.services.dynamodb' is imported (usage/app/model/UsageRecord.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'software.amazon.awssdk.services.dynamodb' is imported (usage/app/model/UsageRecord.scala:3), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
  • GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Java, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 reads a prose claim (a path, a setting, a variable, a route, a version, a project, an install, a bare project name in a command) only in text identified as English: the cues that tell a claim from an absence, the past, a plan or an example are an English lexicon, and on other text they would let a false claim through. Links, image targets, fenced commands with an explicit path or a package-manager script, and env-fence variables are checked in every language. 'und' is text the identifier could not name (too short, mixed script, no function words).
  • M4 Documentation accuracy — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9). Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • R10 Code Duplication — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 4 further occurrence(s) are not listed individually; the score already reflects all 44.
  • R4 Test Coverage — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 126 further occurrence(s) are not listed individually; the score already reflects all 166.

Repo exclusion declarations: 4 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.0 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Prevented

28 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was (anonymous) at 101. A further 6 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Subject.create at 37 — they are counted neither in the figure above nor in this dimension's score. 6 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: common-lib/src/main/scala/com/gu/mediaservice/lib/metadata/Subject.scala (Subject.create at 37), common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala (UsageRights.jsonWrites at 30), thrall/app/lib/kinesis/MessageProcessor.scala (MessageProcessor.process at 23), common-lib/src/main/scala/com/gu/mediaservice/lib/cleanup/InsertGuardianImageType.scala (InsertGuardianImageType.toImageType at 21), metadata-editor/app/model/UsageRightsProperty.scala (UsageRightsProperty.categoryUsageRightsProperties at 18), and 1 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

(anonymous) (cyclomatic 34) · ×2kahuna/public/js/image/controller.js:91
(anonymous) (cyclomatic 101)kahuna/public/js/search/results.js:104
(anonymous) (cyclomatic 78)kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:47
delete-from-grid-step.DeleteFromGridStep (cyclomatic 43)kahuna/public/js/takedown/delete-from-grid-step.tsx:88
(anonymous) (cyclomatic 43)kahuna/public/js/edits/image-editor.js:49

+ 22 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 2 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with (anonymous) (cyclomatic 101), (anonymous) (cyclomatic 78). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 6.0 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.6 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.6 / 10 · rule-coverage 100% · ceiling Prevented

42 method(s) exceeded the cognitive complexity threshold of 15; the worst was GoodToGoCheck.run at 148.

(anonymous)::watchSearchChange (cognitive 29) · ×4kahuna/public/js/search/query.js:315
(anonymous) (cognitive 18) · ×2kahuna/public/js/edits/list-editor.js:26
GoodToGoCheck.run (cognitive 148)thrall/app/lib/elasticsearch/GoodToGoCheck.scala:18
(anonymous) (cognitive 79)kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:47
Uploader.uploadAndStoreImage (cognitive 76)image-loader/app/model/Uploader.scala:129

+ 33 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 3 bodies over 60 down to 60 or less in Cognitive Complexity — start with GoodToGoCheck.run (cognitive 148), (anonymous) (cognitive 79), Uploader.uploadAndStoreImage (cognitive 76). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 5.6 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.6 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

19 god class(es) detected.

TooManyMethods: QuerySyntax · ×6REDACTED:10
FunctionTooLong: delete-from-grid-step.DeleteFromGridStep · ×5kahuna/public/js/takedown/delete-from-grid-step.tsx:88
FileTooLong: controllers/MediaApi.scala · ×3media-api/app/controllers/MediaApi.scala
ClassTooLong: ElasticSearch · ×3media-api/app/lib/elasticsearch/ElasticSearch.scala:43
MethodTooLong: MediaApi.imageSearch · ×2media-api/app/controllers/MediaApi.scala:632

What to do

  1. Resolve the 6 TooManyMethods finding(s) in God Classes — start with ElasticSearch.scala (2), REDACTED, Mappings.scala. — One of this dimension's main actionable groups (6 warning-level).
  2. Resolve the 5 FunctionTooLong finding(s) in God Classes — start with delete-from-grid-step.tsx, crops-and-usages.tsx, gr-permissions-filter.tsx. — One of this dimension's main actionable groups (5 warning-level).
  3. Resolve the 3 FileTooLong finding(s) in God Classes — start with MediaApi.scala, results.js, ElasticSearch.scala. — One of this dimension's main actionable groups (3 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.9 / 10Stronggated by 15 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

14 duplicated block group(s) detected. One further row reports members as variants of one another; it aggregates block groups already counted above and is not itself counted. Measured on part of this repository only: .ts (18% of production source) was not exposed to THIS dimension's token comparison and is not in this count; duplication there is measured by R10 Code Duplication, the frontend lens's card running the same clone algorithm over the JS/TS token stream.

Duplicated block (11 lines × 2) · ×3thrall/app/lib/elasticsearch/ElasticSearch.scala:508
Duplicated block (10 lines × 2) · ×3common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:249
Duplicated block (5 lines × 2) · ×2thrall/app/lib/elasticsearch/ElasticSearch.scala:810
Members sharing a duplicated core (4 members, 50+ identical tokens)media-api/app/controllers/MediaApi.scala:265
Duplicated block (11–13 lines × 2)media-api/app/controllers/MediaApi.scala:366

+ 5 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 3 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with ElasticSearch.scala, UsageApi.scala, UsageRecord.scala. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 3 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with MediaApi.scala (2), MagickImageOperations.scala. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 2 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with ElasticSearch.scala (2). — One of this dimension's main actionable groups (2 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

12 production modules (npm+sbt), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; a dependsOn spread (deps: _*) and a project whose directory a helper computes are not visible there; 0 module(s) off the main sequence, with abstractness counted on 2 of the 12 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)8.0 / 10Strong✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Verified

10 of 59 classes have LCOM4 above 3.

Low cohesion: UsageApi (LCOM4 10) · ×10usage/app/controllers/UsageApi.scala:24

What to do

  1. Resolve the 10 Low cohesion finding(s) in Cohesion (LCOM4) — start with UsageApi.scala, ThrallController.scala, UsageController.scala. — One of this dimension's main actionable groups (10 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

1054 test methods: 1040 unit, 3 integration, 0 BDD, 11 e2e. The JavaScript/TypeScript suite contributes 109 `it`/`test` case(s) across 18 test file(s) declaring at least one; its tier split is read from package names and paths only. The Scala suite contributes 945 test case(s) across 86 file(s) in a test source set declaring at least one — every `test("…")`, `it("…")`, `property("…")` and `"…" in {…}` registration and every JUnit `@Test`, which is how munit, ScalaTest, utest, ZIO Test and specs2 declare a case; a case registered under a computed name is not counted, so this is a floor. Its tier split is INFERRED from paths and file names, except sbt's src/it source set, which the build declares.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 skipped, 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 109 tests. Measured on the JavaScript/TypeScript suite only — at least 96 test source file(s) (.scala) went unread, so its test quality is unmeasured and is not in these counts.

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md.

D12 · Dependency Hygiene8.0 / 10Strong✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Verified

43 outdated direct sbt declarations. An sbt declaration names an EXACT version, so the remedy is an edit to the build file — there is no lockfile refresh that would move it. Test-, Provided- and it-scoped declarations are excluded, because a consumer of this project never receives them. A version held in a Scala val is read only when the val is one string literal: sbt is a program rather than a manifest, and evaluating a computed version would invent the measurement rather than take it. Whether any artifact is DEPRECATED or ABANDONED is not graded and cannot be — Maven Central publishes no such marker, and release age does not stand in for one: the most widely depended-upon libraries are routinely the stalest, being finished rather than abandoned. Known CVEs in this dependency graph are D30's question.

Outdated: at.yawk.lz4:lz4-java · ×43

What to do

  1. Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning5.0 / 10Adequate✓ Tool-verified

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Prevented

1 secret(s) detected.

REDACTED

What to do

  1. Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Enforce REDACTED Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 50 declared sbt dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the production coordinates this repository's 1 sbt build file(s) (REDACTED and project/*.scala) declare with a literal version, directly or through a string-literal val — `%%` resolved to the Scala binary suffix Central publishes under, test-scoped declarations excluded — the same declaration-site closure this analysis reads for dependency currency. sbt has no lockfile a checkout carries, so this is deliberately NOT the transitive closure. 1 further production coordinate(s) are declared with a version the build computes rather than writes as a literal — sbt is a program, and this pass does not run it — and are NOT graded: this verdict covers what the build pins literally or through a string-literal val, not the full graph. ★ COVERAGE OF THIS VERDICT: it grades this repository's sbt dependencies and nothing else. The repository also declares REDACTED, and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.8 / 10Stronggated by 7 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: kahuna/public/js/takedown/delete-from-grid-step.tsx (10×43=430); media-api/app/controllers/MediaApi.scala (13×22=286); media-api/app/lib/elasticsearch/QueryBuilder.scala (8×24=192)

Hotspot: kahuna/public/js/takedown/delete-from-grid-step.tsx · ×7kahuna/public/js/takedown/delete-from-grid-step.tsx:88

What to do

  1. Resolve the 7 Hotspot finding(s) in Churn × Complexity Hotspots — start with delete-from-grid-step.tsx, MediaApi.scala, QueryBuilder.scala. — One of this dimension's main actionable groups (7 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor7.7 / 10Strong✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 7.7 / 10 · rule-coverage 100% · ceiling Documented

42 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is common-lib/src/main/scala/com/gu/mediaservice/lib/cleanup/PhotographerRenamer.scala. Counted over 190 of the 493 production source files in this repository: 288 are under the ~2,400-byte size floor this dimension measures over, and the remaining 15 have no attributable history left to measure.

Off-boarding risk: anonymized user #1 · ×5
Further sole-owners (lower concentration)

What to do

  1. Resolve the 5 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (5 recommendation-level).
  2. Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.5 / 10Stronggated by 140 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Prevented

140 deducted task-comment markers across 53146 LoC (0.3/KLoC) → score 9.5. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×114usage/app/model/UsageGroup.scala:148
FixmeComment · ×25thrall/app/controllers/ThrallController.scala:248
HackCommentcommon-lib/src/main/scala/com/gu/mediaservice/model/Collection.scala:29

What to do

  1. Resolve the 114 TodoComment finding(s) in Explicit Debt — start with ElasticSearch.scala (10), MetadataCleaner.scala (10), ParserTest.scala (8). — One of this dimension's main actionable groups (114 warning-level).
  2. Resolve the 25 FixmeComment finding(s) in Explicit Debt — start with ImageLoaderController.scala (3), Permissions.scala (2), ImageMetadataConverter.scala (2). — One of this dimension's main actionable groups (25 warning-level).
  3. Resolve the 1 HackComment finding(s) in Explicit Debt — start with Collection.scala. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion5.6 / 10Adequate✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 5.6 / 10 · rule-coverage 100% · ceiling Documented

2 of 9 build units (Python, npm, sbt) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)7.0 / 10Adequategated by 3 critical findings✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 7.0 / 10 · rule-coverage 100% · ceiling Documented

3 finding(s): 0 critical, 3 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 2 REDACTED finding(s) in Secrets (history) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 High secret finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)0.9 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.9 / 10 · rule-coverage 100% · ceiling Documented

53 finding(s): 0 critical, 27 high, 23 medium, 3 low. 20 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 11 file(s) — `dev/oidc-provider/app.js` (line 5), `dev/script/create-root-collection.sh` (line 20, line 25, line 35), `kahuna/app/views/main.scala.html` (lines 1–20, line 35, line 36, …), `kahuna/app/views/quotas.scala.html` (line 1, line 77), `thrall/app/views/index.scala.html` (lines 1–54, lines 74–78, lines 82–84, …), … (+6 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (6 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 20 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (20 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.0 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

36 finding(s): 0 critical, 20 high, 11 medium, 5 low.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 19 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (17), REDACTED, REDACTED. — One of this dimension's main actionable groups (19 issue-level).
  2. Resolve the 11 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (10), REDACTED. — One of this dimension's main actionable groups (11 warning-level).
  3. Resolve the 1 High vulnerability finding(s) in Dependency Vulnerabilities — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security0.0 / 10Critical✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 88% · ceiling Documented

124 finding(s): 1 critical, 2 high, 120 medium, 1 low.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 120 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (99), REDACTED (12), REDACTED (7). — One of this dimension's main actionable groups (120 warning-level).
  2. Resolve the 2 High IaC finding(s) in IaC & Container Security — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
  3. Resolve the 1 Critical IaC finding(s) in IaC & Container Security — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness7.4 / 10Strong✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Documented

55 of 205 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is scripts/src/main/java/com/gu/typesafe/config/impl/ConfigNodeObject.java. Counted over 205 of the 493 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×55scripts/src/main/java/com/gu/typesafe/config/impl/ConfigNodeObject.java:1
Orphaned files with no living knowledge

What to do

  1. Resolve the 55 Orphaned file finding(s) in Knowledge Freshness — start with ConfigNodeObject.java, ConfigBeanImpl.java, ResolveSource.java. — One of this dimension's main actionable groups (55 recommendation-level).
  2. Resolve the 1 Orphaned files with no living knowledge finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling9.8 / 10Stronggated by 10 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: ImageLoaderController.scala↔loader.js 90%; MessageProcessor.scala↔MessageTranslator.scala 73%; ImageOperations.scala↔ImageMagick.scala 71%

Change coupling: ImageLoaderController.scala ↔ loader.js · ×10image-loader/app/controllers/ImageLoaderController.scala:1

What to do

  1. Resolve the 10 Change coupling finding(s) in Change Coupling — start with ImageLoaderController.scala, MessageProcessor.scala, ImageOperations.scala. — One of this dimension's main actionable groups (10 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 5 platform declaration(s) and 2 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives5.5 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

  • An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. — kahuna/public/js/upload/jobs/upload-jobs.html:14

What to do

  • Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
AC2 · Forms & labels5.7 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label. — kahuna/app/views/quotas.scala.html:66
  • This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×11) — kahuna/public/js/components/gr-chips/gr-filter-chip.html:8, kahuna/public/js/components/gr-chips/gr-filter-chooser-chip.html:5, kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:397, …
  • This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. (×9) — kahuna/public/js/components/gr-chips/gr-text-chip.html:1, kahuna/public/js/components/gr-collections-panel/gr-collections-panel-node.html:73, kahuna/public/js/components/gu-date-range/gu-date-range.html:60, …
  • A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one). — kahuna/public/js/components/gr-feature-switch-panel/gr-feature-switch-panel.tsx:109

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure4.8 / 10Weak✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). (×5) — kahuna/app/views/main.scala.html:22, kahuna/app/views/quotas.scala.html:3, scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2, …
  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×5) — kahuna/app/views/main.scala.html:22, scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2, scripts/src/main/java/com/gu/typesafe/config/package.html:2, …
  • A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). (×3) — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:244, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:194, kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx:116
  • A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>. (×3) — scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2, scripts/src/main/java/com/gu/typesafe/config/package.html:2, scripts/src/main/java/com/gu/typesafe/config/parser/package.html:2
  • Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. — thrall/app/views/reaper.scala.html:39

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC4 · Keyboard semantics1.2 / 10Critical✓ Tool-verified

Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".

  • An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action. (×27) — REDACTED:11, kahuna/public/js/components/gr-collections-panel/gr-collections-panel-node.html:29, kahuna/public/js/components/gr-crop-image/gr-crop-image.html:2, …
  • The repo's own CSS styles .clickable with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — kahuna/public/js/components/gr-batch-export-original-images/gr-batch-export-original-images.html:1
  • A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler. — kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:118
  • This <div> carries tabIndex={0}, so it is in the tab order and a keyboard user will land on it — but its behaviour is bound to the pointer only, with no key handler. A tabindex makes an element focusable, not operable: Enter and Space fire a click on a native <button> or <a href> and nowhere else, so this can be focused and never activated. Use a <button>, or handle Enter/Space in a key handler. Give it a role as well, so assistive tech can announce what it is. (×2) — kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:123, kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:127
  • The repo's own CSS styles .custom-checkbox with `cursor: pointer`, so this <span> is a control — but it has no role, no tabIndex={0} and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabIndex={0} + a key handler. — kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:89
  • This <div> carries tabIndex={0}, so it is in the tab order and a keyboard user will land on it — but its behaviour is bound to the pointer only, with no key handler. A tabindex makes an element focusable, not operable: Enter and Space fire a click on a native <button> or <a href> and nowhere else, so this can be focused and never activated. Use a <button>, or handle Enter/Space in a key handler. — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:251
  • A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}. (×7) — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:236, kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:247, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:181, …

What to do

  • Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety5.0 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.status` sets color: white on background-color: orange — 2.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — kahuna/public/stylesheets/main.css:915
  • `.element--partial .element__value, .element--partial .element__add, .element--partial .element__right-bit` sets color: #00adee on background-color: white — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — kahuna/public/js/edits/list-editor.css:27
  • `.preset-label__value, .preset-label__remove` sets color: white on background-color: #00adee — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them. — kahuna/public/js/components/gr-preset-labels/gr-preset-labels.css:27
  • `.search-query__clear` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/stylesheets/main.css:1117
  • `.search__advanced-toggle:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/stylesheets/main.css:1219
  • `.image-info__wrap .editable-wrap .image-info__editor--error` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/stylesheets/main.css:2465
  • `.image-info__wrap .editable-wrap .image-info__editor--saving` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/stylesheets/main.css:2470
  • `.gr-tab` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/js/components/gr-tab-swap/gr-tab-swap.css:23
  • `gr-text-chip button:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — kahuna/public/js/components/gr-chips/gr-chips.css:82
  • `.search input` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — e2e-tests/feature-library/styles.css:89
  • `.loader:after` moves (`animation-name: flipper`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — kahuna/public/stylesheets/main.css:575
  • `.saving` moves (`animation-name: spin`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — kahuna/public/stylesheets/main.css:600
  • `.spin` moves (`animation-name: spin`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — kahuna/public/stylesheets/main.css:611
  • `.gr-panel__content` moves (`transition: width 0.2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — kahuna/public/js/components/gr-panels/gr-panels.css:26

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified

Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.

Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.

Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.

  • No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 101 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.

What to do

  • Enforce accessibility in the toolchain: add eslint-plugin-jsx-a11y, then assert with jest-axe in tests, then gate axe/pa11y/Lighthouse in CI.
AX10 · Code composition6.8 / 10Adequate✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `Config` declares 55 abstract methods: `atKey`, `atPath`, `checkValid`, `entrySet`, `getAnyRef`, `getAnyRefList`, `getBoolean`, `getBooleanList`, `getBytes`, `getBytesList`, `getConfig`, `getConfigList`, `getDouble`, `getDoubleList`, `getDuration`, `getDuration`, `getDurationList`, `getDurationList`, `getEnum`, `getEnumList`, `getInt`, `getIntList`, `getIsNull`, `getList`, `getLong`, `getLongList`, `getMemorySize`, `getMemorySizeList`, `getMilliseconds`, `getMillisecondsList`, `getNanoseconds`, `getNanosecondsList`, `getNumber`, `getNumberList`, `getObject`, `getObjectList`, `getPeriod`, `getString`, `getStringList`, `getTemporal`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 51 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 51 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — scripts/src/main/java/com/gu/typesafe/config/Config.java:168

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

M1 · Documentation (README)4.5 / 10Weak✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

  • The root README is 106 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
  • 220 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.

What to do

  • Expand the README with getting-started, architecture overview and a project map.
  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Review the README against recent changes; refresh the parts that drifted.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

P11 · BDD / executable specs10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether behaviour is captured as executable Gherkin specifications (a plus for shared understanding) — only assessed when a BDD framework is present.

Method: Filesystem scan: BDD framework presence (SpecFlow, Gherkin files) when a project references a BDD tool. Exhaustive, deterministic.

P2 · Observability7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 2/3 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `e2e-tests`.
  • `kahuna/public/js/quotas.js` reports through `console.*` at line 43 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/quotas.js:43
  • `kahuna/public/js/util/batch-tracking.js` reports through `console.*` at line 54 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/util/batch-tracking.js:54
  • `kahuna/public/js/upload/manager.js` reports through `console.*` at line 144 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/upload/manager.js:144
  • `kahuna/public/js/search/results.js` reports through `console.*` at line 700 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/search/results.js:700
  • `kahuna/public/js/metadata-templates/metadata-templates.js` reports through `console.*` at line 189 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/metadata-templates/metadata-templates.js:189
  • `kahuna/public/js/leases/leases.js` reports through `console.*` at line 106 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/leases/leases.js:106
  • `kahuna/public/js/image/controller.js` reports through `console.*` at line 300 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/image/controller.js:300
  • `kahuna/public/js/edits/list-editor.js` reports through `console.*` at line 63 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/edits/list-editor.js:63
  • `kahuna/public/js/crop/controller.js` reports through `console.*` at line 62 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/crop/controller.js:62
  • `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 29 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:29
  • `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 30 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:30
  • `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 31 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:31
  • `kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx` reports through `console.*` at line 150 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:150
  • `kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js` reports through `console.*` at line 163 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:163
  • `kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js` reports through `console.*` at line 106 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:106
  • `kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js` reports through `console.*` at line 107 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:107
  • `kahuna/public/js/components/gr-archiver/gr-archiver.js` reports through `console.*` at line 144 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-archiver/gr-archiver.js:144
  • `kahuna/public/js/components/gr-add-label/gr-add-label.js` reports through `console.*` at line 50 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-add-label/gr-add-label.js:50
  • `kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js` reports through `console.*` at line 87 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline. — kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:87

What to do

  • Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
  • Route service-code `console.*` output through the module's structured logger (with named fields), so delivery outcomes and failures reach the log pipeline with a level.
  • Add OpenTelemetry tracing/metrics (opentelemetry-java or Micrometer) so requests are traceable across the system, not just health-probable.
P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 18513 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Dependabot is configured but does not watch `pip` — add that `package-ecosystem` entry to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

  • Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse.

What to do

  • Add a `healthcheck:` to the served compose service — probing the endpoint it already answers on where it has one — with `depends_on: condition: service_healthy` on whatever waits for it, and keep the deployed image tag immutable and recorded so rolling back is re-pointing at the previous tag rather than rebuilding.
  • Add an approval/environment gate (required reviewers / protection rules) before production promotion.
P5 · DR & Backup0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

  • A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.

What to do

  • Codify backups + geo-recovery in IaC and document RTO/RPO and the restore procedure — a persistence guard alone is not disaster recovery.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

  • Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • `projectS3ImageById` is async and calls Await.result — a blocking call inside async code stalls the execution-context thread, and every future or fiber scheduled on it for as long as it runs. — image-loader/app/model/Projector.scala:87
  • `fs.readFileSync` in `createStack` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/provision.ts:58
  • `fs.readFileSync` in `callback to map` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/provision.ts:113
  • `fs.readFileSync` in `seedBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/provision.ts:119
  • `generateKeyPairSync` in `seedAuthBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/provision.ts:129
  • `fs.readFileSync` in `seedAuthBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/provision.ts:153
  • `fs.readFileSync` in `seedElasticsearch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/seed-elasticsearch.ts:75
  • `fs.rmSync` in `task` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×2) — e2e-tests/setup/stack.ts:551, e2e-tests/setup/stack.ts:814
  • `fs.mkdirSync` in `task` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/setup/stack.ts:552
  • `readFileSync` in `callback to map` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — e2e-tests/steps/utils/drag-and-drop.ts:20

What to do

  • Scala: compose the Future or effect (map/flatMap, a for-comprehension) instead of Await.result or unsafeRunSync, and wrap unavoidable blocking calls in blocking { } (Future), IO.blocking or ZIO.attemptBlocking.
  • TypeScript/JavaScript: use the promise APIs (fs/promises, a promisified child_process.execFile, the async zlib/crypto functions) and await them instead of the *Sync variants.
R1 · Type Safety4.0 / 10Weak✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

  • 101 typed · 149 plain JS — the untyped files are cdk/jest.setup.js, dev/oidc-provider/app.js, dev/oidc-provider/find-account.js, dev/oidc-provider/find-account.test.js, dev/oidc-provider/make-provider.js, dev/script/generate-config/generate-config.js (+143 more).

What to do

  • Migrate the remaining .js/.jsx files to TypeScript.
R10 · Code Duplication9.1 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.

  • 21 duplicated blocks under kahuna/public/js/components/ have copies in at least two of the sibling directories gr-add-keyword, gr-add-label, gr-archiver, gr-archiver-status, gr-batch-export-original-images, gr-chips (+15 more sibling(s) not listed) — 12 of them are reported below, and 9 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 21 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 21 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 21 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20
  • 15 duplicated blocks under kahuna/public/js/ have copies in at least two of the sibling directories components, crop, edits, image, leases, metadata-templates (+4 more sibling(s) not listed) — 9 of them are reported below, and 6 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 15 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 15 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 15 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600
  • kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:16 — the two spans are one implementation copied and then locally edited — 454 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20
  • kahuna/public/js/lib/data-structure/list-factory.js:12 · kahuna/public/js/lib/data-structure/ordered-set-factory.js:12 — the two spans are one implementation copied and then locally edited — 312 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/lib/data-structure/list-factory.js:12
  • kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:66 · kahuna/public/js/components/gr-add-label/gr-add-label.js:27 — the two spans are one implementation copied and then locally edited — 255 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:66
  • kahuna/public/js/takedown/crops-and-usages.tsx:97 · kahuna/public/js/takedown/crops-and-usages.tsx:143 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/takedown/crops-and-usages.tsx:97
  • REDACTED:166 · REDACTED:203 — the two spans are one implementation copied and then locally edited — 107 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — REDACTED:166
  • REDACTED:69 · kahuna/public/js/takedown/delete-from-grid-step.tsx:281 — the two spans are one implementation copied and then locally edited — 64 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — REDACTED:69
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600 · kahuna/public/js/edits/image-editor.js:243 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600
  • kahuna/public/js/takedown/crops-and-usages.tsx:173 · kahuna/public/js/takedown/crops-and-usages.tsx:236 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — kahuna/public/js/takedown/crops-and-usages.tsx:173
  • kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:23 · kahuna/public/js/edits/image-editor.js:383 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:23
  • kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:218 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:105 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:218
  • kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:250 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:200 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:250
  • kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:138 · kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:64 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:138
  • kahuna/public/js/services/api/collections-api.js:122 · kahuna/public/js/services/archive.js:10 — the two spans are one implementation copied and then locally edited — 56 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/services/api/collections-api.js:122
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:299 · kahuna/public/js/edits/image-editor.js:90 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:299
  • kahuna/public/js/edits/image-editor.js:327 · kahuna/public/js/edits/image-editor.js:342 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — kahuna/public/js/edits/image-editor.js:327
  • kahuna/public/js/image/controller.js:244 · kahuna/public/js/upload/controller.js:59 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/image/controller.js:244
  • cdk/lib/image-embedder-lambda.ts:77 · cdk/lib/image-embedder-lambda.ts:91 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — cdk/lib/image-embedder-lambda.ts:77
  • dev/script/generate-config/service-config.js:131 · dev/script/generate-config/service-config.js:200 · dev/script/generate-config/service-config.js:241 — all 3 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — dev/script/generate-config/service-config.js:131
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:477 · kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:567 — the two spans are one implementation copied and then locally edited — 101 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:477
  • kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:15 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:16 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:15
  • kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx:92 · kahuna/public/js/components/gr-sort-control/gr-sort-control.tsx:78 · kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:74 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx:92
  • kahuna/public/js/search/structured-query/query-suggestions.ts:213 · kahuna/public/js/search/structured-query/query-suggestions.ts:249 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/search/structured-query/query-suggestions.ts:213
  • kahuna/public/js/upload/jobs/upload-jobs.js:192 · kahuna/public/js/upload/recent/recent-uploads.js:59 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/upload/jobs/upload-jobs.js:192
  • kahuna/public/js/components/gr-archiver-status/gr-archiver-status.js:27 · kahuna/public/js/components/gr-archiver/gr-archiver.js:47 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — kahuna/public/js/components/gr-archiver-status/gr-archiver-status.js:27
  • kahuna/public/js/components/gr-delete-image/gr-delete-image.js:43 · kahuna/public/js/components/gr-undelete-image/gr-un-delete-image.js:37 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/components/gr-delete-image/gr-delete-image.js:43
  • kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:51 · kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:199 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:51
  • kahuna/public/js/upload/dnd-uploader.js:12 · kahuna/public/js/upload/file-uploader.js:11 — the two spans are one implementation copied and then locally edited — 58 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/upload/dnd-uploader.js:12
  • kahuna/public/js/usage-rights/usage-rights-editor.js:237 · kahuna/public/js/usage-rights/usage-rights-editor.js:249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — kahuna/public/js/usage-rights/usage-rights-editor.js:237
  • kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:47 · kahuna/public/js/edits/image-editor.js:114 — the two spans are one implementation copied and then locally edited — 52 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:47
  • kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:24 · kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:74 · kahuna/public/js/edits/image-editor.js:384 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:24
  • kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:138 · kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:165 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:138
  • kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:52 · kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:64 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:52
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:197 · kahuna/public/js/upload/jobs/required-metadata-editor.js:63 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:197
  • kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:38 · kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:47 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:38
  • kahuna/public/js/search/structured-query/query-suggestions.ts:259 · kahuna/public/js/search/structured-query/query-suggestions.ts:277 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — kahuna/public/js/search/structured-query/query-suggestions.ts:259
  • kahuna/public/js/services/api/leases.js:56 · kahuna/public/js/services/api/leases.js:84 — the two spans are one implementation copied and then locally edited — 53 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — kahuna/public/js/services/api/leases.js:56
  • kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:8 · kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:40 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:8
  • kahuna/public/js/edits/service.js:158 · kahuna/public/js/edits/service.js:176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — kahuna/public/js/edits/service.js:158

What to do

  • Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
R11 · Import Boundaries6.3 / 10Adequate✓ Tool-verified

React / JS · Architecture — Conformance to the detected frontend architecture layout (feature-sliced / layered src) plus cross-package deep-import rules (D-386).

Method: Conformance to the detected frontend layout (feature-sliced / layered src) plus cross-package deep-import rules, over the module graph. Deterministic.

  • cdk/lib/image-cache-purger.ts:2 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-cache-purger.ts:2
  • cdk/lib/image-cache-purger.ts:3 imports @guardian/cdk/lib/constructs/lambda, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-cache-purger.ts:3
  • cdk/lib/image-embedder-lambda.ts:3 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-embedder-lambda.ts:3
  • cdk/lib/image-embedder-lambda.ts:4 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-embedder-lambda.ts:4
  • cdk/lib/image-embedder-lambda.ts:5 imports @guardian/cdk/lib/constructs/ec2, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-embedder-lambda.ts:5
  • cdk/lib/image-embedder-lambda.ts:6 imports @guardian/cdk/lib/constructs/lambda, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-embedder-lambda.ts:6
  • cdk/lib/image-embedder-lambda.ts:7 imports @guardian/cdk/lib/constructs/s3, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — cdk/lib/image-embedder-lambda.ts:7
  • dev/script/generate-config/generate-config.js:7 imports json5/lib/register, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead. — dev/script/generate-config/generate-config.js:7

What to do

  • Fix the listed violations: import through public entries (package exports / slice index), never reach into another layer or package's internals.
R2 · Cyclomatic Complexity9.8 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

  • (anonymous) has cyclomatic complexity 28 and cognitive complexity 35; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — e2e-tests/feature-library/serve.ts:27
  • watchSearchChange has cyclomatic complexity 21 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/search/query.js:315
  • createLibrary has cyclomatic complexity 15 and cognitive complexity 41; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — e2e-tests/feature-library/library.ts:279
  • structureQuery has cyclomatic complexity 15 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/search/structured-query/syntax.ts:35
  • (anonymous) has cyclomatic complexity 15 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. (×2) — kahuna/public/js/common/usageRightsUtils.js:5, kahuna/public/js/components/gr-chips/gr-chip-input.js:101
  • (anonymous) has cyclomatic complexity 15 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:56
  • (anonymous) has cyclomatic complexity 14 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/search/results.js:104
  • manageUploadedBy has cyclomatic complexity 13 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/search/query.js:162
  • ScenarioDetail has cyclomatic complexity 13 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — e2e-tests/feature-library/app.tsx:294
  • handleKey has cyclomatic complexity 12 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/components/gr-chips/gr-text-chip.js:41
  • save has cyclomatic complexity 11 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/leases/leases.js:59
  • (anonymous) has cyclomatic complexity 11 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/search/query.js:694
  • (anonymous) has cyclomatic complexity 11 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — e2e-tests/feature-library/app.test.ts:53
  • onMetadataTemplateSelected has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:588
  • handleArrowKeys has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:96
  • TabControl has cyclomatic complexity 11 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:16

What to do

  • Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
R3 · Large Files9.0 / 10Strong✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

  • kahuna/public/js/search/results.js has 841 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — kahuna/public/js/search/results.js:1
  • e2e-tests/setup/stack.ts has 766 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — e2e-tests/setup/stack.ts:1
  • kahuna/public/js/search/query.js has 674 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — kahuna/public/js/search/query.js:1
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js has 594 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:1
  • image-embedder-lambda/src/backfiller/freeImagesFilter.ts has 558 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — image-embedder-lambda/src/backfiller/freeImagesFilter.ts:1
  • e2e-tests/feature-library/app.tsx has 499 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — e2e-tests/feature-library/app.tsx:1

What to do

  • Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
R4 · Test Coverage1.3 / 10Critical✓ Tool-verified

React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.

Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.

  • No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×40) — kahuna/public/js/search/results.js:1, kahuna/public/js/search/query.js:1, kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:1, …

What to do

  • Add tests that import the unreached modules (directly or through their public entry).
R5 · Dependency Freshness10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — How outdated the npm dependencies are (a maturity signal). JS/npm CVEs are scored separately in D30 (JS/npm Dependency Vulnerabilities).

Method: npm dependency staleness from manifest/registry metadata (a maturity signal; JS/npm CVEs are scored separately in D30, which answers dependency vulnerabilities for every ecosystem). Deterministic.

R6 · Tooling10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each REDACTED script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.

Method: REDACTED scanned for test/lint/typecheck script wiring. Deterministic presence check.

R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

  • 6 file(s) (~337 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package. — cdk
R8 · Dependency Hygiene5.5 / 10Adequate✓ Tool-verified

React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.

Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.

  • Imported but not declared in any reachable REDACTED — installs work only by hoisting accident. — image-embedder-lambda/src/embedder/embedder.ts:3
  • Declared in REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it. (×3)

What to do

  • Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
R9 · Circular Imports10.0 / 10Exemplary✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

S1 · Web-Security Posture6.0 / 10Adequate✓ Tool-verified

Other · Security — Read from this repository's Scala source and the Java beside it: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository commits the configuration that serves its own HTTP surface, so that configuration was read in full for the security response headers it sets. This repository serves HTTP itself (auth/conf/routes:1 — a Play route table), so its Scala source was also read for the server controls: TLS served or HSTS set, security response headers, cookie flags and inbound validation — each credited where its Scala spelling appears in production source, not proven on every route. A Play application is credited the security headers Play's default `SecurityHeadersFilter` sends unless its build or configuration switches that filter off, and its cookies the HttpOnly flag Play sets by default.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call. (×3) — common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java:13, common-lib/src/main/scala/com/gu/mediaservice/lib/MD5.scala:6, image-loader/app/lib/BodyParsers.scala:39
  • None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `REDACTED` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.) — REDACTED:29

What to do

  • Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 3 sites, not one: `common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java:13` (Hashing.sha1), `common-lib/src/main/scala/com/gu/mediaservice/lib/MD5.scala:6` (MessageDigest.getInstance("MD5")), `image-loader/app/lib/BodyParsers.scala:39` (MessageDigest.getInstance("SHA-1")). Each is a separate decision — fixing only the line this row cites leaves the others in place.
  • Set security response headers on the surface this repository serves: an `add_header` directive per header in the nginx/Caddy/Apache config, a `_headers` / `vercel.json` / `netlify.toml` entry for a static host, or `helmet()` in the HTTP server. `Content-Security-Policy` is the one that pays for itself first — it is what contains an injected script once one reaches the page — followed by `X-Content-Type-Options: nosniff` and a frame policy (`X-Frame-Options: DENY`, or CSP `frame-ancestors`). Where the app is served from a build container, the header configuration belongs in the image beside the built assets, so it ships with them rather than depending on where it lands.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document2.2 / 10Critical✓ Tool-verified

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

  • `JsonDiff.diff` is public and takes `a: JsValue` from its caller, and it calls itself at line 24 with a piece of `a`, not as a tail call the compiler turns into a loop — and nowhere in `JsonDiff.diff` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `JsonDiff.diff` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — common-lib/src/main/scala/com/gu/mediaservice/JsonDiff.scala:24
  • `DynamoDB.jsonToAttributeValue` is public and takes `json: JsValue` from its caller, and it calls itself at line 237 with a piece of `json` (and at line 238), not as a tail call the compiler turns into a loop — and nowhere in `DynamoDB.jsonToAttributeValue` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `DynamoDB.jsonToAttributeValue` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala:237
  • `DynamoDB.mapJsValue` is public and takes `jsValue: JsValue` from its caller, and it calls itself at line 272 with a piece of `jsValue`, not as a tail call the compiler turns into a loop — and nowhere in `DynamoDB.mapJsValue` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `DynamoDB.mapJsValue` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala:272

What to do

  • Each finding names the externally-callable member that accepts the document and the self-call that descends, and states that no depth parameter or counter exists anywhere in the walk. Confirm from the two, then thread a depth argument through the walk and reject documents past a fixed maximum, or rewrite it with an explicit stack.
X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async functions that make a cancellable request accept or pass on an AbortSignal (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/4 async functions that make a cancellable request (fetch, axios, ky, ofetch) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
  • `importImage` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — scripts/sample-images/index.js:30
  • `upload` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — kahuna/public/js/upload/manager.js:128
  • `queryElasticSearch` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — image-embedder-lambda/src/backfiller/elasticSearch.ts:40
  • `getImageCount` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`. — image-counter-lambda/src/handler.ts:16

What to do

  • Thread an AbortSignal through async functions that make requests, so the work stops when its caller gives up.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped4.3 / 10Weak✓ Tool-verified

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

  • `content` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — kahuna/public/js/quotas.js:5
  • `icon.svg` is text this program did not author, and it is written into the text of an element through `dangerouslySetInnerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — REDACTED:49

What to do

  • Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for` comprehension or `foreach` leaves the mutable collection it is walking alone — an `ArrayBuffer` or `ListBuffer` counts its changes and its iterator checks the count, an `ArrayDeque` (and `mutable.Queue`/`mutable.Stack`) is walked by index up to its starting length, and a `java.util` collection walked through `asScala` is fail-fast, so a body that adds to or removes from the very collection the loop is walking makes a later step throw `ConcurrentModificationException` (`IndexOutOfBoundsException` for a deque) and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.3 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch (e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — kahuna/public/js/sentry/sentry.js:33
  • `.catch(() => {})` handles the rejection by doing nothing — the failure is discarded with no log and no rethrow, and the chain carries on as if the work succeeded. Log it through whatever this codebase already uses to report problems, hand it to a caller that can (`next(error)`, a returned rejection), or don't catch it. — kahuna/public/js/components/gr-downloader/gr-downloader.js:123
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:40
  • `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — image-loader/app/lib/imaging/C2PADetector.scala:60

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging4.1 / 10Weak✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `REDACTED` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `info` at line 21 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:21
  • `info` at line 27 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:27
  • `info` at line 32 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:32
  • `info` at line 40 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:40
  • `info` at line 50 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:50

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Scala's null is held to the type system and not undermined by assertions — a file compiled with `-Yexplicit-nulls` is one where `String` excludes null and `String | Null` admits it, a file under WartRemover's `Null` wart or Scalafix's `DisableSyntax.noNulls` is one whose code cannot write `null` and must say `Option`, and each `.nn`, `import scala.language.unsafeNulls` or null-lint suppression is the author overruling that.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • No build over this repository's 371 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.

What to do

  • On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.

WCAG coverage — what static analysis assessed

Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC4 · Keyboard semantics2.1.1, 2.4.3Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only
AC7 · A11y enforcementenforcement — no page criterionEnforcement posture (process)

Not statically assessed — these 40 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health48%Weak — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture80%StrongStrongest area.
Maturity67%AdequateAcceptable, with room to improve.
Readiness33%Weak — gated by R4, P3, P5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security48%Weak — gated by D29, D30, D31, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility40%Weak — gated by AC4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance60%AdequateAcceptable, with room to improve.
Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • P12 CI test-gate honesty — 2 observation(s) recorded · Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • X10 Duplicated predicate — 14 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: this repository stores data through 'software.amazon.awssdk.services.dynamodb' (usage/app/model/UsageRecord.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether its changes need an audit trail could not be established, and the trail's absence is not scored.
  • C4 Data Retention — Not assessed: this repository stores data through 'software.amazon.awssdk.services.dynamodb' (usage/app/model/UsageRecord.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether a retention limit applies here could not be established, and its absence is not scored.
  • C5 Data-Subject Rights — Not assessed: this repository stores data through 'software.amazon.awssdk.services.dynamodb' (usage/app/model/UsageRecord.scala:3) but declares no persisted model this check reads (Slick table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations). Personal data may be written through raw SQL or a hosted backend, so whether data-subject rights apply here could not be established, and their absence is not scored.
Not included — 40 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — compose up failed (exit 18 — an image could not be pulled) — elasticsearch Pulling cerebro Pulling localstack Pulling localstack Error Get "https://registry-1.docker.io/v2/": Forbidden cerebro Error Get "https://registry-1.docker.io/v2/": Forbidden elasticsearch Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the earlier `compose pull` step reported: oidc-provider Skipped - No image to be pulled imgops Skipped - No image to be pulled elasticsearch Pulling cerebro Pulling localstack Pulling localstack Error Get "https://registry-1.docker.io/v2/": Forbidden cerebro Error Get "https://registry-1.docker.io/v2/": Forbidden elasticsearch Error context canceled Error response from daemon: Get "https://registry-1.docker.io/v2/": Forbidden; the runtime sandbox reaches registries only through the in-fence pull-through mirror, so an image the mirror does not carry cannot be fetched — this is a limit of our sandbox, not of your stack; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D11 Test Reliability — Test reliability not scored — polyglot repository, one half's runner produced no measurement
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D19 Documentation Quality — D19 reads .NET projects as units only; 8 folder(s) declared by REDACTED were not judged for an overview, an example or the map.
  • D21 Naming Consistency — Naming consistency is measured on C# only; Java, JavaScript, Python, Scala, TypeScript not measured.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C# and Visual Basic comments only — this repository's production source is .java, .py, .scala, .ts, .tsx, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.scala), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D32 Data Compliance (PII/GDPR) — 1 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not measured — polyglot repository, one half has no runner
  • DM1 Domain Modelling — applicable but not scored (2 signals for this style, 2 needed — the count is met but a required primary signal is absent): 293 value object(s); 4 domain event(s); its domain events are published by services or handlers — no domain entity raises one
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, JavaScript/TypeScript, Python source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage data present for 11 file(s), but no domain-layer files were identified: no covered file's path contains any of the markers this check keys on (/domain/, /aggregates/, /valueobjects/, /domainmodel/, .domain/, /entities/), which are matched case-insensitively anywhere in the path. With no domain partition there is nothing to compare the web/controller layer against — if this repository keeps its business rules under a folder named none of those, that naming is what the check cannot see, not the domain logic.
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not applicable: allocation awareness is rated where code engineers for it — at least 400 production lines that ship benchmarks or already use allocation-aware idioms (8 or more). This repository's Java and Scala code has 50,028 production line(s), 5 such use(s) and no benchmarks, so there is no allocation work to rate. The card is reward-only: its absence costs nothing.
  • SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 99 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×19
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · <input> without a programmatic label · ×17
  • <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-filter-chip.html:8 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-filter-chooser-chip.html:5 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/components/gr-chips/gr-text-chip.html:1 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label kahuna/public/js/components/gr-collections-panel/gr-collections-panel-node.html:73 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:397 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:444 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:616 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/components/gu-date-range/gu-date-range.html:60 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label kahuna/public/js/components/gu-date-range/gu-date-range.html:71 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label kahuna/public/js/components/gu-date/gu-date.html:20 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label kahuna/public/js/crop/view.html:14 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/crop/view.html:25 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/crop/view.html:38 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/crop/view.html:49 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <input> without a programmatic label kahuna/public/js/leases/leases.html:98 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label thrall/app/views/index.scala.html:32 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label thrall/app/views/index.scala.html:121 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC4 · Keyboard semantics · Click handler on a non-interactive <div> · ×6
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:118 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabIndex={0} + a key handler.
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:236 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:181 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:187 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:92 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
  • Click handler on a non-interactive <div> kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:99 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC3 · Page structure · <html> without a lang · ×5
  • <html> without a lang kahuna/app/views/main.scala.html:22 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang kahuna/app/views/quotas.scala.html:3 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang scripts/src/main/java/com/gu/typesafe/config/package.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
  • <html> without a lang scripts/src/main/java/com/gu/typesafe/config/parser/package.html:2 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
AC3 · Page structure · Document without a <title> · ×3
  • Document without a <title> scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2 — A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
  • Document without a <title> scripts/src/main/java/com/gu/typesafe/config/package.html:2 — A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
  • Document without a <title> scripts/src/main/java/com/gu/typesafe/config/parser/package.html:2 — A page with no <title> gives no name in the tab, history or screen-reader page list. Add a descriptive <title> in <head>.
AC4 · Keyboard semantics · Focusable <div> isn't keyboard-operable · ×3
  • Focusable <div> isn't keyboard-operable kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:123 — This <div> carries tabIndex={0}, so it is in the tab order and a keyboard user will land on it — but its behaviour is bound to the pointer only, with no key handler. A tabindex makes an element focusable, not operable: Enter and Space fire a click on a native <button> or <a href> and nowhere else, so this can be focused and never activated. Use a <button>, or handle Enter/Space in a key handler. Give it a role as well, so assistive tech can announce what it is.
  • Focusable <div> isn't keyboard-operable kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:127 — This <div> carries tabIndex={0}, so it is in the tab order and a keyboard user will land on it — but its behaviour is bound to the pointer only, with no key handler. A tabindex makes an element focusable, not operable: Enter and Space fire a click on a native <button> or <a href> and nowhere else, so this can be focused and never activated. Use a <button>, or handle Enter/Space in a key handler. Give it a role as well, so assistive tech can announce what it is.
  • Focusable <div> isn't keyboard-operable kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:251 — This <div> carries tabIndex={0}, so it is in the tab order and a keyboard user will land on it — but its behaviour is bound to the pointer only, with no key handler. A tabindex makes an element focusable, not operable: Enter and Space fire a click on a native <button> or <a href> and nowhere else, so this can be focused and never activated. Use a <button>, or handle Enter/Space in a key handler.
AC2 · Forms & labels · <textarea> without a programmatic label · ×2
  • <textarea> without a programmatic label REDACTED:90 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <textarea> without a programmatic label REDACTED:100 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC4 · Keyboard semantics · Clickable element isn't keyboard-operable · ×2
  • Clickable element isn't keyboard-operable kahuna/public/js/components/gr-batch-export-original-images/gr-batch-export-original-images.html:1 — The repo's own CSS styles .clickable with `cursor: pointer`, so this <div> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
  • Clickable element isn't keyboard-operable kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:89 — The repo's own CSS styles .custom-checkbox with `cursor: pointer`, so this <span> is a control — but it has no role, no tabIndex={0} and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabIndex={0} + a key handler.
AC4 · Keyboard semantics · Click handler on a non-interactive <tr> · ×2
  • Click handler on a non-interactive <tr> kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:247 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
  • Click handler on a non-interactive <tr> kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:197 — A click handler on a plain element with no role and no tabindex: even where another element's key handler can reach it, assistive tech can neither focus it nor announce what it is. Use a <button>, or add role + tabIndex={0}.
D28 · Secrets (history) · REDACTED · ×2
  • REDACTED
  • REDACTED
D31 · IaC & Container Security · High IaC · ×2
  • REDACTED
  • REDACTED
AC1 · Text alternatives · <img> without a text alternative · ×1
  • <img> without a text alternative kahuna/public/js/upload/jobs/upload-jobs.html:14 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
AC2 · Forms & labels · Link with no accessible name · ×1
  • Link with no accessible name kahuna/app/views/quotas.scala.html:66 — A link with no text, aria-label or labelled child (e.g. an icon-only link) has no accessible name, so assistive tech can't say where it goes. Add visible text or an aria-label.
AC2 · Forms & labels · <button> with no accessible text · ×1
  • <button> with no accessible text kahuna/public/js/components/gr-feature-switch-panel/gr-feature-switch-panel.tsx:109 — A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one).
AC2 · Forms & labels · <select> without a programmatic label · ×1
  • <select> without a programmatic label kahuna/public/js/leases/leases.html:38 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
D13 · REDACTED Scanning · Leaked secret · ×1
  • REDACTED
D28 · Secrets (history) · High secret · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · High vulnerability · ×1
  • REDACTED
D31 · IaC & Container Security · Critical IaC · ×1
  • REDACTED
R8 · Dependency Hygiene · Unlisted import '@smithy/node-http-handler' · ×1
  • Unlisted import '@smithy/node-http-handler' image-embedder-lambda/src/embedder/embedder.ts:3 — Imported but not declared in any reachable REDACTED — installs work only by hoisting accident.
Serious — 624 finding(s)
D31 · IaC & Container Security · Medium IaC · ×120
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 95 more in this group — see findings.md.
D17 · Explicit Debt · TodoComment · ×114
  • TodoComment usage/app/model/UsageGroup.scala:148 — // TODO capture images from interactive embeds — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment usage/app/lib/CrierEventProcessor.scala:142 — //TODO: how do we deal with a piece of content that has been deleted? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/test/lib/elasticsearch/ElasticSearchTest.scala:137 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/test/lib/elasticsearch/ElasticSearchTest.scala:141 — // TODO don't know how to assert this — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/test/lib/elasticsearch/ElasticSearchTest.scala:245 — // TODO rename to add — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/test/lib/elasticsearch/ElasticSearchTest.scala:760 — // TODO how to assert that the suggestion was added? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/test/lib/elasticsearch/ElasticSearchTestBase.scala:82 — // TODO use eventually clause — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/SyncChecker.scala:69 — // TODO String? or more complex? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/SyncChecker.scala:87 — // TODO fetch all objects at unexpected locations ie. not at /^([0-9a-f]/){6}[0-9a-f]{34}$/ — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:416 — // TODO could be a Seq — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:432 — // TODO no order? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:485 — // TODO: is there a more efficient way to do this? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:672 — // TODO deduplicate with set collections — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:808 — // TODO ScalaObjectMapper is deprecated because unusable in Scala 3 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:818 — // TODO ScalaObjectMapper is deprecated because unusable in Scala 3 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:809 — // TODO not great; there must be a better way to flatten a case class into a Map — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ElasticSearch.scala:819 — // TODO not great; there must be a better way to flatten a case class into a Map — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment thrall/app/lib/elasticsearch/ThrallMigrationClient.scala:28 — // TODO create constant for field name "esInfo.migration.migratedTo" — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment rest-lib/src/main/scala/com/gu/mediaservice/lib/auth/Authentication.scala:56 — // TODO: see if we can avoid repetition — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/model/UsageRightsProperty.scala:8 — // TODO: We'll be able to deprecate this and build it up directly from case — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/model/UsageRightsProperty.scala:10 — // TODO: turn this into a case class? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/controllers/EditsApi.scala:26 — // TODO: add links to the different responses esp. to the reference image — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/controllers/EditsController.scala:31 — // TODO: Look at adding actions e.g. to collections / sets where we could `PUT` — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/controllers/EditsController.scala:72 — // TODO: Think about calling this `overrides` or something that isn't metadata — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment metadata-editor/app/controllers/EditsController.scala:202 — // TODO think more about this - image may exist but not have been edited?? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • + 89 more in this group — see findings.md.
R4 · Test Coverage · No test reaches this file · ×40
  • No test reaches this file kahuna/public/js/search/results.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/search/query.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/edits/image-editor.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/takedown/delete-from-grid-step.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/edits/service.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gu-lazy-table/gu-lazy-table.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/image/controller.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/search/index.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/leases/leases.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/search/structured-query/query-suggestions.ts:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/usage-rights/usage-rights-editor.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/crop/controller.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/takedown/crops-and-usages.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file REDACTED:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/takedown/takedown-context.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/upload/jobs/upload-jobs.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file image-embedder-lambda/src/embedder/localRun.ts:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/metadata-templates/metadata-templates.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/services/api/leases.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/edits/list-editor.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • + 15 more in this group — see findings.md.
AC4 · Keyboard semantics · Anchor without href · ×27
  • Anchor without href REDACTED:11 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-collections-panel/gr-collections-panel-node.html:29 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-crop-image/gr-crop-image.html:2 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-crop-image/gr-crop-image.html:10 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:179 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:188 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:429 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:478 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:507 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:648 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:670 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:826 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:857 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:921 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:958 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:995 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:1031 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:1063 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-image-metadata/gr-image-metadata.html:1072 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-more-like-this/gr-more-like-this.html:2 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-photoshoot/gr-photoshoot.html:25 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/components/gr-preset-labels/gr-preset-labels.html:6 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/crop/view.html:3 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/crop/view.html:107 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • Anchor without href kahuna/public/js/edits/image-editor.html:8 — An <a> with no href, role or tabindex isn't focusable or keyboard-activatable. Give it a real href, or use a <button> for an action.
  • + 2 more in this group — see findings.md.
D17 · Explicit Debt · FixmeComment · ×25
  • FixmeComment thrall/app/controllers/ThrallController.scala:248 — //FIXME figure out imageId bit — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment rest-lib/src/main/scala/com/gu/mediaservice/lib/guardian/auth/Permissions.scala:15 — // FIXME ideally factor this out in favour of a permission definition that can be defined at runtime (e.g. loaded from config) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment rest-lib/src/main/scala/com/gu/mediaservice/lib/auth/Permissions.scala:21 — // FIXME ideally factor this out in favour of something more generic — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment metadata-editor/app/controllers/EditsController.scala:29 — // FIXME: the argoHelpers are all returning `Ok`s (200) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment media-api/test/lib/querysyntax/ParserTest.scala:133 — // // FIXME: gets caught as label; exclude numeric? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment media-api/app/controllers/MediaApi.scala:137 — // FIXME: credit is the only field available for now as it's the only on — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment kahuna/app/lib/KahunaConfig.scala:71 — // FIXME ideally the below would not hardcode reference to pinboard - hopefully future iterations of the pluggable authorisation will support evaluating permissions without a corresponding case object — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/test/scala/model/ProjectorTest.scala:51 — // FIXME temporary ignored as test is not executable in CI/CD machine — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/app/model/Uploader.scala:197 — // FIXME: dirty hack to sync the originalUsageRights and originalMetadata as well — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/app/lib/imaging/FileMetadataReader.scala:60 — // FIXME: JPEG, JFIF, Photoshop, GPS, File — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/app/controllers/ImageLoaderController.scala:510 — //FIXME use set status to avoid potential ConditionNotMet (when status table rows have expired/TTL) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/app/controllers/ImageLoaderController.scala:546 — //FIXME use set status to avoid potential ConditionNotMet (when status table rows have expired/TTL) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment image-loader/app/controllers/ImageLoaderController.scala:552 — //FIXME use set status to avoid potential ConditionNotMet (when status table rows have expired/TTL) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment cropper/app/lib/CropStore.scala:77 — // FIXME: this doesn't really belong here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/syntax/MessageSubjects.scala:6 — // FIXME: the new migration process will replace the legacy reingest lambda etc — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/model/Asset.scala:9 — // FIXME: size, mimeType and dimensions not optional (must backfill first) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/model/Crop.scala:9 — //FIXME: Both id and file size here should not be an Option and are awaiting backfilling the correct data in ES — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/model/Image.scala:79 — // FIXME: many fields made nullable to accommodate for legacy data that pre-dates them. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/metadata/ImageMetadataConverter.scala:98 — // FIXME: Parse newest location schema: http://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata#location-structure
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/metadata/ImageMetadataConverter.scala:113 — // FIXME add extractor for imageType https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata#digital-source-type
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/cleanup/CapitaliseProperty.scala:20 — // FIXME: is there no more efficient way of partial matching a regexp on a string? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala:266 — // FIXME: Dynamo accepts `null`, but not `""`. This is a well documented issue — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/argo/ArgoHelpers.scala:15 — // FIXME: DSL to append links and actions? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/argo/ArgoHelpers.scala:38 — //FIXME using actions below is a hack to get extra counts into the response (until such time as we move theseus into the grid, so client can safely parse the response) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • FixmeComment common-lib/src/main/scala/com/gu/mediaservice/lib/argo/model/CollectionResponse.scala:41 — // FIXME: the 'theseus' library used on the client mandates a strict set of top level keys, so crow-barring something else into 'actions' here (https://github.com/argo-rest/theseus [last updated 2015] needs to move into grid repo, so we can update it for this use-case and others)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · Medium CVE · ×11
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
PF3 · Async & latency hygiene · Sync-over-async blocking · ×11
  • Sync-over-async blocking image-loader/app/model/Projector.scala:87 — `projectS3ImageById` is async and calls Await.result — a blocking call inside async code stalls the execution-context thread, and every future or fiber scheduled on it for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/provision.ts:58 — `fs.readFileSync` in `createStack` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/provision.ts:113 — `fs.readFileSync` in `callback to map` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/provision.ts:119 — `fs.readFileSync` in `seedBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/provision.ts:129 — `generateKeyPairSync` in `seedAuthBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/provision.ts:153 — `fs.readFileSync` in `seedAuthBuckets` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/seed-elasticsearch.ts:75 — `fs.readFileSync` in `seedElasticsearch` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/stack.ts:551 — `fs.rmSync` in `task` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/stack.ts:552 — `fs.mkdirSync` in `task` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/setup/stack.ts:814 — `fs.rmSync` in `task` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking e2e-tests/steps/utils/drag-and-drop.ts:20 — `readFileSync` in `callback to map` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
D35 · Change Coupling · Change coupling · ×10
  • Change coupling: ImageLoaderController.scala ↔ loader.js image-loader/app/controllers/ImageLoaderController.scala:1 — `image-loader/app/controllers/ImageLoaderController.scala` and `kahuna/public/js/services/api/loader.js` change together 90% of the time (9 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `bed54051` fix routing with separate controller methods, rename endpoint; `072dd138` Apply suggestions from code review - userId is optional, defaults to …; `94c8e1dd` update status to queued after successful S3 upload on the client — run `git show` on any of them.
  • Change coupling: MessageProcessor.scala ↔ MessageTranslator.scala thrall/app/lib/kinesis/MessageProcessor.scala:1 — `thrall/app/lib/kinesis/MessageProcessor.scala` and `thrall/app/lib/kinesis/MessageTranslator.scala` change together 73% of the time (11 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are `adb1930c` IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.4; `7b77fe53` IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP; `302eca63` API to delete single usage — run `git show` on any of them.
  • Change coupling: ImageOperations.scala ↔ ImageMagick.scala common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala:1 — `common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/ImageOperations.scala` and `common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/im4jwrapper/ImageMagick.scala` change together 71% of the time (10 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `eae8dce4` Crops and thumbnails are corrected for orientation.; `8e2742cc` Pass some more logMarkers around, including parts of common-lib; `a1b45ae8` Bake thumbs to background colour and reduce bpc to 8 — run `git show` on any of them.
  • Change coupling: jest.integration.config.ts ↔ embedder.ts image-embedder-lambda/jest.integration.config.ts:1 — `image-embedder-lambda/jest.integration.config.ts` and `image-embedder-lambda/src/embedder/embedder.ts` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `31165318` linting (at that commit the file was still `image-embedder-lambda/src/index.ts`); `91234165` linting (at that commit the file was still `image-embedder-lambda/src/index.ts`); `9b1b7af3` action a bunch of stuff (at that commit the file was still `image-embedder-lambda/src/index.ts`) — run `git show` on any of them.
  • Change coupling: results.js ↔ media-api.js kahuna/public/js/search/results.js:1 — `kahuna/public/js/search/results.js` and `kahuna/public/js/services/api/media-api.js` change together 66% of the time (19 of the 29 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 19 shared commits counted here, the most recent 3 are `7683c460` Make fill scores the default approach; `98d56696` Add fill scores tickbox to frontend; `cf10157f` not working, intermediate commit — run `git show` on any of them.
  • Change coupling: KahunaConfig.scala ↔ window.ts kahuna/app/lib/KahunaConfig.scala:1 — `kahuna/app/lib/KahunaConfig.scala` and `kahuna/public/js/window.ts` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `7651b084` Takedown page UI; `d588bcde` add config setting; `46b41536` refactor of interim filters to move config into app.config and improv… — run `git show` on any of them.
  • Change coupling: gr-my-uploads.tsx ↔ gr-permissions-filter.tsx kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:1 — `kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx` and `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `f036eb7f` remove unneeded comments; `f491be3f` removing instrumentation and logging code; `a4e095bc` swapping onChange to onClick to avoid repeats — run `git show` on any of them.
  • Change coupling: ThrallMessage.scala ↔ MessageSubjects.scala common-lib/src/main/scala/com/gu/mediaservice/model/ThrallMessage.scala:1 — `common-lib/src/main/scala/com/gu/mediaservice/model/ThrallMessage.scala` and `common-lib/src/main/scala/com/gu/mediaservice/syntax/MessageSubjects.scala` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `adb1930c` IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP pt2.4; `7b77fe53` IMAGEDAM-1593 - Updating ElasticSearch with new usage status WIP; `302eca63` API to delete single usage — run `git show` on any of them.
  • Change coupling: query.js ↔ media-api.js kahuna/public/js/search/query.js:1 — `kahuna/public/js/search/query.js` and `kahuna/public/js/services/api/media-api.js` change together 52% of the time (15 of the 29 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 15 shared commits counted here, the most recent 3 are `7683c460` Make fill scores the default approach; `98d56696` Add fill scores tickbox to frontend; `cf10157f` not working, intermediate commit — run `git show` on any of them.
  • Change coupling: UploadStatusTable.scala ↔ manager.js image-loader/app/lib/UploadStatusTable.scala:1 — `image-loader/app/lib/UploadStatusTable.scala` and `kahuna/public/js/upload/manager.js` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `3e9fe1fb` fix handling of new queued status; `94c8e1dd` update status to queued after successful S3 upload on the client; `e483e6d2` fix handling of new queued status — run `git show` on any of them.
D6 · Cohesion (LCOM4) · Low cohesion · ×10
  • Low cohesion: UsageApi (LCOM4 10) usage/app/controllers/UsageApi.scala:24 — UsageApi's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ThrallController (LCOM4 7) thrall/app/controllers/ThrallController.scala:27 — ThrallController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: UsageController (LCOM4 6) media-api/app/controllers/UsageController.scala:20 — UsageController's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MediaApi (LCOM4 5) media-api/app/controllers/MediaApi.scala:57 — MediaApi's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PandaAuthenticationProvider (LCOM4 5) rest-lib/src/main/scala/com/gu/mediaservice/lib/guardian/auth/PandaAuthenticationProvider.scala:23 — PandaAuthenticationProvider's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: CrierEventProcessor (LCOM4 5) usage/app/lib/CrierEventProcessor.scala:69 — CrierEventProcessor's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: AuthController (LCOM4 4) auth/app/auth/AuthController.scala:18 — AuthController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: S3ImageStorage (LCOM4 4) common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:15 — S3ImageStorage's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MagickImageOperations (LCOM4 4) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:18 — MagickImageOperations's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MediaLeaseController (LCOM4 4) leases/app/controllers/MediaLeaseController.scala:22 — MediaLeaseController's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
R11 · Import Boundaries · Boundary violation [package · ×8
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-cache-purger.ts:2 — cdk/lib/image-cache-purger.ts:2 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-cache-purger.ts:3 — cdk/lib/image-cache-purger.ts:3 imports @guardian/cdk/lib/constructs/lambda, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-embedder-lambda.ts:3 — cdk/lib/image-embedder-lambda.ts:3 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-embedder-lambda.ts:4 — cdk/lib/image-embedder-lambda.ts:4 imports @guardian/cdk/lib/constructs/core, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-embedder-lambda.ts:5 — cdk/lib/image-embedder-lambda.ts:5 imports @guardian/cdk/lib/constructs/ec2, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-embedder-lambda.ts:6 — cdk/lib/image-embedder-lambda.ts:6 imports @guardian/cdk/lib/constructs/lambda, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] cdk/lib/image-embedder-lambda.ts:7 — cdk/lib/image-embedder-lambda.ts:7 imports @guardian/cdk/lib/constructs/s3, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
  • Boundary violation [package:third-party-deep-import] dev/script/generate-config/generate-config.js:7 — dev/script/generate-config/generate-config.js:7 imports json5/lib/register, reaching past a declared dependency's public entry into its build output — that path is the package's toolchain layout, not its API, and a minor version bump can relocate it with no semver signal. Import from the package's documented entry point instead.
AC6 · Visual & motion safety · Focus outline removed in CSS without a · ×7
  • Focus outline removed in CSS without a :focus replacement kahuna/public/stylesheets/main.css:1117 — `.search-query__clear` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement kahuna/public/stylesheets/main.css:1219 — `.search__advanced-toggle:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement kahuna/public/stylesheets/main.css:2465 — `.image-info__wrap .editable-wrap .image-info__editor--error` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement kahuna/public/stylesheets/main.css:2470 — `.image-info__wrap .editable-wrap .image-info__editor--saving` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement kahuna/public/js/components/gr-tab-swap/gr-tab-swap.css:23 — `.gr-tab` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement kahuna/public/js/components/gr-chips/gr-chips.css:82 — `gr-text-chip button:focus` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement e2e-tests/feature-library/styles.css:89 — `.search input` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D15 · Churn × Complexity Hotspots · Hotspot · ×7
  • Hotspot: kahuna/public/js/takedown/delete-from-grid-step.tsx kahuna/public/js/takedown/delete-from-grid-step.tsx:88 — kahuna/public/js/takedown/delete-from-grid-step.tsx changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 43 in delete-from-grid-step.DeleteFromGridStep at line 88. 1 of those changes was a fix/bug commit, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- kahuna/public/js/takedown/delete-from-grid-step.tsx`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: media-api/app/controllers/MediaApi.scala media-api/app/controllers/MediaApi.scala:632 — media-api/app/controllers/MediaApi.scala changed 13 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 22 in MediaApi.imageSearch at line 632. 2 of those changes were fix/bug commits, and the other 11 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- media-api/app/controllers/MediaApi.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: media-api/app/lib/elasticsearch/QueryBuilder.scala media-api/app/lib/elasticsearch/QueryBuilder.scala:76 — media-api/app/lib/elasticsearch/QueryBuilder.scala changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in QueryBuilder.makeQueryBit at line 76. 1 of those changes was a fix/bug commit, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- media-api/app/lib/elasticsearch/QueryBuilder.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:79 — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in gr-permissions-filter.PermissionsFilter at line 79. 1 of those changes was a fix/bug commit, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala:84 — common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in UsageRights.jsonWrites at line 84. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- common-lib/src/main/scala/com/gu/mediaservice/model/UsageRights.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: e2e-tests/feature-library/app.tsx e2e-tests/feature-library/app.tsx:381 — e2e-tests/feature-library/app.tsx changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 21 in app.FeatureLibrary at line 381. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- e2e-tests/feature-library/app.tsx`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: REDACTED REDACTED:58 — REDACTED changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in delete-from-content-step.DeleteFromContentStep at line 58. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-25..2026-10-23, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-25 16:37:12 +01:00' --until='2026-10-23 16:37:12 +01:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D3 · God Classes · TooManyMethods · ×6
  • TooManyMethods: QuerySyntax REDACTED:10 — TooManyMethods — 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ElasticSearch thrall/app/lib/elasticsearch/ElasticSearch.scala:32 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Mappings common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/Mappings.scala:9 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MediaApi media-api/app/controllers/MediaApi.scala:57 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ImageResponse media-api/app/lib/ImageResponse.scala:23 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ElasticSearch media-api/app/lib/elasticsearch/ElasticSearch.scala:43 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
AC3 · Page structure · Page without a main landmark · ×5
  • Page without a main landmark kahuna/app/views/main.scala.html:22 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark scripts/src/main/java/com/gu/typesafe/config/impl/package.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark scripts/src/main/java/com/gu/typesafe/config/package.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark scripts/src/main/java/com/gu/typesafe/config/parser/package.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark thrall/app/views/migrationFailures.scala.html — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
D3 · God Classes · FunctionTooLong · ×5
  • FunctionTooLong: delete-from-grid-step.DeleteFromGridStep kahuna/public/js/takedown/delete-from-grid-step.tsx:88 — FunctionTooLong — DeleteFromGridStep runs 248 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 148 over it, 2.48× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: crops-and-usages.CropsAndUsages kahuna/public/js/takedown/crops-and-usages.tsx:42 — FunctionTooLong — CropsAndUsages runs 200 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 100 over it, 2.00× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: gr-permissions-filter.PermissionsFilter kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:79 — FunctionTooLong — PermissionsFilter runs 152 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 52 over it, 1.52× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: base-sort-control.BaseSortControl kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:67 — FunctionTooLong — BaseSortControl runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • FunctionTooLong: gr-notifications-banner.NotificationsBanner kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:116 — FunctionTooLong — NotificationsBanner runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
AC6 · Visual & motion safety · Animation without a prefers-reduced-motion guard · ×4
  • Animation without a prefers-reduced-motion guard kahuna/public/stylesheets/main.css:575 — `.loader:after` moves (`animation-name: flipper`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard kahuna/public/stylesheets/main.css:600 — `.saving` moves (`animation-name: spin`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard kahuna/public/stylesheets/main.css:611 — `.spin` moves (`animation-name: spin`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
  • Animation without a prefers-reduced-motion guard kahuna/public/js/components/gr-panels/gr-panels.css:26 — `.gr-panel__content` moves (`transition: width 0.2s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
D2 · Cognitive Complexity · (anonymous) · ×4
  • (anonymous)::watchSearchChange (cognitive 29) kahuna/public/js/search/query.js:315 — (anonymous)::watchSearchChange has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (13 pts), ternaries 5 (11 pts), boolean chains 5 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • (anonymous)::$onInit::save (cognitive 23) kahuna/public/js/leases/leases.js:59 — (anonymous)::$onInit::save has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 3 (9 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • (anonymous)::manageUploadedBy (cognitive 23) kahuna/public/js/search/query.js:162 — (anonymous)::manageUploadedBy has cognitive complexity 23 (threshold 15). Drivers by points: ternaries 3 (10 pts), if/else 5 (9 pts), boolean chains 4 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
  • (anonymous)::notificationMessages (cognitive 17) kahuna/public/js/search/results.js:424 — (anonymous)::notificationMessages has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
R10 · Code Duplication · Duplicated block (12 lines × 2 locations) · ×4
  • Duplicated block (12 lines × 2 locations) cdk/lib/image-embedder-lambda.ts:77 — cdk/lib/image-embedder-lambda.ts:77 · cdk/lib/image-embedder-lambda.ts:91 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (12 lines × 2 locations) kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:15 — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:15 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:16 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
  • Duplicated block (12 lines × 2 locations) kahuna/public/js/search/structured-query/query-suggestions.ts:213 — kahuna/public/js/search/structured-query/query-suggestions.ts:213 · kahuna/public/js/search/structured-query/query-suggestions.ts:249 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (12 lines × 2 locations) kahuna/public/js/upload/jobs/upload-jobs.js:192 — kahuna/public/js/upload/jobs/upload-jobs.js:192 · kahuna/public/js/upload/recent/recent-uploads.js:59 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
X2 · Cancellation propagation · Async function without AbortSignal · ×4
  • Async function without AbortSignal: importImage scripts/sample-images/index.js:30 — `importImage` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
  • Async function without AbortSignal: upload kahuna/public/js/upload/manager.js:128 — `upload` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
  • Async function without AbortSignal: queryElasticSearch image-embedder-lambda/src/backfiller/elasticSearch.ts:40 — `queryElasticSearch` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
  • Async function without AbortSignal: getImageCount image-counter-lambda/src/handler.ts:16 — `getImageCount` awaits `fetch(…)` but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept `{ signal }` and pass it through: `fetch(url, { signal })`.
AC3 · Page structure · Data table has no header cells · ×3
  • Data table has no header cells kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:244 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:194 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx:116 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · FileTooLong · ×3
  • FileTooLong: controllers/MediaApi.scala media-api/app/controllers/MediaApi.scala — FileTooLong — 648 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: MediaApi (57-935). The bar is 500 significant lines; this is 148 over it, 1.30× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: search/results.js kahuna/public/js/search/results.js — FileTooLong — 610 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: lastSearchFirstResultTime (80-977). The bar is 500 significant lines; this is 110 over it, 1.22× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: elasticsearch/ElasticSearch.scala thrall/app/lib/elasticsearch/ElasticSearch.scala — FileTooLong — 595 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 95 over it, 1.19× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D3 · God Classes · ClassTooLong · ×3
  • ClassTooLong: ElasticSearch media-api/app/lib/elasticsearch/ElasticSearch.scala:43 — ClassTooLong — 457 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods. The bar is 400 significant lines; this is 57 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: query kahuna/public/js/search/query.js:1 — ClassTooLong — 446 significant lines (blank, comment-only and punctuation-only lines excluded), 2 methods. The bar is 400 significant lines; this is 46 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ImageLoaderController image-loader/app/controllers/ImageLoaderController.scala:47 — ClassTooLong — 436 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 36 over it, 1.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) thrall/app/lib/elasticsearch/ElasticSearch.scala:508 — thrall/app/lib/elasticsearch/ElasticSearch.scala:508-518 | thrall/app/lib/elasticsearch/ElasticSearch.scala:527-537 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `thrall/app/lib/elasticsearch/ElasticSearch.scala:508` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) usage/app/controllers/UsageApi.scala:241 — usage/app/controllers/UsageApi.scala:241-251 | usage/app/controllers/UsageApi.scala:264-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `usage/app/controllers/UsageApi.scala:241` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) usage/app/model/UsageRecord.scala:127 — usage/app/model/UsageRecord.scala:127-137 | usage/app/model/UsageRecord.scala:144-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×3
  • Duplicated block (10 lines × 2) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:249 — common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:249-258 | common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:273-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:249` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) media-api/app/controllers/MediaApi.scala:267 — media-api/app/controllers/MediaApi.scala:267-276 | media-api/app/controllers/MediaApi.scala:284-293 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/controllers/MediaApi.scala:267` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) media-api/app/controllers/MediaApi.scala:299 — media-api/app/controllers/MediaApi.scala:299-308 | media-api/app/controllers/MediaApi.scala:332-341 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/controllers/MediaApi.scala:299` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
R10 · Code Duplication · Duplicated block (14 lines × 2 locations) · ×3
  • Duplicated block (14 lines × 2 locations) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:218 — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:218 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:105 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
  • Duplicated block (14 lines × 2 locations) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:250 — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:250 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:200 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
  • Duplicated block (14 lines × 2 locations) kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:138 — kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:138 · kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:64 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (13 lines × 2 locations) · ×3
  • Duplicated block (13 lines × 2 locations) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:299 — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:299 · kahuna/public/js/edits/image-editor.js:90 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
  • Duplicated block (13 lines × 2 locations) kahuna/public/js/edits/image-editor.js:327 — kahuna/public/js/edits/image-editor.js:327 · kahuna/public/js/edits/image-editor.js:342 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (13 lines × 2 locations) kahuna/public/js/image/controller.js:244 — kahuna/public/js/image/controller.js:244 · kahuna/public/js/upload/controller.js:59 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (10 lines × 2 locations) · ×3
  • Duplicated block (10 lines × 2 locations) kahuna/public/js/components/gr-delete-image/gr-delete-image.js:43 — kahuna/public/js/components/gr-delete-image/gr-delete-image.js:43 · kahuna/public/js/components/gr-undelete-image/gr-un-delete-image.js:37 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (10 lines × 2 locations) kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:51 — kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx:51 · kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:199 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (10 lines × 2 locations) kahuna/public/js/usage-rights/usage-rights-editor.js:237 — kahuna/public/js/usage-rights/usage-rights-editor.js:237 · kahuna/public/js/usage-rights/usage-rights-editor.js:249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (8 lines × 2 locations) · ×3
  • Duplicated block (8 lines × 2 locations) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:197 — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:197 · kahuna/public/js/upload/jobs/required-metadata-editor.js:63 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (8 lines × 2 locations) kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:38 — kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:38 · kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:47 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2 locations) kahuna/public/js/search/structured-query/query-suggestions.ts:259 — kahuna/public/js/search/structured-query/query-suggestions.ts:259 · kahuna/public/js/search/structured-query/query-suggestions.ts:277 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
S1 · Web-Security Posture · Weak hash algorithm · ×3
  • Weak hash algorithm common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java:13 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm common-lib/src/main/scala/com/gu/mediaservice/lib/MD5.scala:6 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm image-loader/app/lib/BodyParsers.scala:39 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
X17 · Uncapped recursion over a caller-supplied document · Recursive walk over a caller-supplied document has no depth cap · ×3
  • Recursive walk over a caller-supplied document has no depth cap common-lib/src/main/scala/com/gu/mediaservice/JsonDiff.scala:24 — `JsonDiff.diff` is public and takes `a: JsValue` from its caller, and it calls itself at line 24 with a piece of `a`, not as a tail call the compiler turns into a loop — and nowhere in `JsonDiff.diff` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `JsonDiff.diff` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
  • Recursive walk over a caller-supplied document has no depth cap common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala:237 — `DynamoDB.jsonToAttributeValue` is public and takes `json: JsValue` from its caller, and it calls itself at line 237 with a piece of `json` (and at line 238), not as a tail call the compiler turns into a loop — and nowhere in `DynamoDB.jsonToAttributeValue` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `DynamoDB.jsonToAttributeValue` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
  • Recursive walk over a caller-supplied document has no depth cap common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala:272 — `DynamoDB.mapJsValue` is public and takes `jsValue: JsValue` from its caller, and it calls itself at line 272 with a piece of `jsValue`, not as a tail call the compiler turns into a loop — and nowhere in `DynamoDB.mapJsValue` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `DynamoDB.mapJsValue` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (2.6 · ×2
  • Low contrast colour pair in CSS (2.6:1) kahuna/public/js/edits/list-editor.css:27 — `.element--partial .element__value, .element--partial .element__add, .element--partial .element__right-bit` sets color: #00adee on background-color: white — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
  • Low contrast colour pair in CSS (2.6:1) kahuna/public/js/components/gr-preset-labels/gr-preset-labels.css:27 — `.preset-label__value, .preset-label__remove` sets color: white on background-color: #00adee — 2.6:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 34) · ×2
  • (anonymous) (cyclomatic 34) kahuna/public/js/image/controller.js:91 — (anonymous) has cyclomatic complexity 34 (threshold 15). Most of this is not in the body itself: 7 of the 34 points are its own statements and the rest belongs to 37 function items inside it that branch (callback, a function literal at line 336, a function literal at line 270, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cyclomatic 34) kahuna/public/js/leases/leases.js:31 — (anonymous) has cyclomatic complexity 34 (threshold 15). Most of this is not in the body itself: 1 of the 34 points is its own statement and the rest belongs to 40 function items inside it that branch ($onInit::save, a function literal at line 130, $onInit::leaseStatus, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 18) · ×2
  • (anonymous) (cognitive 18) kahuna/public/js/edits/list-editor.js:26 — (anonymous) has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 2, error handling 2, ternaries 2 (nesting depth added 3). None of this is in the body itself: all 18 points belong to 27 function items inside it that branch ($onInit::removeAll, $onInit::addElements, $onInit::batchApply, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
  • (anonymous) (cognitive 18) kahuna/public/js/preview/image.js:47 — (anonymous) has cognitive complexity 18 (threshold 15). Drivers by points: boolean chains 9, if/else 4, ternaries 4, other 1. None of this is in the body itself: all 18 points belong to 24 function items inside it that branch ($onInit::getWarningMessage, $onInit, $onInit::showOverlay, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D3 · God Classes · MethodTooLong · ×2
  • MethodTooLong: MediaApi.imageSearch media-api/app/controllers/MediaApi.scala:632 — MethodTooLong — imageSearch runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ImageEmbedder.constructor cdk/lib/image-embedder-lambda.ts:36 — MethodTooLong — constructor runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×2
  • Duplicated block (5 lines × 2) thrall/app/lib/elasticsearch/ElasticSearch.scala:810 — thrall/app/lib/elasticsearch/ElasticSearch.scala:810-814 | thrall/app/lib/elasticsearch/ElasticSearch.scala:820-824 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) media-api/app/lib/elasticsearch/ElasticSearch.scala:220 — media-api/app/lib/elasticsearch/ElasticSearch.scala:220-224 | media-api/app/lib/elasticsearch/ElasticSearch.scala:253-257 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/lib/elasticsearch/ElasticSearch.scala:220` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
P12 · CI test-gate honesty · Runner config excludes tests no gate runs · ×2
  • Runner config excludes tests no gate runs image-embedder-lambda/jest.config.ts:10 — `/__tests__/embedder/integration/` removes 2 test(s) in 2 file(s) (e.g. `image-embedder-lambda/__tests__/embedder/integration/embedding.integration.test.ts`, `image-embedder-lambda/__tests__/embedder/integration/localTestFiles.ts`) from what jest collects, and no other runner or CI command runs them — they are dead tests. Run them (another runner, project or job), or delete them.
  • Runner config excludes tests no gate runs image-embedder-lambda/jest.config.ts:11 — `/__tests__/backfiller/integration/` removes 2 test(s) in 1 file(s) (e.g. `image-embedder-lambda/__tests__/backfiller/integration/backfiller.integration.test.ts`) from what jest collects, and no other runner or CI command runs them — they are dead tests. Run them (another runner, project or job), or delete them.
R10 · Code Duplication · Duplicated block (12 lines × 3 locations) · ×2
  • Duplicated block (12 lines × 3 locations) dev/script/generate-config/service-config.js:131 — dev/script/generate-config/service-config.js:131 · dev/script/generate-config/service-config.js:200 · dev/script/generate-config/service-config.js:241 — all 3 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (12 lines × 3 locations) kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx:92 — kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx:92 · kahuna/public/js/components/gr-sort-control/gr-sort-control.tsx:78 · kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:74 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (9 lines × 2 locations) · ×2
  • Duplicated block (9 lines × 2 locations) kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:138 — kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:138 · kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:165 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2 locations) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:52 — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:52 · kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:64 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (7 lines × 2 locations) · ×2
  • Duplicated block (7 lines × 2 locations) kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:8 — kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:8 · kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:40 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
  • Duplicated block (7 lines × 2 locations) kahuna/public/js/edits/service.js:158 — kahuna/public/js/edits/service.js:158 · kahuna/public/js/edits/service.js:176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 15, cognitive 13) · ×2
  • Complex function (anonymous) (cyclomatic 15, cognitive 13) kahuna/public/js/common/usageRightsUtils.js:5 — (anonymous) has cyclomatic complexity 15 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
  • Complex function (anonymous) (cyclomatic 15, cognitive 13) kahuna/public/js/components/gr-chips/gr-chip-input.js:101 — (anonymous) has cyclomatic complexity 15 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
X24 · Document value interpolated into markup unescaped · Untrusted text written into markup unescaped · ×2
  • Untrusted text written into markup unescaped kahuna/public/js/quotas.js:5 — `content` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped REDACTED:49 — `icon.svg` is text this program did not author, and it is written into the text of an element through `dangerouslySetInnerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×2
  • Swallowed exception (caught, then discarded) kahuna/public/js/sentry/sentry.js:33 — `catch (e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) image-loader/app/lib/imaging/C2PADetector.scala:60 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
X3 · Exception handling · Swallowed exception (empty catch) · ×2
  • Swallowed exception (empty catch) kahuna/public/js/components/gr-downloader/gr-downloader.js:123 — `.catch(() => {})` handles the rejection by doing nothing — the failure is discarded with no log and no rethrow, and the chain carries on as if the work succeeded. Log it through whatever this codebase already uses to report problems, hand it to a caller that can (`next(error)`, a returned rejection), or don't catch it.
  • Swallowed exception (empty catch) kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:40 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
AC3 · Page structure · Heading level jumps from h1 to h3 · ×1
  • Heading level jumps from h1 to h3 thrall/app/views/reaper.scala.html:39 — Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
AC6 · Visual & motion safety · Low contrast colour pair in CSS (2.0 · ×1
  • Low contrast colour pair in CSS (2.0:1) kahuna/public/stylesheets/main.css:915 — `.status` sets color: white on background-color: orange — 2.0:1, below the 4.5:1 WCAG AA minimum for normal text. Darken or lighten one of them.
AC7 · A11y enforcement · Accessibility enforcement below the top rung · ×1
  • Accessibility enforcement below the top rung — No accessibility enforcement found — no a11y linter (eslint-plugin-jsx-a11y) and no axe/pa11y/Lighthouse in tests or CI. Start with the linter to catch issues at author time. What was searched, so you can tell an absence from a miss: the 101 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 101) · ×1
  • (anonymous) (cyclomatic 101) kahuna/public/js/search/results.js:104 — (anonymous) has cyclomatic complexity 101 (threshold 15). Most of this is not in the body itself: 14 of the 101 points are its own statements and the rest belongs to 97 function items inside it that branch (notificationMessages, search, displayConfirmationModal, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 78) · ×1
  • (anonymous) (cyclomatic 78) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:47 — (anonymous) has cyclomatic complexity 78 (threshold 15). Most of this is not in the body itself: 3 of the 78 points are its own statements and the rest belongs to 104 function items inside it that branch ($onInit::onMetadataTemplateSelected, $onInit::textareaKeydownListener, $onInit::updateTextareaCursor, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · delete-from-grid-step.DeleteFromGridStep (cyclomatic 43) · ×1
  • delete-from-grid-step.DeleteFromGridStep (cyclomatic 43) kahuna/public/js/takedown/delete-from-grid-step.tsx:88 — delete-from-grid-step.DeleteFromGridStep has cyclomatic complexity 43 (threshold 15). Most of this is not in the body itself: 7 of the 43 points are its own statements and the rest belongs to 11 function items inside it that branch (a function literal at line 295, handleConfirm, deleteUsages, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 43) · ×1
  • (anonymous) (cyclomatic 43) kahuna/public/js/edits/image-editor.js:49 — (anonymous) has cyclomatic complexity 43 (threshold 15). Most of this is not in the body itself: 2 of the 43 points are its own statements and the rest belongs to 58 function items inside it that branch ($onInit::onMetadataTemplateSelected, $onInit::batchSetLeasesFromUsageRights, $onInit, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · base-sort-control.BaseSortControl (cyclomatic 36) · ×1
  • base-sort-control.BaseSortControl (cyclomatic 36) kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:67 — base-sort-control.BaseSortControl has cyclomatic complexity 36 (threshold 15). Most of this is not in the body itself: 11 of the 36 points are its own statements and the rest belongs to 8 function items inside it that branch (handleArrowKeys, a function literal at line 128, a function literal at line 120, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · MessageTranslator.translate (cyclomatic 35) · ×1
  • MessageTranslator.translate (cyclomatic 35) thrall/app/lib/kinesis/MessageTranslator.scala:9 — MessageTranslator.translate has cyclomatic complexity 35 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 35) · ×1
  • (anonymous) (cyclomatic 35) kahuna/public/js/metadata-templates/metadata-templates.js:26 — (anonymous) has cyclomatic complexity 35 (threshold 15). Most of this is not in the body itself: 1 of the 35 points is its own statement and the rest belongs to 27 function items inside it that branch ($onInit::applyTemplateToUsageRights, $onInit::toLease, $onInit::verifyTemplateCollection, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · gr-permissions-filter.PermissionsFilter (cyclomatic 33) · ×1
  • gr-permissions-filter.PermissionsFilter (cyclomatic 33) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:79 — gr-permissions-filter.PermissionsFilter has cyclomatic complexity 33 (threshold 15). Most of this is not in the body itself: 6 of the 33 points are its own statements and the rest belongs to 8 function items inside it that branch (handleKeyboard, syncSelectionFromQuery, autoHideListener, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 33) · ×1
  • (anonymous) (cyclomatic 33) kahuna/public/js/usage-rights/usage-rights-editor.js:29 — (anonymous) has cyclomatic complexity 33 (threshold 15). Most of this is not in the body itself: 1 of the 33 points is its own statement and the rest belongs to 45 function items inside it that branch ($onInit::setLeasesFromUsageRights, a function literal at line 44, $onInit::save, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · QueryBuilder.makeQueryBit (cyclomatic 24) · ×1
  • QueryBuilder.makeQueryBit (cyclomatic 24) media-api/app/lib/elasticsearch/QueryBuilder.scala:76 — QueryBuilder.makeQueryBit has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Controller (cyclomatic 23) · ×1
  • Controller (cyclomatic 23) kahuna/public/js/components/gr-downloader/gr-downloader.js:23 — Controller has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 22 function items inside it that branch (a function literal at line 41, $onInit::onSingleDownloadClicked, a function literal at line 73, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · MagickImageOperations.identifyColourModel (cyclomatic 22) · ×1
  • MagickImageOperations.identifyColourModel (cyclomatic 22) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:232 — MagickImageOperations.identifyColourModel has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · MediaApi.imageSearch (cyclomatic 22) · ×1
  • MediaApi.imageSearch (cyclomatic 22) media-api/app/controllers/MediaApi.scala:632 — MediaApi.imageSearch has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 21) · ×1
  • (anonymous) (cyclomatic 21) kahuna/public/js/preview/image.js:47 — (anonymous) has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to 24 function items inside it that branch ($onInit::showOverlay, $onInit::getWarningMessage, $onInit, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) · ×1
  • (anonymous)::watchSearchChange (cyclomatic 21) kahuna/public/js/search/query.js:315 — (anonymous)::watchSearchChange has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GoodToGoCheck.run (cyclomatic 20) · ×1
  • GoodToGoCheck.run (cyclomatic 20) thrall/app/lib/elasticsearch/GoodToGoCheck.scala:18 — GoodToGoCheck.run has cyclomatic complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · (anonymous).link (cyclomatic 20) · ×1
  • (anonymous).link (cyclomatic 20) kahuna/public/js/components/gr-chips/gr-chip-input.js:46 — (anonymous).link has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 9 function literals inside it that branch (lines 101, 60, 55, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 20) · ×1
  • (anonymous) (cyclomatic 20) kahuna/public/js/upload/jobs/upload-jobs.js:30 — (anonymous) has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 26 function items inside it that branch (a function literal at line 152, a function literal at line 66, a function literal at line 51, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 19) · ×1
  • (anonymous) (cyclomatic 19) kahuna/public/js/components/gr-chips/gr-chips.js:19 — (anonymous) has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 21 function items inside it that branch (removeChipAt, configureNgModel, configureNgModel::isValidKey, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · gr-usagerights-summary.UsageRightsSummary (cyclomatic 18) · ×1
  • gr-usagerights-summary.UsageRightsSummary (cyclomatic 18) kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx:27 — gr-usagerights-summary.UsageRightsSummary has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 3 of the 18 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 51, 55, 58). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous) (cyclomatic 18) · ×1
  • (anonymous) (cyclomatic 18) kahuna/public/js/crop/controller.js:34 — (anonymous) has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 7 of the 18 points are its own statements and the rest belongs to 40 function items inside it that branch (a function literal at line 216, a function literal at line 79, a function literal at line 78, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · gr-tab-swap.TabControl (cyclomatic 17) · ×1
  • gr-tab-swap.TabControl (cyclomatic 17) kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:16 — gr-tab-swap.TabControl has cyclomatic complexity 17 (threshold 15). Of this number, 11 points are the body's own statements and 6 belong to 4 function items inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Uploader.uploadAndStoreImage (cyclomatic 16) · ×1
  • Uploader.uploadAndStoreImage (cyclomatic 16) image-loader/app/model/Uploader.scala:129 — Uploader.uploadAndStoreImage has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · gr-confirmation-modal.confirmationModal (cyclomatic 16) · ×1
  • gr-confirmation-modal.confirmationModal (cyclomatic 16) kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:16 — gr-confirmation-modal.confirmationModal has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 4 of the 16 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 65, a function literal at line 74, handleDisplay, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D1 · Cyclomatic Complexity · delete-from-content-step.DeleteFromContentStep (cyclomatic 16) · ×1
  • delete-from-content-step.DeleteFromContentStep (cyclomatic 16) REDACTED:58 — delete-from-content-step.DeleteFromContentStep has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 6 of the 16 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 83, 66, 115). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D1 · Cyclomatic Complexity · (anonymous).link (cyclomatic 16) · ×1
  • (anonymous).link (cyclomatic 16) kahuna/public/js/forms/datalist.js:69 — (anonymous).link has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 12 function items inside it that branch (a function literal at line 119, a function literal at line 106, activate, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D17 · Explicit Debt · HackComment · ×1
  • HackComment common-lib/src/main/scala/com/gu/mediaservice/model/Collection.scala:29 — // HACK: path should be an NonEmptyList, till then, this'll do — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D2 · Cognitive Complexity · GoodToGoCheck.run (cognitive 148) · ×1
  • GoodToGoCheck.run (cognitive 148) thrall/app/lib/elasticsearch/GoodToGoCheck.scala:18 — GoodToGoCheck.run has cognitive complexity 148 (threshold 15). Drivers by points: loops 14 (105 pts), if/else 7 (43 pts) (nesting depth added 127). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · (anonymous) (cognitive 79) · ×1
  • (anonymous) (cognitive 79) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:47 — (anonymous) has cognitive complexity 79 (threshold 15). Drivers by points: if/else 27 (31 pts), boolean chains 26, ternaries 11 (12 pts), loops 2 (4 pts), match/switch 4, error handling 2 (nesting depth added 7). Most of this is not in the body itself: 2 of the 79 points are its own statements and the rest belongs to 104 function items inside it that branch ($onInit::onMetadataTemplateSelected, $onInit::textareaKeydownListener, $onInit::updateTextareaCursor, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · Uploader.uploadAndStoreImage (cognitive 76) · ×1
  • Uploader.uploadAndStoreImage (cognitive 76) image-loader/app/model/Uploader.scala:129 — Uploader.uploadAndStoreImage has cognitive complexity 76 (threshold 15). Drivers by points: loops 11 (66 pts), match/switch 2 (10 pts) (nesting depth added 63). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MessageTranslator.translate (cognitive 53) · ×1
  • MessageTranslator.translate (cognitive 53) thrall/app/lib/kinesis/MessageTranslator.scala:9 — MessageTranslator.translate has cognitive complexity 53 (threshold 15). Drivers by points: match/switch 18 (35 pts), if/else 18 (nesting depth added 17). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · (anonymous) (cognitive 52) · ×1
  • (anonymous) (cognitive 52) kahuna/public/js/edits/image-editor.js:49 — (anonymous) has cognitive complexity 52 (threshold 15). Drivers by points: if/else 25 (33 pts), boolean chains 10, ternaries 7 (8 pts), error handling 1 (nesting depth added 9). Most of this is not in the body itself: 1 of the 52 points is its own statement and the rest belongs to 58 function items inside it that branch ($onInit::batchSetLeasesFromUsageRights, $onInit::onMetadataTemplateSelected, $onInit::batchApplyUsageRights, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · delete-from-grid-step.DeleteFromGridStep (cognitive 44) · ×1
  • delete-from-grid-step.DeleteFromGridStep (cognitive 44) kahuna/public/js/takedown/delete-from-grid-step.tsx:88 — delete-from-grid-step.DeleteFromGridStep has cognitive complexity 44 (threshold 15). Drivers by points: if/else 17 (18 pts), boolean chains 14, ternaries 5 (8 pts), error handling 4 (nesting depth added 4). Most of this is not in the body itself: 6 of the 44 points are its own statements and the rest belongs to 11 function items inside it that branch (handleConfirm, deleteUsages, a function literal at line 295, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 43) · ×1
  • (anonymous) (cognitive 43) kahuna/public/js/metadata-templates/metadata-templates.js:26 — (anonymous) has cognitive complexity 43 (threshold 15). Drivers by points: if/else 22 (23 pts), ternaries 6 (11 pts), boolean chains 6, loops 1 (2 pts), error handling 1 (nesting depth added 7). None of this is in the body itself: all 43 points belong to 27 function items inside it that branch ($onInit::applyTemplateToUsageRights, $onInit::verifyTemplateCollection, $onInit::toLease, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 42) · ×1
  • (anonymous) (cognitive 42) kahuna/public/js/usage-rights/usage-rights-editor.js:29 — (anonymous) has cognitive complexity 42 (threshold 15). Drivers by points: if/else 22 (27 pts), boolean chains 10, ternaries 4, error handling 1 (nesting depth added 5). None of this is in the body itself: all 42 points belong to 45 function items inside it that branch (a function literal at line 44, $onInit::setLeasesFromUsageRights, a function literal at line 161, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · ImageDataMerger.aggregate (cognitive 36) · ×1
  • ImageDataMerger.aggregate (cognitive 36) common-lib/src/main/scala/com/gu/mediaservice/ImageDataMerger.scala:11 — ImageDataMerger.aggregate has cognitive complexity 36 (threshold 15). Drivers by points: loops 7 (28 pts), match/switch 1 (8 pts) (nesting depth added 28). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · UsageGroupOps.extractCartoonUniqueMediaIds (cognitive 36) · ×1
  • UsageGroupOps.extractCartoonUniqueMediaIds (cognitive 36) usage/app/model/UsageGroup.scala:229 — UsageGroupOps.extractCartoonUniqueMediaIds has cognitive complexity 36 (threshold 15). Drivers by points: loops 8 (36 pts) (nesting depth added 28). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · gr-permissions-filter.PermissionsFilter (cognitive 36) · ×1
  • gr-permissions-filter.PermissionsFilter (cognitive 36) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:79 — gr-permissions-filter.PermissionsFilter has cognitive complexity 36 (threshold 15). Drivers by points: if/else 17 (23 pts), boolean chains 7, ternaries 3 (4 pts), loops 1 (2 pts) (nesting depth added 8). Most of this is not in the body itself: 3 of the 36 points are its own statements and the rest belongs to 8 function items inside it that branch (handleKeyboard, syncSelectionFromQuery, autoHideListener, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · base-sort-control.BaseSortControl (cognitive 35) · ×1
  • base-sort-control.BaseSortControl (cognitive 35) kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:67 — base-sort-control.BaseSortControl has cognitive complexity 35 (threshold 15). Drivers by points: if/else 15 (20 pts), boolean chains 11, ternaries 4 (nesting depth added 5). Most of this is not in the body itself: 9 of the 35 points are its own statements and the rest belongs to 8 function items inside it that branch (handleArrowKeys, a function literal at line 128, a function literal at line 84, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 34) · ×1
  • (anonymous) (cognitive 34) kahuna/public/js/image/controller.js:91 — (anonymous) has cognitive complexity 34 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 10, ternaries 7 (9 pts), other 1 (nesting depth added 5). Most of this is not in the body itself: 6 of the 34 points are its own statements and the rest belongs to 37 function items inside it that branch (a function literal at line 336, callback, a function literal at line 287, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · Syndication.publishChangedSyndicationRightsForPhotoshoot (cognitive 31) · ×1
  • Syndication.publishChangedSyndicationRightsForPhotoshoot (cognitive 31) metadata-editor/app/lib/Syndication.scala:28 — Syndication.publishChangedSyndicationRightsForPhotoshoot has cognitive complexity 31 (threshold 15). Drivers by points: loops 7 (28 pts), if/else 2 (3 pts) (nesting depth added 22). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MediaApi.imageSearch (cognitive 30) · ×1
  • MediaApi.imageSearch (cognitive 30) media-api/app/controllers/MediaApi.scala:632 — MediaApi.imageSearch has cognitive complexity 30 (threshold 15). Drivers by points: loops 7 (13 pts), if/else 8 (10 pts), match/switch 4 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryBuilder.makeQueryBit (cognitive 30) · ×1
  • QueryBuilder.makeQueryBit (cognitive 30) media-api/app/lib/elasticsearch/QueryBuilder.scala:76 — QueryBuilder.makeQueryBit has cognitive complexity 30 (threshold 15). Drivers by points: match/switch 8 (17 pts), if/else 9 (11 pts), boolean chains 2 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · gr-usagerights-summary.UsageRightsSummary (cognitive 26) · ×1
  • gr-usagerights-summary.UsageRightsSummary (cognitive 26) kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx:27 — gr-usagerights-summary.UsageRightsSummary has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (14 pts), ternaries 4 (8 pts), boolean chains 4 (nesting depth added 7). Most of this is not in the body itself: 2 of the 26 points are its own statements and the rest belongs to 3 function literals inside it that branch (lines 51, 55, 58). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · (anonymous) (cognitive 25) · ×1
  • (anonymous) (cognitive 25) kahuna/public/js/upload/jobs/upload-jobs.js:30 — (anonymous) has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 6, ternaries 1 (nesting depth added 4). None of this is in the body itself: all 25 points belong to 26 function items inside it that branch (a function literal at line 152, a function literal at line 51, a function literal at line 66, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CropperController.executeRequest (cognitive 21) · ×1
  • CropperController.executeRequest (cognitive 21) cropper/app/controllers/CropperController.scala:161 — CropperController.executeRequest has cognitive complexity 21 (threshold 15). Drivers by points: loops 6 (21 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · Crops.makeExport (cognitive 21) · ×1
  • Crops.makeExport (cognitive 21) cropper/app/lib/Crops.scala:109 — Crops.makeExport has cognitive complexity 21 (threshold 15). Drivers by points: loops 6 (21 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MagickImageOperations.identifyColourModel (cognitive 20) · ×1
  • MagickImageOperations.identifyColourModel (cognitive 20) common-lib/src/main/scala/com/gu/mediaservice/lib/imaging/MagickImageOperations.scala:232 — MagickImageOperations.identifyColourModel has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 4 (10 pts), loops 3 (6 pts), if/else 4 (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · (anonymous) (cognitive 20) · ×1
  • (anonymous) (cognitive 20) kahuna/public/js/crop/controller.js:34 — (anonymous) has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 7, error handling 1, ternaries 1 (nesting depth added 1). Most of this is not in the body itself: 7 of the 20 points are its own statements and the rest belongs to 40 function items inside it that branch (a function literal at line 216, a function literal at line 79, a function literal at line 78, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · Controller (cognitive 20) · ×1
  • Controller (cognitive 20) kahuna/public/js/components/gr-downloader/gr-downloader.js:23 — Controller has cognitive complexity 20 (threshold 15). Drivers by points: boolean chains 13, if/else 3, error handling 1 (2 pts), ternaries 2 (nesting depth added 1). None of this is in the body itself: all 20 points belong to 22 function items inside it that branch (a function literal at line 41, $onInit::onSingleDownloadClicked, $onInit, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · QueryBuilder.makeQuery (cognitive 19) · ×1
  • QueryBuilder.makeQuery (cognitive 19) media-api/app/lib/elasticsearch/QueryBuilder.scala:147 — QueryBuilder.makeQuery has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 7 (14 pts), if/else 4, boolean chains 1 (nesting depth added 7). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · syntax.structureQuery (cognitive 19) · ×1
  • syntax.structureQuery (cognitive 19) kahuna/public/js/search/structured-query/syntax.ts:35 — syntax.structureQuery has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 3 (9 pts), boolean chains 5, if/else 3 (4 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · (anonymous) (cognitive 19) · ×1
  • (anonymous) (cognitive 19) kahuna/public/js/components/gr-chips/gr-chips.js:19 — (anonymous) has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15, boolean chains 3, ternaries 1. None of this is in the body itself: all 19 points belong to 21 function items inside it that branch (configureNgModel::isValidKey, removeChipAt, configureNgModel, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · gr-confirmation-modal.confirmationModal (cognitive 18) · ×1
  • gr-confirmation-modal.confirmationModal (cognitive 18) kahuna/public/js/components/gr-confirmation-modal/gr-confirmation-modal.tsx:16 — gr-confirmation-modal.confirmationModal has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 5, ternaries 2 (nesting depth added 2). Most of this is not in the body itself: 3 of the 18 points are its own statements and the rest belongs to 4 function items inside it that branch (a function literal at line 74, a function literal at line 65, handleDisplay, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · (anonymous).link (cognitive 18) · ×1
  • (anonymous).link (cognitive 18) kahuna/public/js/components/gr-chips/gr-chip-input.js:46 — (anonymous).link has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 4, match/switch 1 (nesting depth added 6). None of this is in the body itself: all 18 points belong to 9 function literals inside it that branch (lines 101, 60, 55, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · CropperController.getCrops (cognitive 17) · ×1
  • CropperController.getCrops (cognitive 17) cropper/app/controllers/CropperController.scala:107 — CropperController.getCrops has cognitive complexity 17 (threshold 15). Drivers by points: loops 5 (11 pts), if/else 4 (5 pts), boolean chains 1 (nesting depth added 7). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · (anonymous).link (cognitive 17) · ×1
  • (anonymous).link (cognitive 17) kahuna/public/js/forms/datalist.js:69 — (anonymous).link has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, boolean chains 8. None of this is in the body itself: all 17 points belong to 12 function items inside it that branch (a function literal at line 119, a function literal at line 106, valueSelector, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D2 · Cognitive Complexity · CropStore.listCrops (cognitive 16) · ×1
  • CropStore.listCrops (cognitive 16) cropper/app/lib/CropStore.scala:29 — CropStore.listCrops has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Uploader.getStorableOptimisedImage (cognitive 16) · ×1
  • Uploader.getStorableOptimisedImage (cognitive 16) image-loader/app/model/Uploader.scala:210 — Uploader.getStorableOptimisedImage has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), match/switch 1 (4 pts), if/else 3 (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MediaApi.downloadImageExport (cognitive 16) · ×1
  • MediaApi.downloadImageExport (cognitive 16) media-api/app/controllers/MediaApi.scala:332 — MediaApi.downloadImageExport has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 2 (6 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ThrallMigrationClient.completeMigration (cognitive 16) · ×1
  • ThrallMigrationClient.completeMigration (cognitive 16) thrall/app/lib/elasticsearch/ThrallMigrationClient.scala:93 — ThrallMigrationClient.completeMigration has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), match/switch 2 (5 pts), if/else 2 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CrierEventProcessor.processEvent (cognitive 16) · ×1
  • CrierEventProcessor.processEvent (cognitive 16) usage/app/lib/CrierEventProcessor.scala:122 — CrierEventProcessor.processEvent has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 5 (11 pts), if/else 5 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · takedown-context.TakedownContextProvider (cognitive 16) · ×1
  • takedown-context.TakedownContextProvider (cognitive 16) kahuna/public/js/takedown/takedown-context.tsx:90 — takedown-context.TakedownContextProvider has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (9 pts), ternaries 3 (4 pts), boolean chains 2, error handling 1 (nesting depth added 2). Most of this is not in the body itself: 5 of the 16 points are its own statements and the rest belongs to 5 function items inside it that branch (fetchUsages, getStepStatus, a function literal at line 160, …). The named helpers are already separate functions; the literals' work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal's work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) media-api/app/controllers/MediaApi.scala:265 — media-api/app/controllers/MediaApi.scala:265-280 | media-api/app/controllers/MediaApi.scala:282-297 | media-api/app/controllers/MediaApi.scala:364-391 | media-api/app/controllers/MediaApi.scala:393-429 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (11–13 lines × 2) · ×1
  • Duplicated block (11–13 lines × 2) media-api/app/controllers/MediaApi.scala:366 — media-api/app/controllers/MediaApi.scala:366-378 | media-api/app/controllers/MediaApi.scala:395-405 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/controllers/MediaApi.scala:366` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/Mappings.scala:83 — common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/Mappings.scala:83-93 | common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/Mappings.scala:96-107 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/Mappings.scala:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×1
  • Duplicated block (12 lines × 2) thrall/app/lib/elasticsearch/ElasticSearch.scala:367 — thrall/app/lib/elasticsearch/ElasticSearch.scala:367-378 | thrall/app/lib/elasticsearch/ElasticSearch.scala:402-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `thrall/app/lib/elasticsearch/ElasticSearch.scala:367` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–10 lines × 3) · ×1
  • Duplicated block (8–10 lines × 3) media-api/app/controllers/MediaApi.scala:431 — media-api/app/controllers/MediaApi.scala:431-440 | media-api/app/controllers/MediaApi.scala:464-471 | media-api/app/controllers/MediaApi.scala:564-571 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/controllers/MediaApi.scala:431` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) media-api/app/controllers/MediaApi.scala:265 — media-api/app/controllers/MediaApi.scala:265-273 | media-api/app/controllers/MediaApi.scala:282-290 | media-api/app/controllers/MediaApi.scala:364-372 | media-api/app/controllers/MediaApi.scala:393-401 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `media-api/app/controllers/MediaApi.scala:265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×1
  • Duplicated block (7 lines × 2) media-api/app/lib/elasticsearch/ElasticSearchModel.scala:118 — media-api/app/lib/elasticsearch/ElasticSearchModel.scala:118-124 | media-api/app/lib/elasticsearch/ElasticSearchModel.scala:223-229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
M1 · Documentation (README) · README may be stale · ×1
  • README may be stale — 220 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
P5 · DR & Backup · No DR/backup evidence · ×1
  • No DR/backup evidence — A persistence guard (data volume / purge-protection) was found, but no backup, geo-recovery or RTO/RPO controls were evidenced — a volume that survives a container recreate is not a tested restore from catastrophic loss.
R1 · Type Safety · Type Safety · ×1
  • Type Safety — 101 typed · 149 plain JS — the untyped files are cdk/jest.setup.js, dev/oidc-provider/app.js, dev/oidc-provider/find-account.js, dev/oidc-provider/find-account.test.js, dev/oidc-provider/make-provider.js, dev/script/generate-config/generate-config.js (+143 more).
R10 · Code Duplication · Duplication concentrated across 21 sibling directories (21 clone groups) · ×1
  • Duplication concentrated across 21 sibling directories (21 clone groups) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20 — 21 duplicated blocks under kahuna/public/js/components/ have copies in at least two of the sibling directories gr-add-keyword, gr-add-label, gr-archiver, gr-archiver-status, gr-batch-export-original-images, gr-chips (+15 more sibling(s) not listed) — 12 of them are reported below, and 9 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 21 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 21 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 21 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplication concentrated across 10 sibling directories (15 clone groups) · ×1
  • Duplication concentrated across 10 sibling directories (15 clone groups) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600 — 15 duplicated blocks under kahuna/public/js/ have copies in at least two of the sibling directories components, crop, edits, image, leases, metadata-templates (+4 more sibling(s) not listed) — 9 of them are reported below, and 6 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 15 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 15 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 15 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Duplicated block with local edits (67 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (67 matched lines × 2 locations) kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20 — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:20 · kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:16 — the two spans are one implementation copied and then locally edited — 454 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (50 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (50 matched lines × 2 locations) kahuna/public/js/lib/data-structure/list-factory.js:12 — kahuna/public/js/lib/data-structure/list-factory.js:12 · kahuna/public/js/lib/data-structure/ordered-set-factory.js:12 — the two spans are one implementation copied and then locally edited — 312 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (44 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (44 matched lines × 2 locations) kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:66 — kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:66 · kahuna/public/js/components/gr-add-label/gr-add-label.js:27 — the two spans are one implementation copied and then locally edited — 255 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (31 lines × 2 locations) · ×1
  • Duplicated block (31 lines × 2 locations) kahuna/public/js/takedown/crops-and-usages.tsx:97 — kahuna/public/js/takedown/crops-and-usages.tsx:97 · kahuna/public/js/takedown/crops-and-usages.tsx:143 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block with local edits (29 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (29 matched lines × 2 locations) REDACTED:166 — REDACTED:166 · REDACTED:203 — the two spans are one implementation copied and then locally edited — 107 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (19 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (19 matched lines × 2 locations) REDACTED:69 — REDACTED:69 · kahuna/public/js/takedown/delete-from-grid-step.tsx:281 — the two spans are one implementation copied and then locally edited — 64 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (17 lines × 2 locations) · ×1
  • Duplicated block (17 lines × 2 locations) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600 — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:600 · kahuna/public/js/edits/image-editor.js:243 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block (16 lines × 2 locations) · ×1
  • Duplicated block (16 lines × 2 locations) kahuna/public/js/takedown/crops-and-usages.tsx:173 — kahuna/public/js/takedown/crops-and-usages.tsx:173 · kahuna/public/js/takedown/crops-and-usages.tsx:236 — all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block (15 lines × 2 locations) · ×1
  • Duplicated block (15 lines × 2 locations) kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:23 — kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:23 · kahuna/public/js/edits/image-editor.js:383 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block with local edits (14 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (14 matched lines × 2 locations) kahuna/public/js/services/api/collections-api.js:122 — kahuna/public/js/services/api/collections-api.js:122 · kahuna/public/js/services/archive.js:10 — the two spans are one implementation copied and then locally edited — 56 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (12 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (12 matched lines × 2 locations) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:477 — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:477 · kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:567 — the two spans are one implementation copied and then locally edited — 101 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (11 lines × 2 locations) · ×1
  • Duplicated block (11 lines × 2 locations) kahuna/public/js/components/gr-archiver-status/gr-archiver-status.js:27 — kahuna/public/js/components/gr-archiver-status/gr-archiver-status.js:27 · kahuna/public/js/components/gr-archiver/gr-archiver.js:47 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block with local edits (10 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (10 matched lines × 2 locations) kahuna/public/js/upload/dnd-uploader.js:12 — kahuna/public/js/upload/dnd-uploader.js:12 · kahuna/public/js/upload/file-uploader.js:11 — the two spans are one implementation copied and then locally edited — 58 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (9 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (9 matched lines × 2 locations) kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:47 — kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:47 · kahuna/public/js/edits/image-editor.js:114 — the two spans are one implementation copied and then locally edited — 52 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (9 lines × 3 locations) · ×1
  • Duplicated block (9 lines × 3 locations) kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:24 — kahuna/public/js/components/gr-collection-overlay/gr-collection-overlay.js:24 · kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:74 · kahuna/public/js/edits/image-editor.js:384 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R10 · Code Duplication · Duplicated block with local edits (8 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (8 matched lines × 2 locations) kahuna/public/js/services/api/leases.js:56 — kahuna/public/js/services/api/leases.js:56 · kahuna/public/js/services/api/leases.js:84 — the two spans are one implementation copied and then locally edited — 53 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 28, cognitive 35) · ×1
  • Complex function (anonymous) (cyclomatic 28, cognitive 35) e2e-tests/feature-library/serve.ts:27 — (anonymous) has cyclomatic complexity 28 and cognitive complexity 35; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function watchSearchChange (cyclomatic 21, cognitive 29) · ×1
  • Complex function watchSearchChange (cyclomatic 21, cognitive 29) kahuna/public/js/search/query.js:315 — watchSearchChange has cyclomatic complexity 21 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function createLibrary (cyclomatic 15, cognitive 41) · ×1
  • Complex function createLibrary (cyclomatic 15, cognitive 41) e2e-tests/feature-library/library.ts:279 — createLibrary has cyclomatic complexity 15 and cognitive complexity 41; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function structureQuery (cyclomatic 15, cognitive 19) · ×1
  • Complex function structureQuery (cyclomatic 15, cognitive 19) kahuna/public/js/search/structured-query/syntax.ts:35 — structureQuery has cyclomatic complexity 15 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 15, cognitive 12) · ×1
  • Complex function (anonymous) (cyclomatic 15, cognitive 12) kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-bbc.tsx:56 — (anonymous) has cyclomatic complexity 15 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 14, cognitive 12) · ×1
  • Complex function (anonymous) (cyclomatic 14, cognitive 12) kahuna/public/js/search/results.js:104 — (anonymous) has cyclomatic complexity 14 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function manageUploadedBy (cyclomatic 13, cognitive 23) · ×1
  • Complex function manageUploadedBy (cyclomatic 13, cognitive 23) kahuna/public/js/search/query.js:162 — manageUploadedBy has cyclomatic complexity 13 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function ScenarioDetail (cyclomatic 13, cognitive 12) · ×1
  • Complex function ScenarioDetail (cyclomatic 13, cognitive 12) e2e-tests/feature-library/app.tsx:294 — ScenarioDetail has cyclomatic complexity 13 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function handleKey (cyclomatic 12, cognitive 13) · ×1
  • Complex function handleKey (cyclomatic 12, cognitive 13) kahuna/public/js/components/gr-chips/gr-text-chip.js:41 — handleKey has cyclomatic complexity 12 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function save (cyclomatic 11, cognitive 23) · ×1
  • Complex function save (cyclomatic 11, cognitive 23) kahuna/public/js/leases/leases.js:59 — save has cyclomatic complexity 11 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 11, cognitive 18) · ×1
  • Complex function (anonymous) (cyclomatic 11, cognitive 18) kahuna/public/js/search/query.js:694 — (anonymous) has cyclomatic complexity 11 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function (anonymous) (cyclomatic 11, cognitive 15) · ×1
  • Complex function (anonymous) (cyclomatic 11, cognitive 15) e2e-tests/feature-library/app.test.ts:53 — (anonymous) has cyclomatic complexity 11 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function onMetadataTemplateSelected (cyclomatic 11, cognitive 13) · ×1
  • Complex function onMetadataTemplateSelected (cyclomatic 11, cognitive 13) kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:588 — onMetadataTemplateSelected has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function handleArrowKeys (cyclomatic 11, cognitive 13) · ×1
  • Complex function handleArrowKeys (cyclomatic 11, cognitive 13) kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:96 — handleArrowKeys has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function TabControl (cyclomatic 11, cognitive 9) · ×1
  • Complex function TabControl (cyclomatic 11, cognitive 9) kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx:16 — TabControl has cyclomatic complexity 11 and cognitive complexity 9; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R3 · Large Files · kahuna/public/js/search/results.js · ×1
  • kahuna/public/js/search/results.js: 841 lines of code kahuna/public/js/search/results.js:1 — kahuna/public/js/search/results.js has 841 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · e2e-tests/setup/stack.ts · ×1
  • e2e-tests/setup/stack.ts: 766 lines of code e2e-tests/setup/stack.ts:1 — e2e-tests/setup/stack.ts has 766 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · kahuna/public/js/search/query.js · ×1
  • kahuna/public/js/search/query.js: 674 lines of code kahuna/public/js/search/query.js:1 — kahuna/public/js/search/query.js has 674 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js · ×1
  • kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js: 594 lines of code kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:1 — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js has 594 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · image-embedder-lambda/src/backfiller/freeImagesFilter.ts · ×1
  • image-embedder-lambda/src/backfiller/freeImagesFilter.ts: 558 lines of code image-embedder-lambda/src/backfiller/freeImagesFilter.ts:1 — image-embedder-lambda/src/backfiller/freeImagesFilter.ts has 558 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R3 · Large Files · e2e-tests/feature-library/app.tsx · ×1
  • e2e-tests/feature-library/app.tsx: 499 lines of code e2e-tests/feature-library/app.tsx:1 — e2e-tests/feature-library/app.tsx has 499 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R8 · Dependency Hygiene · Unused dependency 'angular-animate' · ×1
  • Unused dependency 'angular-animate' — Declared in REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'imagemin-svgo' · ×1
  • Unused dependency 'imagemin-svgo' — Declared in REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
R8 · Dependency Hygiene · Unused dependency 'panda-session' · ×1
  • Unused dependency 'panda-session' — Declared in REDACTED but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Minor — 126 finding(s)
D34 · Knowledge Freshness · Orphaned file · ×55
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ConfigNodeObject.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ConfigBeanImpl.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ResolveSource.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ConfigConcatenation.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ResolveContext.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/scala/com/gu/mediaservice/scripts/ProposeS3Changes.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file usage/app/model/UsageGroup.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file common-lib/src/main/scala/com/gu/mediaservice/lib/config/ProviderLoader.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file cropper/app/controllers/CropperController.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file collections/app/controllers/CollectionsController.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file rest-lib/src/main/scala/com/gu/mediaservice/lib/auth/Authentication.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/ConfigReference.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file thrall/app/lib/elasticsearch/GoodToGoCheck.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/scala/com/gu/mediaservice/scripts/BackfillEditLastModified.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file rest-lib/src/main/scala/com/gu/mediaservice/lib/auth/provider/AuthenticationProvider.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/scala/com/gu/mediaservice/scripts/EsImageMetadata.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file thrall/app/lib/MigrationSourceWithSender.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file kahuna/public/js/components/gr-feature-switch-panel/gr-feature-switch-panel.tsx:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file kahuna/app/lib/MetadataTemplateConfig.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file common-lib/src/main/scala/com/gu/mediaservice/model/ImageMetadata.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file common-lib/src/main/scala/com/gu/mediaservice/model/FileMetadataAggregator.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file media-api/app/lib/ImagePersistenceReasons.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file media-api/app/lib/elasticsearch/SearchFilters.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file media-api/app/lib/ImageExtras.scala:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file scripts/src/main/java/com/gu/typesafe/config/impl/BadMap.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 30 more in this group — see findings.md.
P2 · Observability · Console output used as the logging channel · ×19
  • Console output used as the logging channel kahuna/public/js/quotas.js:43 — `kahuna/public/js/quotas.js` reports through `console.*` at line 43 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/util/batch-tracking.js:54 — `kahuna/public/js/util/batch-tracking.js` reports through `console.*` at line 54 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/upload/manager.js:144 — `kahuna/public/js/upload/manager.js` reports through `console.*` at line 144 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/search/results.js:700 — `kahuna/public/js/search/results.js` reports through `console.*` at line 700 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/metadata-templates/metadata-templates.js:189 — `kahuna/public/js/metadata-templates/metadata-templates.js` reports through `console.*` at line 189 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/leases/leases.js:106 — `kahuna/public/js/leases/leases.js` reports through `console.*` at line 106 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/image/controller.js:300 — `kahuna/public/js/image/controller.js` reports through `console.*` at line 300 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/edits/list-editor.js:63 — `kahuna/public/js/edits/list-editor.js` reports through `console.*` at line 63 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/crop/controller.js:62 — `kahuna/public/js/crop/controller.js` reports through `console.*` at line 62 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:29 — `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 29 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:30 — `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 30 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts:31 — `kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter-config.ts` reports through `console.*` at line 31 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx:150 — `kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx` reports through `console.*` at line 150 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:163 — `kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js` reports through `console.*` at line 163 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:106 — `kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js` reports through `console.*` at line 106 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js:107 — `kahuna/public/js/components/gr-collections-panel/gr-collections-panel.js` reports through `console.*` at line 107 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-archiver/gr-archiver.js:144 — `kahuna/public/js/components/gr-archiver/gr-archiver.js` reports through `console.*` at line 144 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-add-label/gr-add-label.js:50 — `kahuna/public/js/components/gr-add-label/gr-add-label.js` reports through `console.*` at line 50 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
  • Console output used as the logging channel kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js:87 — `kahuna/public/js/components/gr-add-keyword/gr-add-keyword.js` reports through `console.*` at line 87 although other files in its module log through a logger. Console lines carry no level, fields or correlation and never reach the log pipeline.
X10 · Duplicated predicate · Duplicated predicate · ×14
  • Duplicated predicate kahuna/public/js/components/gr-chips/gr-chip-input.js:24 — `caretStart === 0 || input[caretStart - 1] === ' '` appears character-identically in 2 files — kahuna/public/js/components/gr-chips/gr-chip-input.js, kahuna/public/js/components/gr-chips/gr-text-chip.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/image/controller.js:162 — `ctrl.image && ctrl.image.data.softDeletedMetadata !== undefined` appears character-identically in 2 files — kahuna/public/js/image/controller.js, kahuna/public/js/search/results.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:247 — `currentIndex > -1 && options[currentIndex].value` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gu-lazy-table/gu-lazy-table.js:315 — `document.body.scrollTop || document.documentElement.scrollTop` appears character-identically in 2 files — kahuna/public/js/components/gu-lazy-table/gu-lazy-table.js, kahuna/public/js/services/scroll-position.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:211 — `event.key === 'ArrowDown' || event.key === 'ArrowUp' || event.key === 'Enter' || event.code === 'Space'` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:222 — `event.key === 'Enter' || event.code === 'Space'` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:98 — `event.type === "keydown" && event.key === "Escape"` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-metadata-validity/gr-metadata-validity.js:27 — `lease.active && lease.access === 'allow-use'` appears character-identically in 2 files — kahuna/public/js/components/gr-metadata-validity/gr-metadata-validity.js, kahuna/public/js/preview/image.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:52 — `node !== null && node.classList && node.classList.contains(className)` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:56 — `node && node.parentNode && node.parentNode !== document` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx:58 — `node.classList && node.classList.contains(className)` appears character-identically in 2 files — kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, kahuna/public/js/components/gr-sort-control/base-sort-control.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-sort-control/base-sort-control.tsx:147 — `panel === PANEL_IDENTIFIER || panel === SCROLL_IDENTIFIER` appears character-identically in 2 files — kahuna/public/js/components/gr-sort-control/base-sort-control.tsx, kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate image-embedder-lambda/src/backfiller/localRun.ts:8 — `process.env.QUEUE_URL || 'http://localhost:4566/000000000000/image-embedder-DEV'` appears character-identically in 2 files — image-embedder-lambda/src/backfiller/localRun.ts, image-embedder-lambda/src/embedder/localRun.ts. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js:64 — `window._clientConfig.metadataTemplates !== undefined && window._clientConfig.metadataTemplates.length > 0` appears character-identically in 2 files — kahuna/public/js/components/gr-image-metadata/gr-image-metadata.js, kahuna/public/js/edits/image-editor.js. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D16 · Bus Factor · Off-boarding risk · ×5
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 11 significant file(s) lose their only recent owner: common-lib/src/main/scala/com/gu/mediaservice/lib/aws/DynamoDB.scala, usage/app/model/UsageTable.scala, usage/app/model/UsageRecord.scala, common-lib/src/main/scala/com/gu/mediaservice/lib/ImageIngestOperations.scala, common-lib/src/main/scala/com/gu/mediaservice/lib/usage/ItemToMediaUsage.scala, media-api/app/lib/ContentApi.scala, cropper/app/lib/CropStore.scala, usage/app/lib/UsageConfig.scala (+3 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 9 significant file(s) lose their only recent owner: kahuna/public/js/takedown/crops-and-usages.tsx, REDACTED, kahuna/public/js/takedown/takedown-context.tsx, kahuna/public/js/components/gr-usagerights-summary/gr-usagerights-summary.tsx, kahuna/public/js/takedown/index.ts, image-loader/app/lib/imaging/C2PADetector.scala, kahuna/public/js/util/constants/standThemeOverride.ts, kahuna/public/js/takedown/takedown-page.tsx (+1 more). Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 6 significant file(s) lose their only recent owner: kahuna/public/js/components/gr-notifications-banner/gr-notifications-banner.tsx, kahuna/public/js/components/gr-permissions-filter/gr-permissions-filter.tsx, common-lib/src/main/scala/com/gu/mediaservice/lib/metadata/ImageMetadataConverter.scala, kahuna/public/js/components/gr-sort-control/gr-extended-sort-control.tsx, kahuna/public/js/components/gr-tab-swap/gr-tab-swap.tsx, kahuna/public/js/components/gr-my-uploads/gr-my-uploads.tsx. Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #4 — If anonymized user #4 becomes unavailable, 5 significant file(s) lose their only recent owner: e2e-tests/setup/provision.ts, e2e-tests/setup/seed-elasticsearch.ts, REDACTED, REDACTED, e2e-tests/setup/dev.ts. Pair on, review, or document these before any departure.
  • Off-boarding risk: anonymized user #5 — If anonymized user #5 becomes unavailable, 3 significant file(s) lose their only recent owner: usage/app/lib/CrierEventProcessor.scala, usage/app/lib/CrierStreamReader.scala, common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/filters.scala. Pair on, review, or document these before any departure.
X4 · Structured logging · Interpolated log message defeats structured logging · ×5
  • Interpolated log message defeats structured logging common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:21 — `info` at line 21 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:27 — `info` at line 27 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:32 — `info` at line 32 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:40 — `info` at line 40 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging common-lib/src/main/scala/com/gu/mediaservice/lib/S3ImageStorage.scala:50 — `info` at line 50 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
D30 · Dependency Vulnerabilities · Low CVE · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AX6 · Interface segregation · Fat interface · ×1
  • Fat interface: Config (55 abstract methods) scripts/src/main/java/com/gu/typesafe/config/Config.java:168 — `Config` declares 55 abstract methods: `atKey`, `atPath`, `checkValid`, `entrySet`, `getAnyRef`, `getAnyRefList`, `getBoolean`, `getBooleanList`, `getBytes`, `getBytesList`, `getConfig`, `getConfigList`, `getDouble`, `getDoubleList`, `getDuration`, `getDuration`, `getDurationList`, `getDurationList`, `getEnum`, `getEnumList`, `getInt`, `getIntList`, `getIsNull`, `getList`, `getLong`, `getLongList`, `getMemorySize`, `getMemorySizeList`, `getMilliseconds`, `getMillisecondsList`, `getNanoseconds`, `getNanosecondsList`, `getNumber`, `getNumberList`, `getObject`, `getObjectList`, `getPeriod`, `getString`, `getStringList`, `getTemporal`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 51 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 51 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
D16 · Bus Factor · Further sole-owners (lower concentration) · ×1
  • Further sole-owners (lower concentration) — 5 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (42 single-owned of 190 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 190 of the 493 production source files in this repository met that bar). They are anonymized user #6 (2 file(s)), anonymized user #7 (2 file(s)), anonymized user #8 (1 file(s)), anonymized user #9 (1 file(s)), anonymized user #10 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: media-api/app/lib/elasticsearch/HybridResult.scala, common-lib/src/main/scala/com/gu/mediaservice/lib/VectorUtils.scala, image-embedder-lambda/src/backfiller/backfiller.ts, image-embedder-lambda/src/embedder/resizeImage.ts, common-lib/src/main/scala/com/gu/mediaservice/lib/cleanup/PhotographerRenamer.scala, common-lib/src/main/scala/com/gu/mediaservice/model/ThrallMessage.scala, common-lib/src/main/scala/com/gu/mediaservice/lib/elasticsearch/ElasticSearchExecutions.scala.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 2 of 9 project(s) overshoot their size bounds, lowering Project Cohesion to 5.6/10. The most over is `(repository root)` (24747 LoC, 1060 module-visible types across 82 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D30 · Dependency Vulnerabilities · Low vulnerability · ×1
  • REDACTED
D31 · IaC & Container Security · Low IaC · ×1
  • REDACTED
D34 · Knowledge Freshness · Orphaned files with no living knowledge · ×1
  • Orphaned files with no living knowledge — 55 of 205 analysed file(s) have no living knowledge left — their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 205 of the 493 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each — most significant first: scripts/src/main/scala/com/gu/mediaservice/scripts/ProposeS3Changes.scala, usage/app/model/UsageGroup.scala, scripts/src/main/java/com/gu/typesafe/config/impl/ConfigNodeObject.java, scripts/src/main/java/com/gu/typesafe/config/impl/ConfigBeanImpl.java, scripts/src/main/java/com/gu/typesafe/config/impl/ResolveSource.java, scripts/src/main/java/com/gu/typesafe/config/impl/ConfigConcatenation.java, rest-lib/src/main/scala/com/gu/mediaservice/lib/auth/Authentication.scala, scripts/src/main/java/com/gu/typesafe/config/impl/ResolveContext.java (and 47 more). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M1 · Documentation (README) · Thin README · ×1
  • Thin README — The root README is 106 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 2/3 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `e2e-tests`.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 18513 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P4 · Deployment & Rollback · No rollback/health safety · ×1
  • No rollback/health safety — Deployment is orchestrated by compose, but no service declares a `healthcheck:` and nothing pins a previous image to fall back to — the runtime can tell that the container is up, not that it is serving, so a bad release is harder to detect and reverse.
P6 · Release Hygiene · No changelog · ×1
  • No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
S1 · Web-Security Posture · No security response headers detected · ×1
  • No security response headers detected REDACTED:29 — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. This is reported because `REDACTED` is committed to this repository and declares the server that serves it, so the configuration that would carry these headers is in this repository and was read in full. (−2.0 on this card.)
X2 · Cancellation propagation · Not all async functions that make a request accept an AbortSignal · ×1
  • Not all async functions that make a request accept an AbortSignal — Only 0/4 async functions that make a cancellable request (fetch, axios, ky, ofetch) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up — a page navigated away from, an unmounted component, a timed-out job. Take a `signal` (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice — judge against how the function is used.
X5 · Nullable reference types · Scala's null is not held to the type system everywhere · ×1
  • Scala's null is not held to the type system everywhere — No build over this repository's 371 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.
X7 · Silent fallback defaults · Silent fallback default in catch · ×1
  • Silent fallback default in catch common-lib/src/main/scala/com/gu/mediaservice/lib/aws/SqsHelpers.scala:13 — `getApproximateReceiveCount` swallows every exception into `-1` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
Minor — 43 finding(s)
D12 · Dependency Hygiene · Outdated · ×43
  • Outdated: at.yawk.lz4:lz4-java — `at.yawk.lz4 %% lz4-java` is declared at 1.11.4 in REDACTED, but 1.12.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.11.4 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.amazonaws:aws-lambda-java-core — `com.amazonaws %% aws-lambda-java-core` is declared at 1.4.0 in REDACTED, but 1.4.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.4.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.beust:jcommander — `com.beust %% jcommander` is declared at 1.75 in REDACTED, but 1.82 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.75 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.drewnoakes:metadata-extractor — `com.drewnoakes %% metadata-extractor` is declared at 2.19.0 in REDACTED, but 2.22.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.19.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.fasterxml.jackson.core:jackson-annotations — `com.fasterxml.jackson.core %% jackson-annotations` is declared at 2.21 in REDACTED, but 2.22 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.21 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.fasterxml.jackson.core:jackson-databind — `com.fasterxml.jackson.core %% jackson-databind` is declared at 2.21.7 in REDACTED, but 2.22.4 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.21.7 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core_2.13 — `com.github.plokhotnyuk.jsoniter-scala %% jsoniter-scala-core_2.13` is declared at 2.6.4 in REDACTED, but 2.42.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.6.4 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.google.protobuf:protobuf-java — `com.google.protobuf %% protobuf-java` is declared at 3.19.6 in REDACTED, but 4.36.2 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.19.6 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.gu:content-api-client-default_2.13 — `com.gu %% content-api-client-default_2.13` is declared at 32.0.0 in REDACTED, but 50.1.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 32.0.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.gu:editorial-permissions-client_2.13 — `com.gu %% editorial-permissions-client_2.13` is declared at 7.0.0 in REDACTED, but 8.0.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 7.0.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.gu:kcl-pekko-stream_2.13 — `com.gu %% kcl-pekko-stream_2.13` is declared at 0.1.2 in REDACTED, but 0.1.3 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.1.2 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.gu:pan-domain-auth-play_3-0_2.13 — `com.gu %% pan-domain-auth-play_3-0_2.13` is declared at 22.0.0 in REDACTED, but 22.2.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 22.0.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: com.typesafe.scala-logging:scala-logging_2.13 — `com.typesafe.scala-logging %% scala-logging_2.13` is declared at 3.9.2 in REDACTED, but 3.9.6 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.9.2 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: net.logstash.logback:logstash-logback-encoder — `net.logstash.logback %% logstash-logback-encoder` is declared at 5.0 in REDACTED, but 9.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 5.0 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: nl.gn0s1s:elastic4s-client-esjava_2.13 — `nl.gn0s1s %% elastic4s-client-esjava_2.13` is declared at 8.19.1 in REDACTED, but 9.5.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 8.19.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: nl.gn0s1s:elastic4s-core_2.13 — `nl.gn0s1s %% elastic4s-core_2.13` is declared at 8.19.1 in REDACTED, but 9.5.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 8.19.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: nl.gn0s1s:elastic4s-domain_2.13 — `nl.gn0s1s %% elastic4s-domain_2.13` is declared at 8.19.1 in REDACTED, but 9.5.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 8.19.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.apache.commons:commons-compress — `org.apache.commons %% commons-compress` is declared at 1.27.1 in REDACTED, but 1.28.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.27.1 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.apache.commons:commons-email — `org.apache.commons %% commons-email` is declared at 1.5 in REDACTED, but 1.6.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.5 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.apache.pekko:pekko-stream_2.13 — `org.apache.pekko %% pekko-stream_2.13` is declared at 1.0.3 in REDACTED, but 1.7.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 1.0.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.apache.tika:tika-core — `org.apache.tika %% tika-core` is declared at 3.2.3 in REDACTED, but 4.1.0 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.2.3 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.codehaus.groovy:groovy-json — `org.codehaus.groovy %% groovy-json` is declared at 3.0.7 in REDACTED, but 3.0.25 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.0.7 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.codehaus.janino:janino — `org.codehaus.janino %% janino` is declared at 3.0.6 in REDACTED, but 3.1.12 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 3.0.6 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.http4s:http4s-core_2.13 — `org.http4s %% http4s-core_2.13` is declared at 0.23.17 in REDACTED, but 1.0-4-a7fc4a9 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 0.23.17 until the declaration is edited — there is no lockfile refresh that would move it.
  • Outdated: org.parboiled:parboiled_2.13 — `org.parboiled %% parboiled_2.13` is declared at 2.1.7 in REDACTED, but 2.5.1 is the current release on Maven Central. An sbt declaration names an exact version, so this repository builds against 2.1.7 until the declaration is edited — there is no lockfile refresh that would move it.
  • + 18 more in this group — see findings.md.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-caf8eba31d1845318a059e9d2337ebbf/history.json --exit-code 0 --source .2artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-caf8eba31d1845318a059e9d2337ebbf/tree.json --exit-code 0 --source .1artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .53artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update36artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .124artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 1 file(s) — `dev/oidc-provider/app.js` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update0artifacts/raw/trivy-fs.json

Run 01a17763-2b0b-79f0-87af-77f20ec02e3e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 99 · Warnings: 624 · Recommendations: 126 · Info: 43 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 26-10-2026 @ 08:45 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md